{"action":"created","issue":{"url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/6","repository_url":"https://api.github.com/repos/tesserae/tesserae-v5","labels_url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/6/comments","events_url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/6/events","html_url":"https://github.com/tesserae/tesserae-v5/issues/6","id":361014352,"node_id":"MDU6SXNzdWUzNjEwMTQzNTI=","number":6,"title":"For texts:  Is `unit_types` field necessary? / Will there be a `genre` field?","user":{"login":"nOkuda","id":1238620,"node_id":"MDQ6VXNlcjEyMzg2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1238620?v=4","gravatar_id":"","url":"https://api.github.com/users/nOkuda","html_url":"https://github.com/nOkuda","followers_url":"https://api.github.com/users/nOkuda/followers","following_url":"https://api.github.com/users/nOkuda/following{/other_user}","gists_url":"https://api.github.com/users/nOkuda/gists{/gist_id}","starred_url":"https://api.github.com/users/nOkuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nOkuda/subscriptions","organizations_url":"https://api.github.com/users/nOkuda/orgs","repos_url":"https://api.github.com/users/nOkuda/repos","events_url":"https://api.github.com/users/nOkuda/events{/privacy}","received_events_url":"https://api.github.com/users/nOkuda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-17T19:42:52Z","updated_at":"2018-09-19T19:00:08Z","closed_at":null,"author_association":"NONE","body":"I requested the `genre` field in our previous call.  Assuming that `genre` gets added to Text, will it make sense to keep `unit_types` in the database record?  I think not, since the units are determined by the genre.\r\n\r\nOn the other hand, does it make sense to unitize by genre?  Looking into the future, we might want to unitize by n-token windows, which is as arbitrary as unitizing by lines or phrases.  Perhaps it should be up to the user to make an appropriate unitization decision (i.e., we don't enforce any unitization constraints by genre).  In this case, `genre` would be unnecessary.\r\n\r\nIn counter to the previous argument, it may make sense to have a default unitization based on the genre of the text.  So poetry by default gets unitized by line and prose by default gets unitized by phrase.  In this case, `genre` would still be necessary, but `unit_types` would be unnecessary.\r\n\r\nWhich direction do you think we should go?"},"comment":{"url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/comments/422920576","html_url":"https://github.com/tesserae/tesserae-v5/issues/6#issuecomment-422920576","issue_url":"https://api.github.com/repos/tesserae/tesserae-v5/issues/6","id":422920576,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjkyMDU3Ng==","user":{"login":"jeffkinnison","id":3553147,"node_id":"MDQ6VXNlcjM1NTMxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3553147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffkinnison","html_url":"https://github.com/jeffkinnison","followers_url":"https://api.github.com/users/jeffkinnison/followers","following_url":"https://api.github.com/users/jeffkinnison/following{/other_user}","gists_url":"https://api.github.com/users/jeffkinnison/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkinnison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkinnison/subscriptions","organizations_url":"https://api.github.com/users/jeffkinnison/orgs","repos_url":"https://api.github.com/users/jeffkinnison/repos","events_url":"https://api.github.com/users/jeffkinnison/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkinnison/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T19:00:08Z","updated_at":"2018-09-19T19:00:08Z","author_association":"COLLABORATOR","body":"I think we can replace `unit_types` with `genre`, and am doing so. At least as we're currently operating, lines and phrases are delimited in the same way across genre, so it makes more sense to have one unitizer and a default option for each genre like you suggest."}}
{"actor":{"display_login":"jeffkinnison"}}