{"action":"created","comment":{"url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/comments/194129071","pull_request_review_id":127250473,"id":194129071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDEyOTA3MQ==","diff_hunk":"@@ -74,6 +75,7 @@ export default class Shape extends BaseClass {\n     this._name = \"Shape\";\n     this._opacity = constant(1);\n     this._pointerEvents = constant(\"visiblePainted\");\n+    this._role = \"presentation\";","path":"src/Shape/Shape.js","position":12,"original_position":12,"commit_id":"04bd375d92cd8714edb2236c229993e52e5d8cd9","original_commit_id":"04bd375d92cd8714edb2236c229993e52e5d8cd9","user":{"login":"davelandry","id":1847581,"node_id":"MDQ6VXNlcjE4NDc1ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1847581?v=4","gravatar_id":"","url":"https://api.github.com/users/davelandry","html_url":"https://github.com/davelandry","followers_url":"https://api.github.com/users/davelandry/followers","following_url":"https://api.github.com/users/davelandry/following{/other_user}","gists_url":"https://api.github.com/users/davelandry/gists{/gist_id}","starred_url":"https://api.github.com/users/davelandry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelandry/subscriptions","organizations_url":"https://api.github.com/users/davelandry/orgs","repos_url":"https://api.github.com/users/davelandry/repos","events_url":"https://api.github.com/users/davelandry/events{/privacy}","received_events_url":"https://api.github.com/users/davelandry/received_events","type":"User","site_admin":false},"body":"make the default value use the constant function: `this._role = constant(\"presentation\");`","created_at":"2018-06-08T17:32:16Z","updated_at":"2018-06-08T17:34:02Z","html_url":"https://github.com/d3plus/d3plus-shape/pull/81#discussion_r194129071","pull_request_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/comments/194129071"},"html":{"href":"https://github.com/d3plus/d3plus-shape/pull/81#discussion_r194129071"},"pull_request":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81","id":193669682,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjY5Njgy","html_url":"https://github.com/d3plus/d3plus-shape/pull/81","diff_url":"https://github.com/d3plus/d3plus-shape/pull/81.diff","patch_url":"https://github.com/d3plus/d3plus-shape/pull/81.patch","issue_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/81","number":81,"state":"open","locked":false,"title":"Added support for aria-label #78 and role #79 attributes.","user":{"login":"rbaheti","id":9449212,"node_id":"MDQ6VXNlcjk0NDkyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/9449212?v=4","gravatar_id":"","url":"https://api.github.com/users/rbaheti","html_url":"https://github.com/rbaheti","followers_url":"https://api.github.com/users/rbaheti/followers","following_url":"https://api.github.com/users/rbaheti/following{/other_user}","gists_url":"https://api.github.com/users/rbaheti/gists{/gist_id}","starred_url":"https://api.github.com/users/rbaheti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbaheti/subscriptions","organizations_url":"https://api.github.com/users/rbaheti/orgs","repos_url":"https://api.github.com/users/rbaheti/repos","events_url":"https://api.github.com/users/rbaheti/events{/privacy}","received_events_url":"https://api.github.com/users/rbaheti/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the title above -->\r\n\r\n### Description\r\n<!--- Describe your changes in detail -->\r\naria-label #78:\r\n- assigned default value in the constructor\r\n- assigned aria-label attribute to this._enter variable\r\n- created a user-accessible method, ariaLabel, to change the value\r\n\r\nrole #79 :\r\n- assigned default value in the constructor\r\n- assigned aria-label attribute to this._enter variable\r\n- created a user-accessible method, role, to change the value\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have documented all new methods.\r\n- [ ] I have written tests for all new methods/functionality.\r\n- [x] I have written examples for all new methods/functionality.\r\n\r\n","created_at":"2018-06-08T16:52:16Z","updated_at":"2018-06-08T17:34:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ef788c2ba8b61c49764b29dbd1afbe62cc133f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81/commits","review_comments_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81/comments","review_comment_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/81/comments","statuses_url":"https://api.github.com/repos/d3plus/d3plus-shape/statuses/04bd375d92cd8714edb2236c229993e52e5d8cd9","head":{"label":"d3plus:aria-lable#78-role#79","ref":"aria-lable#78-role#79","sha":"04bd375d92cd8714edb2236c229993e52e5d8cd9","user":{"login":"d3plus","id":13490477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDkwNDc3","avatar_url":"https://avatars0.githubusercontent.com/u/13490477?v=4","gravatar_id":"","url":"https://api.github.com/users/d3plus","html_url":"https://github.com/d3plus","followers_url":"https://api.github.com/users/d3plus/followers","following_url":"https://api.github.com/users/d3plus/following{/other_user}","gists_url":"https://api.github.com/users/d3plus/gists{/gist_id}","starred_url":"https://api.github.com/users/d3plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3plus/subscriptions","organizations_url":"https://api.github.com/users/d3plus/orgs","repos_url":"https://api.github.com/users/d3plus/repos","events_url":"https://api.github.com/users/d3plus/events{/privacy}","received_events_url":"https://api.github.com/users/d3plus/received_events","type":"Organization","site_admin":false},"repo":{"id":39750654,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc1MDY1NA==","name":"d3plus-shape","full_name":"d3plus/d3plus-shape","owner":{"login":"d3plus","id":13490477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDkwNDc3","avatar_url":"https://avatars0.githubusercontent.com/u/13490477?v=4","gravatar_id":"","url":"https://api.github.com/users/d3plus","html_url":"https://github.com/d3plus","followers_url":"https://api.github.com/users/d3plus/followers","following_url":"https://api.github.com/users/d3plus/following{/other_user}","gists_url":"https://api.github.com/users/d3plus/gists{/gist_id}","starred_url":"https://api.github.com/users/d3plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3plus/subscriptions","organizations_url":"https://api.github.com/users/d3plus/orgs","repos_url":"https://api.github.com/users/d3plus/repos","events_url":"https://api.github.com/users/d3plus/events{/privacy}","received_events_url":"https://api.github.com/users/d3plus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d3plus/d3plus-shape","description":"Fancy SVG shapes for visualizations","fork":false,"url":"https://api.github.com/repos/d3plus/d3plus-shape","forks_url":"https://api.github.com/repos/d3plus/d3plus-shape/forks","keys_url":"https://api.github.com/repos/d3plus/d3plus-shape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3plus/d3plus-shape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3plus/d3plus-shape/teams","hooks_url":"https://api.github.com/repos/d3plus/d3plus-shape/hooks","issue_events_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/events{/number}","events_url":"https://api.github.com/repos/d3plus/d3plus-shape/events","assignees_url":"https://api.github.com/repos/d3plus/d3plus-shape/assignees{/user}","branches_url":"https://api.github.com/repos/d3plus/d3plus-shape/branches{/branch}","tags_url":"https://api.github.com/repos/d3plus/d3plus-shape/tags","blobs_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3plus/d3plus-shape/statuses/{sha}","languages_url":"https://api.github.com/repos/d3plus/d3plus-shape/languages","stargazers_url":"https://api.github.com/repos/d3plus/d3plus-shape/stargazers","contributors_url":"https://api.github.com/repos/d3plus/d3plus-shape/contributors","subscribers_url":"https://api.github.com/repos/d3plus/d3plus-shape/subscribers","subscription_url":"https://api.github.com/repos/d3plus/d3plus-shape/subscription","commits_url":"https://api.github.com/repos/d3plus/d3plus-shape/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3plus/d3plus-shape/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3plus/d3plus-shape/contents/{+path}","compare_url":"https://api.github.com/repos/d3plus/d3plus-shape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3plus/d3plus-shape/merges","archive_url":"https://api.github.com/repos/d3plus/d3plus-shape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3plus/d3plus-shape/downloads","issues_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues{/number}","pulls_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls{/number}","milestones_url":"https://api.github.com/repos/d3plus/d3plus-shape/milestones{/number}","notifications_url":"https://api.github.com/repos/d3plus/d3plus-shape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3plus/d3plus-shape/labels{/name}","releases_url":"https://api.github.com/repos/d3plus/d3plus-shape/releases{/id}","deployments_url":"https://api.github.com/repos/d3plus/d3plus-shape/deployments","created_at":"2015-07-27T02:17:08Z","updated_at":"2018-06-08T16:31:36Z","pushed_at":"2018-06-08T16:52:17Z","git_url":"git://github.com/d3plus/d3plus-shape.git","ssh_url":"git@github.com:d3plus/d3plus-shape.git","clone_url":"https://github.com/d3plus/d3plus-shape.git","svn_url":"https://github.com/d3plus/d3plus-shape","homepage":"","size":2032,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"d3plus:master","ref":"master","sha":"917caefd29be8eb30411aa42ceac8a7599998c6a","user":{"login":"d3plus","id":13490477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDkwNDc3","avatar_url":"https://avatars0.githubusercontent.com/u/13490477?v=4","gravatar_id":"","url":"https://api.github.com/users/d3plus","html_url":"https://github.com/d3plus","followers_url":"https://api.github.com/users/d3plus/followers","following_url":"https://api.github.com/users/d3plus/following{/other_user}","gists_url":"https://api.github.com/users/d3plus/gists{/gist_id}","starred_url":"https://api.github.com/users/d3plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3plus/subscriptions","organizations_url":"https://api.github.com/users/d3plus/orgs","repos_url":"https://api.github.com/users/d3plus/repos","events_url":"https://api.github.com/users/d3plus/events{/privacy}","received_events_url":"https://api.github.com/users/d3plus/received_events","type":"Organization","site_admin":false},"repo":{"id":39750654,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc1MDY1NA==","name":"d3plus-shape","full_name":"d3plus/d3plus-shape","owner":{"login":"d3plus","id":13490477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDkwNDc3","avatar_url":"https://avatars0.githubusercontent.com/u/13490477?v=4","gravatar_id":"","url":"https://api.github.com/users/d3plus","html_url":"https://github.com/d3plus","followers_url":"https://api.github.com/users/d3plus/followers","following_url":"https://api.github.com/users/d3plus/following{/other_user}","gists_url":"https://api.github.com/users/d3plus/gists{/gist_id}","starred_url":"https://api.github.com/users/d3plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3plus/subscriptions","organizations_url":"https://api.github.com/users/d3plus/orgs","repos_url":"https://api.github.com/users/d3plus/repos","events_url":"https://api.github.com/users/d3plus/events{/privacy}","received_events_url":"https://api.github.com/users/d3plus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d3plus/d3plus-shape","description":"Fancy SVG shapes for visualizations","fork":false,"url":"https://api.github.com/repos/d3plus/d3plus-shape","forks_url":"https://api.github.com/repos/d3plus/d3plus-shape/forks","keys_url":"https://api.github.com/repos/d3plus/d3plus-shape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3plus/d3plus-shape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3plus/d3plus-shape/teams","hooks_url":"https://api.github.com/repos/d3plus/d3plus-shape/hooks","issue_events_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/events{/number}","events_url":"https://api.github.com/repos/d3plus/d3plus-shape/events","assignees_url":"https://api.github.com/repos/d3plus/d3plus-shape/assignees{/user}","branches_url":"https://api.github.com/repos/d3plus/d3plus-shape/branches{/branch}","tags_url":"https://api.github.com/repos/d3plus/d3plus-shape/tags","blobs_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3plus/d3plus-shape/statuses/{sha}","languages_url":"https://api.github.com/repos/d3plus/d3plus-shape/languages","stargazers_url":"https://api.github.com/repos/d3plus/d3plus-shape/stargazers","contributors_url":"https://api.github.com/repos/d3plus/d3plus-shape/contributors","subscribers_url":"https://api.github.com/repos/d3plus/d3plus-shape/subscribers","subscription_url":"https://api.github.com/repos/d3plus/d3plus-shape/subscription","commits_url":"https://api.github.com/repos/d3plus/d3plus-shape/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3plus/d3plus-shape/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3plus/d3plus-shape/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3plus/d3plus-shape/contents/{+path}","compare_url":"https://api.github.com/repos/d3plus/d3plus-shape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3plus/d3plus-shape/merges","archive_url":"https://api.github.com/repos/d3plus/d3plus-shape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3plus/d3plus-shape/downloads","issues_url":"https://api.github.com/repos/d3plus/d3plus-shape/issues{/number}","pulls_url":"https://api.github.com/repos/d3plus/d3plus-shape/pulls{/number}","milestones_url":"https://api.github.com/repos/d3plus/d3plus-shape/milestones{/number}","notifications_url":"https://api.github.com/repos/d3plus/d3plus-shape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3plus/d3plus-shape/labels{/name}","releases_url":"https://api.github.com/repos/d3plus/d3plus-shape/releases{/id}","deployments_url":"https://api.github.com/repos/d3plus/d3plus-shape/deployments","created_at":"2015-07-27T02:17:08Z","updated_at":"2018-06-08T16:31:36Z","pushed_at":"2018-06-08T16:52:17Z","git_url":"git://github.com/d3plus/d3plus-shape.git","ssh_url":"git@github.com:d3plus/d3plus-shape.git","clone_url":"https://github.com/d3plus/d3plus-shape.git","svn_url":"https://github.com/d3plus/d3plus-shape","homepage":"","size":2032,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81"},"html":{"href":"https://github.com/d3plus/d3plus-shape/pull/81"},"issue":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/issues/81"},"comments":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/d3plus/d3plus-shape/statuses/04bd375d92cd8714edb2236c229993e52e5d8cd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davelandry"}}