{"action":"created","comment":{"url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/comments/187049098","pull_request_review_id":118749227,"id":187049098,"diff_hunk":"@@ -170,20 +318,25 @@ public Response listClassifications(@Context UriInfo info, @Context HttpServletR\n      *      - 'opened' - (together with 'jstree') - all nodes will be opened\n      *      - 'disabled' - (together with 'jstree') - all nodes will be disabled\n      *      - 'selected' - (together with 'jstree') - all nodes will be selected\n-     * @param request - the HTTPServletRequestObject\n      * @param callback - used in JSONP to wrap json result into a Javascript function named by callback parameter\n      * @return a Jersey Response object\n-     * @throws MCRRestAPIException\n      */\n     @GET\n     //@Path(\"/id/{value}{format:(\\\\.[^/]+?)?}\")  -> working, but returns empty string instead of default value\n     @Path(\"/{classID}\")\n     @Produces({ MediaType.TEXT_XML + \";charset=UTF-8\", MediaType.APPLICATION_JSON + \";charset=UTF-8\" })\n-    public Response showObject(@Context HttpServletRequest request, @PathParam(\"classID\") String classID,\n+    @MCRCacheControl(maxAge = @MCRCacheControl.Age(time = 1, unit = TimeUnit.HOURS),\n+        sMaxAge = @MCRCacheControl.Age(time = 1, unit = TimeUnit.HOURS))\n+    public Response showObject(@PathParam(\"classID\") String classID,","path":"mycore-restapi/src/main/java/org/mycore/restapi/v1/MCRRestAPIClassifications.java","position":268,"original_position":268,"commit_id":"8fc98c98aaa6ce5c285d2506a9e0259c485026d6","original_commit_id":"8fc98c98aaa6ce5c285d2506a9e0259c485026d6","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [The method showObject() has an NPath complexity of 22134](https://app.codacy.com/app/MyCoRe/mycore/pullRequest?prid=1629279)","created_at":"2018-05-09T13:59:04Z","updated_at":"2018-05-09T13:59:04Z","html_url":"https://github.com/MyCoRe-Org/mycore/pull/576#discussion_r187049098","pull_request_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/comments/187049098"},"html":{"href":"https://github.com/MyCoRe-Org/mycore/pull/576#discussion_r187049098"},"pull_request":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576"}}},"pull_request":{"url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576","id":186891815,"html_url":"https://github.com/MyCoRe-Org/mycore/pull/576","diff_url":"https://github.com/MyCoRe-Org/mycore/pull/576.diff","patch_url":"https://github.com/MyCoRe-Org/mycore/pull/576.patch","issue_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/576","number":576,"state":"open","locked":false,"title":"MCR-1824 mycore restapi overhaul","user":{"login":"yagee-de","id":2152273,"avatar_url":"https://avatars3.githubusercontent.com/u/2152273?v=4","gravatar_id":"","url":"https://api.github.com/users/yagee-de","html_url":"https://github.com/yagee-de","followers_url":"https://api.github.com/users/yagee-de/followers","following_url":"https://api.github.com/users/yagee-de/following{/other_user}","gists_url":"https://api.github.com/users/yagee-de/gists{/gist_id}","starred_url":"https://api.github.com/users/yagee-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yagee-de/subscriptions","organizations_url":"https://api.github.com/users/yagee-de/orgs","repos_url":"https://api.github.com/users/yagee-de/repos","events_url":"https://api.github.com/users/yagee-de/events{/privacy}","received_events_url":"https://api.github.com/users/yagee-de/received_events","type":"User","site_admin":false},"body":"[Link to jira](https://mycore.atlassian.net/browse/MCR-1824).\r\n\r\nFixes session handling, authentication and authorization for REST Api v1.\r\nUses new JWT library with shared secret instead of certificate (changed in v1).\r\n\r\nAdded proposal for v2:\r\n- Repository information (read)\r\n- Classifications (read & write)\r\n- MCRObject (read & write)\r\n- MCRDerivate (read & write)\r\n- Files and directories (read & write)\r\n","created_at":"2018-05-09T11:21:08Z","updated_at":"2018-05-09T13:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b99ba2260dbdb4c92243c08db955b58fe081e41","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kkrebs","id":944083,"avatar_url":"https://avatars2.githubusercontent.com/u/944083?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrebs","html_url":"https://github.com/kkrebs","followers_url":"https://api.github.com/users/kkrebs/followers","following_url":"https://api.github.com/users/kkrebs/following{/other_user}","gists_url":"https://api.github.com/users/kkrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrebs/subscriptions","organizations_url":"https://api.github.com/users/kkrebs/orgs","repos_url":"https://api.github.com/users/kkrebs/repos","events_url":"https://api.github.com/users/kkrebs/events{/privacy}","received_events_url":"https://api.github.com/users/kkrebs/received_events","type":"User","site_admin":false},{"login":"Mewel","id":1984531,"avatar_url":"https://avatars2.githubusercontent.com/u/1984531?v=4","gravatar_id":"","url":"https://api.github.com/users/Mewel","html_url":"https://github.com/Mewel","followers_url":"https://api.github.com/users/Mewel/followers","following_url":"https://api.github.com/users/Mewel/following{/other_user}","gists_url":"https://api.github.com/users/Mewel/gists{/gist_id}","starred_url":"https://api.github.com/users/Mewel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mewel/subscriptions","organizations_url":"https://api.github.com/users/Mewel/orgs","repos_url":"https://api.github.com/users/Mewel/repos","events_url":"https://api.github.com/users/Mewel/events{/privacy}","received_events_url":"https://api.github.com/users/Mewel/received_events","type":"User","site_admin":false},{"login":"rsteph-de","id":20067327,"avatar_url":"https://avatars2.githubusercontent.com/u/20067327?v=4","gravatar_id":"","url":"https://api.github.com/users/rsteph-de","html_url":"https://github.com/rsteph-de","followers_url":"https://api.github.com/users/rsteph-de/followers","following_url":"https://api.github.com/users/rsteph-de/following{/other_user}","gists_url":"https://api.github.com/users/rsteph-de/gists{/gist_id}","starred_url":"https://api.github.com/users/rsteph-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsteph-de/subscriptions","organizations_url":"https://api.github.com/users/rsteph-de/orgs","repos_url":"https://api.github.com/users/rsteph-de/repos","events_url":"https://api.github.com/users/rsteph-de/events{/privacy}","received_events_url":"https://api.github.com/users/rsteph-de/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576/commits","review_comments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576/comments","review_comment_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/576/comments","statuses_url":"https://api.github.com/repos/MyCoRe-Org/mycore/statuses/8fc98c98aaa6ce5c285d2506a9e0259c485026d6","head":{"label":"MyCoRe-Org:issues/MCR-1824-mycore-restapi-overhaul","ref":"issues/MCR-1824-mycore-restapi-overhaul","sha":"8fc98c98aaa6ce5c285d2506a9e0259c485026d6","user":{"login":"MyCoRe-Org","id":20062922,"avatar_url":"https://avatars0.githubusercontent.com/u/20062922?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCoRe-Org","html_url":"https://github.com/MyCoRe-Org","followers_url":"https://api.github.com/users/MyCoRe-Org/followers","following_url":"https://api.github.com/users/MyCoRe-Org/following{/other_user}","gists_url":"https://api.github.com/users/MyCoRe-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCoRe-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCoRe-Org/subscriptions","organizations_url":"https://api.github.com/users/MyCoRe-Org/orgs","repos_url":"https://api.github.com/users/MyCoRe-Org/repos","events_url":"https://api.github.com/users/MyCoRe-Org/events{/privacy}","received_events_url":"https://api.github.com/users/MyCoRe-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":70219747,"name":"mycore","full_name":"MyCoRe-Org/mycore","owner":{"login":"MyCoRe-Org","id":20062922,"avatar_url":"https://avatars0.githubusercontent.com/u/20062922?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCoRe-Org","html_url":"https://github.com/MyCoRe-Org","followers_url":"https://api.github.com/users/MyCoRe-Org/followers","following_url":"https://api.github.com/users/MyCoRe-Org/following{/other_user}","gists_url":"https://api.github.com/users/MyCoRe-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCoRe-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCoRe-Org/subscriptions","organizations_url":"https://api.github.com/users/MyCoRe-Org/orgs","repos_url":"https://api.github.com/users/MyCoRe-Org/repos","events_url":"https://api.github.com/users/MyCoRe-Org/events{/privacy}","received_events_url":"https://api.github.com/users/MyCoRe-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyCoRe-Org/mycore","description":"MyCoRe (acronym for My Content Repository) is an open source repository software framework for building disciplinary or institutional repositories, digital archives, digital libraries, and scientific journals.","fork":false,"url":"https://api.github.com/repos/MyCoRe-Org/mycore","forks_url":"https://api.github.com/repos/MyCoRe-Org/mycore/forks","keys_url":"https://api.github.com/repos/MyCoRe-Org/mycore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyCoRe-Org/mycore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyCoRe-Org/mycore/teams","hooks_url":"https://api.github.com/repos/MyCoRe-Org/mycore/hooks","issue_events_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/events{/number}","events_url":"https://api.github.com/repos/MyCoRe-Org/mycore/events","assignees_url":"https://api.github.com/repos/MyCoRe-Org/mycore/assignees{/user}","branches_url":"https://api.github.com/repos/MyCoRe-Org/mycore/branches{/branch}","tags_url":"https://api.github.com/repos/MyCoRe-Org/mycore/tags","blobs_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyCoRe-Org/mycore/statuses/{sha}","languages_url":"https://api.github.com/repos/MyCoRe-Org/mycore/languages","stargazers_url":"https://api.github.com/repos/MyCoRe-Org/mycore/stargazers","contributors_url":"https://api.github.com/repos/MyCoRe-Org/mycore/contributors","subscribers_url":"https://api.github.com/repos/MyCoRe-Org/mycore/subscribers","subscription_url":"https://api.github.com/repos/MyCoRe-Org/mycore/subscription","commits_url":"https://api.github.com/repos/MyCoRe-Org/mycore/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyCoRe-Org/mycore/contents/{+path}","compare_url":"https://api.github.com/repos/MyCoRe-Org/mycore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyCoRe-Org/mycore/merges","archive_url":"https://api.github.com/repos/MyCoRe-Org/mycore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyCoRe-Org/mycore/downloads","issues_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues{/number}","pulls_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls{/number}","milestones_url":"https://api.github.com/repos/MyCoRe-Org/mycore/milestones{/number}","notifications_url":"https://api.github.com/repos/MyCoRe-Org/mycore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyCoRe-Org/mycore/labels{/name}","releases_url":"https://api.github.com/repos/MyCoRe-Org/mycore/releases{/id}","deployments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/deployments","created_at":"2016-10-07T06:02:02Z","updated_at":"2018-05-07T13:33:22Z","pushed_at":"2018-05-09T13:54:11Z","git_url":"git://github.com/MyCoRe-Org/mycore.git","ssh_url":"git@github.com:MyCoRe-Org/mycore.git","clone_url":"https://github.com/MyCoRe-Org/mycore.git","svn_url":"https://github.com/MyCoRe-Org/mycore","homepage":null,"size":229290,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":7,"watchers":12,"default_branch":"master"}},"base":{"label":"MyCoRe-Org:master","ref":"master","sha":"11d2b72c87b3661a27b498c82f8cbdfcf7e787be","user":{"login":"MyCoRe-Org","id":20062922,"avatar_url":"https://avatars0.githubusercontent.com/u/20062922?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCoRe-Org","html_url":"https://github.com/MyCoRe-Org","followers_url":"https://api.github.com/users/MyCoRe-Org/followers","following_url":"https://api.github.com/users/MyCoRe-Org/following{/other_user}","gists_url":"https://api.github.com/users/MyCoRe-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCoRe-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCoRe-Org/subscriptions","organizations_url":"https://api.github.com/users/MyCoRe-Org/orgs","repos_url":"https://api.github.com/users/MyCoRe-Org/repos","events_url":"https://api.github.com/users/MyCoRe-Org/events{/privacy}","received_events_url":"https://api.github.com/users/MyCoRe-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":70219747,"name":"mycore","full_name":"MyCoRe-Org/mycore","owner":{"login":"MyCoRe-Org","id":20062922,"avatar_url":"https://avatars0.githubusercontent.com/u/20062922?v=4","gravatar_id":"","url":"https://api.github.com/users/MyCoRe-Org","html_url":"https://github.com/MyCoRe-Org","followers_url":"https://api.github.com/users/MyCoRe-Org/followers","following_url":"https://api.github.com/users/MyCoRe-Org/following{/other_user}","gists_url":"https://api.github.com/users/MyCoRe-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/MyCoRe-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyCoRe-Org/subscriptions","organizations_url":"https://api.github.com/users/MyCoRe-Org/orgs","repos_url":"https://api.github.com/users/MyCoRe-Org/repos","events_url":"https://api.github.com/users/MyCoRe-Org/events{/privacy}","received_events_url":"https://api.github.com/users/MyCoRe-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyCoRe-Org/mycore","description":"MyCoRe (acronym for My Content Repository) is an open source repository software framework for building disciplinary or institutional repositories, digital archives, digital libraries, and scientific journals.","fork":false,"url":"https://api.github.com/repos/MyCoRe-Org/mycore","forks_url":"https://api.github.com/repos/MyCoRe-Org/mycore/forks","keys_url":"https://api.github.com/repos/MyCoRe-Org/mycore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyCoRe-Org/mycore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyCoRe-Org/mycore/teams","hooks_url":"https://api.github.com/repos/MyCoRe-Org/mycore/hooks","issue_events_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/events{/number}","events_url":"https://api.github.com/repos/MyCoRe-Org/mycore/events","assignees_url":"https://api.github.com/repos/MyCoRe-Org/mycore/assignees{/user}","branches_url":"https://api.github.com/repos/MyCoRe-Org/mycore/branches{/branch}","tags_url":"https://api.github.com/repos/MyCoRe-Org/mycore/tags","blobs_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyCoRe-Org/mycore/statuses/{sha}","languages_url":"https://api.github.com/repos/MyCoRe-Org/mycore/languages","stargazers_url":"https://api.github.com/repos/MyCoRe-Org/mycore/stargazers","contributors_url":"https://api.github.com/repos/MyCoRe-Org/mycore/contributors","subscribers_url":"https://api.github.com/repos/MyCoRe-Org/mycore/subscribers","subscription_url":"https://api.github.com/repos/MyCoRe-Org/mycore/subscription","commits_url":"https://api.github.com/repos/MyCoRe-Org/mycore/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyCoRe-Org/mycore/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyCoRe-Org/mycore/contents/{+path}","compare_url":"https://api.github.com/repos/MyCoRe-Org/mycore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyCoRe-Org/mycore/merges","archive_url":"https://api.github.com/repos/MyCoRe-Org/mycore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyCoRe-Org/mycore/downloads","issues_url":"https://api.github.com/repos/MyCoRe-Org/mycore/issues{/number}","pulls_url":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls{/number}","milestones_url":"https://api.github.com/repos/MyCoRe-Org/mycore/milestones{/number}","notifications_url":"https://api.github.com/repos/MyCoRe-Org/mycore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyCoRe-Org/mycore/labels{/name}","releases_url":"https://api.github.com/repos/MyCoRe-Org/mycore/releases{/id}","deployments_url":"https://api.github.com/repos/MyCoRe-Org/mycore/deployments","created_at":"2016-10-07T06:02:02Z","updated_at":"2018-05-07T13:33:22Z","pushed_at":"2018-05-09T13:54:11Z","git_url":"git://github.com/MyCoRe-Org/mycore.git","ssh_url":"git@github.com:MyCoRe-Org/mycore.git","clone_url":"https://github.com/MyCoRe-Org/mycore.git","svn_url":"https://github.com/MyCoRe-Org/mycore","homepage":null,"size":229290,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576"},"html":{"href":"https://github.com/MyCoRe-Org/mycore/pull/576"},"issue":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/576"},"comments":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/issues/576/comments"},"review_comments":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576/comments"},"review_comment":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/pulls/576/commits"},"statuses":{"href":"https://api.github.com/repos/MyCoRe-Org/mycore/statuses/8fc98c98aaa6ce5c285d2506a9e0259c485026d6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"codacy-bot"}}