{"action":"created","issue":{"url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/661","repository_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind","labels_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/661/labels{/name}","comments_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/661/comments","events_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/661/events","html_url":"https://github.com/NASAWorldWind/WebWorldWind/pull/661","id":319703926,"number":661,"title":"Replacement of Bing logo image credit for a ScreenImage","user":{"login":"Beak-man","id":7622894,"avatar_url":"https://avatars3.githubusercontent.com/u/7622894?v=4","gravatar_id":"","url":"https://api.github.com/users/Beak-man","html_url":"https://github.com/Beak-man","followers_url":"https://api.github.com/users/Beak-man/followers","following_url":"https://api.github.com/users/Beak-man/following{/other_user}","gists_url":"https://api.github.com/users/Beak-man/gists{/gist_id}","starred_url":"https://api.github.com/users/Beak-man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beak-man/subscriptions","organizations_url":"https://api.github.com/users/Beak-man/orgs","repos_url":"https://api.github.com/users/Beak-man/repos","events_url":"https://api.github.com/users/Beak-man/events{/privacy}","received_events_url":"https://api.github.com/users/Beak-man/received_events","type":"User","site_admin":false},"labels":[{"id":628237623,"url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":{"login":"Beak-man","id":7622894,"avatar_url":"https://avatars3.githubusercontent.com/u/7622894?v=4","gravatar_id":"","url":"https://api.github.com/users/Beak-man","html_url":"https://github.com/Beak-man","followers_url":"https://api.github.com/users/Beak-man/followers","following_url":"https://api.github.com/users/Beak-man/following{/other_user}","gists_url":"https://api.github.com/users/Beak-man/gists{/gist_id}","starred_url":"https://api.github.com/users/Beak-man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beak-man/subscriptions","organizations_url":"https://api.github.com/users/Beak-man/orgs","repos_url":"https://api.github.com/users/Beak-man/repos","events_url":"https://api.github.com/users/Beak-man/events{/privacy}","received_events_url":"https://api.github.com/users/Beak-man/received_events","type":"User","site_admin":false},"assignees":[{"login":"Beak-man","id":7622894,"avatar_url":"https://avatars3.githubusercontent.com/u/7622894?v=4","gravatar_id":"","url":"https://api.github.com/users/Beak-man","html_url":"https://github.com/Beak-man","followers_url":"https://api.github.com/users/Beak-man/followers","following_url":"https://api.github.com/users/Beak-man/following{/other_user}","gists_url":"https://api.github.com/users/Beak-man/gists{/gist_id}","starred_url":"https://api.github.com/users/Beak-man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beak-man/subscriptions","organizations_url":"https://api.github.com/users/Beak-man/orgs","repos_url":"https://api.github.com/users/Beak-man/repos","events_url":"https://api.github.com/users/Beak-man/events{/privacy}","received_events_url":"https://api.github.com/users/Beak-man/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/milestones/2","html_url":"https://github.com/NASAWorldWind/WebWorldWind/milestone/2","labels_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/milestones/2/labels","id":2891822,"number":2,"title":"WebWW v0.10.0","description":"","creator":{"login":"pdavidc","id":14062862,"avatar_url":"https://avatars0.githubusercontent.com/u/14062862?v=4","gravatar_id":"","url":"https://api.github.com/users/pdavidc","html_url":"https://github.com/pdavidc","followers_url":"https://api.github.com/users/pdavidc/followers","following_url":"https://api.github.com/users/pdavidc/following{/other_user}","gists_url":"https://api.github.com/users/pdavidc/gists{/gist_id}","starred_url":"https://api.github.com/users/pdavidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdavidc/subscriptions","organizations_url":"https://api.github.com/users/pdavidc/orgs","repos_url":"https://api.github.com/users/pdavidc/repos","events_url":"https://api.github.com/users/pdavidc/events{/privacy}","received_events_url":"https://api.github.com/users/pdavidc/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":115,"state":"open","created_at":"2017-11-06T17:32:27Z","updated_at":"2018-05-02T21:28:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-02T20:39:56Z","updated_at":"2018-05-02T23:35:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/pulls/661","html_url":"https://github.com/NASAWorldWind/WebWorldWind/pull/661","diff_url":"https://github.com/NASAWorldWind/WebWorldWind/pull/661.diff","patch_url":"https://github.com/NASAWorldWind/WebWorldWind/pull/661.patch"},"body":"### Description of the Change\r\nRemoved image credit usage from Bing's layers in order to replace it with a ScreenImage with the same contents.\r\nBing seems to be a special case among 3rd party imagery providers in that they require displaying their logo (instead of only string-based attributions) when their imagery is used. With this change we maintain compliance with Bing's TOS while setting the stage to simplify our general handling of attributions by relying only in text-based credits in a future step.\r\n\r\n### Benefits\r\n- Maintains compliance with Bing's TOS by displaying their logo when their tiles are displayed in the globe. \r\n- Enables us to handle credits independently of this logo in order to address credit cluttering and customization.\r\n- Places the logo where screen real estate is available without operlapping other WebWW overlay elements. The logo accommodates itself when coordinates display is moved to the top of the canvas in small screens, utilizing the same resolution criteria as CoordinatesDisplayLayer.\r\n\r\n### Potential Drawbacks\r\n- Bing's logo is not retrieved from its web service. This was attempted but the URL provided by Bing's REST service does not allow CORS, plus it's hosted via insecure http. Another source that allowed hotlinking couldn't be found. This still uses our locally hosted Bing logo image file.\r\n\r\n- Aesthetic choices on where to put the Bing logo. This can of course be changed after feedback from the team.\r\n\r\n### Applicable Issues\r\nRelates to #659."},"comment":{"url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/comments/386153122","html_url":"https://github.com/NASAWorldWind/WebWorldWind/pull/661#issuecomment-386153122","issue_url":"https://api.github.com/repos/NASAWorldWind/WebWorldWind/issues/661","id":386153122,"user":{"login":"Beak-man","id":7622894,"avatar_url":"https://avatars3.githubusercontent.com/u/7622894?v=4","gravatar_id":"","url":"https://api.github.com/users/Beak-man","html_url":"https://github.com/Beak-man","followers_url":"https://api.github.com/users/Beak-man/followers","following_url":"https://api.github.com/users/Beak-man/following{/other_user}","gists_url":"https://api.github.com/users/Beak-man/gists{/gist_id}","starred_url":"https://api.github.com/users/Beak-man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beak-man/subscriptions","organizations_url":"https://api.github.com/users/Beak-man/orgs","repos_url":"https://api.github.com/users/Beak-man/repos","events_url":"https://api.github.com/users/Beak-man/events{/privacy}","received_events_url":"https://api.github.com/users/Beak-man/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T23:35:40Z","updated_at":"2018-05-02T23:35:40Z","author_association":"MEMBER","body":"@pdavidc , @markpet49 , indeed filtering looks different. With screen credits, we apply opacity to the credits as a layer. In this implementation opacity is given to the screen image directly. Maybe that's where the difference stems from?\r\n\r\nThe image credit looks stretched by a single pixel compared to the logotype as implemented in this pull request. I couldn't replicate the exact alignment given by ScreenCreditController. The differences can be seen below (the screenshot with the OpenStreetMap attribution is the current implementation in develop).\r\n\r\n![binglogopositioning](https://user-images.githubusercontent.com/7622894/39554274-8a4687d8-4e37-11e8-90ca-38162b79223f.gif)\r\n"}}
{"actor":{"display_login":"Beak-man"}}