{"push_id":2611556125,"size":36,"distinct_size":10,"ref":"refs/heads/fg/manage_DUID-rh1414093","head":"9fea5c95c89f521027971fbf26948c29eb942247","before":"5c4bd963d0fb56e4a57b3d334d19b9e79af573d0","commits":[{"sha":"3021a8cf6b2a3dd4596b7dfcf4c08b5efa8d5c2e","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared/trivial: rename local variable class\n\nThere is no real problem with using \"class\" in C. However, it would\nbe a keyword in C++. Just avoid it, and use \"klass\" instead.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/3021a8cf6b2a3dd4596b7dfcf4c08b5efa8d5c2e"},{"sha":"84a6eff106732f9754896c53599f907f811aed8e","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: don't allow aliases re-numbering in _nm_utils_enum_from_str_full()\n\nFor _nm_utils_enum_to_str_full(), we always first look whether we have\nan alias/nick for the numeric value, and preferably use that. That makes a\nlot of sense, as it allows the caller to provide better names (aliases),\nwhich are preferred over the name from the GLib type. It renames the\nnumeric value.\n\nFor the reverse conversion, this makes less sense. A name should have a\nunique numeric value. That is, we should not use one name that maps to\na different numeric value based on value_infos and GLib type. IOW, we\nshould not re-number names.\n\nAdd an assertion that we don't provide such a value_infos parameter,\nthat conflicts with names from GLib type.\n\nAlso, although the case where GLib type and value_infos disagree is now\nforbidden by an assert, reorder the statements in _nm_utils_enum_from_str_full()\ntoo. There is no difference in practice, but it mirros what we do in the\nto-str case.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/84a6eff106732f9754896c53599f907f811aed8e"},{"sha":"54356ac8c7ee922a51c0a5428839d31b58d7ea92","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: don't use nm_str_hash() in \"nm-enum-utils.c\"\n\nThis was only used for some extra assertions. It' is not essential.\nIf this would be for real usage, we should add a dependancy so that\nnm-utils/nm-enum-utils.c requires nm-hash-utils.h. But as it is,\nthis is not necessary.\n\nThis fixes build for meson, which wrongly tries to build nm-enum-utils.c\nfor libnm-util, but then fails to include nm-hash-utils.c. That should\nbe fixed independently.\n\nFixes: 84a6eff106732f9754896c53599f907f811aed8e","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/54356ac8c7ee922a51c0a5428839d31b58d7ea92"},{"sha":"851d89dc6ab59cd19de03fc842893fabe8c33036","author":{"name":"Beniamino Galvani","email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com"},"message":"platform: sort known IPv6 addresses by scope before a sync\n\nThe order we want to enforce is only among addresses with the same\nscope, as the kernel always keeps addresses sorted by\nscope. Therefore, apply the same sorting to known addresses, so that\nwe don't try to unnecessary change the order of addresses with\ndifferent scopes.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1578668","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/851d89dc6ab59cd19de03fc842893fabe8c33036"},{"sha":"fd86a1aebbcdbfd9854ca5f9755e8e2fe90e5f1d","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"settings: refactor load_plugins() to remote a harmful use of goto\n\nTurn the plugin loading logic between load_plugin: and next: into a\nsubroutine.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/fd86a1aebbcdbfd9854ca5f9755e8e2fe90e5f1d"},{"sha":"159cb0302c0e988fd25785628b098e036b77a7fb","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"settings: simplify the settings plugin loading log line\n\nIt's actually annoying, useless and wraps over even on wide displays.\nLet's make it consistent with the log line we use for device plugins.\n\nAlso, this drops the last use of the \"info\" property and one useless use\nof the \"name\" property.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/159cb0302c0e988fd25785628b098e036b77a7fb"},{"sha":"8b6c998a949747c46c05b72d2be721117398e212","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"settings: don't use the name property to disambiguate plugins\n\nUse the path instead. This drop an useless use of the \"name\" property,\nwhich is, coincidentally also wrong. (We use \"ibft\" in the plugin path\nwhereas the property is set to \"iBFT\".)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8b6c998a949747c46c05b72d2be721117398e212"},{"sha":"011225306470675cd36931ef0e8bf96e28a8baf8","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"settings: do away with plugin capabilities\n\nThere's exactly one and not too useful -- only used only in one spot\nwhere we can do hapilly without it.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/011225306470675cd36931ef0e8bf96e28a8baf8"},{"sha":"0a3f1ab1a448f41ca7974dcacbb5a6720a158d40","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"settings-plugin: drop all properties\n\nThey're not useful and just add extra noise.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0a3f1ab1a448f41ca7974dcacbb5a6720a158d40"},{"sha":"581ce347fbcff0f8190ad200f6314592a209d818","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"merge: branch 'lr/setting-plugin-props-cleanup'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/119","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/581ce347fbcff0f8190ad200f6314592a209d818"},{"sha":"cdbd99c5d5b5a62c5d4bf4d5e7a49e97e307d987","author":{"name":"Alfonso Sánchez-Beato","email":"7cc8c697fbe95a459af6ba78e749d4b11d0bc464@canonical.com"},"message":"platform/wifi: do not double-free nl_msg\n\nIn some places, there was an unneeded call to nlmsg_free () for\nmessages declared with the nm_auto_nlmsg macro.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cdbd99c5d5b5a62c5d4bf4d5e7a49e97e307d987"},{"sha":"82b088ab5f8b619cbbd187d1906e196deaf759ef","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build: don't add shared/nm-utils directory to include search path\n\nAll users are supposed to include files from nm-utils by fully specifying\nthe path. -I.*shared/nm-utils is wrong.\n\nOnly, systemd code likes to include \"siphash24.h\" directly. Instead of\nadding \"-Ishared/nm-utils\" to the search path, add an intermediary\nheader to sd-adapt. Note, that in the meantime we anyway should rework\nsiphash24 to use shared/c-siphash instead.\n\nThis also fixes build for meson, which was broken recently.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/82b088ab5f8b619cbbd187d1906e196deaf759ef"},{"sha":"e5d1a71396e107d1909744d26ad401f206c0c915","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build: unifiy specifying locale directory define","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e5d1a71396e107d1909744d26ad401f206c0c915"},{"sha":"d63cf1ef2faba57595112a82e962b9643cce4718","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build: use common locale directory for building nmtui\n\nAll other places use $(nmlocaledir) variable.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d63cf1ef2faba57595112a82e962b9643cce4718"},{"sha":"7fcf33908be0ec10c7ed8a2a36bf8bf516058f5e","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build: define NM_BUILD_SRCDIR and NM_BUILD_BUILDDIR","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7fcf33908be0ec10c7ed8a2a36bf8bf516058f5e"},{"sha":"b7426e91dbcbc9080e0018a43efd0aec1f5fc5ba","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build: use default NM_BUILD_* defines for tests\n\nUse two common defines NM_BUILD_SRCDIR and NM_BUILD_BUILDDIR\nfor specifying the location of srcdir and builddir.\n\nNote that this is only relevant for tests, as they expect\na certain layout of the directories, to find files that concern\nthem.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/b7426e91dbcbc9080e0018a43efd0aec1f5fc5ba"},{"sha":"b8b6100c78a039c9ae02013860b1e1a93ac1783a","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"all: replace systemd's siphash24 with c-siphash\n\nOriginally, we used \"nm-utils/siphash24.c\", which was copied\nfrom systemd's source tree. It was both used by our own NetworkManager\ncode, and by our internal systemd fork.\n\nThen, we added \"shared/c-siphash\" as a dependency for n-acd.\n\nNow, drop systemd's implementation and use c-siphash also\nfor our internal purpose. Also, let systemd code use c-siphash,\nby patching \"src/systemd/src/basic/siphash24.h\".","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/b8b6100c78a039c9ae02013860b1e1a93ac1783a"},{"sha":"f445128af4255cc1c195530bd888f2024a4f71f3","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build/meson: fix meson build for shared files\n\nThe files in shared/nm-utils are not compiled as one static library,\ninstead each subproject that needs (parts of) them, re-compiles the\nfiles individually.\n\nThe major reason for that is, because we might have different compile\nflags, depending on whether we build libnm-core or\nlibnm-util/libnm-glib. Actually, I think that is not really the case,\nand maybe this should be refactored, to indeed build them all as a\nstatic library first.\n\nAnyway, libnm-util, libnm-glib, clients' common lib, they all need a\ndifferent set of shared files that they should compile. Refactor\n\"shared/meson.build\" to account for that and handle it like autotools\ndoes.\n\nAnother change is, that \"shared_c_siphash_dep\" no longer advertises\n\"include_directories: include_directories('c-siphash/src')\". We don't\nput c-siphash.h into the include search path. Users who need it, should\ninclude it via \"#include <c-siphash/src/c-siphash.h>\". The only exception\nis when building shared_n_acd library, which is not under our control.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f445128af4255cc1c195530bd888f2024a4f71f3"},{"sha":"cc472f52fb37cd653857e10dd24ecca5d68eb959","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"all: merge branch 'th/build-cleanup-defines'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/126","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cc472f52fb37cd653857e10dd24ecca5d68eb959"},{"sha":"ad7b700d6a2bdccadd5a06c97c1eede75a7e5d78","author":{"name":"Lubomir Rintel","email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk"},"message":"test: don't assert on the tun link being up to date prior to upping it\n\nFixes the test run with:\n\n  NMTST_SEED_RAND=502735495 src/platform/tests/test-link-linux \\\n      -p /link/software/detect/tun/external","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ad7b700d6a2bdccadd5a06c97c1eede75a7e5d78"}]}
{"actor":{"display_login":"lkundrak"}}