{"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/comments/214837829","pull_request_review_id":151971724,"id":214837829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDgzNzgyOQ==","diff_hunk":"@@ -0,0 +1,15 @@\n+pragma solidity ^0.4.21;\n+\n+// NOTE:\n+//  This file porpouse is just to make sure truffle compiles all of depending\n+//  contracts when we are in development.\n+// \n+//  For other environments, we just use the compiled contracts from the NPM \n+//  package\n+ \n+ \n+// TODO: Use the same getter pattern also for dependencies\n+import \"@gnosis.pm/util-contracts/contracts/StandardToken.sol\";","path":"contracts/DevDependencies.sol","position":null,"original_position":12,"commit_id":"e51be791c9ef37acfb44ff9b4e24cef1db84ac12","original_commit_id":"683e413364e9a0e8e87904cb0c6a9b005fddfd37","user":{"login":"fleupold","id":1200333,"node_id":"MDQ6VXNlcjEyMDAzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1200333?v=4","gravatar_id":"","url":"https://api.github.com/users/fleupold","html_url":"https://github.com/fleupold","followers_url":"https://api.github.com/users/fleupold/followers","following_url":"https://api.github.com/users/fleupold/following{/other_user}","gists_url":"https://api.github.com/users/fleupold/gists{/gist_id}","starred_url":"https://api.github.com/users/fleupold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fleupold/subscriptions","organizations_url":"https://api.github.com/users/fleupold/orgs","repos_url":"https://api.github.com/users/fleupold/repos","events_url":"https://api.github.com/users/fleupold/events{/privacy}","received_events_url":"https://api.github.com/users/fleupold/received_events","type":"User","site_admin":false},"body":"Why is EtherToken needed? Wouldn't the first time we are using it in code lead to it being compiled?","created_at":"2018-09-04T09:00:12Z","updated_at":"2018-09-04T09:00:13Z","html_url":"https://github.com/gnosis/dex-contracts/pull/3#discussion_r214837829","pull_request_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/comments/214837829"},"html":{"href":"https://github.com/gnosis/dex-contracts/pull/3#discussion_r214837829"},"pull_request":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3"}},"in_reply_to_id":214811200},"pull_request":{"url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3","id":212876788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODc2Nzg4","html_url":"https://github.com/gnosis/dex-contracts/pull/3","diff_url":"https://github.com/gnosis/dex-contracts/pull/3.diff","patch_url":"https://github.com/gnosis/dex-contracts/pull/3.patch","issue_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/3","number":3,"state":"closed","locked":false,"title":"Migration: first version of migration script","user":{"login":"josojo","id":7348154,"node_id":"MDQ6VXNlcjczNDgxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7348154?v=4","gravatar_id":"","url":"https://api.github.com/users/josojo","html_url":"https://github.com/josojo","followers_url":"https://api.github.com/users/josojo/followers","following_url":"https://api.github.com/users/josojo/following{/other_user}","gists_url":"https://api.github.com/users/josojo/gists{/gist_id}","starred_url":"https://api.github.com/users/josojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josojo/subscriptions","organizations_url":"https://api.github.com/users/josojo/orgs","repos_url":"https://api.github.com/users/josojo/repos","events_url":"https://api.github.com/users/josojo/events{/privacy}","received_events_url":"https://api.github.com/users/josojo/received_events","type":"User","site_admin":false},"body":"Hey,\r\n\r\n\r\nthis is the version for the migration script. This is not intended to be the final migration script. \r\n\r\nFollowing points can be discussed:\r\nBest practices on: Importing other smart contracts + their migration scripts/ \r\nIs there a better solution than DevDeppendencies.sol/ Update on Alan’s pr.\r\n\r\nGnosis-utils vs global standard of zeppelin Which ERC20/EtherToken etc.\r\n\r\nI put them on the agenda for the smartcontract weekly.","created_at":"2018-09-04T07:16:45Z","updated_at":"2018-09-04T09:00:13Z","closed_at":"2018-09-04T08:33:23Z","merged_at":"2018-09-04T08:33:23Z","merge_commit_sha":"75a28d708b838e2f56e797628b1db6ebe3e6d288","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3/commits","review_comments_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3/comments","review_comment_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/3/comments","statuses_url":"https://api.github.com/repos/gnosis/dex-contracts/statuses/e51be791c9ef37acfb44ff9b4e24cef1db84ac12","head":{"label":"gnosis:migrationScript","ref":"migrationScript","sha":"e51be791c9ef37acfb44ff9b4e24cef1db84ac12","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":146969218,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NjkyMTg=","name":"dex-contracts","full_name":"gnosis/dex-contracts","owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnosis/dex-contracts","description":"Here, we will have the contracts for our dex - plasma batch auctions","fork":false,"url":"https://api.github.com/repos/gnosis/dex-contracts","forks_url":"https://api.github.com/repos/gnosis/dex-contracts/forks","keys_url":"https://api.github.com/repos/gnosis/dex-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-contracts/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-contracts/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-contracts/events","assignees_url":"https://api.github.com/repos/gnosis/dex-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-contracts/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-contracts/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-contracts/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-contracts/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-contracts/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-contracts/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-contracts/merges","archive_url":"https://api.github.com/repos/gnosis/dex-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-contracts/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-contracts/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-contracts/deployments","created_at":"2018-09-01T05:02:29Z","updated_at":"2018-09-04T08:33:25Z","pushed_at":"2018-09-04T08:33:23Z","git_url":"git://github.com/gnosis/dex-contracts.git","ssh_url":"git@github.com:gnosis/dex-contracts.git","clone_url":"https://github.com/gnosis/dex-contracts.git","svn_url":"https://github.com/gnosis/dex-contracts","homepage":null,"size":90,"stargazers_count":2,"watchers_count":2,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"gnosis:develop","ref":"develop","sha":"61aec1cec9ab0cec1bfa5e19dec79ce027fb4c4d","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":146969218,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NjkyMTg=","name":"dex-contracts","full_name":"gnosis/dex-contracts","owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnosis/dex-contracts","description":"Here, we will have the contracts for our dex - plasma batch auctions","fork":false,"url":"https://api.github.com/repos/gnosis/dex-contracts","forks_url":"https://api.github.com/repos/gnosis/dex-contracts/forks","keys_url":"https://api.github.com/repos/gnosis/dex-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-contracts/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-contracts/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-contracts/events","assignees_url":"https://api.github.com/repos/gnosis/dex-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-contracts/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-contracts/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-contracts/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-contracts/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-contracts/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-contracts/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-contracts/merges","archive_url":"https://api.github.com/repos/gnosis/dex-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-contracts/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-contracts/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-contracts/deployments","created_at":"2018-09-01T05:02:29Z","updated_at":"2018-09-04T08:33:25Z","pushed_at":"2018-09-04T08:33:23Z","git_url":"git://github.com/gnosis/dex-contracts.git","ssh_url":"git@github.com:gnosis/dex-contracts.git","clone_url":"https://github.com/gnosis/dex-contracts.git","svn_url":"https://github.com/gnosis/dex-contracts","homepage":null,"size":90,"stargazers_count":2,"watchers_count":2,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3"},"html":{"href":"https://github.com/gnosis/dex-contracts/pull/3"},"issue":{"href":"https://api.github.com/repos/gnosis/dex-contracts/issues/3"},"comments":{"href":"https://api.github.com/repos/gnosis/dex-contracts/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/dex-contracts/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/dex-contracts/statuses/e51be791c9ef37acfb44ff9b4e24cef1db84ac12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fleupold"}}