{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity-signer/pulls/comments/237493723","pull_request_review_id":179802587,"id":237493723,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ5MzcyMw==","diff_hunk":"@@ -85,8 +87,13 @@ export class AccountUnlock extends React.Component {\n                   ]\n                 });\n                 this.props.navigation.dispatch(resetAction);\n+                console.log('verifyPinAndNavigate 1')","path":"src/screens/AccountUnlock.js","position":68,"original_position":68,"commit_id":"48b5289b51985196523d2a6a8eb04b0a56fc0196","original_commit_id":"48b5289b51985196523d2a6a8eb04b0a56fc0196","user":{"login":"fckt","id":547167,"node_id":"MDQ6VXNlcjU0NzE2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/547167?v=4","gravatar_id":"","url":"https://api.github.com/users/fckt","html_url":"https://github.com/fckt","followers_url":"https://api.github.com/users/fckt/followers","following_url":"https://api.github.com/users/fckt/following{/other_user}","gists_url":"https://api.github.com/users/fckt/gists{/gist_id}","starred_url":"https://api.github.com/users/fckt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fckt/subscriptions","organizations_url":"https://api.github.com/users/fckt/orgs","repos_url":"https://api.github.com/users/fckt/repos","events_url":"https://api.github.com/users/fckt/events{/privacy}","received_events_url":"https://api.github.com/users/fckt/received_events","type":"User","site_admin":false},"body":"unnecessary `console.log`","created_at":"2018-11-29T13:52:54Z","updated_at":"2018-11-29T13:59:08Z","html_url":"https://github.com/paritytech/parity-signer/pull/195#discussion_r237493723","pull_request_url":"https://api.github.com/repos/paritytech/parity-signer/pulls/195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/comments/237493723"},"html":{"href":"https://github.com/paritytech/parity-signer/pull/195#discussion_r237493723"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity-signer/pulls/195","id":234640833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjQwODMz","html_url":"https://github.com/paritytech/parity-signer/pull/195","diff_url":"https://github.com/paritytech/parity-signer/pull/195.diff","patch_url":"https://github.com/paritytech/parity-signer/pull/195.patch","issue_url":"https://api.github.com/repos/paritytech/parity-signer/issues/195","number":195,"state":"open","locked":false,"title":"[WIP] Add error messages when wrong pin is entered","user":{"login":"Tbaut","id":33178835,"node_id":"MDQ6VXNlcjMzMTc4ODM1","avatar_url":"https://avatars2.githubusercontent.com/u/33178835?v=4","gravatar_id":"","url":"https://api.github.com/users/Tbaut","html_url":"https://github.com/Tbaut","followers_url":"https://api.github.com/users/Tbaut/followers","following_url":"https://api.github.com/users/Tbaut/following{/other_user}","gists_url":"https://api.github.com/users/Tbaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Tbaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tbaut/subscriptions","organizations_url":"https://api.github.com/users/Tbaut/orgs","repos_url":"https://api.github.com/users/Tbaut/repos","events_url":"https://api.github.com/users/Tbaut/events{/privacy}","received_events_url":"https://api.github.com/users/Tbaut/received_events","type":"User","site_admin":false},"body":"- fix https://github.com/paritytech/parity-signer/issues/156\r\n- Did some cleanup for unused components or functions (sometime I just commented it, will remove it if it's ok, along with the console.log)\r\n- added feedback at pin creation when pin is too short or don't match\r\n- added feedback at account unlock\r\n--> Feedback requested for the later, is that ok to do it like this?\r\n- I didn't implement the \"wrong pin\" feedback for `UnlockAccountAndSign` because I'd need to know if for some reason the signing hasn't worked correctly. Have `scannerStore.signData(o.pin);` to return a bool would do the job, but it doesn't seem straightforward. (we can clear that in a chat :) )\r\n","created_at":"2018-11-29T13:38:38Z","updated_at":"2018-11-29T13:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34cd47c0881f2cd06645badc219573ccf816f5f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":954989632,"node_id":"MDU6TGFiZWw5NTQ5ODk2MzI=","url":"https://api.github.com/repos/paritytech/parity-signer/labels/M7-UI","name":"M7-UI","color":"EEF0FB","default":false},{"id":954989587,"node_id":"MDU6TGFiZWw5NTQ5ODk1ODc=","url":"https://api.github.com/repos/paritytech/parity-signer/labels/M7-UX","name":"M7-UX","color":"EEF5FA","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity-signer/pulls/195/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity-signer/pulls/195/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity-signer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity-signer/issues/195/comments","statuses_url":"https://api.github.com/repos/paritytech/parity-signer/statuses/48b5289b51985196523d2a6a8eb04b0a56fc0196","head":{"label":"paritytech:tbaut-error-message-pin","ref":"tbaut-error-message-pin","sha":"48b5289b51985196523d2a6a8eb04b0a56fc0196","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":80412649,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQxMjY0OQ==","name":"parity-signer","full_name":"paritytech/parity-signer","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/parity-signer","description":null,"fork":false,"url":"https://api.github.com/repos/paritytech/parity-signer","forks_url":"https://api.github.com/repos/paritytech/parity-signer/forks","keys_url":"https://api.github.com/repos/paritytech/parity-signer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-signer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-signer/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-signer/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-signer/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-signer/events","assignees_url":"https://api.github.com/repos/paritytech/parity-signer/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-signer/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-signer/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-signer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-signer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-signer/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-signer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-signer/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-signer/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-signer/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-signer/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-signer/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-signer/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-signer/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-signer/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-signer/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-signer/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-signer/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-signer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-signer/merges","archive_url":"https://api.github.com/repos/paritytech/parity-signer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-signer/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-signer/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-signer/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-signer/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-signer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-signer/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-signer/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-signer/deployments","created_at":"2017-01-30T10:41:50Z","updated_at":"2018-11-28T21:51:19Z","pushed_at":"2018-11-29T13:38:38Z","git_url":"git://github.com/paritytech/parity-signer.git","ssh_url":"git@github.com:paritytech/parity-signer.git","clone_url":"https://github.com/paritytech/parity-signer.git","svn_url":"https://github.com/paritytech/parity-signer","homepage":null,"size":3770,"stargazers_count":144,"watchers_count":144,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":44,"watchers":144,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"d8c21f5f0470b0ac4b44caba14295d5853594de0","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":80412649,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQxMjY0OQ==","name":"parity-signer","full_name":"paritytech/parity-signer","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/parity-signer","description":null,"fork":false,"url":"https://api.github.com/repos/paritytech/parity-signer","forks_url":"https://api.github.com/repos/paritytech/parity-signer/forks","keys_url":"https://api.github.com/repos/paritytech/parity-signer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-signer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-signer/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-signer/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-signer/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-signer/events","assignees_url":"https://api.github.com/repos/paritytech/parity-signer/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-signer/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-signer/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-signer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-signer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-signer/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-signer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-signer/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-signer/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-signer/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-signer/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-signer/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-signer/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-signer/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-signer/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-signer/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-signer/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-signer/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-signer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-signer/merges","archive_url":"https://api.github.com/repos/paritytech/parity-signer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-signer/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-signer/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-signer/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-signer/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-signer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-signer/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-signer/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-signer/deployments","created_at":"2017-01-30T10:41:50Z","updated_at":"2018-11-28T21:51:19Z","pushed_at":"2018-11-29T13:38:38Z","git_url":"git://github.com/paritytech/parity-signer.git","ssh_url":"git@github.com:paritytech/parity-signer.git","clone_url":"https://github.com/paritytech/parity-signer.git","svn_url":"https://github.com/paritytech/parity-signer","homepage":null,"size":3770,"stargazers_count":144,"watchers_count":144,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":44,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/195"},"html":{"href":"https://github.com/paritytech/parity-signer/pull/195"},"issue":{"href":"https://api.github.com/repos/paritytech/parity-signer/issues/195"},"comments":{"href":"https://api.github.com/repos/paritytech/parity-signer/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity-signer/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity-signer/statuses/48b5289b51985196523d2a6a8eb04b0a56fc0196"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fckt"}}