{"action":"created","comment":{"url":"https://api.github.com/repos/ridi/php-oauth2/pulls/comments/225810546","pull_request_review_id":165490932,"id":225810546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTgxMDU0Ng==","diff_hunk":"@@ -18,5 +18,10 @@\n     },\n     \"require-dev\": {\n         \"phpunit/phpunit\": \"^7\"\n+    },\n+    \"suggest\": {\n+        \"silex/silex\": \"Required when using `OAuth2ServiceProvider`(compatible with `1.x.x` version)\",\n+        \"symfony/symfony\": \"Required when using `OAuth2ServiceProviderBundle`\",\n+        \"guzzlehttp/guzzle\": \"Required when using `OAuth2ServiceProvider` and `DefaultUserProvider` of Silex & Symfony\"","path":"composer.json","position":44,"original_position":8,"commit_id":"fe0dc50e306e2114f35dfc089aeb2f9053e828aa","original_commit_id":"fe0dc50e306e2114f35dfc089aeb2f9053e828aa","user":{"login":"kyungmi","id":8926395,"node_id":"MDQ6VXNlcjg5MjYzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8926395?v=4","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"body":"`silex/silex`, `symfony/symfony` 패키지는 디스크립션 보강이 되어야 할 것 같아요.\r\n클래스명만 있으면 헷갈리니까 namespace도 함께 적으면 어떨까요?","created_at":"2018-10-17T07:40:46Z","updated_at":"2018-10-17T07:40:47Z","html_url":"https://github.com/ridi/php-oauth2/pull/15#discussion_r225810546","pull_request_url":"https://api.github.com/repos/ridi/php-oauth2/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/comments/225810546"},"html":{"href":"https://github.com/ridi/php-oauth2/pull/15#discussion_r225810546"},"pull_request":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/ridi/php-oauth2/pulls/15","id":222836321,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODM2MzIx","html_url":"https://github.com/ridi/php-oauth2/pull/15","diff_url":"https://github.com/ridi/php-oauth2/pull/15.diff","patch_url":"https://github.com/ridi/php-oauth2/pull/15.patch","issue_url":"https://api.github.com/repos/ridi/php-oauth2/issues/15","number":15,"state":"open","locked":false,"title":"Symfony 4용 OAuth2 Service Provider 추가","user":{"login":"amolorsy","id":8010756,"node_id":"MDQ6VXNlcjgwMTA3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8010756?v=4","gravatar_id":"","url":"https://api.github.com/users/amolorsy","html_url":"https://github.com/amolorsy","followers_url":"https://api.github.com/users/amolorsy/followers","following_url":"https://api.github.com/users/amolorsy/following{/other_user}","gists_url":"https://api.github.com/users/amolorsy/gists{/gist_id}","starred_url":"https://api.github.com/users/amolorsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amolorsy/subscriptions","organizations_url":"https://api.github.com/users/amolorsy/orgs","repos_url":"https://api.github.com/users/amolorsy/repos","events_url":"https://api.github.com/users/amolorsy/events{/privacy}","received_events_url":"https://api.github.com/users/amolorsy/received_events","type":"User","site_admin":false},"body":"# 변경 사항\r\n- Symfony 4용 `OAuth2ServiceProvider`를 추가했습니다.\r\n  - Symfony `Bundle` Installation 방식을 이용합니다.\r\n  - 기본적인 패키지 환경 설정은 Symfony 4에서 권장하는 `yaml`을 이용합니다.\r\n  - Application Controller에서 `@OAuth2` Annotation을 통해, `scopes`, `user_provider`, `exception_handler`를 Custom 지정할 수 있습니다.\r\n- Silex Provider와 Symfony Provider 디렉토리 간 `composer.json` 분리\r\n  - `silex/silex:^1.3` 버전이 `symfony/symfony:^4.0`를 지원하지 않아서 프로젝트 root의 `composer.json`에서 양쪽 프레임워크의 의존성을 같이 위치시키기가 어려워, `lib/Silex`와 `lib/Symfony` 내 composer.json을 각자 두었습니다.\r\n  - 이후에 Silex Provider와 Symfony Provider를 아예 repo 차원에서 분리해보는 것도 고려해볼만 한 것 같습니다. \r\n- Symfony 4 대응을 위해, `.travis.yml`의 php 버전 Upgrade\r\n- 테스트 코드 작성(`OAuth2MiddlewareTest`)\r\n\r\n# 특징\r\n- Silex용 Service Provider와 상당히 유사하게 구현하였기 때문에, 사용 면에서 흐름은 유사합니다.\r\n- Exception Handler는 `Interface`만 추가하였고, 구현체는 추가하지 않았습니다.\r\n  - Exception Handler는 주로 예외를 핸들링하고 적절한 `Response`를 반환하는 데 쓰이는데, 이 `Response`의 포맷이 사용처마다 다를 것 같아서 별도로 한정하지 않는 게 좋을 것 같다는 판단이 들었습니다.\r\n\r\n# 사용 방법\r\n자세한 사용 방법은 [README.md](https://github.com/ridi/php-oauth2/blob/symfony-provider/README.md#usage-with-symfony-provider)를 참고해주세요.\r\n","created_at":"2018-10-15T09:21:55Z","updated_at":"2018-10-17T07:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de666740811afc51da9397539be4ab0ab4b7e5a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ryanpark91","id":10189871,"node_id":"MDQ6VXNlcjEwMTg5ODcx","avatar_url":"https://avatars1.githubusercontent.com/u/10189871?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanpark91","html_url":"https://github.com/ryanpark91","followers_url":"https://api.github.com/users/ryanpark91/followers","following_url":"https://api.github.com/users/ryanpark91/following{/other_user}","gists_url":"https://api.github.com/users/ryanpark91/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpark91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpark91/subscriptions","organizations_url":"https://api.github.com/users/ryanpark91/orgs","repos_url":"https://api.github.com/users/ryanpark91/repos","events_url":"https://api.github.com/users/ryanpark91/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpark91/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ridi/php-oauth2/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ridi/php-oauth2/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ridi/php-oauth2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ridi/php-oauth2/issues/15/comments","statuses_url":"https://api.github.com/repos/ridi/php-oauth2/statuses/fe0dc50e306e2114f35dfc089aeb2f9053e828aa","head":{"label":"ridi:symfony-provider","ref":"symfony-provider","sha":"fe0dc50e306e2114f35dfc089aeb2f9053e828aa","user":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"repo":{"id":125811887,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4MTE4ODc=","name":"php-oauth2","full_name":"ridi/php-oauth2","private":false,"owner":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ridi/php-oauth2","description":null,"fork":false,"url":"https://api.github.com/repos/ridi/php-oauth2","forks_url":"https://api.github.com/repos/ridi/php-oauth2/forks","keys_url":"https://api.github.com/repos/ridi/php-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ridi/php-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ridi/php-oauth2/teams","hooks_url":"https://api.github.com/repos/ridi/php-oauth2/hooks","issue_events_url":"https://api.github.com/repos/ridi/php-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/ridi/php-oauth2/events","assignees_url":"https://api.github.com/repos/ridi/php-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/ridi/php-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/ridi/php-oauth2/tags","blobs_url":"https://api.github.com/repos/ridi/php-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ridi/php-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ridi/php-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ridi/php-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ridi/php-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/ridi/php-oauth2/languages","stargazers_url":"https://api.github.com/repos/ridi/php-oauth2/stargazers","contributors_url":"https://api.github.com/repos/ridi/php-oauth2/contributors","subscribers_url":"https://api.github.com/repos/ridi/php-oauth2/subscribers","subscription_url":"https://api.github.com/repos/ridi/php-oauth2/subscription","commits_url":"https://api.github.com/repos/ridi/php-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ridi/php-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ridi/php-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ridi/php-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ridi/php-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/ridi/php-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ridi/php-oauth2/merges","archive_url":"https://api.github.com/repos/ridi/php-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ridi/php-oauth2/downloads","issues_url":"https://api.github.com/repos/ridi/php-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/ridi/php-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/ridi/php-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/ridi/php-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ridi/php-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/ridi/php-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/ridi/php-oauth2/deployments","created_at":"2018-03-19T06:31:58Z","updated_at":"2018-10-05T10:57:41Z","pushed_at":"2018-10-17T07:30:43Z","git_url":"git://github.com/ridi/php-oauth2.git","ssh_url":"git@github.com:ridi/php-oauth2.git","clone_url":"https://github.com/ridi/php-oauth2.git","svn_url":"https://github.com/ridi/php-oauth2","homepage":null,"size":150,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"ridi:master","ref":"master","sha":"c11f9ef3c3561f16ec3827519a0a4d17ebf198e8","user":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"repo":{"id":125811887,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4MTE4ODc=","name":"php-oauth2","full_name":"ridi/php-oauth2","private":false,"owner":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ridi/php-oauth2","description":null,"fork":false,"url":"https://api.github.com/repos/ridi/php-oauth2","forks_url":"https://api.github.com/repos/ridi/php-oauth2/forks","keys_url":"https://api.github.com/repos/ridi/php-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ridi/php-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ridi/php-oauth2/teams","hooks_url":"https://api.github.com/repos/ridi/php-oauth2/hooks","issue_events_url":"https://api.github.com/repos/ridi/php-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/ridi/php-oauth2/events","assignees_url":"https://api.github.com/repos/ridi/php-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/ridi/php-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/ridi/php-oauth2/tags","blobs_url":"https://api.github.com/repos/ridi/php-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ridi/php-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ridi/php-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ridi/php-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ridi/php-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/ridi/php-oauth2/languages","stargazers_url":"https://api.github.com/repos/ridi/php-oauth2/stargazers","contributors_url":"https://api.github.com/repos/ridi/php-oauth2/contributors","subscribers_url":"https://api.github.com/repos/ridi/php-oauth2/subscribers","subscription_url":"https://api.github.com/repos/ridi/php-oauth2/subscription","commits_url":"https://api.github.com/repos/ridi/php-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ridi/php-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ridi/php-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ridi/php-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ridi/php-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/ridi/php-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ridi/php-oauth2/merges","archive_url":"https://api.github.com/repos/ridi/php-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ridi/php-oauth2/downloads","issues_url":"https://api.github.com/repos/ridi/php-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/ridi/php-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/ridi/php-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/ridi/php-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ridi/php-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/ridi/php-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/ridi/php-oauth2/deployments","created_at":"2018-03-19T06:31:58Z","updated_at":"2018-10-05T10:57:41Z","pushed_at":"2018-10-17T07:30:43Z","git_url":"git://github.com/ridi/php-oauth2.git","ssh_url":"git@github.com:ridi/php-oauth2.git","clone_url":"https://github.com/ridi/php-oauth2.git","svn_url":"https://github.com/ridi/php-oauth2","homepage":null,"size":150,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/15"},"html":{"href":"https://github.com/ridi/php-oauth2/pull/15"},"issue":{"href":"https://api.github.com/repos/ridi/php-oauth2/issues/15"},"comments":{"href":"https://api.github.com/repos/ridi/php-oauth2/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ridi/php-oauth2/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ridi/php-oauth2/statuses/fe0dc50e306e2114f35dfc089aeb2f9053e828aa"}},"author_association":"NONE"}}
{"actor":{"display_login":"kyungmi"}}