{"action":"closed","issue":{"url":"https://api.github.com/repos/robotology/yarp/issues/1559","repository_url":"https://api.github.com/repos/robotology/yarp","labels_url":"https://api.github.com/repos/robotology/yarp/issues/1559/labels{/name}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1559/comments","events_url":"https://api.github.com/repos/robotology/yarp/issues/1559/events","html_url":"https://github.com/robotology/yarp/issues/1559","id":299666386,"number":1559,"title":"Make YARP_math mandatory","user":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"labels":[{"id":90673779,"url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Library%20-%20YARP_math","name":"Component: Library - YARP_math","color":"207de5","default":false},{"id":150031843,"url":"https://api.github.com/repos/robotology/yarp/labels/Type:%20Discussion","name":"Type: Discussion","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"assignees":[{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-02-23T10:31:12Z","updated_at":"2018-05-24T09:29:22Z","closed_at":"2018-05-24T09:29:22Z","author_association":"MEMBER","body":"Once upon a time, YARP_math depended on GSL that is GPL, therefore building YARP_math was optional.\r\n\r\nThis dependency is now replaced by Eigen and we no longer have issues with the licenses, therefore the only reason for keeping the math library optional is that we don't want to add mandatory dependencies on YARP\r\n\r\nHaving YARP_math optional has some weird effects. For example in YARP_dev some parts are optional due to this limitation, yarpmanager and some other parts of YARP behave in a different way if the library is not built.\r\n\r\nAll our instructions, suggest to enable the `CREATE_LIB_MATH` flag when building YARP and we actually do it in all our computers.\r\n\r\nI suggest we should stop pretending that we depend only on ACE, and make Eigen a mandatory dependency for building YARP. Eventually it is very simple to include it in the extern folder, since it is a header only library.\r\n\r\n\r\nComments?\r\n@lornat75 @traversaro @pattacini @vtikha @randaz81 \r\n\r\n"}}
{"actor":{"display_login":"drdanz"}}