{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/208974872","pull_request_review_id":144897203,"id":208974872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODk3NDg3Mg==","diff_hunk":"@@ -195,7 +195,7 @@ public async Task<PartialValidationResult> ValidateAsync(Block block, ChainedHea\n                 Succeeded = validationContext.Error == null\n             };\n \n-            this.logger.LogTrace(\"(-):{0}={1}\", nameof(partialValidationResult.Succeeded), partialValidationResult.Succeeded);\n+            this.logger.LogTrace(\"(-):{0}\", partialValidationResult, partialValidationResult);","path":"src/Stratis.Bitcoin/Consensus/Validators/BlockValidator.cs","position":null,"original_position":5,"commit_id":"3fa1eb5f22998a18dea69de974c8b35182f415b8","original_commit_id":"3fa1eb5f22998a18dea69de974c8b35182f415b8","user":{"login":"Aprogiena","id":30052221,"node_id":"MDQ6VXNlcjMwMDUyMjIx","avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"body":"just one please","created_at":"2018-08-09T15:28:30Z","updated_at":"2018-08-09T15:28:30Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870#discussion_r208974872","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/208974872"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870#discussion_r208974872"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870","id":206739031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzM5MDMx","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1870","number":1870,"state":"open","locked":false,"title":"[Activation] Implement BlockMined","user":{"login":"fassadlr","id":4281271,"node_id":"MDQ6VXNlcjQyODEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"body":"Fixes #1807.\r\n\r\n@Aprogiena / @noescape00  this is sort of a draft PR. Can you review the logic implemented in `BlockMined` and `ValidateSynchronously` thus far and let me know if there any changes needed in the method? Don't worry about the unit test for now.\r\n\r\nThanks!","created_at":"2018-08-07T15:30:32Z","updated_at":"2018-08-09T15:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb4cf27565c93558bd50e453b9c17d6d27a783a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1012493668,"node_id":"MDU6TGFiZWwxMDEyNDkzNjY4","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/Activation","name":"Activation","color":"51c61f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1870/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3fa1eb5f22998a18dea69de974c8b35182f415b8","head":{"label":"fassadlr:implement-blockmined","ref":"implement-blockmined","sha":"3fa1eb5f22998a18dea69de974c8b35182f415b8","user":{"login":"fassadlr","id":4281271,"node_id":"MDQ6VXNlcjQyODEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"repo":{"id":102562819,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NjI4MTk=","name":"StratisBitcoinFullNode","full_name":"fassadlr/StratisBitcoinFullNode","owner":{"login":"fassadlr","id":4281271,"node_id":"MDQ6VXNlcjQyODEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fassadlr/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/deployments","created_at":"2017-09-06T04:31:20Z","updated_at":"2018-08-09T09:40:30Z","pushed_at":"2018-08-09T15:25:38Z","git_url":"git://github.com/fassadlr/StratisBitcoinFullNode.git","ssh_url":"git@github.com:fassadlr/StratisBitcoinFullNode.git","clone_url":"https://github.com/fassadlr/StratisBitcoinFullNode.git","svn_url":"https://github.com/fassadlr/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":31546,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:core-way-activation","ref":"core-way-activation","sha":"16f0e861705b11564c146e8c14815e7992983c4a","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-09T02:29:37Z","pushed_at":"2018-08-09T15:25:40Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":33017,"stargazers_count":529,"watchers_count":529,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":153,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1870"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1870"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1870/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1870/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3fa1eb5f22998a18dea69de974c8b35182f415b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aprogiena"}}