{"action":"created","comment":{"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments/194077289","pull_request_review_id":127177690,"id":194077289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA3NzI4OQ==","diff_hunk":"@@ -0,0 +1,168 @@\n+/**\n+ * Payments Converter\n+ * Data Converter for Payments Request\\Responses between PagoPa and BackendAPP types\n+ */\n+import { Either, left, right } from \"fp-ts/lib/Either\";\n+import { ValidationError } from \"io-ts\";\n+import {\n+  codificaInfrastrutturaPSPEnum,\n+  IcdInfoWispInput,\n+  InodoAttivaRPTInput,\n+  InodoAttivaRPTOutput,\n+  InodoVerificaRPTInput,\n+  InodoVerificaRPTOutput\n+} from \"italia-pagopa-api/dist/wsdl-lib/PagamentiTelematiciPspNodoservice/PPTPort\";\n+import { PagoPaConfig } from \"../Configuration\";\n+import { PaymentsActivationRequest } from \"../types/controllers/PaymentsActivationRequest\";\n+import { PaymentsActivationResponse } from \"../types/controllers/PaymentsActivationResponse\";\n+import { PaymentsCheckRequest } from \"../types/controllers/PaymentsCheckRequest\";\n+import { PaymentsCheckResponse } from \"../types/controllers/PaymentsCheckResponse\";\n+import { PaymentsStatusUpdateRequest } from \"../types/controllers/PaymentsStatusUpdateRequest\";\n+import { CodiceContestoPagamento } from \"../types/PagoPaTypes\";\n+\n+// Convert PaymentsCheckRequest (controller) to PaymentsCheckRequestPagoPa (PagoPa API)","path":"src/utils/PaymentsConverter.ts","position":23,"original_position":23,"commit_id":"fdfc9da554928e2d866f9fae659a4c134ff87d75","original_commit_id":"fdfc9da554928e2d866f9fae659a4c134ff87d75","user":{"login":"cloudify","id":48206,"node_id":"MDQ6VXNlcjQ4MjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48206?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify","html_url":"https://github.com/cloudify","followers_url":"https://api.github.com/users/cloudify/followers","following_url":"https://api.github.com/users/cloudify/following{/other_user}","gists_url":"https://api.github.com/users/cloudify/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify/subscriptions","organizations_url":"https://api.github.com/users/cloudify/orgs","repos_url":"https://api.github.com/users/cloudify/repos","events_url":"https://api.github.com/users/cloudify/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify/received_events","type":"User","site_admin":false},"body":"general comment: methods should be commented with a jsdoc block comment","created_at":"2018-06-08T14:34:58Z","updated_at":"2018-06-08T14:41:18Z","html_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37#discussion_r194077289","pull_request_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments/194077289"},"html":{"href":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37#discussion_r194077289"},"pull_request":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37","id":193237973,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjM3OTcz","html_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37","diff_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37.diff","patch_url":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37.patch","issue_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/37","number":37,"state":"open","locked":false,"title":"[#156913899] WIP skeleton","user":{"login":"LsKoder","id":35400947,"node_id":"MDQ6VXNlcjM1NDAwOTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/35400947?v=4","gravatar_id":"","url":"https://api.github.com/users/LsKoder","html_url":"https://github.com/LsKoder","followers_url":"https://api.github.com/users/LsKoder/followers","following_url":"https://api.github.com/users/LsKoder/following{/other_user}","gists_url":"https://api.github.com/users/LsKoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LsKoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LsKoder/subscriptions","organizations_url":"https://api.github.com/users/LsKoder/orgs","repos_url":"https://api.github.com/users/LsKoder/repos","events_url":"https://api.github.com/users/LsKoder/events{/privacy}","received_events_url":"https://api.github.com/users/LsKoder/received_events","type":"User","site_admin":false},"body":"Main PR Contents:\r\n- ProxyPagoPa Server Skeleton\r\n- Services and data structures exposed via RESTful\r\n- Data Converters for PagoPa structures\r\n- Services for PagoPa SOAP communications\r\n\r\nWIP points:\r\n- Integration Tests\r\n- RESTful controller (cdInfoWisp) for Backend APP (Data persistence + polling)\r\n- SOAP endpoint (cdInfoWisp) for PagoPa","created_at":"2018-06-07T08:16:17Z","updated_at":"2018-06-08T14:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e983d9534754de3019c43c98ca372a7761e198f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alessiosaltarin","id":38555210,"node_id":"MDQ6VXNlcjM4NTU1MjEw","avatar_url":"https://avatars2.githubusercontent.com/u/38555210?v=4","gravatar_id":"","url":"https://api.github.com/users/alessiosaltarin","html_url":"https://github.com/alessiosaltarin","followers_url":"https://api.github.com/users/alessiosaltarin/followers","following_url":"https://api.github.com/users/alessiosaltarin/following{/other_user}","gists_url":"https://api.github.com/users/alessiosaltarin/gists{/gist_id}","starred_url":"https://api.github.com/users/alessiosaltarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessiosaltarin/subscriptions","organizations_url":"https://api.github.com/users/alessiosaltarin/orgs","repos_url":"https://api.github.com/users/alessiosaltarin/repos","events_url":"https://api.github.com/users/alessiosaltarin/events{/privacy}","received_events_url":"https://api.github.com/users/alessiosaltarin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37/commits","review_comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37/comments","review_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/37/comments","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/fdfc9da554928e2d866f9fae659a4c134ff87d75","head":{"label":"teamdigitale:156913899-skeleton","ref":"156913899-skeleton","sha":"fdfc9da554928e2d866f9fae659a4c134ff87d75","user":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":127117664,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxMTc2NjQ=","name":"italia-pagopa-proxy","full_name":"teamdigitale/italia-pagopa-proxy","owner":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-pagopa-proxy","description":"A proxy for interacting with pagoPA backend","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy","forks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/deployments","created_at":"2018-03-28T09:35:14Z","updated_at":"2018-06-05T19:06:16Z","pushed_at":"2018-06-08T14:11:59Z","git_url":"git://github.com/teamdigitale/italia-pagopa-proxy.git","ssh_url":"git@github.com:teamdigitale/italia-pagopa-proxy.git","clone_url":"https://github.com/teamdigitale/italia-pagopa-proxy.git","svn_url":"https://github.com/teamdigitale/italia-pagopa-proxy","homepage":null,"size":750,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"teamdigitale:master","ref":"master","sha":"3fe899200eb2c19387631fe4449ac6e5e9084156","user":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":127117664,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxMTc2NjQ=","name":"italia-pagopa-proxy","full_name":"teamdigitale/italia-pagopa-proxy","owner":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-pagopa-proxy","description":"A proxy for interacting with pagoPA backend","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy","forks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/deployments","created_at":"2018-03-28T09:35:14Z","updated_at":"2018-06-05T19:06:16Z","pushed_at":"2018-06-08T14:11:59Z","git_url":"git://github.com/teamdigitale/italia-pagopa-proxy.git","ssh_url":"git@github.com:teamdigitale/italia-pagopa-proxy.git","clone_url":"https://github.com/teamdigitale/italia-pagopa-proxy.git","svn_url":"https://github.com/teamdigitale/italia-pagopa-proxy","homepage":null,"size":750,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37"},"html":{"href":"https://github.com/teamdigitale/italia-pagopa-proxy/pull/37"},"issue":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/37"},"comments":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/teamdigitale/italia-pagopa-proxy/statuses/fdfc9da554928e2d866f9fae659a4c134ff87d75"}},"author_association":"NONE"}}
{"actor":{"display_login":"cloudify"}}