{"action":"created","issue":{"url":"https://api.github.com/repos/betaflight/betaflight/issues/5642","repository_url":"https://api.github.com/repos/betaflight/betaflight","labels_url":"https://api.github.com/repos/betaflight/betaflight/issues/5642/labels{/name}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/5642/comments","events_url":"https://api.github.com/repos/betaflight/betaflight/issues/5642/events","html_url":"https://github.com/betaflight/betaflight/issues/5642","id":312158512,"number":5642,"title":"Parameter groups not resetting properly when updating","user":{"login":"mikeller","id":4742747,"avatar_url":"https://avatars1.githubusercontent.com/u/4742747?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"labels":[{"id":221798115,"url":"https://api.github.com/repos/betaflight/betaflight/labels/BUG","name":"BUG","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/betaflight/betaflight/milestones/7","html_url":"https://github.com/betaflight/betaflight/milestone/7","labels_url":"https://api.github.com/repos/betaflight/betaflight/milestones/7/labels","id":2278188,"number":7,"title":"Betaflight v3.4","description":"","creator":{"login":"blckmn","id":6168871,"avatar_url":"https://avatars2.githubusercontent.com/u/6168871?v=4","gravatar_id":"","url":"https://api.github.com/users/blckmn","html_url":"https://github.com/blckmn","followers_url":"https://api.github.com/users/blckmn/followers","following_url":"https://api.github.com/users/blckmn/following{/other_user}","gists_url":"https://api.github.com/users/blckmn/gists{/gist_id}","starred_url":"https://api.github.com/users/blckmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blckmn/subscriptions","organizations_url":"https://api.github.com/users/blckmn/orgs","repos_url":"https://api.github.com/users/blckmn/repos","events_url":"https://api.github.com/users/blckmn/events{/privacy}","received_events_url":"https://api.github.com/users/blckmn/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":122,"state":"open","created_at":"2017-01-25T19:22:55Z","updated_at":"2018-04-07T20:57:50Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-04-07T01:11:32Z","updated_at":"2018-04-07T21:26:06Z","closed_at":null,"author_association":"OWNER","body":"Steps to reproduce:\r\n- build SPRACINGF3 target from 31639e4a4; install with 'full chip erase';\r\n- use `diff all` to get clean diff, save to file;\r\n- build SPRACINGF3 target from 9a7533f57; install without 'full chip erase';\r\n- use `diff all` to get clean diff, save to file;\r\n- compare the two files.\r\n\r\nExpected result: The files are identical.\r\n\r\nResult: See diff listing below.\r\n\r\nHypothesis: The actual length of parameter groups is not properly persisted / taken into account when reading them, and the length of the parameter group that is stored in the firmware (and may be larger than what it was when the parameter group was stored with an older version of the firmware) is used, causing all following parameter groups to be read with an offset.\r\n\r\n\r\n```\r\n$ diff -u BTFL_cli_20180407_130201.txt BTFL_cli_20180407_130435.txt\r\n--- BTFL_cli_20180407_130201.txt\t2018-04-07 13:02:18.696539717 +1200\r\n+++ BTFL_cli_20180407_130435.txt\t2018-04-07 13:04:43.187484610 +1200\r\n@@ -1,5 +1,5 @@\r\n diff all\r\n-# Betaflight / SPRACINGF3 (SRF3) 3.4.0 Apr  7 2018 / 12:59:00 (31639e4a4) MSP API: 1.39\r\n+# Betaflight / SPRACINGF3 (SRF3) 3.4.0 Apr  7 2018 / 13:02:32 (9a7533f57) MSP API: 1.39\r\n defaults nosave\r\n \r\n feature -TRANSPONDER\r\n@@ -12,16 +12,76 @@\r\n profile 0\r\n rateprofile 0\r\n \r\n+set throttle_limit_type = PROSHOT1000\r\n+set throttle_limit_percent = 0\r\n rateprofile 1\r\n \r\n+set thr_mid = 0\r\n+set thr_expo = 100\r\n+set rates_type = DEFAULT\r\n+set pitch_rc_rate = 0\r\n+set yaw_rc_rate = 0\r\n+set pitch_expo = 70\r\n+set yaw_expo = 70\r\n+set pitch_srate = 10\r\n+set yaw_srate = 0\r\n+set tpa_rate = 114\r\n+set tpa_breakpoint = 50\r\n rateprofile 2\r\n \r\n+set thr_mid = 100\r\n+set thr_expo = 100\r\n+set roll_rc_rate = 0\r\n+set pitch_rc_rate = 0\r\n+set yaw_rc_rate = 70\r\n+set roll_expo = 70\r\n+set pitch_expo = 70\r\n+set yaw_expo = 10\r\n+set roll_srate = 0\r\n+set pitch_srate = 114\r\n+set yaw_srate = 6\r\n+set tpa_rate = 50\r\n+set tpa_breakpoint = 25600\r\n+set throttle_limit_type = ALWAYS\r\n rateprofile 3\r\n \r\n+set thr_mid = 0\r\n+set roll_rc_rate = 70\r\n+set pitch_rc_rate = 70\r\n+set yaw_rc_rate = 70\r\n+set roll_expo = 10\r\n+set yaw_expo = 114\r\n+set roll_srate = 6\r\n+set pitch_srate = 50\r\n+set yaw_srate = 0\r\n+set tpa_rate = 0\r\n+set tpa_breakpoint = 25700\r\n+set throttle_limit_percent = 0\r\n rateprofile 4\r\n \r\n+set thr_mid = 0\r\n+set thr_expo = 70\r\n+set rates_type = ICM20608G\r\n+set roll_rc_rate = 70\r\n+set pitch_rc_rate = 10\r\n+set yaw_rc_rate = 0\r\n+set roll_expo = 114\r\n+set pitch_expo = 6\r\n+set yaw_expo = 50\r\n+set roll_srate = 0\r\n+set pitch_srate = 0\r\n+set yaw_srate = 100\r\n+set tpa_rate = 100\r\n+set tpa_breakpoint = 0\r\n+set throttle_limit_percent = 70\r\n rateprofile 5\r\n \r\n+set thr_mid = 70\r\n+set thr_expo = 70\r\n+set rates_type = I2C\r\n+set roll_rc_rate = 0\r\n+set pitch_rc_rate = 114\r\n+set yaw_rc_rate = 6\r\n rateprofile 0\r\n save\r\n # \r\n\\ No newline at end of file\r\n```"},"comment":{"url":"https://api.github.com/repos/betaflight/betaflight/issues/comments/379500381","html_url":"https://github.com/betaflight/betaflight/issues/5642#issuecomment-379500381","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/5642","id":379500381,"user":{"login":"etracer65","id":17088539,"avatar_url":"https://avatars1.githubusercontent.com/u/17088539?v=4","gravatar_id":"","url":"https://api.github.com/users/etracer65","html_url":"https://github.com/etracer65","followers_url":"https://api.github.com/users/etracer65/followers","following_url":"https://api.github.com/users/etracer65/following{/other_user}","gists_url":"https://api.github.com/users/etracer65/gists{/gist_id}","starred_url":"https://api.github.com/users/etracer65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etracer65/subscriptions","organizations_url":"https://api.github.com/users/etracer65/orgs","repos_url":"https://api.github.com/users/etracer65/repos","events_url":"https://api.github.com/users/etracer65/events{/privacy}","received_events_url":"https://api.github.com/users/etracer65/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T21:26:06Z","updated_at":"2018-04-07T21:26:06Z","author_association":"MEMBER","body":"Well maybe this is a special case.  For the later commit the extra parameters were added to settings but no change to the actual PG was made since the elements already existed.  Maybe this is a case where we need to update the PG version even though it didn't actually change.  But not 100% that would have prevented this issue."}}
{"actor":{"display_login":"etracer65"}}