{"action":"opened","number":402,"pull_request":{"url":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402","id":172556671,"html_url":"https://github.com/ietf-wg-acme/acme/pull/402","diff_url":"https://github.com/ietf-wg-acme/acme/pull/402.diff","patch_url":"https://github.com/ietf-wg-acme/acme/pull/402.patch","issue_url":"https://api.github.com/repos/ietf-wg-acme/acme/issues/402","number":402,"state":"open","locked":false,"title":"Add optional \"wildcard\" field to authorizations.","user":{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false},"body":"`NewOrder` and `NewAuthz` pre-authorization requests are allowed\r\nto send DNS type identifiers with a value that contains a wildcard\r\nprefix ('*') as the leftmost label.\r\n\r\nThe authorization object created for the wildcard identifiers in the\r\nrequests are **not** allowed to carry the wildcard prefix in the\r\nauthorization identifier per spec language:\r\n> An authorization returned by the server for a wildcard domain name \r\n> identifier MUST NOT include the asterisk and full stop (\"\\*.\") prefix in the\r\n> authorization identifier value\r\n\r\nThis is sensible because the authorization is not for the logical \r\nwildcard but for the specific base domain.\r\n\r\nThis leaves an ambiguous situation for client developers/users. Imagine\r\na situation where a user requests a new order with the following\r\nrequest body:\r\n```\r\n{\r\n  \"identifiers\": [\r\n    { \"type\": \"dns\", \"value\": \"example.com\" },\r\n    { \"type\": \"dns\", \"value\": \"*.example.com\" }\r\n  ]\r\n}\r\n```\r\nIt's possible two authorizations will be created for this case, but both\r\nwill contain the identifier `{ \"type\":\"dns\", \"value\": \"example.com\"}`.\r\nThis can be confusing to users! (e.g.  shred/acme4j#53)\r\n\r\nIf one of the authorizations fails a challenge validation operation the\r\nclient can't know whether it was the \"example.com\" validation, or the\r\n\"*.example.com\" validation that failed and won't be able to prompt the\r\nuser to retry with the failed domain removed. Generally speaking it\r\nmakes presenting accurate error information difficult without\r\nover-fitting Let's Encrypt's particular Wildcard issuance policies.\r\n(E.g. see discussion in https://github.com/certbot/certbot/pull/5620#issuecomment-369111947 and \r\nhttps://github.com/certbot/certbot/issues/5613#issuecomment-368097551)\r\n\r\nThis commit introduces an optional boolean authorization field that can\r\nbe used to indicate the authorization's identifier should be considered\r\nthe base domain of a wildcard identifier that was requested.\r\n\r\n**Note to reviewers: This builds on top of #401 and only 050474a is new\r\ncontent.**","created_at":"2018-03-02T17:13:29Z","updated_at":"2018-03-02T17:13:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false},"assignees":[{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402/commits","review_comments_url":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402/comments","review_comment_url":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ietf-wg-acme/acme/issues/402/comments","statuses_url":"https://api.github.com/repos/ietf-wg-acme/acme/statuses/050474a51a17e8eb110f1a9efce5f8719cf2a121","head":{"label":"cpu:cpu-authz-wildcard-field","ref":"cpu-authz-wildcard-field","sha":"050474a51a17e8eb110f1a9efce5f8719cf2a121","user":{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false},"repo":{"id":63190577,"name":"acme","full_name":"cpu/acme","owner":{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpu/acme","description":null,"fork":true,"url":"https://api.github.com/repos/cpu/acme","forks_url":"https://api.github.com/repos/cpu/acme/forks","keys_url":"https://api.github.com/repos/cpu/acme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpu/acme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpu/acme/teams","hooks_url":"https://api.github.com/repos/cpu/acme/hooks","issue_events_url":"https://api.github.com/repos/cpu/acme/issues/events{/number}","events_url":"https://api.github.com/repos/cpu/acme/events","assignees_url":"https://api.github.com/repos/cpu/acme/assignees{/user}","branches_url":"https://api.github.com/repos/cpu/acme/branches{/branch}","tags_url":"https://api.github.com/repos/cpu/acme/tags","blobs_url":"https://api.github.com/repos/cpu/acme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpu/acme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpu/acme/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpu/acme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpu/acme/statuses/{sha}","languages_url":"https://api.github.com/repos/cpu/acme/languages","stargazers_url":"https://api.github.com/repos/cpu/acme/stargazers","contributors_url":"https://api.github.com/repos/cpu/acme/contributors","subscribers_url":"https://api.github.com/repos/cpu/acme/subscribers","subscription_url":"https://api.github.com/repos/cpu/acme/subscription","commits_url":"https://api.github.com/repos/cpu/acme/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpu/acme/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpu/acme/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpu/acme/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpu/acme/contents/{+path}","compare_url":"https://api.github.com/repos/cpu/acme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpu/acme/merges","archive_url":"https://api.github.com/repos/cpu/acme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpu/acme/downloads","issues_url":"https://api.github.com/repos/cpu/acme/issues{/number}","pulls_url":"https://api.github.com/repos/cpu/acme/pulls{/number}","milestones_url":"https://api.github.com/repos/cpu/acme/milestones{/number}","notifications_url":"https://api.github.com/repos/cpu/acme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpu/acme/labels{/name}","releases_url":"https://api.github.com/repos/cpu/acme/releases{/id}","deployments_url":"https://api.github.com/repos/cpu/acme/deployments","created_at":"2016-07-12T20:34:28Z","updated_at":"2016-07-12T20:34:29Z","pushed_at":"2018-03-02T17:07:31Z","git_url":"git://github.com/cpu/acme.git","ssh_url":"git@github.com:cpu/acme.git","clone_url":"https://github.com/cpu/acme.git","svn_url":"https://github.com/cpu/acme","homepage":null,"size":1305,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ietf-wg-acme:master","ref":"master","sha":"da87fc061570922380f5685174a76edc026d2a5e","user":{"login":"ietf-wg-acme","id":13089532,"avatar_url":"https://avatars0.githubusercontent.com/u/13089532?v=4","gravatar_id":"","url":"https://api.github.com/users/ietf-wg-acme","html_url":"https://github.com/ietf-wg-acme","followers_url":"https://api.github.com/users/ietf-wg-acme/followers","following_url":"https://api.github.com/users/ietf-wg-acme/following{/other_user}","gists_url":"https://api.github.com/users/ietf-wg-acme/gists{/gist_id}","starred_url":"https://api.github.com/users/ietf-wg-acme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ietf-wg-acme/subscriptions","organizations_url":"https://api.github.com/users/ietf-wg-acme/orgs","repos_url":"https://api.github.com/users/ietf-wg-acme/repos","events_url":"https://api.github.com/users/ietf-wg-acme/events{/privacy}","received_events_url":"https://api.github.com/users/ietf-wg-acme/received_events","type":"Organization","site_admin":false},"repo":{"id":38263155,"name":"acme","full_name":"ietf-wg-acme/acme","owner":{"login":"ietf-wg-acme","id":13089532,"avatar_url":"https://avatars0.githubusercontent.com/u/13089532?v=4","gravatar_id":"","url":"https://api.github.com/users/ietf-wg-acme","html_url":"https://github.com/ietf-wg-acme","followers_url":"https://api.github.com/users/ietf-wg-acme/followers","following_url":"https://api.github.com/users/ietf-wg-acme/following{/other_user}","gists_url":"https://api.github.com/users/ietf-wg-acme/gists{/gist_id}","starred_url":"https://api.github.com/users/ietf-wg-acme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ietf-wg-acme/subscriptions","organizations_url":"https://api.github.com/users/ietf-wg-acme/orgs","repos_url":"https://api.github.com/users/ietf-wg-acme/repos","events_url":"https://api.github.com/users/ietf-wg-acme/events{/privacy}","received_events_url":"https://api.github.com/users/ietf-wg-acme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ietf-wg-acme/acme","description":null,"fork":false,"url":"https://api.github.com/repos/ietf-wg-acme/acme","forks_url":"https://api.github.com/repos/ietf-wg-acme/acme/forks","keys_url":"https://api.github.com/repos/ietf-wg-acme/acme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ietf-wg-acme/acme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ietf-wg-acme/acme/teams","hooks_url":"https://api.github.com/repos/ietf-wg-acme/acme/hooks","issue_events_url":"https://api.github.com/repos/ietf-wg-acme/acme/issues/events{/number}","events_url":"https://api.github.com/repos/ietf-wg-acme/acme/events","assignees_url":"https://api.github.com/repos/ietf-wg-acme/acme/assignees{/user}","branches_url":"https://api.github.com/repos/ietf-wg-acme/acme/branches{/branch}","tags_url":"https://api.github.com/repos/ietf-wg-acme/acme/tags","blobs_url":"https://api.github.com/repos/ietf-wg-acme/acme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ietf-wg-acme/acme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ietf-wg-acme/acme/git/refs{/sha}","trees_url":"https://api.github.com/repos/ietf-wg-acme/acme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ietf-wg-acme/acme/statuses/{sha}","languages_url":"https://api.github.com/repos/ietf-wg-acme/acme/languages","stargazers_url":"https://api.github.com/repos/ietf-wg-acme/acme/stargazers","contributors_url":"https://api.github.com/repos/ietf-wg-acme/acme/contributors","subscribers_url":"https://api.github.com/repos/ietf-wg-acme/acme/subscribers","subscription_url":"https://api.github.com/repos/ietf-wg-acme/acme/subscription","commits_url":"https://api.github.com/repos/ietf-wg-acme/acme/commits{/sha}","git_commits_url":"https://api.github.com/repos/ietf-wg-acme/acme/git/commits{/sha}","comments_url":"https://api.github.com/repos/ietf-wg-acme/acme/comments{/number}","issue_comment_url":"https://api.github.com/repos/ietf-wg-acme/acme/issues/comments{/number}","contents_url":"https://api.github.com/repos/ietf-wg-acme/acme/contents/{+path}","compare_url":"https://api.github.com/repos/ietf-wg-acme/acme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ietf-wg-acme/acme/merges","archive_url":"https://api.github.com/repos/ietf-wg-acme/acme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ietf-wg-acme/acme/downloads","issues_url":"https://api.github.com/repos/ietf-wg-acme/acme/issues{/number}","pulls_url":"https://api.github.com/repos/ietf-wg-acme/acme/pulls{/number}","milestones_url":"https://api.github.com/repos/ietf-wg-acme/acme/milestones{/number}","notifications_url":"https://api.github.com/repos/ietf-wg-acme/acme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ietf-wg-acme/acme/labels{/name}","releases_url":"https://api.github.com/repos/ietf-wg-acme/acme/releases{/id}","deployments_url":"https://api.github.com/repos/ietf-wg-acme/acme/deployments","created_at":"2015-06-29T18:18:08Z","updated_at":"2018-03-02T06:40:19Z","pushed_at":"2018-03-02T16:39:32Z","git_url":"git://github.com/ietf-wg-acme/acme.git","ssh_url":"git@github.com:ietf-wg-acme/acme.git","clone_url":"https://github.com/ietf-wg-acme/acme.git","svn_url":"https://github.com/ietf-wg-acme/acme","homepage":null,"size":2625,"stargazers_count":537,"watchers_count":537,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":125,"open_issues":9,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402"},"html":{"href":"https://github.com/ietf-wg-acme/acme/pull/402"},"issue":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/issues/402"},"comments":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/ietf-wg-acme/acme/statuses/050474a51a17e8eb110f1a9efce5f8719cf2a121"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":33,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"cpu"}}