{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/minigo/pulls/comments/183243036","pull_request_review_id":114207266,"id":183243036,"diff_hunk":"@@ -86,7 +93,8 @@ def __init__(self, network, seconds_per_move=5, simulations_per_move=0,\n         self.root = None\n         self.result = 0\n         self.result_string = None\n-        self.resign_threshold = -abs(resign_threshold)\n+        self.resign_threshold = resign_threshold or FLAGS.resign_threshold\n+        self.timed_match = timed_match","path":"strategies.py","position":57,"original_position":41,"commit_id":"61267bef559a177d958f866aa4736eb2957f2b40","original_commit_id":"68b77df58c06c0b4be464ea824539ff788b1805a","user":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"body":"Added an assert to prevent cases where neither time / readout settings are configured.","created_at":"2018-04-22T16:39:31Z","updated_at":"2018-04-22T16:39:32Z","html_url":"https://github.com/tensorflow/minigo/pull/172#discussion_r183243036","pull_request_url":"https://api.github.com/repos/tensorflow/minigo/pulls/172","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/comments/183243036"},"html":{"href":"https://github.com/tensorflow/minigo/pull/172#discussion_r183243036"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/172"}},"in_reply_to_id":183222438},"pull_request":{"url":"https://api.github.com/repos/tensorflow/minigo/pulls/172","id":183242812,"html_url":"https://github.com/tensorflow/minigo/pull/172","diff_url":"https://github.com/tensorflow/minigo/pull/172.diff","patch_url":"https://github.com/tensorflow/minigo/pull/172.patch","issue_url":"https://api.github.com/repos/tensorflow/minigo/issues/172","number":172,"state":"open","locked":false,"title":"Replace num_readouts and resign_threshold with flag versions","user":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-21T21:21:08Z","updated_at":"2018-04-22T16:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded8528c0e39752994634be14ea2b4f69fcdf4b2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kashomon","id":417814,"avatar_url":"https://avatars1.githubusercontent.com/u/417814?v=4","gravatar_id":"","url":"https://api.github.com/users/Kashomon","html_url":"https://github.com/Kashomon","followers_url":"https://api.github.com/users/Kashomon/followers","following_url":"https://api.github.com/users/Kashomon/following{/other_user}","gists_url":"https://api.github.com/users/Kashomon/gists{/gist_id}","starred_url":"https://api.github.com/users/Kashomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kashomon/subscriptions","organizations_url":"https://api.github.com/users/Kashomon/orgs","repos_url":"https://api.github.com/users/Kashomon/repos","events_url":"https://api.github.com/users/Kashomon/events{/privacy}","received_events_url":"https://api.github.com/users/Kashomon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":832833043,"url":"https://api.github.com/repos/tensorflow/minigo/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/minigo/pulls/172/commits","review_comments_url":"https://api.github.com/repos/tensorflow/minigo/pulls/172/comments","review_comment_url":"https://api.github.com/repos/tensorflow/minigo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/minigo/issues/172/comments","statuses_url":"https://api.github.com/repos/tensorflow/minigo/statuses/61267bef559a177d958f866aa4736eb2957f2b40","head":{"label":"brilee:hyperparams","ref":"hyperparams","sha":"61267bef559a177d958f866aa4736eb2957f2b40","user":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"repo":{"id":120157364,"name":"minigo","full_name":"brilee/minigo","owner":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brilee/minigo","description":"An open-source implementation of the AlphaGoZero algorithm","fork":true,"url":"https://api.github.com/repos/brilee/minigo","forks_url":"https://api.github.com/repos/brilee/minigo/forks","keys_url":"https://api.github.com/repos/brilee/minigo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brilee/minigo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brilee/minigo/teams","hooks_url":"https://api.github.com/repos/brilee/minigo/hooks","issue_events_url":"https://api.github.com/repos/brilee/minigo/issues/events{/number}","events_url":"https://api.github.com/repos/brilee/minigo/events","assignees_url":"https://api.github.com/repos/brilee/minigo/assignees{/user}","branches_url":"https://api.github.com/repos/brilee/minigo/branches{/branch}","tags_url":"https://api.github.com/repos/brilee/minigo/tags","blobs_url":"https://api.github.com/repos/brilee/minigo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brilee/minigo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brilee/minigo/git/refs{/sha}","trees_url":"https://api.github.com/repos/brilee/minigo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brilee/minigo/statuses/{sha}","languages_url":"https://api.github.com/repos/brilee/minigo/languages","stargazers_url":"https://api.github.com/repos/brilee/minigo/stargazers","contributors_url":"https://api.github.com/repos/brilee/minigo/contributors","subscribers_url":"https://api.github.com/repos/brilee/minigo/subscribers","subscription_url":"https://api.github.com/repos/brilee/minigo/subscription","commits_url":"https://api.github.com/repos/brilee/minigo/commits{/sha}","git_commits_url":"https://api.github.com/repos/brilee/minigo/git/commits{/sha}","comments_url":"https://api.github.com/repos/brilee/minigo/comments{/number}","issue_comment_url":"https://api.github.com/repos/brilee/minigo/issues/comments{/number}","contents_url":"https://api.github.com/repos/brilee/minigo/contents/{+path}","compare_url":"https://api.github.com/repos/brilee/minigo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brilee/minigo/merges","archive_url":"https://api.github.com/repos/brilee/minigo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brilee/minigo/downloads","issues_url":"https://api.github.com/repos/brilee/minigo/issues{/number}","pulls_url":"https://api.github.com/repos/brilee/minigo/pulls{/number}","milestones_url":"https://api.github.com/repos/brilee/minigo/milestones{/number}","notifications_url":"https://api.github.com/repos/brilee/minigo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brilee/minigo/labels{/name}","releases_url":"https://api.github.com/repos/brilee/minigo/releases{/id}","deployments_url":"https://api.github.com/repos/brilee/minigo/deployments","created_at":"2018-02-04T05:19:56Z","updated_at":"2018-04-21T21:20:09Z","pushed_at":"2018-04-22T16:39:01Z","git_url":"git://github.com/brilee/minigo.git","ssh_url":"git@github.com:brilee/minigo.git","clone_url":"https://github.com/brilee/minigo.git","svn_url":"https://github.com/brilee/minigo","homepage":"","size":732,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"8eb1e60a55120760255b36fd8e9e277af9556e77","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":119455332,"name":"minigo","full_name":"tensorflow/minigo","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/minigo","description":"An open-source implementation of the AlphaGoZero algorithm","fork":false,"url":"https://api.github.com/repos/tensorflow/minigo","forks_url":"https://api.github.com/repos/tensorflow/minigo/forks","keys_url":"https://api.github.com/repos/tensorflow/minigo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/minigo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/minigo/teams","hooks_url":"https://api.github.com/repos/tensorflow/minigo/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/minigo/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/minigo/events","assignees_url":"https://api.github.com/repos/tensorflow/minigo/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/minigo/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/minigo/tags","blobs_url":"https://api.github.com/repos/tensorflow/minigo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/minigo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/minigo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/minigo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/minigo/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/minigo/languages","stargazers_url":"https://api.github.com/repos/tensorflow/minigo/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/minigo/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/minigo/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/minigo/subscription","commits_url":"https://api.github.com/repos/tensorflow/minigo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/minigo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/minigo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/minigo/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/minigo/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/minigo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/minigo/merges","archive_url":"https://api.github.com/repos/tensorflow/minigo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/minigo/downloads","issues_url":"https://api.github.com/repos/tensorflow/minigo/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/minigo/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/minigo/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/minigo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/minigo/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/minigo/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/minigo/deployments","created_at":"2018-01-29T23:29:07Z","updated_at":"2018-04-22T14:57:46Z","pushed_at":"2018-04-22T16:39:02Z","git_url":"git://github.com/tensorflow/minigo.git","ssh_url":"git@github.com:tensorflow/minigo.git","clone_url":"https://github.com/tensorflow/minigo.git","svn_url":"https://github.com/tensorflow/minigo","homepage":"","size":743,"stargazers_count":1966,"watchers_count":1966,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":245,"open_issues":47,"watchers":1966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/172"},"html":{"href":"https://github.com/tensorflow/minigo/pull/172"},"issue":{"href":"https://api.github.com/repos/tensorflow/minigo/issues/172"},"comments":{"href":"https://api.github.com/repos/tensorflow/minigo/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/minigo/statuses/61267bef559a177d958f866aa4736eb2957f2b40"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brilee"}}