{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/230301171","pull_request_review_id":171008280,"id":230301171,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDMwMTE3MQ==","diff_hunk":"@@ -0,0 +1,321 @@\n+//! Visitor for a run-time value with a given layout: Traverse enums, structs and other compound\n+//! types until we arrive at the leaves, with custom handling for primitive types.\n+\n+use rustc::ty::layout::{self, TyLayout};\n+use rustc::ty;\n+use rustc::mir::interpret::{\n+    EvalResult,\n+};\n+\n+use super::{\n+    Machine, EvalContext, MPlaceTy, PlaceTy, OpTy,\n+};\n+\n+// A thing that we can project into, and that has a layout.\n+// This wouldn't have to depend on `Machine` but with the current type inference,\n+// that's just more convenient to work with (avoids repeading all the `Machine` bounds).\n+pub trait Value<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>>: Copy\n+{\n+    // Get this value's layout.","path":"src/librustc_mir/interpret/visitor.rs","position":19,"original_position":19,"commit_id":"d51b3525c77e11f18ce611c1fb76e54d3176528d","original_commit_id":"d51b3525c77e11f18ce611c1fb76e54d3176528d","user":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"upgrade all comments to doc comments","created_at":"2018-11-02T08:38:15Z","updated_at":"2018-11-02T08:48:21Z","html_url":"https://github.com/rust-lang/rust/pull/55549#discussion_r230301171","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/55549","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/230301171"},"html":{"href":"https://github.com/rust-lang/rust/pull/55549#discussion_r230301171"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55549"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/55549","id":227404946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDA0OTQ2","html_url":"https://github.com/rust-lang/rust/pull/55549","diff_url":"https://github.com/rust-lang/rust/pull/55549.diff","patch_url":"https://github.com/rust-lang/rust/pull/55549.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/55549","number":55549,"state":"open","locked":false,"title":"Value visitors for miri","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"body":"Generalize the traversal part of validation to a `ValueVisitor`.\r\n\r\nThis includes https://github.com/rust-lang/rust/pull/55316, [click here](https://github.com/RalfJung/rust/compare/retagging...RalfJung:miri-visitor) for just the new commits.\r\n\r\nThis PR does not change the interface to miri, so I use the opportunity to update miri.","created_at":"2018-10-31T18:55:19Z","updated_at":"2018-11-02T08:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa26290727aaa74a7412d8cd81c19fc85233f01d","assignee":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"assignees":[{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/55549/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/55549/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/55549/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d51b3525c77e11f18ce611c1fb76e54d3176528d","head":{"label":"RalfJung:miri-visitor","ref":"miri-visitor","sha":"d51b3525c77e11f18ce611c1fb76e54d3176528d","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"repo":{"id":81860024,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2MDAyNA==","name":"rust","full_name":"RalfJung/rust","private":false,"owner":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RalfJung/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/RalfJung/rust","forks_url":"https://api.github.com/repos/RalfJung/rust/forks","keys_url":"https://api.github.com/repos/RalfJung/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RalfJung/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RalfJung/rust/teams","hooks_url":"https://api.github.com/repos/RalfJung/rust/hooks","issue_events_url":"https://api.github.com/repos/RalfJung/rust/issues/events{/number}","events_url":"https://api.github.com/repos/RalfJung/rust/events","assignees_url":"https://api.github.com/repos/RalfJung/rust/assignees{/user}","branches_url":"https://api.github.com/repos/RalfJung/rust/branches{/branch}","tags_url":"https://api.github.com/repos/RalfJung/rust/tags","blobs_url":"https://api.github.com/repos/RalfJung/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RalfJung/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RalfJung/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/RalfJung/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RalfJung/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/RalfJung/rust/languages","stargazers_url":"https://api.github.com/repos/RalfJung/rust/stargazers","contributors_url":"https://api.github.com/repos/RalfJung/rust/contributors","subscribers_url":"https://api.github.com/repos/RalfJung/rust/subscribers","subscription_url":"https://api.github.com/repos/RalfJung/rust/subscription","commits_url":"https://api.github.com/repos/RalfJung/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/RalfJung/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/RalfJung/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/RalfJung/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/RalfJung/rust/contents/{+path}","compare_url":"https://api.github.com/repos/RalfJung/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RalfJung/rust/merges","archive_url":"https://api.github.com/repos/RalfJung/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RalfJung/rust/downloads","issues_url":"https://api.github.com/repos/RalfJung/rust/issues{/number}","pulls_url":"https://api.github.com/repos/RalfJung/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/RalfJung/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/RalfJung/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RalfJung/rust/labels{/name}","releases_url":"https://api.github.com/repos/RalfJung/rust/releases{/id}","deployments_url":"https://api.github.com/repos/RalfJung/rust/deployments","created_at":"2017-02-13T18:59:58Z","updated_at":"2018-09-01T09:07:38Z","pushed_at":"2018-11-02T08:36:29Z","git_url":"git://github.com/RalfJung/rust.git","ssh_url":"git@github.com:RalfJung/rust.git","clone_url":"https://github.com/RalfJung/rust.git","svn_url":"https://github.com/RalfJung/rust","homepage":"https://www.rust-lang.org","size":398702,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"de9666f123e800d5fc34210f23127aa6a5d6e4ef","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-11-02T07:04:35Z","pushed_at":"2018-11-02T08:36:40Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":401182,"stargazers_count":31475,"watchers_count":31475,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5263,"mirror_url":null,"archived":false,"open_issues_count":4498,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5263,"open_issues":4498,"watchers":31475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55549"},"html":{"href":"https://github.com/rust-lang/rust/pull/55549"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55549"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55549/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55549/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55549/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d51b3525c77e11f18ce611c1fb76e54d3176528d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"oli-obk"}}