{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/212718410","pull_request_review_id":149415078,"id":212718410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjcxODQxMA==","diff_hunk":"@@ -236,4 +304,10 @@ class GeckoEngineSession(\n         internal const val MOZ_NULL_PRINCIPAL = \"moz-nullprincipal:\"\n         internal const val ABOUT_BLANK = \"about:blank\"\n     }\n+\n+    fun String.isPhone(): Boolean = contains(\"tel:\", true)","path":"components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt","position":98,"original_position":98,"commit_id":"0c199f40bfdbf536e14adbf41e096b6608022066","original_commit_id":"0c199f40bfdbf536e14adbf41e096b6608022066","user":{"login":"jonalmeida","id":1370580,"node_id":"MDQ6VXNlcjEzNzA1ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1370580?v=4","gravatar_id":"","url":"https://api.github.com/users/jonalmeida","html_url":"https://github.com/jonalmeida","followers_url":"https://api.github.com/users/jonalmeida/followers","following_url":"https://api.github.com/users/jonalmeida/following{/other_user}","gists_url":"https://api.github.com/users/jonalmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/jonalmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonalmeida/subscriptions","organizations_url":"https://api.github.com/users/jonalmeida/orgs","repos_url":"https://api.github.com/users/jonalmeida/repos","events_url":"https://api.github.com/users/jonalmeida/events{/privacy}","received_events_url":"https://api.github.com/users/jonalmeida/received_events","type":"User","site_admin":false},"body":"I kept in here so that it wouldn't show up for all Strings outside this class. I don't think it makes sense for all strings to have an `isPhone`. I know extension functions don't add any overhead to the class since they're static methods really, but it seems misleading.\r\n\r\nWhen we have a URI class (see #648) these exts should go there.","created_at":"2018-08-24T18:35:16Z","updated_at":"2018-08-24T18:35:16Z","html_url":"https://github.com/mozilla-mobile/android-components/pull/659#discussion_r212718410","pull_request_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/212718410"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/659#discussion_r212718410"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659"}},"in_reply_to_id":212705518},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659","id":210774441,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzc0NDQx","html_url":"https://github.com/mozilla-mobile/android-components/pull/659","diff_url":"https://github.com/mozilla-mobile/android-components/pull/659.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/659.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/659","number":659,"state":"open","locked":false,"title":"Issue #476: Add long press support as observable","user":{"login":"jonalmeida","id":1370580,"node_id":"MDQ6VXNlcjEzNzA1ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1370580?v=4","gravatar_id":"","url":"https://api.github.com/users/jonalmeida","html_url":"https://github.com/jonalmeida","followers_url":"https://api.github.com/users/jonalmeida/followers","following_url":"https://api.github.com/users/jonalmeida/following{/other_user}","gists_url":"https://api.github.com/users/jonalmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/jonalmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonalmeida/subscriptions","organizations_url":"https://api.github.com/users/jonalmeida/orgs","repos_url":"https://api.github.com/users/jonalmeida/repos","events_url":"https://api.github.com/users/jonalmeida/events{/privacy}","received_events_url":"https://api.github.com/users/jonalmeida/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-24T15:29:26Z","updated_at":"2018-08-24T18:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8543d77f3376658d6ae2c9d224b582910c1f5329","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/659/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/0c199f40bfdbf536e14adbf41e096b6608022066","head":{"label":"jonalmeida:issue-476_long_press","ref":"issue-476_long_press","sha":"0c199f40bfdbf536e14adbf41e096b6608022066","user":{"login":"jonalmeida","id":1370580,"node_id":"MDQ6VXNlcjEzNzA1ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1370580?v=4","gravatar_id":"","url":"https://api.github.com/users/jonalmeida","html_url":"https://github.com/jonalmeida","followers_url":"https://api.github.com/users/jonalmeida/followers","following_url":"https://api.github.com/users/jonalmeida/following{/other_user}","gists_url":"https://api.github.com/users/jonalmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/jonalmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonalmeida/subscriptions","organizations_url":"https://api.github.com/users/jonalmeida/orgs","repos_url":"https://api.github.com/users/jonalmeida/repos","events_url":"https://api.github.com/users/jonalmeida/events{/privacy}","received_events_url":"https://api.github.com/users/jonalmeida/received_events","type":"User","site_admin":false},"repo":{"id":144650995,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NTA5OTU=","name":"android-components","full_name":"jonalmeida/android-components","owner":{"login":"jonalmeida","id":1370580,"node_id":"MDQ6VXNlcjEzNzA1ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1370580?v=4","gravatar_id":"","url":"https://api.github.com/users/jonalmeida","html_url":"https://github.com/jonalmeida","followers_url":"https://api.github.com/users/jonalmeida/followers","following_url":"https://api.github.com/users/jonalmeida/following{/other_user}","gists_url":"https://api.github.com/users/jonalmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/jonalmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonalmeida/subscriptions","organizations_url":"https://api.github.com/users/jonalmeida/orgs","repos_url":"https://api.github.com/users/jonalmeida/repos","events_url":"https://api.github.com/users/jonalmeida/events{/privacy}","received_events_url":"https://api.github.com/users/jonalmeida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonalmeida/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":true,"url":"https://api.github.com/repos/jonalmeida/android-components","forks_url":"https://api.github.com/repos/jonalmeida/android-components/forks","keys_url":"https://api.github.com/repos/jonalmeida/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonalmeida/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonalmeida/android-components/teams","hooks_url":"https://api.github.com/repos/jonalmeida/android-components/hooks","issue_events_url":"https://api.github.com/repos/jonalmeida/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/jonalmeida/android-components/events","assignees_url":"https://api.github.com/repos/jonalmeida/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/jonalmeida/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/jonalmeida/android-components/tags","blobs_url":"https://api.github.com/repos/jonalmeida/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonalmeida/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonalmeida/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonalmeida/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonalmeida/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/jonalmeida/android-components/languages","stargazers_url":"https://api.github.com/repos/jonalmeida/android-components/stargazers","contributors_url":"https://api.github.com/repos/jonalmeida/android-components/contributors","subscribers_url":"https://api.github.com/repos/jonalmeida/android-components/subscribers","subscription_url":"https://api.github.com/repos/jonalmeida/android-components/subscription","commits_url":"https://api.github.com/repos/jonalmeida/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonalmeida/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonalmeida/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonalmeida/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonalmeida/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/jonalmeida/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonalmeida/android-components/merges","archive_url":"https://api.github.com/repos/jonalmeida/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonalmeida/android-components/downloads","issues_url":"https://api.github.com/repos/jonalmeida/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/jonalmeida/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/jonalmeida/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/jonalmeida/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonalmeida/android-components/labels{/name}","releases_url":"https://api.github.com/repos/jonalmeida/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/jonalmeida/android-components/deployments","created_at":"2018-08-14T01:10:54Z","updated_at":"2018-08-14T01:10:58Z","pushed_at":"2018-08-24T15:27:54Z","git_url":"git://github.com/jonalmeida/android-components.git","ssh_url":"git@github.com:jonalmeida/android-components.git","clone_url":"https://github.com/jonalmeida/android-components.git","svn_url":"https://github.com/jonalmeida/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":3544,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"98fe6eb2da12d555e46a624f31221ab4d30978a2","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":126199585,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTk1ODU=","name":"android-components","full_name":"mozilla-mobile/android-components","owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/android-components","forks_url":"https://api.github.com/repos/mozilla-mobile/android-components/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/android-components/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/android-components/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/android-components/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/android-components/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/android-components/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/android-components/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/android-components/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/android-components/deployments","created_at":"2018-03-21T15:24:03Z","updated_at":"2018-08-24T18:35:02Z","pushed_at":"2018-08-24T17:43:26Z","git_url":"git://github.com/mozilla-mobile/android-components.git","ssh_url":"git@github.com:mozilla-mobile/android-components.git","clone_url":"https://github.com/mozilla-mobile/android-components.git","svn_url":"https://github.com/mozilla-mobile/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":3528,"stargazers_count":216,"watchers_count":216,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":48,"open_issues":112,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/659"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/659"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/0c199f40bfdbf536e14adbf41e096b6608022066"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonalmeida"}}