{"action":"created","comment":{"url":"https://api.github.com/repos/openturns/openturns/pulls/comments/231449620","pull_request_review_id":172421015,"id":231449620,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ0OTYyMA==","diff_hunk":"@@ -15,7 +15,7 @@ CXXFLAGS=\"-D_hypot=hypot -D_GLIBCXX_ASSERTIONS\" ${ARCH}-w64-mingw32-cmake \\\n   -DPYTHON_LIBRARY=${MINGW_PREFIX}/lib/libpython${PYMAJMIN}.dll.a \\\n   -DPYTHON_EXECUTABLE=/usr/bin/${ARCH}-w64-mingw32-python${PYMAJMIN}-bin \\\n   -DPYTHON_SITE_PACKAGES=Lib/site-packages \\\n-  -DUSE_TBB=OFF \\\n+  -DUSE_TBB=OFF -DCMAKE_CXX_FLAGS=\"-march=native\" \\","path":".circleci/run_docker_mingw.sh","position":5,"original_position":5,"commit_id":"b1f57f2b32b12f955401a6f8a38a088d5f6f8b6d","original_commit_id":"b1f57f2b32b12f955401a6f8a38a088d5f6f8b6d","user":{"login":"jschueller","id":3832365,"node_id":"MDQ6VXNlcjM4MzIzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3832365?v=4","gravatar_id":"","url":"https://api.github.com/users/jschueller","html_url":"https://github.com/jschueller","followers_url":"https://api.github.com/users/jschueller/followers","following_url":"https://api.github.com/users/jschueller/following{/other_user}","gists_url":"https://api.github.com/users/jschueller/gists{/gist_id}","starred_url":"https://api.github.com/users/jschueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschueller/subscriptions","organizations_url":"https://api.github.com/users/jschueller/orgs","repos_url":"https://api.github.com/users/jschueller/repos","events_url":"https://api.github.com/users/jschueller/events{/privacy}","received_events_url":"https://api.github.com/users/jschueller/received_events","type":"User","site_admin":false},"body":"I 'd rather not to have to use \"march=native\". What happens is that the ci uses mingw in it's 32 bits variant (64 is available too though). It works because the host processor actually is x86_64, so it has sse2. But the client machine could run an i686 processor and this will crash with an illegal instruction. \r\n\r\nA better way to do that is to explicitely test if sse2 is available:\r\n```\r\ntry_compile (OPENTURNS_HAVE_SSE2\r\n  ${CMAKE_CURRENT_BINARY_DIR}\r\n  ${CMAKE_CURRENT_SOURCE_DIR}/cmake/sse2.cxx)\r\n```\r\n\r\nwith cmake/sse2.cxx:\r\n```\r\n#include <emmintrin.h>\r\n\r\nint main()\r\n{\r\n  __m128d v = _mm_setzero_pd();\r\n  return 0;\r\n}\r\n```\r\n\r\nThen we only use fmath only if OPENTURNS_HAVE_SSE2.\r\n","created_at":"2018-11-07T10:19:55Z","updated_at":"2018-11-07T10:19:55Z","html_url":"https://github.com/openturns/openturns/pull/888#discussion_r231449620","pull_request_url":"https://api.github.com/repos/openturns/openturns/pulls/888","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openturns/openturns/pulls/comments/231449620"},"html":{"href":"https://github.com/openturns/openturns/pull/888#discussion_r231449620"},"pull_request":{"href":"https://api.github.com/repos/openturns/openturns/pulls/888"}}},"pull_request":{"url":"https://api.github.com/repos/openturns/openturns/pulls/888","id":228719030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzE5MDMw","html_url":"https://github.com/openturns/openturns/pull/888","diff_url":"https://github.com/openturns/openturns/pull/888.diff","patch_url":"https://github.com/openturns/openturns/pull/888.patch","issue_url":"https://api.github.com/repos/openturns/openturns/issues/888","number":888,"state":"open","locked":false,"title":"Integration of fmath","user":{"login":"regislebrun","id":8220933,"node_id":"MDQ6VXNlcjgyMjA5MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8220933?v=4","gravatar_id":"","url":"https://api.github.com/users/regislebrun","html_url":"https://github.com/regislebrun","followers_url":"https://api.github.com/users/regislebrun/followers","following_url":"https://api.github.com/users/regislebrun/following{/other_user}","gists_url":"https://api.github.com/users/regislebrun/gists{/gist_id}","starred_url":"https://api.github.com/users/regislebrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regislebrun/subscriptions","organizations_url":"https://api.github.com/users/regislebrun/orgs","repos_url":"https://api.github.com/users/regislebrun/repos","events_url":"https://api.github.com/users/regislebrun/events{/privacy}","received_events_url":"https://api.github.com/users/regislebrun/received_events","type":"User","site_admin":false},"body":"- Added SpecFunc::Exp(): This method allows to use the *fast* implementation of the exponential function provided by https://github.com/herumi/fmath/blob/master/fmath.hpp. The resulting speedup of EmpiricalBernsteinCopula::computePDF() is significant (x2.3).\r\n\r\n- Replaced std::exp() by SpecFunc::Exp(): All the computations of exponential of real numbers have been replaced in order to benefit from the new high performance implementation of the exponential function.\r\n","created_at":"2018-11-06T14:54:01Z","updated_at":"2018-11-07T10:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6bffe3e966c2269e57fa7a4d3564af20b2632b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openturns/openturns/pulls/888/commits","review_comments_url":"https://api.github.com/repos/openturns/openturns/pulls/888/comments","review_comment_url":"https://api.github.com/repos/openturns/openturns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openturns/openturns/issues/888/comments","statuses_url":"https://api.github.com/repos/openturns/openturns/statuses/b1f57f2b32b12f955401a6f8a38a088d5f6f8b6d","head":{"label":"regislebrun:test_fmath","ref":"test_fmath","sha":"b1f57f2b32b12f955401a6f8a38a088d5f6f8b6d","user":{"login":"regislebrun","id":8220933,"node_id":"MDQ6VXNlcjgyMjA5MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8220933?v=4","gravatar_id":"","url":"https://api.github.com/users/regislebrun","html_url":"https://github.com/regislebrun","followers_url":"https://api.github.com/users/regislebrun/followers","following_url":"https://api.github.com/users/regislebrun/following{/other_user}","gists_url":"https://api.github.com/users/regislebrun/gists{/gist_id}","starred_url":"https://api.github.com/users/regislebrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regislebrun/subscriptions","organizations_url":"https://api.github.com/users/regislebrun/orgs","repos_url":"https://api.github.com/users/regislebrun/repos","events_url":"https://api.github.com/users/regislebrun/events{/privacy}","received_events_url":"https://api.github.com/users/regislebrun/received_events","type":"User","site_admin":false},"repo":{"id":41668597,"node_id":"MDEwOlJlcG9zaXRvcnk0MTY2ODU5Nw==","name":"openturns","full_name":"regislebrun/openturns","private":false,"owner":{"login":"regislebrun","id":8220933,"node_id":"MDQ6VXNlcjgyMjA5MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8220933?v=4","gravatar_id":"","url":"https://api.github.com/users/regislebrun","html_url":"https://github.com/regislebrun","followers_url":"https://api.github.com/users/regislebrun/followers","following_url":"https://api.github.com/users/regislebrun/following{/other_user}","gists_url":"https://api.github.com/users/regislebrun/gists{/gist_id}","starred_url":"https://api.github.com/users/regislebrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regislebrun/subscriptions","organizations_url":"https://api.github.com/users/regislebrun/orgs","repos_url":"https://api.github.com/users/regislebrun/repos","events_url":"https://api.github.com/users/regislebrun/events{/privacy}","received_events_url":"https://api.github.com/users/regislebrun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/regislebrun/openturns","description":"Uncertainty library in C++/Python","fork":true,"url":"https://api.github.com/repos/regislebrun/openturns","forks_url":"https://api.github.com/repos/regislebrun/openturns/forks","keys_url":"https://api.github.com/repos/regislebrun/openturns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regislebrun/openturns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regislebrun/openturns/teams","hooks_url":"https://api.github.com/repos/regislebrun/openturns/hooks","issue_events_url":"https://api.github.com/repos/regislebrun/openturns/issues/events{/number}","events_url":"https://api.github.com/repos/regislebrun/openturns/events","assignees_url":"https://api.github.com/repos/regislebrun/openturns/assignees{/user}","branches_url":"https://api.github.com/repos/regislebrun/openturns/branches{/branch}","tags_url":"https://api.github.com/repos/regislebrun/openturns/tags","blobs_url":"https://api.github.com/repos/regislebrun/openturns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regislebrun/openturns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regislebrun/openturns/git/refs{/sha}","trees_url":"https://api.github.com/repos/regislebrun/openturns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regislebrun/openturns/statuses/{sha}","languages_url":"https://api.github.com/repos/regislebrun/openturns/languages","stargazers_url":"https://api.github.com/repos/regislebrun/openturns/stargazers","contributors_url":"https://api.github.com/repos/regislebrun/openturns/contributors","subscribers_url":"https://api.github.com/repos/regislebrun/openturns/subscribers","subscription_url":"https://api.github.com/repos/regislebrun/openturns/subscription","commits_url":"https://api.github.com/repos/regislebrun/openturns/commits{/sha}","git_commits_url":"https://api.github.com/repos/regislebrun/openturns/git/commits{/sha}","comments_url":"https://api.github.com/repos/regislebrun/openturns/comments{/number}","issue_comment_url":"https://api.github.com/repos/regislebrun/openturns/issues/comments{/number}","contents_url":"https://api.github.com/repos/regislebrun/openturns/contents/{+path}","compare_url":"https://api.github.com/repos/regislebrun/openturns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regislebrun/openturns/merges","archive_url":"https://api.github.com/repos/regislebrun/openturns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regislebrun/openturns/downloads","issues_url":"https://api.github.com/repos/regislebrun/openturns/issues{/number}","pulls_url":"https://api.github.com/repos/regislebrun/openturns/pulls{/number}","milestones_url":"https://api.github.com/repos/regislebrun/openturns/milestones{/number}","notifications_url":"https://api.github.com/repos/regislebrun/openturns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regislebrun/openturns/labels{/name}","releases_url":"https://api.github.com/repos/regislebrun/openturns/releases{/id}","deployments_url":"https://api.github.com/repos/regislebrun/openturns/deployments","created_at":"2015-08-31T09:57:44Z","updated_at":"2018-11-05T09:06:22Z","pushed_at":"2018-11-07T10:19:42Z","git_url":"git://github.com/regislebrun/openturns.git","ssh_url":"git@github.com:regislebrun/openturns.git","clone_url":"https://github.com/regislebrun/openturns.git","svn_url":"https://github.com/regislebrun/openturns","homepage":"","size":37969,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openturns:master","ref":"master","sha":"28d14bc4e9c67d6b1134020853d7e06b97bc1f84","user":{"login":"openturns","id":13798124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk4MTI0","avatar_url":"https://avatars2.githubusercontent.com/u/13798124?v=4","gravatar_id":"","url":"https://api.github.com/users/openturns","html_url":"https://github.com/openturns","followers_url":"https://api.github.com/users/openturns/followers","following_url":"https://api.github.com/users/openturns/following{/other_user}","gists_url":"https://api.github.com/users/openturns/gists{/gist_id}","starred_url":"https://api.github.com/users/openturns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openturns/subscriptions","organizations_url":"https://api.github.com/users/openturns/orgs","repos_url":"https://api.github.com/users/openturns/repos","events_url":"https://api.github.com/users/openturns/events{/privacy}","received_events_url":"https://api.github.com/users/openturns/received_events","type":"Organization","site_admin":false},"repo":{"id":40717169,"node_id":"MDEwOlJlcG9zaXRvcnk0MDcxNzE2OQ==","name":"openturns","full_name":"openturns/openturns","private":false,"owner":{"login":"openturns","id":13798124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk4MTI0","avatar_url":"https://avatars2.githubusercontent.com/u/13798124?v=4","gravatar_id":"","url":"https://api.github.com/users/openturns","html_url":"https://github.com/openturns","followers_url":"https://api.github.com/users/openturns/followers","following_url":"https://api.github.com/users/openturns/following{/other_user}","gists_url":"https://api.github.com/users/openturns/gists{/gist_id}","starred_url":"https://api.github.com/users/openturns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openturns/subscriptions","organizations_url":"https://api.github.com/users/openturns/orgs","repos_url":"https://api.github.com/users/openturns/repos","events_url":"https://api.github.com/users/openturns/events{/privacy}","received_events_url":"https://api.github.com/users/openturns/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openturns/openturns","description":"Uncertainty treatment library","fork":false,"url":"https://api.github.com/repos/openturns/openturns","forks_url":"https://api.github.com/repos/openturns/openturns/forks","keys_url":"https://api.github.com/repos/openturns/openturns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openturns/openturns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openturns/openturns/teams","hooks_url":"https://api.github.com/repos/openturns/openturns/hooks","issue_events_url":"https://api.github.com/repos/openturns/openturns/issues/events{/number}","events_url":"https://api.github.com/repos/openturns/openturns/events","assignees_url":"https://api.github.com/repos/openturns/openturns/assignees{/user}","branches_url":"https://api.github.com/repos/openturns/openturns/branches{/branch}","tags_url":"https://api.github.com/repos/openturns/openturns/tags","blobs_url":"https://api.github.com/repos/openturns/openturns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openturns/openturns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openturns/openturns/git/refs{/sha}","trees_url":"https://api.github.com/repos/openturns/openturns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openturns/openturns/statuses/{sha}","languages_url":"https://api.github.com/repos/openturns/openturns/languages","stargazers_url":"https://api.github.com/repos/openturns/openturns/stargazers","contributors_url":"https://api.github.com/repos/openturns/openturns/contributors","subscribers_url":"https://api.github.com/repos/openturns/openturns/subscribers","subscription_url":"https://api.github.com/repos/openturns/openturns/subscription","commits_url":"https://api.github.com/repos/openturns/openturns/commits{/sha}","git_commits_url":"https://api.github.com/repos/openturns/openturns/git/commits{/sha}","comments_url":"https://api.github.com/repos/openturns/openturns/comments{/number}","issue_comment_url":"https://api.github.com/repos/openturns/openturns/issues/comments{/number}","contents_url":"https://api.github.com/repos/openturns/openturns/contents/{+path}","compare_url":"https://api.github.com/repos/openturns/openturns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openturns/openturns/merges","archive_url":"https://api.github.com/repos/openturns/openturns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openturns/openturns/downloads","issues_url":"https://api.github.com/repos/openturns/openturns/issues{/number}","pulls_url":"https://api.github.com/repos/openturns/openturns/pulls{/number}","milestones_url":"https://api.github.com/repos/openturns/openturns/milestones{/number}","notifications_url":"https://api.github.com/repos/openturns/openturns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openturns/openturns/labels{/name}","releases_url":"https://api.github.com/repos/openturns/openturns/releases{/id}","deployments_url":"https://api.github.com/repos/openturns/openturns/deployments","created_at":"2015-08-14T13:48:42Z","updated_at":"2018-11-05T07:41:10Z","pushed_at":"2018-11-07T10:19:43Z","git_url":"git://github.com/openturns/openturns.git","ssh_url":"git@github.com:openturns/openturns.git","clone_url":"https://github.com/openturns/openturns.git","svn_url":"https://github.com/openturns/openturns","homepage":"http://openturns.github.io/openturns/latest/index.html","size":38103,"stargazers_count":41,"watchers_count":41,"language":"Jupyter Notebook","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":4,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openturns/openturns/pulls/888"},"html":{"href":"https://github.com/openturns/openturns/pull/888"},"issue":{"href":"https://api.github.com/repos/openturns/openturns/issues/888"},"comments":{"href":"https://api.github.com/repos/openturns/openturns/issues/888/comments"},"review_comments":{"href":"https://api.github.com/repos/openturns/openturns/pulls/888/comments"},"review_comment":{"href":"https://api.github.com/repos/openturns/openturns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openturns/openturns/pulls/888/commits"},"statuses":{"href":"https://api.github.com/repos/openturns/openturns/statuses/b1f57f2b32b12f955401a6f8a38a088d5f6f8b6d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jschueller"}}