{"action":"created","issue":{"url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/62","repository_url":"https://api.github.com/repos/opengeospatial/ets-gpkg12","labels_url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/62/comments","events_url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/62/events","html_url":"https://github.com/opengeospatial/ets-gpkg12/pull/62","id":327955777,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjE5MjE5","number":62,"title":"Feature tests handling almost all of the geometry blob information","user":{"login":"ajanett","id":16159968,"node_id":"MDQ6VXNlcjE2MTU5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16159968?v=4","gravatar_id":"","url":"https://api.github.com/users/ajanett","html_url":"https://github.com/ajanett","followers_url":"https://api.github.com/users/ajanett/followers","following_url":"https://api.github.com/users/ajanett/following{/other_user}","gists_url":"https://api.github.com/users/ajanett/gists{/gist_id}","starred_url":"https://api.github.com/users/ajanett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajanett/subscriptions","organizations_url":"https://api.github.com/users/ajanett/orgs","repos_url":"https://api.github.com/users/ajanett/repos","events_url":"https://api.github.com/users/ajanett/events{/privacy}","received_events_url":"https://api.github.com/users/ajanett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-31T01:09:33Z","updated_at":"2018-05-31T16:15:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/pulls/62","html_url":"https://github.com/opengeospatial/ets-gpkg12/pull/62","diff_url":"https://github.com/opengeospatial/ets-gpkg12/pull/62.diff","patch_url":"https://github.com/opengeospatial/ets-gpkg12/pull/62.patch"},"body":"featureSRSconsistency - Test extending 13 which is currently only looking at table definitions, but if one inspects the standard, there are additional tests such as inconsistencies between srs_id that need to be examined.  The feature portion of this test has been added to check for inconsistencies between the geopackage contents, the geopackage geometry columns, and the set of srs_id and feature tables.\r\n\r\ngetFeaturesWithGeometryInfo - Iterator for processing feature geometry tests. This iterator performs the baseline query needed for all feature geometry tests, gathering the gpkg_geometry_columns values that will be checked for consistency against the geometry blob content in each feature.  By processing these tests with the iterator, we can check for errors in each feature table and not just quit at the very first error found.\r\n\r\nfeatureGeometryEncodingTesting – Called by the iterator for each feature table, this test function performs all testing against the geometry blob for each row of the feature table. In order to maintain some processing performance, all of these tests have to be done here rather than re-process the blob for each test separately. The tests do attempt to re-use previously identified data. Each test performed within this group provides a detailed response if an issue is found. Reviewing the tests in here:\r\n19 i   Looks for the correct magic number\r\n19 ii  Looks for the correct version number\r\n19 iii Verifies the binary type\r\n19 iv  Verifies the correct envelope flag values\r\n33     Verifies the srs_id. This test also will check for byte swap errors within the srs_id, hence by putting the test before 19 v, it will catch potential byte swap errors that may affect retrieval of the envelope.\r\n19 v   If the geometry is empty but the envelope is not empty, triggers an error\r\n20     Verifies the geometry type from within the WKB. This test also will check for possible byte swap errors within the WKB.\r\n32\tChecks if the WKB geometry type (subtype) is allowed based on the geometry type provided by gpkg_geometry_columns.\r\n66\tPartial – included only a check on the WKB item count value (when applicable) at this time. WKB processing is going to suck down a huge amount of processing time!\r\n67\tCheck for gpkg_extensions for gpkg_geom_<feature> for the feature (when there are extensions).\r\nNSG 19B Ensure the geopackage extents from gpkg_geometry_columns contains the feature envelope.\r\n78\tVerify that the rtree trigger accurately contains the feature envelope when there are rtree extensions\r\n\r\nfeatureGeometryColumnsDataValuesTableNameNEW – Added because it does not appear that the existing tests for 23 and 26 are compliant with OGC 12-128r14.\r\n\r\n\r\nAlso:\r\nClean up of escaped single quotes in SQL statements."},"comment":{"url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/comments/393587403","html_url":"https://github.com/opengeospatial/ets-gpkg12/pull/62#issuecomment-393587403","issue_url":"https://api.github.com/repos/opengeospatial/ets-gpkg12/issues/62","id":393587403,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzU4NzQwMw==","user":{"login":"ajanett","id":16159968,"node_id":"MDQ6VXNlcjE2MTU5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16159968?v=4","gravatar_id":"","url":"https://api.github.com/users/ajanett","html_url":"https://github.com/ajanett","followers_url":"https://api.github.com/users/ajanett/followers","following_url":"https://api.github.com/users/ajanett/following{/other_user}","gists_url":"https://api.github.com/users/ajanett/gists{/gist_id}","starred_url":"https://api.github.com/users/ajanett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajanett/subscriptions","organizations_url":"https://api.github.com/users/ajanett/orgs","repos_url":"https://api.github.com/users/ajanett/repos","events_url":"https://api.github.com/users/ajanett/events{/privacy}","received_events_url":"https://api.github.com/users/ajanett/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T16:15:59Z","updated_at":"2018-05-31T16:15:59Z","author_association":"NONE","body":"This pull request addresses issue #60 \r\n\r\nIt also addressed the ETS test code for: geopackage/issues/443, 442, and the feature portion of 444\r\n"}}
{"actor":{"display_login":"ajanett"}}