{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/187387702","pull_request_review_id":119158647,"id":187387702,"diff_hunk":"@@ -30,39 +30,63 @@ const (\n \n \t// KubeLoopBackIPSet is used to store endpoints dst ip:port, source ip for solving hairpin purpose.\n \tKubeLoopBackIPSet = \"KUBE-LOOP-BACK\"","path":"pkg/proxy/ipvs/ipset.go","position":3,"original_position":3,"commit_id":"c29965b98b44d1a50abfd1eb97691666f80b5fe2","original_commit_id":"c29965b98b44d1a50abfd1eb97691666f80b5fe2","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"Looks much better now. One more small suggestion. Now that the comment for the variable is the same as the value for the comment variable, maybe we can structure it like so:\r\n\r\n```\r\nKubeLoopbackIPSetComment = \"Kubernetes endpoints dst ip:port, source ip for solving hairpin purpose\"\r\nKubeLoopBackIPSet = \"KUBE-LOOP-BACK\"\r\n```\r\n\r\nBasically use the value of the comment variable as the comment for the actual IPSet. In other words, no need for \"//\" style comments.","created_at":"2018-05-10T16:42:34Z","updated_at":"2018-05-10T16:42:34Z","html_url":"https://github.com/kubernetes/kubernetes/pull/63585#discussion_r187387702","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/187387702"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63585#discussion_r187387702"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585","id":186873796,"html_url":"https://github.com/kubernetes/kubernetes/pull/63585","diff_url":"https://github.com/kubernetes/kubernetes/pull/63585.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63585.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63585","number":63585,"state":"open","locked":false,"title":"Add comments for ipset entries in kube-proxy","user":{"login":"islinwb","id":22442964,"avatar_url":"https://avatars3.githubusercontent.com/u/22442964?v=4","gravatar_id":"","url":"https://api.github.com/users/islinwb","html_url":"https://github.com/islinwb","followers_url":"https://api.github.com/users/islinwb/followers","following_url":"https://api.github.com/users/islinwb/following{/other_user}","gists_url":"https://api.github.com/users/islinwb/gists{/gist_id}","starred_url":"https://api.github.com/users/islinwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islinwb/subscriptions","organizations_url":"https://api.github.com/users/islinwb/orgs","repos_url":"https://api.github.com/users/islinwb/repos","events_url":"https://api.github.com/users/islinwb/events{/privacy}","received_events_url":"https://api.github.com/users/islinwb/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #63584 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-05-09T10:01:09Z","updated_at":"2018-05-10T16:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"788af329d0b918709a4442b870b489f655c63f88","assignee":null,"assignees":[],"requested_reviewers":[{"login":"m1093782566","id":4953962,"avatar_url":"https://avatars1.githubusercontent.com/u/4953962?v=4","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63585/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c29965b98b44d1a50abfd1eb97691666f80b5fe2","head":{"label":"islinwb:ipset_comment","ref":"ipset_comment","sha":"c29965b98b44d1a50abfd1eb97691666f80b5fe2","user":{"login":"islinwb","id":22442964,"avatar_url":"https://avatars3.githubusercontent.com/u/22442964?v=4","gravatar_id":"","url":"https://api.github.com/users/islinwb","html_url":"https://github.com/islinwb","followers_url":"https://api.github.com/users/islinwb/followers","following_url":"https://api.github.com/users/islinwb/following{/other_user}","gists_url":"https://api.github.com/users/islinwb/gists{/gist_id}","starred_url":"https://api.github.com/users/islinwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islinwb/subscriptions","organizations_url":"https://api.github.com/users/islinwb/orgs","repos_url":"https://api.github.com/users/islinwb/repos","events_url":"https://api.github.com/users/islinwb/events{/privacy}","received_events_url":"https://api.github.com/users/islinwb/received_events","type":"User","site_admin":false},"repo":{"id":99781692,"name":"kubernetes","full_name":"islinwb/kubernetes","owner":{"login":"islinwb","id":22442964,"avatar_url":"https://avatars3.githubusercontent.com/u/22442964?v=4","gravatar_id":"","url":"https://api.github.com/users/islinwb","html_url":"https://github.com/islinwb","followers_url":"https://api.github.com/users/islinwb/followers","following_url":"https://api.github.com/users/islinwb/following{/other_user}","gists_url":"https://api.github.com/users/islinwb/gists{/gist_id}","starred_url":"https://api.github.com/users/islinwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islinwb/subscriptions","organizations_url":"https://api.github.com/users/islinwb/orgs","repos_url":"https://api.github.com/users/islinwb/repos","events_url":"https://api.github.com/users/islinwb/events{/privacy}","received_events_url":"https://api.github.com/users/islinwb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/islinwb/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/islinwb/kubernetes","forks_url":"https://api.github.com/repos/islinwb/kubernetes/forks","keys_url":"https://api.github.com/repos/islinwb/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/islinwb/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/islinwb/kubernetes/teams","hooks_url":"https://api.github.com/repos/islinwb/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/islinwb/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/islinwb/kubernetes/events","assignees_url":"https://api.github.com/repos/islinwb/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/islinwb/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/islinwb/kubernetes/tags","blobs_url":"https://api.github.com/repos/islinwb/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/islinwb/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/islinwb/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/islinwb/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/islinwb/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/islinwb/kubernetes/languages","stargazers_url":"https://api.github.com/repos/islinwb/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/islinwb/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/islinwb/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/islinwb/kubernetes/subscription","commits_url":"https://api.github.com/repos/islinwb/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/islinwb/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/islinwb/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/islinwb/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/islinwb/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/islinwb/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/islinwb/kubernetes/merges","archive_url":"https://api.github.com/repos/islinwb/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/islinwb/kubernetes/downloads","issues_url":"https://api.github.com/repos/islinwb/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/islinwb/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/islinwb/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/islinwb/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/islinwb/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/islinwb/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/islinwb/kubernetes/deployments","created_at":"2017-08-09T08:05:27Z","updated_at":"2017-08-09T08:06:13Z","pushed_at":"2018-05-10T09:14:36Z","git_url":"git://github.com/islinwb/kubernetes.git","ssh_url":"git@github.com:islinwb/kubernetes.git","clone_url":"https://github.com/islinwb/kubernetes.git","svn_url":"https://github.com/islinwb/kubernetes","homepage":"http://kubernetes.io","size":549273,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9d6ea5b4a3ce89df98b73a529b8b0da164aa6af5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-10T16:18:30Z","pushed_at":"2018-05-10T16:36:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":776302,"stargazers_count":36128,"watchers_count":36128,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12733,"mirror_url":null,"archived":false,"open_issues_count":3323,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12733,"open_issues":3323,"watchers":36128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63585"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63585"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63585/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63585/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c29965b98b44d1a50abfd1eb97691666f80b5fe2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rramkumar1"}}