{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/104","repository_url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl","labels_url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/104/comments","events_url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/104/events","html_url":"https://github.com/JuliaStats/DataFramesMeta.jl/pull/104","id":351801262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzAwNzcz","number":104,"title":"Upgrade to Julia 1.0","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-18T08:01:30Z","updated_at":"2018-08-18T12:38:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/pulls/104","html_url":"https://github.com/JuliaStats/DataFramesMeta.jl/pull/104","diff_url":"https://github.com/JuliaStats/DataFramesMeta.jl/pull/104.diff","patch_url":"https://github.com/JuliaStats/DataFramesMeta.jl/pull/104.patch"},"body":"Prepare a for a new release of DataFramesMeta.jl working on Julia 1.0."},"comment":{"url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/comments/414055183","html_url":"https://github.com/JuliaStats/DataFramesMeta.jl/pull/104#issuecomment-414055183","issue_url":"https://api.github.com/repos/JuliaStats/DataFramesMeta.jl/issues/104","id":414055183,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA1NTE4Mw==","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T12:38:25Z","updated_at":"2018-08-18T12:38:25Z","author_association":"CONTRIBUTOR","body":"Now it is good for a review. I have it working under 1.0 with all core functionality.\r\n\r\nI did not do support (and they are commented out in tests) for two things:\r\n* `DataArrays` package dependencies (in tests) - do we need to test against it (I do not know how much this package is used, but for sure it is not updated for Julia 1.0 and it will require many changes to provide support);\r\n* `CompositeDataFrame` which uses `eval` in other module, which is problematic AFAIK (I am not sure if support for `CompositeDataFrame` is needed as it does not keep up with changes in `DataFrames.jl` functionality anyway and we have `JuliaDB` that provides type stable column access).\r\n\r\nTherefore, I would drop those two things (the second is more problematic as it is breaking in functionality - but maybe there is a simple and safe fix for this?).\r\n\r\n@nalimilan Any opinions about the best approach? I would want to tag a release of `DataFramesMeta` that would support Julia 1.0."}}
{"actor":{"display_login":"bkamins"}}