{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/comments/233221317","pull_request_review_id":174585968,"id":233221317,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIyMTMxNw==","diff_hunk":"@@ -298,6 +298,17 @@ func tearDownNS(addr *net.IPNet, table int, netLink netlinkwrapper.NetLink) erro\n \t\tlog.Infof(\"Delete fromContainer rule for %s in table %d\", addr.String(), table)\n \t}\n \n+\taddrHostAddr := &net.IPNet{\n+\t\tIP:   addr.IP,\n+\t\tMask: net.CIDRMask(32, 32)}\n+\n+\t// cleanup host route:\n+\tif err = netLink.RouteDel(&netlink.Route{\n+\t\tScope: netlink.SCOPE_LINK,\n+\t\tDst:   addrHostAddr}); err != nil {\n+\t\tlog.Errorf(\"delete NS network:failed to delete host route for %s, %v\", addr.String(), err)","path":"plugins/routed-eni/driver/driver.go","position":12,"original_position":12,"commit_id":"ece5edb79e8915c7777020798cd61352c20572bc","original_commit_id":"ece5edb79e8915c7777020798cd61352c20572bc","user":{"login":"mogren","id":50456,"node_id":"MDQ6VXNlcjUwNDU2","avatar_url":"https://avatars1.githubusercontent.com/u/50456?v=4","gravatar_id":"","url":"https://api.github.com/users/mogren","html_url":"https://github.com/mogren","followers_url":"https://api.github.com/users/mogren/followers","following_url":"https://api.github.com/users/mogren/following{/other_user}","gists_url":"https://api.github.com/users/mogren/gists{/gist_id}","starred_url":"https://api.github.com/users/mogren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogren/subscriptions","organizations_url":"https://api.github.com/users/mogren/orgs","repos_url":"https://api.github.com/users/mogren/repos","events_url":"https://api.github.com/users/mogren/events{/privacy}","received_events_url":"https://api.github.com/users/mogren/received_events","type":"User","site_admin":false},"body":"Nit: space missing after the `:` ","created_at":"2018-11-13T21:06:13Z","updated_at":"2018-11-13T21:07:45Z","html_url":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228#discussion_r233221317","pull_request_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/comments/233221317"},"html":{"href":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228#discussion_r233221317"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228","id":230596035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTk2MDM1","html_url":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228","diff_url":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228.diff","patch_url":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228.patch","issue_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/228","number":228,"state":"open","locked":false,"title":"cleanup up the hostroute when perform CNI delete","user":{"login":"liwenwu-amazon","id":24555154,"node_id":"MDQ6VXNlcjI0NTU1MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/24555154?v=4","gravatar_id":"","url":"https://api.github.com/users/liwenwu-amazon","html_url":"https://github.com/liwenwu-amazon","followers_url":"https://api.github.com/users/liwenwu-amazon/followers","following_url":"https://api.github.com/users/liwenwu-amazon/following{/other_user}","gists_url":"https://api.github.com/users/liwenwu-amazon/gists{/gist_id}","starred_url":"https://api.github.com/users/liwenwu-amazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liwenwu-amazon/subscriptions","organizations_url":"https://api.github.com/users/liwenwu-amazon/orgs","repos_url":"https://api.github.com/users/liwenwu-amazon/repos","events_url":"https://api.github.com/users/liwenwu-amazon/events{/privacy}","received_events_url":"https://api.github.com/users/liwenwu-amazon/received_events","type":"User","site_admin":false},"body":"*Issue #166 , if available:*\r\n\r\n*Description of changes:*\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-13T19:24:21Z","updated_at":"2018-11-13T21:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb3a1b0871ddea71bece5139d5d538fdb2cb2256","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/228/comments","statuses_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/statuses/ece5edb79e8915c7777020798cd61352c20572bc","head":{"label":"liwenwu-amazon:route-del","ref":"route-del","sha":"ece5edb79e8915c7777020798cd61352c20572bc","user":{"login":"liwenwu-amazon","id":24555154,"node_id":"MDQ6VXNlcjI0NTU1MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/24555154?v=4","gravatar_id":"","url":"https://api.github.com/users/liwenwu-amazon","html_url":"https://github.com/liwenwu-amazon","followers_url":"https://api.github.com/users/liwenwu-amazon/followers","following_url":"https://api.github.com/users/liwenwu-amazon/following{/other_user}","gists_url":"https://api.github.com/users/liwenwu-amazon/gists{/gist_id}","starred_url":"https://api.github.com/users/liwenwu-amazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liwenwu-amazon/subscriptions","organizations_url":"https://api.github.com/users/liwenwu-amazon/orgs","repos_url":"https://api.github.com/users/liwenwu-amazon/repos","events_url":"https://api.github.com/users/liwenwu-amazon/events{/privacy}","received_events_url":"https://api.github.com/users/liwenwu-amazon/received_events","type":"User","site_admin":false},"repo":{"id":112650284,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NTAyODQ=","name":"amazon-vpc-cni-k8s-1","full_name":"liwenwu-amazon/amazon-vpc-cni-k8s-1","private":false,"owner":{"login":"liwenwu-amazon","id":24555154,"node_id":"MDQ6VXNlcjI0NTU1MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/24555154?v=4","gravatar_id":"","url":"https://api.github.com/users/liwenwu-amazon","html_url":"https://github.com/liwenwu-amazon","followers_url":"https://api.github.com/users/liwenwu-amazon/followers","following_url":"https://api.github.com/users/liwenwu-amazon/following{/other_user}","gists_url":"https://api.github.com/users/liwenwu-amazon/gists{/gist_id}","starred_url":"https://api.github.com/users/liwenwu-amazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liwenwu-amazon/subscriptions","organizations_url":"https://api.github.com/users/liwenwu-amazon/orgs","repos_url":"https://api.github.com/users/liwenwu-amazon/repos","events_url":"https://api.github.com/users/liwenwu-amazon/events{/privacy}","received_events_url":"https://api.github.com/users/liwenwu-amazon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liwenwu-amazon/amazon-vpc-cni-k8s-1","description":"Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS","fork":true,"url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1","forks_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/forks","keys_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/teams","hooks_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/hooks","issue_events_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/issues/events{/number}","events_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/events","assignees_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/assignees{/user}","branches_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/branches{/branch}","tags_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/tags","blobs_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/statuses/{sha}","languages_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/languages","stargazers_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/stargazers","contributors_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/contributors","subscribers_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/subscribers","subscription_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/subscription","commits_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/contents/{+path}","compare_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/merges","archive_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/downloads","issues_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/issues{/number}","pulls_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/pulls{/number}","milestones_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/milestones{/number}","notifications_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/labels{/name}","releases_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/releases{/id}","deployments_url":"https://api.github.com/repos/liwenwu-amazon/amazon-vpc-cni-k8s-1/deployments","created_at":"2017-11-30T19:16:15Z","updated_at":"2018-01-29T21:01:23Z","pushed_at":"2018-11-13T19:22:58Z","git_url":"git://github.com/liwenwu-amazon/amazon-vpc-cni-k8s-1.git","ssh_url":"git@github.com:liwenwu-amazon/amazon-vpc-cni-k8s-1.git","clone_url":"https://github.com/liwenwu-amazon/amazon-vpc-cni-k8s-1.git","svn_url":"https://github.com/liwenwu-amazon/amazon-vpc-cni-k8s-1","homepage":null,"size":61735,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"15a69f25fdc29a9596f052032b3168c9ca14697a","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":107597148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1OTcxNDg=","name":"amazon-vpc-cni-k8s","full_name":"aws/amazon-vpc-cni-k8s","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/amazon-vpc-cni-k8s","description":"Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS","fork":false,"url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s","forks_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/forks","keys_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/teams","hooks_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/events","assignees_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/tags","blobs_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/subscription","commits_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/merges","archive_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/downloads","issues_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/deployments","created_at":"2017-10-19T20:48:50Z","updated_at":"2018-11-13T19:52:25Z","pushed_at":"2018-11-13T19:24:22Z","git_url":"git://github.com/aws/amazon-vpc-cni-k8s.git","ssh_url":"git@github.com:aws/amazon-vpc-cni-k8s.git","clone_url":"https://github.com/aws/amazon-vpc-cni-k8s.git","svn_url":"https://github.com/aws/amazon-vpc-cni-k8s","homepage":null,"size":37401,"stargazers_count":537,"watchers_count":537,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":110,"open_issues":70,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228"},"html":{"href":"https://github.com/aws/amazon-vpc-cni-k8s/pull/228"},"issue":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/228"},"comments":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-vpc-cni-k8s/statuses/ece5edb79e8915c7777020798cd61352c20572bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mogren"}}