{"action":"created","issue":{"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/65","repository_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release","labels_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/65/comments","events_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/65/events","html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/65","id":325192646,"number":65,"title":"web info optimizations","user":{"login":"papampi","id":1108483,"avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-22T08:37:22Z","updated_at":"2018-05-23T13:58:35Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/65","html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/65","diff_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/65.diff","patch_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/65.patch"},"body":"Instead of filtering miner log and only show good info, show all and add new section to highlight  errors and rejects\r\nAdd a new \"clear alerts\" on top"},"comment":{"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/comments/391357048","html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/65#issuecomment-391357048","issue_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/65","id":391357048,"user":{"login":"LuKePicci","id":8722358,"avatar_url":"https://avatars3.githubusercontent.com/u/8722358?v=4","gravatar_id":"","url":"https://api.github.com/users/LuKePicci","html_url":"https://github.com/LuKePicci","followers_url":"https://api.github.com/users/LuKePicci/followers","following_url":"https://api.github.com/users/LuKePicci/following{/other_user}","gists_url":"https://api.github.com/users/LuKePicci/gists{/gist_id}","starred_url":"https://api.github.com/users/LuKePicci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuKePicci/subscriptions","organizations_url":"https://api.github.com/users/LuKePicci/orgs","repos_url":"https://api.github.com/users/LuKePicci/repos","events_url":"https://api.github.com/users/LuKePicci/events{/privacy}","received_events_url":"https://api.github.com/users/LuKePicci/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T13:58:35Z","updated_at":"2018-05-23T13:58:35Z","author_association":"COLLABORATOR","body":"The double bracket should solve your issue with wtm_switching if block not being entered.\n\nNever though to pit 1bash user settings, but only the algo identification code.\n\nThere was a misleading on what I intend with keeping 1bash untouched, but don’t care. \n\nIf you really need to know which is he algo move that chunk of code, which is not user settings, outside of 3main in a new file. Will come in handy in other cases also.\n\nDa: Payam Nab\nInviato: mercoledì 23 maggio 2018 15:50\nA: papampi/nvOC_by_fullzero_Community_Release\nCc: Luca Piccirillo; Mention\nOggetto: Re: [papampi/nvOC_by_fullzero_Community_Release] web infooptimizations (#65)\n\nIt's impossible to keep 1bash untouched for upgrades (minor or major) there are so many variables from Temp, Power, OC, PL, fan speed, wallets, ...\nThe only way is to add separators/identifiers for each section and replace those section with some simple sed command in upgrade script and notify user to check/edit those sections.\nSeparating 1bash into multiple files will confuse users so instead of editing 1 file they have to edit multiple files and again on upgrades they have to edit some ...\nWe have talked about the separate wallet file many times and it's the same.\nAs I said before I think we should move \"ALGO identification\" to 1bash to simplify editing and adding coins and easier read by all other scripts and users dont need to edit 3main incase they wanted to add new coins.\nI already tried double bracket, that is not the problem.\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub, or mute the thread.\n\n"}}
{"actor":{"display_login":"LuKePicci"}}