{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69359","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69359/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69359/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69359/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69359","id":366142149,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODkyMzI3","number":69359,"title":"Add CreateOptions and UpdateOptions to apiserver rest parameter installation","user":{"login":"roycaihw","id":6629765,"node_id":"MDQ6VXNlcjY2Mjk3NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6629765?v=4","gravatar_id":"","url":"https://api.github.com/users/roycaihw","html_url":"https://github.com/roycaihw","followers_url":"https://api.github.com/users/roycaihw/followers","following_url":"https://api.github.com/users/roycaihw/following{/other_user}","gists_url":"https://api.github.com/users/roycaihw/gists{/gist_id}","starred_url":"https://api.github.com/users/roycaihw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roycaihw/subscriptions","organizations_url":"https://api.github.com/users/roycaihw/orgs","repos_url":"https://api.github.com/users/roycaihw/repos","events_url":"https://api.github.com/users/roycaihw/events{/privacy}","received_events_url":"https://api.github.com/users/roycaihw/received_events","type":"User","site_admin":false},"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-03T01:38:50Z","updated_at":"2018-10-04T20:53:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69359","html_url":"https://github.com/kubernetes/kubernetes/pull/69359","diff_url":"https://github.com/kubernetes/kubernetes/pull/69359.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69359.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nIn 1.12 we introduced `metav1.CreateOptions` and `metav1.UpdateOptions` to support `dryRun` query parameter in apiserver POST/PUT/PATCH/DELETE handlers: https://github.com/kubernetes/kubernetes/pull/65105. However our openapi spec didn't reflect the parameter in POST/PUT/PATCH operations.\r\n\r\nThis PR adds CreateOptions and UpdateOptions to apiserver rest parameter installation, to parse the option struct and register the query parameters.\r\n\r\nThe openapi-generated clients (python, java, etc.) are unaware of the `dryRun` parameter without this fix. We may want to cherrypick this PR to 1.12, to make those clients support dry-run.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #69304 \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nOpenAPI spec and API reference now reflect dryRun query parameter for POST/PUT/PATCH operations\r\n```\r\n\r\n/cc @apelisse @mbohlool \r\n/sig api-machinery"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/427165669","html_url":"https://github.com/kubernetes/kubernetes/pull/69359#issuecomment-427165669","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69359","id":427165669,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE2NTY2OQ==","user":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T20:53:57Z","updated_at":"2018-10-04T20:53:57Z","author_association":"CONTRIBUTOR","body":"/assign @mbohlool \r\n"}}
{"actor":{"display_login":"jennybuckley"}}