{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/199099957","pull_request_review_id":133152031,"id":199099957,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA5OTk1Nw==","diff_hunk":"@@ -1,103 +1,55 @@\n-buildscript {\n+description 'Corda Shell CLI'\n \n+buildscript {\n     repositories {\n-        mavenLocal()\n-        mavenCentral()\n-        jcenter()\n+        maven {\n+            url \"https://plugins.gradle.org/m2/\"\n+        }\n     }\n-\n     dependencies {\n-        classpath \"org.jetbrains.kotlin:kotlin-noarg:$kotlin_version\"\n-        classpath \"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version\"\n-        classpath 'com.github.jengelman.gradle.plugins:shadow:2.0.1'\n+        classpath \"com.github.jengelman.gradle.plugins:shadow:$shadow_version\"\n+        classpath 'de.sebastianboegl.gradle.plugins:shadow-log4j-transformer:2.1.1'\n     }\n }\n \n-repositories {\n-    mavenLocal()\n-    mavenCentral()\n-    jcenter()\n-}\n-\n-apply plugin: 'kotlin'\n-apply plugin: 'java'\n apply plugin: 'application'\n+apply plugin: 'com.github.johnrengelman.shadow'\n apply plugin: 'net.corda.plugins.publish-utils'\n apply plugin: 'com.jfrog.artifactory'\n-apply plugin: 'com.github.johnrengelman.shadow'\n-apply plugin: 'maven-publish'\n-\n-description 'Corda Shell CLI'\n \n-configurations {\n-    integrationTestCompile.extendsFrom testCompile\n-    integrationTestRuntime.extendsFrom testRuntime\n-}\n-\n-sourceSets {\n-    integrationTest {\n-        kotlin {\n-            compileClasspath += main.output + test.output\n-            runtimeClasspath += main.output + test.output\n-            srcDir file('src/integration-test/kotlin')\n-        }\n-        resources {\n-            srcDir file('src/integration-test/resources')\n-        }\n-    }\n-    test {\n-        resources {\n-            srcDir file('src/test/resources')\n-        }\n-    }\n-}\n+mainClassName = 'net.corda.tools.shell.StandaloneShellKt'\n \n dependencies {\n-    compile \"org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version\"\n-    testCompile \"org.jetbrains.kotlin:kotlin-test:$kotlin_version\"\n-\n     compile project(':tools:shell')\n+    compile group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.25'\n \n-    // Unit testing helpers.\n-    testCompile \"junit:junit:$junit_version\"\n-    testCompile \"org.assertj:assertj-core:${assertj_version}\"\n     testCompile project(':test-utils')\n-    testCompile project(':finance')\n-\n-}\n-\n-mainClassName = 'net.corda.tools.shell.StandaloneShellKt'\n-\n-jar {\n-    baseName 'corda-shell-cli'\n }\n \n processResources {\n     from file(\"$rootDir/config/dev/log4j2.xml\")\n }\n \n-task integrationTest(type: Test) {\n-    testClassesDirs = sourceSets.integrationTest.output.classesDirs\n-    classpath = sourceSets.integrationTest.runtimeClasspath\n-}\n-\n-publishing {\n-    publications {\n-        shadow(MavenPublication) { publication ->\n-            project.shadow.component(publication)\n-            artifactId = \"corda-tools-shell-cli\"\n-        }\n-    }\n-}\n-\n shadowJar  {\n     //transform(de.sebastianboegl.gradle.plugins.shadow.transformers.Log4j2PluginsFileTransformer)\n-    archiveName = \"corda-shell-cli-${version}.jar\"\n+    archiveName = \"shell-cli-${version}.jar\"\n \n-    baseName = 'corda-shell-cli'\n-    classifier = null\n-    mainClassName = 'net.corda.tools.shell.StandaloneShellKt'\n     mergeServiceFiles()\n }\n \n task buildShellCli(dependsOn: shadowJar)\n+\n+artifacts {\n+    publish shadowJar {\n+        classifier \"\"\n+    }\n+}\n+\n+jar {\n+    classifier \"ignore\"\n+}\n+\n+publish {\n+    name 'corda-tools-shell-cli'\n+    disableDefaultJar = true\n+}","path":"tools/shell-cli/build.gradle","position":129,"original_position":129,"commit_id":"1ec437b9a0812ede9b9b92ca39e70debb32d3c5b","original_commit_id":"75039fc9a874c0bde0dbf92842b3670d9f387e7b","user":{"login":"chrisr3","id":25174078,"node_id":"MDQ6VXNlcjI1MTc0MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/25174078?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisr3","html_url":"https://github.com/chrisr3","followers_url":"https://api.github.com/users/chrisr3/followers","following_url":"https://api.github.com/users/chrisr3/following{/other_user}","gists_url":"https://api.github.com/users/chrisr3/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisr3/subscriptions","organizations_url":"https://api.github.com/users/chrisr3/orgs","repos_url":"https://api.github.com/users/chrisr3/repos","events_url":"https://api.github.com/users/chrisr3/events{/privacy}","received_events_url":"https://api.github.com/users/chrisr3/received_events","type":"User","site_admin":false},"body":"Due to a quirk in the `publish-utils` plugin, the `name` property _must_ be set *last*. It will ignore any further configuration after `name` is set, i.e. `disableDefaultJar`.","created_at":"2018-06-29T09:10:08Z","updated_at":"2018-06-29T09:40:07Z","html_url":"https://github.com/corda/corda/pull/3474#discussion_r199099957","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/3474","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/199099957"},"html":{"href":"https://github.com/corda/corda/pull/3474#discussion_r199099957"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/3474"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/3474","id":198246687,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjQ2Njg3","html_url":"https://github.com/corda/corda/pull/3474","diff_url":"https://github.com/corda/corda/pull/3474.diff","patch_url":"https://github.com/corda/corda/pull/3474.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/3474","number":3474,"state":"closed","locked":false,"title":"ENT-1741 Build standalone shell JAR distribution - fix","user":{"login":"szymonsztuka","id":8189785,"node_id":"MDQ6VXNlcjgxODk3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8189785?v=4","gravatar_id":"","url":"https://api.github.com/users/szymonsztuka","html_url":"https://github.com/szymonsztuka","followers_url":"https://api.github.com/users/szymonsztuka/followers","following_url":"https://api.github.com/users/szymonsztuka/following{/other_user}","gists_url":"https://api.github.com/users/szymonsztuka/gists{/gist_id}","starred_url":"https://api.github.com/users/szymonsztuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szymonsztuka/subscriptions","organizations_url":"https://api.github.com/users/szymonsztuka/orgs","repos_url":"https://api.github.com/users/szymonsztuka/repos","events_url":"https://api.github.com/users/szymonsztuka/events{/privacy}","received_events_url":"https://api.github.com/users/szymonsztuka/received_events","type":"User","site_admin":false},"body":"Fix to publish standalone shell to repository","created_at":"2018-06-29T08:19:53Z","updated_at":"2018-06-29T09:40:07Z","closed_at":"2018-06-29T09:32:38Z","merged_at":"2018-06-29T09:32:38Z","merge_commit_sha":"0a700fd3f0c8d3b6ce922d89b0e18db6a23c7c0c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sollecitom","id":5455106,"node_id":"MDQ6VXNlcjU0NTUxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5455106?v=4","gravatar_id":"","url":"https://api.github.com/users/sollecitom","html_url":"https://github.com/sollecitom","followers_url":"https://api.github.com/users/sollecitom/followers","following_url":"https://api.github.com/users/sollecitom/following{/other_user}","gists_url":"https://api.github.com/users/sollecitom/gists{/gist_id}","starred_url":"https://api.github.com/users/sollecitom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sollecitom/subscriptions","organizations_url":"https://api.github.com/users/sollecitom/orgs","repos_url":"https://api.github.com/users/sollecitom/repos","events_url":"https://api.github.com/users/sollecitom/events{/privacy}","received_events_url":"https://api.github.com/users/sollecitom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/3474/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/3474/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/3474/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/1ec437b9a0812ede9b9b92ca39e70debb32d3c5b","head":{"label":"corda:features/standalone-shell-build","ref":"features/standalone-shell-build","sha":"1ec437b9a0812ede9b9b92ca39e70debb32d3c5b","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-06-29T09:32:44Z","pushed_at":"2018-06-29T09:39:02Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":147702,"stargazers_count":2009,"watchers_count":2009,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":537,"open_issues":113,"watchers":2009,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"7ae0775514b8ae0e1da365d1e0761da19b29e4c6","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-06-29T09:32:44Z","pushed_at":"2018-06-29T09:39:02Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":147702,"stargazers_count":2009,"watchers_count":2009,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":537,"open_issues":113,"watchers":2009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/3474"},"html":{"href":"https://github.com/corda/corda/pull/3474"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/3474"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/3474/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/3474/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/3474/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/1ec437b9a0812ede9b9b92ca39e70debb32d3c5b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chrisr3"}}