{"action":"closed","number":261,"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/261","id":201809303,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODA5MzAz","html_url":"https://github.com/brave/brave-core/pull/261","diff_url":"https://github.com/brave/brave-core/pull/261.diff","patch_url":"https://github.com/brave/brave-core/pull/261.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/261","number":261,"state":"closed","locked":false,"title":"Fix darwin dmg name in upload script","user":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"body":"Fix darwin dmg name in upload script\r\n    \r\nThis resolves brave/brave-browser#565 by passing the filename and changing the match pattern to:\r\n> 'Brave-Browser-' + channel.capitalize() + r'.*\\.dmg$'\r\n\r\nAlso adds tests for yield_brave_packages in scripts/upload.py\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n\r\n## Test Plan:\r\n\r\nhttps://staging.ci.brave.com/view/all/job/brave-browser-build-darwin-upload/15/console\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [x] Adequate test coverage exists to prevent regressions\r\n","created_at":"2018-07-17T02:37:55Z","updated_at":"2018-07-17T03:49:45Z","closed_at":"2018-07-17T03:49:44Z","merged_at":"2018-07-17T03:49:44Z","merge_commit_sha":"3d4a3c84f087dd9480890e442ae7ffbde5bacc2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/261/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/261/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/261/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/4e5579f3593cff9ecfc148b782aa19f49b3099ad","head":{"label":"RyanJarv:fix/darwin-upload","ref":"fix/darwin-upload","sha":"4e5579f3593cff9ecfc148b782aa19f49b3099ad","user":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"repo":{"id":131938718,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5Mzg3MTg=","name":"brave-core","full_name":"RyanJarv/brave-core","owner":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyanJarv/brave-core","description":"New version of muon based on chromium and for all platforms","fork":true,"url":"https://api.github.com/repos/RyanJarv/brave-core","forks_url":"https://api.github.com/repos/RyanJarv/brave-core/forks","keys_url":"https://api.github.com/repos/RyanJarv/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyanJarv/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyanJarv/brave-core/teams","hooks_url":"https://api.github.com/repos/RyanJarv/brave-core/hooks","issue_events_url":"https://api.github.com/repos/RyanJarv/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/RyanJarv/brave-core/events","assignees_url":"https://api.github.com/repos/RyanJarv/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/RyanJarv/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/RyanJarv/brave-core/tags","blobs_url":"https://api.github.com/repos/RyanJarv/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyanJarv/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyanJarv/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyanJarv/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyanJarv/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RyanJarv/brave-core/languages","stargazers_url":"https://api.github.com/repos/RyanJarv/brave-core/stargazers","contributors_url":"https://api.github.com/repos/RyanJarv/brave-core/contributors","subscribers_url":"https://api.github.com/repos/RyanJarv/brave-core/subscribers","subscription_url":"https://api.github.com/repos/RyanJarv/brave-core/subscription","commits_url":"https://api.github.com/repos/RyanJarv/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyanJarv/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyanJarv/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyanJarv/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyanJarv/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/RyanJarv/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyanJarv/brave-core/merges","archive_url":"https://api.github.com/repos/RyanJarv/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyanJarv/brave-core/downloads","issues_url":"https://api.github.com/repos/RyanJarv/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/RyanJarv/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RyanJarv/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RyanJarv/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyanJarv/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/RyanJarv/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/RyanJarv/brave-core/deployments","created_at":"2018-05-03T03:47:40Z","updated_at":"2018-06-29T15:26:48Z","pushed_at":"2018-07-17T02:36:36Z","git_url":"git://github.com/RyanJarv/brave-core.git","ssh_url":"git@github.com:RyanJarv/brave-core.git","clone_url":"https://github.com/RyanJarv/brave-core.git","svn_url":"https://github.com/RyanJarv/brave-core","homepage":null,"size":18841,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"0fd4cc2229e8dc485811f0fcbda3d5661857b1a2","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android ","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-07-17T03:47:53Z","pushed_at":"2018-07-17T03:49:44Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":19651,"stargazers_count":81,"watchers_count":81,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":10,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/261"},"html":{"href":"https://github.com/brave/brave-core/pull/261"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/261"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/4e5579f3593cff9ecfc148b782aa19f49b3099ad"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":7,"changed_files":8}}
{"actor":{"display_login":"RyanJarv"}}