{"action":"created","comment":{"url":"https://api.github.com/repos/pf4j/pf4j/pulls/comments/244480644","pull_request_review_id":188406330,"id":244480644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ4MDY0NA==","diff_hunk":"@@ -34,4 +34,13 @@\n \n     int ordinal() default 0;\n \n+    /**\n+     * An array of extension points, that are implemented by this extension.\n+     * This explicit configuration overrides the automatic detection of extension points in the\n+     * {@link org.pf4j.processor.ExtensionAnnotationProcessor}.\n+     *\n+     * @return classes of extension points implemented by this extension\n+     */\n+    Class<? extends ExtensionPoint>[] provides() default {};","path":"pf4j/src/main/java/org/pf4j/Extension.java","position":11,"original_position":11,"commit_id":"3d929a3d8831ba2acccd31182f9308b8763254d3","original_commit_id":"3d929a3d8831ba2acccd31182f9308b8763254d3","user":{"login":"decebals","id":1248311,"node_id":"MDQ6VXNlcjEyNDgzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1248311?v=4","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"body":"Here I have two questions:\r\n- do you think that it's better to rename this attribute from `provides` in `points` (I feel that it's better from semantically point of view) ?\r\n- I don't have until now an extension that implements multiple points. I don't know if it's possible with the actual release and I didn't tested. Personal I prefer in my projects to have one extension for one extension point. So, my question is do we real need a list of extension point class for this attribute, is not a single extension point class enough (at least for the moment)?","created_at":"2018-12-29T11:26:51Z","updated_at":"2018-12-29T11:35:10Z","html_url":"https://github.com/pf4j/pf4j/pull/265#discussion_r244480644","pull_request_url":"https://api.github.com/repos/pf4j/pf4j/pulls/265","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/comments/244480644"},"html":{"href":"https://github.com/pf4j/pf4j/pull/265#discussion_r244480644"},"pull_request":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/pf4j/pf4j/pulls/265","id":241173490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTczNDkw","html_url":"https://github.com/pf4j/pf4j/pull/265","diff_url":"https://github.com/pf4j/pf4j/pull/265.diff","patch_url":"https://github.com/pf4j/pf4j/pull/265.patch","issue_url":"https://api.github.com/repos/pf4j/pf4j/issues/265","number":265,"state":"open","locked":false,"title":"explicitly configure extension points for an extension","user":{"login":"pinhead84","id":7954406,"node_id":"MDQ6VXNlcjc5NTQ0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7954406?v=4","gravatar_id":"","url":"https://api.github.com/users/pinhead84","html_url":"https://github.com/pinhead84","followers_url":"https://api.github.com/users/pinhead84/followers","following_url":"https://api.github.com/users/pinhead84/following{/other_user}","gists_url":"https://api.github.com/users/pinhead84/gists{/gist_id}","starred_url":"https://api.github.com/users/pinhead84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinhead84/subscriptions","organizations_url":"https://api.github.com/users/pinhead84/orgs","repos_url":"https://api.github.com/users/pinhead84/repos","events_url":"https://api.github.com/users/pinhead84/events{/privacy}","received_events_url":"https://api.github.com/users/pinhead84/received_events","type":"User","site_admin":false},"body":"This pull requests provides a possible workaround for issue #264.\r\n\r\nAn extension may provide its implemented extension points explicitly through its annotation. According to my example in issue #264 you might use:\r\n\r\n```java\r\n@Extension(provides = {BootExtensionPoint.class})\r\npublic class Plugin1BootExtension extends BootAdapter {\r\n    // ... some implementations \r\n}\r\n```\r\n\r\nIf the `@Extension` provides its implemented extension points through the `provides` attribute, there is no need for the annotation processor to detect the extension points automatically, which currently fails under the described conditions.\r\n\r\nI know, that this might not the best approach. I guess you also can improve the automatic detection of extension points in the [`findExtensionPoints`](https://github.com/pf4j/pf4j/blob/ab12f7fa5a95dd570f2e62812a243d48411c1dce/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java#L168-L191) method. But with this pull request I don't want to break compatibility by changing your current implementation. Therefore I've decided not to change your implementation and keep it as a default behaviour.\r\n\r\nIn general I'm not sure, if an improved [`findExtensionPoints`](https://github.com/pf4j/pf4j/blob/ab12f7fa5a95dd570f2e62812a243d48411c1dce/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java#L168-L191) method would work in every possible use case as expected. Therefore it might be quite helpful to have a solution, that circumvents the automatic detection.\r\n\r\nPlease let me know, what you think about this solution.","created_at":"2018-12-27T15:22:36Z","updated_at":"2018-12-29T11:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55aef256dc06117488a21d3cfd0b78b78de4dda5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pf4j/pf4j/pulls/265/commits","review_comments_url":"https://api.github.com/repos/pf4j/pf4j/pulls/265/comments","review_comment_url":"https://api.github.com/repos/pf4j/pf4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pf4j/pf4j/issues/265/comments","statuses_url":"https://api.github.com/repos/pf4j/pf4j/statuses/3d929a3d8831ba2acccd31182f9308b8763254d3","head":{"label":"pinhead84:explicit-extension-point-annotation","ref":"explicit-extension-point-annotation","sha":"3d929a3d8831ba2acccd31182f9308b8763254d3","user":{"login":"pinhead84","id":7954406,"node_id":"MDQ6VXNlcjc5NTQ0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7954406?v=4","gravatar_id":"","url":"https://api.github.com/users/pinhead84","html_url":"https://github.com/pinhead84","followers_url":"https://api.github.com/users/pinhead84/followers","following_url":"https://api.github.com/users/pinhead84/following{/other_user}","gists_url":"https://api.github.com/users/pinhead84/gists{/gist_id}","starred_url":"https://api.github.com/users/pinhead84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinhead84/subscriptions","organizations_url":"https://api.github.com/users/pinhead84/orgs","repos_url":"https://api.github.com/users/pinhead84/repos","events_url":"https://api.github.com/users/pinhead84/events{/privacy}","received_events_url":"https://api.github.com/users/pinhead84/received_events","type":"User","site_admin":false},"repo":{"id":162708063,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3MDgwNjM=","name":"pf4j","full_name":"pinhead84/pf4j","private":false,"owner":{"login":"pinhead84","id":7954406,"node_id":"MDQ6VXNlcjc5NTQ0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7954406?v=4","gravatar_id":"","url":"https://api.github.com/users/pinhead84","html_url":"https://github.com/pinhead84","followers_url":"https://api.github.com/users/pinhead84/followers","following_url":"https://api.github.com/users/pinhead84/following{/other_user}","gists_url":"https://api.github.com/users/pinhead84/gists{/gist_id}","starred_url":"https://api.github.com/users/pinhead84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinhead84/subscriptions","organizations_url":"https://api.github.com/users/pinhead84/orgs","repos_url":"https://api.github.com/users/pinhead84/repos","events_url":"https://api.github.com/users/pinhead84/events{/privacy}","received_events_url":"https://api.github.com/users/pinhead84/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pinhead84/pf4j","description":"Plugin Framework for Java (PF4J)","fork":true,"url":"https://api.github.com/repos/pinhead84/pf4j","forks_url":"https://api.github.com/repos/pinhead84/pf4j/forks","keys_url":"https://api.github.com/repos/pinhead84/pf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinhead84/pf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinhead84/pf4j/teams","hooks_url":"https://api.github.com/repos/pinhead84/pf4j/hooks","issue_events_url":"https://api.github.com/repos/pinhead84/pf4j/issues/events{/number}","events_url":"https://api.github.com/repos/pinhead84/pf4j/events","assignees_url":"https://api.github.com/repos/pinhead84/pf4j/assignees{/user}","branches_url":"https://api.github.com/repos/pinhead84/pf4j/branches{/branch}","tags_url":"https://api.github.com/repos/pinhead84/pf4j/tags","blobs_url":"https://api.github.com/repos/pinhead84/pf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinhead84/pf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinhead84/pf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinhead84/pf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinhead84/pf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/pinhead84/pf4j/languages","stargazers_url":"https://api.github.com/repos/pinhead84/pf4j/stargazers","contributors_url":"https://api.github.com/repos/pinhead84/pf4j/contributors","subscribers_url":"https://api.github.com/repos/pinhead84/pf4j/subscribers","subscription_url":"https://api.github.com/repos/pinhead84/pf4j/subscription","commits_url":"https://api.github.com/repos/pinhead84/pf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinhead84/pf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinhead84/pf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinhead84/pf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinhead84/pf4j/contents/{+path}","compare_url":"https://api.github.com/repos/pinhead84/pf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinhead84/pf4j/merges","archive_url":"https://api.github.com/repos/pinhead84/pf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinhead84/pf4j/downloads","issues_url":"https://api.github.com/repos/pinhead84/pf4j/issues{/number}","pulls_url":"https://api.github.com/repos/pinhead84/pf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/pinhead84/pf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/pinhead84/pf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinhead84/pf4j/labels{/name}","releases_url":"https://api.github.com/repos/pinhead84/pf4j/releases{/id}","deployments_url":"https://api.github.com/repos/pinhead84/pf4j/deployments","created_at":"2018-12-21T11:47:51Z","updated_at":"2018-12-28T23:54:44Z","pushed_at":"2018-12-28T23:54:42Z","git_url":"git://github.com/pinhead84/pf4j.git","ssh_url":"git@github.com:pinhead84/pf4j.git","clone_url":"https://github.com/pinhead84/pf4j.git","svn_url":"https://github.com/pinhead84/pf4j","homepage":"http://www.pf4j.org","size":965,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pf4j:master","ref":"master","sha":"ab12f7fa5a95dd570f2e62812a243d48411c1dce","user":{"login":"pf4j","id":25959549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTU5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/25959549?v=4","gravatar_id":"","url":"https://api.github.com/users/pf4j","html_url":"https://github.com/pf4j","followers_url":"https://api.github.com/users/pf4j/followers","following_url":"https://api.github.com/users/pf4j/following{/other_user}","gists_url":"https://api.github.com/users/pf4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pf4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pf4j/subscriptions","organizations_url":"https://api.github.com/users/pf4j/orgs","repos_url":"https://api.github.com/users/pf4j/repos","events_url":"https://api.github.com/users/pf4j/events{/privacy}","received_events_url":"https://api.github.com/users/pf4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6157458,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU3NDU4","name":"pf4j","full_name":"pf4j/pf4j","private":false,"owner":{"login":"pf4j","id":25959549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTU5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/25959549?v=4","gravatar_id":"","url":"https://api.github.com/users/pf4j","html_url":"https://github.com/pf4j","followers_url":"https://api.github.com/users/pf4j/followers","following_url":"https://api.github.com/users/pf4j/following{/other_user}","gists_url":"https://api.github.com/users/pf4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pf4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pf4j/subscriptions","organizations_url":"https://api.github.com/users/pf4j/orgs","repos_url":"https://api.github.com/users/pf4j/repos","events_url":"https://api.github.com/users/pf4j/events{/privacy}","received_events_url":"https://api.github.com/users/pf4j/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pf4j/pf4j","description":"Plugin Framework for Java (PF4J)","fork":false,"url":"https://api.github.com/repos/pf4j/pf4j","forks_url":"https://api.github.com/repos/pf4j/pf4j/forks","keys_url":"https://api.github.com/repos/pf4j/pf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pf4j/pf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pf4j/pf4j/teams","hooks_url":"https://api.github.com/repos/pf4j/pf4j/hooks","issue_events_url":"https://api.github.com/repos/pf4j/pf4j/issues/events{/number}","events_url":"https://api.github.com/repos/pf4j/pf4j/events","assignees_url":"https://api.github.com/repos/pf4j/pf4j/assignees{/user}","branches_url":"https://api.github.com/repos/pf4j/pf4j/branches{/branch}","tags_url":"https://api.github.com/repos/pf4j/pf4j/tags","blobs_url":"https://api.github.com/repos/pf4j/pf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pf4j/pf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pf4j/pf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/pf4j/pf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pf4j/pf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/pf4j/pf4j/languages","stargazers_url":"https://api.github.com/repos/pf4j/pf4j/stargazers","contributors_url":"https://api.github.com/repos/pf4j/pf4j/contributors","subscribers_url":"https://api.github.com/repos/pf4j/pf4j/subscribers","subscription_url":"https://api.github.com/repos/pf4j/pf4j/subscription","commits_url":"https://api.github.com/repos/pf4j/pf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/pf4j/pf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/pf4j/pf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/pf4j/pf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/pf4j/pf4j/contents/{+path}","compare_url":"https://api.github.com/repos/pf4j/pf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pf4j/pf4j/merges","archive_url":"https://api.github.com/repos/pf4j/pf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pf4j/pf4j/downloads","issues_url":"https://api.github.com/repos/pf4j/pf4j/issues{/number}","pulls_url":"https://api.github.com/repos/pf4j/pf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/pf4j/pf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/pf4j/pf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pf4j/pf4j/labels{/name}","releases_url":"https://api.github.com/repos/pf4j/pf4j/releases{/id}","deployments_url":"https://api.github.com/repos/pf4j/pf4j/deployments","created_at":"2012-10-10T13:10:32Z","updated_at":"2018-12-28T21:17:42Z","pushed_at":"2018-12-28T21:58:21Z","git_url":"git://github.com/pf4j/pf4j.git","ssh_url":"git@github.com:pf4j/pf4j.git","clone_url":"https://github.com/pf4j/pf4j.git","svn_url":"https://github.com/pf4j/pf4j","homepage":"http://www.pf4j.org","size":954,"stargazers_count":809,"watchers_count":809,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":253,"open_issues":32,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/265"},"html":{"href":"https://github.com/pf4j/pf4j/pull/265"},"issue":{"href":"https://api.github.com/repos/pf4j/pf4j/issues/265"},"comments":{"href":"https://api.github.com/repos/pf4j/pf4j/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/pf4j/pf4j/statuses/3d929a3d8831ba2acccd31182f9308b8763254d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"decebals"}}