{"action":"closed","number":929,"pull_request":{"url":"https://api.github.com/repos/pallets/jinja/pulls/929","id":233390113,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzkwMTEz","html_url":"https://github.com/pallets/jinja/pull/929","diff_url":"https://github.com/pallets/jinja/pull/929.diff","patch_url":"https://github.com/pallets/jinja/pull/929.patch","issue_url":"https://api.github.com/repos/pallets/jinja/issues/929","number":929,"state":"closed","locked":false,"title":"Fix broken nl2br filter example","user":{"login":"ExplodingCabbage","id":2358339,"node_id":"MDQ6VXNlcjIzNTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2358339?v=4","gravatar_id":"","url":"https://api.github.com/users/ExplodingCabbage","html_url":"https://github.com/ExplodingCabbage","followers_url":"https://api.github.com/users/ExplodingCabbage/followers","following_url":"https://api.github.com/users/ExplodingCabbage/following{/other_user}","gists_url":"https://api.github.com/users/ExplodingCabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/ExplodingCabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExplodingCabbage/subscriptions","organizations_url":"https://api.github.com/users/ExplodingCabbage/orgs","repos_url":"https://api.github.com/users/ExplodingCabbage/repos","events_url":"https://api.github.com/users/ExplodingCabbage/events{/privacy}","received_events_url":"https://api.github.com/users/ExplodingCabbage/received_events","type":"User","site_admin":false},"body":"This example attempts to handle both Windows-style and Unix-style line endings, but does it wrong; as noted at https://stackoverflow.com/q/12521127/1709587, the regex here will match a single \\r\\n as if it were a double line-break, which results in all single Windows-style line-breaks getting converted into `<p>` breaks instead of `<br>` breaks as intended.\r\n\r\nThis patch fixes that by applying Alan Moore's proposed fix from https://stackoverflow.com/a/12521544/1709587 of using a negative lookahead so that a \\r cannot be counted as a line break if it is followed by a \\n (while still allowing the \\r\\n combination to count as a line break).","created_at":"2018-11-25T17:55:36Z","updated_at":"2018-11-25T18:54:44Z","closed_at":"2018-11-25T18:54:44Z","merged_at":"2018-11-25T18:54:44Z","merge_commit_sha":"dd6c76599c14f9fc1995404996a5466db4a6b67d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pallets/jinja/pulls/929/commits","review_comments_url":"https://api.github.com/repos/pallets/jinja/pulls/929/comments","review_comment_url":"https://api.github.com/repos/pallets/jinja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pallets/jinja/issues/929/comments","statuses_url":"https://api.github.com/repos/pallets/jinja/statuses/9e410c7b04a91cb296aaaa39788d67bf8491b986","head":{"label":"ExplodingCabbage:fix-nl2br","ref":"fix-nl2br","sha":"9e410c7b04a91cb296aaaa39788d67bf8491b986","user":{"login":"ExplodingCabbage","id":2358339,"node_id":"MDQ6VXNlcjIzNTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2358339?v=4","gravatar_id":"","url":"https://api.github.com/users/ExplodingCabbage","html_url":"https://github.com/ExplodingCabbage","followers_url":"https://api.github.com/users/ExplodingCabbage/followers","following_url":"https://api.github.com/users/ExplodingCabbage/following{/other_user}","gists_url":"https://api.github.com/users/ExplodingCabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/ExplodingCabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExplodingCabbage/subscriptions","organizations_url":"https://api.github.com/users/ExplodingCabbage/orgs","repos_url":"https://api.github.com/users/ExplodingCabbage/repos","events_url":"https://api.github.com/users/ExplodingCabbage/events{/privacy}","received_events_url":"https://api.github.com/users/ExplodingCabbage/received_events","type":"User","site_admin":false},"repo":{"id":159058426,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkwNTg0MjY=","name":"jinja","full_name":"ExplodingCabbage/jinja","private":false,"owner":{"login":"ExplodingCabbage","id":2358339,"node_id":"MDQ6VXNlcjIzNTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2358339?v=4","gravatar_id":"","url":"https://api.github.com/users/ExplodingCabbage","html_url":"https://github.com/ExplodingCabbage","followers_url":"https://api.github.com/users/ExplodingCabbage/followers","following_url":"https://api.github.com/users/ExplodingCabbage/following{/other_user}","gists_url":"https://api.github.com/users/ExplodingCabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/ExplodingCabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExplodingCabbage/subscriptions","organizations_url":"https://api.github.com/users/ExplodingCabbage/orgs","repos_url":"https://api.github.com/users/ExplodingCabbage/repos","events_url":"https://api.github.com/users/ExplodingCabbage/events{/privacy}","received_events_url":"https://api.github.com/users/ExplodingCabbage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ExplodingCabbage/jinja","description":"The Jinja2 template engine","fork":true,"url":"https://api.github.com/repos/ExplodingCabbage/jinja","forks_url":"https://api.github.com/repos/ExplodingCabbage/jinja/forks","keys_url":"https://api.github.com/repos/ExplodingCabbage/jinja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExplodingCabbage/jinja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExplodingCabbage/jinja/teams","hooks_url":"https://api.github.com/repos/ExplodingCabbage/jinja/hooks","issue_events_url":"https://api.github.com/repos/ExplodingCabbage/jinja/issues/events{/number}","events_url":"https://api.github.com/repos/ExplodingCabbage/jinja/events","assignees_url":"https://api.github.com/repos/ExplodingCabbage/jinja/assignees{/user}","branches_url":"https://api.github.com/repos/ExplodingCabbage/jinja/branches{/branch}","tags_url":"https://api.github.com/repos/ExplodingCabbage/jinja/tags","blobs_url":"https://api.github.com/repos/ExplodingCabbage/jinja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExplodingCabbage/jinja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExplodingCabbage/jinja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExplodingCabbage/jinja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExplodingCabbage/jinja/statuses/{sha}","languages_url":"https://api.github.com/repos/ExplodingCabbage/jinja/languages","stargazers_url":"https://api.github.com/repos/ExplodingCabbage/jinja/stargazers","contributors_url":"https://api.github.com/repos/ExplodingCabbage/jinja/contributors","subscribers_url":"https://api.github.com/repos/ExplodingCabbage/jinja/subscribers","subscription_url":"https://api.github.com/repos/ExplodingCabbage/jinja/subscription","commits_url":"https://api.github.com/repos/ExplodingCabbage/jinja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExplodingCabbage/jinja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExplodingCabbage/jinja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExplodingCabbage/jinja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExplodingCabbage/jinja/contents/{+path}","compare_url":"https://api.github.com/repos/ExplodingCabbage/jinja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExplodingCabbage/jinja/merges","archive_url":"https://api.github.com/repos/ExplodingCabbage/jinja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExplodingCabbage/jinja/downloads","issues_url":"https://api.github.com/repos/ExplodingCabbage/jinja/issues{/number}","pulls_url":"https://api.github.com/repos/ExplodingCabbage/jinja/pulls{/number}","milestones_url":"https://api.github.com/repos/ExplodingCabbage/jinja/milestones{/number}","notifications_url":"https://api.github.com/repos/ExplodingCabbage/jinja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExplodingCabbage/jinja/labels{/name}","releases_url":"https://api.github.com/repos/ExplodingCabbage/jinja/releases{/id}","deployments_url":"https://api.github.com/repos/ExplodingCabbage/jinja/deployments","created_at":"2018-11-25T17:47:13Z","updated_at":"2018-11-25T17:47:16Z","pushed_at":"2018-11-25T17:53:57Z","git_url":"git://github.com/ExplodingCabbage/jinja.git","ssh_url":"git@github.com:ExplodingCabbage/jinja.git","clone_url":"https://github.com/ExplodingCabbage/jinja.git","svn_url":"https://github.com/ExplodingCabbage/jinja","homepage":"http://jinja.pocoo.org/","size":4536,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pallets:master","ref":"master","sha":"a7f1f528f5e77d5401a96aa326885508245f7c6f","user":{"login":"pallets","id":16748505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQ4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"repo":{"id":994551,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQ1NTE=","name":"jinja","full_name":"pallets/jinja","private":false,"owner":{"login":"pallets","id":16748505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQ4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pallets/jinja","description":"The Jinja2 template engine","fork":false,"url":"https://api.github.com/repos/pallets/jinja","forks_url":"https://api.github.com/repos/pallets/jinja/forks","keys_url":"https://api.github.com/repos/pallets/jinja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallets/jinja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallets/jinja/teams","hooks_url":"https://api.github.com/repos/pallets/jinja/hooks","issue_events_url":"https://api.github.com/repos/pallets/jinja/issues/events{/number}","events_url":"https://api.github.com/repos/pallets/jinja/events","assignees_url":"https://api.github.com/repos/pallets/jinja/assignees{/user}","branches_url":"https://api.github.com/repos/pallets/jinja/branches{/branch}","tags_url":"https://api.github.com/repos/pallets/jinja/tags","blobs_url":"https://api.github.com/repos/pallets/jinja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallets/jinja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallets/jinja/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallets/jinja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallets/jinja/statuses/{sha}","languages_url":"https://api.github.com/repos/pallets/jinja/languages","stargazers_url":"https://api.github.com/repos/pallets/jinja/stargazers","contributors_url":"https://api.github.com/repos/pallets/jinja/contributors","subscribers_url":"https://api.github.com/repos/pallets/jinja/subscribers","subscription_url":"https://api.github.com/repos/pallets/jinja/subscription","commits_url":"https://api.github.com/repos/pallets/jinja/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallets/jinja/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallets/jinja/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallets/jinja/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallets/jinja/contents/{+path}","compare_url":"https://api.github.com/repos/pallets/jinja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallets/jinja/merges","archive_url":"https://api.github.com/repos/pallets/jinja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallets/jinja/downloads","issues_url":"https://api.github.com/repos/pallets/jinja/issues{/number}","pulls_url":"https://api.github.com/repos/pallets/jinja/pulls{/number}","milestones_url":"https://api.github.com/repos/pallets/jinja/milestones{/number}","notifications_url":"https://api.github.com/repos/pallets/jinja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallets/jinja/labels{/name}","releases_url":"https://api.github.com/repos/pallets/jinja/releases{/id}","deployments_url":"https://api.github.com/repos/pallets/jinja/deployments","created_at":"2010-10-17T13:41:17Z","updated_at":"2018-11-25T16:54:44Z","pushed_at":"2018-11-25T18:54:44Z","git_url":"git://github.com/pallets/jinja.git","ssh_url":"git@github.com:pallets/jinja.git","clone_url":"https://github.com/pallets/jinja.git","svn_url":"https://github.com/pallets/jinja","homepage":"http://jinja.pocoo.org/","size":4536,"stargazers_count":5629,"watchers_count":5629,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1094,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1094,"open_issues":142,"watchers":5629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pallets/jinja/pulls/929"},"html":{"href":"https://github.com/pallets/jinja/pull/929"},"issue":{"href":"https://api.github.com/repos/pallets/jinja/issues/929"},"comments":{"href":"https://api.github.com/repos/pallets/jinja/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/pallets/jinja/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/pallets/jinja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pallets/jinja/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/pallets/jinja/statuses/9e410c7b04a91cb296aaaa39788d67bf8491b986"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davidism","id":1242887,"node_id":"MDQ6VXNlcjEyNDI4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1242887?v=4","gravatar_id":"","url":"https://api.github.com/users/davidism","html_url":"https://github.com/davidism","followers_url":"https://api.github.com/users/davidism/followers","following_url":"https://api.github.com/users/davidism/following{/other_user}","gists_url":"https://api.github.com/users/davidism/gists{/gist_id}","starred_url":"https://api.github.com/users/davidism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidism/subscriptions","organizations_url":"https://api.github.com/users/davidism/orgs","repos_url":"https://api.github.com/users/davidism/repos","events_url":"https://api.github.com/users/davidism/events{/privacy}","received_events_url":"https://api.github.com/users/davidism/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"davidism"}}