{"action":"created","comment":{"url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments/238133512","pull_request_review_id":180600703,"id":238133512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEzMzUxMg==","diff_hunk":"@@ -266,6 +268,16 @@ loadFrontendToml(std::shared_ptr<cpptoml::table> config)\n    }\n \n    config::input::vpad0 = config->get_qualified_as<std::string>(\"input.vpad0\").value_or(config::input::vpad0);\n+\n+   config::input::wpad[0] = config->get_qualified_as<std::string>(\"input.wpad0\").value_or(config::input::wpad[0]);\n+   config::input::wpad[1] = config->get_qualified_as<std::string>(\"input.wpad1\").value_or(config::input::wpad[1]);\n+   config::input::wpad[2] = config->get_qualified_as<std::string>(\"input.wpad2\").value_or(config::input::wpad[2]);\n+   config::input::wpad[3] = config->get_qualified_as<std::string>(\"input.wpad3\").value_or(config::input::wpad[3]);\n+\n+   config::input::wpadType[0] = config->get_qualified_as<std::string>(\"input.wpadType0\").value_or(config::input::wpadType[0]);\n+   config::input::wpadType[1] = config->get_qualified_as<std::string>(\"input.wpadType1\").value_or(config::input::wpadType[1]);\n+   config::input::wpadType[2] = config->get_qualified_as<std::string>(\"input.wpadType2\").value_or(config::input::wpadType[2]);\n+   config::input::wpadType[3] = config->get_qualified_as<std::string>(\"input.wpadType3\").value_or(config::input::wpadType[3]);","path":"src/common-sdl/decafsdl_config.cpp","position":22,"original_position":22,"commit_id":"ff0d28558b34f4680a0d72d92044995778f42d97","original_commit_id":"ff0d28558b34f4680a0d72d92044995778f42d97","user":{"login":"baryluk","id":110322,"node_id":"MDQ6VXNlcjExMDMyMg==","avatar_url":"https://avatars0.githubusercontent.com/u/110322?v=4","gravatar_id":"","url":"https://api.github.com/users/baryluk","html_url":"https://github.com/baryluk","followers_url":"https://api.github.com/users/baryluk/followers","following_url":"https://api.github.com/users/baryluk/following{/other_user}","gists_url":"https://api.github.com/users/baryluk/gists{/gist_id}","starred_url":"https://api.github.com/users/baryluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baryluk/subscriptions","organizations_url":"https://api.github.com/users/baryluk/orgs","repos_url":"https://api.github.com/users/baryluk/repos","events_url":"https://api.github.com/users/baryluk/events{/privacy}","received_events_url":"https://api.github.com/users/baryluk/received_events","type":"User","site_admin":false},"body":"change these repetitive code to use for loops?\r\n\r\nalso in other places below and in config.cpp and main.cpp ?","created_at":"2018-12-03T02:56:10Z","updated_at":"2018-12-03T02:56:10Z","html_url":"https://github.com/decaf-emu/decaf-emu/pull/497#discussion_r238133512","pull_request_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments/238133512"},"html":{"href":"https://github.com/decaf-emu/decaf-emu/pull/497#discussion_r238133512"},"pull_request":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497","id":220943307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTQzMzA3","html_url":"https://github.com/decaf-emu/decaf-emu/pull/497","diff_url":"https://github.com/decaf-emu/decaf-emu/pull/497.diff","patch_url":"https://github.com/decaf-emu/decaf-emu/pull/497.patch","issue_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/497","number":497,"state":"open","locked":false,"title":"Implementation of KPAD / WPAD","user":{"login":"SteveLeafo","id":8372950,"node_id":"MDQ6VXNlcjgzNzI5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8372950?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveLeafo","html_url":"https://github.com/SteveLeafo","followers_url":"https://api.github.com/users/SteveLeafo/followers","following_url":"https://api.github.com/users/SteveLeafo/following{/other_user}","gists_url":"https://api.github.com/users/SteveLeafo/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveLeafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveLeafo/subscriptions","organizations_url":"https://api.github.com/users/SteveLeafo/orgs","repos_url":"https://api.github.com/users/SteveLeafo/repos","events_url":"https://api.github.com/users/SteveLeafo/events{/privacy}","received_events_url":"https://api.github.com/users/SteveLeafo/received_events","type":"User","site_admin":false},"body":"With these changes I was able to play a two player game of family tennis, but there is still a long way to go.\r\nI wasn't able to get a second player to join a Mario Kart game.\r\n","created_at":"2018-10-07T11:51:47Z","updated_at":"2018-12-03T02:56:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"607b35b1f2d77a13f0a50fefa9800e2669a5b087","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497/commits","review_comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497/comments","review_comment_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/497/comments","statuses_url":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/ff0d28558b34f4680a0d72d92044995778f42d97","head":{"label":"SteveLeafo:kpad","ref":"kpad","sha":"ff0d28558b34f4680a0d72d92044995778f42d97","user":{"login":"SteveLeafo","id":8372950,"node_id":"MDQ6VXNlcjgzNzI5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8372950?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveLeafo","html_url":"https://github.com/SteveLeafo","followers_url":"https://api.github.com/users/SteveLeafo/followers","following_url":"https://api.github.com/users/SteveLeafo/following{/other_user}","gists_url":"https://api.github.com/users/SteveLeafo/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveLeafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveLeafo/subscriptions","organizations_url":"https://api.github.com/users/SteveLeafo/orgs","repos_url":"https://api.github.com/users/SteveLeafo/repos","events_url":"https://api.github.com/users/SteveLeafo/events{/privacy}","received_events_url":"https://api.github.com/users/SteveLeafo/received_events","type":"User","site_admin":false},"repo":{"id":148302295,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMDIyOTU=","name":"decaf-emu","full_name":"SteveLeafo/decaf-emu","private":false,"owner":{"login":"SteveLeafo","id":8372950,"node_id":"MDQ6VXNlcjgzNzI5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8372950?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveLeafo","html_url":"https://github.com/SteveLeafo","followers_url":"https://api.github.com/users/SteveLeafo/followers","following_url":"https://api.github.com/users/SteveLeafo/following{/other_user}","gists_url":"https://api.github.com/users/SteveLeafo/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveLeafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveLeafo/subscriptions","organizations_url":"https://api.github.com/users/SteveLeafo/orgs","repos_url":"https://api.github.com/users/SteveLeafo/repos","events_url":"https://api.github.com/users/SteveLeafo/events{/privacy}","received_events_url":"https://api.github.com/users/SteveLeafo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SteveLeafo/decaf-emu","description":"Researching Wii U emulation.","fork":true,"url":"https://api.github.com/repos/SteveLeafo/decaf-emu","forks_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/forks","keys_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/teams","hooks_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/hooks","issue_events_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/issues/events{/number}","events_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/events","assignees_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/assignees{/user}","branches_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/branches{/branch}","tags_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/tags","blobs_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/languages","stargazers_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/stargazers","contributors_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/contributors","subscribers_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/subscribers","subscription_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/subscription","commits_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/contents/{+path}","compare_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/merges","archive_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/downloads","issues_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/issues{/number}","pulls_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/labels{/name}","releases_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/releases{/id}","deployments_url":"https://api.github.com/repos/SteveLeafo/decaf-emu/deployments","created_at":"2018-09-11T10:46:17Z","updated_at":"2018-12-02T01:34:43Z","pushed_at":"2018-12-02T01:34:41Z","git_url":"git://github.com/SteveLeafo/decaf-emu.git","ssh_url":"git@github.com:SteveLeafo/decaf-emu.git","clone_url":"https://github.com/SteveLeafo/decaf-emu.git","svn_url":"https://github.com/SteveLeafo/decaf-emu","homepage":null,"size":25335,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decaf-emu:master","ref":"master","sha":"d33c92f4a457fe05351c91e4f6a6cb2854e96d89","user":{"login":"decaf-emu","id":15236850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjM2ODUw","avatar_url":"https://avatars2.githubusercontent.com/u/15236850?v=4","gravatar_id":"","url":"https://api.github.com/users/decaf-emu","html_url":"https://github.com/decaf-emu","followers_url":"https://api.github.com/users/decaf-emu/followers","following_url":"https://api.github.com/users/decaf-emu/following{/other_user}","gists_url":"https://api.github.com/users/decaf-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/decaf-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decaf-emu/subscriptions","organizations_url":"https://api.github.com/users/decaf-emu/orgs","repos_url":"https://api.github.com/users/decaf-emu/repos","events_url":"https://api.github.com/users/decaf-emu/events{/privacy}","received_events_url":"https://api.github.com/users/decaf-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":35845931,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg0NTkzMQ==","name":"decaf-emu","full_name":"decaf-emu/decaf-emu","private":false,"owner":{"login":"decaf-emu","id":15236850,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjM2ODUw","avatar_url":"https://avatars2.githubusercontent.com/u/15236850?v=4","gravatar_id":"","url":"https://api.github.com/users/decaf-emu","html_url":"https://github.com/decaf-emu","followers_url":"https://api.github.com/users/decaf-emu/followers","following_url":"https://api.github.com/users/decaf-emu/following{/other_user}","gists_url":"https://api.github.com/users/decaf-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/decaf-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decaf-emu/subscriptions","organizations_url":"https://api.github.com/users/decaf-emu/orgs","repos_url":"https://api.github.com/users/decaf-emu/repos","events_url":"https://api.github.com/users/decaf-emu/events{/privacy}","received_events_url":"https://api.github.com/users/decaf-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decaf-emu/decaf-emu","description":"Researching Wii U emulation.","fork":false,"url":"https://api.github.com/repos/decaf-emu/decaf-emu","forks_url":"https://api.github.com/repos/decaf-emu/decaf-emu/forks","keys_url":"https://api.github.com/repos/decaf-emu/decaf-emu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decaf-emu/decaf-emu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decaf-emu/decaf-emu/teams","hooks_url":"https://api.github.com/repos/decaf-emu/decaf-emu/hooks","issue_events_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/events{/number}","events_url":"https://api.github.com/repos/decaf-emu/decaf-emu/events","assignees_url":"https://api.github.com/repos/decaf-emu/decaf-emu/assignees{/user}","branches_url":"https://api.github.com/repos/decaf-emu/decaf-emu/branches{/branch}","tags_url":"https://api.github.com/repos/decaf-emu/decaf-emu/tags","blobs_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/refs{/sha}","trees_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/{sha}","languages_url":"https://api.github.com/repos/decaf-emu/decaf-emu/languages","stargazers_url":"https://api.github.com/repos/decaf-emu/decaf-emu/stargazers","contributors_url":"https://api.github.com/repos/decaf-emu/decaf-emu/contributors","subscribers_url":"https://api.github.com/repos/decaf-emu/decaf-emu/subscribers","subscription_url":"https://api.github.com/repos/decaf-emu/decaf-emu/subscription","commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/commits{/sha}","git_commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/commits{/sha}","comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/comments{/number}","issue_comment_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/comments{/number}","contents_url":"https://api.github.com/repos/decaf-emu/decaf-emu/contents/{+path}","compare_url":"https://api.github.com/repos/decaf-emu/decaf-emu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decaf-emu/decaf-emu/merges","archive_url":"https://api.github.com/repos/decaf-emu/decaf-emu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decaf-emu/decaf-emu/downloads","issues_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues{/number}","pulls_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls{/number}","milestones_url":"https://api.github.com/repos/decaf-emu/decaf-emu/milestones{/number}","notifications_url":"https://api.github.com/repos/decaf-emu/decaf-emu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decaf-emu/decaf-emu/labels{/name}","releases_url":"https://api.github.com/repos/decaf-emu/decaf-emu/releases{/id}","deployments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/deployments","created_at":"2015-05-18T22:29:19Z","updated_at":"2018-11-30T21:42:19Z","pushed_at":"2018-12-02T23:32:25Z","git_url":"git://github.com/decaf-emu/decaf-emu.git","ssh_url":"git@github.com:decaf-emu/decaf-emu.git","clone_url":"https://github.com/decaf-emu/decaf-emu.git","svn_url":"https://github.com/decaf-emu/decaf-emu","homepage":null,"size":25159,"stargazers_count":737,"watchers_count":737,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":97,"open_issues":47,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497"},"html":{"href":"https://github.com/decaf-emu/decaf-emu/pull/497"},"issue":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/497"},"comments":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/ff0d28558b34f4680a0d72d92044995778f42d97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"baryluk"}}