{"action":"created","issue":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/2179","repository_url":"https://api.github.com/repos/tendermint/tendermint","labels_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179/labels{/name}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179/comments","events_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179/events","html_url":"https://github.com/tendermint/tendermint/pull/2179","id":348521976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODUzODIx","number":2179,"title":"Reduce Commit to Signatures and Timestamps","user":{"login":"jlandrews","id":20493822,"node_id":"MDQ6VXNlcjIwNDkzODIy","avatar_url":"https://avatars1.githubusercontent.com/u/20493822?v=4","gravatar_id":"","url":"https://api.github.com/users/jlandrews","html_url":"https://github.com/jlandrews","followers_url":"https://api.github.com/users/jlandrews/followers","following_url":"https://api.github.com/users/jlandrews/following{/other_user}","gists_url":"https://api.github.com/users/jlandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jlandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlandrews/subscriptions","organizations_url":"https://api.github.com/users/jlandrews/orgs","repos_url":"https://api.github.com/users/jlandrews/repos","events_url":"https://api.github.com/users/jlandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jlandrews/received_events","type":"User","site_admin":false},"labels":[{"id":1007048207,"node_id":"MDU6TGFiZWwxMDA3MDQ4MjA3","url":"https://api.github.com/repos/tendermint/tendermint/labels/breaking","name":"breaking","color":"b60205","default":false},{"id":795907908,"node_id":"MDU6TGFiZWw3OTU5MDc5MDg=","url":"https://api.github.com/repos/tendermint/tendermint/labels/consensus","name":"consensus","color":"fafad2","default":false},{"id":789775642,"node_id":"MDU6TGFiZWw3ODk3NzU2NDI=","url":"https://api.github.com/repos/tendermint/tendermint/labels/perf","name":"perf","color":"fafad2","default":false},{"id":1007052408,"node_id":"MDU6TGFiZWwxMDA3MDUyNDA4","url":"https://api.github.com/repos/tendermint/tendermint/labels/protocol","name":"protocol","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-07T23:28:20Z","updated_at":"2018-08-15T00:13:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2179","html_url":"https://github.com/tendermint/tendermint/pull/2179","diff_url":"https://github.com/tendermint/tendermint/pull/2179.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2179.patch"},"body":"<!-- Thanks for filing a PR! Before hitting the button, please check the following items.-->\r\nCloses #1648 \r\n* [x] Updated all relevant documentation in docs\r\n* [x] Updated all code comments where relevant\r\n* [x] Wrote tests\r\n* [x] Updated CHANGELOG_PENDING.md\r\n"},"comment":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/comments/413055322","html_url":"https://github.com/tendermint/tendermint/pull/2179#issuecomment-413055322","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179","id":413055322,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzA1NTMyMg==","user":{"login":"jlandrews","id":20493822,"node_id":"MDQ6VXNlcjIwNDkzODIy","avatar_url":"https://avatars1.githubusercontent.com/u/20493822?v=4","gravatar_id":"","url":"https://api.github.com/users/jlandrews","html_url":"https://github.com/jlandrews","followers_url":"https://api.github.com/users/jlandrews/followers","following_url":"https://api.github.com/users/jlandrews/following{/other_user}","gists_url":"https://api.github.com/users/jlandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jlandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlandrews/subscriptions","organizations_url":"https://api.github.com/users/jlandrews/orgs","repos_url":"https://api.github.com/users/jlandrews/repos","events_url":"https://api.github.com/users/jlandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jlandrews/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T00:13:23Z","updated_at":"2018-08-15T00:13:23Z","author_association":"CONTRIBUTOR","body":"Interesting problem I'm running into here... There's no way to find all the places that a `String()` function is being called from, since it's an implicit conversion. I've changed the method signatures and all the tests pass, but I'm sure there are places where blocks, votes or commits are being printed or logged that I can't find. It seems like the only option is to manually look through areas where those objects are being used and look for implicit conversions, or just not have the validator address in the string representation."}}
{"actor":{"display_login":"jlandrews"}}