{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/205292477","pull_request_review_id":140535581,"id":205292477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTI5MjQ3Nw==","diff_hunk":"@@ -2403,6 +2443,128 @@ ValueDecl::getFormalAccessScope(const DeclContext *useDC,\n   llvm_unreachable(\"unknown access level\");\n }\n \n+AccessScope\n+ValueDecl::getFormalAccessScope(const DeclContext *useDC,\n+                                bool treatUsableFromInlineAsPublic) const {\n+  return getAccessScopeForFormalAccess(this, getFormalAccess(), useDC,\n+                                       treatUsableFromInlineAsPublic);\n+}\n+\n+/// Checks if \\p VD may be used from \\p useDC, taking \\@testable imports into\n+/// account.\n+///\n+/// Whenever the enclosing context of \\p VD is usable from \\p useDC, this\n+/// should compute the same result as checkAccess, below, but more slowly.\n+///\n+/// See ValueDecl::isAccessibleFrom for a description of \\p forConformance.\n+static bool checkAccessUsingAccessScopes(const DeclContext *useDC,\n+                                         const ValueDecl *VD,\n+                                         AccessLevel access) {\n+  AccessScope accessScope =\n+      getAccessScopeForFormalAccess(VD, access, useDC,\n+                                    /*treatUsableFromInlineAsPublic*/false);\n+  return accessScope.getDeclContext() == useDC ||\n+         AccessScope(useDC).isChildOf(accessScope);\n+}\n+\n+/// Checks if \\p VD may be used from \\p useDC, taking \\@testable imports into\n+/// account.\n+///\n+/// When \\p access is the same as `VD->getFormalAccess()` and the enclosing\n+/// context of \\p VD is usable from \\p useDC, this ought to be the same as\n+/// getting the AccessScope for `VD` and checking if \\p useDC is within it.\n+/// However, there's a source compatibility hack around protocol extensions\n+/// that makes it not quite the same.\n+///\n+/// See ValueDecl::isAccessibleFrom for a description of \\p forConformance.\n+static bool checkAccess(const DeclContext *useDC, const ValueDecl *VD,\n+                        AccessLevel access, bool forConformance) {\n+  auto *sourceDC = VD->getDeclContext();\n+\n+  if (!forConformance) {\n+    if (auto *proto = sourceDC->getAsProtocolOrProtocolExtensionContext()) {\n+      // FIXME: Swift 4.1 allowed accessing protocol extension methods that were\n+      // marked 'public' if the protocol was '@_versioned' (now\n+      // '@usableFromInline'). Which works at the ABI level, so let's keep\n+      // supporting that here by explicitly checking for it.\n+      if (access == AccessLevel::Public) {\n+        assert(proto->getDeclContext()->isModuleScopeContext() &&","path":"lib/AST/Decl.cpp","position":201,"original_position":201,"commit_id":"cd22c5d546580b84ff636b74c243da1eb1a09835","original_commit_id":"cd22c5d546580b84ff636b74c243da1eb1a09835","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Uh, hm. I'll write a test for that, then (in a follow-up PR).","created_at":"2018-07-25T23:31:44Z","updated_at":"2018-07-25T23:31:45Z","html_url":"https://github.com/apple/swift/pull/18048#discussion_r205292477","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/18048","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/205292477"},"html":{"href":"https://github.com/apple/swift/pull/18048#discussion_r205292477"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/18048"}},"in_reply_to_id":205291519},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18048","id":202348539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzQ4NTM5","html_url":"https://github.com/apple/swift/pull/18048","diff_url":"https://github.com/apple/swift/pull/18048.diff","patch_url":"https://github.com/apple/swift/pull/18048.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18048","number":18048,"state":"open","locked":false,"title":"Limit ValueDecl::getFormalAccess and get rid of adjustAccessLevelForProtocolExtension","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Access scopes implement the correct language semantics, so make sure we're encouraging clients to use them. In the one case where we deliberately aren't doing so, make sure that *that* doesn't change semantics. Finally, in this push we can eliminate ValueDecl::adjustAccessLevelForProtocolExtension, though unfortunately not all of the underlying problems that originally made it necessary.\r\n\r\nThis net-added code but I promise it's a cleanup. Really.","created_at":"2018-07-18T18:58:31Z","updated_at":"2018-07-25T23:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb09135e496e4ef4e6a48b27115f63f8cd13f31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"graydon","id":14097,"node_id":"MDQ6VXNlcjE0MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18048/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18048/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18048/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/cd22c5d546580b84ff636b74c243da1eb1a09835","head":{"label":"jrose-apple:finding-ways-to-scope","ref":"finding-ways-to-scope","sha":"cd22c5d546580b84ff636b74c243da1eb1a09835","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"repo":{"id":47434397,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQzNDM5Nw==","name":"swift","full_name":"jrose-apple/swift","owner":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrose-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jrose-apple/swift","forks_url":"https://api.github.com/repos/jrose-apple/swift/forks","keys_url":"https://api.github.com/repos/jrose-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrose-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrose-apple/swift/teams","hooks_url":"https://api.github.com/repos/jrose-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/jrose-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jrose-apple/swift/events","assignees_url":"https://api.github.com/repos/jrose-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jrose-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jrose-apple/swift/tags","blobs_url":"https://api.github.com/repos/jrose-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrose-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrose-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrose-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrose-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jrose-apple/swift/languages","stargazers_url":"https://api.github.com/repos/jrose-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/jrose-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/jrose-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/jrose-apple/swift/subscription","commits_url":"https://api.github.com/repos/jrose-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrose-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrose-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrose-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrose-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jrose-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrose-apple/swift/merges","archive_url":"https://api.github.com/repos/jrose-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrose-apple/swift/downloads","issues_url":"https://api.github.com/repos/jrose-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jrose-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jrose-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jrose-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrose-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/jrose-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jrose-apple/swift/deployments","created_at":"2015-12-04T23:42:49Z","updated_at":"2017-08-31T16:24:50Z","pushed_at":"2018-07-25T22:01:27Z","git_url":"git://github.com/jrose-apple/swift.git","ssh_url":"git@github.com:jrose-apple/swift.git","clone_url":"https://github.com/jrose-apple/swift.git","svn_url":"https://github.com/jrose-apple/swift","homepage":"","size":293743,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"3d69741927085c2535f4f389f3887e17cbbc4781","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-25T22:54:07Z","pushed_at":"2018-07-25T23:30:25Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":317764,"stargazers_count":44650,"watchers_count":44650,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7040,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7040,"open_issues":371,"watchers":44650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18048"},"html":{"href":"https://github.com/apple/swift/pull/18048"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18048"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18048/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18048/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18048/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/cd22c5d546580b84ff636b74c243da1eb1a09835"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jrose-apple"}}