{"action":"closed","number":82,"pull_request":{"url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82","id":227478229,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDc4MjI5","html_url":"https://github.com/CumulusNetworks/ifupdown2/pull/82","diff_url":"https://github.com/CumulusNetworks/ifupdown2/pull/82.diff","patch_url":"https://github.com/CumulusNetworks/ifupdown2/pull/82.patch","issue_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/82","number":82,"state":"closed","locked":false,"title":"addons: address: Fix address check for pointopoint setups.","user":{"login":"BarbarossaTM","id":10324868,"node_id":"MDQ6VXNlcjEwMzI0ODY4","avatar_url":"https://avatars3.githubusercontent.com/u/10324868?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbarossaTM","html_url":"https://github.com/BarbarossaTM","followers_url":"https://api.github.com/users/BarbarossaTM/followers","following_url":"https://api.github.com/users/BarbarossaTM/following{/other_user}","gists_url":"https://api.github.com/users/BarbarossaTM/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbarossaTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbarossaTM/subscriptions","organizations_url":"https://api.github.com/users/BarbarossaTM/orgs","repos_url":"https://api.github.com/users/BarbarossaTM/repos","events_url":"https://api.github.com/users/BarbarossaTM/events{/privacy}","received_events_url":"https://api.github.com/users/BarbarossaTM/received_events","type":"User","site_admin":false},"body":"  In case of an IPv4 pointopoint setup like the following\r\n\r\n    auto eth0\r\n    iface eth0\r\n        address 10.0.0.1/32\r\n        pointopoint 10.1.2.3\r\n        gateway 10.1.2.3\r\n\r\n  the configuration would only be correct on the first configuration attemp\r\n  by ifupdown2 (read: after systemctl [re]start networking). After any ifup\r\n  or ifreload -a the default route would be gone rendering the host offline.\r\n\r\n  The problem is within an internal comparison between the configured IP on\r\n  the interface - read by iproute2 - and the one configured as iproute will\r\n  show a pointopoint address without a netmask, but the configuration holds\r\n  a /32 mask. This patch will ensure that every address read is represented\r\n  in CIDR notation to avoid this issue.\r\n\r\nSigned-off-by: Maximilian Wilhelm <max@sdn.clinic>","created_at":"2018-11-01T00:11:31Z","updated_at":"2018-11-01T18:53:04Z","closed_at":"2018-11-01T18:53:04Z","merged_at":"2018-11-01T18:53:04Z","merge_commit_sha":"f8f8cba7c269185a7ce1c0ee6a5a20a7bd263037","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82/commits","review_comments_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82/comments","review_comment_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/82/comments","statuses_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/statuses/d37f0d0e41717bd2eecb8cbff5723358f9c9692f","head":{"label":"BarbarossaTM:ptp-gw-fix","ref":"ptp-gw-fix","sha":"d37f0d0e41717bd2eecb8cbff5723358f9c9692f","user":{"login":"BarbarossaTM","id":10324868,"node_id":"MDQ6VXNlcjEwMzI0ODY4","avatar_url":"https://avatars3.githubusercontent.com/u/10324868?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbarossaTM","html_url":"https://github.com/BarbarossaTM","followers_url":"https://api.github.com/users/BarbarossaTM/followers","following_url":"https://api.github.com/users/BarbarossaTM/following{/other_user}","gists_url":"https://api.github.com/users/BarbarossaTM/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbarossaTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbarossaTM/subscriptions","organizations_url":"https://api.github.com/users/BarbarossaTM/orgs","repos_url":"https://api.github.com/users/BarbarossaTM/repos","events_url":"https://api.github.com/users/BarbarossaTM/events{/privacy}","received_events_url":"https://api.github.com/users/BarbarossaTM/received_events","type":"User","site_admin":false},"repo":{"id":61153615,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzYxNQ==","name":"ifupdown2","full_name":"BarbarossaTM/ifupdown2","private":false,"owner":{"login":"BarbarossaTM","id":10324868,"node_id":"MDQ6VXNlcjEwMzI0ODY4","avatar_url":"https://avatars3.githubusercontent.com/u/10324868?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbarossaTM","html_url":"https://github.com/BarbarossaTM","followers_url":"https://api.github.com/users/BarbarossaTM/followers","following_url":"https://api.github.com/users/BarbarossaTM/following{/other_user}","gists_url":"https://api.github.com/users/BarbarossaTM/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbarossaTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbarossaTM/subscriptions","organizations_url":"https://api.github.com/users/BarbarossaTM/orgs","repos_url":"https://api.github.com/users/BarbarossaTM/repos","events_url":"https://api.github.com/users/BarbarossaTM/events{/privacy}","received_events_url":"https://api.github.com/users/BarbarossaTM/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BarbarossaTM/ifupdown2","description":null,"fork":true,"url":"https://api.github.com/repos/BarbarossaTM/ifupdown2","forks_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/forks","keys_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/teams","hooks_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/hooks","issue_events_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/issues/events{/number}","events_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/events","assignees_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/assignees{/user}","branches_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/branches{/branch}","tags_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/tags","blobs_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/git/refs{/sha}","trees_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/statuses/{sha}","languages_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/languages","stargazers_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/stargazers","contributors_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/contributors","subscribers_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/subscribers","subscription_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/subscription","commits_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/commits{/sha}","git_commits_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/git/commits{/sha}","comments_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/comments{/number}","issue_comment_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/issues/comments{/number}","contents_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/contents/{+path}","compare_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/merges","archive_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/downloads","issues_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/issues{/number}","pulls_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/pulls{/number}","milestones_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/milestones{/number}","notifications_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/labels{/name}","releases_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/releases{/id}","deployments_url":"https://api.github.com/repos/BarbarossaTM/ifupdown2/deployments","created_at":"2016-06-14T20:28:50Z","updated_at":"2016-06-14T20:28:51Z","pushed_at":"2018-11-01T00:09:42Z","git_url":"git://github.com/BarbarossaTM/ifupdown2.git","ssh_url":"git@github.com:BarbarossaTM/ifupdown2.git","clone_url":"https://github.com/BarbarossaTM/ifupdown2.git","svn_url":"https://github.com/BarbarossaTM/ifupdown2","homepage":null,"size":1753,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CumulusNetworks:debian-prep2","ref":"debian-prep2","sha":"22ba670e638d073ea6f8f52d8ca37d6da0eaeebe","user":{"login":"CumulusNetworks","id":4306877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDY4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/4306877?v=4","gravatar_id":"","url":"https://api.github.com/users/CumulusNetworks","html_url":"https://github.com/CumulusNetworks","followers_url":"https://api.github.com/users/CumulusNetworks/followers","following_url":"https://api.github.com/users/CumulusNetworks/following{/other_user}","gists_url":"https://api.github.com/users/CumulusNetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/CumulusNetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CumulusNetworks/subscriptions","organizations_url":"https://api.github.com/users/CumulusNetworks/orgs","repos_url":"https://api.github.com/users/CumulusNetworks/repos","events_url":"https://api.github.com/users/CumulusNetworks/events{/privacy}","received_events_url":"https://api.github.com/users/CumulusNetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":22025555,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAyNTU1NQ==","name":"ifupdown2","full_name":"CumulusNetworks/ifupdown2","private":false,"owner":{"login":"CumulusNetworks","id":4306877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDY4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/4306877?v=4","gravatar_id":"","url":"https://api.github.com/users/CumulusNetworks","html_url":"https://github.com/CumulusNetworks","followers_url":"https://api.github.com/users/CumulusNetworks/followers","following_url":"https://api.github.com/users/CumulusNetworks/following{/other_user}","gists_url":"https://api.github.com/users/CumulusNetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/CumulusNetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CumulusNetworks/subscriptions","organizations_url":"https://api.github.com/users/CumulusNetworks/orgs","repos_url":"https://api.github.com/users/CumulusNetworks/repos","events_url":"https://api.github.com/users/CumulusNetworks/events{/privacy}","received_events_url":"https://api.github.com/users/CumulusNetworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CumulusNetworks/ifupdown2","description":null,"fork":false,"url":"https://api.github.com/repos/CumulusNetworks/ifupdown2","forks_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/forks","keys_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/teams","hooks_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/hooks","issue_events_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/events{/number}","events_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/events","assignees_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/assignees{/user}","branches_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/branches{/branch}","tags_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/tags","blobs_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/git/refs{/sha}","trees_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/statuses/{sha}","languages_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/languages","stargazers_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/stargazers","contributors_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/contributors","subscribers_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/subscribers","subscription_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/subscription","commits_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/commits{/sha}","git_commits_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/git/commits{/sha}","comments_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/comments{/number}","issue_comment_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/comments{/number}","contents_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/contents/{+path}","compare_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/merges","archive_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/downloads","issues_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues{/number}","pulls_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls{/number}","milestones_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/milestones{/number}","notifications_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/labels{/name}","releases_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/releases{/id}","deployments_url":"https://api.github.com/repos/CumulusNetworks/ifupdown2/deployments","created_at":"2014-07-20T04:03:25Z","updated_at":"2018-10-30T11:17:59Z","pushed_at":"2018-11-01T18:53:04Z","git_url":"git://github.com/CumulusNetworks/ifupdown2.git","ssh_url":"git@github.com:CumulusNetworks/ifupdown2.git","clone_url":"https://github.com/CumulusNetworks/ifupdown2.git","svn_url":"https://github.com/CumulusNetworks/ifupdown2","homepage":null,"size":2683,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":20,"open_issues":20,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82"},"html":{"href":"https://github.com/CumulusNetworks/ifupdown2/pull/82"},"issue":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/82"},"comments":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/CumulusNetworks/ifupdown2/statuses/d37f0d0e41717bd2eecb8cbff5723358f9c9692f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"julienfortin","id":1872075,"node_id":"MDQ6VXNlcjE4NzIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1872075?v=4","gravatar_id":"","url":"https://api.github.com/users/julienfortin","html_url":"https://github.com/julienfortin","followers_url":"https://api.github.com/users/julienfortin/followers","following_url":"https://api.github.com/users/julienfortin/following{/other_user}","gists_url":"https://api.github.com/users/julienfortin/gists{/gist_id}","starred_url":"https://api.github.com/users/julienfortin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienfortin/subscriptions","organizations_url":"https://api.github.com/users/julienfortin/orgs","repos_url":"https://api.github.com/users/julienfortin/repos","events_url":"https://api.github.com/users/julienfortin/events{/privacy}","received_events_url":"https://api.github.com/users/julienfortin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"julienfortin"}}