{"action":"created","issue":{"url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/124","repository_url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl","labels_url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/124/comments","events_url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/124/events","html_url":"https://github.com/GUI/lua-resty-auto-ssl/pull/124","id":315642224,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNjAyODY2","number":124,"title":"Don't store cert backups","user":{"login":"gohai","id":4945451,"node_id":"MDQ6VXNlcjQ5NDU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4945451?v=4","gravatar_id":"","url":"https://api.github.com/users/gohai","html_url":"https://github.com/gohai","followers_url":"https://api.github.com/users/gohai/followers","following_url":"https://api.github.com/users/gohai/following{/other_user}","gists_url":"https://api.github.com/users/gohai/gists{/gist_id}","starred_url":"https://api.github.com/users/gohai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohai/subscriptions","organizations_url":"https://api.github.com/users/gohai/orgs","repos_url":"https://api.github.com/users/gohai/repos","events_url":"https://api.github.com/users/gohai/events{/privacy}","received_events_url":"https://api.github.com/users/gohai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-18T21:05:28Z","updated_at":"2018-06-07T17:41:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/pulls/124","html_url":"https://github.com/GUI/lua-resty-auto-ssl/pull/124","diff_url":"https://github.com/GUI/lua-resty-auto-ssl/pull/124.diff","patch_url":"https://github.com/GUI/lua-resty-auto-ssl/pull/124.patch"},"body":"Those are inconvenient if you don't want to run Redis as LRU cache. We are more interested in not silently discarding any certificates, and scaling Redis with increasing number of domains, so we don't.\r\n\r\nIf this change is not acceptable, another scheme could be to store the previous (\":old\") certificate in addition to the current one (\":latest\"). This way we'd only be storing at most two certificates per domain in Redis, and not a growing number due to renewals."},"comment":{"url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/comments/395505603","html_url":"https://github.com/GUI/lua-resty-auto-ssl/pull/124#issuecomment-395505603","issue_url":"https://api.github.com/repos/GUI/lua-resty-auto-ssl/issues/124","id":395505603,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTUwNTYwMw==","user":{"login":"bacheson","id":9341738,"node_id":"MDQ6VXNlcjkzNDE3Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9341738?v=4","gravatar_id":"","url":"https://api.github.com/users/bacheson","html_url":"https://github.com/bacheson","followers_url":"https://api.github.com/users/bacheson/followers","following_url":"https://api.github.com/users/bacheson/following{/other_user}","gists_url":"https://api.github.com/users/bacheson/gists{/gist_id}","starred_url":"https://api.github.com/users/bacheson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacheson/subscriptions","organizations_url":"https://api.github.com/users/bacheson/orgs","repos_url":"https://api.github.com/users/bacheson/repos","events_url":"https://api.github.com/users/bacheson/events{/privacy}","received_events_url":"https://api.github.com/users/bacheson/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T17:41:55Z","updated_at":"2018-06-07T17:41:55Z","author_association":"NONE","body":"I have 800mb of certs clogging a redis instance....I'd love to see the keep_previous_certs setting make it to the next release "}}
{"actor":{"display_login":"bacheson"}}