{"action":"closed","number":1126,"pull_request":{"url":"https://api.github.com/repos/developit/preact/pulls/1126","id":191250004,"html_url":"https://github.com/developit/preact/pull/1126","diff_url":"https://github.com/developit/preact/pull/1126.diff","patch_url":"https://github.com/developit/preact/pull/1126.patch","issue_url":"https://api.github.com/repos/developit/preact/issues/1126","number":1126,"state":"closed","locked":false,"title":"Fixing master build on Travis","user":{"login":"mkxml","id":1051644,"avatar_url":"https://avatars2.githubusercontent.com/u/1051644?v=4","gravatar_id":"","url":"https://api.github.com/users/mkxml","html_url":"https://github.com/mkxml","followers_url":"https://api.github.com/users/mkxml/followers","following_url":"https://api.github.com/users/mkxml/following{/other_user}","gists_url":"https://api.github.com/users/mkxml/gists{/gist_id}","starred_url":"https://api.github.com/users/mkxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkxml/subscriptions","organizations_url":"https://api.github.com/users/mkxml/orgs","repos_url":"https://api.github.com/users/mkxml/repos","events_url":"https://api.github.com/users/mkxml/events{/privacy}","received_events_url":"https://api.github.com/users/mkxml/received_events","type":"User","site_admin":false},"body":"This PR relates to #1038.\r\n\r\nBasically what we are doing here is switching to IE11 on Windows 7, which oddly greens the problematic empty node test that is currently not passing on IE11 Windows 10 on Sauce Labs for no apparent reason.\r\n\r\nLocally all IE11 versions work, Windows 10 included. It must be some env bug in Sauce Labs.\r\n\r\nThis PR also changes the way we connect to Sauce Labs, now leveraging the tunnel created by Travis Sauce Connect addon. Now sending all the relevant info (tunneldentifier, buildNumber, etc). This should fix the errors we saw on #1089.\r\n\r\nThe base code of this PR was tested in `sauce-test` branch, logs from Travis (https://travis-ci.org/developit/preact/builds) and Sauce Labs (https://saucelabs.com/u/preact) from those tests appear OK.\r\n\r\nFinally, this PR prepares the ground for #1124, which aims to test multiple node versions on Travis.\r\n\r\nPlease let me know if this looks good 😄 ","created_at":"2018-05-29T19:42:43Z","updated_at":"2018-05-29T21:36:22Z","closed_at":"2018-05-29T21:36:22Z","merged_at":"2018-05-29T21:36:22Z","merge_commit_sha":"2364da58142af4630e606b19936ae36aea71901f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491773363,"url":"https://api.github.com/repos/developit/preact/labels/builds","name":"builds","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/developit/preact/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/developit/preact/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/developit/preact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/developit/preact/issues/1126/comments","statuses_url":"https://api.github.com/repos/developit/preact/statuses/7686475ccc55a39994e3dcdd9c89306c334a30ef","head":{"label":"mkxml:master","ref":"master","sha":"7686475ccc55a39994e3dcdd9c89306c334a30ef","user":{"login":"mkxml","id":1051644,"avatar_url":"https://avatars2.githubusercontent.com/u/1051644?v=4","gravatar_id":"","url":"https://api.github.com/users/mkxml","html_url":"https://github.com/mkxml","followers_url":"https://api.github.com/users/mkxml/followers","following_url":"https://api.github.com/users/mkxml/following{/other_user}","gists_url":"https://api.github.com/users/mkxml/gists{/gist_id}","starred_url":"https://api.github.com/users/mkxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkxml/subscriptions","organizations_url":"https://api.github.com/users/mkxml/orgs","repos_url":"https://api.github.com/users/mkxml/repos","events_url":"https://api.github.com/users/mkxml/events{/privacy}","received_events_url":"https://api.github.com/users/mkxml/received_events","type":"User","site_admin":false},"repo":{"id":72860929,"name":"preact","full_name":"mkxml/preact","owner":{"login":"mkxml","id":1051644,"avatar_url":"https://avatars2.githubusercontent.com/u/1051644?v=4","gravatar_id":"","url":"https://api.github.com/users/mkxml","html_url":"https://github.com/mkxml","followers_url":"https://api.github.com/users/mkxml/followers","following_url":"https://api.github.com/users/mkxml/following{/other_user}","gists_url":"https://api.github.com/users/mkxml/gists{/gist_id}","starred_url":"https://api.github.com/users/mkxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkxml/subscriptions","organizations_url":"https://api.github.com/users/mkxml/orgs","repos_url":"https://api.github.com/users/mkxml/repos","events_url":"https://api.github.com/users/mkxml/events{/privacy}","received_events_url":"https://api.github.com/users/mkxml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkxml/preact","description":":zap: Fast 3kb React alternative with the same ES6 API. Components & Virtual DOM.","fork":true,"url":"https://api.github.com/repos/mkxml/preact","forks_url":"https://api.github.com/repos/mkxml/preact/forks","keys_url":"https://api.github.com/repos/mkxml/preact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkxml/preact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkxml/preact/teams","hooks_url":"https://api.github.com/repos/mkxml/preact/hooks","issue_events_url":"https://api.github.com/repos/mkxml/preact/issues/events{/number}","events_url":"https://api.github.com/repos/mkxml/preact/events","assignees_url":"https://api.github.com/repos/mkxml/preact/assignees{/user}","branches_url":"https://api.github.com/repos/mkxml/preact/branches{/branch}","tags_url":"https://api.github.com/repos/mkxml/preact/tags","blobs_url":"https://api.github.com/repos/mkxml/preact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkxml/preact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkxml/preact/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkxml/preact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkxml/preact/statuses/{sha}","languages_url":"https://api.github.com/repos/mkxml/preact/languages","stargazers_url":"https://api.github.com/repos/mkxml/preact/stargazers","contributors_url":"https://api.github.com/repos/mkxml/preact/contributors","subscribers_url":"https://api.github.com/repos/mkxml/preact/subscribers","subscription_url":"https://api.github.com/repos/mkxml/preact/subscription","commits_url":"https://api.github.com/repos/mkxml/preact/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkxml/preact/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkxml/preact/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkxml/preact/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkxml/preact/contents/{+path}","compare_url":"https://api.github.com/repos/mkxml/preact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkxml/preact/merges","archive_url":"https://api.github.com/repos/mkxml/preact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkxml/preact/downloads","issues_url":"https://api.github.com/repos/mkxml/preact/issues{/number}","pulls_url":"https://api.github.com/repos/mkxml/preact/pulls{/number}","milestones_url":"https://api.github.com/repos/mkxml/preact/milestones{/number}","notifications_url":"https://api.github.com/repos/mkxml/preact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkxml/preact/labels{/name}","releases_url":"https://api.github.com/repos/mkxml/preact/releases{/id}","deployments_url":"https://api.github.com/repos/mkxml/preact/deployments","created_at":"2016-11-04T15:36:29Z","updated_at":"2018-05-29T19:20:23Z","pushed_at":"2018-05-29T19:20:22Z","git_url":"git://github.com/mkxml/preact.git","ssh_url":"git@github.com:mkxml/preact.git","clone_url":"https://github.com/mkxml/preact.git","svn_url":"https://github.com/mkxml/preact","homepage":"https://preactjs.com","size":1250,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"developit:master","ref":"master","sha":"cd422d047f6d21607ff980c84b9c4ac1845ca798","user":{"login":"developit","id":105127,"avatar_url":"https://avatars2.githubusercontent.com/u/105127?v=4","gravatar_id":"","url":"https://api.github.com/users/developit","html_url":"https://github.com/developit","followers_url":"https://api.github.com/users/developit/followers","following_url":"https://api.github.com/users/developit/following{/other_user}","gists_url":"https://api.github.com/users/developit/gists{/gist_id}","starred_url":"https://api.github.com/users/developit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developit/subscriptions","organizations_url":"https://api.github.com/users/developit/orgs","repos_url":"https://api.github.com/users/developit/repos","events_url":"https://api.github.com/users/developit/events{/privacy}","received_events_url":"https://api.github.com/users/developit/received_events","type":"User","site_admin":false},"repo":{"id":42283287,"name":"preact","full_name":"developit/preact","owner":{"login":"developit","id":105127,"avatar_url":"https://avatars2.githubusercontent.com/u/105127?v=4","gravatar_id":"","url":"https://api.github.com/users/developit","html_url":"https://github.com/developit","followers_url":"https://api.github.com/users/developit/followers","following_url":"https://api.github.com/users/developit/following{/other_user}","gists_url":"https://api.github.com/users/developit/gists{/gist_id}","starred_url":"https://api.github.com/users/developit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developit/subscriptions","organizations_url":"https://api.github.com/users/developit/orgs","repos_url":"https://api.github.com/users/developit/repos","events_url":"https://api.github.com/users/developit/events{/privacy}","received_events_url":"https://api.github.com/users/developit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/developit/preact","description":"⚛️ Fast 3kB React alternative with the same modern API. Components & Virtual DOM.","fork":false,"url":"https://api.github.com/repos/developit/preact","forks_url":"https://api.github.com/repos/developit/preact/forks","keys_url":"https://api.github.com/repos/developit/preact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/developit/preact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/developit/preact/teams","hooks_url":"https://api.github.com/repos/developit/preact/hooks","issue_events_url":"https://api.github.com/repos/developit/preact/issues/events{/number}","events_url":"https://api.github.com/repos/developit/preact/events","assignees_url":"https://api.github.com/repos/developit/preact/assignees{/user}","branches_url":"https://api.github.com/repos/developit/preact/branches{/branch}","tags_url":"https://api.github.com/repos/developit/preact/tags","blobs_url":"https://api.github.com/repos/developit/preact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/developit/preact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/developit/preact/git/refs{/sha}","trees_url":"https://api.github.com/repos/developit/preact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/developit/preact/statuses/{sha}","languages_url":"https://api.github.com/repos/developit/preact/languages","stargazers_url":"https://api.github.com/repos/developit/preact/stargazers","contributors_url":"https://api.github.com/repos/developit/preact/contributors","subscribers_url":"https://api.github.com/repos/developit/preact/subscribers","subscription_url":"https://api.github.com/repos/developit/preact/subscription","commits_url":"https://api.github.com/repos/developit/preact/commits{/sha}","git_commits_url":"https://api.github.com/repos/developit/preact/git/commits{/sha}","comments_url":"https://api.github.com/repos/developit/preact/comments{/number}","issue_comment_url":"https://api.github.com/repos/developit/preact/issues/comments{/number}","contents_url":"https://api.github.com/repos/developit/preact/contents/{+path}","compare_url":"https://api.github.com/repos/developit/preact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/developit/preact/merges","archive_url":"https://api.github.com/repos/developit/preact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/developit/preact/downloads","issues_url":"https://api.github.com/repos/developit/preact/issues{/number}","pulls_url":"https://api.github.com/repos/developit/preact/pulls{/number}","milestones_url":"https://api.github.com/repos/developit/preact/milestones{/number}","notifications_url":"https://api.github.com/repos/developit/preact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/developit/preact/labels{/name}","releases_url":"https://api.github.com/repos/developit/preact/releases{/id}","deployments_url":"https://api.github.com/repos/developit/preact/deployments","created_at":"2015-09-11T02:40:18Z","updated_at":"2018-05-29T21:34:40Z","pushed_at":"2018-05-29T21:36:21Z","git_url":"git://github.com/developit/preact.git","ssh_url":"git@github.com:developit/preact.git","clone_url":"https://github.com/developit/preact.git","svn_url":"https://github.com/developit/preact","homepage":"https://preactjs.com","size":1294,"stargazers_count":18904,"watchers_count":18904,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":934,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":934,"open_issues":169,"watchers":18904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/developit/preact/pulls/1126"},"html":{"href":"https://github.com/developit/preact/pull/1126"},"issue":{"href":"https://api.github.com/repos/developit/preact/issues/1126"},"comments":{"href":"https://api.github.com/repos/developit/preact/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/developit/preact/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/developit/preact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/developit/preact/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/developit/preact/statuses/7686475ccc55a39994e3dcdd9c89306c334a30ef"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mkxml","id":1051644,"avatar_url":"https://avatars2.githubusercontent.com/u/1051644?v=4","gravatar_id":"","url":"https://api.github.com/users/mkxml","html_url":"https://github.com/mkxml","followers_url":"https://api.github.com/users/mkxml/followers","following_url":"https://api.github.com/users/mkxml/following{/other_user}","gists_url":"https://api.github.com/users/mkxml/gists{/gist_id}","starred_url":"https://api.github.com/users/mkxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkxml/subscriptions","organizations_url":"https://api.github.com/users/mkxml/orgs","repos_url":"https://api.github.com/users/mkxml/repos","events_url":"https://api.github.com/users/mkxml/events{/privacy}","received_events_url":"https://api.github.com/users/mkxml/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":20,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"mkxml"}}