{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments/221077247","pull_request_review_id":159641640,"id":221077247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTA3NzI0Nw==","diff_hunk":"@@ -1,19 +1,4 @@\n module.exports = {\n+  // DEPRECATED: plugin:shopify/prettier is sufficient now\n   extends: ['plugin:shopify/prettier'],\n-\n-  rules: {\n-    // rules to disable to prefer prettier\n-    'typescript/member-delimiter-style': 'off',","path":"lib/config/typescript-prettier.js","position":8,"original_position":7,"commit_id":"4fe4585365b1a91f9bfedfd3beccf15ad68a526d","original_commit_id":"d4d43915bdbea69585db3f26a8a1dcaf2cd7d433","user":{"login":"BPScott","id":227292,"node_id":"MDQ6VXNlcjIyNzI5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/227292?v=4","gravatar_id":"","url":"https://api.github.com/users/BPScott","html_url":"https://github.com/BPScott","followers_url":"https://api.github.com/users/BPScott/followers","following_url":"https://api.github.com/users/BPScott/following{/other_user}","gists_url":"https://api.github.com/users/BPScott/gists{/gist_id}","starred_url":"https://api.github.com/users/BPScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BPScott/subscriptions","organizations_url":"https://api.github.com/users/BPScott/orgs","repos_url":"https://api.github.com/users/BPScott/repos","events_url":"https://api.github.com/users/BPScott/events{/privacy}","received_events_url":"https://api.github.com/users/BPScott/received_events","type":"User","site_admin":false},"body":"The typescript ruleset [configures \"typescript/member-delimiter-style\"](https://github.com/Shopify/eslint-plugin-shopify/blob/4fe4585365b1a91f9bfedfd3beccf15ad68a526d/lib/config/rules/typescript.js#L87). When using prettier, we want to disable that eslint rule, and instead trust whatever prettier outputs.","created_at":"2018-09-27T21:06:42Z","updated_at":"2018-09-27T21:06:42Z","html_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/173#discussion_r221077247","pull_request_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments/221077247"},"html":{"href":"https://github.com/Shopify/eslint-plugin-shopify/pull/173#discussion_r221077247"},"pull_request":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173"}},"in_reply_to_id":220777577},"pull_request":{"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173","id":218498666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDk4NjY2","html_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/173","diff_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/173.diff","patch_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/173.patch","issue_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/173","number":173,"state":"open","locked":false,"title":"[WIP] updating prettier and react configs","user":{"login":"patsissons","id":5505280,"node_id":"MDQ6VXNlcjU1MDUyODA=","avatar_url":"https://avatars1.githubusercontent.com/u/5505280?v=4","gravatar_id":"","url":"https://api.github.com/users/patsissons","html_url":"https://github.com/patsissons","followers_url":"https://api.github.com/users/patsissons/followers","following_url":"https://api.github.com/users/patsissons/following{/other_user}","gists_url":"https://api.github.com/users/patsissons/gists{/gist_id}","starred_url":"https://api.github.com/users/patsissons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patsissons/subscriptions","organizations_url":"https://api.github.com/users/patsissons/orgs","repos_url":"https://api.github.com/users/patsissons/repos","events_url":"https://api.github.com/users/patsissons/events{/privacy}","received_events_url":"https://api.github.com/users/patsissons/received_events","type":"User","site_admin":false},"body":"This PR deprecates `plugin:shopify/typescript-prettier` and `plugin:shopify/typescript-react` in favour of using overrides in `plugin:shopify/prettier` and `plugin:shopify/react` respectively. We may want to split up the `react` and `prettier` adjustments into separate PR's.\r\n\r\n`prettier` (and related tooling) is also getting an upgrade. this may not be necessary, I would like to do some more testing around what is necessary.","created_at":"2018-09-27T01:26:31Z","updated_at":"2018-09-27T21:06:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff1e6978cac4839e09dc47e23f707f99ec55826","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173/commits","review_comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173/comments","review_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/173/comments","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/4fe4585365b1a91f9bfedfd3beccf15ad68a526d","head":{"label":"Shopify:config-overrides","ref":"config-overrides","sha":"4fe4585365b1a91f9bfedfd3beccf15ad68a526d","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":78081495,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4MTQ5NQ==","name":"eslint-plugin-shopify","full_name":"Shopify/eslint-plugin-shopify","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/eslint-plugin-shopify","description":"Shopify’s ESLint rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify","forks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/deployments","created_at":"2017-01-05T05:11:19Z","updated_at":"2018-09-26T19:23:31Z","pushed_at":"2018-09-27T20:44:25Z","git_url":"git://github.com/Shopify/eslint-plugin-shopify.git","ssh_url":"git@github.com:Shopify/eslint-plugin-shopify.git","clone_url":"https://github.com/Shopify/eslint-plugin-shopify.git","svn_url":"https://github.com/Shopify/eslint-plugin-shopify","homepage":null,"size":852,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":8,"open_issues":47,"watchers":30,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"8586af3e38aa4fe8ef3af81b263bfac8f00a764b","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":78081495,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4MTQ5NQ==","name":"eslint-plugin-shopify","full_name":"Shopify/eslint-plugin-shopify","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/eslint-plugin-shopify","description":"Shopify’s ESLint rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify","forks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/deployments","created_at":"2017-01-05T05:11:19Z","updated_at":"2018-09-26T19:23:31Z","pushed_at":"2018-09-27T20:44:25Z","git_url":"git://github.com/Shopify/eslint-plugin-shopify.git","ssh_url":"git@github.com:Shopify/eslint-plugin-shopify.git","clone_url":"https://github.com/Shopify/eslint-plugin-shopify.git","svn_url":"https://github.com/Shopify/eslint-plugin-shopify","homepage":null,"size":852,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":8,"open_issues":47,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173"},"html":{"href":"https://github.com/Shopify/eslint-plugin-shopify/pull/173"},"issue":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/173"},"comments":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/4fe4585365b1a91f9bfedfd3beccf15ad68a526d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BPScott"}}