{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/229943007","pull_request_review_id":170561034,"id":229943007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTk0MzAwNw==","diff_hunk":"@@ -41,19 +41,19 @@ echo \"Flink distribution directory: $FLINK_DIR\"\n \n # Template for adding a test:\n \n-# run_test \"<description>\" \"$END_TO_END_DIR/test-scripts/<script_name>\"\n+# run_test \"<description>\" \"$END_TO_END_DIR/test-scripts/<script_name>\" [\"skip_check_exceptions\"]","path":"flink-end-to-end-tests/run-nightly-tests.sh","position":5,"original_position":5,"commit_id":"fe986e39c4007c99bcfa58636f5ec8076261706b","original_commit_id":"fe986e39c4007c99bcfa58636f5ec8076261706b","user":{"login":"tzulitai","id":5284370,"node_id":"MDQ6VXNlcjUyODQzNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/5284370?v=4","gravatar_id":"","url":"https://api.github.com/users/tzulitai","html_url":"https://github.com/tzulitai","followers_url":"https://api.github.com/users/tzulitai/followers","following_url":"https://api.github.com/users/tzulitai/following{/other_user}","gists_url":"https://api.github.com/users/tzulitai/gists{/gist_id}","starred_url":"https://api.github.com/users/tzulitai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzulitai/subscriptions","organizations_url":"https://api.github.com/users/tzulitai/orgs","repos_url":"https://api.github.com/users/tzulitai/repos","events_url":"https://api.github.com/users/tzulitai/events{/privacy}","received_events_url":"https://api.github.com/users/tzulitai/received_events","type":"User","site_admin":false},"body":"I think we should add at least comments about what the consequences are for skipping the exceptions check / in what situations you would want to skip exception checking completely.","created_at":"2018-11-01T05:28:30Z","updated_at":"2018-11-01T05:28:30Z","html_url":"https://github.com/apache/flink/pull/6959#discussion_r229943007","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6959","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/229943007"},"html":{"href":"https://github.com/apache/flink/pull/6959#discussion_r229943007"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6959"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6959","id":226529395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTI5Mzk1","html_url":"https://github.com/apache/flink/pull/6959","diff_url":"https://github.com/apache/flink/pull/6959.diff","patch_url":"https://github.com/apache/flink/pull/6959.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6959","number":6959,"state":"open","locked":false,"title":"[FLINK-10678][e2e] Introduced switch to disable log checking in e2e tests","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"body":"Added flag to disable logs/output files checking for errors/exceptions.","created_at":"2018-10-29T11:45:41Z","updated_at":"2018-11-01T05:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b33ade73398e00ee2145c89999ad3e61ebe810a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6959/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6959/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6959/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/fe986e39c4007c99bcfa58636f5ec8076261706b","head":{"label":"dawidwys:flink10678","ref":"flink10678","sha":"fe986e39c4007c99bcfa58636f5ec8076261706b","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"repo":{"id":43764900,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2NDkwMA==","name":"flink","full_name":"dawidwys/flink","private":false,"owner":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dawidwys/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/dawidwys/flink","forks_url":"https://api.github.com/repos/dawidwys/flink/forks","keys_url":"https://api.github.com/repos/dawidwys/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dawidwys/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dawidwys/flink/teams","hooks_url":"https://api.github.com/repos/dawidwys/flink/hooks","issue_events_url":"https://api.github.com/repos/dawidwys/flink/issues/events{/number}","events_url":"https://api.github.com/repos/dawidwys/flink/events","assignees_url":"https://api.github.com/repos/dawidwys/flink/assignees{/user}","branches_url":"https://api.github.com/repos/dawidwys/flink/branches{/branch}","tags_url":"https://api.github.com/repos/dawidwys/flink/tags","blobs_url":"https://api.github.com/repos/dawidwys/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dawidwys/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dawidwys/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/dawidwys/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dawidwys/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/dawidwys/flink/languages","stargazers_url":"https://api.github.com/repos/dawidwys/flink/stargazers","contributors_url":"https://api.github.com/repos/dawidwys/flink/contributors","subscribers_url":"https://api.github.com/repos/dawidwys/flink/subscribers","subscription_url":"https://api.github.com/repos/dawidwys/flink/subscription","commits_url":"https://api.github.com/repos/dawidwys/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/dawidwys/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/dawidwys/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/dawidwys/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/dawidwys/flink/contents/{+path}","compare_url":"https://api.github.com/repos/dawidwys/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dawidwys/flink/merges","archive_url":"https://api.github.com/repos/dawidwys/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dawidwys/flink/downloads","issues_url":"https://api.github.com/repos/dawidwys/flink/issues{/number}","pulls_url":"https://api.github.com/repos/dawidwys/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/dawidwys/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/dawidwys/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dawidwys/flink/labels{/name}","releases_url":"https://api.github.com/repos/dawidwys/flink/releases{/id}","deployments_url":"https://api.github.com/repos/dawidwys/flink/deployments","created_at":"2015-10-06T17:01:12Z","updated_at":"2018-10-04T07:46:10Z","pushed_at":"2018-10-31T10:44:32Z","git_url":"git://github.com/dawidwys/flink.git","ssh_url":"git@github.com:dawidwys/flink.git","clone_url":"https://github.com/dawidwys/flink.git","svn_url":"https://github.com/dawidwys/flink","homepage":null,"size":163594,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"62ecdb3ca6c0d47a0a96d55df683fd3ea27de39a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-11-01T03:44:18Z","pushed_at":"2018-11-01T05:02:39Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":169057,"stargazers_count":4775,"watchers_count":4775,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3055,"mirror_url":null,"archived":false,"open_issues_count":392,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3055,"open_issues":392,"watchers":4775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6959"},"html":{"href":"https://github.com/apache/flink/pull/6959"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6959"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6959/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6959/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6959/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/fe986e39c4007c99bcfa58636f5ec8076261706b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tzulitai"}}