{"action":"created","issue":{"url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/1","repository_url":"https://api.github.com/repos/tilmantroester/pycl2xi","labels_url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/1/comments","events_url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/1/events","html_url":"https://github.com/tilmantroester/pycl2xi/issues/1","id":339314475,"node_id":"MDU6SXNzdWUzMzkzMTQ0NzU=","number":1,"title":"Needed to include flag for C99 standard","user":{"login":"fkoehlin","id":11902084,"node_id":"MDQ6VXNlcjExOTAyMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/11902084?v=4","gravatar_id":"","url":"https://api.github.com/users/fkoehlin","html_url":"https://github.com/fkoehlin","followers_url":"https://api.github.com/users/fkoehlin/followers","following_url":"https://api.github.com/users/fkoehlin/following{/other_user}","gists_url":"https://api.github.com/users/fkoehlin/gists{/gist_id}","starred_url":"https://api.github.com/users/fkoehlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkoehlin/subscriptions","organizations_url":"https://api.github.com/users/fkoehlin/orgs","repos_url":"https://api.github.com/users/fkoehlin/repos","events_url":"https://api.github.com/users/fkoehlin/events{/privacy}","received_events_url":"https://api.github.com/users/fkoehlin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-09T05:58:14Z","updated_at":"2018-07-12T07:22:42Z","closed_at":"2018-07-12T07:22:42Z","author_association":"NONE","body":"Hi Tilman,\r\n\r\nin order for `python setup.py install` to work without any complaints on my setup (conda's GCC on macOS), I needed to pass a flag to GCC to invoke the C99 standard. For that I changed the following in `setup.py`:\r\n`fftlog_module = Extension( name=\"pycl2xi._fftlog\",\r\n                           sources=[\"src/fftlog.c\"],\r\n                           depends=[\"src/fftlog.h\"],\r\n                           libraries=[\"fftw3\"],\r\n                           # FK: need to pass C99 standard for compilation to work with conda's GCC on macOS\r\n                           extra_compile_args=[\"-std=c99\"]\r\n                           )`\r\n\r\nI'm happy tp push that back in a bugfix branch but it seems like I only have read access.\r\n\r\nCheers,\r\n\r\nFabian"},"comment":{"url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/comments/404415051","html_url":"https://github.com/tilmantroester/pycl2xi/issues/1#issuecomment-404415051","issue_url":"https://api.github.com/repos/tilmantroester/pycl2xi/issues/1","id":404415051,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDQxNTA1MQ==","user":{"login":"fkoehlin","id":11902084,"node_id":"MDQ6VXNlcjExOTAyMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/11902084?v=4","gravatar_id":"","url":"https://api.github.com/users/fkoehlin","html_url":"https://github.com/fkoehlin","followers_url":"https://api.github.com/users/fkoehlin/followers","following_url":"https://api.github.com/users/fkoehlin/following{/other_user}","gists_url":"https://api.github.com/users/fkoehlin/gists{/gist_id}","starred_url":"https://api.github.com/users/fkoehlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkoehlin/subscriptions","organizations_url":"https://api.github.com/users/fkoehlin/orgs","repos_url":"https://api.github.com/users/fkoehlin/repos","events_url":"https://api.github.com/users/fkoehlin/events{/privacy}","received_events_url":"https://api.github.com/users/fkoehlin/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T07:22:42Z","updated_at":"2018-07-12T07:22:42Z","author_association":"NONE","body":"I finally figured out the whole PR workflow and pushed my solution."}}
{"actor":{"display_login":"fkoehlin"}}