{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/236322654","pull_request_review_id":178374545,"id":236322654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMyMjY1NA==","diff_hunk":"@@ -141,16 +89,19 @@ public void removeLocationUpdates(@NonNull LocationListener listener) {\n   }\n \n   @Override\n-  public void removeLocationUpdates(@NonNull PendingIntent pendingIntent) {\n+  public void removeLocationUpdates(PendingIntent pendingIntent) {","path":"liblocation/src/main/java/com/mapbox/android/core/location/AndroidLocationEngineImpl.java","position":113,"original_position":113,"commit_id":"b36b925788a19fcf183f619dad2891708a8fb48f","original_commit_id":"f228914671229f6e327116302c1cac6d472da2ee","user":{"login":"andrlee","id":1395397,"node_id":"MDQ6VXNlcjEzOTUzOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1395397?v=4","gravatar_id":"","url":"https://api.github.com/users/andrlee","html_url":"https://github.com/andrlee","followers_url":"https://api.github.com/users/andrlee/followers","following_url":"https://api.github.com/users/andrlee/following{/other_user}","gists_url":"https://api.github.com/users/andrlee/gists{/gist_id}","starred_url":"https://api.github.com/users/andrlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrlee/subscriptions","organizations_url":"https://api.github.com/users/andrlee/orgs","repos_url":"https://api.github.com/users/andrlee/repos","events_url":"https://api.github.com/users/andrlee/events{/privacy}","received_events_url":"https://api.github.com/users/andrlee/received_events","type":"User","site_admin":false},"body":"@LukasPaczos what do you mean by \"accept\"? wouldn't annotation just result in warning in IDE? The main reason i removed annotation is to silence the ide warnings. also i do null check here because i wanted wrapper to behave consistently, since passing `null` value to `LocationManager` vs. `FusedLocationProviderClient` will result in different error.","created_at":"2018-11-26T16:20:18Z","updated_at":"2018-11-26T16:20:18Z","html_url":"https://github.com/mapbox/mapbox-events-android/pull/290#discussion_r236322654","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/236322654"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/290#discussion_r236322654"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290"}},"in_reply_to_id":235914881},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290","id":231869136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODY5MTM2","html_url":"https://github.com/mapbox/mapbox-events-android/pull/290","diff_url":"https://github.com/mapbox/mapbox-events-android/pull/290.diff","patch_url":"https://github.com/mapbox/mapbox-events-android/pull/290.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/290","number":290,"state":"closed","locked":false,"title":"Refactor listener management infrastructure & background mode support","user":{"login":"andrlee","id":1395397,"node_id":"MDQ6VXNlcjEzOTUzOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1395397?v=4","gravatar_id":"","url":"https://api.github.com/users/andrlee","html_url":"https://github.com/andrlee","followers_url":"https://api.github.com/users/andrlee/followers","following_url":"https://api.github.com/users/andrlee/following{/other_user}","gists_url":"https://api.github.com/users/andrlee/gists{/gist_id}","starred_url":"https://api.github.com/users/andrlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrlee/subscriptions","organizations_url":"https://api.github.com/users/andrlee/orgs","repos_url":"https://api.github.com/users/andrlee/repos","events_url":"https://api.github.com/users/andrlee/events{/privacy}","received_events_url":"https://api.github.com/users/andrlee/received_events","type":"User","site_admin":false},"body":"Expose background requests as public interface to comply with Android location services and delegate background job management to the client of the location APIs.\r\n\r\nAlso refactor listener management logic to address https://github.com/mapbox/mapbox-events-android/issues/289","created_at":"2018-11-19T06:46:20Z","updated_at":"2018-11-26T16:20:18Z","closed_at":"2018-11-24T01:50:39Z","merged_at":"2018-11-24T01:50:39Z","merge_commit_sha":"2eacb1920502e69c75ab037e9fcd898ea7f822b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":716790574,"node_id":"MDU6TGFiZWw3MTY3OTA1NzQ=","url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":751599634,"node_id":"MDU6TGFiZWw3NTE1OTk2MzQ=","url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels/ready%20for%20review","name":"ready for review","color":"65f957","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/290/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/b36b925788a19fcf183f619dad2891708a8fb48f","head":{"label":"mapbox:al-fix-memory-leak","ref":"al-fix-memory-leak","sha":"b36b925788a19fcf183f619dad2891708a8fb48f","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NTk0MzY=","name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry and core libraries for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2018-11-24T01:50:42Z","pushed_at":"2018-11-24T01:50:39Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":"https://www.mapbox.com/android-docs/core/","size":1083,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":25,"watchers":24,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"232fd3e91089bee7140177c5221114cef83bbfbf","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NTk0MzY=","name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry and core libraries for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2018-11-24T01:50:42Z","pushed_at":"2018-11-24T01:50:39Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":"https://www.mapbox.com/android-docs/core/","size":1083,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":25,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/290"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/290"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/b36b925788a19fcf183f619dad2891708a8fb48f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andrlee"}}