{"action":"created","comment":{"url":"https://api.github.com/repos/embox/embox/pulls/comments/205424185","pull_request_review_id":140688674,"id":205424185,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQyNDE4NQ==","diff_hunk":"@@ -19,20 +19,16 @@ EMBOX_UNIT_INIT(phymem_init);\n struct page_allocator *__phymem_allocator;\n \n static int phymem_init(void) {\n-\textern char _ram_base;\n-\textern char _ram_size;\n-\textern char _reserve_end;\n-\tchar *const phymem_alloc_start = (char *)\n-\t\tbinalign_bound((uintptr_t) &_reserve_end, PAGE_SIZE());\n-\tchar *const phymem_alloc_end = (char *)\n-\t\tbinalign_bound((uintptr_t) &_ram_base + (size_t) &_ram_size, PAGE_SIZE());\n+\tchar *const phymem_alloc_start = phymem_allocated_start();\n+\tchar *const phymem_alloc_end = phymem_allocated_end();\n \tconst size_t mem_len = phymem_alloc_end - phymem_alloc_start;\n \tvoid *va;\n \n \tlog_boot_start();\n \tlog_boot(\"start=%p end=%p size=%zu\\n\", phymem_alloc_start, phymem_alloc_end, mem_len);\n \n-\tva = mmap_device_memory(phymem_alloc_start,\n+\n+\tva = mmap_device_memory (phymem_alloc_start,","path":"src/mem/phymem.c","position":null,"original_position":21,"commit_id":"1b2087dbcfbfac6b2be2f780e6e66146d2c0b4bd","original_commit_id":"5a788d4e021d6b60188bbf9297639f754541ca78","user":{"login":"jackbogdanov","id":19926284,"node_id":"MDQ6VXNlcjE5OTI2Mjg0","avatar_url":"https://avatars1.githubusercontent.com/u/19926284?v=4","gravatar_id":"","url":"https://api.github.com/users/jackbogdanov","html_url":"https://github.com/jackbogdanov","followers_url":"https://api.github.com/users/jackbogdanov/followers","following_url":"https://api.github.com/users/jackbogdanov/following{/other_user}","gists_url":"https://api.github.com/users/jackbogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/jackbogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackbogdanov/subscriptions","organizations_url":"https://api.github.com/users/jackbogdanov/orgs","repos_url":"https://api.github.com/users/jackbogdanov/repos","events_url":"https://api.github.com/users/jackbogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/jackbogdanov/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-07-26T11:39:52Z","updated_at":"2018-07-26T11:39:52Z","html_url":"https://github.com/embox/embox/pull/1177#discussion_r205424185","pull_request_url":"https://api.github.com/repos/embox/embox/pulls/1177","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/comments/205424185"},"html":{"href":"https://github.com/embox/embox/pull/1177#discussion_r205424185"},"pull_request":{"href":"https://api.github.com/repos/embox/embox/pulls/1177"}},"in_reply_to_id":204703242},"pull_request":{"url":"https://api.github.com/repos/embox/embox/pulls/1177","id":200363775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzYzNzc1","html_url":"https://github.com/embox/embox/pull/1177","diff_url":"https://github.com/embox/embox/pull/1177.diff","patch_url":"https://github.com/embox/embox/pull/1177.patch","issue_url":"https://api.github.com/repos/embox/embox/issues/1177","number":1177,"state":"open","locked":false,"title":"Added an infomem command.","user":{"login":"jackbogdanov","id":19926284,"node_id":"MDQ6VXNlcjE5OTI2Mjg0","avatar_url":"https://avatars1.githubusercontent.com/u/19926284?v=4","gravatar_id":"","url":"https://api.github.com/users/jackbogdanov","html_url":"https://github.com/jackbogdanov","followers_url":"https://api.github.com/users/jackbogdanov/followers","following_url":"https://api.github.com/users/jackbogdanov/following{/other_user}","gists_url":"https://api.github.com/users/jackbogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/jackbogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackbogdanov/subscriptions","organizations_url":"https://api.github.com/users/jackbogdanov/orgs","repos_url":"https://api.github.com/users/jackbogdanov/repos","events_url":"https://api.github.com/users/jackbogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/jackbogdanov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-10T11:23:54Z","updated_at":"2018-07-26T11:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57bc36ea83ba30fec0dfaf96e7af9a8ffb8fed48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/embox/embox/pulls/1177/commits","review_comments_url":"https://api.github.com/repos/embox/embox/pulls/1177/comments","review_comment_url":"https://api.github.com/repos/embox/embox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embox/embox/issues/1177/comments","statuses_url":"https://api.github.com/repos/embox/embox/statuses/1b2087dbcfbfac6b2be2f780e6e66146d2c0b4bd","head":{"label":"jackbogdanov:infomem","ref":"infomem","sha":"1b2087dbcfbfac6b2be2f780e6e66146d2c0b4bd","user":{"login":"jackbogdanov","id":19926284,"node_id":"MDQ6VXNlcjE5OTI2Mjg0","avatar_url":"https://avatars1.githubusercontent.com/u/19926284?v=4","gravatar_id":"","url":"https://api.github.com/users/jackbogdanov","html_url":"https://github.com/jackbogdanov","followers_url":"https://api.github.com/users/jackbogdanov/followers","following_url":"https://api.github.com/users/jackbogdanov/following{/other_user}","gists_url":"https://api.github.com/users/jackbogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/jackbogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackbogdanov/subscriptions","organizations_url":"https://api.github.com/users/jackbogdanov/orgs","repos_url":"https://api.github.com/users/jackbogdanov/repos","events_url":"https://api.github.com/users/jackbogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/jackbogdanov/received_events","type":"User","site_admin":false},"repo":{"id":140415393,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MTUzOTM=","name":"embox","full_name":"jackbogdanov/embox","owner":{"login":"jackbogdanov","id":19926284,"node_id":"MDQ6VXNlcjE5OTI2Mjg0","avatar_url":"https://avatars1.githubusercontent.com/u/19926284?v=4","gravatar_id":"","url":"https://api.github.com/users/jackbogdanov","html_url":"https://github.com/jackbogdanov","followers_url":"https://api.github.com/users/jackbogdanov/followers","following_url":"https://api.github.com/users/jackbogdanov/following{/other_user}","gists_url":"https://api.github.com/users/jackbogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/jackbogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackbogdanov/subscriptions","organizations_url":"https://api.github.com/users/jackbogdanov/orgs","repos_url":"https://api.github.com/users/jackbogdanov/repos","events_url":"https://api.github.com/users/jackbogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/jackbogdanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackbogdanov/embox","description":"Modular and configurable OS kernel for embedded applications","fork":true,"url":"https://api.github.com/repos/jackbogdanov/embox","forks_url":"https://api.github.com/repos/jackbogdanov/embox/forks","keys_url":"https://api.github.com/repos/jackbogdanov/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackbogdanov/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackbogdanov/embox/teams","hooks_url":"https://api.github.com/repos/jackbogdanov/embox/hooks","issue_events_url":"https://api.github.com/repos/jackbogdanov/embox/issues/events{/number}","events_url":"https://api.github.com/repos/jackbogdanov/embox/events","assignees_url":"https://api.github.com/repos/jackbogdanov/embox/assignees{/user}","branches_url":"https://api.github.com/repos/jackbogdanov/embox/branches{/branch}","tags_url":"https://api.github.com/repos/jackbogdanov/embox/tags","blobs_url":"https://api.github.com/repos/jackbogdanov/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackbogdanov/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackbogdanov/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackbogdanov/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackbogdanov/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/jackbogdanov/embox/languages","stargazers_url":"https://api.github.com/repos/jackbogdanov/embox/stargazers","contributors_url":"https://api.github.com/repos/jackbogdanov/embox/contributors","subscribers_url":"https://api.github.com/repos/jackbogdanov/embox/subscribers","subscription_url":"https://api.github.com/repos/jackbogdanov/embox/subscription","commits_url":"https://api.github.com/repos/jackbogdanov/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackbogdanov/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackbogdanov/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackbogdanov/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackbogdanov/embox/contents/{+path}","compare_url":"https://api.github.com/repos/jackbogdanov/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackbogdanov/embox/merges","archive_url":"https://api.github.com/repos/jackbogdanov/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackbogdanov/embox/downloads","issues_url":"https://api.github.com/repos/jackbogdanov/embox/issues{/number}","pulls_url":"https://api.github.com/repos/jackbogdanov/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/jackbogdanov/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/jackbogdanov/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackbogdanov/embox/labels{/name}","releases_url":"https://api.github.com/repos/jackbogdanov/embox/releases{/id}","deployments_url":"https://api.github.com/repos/jackbogdanov/embox/deployments","created_at":"2018-07-10T10:23:54Z","updated_at":"2018-07-25T21:04:31Z","pushed_at":"2018-07-25T22:04:06Z","git_url":"git://github.com/jackbogdanov/embox.git","ssh_url":"git@github.com:jackbogdanov/embox.git","clone_url":"https://github.com/jackbogdanov/embox.git","svn_url":"https://github.com/jackbogdanov/embox","homepage":"","size":33533,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"embox:master","ref":"master","sha":"7c6ff69c0a818e4c00390d7d01a6c1793830663d","user":{"login":"embox","id":9039916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMzk5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9039916?v=4","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA3ODEzOA==","name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMzk5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9039916?v=4","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"Modular and configurable OS kernel for embedded applications","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","deployments_url":"https://api.github.com/repos/embox/embox/deployments","created_at":"2015-03-29T15:27:48Z","updated_at":"2018-07-23T11:30:04Z","pushed_at":"2018-07-25T22:04:08Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":33586,"stargazers_count":196,"watchers_count":196,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":59,"open_issues":75,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/1177"},"html":{"href":"https://github.com/embox/embox/pull/1177"},"issue":{"href":"https://api.github.com/repos/embox/embox/issues/1177"},"comments":{"href":"https://api.github.com/repos/embox/embox/issues/1177/comments"},"review_comments":{"href":"https://api.github.com/repos/embox/embox/pulls/1177/comments"},"review_comment":{"href":"https://api.github.com/repos/embox/embox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embox/embox/pulls/1177/commits"},"statuses":{"href":"https://api.github.com/repos/embox/embox/statuses/1b2087dbcfbfac6b2be2f780e6e66146d2c0b4bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"jackbogdanov"}}