{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments/183791573","pull_request_review_id":114857437,"id":183791573,"diff_hunk":"@@ -10,22 +10,34 @@ It's main features are:\n \n == Installation\n \n-Use the Cordova CLI to add the Core module as a plugin to your project:\n+The `@aerogear/core` module is available via NPM:\n \n ----\n-cordova plugin add @aerogearservices/core-cordova\n+npm install @aerogear/core\n ----\n \n-This will install the package from the NPM registry and properly link all native dependencies to the project's cordova Platforms.\n+=== Additional steps for a Cordova project\n+\n+After node module installation via NPM use the Cordova CLI to add the additional native dependencies to your project:\n+\n+----\n+cordova plugin add cordova-plugin-device\n+cordova plugin add cordova-plugin-app-version\n+----\n+\n+This will install the packages with these native dependencies from the NPM registry and properly link all native dependencies to the project's cordova Platforms.\n \n Refer to the link:./getting-started[Getting Started] guide for more information on installing the AeroGear SDK.\n \n == Usage\n \n-After installation, the Core module will become available through the global `window.aerogear` object in your project.\n-\n-=== Logging\n+The Core module supports parsing of the configuration file generated by the mobile CLI, in practice this feature is used internally by other modules of the SDK:\n \n-=== Networking\n+[source, javascript]\n+----\n+import { MetricsService } from '@aerogear/core';\n+import configuration from '../mobile-services.json';\n \n-=== Metrics Service\n+// utilizes Core to retrieve it's own configuration\n+const metrics = new MetricsService(configuration);","path":"docs/core.adoc","position":41,"original_position":41,"commit_id":"2056824afdea914a9976ecaee50b2b06cfa54c06","original_commit_id":"2056824afdea914a9976ecaee50b2b06cfa54c06","user":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars0.githubusercontent.com/u/1294893?v=4","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"body":"@josemigallas @wtrocki  I've tried to change the Usage section to point out how core's used by other modules and doesn't make sense by itself but it can be a bit clunky, removing this section is also an option.","created_at":"2018-04-24T16:07:40Z","updated_at":"2018-04-24T16:07:40Z","html_url":"https://github.com/aerogear/aerogear-js-sdk/pull/58#discussion_r183791573","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments/183791573"},"html":{"href":"https://github.com/aerogear/aerogear-js-sdk/pull/58#discussion_r183791573"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58","id":183614822,"html_url":"https://github.com/aerogear/aerogear-js-sdk/pull/58","diff_url":"https://github.com/aerogear/aerogear-js-sdk/pull/58.diff","patch_url":"https://github.com/aerogear/aerogear-js-sdk/pull/58.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/58","number":58,"state":"open","locked":false,"title":"Docs update","user":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars0.githubusercontent.com/u/1294893?v=4","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"body":"## Motivation\r\nUpdate core.adoc with current sdk structure","created_at":"2018-04-24T03:59:30Z","updated_at":"2018-04-24T16:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6be4751b65bb122a33b1a155895ee804b0d35224","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/58/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/2056824afdea914a9976ecaee50b2b06cfa54c06","head":{"label":"aerogear:docs-update","ref":"docs-update","sha":"2056824afdea914a9976ecaee50b2b06cfa54c06","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":121781914,"name":"aerogear-js-sdk","full_name":"aerogear/aerogear-js-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-js-sdk","description":"AeroGear SDK for Java Script, Apache Cordova and React Native.","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/deployments","created_at":"2018-02-16T17:51:49Z","updated_at":"2018-04-24T14:28:06Z","pushed_at":"2018-04-24T16:06:12Z","git_url":"git://github.com/aerogear/aerogear-js-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-js-sdk.git","clone_url":"https://github.com/aerogear/aerogear-js-sdk.git","svn_url":"https://github.com/aerogear/aerogear-js-sdk","homepage":"http://aerogear.org","size":10827,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"a4cac51da9228cbd51ce5777f2f4e56a2cf976a2","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":121781914,"name":"aerogear-js-sdk","full_name":"aerogear/aerogear-js-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-js-sdk","description":"AeroGear SDK for Java Script, Apache Cordova and React Native.","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/deployments","created_at":"2018-02-16T17:51:49Z","updated_at":"2018-04-24T14:28:06Z","pushed_at":"2018-04-24T16:06:12Z","git_url":"git://github.com/aerogear/aerogear-js-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-js-sdk.git","clone_url":"https://github.com/aerogear/aerogear-js-sdk.git","svn_url":"https://github.com/aerogear/aerogear-js-sdk","homepage":"http://aerogear.org","size":10827,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58"},"html":{"href":"https://github.com/aerogear/aerogear-js-sdk/pull/58"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/58"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/2056824afdea914a9976ecaee50b2b06cfa54c06"}},"author_association":"OWNER"}}
{"actor":{"display_login":"paolobueno"}}