{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58","id":177336622,"html_url":"https://github.com/Aegisub/Aegisub/pull/58","diff_url":"https://github.com/Aegisub/Aegisub/pull/58.diff","patch_url":"https://github.com/Aegisub/Aegisub/pull/58.patch","issue_url":"https://api.github.com/repos/Aegisub/Aegisub/issues/58","number":58,"state":"closed","locked":false,"title":"Various changes","user":{"login":"CoffeeFlux","id":3180302,"avatar_url":"https://avatars1.githubusercontent.com/u/3180302?v=4","gravatar_id":"","url":"https://api.github.com/users/CoffeeFlux","html_url":"https://github.com/CoffeeFlux","followers_url":"https://api.github.com/users/CoffeeFlux/followers","following_url":"https://api.github.com/users/CoffeeFlux/following{/other_user}","gists_url":"https://api.github.com/users/CoffeeFlux/gists{/gist_id}","starred_url":"https://api.github.com/users/CoffeeFlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoffeeFlux/subscriptions","organizations_url":"https://api.github.com/users/CoffeeFlux/orgs","repos_url":"https://api.github.com/users/CoffeeFlux/repos","events_url":"https://api.github.com/users/CoffeeFlux/events{/privacy}","received_events_url":"https://api.github.com/users/CoffeeFlux/received_events","type":"User","site_admin":false},"body":"Best reviewed commit-by-commit.\r\n\r\nChanges to the config are largely based off unanimated's recommendations, which have more or less become standard in fansubbing.\r\n\r\nStill not sure if this is the ideal behavior for the color matrix, but no one seems to know what the best way to handle that actually is and you're guaranteed to be wrong sometimes.\r\n\r\nThat translation assistant commit adds an option that apparently is important enough to some translators that they've been downgrading to 2.x, so I think it's well worth including even if it doesn't seem to be intended usage of the tool.\r\n\r\nOn the character_count commit, I suspect there's a better place to put the special characters I'm checking for, so if someone has suggestions for that I'm all ears.","created_at":"2018-03-26T03:49:22Z","updated_at":"2018-04-07T23:33:49Z","closed_at":"2018-04-07T23:33:49Z","merged_at":null,"merge_commit_sha":"519f4f22c8e40a60e3ad35c5fd6c45c6887f2fd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58/commits","review_comments_url":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58/comments","review_comment_url":"https://api.github.com/repos/Aegisub/Aegisub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aegisub/Aegisub/issues/58/comments","statuses_url":"https://api.github.com/repos/Aegisub/Aegisub/statuses/8aad6f25c22dc9961cfb7bc9567dea16cc34d657","head":{"label":"CoffeeFlux:modernize-config","ref":"modernize-config","sha":"8aad6f25c22dc9961cfb7bc9567dea16cc34d657","user":{"login":"CoffeeFlux","id":3180302,"avatar_url":"https://avatars1.githubusercontent.com/u/3180302?v=4","gravatar_id":"","url":"https://api.github.com/users/CoffeeFlux","html_url":"https://github.com/CoffeeFlux","followers_url":"https://api.github.com/users/CoffeeFlux/followers","following_url":"https://api.github.com/users/CoffeeFlux/following{/other_user}","gists_url":"https://api.github.com/users/CoffeeFlux/gists{/gist_id}","starred_url":"https://api.github.com/users/CoffeeFlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoffeeFlux/subscriptions","organizations_url":"https://api.github.com/users/CoffeeFlux/orgs","repos_url":"https://api.github.com/users/CoffeeFlux/repos","events_url":"https://api.github.com/users/CoffeeFlux/events{/privacy}","received_events_url":"https://api.github.com/users/CoffeeFlux/received_events","type":"User","site_admin":false},"repo":{"id":122922861,"name":"Aegisub","full_name":"CoffeeFlux/Aegisub","owner":{"login":"CoffeeFlux","id":3180302,"avatar_url":"https://avatars1.githubusercontent.com/u/3180302?v=4","gravatar_id":"","url":"https://api.github.com/users/CoffeeFlux","html_url":"https://github.com/CoffeeFlux","followers_url":"https://api.github.com/users/CoffeeFlux/followers","following_url":"https://api.github.com/users/CoffeeFlux/following{/other_user}","gists_url":"https://api.github.com/users/CoffeeFlux/gists{/gist_id}","starred_url":"https://api.github.com/users/CoffeeFlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoffeeFlux/subscriptions","organizations_url":"https://api.github.com/users/CoffeeFlux/orgs","repos_url":"https://api.github.com/users/CoffeeFlux/repos","events_url":"https://api.github.com/users/CoffeeFlux/events{/privacy}","received_events_url":"https://api.github.com/users/CoffeeFlux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CoffeeFlux/Aegisub","description":"Cross-platform advanced subtitle editor","fork":true,"url":"https://api.github.com/repos/CoffeeFlux/Aegisub","forks_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/forks","keys_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/teams","hooks_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/hooks","issue_events_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/issues/events{/number}","events_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/events","assignees_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/assignees{/user}","branches_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/branches{/branch}","tags_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/tags","blobs_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/statuses/{sha}","languages_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/languages","stargazers_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/stargazers","contributors_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/contributors","subscribers_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/subscribers","subscription_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/subscription","commits_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/contents/{+path}","compare_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/merges","archive_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/downloads","issues_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/issues{/number}","pulls_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/pulls{/number}","milestones_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/milestones{/number}","notifications_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/labels{/name}","releases_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/releases{/id}","deployments_url":"https://api.github.com/repos/CoffeeFlux/Aegisub/deployments","created_at":"2018-02-26T06:19:23Z","updated_at":"2018-03-14T09:24:29Z","pushed_at":"2018-04-07T08:18:33Z","git_url":"git://github.com/CoffeeFlux/Aegisub.git","ssh_url":"git@github.com:CoffeeFlux/Aegisub.git","clone_url":"https://github.com/CoffeeFlux/Aegisub.git","svn_url":"https://github.com/CoffeeFlux/Aegisub","homepage":"http://devel.aegisub.org/","size":39188,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aegisub:master","ref":"master","sha":"f6a2ac08a63f37c1cb3e7315144411f7d5aa5403","user":{"login":"Aegisub","id":2125289,"avatar_url":"https://avatars3.githubusercontent.com/u/2125289?v=4","gravatar_id":"","url":"https://api.github.com/users/Aegisub","html_url":"https://github.com/Aegisub","followers_url":"https://api.github.com/users/Aegisub/followers","following_url":"https://api.github.com/users/Aegisub/following{/other_user}","gists_url":"https://api.github.com/users/Aegisub/gists{/gist_id}","starred_url":"https://api.github.com/users/Aegisub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aegisub/subscriptions","organizations_url":"https://api.github.com/users/Aegisub/orgs","repos_url":"https://api.github.com/users/Aegisub/repos","events_url":"https://api.github.com/users/Aegisub/events{/privacy}","received_events_url":"https://api.github.com/users/Aegisub/received_events","type":"Organization","site_admin":false},"repo":{"id":5360758,"name":"Aegisub","full_name":"Aegisub/Aegisub","owner":{"login":"Aegisub","id":2125289,"avatar_url":"https://avatars3.githubusercontent.com/u/2125289?v=4","gravatar_id":"","url":"https://api.github.com/users/Aegisub","html_url":"https://github.com/Aegisub","followers_url":"https://api.github.com/users/Aegisub/followers","following_url":"https://api.github.com/users/Aegisub/following{/other_user}","gists_url":"https://api.github.com/users/Aegisub/gists{/gist_id}","starred_url":"https://api.github.com/users/Aegisub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aegisub/subscriptions","organizations_url":"https://api.github.com/users/Aegisub/orgs","repos_url":"https://api.github.com/users/Aegisub/repos","events_url":"https://api.github.com/users/Aegisub/events{/privacy}","received_events_url":"https://api.github.com/users/Aegisub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aegisub/Aegisub","description":"Cross-platform advanced subtitle editor","fork":false,"url":"https://api.github.com/repos/Aegisub/Aegisub","forks_url":"https://api.github.com/repos/Aegisub/Aegisub/forks","keys_url":"https://api.github.com/repos/Aegisub/Aegisub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aegisub/Aegisub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aegisub/Aegisub/teams","hooks_url":"https://api.github.com/repos/Aegisub/Aegisub/hooks","issue_events_url":"https://api.github.com/repos/Aegisub/Aegisub/issues/events{/number}","events_url":"https://api.github.com/repos/Aegisub/Aegisub/events","assignees_url":"https://api.github.com/repos/Aegisub/Aegisub/assignees{/user}","branches_url":"https://api.github.com/repos/Aegisub/Aegisub/branches{/branch}","tags_url":"https://api.github.com/repos/Aegisub/Aegisub/tags","blobs_url":"https://api.github.com/repos/Aegisub/Aegisub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aegisub/Aegisub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aegisub/Aegisub/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aegisub/Aegisub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aegisub/Aegisub/statuses/{sha}","languages_url":"https://api.github.com/repos/Aegisub/Aegisub/languages","stargazers_url":"https://api.github.com/repos/Aegisub/Aegisub/stargazers","contributors_url":"https://api.github.com/repos/Aegisub/Aegisub/contributors","subscribers_url":"https://api.github.com/repos/Aegisub/Aegisub/subscribers","subscription_url":"https://api.github.com/repos/Aegisub/Aegisub/subscription","commits_url":"https://api.github.com/repos/Aegisub/Aegisub/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aegisub/Aegisub/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aegisub/Aegisub/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aegisub/Aegisub/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aegisub/Aegisub/contents/{+path}","compare_url":"https://api.github.com/repos/Aegisub/Aegisub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aegisub/Aegisub/merges","archive_url":"https://api.github.com/repos/Aegisub/Aegisub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aegisub/Aegisub/downloads","issues_url":"https://api.github.com/repos/Aegisub/Aegisub/issues{/number}","pulls_url":"https://api.github.com/repos/Aegisub/Aegisub/pulls{/number}","milestones_url":"https://api.github.com/repos/Aegisub/Aegisub/milestones{/number}","notifications_url":"https://api.github.com/repos/Aegisub/Aegisub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aegisub/Aegisub/labels{/name}","releases_url":"https://api.github.com/repos/Aegisub/Aegisub/releases{/id}","deployments_url":"https://api.github.com/repos/Aegisub/Aegisub/deployments","created_at":"2012-08-09T20:22:23Z","updated_at":"2018-04-05T16:07:28Z","pushed_at":"2018-04-02T03:36:13Z","git_url":"git://github.com/Aegisub/Aegisub.git","ssh_url":"git@github.com:Aegisub/Aegisub.git","clone_url":"https://github.com/Aegisub/Aegisub.git","svn_url":"https://github.com/Aegisub/Aegisub","homepage":"http://devel.aegisub.org/","size":45416,"stargazers_count":357,"watchers_count":357,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":90,"open_issues":15,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58"},"html":{"href":"https://github.com/Aegisub/Aegisub/pull/58"},"issue":{"href":"https://api.github.com/repos/Aegisub/Aegisub/issues/58"},"comments":{"href":"https://api.github.com/repos/Aegisub/Aegisub/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/Aegisub/Aegisub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aegisub/Aegisub/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/Aegisub/Aegisub/statuses/8aad6f25c22dc9961cfb7bc9567dea16cc34d657"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":87,"deletions":45,"changed_files":11}}
{"actor":{"display_login":"CoffeeFlux"}}