{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/201462375","pull_request_review_id":135970216,"id":201462375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ2MjM3NQ==","diff_hunk":"@@ -0,0 +1,232 @@\n+using System;\n+using Windows.UI.Xaml.Controls;\n+using ReactNative.UIManager;\n+using ReactNative.UIManager.Annotations;\n+using ReactNative.UIManager.Events;\n+using Newtonsoft.Json.Linq;\n+\n+namespace ReactNative.Views.DatePicker\n+{\n+    /// <summary>\n+    /// A view manager responsible for rendering a CalendarDatePicker.\n+    /// </summary>\n+    public class ReactCalendarDatePickerManager : BaseViewManager<CalendarDatePicker, ReactCalendarDatePickerShadowNode>\n+    {\n+        /// <summary>\n+        /// The name of the view manager.\n+        /// </summary>\n+        public override string Name\n+        {\n+            get\n+            {\n+                return \"CalendarDatePickerWindows\";\n+            }\n+        }\n+\n+        /// <summary>\n+        /// Sets the value of the picker.\n+        /// </summary>\n+        /// <param name=\"view\">The picker view element.</param>\n+        /// <param name=\"date\">The new value.</param>\n+        [ReactProp(\"date\")]\n+        public void SetDate(CalendarDatePicker view, DateTime? date)\n+        {\n+            view.Date = date ?? null;\n+        }\n+\n+\n+        /// <summary>\n+        /// Sets the maximum allowed date of the picker.\n+        /// </summary>\n+        /// <param name=\"view\">The picker view element.</param>\n+        /// <param name=\"date\">The value to set as maximum.</param>\n+        [ReactProp(\"maxDate\")]\n+        public void SetMaxDate(CalendarDatePicker view, DateTime? date)\n+        {\n+            if (date.HasValue)","path":"ReactWindows/ReactNative/Views/DatePicker/ReactCalendarDatePickerManager.cs","position":46,"original_position":46,"commit_id":"d356c5a0aec78ef17d8f6823730942a715f1c1fe","original_commit_id":"d356c5a0aec78ef17d8f6823730942a715f1c1fe","user":{"login":"rozele","id":1106239,"node_id":"MDQ6VXNlcjExMDYyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"Do you want to clear out the `MaxDate` if the prop value is unset or reset to null?","created_at":"2018-07-10T19:15:07Z","updated_at":"2018-07-10T19:15:07Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/1881#discussion_r201462375","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/201462375"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1881#discussion_r201462375"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881","id":199055487,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDU1NDg3","html_url":"https://github.com/Microsoft/react-native-windows/pull/1881","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1881.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1881.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1881","number":1881,"state":"open","locked":false,"title":"#230 datepicker","user":{"login":"martinarroyo","id":4853097,"node_id":"MDQ6VXNlcjQ4NTMwOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4853097?v=4","gravatar_id":"","url":"https://api.github.com/users/martinarroyo","html_url":"https://github.com/martinarroyo","followers_url":"https://api.github.com/users/martinarroyo/followers","following_url":"https://api.github.com/users/martinarroyo/following{/other_user}","gists_url":"https://api.github.com/users/martinarroyo/gists{/gist_id}","starred_url":"https://api.github.com/users/martinarroyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinarroyo/subscriptions","organizations_url":"https://api.github.com/users/martinarroyo/orgs","repos_url":"https://api.github.com/users/martinarroyo/repos","events_url":"https://api.github.com/users/martinarroyo/events{/privacy}","received_events_url":"https://api.github.com/users/martinarroyo/received_events","type":"User","site_admin":false},"body":"It's been a while since the first PR for #230. The project has changed its structure slightly and as such I thought it might be easier to just start anew. Here is the code with the changes suggested by @rozele. Here is a summary of the changes:\r\n\r\n- Refactors the JS bridge components to comply with the new structure (uses ES6 classes instead of `React.createClass` and other minor changes).\r\n- Removes the `DateTimePicker` element.\r\n\r\nBased on the review from @rozele, some changes might still be missing:\r\n- No support for WPF and no `NotImplementedException` handling. How should I approach that? Simply defining the component in the `ReactNative.Net46` project?\r\n- Views still extends the `BaseViewManager` class instead of `SimpleViewManager`. The components I took as reference use `BaseViewManager`, so I kept it. With some reference I might be able to do the refactoring.","created_at":"2018-07-03T18:58:17Z","updated_at":"2018-07-10T19:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b09123702541dc1a1f0573af3022ebe0e285cacb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1881/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/d356c5a0aec78ef17d8f6823730942a715f1c1fe","head":{"label":"martinarroyo:230-datepicker","ref":"230-datepicker","sha":"d356c5a0aec78ef17d8f6823730942a715f1c1fe","user":{"login":"martinarroyo","id":4853097,"node_id":"MDQ6VXNlcjQ4NTMwOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4853097?v=4","gravatar_id":"","url":"https://api.github.com/users/martinarroyo","html_url":"https://github.com/martinarroyo","followers_url":"https://api.github.com/users/martinarroyo/followers","following_url":"https://api.github.com/users/martinarroyo/following{/other_user}","gists_url":"https://api.github.com/users/martinarroyo/gists{/gist_id}","starred_url":"https://api.github.com/users/martinarroyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinarroyo/subscriptions","organizations_url":"https://api.github.com/users/martinarroyo/orgs","repos_url":"https://api.github.com/users/martinarroyo/repos","events_url":"https://api.github.com/users/martinarroyo/events{/privacy}","received_events_url":"https://api.github.com/users/martinarroyo/received_events","type":"User","site_admin":false},"repo":{"id":139624548,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MjQ1NDg=","name":"react-native-windows","full_name":"martinarroyo/react-native-windows","owner":{"login":"martinarroyo","id":4853097,"node_id":"MDQ6VXNlcjQ4NTMwOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4853097?v=4","gravatar_id":"","url":"https://api.github.com/users/martinarroyo","html_url":"https://github.com/martinarroyo","followers_url":"https://api.github.com/users/martinarroyo/followers","following_url":"https://api.github.com/users/martinarroyo/following{/other_user}","gists_url":"https://api.github.com/users/martinarroyo/gists{/gist_id}","starred_url":"https://api.github.com/users/martinarroyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinarroyo/subscriptions","organizations_url":"https://api.github.com/users/martinarroyo/orgs","repos_url":"https://api.github.com/users/martinarroyo/repos","events_url":"https://api.github.com/users/martinarroyo/events{/privacy}","received_events_url":"https://api.github.com/users/martinarroyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinarroyo/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/martinarroyo/react-native-windows","forks_url":"https://api.github.com/repos/martinarroyo/react-native-windows/forks","keys_url":"https://api.github.com/repos/martinarroyo/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinarroyo/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinarroyo/react-native-windows/teams","hooks_url":"https://api.github.com/repos/martinarroyo/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/martinarroyo/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/martinarroyo/react-native-windows/events","assignees_url":"https://api.github.com/repos/martinarroyo/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/martinarroyo/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/martinarroyo/react-native-windows/tags","blobs_url":"https://api.github.com/repos/martinarroyo/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinarroyo/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinarroyo/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinarroyo/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinarroyo/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/martinarroyo/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/martinarroyo/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/martinarroyo/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/martinarroyo/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/martinarroyo/react-native-windows/subscription","commits_url":"https://api.github.com/repos/martinarroyo/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinarroyo/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinarroyo/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinarroyo/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinarroyo/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/martinarroyo/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinarroyo/react-native-windows/merges","archive_url":"https://api.github.com/repos/martinarroyo/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinarroyo/react-native-windows/downloads","issues_url":"https://api.github.com/repos/martinarroyo/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/martinarroyo/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/martinarroyo/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/martinarroyo/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinarroyo/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/martinarroyo/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/martinarroyo/react-native-windows/deployments","created_at":"2018-07-03T18:41:26Z","updated_at":"2018-07-03T18:41:30Z","pushed_at":"2018-07-03T18:50:56Z","git_url":"git://github.com/martinarroyo/react-native-windows.git","ssh_url":"git@github.com:martinarroyo/react-native-windows.git","clone_url":"https://github.com/martinarroyo/react-native-windows.git","svn_url":"https://github.com/martinarroyo/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160432,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"9a9cfeaf574a5505e767cf3afe187e6da74c1b96","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAwOTIxNA==","name":"react-native-windows","full_name":"Microsoft/react-native-windows","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-07-10T18:03:56Z","pushed_at":"2018-07-10T18:03:46Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160461,"stargazers_count":5179,"watchers_count":5179,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":394,"open_issues":313,"watchers":5179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1881"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1881"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1881/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1881/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/d356c5a0aec78ef17d8f6823730942a715f1c1fe"}},"author_association":"NONE"}}
{"actor":{"display_login":"rozele"}}