{"action":"created","comment":{"url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/comments/186589398","pull_request_review_id":118197234,"id":186589398,"diff_hunk":"@@ -524,6 +524,18 @@ def _process_container(\n         return self._find_missing_objects(container, aws_bucket, marker,\n                                           prefix, list_all)\n \n+    def _old_enough(self, remote):\n+        if 'last_modified' not in remote:","path":"s3_sync/migrator.py","position":5,"original_position":5,"commit_id":"949d15343850c1f3a7fad284446ca46a76ea6dce","original_commit_id":"f5493cb7247ea781873c5511ba7fb470db8cc283","user":{"login":"mdegerne","id":60821,"avatar_url":"https://avatars0.githubusercontent.com/u/60821?v=4","gravatar_id":"","url":"https://api.github.com/users/mdegerne","html_url":"https://github.com/mdegerne","followers_url":"https://api.github.com/users/mdegerne/followers","following_url":"https://api.github.com/users/mdegerne/following{/other_user}","gists_url":"https://api.github.com/users/mdegerne/gists{/gist_id}","starred_url":"https://api.github.com/users/mdegerne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdegerne/subscriptions","organizations_url":"https://api.github.com/users/mdegerne/orgs","repos_url":"https://api.github.com/users/mdegerne/repos","events_url":"https://api.github.com/users/mdegerne/events{/privacy}","received_events_url":"https://api.github.com/users/mdegerne/received_events","type":"User","site_admin":false},"body":"You're right. I instituted this before I had the current order of operations. Deleting.","created_at":"2018-05-08T00:33:15Z","updated_at":"2018-05-08T00:33:15Z","html_url":"https://github.com/swiftstack/swift-s3-sync/pull/106#discussion_r186589398","pull_request_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/comments/186589398"},"html":{"href":"https://github.com/swiftstack/swift-s3-sync/pull/106#discussion_r186589398"},"pull_request":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106"}},"in_reply_to_id":186584437},"pull_request":{"url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106","id":185080255,"html_url":"https://github.com/swiftstack/swift-s3-sync/pull/106","diff_url":"https://github.com/swiftstack/swift-s3-sync/pull/106.diff","patch_url":"https://github.com/swiftstack/swift-s3-sync/pull/106.patch","issue_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/106","number":106,"state":"open","locked":false,"title":"Allow older_than (seconds) in migrations","user":{"login":"mdegerne","id":60821,"avatar_url":"https://avatars0.githubusercontent.com/u/60821?v=4","gravatar_id":"","url":"https://api.github.com/users/mdegerne","html_url":"https://github.com/mdegerne","followers_url":"https://api.github.com/users/mdegerne/followers","following_url":"https://api.github.com/users/mdegerne/following{/other_user}","gists_url":"https://api.github.com/users/mdegerne/gists{/gist_id}","starred_url":"https://api.github.com/users/mdegerne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdegerne/subscriptions","organizations_url":"https://api.github.com/users/mdegerne/orgs","repos_url":"https://api.github.com/users/mdegerne/repos","events_url":"https://api.github.com/users/mdegerne/events{/privacy}","received_events_url":"https://api.github.com/users/mdegerne/received_events","type":"User","site_admin":false},"body":"Will only migrate objects whose last_modification date is older than the\r\nspecified number of seconds. If not specified, it behaves as before.","created_at":"2018-04-30T22:23:47Z","updated_at":"2018-05-08T00:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bf4367578b9d7014aef89c81f2387065918eec3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106/commits","review_comments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106/comments","review_comment_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/106/comments","statuses_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/statuses/949d15343850c1f3a7fad284446ca46a76ea6dce","head":{"label":"swiftstack:feature/older_than","ref":"feature/older_than","sha":"949d15343850c1f3a7fad284446ca46a76ea6dce","user":{"login":"swiftstack","id":1240687,"avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"repo":{"id":58976963,"name":"swift-s3-sync","full_name":"swiftstack/swift-s3-sync","owner":{"login":"swiftstack","id":1240687,"avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swiftstack/swift-s3-sync","description":"Swift-S3 synchronization tool","fork":false,"url":"https://api.github.com/repos/swiftstack/swift-s3-sync","forks_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/forks","keys_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/teams","hooks_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/hooks","issue_events_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/events{/number}","events_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/events","assignees_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/assignees{/user}","branches_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/branches{/branch}","tags_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/tags","blobs_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/languages","stargazers_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/stargazers","contributors_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/contributors","subscribers_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/subscribers","subscription_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/subscription","commits_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/contents/{+path}","compare_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/merges","archive_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/downloads","issues_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues{/number}","pulls_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/labels{/name}","releases_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/releases{/id}","deployments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/deployments","created_at":"2016-05-17T00:20:29Z","updated_at":"2018-05-07T23:46:45Z","pushed_at":"2018-05-08T00:26:01Z","git_url":"git://github.com/swiftstack/swift-s3-sync.git","ssh_url":"git@github.com:swiftstack/swift-s3-sync.git","clone_url":"https://github.com/swiftstack/swift-s3-sync.git","svn_url":"https://github.com/swiftstack/swift-s3-sync","homepage":"","size":826,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":8,"watchers":6,"default_branch":"master"}},"base":{"label":"swiftstack:master","ref":"master","sha":"76090e376beeb40bdee2345bd7c91d712ec91e3a","user":{"login":"swiftstack","id":1240687,"avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"repo":{"id":58976963,"name":"swift-s3-sync","full_name":"swiftstack/swift-s3-sync","owner":{"login":"swiftstack","id":1240687,"avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swiftstack/swift-s3-sync","description":"Swift-S3 synchronization tool","fork":false,"url":"https://api.github.com/repos/swiftstack/swift-s3-sync","forks_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/forks","keys_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/teams","hooks_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/hooks","issue_events_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/events{/number}","events_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/events","assignees_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/assignees{/user}","branches_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/branches{/branch}","tags_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/tags","blobs_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/languages","stargazers_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/stargazers","contributors_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/contributors","subscribers_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/subscribers","subscription_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/subscription","commits_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/contents/{+path}","compare_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/merges","archive_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/downloads","issues_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues{/number}","pulls_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/labels{/name}","releases_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/releases{/id}","deployments_url":"https://api.github.com/repos/swiftstack/swift-s3-sync/deployments","created_at":"2016-05-17T00:20:29Z","updated_at":"2018-05-07T23:46:45Z","pushed_at":"2018-05-08T00:26:01Z","git_url":"git://github.com/swiftstack/swift-s3-sync.git","ssh_url":"git@github.com:swiftstack/swift-s3-sync.git","clone_url":"https://github.com/swiftstack/swift-s3-sync.git","svn_url":"https://github.com/swiftstack/swift-s3-sync","homepage":"","size":826,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":8,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106"},"html":{"href":"https://github.com/swiftstack/swift-s3-sync/pull/106"},"issue":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/106"},"comments":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/swiftstack/swift-s3-sync/statuses/949d15343850c1f3a7fad284446ca46a76ea6dce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mdegerne"}}