{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/zalenium/pulls/comments/177962800","pull_request_review_id":107935930,"id":177962800,"diff_hunk":"@@ -16,8 +16,7 @@\n # By default we only configure a ConsoleHandler, which will only\n # show messages at the INFO and above levels.\n #handlers= java.util.logging.ConsoleHandler\n-handlers= java.util.logging.FileHandler, java.util.logging.ConsoleHandler\n-\n+handlers = org.slf4j.bridge.SLF4JBridgeHandler","path":"src/main/resources/logging_info.properties","position":6,"original_position":6,"commit_id":"b5e2a0c385f1d8b9c90146b80f9a323dfcfebc6c","original_commit_id":"b5e2a0c385f1d8b9c90146b80f9a323dfcfebc6c","user":{"login":"dennisgranath","id":9192644,"avatar_url":"https://avatars2.githubusercontent.com/u/9192644?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisgranath","html_url":"https://github.com/dennisgranath","followers_url":"https://api.github.com/users/dennisgranath/followers","following_url":"https://api.github.com/users/dennisgranath/following{/other_user}","gists_url":"https://api.github.com/users/dennisgranath/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisgranath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisgranath/subscriptions","organizations_url":"https://api.github.com/users/dennisgranath/orgs","repos_url":"https://api.github.com/users/dennisgranath/repos","events_url":"https://api.github.com/users/dennisgranath/events{/privacy}","received_events_url":"https://api.github.com/users/dennisgranath/received_events","type":"User","site_admin":false},"body":"Just one note here. If someone is dependent on that logs are written to a file I think we need to add an optional filehandler in logback.xml.","created_at":"2018-03-29T06:26:09Z","updated_at":"2018-03-29T06:26:10Z","html_url":"https://github.com/zalando/zalenium/pull/501#discussion_r177962800","pull_request_url":"https://api.github.com/repos/zalando/zalenium/pulls/501","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/comments/177962800"},"html":{"href":"https://github.com/zalando/zalenium/pull/501#discussion_r177962800"},"pull_request":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/zalenium/pulls/501","id":178016891,"html_url":"https://github.com/zalando/zalenium/pull/501","diff_url":"https://github.com/zalando/zalenium/pull/501.diff","patch_url":"https://github.com/zalando/zalenium/pull/501.patch","issue_url":"https://api.github.com/repos/zalando/zalenium/issues/501","number":501,"state":"closed","locked":false,"title":"Improve logging by introducing slf4j and logback","user":{"login":"dennisgranath","id":9192644,"avatar_url":"https://avatars2.githubusercontent.com/u/9192644?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisgranath","html_url":"https://github.com/dennisgranath","followers_url":"https://api.github.com/users/dennisgranath/followers","following_url":"https://api.github.com/users/dennisgranath/following{/other_user}","gists_url":"https://api.github.com/users/dennisgranath/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisgranath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisgranath/subscriptions","organizations_url":"https://api.github.com/users/dennisgranath/orgs","repos_url":"https://api.github.com/users/dennisgranath/repos","events_url":"https://api.github.com/users/dennisgranath/events{/privacy}","received_events_url":"https://api.github.com/users/dennisgranath/received_events","type":"User","site_admin":false},"body":"### Description\r\nChange logging from java util logging (jul) to slf4j. Add option to log in jsonFormat with command line argument --logJson. All \"native\" selenium logs are sent to logback using jul-to-slf4j by setting the SLF4JBridgeHandler (logging_info.properties). In order to that in a smooth way i added the selenium jar into the resulting zalenium.jar.\r\n\r\n### Motivation and Context\r\nWe would like to be able to log in json output and add support for MDC (mapped diagnotic context). Using this approach one could build dashboards in tools like for example kibana. \r\n\r\n### How Has This Been Tested?\r\n- Unit tests run\r\n- Manual testing of DockerSeleniumStarterProxy and BrowserStackProxy\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] All new and existing tests passed.\r\n<!--- Provide a general summary of your changes in the Title above -->","created_at":"2018-03-28T12:06:03Z","updated_at":"2018-03-29T06:26:10Z","closed_at":"2018-03-28T19:31:46Z","merged_at":"2018-03-28T19:31:46Z","merge_commit_sha":"d9d08f2fa977309b2d148f32bcea3e44c2ee5854","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/zalenium/pulls/501/commits","review_comments_url":"https://api.github.com/repos/zalando/zalenium/pulls/501/comments","review_comment_url":"https://api.github.com/repos/zalando/zalenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/zalenium/issues/501/comments","statuses_url":"https://api.github.com/repos/zalando/zalenium/statuses/b5e2a0c385f1d8b9c90146b80f9a323dfcfebc6c","head":{"label":"dennisgranath:use_slf4j_and_logback","ref":"use_slf4j_and_logback","sha":"b5e2a0c385f1d8b9c90146b80f9a323dfcfebc6c","user":{"login":"dennisgranath","id":9192644,"avatar_url":"https://avatars2.githubusercontent.com/u/9192644?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisgranath","html_url":"https://github.com/dennisgranath","followers_url":"https://api.github.com/users/dennisgranath/followers","following_url":"https://api.github.com/users/dennisgranath/following{/other_user}","gists_url":"https://api.github.com/users/dennisgranath/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisgranath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisgranath/subscriptions","organizations_url":"https://api.github.com/users/dennisgranath/orgs","repos_url":"https://api.github.com/users/dennisgranath/repos","events_url":"https://api.github.com/users/dennisgranath/events{/privacy}","received_events_url":"https://api.github.com/users/dennisgranath/received_events","type":"User","site_admin":false},"repo":{"id":125978903,"name":"zalenium","full_name":"dennisgranath/zalenium","owner":{"login":"dennisgranath","id":9192644,"avatar_url":"https://avatars2.githubusercontent.com/u/9192644?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisgranath","html_url":"https://github.com/dennisgranath","followers_url":"https://api.github.com/users/dennisgranath/followers","following_url":"https://api.github.com/users/dennisgranath/following{/other_user}","gists_url":"https://api.github.com/users/dennisgranath/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisgranath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisgranath/subscriptions","organizations_url":"https://api.github.com/users/dennisgranath/orgs","repos_url":"https://api.github.com/users/dennisgranath/repos","events_url":"https://api.github.com/users/dennisgranath/events{/privacy}","received_events_url":"https://api.github.com/users/dennisgranath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennisgranath/zalenium","description":"Allows anyone to have a disposable, flexible, container based Selenium Grid infrastructure featuring video recording, live preview, basic auth & online/offline dashboards","fork":true,"url":"https://api.github.com/repos/dennisgranath/zalenium","forks_url":"https://api.github.com/repos/dennisgranath/zalenium/forks","keys_url":"https://api.github.com/repos/dennisgranath/zalenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennisgranath/zalenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennisgranath/zalenium/teams","hooks_url":"https://api.github.com/repos/dennisgranath/zalenium/hooks","issue_events_url":"https://api.github.com/repos/dennisgranath/zalenium/issues/events{/number}","events_url":"https://api.github.com/repos/dennisgranath/zalenium/events","assignees_url":"https://api.github.com/repos/dennisgranath/zalenium/assignees{/user}","branches_url":"https://api.github.com/repos/dennisgranath/zalenium/branches{/branch}","tags_url":"https://api.github.com/repos/dennisgranath/zalenium/tags","blobs_url":"https://api.github.com/repos/dennisgranath/zalenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennisgranath/zalenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennisgranath/zalenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennisgranath/zalenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennisgranath/zalenium/statuses/{sha}","languages_url":"https://api.github.com/repos/dennisgranath/zalenium/languages","stargazers_url":"https://api.github.com/repos/dennisgranath/zalenium/stargazers","contributors_url":"https://api.github.com/repos/dennisgranath/zalenium/contributors","subscribers_url":"https://api.github.com/repos/dennisgranath/zalenium/subscribers","subscription_url":"https://api.github.com/repos/dennisgranath/zalenium/subscription","commits_url":"https://api.github.com/repos/dennisgranath/zalenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennisgranath/zalenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennisgranath/zalenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennisgranath/zalenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/dennisgranath/zalenium/contents/{+path}","compare_url":"https://api.github.com/repos/dennisgranath/zalenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennisgranath/zalenium/merges","archive_url":"https://api.github.com/repos/dennisgranath/zalenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennisgranath/zalenium/downloads","issues_url":"https://api.github.com/repos/dennisgranath/zalenium/issues{/number}","pulls_url":"https://api.github.com/repos/dennisgranath/zalenium/pulls{/number}","milestones_url":"https://api.github.com/repos/dennisgranath/zalenium/milestones{/number}","notifications_url":"https://api.github.com/repos/dennisgranath/zalenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennisgranath/zalenium/labels{/name}","releases_url":"https://api.github.com/repos/dennisgranath/zalenium/releases{/id}","deployments_url":"https://api.github.com/repos/dennisgranath/zalenium/deployments","created_at":"2018-03-20T07:39:22Z","updated_at":"2018-03-20T07:39:24Z","pushed_at":"2018-03-28T12:03:20Z","git_url":"git://github.com/dennisgranath/zalenium.git","ssh_url":"git@github.com:dennisgranath/zalenium.git","clone_url":"https://github.com/dennisgranath/zalenium.git","svn_url":"https://github.com/dennisgranath/zalenium","homepage":"https://zalando.github.io/zalenium/","size":12450,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:merge-501","ref":"merge-501","sha":"0ace27d3d87db94ce0a5337a0bd63277d2c6bbce","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":69958211,"name":"zalenium","full_name":"zalando/zalenium","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/zalenium","description":"Allows anyone to have a disposable, flexible, container based Selenium Grid infrastructure featuring video recording, live preview, basic auth & online/offline dashboards","fork":false,"url":"https://api.github.com/repos/zalando/zalenium","forks_url":"https://api.github.com/repos/zalando/zalenium/forks","keys_url":"https://api.github.com/repos/zalando/zalenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/zalenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/zalenium/teams","hooks_url":"https://api.github.com/repos/zalando/zalenium/hooks","issue_events_url":"https://api.github.com/repos/zalando/zalenium/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/zalenium/events","assignees_url":"https://api.github.com/repos/zalando/zalenium/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/zalenium/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/zalenium/tags","blobs_url":"https://api.github.com/repos/zalando/zalenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/zalenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/zalenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/zalenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/zalenium/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/zalenium/languages","stargazers_url":"https://api.github.com/repos/zalando/zalenium/stargazers","contributors_url":"https://api.github.com/repos/zalando/zalenium/contributors","subscribers_url":"https://api.github.com/repos/zalando/zalenium/subscribers","subscription_url":"https://api.github.com/repos/zalando/zalenium/subscription","commits_url":"https://api.github.com/repos/zalando/zalenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/zalenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/zalenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/zalenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/zalenium/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/zalenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/zalenium/merges","archive_url":"https://api.github.com/repos/zalando/zalenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/zalenium/downloads","issues_url":"https://api.github.com/repos/zalando/zalenium/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/zalenium/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/zalenium/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/zalenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/zalenium/labels{/name}","releases_url":"https://api.github.com/repos/zalando/zalenium/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/zalenium/deployments","created_at":"2016-10-04T11:23:35Z","updated_at":"2018-03-28T14:34:30Z","pushed_at":"2018-03-28T19:32:30Z","git_url":"git://github.com/zalando/zalenium.git","ssh_url":"git@github.com:zalando/zalenium.git","clone_url":"https://github.com/zalando/zalenium.git","svn_url":"https://github.com/zalando/zalenium","homepage":"https://zalando.github.io/zalenium/","size":12451,"stargazers_count":803,"watchers_count":803,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":134,"open_issues":25,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/501"},"html":{"href":"https://github.com/zalando/zalenium/pull/501"},"issue":{"href":"https://api.github.com/repos/zalando/zalenium/issues/501"},"comments":{"href":"https://api.github.com/repos/zalando/zalenium/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/zalenium/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/zalenium/statuses/b5e2a0c385f1d8b9c90146b80f9a323dfcfebc6c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dennisgranath"}}