{"action":"opened","number":132,"pull_request":{"url":"https://api.github.com/repos/mrkite/minutor/pulls/132","id":205798268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Nzk4MjY4","html_url":"https://github.com/mrkite/minutor/pull/132","diff_url":"https://github.com/mrkite/minutor/pull/132.diff","patch_url":"https://github.com/mrkite/minutor/pull/132.patch","issue_url":"https://api.github.com/repos/mrkite/minutor/issues/132","number":132,"state":"open","locked":false,"title":"backwards compatible 1.13 translation layer","user":{"login":"EtlamGit","id":5821779,"node_id":"MDQ6VXNlcjU4MjE3Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5821779?v=4","gravatar_id":"","url":"https://api.github.com/users/EtlamGit","html_url":"https://github.com/EtlamGit","followers_url":"https://api.github.com/users/EtlamGit/followers","following_url":"https://api.github.com/users/EtlamGit/following{/other_user}","gists_url":"https://api.github.com/users/EtlamGit/gists{/gist_id}","starred_url":"https://api.github.com/users/EtlamGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EtlamGit/subscriptions","organizations_url":"https://api.github.com/users/EtlamGit/orgs","repos_url":"https://api.github.com/users/EtlamGit/repos","events_url":"https://api.github.com/users/EtlamGit/events{/privacy}","received_events_url":"https://api.github.com/users/EtlamGit/received_events","type":"User","site_admin":false},"body":"This is the first approach to be able to load old and 1.13 version maps with the same version of Minutor.\r\n\r\nAt least here it is working with different maps. Some trillion block definitions are still missing, as Mojang renamed also a lot of blocks: https://minecraft.gamepedia.com/1.13/Flattening#Block_and_Item_IDs\r\nI have added them for grass_block, tall_grass and vine just for test purpose. As they are highlighted and named in Minutor it should be easy to rule that out.\r\n\r\nThere are several other drawbacks in the new 1.13 definitions and code. I will try to address some of them in the rest of the year, but for now we have same starting point.\r\n* definitions are way from complete, also colors for added blocks are wrong\r\n* performance is very slow, this is probably because of all that strings. I will try to replace that with hashes.\r\n\r\n(now pulling to correct branch)","created_at":"2018-08-02T16:50:20Z","updated_at":"2018-08-02T16:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrkite/minutor/pulls/132/commits","review_comments_url":"https://api.github.com/repos/mrkite/minutor/pulls/132/comments","review_comment_url":"https://api.github.com/repos/mrkite/minutor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrkite/minutor/issues/132/comments","statuses_url":"https://api.github.com/repos/mrkite/minutor/statuses/d10052efba2580b1a5f40a95955ef3c0ee920953","head":{"label":"EtlamGit:upstream/m1.13","ref":"upstream/m1.13","sha":"d10052efba2580b1a5f40a95955ef3c0ee920953","user":{"login":"EtlamGit","id":5821779,"node_id":"MDQ6VXNlcjU4MjE3Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5821779?v=4","gravatar_id":"","url":"https://api.github.com/users/EtlamGit","html_url":"https://github.com/EtlamGit","followers_url":"https://api.github.com/users/EtlamGit/followers","following_url":"https://api.github.com/users/EtlamGit/following{/other_user}","gists_url":"https://api.github.com/users/EtlamGit/gists{/gist_id}","starred_url":"https://api.github.com/users/EtlamGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EtlamGit/subscriptions","organizations_url":"https://api.github.com/users/EtlamGit/orgs","repos_url":"https://api.github.com/users/EtlamGit/repos","events_url":"https://api.github.com/users/EtlamGit/events{/privacy}","received_events_url":"https://api.github.com/users/EtlamGit/received_events","type":"User","site_admin":false},"repo":{"id":15903733,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkwMzczMw==","name":"minutor","full_name":"EtlamGit/minutor","owner":{"login":"EtlamGit","id":5821779,"node_id":"MDQ6VXNlcjU4MjE3Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5821779?v=4","gravatar_id":"","url":"https://api.github.com/users/EtlamGit","html_url":"https://github.com/EtlamGit","followers_url":"https://api.github.com/users/EtlamGit/followers","following_url":"https://api.github.com/users/EtlamGit/following{/other_user}","gists_url":"https://api.github.com/users/EtlamGit/gists{/gist_id}","starred_url":"https://api.github.com/users/EtlamGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EtlamGit/subscriptions","organizations_url":"https://api.github.com/users/EtlamGit/orgs","repos_url":"https://api.github.com/users/EtlamGit/repos","events_url":"https://api.github.com/users/EtlamGit/events{/privacy}","received_events_url":"https://api.github.com/users/EtlamGit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EtlamGit/minutor","description":"Mapping for Minecraft","fork":true,"url":"https://api.github.com/repos/EtlamGit/minutor","forks_url":"https://api.github.com/repos/EtlamGit/minutor/forks","keys_url":"https://api.github.com/repos/EtlamGit/minutor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EtlamGit/minutor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EtlamGit/minutor/teams","hooks_url":"https://api.github.com/repos/EtlamGit/minutor/hooks","issue_events_url":"https://api.github.com/repos/EtlamGit/minutor/issues/events{/number}","events_url":"https://api.github.com/repos/EtlamGit/minutor/events","assignees_url":"https://api.github.com/repos/EtlamGit/minutor/assignees{/user}","branches_url":"https://api.github.com/repos/EtlamGit/minutor/branches{/branch}","tags_url":"https://api.github.com/repos/EtlamGit/minutor/tags","blobs_url":"https://api.github.com/repos/EtlamGit/minutor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EtlamGit/minutor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EtlamGit/minutor/git/refs{/sha}","trees_url":"https://api.github.com/repos/EtlamGit/minutor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EtlamGit/minutor/statuses/{sha}","languages_url":"https://api.github.com/repos/EtlamGit/minutor/languages","stargazers_url":"https://api.github.com/repos/EtlamGit/minutor/stargazers","contributors_url":"https://api.github.com/repos/EtlamGit/minutor/contributors","subscribers_url":"https://api.github.com/repos/EtlamGit/minutor/subscribers","subscription_url":"https://api.github.com/repos/EtlamGit/minutor/subscription","commits_url":"https://api.github.com/repos/EtlamGit/minutor/commits{/sha}","git_commits_url":"https://api.github.com/repos/EtlamGit/minutor/git/commits{/sha}","comments_url":"https://api.github.com/repos/EtlamGit/minutor/comments{/number}","issue_comment_url":"https://api.github.com/repos/EtlamGit/minutor/issues/comments{/number}","contents_url":"https://api.github.com/repos/EtlamGit/minutor/contents/{+path}","compare_url":"https://api.github.com/repos/EtlamGit/minutor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EtlamGit/minutor/merges","archive_url":"https://api.github.com/repos/EtlamGit/minutor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EtlamGit/minutor/downloads","issues_url":"https://api.github.com/repos/EtlamGit/minutor/issues{/number}","pulls_url":"https://api.github.com/repos/EtlamGit/minutor/pulls{/number}","milestones_url":"https://api.github.com/repos/EtlamGit/minutor/milestones{/number}","notifications_url":"https://api.github.com/repos/EtlamGit/minutor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EtlamGit/minutor/labels{/name}","releases_url":"https://api.github.com/repos/EtlamGit/minutor/releases{/id}","deployments_url":"https://api.github.com/repos/EtlamGit/minutor/deployments","created_at":"2014-01-14T14:04:12Z","updated_at":"2018-07-28T16:55:21Z","pushed_at":"2018-07-30T19:14:51Z","git_url":"git://github.com/EtlamGit/minutor.git","ssh_url":"git@github.com:EtlamGit/minutor.git","clone_url":"https://github.com/EtlamGit/minutor.git","svn_url":"https://github.com/EtlamGit/minutor","homepage":"http://seancode.com/minutor","size":1995,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrkite:m1.13","ref":"m1.13","sha":"c9901e040c54dcb128b40c6c69f5ad4f72a00c3f","user":{"login":"mrkite","id":788839,"node_id":"MDQ6VXNlcjc4ODgzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/788839?v=4","gravatar_id":"","url":"https://api.github.com/users/mrkite","html_url":"https://github.com/mrkite","followers_url":"https://api.github.com/users/mrkite/followers","following_url":"https://api.github.com/users/mrkite/following{/other_user}","gists_url":"https://api.github.com/users/mrkite/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkite/subscriptions","organizations_url":"https://api.github.com/users/mrkite/orgs","repos_url":"https://api.github.com/users/mrkite/repos","events_url":"https://api.github.com/users/mrkite/events{/privacy}","received_events_url":"https://api.github.com/users/mrkite/received_events","type":"User","site_admin":false},"repo":{"id":3641035,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQxMDM1","name":"minutor","full_name":"mrkite/minutor","owner":{"login":"mrkite","id":788839,"node_id":"MDQ6VXNlcjc4ODgzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/788839?v=4","gravatar_id":"","url":"https://api.github.com/users/mrkite","html_url":"https://github.com/mrkite","followers_url":"https://api.github.com/users/mrkite/followers","following_url":"https://api.github.com/users/mrkite/following{/other_user}","gists_url":"https://api.github.com/users/mrkite/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkite/subscriptions","organizations_url":"https://api.github.com/users/mrkite/orgs","repos_url":"https://api.github.com/users/mrkite/repos","events_url":"https://api.github.com/users/mrkite/events{/privacy}","received_events_url":"https://api.github.com/users/mrkite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrkite/minutor","description":"Mapping for Minecraft","fork":false,"url":"https://api.github.com/repos/mrkite/minutor","forks_url":"https://api.github.com/repos/mrkite/minutor/forks","keys_url":"https://api.github.com/repos/mrkite/minutor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrkite/minutor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrkite/minutor/teams","hooks_url":"https://api.github.com/repos/mrkite/minutor/hooks","issue_events_url":"https://api.github.com/repos/mrkite/minutor/issues/events{/number}","events_url":"https://api.github.com/repos/mrkite/minutor/events","assignees_url":"https://api.github.com/repos/mrkite/minutor/assignees{/user}","branches_url":"https://api.github.com/repos/mrkite/minutor/branches{/branch}","tags_url":"https://api.github.com/repos/mrkite/minutor/tags","blobs_url":"https://api.github.com/repos/mrkite/minutor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrkite/minutor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrkite/minutor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrkite/minutor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrkite/minutor/statuses/{sha}","languages_url":"https://api.github.com/repos/mrkite/minutor/languages","stargazers_url":"https://api.github.com/repos/mrkite/minutor/stargazers","contributors_url":"https://api.github.com/repos/mrkite/minutor/contributors","subscribers_url":"https://api.github.com/repos/mrkite/minutor/subscribers","subscription_url":"https://api.github.com/repos/mrkite/minutor/subscription","commits_url":"https://api.github.com/repos/mrkite/minutor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrkite/minutor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrkite/minutor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrkite/minutor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrkite/minutor/contents/{+path}","compare_url":"https://api.github.com/repos/mrkite/minutor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrkite/minutor/merges","archive_url":"https://api.github.com/repos/mrkite/minutor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrkite/minutor/downloads","issues_url":"https://api.github.com/repos/mrkite/minutor/issues{/number}","pulls_url":"https://api.github.com/repos/mrkite/minutor/pulls{/number}","milestones_url":"https://api.github.com/repos/mrkite/minutor/milestones{/number}","notifications_url":"https://api.github.com/repos/mrkite/minutor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrkite/minutor/labels{/name}","releases_url":"https://api.github.com/repos/mrkite/minutor/releases{/id}","deployments_url":"https://api.github.com/repos/mrkite/minutor/deployments","created_at":"2012-03-06T18:21:11Z","updated_at":"2018-07-28T07:40:24Z","pushed_at":"2018-07-31T00:02:19Z","git_url":"git://github.com/mrkite/minutor.git","ssh_url":"git@github.com:mrkite/minutor.git","clone_url":"https://github.com/mrkite/minutor.git","svn_url":"https://github.com/mrkite/minutor","homepage":"http://seancode.com/minutor","size":1964,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":25,"open_issues":21,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrkite/minutor/pulls/132"},"html":{"href":"https://github.com/mrkite/minutor/pull/132"},"issue":{"href":"https://api.github.com/repos/mrkite/minutor/issues/132"},"comments":{"href":"https://api.github.com/repos/mrkite/minutor/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/mrkite/minutor/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/mrkite/minutor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrkite/minutor/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/mrkite/minutor/statuses/d10052efba2580b1a5f40a95955ef3c0ee920953"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":5106,"deletions":2007,"changed_files":14}}
{"actor":{"display_login":"EtlamGit"}}