{"action":"created","issue":{"url":"https://api.github.com/repos/binast/binjs-ref/issues/144","repository_url":"https://api.github.com/repos/binast/binjs-ref","labels_url":"https://api.github.com/repos/binast/binjs-ref/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/binast/binjs-ref/issues/144/comments","events_url":"https://api.github.com/repos/binast/binjs-ref/issues/144/events","html_url":"https://github.com/binast/binjs-ref/pull/144","id":337010584,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzI2NDUz","number":144,"title":"Update idl to match ecmascript-binary-ast f2bbb2a69fa0d37a36efa70716cf7d6e5fe10851","user":{"login":"arai-a","id":6299746,"node_id":"MDQ6VXNlcjYyOTk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6299746?v=4","gravatar_id":"","url":"https://api.github.com/users/arai-a","html_url":"https://github.com/arai-a","followers_url":"https://api.github.com/users/arai-a/followers","following_url":"https://api.github.com/users/arai-a/following{/other_user}","gists_url":"https://api.github.com/users/arai-a/gists{/gist_id}","starred_url":"https://api.github.com/users/arai-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arai-a/subscriptions","organizations_url":"https://api.github.com/users/arai-a/orgs","repos_url":"https://api.github.com/users/arai-a/repos","events_url":"https://api.github.com/users/arai-a/events{/privacy}","received_events_url":"https://api.github.com/users/arai-a/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-29T14:01:06Z","updated_at":"2018-07-30T06:07:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/binast/binjs-ref/pulls/144","html_url":"https://github.com/binast/binjs-ref/pull/144","diff_url":"https://github.com/binast/binjs-ref/pull/144.diff","patch_url":"https://github.com/binast/binjs-ref/pull/144.patch"},"body":"to be clear, I don't intend do land this immediately.\r\ndiscussion is here: https://github.com/orgs/binast/teams/binast-core/discussions/7\r\n\r\nthis updates the in-tree idl and corresponding parts to match to the spec at the point of Jun 28.\r\nhttps://github.com/binast/ecmascript-binary-ast/commits/spec-draft\r\n\r\nThe main changes are:\r\n - AssertedDeclaredName/AssertedBoundName + AssertedDeclaredKind for scopes\r\n - Skippable interface to Lazy field\r\n   - skip/skipped implicit fields are removed, and {fieldname}_skip field is inserted before the lazy field, which has offset\r\n - separate Function and Contents\r\n - separate ArrowExpression for FunctionBody and Expression\r\n - scope is no more optional\r\n   - when converting from Shift's JSON, dummy scope object is created\r\n - version number is bumped"},"comment":{"url":"https://api.github.com/repos/binast/binjs-ref/issues/comments/408756707","html_url":"https://github.com/binast/binjs-ref/pull/144#issuecomment-408756707","issue_url":"https://api.github.com/repos/binast/binjs-ref/issues/144","id":408756707,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc1NjcwNw==","user":{"login":"arai-a","id":6299746,"node_id":"MDQ6VXNlcjYyOTk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6299746?v=4","gravatar_id":"","url":"https://api.github.com/users/arai-a","html_url":"https://github.com/arai-a","followers_url":"https://api.github.com/users/arai-a/followers","following_url":"https://api.github.com/users/arai-a/following{/other_user}","gists_url":"https://api.github.com/users/arai-a/gists{/gist_id}","starred_url":"https://api.github.com/users/arai-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arai-a/subscriptions","organizations_url":"https://api.github.com/users/arai-a/orgs","repos_url":"https://api.github.com/users/arai-a/repos","events_url":"https://api.github.com/users/arai-a/events{/privacy}","received_events_url":"https://api.github.com/users/arai-a/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T06:07:14Z","updated_at":"2018-07-30T06:07:14Z","author_association":"COLLABORATOR","body":"@efaust , @Yoric , can you review this?\r\n(I'm going to change the spec maybe shortly, but I think it worth updating binjs-ref to current spec, so that the subsequent update will be more smooth)"}}
{"actor":{"display_login":"arai-a"}}