{"action":"created","issue":{"url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/12","repository_url":"https://api.github.com/repos/cloudflare/lua-aho-corasick","labels_url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/12/comments","events_url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/12/events","html_url":"https://github.com/cloudflare/lua-aho-corasick/issues/12","id":383622593,"node_id":"MDU6SXNzdWUzODM2MjI1OTM=","number":12,"title":"CFLAGS etc.","user":{"login":"vcunat","id":1785925,"node_id":"MDQ6VXNlcjE3ODU5MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1785925?v=4","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-22T17:43:53Z","updated_at":"2018-12-13T14:39:51Z","closed_at":null,"author_association":"NONE","body":"When I see things like `-msse4.1` in `./Makefile`, I wonder whether you intend the master branch of this repo for general-purpose usage, e.g. ending up in distribution packages.  Should I make similar changes in a fork or shall we generalize it directly here, perhaps in a way that you might keep injecting such flags somehow?\r\n\r\nCurrently the binaries will end up in knot-resolver packages _with_ these flags (even on ARM :)  I suspect this will be a real problem for x86 systems without SSE 4.1, and most users surely won't notice a significant difference in speed if we drop these flags.  (I understand _you_ might notice the difference on CloudFlare servers.)"},"comment":{"url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/comments/446991161","html_url":"https://github.com/cloudflare/lua-aho-corasick/issues/12#issuecomment-446991161","issue_url":"https://api.github.com/repos/cloudflare/lua-aho-corasick/issues/12","id":446991161,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk5MTE2MQ==","user":{"login":"pspacek","id":11509590,"node_id":"MDQ6VXNlcjExNTA5NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/11509590?v=4","gravatar_id":"","url":"https://api.github.com/users/pspacek","html_url":"https://github.com/pspacek","followers_url":"https://api.github.com/users/pspacek/followers","following_url":"https://api.github.com/users/pspacek/following{/other_user}","gists_url":"https://api.github.com/users/pspacek/gists{/gist_id}","starred_url":"https://api.github.com/users/pspacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pspacek/subscriptions","organizations_url":"https://api.github.com/users/pspacek/orgs","repos_url":"https://api.github.com/users/pspacek/repos","events_url":"https://api.github.com/users/pspacek/events{/privacy}","received_events_url":"https://api.github.com/users/pspacek/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T14:39:51Z","updated_at":"2018-12-13T14:39:51Z","author_association":"NONE","body":"@vavrusa Could you please poke someone to get fixes merged? Thanks!"}}
{"actor":{"display_login":"pspacek"}}