{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/232723519","pull_request_review_id":173983082,"id":232723519,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjcyMzUxOQ==","diff_hunk":"@@ -119,6 +119,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.\n ## [4.0.0-preview] - 2018-09-28\n \n ### Added\n+- Added controls for linear fade at the boundary of density volumes","path":"com.unity.render-pipelines.high-definition/CHANGELOG.md","position":4,"original_position":4,"commit_id":"57442e06f549bc7e6417c77bb89751afdfa20a2b","original_commit_id":"57442e06f549bc7e6417c77bb89751afdfa20a2b","user":{"login":"sebastienlagarde","id":21238527,"node_id":"MDQ6VXNlcjIxMjM4NTI3","avatar_url":"https://avatars2.githubusercontent.com/u/21238527?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienlagarde","html_url":"https://github.com/sebastienlagarde","followers_url":"https://api.github.com/users/sebastienlagarde/followers","following_url":"https://api.github.com/users/sebastienlagarde/following{/other_user}","gists_url":"https://api.github.com/users/sebastienlagarde/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienlagarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienlagarde/subscriptions","organizations_url":"https://api.github.com/users/sebastienlagarde/orgs","repos_url":"https://api.github.com/users/sebastienlagarde/repos","events_url":"https://api.github.com/users/sebastienlagarde/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienlagarde/received_events","type":"User","site_admin":false},"body":"changelog are at the wrong place now :)","created_at":"2018-11-12T16:23:31Z","updated_at":"2018-11-12T16:23:31Z","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392#discussion_r232723519","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/232723519"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392#discussion_r232723519"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392","id":230182377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTgyMzc3","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392","diff_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392.diff","patch_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2392","number":2392,"state":"open","locked":false,"title":"HD Reflection System (DON'T MERGE)","user":{"login":"fredpointzero","id":1635937,"node_id":"MDQ6VXNlcjE2MzU5Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1635937?v=4","gravatar_id":"","url":"https://api.github.com/users/fredpointzero","html_url":"https://github.com/fredpointzero","followers_url":"https://api.github.com/users/fredpointzero/followers","following_url":"https://api.github.com/users/fredpointzero/following{/other_user}","gists_url":"https://api.github.com/users/fredpointzero/gists{/gist_id}","starred_url":"https://api.github.com/users/fredpointzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredpointzero/subscriptions","organizations_url":"https://api.github.com/users/fredpointzero/orgs","repos_url":"https://api.github.com/users/fredpointzero/repos","events_url":"https://api.github.com/users/fredpointzero/events{/privacy}","received_events_url":"https://api.github.com/users/fredpointzero/received_events","type":"User","site_admin":false},"body":"### Purpose of this PR\r\n\r\nHandle properly the baking and rendering of Reflection and Planar probes.\r\nProvides an API to bake or render Reflection or Planar probes from C#.\r\n\r\n---\r\n### Release Notes\r\n\r\nAdded new Reflection System to control Reflection and Planar probe baking and rendering.\r\n\r\n---\r\n### Testing status\r\n**Katana Tests**: First off we need to make sure the Katana SRP tests are green?\r\n\r\n**Manual Tests**:\r\n - Test continuous and manual baking on single/multiple scenes\r\n - Test baking of baked/custom reflection/planar probes\r\n - Test influence of probes\r\n\r\n**Automated Tests**:\r\n - Added EditMode tests to migrate probes from previous data layouts to the last one.\r\n\r\n---\r\n### Overall Product Risks\r\n**Technical Risk**: High\r\n\r\n**Halo Effect**: Medium\r\nAll environment lighting are involved.\r\n\r\n---\r\n### Comments to reviewers\r\nNotes for the reviewers you have assigned.\r\n","created_at":"2018-11-12T15:54:32Z","updated_at":"2018-11-12T16:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0a782cc99e72d5a5cd671613109d76da3534b2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":862572140,"node_id":"MDU6TGFiZWw4NjI1NzIxNDA=","url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels/HDRP","name":"HDRP","color":"dd75a6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2392/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/57442e06f549bc7e6417c77bb89751afdfa20a2b","head":{"label":"Unity-Technologies:HDRP/probeRenderAPI","ref":"HDRP/probeRenderAPI","sha":"57442e06f549bc7e6417c77bb89751afdfa20a2b","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3Mjc3OA==","name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2018-11-12T16:16:56Z","pushed_at":"2018-11-12T16:19:08Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":3184622,"stargazers_count":1346,"watchers_count":1346,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":306,"open_issues":58,"watchers":1346,"default_branch":"master"}},"base":{"label":"Unity-Technologies:master","ref":"master","sha":"1f9a695807cbdab65c5f99e38d0619b3a4408202","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3Mjc3OA==","name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2018-11-12T16:16:56Z","pushed_at":"2018-11-12T16:19:08Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":3184622,"stargazers_count":1346,"watchers_count":1346,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":306,"open_issues":58,"watchers":1346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2392"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2392"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2392/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2392/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/57442e06f549bc7e6417c77bb89751afdfa20a2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sebastienlagarde"}}