{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/189691268","pull_request_review_id":121919557,"id":189691268,"diff_hunk":"@@ -45,18 +45,30 @@ class TraceOfTab extends ComputedArtifact {\n       .filter(e => {\n         return e.cat.includes('blink.user_timing') ||\n           e.cat.includes('loading') ||\n-          e.cat.includes('devtools.timeline') ||\n-          e.name === 'TracingStartedInPage';","path":"lighthouse-core/gather/computed/trace-of-tab.js","position":5,"original_position":5,"commit_id":"def4e0980dc3353db9396bdab2029a395ab7df13","original_commit_id":"def4e0980dc3353db9396bdab2029a395ab7df13","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars3.githubusercontent.com/u/316891?v=4","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"also, does the filter now need to let through `e.name === 'TracingStartedInBrowser'` events?","created_at":"2018-05-21T19:36:44Z","updated_at":"2018-05-21T19:42:46Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/5271#discussion_r189691268","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/189691268"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/5271#discussion_r189691268"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271"}},"in_reply_to_id":189690835},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271","id":189163566,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/5271","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/5271.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/5271.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5271","number":5271,"state":"open","locked":false,"title":"core: Support traces with TracingStartedInBrowser event","user":{"login":"a1ph","id":5192288,"avatar_url":"https://avatars0.githubusercontent.com/u/5192288?v=4","gravatar_id":"","url":"https://api.github.com/users/a1ph","html_url":"https://github.com/a1ph","followers_url":"https://api.github.com/users/a1ph/followers","following_url":"https://api.github.com/users/a1ph/following{/other_user}","gists_url":"https://api.github.com/users/a1ph/gists{/gist_id}","starred_url":"https://api.github.com/users/a1ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a1ph/subscriptions","organizations_url":"https://api.github.com/users/a1ph/orgs","repos_url":"https://api.github.com/users/a1ph/repos","events_url":"https://api.github.com/users/a1ph/events{/privacy}","received_events_url":"https://api.github.com/users/a1ph/received_events","type":"User","site_admin":false},"body":"Since version 67 Chrome uses a new schema to describe page frame tree.\r\nThe tree is encoded within TracingStartedInBrowser trace event.\r\nThe patch makes lighthouse to support the new event.\r\nLegacy TracingStartedInPage event is going to the removed soon.","created_at":"2018-05-19T01:15:29Z","updated_at":"2018-05-21T19:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c5d9cbea21916d2cd481fa0eec12b4c59a3b73","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paulirish","id":39191,"avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars2.githubusercontent.com/u/2301202?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5271/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/def4e0980dc3353db9396bdab2029a395ab7df13","head":{"label":"a1ph:master","ref":"master","sha":"def4e0980dc3353db9396bdab2029a395ab7df13","user":{"login":"a1ph","id":5192288,"avatar_url":"https://avatars0.githubusercontent.com/u/5192288?v=4","gravatar_id":"","url":"https://api.github.com/users/a1ph","html_url":"https://github.com/a1ph","followers_url":"https://api.github.com/users/a1ph/followers","following_url":"https://api.github.com/users/a1ph/following{/other_user}","gists_url":"https://api.github.com/users/a1ph/gists{/gist_id}","starred_url":"https://api.github.com/users/a1ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a1ph/subscriptions","organizations_url":"https://api.github.com/users/a1ph/orgs","repos_url":"https://api.github.com/users/a1ph/repos","events_url":"https://api.github.com/users/a1ph/events{/privacy}","received_events_url":"https://api.github.com/users/a1ph/received_events","type":"User","site_admin":false},"repo":{"id":134007350,"name":"lighthouse","full_name":"a1ph/lighthouse","owner":{"login":"a1ph","id":5192288,"avatar_url":"https://avatars0.githubusercontent.com/u/5192288?v=4","gravatar_id":"","url":"https://api.github.com/users/a1ph","html_url":"https://github.com/a1ph","followers_url":"https://api.github.com/users/a1ph/followers","following_url":"https://api.github.com/users/a1ph/following{/other_user}","gists_url":"https://api.github.com/users/a1ph/gists{/gist_id}","starred_url":"https://api.github.com/users/a1ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a1ph/subscriptions","organizations_url":"https://api.github.com/users/a1ph/orgs","repos_url":"https://api.github.com/users/a1ph/repos","events_url":"https://api.github.com/users/a1ph/events{/privacy}","received_events_url":"https://api.github.com/users/a1ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a1ph/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":true,"url":"https://api.github.com/repos/a1ph/lighthouse","forks_url":"https://api.github.com/repos/a1ph/lighthouse/forks","keys_url":"https://api.github.com/repos/a1ph/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a1ph/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a1ph/lighthouse/teams","hooks_url":"https://api.github.com/repos/a1ph/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/a1ph/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/a1ph/lighthouse/events","assignees_url":"https://api.github.com/repos/a1ph/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/a1ph/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/a1ph/lighthouse/tags","blobs_url":"https://api.github.com/repos/a1ph/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a1ph/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a1ph/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/a1ph/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a1ph/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/a1ph/lighthouse/languages","stargazers_url":"https://api.github.com/repos/a1ph/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/a1ph/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/a1ph/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/a1ph/lighthouse/subscription","commits_url":"https://api.github.com/repos/a1ph/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/a1ph/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/a1ph/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/a1ph/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/a1ph/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/a1ph/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a1ph/lighthouse/merges","archive_url":"https://api.github.com/repos/a1ph/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a1ph/lighthouse/downloads","issues_url":"https://api.github.com/repos/a1ph/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/a1ph/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/a1ph/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/a1ph/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a1ph/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/a1ph/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/a1ph/lighthouse/deployments","created_at":"2018-05-18T21:50:51Z","updated_at":"2018-05-19T01:14:26Z","pushed_at":"2018-05-19T01:14:24Z","git_url":"git://github.com/a1ph/lighthouse.git","ssh_url":"git@github.com:a1ph/lighthouse.git","clone_url":"https://github.com/a1ph/lighthouse.git","svn_url":"https://github.com/a1ph/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":22726,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"1b5bf18ad05758a5eae4a94794ce1ea8f2469b99","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-05-21T19:42:45Z","pushed_at":"2018-05-21T18:25:25Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":22655,"stargazers_count":13522,"watchers_count":13522,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":3004,"mirror_url":null,"archived":false,"open_issues_count":375,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3004,"open_issues":375,"watchers":13522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/5271"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5271"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/5271/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/5271/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/def4e0980dc3353db9396bdab2029a395ab7df13"}},"author_association":"NONE"}}
{"actor":{"display_login":"brendankenny"}}