{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/190904342","pull_request_review_id":123384673,"id":190904342,"diff_hunk":"@@ -42,24 +42,28 @@\n               \" such as hbase-site.xml and core-site.xml for kerberos, \" +\n               \"including full paths to the files.\")\n             .addValidator(new ConfigFilesValidator())\n+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)\n             .build();\n \n     PropertyDescriptor ZOOKEEPER_QUORUM = new PropertyDescriptor.Builder()\n             .name(\"ZooKeeper Quorum\")\n             .description(\"Comma-separated list of ZooKeeper hosts for HBase. Required if Hadoop Configuration Files are not provided.\")\n             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)\n+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)\n             .build();\n \n     PropertyDescriptor ZOOKEEPER_CLIENT_PORT = new PropertyDescriptor.Builder()\n             .name(\"ZooKeeper Client Port\")\n             .description(\"The port on which ZooKeeper is accepting client connections. Required if Hadoop Configuration Files are not provided.\")\n             .addValidator(StandardValidators.PORT_VALIDATOR)\n+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)\n             .build();\n \n     PropertyDescriptor ZOOKEEPER_ZNODE_PARENT = new PropertyDescriptor.Builder()\n             .name(\"ZooKeeper ZNode Parent\")\n             .description(\"The ZooKeeper ZNode Parent value for HBase (example: /hbase). Required if Hadoop Configuration Files are not provided.\")\n             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)\n+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)\n             .build();\n \n     PropertyDescriptor HBASE_CLIENT_RETRIES = new PropertyDescriptor.Builder()","path":"nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java","position":28,"original_position":28,"commit_id":"d5b92ba29f04d37f136f72b06cee6c607bcdd02c","original_commit_id":"92792d3e82ec39fd27f8ca8e3a5ea353a21933a9","user":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"body":"doh... good catch","created_at":"2018-05-25T14:04:38Z","updated_at":"2018-05-25T14:04:39Z","html_url":"https://github.com/apache/nifi/pull/2738#discussion_r190904342","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/2738","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/190904342"},"html":{"href":"https://github.com/apache/nifi/pull/2738#discussion_r190904342"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/2738"}},"in_reply_to_id":190710420},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2738","id":190315060,"html_url":"https://github.com/apache/nifi/pull/2738","diff_url":"https://github.com/apache/nifi/pull/2738.diff","patch_url":"https://github.com/apache/nifi/pull/2738.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/2738","number":2738,"state":"open","locked":false,"title":"NIFI-5233 - Add EL support with Variable Registry scope for HBase cli…","user":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"body":"…ent service\r\n\r\nThank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2018-05-24T14:42:53Z","updated_at":"2018-05-25T14:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd9791ba17144aa0300967431ec30d8399880384","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/2738/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/2738/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2738/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/d5b92ba29f04d37f136f72b06cee6c607bcdd02c","head":{"label":"pvillard31:NIFI-5233","ref":"NIFI-5233","sha":"d5b92ba29f04d37f136f72b06cee6c607bcdd02c","user":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"repo":{"id":51175123,"name":"nifi","full_name":"pvillard31/nifi","owner":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvillard31/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/pvillard31/nifi","forks_url":"https://api.github.com/repos/pvillard31/nifi/forks","keys_url":"https://api.github.com/repos/pvillard31/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvillard31/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvillard31/nifi/teams","hooks_url":"https://api.github.com/repos/pvillard31/nifi/hooks","issue_events_url":"https://api.github.com/repos/pvillard31/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/pvillard31/nifi/events","assignees_url":"https://api.github.com/repos/pvillard31/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/pvillard31/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/pvillard31/nifi/tags","blobs_url":"https://api.github.com/repos/pvillard31/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvillard31/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvillard31/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvillard31/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvillard31/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/pvillard31/nifi/languages","stargazers_url":"https://api.github.com/repos/pvillard31/nifi/stargazers","contributors_url":"https://api.github.com/repos/pvillard31/nifi/contributors","subscribers_url":"https://api.github.com/repos/pvillard31/nifi/subscribers","subscription_url":"https://api.github.com/repos/pvillard31/nifi/subscription","commits_url":"https://api.github.com/repos/pvillard31/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvillard31/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvillard31/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvillard31/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvillard31/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/pvillard31/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvillard31/nifi/merges","archive_url":"https://api.github.com/repos/pvillard31/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvillard31/nifi/downloads","issues_url":"https://api.github.com/repos/pvillard31/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/pvillard31/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/pvillard31/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/pvillard31/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvillard31/nifi/labels{/name}","releases_url":"https://api.github.com/repos/pvillard31/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/pvillard31/nifi/deployments","created_at":"2016-02-05T21:27:44Z","updated_at":"2018-05-25T10:39:50Z","pushed_at":"2018-05-25T14:04:29Z","git_url":"git://github.com/pvillard31/nifi.git","ssh_url":"git@github.com:pvillard31/nifi.git","clone_url":"https://github.com/pvillard31/nifi.git","svn_url":"https://github.com/pvillard31/nifi","homepage":"","size":120579,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cf6089196f7780e546bdd9d36ce52f535149fabf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2018-05-25T12:55:30Z","pushed_at":"2018-05-25T14:04:31Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":121961,"stargazers_count":952,"watchers_count":952,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":910,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":910,"open_issues":124,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/2738"},"html":{"href":"https://github.com/apache/nifi/pull/2738"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/2738"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/2738/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/2738/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/2738/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/d5b92ba29f04d37f136f72b06cee6c607bcdd02c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pvillard31"}}