{"action":"created","issue":{"url":"https://api.github.com/repos/bobthecow/psysh/issues/488","repository_url":"https://api.github.com/repos/bobthecow/psysh","labels_url":"https://api.github.com/repos/bobthecow/psysh/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/bobthecow/psysh/issues/488/comments","events_url":"https://api.github.com/repos/bobthecow/psysh/issues/488/events","html_url":"https://github.com/bobthecow/psysh/pull/488","id":317919406,"number":488,"title":"Switch to Box","user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-26T08:06:06Z","updated_at":"2018-05-06T00:31:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bobthecow/psysh/pulls/488","html_url":"https://github.com/bobthecow/psysh/pull/488","diff_url":"https://github.com/bobthecow/psysh/pull/488.diff","patch_url":"https://github.com/bobthecow/psysh/pull/488.patch"},"body":"As promised somewhere, here's the PR to switch to [Box](https://github.com/humbug/box/issues/19) to build the PHAR.\r\n\r\nI used a `Makefile` here because I would like to propose it as a new tool instead of the bash files. Indeed in think it has a few advantages:\r\n\r\n- There is a better discoverability of the available commands\r\n- It is easier to declare dependencies and achieve that `make smth` and it will just work experience, all the necessary stuff will be installed for you.\r\n\r\nAs an example, clone the project and type `make build` and it will just work: no need to concern yourself with installing the dependencies & co.\r\n\r\nThere is still stuff to improve in this PR (or can be done in another):\r\n\r\n- [x] Build all the PHARs: I see that you have a dedicated compat and PHP 5.4 files, those are still missing\r\n- [ ] Add an e2e tests for the PHARs, eventually via Docker for the old PHP versions. Building a PHAR is not a trivial process the code may easily break in it\r\n- [ ] Isolate the PHAR, to be done in another PR I think\r\n\r\nFor reference the PHAR you are publishing is 1.4MB (from the last release). The one built with Box is `649.59KB` so it's a nice improvement 😄 \r\n\r\nI'm also not sure to understand why we are using the local autoload when inside the PsySH project?"},"comment":{"url":"https://api.github.com/repos/bobthecow/psysh/issues/comments/386844795","html_url":"https://github.com/bobthecow/psysh/pull/488#issuecomment-386844795","issue_url":"https://api.github.com/repos/bobthecow/psysh/issues/488","id":386844795,"user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"created_at":"2018-05-06T00:31:11Z","updated_at":"2018-05-06T00:31:11Z","author_association":"CONTRIBUTOR","body":">I'm still seeing ~1.7MB box-build phars, at a minimum. How did you get 649KB?\r\n\r\nI see the same, they were just compressed at one point which you probably don't want unless you don't mind the PHAR not being usable because the user does not have the `zlib` extension loaded"}}
{"actor":{"display_login":"theofidry"}}