{"action":"created","issue":{"url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/227","repository_url":"https://api.github.com/repos/mapgears/ol3-google-maps","labels_url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/227/comments","events_url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/227/events","html_url":"https://github.com/mapgears/ol3-google-maps/pull/227","id":343154882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODg1OTcw","number":227,"title":"OpenLayers 5 support, olgm package, workflow changes and ES modules","user":{"login":"JamiesWhiteShirt","id":5446387,"node_id":"MDQ6VXNlcjU0NDYzODc=","avatar_url":"https://avatars0.githubusercontent.com/u/5446387?v=4","gravatar_id":"","url":"https://api.github.com/users/JamiesWhiteShirt","html_url":"https://github.com/JamiesWhiteShirt","followers_url":"https://api.github.com/users/JamiesWhiteShirt/followers","following_url":"https://api.github.com/users/JamiesWhiteShirt/following{/other_user}","gists_url":"https://api.github.com/users/JamiesWhiteShirt/gists{/gist_id}","starred_url":"https://api.github.com/users/JamiesWhiteShirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamiesWhiteShirt/subscriptions","organizations_url":"https://api.github.com/users/JamiesWhiteShirt/orgs","repos_url":"https://api.github.com/users/JamiesWhiteShirt/repos","events_url":"https://api.github.com/users/JamiesWhiteShirt/events{/privacy}","received_events_url":"https://api.github.com/users/JamiesWhiteShirt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-07-20T15:39:13Z","updated_at":"2018-09-14T06:12:05Z","closed_at":"2018-08-21T13:07:18Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mapgears/ol3-google-maps/pulls/227","html_url":"https://github.com/mapgears/ol3-google-maps/pull/227","diff_url":"https://github.com/mapgears/ol3-google-maps/pull/227.diff","patch_url":"https://github.com/mapgears/ol3-google-maps/pull/227.patch"},"body":"This is a massive refactoring of ol3-google-maps to support OpenLayers 5, while at the same time inheriting other advancements of the OpenLayers development workflow.\r\n\r\nThe OpenLayers migration to version 5 has served as a guide for ours. The path of least resistance was to inherit their workflow rather than adapt the current one. I can understand how it could be a big undertaking to support OL-Google-Maps with all these changes and new things to learn, so I am willing to make changes to suit your preferences.\r\n\r\n# Notable changes\r\n* ES6 features, namely modules, classes and arrow functions.\r\n* The setup is simpler - no dependency on Java, Python or Make.\r\n* Deprecation of the name OL3-Google-Maps in favor of OL-Google-Maps. The major version of OpenLayers is no longer significant. I found this to be a good opportunity to change it.\r\n* Deprecation of the `ol3-google-maps` package in favor of a new `olgm` package.\r\n* `olgm` declares `ol` as a peer dependency, meaning `olgm` users can use new versions of `ol` straight away without waiting for `olgm` to update and bundle the new version.\r\n* The Google Maps API key used to testing and examples is provided as the environment variable `GOOGLE_MAPS_API_KEY` instead of having to be written to scattered files. This makes the workflow better in terms of both simplicity and source control compatibility.\r\n* No more Make - all tasks are performed with NPM scripts.\r\n* JSDoc site generation, defined and rendered in the style of OpenLayers.\r\n* Examples site generation, defined and rendered in the style of OpenLayers. [See OpenLayers examples](https://github.com/openlayers/openlayers/tree/master/examples)\r\n\r\n# Not included\r\n\r\n### Type checking\r\nWe currently have no type checking. A TypeScript type checking implementation is pending for OpenLayers. When it is ready we should be able to reuse the implementation. https://github.com/openlayers/openlayers/pull/8345\r\n\r\n### Legacy bundles\r\nOpenLayers distributes legacy builds of new versions behaving like the old closure bundles did. I expect that some users are interested in using OpenLayers 5 features with OL-Google-Maps as a legacy bundle.\r\n\r\nIt appears to be fairly straightforward to create legacy bundles containing both `ol` and `olgm`. This is not an ideal solution, because it requires keeping up with OpenLayers like we currently do.\r\n\r\nIdeally, an `olgm` legacy bundle could live alongside an `ol` legacy bundle. This appears to be technically possible, however, implementing this isn't very straightforward, and is left to implement in the future."},"comment":{"url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/comments/421242162","html_url":"https://github.com/mapgears/ol3-google-maps/pull/227#issuecomment-421242162","issue_url":"https://api.github.com/repos/mapgears/ol3-google-maps/issues/227","id":421242162,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTI0MjE2Mg==","user":{"login":"boomdrak","id":4997449,"node_id":"MDQ6VXNlcjQ5OTc0NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/4997449?v=4","gravatar_id":"","url":"https://api.github.com/users/boomdrak","html_url":"https://github.com/boomdrak","followers_url":"https://api.github.com/users/boomdrak/followers","following_url":"https://api.github.com/users/boomdrak/following{/other_user}","gists_url":"https://api.github.com/users/boomdrak/gists{/gist_id}","starred_url":"https://api.github.com/users/boomdrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boomdrak/subscriptions","organizations_url":"https://api.github.com/users/boomdrak/orgs","repos_url":"https://api.github.com/users/boomdrak/repos","events_url":"https://api.github.com/users/boomdrak/events{/privacy}","received_events_url":"https://api.github.com/users/boomdrak/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T06:12:05Z","updated_at":"2018-09-14T06:12:05Z","author_association":"NONE","body":"We have been using beta4 in our production environment for a months time now.\r\nNo issues or bugs met upon at this time.\r\n\r\nGood work! :)"}}
{"actor":{"display_login":"boomdrak"}}