{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/207484393","pull_request_review_id":143105294,"id":207484393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ4NDM5Mw==","diff_hunk":"@@ -50,6 +50,43 @@ $ kubectl describe deployment sparkoperator -n sparkoperator\n \n ```\n \n+### Metrics\n+\n+The operator exposes a set of metrics via the metric endpoint to be scraped by `Prometheus`.  If you would like to expose metrics, please install the operator via `kubectl apply -f manifest/spark-operator-with-metrics.yaml`.\n+This installs the operator with additional flag to enable metrics (`-enable-metrics=true`) as well as other annotations used by Prometheus to scrape the metric endpoint.\n+  \n+If enabled, the operator generates the following metrics:\n+\n+| Metric | Description |\n+| ------------- | ------------- |\n+| `spark_app_submit_count`  | Total number of SparkApplication submitted by the Operator.|\n+| `spark_app_success_count` | Total number of SparkApplication which completed successfully.|\n+| `spark_app_failure_count` | Total number of SparkApplication which failed to complete. |\n+| `spark_app_running_count` | Total number of SparkApplication which are currently running.|\n+| `spark_app_success_execution_time_microseconds` | Execution time for applications which succeeded.|\n+| `spark_app_failure_execution_time_microseconds` |Execution time for applications which failed. |\n+| `spark_app_executor_success_count` | Total number of Spark Executors which completed successfully. |\n+| `spark_app_executor_failure_count` | Total number of Spark Executors which failed. |\n+| `spark_app_executor_running_count` | Total number of Spark Executors which are currently running. |\n+\n+The following is a list of all the configurations the operators supports for metrics: \n+\n+```bash\n+-enable-metrics=true\n+-metrics-port=10254","path":"docs/quick-start-guide.md","position":27,"original_position":27,"commit_id":"3381ded7d2f93e993afdec85139eb2a81a73e601","original_commit_id":"f600336b353287b0cd983148071c2bf9640b1135","user":{"login":"akhurana001","id":34587798,"node_id":"MDQ6VXNlcjM0NTg3Nzk4","avatar_url":"https://avatars0.githubusercontent.com/u/34587798?v=4","gravatar_id":"","url":"https://api.github.com/users/akhurana001","html_url":"https://github.com/akhurana001","followers_url":"https://api.github.com/users/akhurana001/followers","following_url":"https://api.github.com/users/akhurana001/following{/other_user}","gists_url":"https://api.github.com/users/akhurana001/gists{/gist_id}","starred_url":"https://api.github.com/users/akhurana001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhurana001/subscriptions","organizations_url":"https://api.github.com/users/akhurana001/orgs","repos_url":"https://api.github.com/users/akhurana001/repos","events_url":"https://api.github.com/users/akhurana001/events{/privacy}","received_events_url":"https://api.github.com/users/akhurana001/received_events","type":"User","site_admin":false},"body":"sure, done","created_at":"2018-08-03T09:02:49Z","updated_at":"2018-08-03T09:02:49Z","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227#discussion_r207484393","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/207484393"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227#discussion_r207484393"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227"}},"in_reply_to_id":207437242},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227","id":203336978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzM2OTc4","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227","diff_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227.diff","patch_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227","number":227,"state":"open","locked":false,"title":"SparkOperator: Prometheus Metrics Integration","user":{"login":"akhurana001","id":34587798,"node_id":"MDQ6VXNlcjM0NTg3Nzk4","avatar_url":"https://avatars0.githubusercontent.com/u/34587798?v=4","gravatar_id":"","url":"https://api.github.com/users/akhurana001","html_url":"https://github.com/akhurana001","followers_url":"https://api.github.com/users/akhurana001/followers","following_url":"https://api.github.com/users/akhurana001/following{/other_user}","gists_url":"https://api.github.com/users/akhurana001/gists{/gist_id}","starred_url":"https://api.github.com/users/akhurana001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhurana001/subscriptions","organizations_url":"https://api.github.com/users/akhurana001/orgs","repos_url":"https://api.github.com/users/akhurana001/repos","events_url":"https://api.github.com/users/akhurana001/events{/privacy}","received_events_url":"https://api.github.com/users/akhurana001/received_events","type":"User","site_admin":false},"body":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/67","created_at":"2018-07-23T20:39:36Z","updated_at":"2018-08-03T09:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d357751a01bbb5e37ee500f2af6fc9ed58d5f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/3381ded7d2f93e993afdec85139eb2a81a73e601","head":{"label":"lyft:metrics","ref":"metrics","sha":"3381ded7d2f93e993afdec85139eb2a81a73e601","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":131327922,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMjc5MjI=","name":"spark-on-k8s-operator","full_name":"lyft/spark-on-k8s-operator","owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/spark-on-k8s-operator","description":"Fork of open-source project to allow launching containerized Spark on Kubernetes","fork":true,"url":"https://api.github.com/repos/lyft/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/deployments","created_at":"2018-04-27T17:48:01Z","updated_at":"2018-07-19T22:10:39Z","pushed_at":"2018-08-03T09:02:18Z","git_url":"git://github.com/lyft/spark-on-k8s-operator.git","ssh_url":"git@github.com:lyft/spark-on-k8s-operator.git","clone_url":"https://github.com/lyft/spark-on-k8s-operator.git","svn_url":"https://github.com/lyft/spark-on-k8s-operator","homepage":"","size":786,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"db08789ffe682b7fb31a1d58d2f06dd3485018c6","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":116165188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjUxODg=","name":"spark-on-k8s-operator","full_name":"GoogleCloudPlatform/spark-on-k8s-operator","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","description":"Kubernetes CRD operator for specifying and running Apache Spark applications idiomatically on Kubernetes. ","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/deployments","created_at":"2018-01-03T17:43:16Z","updated_at":"2018-08-03T04:11:52Z","pushed_at":"2018-08-03T09:02:21Z","git_url":"git://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","ssh_url":"git@github.com:GoogleCloudPlatform/spark-on-k8s-operator.git","clone_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","svn_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","homepage":"","size":727,"stargazers_count":152,"watchers_count":152,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":29,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/3381ded7d2f93e993afdec85139eb2a81a73e601"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akhurana001"}}