{"action":"created","issue":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2819","repository_url":"https://api.github.com/repos/umbraco/Umbraco-CMS","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2819/labels{/name}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2819/comments","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2819/events","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2819","id":345528163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjQwNTcy","number":2819,"title":"Change angular.mobile for Hammerjs","user":{"login":"ssougnez","id":10199821,"node_id":"MDQ6VXNlcjEwMTk5ODIx","avatar_url":"https://avatars1.githubusercontent.com/u/10199821?v=4","gravatar_id":"","url":"https://api.github.com/users/ssougnez","html_url":"https://github.com/ssougnez","followers_url":"https://api.github.com/users/ssougnez/followers","following_url":"https://api.github.com/users/ssougnez/following{/other_user}","gists_url":"https://api.github.com/users/ssougnez/gists{/gist_id}","starred_url":"https://api.github.com/users/ssougnez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssougnez/subscriptions","organizations_url":"https://api.github.com/users/ssougnez/orgs","repos_url":"https://api.github.com/users/ssougnez/repos","events_url":"https://api.github.com/users/ssougnez/events{/privacy}","received_events_url":"https://api.github.com/users/ssougnez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-29T12:46:41Z","updated_at":"2018-07-31T13:00:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/2819","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2819","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/2819.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/2819.patch"},"body":"### Prerequisites\r\n\r\n- [x] I have written a descriptive pull-request title\r\n- [x] I have linked this PR to an issue on the tracker at http://issues.umbraco.org\r\n\r\n### Description\r\n\r\nAs shown in [the screen cast attached to the issue tracker](http://issues.umbraco.org/_persistent/umb.webm?file=64-7073&v=0&c=true), it is currently impossible to select text into some input of the back office (the login screen, the search box in the tree, etc...). After investigation, it turns out that it is due to \"angular.mobile\" that messes up with some gesture.\r\n\r\nAs this is an annoying issue and as AngularJs announced that \"angular.mobile\" is not supported for AngularJs 1.7, this PR proposes a replacement of this library by HammerJs (following the recommendation of AngularJs team).\r\n\r\nThis PR simply remove references to \"angular.mobile\" and replaces them by \"HammerJs\". Some CSS classes have also been updated to allow \"HammerJs\" to work as expected.\r\n\r\nI tested the behavior of the back office with these changes and compared them with the one of the dev7 branch and it seems that there is no regression.\r\n\r\nMoreover, as \"angular.mobile\" is not supported by \"AngularJs\" 1.7, this PR can also be beneficial for Umbraco v8."},"comment":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments/409212150","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2819#issuecomment-409212150","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2819","id":409212150,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTIxMjE1MA==","user":{"login":"ssougnez","id":10199821,"node_id":"MDQ6VXNlcjEwMTk5ODIx","avatar_url":"https://avatars1.githubusercontent.com/u/10199821?v=4","gravatar_id":"","url":"https://api.github.com/users/ssougnez","html_url":"https://github.com/ssougnez","followers_url":"https://api.github.com/users/ssougnez/followers","following_url":"https://api.github.com/users/ssougnez/following{/other_user}","gists_url":"https://api.github.com/users/ssougnez/gists{/gist_id}","starred_url":"https://api.github.com/users/ssougnez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssougnez/subscriptions","organizations_url":"https://api.github.com/users/ssougnez/orgs","repos_url":"https://api.github.com/users/ssougnez/repos","events_url":"https://api.github.com/users/ssougnez/events{/privacy}","received_events_url":"https://api.github.com/users/ssougnez/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T13:00:39Z","updated_at":"2018-07-31T13:00:39Z","author_association":"CONTRIBUTOR","body":"Okay, I will have a look at it. I expected some issue, it's nice that you found them. I noticed that some CSS property don't work well with hammer (especially absolute positioning).\r\n\r\nFor the bower version, I did it like that because I think other library has been included this way (I checked the bower file and didn't see angular for example) but I might be wrong so I'll have a look at it ;-)\r\n\r\nBtw, did you guys notices that on mobile, if I swipe right on the login screen, it goes away (even in the angular.mobile version) ^^"}}
{"actor":{"display_login":"ssougnez"}}