{"action":"created","comment":{"url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/comments/202446571","pull_request_review_id":137156577,"id":202446571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ0NjU3MQ==","diff_hunk":"@@ -5,17 +5,37 @@\n \n import React from 'react';\n import PropTypes from 'prop-types';\n-import { Typography } from '@material-ui/core';\n+import classNames from 'classnames';\n+import { Typography, withStyles } from '@material-ui/core';\n \n-const Message = ({ children }) =>\n-  children ? <Typography variant=\"subheading\">{children}</Typography> : null;\n+import MessageStyles from './Message.style';\n+\n+const Message = ({ children, classes, type }) =>","path":"src/components/Message/Message.js","position":12,"original_position":12,"commit_id":"20951409d215ac779a1990b85f37920aa387a7af","original_commit_id":"20951409d215ac779a1990b85f37920aa387a7af","user":{"login":"patrickocoffeyo","id":1107871,"node_id":"MDQ6VXNlcjExMDc4NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1107871?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickocoffeyo","html_url":"https://github.com/patrickocoffeyo","followers_url":"https://api.github.com/users/patrickocoffeyo/followers","following_url":"https://api.github.com/users/patrickocoffeyo/following{/other_user}","gists_url":"https://api.github.com/users/patrickocoffeyo/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickocoffeyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickocoffeyo/subscriptions","organizations_url":"https://api.github.com/users/patrickocoffeyo/orgs","repos_url":"https://api.github.com/users/patrickocoffeyo/repos","events_url":"https://api.github.com/users/patrickocoffeyo/events{/privacy}","received_events_url":"https://api.github.com/users/patrickocoffeyo/received_events","type":"User","site_admin":false},"body":"I adjusted the `Message` component so that it can return an error or info messages. More message types are likely to be needed in the future, so I prepared for that :)","created_at":"2018-07-13T19:09:32Z","updated_at":"2018-07-13T19:09:33Z","html_url":"https://github.com/EditVR/editvr-frontend/pull/13#discussion_r202446571","pull_request_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/comments/202446571"},"html":{"href":"https://github.com/EditVR/editvr-frontend/pull/13#discussion_r202446571"},"pull_request":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13","id":200839322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODM5MzIy","html_url":"https://github.com/EditVR/editvr-frontend/pull/13","diff_url":"https://github.com/EditVR/editvr-frontend/pull/13.diff","patch_url":"https://github.com/EditVR/editvr-frontend/pull/13.patch","issue_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/13","number":13,"state":"open","locked":false,"title":"FKED-32, FKED-33, FKED-68, FKED-69: Form Validation","user":{"login":"patrickocoffeyo","id":1107871,"node_id":"MDQ6VXNlcjExMDc4NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1107871?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickocoffeyo","html_url":"https://github.com/patrickocoffeyo","followers_url":"https://api.github.com/users/patrickocoffeyo/followers","following_url":"https://api.github.com/users/patrickocoffeyo/following{/other_user}","gists_url":"https://api.github.com/users/patrickocoffeyo/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickocoffeyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickocoffeyo/subscriptions","organizations_url":"https://api.github.com/users/patrickocoffeyo/orgs","repos_url":"https://api.github.com/users/patrickocoffeyo/repos","events_url":"https://api.github.com/users/patrickocoffeyo/events{/privacy}","received_events_url":"https://api.github.com/users/patrickocoffeyo/received_events","type":"User","site_admin":false},"body":"**This PR does the following:**\r\n- Implements Formik (and Yup) to handle validating input on the Experience form.\r\n- Implements Formik (and Yup) to handle validating input on the Scene form.\r\n- Expands the Scene form so that it now supports editing existing scenes.\r\n- Adds actions, reducers, and API methods that support the scene editing process.\r\n\r\n### To Review:\r\n\r\n- [ ] Checkout this branch.\r\n- [ ] Run `yarn ; yarn start`.\r\n- [ ] Navigate to the dashboard, and edit an experience.\r\n- [ ] Change the title, description, and URL path.\r\n- [ ] Add an invalid value for the URL path field (something that isn't URL friendly).\r\n- [ ] Note that you are instructed to enter a URL-friendly value. Fix your input so that it is URL-friendly.\r\n- [ ] Click \"Save\".\r\n- [ ] Note that when you click \"Save\" the fields become disabled temporarily.\r\n- [ ] Note that you are redirected back to the dashboard.\r\n- [ ] Note that the experience title/description are updated.\r\n- [ ] Go back to the dashboard, and click \"Create\" to create an experience.\r\n- [ ] Note that, when you provide valid input data, the Experience form can create a new experience.\r\n- [ ] Open the experience you just edited.\r\n- [ ] Note that the slug has been updated to the new value you specified when editing the experience.\r\n- [ ] Click \"Create\" and note that a scene creation form appears.\r\n- [ ] Note that you can create a scene once you've input valid values for each field.\r\n- [ ] Edit an existing scene by clicking the \"Edit\" button on a scene card.\r\n- [ ] Note that you are taken to the same scene edit form.\r\n- [ ] Note that there is no file upload field, only a preview of the existing scene sky... To simplify the scene editing process, I've mandated that changing scene skies involves adding a new scene. I think this is fair. If we want to support editing skies in the future, that can be a separate ticket.\r\n- [ ] Change every value in the scene form, including the URL path.\r\n- [ ] Save the scene.\r\n- [ ] Note that the fields are temporarily disabled.\r\n- [ ] Note that the scene saves, and you are then redirected to the scene in it's opened state.\r\n- [ ] Note how edits to the URL path are immediately pulled into the URL.\r\n- [ ] Cool, go have a beer! :beers: \r\n","created_at":"2018-07-11T22:09:58Z","updated_at":"2018-07-13T19:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c758f08921df17da6902ef34c5b6290fa4592d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":949642329,"node_id":"MDU6TGFiZWw5NDk2NDIzMjk=","url":"https://api.github.com/repos/EditVR/editvr-frontend/labels/ready%20for%20review","name":"ready for review","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13/commits","review_comments_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13/comments","review_comment_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/13/comments","statuses_url":"https://api.github.com/repos/EditVR/editvr-frontend/statuses/20951409d215ac779a1990b85f37920aa387a7af","head":{"label":"EditVR:feat/FKED-69-form-validation","ref":"feat/FKED-69-form-validation","sha":"20951409d215ac779a1990b85f37920aa387a7af","user":{"login":"EditVR","id":39352651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzUyNjUx","avatar_url":"https://avatars1.githubusercontent.com/u/39352651?v=4","gravatar_id":"","url":"https://api.github.com/users/EditVR","html_url":"https://github.com/EditVR","followers_url":"https://api.github.com/users/EditVR/followers","following_url":"https://api.github.com/users/EditVR/following{/other_user}","gists_url":"https://api.github.com/users/EditVR/gists{/gist_id}","starred_url":"https://api.github.com/users/EditVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EditVR/subscriptions","organizations_url":"https://api.github.com/users/EditVR/orgs","repos_url":"https://api.github.com/users/EditVR/repos","events_url":"https://api.github.com/users/EditVR/events{/privacy}","received_events_url":"https://api.github.com/users/EditVR/received_events","type":"Organization","site_admin":false},"repo":{"id":133734698,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MzQ2OTg=","name":"editvr-frontend","full_name":"EditVR/editvr-frontend","owner":{"login":"EditVR","id":39352651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzUyNjUx","avatar_url":"https://avatars1.githubusercontent.com/u/39352651?v=4","gravatar_id":"","url":"https://api.github.com/users/EditVR","html_url":"https://github.com/EditVR","followers_url":"https://api.github.com/users/EditVR/followers","following_url":"https://api.github.com/users/EditVR/following{/other_user}","gists_url":"https://api.github.com/users/EditVR/gists{/gist_id}","starred_url":"https://api.github.com/users/EditVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EditVR/subscriptions","organizations_url":"https://api.github.com/users/EditVR/orgs","repos_url":"https://api.github.com/users/EditVR/repos","events_url":"https://api.github.com/users/EditVR/events{/privacy}","received_events_url":"https://api.github.com/users/EditVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EditVR/editvr-frontend","description":"Editorial frontend, driven by EditVR's API.","fork":false,"url":"https://api.github.com/repos/EditVR/editvr-frontend","forks_url":"https://api.github.com/repos/EditVR/editvr-frontend/forks","keys_url":"https://api.github.com/repos/EditVR/editvr-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EditVR/editvr-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EditVR/editvr-frontend/teams","hooks_url":"https://api.github.com/repos/EditVR/editvr-frontend/hooks","issue_events_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/EditVR/editvr-frontend/events","assignees_url":"https://api.github.com/repos/EditVR/editvr-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/EditVR/editvr-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/EditVR/editvr-frontend/tags","blobs_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EditVR/editvr-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/EditVR/editvr-frontend/languages","stargazers_url":"https://api.github.com/repos/EditVR/editvr-frontend/stargazers","contributors_url":"https://api.github.com/repos/EditVR/editvr-frontend/contributors","subscribers_url":"https://api.github.com/repos/EditVR/editvr-frontend/subscribers","subscription_url":"https://api.github.com/repos/EditVR/editvr-frontend/subscription","commits_url":"https://api.github.com/repos/EditVR/editvr-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/EditVR/editvr-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/EditVR/editvr-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/EditVR/editvr-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EditVR/editvr-frontend/merges","archive_url":"https://api.github.com/repos/EditVR/editvr-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EditVR/editvr-frontend/downloads","issues_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/EditVR/editvr-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/EditVR/editvr-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EditVR/editvr-frontend/labels{/name}","releases_url":"https://api.github.com/repos/EditVR/editvr-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/EditVR/editvr-frontend/deployments","created_at":"2018-05-16T23:47:26Z","updated_at":"2018-07-08T21:59:31Z","pushed_at":"2018-07-13T18:51:03Z","git_url":"git://github.com/EditVR/editvr-frontend.git","ssh_url":"git@github.com:EditVR/editvr-frontend.git","clone_url":"https://github.com/EditVR/editvr-frontend.git","svn_url":"https://github.com/EditVR/editvr-frontend","homepage":"https://editvr.github.io/editvr-frontend/","size":2719,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"develop"}},"base":{"label":"EditVR:develop","ref":"develop","sha":"9a8274dceb4ac6713e6552ed28502e2fa58fbcd6","user":{"login":"EditVR","id":39352651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzUyNjUx","avatar_url":"https://avatars1.githubusercontent.com/u/39352651?v=4","gravatar_id":"","url":"https://api.github.com/users/EditVR","html_url":"https://github.com/EditVR","followers_url":"https://api.github.com/users/EditVR/followers","following_url":"https://api.github.com/users/EditVR/following{/other_user}","gists_url":"https://api.github.com/users/EditVR/gists{/gist_id}","starred_url":"https://api.github.com/users/EditVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EditVR/subscriptions","organizations_url":"https://api.github.com/users/EditVR/orgs","repos_url":"https://api.github.com/users/EditVR/repos","events_url":"https://api.github.com/users/EditVR/events{/privacy}","received_events_url":"https://api.github.com/users/EditVR/received_events","type":"Organization","site_admin":false},"repo":{"id":133734698,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MzQ2OTg=","name":"editvr-frontend","full_name":"EditVR/editvr-frontend","owner":{"login":"EditVR","id":39352651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzUyNjUx","avatar_url":"https://avatars1.githubusercontent.com/u/39352651?v=4","gravatar_id":"","url":"https://api.github.com/users/EditVR","html_url":"https://github.com/EditVR","followers_url":"https://api.github.com/users/EditVR/followers","following_url":"https://api.github.com/users/EditVR/following{/other_user}","gists_url":"https://api.github.com/users/EditVR/gists{/gist_id}","starred_url":"https://api.github.com/users/EditVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EditVR/subscriptions","organizations_url":"https://api.github.com/users/EditVR/orgs","repos_url":"https://api.github.com/users/EditVR/repos","events_url":"https://api.github.com/users/EditVR/events{/privacy}","received_events_url":"https://api.github.com/users/EditVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EditVR/editvr-frontend","description":"Editorial frontend, driven by EditVR's API.","fork":false,"url":"https://api.github.com/repos/EditVR/editvr-frontend","forks_url":"https://api.github.com/repos/EditVR/editvr-frontend/forks","keys_url":"https://api.github.com/repos/EditVR/editvr-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EditVR/editvr-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EditVR/editvr-frontend/teams","hooks_url":"https://api.github.com/repos/EditVR/editvr-frontend/hooks","issue_events_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/EditVR/editvr-frontend/events","assignees_url":"https://api.github.com/repos/EditVR/editvr-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/EditVR/editvr-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/EditVR/editvr-frontend/tags","blobs_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EditVR/editvr-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/EditVR/editvr-frontend/languages","stargazers_url":"https://api.github.com/repos/EditVR/editvr-frontend/stargazers","contributors_url":"https://api.github.com/repos/EditVR/editvr-frontend/contributors","subscribers_url":"https://api.github.com/repos/EditVR/editvr-frontend/subscribers","subscription_url":"https://api.github.com/repos/EditVR/editvr-frontend/subscription","commits_url":"https://api.github.com/repos/EditVR/editvr-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/EditVR/editvr-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/EditVR/editvr-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/EditVR/editvr-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/EditVR/editvr-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EditVR/editvr-frontend/merges","archive_url":"https://api.github.com/repos/EditVR/editvr-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EditVR/editvr-frontend/downloads","issues_url":"https://api.github.com/repos/EditVR/editvr-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/EditVR/editvr-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/EditVR/editvr-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/EditVR/editvr-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EditVR/editvr-frontend/labels{/name}","releases_url":"https://api.github.com/repos/EditVR/editvr-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/EditVR/editvr-frontend/deployments","created_at":"2018-05-16T23:47:26Z","updated_at":"2018-07-08T21:59:31Z","pushed_at":"2018-07-13T18:51:03Z","git_url":"git://github.com/EditVR/editvr-frontend.git","ssh_url":"git@github.com:EditVR/editvr-frontend.git","clone_url":"https://github.com/EditVR/editvr-frontend.git","svn_url":"https://github.com/EditVR/editvr-frontend","homepage":"https://editvr.github.io/editvr-frontend/","size":2719,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13"},"html":{"href":"https://github.com/EditVR/editvr-frontend/pull/13"},"issue":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/issues/13"},"comments":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/EditVR/editvr-frontend/statuses/20951409d215ac779a1990b85f37920aa387a7af"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"patrickocoffeyo"}}