{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/190022882","pull_request_review_id":122315851,"id":190022882,"diff_hunk":"@@ -0,0 +1,79 @@\n+/*\n+ * Copyright (c) 2013, Ford Motor Company","path":"src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/hmi/button_get_capabilities_response.h","position":2,"original_position":2,"commit_id":"73bbf28b1cabcda4615ddbaaa619aaa8b1f14b45","original_commit_id":"73bbf28b1cabcda4615ddbaaa619aaa8b1f14b45","user":{"login":"yang1070","id":12255391,"avatar_url":"https://avatars1.githubusercontent.com/u/12255391?v=4","gravatar_id":"","url":"https://api.github.com/users/yang1070","html_url":"https://github.com/yang1070","followers_url":"https://api.github.com/users/yang1070/followers","following_url":"https://api.github.com/users/yang1070/following{/other_user}","gists_url":"https://api.github.com/users/yang1070/gists{/gist_id}","starred_url":"https://api.github.com/users/yang1070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang1070/subscriptions","organizations_url":"https://api.github.com/users/yang1070/orgs","repos_url":"https://api.github.com/users/yang1070/repos","events_url":"https://api.github.com/users/yang1070/events{/privacy}","received_events_url":"https://api.github.com/users/yang1070/received_events","type":"User","site_admin":false},"body":"2018","created_at":"2018-05-22T19:22:13Z","updated_at":"2018-05-22T19:22:14Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/2196#discussion_r190022882","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/190022882"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/2196#discussion_r190022882"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196","id":189341119,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/2196","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/2196.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/2196.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2196","number":2196,"state":"open","locked":false,"title":"RPC design refactoring","user":{"login":"LitvinenkoIra","id":18070449,"avatar_url":"https://avatars3.githubusercontent.com/u/18070449?v=4","gravatar_id":"","url":"https://api.github.com/users/LitvinenkoIra","html_url":"https://github.com/LitvinenkoIra","followers_url":"https://api.github.com/users/LitvinenkoIra/followers","following_url":"https://api.github.com/users/LitvinenkoIra/following{/other_user}","gists_url":"https://api.github.com/users/LitvinenkoIra/gists{/gist_id}","starred_url":"https://api.github.com/users/LitvinenkoIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LitvinenkoIra/subscriptions","organizations_url":"https://api.github.com/users/LitvinenkoIra/orgs","repos_url":"https://api.github.com/users/LitvinenkoIra/repos","events_url":"https://api.github.com/users/LitvinenkoIra/events{/privacy}","received_events_url":"https://api.github.com/users/LitvinenkoIra/received_events","type":"User","site_admin":false},"body":"Technical task : #2189 \r\nThis PR is **ready** for review.\r\n\r\nThis pull request is the first from two expected pull requests in scope of proposal:\r\nhttps://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0168-rpc-design-refactoring.md\r\n\r\nThese code changes are aimed to separate RC functionality as plugin.\r\nSo, there are no functional changes in this pull request.\r\nSDL should interact with Remote Control Applications in the same way as before.\r\nCurrent code is just a base for further development of RC functionality.\r\nTo make sure that nothing is broken, could be run already present in open source tests for RC.\r\nHere the link to RC test set:\r\nhttps://github.com/smartdevicelink/sdl_atf_test_scripts/blob/develop/test_sets/rc_CLIMATE_RADIO.txt\r\nTogether with review of the code it's good to review also architecture changes.\r\nHere the link to appropriate pull request:\r\nhttps://github.com/smartdevicelink/sdl_core_documentation/pull/10\r\n\r\nRisk\r\nThis PR makes **major** API changes.\r\n\r\n### CLA\r\n- [x ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)\r\n","created_at":"2018-05-21T10:30:31Z","updated_at":"2018-05-22T19:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d4ca24d7536ba100d14f80ea79bad2959103d9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"askirk","id":5473611,"avatar_url":"https://avatars2.githubusercontent.com/u/5473611?v=4","gravatar_id":"","url":"https://api.github.com/users/askirk","html_url":"https://github.com/askirk","followers_url":"https://api.github.com/users/askirk/followers","following_url":"https://api.github.com/users/askirk/following{/other_user}","gists_url":"https://api.github.com/users/askirk/gists{/gist_id}","starred_url":"https://api.github.com/users/askirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askirk/subscriptions","organizations_url":"https://api.github.com/users/askirk/orgs","repos_url":"https://api.github.com/users/askirk/repos","events_url":"https://api.github.com/users/askirk/events{/privacy}","received_events_url":"https://api.github.com/users/askirk/received_events","type":"User","site_admin":false},{"login":"mrapitis","id":8443128,"avatar_url":"https://avatars1.githubusercontent.com/u/8443128?v=4","gravatar_id":"","url":"https://api.github.com/users/mrapitis","html_url":"https://github.com/mrapitis","followers_url":"https://api.github.com/users/mrapitis/followers","following_url":"https://api.github.com/users/mrapitis/following{/other_user}","gists_url":"https://api.github.com/users/mrapitis/gists{/gist_id}","starred_url":"https://api.github.com/users/mrapitis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrapitis/subscriptions","organizations_url":"https://api.github.com/users/mrapitis/orgs","repos_url":"https://api.github.com/users/mrapitis/repos","events_url":"https://api.github.com/users/mrapitis/events{/privacy}","received_events_url":"https://api.github.com/users/mrapitis/received_events","type":"User","site_admin":false},{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},{"login":"robinmk","id":20776444,"avatar_url":"https://avatars1.githubusercontent.com/u/20776444?v=4","gravatar_id":"","url":"https://api.github.com/users/robinmk","html_url":"https://github.com/robinmk","followers_url":"https://api.github.com/users/robinmk/followers","following_url":"https://api.github.com/users/robinmk/following{/other_user}","gists_url":"https://api.github.com/users/robinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/robinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinmk/subscriptions","organizations_url":"https://api.github.com/users/robinmk/orgs","repos_url":"https://api.github.com/users/robinmk/repos","events_url":"https://api.github.com/users/robinmk/events{/privacy}","received_events_url":"https://api.github.com/users/robinmk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2196/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/73bbf28b1cabcda4615ddbaaa619aaa8b1f14b45","head":{"label":"smartdevicelink:feature/rc_refactoring","ref":"feature/rc_refactoring","sha":"73bbf28b1cabcda4615ddbaaa619aaa8b1f14b45","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2018-05-14T12:51:22Z","pushed_at":"2018-05-22T15:35:15Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":313615,"stargazers_count":147,"watchers_count":147,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":192,"open_issues":329,"watchers":147,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"0529c83d073601048ca77a8957ea29e371e186e1","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2018-05-14T12:51:22Z","pushed_at":"2018-05-22T15:35:15Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":313615,"stargazers_count":147,"watchers_count":147,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":192,"open_issues":329,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/2196"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2196"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2196/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2196/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/73bbf28b1cabcda4615ddbaaa619aaa8b1f14b45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yang1070"}}