{"action":"closed","number":2412,"pull_request":{"url":"https://api.github.com/repos/racket/racket/pulls/2412","id":235275686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mjc1Njg2","html_url":"https://github.com/racket/racket/pull/2412","diff_url":"https://github.com/racket/racket/pull/2412.diff","patch_url":"https://github.com/racket/racket/pull/2412.patch","issue_url":"https://api.github.com/repos/racket/racket/issues/2412","number":2412,"state":"closed","locked":false,"title":"cs: more pure primitives (draft?)","user":{"login":"gus-massa","id":1566656,"node_id":"MDQ6VXNlcjE1NjY2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1566656?v=4","gravatar_id":"","url":"https://api.github.com/users/gus-massa","html_url":"https://github.com/gus-massa","followers_url":"https://api.github.com/users/gus-massa/followers","following_url":"https://api.github.com/users/gus-massa/following{/other_user}","gists_url":"https://api.github.com/users/gus-massa/gists{/gist_id}","starred_url":"https://api.github.com/users/gus-massa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gus-massa/subscriptions","organizations_url":"https://api.github.com/users/gus-massa/orgs","repos_url":"https://api.github.com/users/gus-massa/repos","events_url":"https://api.github.com/users/gus-massa/events{/privacy}","received_events_url":"https://api.github.com/users/gus-massa/received_events","type":"User","site_admin":false},"body":"This PR has a lot of small changes in the table, so it needs a lot of review. There are five deletion of repetitions and the rest are just changes `known-procedure` -> `known-procedure/pure`. I'm not sure if I need to use a more strict definition of `pure`. If there are too many errors, please mark a few and I'll try to find the others.\r\n\r\nMost of the primitives that I marked as `pure` are predicates. They must be total (and immutable) predicates. I tried to filter the wrong cases just reading the manuals and also with some test to ensure that `(something? #t)` and `(something? 7.7)` and a few more cases don't raise an error. During this I discovered the difference between the implementation and the docs of `terminal-port?`. See also https://github.com/racket/racket/pull/2411 . As I said there, it's very difficult to guess which \"predicates\" are total and which have a restricted domain.\r\n\r\nIt's important to notice that there are a few primitives that almost look like a pure predicate, but are not. In particular:\r\n\r\n*  `struct?` depends on the value of the `(current-code-inspector)` (Chez Scheme has an internal primitive `secret-struct-under-the-hood?` that may be useful, IIRC the real name is `#3%$record?`.)\r\n\r\n* `prefab-key?` may change because the fourth item in the list is a vector that may be mutable or have a impersonator.\r\n\r\nI tried to be careful, but some cases are tricky and I'm not sure that I removed all the wrong cases. ","created_at":"2018-12-02T18:26:53Z","updated_at":"2018-12-05T21:38:21Z","closed_at":"2018-12-05T21:38:21Z","merged_at":null,"merge_commit_sha":"e8c2a6a83d72b07ee02ebada24b9f214caf73679","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/racket/racket/pulls/2412/commits","review_comments_url":"https://api.github.com/repos/racket/racket/pulls/2412/comments","review_comment_url":"https://api.github.com/repos/racket/racket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/racket/racket/issues/2412/comments","statuses_url":"https://api.github.com/repos/racket/racket/statuses/03e284a02f65cb4b49c7d35b34497dcc4430d59e","head":{"label":"gus-massa:18-12-PurePrim","ref":"18-12-PurePrim","sha":"03e284a02f65cb4b49c7d35b34497dcc4430d59e","user":{"login":"gus-massa","id":1566656,"node_id":"MDQ6VXNlcjE1NjY2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1566656?v=4","gravatar_id":"","url":"https://api.github.com/users/gus-massa","html_url":"https://github.com/gus-massa","followers_url":"https://api.github.com/users/gus-massa/followers","following_url":"https://api.github.com/users/gus-massa/following{/other_user}","gists_url":"https://api.github.com/users/gus-massa/gists{/gist_id}","starred_url":"https://api.github.com/users/gus-massa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gus-massa/subscriptions","organizations_url":"https://api.github.com/users/gus-massa/orgs","repos_url":"https://api.github.com/users/gus-massa/repos","events_url":"https://api.github.com/users/gus-massa/events{/privacy}","received_events_url":"https://api.github.com/users/gus-massa/received_events","type":"User","site_admin":false},"repo":{"id":19355697,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM1NTY5Nw==","name":"racket","full_name":"gus-massa/racket","private":false,"owner":{"login":"gus-massa","id":1566656,"node_id":"MDQ6VXNlcjE1NjY2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1566656?v=4","gravatar_id":"","url":"https://api.github.com/users/gus-massa","html_url":"https://github.com/gus-massa","followers_url":"https://api.github.com/users/gus-massa/followers","following_url":"https://api.github.com/users/gus-massa/following{/other_user}","gists_url":"https://api.github.com/users/gus-massa/gists{/gist_id}","starred_url":"https://api.github.com/users/gus-massa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gus-massa/subscriptions","organizations_url":"https://api.github.com/users/gus-massa/orgs","repos_url":"https://api.github.com/users/gus-massa/repos","events_url":"https://api.github.com/users/gus-massa/events{/privacy}","received_events_url":"https://api.github.com/users/gus-massa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gus-massa/racket","description":"The Racket repository","fork":true,"url":"https://api.github.com/repos/gus-massa/racket","forks_url":"https://api.github.com/repos/gus-massa/racket/forks","keys_url":"https://api.github.com/repos/gus-massa/racket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gus-massa/racket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gus-massa/racket/teams","hooks_url":"https://api.github.com/repos/gus-massa/racket/hooks","issue_events_url":"https://api.github.com/repos/gus-massa/racket/issues/events{/number}","events_url":"https://api.github.com/repos/gus-massa/racket/events","assignees_url":"https://api.github.com/repos/gus-massa/racket/assignees{/user}","branches_url":"https://api.github.com/repos/gus-massa/racket/branches{/branch}","tags_url":"https://api.github.com/repos/gus-massa/racket/tags","blobs_url":"https://api.github.com/repos/gus-massa/racket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gus-massa/racket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gus-massa/racket/git/refs{/sha}","trees_url":"https://api.github.com/repos/gus-massa/racket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gus-massa/racket/statuses/{sha}","languages_url":"https://api.github.com/repos/gus-massa/racket/languages","stargazers_url":"https://api.github.com/repos/gus-massa/racket/stargazers","contributors_url":"https://api.github.com/repos/gus-massa/racket/contributors","subscribers_url":"https://api.github.com/repos/gus-massa/racket/subscribers","subscription_url":"https://api.github.com/repos/gus-massa/racket/subscription","commits_url":"https://api.github.com/repos/gus-massa/racket/commits{/sha}","git_commits_url":"https://api.github.com/repos/gus-massa/racket/git/commits{/sha}","comments_url":"https://api.github.com/repos/gus-massa/racket/comments{/number}","issue_comment_url":"https://api.github.com/repos/gus-massa/racket/issues/comments{/number}","contents_url":"https://api.github.com/repos/gus-massa/racket/contents/{+path}","compare_url":"https://api.github.com/repos/gus-massa/racket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gus-massa/racket/merges","archive_url":"https://api.github.com/repos/gus-massa/racket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gus-massa/racket/downloads","issues_url":"https://api.github.com/repos/gus-massa/racket/issues{/number}","pulls_url":"https://api.github.com/repos/gus-massa/racket/pulls{/number}","milestones_url":"https://api.github.com/repos/gus-massa/racket/milestones{/number}","notifications_url":"https://api.github.com/repos/gus-massa/racket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gus-massa/racket/labels{/name}","releases_url":"https://api.github.com/repos/gus-massa/racket/releases{/id}","deployments_url":"https://api.github.com/repos/gus-massa/racket/deployments","created_at":"2014-05-01T19:46:56Z","updated_at":"2018-12-05T14:34:51Z","pushed_at":"2018-12-05T14:34:24Z","git_url":"git://github.com/gus-massa/racket.git","ssh_url":"git@github.com:gus-massa/racket.git","clone_url":"https://github.com/gus-massa/racket.git","svn_url":"https://github.com/gus-massa/racket","homepage":"http://racket-lang.org/","size":187344,"stargazers_count":0,"watchers_count":0,"language":"Racket","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"racket:master","ref":"master","sha":"8043768b4c706b30dde9a74570441915121bc142","user":{"login":"racket","id":232371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/232371?v=4","gravatar_id":"","url":"https://api.github.com/users/racket","html_url":"https://github.com/racket","followers_url":"https://api.github.com/users/racket/followers","following_url":"https://api.github.com/users/racket/following{/other_user}","gists_url":"https://api.github.com/users/racket/gists{/gist_id}","starred_url":"https://api.github.com/users/racket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racket/subscriptions","organizations_url":"https://api.github.com/users/racket/orgs","repos_url":"https://api.github.com/users/racket/repos","events_url":"https://api.github.com/users/racket/events{/privacy}","received_events_url":"https://api.github.com/users/racket/received_events","type":"Organization","site_admin":false},"repo":{"id":615969,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU5Njk=","name":"racket","full_name":"racket/racket","private":false,"owner":{"login":"racket","id":232371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/232371?v=4","gravatar_id":"","url":"https://api.github.com/users/racket","html_url":"https://github.com/racket","followers_url":"https://api.github.com/users/racket/followers","following_url":"https://api.github.com/users/racket/following{/other_user}","gists_url":"https://api.github.com/users/racket/gists{/gist_id}","starred_url":"https://api.github.com/users/racket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racket/subscriptions","organizations_url":"https://api.github.com/users/racket/orgs","repos_url":"https://api.github.com/users/racket/repos","events_url":"https://api.github.com/users/racket/events{/privacy}","received_events_url":"https://api.github.com/users/racket/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racket/racket","description":"The Racket repository","fork":false,"url":"https://api.github.com/repos/racket/racket","forks_url":"https://api.github.com/repos/racket/racket/forks","keys_url":"https://api.github.com/repos/racket/racket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racket/racket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racket/racket/teams","hooks_url":"https://api.github.com/repos/racket/racket/hooks","issue_events_url":"https://api.github.com/repos/racket/racket/issues/events{/number}","events_url":"https://api.github.com/repos/racket/racket/events","assignees_url":"https://api.github.com/repos/racket/racket/assignees{/user}","branches_url":"https://api.github.com/repos/racket/racket/branches{/branch}","tags_url":"https://api.github.com/repos/racket/racket/tags","blobs_url":"https://api.github.com/repos/racket/racket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racket/racket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racket/racket/git/refs{/sha}","trees_url":"https://api.github.com/repos/racket/racket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racket/racket/statuses/{sha}","languages_url":"https://api.github.com/repos/racket/racket/languages","stargazers_url":"https://api.github.com/repos/racket/racket/stargazers","contributors_url":"https://api.github.com/repos/racket/racket/contributors","subscribers_url":"https://api.github.com/repos/racket/racket/subscribers","subscription_url":"https://api.github.com/repos/racket/racket/subscription","commits_url":"https://api.github.com/repos/racket/racket/commits{/sha}","git_commits_url":"https://api.github.com/repos/racket/racket/git/commits{/sha}","comments_url":"https://api.github.com/repos/racket/racket/comments{/number}","issue_comment_url":"https://api.github.com/repos/racket/racket/issues/comments{/number}","contents_url":"https://api.github.com/repos/racket/racket/contents/{+path}","compare_url":"https://api.github.com/repos/racket/racket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racket/racket/merges","archive_url":"https://api.github.com/repos/racket/racket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racket/racket/downloads","issues_url":"https://api.github.com/repos/racket/racket/issues{/number}","pulls_url":"https://api.github.com/repos/racket/racket/pulls{/number}","milestones_url":"https://api.github.com/repos/racket/racket/milestones{/number}","notifications_url":"https://api.github.com/repos/racket/racket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racket/racket/labels{/name}","releases_url":"https://api.github.com/repos/racket/racket/releases{/id}","deployments_url":"https://api.github.com/repos/racket/racket/deployments","created_at":"2010-04-18T06:39:16Z","updated_at":"2018-12-05T14:34:05Z","pushed_at":"2018-12-05T20:46:17Z","git_url":"git://github.com/racket/racket.git","ssh_url":"git@github.com:racket/racket.git","clone_url":"https://github.com/racket/racket.git","svn_url":"https://github.com/racket/racket","homepage":"https://racket-lang.org/","size":188751,"stargazers_count":2685,"watchers_count":2685,"language":"Racket","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":364,"license":null,"forks":431,"open_issues":364,"watchers":2685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/racket/racket/pulls/2412"},"html":{"href":"https://github.com/racket/racket/pull/2412"},"issue":{"href":"https://api.github.com/repos/racket/racket/issues/2412"},"comments":{"href":"https://api.github.com/repos/racket/racket/issues/2412/comments"},"review_comments":{"href":"https://api.github.com/repos/racket/racket/pulls/2412/comments"},"review_comment":{"href":"https://api.github.com/repos/racket/racket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/racket/racket/pulls/2412/commits"},"statuses":{"href":"https://api.github.com/repos/racket/racket/statuses/03e284a02f65cb4b49c7d35b34497dcc4430d59e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":104,"deletions":109,"changed_files":1}}
{"actor":{"display_login":"gus-massa"}}