{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/RAJA/pulls/comments/243106683","pull_request_review_id":186788078,"id":243106683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzEwNjY4Mw==","diff_hunk":"@@ -119,19 +117,28 @@ struct CudaStatementExecutor<\n \n \n   static\n-  inline RAJA_DEVICE void exec(Data &data)\n+  inline RAJA_DEVICE void exec(Data &data, bool thread_active)\n   {\n     // block stride loop\n     int len = segment_length<ArgumentId>(data);\n     auto i0 = get_cuda_dim<ThreadDim>(threadIdx);\n     auto i_stride = get_cuda_dim<ThreadDim>(blockDim);\n-    for(auto i = i0;i < len;i += i_stride){\n+    auto i = i0;\n+    for(;i < len;i += i_stride){","path":"include/RAJA/policy/cuda/kernel/For.hpp","position":33,"original_position":33,"commit_id":"aa7c1ef5c270dce54832c2070456daf554a8eac2","original_commit_id":"aa7c1ef5c270dce54832c2070456daf554a8eac2","user":{"login":"rhornung67","id":12800412,"node_id":"MDQ6VXNlcjEyODAwNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/12800412?v=4","gravatar_id":"","url":"https://api.github.com/users/rhornung67","html_url":"https://github.com/rhornung67","followers_url":"https://api.github.com/users/rhornung67/followers","following_url":"https://api.github.com/users/rhornung67/following{/other_user}","gists_url":"https://api.github.com/users/rhornung67/gists{/gist_id}","starred_url":"https://api.github.com/users/rhornung67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhornung67/subscriptions","organizations_url":"https://api.github.com/users/rhornung67/orgs","repos_url":"https://api.github.com/users/rhornung67/repos","events_url":"https://api.github.com/users/rhornung67/events{/privacy}","received_events_url":"https://api.github.com/users/rhornung67/received_events","type":"User","site_admin":false},"body":"OK. Fine.","created_at":"2018-12-19T23:02:09Z","updated_at":"2018-12-19T23:02:09Z","html_url":"https://github.com/LLNL/RAJA/pull/559#discussion_r243106683","pull_request_url":"https://api.github.com/repos/LLNL/RAJA/pulls/559","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/comments/243106683"},"html":{"href":"https://github.com/LLNL/RAJA/pull/559#discussion_r243106683"},"pull_request":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/559"}},"in_reply_to_id":243105088},"pull_request":{"url":"https://api.github.com/repos/LLNL/RAJA/pulls/559","id":239990171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTkwMTcx","html_url":"https://github.com/LLNL/RAJA/pull/559","diff_url":"https://github.com/LLNL/RAJA/pull/559.diff","patch_url":"https://github.com/LLNL/RAJA/pull/559.patch","issue_url":"https://api.github.com/repos/LLNL/RAJA/issues/559","number":559,"state":"closed","locked":false,"title":"Changed plumbing in RAJA::kernel to defer masking off threads until lambda is called","user":{"login":"ajkunen","id":17932804,"node_id":"MDQ6VXNlcjE3OTMyODA0","avatar_url":"https://avatars1.githubusercontent.com/u/17932804?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkunen","html_url":"https://github.com/ajkunen","followers_url":"https://api.github.com/users/ajkunen/followers","following_url":"https://api.github.com/users/ajkunen/following{/other_user}","gists_url":"https://api.github.com/users/ajkunen/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkunen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkunen/subscriptions","organizations_url":"https://api.github.com/users/ajkunen/orgs","repos_url":"https://api.github.com/users/ajkunen/repos","events_url":"https://api.github.com/users/ajkunen/events{/privacy}","received_events_url":"https://api.github.com/users/ajkunen/received_events","type":"User","site_admin":false},"body":"Changed plumbing in RAJA::kernel to only mask off threads that are out of bounds at the Lambda invokation.\r\n\r\nThis allows threads that are masked off to still participate in syncthreads, etc., which was causing hangs with the NVidia V100's.\r\nAlso, it allowed the elimination of the cuda_seq_syncthreads_exec policy.","created_at":"2018-12-19T22:10:21Z","updated_at":"2018-12-19T23:02:09Z","closed_at":"2018-12-19T23:01:58Z","merged_at":"2018-12-19T23:01:58Z","merge_commit_sha":"d36ba5b88996fba66d6987d071dc311f6f5ac3be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidbeckingsale","id":334483,"node_id":"MDQ6VXNlcjMzNDQ4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/334483?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbeckingsale","html_url":"https://github.com/davidbeckingsale","followers_url":"https://api.github.com/users/davidbeckingsale/followers","following_url":"https://api.github.com/users/davidbeckingsale/following{/other_user}","gists_url":"https://api.github.com/users/davidbeckingsale/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeckingsale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeckingsale/subscriptions","organizations_url":"https://api.github.com/users/davidbeckingsale/orgs","repos_url":"https://api.github.com/users/davidbeckingsale/repos","events_url":"https://api.github.com/users/davidbeckingsale/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeckingsale/received_events","type":"User","site_admin":false},{"login":"MrBurmark","id":2646848,"node_id":"MDQ6VXNlcjI2NDY4NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2646848?v=4","gravatar_id":"","url":"https://api.github.com/users/MrBurmark","html_url":"https://github.com/MrBurmark","followers_url":"https://api.github.com/users/MrBurmark/followers","following_url":"https://api.github.com/users/MrBurmark/following{/other_user}","gists_url":"https://api.github.com/users/MrBurmark/gists{/gist_id}","starred_url":"https://api.github.com/users/MrBurmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrBurmark/subscriptions","organizations_url":"https://api.github.com/users/MrBurmark/orgs","repos_url":"https://api.github.com/users/MrBurmark/repos","events_url":"https://api.github.com/users/MrBurmark/events{/privacy}","received_events_url":"https://api.github.com/users/MrBurmark/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":365931122,"node_id":"MDU6TGFiZWwzNjU5MzExMjI=","url":"https://api.github.com/repos/LLNL/RAJA/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/RAJA/pulls/559/commits","review_comments_url":"https://api.github.com/repos/LLNL/RAJA/pulls/559/comments","review_comment_url":"https://api.github.com/repos/LLNL/RAJA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/RAJA/issues/559/comments","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/aa7c1ef5c270dce54832c2070456daf554a8eac2","head":{"label":"LLNL:feature/kunen1/thread_mask","ref":"feature/kunen1/thread_mask","sha":"aa7c1ef5c270dce54832c2070456daf554a8eac2","user":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":57340960,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM0MDk2MA==","name":"RAJA","full_name":"LLNL/RAJA","private":false,"owner":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LLNL/RAJA","description":"RAJA Performance Portability Layer","fork":false,"url":"https://api.github.com/repos/LLNL/RAJA","forks_url":"https://api.github.com/repos/LLNL/RAJA/forks","keys_url":"https://api.github.com/repos/LLNL/RAJA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/RAJA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/RAJA/teams","hooks_url":"https://api.github.com/repos/LLNL/RAJA/hooks","issue_events_url":"https://api.github.com/repos/LLNL/RAJA/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/RAJA/events","assignees_url":"https://api.github.com/repos/LLNL/RAJA/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/RAJA/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/RAJA/tags","blobs_url":"https://api.github.com/repos/LLNL/RAJA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/RAJA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/RAJA/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/RAJA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/RAJA/languages","stargazers_url":"https://api.github.com/repos/LLNL/RAJA/stargazers","contributors_url":"https://api.github.com/repos/LLNL/RAJA/contributors","subscribers_url":"https://api.github.com/repos/LLNL/RAJA/subscribers","subscription_url":"https://api.github.com/repos/LLNL/RAJA/subscription","commits_url":"https://api.github.com/repos/LLNL/RAJA/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/RAJA/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/RAJA/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/RAJA/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/RAJA/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/RAJA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/RAJA/merges","archive_url":"https://api.github.com/repos/LLNL/RAJA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/RAJA/downloads","issues_url":"https://api.github.com/repos/LLNL/RAJA/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/RAJA/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/RAJA/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/RAJA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/RAJA/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/RAJA/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/RAJA/deployments","created_at":"2016-04-28T23:46:22Z","updated_at":"2018-12-19T23:02:03Z","pushed_at":"2018-12-19T23:02:02Z","git_url":"git://github.com/LLNL/RAJA.git","ssh_url":"git@github.com:LLNL/RAJA.git","clone_url":"https://github.com/LLNL/RAJA.git","svn_url":"https://github.com/LLNL/RAJA","homepage":null,"size":18724,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":48,"watchers":95,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"0b8e910d3165bdd1b6a7b0a03c40f326d44c57d4","user":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":57340960,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM0MDk2MA==","name":"RAJA","full_name":"LLNL/RAJA","private":false,"owner":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LLNL/RAJA","description":"RAJA Performance Portability Layer","fork":false,"url":"https://api.github.com/repos/LLNL/RAJA","forks_url":"https://api.github.com/repos/LLNL/RAJA/forks","keys_url":"https://api.github.com/repos/LLNL/RAJA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/RAJA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/RAJA/teams","hooks_url":"https://api.github.com/repos/LLNL/RAJA/hooks","issue_events_url":"https://api.github.com/repos/LLNL/RAJA/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/RAJA/events","assignees_url":"https://api.github.com/repos/LLNL/RAJA/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/RAJA/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/RAJA/tags","blobs_url":"https://api.github.com/repos/LLNL/RAJA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/RAJA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/RAJA/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/RAJA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/RAJA/languages","stargazers_url":"https://api.github.com/repos/LLNL/RAJA/stargazers","contributors_url":"https://api.github.com/repos/LLNL/RAJA/contributors","subscribers_url":"https://api.github.com/repos/LLNL/RAJA/subscribers","subscription_url":"https://api.github.com/repos/LLNL/RAJA/subscription","commits_url":"https://api.github.com/repos/LLNL/RAJA/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/RAJA/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/RAJA/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/RAJA/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/RAJA/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/RAJA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/RAJA/merges","archive_url":"https://api.github.com/repos/LLNL/RAJA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/RAJA/downloads","issues_url":"https://api.github.com/repos/LLNL/RAJA/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/RAJA/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/RAJA/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/RAJA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/RAJA/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/RAJA/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/RAJA/deployments","created_at":"2016-04-28T23:46:22Z","updated_at":"2018-12-19T23:02:03Z","pushed_at":"2018-12-19T23:02:02Z","git_url":"git://github.com/LLNL/RAJA.git","ssh_url":"git@github.com:LLNL/RAJA.git","clone_url":"https://github.com/LLNL/RAJA.git","svn_url":"https://github.com/LLNL/RAJA","homepage":null,"size":18724,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":48,"watchers":95,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/559"},"html":{"href":"https://github.com/LLNL/RAJA/pull/559"},"issue":{"href":"https://api.github.com/repos/LLNL/RAJA/issues/559"},"comments":{"href":"https://api.github.com/repos/LLNL/RAJA/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/RAJA/statuses/aa7c1ef5c270dce54832c2070456daf554a8eac2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rhornung67"}}