{"action":"created","comment":{"url":"https://api.github.com/repos/deads2k/origin/pulls/comments/197772326","pull_request_review_id":131578464,"id":197772326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc3MjMyNg==","diff_hunk":"@@ -197,53 +199,55 @@ func TestChainDescriber(t *testing.T) {\n \t\t},\n \t}\n \n-\tfor _, test := range tests {\n-\t\tobjs := []runtime.Object{}\n-\t\tif len(test.path) > 0 {\n-\t\t\tvar err error\n-\t\t\tobjs, err = readObjectsFromPath(test.path, test.defaultNamespace, legacyscheme.Codecs.UniversalDecoder(), legacyscheme.Scheme)\n-\t\t\tif err != nil {\n-\t\t\t\tt.Fatal(err)\n+\tfor i, test := range tests {\n+\t\tt.Run(fmt.Sprintf(\"%d\", i), func(t *testing.T) {\n+\t\t\tobjs := []runtime.Object{}\n+\t\t\tif len(test.path) > 0 {\n+\t\t\t\tvar err error\n+\t\t\t\tobjs, err = readObjectsFromPath(test.path, test.defaultNamespace, unstructured.UnstructuredJSONScheme, legacyscheme.Scheme)","path":"pkg/oc/cli/describe/chaindescriber_test.go","position":31,"original_position":31,"commit_id":"c4a23d33592451b3d6db4d92e4c9e3d225d4c5ca","original_commit_id":"c4a23d33592451b3d6db4d92e4c9e3d225d4c5ca","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"Well, with the UniversalDecoder I'm getting unstructured types, in which case the rest of functionality fails, that's why I switched to UnstructuredJSON","created_at":"2018-06-25T12:08:59Z","updated_at":"2018-06-25T12:09:04Z","html_url":"https://github.com/deads2k/origin/pull/70#discussion_r197772326","pull_request_url":"https://api.github.com/repos/deads2k/origin/pulls/70","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/deads2k/origin/pulls/comments/197772326"},"html":{"href":"https://github.com/deads2k/origin/pull/70#discussion_r197772326"},"pull_request":{"href":"https://api.github.com/repos/deads2k/origin/pulls/70"}},"in_reply_to_id":197767809},"pull_request":{"url":"https://api.github.com/repos/deads2k/origin/pulls/70","id":197086711,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDg2NzEx","html_url":"https://github.com/deads2k/origin/pull/70","diff_url":"https://github.com/deads2k/origin/pull/70.diff","patch_url":"https://github.com/deads2k/origin/pull/70.patch","issue_url":"https://api.github.com/repos/deads2k/origin/issues/70","number":70,"state":"open","locked":false,"title":"WIP: oc fixes cont'd","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-25T11:47:29Z","updated_at":"2018-06-25T12:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da911c9076666ec1bf9cf4e454ce61809168b0a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deads2k/origin/pulls/70/commits","review_comments_url":"https://api.github.com/repos/deads2k/origin/pulls/70/comments","review_comment_url":"https://api.github.com/repos/deads2k/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deads2k/origin/issues/70/comments","statuses_url":"https://api.github.com/repos/deads2k/origin/statuses/c4a23d33592451b3d6db4d92e4c9e3d225d4c5ca","head":{"label":"soltysh:oc_fixes2","ref":"oc_fixes2","sha":"c4a23d33592451b3d6db4d92e4c9e3d225d4c5ca","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"repo":{"id":22954476,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk1NDQ3Ng==","name":"origin","full_name":"soltysh/origin","owner":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltysh/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/soltysh/origin","forks_url":"https://api.github.com/repos/soltysh/origin/forks","keys_url":"https://api.github.com/repos/soltysh/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltysh/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltysh/origin/teams","hooks_url":"https://api.github.com/repos/soltysh/origin/hooks","issue_events_url":"https://api.github.com/repos/soltysh/origin/issues/events{/number}","events_url":"https://api.github.com/repos/soltysh/origin/events","assignees_url":"https://api.github.com/repos/soltysh/origin/assignees{/user}","branches_url":"https://api.github.com/repos/soltysh/origin/branches{/branch}","tags_url":"https://api.github.com/repos/soltysh/origin/tags","blobs_url":"https://api.github.com/repos/soltysh/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltysh/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltysh/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltysh/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltysh/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/soltysh/origin/languages","stargazers_url":"https://api.github.com/repos/soltysh/origin/stargazers","contributors_url":"https://api.github.com/repos/soltysh/origin/contributors","subscribers_url":"https://api.github.com/repos/soltysh/origin/subscribers","subscription_url":"https://api.github.com/repos/soltysh/origin/subscription","commits_url":"https://api.github.com/repos/soltysh/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltysh/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltysh/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltysh/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltysh/origin/contents/{+path}","compare_url":"https://api.github.com/repos/soltysh/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltysh/origin/merges","archive_url":"https://api.github.com/repos/soltysh/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltysh/origin/downloads","issues_url":"https://api.github.com/repos/soltysh/origin/issues{/number}","pulls_url":"https://api.github.com/repos/soltysh/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/soltysh/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/soltysh/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltysh/origin/labels{/name}","releases_url":"https://api.github.com/repos/soltysh/origin/releases{/id}","deployments_url":"https://api.github.com/repos/soltysh/origin/deployments","created_at":"2014-08-14T13:19:11Z","updated_at":"2018-06-22T20:56:04Z","pushed_at":"2018-06-25T11:47:06Z","git_url":"git://github.com/soltysh/origin.git","ssh_url":"git@github.com:soltysh/origin.git","clone_url":"https://github.com/soltysh/origin.git","svn_url":"https://github.com/soltysh/origin","homepage":"https://openshift.github.io","size":959576,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deads2k:rebase-04-1.11beta2","ref":"rebase-04-1.11beta2","sha":"405993319d021bb2c34ea4e2d819f5553a43522a","user":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"repo":{"id":24424126,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQyNDEyNg==","name":"origin","full_name":"deads2k/origin","owner":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deads2k/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/deads2k/origin","forks_url":"https://api.github.com/repos/deads2k/origin/forks","keys_url":"https://api.github.com/repos/deads2k/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deads2k/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deads2k/origin/teams","hooks_url":"https://api.github.com/repos/deads2k/origin/hooks","issue_events_url":"https://api.github.com/repos/deads2k/origin/issues/events{/number}","events_url":"https://api.github.com/repos/deads2k/origin/events","assignees_url":"https://api.github.com/repos/deads2k/origin/assignees{/user}","branches_url":"https://api.github.com/repos/deads2k/origin/branches{/branch}","tags_url":"https://api.github.com/repos/deads2k/origin/tags","blobs_url":"https://api.github.com/repos/deads2k/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deads2k/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deads2k/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/deads2k/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deads2k/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/deads2k/origin/languages","stargazers_url":"https://api.github.com/repos/deads2k/origin/stargazers","contributors_url":"https://api.github.com/repos/deads2k/origin/contributors","subscribers_url":"https://api.github.com/repos/deads2k/origin/subscribers","subscription_url":"https://api.github.com/repos/deads2k/origin/subscription","commits_url":"https://api.github.com/repos/deads2k/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/deads2k/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/deads2k/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/deads2k/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/deads2k/origin/contents/{+path}","compare_url":"https://api.github.com/repos/deads2k/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deads2k/origin/merges","archive_url":"https://api.github.com/repos/deads2k/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deads2k/origin/downloads","issues_url":"https://api.github.com/repos/deads2k/origin/issues{/number}","pulls_url":"https://api.github.com/repos/deads2k/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/deads2k/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/deads2k/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deads2k/origin/labels{/name}","releases_url":"https://api.github.com/repos/deads2k/origin/releases{/id}","deployments_url":"https://api.github.com/repos/deads2k/origin/deployments","created_at":"2014-09-24T17:02:12Z","updated_at":"2018-06-22T18:46:17Z","pushed_at":"2018-06-25T11:47:30Z","git_url":"git://github.com/deads2k/origin.git","ssh_url":"git@github.com:deads2k/origin.git","clone_url":"https://github.com/deads2k/origin.git","svn_url":"https://github.com/deads2k/origin","homepage":"https://openshift.github.io","size":914846,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deads2k/origin/pulls/70"},"html":{"href":"https://github.com/deads2k/origin/pull/70"},"issue":{"href":"https://api.github.com/repos/deads2k/origin/issues/70"},"comments":{"href":"https://api.github.com/repos/deads2k/origin/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/deads2k/origin/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/deads2k/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deads2k/origin/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/deads2k/origin/statuses/c4a23d33592451b3d6db4d92e4c9e3d225d4c5ca"}},"author_association":"NONE"}}
{"actor":{"display_login":"soltysh"}}