{"action":"closed","number":3973,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973","id":219102567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTAyNTY3","html_url":"https://github.com/apache/incubator-airflow/pull/3973","diff_url":"https://github.com/apache/incubator-airflow/pull/3973.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3973.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3973","number":3973,"state":"closed","locked":false,"title":"[AIRFLOW-XXX] Don't spam test logs with \"bad cron expression\" messages","user":{"login":"ashb","id":34150,"node_id":"MDQ6VXNlcjM0MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/34150?v=4","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"body":"\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] https://issues.apache.org/jira/browse/AIRFLOW-XXX\r\n\r\n### Description\r\n\r\nWe needed these test dags to check the behaviour of invalid cron\r\nexpressions, but by default we were loading them every time we create a\r\nDagBag (which many, many tests to).\r\n\r\nInstead we ignore these known-bad dags by default, and the test checking\r\nthose (tests/models.py:DagBagTest.test_process_file_cron_validity_check)\r\nis already explicitly processing those DAGs directly, so it remains\r\ntested.\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Just makes test output a tiny bit easier to read\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n","created_at":"2018-09-28T22:43:50Z","updated_at":"2018-09-29T14:14:19Z","closed_at":"2018-09-29T14:14:19Z","merged_at":"2018-09-29T14:14:19Z","merge_commit_sha":"7a6f4b013335d42eb7005f49ff202da147b90af1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3973/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/82ad279e794b4d2dba86cf902b7c2de112b1609a","head":{"label":"ashb:dont-spam-test-logs-with-bad-cron-expression","ref":"dont-spam-test-logs-with-bad-cron-expression","sha":"82ad279e794b4d2dba86cf902b7c2de112b1609a","user":{"login":"ashb","id":34150,"node_id":"MDQ6VXNlcjM0MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/34150?v=4","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"repo":{"id":94879701,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg3OTcwMQ==","name":"incubator-airflow","full_name":"ashb/incubator-airflow","private":false,"owner":{"login":"ashb","id":34150,"node_id":"MDQ6VXNlcjM0MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/34150?v=4","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashb/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/ashb/incubator-airflow","forks_url":"https://api.github.com/repos/ashb/incubator-airflow/forks","keys_url":"https://api.github.com/repos/ashb/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashb/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashb/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/ashb/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/ashb/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/ashb/incubator-airflow/events","assignees_url":"https://api.github.com/repos/ashb/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/ashb/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/ashb/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/ashb/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashb/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashb/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashb/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashb/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ashb/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/ashb/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/ashb/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/ashb/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/ashb/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/ashb/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashb/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashb/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashb/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashb/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/ashb/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashb/incubator-airflow/merges","archive_url":"https://api.github.com/repos/ashb/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashb/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/ashb/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/ashb/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ashb/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ashb/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashb/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/ashb/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/ashb/incubator-airflow/deployments","created_at":"2017-06-20T10:32:55Z","updated_at":"2018-09-25T19:50:44Z","pushed_at":"2018-09-29T13:12:53Z","git_url":"git://github.com/ashb/incubator-airflow.git","ssh_url":"git@github.com:ashb/incubator-airflow.git","clone_url":"https://github.com/ashb/incubator-airflow.git","svn_url":"https://github.com/ashb/incubator-airflow","homepage":"","size":24888,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5e9c9b54f6218e70333d70e590874cc88b5f74cc","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"incubator-airflow","full_name":"apache/incubator-airflow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2018-09-29T10:36:04Z","pushed_at":"2018-09-29T14:14:19Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"https://airflow.apache.org","size":24779,"stargazers_count":9504,"watchers_count":9504,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3233,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3233,"open_issues":332,"watchers":9504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3973"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3973"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3973/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3973/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/82ad279e794b4d2dba86cf902b7c2de112b1609a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kaxil","id":8811558,"node_id":"MDQ6VXNlcjg4MTE1NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8811558?v=4","gravatar_id":"","url":"https://api.github.com/users/kaxil","html_url":"https://github.com/kaxil","followers_url":"https://api.github.com/users/kaxil/followers","following_url":"https://api.github.com/users/kaxil/following{/other_user}","gists_url":"https://api.github.com/users/kaxil/gists{/gist_id}","starred_url":"https://api.github.com/users/kaxil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaxil/subscriptions","organizations_url":"https://api.github.com/users/kaxil/orgs","repos_url":"https://api.github.com/users/kaxil/repos","events_url":"https://api.github.com/users/kaxil/events{/privacy}","received_events_url":"https://api.github.com/users/kaxil/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"kaxil"}}