{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/212484018","pull_request_review_id":149130054,"id":212484018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ4NDAxOA==","diff_hunk":"@@ -68,11 +68,14 @@ class Conll2003DatasetReader(DatasetReader):\n         specified here.\n     coding_scheme: ``str``, optional (default=``IOB1``)\n         Specifies the coding scheme for ``ner_labels`` and ``chunk_labels``.\n-        Valid options are ``IOB1`` and ``BIOUL``.  The ``IOB1`` default maintains\n-        the original IOB1 scheme in the CoNLL data.\n+        Valid options are ``IOB1``, ``BIO``, and ``BIOUL``.  The ``IOB1`` default maintains\n+        the original IOB1 scheme in the CoNLL 2003 NER data.\n         In the IOB1 scheme, I is a token inside a span, O is a token outside\n         a span and B is the beginning of span immediately following another\n         span of the same type.\n+        To maintain the default of the CoNLL 2000 syntactic chunking data,","path":"allennlp/data/dataset_readers/conll2003.py","position":11,"original_position":11,"commit_id":"ea50418343d1f2f0cd9d26d4cba7e1e0af05d5a5","original_commit_id":"ea50418343d1f2f0cd9d26d4cba7e1e0af05d5a5","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"body":"@matt-peters in light of this, the `to_bioul` conversion for the conll2000 data actually doesn't work because the `to_bioul` function assumes that the coding is `IOB1`. \r\n\r\nI think it's worth making a `conll2000` dataset reader that subclasses the `conll2003` reader to more explicitly separate them? It's annoying because the chunk coding in the conll2000 data is BIO, while the chunk coding in the conll2003 data is IOB1.","created_at":"2018-08-23T23:14:44Z","updated_at":"2018-08-23T23:14:44Z","html_url":"https://github.com/allenai/allennlp/pull/1656#discussion_r212484018","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/1656","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/212484018"},"html":{"href":"https://github.com/allenai/allennlp/pull/1656#discussion_r212484018"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/1656","id":210597213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTk3MjEz","html_url":"https://github.com/allenai/allennlp/pull/1656","diff_url":"https://github.com/allenai/allennlp/pull/1656.diff","patch_url":"https://github.com/allenai/allennlp/pull/1656.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/1656","number":1656,"state":"open","locked":false,"title":"Standardize tagging datasets","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to enable a single sequence labeling model to work with all sequence labeling dataset readers.\r\n\r\nChanges:\r\n\r\n- [X] Modify CCGBank dataset reader to match Conll2003\r\n- [ ] add test that CRFTagger works on all sequence labeling datasets.\r\n\r\n@matt-peters these CCGBank changes might affect you? What do you think about them?","created_at":"2018-08-23T22:52:47Z","updated_at":"2018-08-23T23:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4275bbb049ed72b6ff2748d23166ffe6cd842328","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matt-gardner","id":3291951,"node_id":"MDQ6VXNlcjMyOTE5NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3291951?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-gardner","html_url":"https://github.com/matt-gardner","followers_url":"https://api.github.com/users/matt-gardner/followers","following_url":"https://api.github.com/users/matt-gardner/following{/other_user}","gists_url":"https://api.github.com/users/matt-gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-gardner/subscriptions","organizations_url":"https://api.github.com/users/matt-gardner/orgs","repos_url":"https://api.github.com/users/matt-gardner/repos","events_url":"https://api.github.com/users/matt-gardner/events{/privacy}","received_events_url":"https://api.github.com/users/matt-gardner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/1656/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/ea50418343d1f2f0cd9d26d4cba7e1e0af05d5a5","head":{"label":"nelson-liu:standardize_tagging_datasets","ref":"standardize_tagging_datasets","sha":"ea50418343d1f2f0cd9d26d4cba7e1e0af05d5a5","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"repo":{"id":96641587,"node_id":"MDEwOlJlcG9zaXRvcnk5NjY0MTU4Nw==","name":"allennlp","full_name":"nelson-liu/allennlp","owner":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelson-liu/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/nelson-liu/allennlp","forks_url":"https://api.github.com/repos/nelson-liu/allennlp/forks","keys_url":"https://api.github.com/repos/nelson-liu/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelson-liu/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelson-liu/allennlp/teams","hooks_url":"https://api.github.com/repos/nelson-liu/allennlp/hooks","issue_events_url":"https://api.github.com/repos/nelson-liu/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/nelson-liu/allennlp/events","assignees_url":"https://api.github.com/repos/nelson-liu/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/nelson-liu/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/nelson-liu/allennlp/tags","blobs_url":"https://api.github.com/repos/nelson-liu/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelson-liu/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelson-liu/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelson-liu/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelson-liu/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/nelson-liu/allennlp/languages","stargazers_url":"https://api.github.com/repos/nelson-liu/allennlp/stargazers","contributors_url":"https://api.github.com/repos/nelson-liu/allennlp/contributors","subscribers_url":"https://api.github.com/repos/nelson-liu/allennlp/subscribers","subscription_url":"https://api.github.com/repos/nelson-liu/allennlp/subscription","commits_url":"https://api.github.com/repos/nelson-liu/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelson-liu/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelson-liu/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelson-liu/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelson-liu/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/nelson-liu/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelson-liu/allennlp/merges","archive_url":"https://api.github.com/repos/nelson-liu/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelson-liu/allennlp/downloads","issues_url":"https://api.github.com/repos/nelson-liu/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/nelson-liu/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/nelson-liu/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/nelson-liu/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelson-liu/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/nelson-liu/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/nelson-liu/allennlp/deployments","created_at":"2017-07-08T20:09:14Z","updated_at":"2018-08-23T22:38:17Z","pushed_at":"2018-08-23T23:12:53Z","git_url":"git://github.com/nelson-liu/allennlp.git","ssh_url":"git@github.com:nelson-liu/allennlp.git","clone_url":"https://github.com/nelson-liu/allennlp.git","svn_url":"https://github.com/nelson-liu/allennlp","homepage":null,"size":14002,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"362060ac513c7bbb82d075a9304637a9bbbebbc5","user":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM1NjQwOA==","name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2018-08-23T23:11:36Z","pushed_at":"2018-08-23T23:12:54Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":13680,"stargazers_count":2999,"watchers_count":2999,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":516,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":516,"open_issues":100,"watchers":2999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1656"},"html":{"href":"https://github.com/allenai/allennlp/pull/1656"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1656"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/ea50418343d1f2f0cd9d26d4cba7e1e0af05d5a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nelson-liu"}}