{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/next.js/pulls/comments/221908830","pull_request_review_id":160668136,"id":221908830,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTkwODgzMA==","diff_hunk":"@@ -174,9 +178,6 @@ export default class Server {\n     }\n \n     const html = await this.renderToHTML(req, res, pathname, query)\n-    if (isResSent(res)) {","path":"packages/next-server/server/next-server.js","position":15,"original_position":15,"commit_id":"0170c49e2f8ac0263d8cec85ab09b6c51e035673","original_commit_id":"0170c49e2f8ac0263d8cec85ab09b6c51e035673","user":{"login":"timneutkens","id":6324199,"node_id":"MDQ6VXNlcjYzMjQxOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6324199?v=4","gravatar_id":"","url":"https://api.github.com/users/timneutkens","html_url":"https://github.com/timneutkens","followers_url":"https://api.github.com/users/timneutkens/followers","following_url":"https://api.github.com/users/timneutkens/following{/other_user}","gists_url":"https://api.github.com/users/timneutkens/gists{/gist_id}","starred_url":"https://api.github.com/users/timneutkens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timneutkens/subscriptions","organizations_url":"https://api.github.com/users/timneutkens/orgs","repos_url":"https://api.github.com/users/timneutkens/repos","events_url":"https://api.github.com/users/timneutkens/events{/privacy}","received_events_url":"https://api.github.com/users/timneutkens/received_events","type":"User","site_admin":false},"body":"This should definitely be here.","created_at":"2018-10-02T11:08:12Z","updated_at":"2018-10-02T11:08:12Z","html_url":"https://github.com/zeit/next.js/pull/5359#discussion_r221908830","pull_request_url":"https://api.github.com/repos/zeit/next.js/pulls/5359","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zeit/next.js/pulls/comments/221908830"},"html":{"href":"https://github.com/zeit/next.js/pull/5359#discussion_r221908830"},"pull_request":{"href":"https://api.github.com/repos/zeit/next.js/pulls/5359"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/next.js/pulls/5359","id":219610896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjEwODk2","html_url":"https://github.com/zeit/next.js/pull/5359","diff_url":"https://github.com/zeit/next.js/pull/5359.diff","patch_url":"https://github.com/zeit/next.js/pull/5359.patch","issue_url":"https://api.github.com/repos/zeit/next.js/issues/5359","number":5359,"state":"open","locked":false,"title":"Make `Server#render()` a noop if the response was already sent","user":{"login":"lpinca","id":1443911,"node_id":"MDQ6VXNlcjE0NDM5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1443911?v=4","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"body":"Move the bail-out check at the top of the method.","created_at":"2018-10-02T07:38:46Z","updated_at":"2018-10-02T11:08:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8e313c035e107724080f732178991928ba51c33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/next.js/pulls/5359/commits","review_comments_url":"https://api.github.com/repos/zeit/next.js/pulls/5359/comments","review_comment_url":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/next.js/issues/5359/comments","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/0170c49e2f8ac0263d8cec85ab09b6c51e035673","head":{"label":"lpinca:move/bail-out-check","ref":"move/bail-out-check","sha":"0170c49e2f8ac0263d8cec85ab09b6c51e035673","user":{"login":"lpinca","id":1443911,"node_id":"MDQ6VXNlcjE0NDM5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1443911?v=4","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"repo":{"id":151213200,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMTMyMDA=","name":"next.js","full_name":"lpinca/next.js","private":false,"owner":{"login":"lpinca","id":1443911,"node_id":"MDQ6VXNlcjE0NDM5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1443911?v=4","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lpinca/next.js","description":"Next.js is a lightweight framework for static and server‑rendered applications.","fork":true,"url":"https://api.github.com/repos/lpinca/next.js","forks_url":"https://api.github.com/repos/lpinca/next.js/forks","keys_url":"https://api.github.com/repos/lpinca/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpinca/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpinca/next.js/teams","hooks_url":"https://api.github.com/repos/lpinca/next.js/hooks","issue_events_url":"https://api.github.com/repos/lpinca/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/lpinca/next.js/events","assignees_url":"https://api.github.com/repos/lpinca/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/lpinca/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/lpinca/next.js/tags","blobs_url":"https://api.github.com/repos/lpinca/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpinca/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpinca/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpinca/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpinca/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/lpinca/next.js/languages","stargazers_url":"https://api.github.com/repos/lpinca/next.js/stargazers","contributors_url":"https://api.github.com/repos/lpinca/next.js/contributors","subscribers_url":"https://api.github.com/repos/lpinca/next.js/subscribers","subscription_url":"https://api.github.com/repos/lpinca/next.js/subscription","commits_url":"https://api.github.com/repos/lpinca/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpinca/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpinca/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpinca/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpinca/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/lpinca/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpinca/next.js/merges","archive_url":"https://api.github.com/repos/lpinca/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpinca/next.js/downloads","issues_url":"https://api.github.com/repos/lpinca/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/lpinca/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/lpinca/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/lpinca/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpinca/next.js/labels{/name}","releases_url":"https://api.github.com/repos/lpinca/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/lpinca/next.js/deployments","created_at":"2018-10-02T06:59:32Z","updated_at":"2018-10-02T06:59:36Z","pushed_at":"2018-10-02T07:38:22Z","git_url":"git://github.com/lpinca/next.js.git","ssh_url":"git@github.com:lpinca/next.js.git","clone_url":"https://github.com/lpinca/next.js.git","svn_url":"https://github.com/lpinca/next.js","homepage":"https://nextjs.org","size":7763,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"canary"}},"base":{"label":"zeit:canary","ref":"canary","sha":"e994159e383765431780ca83eed8ab0618962c9b","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":70107786,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEwNzc4Ng==","name":"next.js","full_name":"zeit/next.js","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/next.js","description":"Next.js is a lightweight framework for static and server‑rendered applications.","fork":false,"url":"https://api.github.com/repos/zeit/next.js","forks_url":"https://api.github.com/repos/zeit/next.js/forks","keys_url":"https://api.github.com/repos/zeit/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/next.js/teams","hooks_url":"https://api.github.com/repos/zeit/next.js/hooks","issue_events_url":"https://api.github.com/repos/zeit/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/next.js/events","assignees_url":"https://api.github.com/repos/zeit/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/next.js/tags","blobs_url":"https://api.github.com/repos/zeit/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/next.js/languages","stargazers_url":"https://api.github.com/repos/zeit/next.js/stargazers","contributors_url":"https://api.github.com/repos/zeit/next.js/contributors","subscribers_url":"https://api.github.com/repos/zeit/next.js/subscribers","subscription_url":"https://api.github.com/repos/zeit/next.js/subscription","commits_url":"https://api.github.com/repos/zeit/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/next.js/merges","archive_url":"https://api.github.com/repos/zeit/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/next.js/downloads","issues_url":"https://api.github.com/repos/zeit/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/next.js/labels{/name}","releases_url":"https://api.github.com/repos/zeit/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/next.js/deployments","created_at":"2016-10-05T23:32:51Z","updated_at":"2018-10-02T10:09:38Z","pushed_at":"2018-10-02T10:32:50Z","git_url":"git://github.com/zeit/next.js.git","ssh_url":"git@github.com:zeit/next.js.git","clone_url":"https://github.com/zeit/next.js.git","svn_url":"https://github.com/zeit/next.js","homepage":"https://nextjs.org","size":7763,"stargazers_count":29874,"watchers_count":29874,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3063,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3063,"open_issues":307,"watchers":29874,"default_branch":"canary"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/next.js/pulls/5359"},"html":{"href":"https://github.com/zeit/next.js/pull/5359"},"issue":{"href":"https://api.github.com/repos/zeit/next.js/issues/5359"},"comments":{"href":"https://api.github.com/repos/zeit/next.js/issues/5359/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/next.js/pulls/5359/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/next.js/pulls/5359/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/next.js/statuses/0170c49e2f8ac0263d8cec85ab09b6c51e035673"}},"author_association":"NONE"}}
{"actor":{"display_login":"timneutkens"}}