{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/comments/212989232","pull_request_review_id":149728595,"id":212989232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjk4OTIzMg==","diff_hunk":"@@ -19,8 +19,8 @@\n     <PackageReference Include=\"Microsoft.NET.Test.Sdk\" Version=\"15.3.0\" />\n     <PackageReference Include=\"NServiceBus.Testing.Fakes.Sources\" Version=\"7.1.0\" />\n     <PackageReference Include=\"NUnit\" Version=\"3.10.1\" />\n-    <PackageReference Include=\"NUnit3TestAdapter\" Version=\"3.10.0\" />\n-    <PackageReference Include=\"PublicApiGenerator\" Version=\"8.0.0\" />\n+    <PackageReference Include=\"PublicApiGenerator\" Version=\"6.4.0\" />\n+    <PackageReference Include=\"NUnit3TestAdapter\" Version=\"3.8.0-alpha1\" />","path":"src/NServiceBus.Transport.Msmq.Tests/NServiceBus.Transport.Msmq.Tests.csproj","position":7,"original_position":7,"commit_id":"0319c173c96f254e05729480cc2c92a13572d2cc","original_commit_id":"0319c173c96f254e05729480cc2c92a13572d2cc","user":{"login":"bording","id":753669,"node_id":"MDQ6VXNlcjc1MzY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/753669?v=4","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"body":"Should we add the comment here about why it needs to stay on this version?","created_at":"2018-08-27T14:11:10Z","updated_at":"2018-08-27T14:11:10Z","html_url":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66#discussion_r212989232","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/comments/212989232"},"html":{"href":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66#discussion_r212989232"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66","id":211083101,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDgzMTAx","html_url":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66","diff_url":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66.diff","patch_url":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/66","number":66,"state":"closed","locked":false,"title":"Minor fixups","user":{"login":"timbussmann","id":3524870,"node_id":"MDQ6VXNlcjM1MjQ4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3524870?v=4","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"body":"Some fixups from #65:\r\n* Fix usage of `NoWarn`\r\n* Keep NUnitTestAdapter and the PublicApiGenerator packages on the old version for .net core compatibility. While the current versions runs fine in VS & TC, it can cause issues when running it via dotnet commands due to Mono.Cecil issues.","created_at":"2018-08-27T11:37:30Z","updated_at":"2018-08-27T14:11:10Z","closed_at":"2018-08-27T11:50:47Z","merged_at":"2018-08-27T11:50:47Z","merge_commit_sha":"dc67bc7e7528fc8731b875071cad736b01a8c08e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/66/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/statuses/0319c173c96f254e05729480cc2c92a13572d2cc","head":{"label":"Particular:update-core-fixups","ref":"update-core-fixups","sha":"0319c173c96f254e05729480cc2c92a13572d2cc","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":88633612,"node_id":"MDEwOlJlcG9zaXRvcnk4ODYzMzYxMg==","name":"NServiceBus.Transport.Msmq","full_name":"Particular/NServiceBus.Transport.Msmq","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Transport.Msmq","description":"MSMQ transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/deployments","created_at":"2017-04-18T14:19:02Z","updated_at":"2018-08-27T11:50:48Z","pushed_at":"2018-08-27T11:50:49Z","git_url":"git://github.com/Particular/NServiceBus.Transport.Msmq.git","ssh_url":"git@github.com:Particular/NServiceBus.Transport.Msmq.git","clone_url":"https://github.com/Particular/NServiceBus.Transport.Msmq.git","svn_url":"https://github.com/Particular/NServiceBus.Transport.Msmq","homepage":"https://docs.particular.net/nservicebus/msmq/","size":343,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":13,"watchers":0,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"45988416ec6a3a89c5669486fd657b08ec95dbf7","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":88633612,"node_id":"MDEwOlJlcG9zaXRvcnk4ODYzMzYxMg==","name":"NServiceBus.Transport.Msmq","full_name":"Particular/NServiceBus.Transport.Msmq","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Transport.Msmq","description":"MSMQ transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/deployments","created_at":"2017-04-18T14:19:02Z","updated_at":"2018-08-27T11:50:48Z","pushed_at":"2018-08-27T11:50:49Z","git_url":"git://github.com/Particular/NServiceBus.Transport.Msmq.git","ssh_url":"git@github.com:Particular/NServiceBus.Transport.Msmq.git","clone_url":"https://github.com/Particular/NServiceBus.Transport.Msmq.git","svn_url":"https://github.com/Particular/NServiceBus.Transport.Msmq","homepage":"https://docs.particular.net/nservicebus/msmq/","size":343,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":13,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66"},"html":{"href":"https://github.com/Particular/NServiceBus.Transport.Msmq/pull/66"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/66"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.Transport.Msmq/statuses/0319c173c96f254e05729480cc2c92a13572d2cc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bording"}}