{"action":"created","comment":{"url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/comments/176284801","pull_request_review_id":105959907,"id":176284801,"diff_hunk":"@@ -336,15 +337,18 @@ - (BOOL)startRendering:(nonnull TVIAudioDeviceContext)context {\n                                     captureContext:self.capturingContext]) {\n             return NO;\n         }\n-        return [self startAudioUnit];\n+        BOOL success = [self startAudioUnit];\n+        if (success) {\n+            TVIAudioSessionActivated(context);\n+        }\n+        return success;","path":"AudioDeviceExample/AudioDevices/ExampleAVAudioEngineDevice.m","position":82,"original_position":82,"commit_id":"fe553f140e5b59e7dad9bab5d9de67e7981b7b70","original_commit_id":"bf24e9988e0f8a22f149ce18880c9afdf32f0667","user":{"login":"ceaglest","id":1302577,"avatar_url":"https://avatars2.githubusercontent.com/u/1302577?v=4","gravatar_id":"","url":"https://api.github.com/users/ceaglest","html_url":"https://github.com/ceaglest","followers_url":"https://api.github.com/users/ceaglest/followers","following_url":"https://api.github.com/users/ceaglest/following{/other_user}","gists_url":"https://api.github.com/users/ceaglest/gists{/gist_id}","starred_url":"https://api.github.com/users/ceaglest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceaglest/subscriptions","organizations_url":"https://api.github.com/users/ceaglest/orgs","repos_url":"https://api.github.com/users/ceaglest/repos","events_url":"https://api.github.com/users/ceaglest/events{/privacy}","received_events_url":"https://api.github.com/users/ceaglest/received_events","type":"User","site_admin":false},"body":"This is the approach that we kept. If we decide to change it in the future, we can issue another PR.","created_at":"2018-03-22T01:05:05Z","updated_at":"2018-03-22T01:05:05Z","html_url":"https://github.com/twilio/video-quickstart-swift/pull/245#discussion_r176284801","pull_request_url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/comments/176284801"},"html":{"href":"https://github.com/twilio/video-quickstart-swift/pull/245#discussion_r176284801"},"pull_request":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245"}},"in_reply_to_id":175969811},"pull_request":{"url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245","id":176357944,"html_url":"https://github.com/twilio/video-quickstart-swift/pull/245","diff_url":"https://github.com/twilio/video-quickstart-swift/pull/245.diff","patch_url":"https://github.com/twilio/video-quickstart-swift/pull/245.patch","issue_url":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/245","number":245,"state":"closed","locked":false,"title":"ISDK-1912: Support TVIAudioDevice backgrounding (2.0.0-beta3)","user":{"login":"ceaglest","id":1302577,"avatar_url":"https://avatars2.githubusercontent.com/u/1302577?v=4","gravatar_id":"","url":"https://api.github.com/users/ceaglest","html_url":"https://github.com/ceaglest","followers_url":"https://api.github.com/users/ceaglest/followers","following_url":"https://api.github.com/users/ceaglest/following{/other_user}","gists_url":"https://api.github.com/users/ceaglest/gists{/gist_id}","starred_url":"https://api.github.com/users/ceaglest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceaglest/subscriptions","organizations_url":"https://api.github.com/users/ceaglest/orgs","repos_url":"https://api.github.com/users/ceaglest/repos","events_url":"https://api.github.com/users/ceaglest/events{/privacy}","received_events_url":"https://api.github.com/users/ceaglest/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR adds support for the API changes in 2.0.0-beta3, focusing on TVIAudioDevice and backgrounding. The devices in AudioDeviceExample have been updated to signal AVAudioSession state changes. I also updated the READMEs, and Podspec.\r\n\r\n### Discussion\r\n\r\nRight now, our examples are \"static\" in their usage of AVAudioSession and they typically just activate it at initialization time (`ExampleAVAudioEngineDevice`) or when the first format is read (`ExampleCoreAudioDevice`). \r\n\r\nI followed the convention from @piyushtank's original commit, by firing audio session events after starting/stopping the AudioUnit. I think we should reconsider this approach and tie the events purely to AVAudioSession interruptions, and manually activating / deactivating the AVAudioSession. This would make the code easier to read, and a truer representation of the AVAudioSession state.\r\n\r\n### Testing\r\n\r\nSo far I've been testing on iOS 11.2.6 but I'll give this a try on a few more device / OS combos before we merge the changes tomorrow.","created_at":"2018-03-21T00:27:57Z","updated_at":"2018-03-22T01:05:05Z","closed_at":"2018-03-21T22:42:51Z","merged_at":"2018-03-21T22:42:51Z","merge_commit_sha":"d09b04d0cb31ad8513c894f38843ea0b906a4220","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245/commits","review_comments_url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245/comments","review_comment_url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/245/comments","statuses_url":"https://api.github.com/repos/twilio/video-quickstart-swift/statuses/fe553f140e5b59e7dad9bab5d9de67e7981b7b70","head":{"label":"ceaglest:task/isdk-1912-audiodevice-backgrounding","ref":"task/isdk-1912-audiodevice-backgrounding","sha":"fe553f140e5b59e7dad9bab5d9de67e7981b7b70","user":{"login":"ceaglest","id":1302577,"avatar_url":"https://avatars2.githubusercontent.com/u/1302577?v=4","gravatar_id":"","url":"https://api.github.com/users/ceaglest","html_url":"https://github.com/ceaglest","followers_url":"https://api.github.com/users/ceaglest/followers","following_url":"https://api.github.com/users/ceaglest/following{/other_user}","gists_url":"https://api.github.com/users/ceaglest/gists{/gist_id}","starred_url":"https://api.github.com/users/ceaglest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceaglest/subscriptions","organizations_url":"https://api.github.com/users/ceaglest/orgs","repos_url":"https://api.github.com/users/ceaglest/repos","events_url":"https://api.github.com/users/ceaglest/events{/privacy}","received_events_url":"https://api.github.com/users/ceaglest/received_events","type":"User","site_admin":false},"repo":{"id":69517832,"name":"video-quickstart-swift","full_name":"ceaglest/video-quickstart-swift","owner":{"login":"ceaglest","id":1302577,"avatar_url":"https://avatars2.githubusercontent.com/u/1302577?v=4","gravatar_id":"","url":"https://api.github.com/users/ceaglest","html_url":"https://github.com/ceaglest","followers_url":"https://api.github.com/users/ceaglest/followers","following_url":"https://api.github.com/users/ceaglest/following{/other_user}","gists_url":"https://api.github.com/users/ceaglest/gists{/gist_id}","starred_url":"https://api.github.com/users/ceaglest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceaglest/subscriptions","organizations_url":"https://api.github.com/users/ceaglest/orgs","repos_url":"https://api.github.com/users/ceaglest/repos","events_url":"https://api.github.com/users/ceaglest/events{/privacy}","received_events_url":"https://api.github.com/users/ceaglest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceaglest/video-quickstart-swift","description":"Twilio Video Quickstart for iOS with Swift https://www.twilio.com/docs/api/video","fork":true,"url":"https://api.github.com/repos/ceaglest/video-quickstart-swift","forks_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/forks","keys_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/teams","hooks_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/hooks","issue_events_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/issues/events{/number}","events_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/events","assignees_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/assignees{/user}","branches_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/branches{/branch}","tags_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/tags","blobs_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/languages","stargazers_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/stargazers","contributors_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/contributors","subscribers_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/subscribers","subscription_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/subscription","commits_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/contents/{+path}","compare_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/merges","archive_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/downloads","issues_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/issues{/number}","pulls_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/labels{/name}","releases_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/releases{/id}","deployments_url":"https://api.github.com/repos/ceaglest/video-quickstart-swift/deployments","created_at":"2016-09-29T01:19:01Z","updated_at":"2017-09-11T03:01:21Z","pushed_at":"2018-03-21T22:43:41Z","git_url":"git://github.com/ceaglest/video-quickstart-swift.git","ssh_url":"git@github.com:ceaglest/video-quickstart-swift.git","clone_url":"https://github.com/ceaglest/video-quickstart-swift.git","svn_url":"https://github.com/ceaglest/video-quickstart-swift","homepage":"","size":8704,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"twilio:master","ref":"master","sha":"22c07301c7b9bfd7121fb2df2413a60147721a34","user":{"login":"twilio","id":109142,"avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":48068060,"name":"video-quickstart-swift","full_name":"twilio/video-quickstart-swift","owner":{"login":"twilio","id":109142,"avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twilio/video-quickstart-swift","description":"Twilio Video Quickstart for iOS with Swift","fork":false,"url":"https://api.github.com/repos/twilio/video-quickstart-swift","forks_url":"https://api.github.com/repos/twilio/video-quickstart-swift/forks","keys_url":"https://api.github.com/repos/twilio/video-quickstart-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/video-quickstart-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/video-quickstart-swift/teams","hooks_url":"https://api.github.com/repos/twilio/video-quickstart-swift/hooks","issue_events_url":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/video-quickstart-swift/events","assignees_url":"https://api.github.com/repos/twilio/video-quickstart-swift/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/video-quickstart-swift/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/video-quickstart-swift/tags","blobs_url":"https://api.github.com/repos/twilio/video-quickstart-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/video-quickstart-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/video-quickstart-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/video-quickstart-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/video-quickstart-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/video-quickstart-swift/languages","stargazers_url":"https://api.github.com/repos/twilio/video-quickstart-swift/stargazers","contributors_url":"https://api.github.com/repos/twilio/video-quickstart-swift/contributors","subscribers_url":"https://api.github.com/repos/twilio/video-quickstart-swift/subscribers","subscription_url":"https://api.github.com/repos/twilio/video-quickstart-swift/subscription","commits_url":"https://api.github.com/repos/twilio/video-quickstart-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/video-quickstart-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/video-quickstart-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/twilio/video-quickstart-swift/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/video-quickstart-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/video-quickstart-swift/merges","archive_url":"https://api.github.com/repos/twilio/video-quickstart-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/video-quickstart-swift/downloads","issues_url":"https://api.github.com/repos/twilio/video-quickstart-swift/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/video-quickstart-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/video-quickstart-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/video-quickstart-swift/labels{/name}","releases_url":"https://api.github.com/repos/twilio/video-quickstart-swift/releases{/id}","deployments_url":"https://api.github.com/repos/twilio/video-quickstart-swift/deployments","created_at":"2015-12-15T20:46:04Z","updated_at":"2018-03-21T22:43:40Z","pushed_at":"2018-03-21T22:43:39Z","git_url":"git://github.com/twilio/video-quickstart-swift.git","ssh_url":"git@github.com:twilio/video-quickstart-swift.git","clone_url":"https://github.com/twilio/video-quickstart-swift.git","svn_url":"https://github.com/twilio/video-quickstart-swift","homepage":"https://www.twilio.com/docs/api/video","size":10894,"stargazers_count":111,"watchers_count":111,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":45,"open_issues":37,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245"},"html":{"href":"https://github.com/twilio/video-quickstart-swift/pull/245"},"issue":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/245"},"comments":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/twilio/video-quickstart-swift/statuses/fe553f140e5b59e7dad9bab5d9de67e7981b7b70"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ceaglest"}}