{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28169","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28169/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28169/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28169/events","html_url":"https://github.com/Automattic/wp-calypso/pull/28169","id":375524687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTQ5NTI3","number":28169,"title":"Simple Payments: gutenberg block UI","user":{"login":"simison","id":87168,"node_id":"MDQ6VXNlcjg3MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/87168?v=4","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"labels":[{"id":780071208,"node_id":"MDU6TGFiZWw3ODAwNzEyMDg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Simple%20Payments","name":"Simple Payments","color":"006b75","default":false},{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false}],"state":"open","locked":false,"assignee":{"login":"simison","id":87168,"node_id":"MDQ6VXNlcjg3MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/87168?v=4","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"assignees":[{"login":"simison","id":87168,"node_id":"MDQ6VXNlcjg3MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/87168?v=4","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-10-30T14:40:23Z","updated_at":"2018-11-02T16:20:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28169","html_url":"https://github.com/Automattic/wp-calypso/pull/28169","diff_url":"https://github.com/Automattic/wp-calypso/pull/28169.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/28169.patch"},"body":"Adds basic UI for Simple payments Gutenberg block.\r\n\r\n## Screenshots\r\n\r\n#### UI:\r\n<img src=\"https://user-images.githubusercontent.com/87168/47922789-903ffd80-dec0-11e8-9801-a05b8d01067b.png\" width=\"500\" />\r\n\r\n#### UI screaming warnings:\r\n<img src=\"https://user-images.githubusercontent.com/87168/47922790-903ffd80-dec0-11e8-97ae-9d0fc70fd018.png\" width=\"500\" />\r\n\r\n#### Preview in editor:\r\n\r\n<img src=\"https://user-images.githubusercontent.com/87168/47882842-760c0e00-de33-11e8-8f30-e407d25e42bb.png\" width=\"250\"/>\r\n\r\n#### End result at the site:\r\n\r\n<img src=\"https://user-images.githubusercontent.com/87168/47883031-342f9780-de34-11e8-8060-740f5f678670.png\" width=\"250\"/>\r\n\r\n\r\n## Todo / known issues\r\n- [ ] Merge API changes https://github.com/Automattic/jetpack/pull/10402\r\n- [x] Missing input error states\r\n   - [x] Improve or add value validation in the block and in the API\r\n   - [x] Highlighting invalid inputs after block de-select\r\n   - [ ] Show errors coming from the API\r\n- [x] Small styling adjustments to other elements:\r\n    - [x] Email help text font size\r\n    - [ ] horizontal alignment of currency and price inputs\r\n- [x] Link \"PayPal\" word in email help text to `paypal.com`\r\n- [x] PayPal image in preview mode doesn't work; need to figure out how to ship png files\r\n- [ ] Limit prices to `>= 1.00`\r\n- [x] _when I unfocus the block, my 0.5 USD becomes $0.00_ (this is probably because of the backend that sanitizes prices to integers right now)\r\n- [x] Cleanup `view.scss` — now it's just copied over from Jetpack plugin and we need very little from it for the preview\r\n- [ ] Block is always enabled regardless of the site plan (Poseidon)\r\n\r\n## Testing instructions\r\n\r\n### Test in Jetpack\r\n* Jurassic Ninja: https://jurassic.ninja/create?jetpack-beta&branch=update/simple-payments-rest-api-meta&gutenpack&gutenberg&calypsobranch=add/gutenpack-simplepayments-ui\r\n* Connect Jetpack, purchase \"premium\" or \"business\" plan\r\n* Create new post in Gutenberg and add \"Payment button\" block\r\n* Open the post and see the button\r\n* Open the post in Calypso classic editor and see the button\r\n* Open the post in Calypso using this branch and Gutenberg and see the button: https://calypso.live/gutenberg/post?branch=add/gutenpack-simplepayments-ui\r\n\r\n### Test in Calypso\r\n- Apply patch to your sandbox: D19907-code\r\n- Open https://calypso.live/gutenberg/post?branch=add/gutenpack-simplepayments-ui\r\n- Choose a site with Simple payments enabled (purchase \"premium\" or \"business\" plan)\r\n\r\n### Manual checking\r\nApply these patches and cross-test the block in different editors:\r\n- This PR\r\n- https://github.com/Automattic/jetpack/pull/10402\r\n- D19907-code\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/435434245","html_url":"https://github.com/Automattic/wp-calypso/pull/28169#issuecomment-435434245","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28169","id":435434245,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQzNDI0NQ==","user":{"login":"thomasguillot","id":177929,"node_id":"MDQ6VXNlcjE3NzkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/177929?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasguillot","html_url":"https://github.com/thomasguillot","followers_url":"https://api.github.com/users/thomasguillot/followers","following_url":"https://api.github.com/users/thomasguillot/following{/other_user}","gists_url":"https://api.github.com/users/thomasguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasguillot/subscriptions","organizations_url":"https://api.github.com/users/thomasguillot/orgs","repos_url":"https://api.github.com/users/thomasguillot/repos","events_url":"https://api.github.com/users/thomasguillot/events{/privacy}","received_events_url":"https://api.github.com/users/thomasguillot/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T16:20:48Z","updated_at":"2018-11-02T16:20:48Z","author_association":"MEMBER","body":"![screenshot 2018-11-02 at 16 16 19](https://user-images.githubusercontent.com/177929/47927311-d2664080-deba-11e8-8282-c9881bd409b9.png)\r\n\r\nFont-size/Line-height for label/error/\"This is where PayPal...\" should all be the same, at `font-size: 13px; line-height: 1.4em;`, per Gutenberg/WP's label standards"}}
{"actor":{"display_login":"thomasguillot"}}