{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/178055580","pull_request_review_id":108047120,"id":178055580,"diff_hunk":"@@ -106,22 +106,31 @@\n             transaction {:id         id\n                          :from       from\n                          :to         to\n+                         :to-name    (when (= to constants/contract-address)\n+                                       (i18n/label :t/new-contract))\n                          :symbol     symbol\n                          :value      (money/bignumber (or value 0))\n                          :data       data\n-                         :gas        (money/bignumber (money/to-decimal gas))\n-                         :gas-price  (money/bignumber (money/to-decimal gasPrice))\n+                         :gas        (when (seq gas)\n+                                       (money/bignumber (money/to-decimal gas)))\n+                         :gas-price  (when (seq gasPrice)\n+                                       (money/bignumber (money/to-decimal gasPrice)))\n                          :timestamp  now\n                          :message-id message_id}\n-            sending-from-chat? (not (get-in db [:wallet :send-transaction :waiting-signal?]))\n+            sending-from-bot-or-dapp? (not (get-in db [:wallet :send-transaction :waiting-signal?]))\n             new-db (assoc-in db [:wallet :transactions-unsigned id] transaction)\n             sending-db {:id         id\n-                        :from-chat? sending-from-chat?}]\n-        (if sending-from-chat?\n-          ;;SENDING FROM CHAT\n-          {:db       (assoc-in new-db [:wallet :send-transaction] sending-db) ; we need to completely reset sending state here\n-           :dispatch-n [[:update-wallet (map :symbol (tokens/tokens-for (ethereum/network->chain-keyword (:network db))))] [:navigate-to-modal :wallet-send-transaction-modal]]}\n-          ;;SEND SCREEN WAITING SIGNAL\n+                        :from-chat? sending-from-bot-or-dapp?}]\n+        (if sending-from-bot-or-dapp?\n+          ;;SENDING FROM BOT (CHAT) OR DAPP\n+          {:db         (assoc-in new-db [:wallet :send-transaction] sending-db) ; we need to completely reset sending state here\n+           :dispatch-n [[:update-wallet (map :symbol (tokens/tokens-for (ethereum/network->chain-keyword (:network db))))]\n+                        [:navigate-to-modal :wallet-send-transaction-modal]\n+                        (when-not (seq gas)","path":"src/status_im/ui/screens/wallet/send/events.cljs","position":33,"original_position":33,"commit_id":"34dcfe4759694658524fbfa2074f32867294c70e","original_commit_id":"34dcfe4759694658524fbfa2074f32867294c70e","user":{"login":"jeluard","id":359723,"avatar_url":"https://avatars1.githubusercontent.com/u/359723?v=4","gravatar_id":"","url":"https://api.github.com/users/jeluard","html_url":"https://github.com/jeluard","followers_url":"https://api.github.com/users/jeluard/followers","following_url":"https://api.github.com/users/jeluard/following{/other_user}","gists_url":"https://api.github.com/users/jeluard/gists{/gist_id}","starred_url":"https://api.github.com/users/jeluard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeluard/subscriptions","organizations_url":"https://api.github.com/users/jeluard/orgs","repos_url":"https://api.github.com/users/jeluard/repos","events_url":"https://api.github.com/users/jeluard/events{/privacy}","received_events_url":"https://api.github.com/users/jeluard/received_events","type":"User","site_admin":false},"body":"`(when (seq s))` is idiomatic to filter empty sequence (as opposed to `(when-not (empty? s))`) but I don't think it is for string? \r\nNot very important, but something we should consider for our style guide.","created_at":"2018-03-29T13:30:32Z","updated_at":"2018-03-29T13:30:32Z","html_url":"https://github.com/status-im/status-react/pull/3724#discussion_r178055580","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/3724","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/178055580"},"html":{"href":"https://github.com/status-im/status-react/pull/3724#discussion_r178055580"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3724"}},"in_reply_to_id":178050459},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/3724","id":178318013,"html_url":"https://github.com/status-im/status-react/pull/3724","diff_url":"https://github.com/status-im/status-react/pull/3724.diff","patch_url":"https://github.com/status-im/status-react/pull/3724.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/3724","number":3724,"state":"open","locked":false,"title":"Bug/Empty Gas limit and Gas price","user":{"login":"flexsurfer","id":11790366,"avatar_url":"https://avatars1.githubusercontent.com/u/11790366?v=4","gravatar_id":"","url":"https://api.github.com/users/flexsurfer","html_url":"https://github.com/flexsurfer","followers_url":"https://api.github.com/users/flexsurfer/followers","following_url":"https://api.github.com/users/flexsurfer/following{/other_user}","gists_url":"https://api.github.com/users/flexsurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/flexsurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flexsurfer/subscriptions","organizations_url":"https://api.github.com/users/flexsurfer/orgs","repos_url":"https://api.github.com/users/flexsurfer/repos","events_url":"https://api.github.com/users/flexsurfer/events{/privacy}","received_events_url":"https://api.github.com/users/flexsurfer/received_events","type":"User","site_admin":false},"body":"\r\n\r\nfixes #3022\r\n","created_at":"2018-03-29T12:46:59Z","updated_at":"2018-03-29T13:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"367b20e130946c0ee687a65f754ae36c075082e7","assignee":{"login":"flexsurfer","id":11790366,"avatar_url":"https://avatars1.githubusercontent.com/u/11790366?v=4","gravatar_id":"","url":"https://api.github.com/users/flexsurfer","html_url":"https://github.com/flexsurfer","followers_url":"https://api.github.com/users/flexsurfer/followers","following_url":"https://api.github.com/users/flexsurfer/following{/other_user}","gists_url":"https://api.github.com/users/flexsurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/flexsurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flexsurfer/subscriptions","organizations_url":"https://api.github.com/users/flexsurfer/orgs","repos_url":"https://api.github.com/users/flexsurfer/repos","events_url":"https://api.github.com/users/flexsurfer/events{/privacy}","received_events_url":"https://api.github.com/users/flexsurfer/received_events","type":"User","site_admin":false},"assignees":[{"login":"flexsurfer","id":11790366,"avatar_url":"https://avatars1.githubusercontent.com/u/11790366?v=4","gravatar_id":"","url":"https://api.github.com/users/flexsurfer","html_url":"https://github.com/flexsurfer","followers_url":"https://api.github.com/users/flexsurfer/followers","following_url":"https://api.github.com/users/flexsurfer/following{/other_user}","gists_url":"https://api.github.com/users/flexsurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/flexsurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flexsurfer/subscriptions","organizations_url":"https://api.github.com/users/flexsurfer/orgs","repos_url":"https://api.github.com/users/flexsurfer/repos","events_url":"https://api.github.com/users/flexsurfer/events{/privacy}","received_events_url":"https://api.github.com/users/flexsurfer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/3724/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/3724/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/3724/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/34dcfe4759694658524fbfa2074f32867294c70e","head":{"label":"status-im:bug/empty-gas-limit-and-gas-price","ref":"bug/empty-gas-limit-and-gas-price","sha":"34dcfe4759694658524fbfa2074f32867294c70e","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-03-29T13:23:57Z","pushed_at":"2018-03-29T13:07:20Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":52533,"stargazers_count":2091,"watchers_count":2091,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":505,"mirror_url":null,"archived":false,"open_issues_count":550,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":505,"open_issues":550,"watchers":2091,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"6786123765535f29a2b869c6597d800d098d76d1","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-03-29T13:23:57Z","pushed_at":"2018-03-29T13:07:20Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":52533,"stargazers_count":2091,"watchers_count":2091,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":505,"mirror_url":null,"archived":false,"open_issues_count":550,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":505,"open_issues":550,"watchers":2091,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3724"},"html":{"href":"https://github.com/status-im/status-react/pull/3724"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/3724"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/3724/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3724/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/3724/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/34dcfe4759694658524fbfa2074f32867294c70e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jeluard"}}