{"action":"created","comment":{"url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments/189334035","pull_request_review_id":121499492,"id":189334035,"diff_hunk":"@@ -197,7 +203,7 @@ fi\n \n # Optimization notes:\n #  -disable-simplify-libcalls:  prevents transforming loops into library calls such as memset, memcopy on GPU\n-$OPT -mtriple amdgcn--amdhsa-amdgiz -mcpu=$AMDGPU_TARGET -infer-address-spaces -amdgpu-internalize-symbols -disable-simplify-libcalls $KMOPTOPT -verify $2.selected.bc -o $2.opt.bc\n+$OPT -mtriple amdgcn--amdhsa-amdgiz -mcpu=$AMDGPU_TARGET -amdgpu-internalize-symbols -disable-simplify-libcalls $KMOPTOPT -verify $2.selected.bc -o $2.opt.bc","path":"lib/clamp-device.in","position":27,"original_position":27,"commit_id":"0c1b86f185e368b24c5f80b0a75955c642a44fb7","original_commit_id":"0fc586d8c4ddef440a631b585358eecba53c5c92","user":{"login":"AlexVlx","id":23191400,"avatar_url":"https://avatars2.githubusercontent.com/u/23191400?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexVlx","html_url":"https://github.com/AlexVlx","followers_url":"https://api.github.com/users/AlexVlx/followers","following_url":"https://api.github.com/users/AlexVlx/following{/other_user}","gists_url":"https://api.github.com/users/AlexVlx/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexVlx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexVlx/subscriptions","organizations_url":"https://api.github.com/users/AlexVlx/orgs","repos_url":"https://api.github.com/users/AlexVlx/repos","events_url":"https://api.github.com/users/AlexVlx/events{/privacy}","received_events_url":"https://api.github.com/users/AlexVlx/received_events","type":"User","site_admin":false},"body":"Definitely not after running optimisation, that will prune the casts. The initial ordering (infer before inline) was a typo on my part, I only realised what you guys meant now; corrected.","created_at":"2018-05-18T17:06:37Z","updated_at":"2018-05-18T17:06:38Z","html_url":"https://github.com/RadeonOpenCompute/hcc/pull/731#discussion_r189334035","pull_request_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments/189334035"},"html":{"href":"https://github.com/RadeonOpenCompute/hcc/pull/731#discussion_r189334035"},"pull_request":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731"}},"in_reply_to_id":189327577},"pull_request":{"url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731","id":187681578,"html_url":"https://github.com/RadeonOpenCompute/hcc/pull/731","diff_url":"https://github.com/RadeonOpenCompute/hcc/pull/731.diff","patch_url":"https://github.com/RadeonOpenCompute/hcc/pull/731.patch","issue_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/731","number":731,"state":"open","locked":false,"title":"Pointers passed / captured to / by a kernel can only point to global,…","user":{"login":"AlexVlx","id":23191400,"avatar_url":"https://avatars2.githubusercontent.com/u/23191400?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexVlx","html_url":"https://github.com/AlexVlx","followers_url":"https://api.github.com/users/AlexVlx/followers","following_url":"https://api.github.com/users/AlexVlx/following{/other_user}","gists_url":"https://api.github.com/users/AlexVlx/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexVlx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexVlx/subscriptions","organizations_url":"https://api.github.com/users/AlexVlx/orgs","repos_url":"https://api.github.com/users/AlexVlx/repos","events_url":"https://api.github.com/users/AlexVlx/events{/privacy}","received_events_url":"https://api.github.com/users/AlexVlx/received_events","type":"User","site_admin":false},"body":"… so promote them from generic to the global address space. This is dependent on https://github.com/RadeonOpenCompute/llvm/pull/145.","created_at":"2018-05-13T17:38:42Z","updated_at":"2018-05-18T17:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e337425b5f847099aa33246f4e46b143f5f9aae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bensander","id":2494978,"avatar_url":"https://avatars3.githubusercontent.com/u/2494978?v=4","gravatar_id":"","url":"https://api.github.com/users/bensander","html_url":"https://github.com/bensander","followers_url":"https://api.github.com/users/bensander/followers","following_url":"https://api.github.com/users/bensander/following{/other_user}","gists_url":"https://api.github.com/users/bensander/gists{/gist_id}","starred_url":"https://api.github.com/users/bensander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensander/subscriptions","organizations_url":"https://api.github.com/users/bensander/orgs","repos_url":"https://api.github.com/users/bensander/repos","events_url":"https://api.github.com/users/bensander/events{/privacy}","received_events_url":"https://api.github.com/users/bensander/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731/commits","review_comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731/comments","review_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/731/comments","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/0c1b86f185e368b24c5f80b0a75955c642a44fb7","head":{"label":"RadeonOpenCompute:feature_promote_kernarg_pointers_to_global","ref":"feature_promote_kernarg_pointers_to_global","sha":"0c1b86f185e368b24c5f80b0a75955c642a44fb7","user":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars3.githubusercontent.com/u/16900649?v=4","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"repo":{"id":54489277,"name":"hcc","full_name":"RadeonOpenCompute/hcc","owner":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars3.githubusercontent.com/u/16900649?v=4","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RadeonOpenCompute/hcc","description":"HCC is an Open Source, Optimizing C++ Compiler for Heterogeneous Compute currently for the ROCm GPU Computing Platform","fork":false,"url":"https://api.github.com/repos/RadeonOpenCompute/hcc","forks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/forks","keys_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/teams","hooks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/hooks","issue_events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/events{/number}","events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/events","assignees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/assignees{/user}","branches_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/branches{/branch}","tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/tags","blobs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/{sha}","languages_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/languages","stargazers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/stargazers","contributors_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contributors","subscribers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscribers","subscription_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscription","commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contents/{+path}","compare_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/merges","archive_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/downloads","issues_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues{/number}","pulls_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls{/number}","milestones_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/milestones{/number}","notifications_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/labels{/name}","releases_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/releases{/id}","deployments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/deployments","created_at":"2016-03-22T16:04:00Z","updated_at":"2018-05-18T13:22:27Z","pushed_at":"2018-05-18T17:05:33Z","git_url":"git://github.com/RadeonOpenCompute/hcc.git","ssh_url":"git@github.com:RadeonOpenCompute/hcc.git","clone_url":"https://github.com/RadeonOpenCompute/hcc.git","svn_url":"https://github.com/RadeonOpenCompute/hcc","homepage":"https://github.com/RadeonOpenCompute/hcc/wiki","size":21672,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":54,"open_issues":41,"watchers":225,"default_branch":"clang_tot_upgrade"}},"base":{"label":"RadeonOpenCompute:clang_tot_upgrade","ref":"clang_tot_upgrade","sha":"4e2cec53f399fd53a413480a14dfe193ec1374ba","user":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars3.githubusercontent.com/u/16900649?v=4","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"repo":{"id":54489277,"name":"hcc","full_name":"RadeonOpenCompute/hcc","owner":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars3.githubusercontent.com/u/16900649?v=4","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RadeonOpenCompute/hcc","description":"HCC is an Open Source, Optimizing C++ Compiler for Heterogeneous Compute currently for the ROCm GPU Computing Platform","fork":false,"url":"https://api.github.com/repos/RadeonOpenCompute/hcc","forks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/forks","keys_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/teams","hooks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/hooks","issue_events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/events{/number}","events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/events","assignees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/assignees{/user}","branches_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/branches{/branch}","tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/tags","blobs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/{sha}","languages_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/languages","stargazers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/stargazers","contributors_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contributors","subscribers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscribers","subscription_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscription","commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contents/{+path}","compare_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/merges","archive_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/downloads","issues_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues{/number}","pulls_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls{/number}","milestones_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/milestones{/number}","notifications_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/labels{/name}","releases_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/releases{/id}","deployments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/deployments","created_at":"2016-03-22T16:04:00Z","updated_at":"2018-05-18T13:22:27Z","pushed_at":"2018-05-18T17:05:33Z","git_url":"git://github.com/RadeonOpenCompute/hcc.git","ssh_url":"git@github.com:RadeonOpenCompute/hcc.git","clone_url":"https://github.com/RadeonOpenCompute/hcc.git","svn_url":"https://github.com/RadeonOpenCompute/hcc","homepage":"https://github.com/RadeonOpenCompute/hcc/wiki","size":21672,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":54,"open_issues":41,"watchers":225,"default_branch":"clang_tot_upgrade"}},"_links":{"self":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731"},"html":{"href":"https://github.com/RadeonOpenCompute/hcc/pull/731"},"issue":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/731"},"comments":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/731/comments"},"review_comments":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731/comments"},"review_comment":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/731/commits"},"statuses":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/0c1b86f185e368b24c5f80b0a75955c642a44fb7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexVlx"}}