{"action":"created","issue":{"url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/34","repository_url":"https://api.github.com/repos/AgileVentures/project_greeter_bot","labels_url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/34/comments","events_url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/34/events","html_url":"https://github.com/AgileVentures/project_greeter_bot/pull/34","id":388287825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTg3ODg5","number":34,"title":"33 support different environments","user":{"login":"justinemar","id":12657290,"node_id":"MDQ6VXNlcjEyNjU3Mjkw","avatar_url":"https://avatars2.githubusercontent.com/u/12657290?v=4","gravatar_id":"","url":"https://api.github.com/users/justinemar","html_url":"https://github.com/justinemar","followers_url":"https://api.github.com/users/justinemar/followers","following_url":"https://api.github.com/users/justinemar/following{/other_user}","gists_url":"https://api.github.com/users/justinemar/gists{/gist_id}","starred_url":"https://api.github.com/users/justinemar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinemar/subscriptions","organizations_url":"https://api.github.com/users/justinemar/orgs","repos_url":"https://api.github.com/users/justinemar/repos","events_url":"https://api.github.com/users/justinemar/events{/privacy}","received_events_url":"https://api.github.com/users/justinemar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-06T16:18:05Z","updated_at":"2018-12-07T11:07:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/pulls/34","html_url":"https://github.com/AgileVentures/project_greeter_bot/pull/34","diff_url":"https://github.com/AgileVentures/project_greeter_bot/pull/34.diff","patch_url":"https://github.com/AgileVentures/project_greeter_bot/pull/34.patch"},"body":"fixes #33"},"comment":{"url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/comments/445200032","html_url":"https://github.com/AgileVentures/project_greeter_bot/pull/34#issuecomment-445200032","issue_url":"https://api.github.com/repos/AgileVentures/project_greeter_bot/issues/34","id":445200032,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTIwMDAzMg==","user":{"login":"tansaku","id":30216,"node_id":"MDQ6VXNlcjMwMjE2","avatar_url":"https://avatars3.githubusercontent.com/u/30216?v=4","gravatar_id":"","url":"https://api.github.com/users/tansaku","html_url":"https://github.com/tansaku","followers_url":"https://api.github.com/users/tansaku/followers","following_url":"https://api.github.com/users/tansaku/following{/other_user}","gists_url":"https://api.github.com/users/tansaku/gists{/gist_id}","starred_url":"https://api.github.com/users/tansaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tansaku/subscriptions","organizations_url":"https://api.github.com/users/tansaku/orgs","repos_url":"https://api.github.com/users/tansaku/repos","events_url":"https://api.github.com/users/tansaku/events{/privacy}","received_events_url":"https://api.github.com/users/tansaku/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T11:07:46Z","updated_at":"2018-12-07T11:07:46Z","author_association":"MEMBER","body":"great suggestions @Kachulio1 \r\n\r\n@justinemar thanks for updating this - I've pulled out the code locally and tried to run.  I don't think it's working for me - the tests are failing as follows:\r\n\r\n```\r\n→ npm test\r\n\r\n> project_greeter_bot@0.0.0 test /Users/tansaku/Documents/GitHub/AgileVentures/project_greeter_bot\r\n> mocha test/**/*.js\r\n\r\n\r\n\r\n  Project Greeter bot\r\n    1) should have LocalSupport channel greeting\r\n    2) should have WebSiteOne channel greeting\r\n    3) should have Rundfunk Mitbestimmen channel greeting\r\n    4) should have Wiki EDU dashboard channel greeting\r\n    5) should have MetPlus dashboard channel greeting\r\n    6) should have bot dashboard channel greeting\r\n    7) should have asyncvoter dashboard channel greeting\r\n\r\n\r\n  0 passing (12ms)\r\n  7 failing\r\n\r\n  1) Project Greeter bot should have LocalSupport channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C0KK907B5'\r\n      at Context.<anonymous> (test/greetings_spec.js:8:35)\r\n\r\n  2) Project Greeter bot should have WebSiteOne channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C029E8G80'\r\n      at Context.<anonymous> (test/greetings_spec.js:11:35)\r\n\r\n  3) Project Greeter bot should have Rundfunk Mitbestimmen channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C5LCQSJMA'\r\n      at Context.<anonymous> (test/greetings_spec.js:14:35)\r\n\r\n  4) Project Greeter bot should have Wiki EDU dashboard channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C724RCXT7'\r\n      at Context.<anonymous> (test/greetings_spec.js:17:35)\r\n\r\n  5) Project Greeter bot should have MetPlus dashboard channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C0VEPAPJP'\r\n      at Context.<anonymous> (test/greetings_spec.js:20:35)\r\n\r\n  6) Project Greeter bot should have bot dashboard channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C3ETFTYHK'\r\n      at Context.<anonymous> (test/greetings_spec.js:23:35)\r\n\r\n  7) Project Greeter bot should have asyncvoter dashboard channel greeting:\r\n     AssertionError: expected { Object (ls, wso, ...) } to have own property 'C2HGJF54G'\r\n      at Context.<anonymous> (test/greetings_spec.js:26:35)\r\n```\r\n\r\nHave you run the tests locally?\r\n\r\nMy local .env file contains the following:\r\n\r\n```\r\nNODE_ENV=development\r\n```\r\n\r\napologies if I'm not setting up correctly, but if we're making changes that require developers to set up a little differently then we should probably update the documentation in the same PR and possibly add things like a .env.sample or what have you to ensure as easy a setup as possible.\r\n\r\nReally appreciate you working on this, and hope that together we can get it all sorted :-)"}}
{"actor":{"display_login":"tansaku"}}