{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/13721","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/13721/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/13721/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/13721/events","html_url":"https://github.com/xbmc/xbmc/pull/13721","id":310257103,"number":13721,"title":"Std thread","user":{"login":"jimfcarroll","id":372696,"avatar_url":"https://avatars2.githubusercontent.com/u/372696?v=4","gravatar_id":"","url":"https://api.github.com/users/jimfcarroll","html_url":"https://github.com/jimfcarroll","followers_url":"https://api.github.com/users/jimfcarroll/followers","following_url":"https://api.github.com/users/jimfcarroll/following{/other_user}","gists_url":"https://api.github.com/users/jimfcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfcarroll/subscriptions","organizations_url":"https://api.github.com/users/jimfcarroll/orgs","repos_url":"https://api.github.com/users/jimfcarroll/repos","events_url":"https://api.github.com/users/jimfcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/jimfcarroll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-03-31T17:25:33Z","updated_at":"2018-05-14T00:51:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/13721","html_url":"https://github.com/xbmc/xbmc/pull/13721","diff_url":"https://github.com/xbmc/xbmc/pull/13721.diff","patch_url":"https://github.com/xbmc/xbmc/pull/13721.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\nThis change moves the base functionality for CThread to std::thread.\r\n\r\n## Description\r\nThis change moves the base functionality for CThread to std::thread. It introduces a proper Join function and thereby solves an intermittent crash on exit. Please note:\r\n\r\n@FernetMenta , @MrMC  *This change removes the custom programmatic setting of the per-thread stacksize.* That code was originally added as a result of a JSON parsing crash. This PR also fixes that original JSON parsing problem by setting the default parser to be iterative rather than recursive. See the discussion here for more information: https://github.com/MrMC/mrmc/commit/441d1b41a1025ff65f338d765738f8cf72c8c626\r\n\r\n## Motivation and Context\r\nThis is a step toward moving toward implementing an Executor service to be used to replace the Job functionality as well as form the basis for message passing in a more \"actor\" based software design.\r\n\r\n## How Has This Been Tested?\r\nTests were added and all tests still run.\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/388669267","html_url":"https://github.com/xbmc/xbmc/pull/13721#issuecomment-388669267","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/13721","id":388669267,"user":{"login":"jimfcarroll","id":372696,"avatar_url":"https://avatars2.githubusercontent.com/u/372696?v=4","gravatar_id":"","url":"https://api.github.com/users/jimfcarroll","html_url":"https://github.com/jimfcarroll","followers_url":"https://api.github.com/users/jimfcarroll/followers","following_url":"https://api.github.com/users/jimfcarroll/following{/other_user}","gists_url":"https://api.github.com/users/jimfcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfcarroll/subscriptions","organizations_url":"https://api.github.com/users/jimfcarroll/orgs","repos_url":"https://api.github.com/users/jimfcarroll/repos","events_url":"https://api.github.com/users/jimfcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/jimfcarroll/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T00:51:03Z","updated_at":"2018-05-14T00:51:03Z","author_association":"MEMBER","body":"jenkins build this please"}}
{"actor":{"display_login":"jimfcarroll"}}