{"action":"created","comment":{"url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments/221980804","pull_request_review_id":160758919,"id":221980804,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk4MDgwNA==","diff_hunk":"@@ -46,12 +46,12 @@ class OL_BUCKETS\n     C_OUTLINE_LIST *start_scan() {\n       for (index = 0; buckets[index].empty () && index < bxdim * bydim - 1;\n         index++);\n-      return &buckets[index];\n+      return &buckets[index++];  //index value has not changed","path":"src/textord/edgblob.h","position":5,"original_position":5,"commit_id":"c8a822c74b61575a6ec1ac9ae5c5367af65542eb","original_commit_id":"c8a822c74b61575a6ec1ac9ae5c5367af65542eb","user":{"login":"stweil","id":6734573,"node_id":"MDQ6VXNlcjY3MzQ1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6734573?v=4","gravatar_id":"","url":"https://api.github.com/users/stweil","html_url":"https://github.com/stweil","followers_url":"https://api.github.com/users/stweil/followers","following_url":"https://api.github.com/users/stweil/following{/other_user}","gists_url":"https://api.github.com/users/stweil/gists{/gist_id}","starred_url":"https://api.github.com/users/stweil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stweil/subscriptions","organizations_url":"https://api.github.com/users/stweil/orgs","repos_url":"https://api.github.com/users/stweil/repos","events_url":"https://api.github.com/users/stweil/events{/privacy}","received_events_url":"https://api.github.com/users/stweil/received_events","type":"User","site_admin":false},"body":"The old code works because the for loop is left with `buckets[index]` being not empty, but being emptied later before calling the `scan_next` method. That also applies to the results of `scan_next`. See calling code in function `empty_buckets`.\r\n\r\nIncreasing `index` like it is done here would be needed in other contexts (like the test case in the descriptions) and could also improve the performance a little bit, but needs special handling for the corner case where `index` reaches the upper limit.","created_at":"2018-10-02T14:44:53Z","updated_at":"2018-10-02T14:47:50Z","html_url":"https://github.com/tesseract-ocr/tesseract/pull/1921#discussion_r221980804","pull_request_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments/221980804"},"html":{"href":"https://github.com/tesseract-ocr/tesseract/pull/1921#discussion_r221980804"},"pull_request":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921"}}},"pull_request":{"url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921","id":216873746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODczNzQ2","html_url":"https://github.com/tesseract-ocr/tesseract/pull/1921","diff_url":"https://github.com/tesseract-ocr/tesseract/pull/1921.diff","patch_url":"https://github.com/tesseract-ocr/tesseract/pull/1921.patch","issue_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/1921","number":1921,"state":"open","locked":false,"title":"Update edgblob.h","user":{"login":"zhangxz189","id":4726366,"node_id":"MDQ6VXNlcjQ3MjYzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4726366?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxz189","html_url":"https://github.com/zhangxz189","followers_url":"https://api.github.com/users/zhangxz189/followers","following_url":"https://api.github.com/users/zhangxz189/following{/other_user}","gists_url":"https://api.github.com/users/zhangxz189/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxz189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxz189/subscriptions","organizations_url":"https://api.github.com/users/zhangxz189/orgs","repos_url":"https://api.github.com/users/zhangxz189/repos","events_url":"https://api.github.com/users/zhangxz189/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxz189/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-20T07:44:07Z","updated_at":"2018-10-02T14:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49dd58423288bec59eca878d6bf869d801049c46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/1921/comments","statuses_url":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/c8a822c74b61575a6ec1ac9ae5c5367af65542eb","head":{"label":"zhangxz189:master","ref":"master","sha":"c8a822c74b61575a6ec1ac9ae5c5367af65542eb","user":{"login":"zhangxz189","id":4726366,"node_id":"MDQ6VXNlcjQ3MjYzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4726366?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxz189","html_url":"https://github.com/zhangxz189","followers_url":"https://api.github.com/users/zhangxz189/followers","following_url":"https://api.github.com/users/zhangxz189/following{/other_user}","gists_url":"https://api.github.com/users/zhangxz189/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxz189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxz189/subscriptions","organizations_url":"https://api.github.com/users/zhangxz189/orgs","repos_url":"https://api.github.com/users/zhangxz189/repos","events_url":"https://api.github.com/users/zhangxz189/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxz189/received_events","type":"User","site_admin":false},"repo":{"id":149570361,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1NzAzNjE=","name":"tesseract","full_name":"zhangxz189/tesseract","private":false,"owner":{"login":"zhangxz189","id":4726366,"node_id":"MDQ6VXNlcjQ3MjYzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4726366?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxz189","html_url":"https://github.com/zhangxz189","followers_url":"https://api.github.com/users/zhangxz189/followers","following_url":"https://api.github.com/users/zhangxz189/following{/other_user}","gists_url":"https://api.github.com/users/zhangxz189/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxz189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxz189/subscriptions","organizations_url":"https://api.github.com/users/zhangxz189/orgs","repos_url":"https://api.github.com/users/zhangxz189/repos","events_url":"https://api.github.com/users/zhangxz189/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxz189/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhangxz189/tesseract","description":"Tesseract Open Source OCR Engine (main repository)","fork":true,"url":"https://api.github.com/repos/zhangxz189/tesseract","forks_url":"https://api.github.com/repos/zhangxz189/tesseract/forks","keys_url":"https://api.github.com/repos/zhangxz189/tesseract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhangxz189/tesseract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhangxz189/tesseract/teams","hooks_url":"https://api.github.com/repos/zhangxz189/tesseract/hooks","issue_events_url":"https://api.github.com/repos/zhangxz189/tesseract/issues/events{/number}","events_url":"https://api.github.com/repos/zhangxz189/tesseract/events","assignees_url":"https://api.github.com/repos/zhangxz189/tesseract/assignees{/user}","branches_url":"https://api.github.com/repos/zhangxz189/tesseract/branches{/branch}","tags_url":"https://api.github.com/repos/zhangxz189/tesseract/tags","blobs_url":"https://api.github.com/repos/zhangxz189/tesseract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhangxz189/tesseract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhangxz189/tesseract/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhangxz189/tesseract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhangxz189/tesseract/statuses/{sha}","languages_url":"https://api.github.com/repos/zhangxz189/tesseract/languages","stargazers_url":"https://api.github.com/repos/zhangxz189/tesseract/stargazers","contributors_url":"https://api.github.com/repos/zhangxz189/tesseract/contributors","subscribers_url":"https://api.github.com/repos/zhangxz189/tesseract/subscribers","subscription_url":"https://api.github.com/repos/zhangxz189/tesseract/subscription","commits_url":"https://api.github.com/repos/zhangxz189/tesseract/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhangxz189/tesseract/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhangxz189/tesseract/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhangxz189/tesseract/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhangxz189/tesseract/contents/{+path}","compare_url":"https://api.github.com/repos/zhangxz189/tesseract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhangxz189/tesseract/merges","archive_url":"https://api.github.com/repos/zhangxz189/tesseract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhangxz189/tesseract/downloads","issues_url":"https://api.github.com/repos/zhangxz189/tesseract/issues{/number}","pulls_url":"https://api.github.com/repos/zhangxz189/tesseract/pulls{/number}","milestones_url":"https://api.github.com/repos/zhangxz189/tesseract/milestones{/number}","notifications_url":"https://api.github.com/repos/zhangxz189/tesseract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhangxz189/tesseract/labels{/name}","releases_url":"https://api.github.com/repos/zhangxz189/tesseract/releases{/id}","deployments_url":"https://api.github.com/repos/zhangxz189/tesseract/deployments","created_at":"2018-09-20T07:36:36Z","updated_at":"2018-09-20T07:41:48Z","pushed_at":"2018-09-20T07:41:43Z","git_url":"git://github.com/zhangxz189/tesseract.git","ssh_url":"git@github.com:zhangxz189/tesseract.git","clone_url":"https://github.com/zhangxz189/tesseract.git","svn_url":"https://github.com/zhangxz189/tesseract","homepage":"","size":41565,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tesseract-ocr:master","ref":"master","sha":"a2612f2830dd16cf272f629eda13e656a7eee59e","user":{"login":"tesseract-ocr","id":8401422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MDE0MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8401422?v=4","gravatar_id":"","url":"https://api.github.com/users/tesseract-ocr","html_url":"https://github.com/tesseract-ocr","followers_url":"https://api.github.com/users/tesseract-ocr/followers","following_url":"https://api.github.com/users/tesseract-ocr/following{/other_user}","gists_url":"https://api.github.com/users/tesseract-ocr/gists{/gist_id}","starred_url":"https://api.github.com/users/tesseract-ocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesseract-ocr/subscriptions","organizations_url":"https://api.github.com/users/tesseract-ocr/orgs","repos_url":"https://api.github.com/users/tesseract-ocr/repos","events_url":"https://api.github.com/users/tesseract-ocr/events{/privacy}","received_events_url":"https://api.github.com/users/tesseract-ocr/received_events","type":"Organization","site_admin":false},"repo":{"id":22887094,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzA5NA==","name":"tesseract","full_name":"tesseract-ocr/tesseract","private":false,"owner":{"login":"tesseract-ocr","id":8401422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MDE0MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8401422?v=4","gravatar_id":"","url":"https://api.github.com/users/tesseract-ocr","html_url":"https://github.com/tesseract-ocr","followers_url":"https://api.github.com/users/tesseract-ocr/followers","following_url":"https://api.github.com/users/tesseract-ocr/following{/other_user}","gists_url":"https://api.github.com/users/tesseract-ocr/gists{/gist_id}","starred_url":"https://api.github.com/users/tesseract-ocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesseract-ocr/subscriptions","organizations_url":"https://api.github.com/users/tesseract-ocr/orgs","repos_url":"https://api.github.com/users/tesseract-ocr/repos","events_url":"https://api.github.com/users/tesseract-ocr/events{/privacy}","received_events_url":"https://api.github.com/users/tesseract-ocr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tesseract-ocr/tesseract","description":"Tesseract Open Source OCR Engine (main repository)","fork":false,"url":"https://api.github.com/repos/tesseract-ocr/tesseract","forks_url":"https://api.github.com/repos/tesseract-ocr/tesseract/forks","keys_url":"https://api.github.com/repos/tesseract-ocr/tesseract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tesseract-ocr/tesseract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tesseract-ocr/tesseract/teams","hooks_url":"https://api.github.com/repos/tesseract-ocr/tesseract/hooks","issue_events_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/events{/number}","events_url":"https://api.github.com/repos/tesseract-ocr/tesseract/events","assignees_url":"https://api.github.com/repos/tesseract-ocr/tesseract/assignees{/user}","branches_url":"https://api.github.com/repos/tesseract-ocr/tesseract/branches{/branch}","tags_url":"https://api.github.com/repos/tesseract-ocr/tesseract/tags","blobs_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/refs{/sha}","trees_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/{sha}","languages_url":"https://api.github.com/repos/tesseract-ocr/tesseract/languages","stargazers_url":"https://api.github.com/repos/tesseract-ocr/tesseract/stargazers","contributors_url":"https://api.github.com/repos/tesseract-ocr/tesseract/contributors","subscribers_url":"https://api.github.com/repos/tesseract-ocr/tesseract/subscribers","subscription_url":"https://api.github.com/repos/tesseract-ocr/tesseract/subscription","commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/commits{/sha}","git_commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/commits{/sha}","comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/comments{/number}","issue_comment_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/comments{/number}","contents_url":"https://api.github.com/repos/tesseract-ocr/tesseract/contents/{+path}","compare_url":"https://api.github.com/repos/tesseract-ocr/tesseract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tesseract-ocr/tesseract/merges","archive_url":"https://api.github.com/repos/tesseract-ocr/tesseract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tesseract-ocr/tesseract/downloads","issues_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues{/number}","pulls_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls{/number}","milestones_url":"https://api.github.com/repos/tesseract-ocr/tesseract/milestones{/number}","notifications_url":"https://api.github.com/repos/tesseract-ocr/tesseract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tesseract-ocr/tesseract/labels{/name}","releases_url":"https://api.github.com/repos/tesseract-ocr/tesseract/releases{/id}","deployments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/deployments","created_at":"2014-08-12T18:04:59Z","updated_at":"2018-10-02T14:45:07Z","pushed_at":"2018-10-02T10:34:09Z","git_url":"git://github.com/tesseract-ocr/tesseract.git","ssh_url":"git@github.com:tesseract-ocr/tesseract.git","clone_url":"https://github.com/tesseract-ocr/tesseract.git","svn_url":"https://github.com/tesseract-ocr/tesseract","homepage":"","size":41701,"stargazers_count":21428,"watchers_count":21428,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4264,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4264,"open_issues":210,"watchers":21428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921"},"html":{"href":"https://github.com/tesseract-ocr/tesseract/pull/1921"},"issue":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/1921"},"comments":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/c8a822c74b61575a6ec1ac9ae5c5367af65542eb"}},"author_association":"NONE"}}
{"actor":{"display_login":"stweil"}}