{"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/223720851","pull_request_review_id":162915491,"id":223720851,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzcyMDg1MQ==","diff_hunk":"@@ -32,7 +32,6 @@ GVAR(ladder) animate [\"rotate\", 0];\n \n {\n     GVAR(ladder) animate [_x, 0];\n-    true","path":"addons/tacticalladder/functions/fnc_cancelTLdeploy.sqf","position":4,"original_position":4,"commit_id":"c61d4f5ab188d6dee60065af63c3644ff06e91ad","original_commit_id":"c61d4f5ab188d6dee60065af63c3644ff06e91ad","user":{"login":"dedmen","id":3768165,"node_id":"MDQ6VXNlcjM3NjgxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"body":"`performance of this code does not matter` it's executed every time the player makes a right-click. :U \r\nBut if postInit runs properly. It will exit at the isNull check at the start of the file.. So maybe not thaat bad. But the problem of the unused eventhandlers always being added still stands.","created_at":"2018-10-09T14:19:26Z","updated_at":"2018-10-09T14:19:26Z","html_url":"https://github.com/acemod/ACE3/pull/6607#discussion_r223720851","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/6607","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/223720851"},"html":{"href":"https://github.com/acemod/ACE3/pull/6607#discussion_r223720851"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6607"}},"in_reply_to_id":223244777},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/6607","id":219435685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDM1Njg1","html_url":"https://github.com/acemod/ACE3/pull/6607","diff_url":"https://github.com/acemod/ACE3/pull/6607.diff","patch_url":"https://github.com/acemod/ACE3/pull/6607.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/6607","number":6607,"state":"open","locked":false,"title":"Some Refactoring","user":{"login":"dedmen","id":3768165,"node_id":"MDQ6VXNlcjM3NjgxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"body":"`findIf` instead of `forEach` loop.\r\n`select` instead of `forEach` with `pushBack`\r\nLazy eval and reordering conditions by performance impact\r\nmore params","created_at":"2018-10-01T16:21:09Z","updated_at":"2018-10-09T14:19:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"800dda034497962728727d8f9a92ab1c9dd3bd14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":164932009,"node_id":"MDU6TGFiZWwxNjQ5MzIwMDk=","url":"https://api.github.com/repos/acemod/ACE3/labels/kind/enhancement","name":"kind/enhancement","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/35","html_url":"https://github.com/acemod/ACE3/milestone/35","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/35/labels","id":2862352,"node_id":"MDk6TWlsZXN0b25lMjg2MjM1Mg==","number":35,"title":"3.13.0","description":"","creator":{"login":"jonpas","id":7935003,"node_id":"MDQ6VXNlcjc5MzUwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7935003?v=4","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":50,"state":"open","created_at":"2017-10-24T13:45:06Z","updated_at":"2018-10-09T01:49:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/6607/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/6607/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/6607/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/c61d4f5ab188d6dee60065af63c3644ff06e91ad","head":{"label":"dedmen:MiscRefactoring","ref":"MiscRefactoring","sha":"c61d4f5ab188d6dee60065af63c3644ff06e91ad","user":{"login":"dedmen","id":3768165,"node_id":"MDQ6VXNlcjM3NjgxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"repo":{"id":79257394,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI1NzM5NA==","name":"ACE3","full_name":"dedmen/ACE3","private":false,"owner":{"login":"dedmen","id":3768165,"node_id":"MDQ6VXNlcjM3NjgxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dedmen/ACE3","description":"Open-source realism mod for Arma 3","fork":true,"url":"https://api.github.com/repos/dedmen/ACE3","forks_url":"https://api.github.com/repos/dedmen/ACE3/forks","keys_url":"https://api.github.com/repos/dedmen/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedmen/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedmen/ACE3/teams","hooks_url":"https://api.github.com/repos/dedmen/ACE3/hooks","issue_events_url":"https://api.github.com/repos/dedmen/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/dedmen/ACE3/events","assignees_url":"https://api.github.com/repos/dedmen/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/dedmen/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/dedmen/ACE3/tags","blobs_url":"https://api.github.com/repos/dedmen/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedmen/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedmen/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedmen/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedmen/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/dedmen/ACE3/languages","stargazers_url":"https://api.github.com/repos/dedmen/ACE3/stargazers","contributors_url":"https://api.github.com/repos/dedmen/ACE3/contributors","subscribers_url":"https://api.github.com/repos/dedmen/ACE3/subscribers","subscription_url":"https://api.github.com/repos/dedmen/ACE3/subscription","commits_url":"https://api.github.com/repos/dedmen/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedmen/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedmen/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedmen/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedmen/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/dedmen/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedmen/ACE3/merges","archive_url":"https://api.github.com/repos/dedmen/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedmen/ACE3/downloads","issues_url":"https://api.github.com/repos/dedmen/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/dedmen/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/dedmen/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/dedmen/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedmen/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/dedmen/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/dedmen/ACE3/deployments","created_at":"2017-01-17T18:20:52Z","updated_at":"2017-01-17T18:21:02Z","pushed_at":"2018-10-02T07:28:29Z","git_url":"git://github.com/dedmen/ACE3.git","ssh_url":"git@github.com:dedmen/ACE3.git","clone_url":"https://github.com/dedmen/ACE3.git","svn_url":"https://github.com/dedmen/ACE3","homepage":"http://ace3mod.com/","size":359557,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"43c52585852205afdd4a61bf61d0c1ba9a2d2b63","user":{"login":"acemod","id":11369030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY5MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/11369030?v=4","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA2OTE3NA==","name":"ACE3","full_name":"acemod/ACE3","private":false,"owner":{"login":"acemod","id":11369030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY5MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/11369030?v=4","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/acemod/ACE3/deployments","created_at":"2015-01-10T19:59:12Z","updated_at":"2018-10-09T01:49:53Z","pushed_at":"2018-10-09T05:26:09Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"https://ace3mod.com/","size":380188,"stargazers_count":620,"watchers_count":620,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":501,"mirror_url":null,"archived":false,"open_issues_count":395,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":501,"open_issues":395,"watchers":620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6607"},"html":{"href":"https://github.com/acemod/ACE3/pull/6607"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/6607"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/6607/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6607/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/6607/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/c61d4f5ab188d6dee60065af63c3644ff06e91ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dedmen"}}