{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/17629","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/17629/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/17629/comments","events_url":"https://api.github.com/repos/angular/angular/issues/17629/events","html_url":"https://github.com/angular/angular/pull/17629","id":237165416,"number":17629,"title":"fix(common): limiting size of memory leak in async pipe","user":{"login":"czterocyty","id":9469693,"avatar_url":"https://avatars3.githubusercontent.com/u/9469693?v=4","gravatar_id":"","url":"https://api.github.com/users/czterocyty","html_url":"https://github.com/czterocyty","followers_url":"https://api.github.com/users/czterocyty/followers","following_url":"https://api.github.com/users/czterocyty/following{/other_user}","gists_url":"https://api.github.com/users/czterocyty/gists{/gist_id}","starred_url":"https://api.github.com/users/czterocyty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czterocyty/subscriptions","organizations_url":"https://api.github.com/users/czterocyty/orgs","repos_url":"https://api.github.com/users/czterocyty/repos","events_url":"https://api.github.com/users/czterocyty/events{/privacy}","received_events_url":"https://api.github.com/users/czterocyty/received_events","type":"User","site_admin":false},"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":217986512,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20common","name":"comp: common","color":"c7def8","default":false},{"id":375498062,"url":"https://api.github.com/repos/angular/angular/labels/severity4:%20memleak","name":"severity4: memleak","color":"0052cc","default":false},{"id":130606843,"url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-20T10:37:19Z","updated_at":"2018-03-16T17:56:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/17629","html_url":"https://github.com/angular/angular/pull/17629","diff_url":"https://github.com/angular/angular/pull/17629.diff","patch_url":"https://github.com/angular/angular/pull/17629.patch"},"body":"Interim fix to limit size of the memory leak in async pipe due to #17624\r\n\r\n## PR Checklist\r\nDoes please check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: #17624 \r\n\r\nReference to `ChangeDetectorRef` is not freed on `ngOnDestroy` leading to bigger memory leak (eg. there might be still detached DOM nodes in ViewRef that cannot be garbage collected).\r\n\r\n## What is the new behavior?\r\n\r\nThis is interim fix. Still waiting for final fix in ReactiveX/rxjs#2675\r\nOn disposing of async pipe, the reference to `ChangeDetectorRef` is cleared, so garbage collector can free more memory.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/373795348","html_url":"https://github.com/angular/angular/pull/17629#issuecomment-373795348","issue_url":"https://api.github.com/repos/angular/angular/issues/17629","id":373795348,"user":{"login":"splincode","id":12021443,"avatar_url":"https://avatars3.githubusercontent.com/u/12021443?v=4","gravatar_id":"","url":"https://api.github.com/users/splincode","html_url":"https://github.com/splincode","followers_url":"https://api.github.com/users/splincode/followers","following_url":"https://api.github.com/users/splincode/following{/other_user}","gists_url":"https://api.github.com/users/splincode/gists{/gist_id}","starred_url":"https://api.github.com/users/splincode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splincode/subscriptions","organizations_url":"https://api.github.com/users/splincode/orgs","repos_url":"https://api.github.com/users/splincode/repos","events_url":"https://api.github.com/users/splincode/events{/privacy}","received_events_url":"https://api.github.com/users/splincode/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T17:56:47Z","updated_at":"2018-03-16T17:56:47Z","author_association":"CONTRIBUTOR","body":"@czterocyty what is the status of your pull request? is it still relevant?"}}
{"actor":{"display_login":"splincode"}}