{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/5385","repository_url":"https://api.github.com/repos/material-components/material-components-ios","labels_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5385/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5385/comments","events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5385/events","html_url":"https://github.com/material-components/material-components-ios/pull/5385","id":368704041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODE5NTkz","number":5385,"title":"[FlexibleHeader] Allow clearing shadow when trackingScrollView is emptied","user":{"login":"AlimoRabbani","id":2232489,"node_id":"MDQ6VXNlcjIyMzI0ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/2232489?v=4","gravatar_id":"","url":"https://api.github.com/users/AlimoRabbani","html_url":"https://github.com/AlimoRabbani","followers_url":"https://api.github.com/users/AlimoRabbani/followers","following_url":"https://api.github.com/users/AlimoRabbani/following{/other_user}","gists_url":"https://api.github.com/users/AlimoRabbani/gists{/gist_id}","starred_url":"https://api.github.com/users/AlimoRabbani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlimoRabbani/subscriptions","organizations_url":"https://api.github.com/users/AlimoRabbani/orgs","repos_url":"https://api.github.com/users/AlimoRabbani/repos","events_url":"https://api.github.com/users/AlimoRabbani/events{/privacy}","received_events_url":"https://api.github.com/users/AlimoRabbani/received_events","type":"User","site_admin":false},"labels":[{"id":328243523,"node_id":"MDU6TGFiZWwzMjgyNDM1MjM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[FlexibleHeader]","name":"[FlexibleHeader]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-10T14:48:41Z","updated_at":"2018-10-10T15:52:52Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5385","html_url":"https://github.com/material-components/material-components-ios/pull/5385","diff_url":"https://github.com/material-components/material-components-ios/pull/5385.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/5385.patch"},"body":"Expose a property that enables resetting the visible shadow opacity to 0 when setting trackingScrollView to 0.\r\n\r\nresetShadowAfterTrackingScrollViewIsReset is now exposed. When it's set to YES by clients, we clear the shadow when trackingScrollView is set to Nil. I am planning to adopt the flag internally where applicable, and change the default value to YES and mark as deprecated after that. \r\n\r\nPartially addresses #5281, but will need to keep it open until the default value has changed.\r\n\r\nInternal testing of this PR is being done in cl/215723028."},"comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments/428627189","html_url":"https://github.com/material-components/material-components-ios/pull/5385#issuecomment-428627189","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5385","id":428627189,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODYyNzE4OQ==","user":{"login":"jverkoey","id":45670,"node_id":"MDQ6VXNlcjQ1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T15:52:52Z","updated_at":"2018-10-10T15:52:52Z","author_association":"MEMBER","body":"I may recommend making this flag super robotic in terms of its application. Essentially: leave any existing code paths as-is but gated by the flag. Any new code should be gated by this flag as well. Avoiding refactoring any code paths in this change will help us shepherd this new behavior in more safely, and once we delete the flag we can then also delete the old code paths."}}
{"actor":{"display_login":"jverkoey"}}