{"action":"closed","number":12381,"pull_request":{"url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381","id":207360590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzYwNTkw","html_url":"https://github.com/web-platform-tests/wpt/pull/12381","diff_url":"https://github.com/web-platform-tests/wpt/pull/12381.diff","patch_url":"https://github.com/web-platform-tests/wpt/pull/12381.patch","issue_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12381","number":12381,"state":"closed","locked":false,"title":"Fix service worker tests generated from non-https .any.js","user":{"login":"jgraham","id":294864,"node_id":"MDQ6VXNlcjI5NDg2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/294864?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraham","html_url":"https://github.com/jgraham","followers_url":"https://api.github.com/users/jgraham/followers","following_url":"https://api.github.com/users/jgraham/following{/other_user}","gists_url":"https://api.github.com/users/jgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraham/subscriptions","organizations_url":"https://api.github.com/users/jgraham/orgs","repos_url":"https://api.github.com/users/jgraham/repos","events_url":"https://api.github.com/users/jgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jgraham/received_events","type":"User","site_admin":false},"body":"Note: this contains a change to the expected behaviour of test\r\nrunners.\r\n\r\nPreviously .any.js tests specifying a serviceworker variant generated\r\na url like foo.https.any.serviceworker.html. But that causes a problem\r\nbecause that looks exctly like a url generated from a file named\r\nfoo.https.js. This ambiguity, together with the fact that wptrunner\r\nwasn't actually looking at the https flag in the test id, but only in\r\nthe filename, meant that service worker tests weren't being run\r\nproperly.\r\n\r\nThis change stops adding .https. to serviceworker tests generated from\r\n.any.js files and instead makes .serviceworker. in the test id\r\ndirectly mean that the test should be loaded over https.","created_at":"2018-08-09T15:42:42Z","updated_at":"2018-08-10T20:31:05Z","closed_at":"2018-08-10T20:31:05Z","merged_at":"2018-08-10T20:31:05Z","merge_commit_sha":"bfec5399443c15c7a201a3d2b5505967433f570c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jugglinmike","id":677252,"node_id":"MDQ6VXNlcjY3NzI1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/677252?v=4","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},{"login":"kereliuk","id":9435736,"node_id":"MDQ6VXNlcjk0MzU3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9435736?v=4","gravatar_id":"","url":"https://api.github.com/users/kereliuk","html_url":"https://github.com/kereliuk","followers_url":"https://api.github.com/users/kereliuk/followers","following_url":"https://api.github.com/users/kereliuk/following{/other_user}","gists_url":"https://api.github.com/users/kereliuk/gists{/gist_id}","starred_url":"https://api.github.com/users/kereliuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kereliuk/subscriptions","organizations_url":"https://api.github.com/users/kereliuk/orgs","repos_url":"https://api.github.com/users/kereliuk/repos","events_url":"https://api.github.com/users/kereliuk/events{/privacy}","received_events_url":"https://api.github.com/users/kereliuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45230790,"node_id":"MDU6TGFiZWw0NTIzMDc5MA==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/infra","name":"infra","color":"fbca04","default":false},{"id":169297394,"node_id":"MDU6TGFiZWwxNjkyOTczOTQ=","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/manifest","name":"manifest","color":"fef2c0","default":false},{"id":1009218070,"node_id":"MDU6TGFiZWwxMDA5MjE4MDcw","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/serve","name":"serve","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381/commits","review_comments_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381/comments","review_comment_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12381/comments","statuses_url":"https://api.github.com/repos/web-platform-tests/wpt/statuses/7c3c1cdf4682007069e2aeda0c1166caef8d9827","head":{"label":"web-platform-tests:serviceworker_https","ref":"serviceworker_https","sha":"7c3c1cdf4682007069e2aeda0c1166caef8d9827","user":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"node_id":"MDEwOlJlcG9zaXRvcnkzNjE4MTMz","name":"wpt","full_name":"web-platform-tests/wpt","owner":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/web-platform-tests/wpt","description":"Test suites for Web platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/web-platform-tests/wpt","forks_url":"https://api.github.com/repos/web-platform-tests/wpt/forks","keys_url":"https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web-platform-tests/wpt/teams","hooks_url":"https://api.github.com/repos/web-platform-tests/wpt/hooks","issue_events_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}","events_url":"https://api.github.com/repos/web-platform-tests/wpt/events","assignees_url":"https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}","branches_url":"https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}","tags_url":"https://api.github.com/repos/web-platform-tests/wpt/tags","blobs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}","trees_url":"https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}","languages_url":"https://api.github.com/repos/web-platform-tests/wpt/languages","stargazers_url":"https://api.github.com/repos/web-platform-tests/wpt/stargazers","contributors_url":"https://api.github.com/repos/web-platform-tests/wpt/contributors","subscribers_url":"https://api.github.com/repos/web-platform-tests/wpt/subscribers","subscription_url":"https://api.github.com/repos/web-platform-tests/wpt/subscription","commits_url":"https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}","git_commits_url":"https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/comments{/number}","issue_comment_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}","contents_url":"https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}","compare_url":"https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web-platform-tests/wpt/merges","archive_url":"https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web-platform-tests/wpt/downloads","issues_url":"https://api.github.com/repos/web-platform-tests/wpt/issues{/number}","pulls_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}","milestones_url":"https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}","notifications_url":"https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web-platform-tests/wpt/labels{/name}","releases_url":"https://api.github.com/repos/web-platform-tests/wpt/releases{/id}","deployments_url":"https://api.github.com/repos/web-platform-tests/wpt/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-08-10T19:06:40Z","pushed_at":"2018-08-10T20:31:05Z","git_url":"git://github.com/web-platform-tests/wpt.git","ssh_url":"git@github.com:web-platform-tests/wpt.git","clone_url":"https://github.com/web-platform-tests/wpt.git","svn_url":"https://github.com/web-platform-tests/wpt","homepage":"http://irc.w3.org/?channels=testing","size":301513,"stargazers_count":1731,"watchers_count":1731,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1467,"mirror_url":null,"archived":false,"open_issues_count":1248,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1467,"open_issues":1248,"watchers":1731,"default_branch":"master"}},"base":{"label":"web-platform-tests:master","ref":"master","sha":"848ceffad26e92d47ffe790ed8b650906b2c2343","user":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"node_id":"MDEwOlJlcG9zaXRvcnkzNjE4MTMz","name":"wpt","full_name":"web-platform-tests/wpt","owner":{"login":"web-platform-tests","id":37226233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/37226233?v=4","gravatar_id":"","url":"https://api.github.com/users/web-platform-tests","html_url":"https://github.com/web-platform-tests","followers_url":"https://api.github.com/users/web-platform-tests/followers","following_url":"https://api.github.com/users/web-platform-tests/following{/other_user}","gists_url":"https://api.github.com/users/web-platform-tests/gists{/gist_id}","starred_url":"https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-platform-tests/subscriptions","organizations_url":"https://api.github.com/users/web-platform-tests/orgs","repos_url":"https://api.github.com/users/web-platform-tests/repos","events_url":"https://api.github.com/users/web-platform-tests/events{/privacy}","received_events_url":"https://api.github.com/users/web-platform-tests/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/web-platform-tests/wpt","description":"Test suites for Web platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/web-platform-tests/wpt","forks_url":"https://api.github.com/repos/web-platform-tests/wpt/forks","keys_url":"https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web-platform-tests/wpt/teams","hooks_url":"https://api.github.com/repos/web-platform-tests/wpt/hooks","issue_events_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}","events_url":"https://api.github.com/repos/web-platform-tests/wpt/events","assignees_url":"https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}","branches_url":"https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}","tags_url":"https://api.github.com/repos/web-platform-tests/wpt/tags","blobs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}","trees_url":"https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}","languages_url":"https://api.github.com/repos/web-platform-tests/wpt/languages","stargazers_url":"https://api.github.com/repos/web-platform-tests/wpt/stargazers","contributors_url":"https://api.github.com/repos/web-platform-tests/wpt/contributors","subscribers_url":"https://api.github.com/repos/web-platform-tests/wpt/subscribers","subscription_url":"https://api.github.com/repos/web-platform-tests/wpt/subscription","commits_url":"https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}","git_commits_url":"https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/comments{/number}","issue_comment_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}","contents_url":"https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}","compare_url":"https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web-platform-tests/wpt/merges","archive_url":"https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web-platform-tests/wpt/downloads","issues_url":"https://api.github.com/repos/web-platform-tests/wpt/issues{/number}","pulls_url":"https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}","milestones_url":"https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}","notifications_url":"https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web-platform-tests/wpt/labels{/name}","releases_url":"https://api.github.com/repos/web-platform-tests/wpt/releases{/id}","deployments_url":"https://api.github.com/repos/web-platform-tests/wpt/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-08-10T19:06:40Z","pushed_at":"2018-08-10T20:31:05Z","git_url":"git://github.com/web-platform-tests/wpt.git","ssh_url":"git@github.com:web-platform-tests/wpt.git","clone_url":"https://github.com/web-platform-tests/wpt.git","svn_url":"https://github.com/web-platform-tests/wpt","homepage":"http://irc.w3.org/?channels=testing","size":301513,"stargazers_count":1731,"watchers_count":1731,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1467,"mirror_url":null,"archived":false,"open_issues_count":1248,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1467,"open_issues":1248,"watchers":1731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381"},"html":{"href":"https://github.com/web-platform-tests/wpt/pull/12381"},"issue":{"href":"https://api.github.com/repos/web-platform-tests/wpt/issues/12381"},"comments":{"href":"https://api.github.com/repos/web-platform-tests/wpt/issues/12381/comments"},"review_comments":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381/comments"},"review_comment":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12381/commits"},"statuses":{"href":"https://api.github.com/repos/web-platform-tests/wpt/statuses/7c3c1cdf4682007069e2aeda0c1166caef8d9827"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jgraham","id":294864,"node_id":"MDQ6VXNlcjI5NDg2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/294864?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraham","html_url":"https://github.com/jgraham","followers_url":"https://api.github.com/users/jgraham/followers","following_url":"https://api.github.com/users/jgraham/following{/other_user}","gists_url":"https://api.github.com/users/jgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraham/subscriptions","organizations_url":"https://api.github.com/users/jgraham/orgs","repos_url":"https://api.github.com/users/jgraham/repos","events_url":"https://api.github.com/users/jgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jgraham/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":54,"deletions":9,"changed_files":7}}
{"actor":{"display_login":"jgraham"}}