{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments/199090355","pull_request_review_id":133133680,"id":199090355,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA5MDM1NQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+<?php\n+\n+/**\n+ * @file\n+ * Main view template.\n+ *\n+ * Variables available:\n+ * - $classes_array: An array of classes determined in\n+ *   template_preprocess_views_view(). Default classes are:\n+ *     .view\n+ *     .view-[css_name]\n+ *     .view-id-[view_name]\n+ *     .view-display-id-[display_name]\n+ *     .view-dom-id-[dom_id]\n+ * - $classes: A string version of $classes_array for use in the class attribute\n+ * - $css_name: A css-safe version of the view name.\n+ * - $css_class: The user-specified classes names, if any\n+ * - $header: The view header\n+ * - $footer: The view footer\n+ * - $rows: The results of the view query, if any\n+ * - $empty: The empty text to display if the view is empty\n+ * - $pager: The pager next/prev links to display, if any\n+ * - $exposed: Exposed widget form/info to display\n+ * - $feed_icon: Feed icon to display, if any\n+ * - $more: A link to view more, if any\n+ *\n+ * @ingroup views_templates\n+ */\n+  // removes view class to avoid generic view style to interfere with styling\n+  $classes = str_replace('view ','', $classes);\n+?>\n+\n+<div class=\"panel-panel <?php print $classes; ?>\">\n+  <div class=\"panel-panel-inner\">\n+    <div class=\"panel-pane pane-block\">\n+\n+      <?php if ($title): ?>\n+        <h2 class=\"pane-title\">\n+          <?php print $title; ?>\n+        </h2>\n+      <?php endif; ?>\n+\n+      <div class=\"pane-content\">\n+\n+        <?php if ($rows): ?>\n+          <div class=\"view-content\">\n+            <?php print $rows; ?>\n+          </div>\n+        <?php elseif ($empty): ?>\n+          <div class=\"view-empty\">\n+            <?php print $empty; ?>\n+          </div>\n+        <?php endif; ?>\n+\n+        <?php if ($footer): ?>\n+          <div class=\"chr_panel__footer\">\n+            <div class=\"chr_actions-wrapper\">\n+              <?php print $footer; ?>\n+            </div>\n+          </div>\n+        <?php endif; ?>\n+\n+      </div> <!-- end: pane-content -->\n+    </div> <!-- end: panel-pane -->\n+  </div> <!-- end: panel-panel-inner -->\n+</div>  <!-- end: panel-panel -->","path":"civihr_employee_portal/views/templates/_views-view--generic-display-output.tpl.php","position":66,"original_position":66,"commit_id":"d14dcda9eeb5e89b2de99bcc2c153c0c7766053f","original_commit_id":"d14dcda9eeb5e89b2de99bcc2c153c0c7766053f","user":{"login":"AkA84","id":6400898,"node_id":"MDQ6VXNlcjY0MDA4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6400898?v=4","gravatar_id":"","url":"https://api.github.com/users/AkA84","html_url":"https://github.com/AkA84","followers_url":"https://api.github.com/users/AkA84/followers","following_url":"https://api.github.com/users/AkA84/following{/other_user}","gists_url":"https://api.github.com/users/AkA84/gists{/gist_id}","starred_url":"https://api.github.com/users/AkA84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkA84/subscriptions","organizations_url":"https://api.github.com/users/AkA84/orgs","repos_url":"https://api.github.com/users/AkA84/repos","events_url":"https://api.github.com/users/AkA84/events{/privacy}","received_events_url":"https://api.github.com/users/AkA84/received_events","type":"User","site_admin":false},"body":"please set up your IDE to automatically leave an empty line when saving a file","created_at":"2018-06-29T08:32:42Z","updated_at":"2018-06-29T08:38:28Z","html_url":"https://github.com/compucorp/civihr-employee-portal/pull/504#discussion_r199090355","pull_request_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments/199090355"},"html":{"href":"https://github.com/compucorp/civihr-employee-portal/pull/504#discussion_r199090355"},"pull_request":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504","id":198029275,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDI5Mjc1","html_url":"https://github.com/compucorp/civihr-employee-portal/pull/504","diff_url":"https://github.com/compucorp/civihr-employee-portal/pull/504.diff","patch_url":"https://github.com/compucorp/civihr-employee-portal/pull/504.patch","issue_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504","number":504,"state":"open","locked":false,"title":"PCHR-3817: create views for my details page","user":{"login":"powdevel","id":3916979,"node_id":"MDQ6VXNlcjM5MTY5Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3916979?v=4","gravatar_id":"","url":"https://api.github.com/users/powdevel","html_url":"https://github.com/powdevel","followers_url":"https://api.github.com/users/powdevel/followers","following_url":"https://api.github.com/users/powdevel/following{/other_user}","gists_url":"https://api.github.com/users/powdevel/gists{/gist_id}","starred_url":"https://api.github.com/users/powdevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powdevel/subscriptions","organizations_url":"https://api.github.com/users/powdevel/orgs","repos_url":"https://api.github.com/users/powdevel/repos","events_url":"https://api.github.com/users/powdevel/events{/privacy}","received_events_url":"https://api.github.com/users/powdevel/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n- Defines views to use in My Details page\r\n- Creates a panel page for My Details page\r\n- Creates a new input filter to output HTML without any filter, mainly for view headers and footers.\r\n\r\nNOTE: To get the previews a branch with the same name in the themes repo must also be active\r\n\r\n## Before\r\n![image](https://user-images.githubusercontent.com/3916979/42036829-52a39568-7aac-11e8-90c1-d94f21c4862b.png)\r\n\r\n## After\r\n![fireshot capture 119 - my details i civi8 - http___civi8_hr-details](https://user-images.githubusercontent.com/3916979/42036868-69233366-7aac-11e8-98f0-886c19490c8f.png)\r\n![fireshot capture 118 - my details i civi8 - http___civi8_hr-details](https://user-images.githubusercontent.com/3916979/42036869-6940e60e-7aac-11e8-80de-67e00c8a87b5.png)\r\n\r\n\r\n## Technical Details\r\nSome work was done to unify HTML structures from panels and views, to integrate them seamlessly with the design. A new generic template is invoked from views-view--default.tpl.php for specific views in My Details page. The goal was to \"hide\" views markup, although technically the panel block markup was set to not output any HTML and the view template _views-view--generic-display-output.tpl.php will mimic a panels block structure.\r\n\"My Details\" page is now a panel page, which would become the preferred structure for pages over custom templates, view pages or any other implementation.","created_at":"2018-06-28T13:25:14Z","updated_at":"2018-06-29T08:38:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d1e0a48600e3250db8a7f8bc4dbeec4abaa6365","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/commits","review_comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/comments","review_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504/comments","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/d14dcda9eeb5e89b2de99bcc2c153c0c7766053f","head":{"label":"compucorp:PCHR-3817-create-views-for-my-details-page","ref":"PCHR-3817-create-views-for-my-details-page","sha":"d14dcda9eeb5e89b2de99bcc2c153c0c7766053f","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":25817866,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgxNzg2Ng==","name":"civihr-employee-portal","full_name":"compucorp/civihr-employee-portal","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-employee-portal","description":"CiviHR employee portal custom Drupal modules","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-employee-portal","forks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/deployments","created_at":"2014-10-27T12:26:29Z","updated_at":"2018-06-21T14:10:27Z","pushed_at":"2018-06-29T07:35:29Z","git_url":"git://github.com/compucorp/civihr-employee-portal.git","ssh_url":"git@github.com:compucorp/civihr-employee-portal.git","clone_url":"https://github.com/compucorp/civihr-employee-portal.git","svn_url":"https://github.com/compucorp/civihr-employee-portal","homepage":null,"size":6215,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4,"open_issues":5,"watchers":5,"default_branch":"staging"}},"base":{"label":"compucorp:PCHR-3667-changes-for-my-details-and-edit-my-details","ref":"PCHR-3667-changes-for-my-details-and-edit-my-details","sha":"09c6d87a697c9549bd13402b869538428f6de93f","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":25817866,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgxNzg2Ng==","name":"civihr-employee-portal","full_name":"compucorp/civihr-employee-portal","owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-employee-portal","description":"CiviHR employee portal custom Drupal modules","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-employee-portal","forks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-employee-portal/deployments","created_at":"2014-10-27T12:26:29Z","updated_at":"2018-06-21T14:10:27Z","pushed_at":"2018-06-29T07:35:29Z","git_url":"git://github.com/compucorp/civihr-employee-portal.git","ssh_url":"git@github.com:compucorp/civihr-employee-portal.git","clone_url":"https://github.com/compucorp/civihr-employee-portal.git","svn_url":"https://github.com/compucorp/civihr-employee-portal","homepage":null,"size":6215,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4,"open_issues":5,"watchers":5,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504"},"html":{"href":"https://github.com/compucorp/civihr-employee-portal/pull/504"},"issue":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504"},"comments":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/civihr-employee-portal/statuses/d14dcda9eeb5e89b2de99bcc2c153c0c7766053f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AkA84"}}