{"action":"created","comment":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments/204565757","pull_request_review_id":139665507,"id":204565757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU2NTc1Nw==","diff_hunk":"@@ -88,21 +89,10 @@ func TestMemcached(t *testing.T) {\n \t}\n \n \tnamespace := \"memcached\"\n-\tkubeconfigPath := filepath.Join(\n-\t\tos.Getenv(\"HOME\"), \".kube\", \"config\",\n-\t)\n-\tkubeconfig, err := clientcmd.BuildConfigFromFlags(\"\", kubeconfigPath)\n-\tif err != nil {\n-\t\tt.Fatal(err)\n-\t}\n-\tkubeclient, err := kubernetes.NewForConfig(kubeconfig)\n-\tif err != nil {\n-\t\tt.Fatal(err)\n-\t}\n \n \t// create namespace","path":"test/e2e/memcached_test.go","position":44,"original_position":44,"commit_id":"d59c1e9760c91d63305e9d12cdd4c2384b94b4e2","original_commit_id":"d59c1e9760c91d63305e9d12cdd4c2384b94b4e2","user":{"login":"fanminshi","id":4983345,"node_id":"MDQ6VXNlcjQ5ODMzNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4983345?v=4","gravatar_id":"","url":"https://api.github.com/users/fanminshi","html_url":"https://github.com/fanminshi","followers_url":"https://api.github.com/users/fanminshi/followers","following_url":"https://api.github.com/users/fanminshi/following{/other_user}","gists_url":"https://api.github.com/users/fanminshi/gists{/gist_id}","starred_url":"https://api.github.com/users/fanminshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanminshi/subscriptions","organizations_url":"https://api.github.com/users/fanminshi/orgs","repos_url":"https://api.github.com/users/fanminshi/repos","events_url":"https://api.github.com/users/fanminshi/events{/privacy}","received_events_url":"https://api.github.com/users/fanminshi/received_events","type":"User","site_admin":false},"body":"make the variables close to its usage.\r\ne.g:\r\n\r\n```go\r\nf := framework.Global\r\nnamespace := \"memcached\" \r\n// create namespace ...\r\n```","created_at":"2018-07-23T21:52:50Z","updated_at":"2018-07-23T21:53:14Z","html_url":"https://github.com/operator-framework/operator-sdk/pull/359#discussion_r204565757","pull_request_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments/204565757"},"html":{"href":"https://github.com/operator-framework/operator-sdk/pull/359#discussion_r204565757"},"pull_request":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359","id":203340504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzQwNTA0","html_url":"https://github.com/operator-framework/operator-sdk/pull/359","diff_url":"https://github.com/operator-framework/operator-sdk/pull/359.diff","patch_url":"https://github.com/operator-framework/operator-sdk/pull/359.patch","issue_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/359","number":359,"state":"open","locked":false,"title":"test/e2e: add framework for e2e tests","user":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"body":"This will allow us to add more tests in the future without\r\nduplicating code and will also allow us to parse command line options\r\nmore easily.\r\n\r\nThis is one of the parts of PR #355 that is being split off for easier review.","created_at":"2018-07-23T20:53:36Z","updated_at":"2018-07-23T21:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42c8d31edb23b67e9146590fc2b7dc57f1a98a26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359/commits","review_comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359/comments","review_comment_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/359/comments","statuses_url":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/d59c1e9760c91d63305e9d12cdd4c2384b94b4e2","head":{"label":"AlexNPavel:e2e-framework","ref":"e2e-framework","sha":"d59c1e9760c91d63305e9d12cdd4c2384b94b4e2","user":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"repo":{"id":140767708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3Njc3MDg=","name":"operator-sdk","full_name":"AlexNPavel/operator-sdk","owner":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexNPavel/operator-sdk","description":"SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.","fork":true,"url":"https://api.github.com/repos/AlexNPavel/operator-sdk","forks_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/forks","keys_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/teams","hooks_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/hooks","issue_events_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/events","assignees_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/tags","blobs_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/languages","stargazers_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/stargazers","contributors_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/contributors","subscribers_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/subscribers","subscription_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/subscription","commits_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/merges","archive_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/downloads","issues_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/labels{/name}","releases_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/deployments","created_at":"2018-07-12T21:45:39Z","updated_at":"2018-07-23T18:07:02Z","pushed_at":"2018-07-23T21:50:22Z","git_url":"git://github.com/AlexNPavel/operator-sdk.git","ssh_url":"git@github.com:AlexNPavel/operator-sdk.git","clone_url":"https://github.com/AlexNPavel/operator-sdk.git","svn_url":"https://github.com/AlexNPavel/operator-sdk","homepage":"https://coreos.com/operators","size":671,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"operator-framework:master","ref":"master","sha":"367ab7db96d6de58fcff438dd8f6af74c2e06361","user":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":120650407,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2NTA0MDc=","name":"operator-sdk","full_name":"operator-framework/operator-sdk","owner":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/operator-framework/operator-sdk","description":"SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.","fork":false,"url":"https://api.github.com/repos/operator-framework/operator-sdk","forks_url":"https://api.github.com/repos/operator-framework/operator-sdk/forks","keys_url":"https://api.github.com/repos/operator-framework/operator-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/operator-framework/operator-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/operator-framework/operator-sdk/teams","hooks_url":"https://api.github.com/repos/operator-framework/operator-sdk/hooks","issue_events_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/operator-framework/operator-sdk/events","assignees_url":"https://api.github.com/repos/operator-framework/operator-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/operator-framework/operator-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/operator-framework/operator-sdk/tags","blobs_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/operator-framework/operator-sdk/languages","stargazers_url":"https://api.github.com/repos/operator-framework/operator-sdk/stargazers","contributors_url":"https://api.github.com/repos/operator-framework/operator-sdk/contributors","subscribers_url":"https://api.github.com/repos/operator-framework/operator-sdk/subscribers","subscription_url":"https://api.github.com/repos/operator-framework/operator-sdk/subscription","commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/operator-framework/operator-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/operator-framework/operator-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/operator-framework/operator-sdk/merges","archive_url":"https://api.github.com/repos/operator-framework/operator-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/operator-framework/operator-sdk/downloads","issues_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/operator-framework/operator-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/operator-framework/operator-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/operator-framework/operator-sdk/labels{/name}","releases_url":"https://api.github.com/repos/operator-framework/operator-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/operator-framework/operator-sdk/deployments","created_at":"2018-02-07T17:53:51Z","updated_at":"2018-07-23T19:50:15Z","pushed_at":"2018-07-23T21:50:24Z","git_url":"git://github.com/operator-framework/operator-sdk.git","ssh_url":"git@github.com:operator-framework/operator-sdk.git","clone_url":"https://github.com/operator-framework/operator-sdk.git","svn_url":"https://github.com/operator-framework/operator-sdk","homepage":"https://coreos.com/operators","size":663,"stargazers_count":679,"watchers_count":679,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":100,"open_issues":57,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359"},"html":{"href":"https://github.com/operator-framework/operator-sdk/pull/359"},"issue":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/issues/359"},"comments":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/d59c1e9760c91d63305e9d12cdd4c2384b94b4e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fanminshi"}}