{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169795385","pull_request_review_id":98371286,"id":169795385,"diff_hunk":"@@ -599,19 +508,19 @@ func (proxier *Proxier) OnServiceSynced() {\n }\n \n func (proxier *Proxier) OnEndpointsAdd(endpoints *api.Endpoints) {\n-\tif proxier.endpointsChanges.Update(nil, endpoints, newEndpointsInfo) && proxier.isInitialized() {\n+\tif proxier.endpointsChanges.Update(nil, endpoints) && proxier.isInitialized() {","path":"pkg/proxy/iptables/proxier.go","position":null,"original_position":229,"commit_id":"dd89fabf4443913424d977fcd2e8d8f4ce5ee0bb","original_commit_id":"2da654c7a6e7458f811b89f3ca90377436af0743","user":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"body":"Sure, updated.","created_at":"2018-02-21T22:14:16Z","updated_at":"2018-02-21T22:37:19Z","html_url":"https://github.com/kubernetes/kubernetes/pull/56880#discussion_r169795385","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169795385"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/56880#discussion_r169795385"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880"}},"in_reply_to_id":169739090},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880","id":156644936,"html_url":"https://github.com/kubernetes/kubernetes/pull/56880","diff_url":"https://github.com/kubernetes/kubernetes/pull/56880.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56880.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56880","number":56880,"state":"open","locked":false,"title":"Harden kube-proxy for unmatched IP versions","user":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nThis PR makes kube-proxy omits & logs & emits event for unmatched IP versions configuration (IPv6 address in IPv4 mode or IPv4 address in IPv6 mode). \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #57219\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nFix the issue in kube-proxy iptables/ipvs mode to properly handle incorrect IP version.\r\n```\r\n","created_at":"2017-12-06T05:36:38Z","updated_at":"2018-02-21T22:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"616007399d5b8be92680a073226f00de6526eeee","assignee":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"freehan","id":1332699,"avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56880/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dd89fabf4443913424d977fcd2e8d8f4ce5ee0bb","head":{"label":"MrHohn:kube-proxy-ipv6-fix","ref":"kube-proxy-ipv6-fix","sha":"dd89fabf4443913424d977fcd2e8d8f4ce5ee0bb","user":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"repo":{"id":63400047,"name":"kubernetes","full_name":"MrHohn/kubernetes","owner":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrHohn/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/MrHohn/kubernetes","forks_url":"https://api.github.com/repos/MrHohn/kubernetes/forks","keys_url":"https://api.github.com/repos/MrHohn/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrHohn/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrHohn/kubernetes/teams","hooks_url":"https://api.github.com/repos/MrHohn/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/MrHohn/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/MrHohn/kubernetes/events","assignees_url":"https://api.github.com/repos/MrHohn/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/MrHohn/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/MrHohn/kubernetes/tags","blobs_url":"https://api.github.com/repos/MrHohn/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrHohn/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrHohn/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrHohn/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrHohn/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/MrHohn/kubernetes/languages","stargazers_url":"https://api.github.com/repos/MrHohn/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/MrHohn/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/MrHohn/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/MrHohn/kubernetes/subscription","commits_url":"https://api.github.com/repos/MrHohn/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrHohn/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrHohn/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrHohn/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrHohn/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/MrHohn/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrHohn/kubernetes/merges","archive_url":"https://api.github.com/repos/MrHohn/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrHohn/kubernetes/downloads","issues_url":"https://api.github.com/repos/MrHohn/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/MrHohn/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/MrHohn/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/MrHohn/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrHohn/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/MrHohn/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/MrHohn/kubernetes/deployments","created_at":"2016-07-15T07:10:33Z","updated_at":"2016-07-19T07:20:43Z","pushed_at":"2018-02-21T22:36:25Z","git_url":"git://github.com/MrHohn/kubernetes.git","ssh_url":"git@github.com:MrHohn/kubernetes.git","clone_url":"https://github.com/MrHohn/kubernetes.git","svn_url":"https://github.com/MrHohn/kubernetes","homepage":"http://kubernetes.io","size":528919,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a6b8c06380526d9631f1f965a61cd1aae2a5832d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-21T21:57:56Z","pushed_at":"2018-02-21T22:36:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":755110,"stargazers_count":32758,"watchers_count":32758,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11548,"mirror_url":null,"archived":false,"open_issues_count":4648,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11548,"open_issues":4648,"watchers":32758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/56880"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56880"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56880/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56880/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dd89fabf4443913424d977fcd2e8d8f4ce5ee0bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MrHohn"}}