{"action":"created","issue":{"url":"https://api.github.com/repos/ximion/appstream/issues/193","repository_url":"https://api.github.com/repos/ximion/appstream","labels_url":"https://api.github.com/repos/ximion/appstream/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/ximion/appstream/issues/193/comments","events_url":"https://api.github.com/repos/ximion/appstream/issues/193/events","html_url":"https://github.com/ximion/appstream/pull/193","id":332260917,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Nzg1Mzkx","number":193,"title":"Fix memory leaks","user":{"login":"PhilMiller","id":126464,"node_id":"MDQ6VXNlcjEyNjQ2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/126464?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilMiller","html_url":"https://github.com/PhilMiller","followers_url":"https://api.github.com/users/PhilMiller/followers","following_url":"https://api.github.com/users/PhilMiller/following{/other_user}","gists_url":"https://api.github.com/users/PhilMiller/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilMiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilMiller/subscriptions","organizations_url":"https://api.github.com/users/PhilMiller/orgs","repos_url":"https://api.github.com/users/PhilMiller/repos","events_url":"https://api.github.com/users/PhilMiller/events{/privacy}","received_events_url":"https://api.github.com/users/PhilMiller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-14T05:55:52Z","updated_at":"2018-06-14T15:14:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ximion/appstream/pulls/193","html_url":"https://github.com/ximion/appstream/pull/193","diff_url":"https://github.com/ximion/appstream/pull/193.diff","patch_url":"https://github.com/ximion/appstream/pull/193.patch"},"body":"Together, these were leaking megabytes at a time in the downstream program isenkramd every time I plugged in my mouse."},"comment":{"url":"https://api.github.com/repos/ximion/appstream/issues/comments/397332003","html_url":"https://github.com/ximion/appstream/pull/193#issuecomment-397332003","issue_url":"https://api.github.com/repos/ximion/appstream/issues/193","id":397332003,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzMzMjAwMw==","user":{"login":"PhilMiller","id":126464,"node_id":"MDQ6VXNlcjEyNjQ2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/126464?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilMiller","html_url":"https://github.com/PhilMiller","followers_url":"https://api.github.com/users/PhilMiller/followers","following_url":"https://api.github.com/users/PhilMiller/following{/other_user}","gists_url":"https://api.github.com/users/PhilMiller/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilMiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilMiller/subscriptions","organizations_url":"https://api.github.com/users/PhilMiller/orgs","repos_url":"https://api.github.com/users/PhilMiller/repos","events_url":"https://api.github.com/users/PhilMiller/events{/privacy}","received_events_url":"https://api.github.com/users/PhilMiller/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T15:14:18Z","updated_at":"2018-06-14T15:14:18Z","author_association":"NONE","body":"Ah, I didn't know those facilities were available. Now that it's got your\nattention, could I let you fix it the preferred way?\n\nOn Jun 14, 2018 9:13 AM, \"Matthias Klumpp\" <notifications@github.com> wrote:\n\nThank you for your patch! I will review & merge it later today.\nOne thing that is notable is that the patch can be simplified by using the\ng_auto macro to automatically finalize a GVariantDict when going out of the\ncurrent scope. That prevents the issue from happening again and simplifies\nthe code.\nThe same can likely be done for the GVariant (via g_autoptr) related issue\nand for the path string in find_files_matching using g_autofree there.\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub\n<https://github.com/ximion/appstream/pull/193#issuecomment-397310806>, or mute\nthe thread\n<https://github.com/notifications/unsubscribe-auth/AAHuAL_iqNlsxoLdEhAKQSHSYihpANuwks5t8m99gaJpZM4UnWZx>\n.\n"}}
{"actor":{"display_login":"PhilMiller"}}