{"action":"created","comment":{"url":"https://api.github.com/repos/psi4/psi4/pulls/comments/236751991","pull_request_review_id":178892688,"id":236751991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjc1MTk5MQ==","diff_hunk":"@@ -33,22 +33,15 @@\n #   OpenMP_LIBRARY_DIRS - list of directories where OpenMP libraries may be found,\n #                         in preference to DEFAULT_PATHS\n #\n-cmake_policy(PUSH)\n-cmake_policy(SET CMP0057 NEW)  # support IN_LISTS\n-\n-\n set(PN TargetOpenMP)\n \n-separate_arguments(${PN}_FIND_COMPONENTS)\n if(NOT ${PN}_FIND_COMPONENTS)\n-    set(${PN}_FINDLIST C CXX Fortran)\n-else()\n-    set(${PN}_FINDLIST ${${PN}_FIND_COMPONENTS})\n+    set(${PN}_FIND_COMPONENTS C CXX Fortran)\n endif()\n-separate_arguments(${PN}_FINDLIST)\n+separate_arguments(${PN}_FIND_COMPONENTS)\n \n if (NOT ${PN}_FIND_QUIETLY)\n-    message(STATUS \"Detecting MathOpenMP -- ?OpenMP=${ENABLE_OPENMP}, ?MKL=${isMKL}, LANG=${${PN}_FINDLIST}, C/CXX/Fortran=${CMAKE_C_COMPILER_ID}/${CMAKE_CXX_COMPILER_ID}/${CMAKE_Fortran_COMPILER_ID}\")\n+    message(STATUS \"Detecting MathOpenMP -- ?OpenMP=${ENABLE_OPENMP}, ?MKL=${isMKL}, LANG=${${PN}_FIND_COMPONENTS}, C/CXX/Fortran=${CMAKE_C_COMPILER_ID}/${CMAKE_CXX_COMPILER_ID}/${CMAKE_Fortran_COMPILER_ID}\")","path":"external/common/lapack/FindTargetOpenMP.cmake","position":23,"original_position":22,"commit_id":"e4fa2f11d2032a0fcc9f455a74245b95ae18b1fc","original_commit_id":"85d2f365797588943fb58da4aa5c3b0e674ebf08","user":{"login":"raimis","id":2469715,"node_id":"MDQ6VXNlcjI0Njk3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2469715?v=4","gravatar_id":"","url":"https://api.github.com/users/raimis","html_url":"https://github.com/raimis","followers_url":"https://api.github.com/users/raimis/followers","following_url":"https://api.github.com/users/raimis/following{/other_user}","gists_url":"https://api.github.com/users/raimis/gists{/gist_id}","starred_url":"https://api.github.com/users/raimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raimis/subscriptions","organizations_url":"https://api.github.com/users/raimis/orgs","repos_url":"https://api.github.com/users/raimis/repos","events_url":"https://api.github.com/users/raimis/events{/privacy}","received_events_url":"https://api.github.com/users/raimis/received_events","type":"User","site_admin":false},"body":"@loriab I see your point, I will return the functionality.","created_at":"2018-11-27T16:47:59Z","updated_at":"2018-11-27T16:48:00Z","html_url":"https://github.com/psi4/psi4/pull/1348#discussion_r236751991","pull_request_url":"https://api.github.com/repos/psi4/psi4/pulls/1348","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/psi4/psi4/pulls/comments/236751991"},"html":{"href":"https://github.com/psi4/psi4/pull/1348#discussion_r236751991"},"pull_request":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1348"}},"in_reply_to_id":236286122},"pull_request":{"url":"https://api.github.com/repos/psi4/psi4/pulls/1348","id":229891434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODkxNDM0","html_url":"https://github.com/psi4/psi4/pull/1348","diff_url":"https://github.com/psi4/psi4/pull/1348.diff","patch_url":"https://github.com/psi4/psi4/pull/1348.patch","issue_url":"https://api.github.com/repos/psi4/psi4/issues/1348","number":1348,"state":"open","locked":false,"title":"Fix OpenMP config for clang-cl on Windonws","user":{"login":"raimis","id":2469715,"node_id":"MDQ6VXNlcjI0Njk3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2469715?v=4","gravatar_id":"","url":"https://api.github.com/users/raimis","html_url":"https://github.com/raimis","followers_url":"https://api.github.com/users/raimis/followers","following_url":"https://api.github.com/users/raimis/following{/other_user}","gists_url":"https://api.github.com/users/raimis/gists{/gist_id}","starred_url":"https://api.github.com/users/raimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raimis/subscriptions","organizations_url":"https://api.github.com/users/raimis/orgs","repos_url":"https://api.github.com/users/raimis/repos","events_url":"https://api.github.com/users/raimis/events{/privacy}","received_events_url":"https://api.github.com/users/raimis/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is part of *Psi4* porting to Windows (#933).\r\n\r\n*FindOpenMP* doesn't yet support *clang-cl*, so the config has to be done manually.\r\n\r\n## Todos\r\nNotable points (developer or user-interest) that this PR has or will accomplish.\r\n- [x] Fix OpenMP config for clang-cl on Windonws\r\n- [x] Check if OpenMP config hadn't failed silently\r\n\r\n## Checklist\r\n- [x] Tests added for any new features\r\n- [x] [All or relevant fraction of full tests run](http://psicode.org/psi4manual/master/build_planning.html#how-to-run-a-subset-of-tests)\r\n\r\n## Status\r\n- [x] Ready for review\r\n- [ ] Ready for merge\r\n","created_at":"2018-11-10T14:10:29Z","updated_at":"2018-11-27T16:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98183ccdf926828697c9dbeebb6f28a62b6ccce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/psi4/psi4/pulls/1348/commits","review_comments_url":"https://api.github.com/repos/psi4/psi4/pulls/1348/comments","review_comment_url":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psi4/psi4/issues/1348/comments","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/e4fa2f11d2032a0fcc9f455a74245b95ae18b1fc","head":{"label":"raimis:fix_openmp","ref":"fix_openmp","sha":"e4fa2f11d2032a0fcc9f455a74245b95ae18b1fc","user":{"login":"raimis","id":2469715,"node_id":"MDQ6VXNlcjI0Njk3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2469715?v=4","gravatar_id":"","url":"https://api.github.com/users/raimis","html_url":"https://github.com/raimis","followers_url":"https://api.github.com/users/raimis/followers","following_url":"https://api.github.com/users/raimis/following{/other_user}","gists_url":"https://api.github.com/users/raimis/gists{/gist_id}","starred_url":"https://api.github.com/users/raimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raimis/subscriptions","organizations_url":"https://api.github.com/users/raimis/orgs","repos_url":"https://api.github.com/users/raimis/repos","events_url":"https://api.github.com/users/raimis/events{/privacy}","received_events_url":"https://api.github.com/users/raimis/received_events","type":"User","site_admin":false},"repo":{"id":133051847,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNTE4NDc=","name":"psi4","full_name":"raimis/psi4","private":false,"owner":{"login":"raimis","id":2469715,"node_id":"MDQ6VXNlcjI0Njk3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2469715?v=4","gravatar_id":"","url":"https://api.github.com/users/raimis","html_url":"https://github.com/raimis","followers_url":"https://api.github.com/users/raimis/followers","following_url":"https://api.github.com/users/raimis/following{/other_user}","gists_url":"https://api.github.com/users/raimis/gists{/gist_id}","starred_url":"https://api.github.com/users/raimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raimis/subscriptions","organizations_url":"https://api.github.com/users/raimis/orgs","repos_url":"https://api.github.com/users/raimis/repos","events_url":"https://api.github.com/users/raimis/events{/privacy}","received_events_url":"https://api.github.com/users/raimis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raimis/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":true,"url":"https://api.github.com/repos/raimis/psi4","forks_url":"https://api.github.com/repos/raimis/psi4/forks","keys_url":"https://api.github.com/repos/raimis/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raimis/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raimis/psi4/teams","hooks_url":"https://api.github.com/repos/raimis/psi4/hooks","issue_events_url":"https://api.github.com/repos/raimis/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/raimis/psi4/events","assignees_url":"https://api.github.com/repos/raimis/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/raimis/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/raimis/psi4/tags","blobs_url":"https://api.github.com/repos/raimis/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raimis/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raimis/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/raimis/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raimis/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/raimis/psi4/languages","stargazers_url":"https://api.github.com/repos/raimis/psi4/stargazers","contributors_url":"https://api.github.com/repos/raimis/psi4/contributors","subscribers_url":"https://api.github.com/repos/raimis/psi4/subscribers","subscription_url":"https://api.github.com/repos/raimis/psi4/subscription","commits_url":"https://api.github.com/repos/raimis/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/raimis/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/raimis/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/raimis/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/raimis/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/raimis/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raimis/psi4/merges","archive_url":"https://api.github.com/repos/raimis/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raimis/psi4/downloads","issues_url":"https://api.github.com/repos/raimis/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/raimis/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/raimis/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/raimis/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raimis/psi4/labels{/name}","releases_url":"https://api.github.com/repos/raimis/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/raimis/psi4/deployments","created_at":"2018-05-11T14:43:21Z","updated_at":"2018-11-27T10:36:56Z","pushed_at":"2018-11-27T16:44:09Z","git_url":"git://github.com/raimis/psi4.git","ssh_url":"git@github.com:raimis/psi4.git","clone_url":"https://github.com/raimis/psi4.git","svn_url":"https://github.com/raimis/psi4","homepage":"http://psicode.org","size":89882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"psi4:master","ref":"master","sha":"f5d77113b8a186ee23a5ecf43479b7b88bb13841","user":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"repo":{"id":9174469,"node_id":"MDEwOlJlcG9zaXRvcnk5MTc0NDY5","name":"psi4","full_name":"psi4/psi4","private":false,"owner":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/psi4/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":false,"url":"https://api.github.com/repos/psi4/psi4","forks_url":"https://api.github.com/repos/psi4/psi4/forks","keys_url":"https://api.github.com/repos/psi4/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psi4/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psi4/psi4/teams","hooks_url":"https://api.github.com/repos/psi4/psi4/hooks","issue_events_url":"https://api.github.com/repos/psi4/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/psi4/psi4/events","assignees_url":"https://api.github.com/repos/psi4/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/psi4/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/psi4/psi4/tags","blobs_url":"https://api.github.com/repos/psi4/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psi4/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psi4/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/psi4/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/psi4/psi4/languages","stargazers_url":"https://api.github.com/repos/psi4/psi4/stargazers","contributors_url":"https://api.github.com/repos/psi4/psi4/contributors","subscribers_url":"https://api.github.com/repos/psi4/psi4/subscribers","subscription_url":"https://api.github.com/repos/psi4/psi4/subscription","commits_url":"https://api.github.com/repos/psi4/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/psi4/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/psi4/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/psi4/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/psi4/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/psi4/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psi4/psi4/merges","archive_url":"https://api.github.com/repos/psi4/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psi4/psi4/downloads","issues_url":"https://api.github.com/repos/psi4/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/psi4/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/psi4/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/psi4/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psi4/psi4/labels{/name}","releases_url":"https://api.github.com/repos/psi4/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/psi4/psi4/deployments","created_at":"2013-04-02T16:21:04Z","updated_at":"2018-11-26T22:47:33Z","pushed_at":"2018-11-27T16:42:15Z","git_url":"git://github.com/psi4/psi4.git","ssh_url":"git@github.com:psi4/psi4.git","clone_url":"https://github.com/psi4/psi4.git","svn_url":"https://github.com/psi4/psi4","homepage":"http://psicode.org","size":89362,"stargazers_count":259,"watchers_count":259,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":207,"open_issues":134,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1348"},"html":{"href":"https://github.com/psi4/psi4/pull/1348"},"issue":{"href":"https://api.github.com/repos/psi4/psi4/issues/1348"},"comments":{"href":"https://api.github.com/repos/psi4/psi4/issues/1348/comments"},"review_comments":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1348/comments"},"review_comment":{"href":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1348/commits"},"statuses":{"href":"https://api.github.com/repos/psi4/psi4/statuses/e4fa2f11d2032a0fcc9f455a74245b95ae18b1fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"raimis"}}