{"action":"created","issue":{"url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/44","repository_url":"https://api.github.com/repos/ScriptFUSION/Porter","labels_url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/44/comments","events_url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/44/events","html_url":"https://github.com/ScriptFUSION/Porter/pull/44","id":268211244,"number":44,"title":"Rewrote CachingConnector as decorator","user":{"login":"Bilge","id":470626,"avatar_url":"https://avatars1.githubusercontent.com/u/470626?v=4","gravatar_id":"","url":"https://api.github.com/users/Bilge","html_url":"https://github.com/Bilge","followers_url":"https://api.github.com/users/Bilge/followers","following_url":"https://api.github.com/users/Bilge/following{/other_user}","gists_url":"https://api.github.com/users/Bilge/gists{/gist_id}","starred_url":"https://api.github.com/users/Bilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bilge/subscriptions","organizations_url":"https://api.github.com/users/Bilge/orgs","repos_url":"https://api.github.com/users/Bilge/repos","events_url":"https://api.github.com/users/Bilge/events{/privacy}","received_events_url":"https://api.github.com/users/Bilge/received_events","type":"User","site_admin":false},"labels":[{"id":459713018,"url":"https://api.github.com/repos/ScriptFUSION/Porter/labels/improvement","name":"improvement","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ScriptFUSION/Porter/milestones/3","html_url":"https://github.com/ScriptFUSION/Porter/milestone/3","labels_url":"https://api.github.com/repos/ScriptFUSION/Porter/milestones/3/labels","id":2394725,"number":3,"title":"4.0.0","description":"","creator":{"login":"Bilge","id":470626,"avatar_url":"https://avatars1.githubusercontent.com/u/470626?v=4","gravatar_id":"","url":"https://api.github.com/users/Bilge","html_url":"https://github.com/Bilge","followers_url":"https://api.github.com/users/Bilge/followers","following_url":"https://api.github.com/users/Bilge/following{/other_user}","gists_url":"https://api.github.com/users/Bilge/gists{/gist_id}","starred_url":"https://api.github.com/users/Bilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bilge/subscriptions","organizations_url":"https://api.github.com/users/Bilge/orgs","repos_url":"https://api.github.com/users/Bilge/repos","events_url":"https://api.github.com/users/Bilge/events{/privacy}","received_events_url":"https://api.github.com/users/Bilge/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":16,"state":"open","created_at":"2017-03-17T23:13:29Z","updated_at":"2018-04-09T20:38:52Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-10-24T22:43:22Z","updated_at":"2018-04-09T20:38:52Z","closed_at":"2018-04-09T20:38:52Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/ScriptFUSION/Porter/pulls/44","html_url":"https://github.com/ScriptFUSION/Porter/pull/44","diff_url":"https://github.com/ScriptFUSION/Porter/pull/44.diff","patch_url":"https://github.com/ScriptFUSION/Porter/pull/44.patch"},"body":"This key change brings the following improvements to `CachingConnector`.\r\n\r\n* `Connector` implementations no longer have to extend `CachingConnector` to provide caching facilities: all connectors can be decorated with `CachingConnector` with no prior knowledge of the existence of such facility. This completely removes the burden on implementations to be aware of caching concerns.\r\n* Frees up the inheritance chain for `Connector` implementations to use however else they see fit.\r\n\r\n## Technical changes\r\n\r\n* Changed `CachingConnector` from abstract class to concrete decorator.\r\n* Replaced `CachedAdvice` with simple boolean (cache or cache not; there is no *try*).\r\n* Removed superfluous `Cache` interface.\r\n* Removed superfluous enumeration dependency.\r\n* Renamed `SuperConnector` -> `ImportConnector`.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/comments/379886548","html_url":"https://github.com/ScriptFUSION/Porter/pull/44#issuecomment-379886548","issue_url":"https://api.github.com/repos/ScriptFUSION/Porter/issues/44","id":379886548,"user":{"login":"Bilge","id":470626,"avatar_url":"https://avatars1.githubusercontent.com/u/470626?v=4","gravatar_id":"","url":"https://api.github.com/users/Bilge","html_url":"https://github.com/Bilge","followers_url":"https://api.github.com/users/Bilge/followers","following_url":"https://api.github.com/users/Bilge/following{/other_user}","gists_url":"https://api.github.com/users/Bilge/gists{/gist_id}","starred_url":"https://api.github.com/users/Bilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bilge/subscriptions","organizations_url":"https://api.github.com/users/Bilge/orgs","repos_url":"https://api.github.com/users/Bilge/repos","events_url":"https://api.github.com/users/Bilge/events{/privacy}","received_events_url":"https://api.github.com/users/Bilge/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T20:38:52Z","updated_at":"2018-04-09T20:38:52Z","author_association":"OWNER","body":"Included in #46."}}
{"actor":{"display_login":"Bilge"}}