{"action":"created","issue":{"url":"https://api.github.com/repos/LLK/scratch-vm/issues/1217","repository_url":"https://api.github.com/repos/LLK/scratch-vm","labels_url":"https://api.github.com/repos/LLK/scratch-vm/issues/1217/labels{/name}","comments_url":"https://api.github.com/repos/LLK/scratch-vm/issues/1217/comments","events_url":"https://api.github.com/repos/LLK/scratch-vm/issues/1217/events","html_url":"https://github.com/LLK/scratch-vm/pull/1217","id":330305339,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzQ2OTMx","number":1217,"title":"Comment state fixes","user":{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},"labels":[{"id":832424885,"node_id":"MDU6TGFiZWw4MzI0MjQ4ODU=","url":"https://api.github.com/repos/LLK/scratch-vm/labels/needs-qa","name":"needs-qa","color":"5319e7","default":false},{"id":364575438,"node_id":"MDU6TGFiZWwzNjQ1NzU0Mzg=","url":"https://api.github.com/repos/LLK/scratch-vm/labels/pr%20-%20good%20to%20merge","name":"pr - good to merge","color":"0e8a66","default":false}],"state":"closed","locked":false,"assignee":{"login":"BryceLTaylor","id":1088291,"node_id":"MDQ6VXNlcjEwODgyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1088291?v=4","gravatar_id":"","url":"https://api.github.com/users/BryceLTaylor","html_url":"https://github.com/BryceLTaylor","followers_url":"https://api.github.com/users/BryceLTaylor/followers","following_url":"https://api.github.com/users/BryceLTaylor/following{/other_user}","gists_url":"https://api.github.com/users/BryceLTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/BryceLTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryceLTaylor/subscriptions","organizations_url":"https://api.github.com/users/BryceLTaylor/orgs","repos_url":"https://api.github.com/users/BryceLTaylor/repos","events_url":"https://api.github.com/users/BryceLTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/BryceLTaylor/received_events","type":"User","site_admin":false},"assignees":[{"login":"BryceLTaylor","id":1088291,"node_id":"MDQ6VXNlcjEwODgyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1088291?v=4","gravatar_id":"","url":"https://api.github.com/users/BryceLTaylor","html_url":"https://github.com/BryceLTaylor","followers_url":"https://api.github.com/users/BryceLTaylor/followers","following_url":"https://api.github.com/users/BryceLTaylor/following{/other_user}","gists_url":"https://api.github.com/users/BryceLTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/BryceLTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryceLTaylor/subscriptions","organizations_url":"https://api.github.com/users/BryceLTaylor/orgs","repos_url":"https://api.github.com/users/BryceLTaylor/repos","events_url":"https://api.github.com/users/BryceLTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/BryceLTaylor/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-vm/milestones/30","html_url":"https://github.com/LLK/scratch-vm/milestone/30","labels_url":"https://api.github.com/repos/LLK/scratch-vm/milestones/30/labels","id":3123368,"node_id":"MDk6TWlsZXN0b25lMzEyMzM2OA==","number":30,"title":"June 2018","description":"","creator":{"login":"chrisgarrity","id":399209,"node_id":"MDQ6VXNlcjM5OTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/399209?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgarrity","html_url":"https://github.com/chrisgarrity","followers_url":"https://api.github.com/users/chrisgarrity/followers","following_url":"https://api.github.com/users/chrisgarrity/following{/other_user}","gists_url":"https://api.github.com/users/chrisgarrity/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgarrity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgarrity/subscriptions","organizations_url":"https://api.github.com/users/chrisgarrity/orgs","repos_url":"https://api.github.com/users/chrisgarrity/repos","events_url":"https://api.github.com/users/chrisgarrity/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgarrity/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":28,"state":"open","created_at":"2018-02-16T22:11:56Z","updated_at":"2018-06-20T18:27:25Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-06-07T14:44:30Z","updated_at":"2018-06-20T18:33:54Z","closed_at":"2018-06-07T18:31:44Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/LLK/scratch-vm/pulls/1217","html_url":"https://github.com/LLK/scratch-vm/pull/1217","diff_url":"https://github.com/LLK/scratch-vm/pull/1217.diff","patch_url":"https://github.com/LLK/scratch-vm/pull/1217.patch"},"body":"### Proposed Changes\r\n\r\nChanges to comment state-keeping.\r\n\r\nThe API for the CommentChange event emitted by scratch-blocks has been updated. Now, when a text change is emitted, the text change is represented as an object containing a 'text' property (to match the other kinds of changes a CommentChange event can encompass) instead of just a string. \r\n\r\nThis change needs to be accommodated in the VM, addressed by this PR.\r\n\r\nPreviously, I had added code to update a block comment's position if the block it's attached to was moved. This causes bugs where the comment keeps moving on sprite switch even if the user did not indicate a move. This is because a block move event is emitted every time the workspace containing the block is updated. This PR reverts this change. \r\n\r\nThere is now instead, a different bug where moving a block (with a comment attached to it) and switching sprites and back shows the comment in a different position relative to the block. This bug will be fixed with the fix for LLK/scratch-blocks#1566.\r\n\r\n\r\n### Reason for Changes\r\n\r\nSee above.\r\n\r\n### Test Coverage\r\n\r\nManual testing with scratch-gui.\r\n"},"comment":{"url":"https://api.github.com/repos/LLK/scratch-vm/issues/comments/398852439","html_url":"https://github.com/LLK/scratch-vm/pull/1217#issuecomment-398852439","issue_url":"https://api.github.com/repos/LLK/scratch-vm/issues/1217","id":398852439,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODg1MjQzOQ==","user":{"login":"BryceLTaylor","id":1088291,"node_id":"MDQ6VXNlcjEwODgyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1088291?v=4","gravatar_id":"","url":"https://api.github.com/users/BryceLTaylor","html_url":"https://github.com/BryceLTaylor","followers_url":"https://api.github.com/users/BryceLTaylor/followers","following_url":"https://api.github.com/users/BryceLTaylor/following{/other_user}","gists_url":"https://api.github.com/users/BryceLTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/BryceLTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryceLTaylor/subscriptions","organizations_url":"https://api.github.com/users/BryceLTaylor/orgs","repos_url":"https://api.github.com/users/BryceLTaylor/repos","events_url":"https://api.github.com/users/BryceLTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/BryceLTaylor/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T18:33:54Z","updated_at":"2018-06-20T18:33:54Z","author_association":"NONE","body":"I found several issues with comments generally and attacked them to the comments issue: https://github.com/LLK/scratch-blocks/issues/1554"}}
{"actor":{"display_login":"BryceLTaylor"}}