{"action":"created","comment":{"url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/comments/180069771","pull_request_review_id":110424580,"id":180069771,"diff_hunk":"@@ -52,10 +52,23 @@ class FFT(nfft: Int) {\n \n     // new value that contains the signal and padded with nfft zeros\n     // because the size doubles due to complex values\n-    val fft: Array[Double] = signal ++ Array.fill(2*nfft - signal.length)(0.0)\n+    val fft: Array[Double] = signal ++ Array.fill(nfft - signal.length)(0.0)\n \n-    // // In place computation\n-    lowLevelFtt.realForwardFull(fft)\n+    /** In place computation\n+     * if nfft is even then\n+     * fft[1] = Re[nfft/2]\n+     * if n is odd then\n+     * fft[1] = Im[(nfft-1)/2]\n+     */\n+    lowLevelFtt.realForward(fft)\n+\n+    val tmpValue: Double = fft(1)\n+    fft(1) = 0.0\n+    // if (nfft%2 == 0) {","path":"src/main/scala/org/ode/engine/signal_processing/FFT.scala","position":19,"original_position":19,"commit_id":"638549bfa1ee747021b25583abfebfd55be863eb","original_commit_id":"638549bfa1ee747021b25583abfebfd55be863eb","user":{"login":"jobar","id":1686047,"avatar_url":"https://avatars1.githubusercontent.com/u/1686047?v=4","gravatar_id":"","url":"https://api.github.com/users/jobar","html_url":"https://github.com/jobar","followers_url":"https://api.github.com/users/jobar/followers","following_url":"https://api.github.com/users/jobar/following{/other_user}","gists_url":"https://api.github.com/users/jobar/gists{/gist_id}","starred_url":"https://api.github.com/users/jobar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobar/subscriptions","organizations_url":"https://api.github.com/users/jobar/orgs","repos_url":"https://api.github.com/users/jobar/repos","events_url":"https://api.github.com/users/jobar/events{/privacy}","received_events_url":"https://api.github.com/users/jobar/received_events","type":"User","site_admin":false},"body":"Let's test that if we want to be sure, but this bit shouldn't be here :)","created_at":"2018-04-09T11:55:14Z","updated_at":"2018-04-09T11:58:09Z","html_url":"https://github.com/Project-ODE/FeatureEngine/pull/17#discussion_r180069771","pull_request_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/comments/180069771"},"html":{"href":"https://github.com/Project-ODE/FeatureEngine/pull/17#discussion_r180069771"},"pull_request":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17","id":179739722,"html_url":"https://github.com/Project-ODE/FeatureEngine/pull/17","diff_url":"https://github.com/Project-ODE/FeatureEngine/pull/17.diff","patch_url":"https://github.com/Project-ODE/FeatureEngine/pull/17.patch","issue_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/17","number":17,"state":"open","locked":false,"title":"Use onesided FFT in FFT class instead of twosided","user":{"login":"Alex2242","id":25385645,"avatar_url":"https://avatars2.githubusercontent.com/u/25385645?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex2242","html_url":"https://github.com/Alex2242","followers_url":"https://api.github.com/users/Alex2242/followers","following_url":"https://api.github.com/users/Alex2242/following{/other_user}","gists_url":"https://api.github.com/users/Alex2242/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex2242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex2242/subscriptions","organizations_url":"https://api.github.com/users/Alex2242/orgs","repos_url":"https://api.github.com/users/Alex2242/repos","events_url":"https://api.github.com/users/Alex2242/events{/privacy}","received_events_url":"https://api.github.com/users/Alex2242/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-05T17:07:12Z","updated_at":"2018-04-09T11:58:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea485885780c75f13bd870ac2f04647c40c927d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/17/comments","statuses_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/statuses/638549bfa1ee747021b25583abfebfd55be863eb","head":{"label":"Alex2242:fftonesided","ref":"fftonesided","sha":"638549bfa1ee747021b25583abfebfd55be863eb","user":{"login":"Alex2242","id":25385645,"avatar_url":"https://avatars2.githubusercontent.com/u/25385645?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex2242","html_url":"https://github.com/Alex2242","followers_url":"https://api.github.com/users/Alex2242/followers","following_url":"https://api.github.com/users/Alex2242/following{/other_user}","gists_url":"https://api.github.com/users/Alex2242/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex2242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex2242/subscriptions","organizations_url":"https://api.github.com/users/Alex2242/orgs","repos_url":"https://api.github.com/users/Alex2242/repos","events_url":"https://api.github.com/users/Alex2242/events{/privacy}","received_events_url":"https://api.github.com/users/Alex2242/received_events","type":"User","site_admin":false},"repo":{"id":106913841,"name":"FeatureEngine","full_name":"Alex2242/FeatureEngine","owner":{"login":"Alex2242","id":25385645,"avatar_url":"https://avatars2.githubusercontent.com/u/25385645?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex2242","html_url":"https://github.com/Alex2242","followers_url":"https://api.github.com/users/Alex2242/followers","following_url":"https://api.github.com/users/Alex2242/following{/other_user}","gists_url":"https://api.github.com/users/Alex2242/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex2242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex2242/subscriptions","organizations_url":"https://api.github.com/users/Alex2242/orgs","repos_url":"https://api.github.com/users/Alex2242/repos","events_url":"https://api.github.com/users/Alex2242/events{/privacy}","received_events_url":"https://api.github.com/users/Alex2242/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alex2242/FeatureEngine","description":null,"fork":true,"url":"https://api.github.com/repos/Alex2242/FeatureEngine","forks_url":"https://api.github.com/repos/Alex2242/FeatureEngine/forks","keys_url":"https://api.github.com/repos/Alex2242/FeatureEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alex2242/FeatureEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alex2242/FeatureEngine/teams","hooks_url":"https://api.github.com/repos/Alex2242/FeatureEngine/hooks","issue_events_url":"https://api.github.com/repos/Alex2242/FeatureEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Alex2242/FeatureEngine/events","assignees_url":"https://api.github.com/repos/Alex2242/FeatureEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Alex2242/FeatureEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Alex2242/FeatureEngine/tags","blobs_url":"https://api.github.com/repos/Alex2242/FeatureEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alex2242/FeatureEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alex2242/FeatureEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alex2242/FeatureEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alex2242/FeatureEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Alex2242/FeatureEngine/languages","stargazers_url":"https://api.github.com/repos/Alex2242/FeatureEngine/stargazers","contributors_url":"https://api.github.com/repos/Alex2242/FeatureEngine/contributors","subscribers_url":"https://api.github.com/repos/Alex2242/FeatureEngine/subscribers","subscription_url":"https://api.github.com/repos/Alex2242/FeatureEngine/subscription","commits_url":"https://api.github.com/repos/Alex2242/FeatureEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alex2242/FeatureEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alex2242/FeatureEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alex2242/FeatureEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alex2242/FeatureEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Alex2242/FeatureEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alex2242/FeatureEngine/merges","archive_url":"https://api.github.com/repos/Alex2242/FeatureEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alex2242/FeatureEngine/downloads","issues_url":"https://api.github.com/repos/Alex2242/FeatureEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Alex2242/FeatureEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Alex2242/FeatureEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Alex2242/FeatureEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alex2242/FeatureEngine/labels{/name}","releases_url":"https://api.github.com/repos/Alex2242/FeatureEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Alex2242/FeatureEngine/deployments","created_at":"2017-10-14T09:05:43Z","updated_at":"2018-04-02T09:19:31Z","pushed_at":"2018-04-09T09:34:53Z","git_url":"git://github.com/Alex2242/FeatureEngine.git","ssh_url":"git@github.com:Alex2242/FeatureEngine.git","clone_url":"https://github.com/Alex2242/FeatureEngine.git","svn_url":"https://github.com/Alex2242/FeatureEngine","homepage":null,"size":101431,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Project-ODE:master","ref":"master","sha":"6164dc285f39afe2e38dcf331c22a76a646df82c","user":{"login":"Project-ODE","id":32296801,"avatar_url":"https://avatars3.githubusercontent.com/u/32296801?v=4","gravatar_id":"","url":"https://api.github.com/users/Project-ODE","html_url":"https://github.com/Project-ODE","followers_url":"https://api.github.com/users/Project-ODE/followers","following_url":"https://api.github.com/users/Project-ODE/following{/other_user}","gists_url":"https://api.github.com/users/Project-ODE/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-ODE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-ODE/subscriptions","organizations_url":"https://api.github.com/users/Project-ODE/orgs","repos_url":"https://api.github.com/users/Project-ODE/repos","events_url":"https://api.github.com/users/Project-ODE/events{/privacy}","received_events_url":"https://api.github.com/users/Project-ODE/received_events","type":"Organization","site_admin":false},"repo":{"id":105042288,"name":"FeatureEngine","full_name":"Project-ODE/FeatureEngine","owner":{"login":"Project-ODE","id":32296801,"avatar_url":"https://avatars3.githubusercontent.com/u/32296801?v=4","gravatar_id":"","url":"https://api.github.com/users/Project-ODE","html_url":"https://github.com/Project-ODE","followers_url":"https://api.github.com/users/Project-ODE/followers","following_url":"https://api.github.com/users/Project-ODE/following{/other_user}","gists_url":"https://api.github.com/users/Project-ODE/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-ODE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-ODE/subscriptions","organizations_url":"https://api.github.com/users/Project-ODE/orgs","repos_url":"https://api.github.com/users/Project-ODE/repos","events_url":"https://api.github.com/users/Project-ODE/events{/privacy}","received_events_url":"https://api.github.com/users/Project-ODE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-ODE/FeatureEngine","description":null,"fork":false,"url":"https://api.github.com/repos/Project-ODE/FeatureEngine","forks_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/forks","keys_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/teams","hooks_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/hooks","issue_events_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/events","assignees_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/tags","blobs_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/languages","stargazers_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/stargazers","contributors_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/contributors","subscribers_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/subscribers","subscription_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/subscription","commits_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/merges","archive_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/downloads","issues_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/labels{/name}","releases_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Project-ODE/FeatureEngine/deployments","created_at":"2017-09-27T16:30:10Z","updated_at":"2018-04-09T09:19:23Z","pushed_at":"2018-04-09T09:34:55Z","git_url":"git://github.com/Project-ODE/FeatureEngine.git","ssh_url":"git@github.com:Project-ODE/FeatureEngine.git","clone_url":"https://github.com/Project-ODE/FeatureEngine.git","svn_url":"https://github.com/Project-ODE/FeatureEngine","homepage":null,"size":7141,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17"},"html":{"href":"https://github.com/Project-ODE/FeatureEngine/pull/17"},"issue":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/17"},"comments":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Project-ODE/FeatureEngine/statuses/638549bfa1ee747021b25583abfebfd55be863eb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jobar"}}