{"action":"created","comment":{"url":"https://api.github.com/repos/SFML/SFML/pulls/comments/177250378","pull_request_review_id":107091139,"id":177250378,"diff_hunk":"@@ -1,5 +1,111 @@\n # Changelog\n \n+## SFML 2.5\n+\n+Also available on the website: https://www.sfml-dev.org/changelog.php#sfml-2.5\n+\n+### General\n+\n+  * Markdown'd and updated readme, changelog, contributing and license files ([#1196](https://github.com/SFML/SFML/pull/1196), [#1368](https://github.com/SFML/SFML/pull/1368), [#1317](https://github.com/SFML/SFML/pull/1317))\n+  * Improve packaging support ([#1173](https://github.com/SFML/SFML/pull/1173))\n+  * Added Tagfile generation and search ([#1327](https://github.com/SFML/SFML/pull/1327))\n+  * Set policy CMP0042 if cmake version > 3.0 ([#1206](https://github.com/SFML/SFML/pull/1206))\n+  * Added CMake variables to select the modules to be built ([#800](https://github.com/SFML/SFML/pull/800))\n+  * Updated the binary libs from exlibs/libs-ios in order to work with Xcode 8 and iOS 10 ([#1209](https://github.com/SFML/SFML/pull/1209))\n+  * Do not install extlibs if `SFML_USE_SYSTEM_DEPS` is true ([#1237](https://github.com/SFML/SFML/pull/1237))\n+  * Updated stb_image to v2.16 and stb_image_write to v1.07 ([#1270](https://github.com/SFML/SFML/pull/1270))\n+  * Fixed various type conversion/comparison warnings ([#1325](https://github.com/SFML/SFML/pull/1325))\n+  * [macOS] Fixed launch of cocoa examples ([#1334](https://github.com/SFML/SFML/pull/1334))\n+  * [macOS] Improved application signing process ([#1194](https://github.com/SFML/SFML/pull/1194))\n+  * [macOS] Improve cmake script ([#1215](https://github.com/SFML/SFML/pull/1215))\n+  * [macOS] Use `-stdlib=libc++` ([#1361](https://github.com/SFML/SFML/pull/1361))\n+  * [macOS] Fix CMake warning since CMake 3.9 ([#1371](https://github.com/SFML/SFML/pull/1371))\n+  * [iOS] Use a CMake toolchain file for iOS build ([#1269](https://github.com/SFML/SFML/pull/1269))\n+  * [iOS] Install extlibs if needed ([#1348](https://github.com/SFML/SFML/pull/1348))\n+  * [iOS] Drop 32 bit support ([#1374](https://github.com/SFML/SFML/pull/1374))\n+  * [iOS] Force correct iOS architecture for cmake ([#1377](https://github.com/SFML/SFML/pull/1377))\n+  * [iOS] Find OpenAL correctly ([#1376](https://github.com/SFML/SFML/pull/1376))\n+  * [Android] Increased minimum API version to 14 ([#1362](https://github.com/SFML/SFML/pull/1362))\n+  * [Android] Removed custom toolchain and added support for the newest NDK version ([#1350](https://github.com/SFML/SFML/pull/1350))\n+\n+### System\n+\n+**Bugfixes**\n+\n+  * Fixed crash when `sf::Clock` is constructed in a global scope ([#1258](https://github.com/SFML/SFML/pull/1258))\n+\n+### Window\n+\n+**Features**\n+\n+  * Implemented Cursor API ([#827](https://github.com/SFML/SFML/pull/827))\n+  * Implemented Clipboard API ([#1221](https://github.com/SFML/SFML/pull/1221))\n+  * [Windows] Added support for interfacing with joysticks via DirectInput when it is available ([#1326](https://github.com/SFML/SFML/pull/1326))\n+\n+**Bugfixes**\n+\n+  * Updated documentation ([#1255](https://github.com/SFML/SFML/pull/1255), [#1310](https://github.com/SFML/SFML/pull/1310))\n+  * [macOS] Fixed window menu not working ([#1193](https://github.com/SFML/SFML/pull/1193))\n+  * [macOS] Removed unused variable ([#1276](https://github.com/SFML/SFML/pull/1276))","path":"changelog.md","position":49,"original_position":49,"commit_id":"05d03fdd6ba7219f5dc3c865e272ab6ae43087eb","original_commit_id":"05d03fdd6ba7219f5dc3c865e272ab6ae43087eb","user":{"login":"eXpl0it3r","id":920861,"avatar_url":"https://avatars1.githubusercontent.com/u/920861?v=4","gravatar_id":"","url":"https://api.github.com/users/eXpl0it3r","html_url":"https://github.com/eXpl0it3r","followers_url":"https://api.github.com/users/eXpl0it3r/followers","following_url":"https://api.github.com/users/eXpl0it3r/following{/other_user}","gists_url":"https://api.github.com/users/eXpl0it3r/gists{/gist_id}","starred_url":"https://api.github.com/users/eXpl0it3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXpl0it3r/subscriptions","organizations_url":"https://api.github.com/users/eXpl0it3r/orgs","repos_url":"https://api.github.com/users/eXpl0it3r/repos","events_url":"https://api.github.com/users/eXpl0it3r/events{/privacy}","received_events_url":"https://api.github.com/users/eXpl0it3r/received_events","type":"User","site_admin":false},"body":"Refactors don't need to be in the changelog unless they have an impact on the API","created_at":"2018-03-26T22:08:50Z","updated_at":"2018-03-26T22:17:44Z","html_url":"https://github.com/SFML/SFML/pull/1389#discussion_r177250378","pull_request_url":"https://api.github.com/repos/SFML/SFML/pulls/1389","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SFML/SFML/pulls/comments/177250378"},"html":{"href":"https://github.com/SFML/SFML/pull/1389#discussion_r177250378"},"pull_request":{"href":"https://api.github.com/repos/SFML/SFML/pulls/1389"}}},"pull_request":{"url":"https://api.github.com/repos/SFML/SFML/pulls/1389","id":175541784,"html_url":"https://github.com/SFML/SFML/pull/1389","diff_url":"https://github.com/SFML/SFML/pull/1389.diff","patch_url":"https://github.com/SFML/SFML/pull/1389.patch","issue_url":"https://api.github.com/repos/SFML/SFML/issues/1389","number":1389,"state":"open","locked":false,"title":"Updated the changelog for 2.5","user":{"login":"Foaly","id":1014762,"avatar_url":"https://avatars1.githubusercontent.com/u/1014762?v=4","gravatar_id":"","url":"https://api.github.com/users/Foaly","html_url":"https://github.com/Foaly","followers_url":"https://api.github.com/users/Foaly/followers","following_url":"https://api.github.com/users/Foaly/following{/other_user}","gists_url":"https://api.github.com/users/Foaly/gists{/gist_id}","starred_url":"https://api.github.com/users/Foaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foaly/subscriptions","organizations_url":"https://api.github.com/users/Foaly/orgs","repos_url":"https://api.github.com/users/Foaly/repos","events_url":"https://api.github.com/users/Foaly/events{/privacy}","received_events_url":"https://api.github.com/users/Foaly/received_events","type":"User","site_admin":false},"body":"I've went through the commit history and updated the changelog up to the commit 8b7a50a914d4986477081e6f94b676e6089180dd.\r\n\r\n@eXpl0it3r I don't know what your criteria was in the past for including or skipping a commit. I descided to try to keep the changelog complete and include everything. I grouped smaller commits into one entry. But I suppose if the changelog is to long there is room to shorten it further.\r\n\r\nThe general block in the beginning turned mostly into a `Build` block, so maybe we should rename it as such or make a new section. What do you think?\r\n\r\nReviews or comments welcome 🙂 \r\n\r\nPS: I would keep this open until we do a commit freeze, then update this to the latest commit and then merge. ","created_at":"2018-03-16T14:03:35Z","updated_at":"2018-03-26T22:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada590fddeb1ac75d0e5cf6392a991c8651262da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":85850,"url":"https://api.github.com/repos/SFML/SFML/labels/feature","name":"feature","color":"23BA35","default":false},{"id":100611,"url":"https://api.github.com/repos/SFML/SFML/labels/m:doc","name":"m:doc","color":"cccccc","default":false},{"id":87275,"url":"https://api.github.com/repos/SFML/SFML/labels/s:undecided","name":"s:undecided","color":"ffe20a","default":false}],"milestone":{"url":"https://api.github.com/repos/SFML/SFML/milestones/14","html_url":"https://github.com/SFML/SFML/milestone/14","labels_url":"https://api.github.com/repos/SFML/SFML/milestones/14/labels","id":1753890,"number":14,"title":"2.5","description":"","creator":{"login":"binary1248","id":949359,"avatar_url":"https://avatars1.githubusercontent.com/u/949359?v=4","gravatar_id":"","url":"https://api.github.com/users/binary1248","html_url":"https://github.com/binary1248","followers_url":"https://api.github.com/users/binary1248/followers","following_url":"https://api.github.com/users/binary1248/following{/other_user}","gists_url":"https://api.github.com/users/binary1248/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1248/subscriptions","organizations_url":"https://api.github.com/users/binary1248/orgs","repos_url":"https://api.github.com/users/binary1248/repos","events_url":"https://api.github.com/users/binary1248/events{/privacy}","received_events_url":"https://api.github.com/users/binary1248/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":124,"state":"open","created_at":"2016-05-08T20:51:56Z","updated_at":"2018-03-26T22:05:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SFML/SFML/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/SFML/SFML/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/SFML/SFML/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SFML/SFML/issues/1389/comments","statuses_url":"https://api.github.com/repos/SFML/SFML/statuses/05d03fdd6ba7219f5dc3c865e272ab6ae43087eb","head":{"label":"Foaly:feature/2.5_changelog","ref":"feature/2.5_changelog","sha":"05d03fdd6ba7219f5dc3c865e272ab6ae43087eb","user":{"login":"Foaly","id":1014762,"avatar_url":"https://avatars1.githubusercontent.com/u/1014762?v=4","gravatar_id":"","url":"https://api.github.com/users/Foaly","html_url":"https://github.com/Foaly","followers_url":"https://api.github.com/users/Foaly/followers","following_url":"https://api.github.com/users/Foaly/following{/other_user}","gists_url":"https://api.github.com/users/Foaly/gists{/gist_id}","starred_url":"https://api.github.com/users/Foaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foaly/subscriptions","organizations_url":"https://api.github.com/users/Foaly/orgs","repos_url":"https://api.github.com/users/Foaly/repos","events_url":"https://api.github.com/users/Foaly/events{/privacy}","received_events_url":"https://api.github.com/users/Foaly/received_events","type":"User","site_admin":false},"repo":{"id":39458739,"name":"SFML","full_name":"Foaly/SFML","owner":{"login":"Foaly","id":1014762,"avatar_url":"https://avatars1.githubusercontent.com/u/1014762?v=4","gravatar_id":"","url":"https://api.github.com/users/Foaly","html_url":"https://github.com/Foaly","followers_url":"https://api.github.com/users/Foaly/followers","following_url":"https://api.github.com/users/Foaly/following{/other_user}","gists_url":"https://api.github.com/users/Foaly/gists{/gist_id}","starred_url":"https://api.github.com/users/Foaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foaly/subscriptions","organizations_url":"https://api.github.com/users/Foaly/orgs","repos_url":"https://api.github.com/users/Foaly/repos","events_url":"https://api.github.com/users/Foaly/events{/privacy}","received_events_url":"https://api.github.com/users/Foaly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Foaly/SFML","description":"Simple and Fast Multimedia Library","fork":true,"url":"https://api.github.com/repos/Foaly/SFML","forks_url":"https://api.github.com/repos/Foaly/SFML/forks","keys_url":"https://api.github.com/repos/Foaly/SFML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Foaly/SFML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Foaly/SFML/teams","hooks_url":"https://api.github.com/repos/Foaly/SFML/hooks","issue_events_url":"https://api.github.com/repos/Foaly/SFML/issues/events{/number}","events_url":"https://api.github.com/repos/Foaly/SFML/events","assignees_url":"https://api.github.com/repos/Foaly/SFML/assignees{/user}","branches_url":"https://api.github.com/repos/Foaly/SFML/branches{/branch}","tags_url":"https://api.github.com/repos/Foaly/SFML/tags","blobs_url":"https://api.github.com/repos/Foaly/SFML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Foaly/SFML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Foaly/SFML/git/refs{/sha}","trees_url":"https://api.github.com/repos/Foaly/SFML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Foaly/SFML/statuses/{sha}","languages_url":"https://api.github.com/repos/Foaly/SFML/languages","stargazers_url":"https://api.github.com/repos/Foaly/SFML/stargazers","contributors_url":"https://api.github.com/repos/Foaly/SFML/contributors","subscribers_url":"https://api.github.com/repos/Foaly/SFML/subscribers","subscription_url":"https://api.github.com/repos/Foaly/SFML/subscription","commits_url":"https://api.github.com/repos/Foaly/SFML/commits{/sha}","git_commits_url":"https://api.github.com/repos/Foaly/SFML/git/commits{/sha}","comments_url":"https://api.github.com/repos/Foaly/SFML/comments{/number}","issue_comment_url":"https://api.github.com/repos/Foaly/SFML/issues/comments{/number}","contents_url":"https://api.github.com/repos/Foaly/SFML/contents/{+path}","compare_url":"https://api.github.com/repos/Foaly/SFML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Foaly/SFML/merges","archive_url":"https://api.github.com/repos/Foaly/SFML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Foaly/SFML/downloads","issues_url":"https://api.github.com/repos/Foaly/SFML/issues{/number}","pulls_url":"https://api.github.com/repos/Foaly/SFML/pulls{/number}","milestones_url":"https://api.github.com/repos/Foaly/SFML/milestones{/number}","notifications_url":"https://api.github.com/repos/Foaly/SFML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Foaly/SFML/labels{/name}","releases_url":"https://api.github.com/repos/Foaly/SFML/releases{/id}","deployments_url":"https://api.github.com/repos/Foaly/SFML/deployments","created_at":"2015-07-21T17:04:42Z","updated_at":"2016-04-23T12:24:38Z","pushed_at":"2018-03-16T13:50:42Z","git_url":"git://github.com/Foaly/SFML.git","ssh_url":"git@github.com:Foaly/SFML.git","clone_url":"https://github.com/Foaly/SFML.git","svn_url":"https://github.com/Foaly/SFML","homepage":"http://www.sfml-dev.org/","size":85055,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SFML:master","ref":"master","sha":"8b7a50a914d4986477081e6f94b676e6089180dd","user":{"login":"SFML","id":4226899,"avatar_url":"https://avatars3.githubusercontent.com/u/4226899?v=4","gravatar_id":"","url":"https://api.github.com/users/SFML","html_url":"https://github.com/SFML","followers_url":"https://api.github.com/users/SFML/followers","following_url":"https://api.github.com/users/SFML/following{/other_user}","gists_url":"https://api.github.com/users/SFML/gists{/gist_id}","starred_url":"https://api.github.com/users/SFML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFML/subscriptions","organizations_url":"https://api.github.com/users/SFML/orgs","repos_url":"https://api.github.com/users/SFML/repos","events_url":"https://api.github.com/users/SFML/events{/privacy}","received_events_url":"https://api.github.com/users/SFML/received_events","type":"Organization","site_admin":false},"repo":{"id":1524684,"name":"SFML","full_name":"SFML/SFML","owner":{"login":"SFML","id":4226899,"avatar_url":"https://avatars3.githubusercontent.com/u/4226899?v=4","gravatar_id":"","url":"https://api.github.com/users/SFML","html_url":"https://github.com/SFML","followers_url":"https://api.github.com/users/SFML/followers","following_url":"https://api.github.com/users/SFML/following{/other_user}","gists_url":"https://api.github.com/users/SFML/gists{/gist_id}","starred_url":"https://api.github.com/users/SFML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFML/subscriptions","organizations_url":"https://api.github.com/users/SFML/orgs","repos_url":"https://api.github.com/users/SFML/repos","events_url":"https://api.github.com/users/SFML/events{/privacy}","received_events_url":"https://api.github.com/users/SFML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SFML/SFML","description":"Simple and Fast Multimedia Library","fork":false,"url":"https://api.github.com/repos/SFML/SFML","forks_url":"https://api.github.com/repos/SFML/SFML/forks","keys_url":"https://api.github.com/repos/SFML/SFML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SFML/SFML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SFML/SFML/teams","hooks_url":"https://api.github.com/repos/SFML/SFML/hooks","issue_events_url":"https://api.github.com/repos/SFML/SFML/issues/events{/number}","events_url":"https://api.github.com/repos/SFML/SFML/events","assignees_url":"https://api.github.com/repos/SFML/SFML/assignees{/user}","branches_url":"https://api.github.com/repos/SFML/SFML/branches{/branch}","tags_url":"https://api.github.com/repos/SFML/SFML/tags","blobs_url":"https://api.github.com/repos/SFML/SFML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SFML/SFML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SFML/SFML/git/refs{/sha}","trees_url":"https://api.github.com/repos/SFML/SFML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SFML/SFML/statuses/{sha}","languages_url":"https://api.github.com/repos/SFML/SFML/languages","stargazers_url":"https://api.github.com/repos/SFML/SFML/stargazers","contributors_url":"https://api.github.com/repos/SFML/SFML/contributors","subscribers_url":"https://api.github.com/repos/SFML/SFML/subscribers","subscription_url":"https://api.github.com/repos/SFML/SFML/subscription","commits_url":"https://api.github.com/repos/SFML/SFML/commits{/sha}","git_commits_url":"https://api.github.com/repos/SFML/SFML/git/commits{/sha}","comments_url":"https://api.github.com/repos/SFML/SFML/comments{/number}","issue_comment_url":"https://api.github.com/repos/SFML/SFML/issues/comments{/number}","contents_url":"https://api.github.com/repos/SFML/SFML/contents/{+path}","compare_url":"https://api.github.com/repos/SFML/SFML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SFML/SFML/merges","archive_url":"https://api.github.com/repos/SFML/SFML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SFML/SFML/downloads","issues_url":"https://api.github.com/repos/SFML/SFML/issues{/number}","pulls_url":"https://api.github.com/repos/SFML/SFML/pulls{/number}","milestones_url":"https://api.github.com/repos/SFML/SFML/milestones{/number}","notifications_url":"https://api.github.com/repos/SFML/SFML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SFML/SFML/labels{/name}","releases_url":"https://api.github.com/repos/SFML/SFML/releases{/id}","deployments_url":"https://api.github.com/repos/SFML/SFML/deployments","created_at":"2011-03-25T08:05:25Z","updated_at":"2018-03-26T22:04:17Z","pushed_at":"2018-03-26T22:04:11Z","git_url":"git://github.com/SFML/SFML.git","ssh_url":"git@github.com:SFML/SFML.git","clone_url":"https://github.com/SFML/SFML.git","svn_url":"https://github.com/SFML/SFML","homepage":"http://www.sfml-dev.org/","size":86921,"stargazers_count":4156,"watchers_count":4156,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":906,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":906,"open_issues":101,"watchers":4156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SFML/SFML/pulls/1389"},"html":{"href":"https://github.com/SFML/SFML/pull/1389"},"issue":{"href":"https://api.github.com/repos/SFML/SFML/issues/1389"},"comments":{"href":"https://api.github.com/repos/SFML/SFML/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/SFML/SFML/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/SFML/SFML/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SFML/SFML/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/SFML/SFML/statuses/05d03fdd6ba7219f5dc3c865e272ab6ae43087eb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eXpl0it3r"}}