{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/241115269","pull_request_review_id":184306484,"id":241115269,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTExNTI2OQ==","diff_hunk":"@@ -371,8 +371,8 @@ public function renderForm()\n \n     public function processSave()\n     {\n-        $search = strval(Tools::getValue('search'));\n-        $string = strval(Tools::getValue('alias'));\n+        $search = (string) (Tools::getValue('search'));\n+        $string = (string) (Tools::getValue('alias'));","path":"controllers/admin/AdminSearchConfController.php","position":7,"original_position":7,"commit_id":"d611c19875de8add8a9a397b660d437c1b2741fa","original_commit_id":"d611c19875de8add8a9a397b660d437c1b2741fa","user":{"login":"Quetzacoalt91","id":6768917,"node_id":"MDQ6VXNlcjY3Njg5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6768917?v=4","gravatar_id":"","url":"https://api.github.com/users/Quetzacoalt91","html_url":"https://github.com/Quetzacoalt91","followers_url":"https://api.github.com/users/Quetzacoalt91/followers","following_url":"https://api.github.com/users/Quetzacoalt91/following{/other_user}","gists_url":"https://api.github.com/users/Quetzacoalt91/gists{/gist_id}","starred_url":"https://api.github.com/users/Quetzacoalt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quetzacoalt91/subscriptions","organizations_url":"https://api.github.com/users/Quetzacoalt91/orgs","repos_url":"https://api.github.com/users/Quetzacoalt91/repos","events_url":"https://api.github.com/users/Quetzacoalt91/events{/privacy}","received_events_url":"https://api.github.com/users/Quetzacoalt91/received_events","type":"User","site_admin":false},"body":"This is also true is another places of this PR, some parentheses can be safely removed.\r\n```suggestion\r\n        $string = (string) Tools::getValue('alias');\r\n```","created_at":"2018-12-12T17:40:19Z","updated_at":"2018-12-12T17:40:19Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11708#discussion_r241115269","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/241115269"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/11708#discussion_r241115269"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708","id":237650589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjUwNTg5","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11708","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/11708.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/11708.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11708","number":11708,"state":"open","locked":false,"title":"Modernize types casting","user":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | /\r\n| Type?         | improvement\r\n| Category?     | CO\r\n| BC breaks?    | Does it break backward compatibility? no\r\n| Deprecations? | Does it deprecate an existing feature? no\r\n| Fixed ticket? | /\r\n| How to test?  | /\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/11708)\n<!-- Reviewable:end -->\n","created_at":"2018-12-11T11:52:17Z","updated_at":"2018-12-12T17:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8170a1929771a584be8755a53fd878f5999da1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":19737371,"node_id":"MDU6TGFiZWwxOTczNzM3MQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Improvement","name":"Improvement","color":"d4c5f9","default":false},{"id":1126077824,"node_id":"MDU6TGFiZWwxMTI2MDc3ODI0","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Wording%20%E2%9C%94%EF%B8%8F","name":"Wording ✔️","color":"b8ed50","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11708/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/d611c19875de8add8a9a397b660d437c1b2741fa","head":{"label":"MathiasReker:p16","ref":"p16","sha":"d611c19875de8add8a9a397b660d437c1b2741fa","user":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"repo":{"id":141559329,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NTkzMjk=","name":"PrestaShop-1","full_name":"MathiasReker/PrestaShop-1","private":false,"owner":{"login":"MathiasReker","id":26626066,"node_id":"MDQ6VXNlcjI2NjI2MDY2","avatar_url":"https://avatars3.githubusercontent.com/u/26626066?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasReker","html_url":"https://github.com/MathiasReker","followers_url":"https://api.github.com/users/MathiasReker/followers","following_url":"https://api.github.com/users/MathiasReker/following{/other_user}","gists_url":"https://api.github.com/users/MathiasReker/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasReker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasReker/subscriptions","organizations_url":"https://api.github.com/users/MathiasReker/orgs","repos_url":"https://api.github.com/users/MathiasReker/repos","events_url":"https://api.github.com/users/MathiasReker/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasReker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MathiasReker/PrestaShop-1","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":true,"url":"https://api.github.com/repos/MathiasReker/PrestaShop-1","forks_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/forks","keys_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/teams","hooks_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/hooks","issue_events_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues/events{/number}","events_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/events","assignees_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/assignees{/user}","branches_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/branches{/branch}","tags_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/tags","blobs_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/statuses/{sha}","languages_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/languages","stargazers_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/stargazers","contributors_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/contributors","subscribers_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/subscribers","subscription_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/subscription","commits_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/contents/{+path}","compare_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/merges","archive_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/downloads","issues_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/issues{/number}","pulls_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/pulls{/number}","milestones_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/milestones{/number}","notifications_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/labels{/name}","releases_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/releases{/id}","deployments_url":"https://api.github.com/repos/MathiasReker/PrestaShop-1/deployments","created_at":"2018-07-19T09:50:59Z","updated_at":"2018-12-11T08:32:24Z","pushed_at":"2018-12-12T16:10:46Z","git_url":"git://github.com/MathiasReker/PrestaShop-1.git","ssh_url":"git@github.com:MathiasReker/PrestaShop-1.git","clone_url":"https://github.com/MathiasReker/PrestaShop-1.git","svn_url":"https://github.com/MathiasReker/PrestaShop-1","homepage":"http://www.prestashop.com/","size":361571,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"1ce076c247771ad9765fda87843cfdc04defe85d","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-12-12T17:28:36Z","pushed_at":"2018-12-12T17:34:46Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":393380,"stargazers_count":3333,"watchers_count":3333,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3001,"mirror_url":null,"archived":false,"open_issues_count":1264,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3001,"open_issues":1264,"watchers":3333,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/11708"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11708"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11708/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11708/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/d611c19875de8add8a9a397b660d437c1b2741fa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Quetzacoalt91"}}