{"action":"created","issue":{"url":"https://api.github.com/repos/askmike/gekko/issues/1834","repository_url":"https://api.github.com/repos/askmike/gekko","labels_url":"https://api.github.com/repos/askmike/gekko/issues/1834/labels{/name}","comments_url":"https://api.github.com/repos/askmike/gekko/issues/1834/comments","events_url":"https://api.github.com/repos/askmike/gekko/issues/1834/events","html_url":"https://github.com/askmike/gekko/pull/1834","id":293373859,"number":1834,"title":"Limit Trading Feature","user":{"login":"Ali1","id":218558,"avatar_url":"https://avatars1.githubusercontent.com/u/218558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ali1","html_url":"https://github.com/Ali1","followers_url":"https://api.github.com/users/Ali1/followers","following_url":"https://api.github.com/users/Ali1/following{/other_user}","gists_url":"https://api.github.com/users/Ali1/gists{/gist_id}","starred_url":"https://api.github.com/users/Ali1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ali1/subscriptions","organizations_url":"https://api.github.com/users/Ali1/orgs","repos_url":"https://api.github.com/users/Ali1/repos","events_url":"https://api.github.com/users/Ali1/events{/privacy}","received_events_url":"https://api.github.com/users/Ali1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-02-01T01:37:43Z","updated_at":"2018-02-19T08:58:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/askmike/gekko/pulls/1834","html_url":"https://github.com/askmike/gekko/pull/1834","diff_url":"https://github.com/askmike/gekko/pull/1834.diff","patch_url":"https://github.com/askmike/gekko/pull/1834.patch"},"body":"* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nFeature\r\n\r\n* **What is the new behavior (if this is a feature change)?\r\nPossibility to configure the maximum amount of fiat currency available to gekko to trade with.\r\nFor example if you have 1 BTC and 100 USD in an exchange account which gekko is performing BTC/USD trading on, you can set currencyAmountAvailableToTrade in your config file to something like 50 USD. If a buy comes in, only 50 USD is used and further buys are prevented. If sells occur, all USD proceeds get added to the available tradable balance ready for the next BUY order. In this way, the other 50 USD of your exchange balance remains untouched.\r\n\r\nI don't use the web version and haven't looked into it's code so it is not compatible with it.\r\n\r\n* **Other information**:\r\nCleaned up and resolved conflicts of PR #1492 "},"comment":{"url":"https://api.github.com/repos/askmike/gekko/issues/comments/366625275","html_url":"https://github.com/askmike/gekko/pull/1834#issuecomment-366625275","issue_url":"https://api.github.com/repos/askmike/gekko/issues/1834","id":366625275,"user":{"login":"ansonphong","id":4825055,"avatar_url":"https://avatars0.githubusercontent.com/u/4825055?v=4","gravatar_id":"","url":"https://api.github.com/users/ansonphong","html_url":"https://github.com/ansonphong","followers_url":"https://api.github.com/users/ansonphong/followers","following_url":"https://api.github.com/users/ansonphong/following{/other_user}","gists_url":"https://api.github.com/users/ansonphong/gists{/gist_id}","starred_url":"https://api.github.com/users/ansonphong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansonphong/subscriptions","organizations_url":"https://api.github.com/users/ansonphong/orgs","repos_url":"https://api.github.com/users/ansonphong/repos","events_url":"https://api.github.com/users/ansonphong/events{/privacy}","received_events_url":"https://api.github.com/users/ansonphong/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T08:58:46Z","updated_at":"2018-02-19T08:58:46Z","author_association":"CONTRIBUTOR","body":"@Ali1 Yes, `let` is the generally preferred way to scope variables in ES6. So let is for defining scoped variables, not object properties. It is generally a replacement for `var`, which orders definitions linearly, otherwise it is similar. For instance, you would use `let` when defining any variable in any scope, in place of `var`.\r\n"}}
{"actor":{"display_login":"ansonphong"}}