{"action":"created","comment":{"url":"https://api.github.com/repos/exodev/wiki/pulls/comments/210245182","pull_request_review_id":146417366,"id":210245182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI0NTE4Mg==","diff_hunk":"@@ -108,6 +108,7 @@ public static String escapeIllegalCharacterInName(String name) {\n       for (char c : ILLEGAL_NAME_CHARACTERS.toCharArray())\r\n         name = name.replace(c, '_');\r\n       name = name.replace(\"%20\", \"_\");\r\n+      name = name.replace(\"%22\", \"_\");\r","path":"wiki-service/src/main/java/org/exoplatform/wiki/utils/Utils.java","position":13,"original_position":13,"commit_id":"97aaa553c0ecf73bad90d0edad254998ac136774","original_commit_id":"97aaa553c0ecf73bad90d0edad254998ac136774","user":{"login":"trongtt","id":515969,"node_id":"MDQ6VXNlcjUxNTk2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/515969?v=4","gravatar_id":"","url":"https://api.github.com/users/trongtt","html_url":"https://github.com/trongtt","followers_url":"https://api.github.com/users/trongtt/followers","following_url":"https://api.github.com/users/trongtt/following{/other_user}","gists_url":"https://api.github.com/users/trongtt/gists{/gist_id}","starred_url":"https://api.github.com/users/trongtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trongtt/subscriptions","organizations_url":"https://api.github.com/users/trongtt/orgs","repos_url":"https://api.github.com/users/trongtt/repos","events_url":"https://api.github.com/users/trongtt/events{/privacy}","received_events_url":"https://api.github.com/users/trongtt/received_events","type":"User","site_admin":false},"body":"we do that for double quote only as the file upload is URL encoding it in filename in Chrome (refer https://bugs.chromium.org/p/chromium/issues/detail?id=81193)\r\n\r\nI just realized that the double quote in filename is still buggy in Firefox. In Firefox, a \" is escaped to \\\\\" which also cause the error message.\r\n\r\nI will take time to investigate more about the issue and try to improve this part.","created_at":"2018-08-15T11:56:13Z","updated_at":"2018-08-15T11:56:13Z","html_url":"https://github.com/exodev/wiki/pull/169#discussion_r210245182","pull_request_url":"https://api.github.com/repos/exodev/wiki/pulls/169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exodev/wiki/pulls/comments/210245182"},"html":{"href":"https://github.com/exodev/wiki/pull/169#discussion_r210245182"},"pull_request":{"href":"https://api.github.com/repos/exodev/wiki/pulls/169"}},"in_reply_to_id":209861263},"pull_request":{"url":"https://api.github.com/repos/exodev/wiki/pulls/169","id":204392519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzkyNTE5","html_url":"https://github.com/exodev/wiki/pull/169","diff_url":"https://github.com/exodev/wiki/pull/169.diff","patch_url":"https://github.com/exodev/wiki/pull/169.patch","issue_url":"https://api.github.com/repos/exodev/wiki/issues/169","number":169,"state":"open","locked":false,"title":"WIKI-1397 fix the problem with special characters in attachment name","user":{"login":"trongtt","id":515969,"node_id":"MDQ6VXNlcjUxNTk2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/515969?v=4","gravatar_id":"","url":"https://api.github.com/users/trongtt","html_url":"https://github.com/trongtt","followers_url":"https://api.github.com/users/trongtt/followers","following_url":"https://api.github.com/users/trongtt/following{/other_user}","gists_url":"https://api.github.com/users/trongtt/gists{/gist_id}","starred_url":"https://api.github.com/users/trongtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trongtt/subscriptions","organizations_url":"https://api.github.com/users/trongtt/orgs","repos_url":"https://api.github.com/users/trongtt/repos","events_url":"https://api.github.com/users/trongtt/events{/privacy}","received_events_url":"https://api.github.com/users/trongtt/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-27T10:28:42Z","updated_at":"2018-08-15T11:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c53ce826adc28494252e18a76f7ff9c4cc083eb6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exodev/wiki/pulls/169/commits","review_comments_url":"https://api.github.com/repos/exodev/wiki/pulls/169/comments","review_comment_url":"https://api.github.com/repos/exodev/wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exodev/wiki/issues/169/comments","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/97aaa553c0ecf73bad90d0edad254998ac136774","head":{"label":"exodev:fix/WIKI-1397","ref":"fix/WIKI-1397","sha":"97aaa553c0ecf73bad90d0edad254998ac136774","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4126238,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI2MjM4","name":"wiki","full_name":"exodev/wiki","owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exodev/wiki","description":"eXo Wiki","fork":true,"url":"https://api.github.com/repos/exodev/wiki","forks_url":"https://api.github.com/repos/exodev/wiki/forks","keys_url":"https://api.github.com/repos/exodev/wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/wiki/teams","hooks_url":"https://api.github.com/repos/exodev/wiki/hooks","issue_events_url":"https://api.github.com/repos/exodev/wiki/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/wiki/events","assignees_url":"https://api.github.com/repos/exodev/wiki/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/wiki/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/wiki/tags","blobs_url":"https://api.github.com/repos/exodev/wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/wiki/languages","stargazers_url":"https://api.github.com/repos/exodev/wiki/stargazers","contributors_url":"https://api.github.com/repos/exodev/wiki/contributors","subscribers_url":"https://api.github.com/repos/exodev/wiki/subscribers","subscription_url":"https://api.github.com/repos/exodev/wiki/subscription","commits_url":"https://api.github.com/repos/exodev/wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/wiki/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/wiki/merges","archive_url":"https://api.github.com/repos/exodev/wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/wiki/downloads","issues_url":"https://api.github.com/repos/exodev/wiki/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/wiki/labels{/name}","releases_url":"https://api.github.com/repos/exodev/wiki/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/wiki/deployments","created_at":"2012-04-24T15:28:02Z","updated_at":"2018-08-02T03:42:07Z","pushed_at":"2018-08-15T09:38:56Z","git_url":"git://github.com/exodev/wiki.git","ssh_url":"git@github.com:exodev/wiki.git","clone_url":"https://github.com/exodev/wiki.git","svn_url":"https://github.com/exodev/wiki","homepage":"","size":51913,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5,"open_issues":18,"watchers":1,"default_branch":"develop"}},"base":{"label":"exodev:develop","ref":"develop","sha":"e8cedad73d5be92607c3b3b6173f9766962ab151","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4126238,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI2MjM4","name":"wiki","full_name":"exodev/wiki","owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exodev/wiki","description":"eXo Wiki","fork":true,"url":"https://api.github.com/repos/exodev/wiki","forks_url":"https://api.github.com/repos/exodev/wiki/forks","keys_url":"https://api.github.com/repos/exodev/wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/wiki/teams","hooks_url":"https://api.github.com/repos/exodev/wiki/hooks","issue_events_url":"https://api.github.com/repos/exodev/wiki/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/wiki/events","assignees_url":"https://api.github.com/repos/exodev/wiki/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/wiki/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/wiki/tags","blobs_url":"https://api.github.com/repos/exodev/wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/wiki/languages","stargazers_url":"https://api.github.com/repos/exodev/wiki/stargazers","contributors_url":"https://api.github.com/repos/exodev/wiki/contributors","subscribers_url":"https://api.github.com/repos/exodev/wiki/subscribers","subscription_url":"https://api.github.com/repos/exodev/wiki/subscription","commits_url":"https://api.github.com/repos/exodev/wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/wiki/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/wiki/merges","archive_url":"https://api.github.com/repos/exodev/wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/wiki/downloads","issues_url":"https://api.github.com/repos/exodev/wiki/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/wiki/labels{/name}","releases_url":"https://api.github.com/repos/exodev/wiki/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/wiki/deployments","created_at":"2012-04-24T15:28:02Z","updated_at":"2018-08-02T03:42:07Z","pushed_at":"2018-08-15T09:38:56Z","git_url":"git://github.com/exodev/wiki.git","ssh_url":"git@github.com:exodev/wiki.git","clone_url":"https://github.com/exodev/wiki.git","svn_url":"https://github.com/exodev/wiki","homepage":"","size":51913,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5,"open_issues":18,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exodev/wiki/pulls/169"},"html":{"href":"https://github.com/exodev/wiki/pull/169"},"issue":{"href":"https://api.github.com/repos/exodev/wiki/issues/169"},"comments":{"href":"https://api.github.com/repos/exodev/wiki/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/exodev/wiki/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/exodev/wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exodev/wiki/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/exodev/wiki/statuses/97aaa553c0ecf73bad90d0edad254998ac136774"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"trongtt"}}