{"action":"created","issue":{"url":"https://api.github.com/repos/ElementsProject/lightning/issues/847","repository_url":"https://api.github.com/repos/ElementsProject/lightning","labels_url":"https://api.github.com/repos/ElementsProject/lightning/issues/847/labels{/name}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/847/comments","events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/847/events","html_url":"https://github.com/ElementsProject/lightning/pull/847","id":292708850,"number":847,"title":"Shutdown fixes","user":{"login":"rustyrussell","id":775844,"avatar_url":"https://avatars2.githubusercontent.com/u/775844?v=4","gravatar_id":"","url":"https://api.github.com/users/rustyrussell","html_url":"https://github.com/rustyrussell","followers_url":"https://api.github.com/users/rustyrussell/followers","following_url":"https://api.github.com/users/rustyrussell/following{/other_user}","gists_url":"https://api.github.com/users/rustyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrussell/subscriptions","organizations_url":"https://api.github.com/users/rustyrussell/orgs","repos_url":"https://api.github.com/users/rustyrussell/repos","events_url":"https://api.github.com/users/rustyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrussell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-30T09:26:50Z","updated_at":"2018-02-01T15:19:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/847","html_url":"https://github.com/ElementsProject/lightning/pull/847","diff_url":"https://github.com/ElementsProject/lightning/pull/847.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/847.patch"},"body":"Builds on #841 \r\n\r\nThis is basically a rewrite of closingd to do negotiation properly.  Doing so revealed a spec bug, so I've created a patch for that too, and assumed it's going to be accepted.  If not, we don't really care; by default we just don't enforce sane negotiation anyway."},"comment":{"url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments/362297761","html_url":"https://github.com/ElementsProject/lightning/pull/847#issuecomment-362297761","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/847","id":362297761,"user":{"login":"cdecker","id":120117,"avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T15:19:29Z","updated_at":"2018-02-01T15:19:29Z","author_association":"MEMBER","body":"Has some `valgrind` errors:\r\n\r\n```\r\n------------------------------- Valgrind errors --------------------------------\r\nValgrind error file: valgrind-errors.5732\r\n==5732== Invalid read of size 8\r\n==5732==    at 0x4149FD: remove_cmd_from_hout (pay.c:292)\r\n==5732==    by 0x468BAB: notify (tal.c:237)\r\n==5732==    by 0x469077: del_tree (tal.c:400)\r\n==5732==    by 0x4690C7: del_tree (tal.c:410)\r\n==5732==    by 0x46948A: tal_free (tal.c:509)\r\n==5732==    by 0x40F1EA: main (lightningd.c:362)\r\n==5732==  Address 0x69df148 is 1,512 bytes inside a block of size 1,544 free'd\r\n==5732==    at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==5732==    by 0x469150: del_tree (tal.c:421)\r\n==5732==    by 0x46948A: tal_free (tal.c:509)\r\n==5732==    by 0x4198F2: free_htlcs (peer_control.c:1281)\r\n==5732==    by 0x40EBA9: shutdown_subdaemons (lightningd.c:209)\r\n==5732==    by 0x40F1DE: main (lightningd.c:360)\r\n==5732==  Block was alloc'd at\r\n==5732==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==5732==    by 0x468C30: allocate (tal.c:250)\r\n==5732==    by 0x4691F7: tal_alloc_ (tal.c:448)\r\n==5732==    by 0x40A279: new_htlc_out (htlc_end.c:143)\r\n==5732==    by 0x41FD64: send_htlc_out (peer_htlcs.c:397)\r\n==5732==    by 0x41511C: send_payment (pay.c:388)\r\n==5732==    by 0x41589E: json_sendpay (pay.c:513)\r\n==5732==    by 0x40D9B1: parse_request (jsonrpc.c:600)\r\n==5732==    by 0x40DCAC: read_json (jsonrpc.c:667)\r\n==5732==    by 0x45C706: next_plan (io.c:59)\r\n==5732==    by 0x45D1DD: do_plan (io.c:387)\r\n==5732==    by 0x45D21B: io_ready (io.c:397)\r\n==5732== \r\n==5732== Invalid write of size 8\r\n==5732==    at 0x414A27: remove_cmd_from_hout (pay.c:293)\r\n==5732==    by 0x468BAB: notify (tal.c:237)\r\n==5732==    by 0x469077: del_tree (tal.c:400)\r\n==5732==    by 0x4690C7: del_tree (tal.c:410)\r\n==5732==    by 0x46948A: tal_free (tal.c:509)\r\n==5732==    by 0x40F1EA: main (lightningd.c:362)\r\n==5732==  Address 0x69df148 is 1,512 bytes inside a block of size 1,544 free'd\r\n==5732==    at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==5732==    by 0x469150: del_tree (tal.c:421)\r\n==5732==    by 0x46948A: tal_free (tal.c:509)\r\n==5732==    by 0x4198F2: free_htlcs (peer_control.c:1281)\r\n==5732==    by 0x40EBA9: shutdown_subdaemons (lightningd.c:209)\r\n==5732==    by 0x40F1DE: main (lightningd.c:360)\r\n==5732==  Block was alloc'd at\r\n==5732==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==5732==    by 0x468C30: allocate (tal.c:250)\r\n==5732==    by 0x4691F7: tal_alloc_ (tal.c:448)\r\n==5732==    by 0x40A279: new_htlc_out (htlc_end.c:143)\r\n==5732==    by 0x41FD64: send_htlc_out (peer_htlcs.c:397)\r\n==5732==    by 0x41511C: send_payment (pay.c:388)\r\n==5732==    by 0x41589E: json_sendpay (pay.c:513)\r\n==5732==    by 0x40D9B1: parse_request (jsonrpc.c:600)\r\n==5732==    by 0x40DCAC: read_json (jsonrpc.c:667)\r\n==5732==    by 0x45C706: next_plan (io.c:59)\r\n==5732==    by 0x45D1DD: do_plan (io.c:387)\r\n==5732==    by 0x45D21B: io_ready (io.c:397)\r\n==5732==\r\n```\r\n\r\nThis is `test_closing_different_fees`, the failing node is `l1` with port `16331`."}}
{"actor":{"display_login":"cdecker"}}