{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/comments/214197036","pull_request_review_id":151202051,"id":214197036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE5NzAzNg==","diff_hunk":"@@ -105,6 +105,10 @@\n       [dir=rtl] & {\n         box-shadow: var(--terra-time-input-focus-keyboard-box-shadow-rtl, 0 0 8px #a6d9f4);\n       }\n+\n+      &::placeholder {\n+        font-style: var(--terra-form-input-placeholder-font-style, italic);","path":"packages/terra-time-input/src/TimeInput.module.scss","position":15,"original_position":15,"commit_id":"1bdefd7a2f637a77838c4504b917c51e82bfa0de","original_commit_id":"1bdefd7a2f637a77838c4504b917c51e82bfa0de","user":{"login":"neilpfeiffer","id":1355485,"node_id":"MDQ6VXNlcjEzNTU0ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1355485?v=4","gravatar_id":"","url":"https://api.github.com/users/neilpfeiffer","html_url":"https://github.com/neilpfeiffer","followers_url":"https://api.github.com/users/neilpfeiffer/followers","following_url":"https://api.github.com/users/neilpfeiffer/following{/other_user}","gists_url":"https://api.github.com/users/neilpfeiffer/gists{/gist_id}","starred_url":"https://api.github.com/users/neilpfeiffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilpfeiffer/subscriptions","organizations_url":"https://api.github.com/users/neilpfeiffer/orgs","repos_url":"https://api.github.com/users/neilpfeiffer/repos","events_url":"https://api.github.com/users/neilpfeiffer/events{/privacy}","received_events_url":"https://api.github.com/users/neilpfeiffer/received_events","type":"User","site_admin":false},"body":"2 problems to fix with this one: \r\n- this is in the incorrect spot, need to move up and insert above the `&:focus` block at line 96, rather than being nested inside of it. \r\n- fix the theming variable names, add color, and remove the italic value for font-style:\r\n```\r\n&::placeholder {\r\n      color: var(--terra-time-input-placeholder-color, #70787c);\r\n      font-style: var(--terra-time-input-placeholder-font-style);\r\n    }\r\n```","created_at":"2018-08-30T22:13:39Z","updated_at":"2018-08-30T22:13:40Z","html_url":"https://github.com/cerner/terra-core/pull/1794#discussion_r214197036","pull_request_url":"https://api.github.com/repos/cerner/terra-core/pulls/1794","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments/214197036"},"html":{"href":"https://github.com/cerner/terra-core/pull/1794#discussion_r214197036"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/1794"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/1794","id":211138120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTM4MTIw","html_url":"https://github.com/cerner/terra-core/pull/1794","diff_url":"https://github.com/cerner/terra-core/pull/1794.diff","patch_url":"https://github.com/cerner/terra-core/pull/1794.patch","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/1794","number":1794,"state":"open","locked":false,"title":"Placeholder styling and webdriver test updates","user":{"login":"amichaelparker","id":13922343,"node_id":"MDQ6VXNlcjEzOTIyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/13922343?v=4","gravatar_id":"","url":"https://api.github.com/users/amichaelparker","html_url":"https://github.com/amichaelparker","followers_url":"https://api.github.com/users/amichaelparker/followers","following_url":"https://api.github.com/users/amichaelparker/following{/other_user}","gists_url":"https://api.github.com/users/amichaelparker/gists{/gist_id}","starred_url":"https://api.github.com/users/amichaelparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amichaelparker/subscriptions","organizations_url":"https://api.github.com/users/amichaelparker/orgs","repos_url":"https://api.github.com/users/amichaelparker/repos","events_url":"https://api.github.com/users/amichaelparker/events{/privacy}","received_events_url":"https://api.github.com/users/amichaelparker/received_events","type":"User","site_admin":false},"body":"Updated placeholder styling to make it theme-able, with accompanying webdriver test updates.\r\n\r\n[#1710](https://github.com/cerner/terra-core/issues/1710)\r\n\r\n","created_at":"2018-08-27T15:03:46Z","updated_at":"2018-08-30T22:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d3d29a9dd319c05a40c225de998a919853b1b9f","assignee":{"login":"amichaelparker","id":13922343,"node_id":"MDQ6VXNlcjEzOTIyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/13922343?v=4","gravatar_id":"","url":"https://api.github.com/users/amichaelparker","html_url":"https://github.com/amichaelparker","followers_url":"https://api.github.com/users/amichaelparker/followers","following_url":"https://api.github.com/users/amichaelparker/following{/other_user}","gists_url":"https://api.github.com/users/amichaelparker/gists{/gist_id}","starred_url":"https://api.github.com/users/amichaelparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amichaelparker/subscriptions","organizations_url":"https://api.github.com/users/amichaelparker/orgs","repos_url":"https://api.github.com/users/amichaelparker/repos","events_url":"https://api.github.com/users/amichaelparker/events{/privacy}","received_events_url":"https://api.github.com/users/amichaelparker/received_events","type":"User","site_admin":false},"assignees":[{"login":"amichaelparker","id":13922343,"node_id":"MDQ6VXNlcjEzOTIyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/13922343?v=4","gravatar_id":"","url":"https://api.github.com/users/amichaelparker","html_url":"https://github.com/amichaelparker","followers_url":"https://api.github.com/users/amichaelparker/followers","following_url":"https://api.github.com/users/amichaelparker/following{/other_user}","gists_url":"https://api.github.com/users/amichaelparker/gists{/gist_id}","starred_url":"https://api.github.com/users/amichaelparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amichaelparker/subscriptions","organizations_url":"https://api.github.com/users/amichaelparker/orgs","repos_url":"https://api.github.com/users/amichaelparker/repos","events_url":"https://api.github.com/users/amichaelparker/events{/privacy}","received_events_url":"https://api.github.com/users/amichaelparker/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},{"login":"JakeLaCombe","id":2552573,"node_id":"MDQ6VXNlcjI1NTI1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2552573?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeLaCombe","html_url":"https://github.com/JakeLaCombe","followers_url":"https://api.github.com/users/JakeLaCombe/followers","following_url":"https://api.github.com/users/JakeLaCombe/following{/other_user}","gists_url":"https://api.github.com/users/JakeLaCombe/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLaCombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLaCombe/subscriptions","organizations_url":"https://api.github.com/users/JakeLaCombe/orgs","repos_url":"https://api.github.com/users/JakeLaCombe/repos","events_url":"https://api.github.com/users/JakeLaCombe/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLaCombe/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":608219660,"node_id":"MDU6TGFiZWw2MDgyMTk2NjA=","url":"https://api.github.com/repos/cerner/terra-core/labels/Needs%20UX%20review","name":"Needs UX review","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-core/pulls/1794/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-core/pulls/1794/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/1794/comments","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/1bdefd7a2f637a77838c4504b917c51e82bfa0de","head":{"label":"cerner:placeholder-styling","ref":"placeholder-styling","sha":"1bdefd7a2f637a77838c4504b917c51e82bfa0de","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-08-30T20:56:52Z","pushed_at":"2018-08-30T22:00:18Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"git@github.com:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":47205,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":72,"open_issues":129,"watchers":102,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"7ae5e16ee615758ddff1aab32da16d80a4026adc","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MzE1Ng==","name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2018-08-30T20:56:52Z","pushed_at":"2018-08-30T22:00:18Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"git@github.com:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":47205,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":72,"open_issues":129,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/1794"},"html":{"href":"https://github.com/cerner/terra-core/pull/1794"},"issue":{"href":"https://api.github.com/repos/cerner/terra-core/issues/1794"},"comments":{"href":"https://api.github.com/repos/cerner/terra-core/issues/1794/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/1794/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/1794/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-core/statuses/1bdefd7a2f637a77838c4504b917c51e82bfa0de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"neilpfeiffer"}}