{"action":"created","comment":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/234041559","pull_request_review_id":175598212,"id":234041559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA0MTU1OQ==","diff_hunk":"@@ -298,277 +300,145 @@ const Vector3D Curl(const Vector3D &v) {\n /**************************************************************************\n  * Upwinding operators\n  **************************************************************************/\n-\n const Field2D V_dot_Grad(const Vector2D &v, const Field2D &f) {\n   TRACE(\"V_dot_Grad( Vector2D , Field2D )\");\n-\n+  SCOREP0();\n   Field2D result(f.getMesh());\n \n   // Get contravariant components of v\n-  Vector2D vcn = v;\n+  auto vcn = v;\n   vcn.toContravariant();\n-\n+  \n   result = VDDX(vcn.x, f) + VDDY(vcn.y, f) + VDDZ(vcn.z, f);\n \n   return result;\n }\n \n const Field3D V_dot_Grad(const Vector2D &v, const Field3D &f) {\n   TRACE(\"V_dot_Grad( Vector2D , Field3D )\");\n-\n+  SCOREP0();\n   Field3D result(f.getMesh());\n \n   // Get contravariant components of v\n-  Vector2D vcn = v;\n+  auto vcn = v;\n   vcn.toContravariant();\n-\n+  \n   result = VDDX(vcn.x, f) + VDDY(vcn.y, f) + VDDZ(vcn.z, f);\n \n   return result;\n }\n \n const Field3D V_dot_Grad(const Vector3D &v, const Field2D &f) {\n-  TRACE(\"V_dot_Grad( Vector3D , Field2D )\");\n-\n+  TRACE(\"V_dot_Grad( Vector3D , Field3D )\");","path":"src/field/vecops.cxx","position":123,"original_position":123,"commit_id":"cb702c3228d68293047cf7c7ee9d6837c9e9a093","original_commit_id":"cb702c3228d68293047cf7c7ee9d6837c9e9a093","user":{"login":"bendudson","id":219233,"node_id":"MDQ6VXNlcjIxOTIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/219233?v=4","gravatar_id":"","url":"https://api.github.com/users/bendudson","html_url":"https://github.com/bendudson","followers_url":"https://api.github.com/users/bendudson/followers","following_url":"https://api.github.com/users/bendudson/following{/other_user}","gists_url":"https://api.github.com/users/bendudson/gists{/gist_id}","starred_url":"https://api.github.com/users/bendudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendudson/subscriptions","organizations_url":"https://api.github.com/users/bendudson/orgs","repos_url":"https://api.github.com/users/bendudson/repos","events_url":"https://api.github.com/users/bendudson/events{/privacy}","received_events_url":"https://api.github.com/users/bendudson/received_events","type":"User","site_admin":false},"body":"Should still be `Field2D` ?","created_at":"2018-11-15T23:06:31Z","updated_at":"2018-11-15T23:06:31Z","html_url":"https://github.com/boutproject/BOUT-dev/pull/1363#discussion_r234041559","pull_request_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/234041559"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1363#discussion_r234041559"},"pull_request":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363"}}},"pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363","id":229682054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjgyMDU0","html_url":"https://github.com/boutproject/BOUT-dev/pull/1363","diff_url":"https://github.com/boutproject/BOUT-dev/pull/1363.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/1363.patch","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1363","number":1363,"state":"open","locked":false,"title":"Optimisations to certain vector routines","user":{"login":"d7919","id":1793698,"node_id":"MDQ6VXNlcjE3OTM2OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1793698?v=4","gravatar_id":"","url":"https://api.github.com/users/d7919","html_url":"https://github.com/d7919","followers_url":"https://api.github.com/users/d7919/followers","following_url":"https://api.github.com/users/d7919/following{/other_user}","gists_url":"https://api.github.com/users/d7919/gists{/gist_id}","starred_url":"https://api.github.com/users/d7919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d7919/subscriptions","organizations_url":"https://api.github.com/users/d7919/orgs","repos_url":"https://api.github.com/users/d7919/repos","events_url":"https://api.github.com/users/d7919/events{/privacy}","received_events_url":"https://api.github.com/users/d7919/received_events","type":"User","site_admin":false},"body":"ToCovariant/Contravariant now use explicit loop rather than multiple\r\nfield operations. Can provide significant reduction in time.\r\n\r\nV_dot_grad for two vector arguments now written in terms of a templated\r\nroutine to avoid large amounts of duplicated code. The templated routine\r\nalso introduces a loop over the mesh rather than using field operations.\r\n\r\nTogether these changes should reduce the time for vector based models be\r\na reasonable fraction (e.g. the orszag-tang example).","created_at":"2018-11-09T12:40:54Z","updated_at":"2018-11-15T23:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9d248438d2081d9e510d31445dac6c480c856f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1363/comments","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/cb702c3228d68293047cf7c7ee9d6837c9e9a093","head":{"label":"boutproject:vector_optimisations","ref":"vector_optimisations","sha":"cb702c3228d68293047cf7c7ee9d6837c9e9a093","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-11-15T23:00:01Z","pushed_at":"2018-11-15T23:00:02Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":43767,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":180,"watchers":28,"default_branch":"master"}},"base":{"label":"boutproject:next","ref":"next","sha":"f2261a5e792ace6ad7c99e5ca7e99645c634dfd1","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-11-15T23:00:01Z","pushed_at":"2018-11-15T23:00:02Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":43767,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":180,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1363"},"issue":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1363"},"comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/cb702c3228d68293047cf7c7ee9d6837c9e9a093"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bendudson"}}