{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2","id":186254929,"html_url":"https://github.com/honestbee/mjml-rails/pull/2","diff_url":"https://github.com/honestbee/mjml-rails/pull/2.diff","patch_url":"https://github.com/honestbee/mjml-rails/pull/2.patch","issue_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/2","number":2,"state":"closed","locked":false,"title":"Replace backtick with Open3 for parser","user":{"login":"anhtrantuan","id":2020180,"avatar_url":"https://avatars1.githubusercontent.com/u/2020180?v=4","gravatar_id":"","url":"https://api.github.com/users/anhtrantuan","html_url":"https://github.com/anhtrantuan","followers_url":"https://api.github.com/users/anhtrantuan/followers","following_url":"https://api.github.com/users/anhtrantuan/following{/other_user}","gists_url":"https://api.github.com/users/anhtrantuan/gists{/gist_id}","starred_url":"https://api.github.com/users/anhtrantuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhtrantuan/subscriptions","organizations_url":"https://api.github.com/users/anhtrantuan/orgs","repos_url":"https://api.github.com/users/anhtrantuan/repos","events_url":"https://api.github.com/users/anhtrantuan/events{/privacy}","received_events_url":"https://api.github.com/users/anhtrantuan/received_events","type":"User","site_admin":false},"body":"## Why is this necessary?\r\n* `Mjml::Parse#run` swallows shell execution error by using backtick syntax. Causing failure for subsequence instructions.\r\n\r\n## What were changed?\r\n* Use `Open3.popen3` to support error raising for `Mjml::Parse#run` method.","created_at":"2018-05-07T04:52:23Z","updated_at":"2018-05-23T17:02:41Z","closed_at":"2018-05-23T17:02:41Z","merged_at":"2018-05-23T17:02:40Z","merge_commit_sha":"2126c77c7b229e2f6eb1eef41c00d7e50ca61047","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tuannvm","id":1461216,"avatar_url":"https://avatars1.githubusercontent.com/u/1461216?v=4","gravatar_id":"","url":"https://api.github.com/users/tuannvm","html_url":"https://github.com/tuannvm","followers_url":"https://api.github.com/users/tuannvm/followers","following_url":"https://api.github.com/users/tuannvm/following{/other_user}","gists_url":"https://api.github.com/users/tuannvm/gists{/gist_id}","starred_url":"https://api.github.com/users/tuannvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuannvm/subscriptions","organizations_url":"https://api.github.com/users/tuannvm/orgs","repos_url":"https://api.github.com/users/tuannvm/repos","events_url":"https://api.github.com/users/tuannvm/events{/privacy}","received_events_url":"https://api.github.com/users/tuannvm/received_events","type":"User","site_admin":false},{"login":"trungdq88","id":4214509,"avatar_url":"https://avatars3.githubusercontent.com/u/4214509?v=4","gravatar_id":"","url":"https://api.github.com/users/trungdq88","html_url":"https://github.com/trungdq88","followers_url":"https://api.github.com/users/trungdq88/followers","following_url":"https://api.github.com/users/trungdq88/following{/other_user}","gists_url":"https://api.github.com/users/trungdq88/gists{/gist_id}","starred_url":"https://api.github.com/users/trungdq88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trungdq88/subscriptions","organizations_url":"https://api.github.com/users/trungdq88/orgs","repos_url":"https://api.github.com/users/trungdq88/repos","events_url":"https://api.github.com/users/trungdq88/events{/privacy}","received_events_url":"https://api.github.com/users/trungdq88/received_events","type":"User","site_admin":false},{"login":"mdaobui","id":8341228,"avatar_url":"https://avatars0.githubusercontent.com/u/8341228?v=4","gravatar_id":"","url":"https://api.github.com/users/mdaobui","html_url":"https://github.com/mdaobui","followers_url":"https://api.github.com/users/mdaobui/followers","following_url":"https://api.github.com/users/mdaobui/following{/other_user}","gists_url":"https://api.github.com/users/mdaobui/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaobui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaobui/subscriptions","organizations_url":"https://api.github.com/users/mdaobui/orgs","repos_url":"https://api.github.com/users/mdaobui/repos","events_url":"https://api.github.com/users/mdaobui/events{/privacy}","received_events_url":"https://api.github.com/users/mdaobui/received_events","type":"User","site_admin":false},{"login":"phongdoduy","id":25846528,"avatar_url":"https://avatars3.githubusercontent.com/u/25846528?v=4","gravatar_id":"","url":"https://api.github.com/users/phongdoduy","html_url":"https://github.com/phongdoduy","followers_url":"https://api.github.com/users/phongdoduy/followers","following_url":"https://api.github.com/users/phongdoduy/following{/other_user}","gists_url":"https://api.github.com/users/phongdoduy/gists{/gist_id}","starred_url":"https://api.github.com/users/phongdoduy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongdoduy/subscriptions","organizations_url":"https://api.github.com/users/phongdoduy/orgs","repos_url":"https://api.github.com/users/phongdoduy/repos","events_url":"https://api.github.com/users/phongdoduy/events{/privacy}","received_events_url":"https://api.github.com/users/phongdoduy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":883508788,"url":"https://api.github.com/repos/honestbee/mjml-rails/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2/commits","review_comments_url":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2/comments","review_comment_url":"https://api.github.com/repos/honestbee/mjml-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/2/comments","statuses_url":"https://api.github.com/repos/honestbee/mjml-rails/statuses/c92c8822989ec6ae35fb17162ee043d438c07e6c","head":{"label":"honestbee:raise-error-for-shell-exec-error","ref":"raise-error-for-shell-exec-error","sha":"c92c8822989ec6ae35fb17162ee043d438c07e6c","user":{"login":"honestbee","id":9959310,"avatar_url":"https://avatars0.githubusercontent.com/u/9959310?v=4","gravatar_id":"","url":"https://api.github.com/users/honestbee","html_url":"https://github.com/honestbee","followers_url":"https://api.github.com/users/honestbee/followers","following_url":"https://api.github.com/users/honestbee/following{/other_user}","gists_url":"https://api.github.com/users/honestbee/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbee/subscriptions","organizations_url":"https://api.github.com/users/honestbee/orgs","repos_url":"https://api.github.com/users/honestbee/repos","events_url":"https://api.github.com/users/honestbee/events{/privacy}","received_events_url":"https://api.github.com/users/honestbee/received_events","type":"Organization","site_admin":false},"repo":{"id":127265108,"name":"mjml-rails","full_name":"honestbee/mjml-rails","owner":{"login":"honestbee","id":9959310,"avatar_url":"https://avatars0.githubusercontent.com/u/9959310?v=4","gravatar_id":"","url":"https://api.github.com/users/honestbee","html_url":"https://github.com/honestbee","followers_url":"https://api.github.com/users/honestbee/followers","following_url":"https://api.github.com/users/honestbee/following{/other_user}","gists_url":"https://api.github.com/users/honestbee/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbee/subscriptions","organizations_url":"https://api.github.com/users/honestbee/orgs","repos_url":"https://api.github.com/users/honestbee/repos","events_url":"https://api.github.com/users/honestbee/events{/privacy}","received_events_url":"https://api.github.com/users/honestbee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/honestbee/mjml-rails","description":"MJML + ERb/Haml/Slim view template","fork":true,"url":"https://api.github.com/repos/honestbee/mjml-rails","forks_url":"https://api.github.com/repos/honestbee/mjml-rails/forks","keys_url":"https://api.github.com/repos/honestbee/mjml-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honestbee/mjml-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honestbee/mjml-rails/teams","hooks_url":"https://api.github.com/repos/honestbee/mjml-rails/hooks","issue_events_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/events{/number}","events_url":"https://api.github.com/repos/honestbee/mjml-rails/events","assignees_url":"https://api.github.com/repos/honestbee/mjml-rails/assignees{/user}","branches_url":"https://api.github.com/repos/honestbee/mjml-rails/branches{/branch}","tags_url":"https://api.github.com/repos/honestbee/mjml-rails/tags","blobs_url":"https://api.github.com/repos/honestbee/mjml-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honestbee/mjml-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honestbee/mjml-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/honestbee/mjml-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honestbee/mjml-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/honestbee/mjml-rails/languages","stargazers_url":"https://api.github.com/repos/honestbee/mjml-rails/stargazers","contributors_url":"https://api.github.com/repos/honestbee/mjml-rails/contributors","subscribers_url":"https://api.github.com/repos/honestbee/mjml-rails/subscribers","subscription_url":"https://api.github.com/repos/honestbee/mjml-rails/subscription","commits_url":"https://api.github.com/repos/honestbee/mjml-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/honestbee/mjml-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/honestbee/mjml-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/honestbee/mjml-rails/contents/{+path}","compare_url":"https://api.github.com/repos/honestbee/mjml-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honestbee/mjml-rails/merges","archive_url":"https://api.github.com/repos/honestbee/mjml-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honestbee/mjml-rails/downloads","issues_url":"https://api.github.com/repos/honestbee/mjml-rails/issues{/number}","pulls_url":"https://api.github.com/repos/honestbee/mjml-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/honestbee/mjml-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/honestbee/mjml-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honestbee/mjml-rails/labels{/name}","releases_url":"https://api.github.com/repos/honestbee/mjml-rails/releases{/id}","deployments_url":"https://api.github.com/repos/honestbee/mjml-rails/deployments","created_at":"2018-03-29T08:57:41Z","updated_at":"2018-05-07T02:55:40Z","pushed_at":"2018-05-23T17:02:40Z","git_url":"git://github.com/honestbee/mjml-rails.git","ssh_url":"git@github.com:honestbee/mjml-rails.git","clone_url":"https://github.com/honestbee/mjml-rails.git","svn_url":"https://github.com/honestbee/mjml-rails","homepage":"https://mjml.io","size":251,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"honestbee:master","ref":"master","sha":"f743fc0851b11bdcf14d55e05d30e5a038121c43","user":{"login":"honestbee","id":9959310,"avatar_url":"https://avatars0.githubusercontent.com/u/9959310?v=4","gravatar_id":"","url":"https://api.github.com/users/honestbee","html_url":"https://github.com/honestbee","followers_url":"https://api.github.com/users/honestbee/followers","following_url":"https://api.github.com/users/honestbee/following{/other_user}","gists_url":"https://api.github.com/users/honestbee/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbee/subscriptions","organizations_url":"https://api.github.com/users/honestbee/orgs","repos_url":"https://api.github.com/users/honestbee/repos","events_url":"https://api.github.com/users/honestbee/events{/privacy}","received_events_url":"https://api.github.com/users/honestbee/received_events","type":"Organization","site_admin":false},"repo":{"id":127265108,"name":"mjml-rails","full_name":"honestbee/mjml-rails","owner":{"login":"honestbee","id":9959310,"avatar_url":"https://avatars0.githubusercontent.com/u/9959310?v=4","gravatar_id":"","url":"https://api.github.com/users/honestbee","html_url":"https://github.com/honestbee","followers_url":"https://api.github.com/users/honestbee/followers","following_url":"https://api.github.com/users/honestbee/following{/other_user}","gists_url":"https://api.github.com/users/honestbee/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbee/subscriptions","organizations_url":"https://api.github.com/users/honestbee/orgs","repos_url":"https://api.github.com/users/honestbee/repos","events_url":"https://api.github.com/users/honestbee/events{/privacy}","received_events_url":"https://api.github.com/users/honestbee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/honestbee/mjml-rails","description":"MJML + ERb/Haml/Slim view template","fork":true,"url":"https://api.github.com/repos/honestbee/mjml-rails","forks_url":"https://api.github.com/repos/honestbee/mjml-rails/forks","keys_url":"https://api.github.com/repos/honestbee/mjml-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honestbee/mjml-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honestbee/mjml-rails/teams","hooks_url":"https://api.github.com/repos/honestbee/mjml-rails/hooks","issue_events_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/events{/number}","events_url":"https://api.github.com/repos/honestbee/mjml-rails/events","assignees_url":"https://api.github.com/repos/honestbee/mjml-rails/assignees{/user}","branches_url":"https://api.github.com/repos/honestbee/mjml-rails/branches{/branch}","tags_url":"https://api.github.com/repos/honestbee/mjml-rails/tags","blobs_url":"https://api.github.com/repos/honestbee/mjml-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honestbee/mjml-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honestbee/mjml-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/honestbee/mjml-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honestbee/mjml-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/honestbee/mjml-rails/languages","stargazers_url":"https://api.github.com/repos/honestbee/mjml-rails/stargazers","contributors_url":"https://api.github.com/repos/honestbee/mjml-rails/contributors","subscribers_url":"https://api.github.com/repos/honestbee/mjml-rails/subscribers","subscription_url":"https://api.github.com/repos/honestbee/mjml-rails/subscription","commits_url":"https://api.github.com/repos/honestbee/mjml-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/honestbee/mjml-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/honestbee/mjml-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/honestbee/mjml-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/honestbee/mjml-rails/contents/{+path}","compare_url":"https://api.github.com/repos/honestbee/mjml-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honestbee/mjml-rails/merges","archive_url":"https://api.github.com/repos/honestbee/mjml-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honestbee/mjml-rails/downloads","issues_url":"https://api.github.com/repos/honestbee/mjml-rails/issues{/number}","pulls_url":"https://api.github.com/repos/honestbee/mjml-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/honestbee/mjml-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/honestbee/mjml-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honestbee/mjml-rails/labels{/name}","releases_url":"https://api.github.com/repos/honestbee/mjml-rails/releases{/id}","deployments_url":"https://api.github.com/repos/honestbee/mjml-rails/deployments","created_at":"2018-03-29T08:57:41Z","updated_at":"2018-05-07T02:55:40Z","pushed_at":"2018-05-23T17:02:40Z","git_url":"git://github.com/honestbee/mjml-rails.git","ssh_url":"git@github.com:honestbee/mjml-rails.git","clone_url":"https://github.com/honestbee/mjml-rails.git","svn_url":"https://github.com/honestbee/mjml-rails","homepage":"https://mjml.io","size":251,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2"},"html":{"href":"https://github.com/honestbee/mjml-rails/pull/2"},"issue":{"href":"https://api.github.com/repos/honestbee/mjml-rails/issues/2"},"comments":{"href":"https://api.github.com/repos/honestbee/mjml-rails/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/honestbee/mjml-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/honestbee/mjml-rails/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/honestbee/mjml-rails/statuses/c92c8822989ec6ae35fb17162ee043d438c07e6c"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"anhtrantuan","id":2020180,"avatar_url":"https://avatars1.githubusercontent.com/u/2020180?v=4","gravatar_id":"","url":"https://api.github.com/users/anhtrantuan","html_url":"https://github.com/anhtrantuan","followers_url":"https://api.github.com/users/anhtrantuan/followers","following_url":"https://api.github.com/users/anhtrantuan/following{/other_user}","gists_url":"https://api.github.com/users/anhtrantuan/gists{/gist_id}","starred_url":"https://api.github.com/users/anhtrantuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhtrantuan/subscriptions","organizations_url":"https://api.github.com/users/anhtrantuan/orgs","repos_url":"https://api.github.com/users/anhtrantuan/repos","events_url":"https://api.github.com/users/anhtrantuan/events{/privacy}","received_events_url":"https://api.github.com/users/anhtrantuan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"anhtrantuan"}}