{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/218611621","pull_request_review_id":156589751,"id":218611621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODYxMTYyMQ==","diff_hunk":"@@ -0,0 +1,153 @@\n+// ============================================================================\n+//                 SeqAn - The Library for Sequence Analysis\n+// ============================================================================\n+//\n+// Copyright (c) 2006-2018, Knut Reinert & Freie Universitaet Berlin\n+// Copyright (c) 2016-2018, Knut Reinert & MPI Molekulare Genetik\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are met:\n+//\n+//     * Redistributions of source code must retain the above copyright\n+//       notice, this list of conditions and the following disclaimer.\n+//     * Redistributions in binary form must reproduce the above copyright\n+//       notice, this list of conditions and the following disclaimer in the\n+//       documentation and/or other materials provided with the distribution.\n+//     * Neither the name of Knut Reinert or the FU Berlin nor the names of\n+//       its contributors may be used to endorse or promote products derived\n+//       from this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+// ARE DISCLAIMED. IN NO EVENT SHALL KNUT REINERT OR THE FU BERLIN BE LIABLE\n+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY\n+// OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH\n+// DAMAGE.\n+//\n+// ============================================================================\n+\n+/*!\\file\n+ * \\brief Provides the mode configuration to define the search modes \"all\", \"all_best\", \"best\" and \"strata\".\n+ * \\author Christopher Pockrandt <christopher.pockrandt AT fu-berlin.de>\n+ */\n+\n+#pragma once\n+\n+#include <seqan3/core/algorithm/all.hpp>\n+#include <seqan3/core/metafunction/basic.hpp>\n+#include <seqan3/core/metafunction/template_inspection.hpp>\n+#include <seqan3/search/algorithm/configuration/utility.hpp>\n+\n+/*!\\addtogroup search\n+ * \\{\n+ */\n+\n+namespace seqan3::detail\n+{\n+\n+struct search_mode_all {};\n+\n+struct search_mode_all_best {};\n+\n+struct search_mode_best {};\n+\n+} // namespace seqan3::detail\n+\n+namespace seqan3::search_cfg\n+{\n+\n+//!\\brief Configuration element to receive all hits within the error bounds.\n+inline detail::search_mode_all constexpr all;","path":"include/seqan3/search/algorithm/configuration/mode.hpp","position":66,"original_position":66,"commit_id":"02527ceda153b9c593956ac50e63a229451cc2e0","original_commit_id":"02527ceda153b9c593956ac50e63a229451cc2e0","user":{"login":"h-2","id":2996863,"node_id":"MDQ6VXNlcjI5OTY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"body":"No! We have always used east-const and it is the more consistent notation!! See http://slashslash.info/eastconst/ for example.\r\nWe just didn't follow through with `constexpr` so we need to fix that.","created_at":"2018-09-18T22:08:52Z","updated_at":"2018-09-18T22:08:52Z","html_url":"https://github.com/seqan/seqan3/pull/422#discussion_r218611621","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/422","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/218611621"},"html":{"href":"https://github.com/seqan/seqan3/pull/422#discussion_r218611621"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/422"}},"in_reply_to_id":218597261},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/422","id":214665480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjY1NDgw","html_url":"https://github.com/seqan/seqan3/pull/422","diff_url":"https://github.com/seqan/seqan3/pull/422.diff","patch_url":"https://github.com/seqan/seqan3/pull/422.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/422","number":422,"state":"open","locked":false,"title":"Search module","user":{"login":"cpockrandt","id":7328307,"node_id":"MDQ6VXNlcjczMjgzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7328307?v=4","gravatar_id":"","url":"https://api.github.com/users/cpockrandt","html_url":"https://github.com/cpockrandt","followers_url":"https://api.github.com/users/cpockrandt/followers","following_url":"https://api.github.com/users/cpockrandt/following{/other_user}","gists_url":"https://api.github.com/users/cpockrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/cpockrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpockrandt/subscriptions","organizations_url":"https://api.github.com/users/cpockrandt/orgs","repos_url":"https://api.github.com/users/cpockrandt/repos","events_url":"https://api.github.com/users/cpockrandt/events{/privacy}","received_events_url":"https://api.github.com/users/cpockrandt/received_events","type":"User","site_admin":false},"body":"Do not review or merge yet. Work in progress.","created_at":"2018-09-11T15:05:57Z","updated_at":"2018-09-18T22:08:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"930b8b26159d537a71450082e68fc05e195be519","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":568314043,"node_id":"MDU6TGFiZWw1NjgzMTQwNDM=","url":"https://api.github.com/repos/seqan/seqan3/labels/feature/proposal","name":"feature/proposal","color":"0e8a16","default":false},{"id":581690505,"node_id":"MDU6TGFiZWw1ODE2OTA1MDU=","url":"https://api.github.com/repos/seqan/seqan3/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/seqan/seqan3/milestones/10","html_url":"https://github.com/seqan/seqan3/milestone/10","labels_url":"https://api.github.com/repos/seqan/seqan3/milestones/10/labels","id":3539439,"node_id":"MDk6TWlsZXN0b25lMzUzOTQzOQ==","number":10,"title":"Index Module","description":"For the workshops in September we need a index module with search interface\r\nThe following minimum requirements must be fulfilled:\r\n\r\n* Load index from Disk\r\n* At least one filter/search interface to select candidates \r\n* [optional!!!] Parallel search interface\r\n* [optional] building the index. We could also just use a prebuilt index from another tool, if the index is compliant.\r\n\r\nDependencies:\r\n* Verification algorithm [Myers', better SIMD Myers' Module]\r\n* Computing Mapping Coordinates [Alignment Module]\r\n* Computing final Alignment [Alignment Module]","creator":{"login":"rrahn","id":1529364,"node_id":"MDQ6VXNlcjE1MjkzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-08-01T14:24:16Z","updated_at":"2018-09-11T15:05:57Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/422/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/422/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/422/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/02527ceda153b9c593956ac50e63a229451cc2e0","head":{"label":"cpockrandt:feature/search_new","ref":"feature/search_new","sha":"02527ceda153b9c593956ac50e63a229451cc2e0","user":{"login":"cpockrandt","id":7328307,"node_id":"MDQ6VXNlcjczMjgzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7328307?v=4","gravatar_id":"","url":"https://api.github.com/users/cpockrandt","html_url":"https://github.com/cpockrandt","followers_url":"https://api.github.com/users/cpockrandt/followers","following_url":"https://api.github.com/users/cpockrandt/following{/other_user}","gists_url":"https://api.github.com/users/cpockrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/cpockrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpockrandt/subscriptions","organizations_url":"https://api.github.com/users/cpockrandt/orgs","repos_url":"https://api.github.com/users/cpockrandt/repos","events_url":"https://api.github.com/users/cpockrandt/events{/privacy}","received_events_url":"https://api.github.com/users/cpockrandt/received_events","type":"User","site_admin":false},"repo":{"id":86163865,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE2Mzg2NQ==","name":"seqan3","full_name":"cpockrandt/seqan3","private":false,"owner":{"login":"cpockrandt","id":7328307,"node_id":"MDQ6VXNlcjczMjgzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7328307?v=4","gravatar_id":"","url":"https://api.github.com/users/cpockrandt","html_url":"https://github.com/cpockrandt","followers_url":"https://api.github.com/users/cpockrandt/followers","following_url":"https://api.github.com/users/cpockrandt/following{/other_user}","gists_url":"https://api.github.com/users/cpockrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/cpockrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpockrandt/subscriptions","organizations_url":"https://api.github.com/users/cpockrandt/orgs","repos_url":"https://api.github.com/users/cpockrandt/repos","events_url":"https://api.github.com/users/cpockrandt/events{/privacy}","received_events_url":"https://api.github.com/users/cpockrandt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cpockrandt/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/cpockrandt/seqan3","forks_url":"https://api.github.com/repos/cpockrandt/seqan3/forks","keys_url":"https://api.github.com/repos/cpockrandt/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpockrandt/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpockrandt/seqan3/teams","hooks_url":"https://api.github.com/repos/cpockrandt/seqan3/hooks","issue_events_url":"https://api.github.com/repos/cpockrandt/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/cpockrandt/seqan3/events","assignees_url":"https://api.github.com/repos/cpockrandt/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/cpockrandt/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/cpockrandt/seqan3/tags","blobs_url":"https://api.github.com/repos/cpockrandt/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpockrandt/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpockrandt/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpockrandt/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpockrandt/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/cpockrandt/seqan3/languages","stargazers_url":"https://api.github.com/repos/cpockrandt/seqan3/stargazers","contributors_url":"https://api.github.com/repos/cpockrandt/seqan3/contributors","subscribers_url":"https://api.github.com/repos/cpockrandt/seqan3/subscribers","subscription_url":"https://api.github.com/repos/cpockrandt/seqan3/subscription","commits_url":"https://api.github.com/repos/cpockrandt/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpockrandt/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpockrandt/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpockrandt/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpockrandt/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/cpockrandt/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpockrandt/seqan3/merges","archive_url":"https://api.github.com/repos/cpockrandt/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpockrandt/seqan3/downloads","issues_url":"https://api.github.com/repos/cpockrandt/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/cpockrandt/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/cpockrandt/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/cpockrandt/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpockrandt/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/cpockrandt/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/cpockrandt/seqan3/deployments","created_at":"2017-03-25T14:37:58Z","updated_at":"2018-09-11T01:17:28Z","pushed_at":"2018-09-18T18:12:14Z","git_url":"git://github.com/cpockrandt/seqan3.git","ssh_url":"git@github.com:cpockrandt/seqan3.git","clone_url":"https://github.com/cpockrandt/seqan3.git","svn_url":"https://github.com/cpockrandt/seqan3","homepage":"http://www.seqan.de","size":1897,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"66abc9dc453fbec9ab5f5acdd532c063b840ba73","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","private":false,"owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2018-09-18T21:03:42Z","pushed_at":"2018-09-18T21:03:38Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":1815,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":124,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/422"},"html":{"href":"https://github.com/seqan/seqan3/pull/422"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/422"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/02527ceda153b9c593956ac50e63a229451cc2e0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"h-2"}}