{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/178678047","pull_request_review_id":108775096,"id":178678047,"diff_hunk":"@@ -26,6 +26,16 @@ type ContainerAttachConfig struct {\n \tMuxStreams bool\n }\n \n+// LogMetaData provides meta data for a partial log message. Messages exceeding a predefined size\n+// are split into chunks with this metadata. The expectation is for the logger endpoints to assemble\n+// the chunks using this metadata.\n+type LogMetaData struct {\n+\tIsPartial   bool","path":"api/types/backend/backend.go","position":8,"original_position":8,"commit_id":"84936134e261a051273f6b0211c6233dbfe608d6","original_commit_id":"84936134e261a051273f6b0211c6233dbfe608d6","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"Can we document these fields?\r\n\r\n```\r\nID string // identifies the log message or group of messages comprising a single record \r\nOrdinal // ordering of message in partial group\r\nIsPartial bool // true if this message is made up of 2 or more messages \r\nLastPartial bool // true if this message is last of a partial\r\n```\r\n\r\nAlso, we might be able to get rid of the need for the partial bool if we use 0 for complete message and 1 for first ordinal of partial, then all you need is `last` bool.","created_at":"2018-04-02T23:31:23Z","updated_at":"2018-04-02T23:31:24Z","html_url":"https://github.com/moby/moby/pull/35831#discussion_r178678047","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/35831","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/178678047"},"html":{"href":"https://github.com/moby/moby/pull/35831#discussion_r178678047"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/35831"}}},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/35831","id":159066372,"html_url":"https://github.com/moby/moby/pull/35831","diff_url":"https://github.com/moby/moby/pull/35831.diff","patch_url":"https://github.com/moby/moby/pull/35831.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/35831","number":35831,"state":"open","locked":false,"title":" Improve partial message support in logger","user":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars0.githubusercontent.com/u/14184178?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"body":"Improve partial message support in logger and use it in Splunk.\r\n\r\nDocker daemon has a 16K buffer for log messages. If a message length\r\nexceeds 16K, it should be split by the logger and merged at the\r\nendpoint.\r\n\r\nThis change adds `LogMetaData` struct for enhanced partial support\r\nIsPartial (bool)    : Indicates if this message is partial\r\nLastPartial (bool) : indicates if this is the last of all partials.\r\nID (string)            : unique 32 bit ID. ID is same across all partials.\r\nOrdinal (int starts at 1) : indicates the position of msg in the series of partials.\r\n \r\n  Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>\r\n  ","created_at":"2017-12-19T02:43:05Z","updated_at":"2018-04-02T23:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c4d1782a218c490e218f2419371cb70398e1b5","assignee":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":70404987,"url":"https://api.github.com/repos/moby/moby/labels/area/logging","name":"area/logging","color":"fbca04","default":false},{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/35831/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/35831/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/35831/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/84936134e261a051273f6b0211c6233dbfe608d6","head":{"label":"anusha-ragunathan:splunk_partial","ref":"splunk_partial","sha":"84936134e261a051273f6b0211c6233dbfe608d6","user":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars0.githubusercontent.com/u/14184178?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"repo":{"id":42128270,"name":"docker","full_name":"anusha-ragunathan/docker","owner":{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars0.githubusercontent.com/u/14184178?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anusha-ragunathan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/anusha-ragunathan/docker","forks_url":"https://api.github.com/repos/anusha-ragunathan/docker/forks","keys_url":"https://api.github.com/repos/anusha-ragunathan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anusha-ragunathan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anusha-ragunathan/docker/teams","hooks_url":"https://api.github.com/repos/anusha-ragunathan/docker/hooks","issue_events_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/anusha-ragunathan/docker/events","assignees_url":"https://api.github.com/repos/anusha-ragunathan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/anusha-ragunathan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/anusha-ragunathan/docker/tags","blobs_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anusha-ragunathan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/anusha-ragunathan/docker/languages","stargazers_url":"https://api.github.com/repos/anusha-ragunathan/docker/stargazers","contributors_url":"https://api.github.com/repos/anusha-ragunathan/docker/contributors","subscribers_url":"https://api.github.com/repos/anusha-ragunathan/docker/subscribers","subscription_url":"https://api.github.com/repos/anusha-ragunathan/docker/subscription","commits_url":"https://api.github.com/repos/anusha-ragunathan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/anusha-ragunathan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/anusha-ragunathan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/anusha-ragunathan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/anusha-ragunathan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anusha-ragunathan/docker/merges","archive_url":"https://api.github.com/repos/anusha-ragunathan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anusha-ragunathan/docker/downloads","issues_url":"https://api.github.com/repos/anusha-ragunathan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/anusha-ragunathan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/anusha-ragunathan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/anusha-ragunathan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anusha-ragunathan/docker/labels{/name}","releases_url":"https://api.github.com/repos/anusha-ragunathan/docker/releases{/id}","deployments_url":"https://api.github.com/repos/anusha-ragunathan/docker/deployments","created_at":"2015-09-08T17:34:24Z","updated_at":"2017-04-18T14:49:21Z","pushed_at":"2018-03-26T17:58:25Z","git_url":"git://github.com/anusha-ragunathan/docker.git","ssh_url":"git@github.com:anusha-ragunathan/docker.git","clone_url":"https://github.com/anusha-ragunathan/docker.git","svn_url":"https://github.com/anusha-ragunathan/docker","homepage":"http://www.docker.com","size":125213,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"c4e93da8a6fcd206e3fbfb07b821b5743f90f437","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-04-02T22:35:31Z","pushed_at":"2018-04-02T23:23:53Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":132312,"stargazers_count":48319,"watchers_count":48319,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14210,"mirror_url":null,"archived":false,"open_issues_count":3155,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14210,"open_issues":3155,"watchers":48319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/35831"},"html":{"href":"https://github.com/moby/moby/pull/35831"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/35831"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/35831/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/35831/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/35831/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/84936134e261a051273f6b0211c6233dbfe608d6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stevvooe"}}