{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/167405014","pull_request_review_id":95628031,"id":167405014,"diff_hunk":"@@ -418,44 +419,28 @@ def _init_dict(self, data, index, columns, dtype=None):\n         Needs to handle a lot of exceptional cases.\n         \"\"\"\n         if columns is not None:\n-            columns = _ensure_index(columns)\n+            arrays = Series(data, index=columns, dtype=object)\n+            data_names = arrays.index\n \n-            # GH10856\n-            # raise ValueError if only scalars in dict\n+            missing = arrays.isnull()\n             if index is None:\n-                extract_index(list(data.values()))\n-\n-            # prefilter if columns passed\n-            data = {k: v for k, v in compat.iteritems(data) if k in columns}\n-\n-            if index is None:\n-                index = extract_index(list(data.values()))\n-\n+                # GH10856\n+                # raise ValueError if only scalars in dict","path":"pandas/core/frame.py","position":29,"original_position":29,"commit_id":"0ddd89ef349d8f588654f1dd6722707ed5408ff9","original_commit_id":"0ddd89ef349d8f588654f1dd6722707ed5408ff9","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"do you need the .tolist()?","created_at":"2018-02-10T17:28:58Z","updated_at":"2018-02-10T17:31:45Z","html_url":"https://github.com/pandas-dev/pandas/pull/18600#discussion_r167405014","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/167405014"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/18600#discussion_r167405014"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600","id":156015599,"html_url":"https://github.com/pandas-dev/pandas/pull/18600","diff_url":"https://github.com/pandas-dev/pandas/pull/18600.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/18600.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/18600","number":18600,"state":"open","locked":false,"title":"BUG: Fix initialization of DataFrame from dict with NaN as key","user":{"login":"toobaz","id":1224492,"avatar_url":"https://avatars1.githubusercontent.com/u/1224492?v=4","gravatar_id":"","url":"https://api.github.com/users/toobaz","html_url":"https://github.com/toobaz","followers_url":"https://api.github.com/users/toobaz/followers","following_url":"https://api.github.com/users/toobaz/following{/other_user}","gists_url":"https://api.github.com/users/toobaz/gists{/gist_id}","starred_url":"https://api.github.com/users/toobaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toobaz/subscriptions","organizations_url":"https://api.github.com/users/toobaz/orgs","repos_url":"https://api.github.com/users/toobaz/repos","events_url":"https://api.github.com/users/toobaz/events{/privacy}","received_events_url":"https://api.github.com/users/toobaz/received_events","type":"User","site_admin":false},"body":"- [x] closes #18455\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n\r\nThis does not solve the [MI example](https://github.com/pandas-dev/pandas/issues/18455#issuecomment-346700652) in #18455, but that should be included in #18485 .","created_at":"2017-12-02T14:27:59Z","updated_at":"2018-02-10T17:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65ff51525d9dccd8e1fd54809169c297872c26ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":31404521,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Dtypes","name":"Dtypes","color":"e102d8","default":false},{"id":2822342,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Missing-data","name":"Missing-data","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/18600/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/0ddd89ef349d8f588654f1dd6722707ed5408ff9","head":{"label":"toobaz:df_init_dict_nan","ref":"df_init_dict_nan","sha":"0ddd89ef349d8f588654f1dd6722707ed5408ff9","user":{"login":"toobaz","id":1224492,"avatar_url":"https://avatars1.githubusercontent.com/u/1224492?v=4","gravatar_id":"","url":"https://api.github.com/users/toobaz","html_url":"https://github.com/toobaz","followers_url":"https://api.github.com/users/toobaz/followers","following_url":"https://api.github.com/users/toobaz/following{/other_user}","gists_url":"https://api.github.com/users/toobaz/gists{/gist_id}","starred_url":"https://api.github.com/users/toobaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toobaz/subscriptions","organizations_url":"https://api.github.com/users/toobaz/orgs","repos_url":"https://api.github.com/users/toobaz/repos","events_url":"https://api.github.com/users/toobaz/events{/privacy}","received_events_url":"https://api.github.com/users/toobaz/received_events","type":"User","site_admin":false},"repo":{"id":17260108,"name":"pandas","full_name":"toobaz/pandas","owner":{"login":"toobaz","id":1224492,"avatar_url":"https://avatars1.githubusercontent.com/u/1224492?v=4","gravatar_id":"","url":"https://api.github.com/users/toobaz","html_url":"https://github.com/toobaz","followers_url":"https://api.github.com/users/toobaz/followers","following_url":"https://api.github.com/users/toobaz/following{/other_user}","gists_url":"https://api.github.com/users/toobaz/gists{/gist_id}","starred_url":"https://api.github.com/users/toobaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toobaz/subscriptions","organizations_url":"https://api.github.com/users/toobaz/orgs","repos_url":"https://api.github.com/users/toobaz/repos","events_url":"https://api.github.com/users/toobaz/events{/privacy}","received_events_url":"https://api.github.com/users/toobaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toobaz/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/toobaz/pandas","forks_url":"https://api.github.com/repos/toobaz/pandas/forks","keys_url":"https://api.github.com/repos/toobaz/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toobaz/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toobaz/pandas/teams","hooks_url":"https://api.github.com/repos/toobaz/pandas/hooks","issue_events_url":"https://api.github.com/repos/toobaz/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/toobaz/pandas/events","assignees_url":"https://api.github.com/repos/toobaz/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/toobaz/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/toobaz/pandas/tags","blobs_url":"https://api.github.com/repos/toobaz/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toobaz/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toobaz/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/toobaz/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toobaz/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/toobaz/pandas/languages","stargazers_url":"https://api.github.com/repos/toobaz/pandas/stargazers","contributors_url":"https://api.github.com/repos/toobaz/pandas/contributors","subscribers_url":"https://api.github.com/repos/toobaz/pandas/subscribers","subscription_url":"https://api.github.com/repos/toobaz/pandas/subscription","commits_url":"https://api.github.com/repos/toobaz/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/toobaz/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/toobaz/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/toobaz/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/toobaz/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/toobaz/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toobaz/pandas/merges","archive_url":"https://api.github.com/repos/toobaz/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toobaz/pandas/downloads","issues_url":"https://api.github.com/repos/toobaz/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/toobaz/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/toobaz/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/toobaz/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toobaz/pandas/labels{/name}","releases_url":"https://api.github.com/repos/toobaz/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/toobaz/pandas/deployments","created_at":"2014-02-27T18:48:23Z","updated_at":"2016-02-07T12:03:26Z","pushed_at":"2018-02-07T21:19:27Z","git_url":"git://github.com/toobaz/pandas.git","ssh_url":"git@github.com:toobaz/pandas.git","clone_url":"https://github.com/toobaz/pandas.git","svn_url":"https://github.com/toobaz/pandas","homepage":"http://pandas.pydata.org","size":114145,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"50528421ae79b27a26b32ba715b17271c8dfda7e","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-10T16:30:18Z","pushed_at":"2018-02-10T17:08:41Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":116007,"stargazers_count":12830,"watchers_count":12830,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4977,"mirror_url":null,"archived":false,"open_issues_count":2323,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4977,"open_issues":2323,"watchers":12830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/18600"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/18600"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/18600/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18600/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/0ddd89ef349d8f588654f1dd6722707ed5408ff9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}