{"action":"created","issue":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2519","repository_url":"https://api.github.com/repos/openhab/openhab2-addons","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2519/labels{/name}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2519/comments","events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2519/events","html_url":"https://github.com/openhab/openhab2-addons/pull/2519","id":248214540,"node_id":"MDExOlB1bGxSZXF1ZXN0MTM0MzA4MDk2","number":2519,"title":"[autelis] jandy support","user":{"login":"digitaldan","id":1903737,"node_id":"MDQ6VXNlcjE5MDM3Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1903737?v=4","gravatar_id":"","url":"https://api.github.com/users/digitaldan","html_url":"https://github.com/digitaldan","followers_url":"https://api.github.com/users/digitaldan/followers","following_url":"https://api.github.com/users/digitaldan/following{/other_user}","gists_url":"https://api.github.com/users/digitaldan/gists{/gist_id}","starred_url":"https://api.github.com/users/digitaldan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitaldan/subscriptions","organizations_url":"https://api.github.com/users/digitaldan/orgs","repos_url":"https://api.github.com/users/digitaldan/repos","events_url":"https://api.github.com/users/digitaldan/events{/privacy}","received_events_url":"https://api.github.com/users/digitaldan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-05T23:05:20Z","updated_at":"2018-10-11T05:46:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2519","html_url":"https://github.com/openhab/openhab2-addons/pull/2519","diff_url":"https://github.com/openhab/openhab2-addons/pull/2519.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2519.patch"},"body":"<!--\r\nThanks for contributing to the openHAB project!\r\nPlease describe the goal and effect of your PR here.\r\nPay attention to the below notes and to *the guidelines* for this repository.\r\nFeel free to delete any comment sections in the template (starting with \"<!--\").\r\n-->\r\n\r\n<!-- TITLE -->\r\n[autelis] Add ability to control Jandy based pool controllers\r\n<!--\r\nPlease provide a PR summary in the *Title* above, according to the following schema:\r\n- If related to one specific addon: Mention the addon shortname in square brackets\r\n  e.g. \"[exec]\", \"[netatmo]\" or \"[tesla]\"\r\n- If the PR is work in progress: Add \"[WIP]\"\r\n- Give a short meaningful description in imperative mood\r\n  e.g. \"Add support for device XYZ\" or \"Fix wrongly handled exception\"\r\n  for a new add-on/binding: \"Initial contribution\"\r\nExamples:\r\n- \"[homematic] Improve communication with weak signal devices\"\r\n- \"[timemachine][WIP] Initial contribution\"\r\n- \"Update contribution guidelines on new signing rules\"\r\n-->\r\n\r\n<!-- DESCRIPTION -->\r\nThis breaks out Jandy and Pentiar pools into their own thing types.  This also cleans up the documentation as well as enhances the polling code.\r\n<!--\r\nPlease give a few sentences describing the overall goals of the pull request.\r\nGive enough details to make the improvement and changes of the PR understandable\r\nto both developers and tech-savy users.\r\n\r\nPlease keep the following in mind:\r\n- What is the classification of the PR, e.g. Bugfix, Improvement, Novel Addition, ... ?\r\n- Did you describe the PRs motivation and goal?\r\n- Did you provide a link to any prior discussion, e.g. an issue or community forum thread?\r\n- Did you describe new features for the end user?\r\n- Did you describe any noteworthy changes in usage for the end user?\r\n- Was the documentation updated accordingly, e.g. the addon README?\r\n- Does your contribution follow the coding guidelines:\r\n  http://docs.openhab.org/developers/development/guidelines.html\r\n- Did you check for any (relevant) issues from the static code analysis:\r\n  http://docs.openhab.org/developers/development/bindings.html#static-code-analysis\r\n- Did you sign-off your work:\r\n  http://docs.openhab.org/developers/contributing/contributing#sign-your-work\r\n-->\r\n\r\n<!-- TESTING -->\r\n\r\n<!--\r\nYour Pull Request will automatically be built and available under the following folder:\r\nhttps://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/\r\n\r\nIt's a good practice to add an URL to your built JAR in this Pull Request description,\r\nso it's easier for the community to test your Add-on.\r\nIf your Pull Request contains a new binding, it will likely take some time\r\nbefore it's reviewed and processed by maintainers.\r\nThat said, consider submitting your Add-on in the Eclipse IoT Marketplace\r\nSee this thread for more info:\r\nhttps://community.openhab.org/t/24491\r\n\r\nDon't forget to submit a thread about your Add-on in the openHAB community:\r\nhttps://community.openhab.org/c/add-ons \r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments/428828344","html_url":"https://github.com/openhab/openhab2-addons/pull/2519#issuecomment-428828344","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2519","id":428828344,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgyODM0NA==","user":{"login":"cweitkamp","id":5131747,"node_id":"MDQ6VXNlcjUxMzE3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5131747?v=4","gravatar_id":"","url":"https://api.github.com/users/cweitkamp","html_url":"https://github.com/cweitkamp","followers_url":"https://api.github.com/users/cweitkamp/followers","following_url":"https://api.github.com/users/cweitkamp/following{/other_user}","gists_url":"https://api.github.com/users/cweitkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/cweitkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweitkamp/subscriptions","organizations_url":"https://api.github.com/users/cweitkamp/orgs","repos_url":"https://api.github.com/users/cweitkamp/repos","events_url":"https://api.github.com/users/cweitkamp/events{/privacy}","received_events_url":"https://api.github.com/users/cweitkamp/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T05:46:09Z","updated_at":"2018-10-11T05:46:09Z","author_association":"CONTRIBUTOR","body":"@digitaldan Thanks. Which commit do you mean? I can see a new commit https://github.com/openhab/openhab2-addons/pull/2519/commits/ecf532138c991e63c020d41de2cb071f2e336f06."}}
{"actor":{"display_login":"cweitkamp"}}