{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/comments/175971364","pull_request_review_id":105592157,"id":175971364,"diff_hunk":"@@ -1,9 +1,31 @@\n ---\n \n-- name: Install bridge-utils\n+- name: Install bridge-utils and iptables\n   yum:\n-    name: bridge-utils\n+    name: \"{{ item }}\"\n     state: latest\n+  with_items:\n+    - bridge-utils\n+    - iptables\n+    - iptables-services\n+\n+- name: enable iptables","path":"roles/bridge-setup/tasks/main.yml","position":14,"original_position":14,"commit_id":"4f7dd06dfb305be5482c04ab30379d26ac51eebc","original_commit_id":"4f7dd06dfb305be5482c04ab30379d26ac51eebc","user":{"login":"s1061123","id":144616,"avatar_url":"https://avatars0.githubusercontent.com/u/144616?v=4","gravatar_id":"","url":"https://api.github.com/users/s1061123","html_url":"https://github.com/s1061123","followers_url":"https://api.github.com/users/s1061123/followers","following_url":"https://api.github.com/users/s1061123/following{/other_user}","gists_url":"https://api.github.com/users/s1061123/gists{/gist_id}","starred_url":"https://api.github.com/users/s1061123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1061123/subscriptions","organizations_url":"https://api.github.com/users/s1061123/orgs","repos_url":"https://api.github.com/users/s1061123/repos","events_url":"https://api.github.com/users/s1061123/events{/privacy}","received_events_url":"https://api.github.com/users/s1061123/received_events","type":"User","site_admin":false},"body":"I understand that firewalld just sends iptables, but it does not said that firewalld is just a command replacement. \r\nAdditionally, there is much information with kube-proxy/iptables than with kube-proxy/iptables, so many user know about only iptables still and may not know that 1:1 command mapping between iptables/firewalld-cmd (at least, I don't know).\r\n\r\nIf you suppose we must support CentOS 7.4 feature, please close this PR and file another issue with bridge/firewalld (oh, I missed SELinux, so please add it!)","created_at":"2018-03-21T01:59:57Z","updated_at":"2018-03-21T01:59:58Z","html_url":"https://github.com/redhat-nfvpe/kube-ansible/pull/202#discussion_r175971364","pull_request_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/comments/175971364"},"html":{"href":"https://github.com/redhat-nfvpe/kube-ansible/pull/202#discussion_r175971364"},"pull_request":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202"}},"in_reply_to_id":175755600},"pull_request":{"url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202","id":176109898,"html_url":"https://github.com/redhat-nfvpe/kube-ansible/pull/202","diff_url":"https://github.com/redhat-nfvpe/kube-ansible/pull/202.diff","patch_url":"https://github.com/redhat-nfvpe/kube-ansible/pull/202.patch","issue_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/202","number":202,"state":"open","locked":false,"title":"Fix bridge network configuration","user":{"login":"s1061123","id":144616,"avatar_url":"https://avatars0.githubusercontent.com/u/144616?v=4","gravatar_id":"","url":"https://api.github.com/users/s1061123","html_url":"https://github.com/s1061123","followers_url":"https://api.github.com/users/s1061123/followers","following_url":"https://api.github.com/users/s1061123/following{/other_user}","gists_url":"https://api.github.com/users/s1061123/gists{/gist_id}","starred_url":"https://api.github.com/users/s1061123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1061123/subscriptions","organizations_url":"https://api.github.com/users/s1061123/orgs","repos_url":"https://api.github.com/users/s1061123/repos","events_url":"https://api.github.com/users/s1061123/events{/privacy}","received_events_url":"https://api.github.com/users/s1061123/received_events","type":"User","site_admin":false},"body":"To run kube with bridge-network, fix iptables, ipv4 forwarding and config file.","created_at":"2018-03-20T07:41:37Z","updated_at":"2018-03-21T01:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87c53e4d8768eb8afb460cfad654af889d96cf7e","assignee":{"login":"s1061123","id":144616,"avatar_url":"https://avatars0.githubusercontent.com/u/144616?v=4","gravatar_id":"","url":"https://api.github.com/users/s1061123","html_url":"https://github.com/s1061123","followers_url":"https://api.github.com/users/s1061123/followers","following_url":"https://api.github.com/users/s1061123/following{/other_user}","gists_url":"https://api.github.com/users/s1061123/gists{/gist_id}","starred_url":"https://api.github.com/users/s1061123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1061123/subscriptions","organizations_url":"https://api.github.com/users/s1061123/orgs","repos_url":"https://api.github.com/users/s1061123/repos","events_url":"https://api.github.com/users/s1061123/events{/privacy}","received_events_url":"https://api.github.com/users/s1061123/received_events","type":"User","site_admin":false},"assignees":[{"login":"s1061123","id":144616,"avatar_url":"https://avatars0.githubusercontent.com/u/144616?v=4","gravatar_id":"","url":"https://api.github.com/users/s1061123","html_url":"https://github.com/s1061123","followers_url":"https://api.github.com/users/s1061123/followers","following_url":"https://api.github.com/users/s1061123/following{/other_user}","gists_url":"https://api.github.com/users/s1061123/gists{/gist_id}","starred_url":"https://api.github.com/users/s1061123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1061123/subscriptions","organizations_url":"https://api.github.com/users/s1061123/orgs","repos_url":"https://api.github.com/users/s1061123/repos","events_url":"https://api.github.com/users/s1061123/events{/privacy}","received_events_url":"https://api.github.com/users/s1061123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":696075081,"url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/labels/state:needs_review","name":"state:needs_review","color":"f6ff00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202/commits","review_comments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202/comments","review_comment_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/202/comments","statuses_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/statuses/4f7dd06dfb305be5482c04ab30379d26ac51eebc","head":{"label":"redhat-nfvpe:fix_bridge","ref":"fix_bridge","sha":"4f7dd06dfb305be5482c04ab30379d26ac51eebc","user":{"login":"redhat-nfvpe","id":20420992,"avatar_url":"https://avatars0.githubusercontent.com/u/20420992?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-nfvpe","html_url":"https://github.com/redhat-nfvpe","followers_url":"https://api.github.com/users/redhat-nfvpe/followers","following_url":"https://api.github.com/users/redhat-nfvpe/following{/other_user}","gists_url":"https://api.github.com/users/redhat-nfvpe/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-nfvpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-nfvpe/subscriptions","organizations_url":"https://api.github.com/users/redhat-nfvpe/orgs","repos_url":"https://api.github.com/users/redhat-nfvpe/repos","events_url":"https://api.github.com/users/redhat-nfvpe/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-nfvpe/received_events","type":"Organization","site_admin":false},"repo":{"id":82108875,"name":"kube-ansible","full_name":"redhat-nfvpe/kube-ansible","owner":{"login":"redhat-nfvpe","id":20420992,"avatar_url":"https://avatars0.githubusercontent.com/u/20420992?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-nfvpe","html_url":"https://github.com/redhat-nfvpe","followers_url":"https://api.github.com/users/redhat-nfvpe/followers","following_url":"https://api.github.com/users/redhat-nfvpe/following{/other_user}","gists_url":"https://api.github.com/users/redhat-nfvpe/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-nfvpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-nfvpe/subscriptions","organizations_url":"https://api.github.com/users/redhat-nfvpe/orgs","repos_url":"https://api.github.com/users/redhat-nfvpe/repos","events_url":"https://api.github.com/users/redhat-nfvpe/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-nfvpe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-nfvpe/kube-ansible","description":"Spin up a Kubernetes development environment","fork":false,"url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible","forks_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/forks","keys_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/teams","hooks_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/hooks","issue_events_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/events","assignees_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/tags","blobs_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/languages","stargazers_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/stargazers","contributors_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/contributors","subscribers_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/subscribers","subscription_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/subscription","commits_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/merges","archive_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/downloads","issues_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/labels{/name}","releases_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/deployments","created_at":"2017-02-15T21:30:35Z","updated_at":"2018-03-20T14:51:56Z","pushed_at":"2018-03-20T20:32:55Z","git_url":"git://github.com/redhat-nfvpe/kube-ansible.git","ssh_url":"git@github.com:redhat-nfvpe/kube-ansible.git","clone_url":"https://github.com/redhat-nfvpe/kube-ansible.git","svn_url":"https://github.com/redhat-nfvpe/kube-ansible","homepage":"","size":360,"stargazers_count":45,"watchers_count":45,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":29,"watchers":45,"default_branch":"master"}},"base":{"label":"redhat-nfvpe:master","ref":"master","sha":"c5f2d1e31bacdd521401a5a91d7fbd5f91326d46","user":{"login":"redhat-nfvpe","id":20420992,"avatar_url":"https://avatars0.githubusercontent.com/u/20420992?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-nfvpe","html_url":"https://github.com/redhat-nfvpe","followers_url":"https://api.github.com/users/redhat-nfvpe/followers","following_url":"https://api.github.com/users/redhat-nfvpe/following{/other_user}","gists_url":"https://api.github.com/users/redhat-nfvpe/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-nfvpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-nfvpe/subscriptions","organizations_url":"https://api.github.com/users/redhat-nfvpe/orgs","repos_url":"https://api.github.com/users/redhat-nfvpe/repos","events_url":"https://api.github.com/users/redhat-nfvpe/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-nfvpe/received_events","type":"Organization","site_admin":false},"repo":{"id":82108875,"name":"kube-ansible","full_name":"redhat-nfvpe/kube-ansible","owner":{"login":"redhat-nfvpe","id":20420992,"avatar_url":"https://avatars0.githubusercontent.com/u/20420992?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-nfvpe","html_url":"https://github.com/redhat-nfvpe","followers_url":"https://api.github.com/users/redhat-nfvpe/followers","following_url":"https://api.github.com/users/redhat-nfvpe/following{/other_user}","gists_url":"https://api.github.com/users/redhat-nfvpe/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-nfvpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-nfvpe/subscriptions","organizations_url":"https://api.github.com/users/redhat-nfvpe/orgs","repos_url":"https://api.github.com/users/redhat-nfvpe/repos","events_url":"https://api.github.com/users/redhat-nfvpe/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-nfvpe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-nfvpe/kube-ansible","description":"Spin up a Kubernetes development environment","fork":false,"url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible","forks_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/forks","keys_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/teams","hooks_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/hooks","issue_events_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/events","assignees_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/tags","blobs_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/languages","stargazers_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/stargazers","contributors_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/contributors","subscribers_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/subscribers","subscription_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/subscription","commits_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/merges","archive_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/downloads","issues_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/labels{/name}","releases_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/deployments","created_at":"2017-02-15T21:30:35Z","updated_at":"2018-03-20T14:51:56Z","pushed_at":"2018-03-20T20:32:55Z","git_url":"git://github.com/redhat-nfvpe/kube-ansible.git","ssh_url":"git@github.com:redhat-nfvpe/kube-ansible.git","clone_url":"https://github.com/redhat-nfvpe/kube-ansible.git","svn_url":"https://github.com/redhat-nfvpe/kube-ansible","homepage":"","size":360,"stargazers_count":45,"watchers_count":45,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":29,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202"},"html":{"href":"https://github.com/redhat-nfvpe/kube-ansible/pull/202"},"issue":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/202"},"comments":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-nfvpe/kube-ansible/statuses/4f7dd06dfb305be5482c04ab30379d26ac51eebc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"s1061123"}}