{"action":"created","issue":{"url":"https://api.github.com/repos/trailofbits/algo/issues/1144","repository_url":"https://api.github.com/repos/trailofbits/algo","labels_url":"https://api.github.com/repos/trailofbits/algo/issues/1144/labels{/name}","comments_url":"https://api.github.com/repos/trailofbits/algo/issues/1144/comments","events_url":"https://api.github.com/repos/trailofbits/algo/issues/1144/events","html_url":"https://github.com/trailofbits/algo/pull/1144","id":367597120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTc1NjY3","number":1144,"title":"allow optionally assigning a floating ip to the droplet","user":{"login":"doy","id":78547,"node_id":"MDQ6VXNlcjc4NTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/78547?v=4","gravatar_id":"","url":"https://api.github.com/users/doy","html_url":"https://github.com/doy","followers_url":"https://api.github.com/users/doy/followers","following_url":"https://api.github.com/users/doy/following{/other_user}","gists_url":"https://api.github.com/users/doy/gists{/gist_id}","starred_url":"https://api.github.com/users/doy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doy/subscriptions","organizations_url":"https://api.github.com/users/doy/orgs","repos_url":"https://api.github.com/users/doy/repos","events_url":"https://api.github.com/users/doy/events{/privacy}","received_events_url":"https://api.github.com/users/doy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-07T21:48:09Z","updated_at":"2018-10-10T17:36:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/trailofbits/algo/pulls/1144","html_url":"https://github.com/trailofbits/algo/pull/1144","diff_url":"https://github.com/trailofbits/algo/pull/1144.diff","patch_url":"https://github.com/trailofbits/algo/pull/1144.patch"},"body":"## Description\r\nif the user has any unassigned floating ips, prompt the user to see if they would like to use one of them when creating the droplet. if the user has no existing floating ips, or if they are all already assigned to droplets, proceed as before without prompting.\r\n\r\n## Motivation and Context\r\nsimplifies rebuilds, since using a floating ip means i can just distribute the new keys without having to also modify my configuration files.\r\n\r\n## How Has This Been Tested?\r\nran `algo` with a free floating ip, both when selecting it and not, and ran it with no free floating ips. in all cases, it did the right thing.\r\n\r\n## Types of changes\r\n- [] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] My code follows the code style of this project.\r\n- [] My change requires a change to the documentation.\r\n- [] I have updated the documentation accordingly.\r\n- [] I have added tests to cover my changes.\r\n- [] All new and existing tests passed.\r\n\r\nit doesn't look like the digitalocean code has any automated tests currently - let me know if there's something you'd like me to do there."},"comment":{"url":"https://api.github.com/repos/trailofbits/algo/issues/comments/428662687","html_url":"https://github.com/trailofbits/algo/pull/1144#issuecomment-428662687","issue_url":"https://api.github.com/repos/trailofbits/algo/issues/1144","id":428662687,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODY2MjY4Nw==","user":{"login":"jackivanov","id":17044561,"node_id":"MDQ6VXNlcjE3MDQ0NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/17044561?v=4","gravatar_id":"","url":"https://api.github.com/users/jackivanov","html_url":"https://github.com/jackivanov","followers_url":"https://api.github.com/users/jackivanov/followers","following_url":"https://api.github.com/users/jackivanov/following{/other_user}","gists_url":"https://api.github.com/users/jackivanov/gists{/gist_id}","starred_url":"https://api.github.com/users/jackivanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackivanov/subscriptions","organizations_url":"https://api.github.com/users/jackivanov/orgs","repos_url":"https://api.github.com/users/jackivanov/repos","events_url":"https://api.github.com/users/jackivanov/events{/privacy}","received_events_url":"https://api.github.com/users/jackivanov/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T17:36:17Z","updated_at":"2018-10-10T17:36:17Z","author_association":"COLLABORATOR","body":"I don't think we should add a prompt for that. You can just add the option [here](https://github.com/trailofbits/algo/blob/master/config.cfg#L107) like for GCE"}}
{"actor":{"display_login":"jackivanov"}}