{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/201788195","pull_request_review_id":136358109,"id":201788195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc4ODE5NQ==","diff_hunk":"@@ -77,36 +74,40 @@\n \t\t},\n \t\t_fetchTabSearchActions: function() {\n \t\t\treturn Promise.all([\n-\t\t\t\tthis.fetchSirenEntity(this.enrollmentsUrl),\n \t\t\t\tthis.fetchSirenEntity(this.promotedSearches),\n \t\t\t\tthis.fetchSirenEntity(this.userSettingsUrl)\n \t\t\t])\n \t\t\t\t.then(function(values) {\n-\t\t\t\t\tvar enrollmentsRootEntity = values[0];\n-\t\t\t\t\tvar promotedSearchesEntity = values[1];\n-\t\t\t\t\tvar userSettingsEntity = values[2];\n-\t\t\t\t\tvar tabSearchActions = [];\n+\t\t\t\t\tvar promotedSearchesEntity = values[0];\n+\t\t\t\t\tvar userSettingsEntity = values[1];\n+\n+\t\t\t\t\tif (!promotedSearchesEntity || !promotedSearchesEntity.properties) {\n+\t\t\t\t\t\treturn;\n+\t\t\t\t\t}\n+\n+\t\t\t\t\tthis._tabSearchType = promotedSearchesEntity.properties.UserEnrollmentsSearchType;\n+\n+\t\t\t\t\tif(promotedSearchesEntity.actions.length < 2 || !promotedSearchesEntity.actions) {","path":"src/d2l-my-courses-content/d2l-my-courses-behavior.html","position":49,"original_position":49,"commit_id":"019975473a2bddecb6a422e0720555380f6b3320","original_commit_id":"019975473a2bddecb6a422e0720555380f6b3320","user":{"login":"ryantmer","id":6231623,"node_id":"MDQ6VXNlcjYyMzE2MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6231623?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"body":"Ah JS, where the order of `||` matters!\r\n\r\n(The order of the conditions here is backwards 😄)","created_at":"2018-07-11T18:02:17Z","updated_at":"2018-07-11T18:08:56Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567#discussion_r201788195","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/201788195"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567#discussion_r201788195"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567","id":200769833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzY5ODMz","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/567","number":567,"state":"open","locked":false,"title":"DE30375: Remove use-saved-searches attribute in favour of checking th…","user":{"login":"njostonehouse","id":5035319,"node_id":"MDQ6VXNlcjUwMzUzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5035319?v=4","gravatar_id":"","url":"https://api.github.com/users/njostonehouse","html_url":"https://github.com/njostonehouse","followers_url":"https://api.github.com/users/njostonehouse/followers","following_url":"https://api.github.com/users/njostonehouse/following{/other_user}","gists_url":"https://api.github.com/users/njostonehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/njostonehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njostonehouse/subscriptions","organizations_url":"https://api.github.com/users/njostonehouse/orgs","repos_url":"https://api.github.com/users/njostonehouse/repos","events_url":"https://api.github.com/users/njostonehouse/events{/privacy}","received_events_url":"https://api.github.com/users/njostonehouse/received_events","type":"User","site_admin":false},"body":"…e tab collection's size.","created_at":"2018-07-11T17:14:45Z","updated_at":"2018-07-11T18:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17942e8228715645125d6e5eb3cdf76a4d202904","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jlai-d2l","id":10850030,"node_id":"MDQ6VXNlcjEwODUwMDMw","avatar_url":"https://avatars2.githubusercontent.com/u/10850030?v=4","gravatar_id":"","url":"https://api.github.com/users/jlai-d2l","html_url":"https://github.com/jlai-d2l","followers_url":"https://api.github.com/users/jlai-d2l/followers","following_url":"https://api.github.com/users/jlai-d2l/following{/other_user}","gists_url":"https://api.github.com/users/jlai-d2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jlai-d2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlai-d2l/subscriptions","organizations_url":"https://api.github.com/users/jlai-d2l/orgs","repos_url":"https://api.github.com/users/jlai-d2l/repos","events_url":"https://api.github.com/users/jlai-d2l/events{/privacy}","received_events_url":"https://api.github.com/users/jlai-d2l/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/567/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/019975473a2bddecb6a422e0720555380f6b3320","head":{"label":"Brightspace:nstonehouse/DE30375/tab-length","ref":"nstonehouse/DE30375/tab-length","sha":"019975473a2bddecb6a422e0720555380f6b3320","user":{"login":"Brightspace","id":5429170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjkxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQ5MjM5OA==","name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjkxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2018-07-11T17:03:33Z","pushed_at":"2018-07-11T17:20:45Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":2067,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"2aac1e69564b8b8f71bfa72e0e2a222dc0ed1627","user":{"login":"Brightspace","id":5429170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjkxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQ5MjM5OA==","name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjkxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2018-07-11T17:03:33Z","pushed_at":"2018-07-11T17:20:45Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":2067,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/567"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/567"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/019975473a2bddecb6a422e0720555380f6b3320"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryantmer"}}