{"action":"opened","number":21211,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21211","id":193623864,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjIzODY0","html_url":"https://github.com/nodejs/node/pull/21211","diff_url":"https://github.com/nodejs/node/pull/21211.diff","patch_url":"https://github.com/nodejs/node/pull/21211.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21211","number":21211,"state":"open","locked":false,"title":"test: remove string literals from assert.strictEqual() calls","user":{"login":"kylstraj","id":38022880,"node_id":"MDQ6VXNlcjM4MDIyODgw","avatar_url":"https://avatars0.githubusercontent.com/u/38022880?v=4","gravatar_id":"","url":"https://api.github.com/users/kylstraj","html_url":"https://github.com/kylstraj","followers_url":"https://api.github.com/users/kylstraj/followers","following_url":"https://api.github.com/users/kylstraj/following{/other_user}","gists_url":"https://api.github.com/users/kylstraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kylstraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylstraj/subscriptions","organizations_url":"https://api.github.com/users/kylstraj/orgs","repos_url":"https://api.github.com/users/kylstraj/repos","events_url":"https://api.github.com/users/kylstraj/events{/privacy}","received_events_url":"https://api.github.com/users/kylstraj/received_events","type":"User","site_admin":false},"body":"In test/parallel/test-intl.js, five calls to assert.strictEqual() use a\r\nthird, string-literal parameter, which specifies a message to display\r\nwhen the assertion fails. The problem is that if the assertion fails,\r\nthe error message will show the string literal but not the values that\r\ncaused the assertion to fail.\r\n\r\nThis commit removes the third parameter from the five calls and makes\r\nthem comments above the assertions instead. The default error message\r\nproduced by assert.strictEqual() shows the values that caused the\r\nassertion to fail, which should be somewhat more helpful.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-06-08T14:03:14Z","updated_at":"2018-06-08T14:03:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21211/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21211/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21211/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/cedd813f524449cf8691fb273201bb114104d060","head":{"label":"kylstraj:kylstra-branch","ref":"kylstra-branch","sha":"cedd813f524449cf8691fb273201bb114104d060","user":{"login":"kylstraj","id":38022880,"node_id":"MDQ6VXNlcjM4MDIyODgw","avatar_url":"https://avatars0.githubusercontent.com/u/38022880?v=4","gravatar_id":"","url":"https://api.github.com/users/kylstraj","html_url":"https://github.com/kylstraj","followers_url":"https://api.github.com/users/kylstraj/followers","following_url":"https://api.github.com/users/kylstraj/following{/other_user}","gists_url":"https://api.github.com/users/kylstraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kylstraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylstraj/subscriptions","organizations_url":"https://api.github.com/users/kylstraj/orgs","repos_url":"https://api.github.com/users/kylstraj/repos","events_url":"https://api.github.com/users/kylstraj/events{/privacy}","received_events_url":"https://api.github.com/users/kylstraj/received_events","type":"User","site_admin":false},"repo":{"id":136085514,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODU1MTQ=","name":"node","full_name":"kylstraj/node","owner":{"login":"kylstraj","id":38022880,"node_id":"MDQ6VXNlcjM4MDIyODgw","avatar_url":"https://avatars0.githubusercontent.com/u/38022880?v=4","gravatar_id":"","url":"https://api.github.com/users/kylstraj","html_url":"https://github.com/kylstraj","followers_url":"https://api.github.com/users/kylstraj/followers","following_url":"https://api.github.com/users/kylstraj/following{/other_user}","gists_url":"https://api.github.com/users/kylstraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kylstraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylstraj/subscriptions","organizations_url":"https://api.github.com/users/kylstraj/orgs","repos_url":"https://api.github.com/users/kylstraj/repos","events_url":"https://api.github.com/users/kylstraj/events{/privacy}","received_events_url":"https://api.github.com/users/kylstraj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kylstraj/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/kylstraj/node","forks_url":"https://api.github.com/repos/kylstraj/node/forks","keys_url":"https://api.github.com/repos/kylstraj/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kylstraj/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kylstraj/node/teams","hooks_url":"https://api.github.com/repos/kylstraj/node/hooks","issue_events_url":"https://api.github.com/repos/kylstraj/node/issues/events{/number}","events_url":"https://api.github.com/repos/kylstraj/node/events","assignees_url":"https://api.github.com/repos/kylstraj/node/assignees{/user}","branches_url":"https://api.github.com/repos/kylstraj/node/branches{/branch}","tags_url":"https://api.github.com/repos/kylstraj/node/tags","blobs_url":"https://api.github.com/repos/kylstraj/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kylstraj/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kylstraj/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/kylstraj/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kylstraj/node/statuses/{sha}","languages_url":"https://api.github.com/repos/kylstraj/node/languages","stargazers_url":"https://api.github.com/repos/kylstraj/node/stargazers","contributors_url":"https://api.github.com/repos/kylstraj/node/contributors","subscribers_url":"https://api.github.com/repos/kylstraj/node/subscribers","subscription_url":"https://api.github.com/repos/kylstraj/node/subscription","commits_url":"https://api.github.com/repos/kylstraj/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/kylstraj/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/kylstraj/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/kylstraj/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/kylstraj/node/contents/{+path}","compare_url":"https://api.github.com/repos/kylstraj/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kylstraj/node/merges","archive_url":"https://api.github.com/repos/kylstraj/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kylstraj/node/downloads","issues_url":"https://api.github.com/repos/kylstraj/node/issues{/number}","pulls_url":"https://api.github.com/repos/kylstraj/node/pulls{/number}","milestones_url":"https://api.github.com/repos/kylstraj/node/milestones{/number}","notifications_url":"https://api.github.com/repos/kylstraj/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kylstraj/node/labels{/name}","releases_url":"https://api.github.com/repos/kylstraj/node/releases{/id}","deployments_url":"https://api.github.com/repos/kylstraj/node/deployments","created_at":"2018-06-04T21:35:56Z","updated_at":"2018-06-04T21:36:31Z","pushed_at":"2018-06-08T14:01:31Z","git_url":"git://github.com/kylstraj/node.git","ssh_url":"git@github.com:kylstraj/node.git","clone_url":"https://github.com/kylstraj/node.git","svn_url":"https://github.com/kylstraj/node","homepage":"https://nodejs.org","size":382028,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"6ac3c44012cf0a52c3d586c4fcf473d98fce69ef","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-06-08T14:01:09Z","pushed_at":"2018-06-08T12:38:22Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":384076,"stargazers_count":49993,"watchers_count":49993,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10510,"mirror_url":null,"archived":false,"open_issues_count":707,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10510,"open_issues":707,"watchers":49993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21211"},"html":{"href":"https://github.com/nodejs/node/pull/21211"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21211"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21211/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21211/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21211/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/cedd813f524449cf8691fb273201bb114104d060"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"kylstraj"}}