{"action":"created","comment":{"url":"https://api.github.com/repos/moov-io/infra/pulls/comments/220722113","pull_request_review_id":159196893,"id":220722113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDcyMjExMw==","diff_hunk":"@@ -0,0 +1,60 @@\n+## secrets","path":"docs/secrets.md","position":1,"original_position":1,"commit_id":"e901cd85391d4bb689dd6b2b1b2997a7768edf45","original_commit_id":"e901cd85391d4bb689dd6b2b1b2997a7768edf45","user":{"login":"adamdecaf","id":120951,"node_id":"MDQ6VXNlcjEyMDk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/120951?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"body":"This doc can use some more detail. It's a bit sparse still. ","created_at":"2018-09-26T21:01:18Z","updated_at":"2018-09-26T21:01:18Z","html_url":"https://github.com/moov-io/infra/pull/13#discussion_r220722113","pull_request_url":"https://api.github.com/repos/moov-io/infra/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moov-io/infra/pulls/comments/220722113"},"html":{"href":"https://github.com/moov-io/infra/pull/13#discussion_r220722113"},"pull_request":{"href":"https://api.github.com/repos/moov-io/infra/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/moov-io/infra/pulls/13","id":218453099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDUzMDk5","html_url":"https://github.com/moov-io/infra/pull/13","diff_url":"https://github.com/moov-io/infra/pull/13.diff","patch_url":"https://github.com/moov-io/infra/pull/13.patch","issue_url":"https://api.github.com/repos/moov-io/infra/issues/13","number":13,"state":"open","locked":false,"title":"initial setup for storing secrets ","user":{"login":"adamdecaf","id":120951,"node_id":"MDQ6VXNlcjEyMDk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/120951?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"body":"We needed a way to store k8s secret objects, which right now are holding: \r\n\r\n```yaml\r\n---\r\napiVersion: v1\r\nkind: Secret\r\nmetadata:\r\n  name: oauth2-proxy-config\r\n  namespace: infra\r\ntype: Opaque\r\ndata:\r\n  client_id:\r\n  client_secret:\r\n  cookie_secret:\r\n---\r\napiVersion: v1\r\nkind: Secret\r\nmetadata:\r\n  name: grafana-secrets\r\n  namespace: infra\r\ntype: Opaque\r\ndata:\r\n  admin_user:\r\n  admin_password:\r\n  secret_key:\r\n```\r\n\r\nOther than that this PR also sets up Terraform \"remote storage\" via Google Cloud Storage (GCS), which also give us state locking. (We can't get out of sync across machines.)","created_at":"2018-09-26T20:59:43Z","updated_at":"2018-09-26T21:01:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d873ccbeac1c80eb7dd0f9397c92aac684586a0b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wadearnold","id":32989,"node_id":"MDQ6VXNlcjMyOTg5","avatar_url":"https://avatars1.githubusercontent.com/u/32989?v=4","gravatar_id":"","url":"https://api.github.com/users/wadearnold","html_url":"https://github.com/wadearnold","followers_url":"https://api.github.com/users/wadearnold/followers","following_url":"https://api.github.com/users/wadearnold/following{/other_user}","gists_url":"https://api.github.com/users/wadearnold/gists{/gist_id}","starred_url":"https://api.github.com/users/wadearnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wadearnold/subscriptions","organizations_url":"https://api.github.com/users/wadearnold/orgs","repos_url":"https://api.github.com/users/wadearnold/repos","events_url":"https://api.github.com/users/wadearnold/events{/privacy}","received_events_url":"https://api.github.com/users/wadearnold/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1070574013,"node_id":"MDU6TGFiZWwxMDcwNTc0MDEz","url":"https://api.github.com/repos/moov-io/infra/labels/security","name":"security","color":"fce19f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moov-io/infra/pulls/13/commits","review_comments_url":"https://api.github.com/repos/moov-io/infra/pulls/13/comments","review_comment_url":"https://api.github.com/repos/moov-io/infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moov-io/infra/issues/13/comments","statuses_url":"https://api.github.com/repos/moov-io/infra/statuses/e901cd85391d4bb689dd6b2b1b2997a7768edf45","head":{"label":"adamdecaf:secrets","ref":"secrets","sha":"e901cd85391d4bb689dd6b2b1b2997a7768edf45","user":{"login":"adamdecaf","id":120951,"node_id":"MDQ6VXNlcjEyMDk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/120951?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"repo":{"id":149169161,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxNjkxNjE=","name":"infra","full_name":"adamdecaf/infra","private":false,"owner":{"login":"adamdecaf","id":120951,"node_id":"MDQ6VXNlcjEyMDk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/120951?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adamdecaf/infra","description":"Infrastrucutre setup for moov.io properties","fork":true,"url":"https://api.github.com/repos/adamdecaf/infra","forks_url":"https://api.github.com/repos/adamdecaf/infra/forks","keys_url":"https://api.github.com/repos/adamdecaf/infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamdecaf/infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamdecaf/infra/teams","hooks_url":"https://api.github.com/repos/adamdecaf/infra/hooks","issue_events_url":"https://api.github.com/repos/adamdecaf/infra/issues/events{/number}","events_url":"https://api.github.com/repos/adamdecaf/infra/events","assignees_url":"https://api.github.com/repos/adamdecaf/infra/assignees{/user}","branches_url":"https://api.github.com/repos/adamdecaf/infra/branches{/branch}","tags_url":"https://api.github.com/repos/adamdecaf/infra/tags","blobs_url":"https://api.github.com/repos/adamdecaf/infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamdecaf/infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamdecaf/infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamdecaf/infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamdecaf/infra/statuses/{sha}","languages_url":"https://api.github.com/repos/adamdecaf/infra/languages","stargazers_url":"https://api.github.com/repos/adamdecaf/infra/stargazers","contributors_url":"https://api.github.com/repos/adamdecaf/infra/contributors","subscribers_url":"https://api.github.com/repos/adamdecaf/infra/subscribers","subscription_url":"https://api.github.com/repos/adamdecaf/infra/subscription","commits_url":"https://api.github.com/repos/adamdecaf/infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamdecaf/infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamdecaf/infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamdecaf/infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamdecaf/infra/contents/{+path}","compare_url":"https://api.github.com/repos/adamdecaf/infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamdecaf/infra/merges","archive_url":"https://api.github.com/repos/adamdecaf/infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamdecaf/infra/downloads","issues_url":"https://api.github.com/repos/adamdecaf/infra/issues{/number}","pulls_url":"https://api.github.com/repos/adamdecaf/infra/pulls{/number}","milestones_url":"https://api.github.com/repos/adamdecaf/infra/milestones{/number}","notifications_url":"https://api.github.com/repos/adamdecaf/infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamdecaf/infra/labels{/name}","releases_url":"https://api.github.com/repos/adamdecaf/infra/releases{/id}","deployments_url":"https://api.github.com/repos/adamdecaf/infra/deployments","created_at":"2018-09-17T18:21:40Z","updated_at":"2018-09-25T23:12:51Z","pushed_at":"2018-09-26T20:55:35Z","git_url":"git://github.com/adamdecaf/infra.git","ssh_url":"git@github.com:adamdecaf/infra.git","clone_url":"https://github.com/adamdecaf/infra.git","svn_url":"https://github.com/adamdecaf/infra","homepage":"","size":63,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moov-io:master","ref":"master","sha":"a8330f0cdb6ef736086981495a4718dde9fa3653","user":{"login":"moov-io","id":26097026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDk3MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/26097026?v=4","gravatar_id":"","url":"https://api.github.com/users/moov-io","html_url":"https://github.com/moov-io","followers_url":"https://api.github.com/users/moov-io/followers","following_url":"https://api.github.com/users/moov-io/following{/other_user}","gists_url":"https://api.github.com/users/moov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/moov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moov-io/subscriptions","organizations_url":"https://api.github.com/users/moov-io/orgs","repos_url":"https://api.github.com/users/moov-io/repos","events_url":"https://api.github.com/users/moov-io/events{/privacy}","received_events_url":"https://api.github.com/users/moov-io/received_events","type":"Organization","site_admin":false},"repo":{"id":145154213,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTQyMTM=","name":"infra","full_name":"moov-io/infra","private":false,"owner":{"login":"moov-io","id":26097026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDk3MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/26097026?v=4","gravatar_id":"","url":"https://api.github.com/users/moov-io","html_url":"https://github.com/moov-io","followers_url":"https://api.github.com/users/moov-io/followers","following_url":"https://api.github.com/users/moov-io/following{/other_user}","gists_url":"https://api.github.com/users/moov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/moov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moov-io/subscriptions","organizations_url":"https://api.github.com/users/moov-io/orgs","repos_url":"https://api.github.com/users/moov-io/repos","events_url":"https://api.github.com/users/moov-io/events{/privacy}","received_events_url":"https://api.github.com/users/moov-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moov-io/infra","description":"Infrastrucutre setup for moov.io properties","fork":false,"url":"https://api.github.com/repos/moov-io/infra","forks_url":"https://api.github.com/repos/moov-io/infra/forks","keys_url":"https://api.github.com/repos/moov-io/infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moov-io/infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moov-io/infra/teams","hooks_url":"https://api.github.com/repos/moov-io/infra/hooks","issue_events_url":"https://api.github.com/repos/moov-io/infra/issues/events{/number}","events_url":"https://api.github.com/repos/moov-io/infra/events","assignees_url":"https://api.github.com/repos/moov-io/infra/assignees{/user}","branches_url":"https://api.github.com/repos/moov-io/infra/branches{/branch}","tags_url":"https://api.github.com/repos/moov-io/infra/tags","blobs_url":"https://api.github.com/repos/moov-io/infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moov-io/infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moov-io/infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/moov-io/infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moov-io/infra/statuses/{sha}","languages_url":"https://api.github.com/repos/moov-io/infra/languages","stargazers_url":"https://api.github.com/repos/moov-io/infra/stargazers","contributors_url":"https://api.github.com/repos/moov-io/infra/contributors","subscribers_url":"https://api.github.com/repos/moov-io/infra/subscribers","subscription_url":"https://api.github.com/repos/moov-io/infra/subscription","commits_url":"https://api.github.com/repos/moov-io/infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/moov-io/infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/moov-io/infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/moov-io/infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/moov-io/infra/contents/{+path}","compare_url":"https://api.github.com/repos/moov-io/infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moov-io/infra/merges","archive_url":"https://api.github.com/repos/moov-io/infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moov-io/infra/downloads","issues_url":"https://api.github.com/repos/moov-io/infra/issues{/number}","pulls_url":"https://api.github.com/repos/moov-io/infra/pulls{/number}","milestones_url":"https://api.github.com/repos/moov-io/infra/milestones{/number}","notifications_url":"https://api.github.com/repos/moov-io/infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moov-io/infra/labels{/name}","releases_url":"https://api.github.com/repos/moov-io/infra/releases{/id}","deployments_url":"https://api.github.com/repos/moov-io/infra/deployments","created_at":"2018-08-17T18:30:33Z","updated_at":"2018-09-25T23:12:36Z","pushed_at":"2018-09-26T20:59:44Z","git_url":"git://github.com/moov-io/infra.git","ssh_url":"git@github.com:moov-io/infra.git","clone_url":"https://github.com/moov-io/infra.git","svn_url":"https://github.com/moov-io/infra","homepage":"","size":62,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moov-io/infra/pulls/13"},"html":{"href":"https://github.com/moov-io/infra/pull/13"},"issue":{"href":"https://api.github.com/repos/moov-io/infra/issues/13"},"comments":{"href":"https://api.github.com/repos/moov-io/infra/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/moov-io/infra/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/moov-io/infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moov-io/infra/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/moov-io/infra/statuses/e901cd85391d4bb689dd6b2b1b2997a7768edf45"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adamdecaf"}}