{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/5939","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/5939/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5939/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/5939/events","html_url":"https://github.com/theforeman/foreman/pull/5939","id":349803267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODE1Njg2","number":5939,"title":"fixes #24590 - adds missing packages to the vendor bundle","user":{"login":"ohadlevy","id":20167,"node_id":"MDQ6VXNlcjIwMTY3","avatar_url":"https://avatars1.githubusercontent.com/u/20167?v=4","gravatar_id":"","url":"https://api.github.com/users/ohadlevy","html_url":"https://github.com/ohadlevy","followers_url":"https://api.github.com/users/ohadlevy/followers","following_url":"https://api.github.com/users/ohadlevy/following{/other_user}","gists_url":"https://api.github.com/users/ohadlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/ohadlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohadlevy/subscriptions","organizations_url":"https://api.github.com/users/ohadlevy/orgs","repos_url":"https://api.github.com/users/ohadlevy/repos","events_url":"https://api.github.com/users/ohadlevy/events{/privacy}","received_events_url":"https://api.github.com/users/ohadlevy/received_events","type":"User","site_admin":false},"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-12T10:58:44Z","updated_at":"2018-08-13T08:32:05Z","closed_at":"2018-08-13T08:26:49Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5939","html_url":"https://github.com/theforeman/foreman/pull/5939","diff_url":"https://github.com/theforeman/foreman/pull/5939.diff","patch_url":"https://github.com/theforeman/foreman/pull/5939.patch"},"body":"This reduces plugin bundles, for example:\r\n\r\nBefore\r\n```\r\n         foreman_ansible-5d349cbac84354973187.js     191 kB\r\nforeman_remote_execution-f5d74437300f4b3c5b05.js     151 kB\r\n                  vendor-006110822861b6733af8.js    3.87 MB\r\n                  bundle-f60c9313893e777715a8.js     183 kB\r\n```\r\nAfter\r\n```\r\n         foreman_ansible-195d8978baa8035f4120.js     168 kB\r\nforeman_remote_execution-b9b0d6b91ed13025743c.js     128 kB\r\n                  vendor-b6241de5b97d3aac0bf8.js    3.89 MB\r\n                  bundle-a70a5008863bfd5b2929.js     161 kB\r\n```\r\nThe large percentage remaining is the component registry it self, which\r\nshould be shared, but probably in another PR."},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/412445890","html_url":"https://github.com/theforeman/foreman/pull/5939#issuecomment-412445890","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5939","id":412445890,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQ0NTg5MA==","user":{"login":"ohadlevy","id":20167,"node_id":"MDQ6VXNlcjIwMTY3","avatar_url":"https://avatars1.githubusercontent.com/u/20167?v=4","gravatar_id":"","url":"https://api.github.com/users/ohadlevy","html_url":"https://github.com/ohadlevy","followers_url":"https://api.github.com/users/ohadlevy/followers","following_url":"https://api.github.com/users/ohadlevy/following{/other_user}","gists_url":"https://api.github.com/users/ohadlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/ohadlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohadlevy/subscriptions","organizations_url":"https://api.github.com/users/ohadlevy/orgs","repos_url":"https://api.github.com/users/ohadlevy/repos","events_url":"https://api.github.com/users/ohadlevy/events{/privacy}","received_events_url":"https://api.github.com/users/ohadlevy/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T08:32:05Z","updated_at":"2018-08-13T08:32:05Z","author_association":"MEMBER","body":"@tbrisker thanks, the main thing that is getting duplicated (easily seen with npm run analyze task) is actually the foreman components that are exposed though the mounter. if we move the mounter to the vendor file (or technically make the foreman bundle a kind of a vendor file too) the plugins will drop to below 20k (or exactly how many kb they are used by the plugin itself). the real worring part is that if a bug is fixed in foreman, its still present in the plugin duplicated code until the plugin recompile."}}
{"actor":{"display_login":"ohadlevy"}}