{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/209411219","pull_request_review_id":145430417,"id":209411219,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQxMTIxOQ==","diff_hunk":"@@ -446,5 +470,95 @@ config.run('amp-image-slider', function() {\n             return pollByBarLeftPos(rect.right);\n           });\n     });\n+\n+    it('should seekTo correct position', () => {\n+      let button;\n+      let pos10Percent;\n+      return prep()\n+          .then(() => {\n+            button = doc.querySelector('#button');\n+            pos10Percent = rect.left + 0.1 * rect.width;\n+            button.click();\n+            return pollByBarLeftPos(pos10Percent);\n+          });\n+    });\n+\n+    it('should show hint again on scroll back and into viewport', () => {\n+      let slider, container_, hint;\n+      let mouseDownEvent;\n+      return prep()\n+          .then(() => {\n+            slider = doc.querySelector('#slider');\n+            container_ = slider\n+                .querySelector('.i-amphtml-image-slider-container');\n+            hint = slider.querySelectorAll('.i-amphtml-image-slider-hint')[0];\n+            mouseDownEvent = createFakeEvent(\n+                'mousedown',\n+                0,\n+                0\n+            );\n+            container_.dispatchEvent(mouseDownEvent);\n+            return poll('should receive hidden class', () => {\n+              return hint.classList\n+                  .contains('i-amphtml-image-slider-hint-hidden');\n+            }, () => {});\n+          })\n+          .then(() => {\n+            env.win.scrollTo({\n+              top: 3000,\n+            });\n+            // Have to use timeout here,\n+            // no indication of proper viewportCallback trigger\n+            return timeout(env.win, 500);","path":"extensions/amp-image-slider/0.1/test/integration/test-amp-image-slider.js","position":158,"original_position":158,"commit_id":"1c18e28754de74db9df82632451dcd612da541b9","original_commit_id":"1c18e28754de74db9df82632451dcd612da541b9","user":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"body":"I could not override any methods or properties for integration tests (with --pseudo_names).\r\n\r\nI can check if `isInViewport()` is exposed, but I believe `--pseudo_names` probably also masked this. On the other hand, I would also need to double check if `isInViewport()` would always reflect whether `viewportCallback` is triggered already, or forcing the latter to trigger before returning from the call","created_at":"2018-08-11T00:47:56Z","updated_at":"2018-08-11T00:47:57Z","html_url":"https://github.com/ampproject/amphtml/pull/17445#discussion_r209411219","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/209411219"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17445#discussion_r209411219"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17445"}},"in_reply_to_id":209410248},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/17445","id":207742917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzQyOTE3","html_url":"https://github.com/ampproject/amphtml/pull/17445","diff_url":"https://github.com/ampproject/amphtml/pull/17445.diff","patch_url":"https://github.com/ampproject/amphtml/pull/17445.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/17445","number":17445,"state":"open","locked":false,"title":"✨[amp-image-slider] P1 Cleanup","user":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"body":"This is a list of updates that complies current amp-image-slider with P1 requirements:\r\n+ `amp-image-slider-hint-left` `amp-image-slider-hint-right` customizability\r\n+ exposing `.seekTo([0-1])` actions.'\r\n\r\n- [x] Update tests and demos\r\n- [x] Remove rejected legacy `disable-gesture` code\r\n- [x] Add documentation of `seekTo` and hint customization\r\n\r\nThis PR also updates the potential P2 feature `initial-percent` to `initial-slider-position`. Since it is a pending feature (along with already-implemented `step-size`), these are not exposed in documentation, nor are tests added for them\r\n","created_at":"2018-08-10T23:28:36Z","updated_at":"2018-08-11T00:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7c5611d2e45ed253ef1562e4195d1272dcf5726","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17445/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17445/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/17445/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/1c18e28754de74db9df82632451dcd612da541b9","head":{"label":"kevinkassimo:ais-p1-main","ref":"ais-p1-main","sha":"1c18e28754de74db9df82632451dcd612da541b9","user":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"repo":{"id":139289968,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyODk5Njg=","name":"amphtml","full_name":"kevinkassimo/amphtml","owner":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinkassimo/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/kevinkassimo/amphtml","forks_url":"https://api.github.com/repos/kevinkassimo/amphtml/forks","keys_url":"https://api.github.com/repos/kevinkassimo/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinkassimo/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinkassimo/amphtml/teams","hooks_url":"https://api.github.com/repos/kevinkassimo/amphtml/hooks","issue_events_url":"https://api.github.com/repos/kevinkassimo/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/kevinkassimo/amphtml/events","assignees_url":"https://api.github.com/repos/kevinkassimo/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/kevinkassimo/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/kevinkassimo/amphtml/tags","blobs_url":"https://api.github.com/repos/kevinkassimo/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinkassimo/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinkassimo/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinkassimo/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinkassimo/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinkassimo/amphtml/languages","stargazers_url":"https://api.github.com/repos/kevinkassimo/amphtml/stargazers","contributors_url":"https://api.github.com/repos/kevinkassimo/amphtml/contributors","subscribers_url":"https://api.github.com/repos/kevinkassimo/amphtml/subscribers","subscription_url":"https://api.github.com/repos/kevinkassimo/amphtml/subscription","commits_url":"https://api.github.com/repos/kevinkassimo/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinkassimo/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinkassimo/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinkassimo/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinkassimo/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/kevinkassimo/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinkassimo/amphtml/merges","archive_url":"https://api.github.com/repos/kevinkassimo/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinkassimo/amphtml/downloads","issues_url":"https://api.github.com/repos/kevinkassimo/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/kevinkassimo/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinkassimo/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinkassimo/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinkassimo/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/kevinkassimo/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/kevinkassimo/amphtml/deployments","created_at":"2018-07-01T00:40:47Z","updated_at":"2018-08-10T21:26:10Z","pushed_at":"2018-08-10T23:21:41Z","git_url":"git://github.com/kevinkassimo/amphtml.git","ssh_url":"git@github.com:kevinkassimo/amphtml.git","clone_url":"https://github.com/kevinkassimo/amphtml.git","svn_url":"https://github.com/kevinkassimo/amphtml","homepage":"https://www.ampproject.org","size":495225,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"3a22755ff92f10f58db394f46be8199788ec6c1a","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-08-10T23:09:32Z","pushed_at":"2018-08-11T00:13:00Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":494951,"stargazers_count":11843,"watchers_count":11843,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2527,"mirror_url":null,"archived":false,"open_issues_count":1320,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2527,"open_issues":1320,"watchers":11843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17445"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17445"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17445"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17445/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17445/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17445/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/1c18e28754de74db9df82632451dcd612da541b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kevinkassimo"}}