{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/211100762","pull_request_review_id":147456464,"id":211100762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEwMDc2Mg==","diff_hunk":"@@ -22,5 +60,59 @@ public bool IsSelf(IPEndPoint ipEndPoint)\n         {\n             return this.knownSelfEndpoints.Contains(ipEndPoint);\n         }\n+\n+        /// <inheritdoc/>\n+        public void UpdateAndAssignMyExternalAddress(IPEndPoint ipEndPoint, bool suppliedEndpointIsFinal, int ipEndPointScore = 0)\n+        {\n+            if (ipEndPoint == null)\n+            {\n+                this.logger.LogTrace(\"(IP ENDPOINT IS NULL)\");\n+                return;\n+            }\n+\n+            // override peer score if supplied\n+            if (ipEndPointScore != 0)","path":"src/Stratis.Bitcoin/P2P/SelfEndpointTracker.cs","position":67,"original_position":67,"commit_id":"db3aa3eb1b07dff798af717d987a8b9599fa5dd5","original_commit_id":"db3aa3eb1b07dff798af717d987a8b9599fa5dd5","user":{"login":"Aprogiena","id":30052221,"node_id":"MDQ6VXNlcjMwMDUyMjIx","avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"body":"also remove this if, we don't want it","created_at":"2018-08-19T11:58:00Z","updated_at":"2018-08-19T11:58:01Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900#discussion_r211100762","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/211100762"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900#discussion_r211100762"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900","id":207644196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjQ0MTk2","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1900","number":1900,"state":"open","locked":false,"title":"MyVersion.AddressFrom is not initialized properly (#1816).","user":{"login":"thefazzer","id":30984080,"node_id":"MDQ6VXNlcjMwOTg0MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/30984080?v=4","gravatar_id":"","url":"https://api.github.com/users/thefazzer","html_url":"https://github.com/thefazzer","followers_url":"https://api.github.com/users/thefazzer/followers","following_url":"https://api.github.com/users/thefazzer/following{/other_user}","gists_url":"https://api.github.com/users/thefazzer/gists{/gist_id}","starred_url":"https://api.github.com/users/thefazzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefazzer/subscriptions","organizations_url":"https://api.github.com/users/thefazzer/orgs","repos_url":"https://api.github.com/users/thefazzer/repos","events_url":"https://api.github.com/users/thefazzer/events{/privacy}","received_events_url":"https://api.github.com/users/thefazzer/received_events","type":"User","site_admin":false},"body":"- If external IP address supplied this overrides all.\r\n- If external IP address not supplied take first routeable bind address and set score to 10.\r\n- If none supplied or routableable take from version handshake.\r\n- If it was the same as value that was there we just increment the score by 1.\r\n- If it was different we decrement the score by 1.\r\n- If the new score is 0 we replace the old one with the new one with score 1.\r\n\r\nPreferred: @Aprogiena @noescape00","created_at":"2018-08-10T15:18:25Z","updated_at":"2018-08-19T11:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b083b952b6bcb6f3ddc834a7af4c422b33e3785c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926800905,"node_id":"MDU6TGFiZWw5MjY4MDA5MDU=","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/pr-review-medium","name":"pr-review-medium","color":"295182","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1900/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/db3aa3eb1b07dff798af717d987a8b9599fa5dd5","head":{"label":"thefazzer:fullnode_fazzdev_#1816_encore","ref":"fullnode_fazzdev_#1816_encore","sha":"db3aa3eb1b07dff798af717d987a8b9599fa5dd5","user":{"login":"thefazzer","id":30984080,"node_id":"MDQ6VXNlcjMwOTg0MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/30984080?v=4","gravatar_id":"","url":"https://api.github.com/users/thefazzer","html_url":"https://github.com/thefazzer","followers_url":"https://api.github.com/users/thefazzer/followers","following_url":"https://api.github.com/users/thefazzer/following{/other_user}","gists_url":"https://api.github.com/users/thefazzer/gists{/gist_id}","starred_url":"https://api.github.com/users/thefazzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefazzer/subscriptions","organizations_url":"https://api.github.com/users/thefazzer/orgs","repos_url":"https://api.github.com/users/thefazzer/repos","events_url":"https://api.github.com/users/thefazzer/events{/privacy}","received_events_url":"https://api.github.com/users/thefazzer/received_events","type":"User","site_admin":false},"repo":{"id":132759918,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3NTk5MTg=","name":"StratisBitcoinFullNode","full_name":"thefazzer/StratisBitcoinFullNode","owner":{"login":"thefazzer","id":30984080,"node_id":"MDQ6VXNlcjMwOTg0MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/30984080?v=4","gravatar_id":"","url":"https://api.github.com/users/thefazzer","html_url":"https://github.com/thefazzer","followers_url":"https://api.github.com/users/thefazzer/followers","following_url":"https://api.github.com/users/thefazzer/following{/other_user}","gists_url":"https://api.github.com/users/thefazzer/gists{/gist_id}","starred_url":"https://api.github.com/users/thefazzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefazzer/subscriptions","organizations_url":"https://api.github.com/users/thefazzer/orgs","repos_url":"https://api.github.com/users/thefazzer/repos","events_url":"https://api.github.com/users/thefazzer/events{/privacy}","received_events_url":"https://api.github.com/users/thefazzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thefazzer/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/thefazzer/StratisBitcoinFullNode/deployments","created_at":"2018-05-09T13:19:19Z","updated_at":"2018-05-18T14:38:43Z","pushed_at":"2018-08-19T10:51:11Z","git_url":"git://github.com/thefazzer/StratisBitcoinFullNode.git","ssh_url":"git@github.com:thefazzer/StratisBitcoinFullNode.git","clone_url":"https://github.com/thefazzer/StratisBitcoinFullNode.git","svn_url":"https://github.com/thefazzer/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":31536,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"fd7c6f3c5faad0ee2b036f03c88fd05ad963007d","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-18T19:04:24Z","pushed_at":"2018-08-19T10:51:13Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":32746,"stargazers_count":532,"watchers_count":532,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":154,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1900"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1900"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1900/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1900/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/db3aa3eb1b07dff798af717d987a8b9599fa5dd5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aprogiena"}}