{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/194266936","pull_request_review_id":127406542,"id":194266936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI2NjkzNg==","diff_hunk":"@@ -429,24 +433,17 @@ def validate_textangular_format(html_list, run_migration=False):\n         ['ALLOWED_TAG_LIST'])\n \n     for html_data in html_list:\n-        try:\n-            if run_migration:\n-                # <br> is replaced with <br/> before conversion because\n-                # BeautifulSoup in some cases adds </br> closing tag\n-                # and br is reported as parent of other tags which\n-                # produces issues in validation.\n-                migrated_data = convert_to_text_angular(html_data).replace(\n-                    '<br>', '<br/>')\n-                soup = bs4.BeautifulSoup(migrated_data, 'html.parser')\n-            else:\n-                soup = bs4.BeautifulSoup(\n-                    html_data.replace('<br>', '<br/>'), 'html.parser')\n-        except Exception as e:\n-            if e in err_dict:\n-                err_dict[e] += [html_data]\n-            else:\n-                err_dict[e] = [html_data]\n-            continue\n+        if run_migration:\n+            # <br> is replaced with <br/> before conversion because","path":"core/domain/html_cleaner.py","position":58,"original_position":58,"commit_id":"312eb44bee3293fc6448eaffc1f323891b5285b8","original_commit_id":"312eb44bee3293fc6448eaffc1f323891b5285b8","user":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2018-06-10T19:03:55Z","updated_at":"2018-06-10T19:03:55Z","html_url":"https://github.com/oppia/oppia/pull/4985#discussion_r194266936","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/4985","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/194266936"},"html":{"href":"https://github.com/oppia/oppia/pull/4985#discussion_r194266936"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4985"}},"in_reply_to_id":194263143},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/4985","id":190796849,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzk2ODQ5","html_url":"https://github.com/oppia/oppia/pull/4985","diff_url":"https://github.com/oppia/oppia/pull/4985.diff","patch_url":"https://github.com/oppia/oppia/pull/4985.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/4985","number":4985,"state":"open","locked":false,"title":"Added migration function for Textangular - Milestone 1 (part 2)","user":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"body":"This PR adds migration function for Textangular along with tests for it.","created_at":"2018-05-27T16:54:29Z","updated_at":"2018-06-10T19:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"045a31e3d4a03e76762a85ef3c763bdbb3efc7d3","assignee":{"login":"AllanYangZhou","id":8732147,"node_id":"MDQ6VXNlcjg3MzIxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/8732147?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanYangZhou","html_url":"https://github.com/AllanYangZhou","followers_url":"https://api.github.com/users/AllanYangZhou/followers","following_url":"https://api.github.com/users/AllanYangZhou/following{/other_user}","gists_url":"https://api.github.com/users/AllanYangZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanYangZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanYangZhou/subscriptions","organizations_url":"https://api.github.com/users/AllanYangZhou/orgs","repos_url":"https://api.github.com/users/AllanYangZhou/repos","events_url":"https://api.github.com/users/AllanYangZhou/events{/privacy}","received_events_url":"https://api.github.com/users/AllanYangZhou/received_events","type":"User","site_admin":false},"assignees":[{"login":"AllanYangZhou","id":8732147,"node_id":"MDQ6VXNlcjg3MzIxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/8732147?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanYangZhou","html_url":"https://github.com/AllanYangZhou","followers_url":"https://api.github.com/users/AllanYangZhou/followers","following_url":"https://api.github.com/users/AllanYangZhou/following{/other_user}","gists_url":"https://api.github.com/users/AllanYangZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanYangZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanYangZhou/subscriptions","organizations_url":"https://api.github.com/users/AllanYangZhou/orgs","repos_url":"https://api.github.com/users/AllanYangZhou/repos","events_url":"https://api.github.com/users/AllanYangZhou/events{/privacy}","received_events_url":"https://api.github.com/users/AllanYangZhou/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":638838928,"node_id":"MDU6TGFiZWw2Mzg4Mzg5Mjg=","url":"https://api.github.com/repos/oppia/oppia/labels/PR:%20for%20current%20release","name":"PR: for current release","color":"FF69B4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/4985/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/4985/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/4985/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/312eb44bee3293fc6448eaffc1f323891b5285b8","head":{"label":"bansalnitish:migration","ref":"migration","sha":"312eb44bee3293fc6448eaffc1f323891b5285b8","user":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"repo":{"id":118839208,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MzkyMDg=","name":"oppia","full_name":"bansalnitish/oppia","owner":{"login":"bansalnitish","id":22434689,"node_id":"MDQ6VXNlcjIyNDM0Njg5","avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bansalnitish/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/bansalnitish/oppia","forks_url":"https://api.github.com/repos/bansalnitish/oppia/forks","keys_url":"https://api.github.com/repos/bansalnitish/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bansalnitish/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bansalnitish/oppia/teams","hooks_url":"https://api.github.com/repos/bansalnitish/oppia/hooks","issue_events_url":"https://api.github.com/repos/bansalnitish/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/bansalnitish/oppia/events","assignees_url":"https://api.github.com/repos/bansalnitish/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/bansalnitish/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/bansalnitish/oppia/tags","blobs_url":"https://api.github.com/repos/bansalnitish/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bansalnitish/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bansalnitish/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/bansalnitish/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bansalnitish/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/bansalnitish/oppia/languages","stargazers_url":"https://api.github.com/repos/bansalnitish/oppia/stargazers","contributors_url":"https://api.github.com/repos/bansalnitish/oppia/contributors","subscribers_url":"https://api.github.com/repos/bansalnitish/oppia/subscribers","subscription_url":"https://api.github.com/repos/bansalnitish/oppia/subscription","commits_url":"https://api.github.com/repos/bansalnitish/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/bansalnitish/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/bansalnitish/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/bansalnitish/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/bansalnitish/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/bansalnitish/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bansalnitish/oppia/merges","archive_url":"https://api.github.com/repos/bansalnitish/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bansalnitish/oppia/downloads","issues_url":"https://api.github.com/repos/bansalnitish/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/bansalnitish/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/bansalnitish/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/bansalnitish/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bansalnitish/oppia/labels{/name}","releases_url":"https://api.github.com/repos/bansalnitish/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/bansalnitish/oppia/deployments","created_at":"2018-01-25T00:19:07Z","updated_at":"2018-06-09T11:31:18Z","pushed_at":"2018-06-10T10:52:03Z","git_url":"git://github.com/bansalnitish/oppia.git","ssh_url":"git@github.com:bansalnitish/oppia.git","clone_url":"https://github.com/bansalnitish/oppia.git","svn_url":"https://github.com/bansalnitish/oppia","homepage":"https://www.oppia.org","size":103861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"b7519a31250fdf060da99ac7255bd58f1e39c52a","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-06-10T16:42:53Z","pushed_at":"2018-06-10T18:41:57Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":103904,"stargazers_count":675,"watchers_count":675,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":643,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":643,"open_issues":322,"watchers":675,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4985"},"html":{"href":"https://github.com/oppia/oppia/pull/4985"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/4985"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/4985/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4985/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4985/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/312eb44bee3293fc6448eaffc1f323891b5285b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bansalnitish"}}