{"action":"created","comment":{"url":"https://api.github.com/repos/wright-group/WrightTools/pulls/comments/210452962","pull_request_review_id":146668278,"id":210452962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQ1Mjk2Mg==","diff_hunk":"@@ -673,8 +678,8 @@ def downscale(self, tup, name=None, parent=None):\n     def flush(self):\n         super().flush()\n \n-    def get_nadir(self, channel=0):\n-        \"\"\"Get the coordinates in units of the minimum in a channel.\n+    def get_nadir(self, channel=0) -> tuple:","path":"WrightTools/data/_data.py","position":166,"original_position":166,"commit_id":"e86a1dd68138782aa442fe4d9c20f9bdbee05bc2","original_commit_id":"e86a1dd68138782aa442fe4d9c20f9bdbee05bc2","user":{"login":"ksunden","id":2501846,"node_id":"MDQ6VXNlcjI1MDE4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/2501846?v=4","gravatar_id":"","url":"https://api.github.com/users/ksunden","html_url":"https://github.com/ksunden","followers_url":"https://api.github.com/users/ksunden/followers","following_url":"https://api.github.com/users/ksunden/following{/other_user}","gists_url":"https://api.github.com/users/ksunden/gists{/gist_id}","starred_url":"https://api.github.com/users/ksunden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksunden/subscriptions","organizations_url":"https://api.github.com/users/ksunden/orgs","repos_url":"https://api.github.com/users/ksunden/repos","events_url":"https://api.github.com/users/ksunden/events{/privacy}","received_events_url":"https://api.github.com/users/ksunden/received_events","type":"User","site_admin":false},"body":"typing.Tuple?","created_at":"2018-08-16T01:03:09Z","updated_at":"2018-08-16T01:13:12Z","html_url":"https://github.com/wright-group/WrightTools/pull/706#discussion_r210452962","pull_request_url":"https://api.github.com/repos/wright-group/WrightTools/pulls/706","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/comments/210452962"},"html":{"href":"https://github.com/wright-group/WrightTools/pull/706#discussion_r210452962"},"pull_request":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/wright-group/WrightTools/pulls/706","id":208310379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzEwMzc5","html_url":"https://github.com/wright-group/WrightTools/pull/706","diff_url":"https://github.com/wright-group/WrightTools/pull/706.diff","patch_url":"https://github.com/wright-group/WrightTools/pull/706.patch","issue_url":"https://api.github.com/repos/wright-group/WrightTools/issues/706","number":706,"state":"open","locked":false,"title":"Type hints","user":{"login":"p770193","id":11864045,"node_id":"MDQ6VXNlcjExODY0MDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11864045?v=4","gravatar_id":"","url":"https://api.github.com/users/p770193","html_url":"https://github.com/p770193","followers_url":"https://api.github.com/users/p770193/followers","following_url":"https://api.github.com/users/p770193/following{/other_user}","gists_url":"https://api.github.com/users/p770193/gists{/gist_id}","starred_url":"https://api.github.com/users/p770193/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p770193/subscriptions","organizations_url":"https://api.github.com/users/p770193/orgs","repos_url":"https://api.github.com/users/p770193/repos","events_url":"https://api.github.com/users/p770193/events{/privacy}","received_events_url":"https://api.github.com/users/p770193/received_events","type":"User","site_admin":false},"body":"Type hints for better user experience with IDE.\r\n\r\nconfer https://docs.python.org/3/library/typing.html\r\n\r\n- [x] get method output type hints:  Data, Axis, Variable, Channel, Group\r\n- [ ] ~~get method input type hints~~\r\n- [ ] ~~support type hints for natural naming of children~~","created_at":"2018-08-14T14:55:16Z","updated_at":"2018-08-16T01:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5de0278c449e8ebb015561e8b8911d4516189bc3","assignee":{"login":"p770193","id":11864045,"node_id":"MDQ6VXNlcjExODY0MDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11864045?v=4","gravatar_id":"","url":"https://api.github.com/users/p770193","html_url":"https://github.com/p770193","followers_url":"https://api.github.com/users/p770193/followers","following_url":"https://api.github.com/users/p770193/following{/other_user}","gists_url":"https://api.github.com/users/p770193/gists{/gist_id}","starred_url":"https://api.github.com/users/p770193/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p770193/subscriptions","organizations_url":"https://api.github.com/users/p770193/orgs","repos_url":"https://api.github.com/users/p770193/repos","events_url":"https://api.github.com/users/p770193/events{/privacy}","received_events_url":"https://api.github.com/users/p770193/received_events","type":"User","site_admin":false},"assignees":[{"login":"p770193","id":11864045,"node_id":"MDQ6VXNlcjExODY0MDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11864045?v=4","gravatar_id":"","url":"https://api.github.com/users/p770193","html_url":"https://github.com/p770193","followers_url":"https://api.github.com/users/p770193/followers","following_url":"https://api.github.com/users/p770193/following{/other_user}","gists_url":"https://api.github.com/users/p770193/gists{/gist_id}","starred_url":"https://api.github.com/users/p770193/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p770193/subscriptions","organizations_url":"https://api.github.com/users/p770193/orgs","repos_url":"https://api.github.com/users/p770193/repos","events_url":"https://api.github.com/users/p770193/events{/privacy}","received_events_url":"https://api.github.com/users/p770193/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"untzag","id":8051086,"node_id":"MDQ6VXNlcjgwNTEwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8051086?v=4","gravatar_id":"","url":"https://api.github.com/users/untzag","html_url":"https://github.com/untzag","followers_url":"https://api.github.com/users/untzag/followers","following_url":"https://api.github.com/users/untzag/following{/other_user}","gists_url":"https://api.github.com/users/untzag/gists{/gist_id}","starred_url":"https://api.github.com/users/untzag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untzag/subscriptions","organizations_url":"https://api.github.com/users/untzag/orgs","repos_url":"https://api.github.com/users/untzag/repos","events_url":"https://api.github.com/users/untzag/events{/privacy}","received_events_url":"https://api.github.com/users/untzag/received_events","type":"User","site_admin":false},{"login":"darienmorrow","id":15792657,"node_id":"MDQ6VXNlcjE1NzkyNjU3","avatar_url":"https://avatars3.githubusercontent.com/u/15792657?v=4","gravatar_id":"","url":"https://api.github.com/users/darienmorrow","html_url":"https://github.com/darienmorrow","followers_url":"https://api.github.com/users/darienmorrow/followers","following_url":"https://api.github.com/users/darienmorrow/following{/other_user}","gists_url":"https://api.github.com/users/darienmorrow/gists{/gist_id}","starred_url":"https://api.github.com/users/darienmorrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darienmorrow/subscriptions","organizations_url":"https://api.github.com/users/darienmorrow/orgs","repos_url":"https://api.github.com/users/darienmorrow/repos","events_url":"https://api.github.com/users/darienmorrow/events{/privacy}","received_events_url":"https://api.github.com/users/darienmorrow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":197834754,"node_id":"MDU6TGFiZWwxOTc4MzQ3NTQ=","url":"https://api.github.com/repos/wright-group/WrightTools/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/wright-group/WrightTools/pulls/706/commits","review_comments_url":"https://api.github.com/repos/wright-group/WrightTools/pulls/706/comments","review_comment_url":"https://api.github.com/repos/wright-group/WrightTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wright-group/WrightTools/issues/706/comments","statuses_url":"https://api.github.com/repos/wright-group/WrightTools/statuses/e86a1dd68138782aa442fe4d9c20f9bdbee05bc2","head":{"label":"wright-group:type-hints","ref":"type-hints","sha":"e86a1dd68138782aa442fe4d9c20f9bdbee05bc2","user":{"login":"wright-group","id":11878781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODc4Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11878781?v=4","gravatar_id":"","url":"https://api.github.com/users/wright-group","html_url":"https://github.com/wright-group","followers_url":"https://api.github.com/users/wright-group/followers","following_url":"https://api.github.com/users/wright-group/following{/other_user}","gists_url":"https://api.github.com/users/wright-group/gists{/gist_id}","starred_url":"https://api.github.com/users/wright-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wright-group/subscriptions","organizations_url":"https://api.github.com/users/wright-group/orgs","repos_url":"https://api.github.com/users/wright-group/repos","events_url":"https://api.github.com/users/wright-group/events{/privacy}","received_events_url":"https://api.github.com/users/wright-group/received_events","type":"Organization","site_admin":false},"repo":{"id":33698232,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY5ODIzMg==","name":"WrightTools","full_name":"wright-group/WrightTools","owner":{"login":"wright-group","id":11878781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODc4Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11878781?v=4","gravatar_id":"","url":"https://api.github.com/users/wright-group","html_url":"https://github.com/wright-group","followers_url":"https://api.github.com/users/wright-group/followers","following_url":"https://api.github.com/users/wright-group/following{/other_user}","gists_url":"https://api.github.com/users/wright-group/gists{/gist_id}","starred_url":"https://api.github.com/users/wright-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wright-group/subscriptions","organizations_url":"https://api.github.com/users/wright-group/orgs","repos_url":"https://api.github.com/users/wright-group/repos","events_url":"https://api.github.com/users/wright-group/events{/privacy}","received_events_url":"https://api.github.com/users/wright-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wright-group/WrightTools","description":"Tools for loading, processing, and plotting multidimensional spectroscopy data.","fork":false,"url":"https://api.github.com/repos/wright-group/WrightTools","forks_url":"https://api.github.com/repos/wright-group/WrightTools/forks","keys_url":"https://api.github.com/repos/wright-group/WrightTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wright-group/WrightTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wright-group/WrightTools/teams","hooks_url":"https://api.github.com/repos/wright-group/WrightTools/hooks","issue_events_url":"https://api.github.com/repos/wright-group/WrightTools/issues/events{/number}","events_url":"https://api.github.com/repos/wright-group/WrightTools/events","assignees_url":"https://api.github.com/repos/wright-group/WrightTools/assignees{/user}","branches_url":"https://api.github.com/repos/wright-group/WrightTools/branches{/branch}","tags_url":"https://api.github.com/repos/wright-group/WrightTools/tags","blobs_url":"https://api.github.com/repos/wright-group/WrightTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wright-group/WrightTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wright-group/WrightTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/wright-group/WrightTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wright-group/WrightTools/statuses/{sha}","languages_url":"https://api.github.com/repos/wright-group/WrightTools/languages","stargazers_url":"https://api.github.com/repos/wright-group/WrightTools/stargazers","contributors_url":"https://api.github.com/repos/wright-group/WrightTools/contributors","subscribers_url":"https://api.github.com/repos/wright-group/WrightTools/subscribers","subscription_url":"https://api.github.com/repos/wright-group/WrightTools/subscription","commits_url":"https://api.github.com/repos/wright-group/WrightTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/wright-group/WrightTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/wright-group/WrightTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/wright-group/WrightTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/wright-group/WrightTools/contents/{+path}","compare_url":"https://api.github.com/repos/wright-group/WrightTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wright-group/WrightTools/merges","archive_url":"https://api.github.com/repos/wright-group/WrightTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wright-group/WrightTools/downloads","issues_url":"https://api.github.com/repos/wright-group/WrightTools/issues{/number}","pulls_url":"https://api.github.com/repos/wright-group/WrightTools/pulls{/number}","milestones_url":"https://api.github.com/repos/wright-group/WrightTools/milestones{/number}","notifications_url":"https://api.github.com/repos/wright-group/WrightTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wright-group/WrightTools/labels{/name}","releases_url":"https://api.github.com/repos/wright-group/WrightTools/releases{/id}","deployments_url":"https://api.github.com/repos/wright-group/WrightTools/deployments","created_at":"2015-04-09T23:41:09Z","updated_at":"2018-08-15T16:44:27Z","pushed_at":"2018-08-15T22:14:14Z","git_url":"git://github.com/wright-group/WrightTools.git","ssh_url":"git@github.com:wright-group/WrightTools.git","clone_url":"https://github.com/wright-group/WrightTools.git","svn_url":"https://github.com/wright-group/WrightTools","homepage":"http://wright.tools","size":33289,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":84,"watchers":3,"default_branch":"development"}},"base":{"label":"wright-group:development","ref":"development","sha":"ca056aa600f341501a99d2ea4d11f7d74047bc26","user":{"login":"wright-group","id":11878781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODc4Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11878781?v=4","gravatar_id":"","url":"https://api.github.com/users/wright-group","html_url":"https://github.com/wright-group","followers_url":"https://api.github.com/users/wright-group/followers","following_url":"https://api.github.com/users/wright-group/following{/other_user}","gists_url":"https://api.github.com/users/wright-group/gists{/gist_id}","starred_url":"https://api.github.com/users/wright-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wright-group/subscriptions","organizations_url":"https://api.github.com/users/wright-group/orgs","repos_url":"https://api.github.com/users/wright-group/repos","events_url":"https://api.github.com/users/wright-group/events{/privacy}","received_events_url":"https://api.github.com/users/wright-group/received_events","type":"Organization","site_admin":false},"repo":{"id":33698232,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY5ODIzMg==","name":"WrightTools","full_name":"wright-group/WrightTools","owner":{"login":"wright-group","id":11878781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODc4Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11878781?v=4","gravatar_id":"","url":"https://api.github.com/users/wright-group","html_url":"https://github.com/wright-group","followers_url":"https://api.github.com/users/wright-group/followers","following_url":"https://api.github.com/users/wright-group/following{/other_user}","gists_url":"https://api.github.com/users/wright-group/gists{/gist_id}","starred_url":"https://api.github.com/users/wright-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wright-group/subscriptions","organizations_url":"https://api.github.com/users/wright-group/orgs","repos_url":"https://api.github.com/users/wright-group/repos","events_url":"https://api.github.com/users/wright-group/events{/privacy}","received_events_url":"https://api.github.com/users/wright-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wright-group/WrightTools","description":"Tools for loading, processing, and plotting multidimensional spectroscopy data.","fork":false,"url":"https://api.github.com/repos/wright-group/WrightTools","forks_url":"https://api.github.com/repos/wright-group/WrightTools/forks","keys_url":"https://api.github.com/repos/wright-group/WrightTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wright-group/WrightTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wright-group/WrightTools/teams","hooks_url":"https://api.github.com/repos/wright-group/WrightTools/hooks","issue_events_url":"https://api.github.com/repos/wright-group/WrightTools/issues/events{/number}","events_url":"https://api.github.com/repos/wright-group/WrightTools/events","assignees_url":"https://api.github.com/repos/wright-group/WrightTools/assignees{/user}","branches_url":"https://api.github.com/repos/wright-group/WrightTools/branches{/branch}","tags_url":"https://api.github.com/repos/wright-group/WrightTools/tags","blobs_url":"https://api.github.com/repos/wright-group/WrightTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wright-group/WrightTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wright-group/WrightTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/wright-group/WrightTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wright-group/WrightTools/statuses/{sha}","languages_url":"https://api.github.com/repos/wright-group/WrightTools/languages","stargazers_url":"https://api.github.com/repos/wright-group/WrightTools/stargazers","contributors_url":"https://api.github.com/repos/wright-group/WrightTools/contributors","subscribers_url":"https://api.github.com/repos/wright-group/WrightTools/subscribers","subscription_url":"https://api.github.com/repos/wright-group/WrightTools/subscription","commits_url":"https://api.github.com/repos/wright-group/WrightTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/wright-group/WrightTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/wright-group/WrightTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/wright-group/WrightTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/wright-group/WrightTools/contents/{+path}","compare_url":"https://api.github.com/repos/wright-group/WrightTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wright-group/WrightTools/merges","archive_url":"https://api.github.com/repos/wright-group/WrightTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wright-group/WrightTools/downloads","issues_url":"https://api.github.com/repos/wright-group/WrightTools/issues{/number}","pulls_url":"https://api.github.com/repos/wright-group/WrightTools/pulls{/number}","milestones_url":"https://api.github.com/repos/wright-group/WrightTools/milestones{/number}","notifications_url":"https://api.github.com/repos/wright-group/WrightTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wright-group/WrightTools/labels{/name}","releases_url":"https://api.github.com/repos/wright-group/WrightTools/releases{/id}","deployments_url":"https://api.github.com/repos/wright-group/WrightTools/deployments","created_at":"2015-04-09T23:41:09Z","updated_at":"2018-08-15T16:44:27Z","pushed_at":"2018-08-15T22:14:14Z","git_url":"git://github.com/wright-group/WrightTools.git","ssh_url":"git@github.com:wright-group/WrightTools.git","clone_url":"https://github.com/wright-group/WrightTools.git","svn_url":"https://github.com/wright-group/WrightTools","homepage":"http://wright.tools","size":33289,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":84,"watchers":3,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/706"},"html":{"href":"https://github.com/wright-group/WrightTools/pull/706"},"issue":{"href":"https://api.github.com/repos/wright-group/WrightTools/issues/706"},"comments":{"href":"https://api.github.com/repos/wright-group/WrightTools/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wright-group/WrightTools/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/wright-group/WrightTools/statuses/e86a1dd68138782aa442fe4d9c20f9bdbee05bc2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ksunden"}}