{"action":"created","comment":{"url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/comments/229253806","pull_request_review_id":169706177,"id":229253806,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI1MzgwNg==","diff_hunk":"@@ -0,0 +1,456 @@\n+declare module 'oidc-provider' {\n+    import { Request, Response, Handler } from 'express';\n+    import Koa = require('koa');\n+    import Router = require('koa-router');\n+    import { IncomingMessage, ServerResponse } from 'http';\n+    import EventEmitter = require('events');\n+    import { JWK } from 'node-jose';\n+\n+    type SubjectType = 'public' | 'parwise';\n+\n+    interface IClient {","path":"index.d.ts","position":null,"original_position":11,"commit_id":"621a8e700df99a5d8bf9a99524a5edc35b8bcea9","original_commit_id":"2baa9f089fcf6715c78a28ea84e522128645fe53","user":{"login":"javlund","id":1478337,"node_id":"MDQ6VXNlcjE0NzgzMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1478337?v=4","gravatar_id":"","url":"https://api.github.com/users/javlund","html_url":"https://github.com/javlund","followers_url":"https://api.github.com/users/javlund/followers","following_url":"https://api.github.com/users/javlund/following{/other_user}","gists_url":"https://api.github.com/users/javlund/gists{/gist_id}","starred_url":"https://api.github.com/users/javlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javlund/subscriptions","organizations_url":"https://api.github.com/users/javlund/orgs","repos_url":"https://api.github.com/users/javlund/repos","events_url":"https://api.github.com/users/javlund/events{/privacy}","received_events_url":"https://api.github.com/users/javlund/received_events","type":"User","site_admin":false},"body":"Can you provide suggested types for them? Then I'd love to comb through the files and include the ones that aren't already there.","created_at":"2018-10-30T10:38:36Z","updated_at":"2018-10-30T10:38:36Z","html_url":"https://github.com/panva/node-oidc-provider/pull/389#discussion_r229253806","pull_request_url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/comments/229253806"},"html":{"href":"https://github.com/panva/node-oidc-provider/pull/389#discussion_r229253806"},"pull_request":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389"}},"in_reply_to_id":229200864},"pull_request":{"url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389","id":226738119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzM4MTE5","html_url":"https://github.com/panva/node-oidc-provider/pull/389","diff_url":"https://github.com/panva/node-oidc-provider/pull/389.diff","patch_url":"https://github.com/panva/node-oidc-provider/pull/389.patch","issue_url":"https://api.github.com/repos/panva/node-oidc-provider/issues/389","number":389,"state":"open","locked":false,"title":"feat: add Typescript declarations","user":{"login":"javlund","id":1478337,"node_id":"MDQ6VXNlcjE0NzgzMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1478337?v=4","gravatar_id":"","url":"https://api.github.com/users/javlund","html_url":"https://github.com/javlund","followers_url":"https://api.github.com/users/javlund/followers","following_url":"https://api.github.com/users/javlund/following{/other_user}","gists_url":"https://api.github.com/users/javlund/gists{/gist_id}","starred_url":"https://api.github.com/users/javlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javlund/subscriptions","organizations_url":"https://api.github.com/users/javlund/orgs","repos_url":"https://api.github.com/users/javlund/repos","events_url":"https://api.github.com/users/javlund/events{/privacy}","received_events_url":"https://api.github.com/users/javlund/received_events","type":"User","site_admin":false},"body":"First version of the declarations file. Please comment or, even better, add commits!\r\n\r\nNote that I'm honestly somewhat a rookie in Typescript, especially when it comes to declaration files and the whole build aspect of it, so I'd really like more eyes on this.\r\n\r\nWhat I've done so far:\r\n* added the declarations file\r\n* added a `tsconfig.json` file (not sure if needed?)\r\n* as a test, run `tsc -p .` in the root dir and then tried starting up a new file importing the provider. Noted that types were available.","created_at":"2018-10-29T22:45:52Z","updated_at":"2018-10-30T10:38:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc0651fd0a5b9a1f3f6446509cb83e6428213904","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":294286315,"node_id":"MDU6TGFiZWwyOTQyODYzMTU=","url":"https://api.github.com/repos/panva/node-oidc-provider/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":294286316,"node_id":"MDU6TGFiZWwyOTQyODYzMTY=","url":"https://api.github.com/repos/panva/node-oidc-provider/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389/commits","review_comments_url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389/comments","review_comment_url":"https://api.github.com/repos/panva/node-oidc-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/panva/node-oidc-provider/issues/389/comments","statuses_url":"https://api.github.com/repos/panva/node-oidc-provider/statuses/621a8e700df99a5d8bf9a99524a5edc35b8bcea9","head":{"label":"javlund:add-typescript","ref":"add-typescript","sha":"621a8e700df99a5d8bf9a99524a5edc35b8bcea9","user":{"login":"javlund","id":1478337,"node_id":"MDQ6VXNlcjE0NzgzMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1478337?v=4","gravatar_id":"","url":"https://api.github.com/users/javlund","html_url":"https://github.com/javlund","followers_url":"https://api.github.com/users/javlund/followers","following_url":"https://api.github.com/users/javlund/following{/other_user}","gists_url":"https://api.github.com/users/javlund/gists{/gist_id}","starred_url":"https://api.github.com/users/javlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javlund/subscriptions","organizations_url":"https://api.github.com/users/javlund/orgs","repos_url":"https://api.github.com/users/javlund/repos","events_url":"https://api.github.com/users/javlund/events{/privacy}","received_events_url":"https://api.github.com/users/javlund/received_events","type":"User","site_admin":false},"repo":{"id":155282237,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUyODIyMzc=","name":"node-oidc-provider","full_name":"javlund/node-oidc-provider","private":false,"owner":{"login":"javlund","id":1478337,"node_id":"MDQ6VXNlcjE0NzgzMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1478337?v=4","gravatar_id":"","url":"https://api.github.com/users/javlund","html_url":"https://github.com/javlund","followers_url":"https://api.github.com/users/javlund/followers","following_url":"https://api.github.com/users/javlund/following{/other_user}","gists_url":"https://api.github.com/users/javlund/gists{/gist_id}","starred_url":"https://api.github.com/users/javlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javlund/subscriptions","organizations_url":"https://api.github.com/users/javlund/orgs","repos_url":"https://api.github.com/users/javlund/repos","events_url":"https://api.github.com/users/javlund/events{/privacy}","received_events_url":"https://api.github.com/users/javlund/received_events","type":"User","site_admin":false},"html_url":"https://github.com/javlund/node-oidc-provider","description":"OpenID Provider(OP) implementation for node.js servers. It provides a mountable or standalone implementation of the specifications including a plenty optional features.","fork":true,"url":"https://api.github.com/repos/javlund/node-oidc-provider","forks_url":"https://api.github.com/repos/javlund/node-oidc-provider/forks","keys_url":"https://api.github.com/repos/javlund/node-oidc-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javlund/node-oidc-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javlund/node-oidc-provider/teams","hooks_url":"https://api.github.com/repos/javlund/node-oidc-provider/hooks","issue_events_url":"https://api.github.com/repos/javlund/node-oidc-provider/issues/events{/number}","events_url":"https://api.github.com/repos/javlund/node-oidc-provider/events","assignees_url":"https://api.github.com/repos/javlund/node-oidc-provider/assignees{/user}","branches_url":"https://api.github.com/repos/javlund/node-oidc-provider/branches{/branch}","tags_url":"https://api.github.com/repos/javlund/node-oidc-provider/tags","blobs_url":"https://api.github.com/repos/javlund/node-oidc-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javlund/node-oidc-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javlund/node-oidc-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/javlund/node-oidc-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javlund/node-oidc-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/javlund/node-oidc-provider/languages","stargazers_url":"https://api.github.com/repos/javlund/node-oidc-provider/stargazers","contributors_url":"https://api.github.com/repos/javlund/node-oidc-provider/contributors","subscribers_url":"https://api.github.com/repos/javlund/node-oidc-provider/subscribers","subscription_url":"https://api.github.com/repos/javlund/node-oidc-provider/subscription","commits_url":"https://api.github.com/repos/javlund/node-oidc-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/javlund/node-oidc-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/javlund/node-oidc-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/javlund/node-oidc-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/javlund/node-oidc-provider/contents/{+path}","compare_url":"https://api.github.com/repos/javlund/node-oidc-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javlund/node-oidc-provider/merges","archive_url":"https://api.github.com/repos/javlund/node-oidc-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javlund/node-oidc-provider/downloads","issues_url":"https://api.github.com/repos/javlund/node-oidc-provider/issues{/number}","pulls_url":"https://api.github.com/repos/javlund/node-oidc-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/javlund/node-oidc-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/javlund/node-oidc-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javlund/node-oidc-provider/labels{/name}","releases_url":"https://api.github.com/repos/javlund/node-oidc-provider/releases{/id}","deployments_url":"https://api.github.com/repos/javlund/node-oidc-provider/deployments","created_at":"2018-10-29T21:14:09Z","updated_at":"2018-10-29T21:14:12Z","pushed_at":"2018-10-30T10:31:02Z","git_url":"git://github.com/javlund/node-oidc-provider.git","ssh_url":"git@github.com:javlund/node-oidc-provider.git","clone_url":"https://github.com/javlund/node-oidc-provider.git","svn_url":"https://github.com/javlund/node-oidc-provider","homepage":"","size":2585,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"panva:master","ref":"master","sha":"33ef63b030627cbdc148facb1e925450aa229113","user":{"login":"panva","id":241506,"node_id":"MDQ6VXNlcjI0MTUwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/241506?v=4","gravatar_id":"","url":"https://api.github.com/users/panva","html_url":"https://github.com/panva","followers_url":"https://api.github.com/users/panva/followers","following_url":"https://api.github.com/users/panva/following{/other_user}","gists_url":"https://api.github.com/users/panva/gists{/gist_id}","starred_url":"https://api.github.com/users/panva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panva/subscriptions","organizations_url":"https://api.github.com/users/panva/orgs","repos_url":"https://api.github.com/users/panva/repos","events_url":"https://api.github.com/users/panva/events{/privacy}","received_events_url":"https://api.github.com/users/panva/received_events","type":"User","site_admin":false},"repo":{"id":47250070,"node_id":"MDEwOlJlcG9zaXRvcnk0NzI1MDA3MA==","name":"node-oidc-provider","full_name":"panva/node-oidc-provider","private":false,"owner":{"login":"panva","id":241506,"node_id":"MDQ6VXNlcjI0MTUwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/241506?v=4","gravatar_id":"","url":"https://api.github.com/users/panva","html_url":"https://github.com/panva","followers_url":"https://api.github.com/users/panva/followers","following_url":"https://api.github.com/users/panva/following{/other_user}","gists_url":"https://api.github.com/users/panva/gists{/gist_id}","starred_url":"https://api.github.com/users/panva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panva/subscriptions","organizations_url":"https://api.github.com/users/panva/orgs","repos_url":"https://api.github.com/users/panva/repos","events_url":"https://api.github.com/users/panva/events{/privacy}","received_events_url":"https://api.github.com/users/panva/received_events","type":"User","site_admin":false},"html_url":"https://github.com/panva/node-oidc-provider","description":"OpenID Provider(OP) implementation for node.js servers. It provides a mountable or standalone implementation of the specifications including a plenty optional features.","fork":false,"url":"https://api.github.com/repos/panva/node-oidc-provider","forks_url":"https://api.github.com/repos/panva/node-oidc-provider/forks","keys_url":"https://api.github.com/repos/panva/node-oidc-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panva/node-oidc-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panva/node-oidc-provider/teams","hooks_url":"https://api.github.com/repos/panva/node-oidc-provider/hooks","issue_events_url":"https://api.github.com/repos/panva/node-oidc-provider/issues/events{/number}","events_url":"https://api.github.com/repos/panva/node-oidc-provider/events","assignees_url":"https://api.github.com/repos/panva/node-oidc-provider/assignees{/user}","branches_url":"https://api.github.com/repos/panva/node-oidc-provider/branches{/branch}","tags_url":"https://api.github.com/repos/panva/node-oidc-provider/tags","blobs_url":"https://api.github.com/repos/panva/node-oidc-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panva/node-oidc-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panva/node-oidc-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/panva/node-oidc-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panva/node-oidc-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/panva/node-oidc-provider/languages","stargazers_url":"https://api.github.com/repos/panva/node-oidc-provider/stargazers","contributors_url":"https://api.github.com/repos/panva/node-oidc-provider/contributors","subscribers_url":"https://api.github.com/repos/panva/node-oidc-provider/subscribers","subscription_url":"https://api.github.com/repos/panva/node-oidc-provider/subscription","commits_url":"https://api.github.com/repos/panva/node-oidc-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/panva/node-oidc-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/panva/node-oidc-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/panva/node-oidc-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/panva/node-oidc-provider/contents/{+path}","compare_url":"https://api.github.com/repos/panva/node-oidc-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panva/node-oidc-provider/merges","archive_url":"https://api.github.com/repos/panva/node-oidc-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panva/node-oidc-provider/downloads","issues_url":"https://api.github.com/repos/panva/node-oidc-provider/issues{/number}","pulls_url":"https://api.github.com/repos/panva/node-oidc-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/panva/node-oidc-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/panva/node-oidc-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panva/node-oidc-provider/labels{/name}","releases_url":"https://api.github.com/repos/panva/node-oidc-provider/releases{/id}","deployments_url":"https://api.github.com/repos/panva/node-oidc-provider/deployments","created_at":"2015-12-02T09:17:41Z","updated_at":"2018-10-30T09:05:44Z","pushed_at":"2018-10-30T10:31:03Z","git_url":"git://github.com/panva/node-oidc-provider.git","ssh_url":"git@github.com:panva/node-oidc-provider.git","clone_url":"https://github.com/panva/node-oidc-provider.git","svn_url":"https://github.com/panva/node-oidc-provider","homepage":"","size":2582,"stargazers_count":434,"watchers_count":434,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":136,"open_issues":2,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389"},"html":{"href":"https://github.com/panva/node-oidc-provider/pull/389"},"issue":{"href":"https://api.github.com/repos/panva/node-oidc-provider/issues/389"},"comments":{"href":"https://api.github.com/repos/panva/node-oidc-provider/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/panva/node-oidc-provider/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/panva/node-oidc-provider/statuses/621a8e700df99a5d8bf9a99524a5edc35b8bcea9"}},"author_association":"NONE"}}
{"actor":{"display_login":"javlund"}}