{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/167019096","pull_request_review_id":95174432,"id":167019096,"diff_hunk":"@@ -4,6 +4,7 @@ import { HttpClient, HttpErrorResponse } from '@angular/common/http';\n import { Observable } from 'rxjs/Observable';\n import { AsyncSubject } from 'rxjs/AsyncSubject';\n import { of } from 'rxjs/observable/of';\n+import 'rxjs/add/observable/of';","path":"aio/src/app/documents/document.service.ts","position":4,"original_position":4,"commit_id":"5cc0fbab4f78b4e04adc0c5e27d654cedd9ccf7d","original_commit_id":"5cc0fbab4f78b4e04adc0c5e27d654cedd9ccf7d","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"body":"Indeed!","created_at":"2018-02-08T18:03:16Z","updated_at":"2018-02-08T18:03:17Z","html_url":"https://github.com/angular/angular/pull/19795#discussion_r167019096","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/19795","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/167019096"},"html":{"href":"https://github.com/angular/angular/pull/19795#discussion_r167019096"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/19795"}},"in_reply_to_id":161214334},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/19795","id":147417348,"html_url":"https://github.com/angular/angular/pull/19795","diff_url":"https://github.com/angular/angular/pull/19795.diff","patch_url":"https://github.com/angular/angular/pull/19795.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/19795","number":19795,"state":"open","locked":false,"title":"feat(aio): Convert AIO to use the new Service Worker 5.0.0.","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"body":"AIO is currently using a beta version of @angular/service-worker.\r\nSince that was implemented, the SW has been rewritten and released\r\nas part of Angular 5.0.0. This commit updates AIO to use the latest\r\nimplementation, with an appropriate configuration file that caches\r\nthe various AIO assets in useful ways.\r\n","created_at":"2017-10-18T21:39:51Z","updated_at":"2018-02-08T18:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecf18ec803e14aac94b0e389d74ec682a5bd451d","assignee":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars0.githubusercontent.com/u/15655?v=4","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"assignees":[{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars0.githubusercontent.com/u/15655?v=4","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/19795/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/19795/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/19795/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/5cc0fbab4f78b4e04adc0c5e27d654cedd9ccf7d","head":{"label":"alxhub:aio-new-sw","ref":"aio-new-sw","sha":"5cc0fbab4f78b4e04adc0c5e27d654cedd9ccf7d","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"repo":{"id":35444156,"name":"angular","full_name":"alxhub/angular","owner":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars0.githubusercontent.com/u/4175141?v=4","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alxhub/angular","description":null,"fork":true,"url":"https://api.github.com/repos/alxhub/angular","forks_url":"https://api.github.com/repos/alxhub/angular/forks","keys_url":"https://api.github.com/repos/alxhub/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alxhub/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alxhub/angular/teams","hooks_url":"https://api.github.com/repos/alxhub/angular/hooks","issue_events_url":"https://api.github.com/repos/alxhub/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alxhub/angular/events","assignees_url":"https://api.github.com/repos/alxhub/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alxhub/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alxhub/angular/tags","blobs_url":"https://api.github.com/repos/alxhub/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alxhub/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alxhub/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alxhub/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alxhub/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alxhub/angular/languages","stargazers_url":"https://api.github.com/repos/alxhub/angular/stargazers","contributors_url":"https://api.github.com/repos/alxhub/angular/contributors","subscribers_url":"https://api.github.com/repos/alxhub/angular/subscribers","subscription_url":"https://api.github.com/repos/alxhub/angular/subscription","commits_url":"https://api.github.com/repos/alxhub/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alxhub/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alxhub/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alxhub/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alxhub/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alxhub/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alxhub/angular/merges","archive_url":"https://api.github.com/repos/alxhub/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alxhub/angular/downloads","issues_url":"https://api.github.com/repos/alxhub/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alxhub/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alxhub/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alxhub/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alxhub/angular/labels{/name}","releases_url":"https://api.github.com/repos/alxhub/angular/releases{/id}","deployments_url":"https://api.github.com/repos/alxhub/angular/deployments","created_at":"2015-05-11T19:08:26Z","updated_at":"2016-01-25T22:09:11Z","pushed_at":"2018-02-08T17:23:55Z","git_url":"git://github.com/alxhub/angular.git","ssh_url":"git@github.com:alxhub/angular.git","clone_url":"https://github.com/alxhub/angular.git","svn_url":"https://github.com/alxhub/angular","homepage":null,"size":71510,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"23596b3f304a931733e761e75e0c1371bdd1995a","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-02-08T17:54:20Z","pushed_at":"2018-02-08T18:01:31Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":73232,"stargazers_count":32858,"watchers_count":32858,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8143,"mirror_url":null,"archived":false,"open_issues_count":2122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8143,"open_issues":2122,"watchers":32858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/19795"},"html":{"href":"https://github.com/angular/angular/pull/19795"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/19795"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/19795/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/19795/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/19795/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/5cc0fbab4f78b4e04adc0c5e27d654cedd9ccf7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alxhub"}}