{"action":"created","comment":{"url":"https://api.github.com/repos/twisted/twisted/pulls/comments/198988202","pull_request_review_id":132971770,"id":198988202,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODk4ODIwMg==","diff_hunk":"@@ -607,7 +611,7 @@ def notifyDone(self, relay):\n         \"\"\"\n         for message in self.manager.managed.get(relay, ()):\n             if self.noisy:\n-                log.msg(\"Setting \" + message + \" waiting\")\n+                log.msg(b\"Setting \" + message + b\" waiting\")","path":"src/twisted/mail/relaymanager.py","position":141,"original_position":141,"commit_id":"3066c204ea0728692cf4f196923873af99495827","original_commit_id":"3066c204ea0728692cf4f196923873af99495827","user":{"login":"wiml","id":156891,"node_id":"MDQ6VXNlcjE1Njg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/156891?v=4","gravatar_id":"","url":"https://api.github.com/users/wiml","html_url":"https://github.com/wiml","followers_url":"https://api.github.com/users/wiml/followers","following_url":"https://api.github.com/users/wiml/following{/other_user}","gists_url":"https://api.github.com/users/wiml/gists{/gist_id}","starred_url":"https://api.github.com/users/wiml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiml/subscriptions","organizations_url":"https://api.github.com/users/wiml/orgs","repos_url":"https://api.github.com/users/wiml/repos","events_url":"https://api.github.com/users/wiml/events{/privacy}","received_events_url":"https://api.github.com/users/wiml/received_events","type":"User","site_admin":false},"body":"I think it would be better to convert `message` to unicode  (e.g. by `repr` ?) than to emit the log text as a bytestring.","created_at":"2018-06-28T21:14:56Z","updated_at":"2018-06-28T21:28:06Z","html_url":"https://github.com/twisted/twisted/pull/933#discussion_r198988202","pull_request_url":"https://api.github.com/repos/twisted/twisted/pulls/933","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments/198988202"},"html":{"href":"https://github.com/twisted/twisted/pull/933#discussion_r198988202"},"pull_request":{"href":"https://api.github.com/repos/twisted/twisted/pulls/933"}}},"pull_request":{"url":"https://api.github.com/repos/twisted/twisted/pulls/933","id":154654362,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU0NjU0MzYy","html_url":"https://github.com/twisted/twisted/pull/933","diff_url":"https://github.com/twisted/twisted/pull/933.diff","patch_url":"https://github.com/twisted/twisted/pull/933.patch","issue_url":"https://api.github.com/repos/twisted/twisted/issues/933","number":933,"state":"open","locked":false,"title":"Port twisted.mail.test.test_mail to Python 3","user":{"login":"rodrigc","id":1895943,"node_id":"MDQ6VXNlcjE4OTU5NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1895943?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"body":"http://twistedmatrix.com/trac/ticket/9337","created_at":"2017-11-25T21:54:34Z","updated_at":"2018-06-28T21:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fade0dbcb052548279a724620a6943dcde67f15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twisted/twisted/pulls/933/commits","review_comments_url":"https://api.github.com/repos/twisted/twisted/pulls/933/comments","review_comment_url":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/twisted/issues/933/comments","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/3066c204ea0728692cf4f196923873af99495827","head":{"label":"twisted:9337-rodrigc-mail-py3","ref":"9337-rodrigc-mail-py3","sha":"3066c204ea0728692cf4f196923873af99495827","user":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzU4","name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2018-06-28T19:14:23Z","pushed_at":"2018-06-28T19:01:21Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":58125,"stargazers_count":2753,"watchers_count":2753,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":774,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":774,"open_issues":91,"watchers":2753,"default_branch":"trunk"}},"base":{"label":"twisted:trunk","ref":"trunk","sha":"2e7b403c03e9b9b891a5eb36297e494f541d5d6a","user":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzU4","name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2018-06-28T19:14:23Z","pushed_at":"2018-06-28T19:01:21Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":58125,"stargazers_count":2753,"watchers_count":2753,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":774,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":774,"open_issues":91,"watchers":2753,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/933"},"html":{"href":"https://github.com/twisted/twisted/pull/933"},"issue":{"href":"https://api.github.com/repos/twisted/twisted/issues/933"},"comments":{"href":"https://api.github.com/repos/twisted/twisted/issues/933/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/twisted/pulls/933/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/twisted/pulls/933/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/twisted/statuses/3066c204ea0728692cf4f196923873af99495827"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wiml"}}