{"action":"created","comment":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/168110196","pull_request_review_id":96422244,"id":168110196,"diff_hunk":"@@ -128,9 +138,13 @@ class Maven : PackageManager() {\n \n         val vcsFromPackage = maven.parseVcsInfo(mavenProject)\n \n+        // If running in SBT mode expect that POM files were generated in a \"target\" subdirectory and that the correct\n+        // project directory is the parent of this.\n+        val projectDir = if (sbtMode) workingDir.parentFile else workingDir\n+\n         val project = Project(\n                 id = Identifier(\n-                        packageManager = javaClass.simpleName,\n+                        packageManager = if (sbtMode) SBT::class.java.simpleName else javaClass.simpleName,","path":"analyzer/src/main/kotlin/managers/Maven.kt","position":37,"original_position":37,"commit_id":"e623f99f27374208da5ee76f46d69981b9eab005","original_commit_id":"e623f99f27374208da5ee76f46d69981b9eab005","user":{"login":"sschuberth","id":349154,"avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"Hmm, I have another proposal how to fix this in a branch of mine (currently called \"maven-all\", but I'll rename it). Mine requires more code, but in exchange does not add a dependency on SBT from Maven. My plan was to change `resolveDependencies()` in `SBT.kt` like so:\r\n\r\n    override fun resolveDependencies(projectDir: File, definitionFiles: List<File>): ResolutionResult {\r\n        val result = mutableMapOf<File, AnalyzerResult>()\r\n\r\n        // Simply pass on the list of POM files to Maven, ignoring the SBT build files here.\r\n        Maven.create().resolveDependencies(projectDir, prepareResolution(definitionFiles)).mapValuesTo(result) {\r\n            val sbtProjectId = it.value.project.id.copy(packageManager = javaClass.simpleName)\r\n            val sbtProject = it.value.project.copy(id = sbtProjectId)\r\n            it.value.copy(project = sbtProject)\r\n        }\r\n\r\n        return result\r\n    }","created_at":"2018-02-14T09:01:29Z","updated_at":"2018-02-14T09:02:26Z","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/322#discussion_r168110196","pull_request_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/168110196"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/322#discussion_r168110196"},"pull_request":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322","id":168902390,"html_url":"https://github.com/heremaps/oss-review-toolkit/pull/322","diff_url":"https://github.com/heremaps/oss-review-toolkit/pull/322.diff","patch_url":"https://github.com/heremaps/oss-review-toolkit/pull/322.patch","issue_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/322","number":322,"state":"open","locked":false,"title":"analyzer: Use directory of definition file to get VcsInfo for projects","user":{"login":"mnonnenmacher","id":2741977,"avatar_url":"https://avatars2.githubusercontent.com/u/2741977?v=4","gravatar_id":"","url":"https://api.github.com/users/mnonnenmacher","html_url":"https://github.com/mnonnenmacher","followers_url":"https://api.github.com/users/mnonnenmacher/followers","following_url":"https://api.github.com/users/mnonnenmacher/following{/other_user}","gists_url":"https://api.github.com/users/mnonnenmacher/gists{/gist_id}","starred_url":"https://api.github.com/users/mnonnenmacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnonnenmacher/subscriptions","organizations_url":"https://api.github.com/users/mnonnenmacher/orgs","repos_url":"https://api.github.com/users/mnonnenmacher/repos","events_url":"https://api.github.com/users/mnonnenmacher/events{/privacy}","received_events_url":"https://api.github.com/users/mnonnenmacher/received_events","type":"User","site_admin":false},"body":"When creating a Project object use the directory where the definition file\r\nis located to get the VcsInfo of the working tree. Before, the root\r\ndirectory of the VCS was used (except for NPM which already did it this\r\nway).\r\n\r\nThis provides more precise information about the project, as the paths were\r\nsometimes not correct before. Also it fixes a big issue with GitRepo where\r\nthe VCS path was determined against the .git/manifest directory which\r\nresulted in a broken VcsInfo, usually with the VCS path \"../..\". With this\r\nchange the subprojects of the GitRepo project now get the VcsInfo for their\r\nGit repository instead.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/heremaps/oss-review-toolkit/322)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-02-13T17:04:41Z","updated_at":"2018-02-14T09:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd965746c65b1f619eed027d3fdfba6f7ddd01b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322/commits","review_comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322/comments","review_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/322/comments","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/e623f99f27374208da5ee76f46d69981b9eab005","head":{"label":"heremaps:project-vcs-working-dir","ref":"project-vcs-working-dir","sha":"e623f99f27374208da5ee76f46d69981b9eab005","user":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-02-13T15:35:23Z","pushed_at":"2018-02-14T08:46:14Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":49445,"stargazers_count":43,"watchers_count":43,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":20,"watchers":43,"default_branch":"master"}},"base":{"label":"heremaps:master","ref":"master","sha":"9310e296bfcc09c88cedbfce071a45abb8910169","user":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-02-13T15:35:23Z","pushed_at":"2018-02-14T08:46:14Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":49445,"stargazers_count":43,"watchers_count":43,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":20,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/322"},"issue":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/322"},"comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/e623f99f27374208da5ee76f46d69981b9eab005"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sschuberth"}}