{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/299","repository_url":"https://api.github.com/repos/Islandora/islandora_scholar","labels_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/299/comments","events_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/299/events","html_url":"https://github.com/Islandora/islandora_scholar/pull/299","id":342055503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDQ2NzI2","number":299,"title":"Islandora 2251 Resubmitted","user":{"login":"DonRichards","id":2738244,"node_id":"MDQ6VXNlcjI3MzgyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2738244?v=4","gravatar_id":"","url":"https://api.github.com/users/DonRichards","html_url":"https://github.com/DonRichards","followers_url":"https://api.github.com/users/DonRichards/followers","following_url":"https://api.github.com/users/DonRichards/following{/other_user}","gists_url":"https://api.github.com/users/DonRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/DonRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonRichards/subscriptions","organizations_url":"https://api.github.com/users/DonRichards/orgs","repos_url":"https://api.github.com/users/DonRichards/repos","events_url":"https://api.github.com/users/DonRichards/events{/privacy}","received_events_url":"https://api.github.com/users/DonRichards/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":82,"created_at":"2018-07-17T19:36:10Z","updated_at":"2018-08-28T18:15:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/299","html_url":"https://github.com/Islandora/islandora_scholar/pull/299","diff_url":"https://github.com/Islandora/islandora_scholar/pull/299.diff","patch_url":"https://github.com/Islandora/islandora_scholar/pull/299.patch"},"body":"## Resubmitted from https://github.com/Islandora/islandora_scholar/pull/295 due to an issue with the branch. \r\n\r\n**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-2251\r\n\r\nhttps://docs.google.com/spreadsheets/d/1PtK16Fo2q4jTMgz17DYmV1nauvoGDEi6f2fhl9K1ZIA\r\n\r\n# What does this Pull Request do?\r\n\r\nMakes the XPaths editable through an admin GUI\r\n\r\n![ISLANDORA SCHOLAR XPATH CONFIGURATION](https://user-images.githubusercontent.com/2738244/43010388-539f4278-8c0e-11e8-89b9-affbe6287451.png)\r\n\r\n### Enabled\r\n![Complete](https://user-images.githubusercontent.com/2738244/43728147-28545948-9972-11e8-88b6-82de81703268.png)\r\n\r\n# What's new?\r\n\r\nIslandora Scholar XPath Configuration Section located on the /admin/islandora/solution_pack_config/scholar page. \r\n\r\n1. It allows you to modify the modules' XPaths.\r\n2. It allows you reset the xpaths back to the original values.\r\n3. It will show in real time preview of the values of a given MODS XPath value for a given PID. Preview returns the value in 1 of 4 states.\r\n     a. Path cannot be blank (User provided XPath is blank and not allowed)\r\n     b. Error (User provided XPath has a syntax error)\r\n     c. Nothing found at the specified XPath\r\n     d. Found value at the specified XPath\r\n\r\n# How should this be tested?\r\n* Start islandora_vagrant and ingest an item (prior to switching to this PR)\r\n  * Inspect it and test that the search results look like expects\r\n  * from the terminal\r\n```terminal\r\n      $ vagrant ssh\r\n      $ cd /var/www/drupal\r\n      $ drush vget islandora_scholar_default_search_xpath\r\n      No matching variable found.\r\n```\r\n* Switch to this PR\r\n  * Go to /admin/islandora/solution_pack_config/scholar page and click 'Save Configuration'\r\n  * from the terminal\r\n```terminal\r\n      $ vagrant ssh\r\n      $ cd /var/www/drupal\r\n      $ drush vget islandora_scholar_default_search_xpath\r\n...\r\n```\r\n  * This time you should see several results\r\n  * Ingest an item\r\n  * Try modifying an XPath (easiest is to switch title with something else)\r\n  * Verify the MODS validation is working as expected(give it a valid value, an invalid value, a blank value and possible an error causing value). \r\n  * Check that the change shows up on a new ingest and an existing one. \r\n  * Also try adding new values to the citation_form.xml or thesis_form.xml and see if pointing to the new values works. \r\n\r\n# Additional Notes:\r\n\r\n* This change requires documentation to be updated. Only placeholders were added. \r\n* This should not impact existing installations.\r\n* This does **NOT** modify the submission form.\r\n* This allows for the 52 XPaths and 3 subpaths to be set\r\n* This exclude subpaths in a few spots where they occurred.\r\n    * Check google doc for excluded some paths\r\n\r\nUsing some feedback (from committers call) I set the menu to default to collapsed to keep the screen clean.\r\n![0](https://user-images.githubusercontent.com/2738244/43010444-7b670390-8c0e-11e8-82c4-6c30c0045407.png)\r\n\r\n# Interested parties\r\nTag (@ mention) interested parties or, if unsure, @Islandora/7-x-1-x-committers "},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/comments/416688116","html_url":"https://github.com/Islandora/islandora_scholar/pull/299#issuecomment-416688116","issue_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/299","id":416688116,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjY4ODExNg==","user":{"login":"d-r-p","id":22350048,"node_id":"MDQ6VXNlcjIyMzUwMDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/22350048?v=4","gravatar_id":"","url":"https://api.github.com/users/d-r-p","html_url":"https://github.com/d-r-p","followers_url":"https://api.github.com/users/d-r-p/followers","following_url":"https://api.github.com/users/d-r-p/following{/other_user}","gists_url":"https://api.github.com/users/d-r-p/gists{/gist_id}","starred_url":"https://api.github.com/users/d-r-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-r-p/subscriptions","organizations_url":"https://api.github.com/users/d-r-p/orgs","repos_url":"https://api.github.com/users/d-r-p/repos","events_url":"https://api.github.com/users/d-r-p/events{/privacy}","received_events_url":"https://api.github.com/users/d-r-p/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T18:15:29Z","updated_at":"2018-08-28T18:15:29Z","author_association":"CONTRIBUTOR","body":"@DonRichards @bryjbrown @bondjimbond I do not mind if we push this through before correcting the wrong values. However, I reckon we should make absolutely sure that the system behaves _identically_ to before this PR if no XPath is changed (independently of whether the admin form has been saved or not). This way, users who already circumvented the wrongly defined (and previously hard-coded) default values will not be caught by surprise. Also, I feel that fixing those values later will be easier this way... Or do you disagree?\r\n\r\n@DiegoPino Good idea with cleaning the MODS. But regarding the wrapping `<modsCollection>`, would it not be possible to get rid of that manually?"}}
{"actor":{"display_login":"d-r-p"}}