{"action":"closed","number":3195,"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/3195","id":219491544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDkxNTQ0","html_url":"https://github.com/kubernetes/minikube/pull/3195","diff_url":"https://github.com/kubernetes/minikube/pull/3195.diff","patch_url":"https://github.com/kubernetes/minikube/pull/3195.patch","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/3195","number":3195,"state":"closed","locked":false,"title":"ensure that /dev has settled before operating","user":{"login":"davidovich","id":1440370,"node_id":"MDQ6VXNlcjE0NDAzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1440370?v=4","gravatar_id":"","url":"https://api.github.com/users/davidovich","html_url":"https://github.com/davidovich","followers_url":"https://api.github.com/users/davidovich/followers","following_url":"https://api.github.com/users/davidovich/following{/other_user}","gists_url":"https://api.github.com/users/davidovich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidovich/subscriptions","organizations_url":"https://api.github.com/users/davidovich/orgs","repos_url":"https://api.github.com/users/davidovich/repos","events_url":"https://api.github.com/users/davidovich/events{/privacy}","received_events_url":"https://api.github.com/users/davidovich/received_events","type":"User","site_admin":false},"body":"Minikube automount relies on a VM disk to be mounted (usually /dev/sda)\r\nto provide .ssh credentials.\r\n\r\nThis commit adds a dependency on systemd-udev-settle to ensure that all devices\r\n(including disks) are up and available before executing the mount\r\nscript.\r\n\r\nWe use systemd-udev-settle\r\nhttps://github.com/systemd/systemd/blob/master/units/systemd-udev-settle.service.in\r\n\r\nTo ensure this. Note that in the above link, we can read a comment\r\nstating that systemd-udev-settle is used to ensure a populated /dev\r\nduring bootup, which is exaclty what we want.\r\n\r\ncloses #3167 \r\n\r\nNote that it may close other ssh related issues on several platforms.","created_at":"2018-10-01T19:39:59Z","updated_at":"2018-10-04T04:36:55Z","closed_at":"2018-10-04T04:36:55Z","merged_at":"2018-10-04T04:36:55Z","merge_commit_sha":"9ce572222e7ee267499354f0448b9b7155a32f32","assignee":null,"assignees":[],"requested_reviewers":[{"login":"balopat","id":635073,"node_id":"MDQ6VXNlcjYzNTA3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false},{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764028805,"node_id":"MDU6TGFiZWw3NjQwMjg4MDU=","url":"https://api.github.com/repos/kubernetes/minikube/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484585353,"node_id":"MDU6TGFiZWw0ODQ1ODUzNTM=","url":"https://api.github.com/repos/kubernetes/minikube/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676458646,"node_id":"MDU6TGFiZWw2NzY0NTg2NDY=","url":"https://api.github.com/repos/kubernetes/minikube/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/minikube/pulls/3195/commits","review_comments_url":"https://api.github.com/repos/kubernetes/minikube/pulls/3195/comments","review_comment_url":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/3195/comments","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/bb07acdc908f6650c6e0e327be0e4021eff16fd0","head":{"label":"davidovich:ensure_dev_mounted","ref":"ensure_dev_mounted","sha":"bb07acdc908f6650c6e0e327be0e4021eff16fd0","user":{"login":"davidovich","id":1440370,"node_id":"MDQ6VXNlcjE0NDAzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1440370?v=4","gravatar_id":"","url":"https://api.github.com/users/davidovich","html_url":"https://github.com/davidovich","followers_url":"https://api.github.com/users/davidovich/followers","following_url":"https://api.github.com/users/davidovich/following{/other_user}","gists_url":"https://api.github.com/users/davidovich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidovich/subscriptions","organizations_url":"https://api.github.com/users/davidovich/orgs","repos_url":"https://api.github.com/users/davidovich/repos","events_url":"https://api.github.com/users/davidovich/events{/privacy}","received_events_url":"https://api.github.com/users/davidovich/received_events","type":"User","site_admin":false},"repo":{"id":150349003,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzNDkwMDM=","name":"minikube","full_name":"davidovich/minikube","private":false,"owner":{"login":"davidovich","id":1440370,"node_id":"MDQ6VXNlcjE0NDAzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1440370?v=4","gravatar_id":"","url":"https://api.github.com/users/davidovich","html_url":"https://github.com/davidovich","followers_url":"https://api.github.com/users/davidovich/followers","following_url":"https://api.github.com/users/davidovich/following{/other_user}","gists_url":"https://api.github.com/users/davidovich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidovich/subscriptions","organizations_url":"https://api.github.com/users/davidovich/orgs","repos_url":"https://api.github.com/users/davidovich/repos","events_url":"https://api.github.com/users/davidovich/events{/privacy}","received_events_url":"https://api.github.com/users/davidovich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidovich/minikube","description":"Run Kubernetes locally","fork":true,"url":"https://api.github.com/repos/davidovich/minikube","forks_url":"https://api.github.com/repos/davidovich/minikube/forks","keys_url":"https://api.github.com/repos/davidovich/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidovich/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidovich/minikube/teams","hooks_url":"https://api.github.com/repos/davidovich/minikube/hooks","issue_events_url":"https://api.github.com/repos/davidovich/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/davidovich/minikube/events","assignees_url":"https://api.github.com/repos/davidovich/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/davidovich/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/davidovich/minikube/tags","blobs_url":"https://api.github.com/repos/davidovich/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidovich/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidovich/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidovich/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidovich/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/davidovich/minikube/languages","stargazers_url":"https://api.github.com/repos/davidovich/minikube/stargazers","contributors_url":"https://api.github.com/repos/davidovich/minikube/contributors","subscribers_url":"https://api.github.com/repos/davidovich/minikube/subscribers","subscription_url":"https://api.github.com/repos/davidovich/minikube/subscription","commits_url":"https://api.github.com/repos/davidovich/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidovich/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidovich/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidovich/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidovich/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/davidovich/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidovich/minikube/merges","archive_url":"https://api.github.com/repos/davidovich/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidovich/minikube/downloads","issues_url":"https://api.github.com/repos/davidovich/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/davidovich/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/davidovich/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/davidovich/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidovich/minikube/labels{/name}","releases_url":"https://api.github.com/repos/davidovich/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/davidovich/minikube/deployments","created_at":"2018-09-26T01:06:57Z","updated_at":"2018-09-26T01:07:01Z","pushed_at":"2018-10-01T19:58:16Z","git_url":"git://github.com/davidovich/minikube.git","ssh_url":"git@github.com:davidovich/minikube.git","clone_url":"https://github.com/davidovich/minikube.git","svn_url":"https://github.com/davidovich/minikube","homepage":null,"size":50631,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"55afd089f45ad0eeaba6843c60258f034bc289c8","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":56353740,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM1Mzc0MA==","name":"minikube","full_name":"kubernetes/minikube","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/minikube","description":"Run Kubernetes locally","fork":false,"url":"https://api.github.com/repos/kubernetes/minikube","forks_url":"https://api.github.com/repos/kubernetes/minikube/forks","keys_url":"https://api.github.com/repos/kubernetes/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/minikube/teams","hooks_url":"https://api.github.com/repos/kubernetes/minikube/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/minikube/events","assignees_url":"https://api.github.com/repos/kubernetes/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/minikube/tags","blobs_url":"https://api.github.com/repos/kubernetes/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/minikube/languages","stargazers_url":"https://api.github.com/repos/kubernetes/minikube/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/minikube/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/minikube/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/minikube/subscription","commits_url":"https://api.github.com/repos/kubernetes/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/minikube/merges","archive_url":"https://api.github.com/repos/kubernetes/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/minikube/downloads","issues_url":"https://api.github.com/repos/kubernetes/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/minikube/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/minikube/deployments","created_at":"2016-04-15T22:38:35Z","updated_at":"2018-10-04T00:20:38Z","pushed_at":"2018-10-04T04:36:55Z","git_url":"git://github.com/kubernetes/minikube.git","ssh_url":"git@github.com:kubernetes/minikube.git","clone_url":"https://github.com/kubernetes/minikube.git","svn_url":"https://github.com/kubernetes/minikube","homepage":null,"size":50654,"stargazers_count":11003,"watchers_count":11003,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1593,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1593,"open_issues":277,"watchers":11003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/3195"},"html":{"href":"https://github.com/kubernetes/minikube/pull/3195"},"issue":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/3195"},"comments":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/3195/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/3195/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/3195/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/minikube/statuses/bb07acdc908f6650c6e0e327be0e4021eff16fd0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tstromberg","id":101424,"node_id":"MDQ6VXNlcjEwMTQyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101424?v=4","gravatar_id":"","url":"https://api.github.com/users/tstromberg","html_url":"https://github.com/tstromberg","followers_url":"https://api.github.com/users/tstromberg/followers","following_url":"https://api.github.com/users/tstromberg/following{/other_user}","gists_url":"https://api.github.com/users/tstromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tstromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstromberg/subscriptions","organizations_url":"https://api.github.com/users/tstromberg/orgs","repos_url":"https://api.github.com/users/tstromberg/repos","events_url":"https://api.github.com/users/tstromberg/events{/privacy}","received_events_url":"https://api.github.com/users/tstromberg/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"tstromberg"}}