{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/tuomas2/and-bible/pulls/13","id":200520297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTIwMjk3","html_url":"https://github.com/tuomas2/and-bible/pull/13","diff_url":"https://github.com/tuomas2/and-bible/pull/13.diff","patch_url":"https://github.com/tuomas2/and-bible/pull/13.patch","issue_url":"https://api.github.com/repos/tuomas2/and-bible/issues/13","number":13,"state":"closed","locked":false,"title":"Feature/sdk update","user":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"body":"- [x] Upgrade SDK version to 27\r\n- [x] Screen timeout (https://github.com/tuomas2/and-bible/pull/11)\r\n- [x] Request permission to save/restore backup to external storage\r\n- [x] Check phone state reading permissions (=> no permissions query needed)\r\n- [x] Check permission to access manual install dir (sdcard/jsword)\r\n- [x] Investigate how Andbible addons can install modules => It can do it with by requesting WRITE_EXTERMAL_STORAGE permission. \r\n- [ ] Request permission to access manual instal dir (sdcard/jsword)? Should we have option for this in settings?\r\n- [x] Notification for document downloading is broken (fixed)\r\n- [x] Test with different targets in emulator\r\n- [x] Incoming call handling bugs\r\n\r\n## Test results:\r\n\r\n### Search index creation and find:\r\nkitkat 19: OK\r\nlollipop 21:  OK\r\nmarshmallow 23: **NOK**\r\nnougat 25: OK\r\noreo 26: OK\r\nP 28: OK\r\n\r\n### Download:\r\nkitkat 19 OK\r\nlollipop: OK\r\nMarshMallow OK\r\nnougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Speak and notification: \r\nkitkat OK\r\nlollipop: OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Widget:\r\nKitkat OK\r\nLollipop OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Stop speaking on phonecall:\r\nKitkat OK\r\nLollipop OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n\r\nUpdated notification:\r\n![screenshot_1531064037](https://user-images.githubusercontent.com/5811789/42421393-8dc0385c-82dd-11e8-8b7d-1ca82f772a4d.png)\r\n","created_at":"2018-07-10T20:53:20Z","updated_at":"2018-07-22T06:05:43Z","closed_at":"2018-07-22T06:05:43Z","merged_at":null,"merge_commit_sha":"8b78e4d817867a01d9f0cec14b50c5a05c4c7232","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tuomas2/and-bible/pulls/13/commits","review_comments_url":"https://api.github.com/repos/tuomas2/and-bible/pulls/13/comments","review_comment_url":"https://api.github.com/repos/tuomas2/and-bible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tuomas2/and-bible/issues/13/comments","statuses_url":"https://api.github.com/repos/tuomas2/and-bible/statuses/25fa3aabb4bd61ac1154d304740ee717203580ef","head":{"label":"tuomas2:feature/sdk-update","ref":"feature/sdk-update","sha":"25fa3aabb4bd61ac1154d304740ee717203580ef","user":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"repo":{"id":37821990,"node_id":"MDEwOlJlcG9zaXRvcnkzNzgyMTk5MA==","name":"and-bible","full_name":"tuomas2/and-bible","owner":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuomas2/and-bible","description":"Bible on Android","fork":true,"url":"https://api.github.com/repos/tuomas2/and-bible","forks_url":"https://api.github.com/repos/tuomas2/and-bible/forks","keys_url":"https://api.github.com/repos/tuomas2/and-bible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuomas2/and-bible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuomas2/and-bible/teams","hooks_url":"https://api.github.com/repos/tuomas2/and-bible/hooks","issue_events_url":"https://api.github.com/repos/tuomas2/and-bible/issues/events{/number}","events_url":"https://api.github.com/repos/tuomas2/and-bible/events","assignees_url":"https://api.github.com/repos/tuomas2/and-bible/assignees{/user}","branches_url":"https://api.github.com/repos/tuomas2/and-bible/branches{/branch}","tags_url":"https://api.github.com/repos/tuomas2/and-bible/tags","blobs_url":"https://api.github.com/repos/tuomas2/and-bible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuomas2/and-bible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuomas2/and-bible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuomas2/and-bible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuomas2/and-bible/statuses/{sha}","languages_url":"https://api.github.com/repos/tuomas2/and-bible/languages","stargazers_url":"https://api.github.com/repos/tuomas2/and-bible/stargazers","contributors_url":"https://api.github.com/repos/tuomas2/and-bible/contributors","subscribers_url":"https://api.github.com/repos/tuomas2/and-bible/subscribers","subscription_url":"https://api.github.com/repos/tuomas2/and-bible/subscription","commits_url":"https://api.github.com/repos/tuomas2/and-bible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuomas2/and-bible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuomas2/and-bible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuomas2/and-bible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuomas2/and-bible/contents/{+path}","compare_url":"https://api.github.com/repos/tuomas2/and-bible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuomas2/and-bible/merges","archive_url":"https://api.github.com/repos/tuomas2/and-bible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuomas2/and-bible/downloads","issues_url":"https://api.github.com/repos/tuomas2/and-bible/issues{/number}","pulls_url":"https://api.github.com/repos/tuomas2/and-bible/pulls{/number}","milestones_url":"https://api.github.com/repos/tuomas2/and-bible/milestones{/number}","notifications_url":"https://api.github.com/repos/tuomas2/and-bible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuomas2/and-bible/labels{/name}","releases_url":"https://api.github.com/repos/tuomas2/and-bible/releases{/id}","deployments_url":"https://api.github.com/repos/tuomas2/and-bible/deployments","created_at":"2015-06-21T19:09:47Z","updated_at":"2018-04-19T08:57:04Z","pushed_at":"2018-07-22T06:00:52Z","git_url":"git://github.com/tuomas2/and-bible.git","ssh_url":"git@github.com:tuomas2/and-bible.git","clone_url":"https://github.com/tuomas2/and-bible.git","svn_url":"https://github.com/tuomas2/and-bible","homepage":"http://mjdenham.github.io/and-bible/","size":102269,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tuomas2:feature/speak/all","ref":"feature/speak/all","sha":"3622a9263fa68d485f8f53fa09dd6f158b68d07a","user":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"repo":{"id":37821990,"node_id":"MDEwOlJlcG9zaXRvcnkzNzgyMTk5MA==","name":"and-bible","full_name":"tuomas2/and-bible","owner":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuomas2/and-bible","description":"Bible on Android","fork":true,"url":"https://api.github.com/repos/tuomas2/and-bible","forks_url":"https://api.github.com/repos/tuomas2/and-bible/forks","keys_url":"https://api.github.com/repos/tuomas2/and-bible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuomas2/and-bible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuomas2/and-bible/teams","hooks_url":"https://api.github.com/repos/tuomas2/and-bible/hooks","issue_events_url":"https://api.github.com/repos/tuomas2/and-bible/issues/events{/number}","events_url":"https://api.github.com/repos/tuomas2/and-bible/events","assignees_url":"https://api.github.com/repos/tuomas2/and-bible/assignees{/user}","branches_url":"https://api.github.com/repos/tuomas2/and-bible/branches{/branch}","tags_url":"https://api.github.com/repos/tuomas2/and-bible/tags","blobs_url":"https://api.github.com/repos/tuomas2/and-bible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuomas2/and-bible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuomas2/and-bible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuomas2/and-bible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuomas2/and-bible/statuses/{sha}","languages_url":"https://api.github.com/repos/tuomas2/and-bible/languages","stargazers_url":"https://api.github.com/repos/tuomas2/and-bible/stargazers","contributors_url":"https://api.github.com/repos/tuomas2/and-bible/contributors","subscribers_url":"https://api.github.com/repos/tuomas2/and-bible/subscribers","subscription_url":"https://api.github.com/repos/tuomas2/and-bible/subscription","commits_url":"https://api.github.com/repos/tuomas2/and-bible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuomas2/and-bible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuomas2/and-bible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuomas2/and-bible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuomas2/and-bible/contents/{+path}","compare_url":"https://api.github.com/repos/tuomas2/and-bible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuomas2/and-bible/merges","archive_url":"https://api.github.com/repos/tuomas2/and-bible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuomas2/and-bible/downloads","issues_url":"https://api.github.com/repos/tuomas2/and-bible/issues{/number}","pulls_url":"https://api.github.com/repos/tuomas2/and-bible/pulls{/number}","milestones_url":"https://api.github.com/repos/tuomas2/and-bible/milestones{/number}","notifications_url":"https://api.github.com/repos/tuomas2/and-bible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuomas2/and-bible/labels{/name}","releases_url":"https://api.github.com/repos/tuomas2/and-bible/releases{/id}","deployments_url":"https://api.github.com/repos/tuomas2/and-bible/deployments","created_at":"2015-06-21T19:09:47Z","updated_at":"2018-04-19T08:57:04Z","pushed_at":"2018-07-22T06:00:52Z","git_url":"git://github.com/tuomas2/and-bible.git","ssh_url":"git@github.com:tuomas2/and-bible.git","clone_url":"https://github.com/tuomas2/and-bible.git","svn_url":"https://github.com/tuomas2/and-bible","homepage":"http://mjdenham.github.io/and-bible/","size":102269,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tuomas2/and-bible/pulls/13"},"html":{"href":"https://github.com/tuomas2/and-bible/pull/13"},"issue":{"href":"https://api.github.com/repos/tuomas2/and-bible/issues/13"},"comments":{"href":"https://api.github.com/repos/tuomas2/and-bible/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/tuomas2/and-bible/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/tuomas2/and-bible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tuomas2/and-bible/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/tuomas2/and-bible/statuses/25fa3aabb4bd61ac1154d304740ee717203580ef"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":19,"additions":254,"deletions":248,"changed_files":20}}
{"actor":{"display_login":"tuomas2"}}