{"action":"created","issue":{"url":"https://api.github.com/repos/onevcat/Kingfisher/issues/985","repository_url":"https://api.github.com/repos/onevcat/Kingfisher","labels_url":"https://api.github.com/repos/onevcat/Kingfisher/issues/985/labels{/name}","comments_url":"https://api.github.com/repos/onevcat/Kingfisher/issues/985/comments","events_url":"https://api.github.com/repos/onevcat/Kingfisher/issues/985/events","html_url":"https://github.com/onevcat/Kingfisher/pull/985","id":353281532,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzcyNjE1","number":985,"title":"Cancel download task when response status code invalid","user":{"login":"zhongwuzw","id":5061845,"node_id":"MDQ6VXNlcjUwNjE4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5061845?v=4","gravatar_id":"","url":"https://api.github.com/users/zhongwuzw","html_url":"https://github.com/zhongwuzw","followers_url":"https://api.github.com/users/zhongwuzw/followers","following_url":"https://api.github.com/users/zhongwuzw/following{/other_user}","gists_url":"https://api.github.com/users/zhongwuzw/gists{/gist_id}","starred_url":"https://api.github.com/users/zhongwuzw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhongwuzw/subscriptions","organizations_url":"https://api.github.com/users/zhongwuzw/orgs","repos_url":"https://api.github.com/users/zhongwuzw/repos","events_url":"https://api.github.com/users/zhongwuzw/events{/privacy}","received_events_url":"https://api.github.com/users/zhongwuzw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-23T08:43:29Z","updated_at":"2018-09-16T01:44:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/onevcat/Kingfisher/pulls/985","html_url":"https://github.com/onevcat/Kingfisher/pull/985","diff_url":"https://github.com/onevcat/Kingfisher/pull/985.diff","patch_url":"https://github.com/onevcat/Kingfisher/pull/985.patch"},"body":"I think we don't need to go on downloading data if the status code is invalid."},"comment":{"url":"https://api.github.com/repos/onevcat/Kingfisher/issues/comments/421669628","html_url":"https://github.com/onevcat/Kingfisher/pull/985#issuecomment-421669628","issue_url":"https://api.github.com/repos/onevcat/Kingfisher/issues/985","id":421669628,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTY2OTYyOA==","user":{"login":"onevcat","id":1019875,"node_id":"MDQ6VXNlcjEwMTk4NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1019875?v=4","gravatar_id":"","url":"https://api.github.com/users/onevcat","html_url":"https://github.com/onevcat","followers_url":"https://api.github.com/users/onevcat/followers","following_url":"https://api.github.com/users/onevcat/following{/other_user}","gists_url":"https://api.github.com/users/onevcat/gists{/gist_id}","starred_url":"https://api.github.com/users/onevcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onevcat/subscriptions","organizations_url":"https://api.github.com/users/onevcat/orgs","repos_url":"https://api.github.com/users/onevcat/repos","events_url":"https://api.github.com/users/onevcat/events{/privacy}","received_events_url":"https://api.github.com/users/onevcat/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T01:44:21Z","updated_at":"2018-09-16T01:44:21Z","author_association":"OWNER","body":"@zhongwuzw Maybe you misunderstood me. I mean, if the request fails due to an invalid status code number after we `.allow` it in this delegate method, the user could get a detail response error with its actual code to know what happened. However, if we `.cancel` it here, only an NSURLError with code -999 (user canceled) will be thrown. It hides the real reason of the error."}}
{"actor":{"display_login":"onevcat"}}