{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/176168355","pull_request_review_id":105819805,"id":176168355,"diff_hunk":"@@ -97,6 +99,7 @@ class Node : public NetworkPeer {\n     NodeType_t _type;\n \n     QUuid _connectionSecret;\n+    std::unique_ptr<HmacAuth> _authenticateHash;","path":"libraries/networking/src/Node.h","position":22,"original_position":22,"commit_id":"8ce03d65b76493ddc4c8d8a92bd3eea6abfc938a","original_commit_id":"8ce03d65b76493ddc4c8d8a92bd3eea6abfc938a","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"It looks like this should maybe just be a regular member of the class? We always have it.","created_at":"2018-03-21T17:22:13Z","updated_at":"2018-03-21T17:28:54Z","html_url":"https://github.com/highfidelity/hifi/pull/12690#discussion_r176168355","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12690","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/176168355"},"html":{"href":"https://github.com/highfidelity/hifi/pull/12690#discussion_r176168355"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12690"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12690","id":176535882,"html_url":"https://github.com/highfidelity/hifi/pull/12690","diff_url":"https://github.com/highfidelity/hifi/pull/12690.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12690.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12690","number":12690,"state":"open","locked":false,"title":"Change packet authentication to use HMAC","user":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"body":"https://highfidelity.manuscript.com/f/cases/12880/\r\n\r\nThis changes the network authentication scheme to use HMAC-MD5 (from the openssl lib) rather than just MD5. The change bumps the version numbers of all affected packet types, which is almost all of them. All hifi components (ACs, interface etc) must be upgraded.\r\n\r\nNB. The change will likely require rerunning cmake.","created_at":"2018-03-21T16:31:25Z","updated_at":"2018-03-21T17:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f7af3526aaa95369c4568917c160084a7de8a39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12690/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12690/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12690/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/8ce03d65b76493ddc4c8d8a92bd3eea6abfc938a","head":{"label":"SimonWalton-HiFi:hmac-auth","ref":"hmac-auth","sha":"8ce03d65b76493ddc4c8d8a92bd3eea6abfc938a","user":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"repo":{"id":122272443,"name":"hifi","full_name":"SimonWalton-HiFi/hifi","owner":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonWalton-HiFi/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/SimonWalton-HiFi/hifi","forks_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/forks","keys_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/teams","hooks_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/hooks","issue_events_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/events","assignees_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/tags","blobs_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/languages","stargazers_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/stargazers","contributors_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/contributors","subscribers_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/subscribers","subscription_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/subscription","commits_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/merges","archive_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/downloads","issues_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/labels{/name}","releases_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/deployments","created_at":"2018-02-21T00:01:45Z","updated_at":"2018-03-15T17:00:47Z","pushed_at":"2018-03-21T01:21:24Z","git_url":"git://github.com/SimonWalton-HiFi/hifi.git","ssh_url":"git@github.com:SimonWalton-HiFi/hifi.git","clone_url":"https://github.com/SimonWalton-HiFi/hifi.git","svn_url":"https://github.com/SimonWalton-HiFi/hifi","homepage":"","size":464365,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"f5f4e2a78079b934dc4b808888fd58afd603176a","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-03-21T16:28:13Z","pushed_at":"2018-03-21T17:20:42Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":465027,"stargazers_count":598,"watchers_count":598,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":395,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":395,"open_issues":147,"watchers":598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12690"},"html":{"href":"https://github.com/highfidelity/hifi/pull/12690"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12690"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12690/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12690/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12690/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/8ce03d65b76493ddc4c8d8a92bd3eea6abfc938a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"birarda"}}