{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/167850975","pull_request_review_id":96125692,"id":167850975,"diff_hunk":"@@ -0,0 +1,47 @@\n+apiVersion: kubevirt.io/v1alpha1\n+kind: VirtualMachinePreset\n+metadata:\n+  name: windows2012r2-preset\n+  selector:\n+    matchLabels:\n+      flavor: windows2012r2\n+spec:\n+  terminationGracePeriodSeconds: 0\n+  domain:\n+    cpu:\n+      cores: 2\n+    features:\n+      acpi: {}\n+      apic: {}\n+      hyperv:\n+        relaxed: {}\n+        vapic: {}\n+        spinlocks:\n+          spinlocks: 8191\n+    clock:\n+      utc: {}\n+      timer:\n+        hpet:\n+          present: false\n+        pit:\n+          tickPolicy: delay\n+        rtc:\n+          tickPolicy: catchup\n+        hyperv: {}\n+    firmware:\n+      uuid: 5d307ca9-b3ef-428c-8861-06e72d69f223\n+    resources:\n+      requests:\n+        memory: 512M\n+    devices:\n+      disks:","path":"cluster/vmpreset-windows.yaml","position":37,"original_position":37,"commit_id":"e41116b44abf61e6984b9751e4e2e9dc0cf69c91","original_commit_id":"e41116b44abf61e6984b9751e4e2e9dc0cf69c91","user":{"login":"fabiand","id":83456,"avatar_url":"https://avatars1.githubusercontent.com/u/83456?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiand","html_url":"https://github.com/fabiand","followers_url":"https://api.github.com/users/fabiand/followers","following_url":"https://api.github.com/users/fabiand/following{/other_user}","gists_url":"https://api.github.com/users/fabiand/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiand/subscriptions","organizations_url":"https://api.github.com/users/fabiand/orgs","repos_url":"https://api.github.com/users/fabiand/repos","events_url":"https://api.github.com/users/fabiand/events{/privacy}","received_events_url":"https://api.github.com/users/fabiand/received_events","type":"User","site_admin":false},"body":"For this preset I'd drop the disk and volumes part.","created_at":"2018-02-13T12:37:57Z","updated_at":"2018-02-13T12:38:21Z","html_url":"https://github.com/kubevirt/kubevirt/pull/731#discussion_r167850975","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/167850975"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/731#discussion_r167850975"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731","id":168788427,"html_url":"https://github.com/kubevirt/kubevirt/pull/731","diff_url":"https://github.com/kubevirt/kubevirt/pull/731.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/731.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/731","number":731,"state":"open","locked":false,"title":"Add Virtual machine preset for Windows Server 2012","user":{"login":"yanirq","id":18440857,"avatar_url":"https://avatars0.githubusercontent.com/u/18440857?v=4","gravatar_id":"","url":"https://api.github.com/users/yanirq","html_url":"https://github.com/yanirq","followers_url":"https://api.github.com/users/yanirq/followers","following_url":"https://api.github.com/users/yanirq/following{/other_user}","gists_url":"https://api.github.com/users/yanirq/gists{/gist_id}","starred_url":"https://api.github.com/users/yanirq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanirq/subscriptions","organizations_url":"https://api.github.com/users/yanirq/orgs","repos_url":"https://api.github.com/users/yanirq/repos","events_url":"https://api.github.com/users/yanirq/events{/privacy}","received_events_url":"https://api.github.com/users/yanirq/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Yanir Quinn <yquinn@redhat.com>","created_at":"2018-02-13T09:09:06Z","updated_at":"2018-02-13T12:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f90aa9b474d719ac6e81543f7d354006652065f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/731/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/e41116b44abf61e6984b9751e4e2e9dc0cf69c91","head":{"label":"yanirq:yquinn-branch","ref":"yquinn-branch","sha":"e41116b44abf61e6984b9751e4e2e9dc0cf69c91","user":{"login":"yanirq","id":18440857,"avatar_url":"https://avatars0.githubusercontent.com/u/18440857?v=4","gravatar_id":"","url":"https://api.github.com/users/yanirq","html_url":"https://github.com/yanirq","followers_url":"https://api.github.com/users/yanirq/followers","following_url":"https://api.github.com/users/yanirq/following{/other_user}","gists_url":"https://api.github.com/users/yanirq/gists{/gist_id}","starred_url":"https://api.github.com/users/yanirq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanirq/subscriptions","organizations_url":"https://api.github.com/users/yanirq/orgs","repos_url":"https://api.github.com/users/yanirq/repos","events_url":"https://api.github.com/users/yanirq/events{/privacy}","received_events_url":"https://api.github.com/users/yanirq/received_events","type":"User","site_admin":false},"repo":{"id":121261379,"name":"kubevirt","full_name":"yanirq/kubevirt","owner":{"login":"yanirq","id":18440857,"avatar_url":"https://avatars0.githubusercontent.com/u/18440857?v=4","gravatar_id":"","url":"https://api.github.com/users/yanirq","html_url":"https://github.com/yanirq","followers_url":"https://api.github.com/users/yanirq/followers","following_url":"https://api.github.com/users/yanirq/following{/other_user}","gists_url":"https://api.github.com/users/yanirq/gists{/gist_id}","starred_url":"https://api.github.com/users/yanirq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanirq/subscriptions","organizations_url":"https://api.github.com/users/yanirq/orgs","repos_url":"https://api.github.com/users/yanirq/repos","events_url":"https://api.github.com/users/yanirq/events{/privacy}","received_events_url":"https://api.github.com/users/yanirq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanirq/kubevirt","description":"A virtualization API and runtime add-on for Kubernetes in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/yanirq/kubevirt","forks_url":"https://api.github.com/repos/yanirq/kubevirt/forks","keys_url":"https://api.github.com/repos/yanirq/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanirq/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanirq/kubevirt/teams","hooks_url":"https://api.github.com/repos/yanirq/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/yanirq/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/yanirq/kubevirt/events","assignees_url":"https://api.github.com/repos/yanirq/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/yanirq/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/yanirq/kubevirt/tags","blobs_url":"https://api.github.com/repos/yanirq/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanirq/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanirq/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanirq/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanirq/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/yanirq/kubevirt/languages","stargazers_url":"https://api.github.com/repos/yanirq/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/yanirq/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/yanirq/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/yanirq/kubevirt/subscription","commits_url":"https://api.github.com/repos/yanirq/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanirq/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanirq/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanirq/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanirq/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/yanirq/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanirq/kubevirt/merges","archive_url":"https://api.github.com/repos/yanirq/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanirq/kubevirt/downloads","issues_url":"https://api.github.com/repos/yanirq/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/yanirq/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/yanirq/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/yanirq/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanirq/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/yanirq/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/yanirq/kubevirt/deployments","created_at":"2018-02-12T15:08:12Z","updated_at":"2018-02-12T15:08:15Z","pushed_at":"2018-02-13T09:04:12Z","git_url":"git://github.com/yanirq/kubevirt.git","ssh_url":"git@github.com:yanirq/kubevirt.git","clone_url":"https://github.com/yanirq/kubevirt.git","svn_url":"https://github.com/yanirq/kubevirt","homepage":"","size":49757,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"e1a1ac09af31bc806d8bb16c2a5b91d93e3d4466","user":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"A virtualization API and runtime add-on for Kubernetes in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-02-10T02:53:25Z","pushed_at":"2018-02-13T12:14:08Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":49777,"stargazers_count":405,"watchers_count":405,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":103,"open_issues":97,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/731"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/731"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/731/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/731/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/e41116b44abf61e6984b9751e4e2e9dc0cf69c91"}},"author_association":"NONE"}}
{"actor":{"display_login":"fabiand"}}