{"action":"opened","number":1314,"pull_request":{"url":"https://api.github.com/repos/fnproject/fn/pulls/1314","id":231031165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDMxMTY1","html_url":"https://github.com/fnproject/fn/pull/1314","diff_url":"https://github.com/fnproject/fn/pull/1314.diff","patch_url":"https://github.com/fnproject/fn/pull/1314.patch","issue_url":"https://api.github.com/repos/fnproject/fn/issues/1314","number":1314,"state":"open","locked":false,"title":"fn: remove go-routine in dispatch","user":{"login":"skinowski","id":6537562,"node_id":"MDQ6VXNlcjY1Mzc1NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6537562?v=4","gravatar_id":"","url":"https://api.github.com/users/skinowski","html_url":"https://github.com/skinowski","followers_url":"https://api.github.com/users/skinowski/followers","following_url":"https://api.github.com/users/skinowski/following{/other_user}","gists_url":"https://api.github.com/users/skinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/skinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skinowski/subscriptions","organizations_url":"https://api.github.com/users/skinowski/orgs","repos_url":"https://api.github.com/users/skinowski/repos","events_url":"https://api.github.com/users/skinowski/events{/privacy}","received_events_url":"https://api.github.com/users/skinowski/received_events","type":"User","site_admin":false},"body":"With this PR, we trust http client to use the context timeout and therefore avoid spawning\r\na go-routine. This simplifies the flow and also avoids case of call.stderr.Close() executing before swapBack.\r\n","created_at":"2018-11-15T00:42:00Z","updated_at":"2018-11-15T00:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fnproject/fn/pulls/1314/commits","review_comments_url":"https://api.github.com/repos/fnproject/fn/pulls/1314/comments","review_comment_url":"https://api.github.com/repos/fnproject/fn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fnproject/fn/issues/1314/comments","statuses_url":"https://api.github.com/repos/fnproject/fn/statuses/20b68fd24a19a24263103a11866d61027ac55d52","head":{"label":"skinowski:slice_range_fix","ref":"slice_range_fix","sha":"20b68fd24a19a24263103a11866d61027ac55d52","user":{"login":"skinowski","id":6537562,"node_id":"MDQ6VXNlcjY1Mzc1NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6537562?v=4","gravatar_id":"","url":"https://api.github.com/users/skinowski","html_url":"https://github.com/skinowski","followers_url":"https://api.github.com/users/skinowski/followers","following_url":"https://api.github.com/users/skinowski/following{/other_user}","gists_url":"https://api.github.com/users/skinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/skinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skinowski/subscriptions","organizations_url":"https://api.github.com/users/skinowski/orgs","repos_url":"https://api.github.com/users/skinowski/repos","events_url":"https://api.github.com/users/skinowski/events{/privacy}","received_events_url":"https://api.github.com/users/skinowski/received_events","type":"User","site_admin":false},"repo":{"id":109311981,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMTE5ODE=","name":"fn","full_name":"skinowski/fn","private":false,"owner":{"login":"skinowski","id":6537562,"node_id":"MDQ6VXNlcjY1Mzc1NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6537562?v=4","gravatar_id":"","url":"https://api.github.com/users/skinowski","html_url":"https://github.com/skinowski","followers_url":"https://api.github.com/users/skinowski/followers","following_url":"https://api.github.com/users/skinowski/following{/other_user}","gists_url":"https://api.github.com/users/skinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/skinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skinowski/subscriptions","organizations_url":"https://api.github.com/users/skinowski/orgs","repos_url":"https://api.github.com/users/skinowski/repos","events_url":"https://api.github.com/users/skinowski/events{/privacy}","received_events_url":"https://api.github.com/users/skinowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skinowski/fn","description":"The container native, cloud agnostic serverless platform.","fork":true,"url":"https://api.github.com/repos/skinowski/fn","forks_url":"https://api.github.com/repos/skinowski/fn/forks","keys_url":"https://api.github.com/repos/skinowski/fn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skinowski/fn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skinowski/fn/teams","hooks_url":"https://api.github.com/repos/skinowski/fn/hooks","issue_events_url":"https://api.github.com/repos/skinowski/fn/issues/events{/number}","events_url":"https://api.github.com/repos/skinowski/fn/events","assignees_url":"https://api.github.com/repos/skinowski/fn/assignees{/user}","branches_url":"https://api.github.com/repos/skinowski/fn/branches{/branch}","tags_url":"https://api.github.com/repos/skinowski/fn/tags","blobs_url":"https://api.github.com/repos/skinowski/fn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skinowski/fn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skinowski/fn/git/refs{/sha}","trees_url":"https://api.github.com/repos/skinowski/fn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skinowski/fn/statuses/{sha}","languages_url":"https://api.github.com/repos/skinowski/fn/languages","stargazers_url":"https://api.github.com/repos/skinowski/fn/stargazers","contributors_url":"https://api.github.com/repos/skinowski/fn/contributors","subscribers_url":"https://api.github.com/repos/skinowski/fn/subscribers","subscription_url":"https://api.github.com/repos/skinowski/fn/subscription","commits_url":"https://api.github.com/repos/skinowski/fn/commits{/sha}","git_commits_url":"https://api.github.com/repos/skinowski/fn/git/commits{/sha}","comments_url":"https://api.github.com/repos/skinowski/fn/comments{/number}","issue_comment_url":"https://api.github.com/repos/skinowski/fn/issues/comments{/number}","contents_url":"https://api.github.com/repos/skinowski/fn/contents/{+path}","compare_url":"https://api.github.com/repos/skinowski/fn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skinowski/fn/merges","archive_url":"https://api.github.com/repos/skinowski/fn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skinowski/fn/downloads","issues_url":"https://api.github.com/repos/skinowski/fn/issues{/number}","pulls_url":"https://api.github.com/repos/skinowski/fn/pulls{/number}","milestones_url":"https://api.github.com/repos/skinowski/fn/milestones{/number}","notifications_url":"https://api.github.com/repos/skinowski/fn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skinowski/fn/labels{/name}","releases_url":"https://api.github.com/repos/skinowski/fn/releases{/id}","deployments_url":"https://api.github.com/repos/skinowski/fn/deployments","created_at":"2017-11-02T19:51:42Z","updated_at":"2018-11-14T19:22:57Z","pushed_at":"2018-11-14T23:56:10Z","git_url":"git://github.com/skinowski/fn.git","ssh_url":"git@github.com:skinowski/fn.git","clone_url":"https://github.com/skinowski/fn.git","svn_url":"https://github.com/skinowski/fn","homepage":"http://fnproject.io","size":143948,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fnproject:master","ref":"master","sha":"65f3f915bed12b4ebbd9d5921569ddfa90910617","user":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"repo":{"id":97652025,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY1MjAyNQ==","name":"fn","full_name":"fnproject/fn","private":false,"owner":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fnproject/fn","description":"The container native, cloud agnostic serverless platform.","fork":false,"url":"https://api.github.com/repos/fnproject/fn","forks_url":"https://api.github.com/repos/fnproject/fn/forks","keys_url":"https://api.github.com/repos/fnproject/fn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnproject/fn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnproject/fn/teams","hooks_url":"https://api.github.com/repos/fnproject/fn/hooks","issue_events_url":"https://api.github.com/repos/fnproject/fn/issues/events{/number}","events_url":"https://api.github.com/repos/fnproject/fn/events","assignees_url":"https://api.github.com/repos/fnproject/fn/assignees{/user}","branches_url":"https://api.github.com/repos/fnproject/fn/branches{/branch}","tags_url":"https://api.github.com/repos/fnproject/fn/tags","blobs_url":"https://api.github.com/repos/fnproject/fn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnproject/fn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnproject/fn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnproject/fn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnproject/fn/statuses/{sha}","languages_url":"https://api.github.com/repos/fnproject/fn/languages","stargazers_url":"https://api.github.com/repos/fnproject/fn/stargazers","contributors_url":"https://api.github.com/repos/fnproject/fn/contributors","subscribers_url":"https://api.github.com/repos/fnproject/fn/subscribers","subscription_url":"https://api.github.com/repos/fnproject/fn/subscription","commits_url":"https://api.github.com/repos/fnproject/fn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnproject/fn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnproject/fn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnproject/fn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnproject/fn/contents/{+path}","compare_url":"https://api.github.com/repos/fnproject/fn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnproject/fn/merges","archive_url":"https://api.github.com/repos/fnproject/fn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnproject/fn/downloads","issues_url":"https://api.github.com/repos/fnproject/fn/issues{/number}","pulls_url":"https://api.github.com/repos/fnproject/fn/pulls{/number}","milestones_url":"https://api.github.com/repos/fnproject/fn/milestones{/number}","notifications_url":"https://api.github.com/repos/fnproject/fn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnproject/fn/labels{/name}","releases_url":"https://api.github.com/repos/fnproject/fn/releases{/id}","deployments_url":"https://api.github.com/repos/fnproject/fn/deployments","created_at":"2017-07-18T23:22:46Z","updated_at":"2018-11-14T19:46:56Z","pushed_at":"2018-11-15T00:29:25Z","git_url":"git://github.com/fnproject/fn.git","ssh_url":"git@github.com:fnproject/fn.git","clone_url":"https://github.com/fnproject/fn.git","svn_url":"https://github.com/fnproject/fn","homepage":"http://fnproject.io","size":154765,"stargazers_count":3481,"watchers_count":3481,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":254,"open_issues":132,"watchers":3481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1314"},"html":{"href":"https://github.com/fnproject/fn/pull/1314"},"issue":{"href":"https://api.github.com/repos/fnproject/fn/issues/1314"},"comments":{"href":"https://api.github.com/repos/fnproject/fn/issues/1314/comments"},"review_comments":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1314/comments"},"review_comment":{"href":"https://api.github.com/repos/fnproject/fn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1314/commits"},"statuses":{"href":"https://api.github.com/repos/fnproject/fn/statuses/20b68fd24a19a24263103a11866d61027ac55d52"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":32,"deletions":48,"changed_files":1}}
{"actor":{"display_login":"skinowski"}}