{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/230718202","pull_request_review_id":171514732,"id":230718202,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcxODIwMg==","diff_hunk":"@@ -178,3 +179,45 @@ func TestReactorSelectiveBroadcast(t *testing.T) {\n \tpeers := reactors[1].Switch.Peers().List()\n \tassert.Equal(t, 1, len(peers))\n }\n+func TestEvidenceListMessageValidationBasic(t *testing.T) {\n+\n+\tconfig := cfg.TestConfig()\n+\n+\tvalAddr := []byte(\"myval\")\n+\theight1 := int64(NUM_EVIDENCE) + 10\n+\theight2 := int64(NUM_EVIDENCE) / 2\n+\n+\t// DB1 is ahead of DB2\n+\tstateDB1 := initializeValidatorState(valAddr, height1)\n+\tstateDB2 := initializeValidatorState(valAddr, height2)\n+\n+\t// make reactors from statedb\n+\treactors := makeAndConnectEvidenceReactors(config, []dbm.DB{stateDB1, stateDB2})\n+\tpeer := reactors[0].Switch.Peers().List()[0]\n+\tps := peerState{height2}\n+\tpeer.Set(types.PeerStateKey, ps)\n+\n+\t// send a bunch of valid evidence to the first reactor's evpool\n+\n+\ttestCases := []struct {\n+\t\ttestName          string\n+\t\tmalleateEvListMsg func(*EvidenceListMessage)\n+\t\texpectErr         bool\n+\t}{\n+\t\t{\"Good EvidenceListMessage\", func(evList *EvidenceListMessage) {}, false},\n+\t\t{\"Invalid EvidenceListMessage\", func(evList *EvidenceListMessage) {\n+\t\t\tevList.Evidence = append(evList.Evidence,\n+\t\t\t\t&types.DuplicateVoteEvidence{PubKey: secp256k1.GenPrivKey().PubKey()})\n+\t\t}, true},\n+\t}\n+\tfor _, tc := range testCases {\n+\t\tt.Run(tc.testName, func(t *testing.T) {\n+\t\t\tevList := sendEvidence(t, reactors[0].evpool, valAddr, NUM_EVIDENCE)","path":"evidence/reactor_test.go","position":45,"original_position":45,"commit_id":"a4a7fea105f62285b1eecb0d4a876b9dbab9e63b","original_commit_id":"a4a7fea105f62285b1eecb0d4a876b9dbab9e63b","user":{"login":"melekes","id":1282182,"node_id":"MDQ6VXNlcjEyODIxODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1282182?v=4","gravatar_id":"","url":"https://api.github.com/users/melekes","html_url":"https://github.com/melekes","followers_url":"https://api.github.com/users/melekes/followers","following_url":"https://api.github.com/users/melekes/following{/other_user}","gists_url":"https://api.github.com/users/melekes/gists{/gist_id}","starred_url":"https://api.github.com/users/melekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melekes/subscriptions","organizations_url":"https://api.github.com/users/melekes/orgs","repos_url":"https://api.github.com/users/melekes/repos","events_url":"https://api.github.com/users/melekes/events{/privacy}","received_events_url":"https://api.github.com/users/melekes/received_events","type":"User","site_admin":false},"body":"why do we need to send it? can't we just validate it without running reactors and all that stuff?","created_at":"2018-11-05T11:32:05Z","updated_at":"2018-11-05T11:39:00Z","html_url":"https://github.com/tendermint/tendermint/pull/2754#discussion_r230718202","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/230718202"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2754#discussion_r230718202"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2754"}}},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2754","id":228197134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk3MTM0","html_url":"https://github.com/tendermint/tendermint/pull/2754","diff_url":"https://github.com/tendermint/tendermint/pull/2754.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2754.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2754","number":2754,"state":"open","locked":false,"title":"Add tests for ValidateBasic methods","user":{"login":"katakonst","id":6519792,"node_id":"MDQ6VXNlcjY1MTk3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6519792?v=4","gravatar_id":"","url":"https://api.github.com/users/katakonst","html_url":"https://github.com/katakonst","followers_url":"https://api.github.com/users/katakonst/followers","following_url":"https://api.github.com/users/katakonst/following{/other_user}","gists_url":"https://api.github.com/users/katakonst/gists{/gist_id}","starred_url":"https://api.github.com/users/katakonst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katakonst/subscriptions","organizations_url":"https://api.github.com/users/katakonst/orgs","repos_url":"https://api.github.com/users/katakonst/repos","events_url":"https://api.github.com/users/katakonst/events{/privacy}","received_events_url":"https://api.github.com/users/katakonst/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for filing a PR! Before hitting the button, please check the following items.-->\r\nFixes  #2740\r\n* [x] Wrote tests","created_at":"2018-11-04T19:28:51Z","updated_at":"2018-11-05T11:39:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ced785b0fcf4516524a03eb21097c0af3661805d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2754/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2754/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2754/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/a4a7fea105f62285b1eecb0d4a876b9dbab9e63b","head":{"label":"katakonst:validate_basic_tests","ref":"validate_basic_tests","sha":"a4a7fea105f62285b1eecb0d4a876b9dbab9e63b","user":{"login":"katakonst","id":6519792,"node_id":"MDQ6VXNlcjY1MTk3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6519792?v=4","gravatar_id":"","url":"https://api.github.com/users/katakonst","html_url":"https://github.com/katakonst","followers_url":"https://api.github.com/users/katakonst/followers","following_url":"https://api.github.com/users/katakonst/following{/other_user}","gists_url":"https://api.github.com/users/katakonst/gists{/gist_id}","starred_url":"https://api.github.com/users/katakonst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katakonst/subscriptions","organizations_url":"https://api.github.com/users/katakonst/orgs","repos_url":"https://api.github.com/users/katakonst/repos","events_url":"https://api.github.com/users/katakonst/events{/privacy}","received_events_url":"https://api.github.com/users/katakonst/received_events","type":"User","site_admin":false},"repo":{"id":153515499,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MTU0OTk=","name":"tendermint","full_name":"katakonst/tendermint","private":false,"owner":{"login":"katakonst","id":6519792,"node_id":"MDQ6VXNlcjY1MTk3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6519792?v=4","gravatar_id":"","url":"https://api.github.com/users/katakonst","html_url":"https://github.com/katakonst","followers_url":"https://api.github.com/users/katakonst/followers","following_url":"https://api.github.com/users/katakonst/following{/other_user}","gists_url":"https://api.github.com/users/katakonst/gists{/gist_id}","starred_url":"https://api.github.com/users/katakonst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katakonst/subscriptions","organizations_url":"https://api.github.com/users/katakonst/orgs","repos_url":"https://api.github.com/users/katakonst/repos","events_url":"https://api.github.com/users/katakonst/events{/privacy}","received_events_url":"https://api.github.com/users/katakonst/received_events","type":"User","site_admin":false},"html_url":"https://github.com/katakonst/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":true,"url":"https://api.github.com/repos/katakonst/tendermint","forks_url":"https://api.github.com/repos/katakonst/tendermint/forks","keys_url":"https://api.github.com/repos/katakonst/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/katakonst/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/katakonst/tendermint/teams","hooks_url":"https://api.github.com/repos/katakonst/tendermint/hooks","issue_events_url":"https://api.github.com/repos/katakonst/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/katakonst/tendermint/events","assignees_url":"https://api.github.com/repos/katakonst/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/katakonst/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/katakonst/tendermint/tags","blobs_url":"https://api.github.com/repos/katakonst/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/katakonst/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/katakonst/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/katakonst/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/katakonst/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/katakonst/tendermint/languages","stargazers_url":"https://api.github.com/repos/katakonst/tendermint/stargazers","contributors_url":"https://api.github.com/repos/katakonst/tendermint/contributors","subscribers_url":"https://api.github.com/repos/katakonst/tendermint/subscribers","subscription_url":"https://api.github.com/repos/katakonst/tendermint/subscription","commits_url":"https://api.github.com/repos/katakonst/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/katakonst/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/katakonst/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/katakonst/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/katakonst/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/katakonst/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/katakonst/tendermint/merges","archive_url":"https://api.github.com/repos/katakonst/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/katakonst/tendermint/downloads","issues_url":"https://api.github.com/repos/katakonst/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/katakonst/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/katakonst/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/katakonst/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/katakonst/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/katakonst/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/katakonst/tendermint/deployments","created_at":"2018-10-17T19:55:07Z","updated_at":"2018-10-17T19:55:11Z","pushed_at":"2018-11-04T19:18:23Z","git_url":"git://github.com/katakonst/tendermint.git","ssh_url":"git@github.com:katakonst/tendermint.git","clone_url":"https://github.com/katakonst/tendermint.git","svn_url":"https://github.com/katakonst/tendermint","homepage":"https://tendermint.com/","size":52132,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"59b75d3f28e4ade0a0d6f15724ee8c656f8bd0b9","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","private":false,"owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-11-05T09:27:58Z","pushed_at":"2018-11-05T10:02:34Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":52267,"stargazers_count":2448,"watchers_count":2448,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":624,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":624,"open_issues":357,"watchers":2448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2754"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2754"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2754"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2754/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2754/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2754/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/a4a7fea105f62285b1eecb0d4a876b9dbab9e63b"}},"author_association":"NONE"}}
{"actor":{"display_login":"melekes"}}