{"action":"closed","number":1235,"pull_request":{"url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235","id":166843837,"html_url":"https://github.com/sparc-request/sparc-request/pull/1235","diff_url":"https://github.com/sparc-request/sparc-request/pull/1235.diff","patch_url":"https://github.com/sparc-request/sparc-request/pull/1235.patch","issue_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/1235","number":1235,"state":"closed","locked":false,"title":"wth - (SPARCRequest & SPARCDashboard) Validate File Types","user":{"login":"wtholt","id":8355974,"avatar_url":"https://avatars1.githubusercontent.com/u/8355974?v=4","gravatar_id":"","url":"https://api.github.com/users/wtholt","html_url":"https://github.com/wtholt","followers_url":"https://api.github.com/users/wtholt/followers","following_url":"https://api.github.com/users/wtholt/following{/other_user}","gists_url":"https://api.github.com/users/wtholt/gists{/gist_id}","starred_url":"https://api.github.com/users/wtholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtholt/subscriptions","organizations_url":"https://api.github.com/users/wtholt/orgs","repos_url":"https://api.github.com/users/wtholt/repos","events_url":"https://api.github.com/users/wtholt/events{/privacy}","received_events_url":"https://api.github.com/users/wtholt/received_events","type":"User","site_admin":false},"body":"When testing, we realized that you have the ability to upload any type of document. This includes .exe files, which we view as a potential security concern.\r\n\r\nValidating rtf, txt, xls, xlsx, csv, ppt, pptx, msg, eml (for emails),\r\njpeg, gif, png, tiff (and other graph formats), pdf, doc, docx\r\n\r\n[#153447613]\r\n\r\nStory - https://www.pivotaltracker.com/story/show/153447613","created_at":"2018-02-02T16:22:27Z","updated_at":"2018-02-05T15:50:37Z","closed_at":"2018-02-05T15:50:37Z","merged_at":"2018-02-05T15:50:37Z","merge_commit_sha":"1c935d02ea906cc2772ee05fdaf0b1949df11d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235/commits","review_comments_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235/comments","review_comment_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/1235/comments","statuses_url":"https://api.github.com/repos/sparc-request/sparc-request/statuses/ea406fa831ee89071ebf4d698a69a5f2b6fcfa01","head":{"label":"sparc-request:wth-validate-documents","ref":"wth-validate-documents","sha":"ea406fa831ee89071ebf4d698a69a5f2b6fcfa01","user":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars1.githubusercontent.com/u/8311757?v=4","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"repo":{"id":22610009,"name":"sparc-request","full_name":"sparc-request/sparc-request","owner":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars1.githubusercontent.com/u/8311757?v=4","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sparc-request/sparc-request","description":null,"fork":false,"url":"https://api.github.com/repos/sparc-request/sparc-request","forks_url":"https://api.github.com/repos/sparc-request/sparc-request/forks","keys_url":"https://api.github.com/repos/sparc-request/sparc-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparc-request/sparc-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparc-request/sparc-request/teams","hooks_url":"https://api.github.com/repos/sparc-request/sparc-request/hooks","issue_events_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/events{/number}","events_url":"https://api.github.com/repos/sparc-request/sparc-request/events","assignees_url":"https://api.github.com/repos/sparc-request/sparc-request/assignees{/user}","branches_url":"https://api.github.com/repos/sparc-request/sparc-request/branches{/branch}","tags_url":"https://api.github.com/repos/sparc-request/sparc-request/tags","blobs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparc-request/sparc-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparc-request/sparc-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparc-request/sparc-request/statuses/{sha}","languages_url":"https://api.github.com/repos/sparc-request/sparc-request/languages","stargazers_url":"https://api.github.com/repos/sparc-request/sparc-request/stargazers","contributors_url":"https://api.github.com/repos/sparc-request/sparc-request/contributors","subscribers_url":"https://api.github.com/repos/sparc-request/sparc-request/subscribers","subscription_url":"https://api.github.com/repos/sparc-request/sparc-request/subscription","commits_url":"https://api.github.com/repos/sparc-request/sparc-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparc-request/sparc-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparc-request/sparc-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparc-request/sparc-request/contents/{+path}","compare_url":"https://api.github.com/repos/sparc-request/sparc-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparc-request/sparc-request/merges","archive_url":"https://api.github.com/repos/sparc-request/sparc-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparc-request/sparc-request/downloads","issues_url":"https://api.github.com/repos/sparc-request/sparc-request/issues{/number}","pulls_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls{/number}","milestones_url":"https://api.github.com/repos/sparc-request/sparc-request/milestones{/number}","notifications_url":"https://api.github.com/repos/sparc-request/sparc-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparc-request/sparc-request/labels{/name}","releases_url":"https://api.github.com/repos/sparc-request/sparc-request/releases{/id}","deployments_url":"https://api.github.com/repos/sparc-request/sparc-request/deployments","created_at":"2014-08-04T15:47:11Z","updated_at":"2018-01-26T21:07:58Z","pushed_at":"2018-02-05T15:50:36Z","git_url":"git://github.com/sparc-request/sparc-request.git","ssh_url":"git@github.com:sparc-request/sparc-request.git","clone_url":"https://github.com/sparc-request/sparc-request.git","svn_url":"https://github.com/sparc-request/sparc-request","homepage":null,"size":29595,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":20,"open_issues":19,"watchers":8,"default_branch":"master"}},"base":{"label":"sparc-request:v3.2.0","ref":"v3.2.0","sha":"1f156c04860609e67bc83612a7638c290bddcc95","user":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars1.githubusercontent.com/u/8311757?v=4","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"repo":{"id":22610009,"name":"sparc-request","full_name":"sparc-request/sparc-request","owner":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars1.githubusercontent.com/u/8311757?v=4","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sparc-request/sparc-request","description":null,"fork":false,"url":"https://api.github.com/repos/sparc-request/sparc-request","forks_url":"https://api.github.com/repos/sparc-request/sparc-request/forks","keys_url":"https://api.github.com/repos/sparc-request/sparc-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparc-request/sparc-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparc-request/sparc-request/teams","hooks_url":"https://api.github.com/repos/sparc-request/sparc-request/hooks","issue_events_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/events{/number}","events_url":"https://api.github.com/repos/sparc-request/sparc-request/events","assignees_url":"https://api.github.com/repos/sparc-request/sparc-request/assignees{/user}","branches_url":"https://api.github.com/repos/sparc-request/sparc-request/branches{/branch}","tags_url":"https://api.github.com/repos/sparc-request/sparc-request/tags","blobs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparc-request/sparc-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparc-request/sparc-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparc-request/sparc-request/statuses/{sha}","languages_url":"https://api.github.com/repos/sparc-request/sparc-request/languages","stargazers_url":"https://api.github.com/repos/sparc-request/sparc-request/stargazers","contributors_url":"https://api.github.com/repos/sparc-request/sparc-request/contributors","subscribers_url":"https://api.github.com/repos/sparc-request/sparc-request/subscribers","subscription_url":"https://api.github.com/repos/sparc-request/sparc-request/subscription","commits_url":"https://api.github.com/repos/sparc-request/sparc-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparc-request/sparc-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparc-request/sparc-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparc-request/sparc-request/contents/{+path}","compare_url":"https://api.github.com/repos/sparc-request/sparc-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparc-request/sparc-request/merges","archive_url":"https://api.github.com/repos/sparc-request/sparc-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparc-request/sparc-request/downloads","issues_url":"https://api.github.com/repos/sparc-request/sparc-request/issues{/number}","pulls_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls{/number}","milestones_url":"https://api.github.com/repos/sparc-request/sparc-request/milestones{/number}","notifications_url":"https://api.github.com/repos/sparc-request/sparc-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparc-request/sparc-request/labels{/name}","releases_url":"https://api.github.com/repos/sparc-request/sparc-request/releases{/id}","deployments_url":"https://api.github.com/repos/sparc-request/sparc-request/deployments","created_at":"2014-08-04T15:47:11Z","updated_at":"2018-01-26T21:07:58Z","pushed_at":"2018-02-05T15:50:36Z","git_url":"git://github.com/sparc-request/sparc-request.git","ssh_url":"git@github.com:sparc-request/sparc-request.git","clone_url":"https://github.com/sparc-request/sparc-request.git","svn_url":"https://github.com/sparc-request/sparc-request","homepage":null,"size":29595,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":20,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235"},"html":{"href":"https://github.com/sparc-request/sparc-request/pull/1235"},"issue":{"href":"https://api.github.com/repos/sparc-request/sparc-request/issues/1235"},"comments":{"href":"https://api.github.com/repos/sparc-request/sparc-request/issues/1235/comments"},"review_comments":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235/comments"},"review_comment":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/1235/commits"},"statuses":{"href":"https://api.github.com/repos/sparc-request/sparc-request/statuses/ea406fa831ee89071ebf4d698a69a5f2b6fcfa01"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Stuart-Johnson","id":508196,"avatar_url":"https://avatars2.githubusercontent.com/u/508196?v=4","gravatar_id":"","url":"https://api.github.com/users/Stuart-Johnson","html_url":"https://github.com/Stuart-Johnson","followers_url":"https://api.github.com/users/Stuart-Johnson/followers","following_url":"https://api.github.com/users/Stuart-Johnson/following{/other_user}","gists_url":"https://api.github.com/users/Stuart-Johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/Stuart-Johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stuart-Johnson/subscriptions","organizations_url":"https://api.github.com/users/Stuart-Johnson/orgs","repos_url":"https://api.github.com/users/Stuart-Johnson/repos","events_url":"https://api.github.com/users/Stuart-Johnson/events{/privacy}","received_events_url":"https://api.github.com/users/Stuart-Johnson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":31,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"Stuart-Johnson"}}