{"action":"created","comment":{"url":"https://api.github.com/repos/cdapio/cdap/pulls/comments/243698706","pull_request_review_id":187546473,"id":243698706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzY5ODcwNg==","diff_hunk":"@@ -442,6 +476,7 @@ public void close() throws IOException {\n     for (FactTable factTable : resolutionToFactTable.values()) {\n       factTable.close();\n     }\n+    executorService.shutdown();","path":"cdap-data-fabric/src/main/java/co/cask/cdap/data2/dataset2/lib/cube/DefaultCube.java","position":81,"original_position":81,"commit_id":"73ad144ea2ae23ac803262697e1f0cd54bc545e7","original_commit_id":"73ad144ea2ae23ac803262697e1f0cd54bc545e7","user":{"login":"chtyim","id":885032,"node_id":"MDQ6VXNlcjg4NTAzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/885032?v=4","gravatar_id":"","url":"https://api.github.com/users/chtyim","html_url":"https://github.com/chtyim","followers_url":"https://api.github.com/users/chtyim/followers","following_url":"https://api.github.com/users/chtyim/following{/other_user}","gists_url":"https://api.github.com/users/chtyim/gists{/gist_id}","starred_url":"https://api.github.com/users/chtyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtyim/subscriptions","organizations_url":"https://api.github.com/users/chtyim/orgs","repos_url":"https://api.github.com/users/chtyim/repos","events_url":"https://api.github.com/users/chtyim/events{/privacy}","received_events_url":"https://api.github.com/users/chtyim/received_events","type":"User","site_admin":false},"body":"Should do this in a `finally` block","created_at":"2018-12-21T21:43:42Z","updated_at":"2018-12-21T21:43:47Z","html_url":"https://github.com/cdapio/cdap/pull/10875#discussion_r243698706","pull_request_url":"https://api.github.com/repos/cdapio/cdap/pulls/10875","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/comments/243698706"},"html":{"href":"https://github.com/cdapio/cdap/pull/10875#discussion_r243698706"},"pull_request":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10875"}}},"pull_request":{"url":"https://api.github.com/repos/cdapio/cdap/pulls/10875","id":238533974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTMzOTc0","html_url":"https://github.com/cdapio/cdap/pull/10875","diff_url":"https://github.com/cdapio/cdap/pull/10875.diff","patch_url":"https://github.com/cdapio/cdap/pull/10875.patch","issue_url":"https://api.github.com/repos/cdapio/cdap/issues/10875","number":10875,"state":"open","locked":false,"title":"CDAP-14628 add concurrent write for fact table","user":{"login":"yaojiefeng","id":12615579,"node_id":"MDQ6VXNlcjEyNjE1NTc5","avatar_url":"https://avatars0.githubusercontent.com/u/12615579?v=4","gravatar_id":"","url":"https://api.github.com/users/yaojiefeng","html_url":"https://github.com/yaojiefeng","followers_url":"https://api.github.com/users/yaojiefeng/followers","following_url":"https://api.github.com/users/yaojiefeng/following{/other_user}","gists_url":"https://api.github.com/users/yaojiefeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojiefeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojiefeng/subscriptions","organizations_url":"https://api.github.com/users/yaojiefeng/orgs","repos_url":"https://api.github.com/users/yaojiefeng/repos","events_url":"https://api.github.com/users/yaojiefeng/events{/privacy}","received_events_url":"https://api.github.com/users/yaojiefeng/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.cask.co/browse/CDAP-14628\r\nBuild: https://builds.cask.co/browse/CDAP-DUT6684-1\r\n\r\nThe write to 4 metrics fact table can happen in parallel. Doing so can greatly reduce the write time for the metrics store","created_at":"2018-12-13T21:13:30Z","updated_at":"2018-12-21T21:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd953ef9687fc45c3c73b330be1a580768c27553","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1120003130,"node_id":"MDU6TGFiZWwxMTIwMDAzMTMw","url":"https://api.github.com/repos/cdapio/cdap/labels/6.0","name":"6.0","color":"7550fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cdapio/cdap/pulls/10875/commits","review_comments_url":"https://api.github.com/repos/cdapio/cdap/pulls/10875/comments","review_comment_url":"https://api.github.com/repos/cdapio/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdapio/cdap/issues/10875/comments","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/73ad144ea2ae23ac803262697e1f0cd54bc545e7","head":{"label":"cdapio:feature/CDAP-14628-add-concurrent-write-for-factTable","ref":"feature/CDAP-14628-add-concurrent-write-for-factTable","sha":"73ad144ea2ae23ac803262697e1f0cd54bc545e7","user":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"cdapio/cdap","private":false,"owner":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cdapio/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/cdapio/cdap","forks_url":"https://api.github.com/repos/cdapio/cdap/forks","keys_url":"https://api.github.com/repos/cdapio/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdapio/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdapio/cdap/teams","hooks_url":"https://api.github.com/repos/cdapio/cdap/hooks","issue_events_url":"https://api.github.com/repos/cdapio/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/cdapio/cdap/events","assignees_url":"https://api.github.com/repos/cdapio/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/cdapio/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/cdapio/cdap/tags","blobs_url":"https://api.github.com/repos/cdapio/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdapio/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdapio/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdapio/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/cdapio/cdap/languages","stargazers_url":"https://api.github.com/repos/cdapio/cdap/stargazers","contributors_url":"https://api.github.com/repos/cdapio/cdap/contributors","subscribers_url":"https://api.github.com/repos/cdapio/cdap/subscribers","subscription_url":"https://api.github.com/repos/cdapio/cdap/subscription","commits_url":"https://api.github.com/repos/cdapio/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdapio/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdapio/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdapio/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdapio/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/cdapio/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdapio/cdap/merges","archive_url":"https://api.github.com/repos/cdapio/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdapio/cdap/downloads","issues_url":"https://api.github.com/repos/cdapio/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/cdapio/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/cdapio/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/cdapio/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdapio/cdap/labels{/name}","releases_url":"https://api.github.com/repos/cdapio/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/cdapio/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-12-21T19:14:18Z","pushed_at":"2018-12-21T20:32:22Z","git_url":"git://github.com/cdapio/cdap.git","ssh_url":"git@github.com:cdapio/cdap.git","clone_url":"https://github.com/cdapio/cdap.git","svn_url":"https://github.com/cdapio/cdap","homepage":"https://cdap.io","size":554270,"stargazers_count":283,"watchers_count":283,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":147,"open_issues":9,"watchers":283,"default_branch":"develop"}},"base":{"label":"cdapio:develop","ref":"develop","sha":"4698392d7c3a1c3ecfa0dce7ddaad4bce38f879b","user":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"cdapio/cdap","private":false,"owner":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cdapio/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/cdapio/cdap","forks_url":"https://api.github.com/repos/cdapio/cdap/forks","keys_url":"https://api.github.com/repos/cdapio/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdapio/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdapio/cdap/teams","hooks_url":"https://api.github.com/repos/cdapio/cdap/hooks","issue_events_url":"https://api.github.com/repos/cdapio/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/cdapio/cdap/events","assignees_url":"https://api.github.com/repos/cdapio/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/cdapio/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/cdapio/cdap/tags","blobs_url":"https://api.github.com/repos/cdapio/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdapio/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdapio/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdapio/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/cdapio/cdap/languages","stargazers_url":"https://api.github.com/repos/cdapio/cdap/stargazers","contributors_url":"https://api.github.com/repos/cdapio/cdap/contributors","subscribers_url":"https://api.github.com/repos/cdapio/cdap/subscribers","subscription_url":"https://api.github.com/repos/cdapio/cdap/subscription","commits_url":"https://api.github.com/repos/cdapio/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdapio/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdapio/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdapio/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdapio/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/cdapio/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdapio/cdap/merges","archive_url":"https://api.github.com/repos/cdapio/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdapio/cdap/downloads","issues_url":"https://api.github.com/repos/cdapio/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/cdapio/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/cdapio/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/cdapio/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdapio/cdap/labels{/name}","releases_url":"https://api.github.com/repos/cdapio/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/cdapio/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-12-21T19:14:18Z","pushed_at":"2018-12-21T20:32:22Z","git_url":"git://github.com/cdapio/cdap.git","ssh_url":"git@github.com:cdapio/cdap.git","clone_url":"https://github.com/cdapio/cdap.git","svn_url":"https://github.com/cdapio/cdap","homepage":"https://cdap.io","size":554270,"stargazers_count":283,"watchers_count":283,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":147,"open_issues":9,"watchers":283,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10875"},"html":{"href":"https://github.com/cdapio/cdap/pull/10875"},"issue":{"href":"https://api.github.com/repos/cdapio/cdap/issues/10875"},"comments":{"href":"https://api.github.com/repos/cdapio/cdap/issues/10875/comments"},"review_comments":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10875/comments"},"review_comment":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10875/commits"},"statuses":{"href":"https://api.github.com/repos/cdapio/cdap/statuses/73ad144ea2ae23ac803262697e1f0cd54bc545e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chtyim"}}