{"action":"created","comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments/175064088","pull_request_review_id":104535138,"id":175064088,"diff_hunk":"@@ -0,0 +1,30 @@\n+{{- if .Values.clusterIssuer.email }}\n+apiVersion: batch/v1\n+kind: Job\n+metadata:\n+  name: apply-issuers\n+  namespace: {{ .Release.Namespace }}\n+  annotations:\n+    \"helm.sh/hook\": post-install,post-upgrade\n+    \"helm.sh/hook-delete-policy\": hook-succeeded\n+spec:\n+  template:\n+    metadata:\n+      name: apply-issuers\n+      namespace: {{ .Release.Namespace }}\n+    spec:\n+      restartPolicy: Never\n+      containers:\n+      - name: apply-issuers\n+        image: claranet/gcloud-kubectl-docker\n+        imagePullPolicy: Always\n+        command: [\"kubectl\",\"apply\",\"-f\",\"/tmp/\"]","path":"contrib/charts/cert-manager/templates/hook_apply_issuers.yaml","position":21,"original_position":21,"commit_id":"f1506b9e9322f227b1664a8e99da2e3081a95f44","original_commit_id":"f1506b9e9322f227b1664a8e99da2e3081a95f44","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"Running `kubectl apply` on upgrade is a bit dangerous; apply is prone to delete user's changes if the kubectl version mismatches enough, and with CRDs it has had numerous issues in the past.\r\n\r\nI worry that this naive upgrade could break people if they've diverged too far from upstream... and there's no annotation (e.g. `managed-by: cert-manager-helm`) that the user can delete/edit to opt-out of upgrades attempting to migrate it.\r\n\r\nOne rather simple example: I have `http01: {}` turned off for my cluster issuer. This would try to turn it back on for the default one each time.","created_at":"2018-03-16T11:41:06Z","updated_at":"2018-03-16T11:41:06Z","html_url":"https://github.com/jetstack/cert-manager/pull/394#discussion_r175064088","pull_request_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/394","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments/175064088"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/394#discussion_r175064088"},"pull_request":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/394","id":175188719,"html_url":"https://github.com/jetstack/cert-manager/pull/394","diff_url":"https://github.com/jetstack/cert-manager/pull/394.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/394.patch","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/394","number":394,"state":"open","locked":false,"title":"Create issuers with helm chart","user":{"login":"pierreozoux","id":1863453,"avatar_url":"https://avatars2.githubusercontent.com/u/1863453?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreozoux","html_url":"https://github.com/pierreozoux","followers_url":"https://api.github.com/users/pierreozoux/followers","following_url":"https://api.github.com/users/pierreozoux/following{/other_user}","gists_url":"https://api.github.com/users/pierreozoux/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreozoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreozoux/subscriptions","organizations_url":"https://api.github.com/users/pierreozoux/orgs","repos_url":"https://api.github.com/users/pierreozoux/repos","events_url":"https://api.github.com/users/pierreozoux/events{/privacy}","received_events_url":"https://api.github.com/users/pierreozoux/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThe objective is to make it as easy as possible for an helm user to get started with cert-manager.\r\nWith this PR, the only thing required to have a production ready cert-manager is to provide an email.\r\nThe instructions are described in the README.\r\n\r\nFollowing [this pattern](https://github.com/kubernetes/charts/pull/3795), I found a nice workaround to be able to deploy the custom resources with the actual definition.\r\n\r\n**Which issue this PR fixes**: fixes #259 \r\n\r\n**Release note**: release-note-none\r\n\r\n","created_at":"2018-03-15T09:20:16Z","updated_at":"2018-03-16T11:41:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b37e189fc9e02d598ad0887fa399236b1ee10780","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":727708353,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":728658201,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/394/commits","review_comments_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/394/comments","review_comment_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/394/comments","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/f1506b9e9322f227b1664a8e99da2e3081a95f44","head":{"label":"pierreozoux:create-issuers","ref":"create-issuers","sha":"f1506b9e9322f227b1664a8e99da2e3081a95f44","user":{"login":"pierreozoux","id":1863453,"avatar_url":"https://avatars2.githubusercontent.com/u/1863453?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreozoux","html_url":"https://github.com/pierreozoux","followers_url":"https://api.github.com/users/pierreozoux/followers","following_url":"https://api.github.com/users/pierreozoux/following{/other_user}","gists_url":"https://api.github.com/users/pierreozoux/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreozoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreozoux/subscriptions","organizations_url":"https://api.github.com/users/pierreozoux/orgs","repos_url":"https://api.github.com/users/pierreozoux/repos","events_url":"https://api.github.com/users/pierreozoux/events{/privacy}","received_events_url":"https://api.github.com/users/pierreozoux/received_events","type":"User","site_admin":false},"repo":{"id":124741755,"name":"cert-manager","full_name":"pierreozoux/cert-manager","owner":{"login":"pierreozoux","id":1863453,"avatar_url":"https://avatars2.githubusercontent.com/u/1863453?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreozoux","html_url":"https://github.com/pierreozoux","followers_url":"https://api.github.com/users/pierreozoux/followers","following_url":"https://api.github.com/users/pierreozoux/following{/other_user}","gists_url":"https://api.github.com/users/pierreozoux/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreozoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreozoux/subscriptions","organizations_url":"https://api.github.com/users/pierreozoux/orgs","repos_url":"https://api.github.com/users/pierreozoux/repos","events_url":"https://api.github.com/users/pierreozoux/events{/privacy}","received_events_url":"https://api.github.com/users/pierreozoux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierreozoux/cert-manager","description":"Automatically provision and manage TLS certificates in Kubernetes","fork":true,"url":"https://api.github.com/repos/pierreozoux/cert-manager","forks_url":"https://api.github.com/repos/pierreozoux/cert-manager/forks","keys_url":"https://api.github.com/repos/pierreozoux/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierreozoux/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierreozoux/cert-manager/teams","hooks_url":"https://api.github.com/repos/pierreozoux/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/pierreozoux/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/pierreozoux/cert-manager/events","assignees_url":"https://api.github.com/repos/pierreozoux/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/pierreozoux/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/pierreozoux/cert-manager/tags","blobs_url":"https://api.github.com/repos/pierreozoux/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierreozoux/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierreozoux/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierreozoux/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierreozoux/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/pierreozoux/cert-manager/languages","stargazers_url":"https://api.github.com/repos/pierreozoux/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/pierreozoux/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/pierreozoux/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/pierreozoux/cert-manager/subscription","commits_url":"https://api.github.com/repos/pierreozoux/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierreozoux/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierreozoux/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierreozoux/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierreozoux/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/pierreozoux/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierreozoux/cert-manager/merges","archive_url":"https://api.github.com/repos/pierreozoux/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierreozoux/cert-manager/downloads","issues_url":"https://api.github.com/repos/pierreozoux/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/pierreozoux/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/pierreozoux/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/pierreozoux/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierreozoux/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/pierreozoux/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/pierreozoux/cert-manager/deployments","created_at":"2018-03-11T09:31:08Z","updated_at":"2018-03-11T09:31:11Z","pushed_at":"2018-03-16T11:23:12Z","git_url":"git://github.com/pierreozoux/cert-manager.git","ssh_url":"git@github.com:pierreozoux/cert-manager.git","clone_url":"https://github.com/pierreozoux/cert-manager.git","svn_url":"https://github.com/pierreozoux/cert-manager","homepage":"","size":51161,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"cfa13a02df872f934a13f3b12d2f72f02a641f48","user":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":92313258,"name":"cert-manager","full_name":"jetstack/cert-manager","owner":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/cert-manager","description":"Automatically provision and manage TLS certificates in Kubernetes","fork":false,"url":"https://api.github.com/repos/jetstack/cert-manager","forks_url":"https://api.github.com/repos/jetstack/cert-manager/forks","keys_url":"https://api.github.com/repos/jetstack/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/cert-manager/teams","hooks_url":"https://api.github.com/repos/jetstack/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/cert-manager/events","assignees_url":"https://api.github.com/repos/jetstack/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/cert-manager/tags","blobs_url":"https://api.github.com/repos/jetstack/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/cert-manager/languages","stargazers_url":"https://api.github.com/repos/jetstack/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/jetstack/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/jetstack/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/jetstack/cert-manager/subscription","commits_url":"https://api.github.com/repos/jetstack/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/cert-manager/merges","archive_url":"https://api.github.com/repos/jetstack/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/cert-manager/downloads","issues_url":"https://api.github.com/repos/jetstack/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/cert-manager/deployments","created_at":"2017-05-24T16:25:59Z","updated_at":"2018-03-16T10:43:02Z","pushed_at":"2018-03-16T11:23:14Z","git_url":"git://github.com/jetstack/cert-manager.git","ssh_url":"git@github.com:jetstack/cert-manager.git","clone_url":"https://github.com/jetstack/cert-manager.git","svn_url":"https://github.com/jetstack/cert-manager","homepage":"","size":51170,"stargazers_count":646,"watchers_count":646,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":87,"open_issues":106,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/394"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/394"},"issue":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/394"},"comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/cert-manager/statuses/f1506b9e9322f227b1664a8e99da2e3081a95f44"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"euank"}}