{"action":"opened","number":25942,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942","id":219563140,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTYzMTQw","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/25942","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/25942.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/25942.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/25942","number":25942,"state":"open","locked":false,"title":"Added --option_overrides flag to test executable","user":{"login":"mctynp","id":6090928,"node_id":"MDQ6VXNlcjYwOTA5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/6090928?v=4","gravatar_id":"","url":"https://api.github.com/users/mctynp","html_url":"https://github.com/mctynp","followers_url":"https://api.github.com/users/mctynp/followers","following_url":"https://api.github.com/users/mctynp/following{/other_user}","gists_url":"https://api.github.com/users/mctynp/gists{/gist_id}","starred_url":"https://api.github.com/users/mctynp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mctynp/subscriptions","organizations_url":"https://api.github.com/users/mctynp/orgs","repos_url":"https://api.github.com/users/mctynp/repos","events_url":"https://api.github.com/users/mctynp/events{/privacy}","received_events_url":"https://api.github.com/users/mctynp/received_events","type":"User","site_admin":false},"body":"SUMMARY: Infrastructure \"Added --option_overrides flag to main test executable\r\nto allow overriding game options used in test execution.\"\r\n\r\n#### Purpose of change\r\nGame options can cause significant changes in code execution, with some bugs\r\nthat only show up under certain option settings (e.g., the ZLEVELS setting and\r\nissues 23250, 24707). Running tests with a specific set of options currently\r\nrequires changing the defaults in config/options.json, which makes it\r\ndifficult to test under different settings. The --option_overrides flag can be\r\nused to override game option settings for a single run of the tests.\r\n\r\n#### Describe the solution\r\nThe --option_overrides flag can be passed to the test executable to supply\r\noption overrides that will be used for the run of the test. For example:\r\n\r\ncata_test --option_overrides=ZLEVELS:true\r\n\r\nwill run the tests with ZLEVELS set to true regardless of the default setting in config/options.json (if present).\r\n\r\n#### Describe alternatives you've considered\r\nIt would be cleaner to set options within only the context of a single test case, so that a single test run could exercise code using multiple option values. However, some options (e.g., ZLEVELS) are cached at a very early stage during code setup. It may not be possible or safe to change these values within the context of a single test case without significant modifications to the core game setup code. Changing the test execution environment setup process to make it easier to set options on a per-test-case basis would require changes to many tests and possibly to core game code as well.\r\n\r\n#### Additional context\r\nSome tests may fail with non-default option settings (e.g., ZLEVELS enabled). Fixing them is outside the scope of this PR.","created_at":"2018-10-02T01:43:09Z","updated_at":"2018-10-02T01:43:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/25942/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/0d842e42077e75fad15eb47eb820b33698dde29a","head":{"label":"mctynp:test_option_override","ref":"test_option_override","sha":"0d842e42077e75fad15eb47eb820b33698dde29a","user":{"login":"mctynp","id":6090928,"node_id":"MDQ6VXNlcjYwOTA5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/6090928?v=4","gravatar_id":"","url":"https://api.github.com/users/mctynp","html_url":"https://github.com/mctynp","followers_url":"https://api.github.com/users/mctynp/followers","following_url":"https://api.github.com/users/mctynp/following{/other_user}","gists_url":"https://api.github.com/users/mctynp/gists{/gist_id}","starred_url":"https://api.github.com/users/mctynp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mctynp/subscriptions","organizations_url":"https://api.github.com/users/mctynp/orgs","repos_url":"https://api.github.com/users/mctynp/repos","events_url":"https://api.github.com/users/mctynp/events{/privacy}","received_events_url":"https://api.github.com/users/mctynp/received_events","type":"User","site_admin":false},"repo":{"id":149369609,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjk2MDk=","name":"Cataclysm-DDA","full_name":"mctynp/Cataclysm-DDA","private":false,"owner":{"login":"mctynp","id":6090928,"node_id":"MDQ6VXNlcjYwOTA5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/6090928?v=4","gravatar_id":"","url":"https://api.github.com/users/mctynp","html_url":"https://github.com/mctynp","followers_url":"https://api.github.com/users/mctynp/followers","following_url":"https://api.github.com/users/mctynp/following{/other_user}","gists_url":"https://api.github.com/users/mctynp/gists{/gist_id}","starred_url":"https://api.github.com/users/mctynp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mctynp/subscriptions","organizations_url":"https://api.github.com/users/mctynp/orgs","repos_url":"https://api.github.com/users/mctynp/repos","events_url":"https://api.github.com/users/mctynp/events{/privacy}","received_events_url":"https://api.github.com/users/mctynp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mctynp/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/mctynp/Cataclysm-DDA","forks_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/mctynp/Cataclysm-DDA/deployments","created_at":"2018-09-19T00:40:00Z","updated_at":"2018-09-30T21:18:26Z","pushed_at":"2018-10-02T01:24:23Z","git_url":"git://github.com/mctynp/Cataclysm-DDA.git","ssh_url":"git@github.com:mctynp/Cataclysm-DDA.git","clone_url":"https://github.com/mctynp/Cataclysm-DDA.git","svn_url":"https://github.com/mctynp/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1337485,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"a2209cd9f8928dc1324b9dc9f805b03df5a4746c","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-10-01T22:36:22Z","pushed_at":"2018-10-02T01:38:55Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1337617,"stargazers_count":2149,"watchers_count":2149,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1431,"mirror_url":null,"archived":false,"open_issues_count":1022,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1431,"open_issues":1022,"watchers":2149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/25942"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/25942"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/25942/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/25942/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/0d842e42077e75fad15eb47eb820b33698dde29a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":70,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"mctynp"}}