{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/1620","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/1620/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/1620/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/1620/events","html_url":"https://github.com/singularityware/singularity/pull/1620","id":329614548,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODI4MjYz","number":1620,"title":"Fix config parser malloc size calculation that resulted in writing off the end of the space","user":{"login":"DrDaveD","id":2129743,"node_id":"MDQ6VXNlcjIxMjk3NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2129743?v=4","gravatar_id":"","url":"https://api.github.com/users/DrDaveD","html_url":"https://github.com/DrDaveD","followers_url":"https://api.github.com/users/DrDaveD/followers","following_url":"https://api.github.com/users/DrDaveD/following{/other_user}","gists_url":"https://api.github.com/users/DrDaveD/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDaveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDaveD/subscriptions","organizations_url":"https://api.github.com/users/DrDaveD/orgs","repos_url":"https://api.github.com/users/DrDaveD/repos","events_url":"https://api.github.com/users/DrDaveD/events{/privacy}","received_events_url":"https://api.github.com/users/DrDaveD/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/singularityware/singularity/milestones/10","html_url":"https://github.com/singularityware/singularity/milestone/10","labels_url":"https://api.github.com/repos/singularityware/singularity/milestones/10/labels","id":3400207,"node_id":"MDk6TWlsZXN0b25lMzQwMDIwNw==","number":10,"title":"2.5.2 Release","description":"","creator":{"login":"GodloveD","id":7672924,"node_id":"MDQ6VXNlcjc2NzI5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7672924?v=4","gravatar_id":"","url":"https://api.github.com/users/GodloveD","html_url":"https://github.com/GodloveD","followers_url":"https://api.github.com/users/GodloveD/followers","following_url":"https://api.github.com/users/GodloveD/following{/other_user}","gists_url":"https://api.github.com/users/GodloveD/gists{/gist_id}","starred_url":"https://api.github.com/users/GodloveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GodloveD/subscriptions","organizations_url":"https://api.github.com/users/GodloveD/orgs","repos_url":"https://api.github.com/users/GodloveD/repos","events_url":"https://api.github.com/users/GodloveD/events{/privacy}","received_events_url":"https://api.github.com/users/GodloveD/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":13,"state":"open","created_at":"2018-06-04T20:52:17Z","updated_at":"2018-06-25T15:17:26Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-06-05T20:34:13Z","updated_at":"2018-06-25T15:19:29Z","closed_at":"2018-06-25T15:17:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/1620","html_url":"https://github.com/singularityware/singularity/pull/1620","diff_url":"https://github.com/singularityware/singularity/pull/1620.diff","patch_url":"https://github.com/singularityware/singularity/pull/1620.patch"},"body":"**Description of the Pull Request (PR):**\r\n\r\nThis PR fixes a miscalculation in malloc size in the config parser new_hash_entry() function.  I found this because I was using the valgrind malloc checker with these parameters:\r\n```\r\nvalgrind --track-origins=yes --keep-stacktraces=alloc-and-free --tool=memcheck --trace-children=yes\r\n```\r\nand it had the following output\r\n```\r\n==7653== Invalid write of size 8\r\n==7653==    at 0x4E3C5A6: new_hash_entry (config_parser.c:60)\r\n==7653==    by 0x4E3C5A6: add_entry (config_parser.c:99)\r\n==7653==    by 0x4E3C5A6: singularity_config_parse (config_parser.c:185)\r\n==7653==    by 0x4E3C8E5: singularity_config_init (config_parser.c:212)\r\n==7653==    by 0x10B6E4: main (action.c:70)\r\n==7653==  Address 0x5639d50 is 512 bytes inside a block of size 513 alloc'd\r\n==7653==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)\r\n==7653==    by 0x4E3C586: new_hash_entry (config_parser.c:56)\r\n==7653==    by 0x4E3C586: add_entry (config_parser.c:99)\r\n==7653==    by 0x4E3C586: singularity_config_parse (config_parser.c:185)\r\n==7653==    by 0x4E3C8E5: singularity_config_init (config_parser.c:212)\r\n==7653==    by 0x10B6E4: main (action.c:70)\r\n```\r\n\r\n\r\n**This fixes or addresses the following GitHub issues:**\r\n\r\n- None\r\n\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [x] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [ ] I have added changes to the [CHANGELOG](https://github.com/singularityware/singularity/blob/development/CHANGELOG.md) and and documentation updates to the [singularityware](https://www.github.com/singularityware/singularityware.github.io) documentation base.\r\n- [x] I have tested this PR locally with a `make test`\r\n- [x] This PR is NOT against the project's master branch\r\n- [x] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\n\r\nAttn: @singularityware-admin\r\n"},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/399989535","html_url":"https://github.com/singularityware/singularity/pull/1620#issuecomment-399989535","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/1620","id":399989535,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTk4OTUzNQ==","user":{"login":"GodloveD","id":7672924,"node_id":"MDQ6VXNlcjc2NzI5MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7672924?v=4","gravatar_id":"","url":"https://api.github.com/users/GodloveD","html_url":"https://github.com/GodloveD","followers_url":"https://api.github.com/users/GodloveD/followers","following_url":"https://api.github.com/users/GodloveD/following{/other_user}","gists_url":"https://api.github.com/users/GodloveD/gists{/gist_id}","starred_url":"https://api.github.com/users/GodloveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GodloveD/subscriptions","organizations_url":"https://api.github.com/users/GodloveD/orgs","repos_url":"https://api.github.com/users/GodloveD/repos","events_url":"https://api.github.com/users/GodloveD/events{/privacy}","received_events_url":"https://api.github.com/users/GodloveD/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T15:19:29Z","updated_at":"2018-06-25T15:19:29Z","author_association":"MEMBER","body":"Thanks @DrDaveD .  Also cherry-picked into release-2.5"}}
{"actor":{"display_login":"GodloveD"}}