{"action":"created","comment":{"url":"https://api.github.com/repos/qiniu/logkit/pulls/comments/174162715","pull_request_review_id":103467581,"id":174162715,"diff_hunk":"@@ -620,34 +681,39 @@ var ModeKeyOptions = map[string][]Option{\n \t\t\tKeyName:      KeySocketServiceAddress,\n \t\t\tChooseOnly:   false,\n \t\t\tDefault:      \"tcp://127.0.0.1:3110\",\n+\t\t\tRequired:     true,\n \t\t\tDefaultNoUse: true,\n \t\t\tDescription:  \"socket监听的地址(协议://端口)(socket_service_address)\",\n \t\t},\n \t\t{\n \t\t\tKeyName:      KeySocketMaxConnections,\n \t\t\tChooseOnly:   false,\n \t\t\tDefault:      \"0\",\n+\t\t\tRequired:     true,\n \t\t\tDefaultNoUse: false,\n \t\t\tDescription:  \"最大并发连接数(tcp)(socket_max_connections)\",\n \t\t},\n \t\t{\n \t\t\tKeyName:      KeySocketReadTimeout,\n \t\t\tChooseOnly:   false,\n \t\t\tDefault:      \"1m\",\n+\t\t\tRequired:     true,\n \t\t\tDefaultNoUse: false,\n \t\t\tDescription:  \"连接超时时间(0为不超时)(socket_read_timeout)\",\n \t\t},\n \t\t{\n \t\t\tKeyName:      KeySocketReadBufferSize,\n \t\t\tChooseOnly:   false,\n \t\t\tDefault:      \"65535\",\n+\t\t\tRequired:     true,","path":"reader/rest_reader_models.go","position":387,"original_position":387,"commit_id":"18fdf75727cd006d87fde54a3f910fe566278736","original_commit_id":"18fdf75727cd006d87fde54a3f910fe566278736","user":{"login":"wonderflow","id":2173670,"avatar_url":"https://avatars0.githubusercontent.com/u/2173670?v=4","gravatar_id":"","url":"https://api.github.com/users/wonderflow","html_url":"https://github.com/wonderflow","followers_url":"https://api.github.com/users/wonderflow/followers","following_url":"https://api.github.com/users/wonderflow/following{/other_user}","gists_url":"https://api.github.com/users/wonderflow/gists{/gist_id}","starred_url":"https://api.github.com/users/wonderflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonderflow/subscriptions","organizations_url":"https://api.github.com/users/wonderflow/orgs","repos_url":"https://api.github.com/users/wonderflow/repos","events_url":"https://api.github.com/users/wonderflow/events{/privacy}","received_events_url":"https://api.github.com/users/wonderflow/received_events","type":"User","site_admin":false},"body":"false","created_at":"2018-03-13T14:57:43Z","updated_at":"2018-03-13T14:57:43Z","html_url":"https://github.com/qiniu/logkit/pull/370#discussion_r174162715","pull_request_url":"https://api.github.com/repos/qiniu/logkit/pulls/370","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/comments/174162715"},"html":{"href":"https://github.com/qiniu/logkit/pull/370#discussion_r174162715"},"pull_request":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/qiniu/logkit/pulls/370","id":174610673,"html_url":"https://github.com/qiniu/logkit/pull/370","diff_url":"https://github.com/qiniu/logkit/pull/370.diff","patch_url":"https://github.com/qiniu/logkit/pull/370.patch","issue_url":"https://api.github.com/repos/qiniu/logkit/issues/370","number":370,"state":"open","locked":false,"title":"配置项中添加 required 和 placeholder 两个字段","user":{"login":"andrewei1316","id":11746576,"avatar_url":"https://avatars2.githubusercontent.com/u/11746576?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewei1316","html_url":"https://github.com/andrewei1316","followers_url":"https://api.github.com/users/andrewei1316/followers","following_url":"https://api.github.com/users/andrewei1316/following{/other_user}","gists_url":"https://api.github.com/users/andrewei1316/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewei1316/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewei1316/subscriptions","organizations_url":"https://api.github.com/users/andrewei1316/orgs","repos_url":"https://api.github.com/users/andrewei1316/repos","events_url":"https://api.github.com/users/andrewei1316/events{/privacy}","received_events_url":"https://api.github.com/users/andrewei1316/received_events","type":"User","site_admin":false},"body":"## Fixes [issue number]\r\n\r\n## Changes\r\n   \r\n  - [ ] 配置项中添加 required 和 placeholder 两个字段\r\n \r\n## Reviewers\r\n\r\n  - [ ] @[someone] please review\r\n  - [ ] @[someotherone] please review\r\n\r\n## Wiki Changes\r\n \r\n  - options1...\r\n  - options2...\r\n    \r\n## Checklist\r\n   \r\n   - [ ] Rebased/mergable\r\n   - [ ] Tests pass\r\n   - [ ] Wiki updated\r\n","created_at":"2018-03-13T10:09:49Z","updated_at":"2018-03-13T14:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52b818dc78d21c1dcbf7b579b8eb099163d198ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qiniu/logkit/pulls/370/commits","review_comments_url":"https://api.github.com/repos/qiniu/logkit/pulls/370/comments","review_comment_url":"https://api.github.com/repos/qiniu/logkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qiniu/logkit/issues/370/comments","statuses_url":"https://api.github.com/repos/qiniu/logkit/statuses/18fdf75727cd006d87fde54a3f910fe566278736","head":{"label":"andrewei1316:master","ref":"master","sha":"18fdf75727cd006d87fde54a3f910fe566278736","user":{"login":"andrewei1316","id":11746576,"avatar_url":"https://avatars2.githubusercontent.com/u/11746576?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewei1316","html_url":"https://github.com/andrewei1316","followers_url":"https://api.github.com/users/andrewei1316/followers","following_url":"https://api.github.com/users/andrewei1316/following{/other_user}","gists_url":"https://api.github.com/users/andrewei1316/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewei1316/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewei1316/subscriptions","organizations_url":"https://api.github.com/users/andrewei1316/orgs","repos_url":"https://api.github.com/users/andrewei1316/repos","events_url":"https://api.github.com/users/andrewei1316/events{/privacy}","received_events_url":"https://api.github.com/users/andrewei1316/received_events","type":"User","site_admin":false},"repo":{"id":107124436,"name":"logkit","full_name":"andrewei1316/logkit","owner":{"login":"andrewei1316","id":11746576,"avatar_url":"https://avatars2.githubusercontent.com/u/11746576?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewei1316","html_url":"https://github.com/andrewei1316","followers_url":"https://api.github.com/users/andrewei1316/followers","following_url":"https://api.github.com/users/andrewei1316/following{/other_user}","gists_url":"https://api.github.com/users/andrewei1316/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewei1316/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewei1316/subscriptions","organizations_url":"https://api.github.com/users/andrewei1316/orgs","repos_url":"https://api.github.com/users/andrewei1316/repos","events_url":"https://api.github.com/users/andrewei1316/events{/privacy}","received_events_url":"https://api.github.com/users/andrewei1316/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewei1316/logkit","description":null,"fork":true,"url":"https://api.github.com/repos/andrewei1316/logkit","forks_url":"https://api.github.com/repos/andrewei1316/logkit/forks","keys_url":"https://api.github.com/repos/andrewei1316/logkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewei1316/logkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewei1316/logkit/teams","hooks_url":"https://api.github.com/repos/andrewei1316/logkit/hooks","issue_events_url":"https://api.github.com/repos/andrewei1316/logkit/issues/events{/number}","events_url":"https://api.github.com/repos/andrewei1316/logkit/events","assignees_url":"https://api.github.com/repos/andrewei1316/logkit/assignees{/user}","branches_url":"https://api.github.com/repos/andrewei1316/logkit/branches{/branch}","tags_url":"https://api.github.com/repos/andrewei1316/logkit/tags","blobs_url":"https://api.github.com/repos/andrewei1316/logkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewei1316/logkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewei1316/logkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewei1316/logkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewei1316/logkit/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewei1316/logkit/languages","stargazers_url":"https://api.github.com/repos/andrewei1316/logkit/stargazers","contributors_url":"https://api.github.com/repos/andrewei1316/logkit/contributors","subscribers_url":"https://api.github.com/repos/andrewei1316/logkit/subscribers","subscription_url":"https://api.github.com/repos/andrewei1316/logkit/subscription","commits_url":"https://api.github.com/repos/andrewei1316/logkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewei1316/logkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewei1316/logkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewei1316/logkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewei1316/logkit/contents/{+path}","compare_url":"https://api.github.com/repos/andrewei1316/logkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewei1316/logkit/merges","archive_url":"https://api.github.com/repos/andrewei1316/logkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewei1316/logkit/downloads","issues_url":"https://api.github.com/repos/andrewei1316/logkit/issues{/number}","pulls_url":"https://api.github.com/repos/andrewei1316/logkit/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewei1316/logkit/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewei1316/logkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewei1316/logkit/labels{/name}","releases_url":"https://api.github.com/repos/andrewei1316/logkit/releases{/id}","deployments_url":"https://api.github.com/repos/andrewei1316/logkit/deployments","created_at":"2017-10-16T12:29:27Z","updated_at":"2017-10-16T12:29:30Z","pushed_at":"2018-03-13T10:15:28Z","git_url":"git://github.com/andrewei1316/logkit.git","ssh_url":"git@github.com:andrewei1316/logkit.git","clone_url":"https://github.com/andrewei1316/logkit.git","svn_url":"https://github.com/andrewei1316/logkit","homepage":"https://qiniu.github.io/pandora-docs/#/util/logkit","size":25802,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qiniu:master","ref":"master","sha":"c9b12bbcd197db6544d5de3cdfce32386ade2fba","user":{"login":"qiniu","id":1563636,"avatar_url":"https://avatars2.githubusercontent.com/u/1563636?v=4","gravatar_id":"","url":"https://api.github.com/users/qiniu","html_url":"https://github.com/qiniu","followers_url":"https://api.github.com/users/qiniu/followers","following_url":"https://api.github.com/users/qiniu/following{/other_user}","gists_url":"https://api.github.com/users/qiniu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiniu/subscriptions","organizations_url":"https://api.github.com/users/qiniu/orgs","repos_url":"https://api.github.com/users/qiniu/repos","events_url":"https://api.github.com/users/qiniu/events{/privacy}","received_events_url":"https://api.github.com/users/qiniu/received_events","type":"Organization","site_admin":false},"repo":{"id":91304426,"name":"logkit","full_name":"qiniu/logkit","owner":{"login":"qiniu","id":1563636,"avatar_url":"https://avatars2.githubusercontent.com/u/1563636?v=4","gravatar_id":"","url":"https://api.github.com/users/qiniu","html_url":"https://github.com/qiniu","followers_url":"https://api.github.com/users/qiniu/followers","following_url":"https://api.github.com/users/qiniu/following{/other_user}","gists_url":"https://api.github.com/users/qiniu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiniu/subscriptions","organizations_url":"https://api.github.com/users/qiniu/orgs","repos_url":"https://api.github.com/users/qiniu/repos","events_url":"https://api.github.com/users/qiniu/events{/privacy}","received_events_url":"https://api.github.com/users/qiniu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qiniu/logkit","description":"Very easy-to-use server agent for collecting & sending logs & metrics.","fork":false,"url":"https://api.github.com/repos/qiniu/logkit","forks_url":"https://api.github.com/repos/qiniu/logkit/forks","keys_url":"https://api.github.com/repos/qiniu/logkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiniu/logkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiniu/logkit/teams","hooks_url":"https://api.github.com/repos/qiniu/logkit/hooks","issue_events_url":"https://api.github.com/repos/qiniu/logkit/issues/events{/number}","events_url":"https://api.github.com/repos/qiniu/logkit/events","assignees_url":"https://api.github.com/repos/qiniu/logkit/assignees{/user}","branches_url":"https://api.github.com/repos/qiniu/logkit/branches{/branch}","tags_url":"https://api.github.com/repos/qiniu/logkit/tags","blobs_url":"https://api.github.com/repos/qiniu/logkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiniu/logkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiniu/logkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiniu/logkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiniu/logkit/statuses/{sha}","languages_url":"https://api.github.com/repos/qiniu/logkit/languages","stargazers_url":"https://api.github.com/repos/qiniu/logkit/stargazers","contributors_url":"https://api.github.com/repos/qiniu/logkit/contributors","subscribers_url":"https://api.github.com/repos/qiniu/logkit/subscribers","subscription_url":"https://api.github.com/repos/qiniu/logkit/subscription","commits_url":"https://api.github.com/repos/qiniu/logkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiniu/logkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiniu/logkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiniu/logkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiniu/logkit/contents/{+path}","compare_url":"https://api.github.com/repos/qiniu/logkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiniu/logkit/merges","archive_url":"https://api.github.com/repos/qiniu/logkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiniu/logkit/downloads","issues_url":"https://api.github.com/repos/qiniu/logkit/issues{/number}","pulls_url":"https://api.github.com/repos/qiniu/logkit/pulls{/number}","milestones_url":"https://api.github.com/repos/qiniu/logkit/milestones{/number}","notifications_url":"https://api.github.com/repos/qiniu/logkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiniu/logkit/labels{/name}","releases_url":"https://api.github.com/repos/qiniu/logkit/releases{/id}","deployments_url":"https://api.github.com/repos/qiniu/logkit/deployments","created_at":"2017-05-15T06:50:40Z","updated_at":"2018-03-13T11:02:38Z","pushed_at":"2018-03-13T14:25:32Z","git_url":"git://github.com/qiniu/logkit.git","ssh_url":"git@github.com:qiniu/logkit.git","clone_url":"https://github.com/qiniu/logkit.git","svn_url":"https://github.com/qiniu/logkit","homepage":"https://pandora-docs.qiniu.com","size":15723,"stargazers_count":421,"watchers_count":421,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":85,"open_issues":19,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/370"},"html":{"href":"https://github.com/qiniu/logkit/pull/370"},"issue":{"href":"https://api.github.com/repos/qiniu/logkit/issues/370"},"comments":{"href":"https://api.github.com/repos/qiniu/logkit/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/qiniu/logkit/statuses/18fdf75727cd006d87fde54a3f910fe566278736"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wonderflow"}}