{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/35441","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35441/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35441/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35441/events","html_url":"https://github.com/elastic/elasticsearch/pull/35441","id":379618515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDE2MTQy","number":35441,"title":"Make keepalive pings bidirectional and optimizable","user":{"login":"tbrooks8","id":862472,"node_id":"MDQ6VXNlcjg2MjQ3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/862472?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrooks8","html_url":"https://github.com/tbrooks8","followers_url":"https://api.github.com/users/tbrooks8/followers","following_url":"https://api.github.com/users/tbrooks8/following{/other_user}","gists_url":"https://api.github.com/users/tbrooks8/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrooks8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrooks8/subscriptions","organizations_url":"https://api.github.com/users/tbrooks8/orgs","repos_url":"https://api.github.com/users/tbrooks8/repos","events_url":"https://api.github.com/users/tbrooks8/events{/privacy}","received_events_url":"https://api.github.com/users/tbrooks8/received_events","type":"User","site_admin":false},"labels":[{"id":146854632,"node_id":"MDU6TGFiZWwxNDY4NTQ2MzI=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Distributed/Network","name":":Distributed/Network","color":"0e8a16","default":false},{"id":73544,"node_id":"MDU6TGFiZWw3MzU0NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Enon-issue","name":">non-issue","color":"cfcfcf","default":false},{"id":1102494662,"node_id":"MDU6TGFiZWwxMTAyNDk0NjYy","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.6.0","name":"v6.6.0","color":"dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-12T04:39:35Z","updated_at":"2018-11-19T09:50:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35441","html_url":"https://github.com/elastic/elasticsearch/pull/35441","diff_url":"https://github.com/elastic/elasticsearch/pull/35441.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/35441.patch"},"body":"This is related to #34405 and a follow-up to #34753. It makes a number\r\nof changes to our current keepalive pings.\r\n\r\n1. The ping interval configuration is moved to the `ConnectionProfile`.\r\n\r\n2. The server channel now responds to pings. This makes the keepalive\r\npings bidirectional.\r\n\r\n3. On the client-side, the pings can now be optimized away. What this\r\nmeans is that if the channel has received a message and sent a message\r\nsince the last pinging round, the ping is not sent for this round."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/439833581","html_url":"https://github.com/elastic/elasticsearch/pull/35441#issuecomment-439833581","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35441","id":439833581,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTgzMzU4MQ==","user":{"login":"s1monw","id":973334,"node_id":"MDQ6VXNlcjk3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/973334?v=4","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T09:50:11Z","updated_at":"2018-11-19T09:50:11Z","author_association":"CONTRIBUTOR","body":">I added an AsyncBiConsumer. That naming seemed most consistent with java.util classes.\r\n\r\nI disagree, a consumer doesn't produce anything. We have a function that passes it return value to a listener. I think that is more intuitive and correct\r\n\r\n> n regards to the ChannelStats - I could move them off of the channel and into a ConcurrentMap channel -> channel stats in TcpTransport. That avoids the need for all the different Transport implementations to handle creating them, etc. Let me know what you think.\r\n\r\n+1\r\n\r\n> I could add one for outbound client channels also. And have them be maps of channels -> channel stats. And then the underlying transport implementations to not need to know anything about channel stats.\r\n\r\n+1\r\n\r\nthis can also be a followup IMO\r\n"}}
{"actor":{"display_login":"s1monw"}}