{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/5894","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/5894/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/5894/comments","events_url":"https://api.github.com/repos/minio/minio/issues/5894/events","html_url":"https://github.com/minio/minio/pull/5894","id":320755039,"number":5894,"title":"SignatureV4 validation with Metadata in the presignedUrl","user":{"login":"Praveenrajmani","id":5410427,"avatar_url":"https://avatars0.githubusercontent.com/u/5410427?v=4","gravatar_id":"","url":"https://api.github.com/users/Praveenrajmani","html_url":"https://github.com/Praveenrajmani","followers_url":"https://api.github.com/users/Praveenrajmani/followers","following_url":"https://api.github.com/users/Praveenrajmani/following{/other_user}","gists_url":"https://api.github.com/users/Praveenrajmani/gists{/gist_id}","starred_url":"https://api.github.com/users/Praveenrajmani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praveenrajmani/subscriptions","organizations_url":"https://api.github.com/users/Praveenrajmani/orgs","repos_url":"https://api.github.com/users/Praveenrajmani/repos","events_url":"https://api.github.com/users/Praveenrajmani/events{/privacy}","received_events_url":"https://api.github.com/users/Praveenrajmani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-07T10:33:59Z","updated_at":"2018-05-08T08:39:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5894","html_url":"https://github.com/minio/minio/pull/5894","diff_url":"https://github.com/minio/minio/pull/5894.diff","patch_url":"https://github.com/minio/minio/pull/5894.patch"},"body":"- [ ] - The presigned url generated by the sdk had the amz-metadata in the query string. The v4signature should have the metadata included,which was not happening before.\r\n- [ ] - The metadata was not handled when sent in as a query string parameter. Still was accepting it via headers.\r\n\r\n**Changes Made:**\r\n- Function doesPresignedSignatureMatch, metadata inclusion in signature validation\r\n\r\n**Function Added:**\r\n- Function extractMetadataFromQueryString, extracting metadata from query string\r\n\r\n**Resolves:** #5857\r\n\r\n**Changes committed:**\r\n\tmodified:   cmd/handler-utils.go\r\n\tmodified:   cmd/object-handlers.go\r\n\tmodified:   cmd/signature-v4.go\r\n"},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/387329042","html_url":"https://github.com/minio/minio/pull/5894#issuecomment-387329042","issue_url":"https://api.github.com/repos/minio/minio/issues/5894","id":387329042,"user":{"login":"balamurugana","id":629407,"avatar_url":"https://avatars2.githubusercontent.com/u/629407?v=4","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T08:39:53Z","updated_at":"2018-05-08T08:39:53Z","author_association":"MEMBER","body":"## Mint Automation\n| Test | Result |\n|:--- |:--- |\n| mint-xl.sh | :heavy_check_mark: |\n| mint-fs.sh | :heavy_check_mark: |\n| mint-dist-xl.sh | :x: [more...](#ff2c12ac-ad7e-4662-af8f-25178a7f1b5f) |\n| mint-gateway-s3.sh | :x: [more...](#df41534d-a0db-46d1-b559-78ce09bd1d2b) |\n| mint-gateway-azure.sh | :x: [more...](#0d341eca-c51d-4487-88a1-075c9320e322) |\n<a name=\"0d341eca-c51d-4487-88a1-075c9320e322\"></a>\n### 5894-ea7f29d/mint-gateway-azure.sh.log:\n```\nRunning with\nSERVER_ENDPOINT: minikube:30809\nACCESS_KEY:      minioazure1\nSECRET_KEY:      ***REDACTED***\nENABLE_HTTPS:    0\nSERVER_REGION:   us-east-1\nMINT_DATA_DIR:   /mint/data\nMINT_MODE:       core\n\nTo get logs, run 'docker cp 67b5b23358b4:/mint/log /tmp/mint-logs'\n(1/13) Running aws-sdk-go tests ... done in 2 seconds\n(2/13) Running aws-sdk-java tests ... done in 19 seconds\n(3/13) Running aws-sdk-php tests ... done in 55 seconds\n(4/13) Running aws-sdk-ruby tests ... done in 39 seconds\n(5/13) Running awscli tests ... done in 4 minutes and 55 seconds\n(6/13) Running mc tests ... done in 7 minutes and 40 seconds\n(7/13) Running minio-dotnet tests ... done in 1 minutes and 17 seconds\n(8/13) Running minio-go tests ... done in 1 seconds\n(9/13) Running minio-java tests ... done in 32 seconds\n(10/13) Running minio-js tests ... FAILED in 2 minutes and 27 seconds\n{\n  \"name\": \"minio-js\",\n  \"function\": \"listObjects(bucketName, prefix, recursive)\",\n  \"args\": \"bucketName:minio-js-test-6d44878c-a52c-452f-a9d9-9114a72c46a0, recursive:false\",\n  \"duration\": 240,\n  \"status\": \"FAIL\",\n  \"error\": \"Error: listObjects lists 11 objects, expected 10 at Readable.client.listObjects.on.on (test/functional-tests.js:947:23) at endReadableNT (_stream_readable.js:978:12) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9)\"\n}\n\nExecuted 9 out of 13 tests successfully.\n```\n<a name=\"df41534d-a0db-46d1-b559-78ce09bd1d2b\"></a>\n### 5894-ea7f29d/mint-gateway-s3.sh.log:\n```\nRunning with\nSERVER_ENDPOINT: minikube:30973\nACCESS_KEY:      AKIAJH7GQKYNU3C2ADXA\nSECRET_KEY:      ***REDACTED***\nENABLE_HTTPS:    0\nSERVER_REGION:   us-east-1\nMINT_DATA_DIR:   /mint/data\nMINT_MODE:       core\n\nTo get logs, run 'docker cp 5a988bb693cb:/mint/log /tmp/mint-logs'\n(1/13) Running aws-sdk-go tests ... done in 3 seconds\n(2/13) Running aws-sdk-java tests ... done in 20 seconds\n(3/13) Running aws-sdk-php tests ... done in 1 minutes and 11 seconds\n(4/13) Running aws-sdk-ruby tests ... done in 56 seconds\n(5/13) Running awscli tests ... done in 4 minutes and 42 seconds\n(6/13) Running mc tests ... done in 4 minutes and 29 seconds\n(7/13) Running minio-dotnet tests ... done in 1 minutes and 14 seconds\n(8/13) Running minio-go tests ... done in 16 seconds\n(9/13) Running minio-java tests ... done in 31 seconds\n(10/13) Running minio-js tests ... FAILED in 44 seconds\n{\n  \"name\": \"minio-js\",\n  \"function\": \"\\\"after all\\\" hook\",\n  \"duration\": 266,\n  \"status\": \"FAIL\",\n  \"error\": \"S3Error: The bucket you tried to delete is not empty at Object.parseError (node_modules/minio/dist/main/xml-parsers.js:56:11) at /mint/run/core/minio-js/node_modules/minio/dist/main/transformers.js:117:22 at DestroyableTransform._flush (node_modules/minio/dist/main/transformers.js:48:26) at DestroyableTransform.<anonymous> (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:135:12) at finishMaybe (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:371:12) at endWritable (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:378:3) at DestroyableTransform.Writable.end (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:356:5) at IncomingMessage.onend (_stream_readable.js:514:10) at endReadableNT (_stream_readable.js:978:12) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9)\"\n}\n\nExecuted 9 out of 13 tests successfully.\n```\n<a name=\"ff2c12ac-ad7e-4662-af8f-25178a7f1b5f\"></a>\n### 5894-ea7f29d/mint-dist-xl.sh.log:\n```\nRunning with\nSERVER_ENDPOINT: minikube:31318\nACCESS_KEY:      minio\nSECRET_KEY:      ***REDACTED***\nENABLE_HTTPS:    0\nSERVER_REGION:   us-east-1\nMINT_DATA_DIR:   /mint/data\nMINT_MODE:       core\n\nTo get logs, run 'docker cp 8e1d48f8e060:/mint/log /tmp/mint-logs'\n(1/13) Running aws-sdk-go tests ... done in 2 seconds\n(2/13) Running aws-sdk-java tests ... done in 19 seconds\n(3/13) Running aws-sdk-php tests ... done in 49 seconds\n(4/13) Running aws-sdk-ruby tests ... done in 30 seconds\n(5/13) Running awscli tests ... done in 5 minutes and 52 seconds\n(6/13) Running mc tests ... done in 2 minutes and 12 seconds\n(7/13) Running minio-dotnet tests ... done in 1 minutes and 2 seconds\n(8/13) Running minio-go tests ... done in 9 seconds\n(9/13) Running minio-java tests ... done in 45 seconds\n(10/13) Running minio-js tests ... FAILED in 45 seconds\n{\n  \"name\": \"minio-js\",\n  \"function\": \"listenBucketNotification(bucketName, prefix, suffix, events)\",\n  \"args\": \"bucketName:minio-js-test-785431ec-cda2-4284-b29c-cbad53495e94, events: s3:ObjectCreated:*\",\n  \"duration\": 8333,\n  \"status\": \"FAIL\",\n  \"error\": \"Error: notification not received at client.removeObject.err (test/functional-tests.js:1034:43) at ClientRequest.<anonymous> (node_modules/minio/dist/main/minio.js:420:9) at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:478:21) at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23) at Socket.socketOnData (_http_client.js:367:20) at readableAddChunk (_stream_readable.js:176:18) at Socket.Readable.push (_stream_readable.js:134:10) at TCP.onread (net.js:559:20)\"\n}\n\nExecuted 9 out of 13 tests successfully.\n```\n"}}
{"actor":{"display_login":"balamurugana"}}