{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/198441345","pull_request_review_id":132370099,"id":198441345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ0MTM0NQ==","diff_hunk":"@@ -44,6 +44,57 @@\n class Siri(RealtimeProxy):\n     \"\"\"\n     Class managing calls to siri external service providing real-time next passages\n+\n+\n+    curl example to check/test that external service is working:\n+    curl -X POST '{server}' -d '<x:Envelope \n+    xmlns:x=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:wsd=\"http://wsdl.siri.org.uk\" xmlns:siri=\"http://www.siri.org.uk/siri\">\n+        <x:Header/>\n+        <x:Body>\n+            <GetStopMonitoring xmlns=\"http://wsdl.siri.org.uk\" xmlns:siri=\"http://www.siri.org.uk/siri\">\n+                <ServiceRequestInfo xmlns=\"\">\n+                    <siri:RequestTimestamp>{datetime}</siri:RequestTimestamp>\n+                    <siri:RequestorRef>{requestor_ref}</siri:RequestorRef>\n+                    <siri:MessageIdentifier>IDontCare</siri:MessageIdentifier>\n+                </ServiceRequestInfo>\n+                <Request version=\"1.3\" xmlns=\"\">\n+                    <siri:RequestTimestamp>{datetime}</siri:RequestTimestamp>\n+                    <siri:MessageIdentifier>IDontCare</siri:MessageIdentifier>\n+                    <siri:MonitoringRef>{stop_code}</siri:MonitoringRef>\n+                    <siri:MaximumStopVisits>{nb_desired}</siri:MaximumStopVisits>\n+                </Request>\n+                <RequestExtension xmlns=\"\"/>\n+            </GetStopMonitoring>\n+        </x:Body>\n+    </x:Envelope>'\n+\n+    Then Navitia matches route-points in the response using {stop_code}, {route_code} and {line_code}.\n+\n+    {datetime} is iso-formated: YYYY-mm-ddTHH:MM:ss.sss+HH:MM\n+    {stop_code}, {route_code} and {line_code} are provided using the same code key, named after\n+    the 'destination_id_tag' if provided on connector's init, or the 'id' otherwise.\n+\n+    In practice it will look like:\n+    curl -X POST 'http://bobito.fr:8080/ProfilSiriKidfProducer-Bobito/SiriServices' -d '<x:Envelope \n+    xmlns:x=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:wsd=\"http://wsdl.siri.org.uk\" xmlns:siri=\"http://www.siri.org.uk/siri\">\n+        <x:Header/>\n+        <x:Body>\n+            <GetStopMonitoring xmlns=\"http://wsdl.siri.org.uk\" xmlns:siri=\"http://www.siri.org.uk/siri\">\n+                <ServiceRequestInfo xmlns=\"\">\n+                    <siri:RequestTimestamp>2018-06-11T17:21:49.703+02:00</siri:RequestTimestamp>\n+                    <siri:RequestorRef>BobitoJVM</siri:RequestorRef>\n+                    <siri:MessageIdentifier>IDontCare</siri:MessageIdentifier>\n+                </ServiceRequestInfo>\n+                <Request version=\"1.3\" xmlns=\"\">\n+                    <siri:RequestTimestamp>2018-06-11T17:21:49.703+02:00</siri:RequestTimestamp>\n+                    <siri:MessageIdentifier>IDontCare</siri:MessageIdentifier>\n+                    <siri:MonitoringRef>Bobito:StopPoint:BOB:00021201:ITO</siri:MonitoringRef>\n+                    <siri:MaximumStopVisits>5</siri:MaximumStopVisits>\n+                </Request>\n+                <RequestExtension xmlns=\"\"/>\n+            </GetStopMonitoring>\n+        </x:Body>\n+    </x:Envelope>'","path":"source/jormungandr/jormungandr/realtime_schedule/siri.py","position":26,"original_position":54,"commit_id":"561668ce924a0d5fa5bf299b454871e5bd3d6b4e","original_commit_id":"561668ce924a0d5fa5bf299b454871e5bd3d6b4e","user":{"login":"mbounabi","id":35227890,"node_id":"MDQ6VXNlcjM1MjI3ODkw","avatar_url":"https://avatars3.githubusercontent.com/u/35227890?v=4","gravatar_id":"","url":"https://api.github.com/users/mbounabi","html_url":"https://github.com/mbounabi","followers_url":"https://api.github.com/users/mbounabi/followers","following_url":"https://api.github.com/users/mbounabi/following{/other_user}","gists_url":"https://api.github.com/users/mbounabi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbounabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbounabi/subscriptions","organizations_url":"https://api.github.com/users/mbounabi/orgs","repos_url":"https://api.github.com/users/mbounabi/repos","events_url":"https://api.github.com/users/mbounabi/events{/privacy}","received_events_url":"https://api.github.com/users/mbounabi/received_events","type":"User","site_admin":false},"body":"I think that this is more of an integration help and not a description of the class in itself. IMO, It shouldn't be here.\r\n","created_at":"2018-06-27T10:18:01Z","updated_at":"2018-06-27T10:28:29Z","html_url":"https://github.com/CanalTP/navitia/pull/2438#discussion_r198441345","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2438","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/198441345"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2438#discussion_r198441345"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2438"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/2438","id":194351874,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzUxODc0","html_url":"https://github.com/CanalTP/navitia/pull/2438","diff_url":"https://github.com/CanalTP/navitia/pull/2438.diff","patch_url":"https://github.com/CanalTP/navitia/pull/2438.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/2438","number":2438,"state":"open","locked":false,"title":"Jormun: filter optim episode 2","user":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"body":"Most of the work is following #2404 , easier to read by commit.\r\n\r\nContains:\r\n* renaming and comments from #2404 's late review\r\n* refactor (debug-mode, remove hazardous early returns & filter interface) from #2404 's late review\r\n* little correction on test after #2404 's late review\r\n* comments on realtime proxies to help debug them when there are questions (easier to build the call)!\r\n* minor comment adds & compile-warning removals (OK, there's a bit of kraken)","created_at":"2018-06-12T17:21:03Z","updated_at":"2018-06-27T10:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ecd3a661d4095c47748e2ecab9934615daa03dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2438/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2438/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/2438/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/561668ce924a0d5fa5bf299b454871e5bd3d6b4e","head":{"label":"pbougue:filter_optim_episode_2","ref":"filter_optim_episode_2","sha":"561668ce924a0d5fa5bf299b454871e5bd3d6b4e","user":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"repo":{"id":37126861,"node_id":"MDEwOlJlcG9zaXRvcnkzNzEyNjg2MQ==","name":"navitia","full_name":"pbougue/navitia","owner":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbougue/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/pbougue/navitia","forks_url":"https://api.github.com/repos/pbougue/navitia/forks","keys_url":"https://api.github.com/repos/pbougue/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbougue/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbougue/navitia/teams","hooks_url":"https://api.github.com/repos/pbougue/navitia/hooks","issue_events_url":"https://api.github.com/repos/pbougue/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/pbougue/navitia/events","assignees_url":"https://api.github.com/repos/pbougue/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/pbougue/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/pbougue/navitia/tags","blobs_url":"https://api.github.com/repos/pbougue/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbougue/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbougue/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbougue/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbougue/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/pbougue/navitia/languages","stargazers_url":"https://api.github.com/repos/pbougue/navitia/stargazers","contributors_url":"https://api.github.com/repos/pbougue/navitia/contributors","subscribers_url":"https://api.github.com/repos/pbougue/navitia/subscribers","subscription_url":"https://api.github.com/repos/pbougue/navitia/subscription","commits_url":"https://api.github.com/repos/pbougue/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbougue/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbougue/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbougue/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbougue/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/pbougue/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbougue/navitia/merges","archive_url":"https://api.github.com/repos/pbougue/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbougue/navitia/downloads","issues_url":"https://api.github.com/repos/pbougue/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/pbougue/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/pbougue/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/pbougue/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbougue/navitia/labels{/name}","releases_url":"https://api.github.com/repos/pbougue/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/pbougue/navitia/deployments","created_at":"2015-06-09T10:57:48Z","updated_at":"2016-07-19T10:27:53Z","pushed_at":"2018-06-26T16:02:38Z","git_url":"git://github.com/pbougue/navitia.git","ssh_url":"git@github.com:pbougue/navitia.git","clone_url":"https://github.com/pbougue/navitia.git","svn_url":"https://github.com/pbougue/navitia","homepage":"http://www.navitia.io","size":40258,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"88277c3e411394ed6dc787d6b8cf862b564c1307","user":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5NzMzMw==","name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The open source software to build cool stuff with locomotion","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/navitia/deployments","created_at":"2013-06-19T15:34:30Z","updated_at":"2018-06-26T23:12:19Z","pushed_at":"2018-06-27T10:22:13Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":41185,"stargazers_count":248,"watchers_count":248,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":84,"open_issues":39,"watchers":248,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2438"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2438"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2438"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2438/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2438/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2438/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/561668ce924a0d5fa5bf299b454871e5bd3d6b4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mbounabi"}}