{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/172277737","pull_request_review_id":101267773,"id":172277737,"diff_hunk":"@@ -100,9 +100,12 @@ def post_install\n       cp Dir[libexec/\"lib/node_modules/npm/man/#{man}/{npm,package.json,npx}*\"], HOMEBREW_PREFIX/\"share/man/#{man}\"\n     end\n \n-    npm_root = node_modules/\"npm\"\n-    npmrc = npm_root/\"npmrc\"\n-    npmrc.atomic_write(\"prefix = #{HOMEBREW_PREFIX}\\n\")\n+    npmrc = <<~EOS\n+      prefix = #{HOMEBREW_PREFIX}\n+      python = #{Formula[\"python@2\"].opt_bin}/python2\\n","path":"Formula/node.rb","position":9,"original_position":9,"commit_id":"734f3b6ca4e158f99a2268da60aa4f4917ddeb51","original_commit_id":"734f3b6ca4e158f99a2268da60aa4f4917ddeb51","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"right. that's my point. no one really expects it to.","created_at":"2018-03-05T18:10:28Z","updated_at":"2018-03-05T18:10:28Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/24870#discussion_r172277737","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/172277737"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/24870#discussion_r172277737"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870"}},"in_reply_to_id":172273938},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870","id":172916970,"html_url":"https://github.com/Homebrew/homebrew-core/pull/24870","diff_url":"https://github.com/Homebrew/homebrew-core/pull/24870.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/24870.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24870","number":24870,"state":"open","locked":false,"title":"node: fix node-gyp after python3 -> python rename","user":{"login":"chrmoritz","id":1686759,"avatar_url":"https://avatars3.githubusercontent.com/u/1686759?v=4","gravatar_id":"","url":"https://api.github.com/users/chrmoritz","html_url":"https://github.com/chrmoritz","followers_url":"https://api.github.com/users/chrmoritz/followers","following_url":"https://api.github.com/users/chrmoritz/following{/other_user}","gists_url":"https://api.github.com/users/chrmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/chrmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrmoritz/subscriptions","organizations_url":"https://api.github.com/users/chrmoritz/orgs","repos_url":"https://api.github.com/users/chrmoritz/repos","events_url":"https://api.github.com/users/chrmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/chrmoritz/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nThe `python3` to `python` rename from https://github.com/Homebrew/homebrew-core/pull/24604 has broken `node-gyp`, because it expects that `python` (on the `$PATH`) to be version 2.7.x.\r\n\r\nFixes: #24869 (look at this for additional context)\r\n\r\nBTW: This issue was covered by our [native addon test](https://github.com/Homebrew/homebrew-core/blob/master/Formula/node.rb#L140) (`brew test node` is failing without this atm), but I can understand that you couldn't run all formulaes test in #24604.","created_at":"2018-03-05T16:27:04Z","updated_at":"2018-03-05T18:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3a736dca1703795caf252a8b78f155a58a20dbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24870/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/734f3b6ca4e158f99a2268da60aa4f4917ddeb51","head":{"label":"chrmoritz:node-gyp","ref":"node-gyp","sha":"734f3b6ca4e158f99a2268da60aa4f4917ddeb51","user":{"login":"chrmoritz","id":1686759,"avatar_url":"https://avatars3.githubusercontent.com/u/1686759?v=4","gravatar_id":"","url":"https://api.github.com/users/chrmoritz","html_url":"https://github.com/chrmoritz","followers_url":"https://api.github.com/users/chrmoritz/followers","following_url":"https://api.github.com/users/chrmoritz/following{/other_user}","gists_url":"https://api.github.com/users/chrmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/chrmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrmoritz/subscriptions","organizations_url":"https://api.github.com/users/chrmoritz/orgs","repos_url":"https://api.github.com/users/chrmoritz/repos","events_url":"https://api.github.com/users/chrmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/chrmoritz/received_events","type":"User","site_admin":false},"repo":{"id":55362168,"name":"homebrew-core","full_name":"chrmoritz/homebrew-core","owner":{"login":"chrmoritz","id":1686759,"avatar_url":"https://avatars3.githubusercontent.com/u/1686759?v=4","gravatar_id":"","url":"https://api.github.com/users/chrmoritz","html_url":"https://github.com/chrmoritz","followers_url":"https://api.github.com/users/chrmoritz/followers","following_url":"https://api.github.com/users/chrmoritz/following{/other_user}","gists_url":"https://api.github.com/users/chrmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/chrmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrmoritz/subscriptions","organizations_url":"https://api.github.com/users/chrmoritz/orgs","repos_url":"https://api.github.com/users/chrmoritz/repos","events_url":"https://api.github.com/users/chrmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/chrmoritz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrmoritz/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/chrmoritz/homebrew-core","forks_url":"https://api.github.com/repos/chrmoritz/homebrew-core/forks","keys_url":"https://api.github.com/repos/chrmoritz/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrmoritz/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrmoritz/homebrew-core/teams","hooks_url":"https://api.github.com/repos/chrmoritz/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/chrmoritz/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/chrmoritz/homebrew-core/events","assignees_url":"https://api.github.com/repos/chrmoritz/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/chrmoritz/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/chrmoritz/homebrew-core/tags","blobs_url":"https://api.github.com/repos/chrmoritz/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrmoritz/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrmoritz/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrmoritz/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrmoritz/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/chrmoritz/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/chrmoritz/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/chrmoritz/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/chrmoritz/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/chrmoritz/homebrew-core/subscription","commits_url":"https://api.github.com/repos/chrmoritz/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrmoritz/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrmoritz/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrmoritz/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrmoritz/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/chrmoritz/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrmoritz/homebrew-core/merges","archive_url":"https://api.github.com/repos/chrmoritz/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrmoritz/homebrew-core/downloads","issues_url":"https://api.github.com/repos/chrmoritz/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/chrmoritz/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/chrmoritz/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/chrmoritz/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrmoritz/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/chrmoritz/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/chrmoritz/homebrew-core/deployments","created_at":"2016-04-03T18:33:42Z","updated_at":"2016-04-03T18:33:55Z","pushed_at":"2018-03-05T17:44:11Z","git_url":"git://github.com/chrmoritz/homebrew-core.git","ssh_url":"git@github.com:chrmoritz/homebrew-core.git","clone_url":"https://github.com/chrmoritz/homebrew-core.git","svn_url":"https://github.com/chrmoritz/homebrew-core","homepage":"http://brew.sh","size":172210,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"node"}},"base":{"label":"Homebrew:master","ref":"master","sha":"bd37905e33a3b3ca8ba52e74c85c66377302f482","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2018-03-05T16:29:53Z","pushed_at":"2018-03-05T17:35:25Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":172012,"stargazers_count":3175,"watchers_count":3175,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4009,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":4009,"open_issues":78,"watchers":3175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/24870"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24870"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/24870/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/24870/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/734f3b6ca4e158f99a2268da60aa4f4917ddeb51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilovezfs"}}