{"action":"created","comment":{"url":"https://api.github.com/repos/build-week/hover-jet/pulls/comments/243933113","pull_request_review_id":187817140,"id":243933113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzkzMzExMw==","diff_hunk":"@@ -6,17 +6,28 @@\n //%deps(i2c)\n \n #include <stdint.h> // uint8_t etc\n+#include <string>\n \n #include \"embedded/pwm_driver/pwm_driver.hh\"\n #include \"third_party/i2c/i2c.h\"\n \n \n class ServoDriver {\n public:\n-\tServoDriver(char* dev);\n+\tServoDriver(const int channel, PwmDriver &driver, const std::string &config_path);\n \tint init();\n-\tvoid set_percentage(int channel, int percentage);\n+\tvoid set_percentage(int percentage);\n+\tint get_percentage() const;\n+\tvoid set_calibrated_angle(float angle);\n \n private:\n-        PwmDriver pwm_driver_;\n+\tint channel_;\n+        PwmDriver &pwm_driver_;\n+        std::string config_path_;\n+\t// The percentage corresponding to max angle.\n+\tint calibrated_max_;\n+\t// The percentage corresponding to zero angle.","path":"embedded/servo_driver/servo_driver.hh","position":27,"original_position":27,"commit_id":"76f8890eaf084fe3a97e6d66ab590659b2afb681","original_commit_id":"76f8890eaf084fe3a97e6d66ab590659b2afb681","user":{"login":"theicfire","id":442311,"node_id":"MDQ6VXNlcjQ0MjMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/442311?v=4","gravatar_id":"","url":"https://api.github.com/users/theicfire","html_url":"https://github.com/theicfire","followers_url":"https://api.github.com/users/theicfire/followers","following_url":"https://api.github.com/users/theicfire/following{/other_user}","gists_url":"https://api.github.com/users/theicfire/gists{/gist_id}","starred_url":"https://api.github.com/users/theicfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theicfire/subscriptions","organizations_url":"https://api.github.com/users/theicfire/orgs","repos_url":"https://api.github.com/users/theicfire/repos","events_url":"https://api.github.com/users/theicfire/events{/privacy}","received_events_url":"https://api.github.com/users/theicfire/received_events","type":"User","site_admin":false},"body":"center angle","created_at":"2018-12-26T02:35:28Z","updated_at":"2018-12-26T02:38:29Z","html_url":"https://github.com/build-week/hover-jet/pull/9#discussion_r243933113","pull_request_url":"https://api.github.com/repos/build-week/hover-jet/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/comments/243933113"},"html":{"href":"https://github.com/build-week/hover-jet/pull/9#discussion_r243933113"},"pull_request":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/build-week/hover-jet/pulls/9","id":240904315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTA0MzE1","html_url":"https://github.com/build-week/hover-jet/pull/9","diff_url":"https://github.com/build-week/hover-jet/pull/9.diff","patch_url":"https://github.com/build-week/hover-jet/pull/9.patch","issue_url":"https://api.github.com/repos/build-week/hover-jet/issues/9","number":9,"state":"open","locked":false,"title":"Add servo calibration!","user":{"login":"theicfire","id":442311,"node_id":"MDQ6VXNlcjQ0MjMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/442311?v=4","gravatar_id":"","url":"https://api.github.com/users/theicfire","html_url":"https://github.com/theicfire","followers_url":"https://api.github.com/users/theicfire/followers","following_url":"https://api.github.com/users/theicfire/following{/other_user}","gists_url":"https://api.github.com/users/theicfire/gists{/gist_id}","starred_url":"https://api.github.com/users/theicfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theicfire/subscriptions","organizations_url":"https://api.github.com/users/theicfire/orgs","repos_url":"https://api.github.com/users/theicfire/repos","events_url":"https://api.github.com/users/theicfire/events{/privacy}","received_events_url":"https://api.github.com/users/theicfire/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-26T02:32:26Z","updated_at":"2018-12-26T02:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7cb52262f1e8c2d3935ccb76ebb62b74a82bfca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/build-week/hover-jet/pulls/9/commits","review_comments_url":"https://api.github.com/repos/build-week/hover-jet/pulls/9/comments","review_comment_url":"https://api.github.com/repos/build-week/hover-jet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/build-week/hover-jet/issues/9/comments","statuses_url":"https://api.github.com/repos/build-week/hover-jet/statuses/76f8890eaf084fe3a97e6d66ab590659b2afb681","head":{"label":"build-week:chase/servo-calibrate","ref":"chase/servo-calibrate","sha":"76f8890eaf084fe3a97e6d66ab590659b2afb681","user":{"login":"build-week","id":44932304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTMyMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/44932304?v=4","gravatar_id":"","url":"https://api.github.com/users/build-week","html_url":"https://github.com/build-week","followers_url":"https://api.github.com/users/build-week/followers","following_url":"https://api.github.com/users/build-week/following{/other_user}","gists_url":"https://api.github.com/users/build-week/gists{/gist_id}","starred_url":"https://api.github.com/users/build-week/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-week/subscriptions","organizations_url":"https://api.github.com/users/build-week/orgs","repos_url":"https://api.github.com/users/build-week/repos","events_url":"https://api.github.com/users/build-week/events{/privacy}","received_events_url":"https://api.github.com/users/build-week/received_events","type":"Organization","site_admin":false},"repo":{"id":157023341,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwMjMzNDE=","name":"hover-jet","full_name":"build-week/hover-jet","private":false,"owner":{"login":"build-week","id":44932304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTMyMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/44932304?v=4","gravatar_id":"","url":"https://api.github.com/users/build-week","html_url":"https://github.com/build-week","followers_url":"https://api.github.com/users/build-week/followers","following_url":"https://api.github.com/users/build-week/following{/other_user}","gists_url":"https://api.github.com/users/build-week/gists{/gist_id}","starred_url":"https://api.github.com/users/build-week/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-week/subscriptions","organizations_url":"https://api.github.com/users/build-week/orgs","repos_url":"https://api.github.com/users/build-week/repos","events_url":"https://api.github.com/users/build-week/events{/privacy}","received_events_url":"https://api.github.com/users/build-week/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/build-week/hover-jet","description":"Control code for Mr. Jet","fork":false,"url":"https://api.github.com/repos/build-week/hover-jet","forks_url":"https://api.github.com/repos/build-week/hover-jet/forks","keys_url":"https://api.github.com/repos/build-week/hover-jet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/build-week/hover-jet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/build-week/hover-jet/teams","hooks_url":"https://api.github.com/repos/build-week/hover-jet/hooks","issue_events_url":"https://api.github.com/repos/build-week/hover-jet/issues/events{/number}","events_url":"https://api.github.com/repos/build-week/hover-jet/events","assignees_url":"https://api.github.com/repos/build-week/hover-jet/assignees{/user}","branches_url":"https://api.github.com/repos/build-week/hover-jet/branches{/branch}","tags_url":"https://api.github.com/repos/build-week/hover-jet/tags","blobs_url":"https://api.github.com/repos/build-week/hover-jet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/build-week/hover-jet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/build-week/hover-jet/git/refs{/sha}","trees_url":"https://api.github.com/repos/build-week/hover-jet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/build-week/hover-jet/statuses/{sha}","languages_url":"https://api.github.com/repos/build-week/hover-jet/languages","stargazers_url":"https://api.github.com/repos/build-week/hover-jet/stargazers","contributors_url":"https://api.github.com/repos/build-week/hover-jet/contributors","subscribers_url":"https://api.github.com/repos/build-week/hover-jet/subscribers","subscription_url":"https://api.github.com/repos/build-week/hover-jet/subscription","commits_url":"https://api.github.com/repos/build-week/hover-jet/commits{/sha}","git_commits_url":"https://api.github.com/repos/build-week/hover-jet/git/commits{/sha}","comments_url":"https://api.github.com/repos/build-week/hover-jet/comments{/number}","issue_comment_url":"https://api.github.com/repos/build-week/hover-jet/issues/comments{/number}","contents_url":"https://api.github.com/repos/build-week/hover-jet/contents/{+path}","compare_url":"https://api.github.com/repos/build-week/hover-jet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/build-week/hover-jet/merges","archive_url":"https://api.github.com/repos/build-week/hover-jet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/build-week/hover-jet/downloads","issues_url":"https://api.github.com/repos/build-week/hover-jet/issues{/number}","pulls_url":"https://api.github.com/repos/build-week/hover-jet/pulls{/number}","milestones_url":"https://api.github.com/repos/build-week/hover-jet/milestones{/number}","notifications_url":"https://api.github.com/repos/build-week/hover-jet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/build-week/hover-jet/labels{/name}","releases_url":"https://api.github.com/repos/build-week/hover-jet/releases{/id}","deployments_url":"https://api.github.com/repos/build-week/hover-jet/deployments","created_at":"2018-11-10T21:32:11Z","updated_at":"2018-12-25T00:26:44Z","pushed_at":"2018-12-26T02:34:22Z","git_url":"git://github.com/build-week/hover-jet.git","ssh_url":"git@github.com:build-week/hover-jet.git","clone_url":"https://github.com/build-week/hover-jet.git","svn_url":"https://github.com/build-week/hover-jet","homepage":null,"size":19197,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"build-week:master","ref":"master","sha":"06ee16a6fb8e5aa1b11932d19117a514e8b63959","user":{"login":"build-week","id":44932304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTMyMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/44932304?v=4","gravatar_id":"","url":"https://api.github.com/users/build-week","html_url":"https://github.com/build-week","followers_url":"https://api.github.com/users/build-week/followers","following_url":"https://api.github.com/users/build-week/following{/other_user}","gists_url":"https://api.github.com/users/build-week/gists{/gist_id}","starred_url":"https://api.github.com/users/build-week/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-week/subscriptions","organizations_url":"https://api.github.com/users/build-week/orgs","repos_url":"https://api.github.com/users/build-week/repos","events_url":"https://api.github.com/users/build-week/events{/privacy}","received_events_url":"https://api.github.com/users/build-week/received_events","type":"Organization","site_admin":false},"repo":{"id":157023341,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwMjMzNDE=","name":"hover-jet","full_name":"build-week/hover-jet","private":false,"owner":{"login":"build-week","id":44932304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTMyMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/44932304?v=4","gravatar_id":"","url":"https://api.github.com/users/build-week","html_url":"https://github.com/build-week","followers_url":"https://api.github.com/users/build-week/followers","following_url":"https://api.github.com/users/build-week/following{/other_user}","gists_url":"https://api.github.com/users/build-week/gists{/gist_id}","starred_url":"https://api.github.com/users/build-week/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-week/subscriptions","organizations_url":"https://api.github.com/users/build-week/orgs","repos_url":"https://api.github.com/users/build-week/repos","events_url":"https://api.github.com/users/build-week/events{/privacy}","received_events_url":"https://api.github.com/users/build-week/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/build-week/hover-jet","description":"Control code for Mr. Jet","fork":false,"url":"https://api.github.com/repos/build-week/hover-jet","forks_url":"https://api.github.com/repos/build-week/hover-jet/forks","keys_url":"https://api.github.com/repos/build-week/hover-jet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/build-week/hover-jet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/build-week/hover-jet/teams","hooks_url":"https://api.github.com/repos/build-week/hover-jet/hooks","issue_events_url":"https://api.github.com/repos/build-week/hover-jet/issues/events{/number}","events_url":"https://api.github.com/repos/build-week/hover-jet/events","assignees_url":"https://api.github.com/repos/build-week/hover-jet/assignees{/user}","branches_url":"https://api.github.com/repos/build-week/hover-jet/branches{/branch}","tags_url":"https://api.github.com/repos/build-week/hover-jet/tags","blobs_url":"https://api.github.com/repos/build-week/hover-jet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/build-week/hover-jet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/build-week/hover-jet/git/refs{/sha}","trees_url":"https://api.github.com/repos/build-week/hover-jet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/build-week/hover-jet/statuses/{sha}","languages_url":"https://api.github.com/repos/build-week/hover-jet/languages","stargazers_url":"https://api.github.com/repos/build-week/hover-jet/stargazers","contributors_url":"https://api.github.com/repos/build-week/hover-jet/contributors","subscribers_url":"https://api.github.com/repos/build-week/hover-jet/subscribers","subscription_url":"https://api.github.com/repos/build-week/hover-jet/subscription","commits_url":"https://api.github.com/repos/build-week/hover-jet/commits{/sha}","git_commits_url":"https://api.github.com/repos/build-week/hover-jet/git/commits{/sha}","comments_url":"https://api.github.com/repos/build-week/hover-jet/comments{/number}","issue_comment_url":"https://api.github.com/repos/build-week/hover-jet/issues/comments{/number}","contents_url":"https://api.github.com/repos/build-week/hover-jet/contents/{+path}","compare_url":"https://api.github.com/repos/build-week/hover-jet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/build-week/hover-jet/merges","archive_url":"https://api.github.com/repos/build-week/hover-jet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/build-week/hover-jet/downloads","issues_url":"https://api.github.com/repos/build-week/hover-jet/issues{/number}","pulls_url":"https://api.github.com/repos/build-week/hover-jet/pulls{/number}","milestones_url":"https://api.github.com/repos/build-week/hover-jet/milestones{/number}","notifications_url":"https://api.github.com/repos/build-week/hover-jet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/build-week/hover-jet/labels{/name}","releases_url":"https://api.github.com/repos/build-week/hover-jet/releases{/id}","deployments_url":"https://api.github.com/repos/build-week/hover-jet/deployments","created_at":"2018-11-10T21:32:11Z","updated_at":"2018-12-25T00:26:44Z","pushed_at":"2018-12-26T02:34:22Z","git_url":"git://github.com/build-week/hover-jet.git","ssh_url":"git@github.com:build-week/hover-jet.git","clone_url":"https://github.com/build-week/hover-jet.git","svn_url":"https://github.com/build-week/hover-jet","homepage":null,"size":19197,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/9"},"html":{"href":"https://github.com/build-week/hover-jet/pull/9"},"issue":{"href":"https://api.github.com/repos/build-week/hover-jet/issues/9"},"comments":{"href":"https://api.github.com/repos/build-week/hover-jet/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/build-week/hover-jet/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/build-week/hover-jet/statuses/76f8890eaf084fe3a97e6d66ab590659b2afb681"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theicfire"}}