{"push_id":2659666800,"size":1,"distinct_size":1,"ref":"refs/heads/github-metadata","head":"b518cf737087ef60a0116bada4cafbf14df34169","before":"9036976a272645f141e5c2333b010a1e71f8cc9c","commits":[{"sha":"b518cf737087ef60a0116bada4cafbf14df34169","author":{"name":"datakit","email":"5bd935e108be9555d53920ea0b07d36ecc398058@mobyproject.org"},"message":"28 items modified \nUpdated\n{linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]}\n{linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]}\n{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed}\n{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}\n{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}\n{linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}\n{linuxkit/linuxkit aed5328d2be616efa6bacd728cee3cb693a1afbe:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/944?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!}\n{linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open \"Setup the bond interfaces with proper default routes\" \n[|0 TheOriginalAlex: \"We need to add the addresses first and then set the routes, that way if the priv\";\n  326737114 justincormack: \"re \\\"- How to verify it - Run on a Packet Type 0 server.\\\" you need to run on type\";\n  334149593 justincormack: \"@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a\";\n  344279607 justincormack: \"I am working on an updated version of this.\";\n  344383444 TheOriginalAlex: \"Sure!  Sorry, I haven't responded much.  Been busy.  Also, I got stuck on gettin\";\n  345272016 justincormack: \"@TheOriginalAlex what problems were you seeing with the default gateway?\";\n  345429732 TheOriginalAlex: \"It just wasn't getting set.  If I printed the output of nsenter.RouteList, I cou\";\n  345674031 justincormack: \"Routes seemed to be working for me ok, but I need to rebase against the new meta\"|]}\n{linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open \"linuxkit bake\" \n[|0 w9n: \"When writing a moby yml I do not care about the container version and hashes (on\";\n  340192010 GordonTheTurtle: \"<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\\nPlease sign your commits following thes\";\n  340204660 rn: \"I don't understand the explanation for this PR (maybe I'm missing some context).\";\n  340224169 w9n: \"added some context to the description. \";\n  340241991 deitch: \"> When writing a moby yml I do not care about the container version and hashes (\";\n  340268573 w9n: \"i basically thought of a not buildable config\\r\\n```\\r\\nkernel:\\r\\n  image: linuxkit/k\";\n  340269095 deitch: \"So, is this basically a way of saying, \\\"for some packages, I want the latest ava\";\n  340269511 w9n: \"yep, but still create the immutable ymls so its reproducable what has been build\";\n  340269588 deitch: \"So rather than the usual moby `.yml`, it kind of is a moby \\\"template\\\" `.yml`, th\";\n  340269816 w9n: \"exactly. It would enable other possibilities as well as described above but ther\";\n  340269924 deitch: \"OK, I get it now; want to think it over somewhat. @rn had commented earlier; let\";\n  340270518 rn: \"This would be better done in the `moby` tool as it handles the build YAML files.\";\n  340271020 deitch: \"Ah yes, the `.mobytags` and overrides proposals.\\r\\n\\r\\n@w9n does that address the q\";\n  340273985 w9n: \"yes, it pretty much goes is in the right direction. I will read and think about \";\n  341074173 ijc: \"I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this \";\n  341552432 w9n: \"i didnt choose ```foo:latest``` because it can conflict with other contexts. But\";\n  352289887 w9n: \"Since moby became a dependency this works now depending on moby/tool#194 `linuxk\";\n  355176335 w9n: \"@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash\";\n  355233916 deitch: \"I remain torn on this. I think I still like the idea of having the ability to ta\";\n  355287913 w9n: \"> If I understand the implementation correctly, pkg collect would then look in l\";\n  355293548 ijc: \"> if a container has `<latest>` tag\\r\\n\\r\\nAre the angle-brackets (`<>`) literally p\";\n  355298378 w9n: \"> Are the angle-brackets (<>) literally part of the tag here or just \\\"syntax\\\"?\\r\\n\";\n  355304180 deitch: \"> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par\";\n  355307237 w9n: \"> Are there 2 distinct behaviours?\\r\\n\\r\\nThere is `linuxkit pkg collect --pkgroot` \";\n  355310745 deitch: \"> there is linuxkit build -collect which pre-processes and directly outputs the \";\n  355311332 rn: \"`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. \";\n  355313071 deitch: \"> linuxkit pkg collect seems a misnomer as it is not an operation on a package\\r\\n\";\n  355314861 rn: \"> Yes, but I could see how you might want a convenience of a single step.\\r\\n\\r\\nYou\";\n  355316644 deitch: \">  I really do not want linuxkit build to do too much magic. It should just buil\";\n  355316963 deitch: \"On second thought, I guess I can see it. `lkt` already contains all of the code \";\n  355318030 rn: \"sure, this can be done with a shell script. `grep` image patterns and `linuxkit \";\n  355321845 ijc: \"> You get a \\\"single\\\" step with linuxkit tranform | linuxkit build -. I really do\";\n  355347992 w9n: \"dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m\";\n  355446448 rn: \"`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t\";\n  355491579 deitch: \">  I think generate is my favourite\\r\\n\\r\\nI like it too. My only concern is that, t\";\n  355491607 deitch: \"Or perhaps `lkt template`?\";\n  355492212 w9n: \"generate sounds good but dont mind changing.\\r\\n\\r\\nChanged to `linuxkit generate --\";\n  355530363 rn: \"@w9n thanks for the quick change, I have a few comments on the implementation it\";\n  355535990 ijc: \"> then a new `linuxkit build` command \\r\\n\\r\\nITYM `linuxkit generate`? Not mad enam\";\n  355538317 ijc: \"> My only concern is whether or not there is some existing YAML templating synta\";\n  355540809 deitch: \"> Couldn't find anything\\r\\n  \\r\\nYeah, I had that issue a while ago. Ended up writi\";\n  355540982 deitch: \"> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba\";\n  355567882 w9n: \"> you shouldn't need to add anything to pkglib. This is a new top level command \";\n  355569715 w9n: \"bake & build would kind of short and precisely describe whats going on and actua\";\n  355570963 ijc: \"> the git methods are not public \\r\\n\\r\\nYou appear to be using them to reimplement \";\n  355572091 w9n: \"Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work\";\n  355574550 ijc: \"Where/why does this code need to deal with old hashes?\\r\\n\\r\\nGenerating the hash co\";\n  355577199 w9n: \"if there is\\r\\n```\\r\\ntags:\\r\\n  - name: <2.1>\\r\\n    hash: bb0c6ae2f12a1b55df24ebce2067\";\n  355577929 rn: \"Can we address one issue at a time. templating of the YAML file is one thing and\";\n  355579842 ijc: \"You can already get the package hash from a git tag today already, it's currentl\";\n  355656944 w9n: \"I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi\";\n  355967540 ijc: \"> I made pkgInfo public \\r\\n\\r\\nI don't like this, sorry. This struct should remain \";\n  356205605 w9n: \"@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu\";\n  356250551 ijc: \"You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h\";\n  356256042 w9n: \"done\";\n  356556345 w9n: \"so i rethought this and the whole templating problem might just not fit into lin\";\n  356567368 ijc: \"I don't think there are objections to templating in general, my specific objecti\";\n  356571088 w9n: \"If git tags or parameter like `foo=abcdef` are used than this would require e.g.\";\n  356572786 ijc: \"We intend to release linuxkit as a whole, with a single consistent set of packag\";\n  356576666 rn: \"I agree with @ijc that we do want some templating. We had several discussions in\";\n  356579465 justincormack: \"I don't understand what the output of `linuxkit bake example/linuxkit_template.y\";\n  356581808 ijc: \"It's a new file which you can pass to `linuxkit build` (after archiving it for r\";\n  356582385 justincormack: \"Does it output to stdout or what? This needs to be documented properly.\";\n  356582717 w9n: \"Okay, so I could live with this somewhere:\\r\\n```\\r\\ntags:\\r\\n    - name: v1.0\\r\\n      \";\n  356585190 rn: \"@w9n please read my comment https://github.com/linuxkit/linuxkit/pull/2648#issue\";\n  356587899 w9n: \"> Do you have an example for a baked YAML file. It would be useful if it would c\";\n  356589814 w9n: \"i dont really trust the test time, something must be wrong...\\r\\n```\\r\\n[+ 24m 58s] \";\n  356647166 w9n: \"@ijc \\r\\n```\\r\\nlinuxkit bake -D foo=abcdef foo.yml\\r\\n```\\r\\nThis can actually be done \";\n  356922250 w9n: \"updated the last comment, otherwise i guess i should revert setting global confi\";\n  357164648 w9n: \"Sorry for all these changes\\r\\n - dropped putting GlobalConfig in its own namespac\";\n  357425907 w9n: \"```\\r\\n[+ 24m 27s] [PASS    ] linuxkit.build.examples.bake 32.57s\\r\\n```\\r\\n\\r\\nfixed te\"|]}\n{linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca}\n{linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} \nRemoved  {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a}\n{linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076}\n{linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651}\n{linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6}\n{linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f}\n{linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994}\n{linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3}\n{linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf}\n{linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0}\n{linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c}\n{linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161}\n{linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d}\n{linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3}\n{linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f}\n{linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3}\n{linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024}\n{linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2}","distinct":true,"url":"https://api.github.com/repos/linuxkit/linuxkit-logs/commits/b518cf737087ef60a0116bada4cafbf14df34169"}]}
{"actor":{"display_login":"datakit"}}