{"action":"created","issue":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/750","repository_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/750/comments","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/750/events","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/750","id":285973753,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYxMTE1MDgz","number":750,"title":"Fixing https://github.com/wso2/product-is/issues/1951","user":{"login":"SachithUd","id":29328630,"node_id":"MDQ6VXNlcjI5MzI4NjMw","avatar_url":"https://avatars2.githubusercontent.com/u/29328630?v=4","gravatar_id":"","url":"https://api.github.com/users/SachithUd","html_url":"https://github.com/SachithUd","followers_url":"https://api.github.com/users/SachithUd/followers","following_url":"https://api.github.com/users/SachithUd/following{/other_user}","gists_url":"https://api.github.com/users/SachithUd/gists{/gist_id}","starred_url":"https://api.github.com/users/SachithUd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SachithUd/subscriptions","organizations_url":"https://api.github.com/users/SachithUd/orgs","repos_url":"https://api.github.com/users/SachithUd/repos","events_url":"https://api.github.com/users/SachithUd/events{/privacy}","received_events_url":"https://api.github.com/users/SachithUd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-04T12:38:49Z","updated_at":"2018-09-20T03:47:16Z","closed_at":"2018-09-20T03:47:16Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/750","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/750","diff_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/750.diff","patch_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/750.patch"},"body":"### Proposed changes in this pull request\r\n\r\n[List all changes you want to add here. If you fixed an issue, please\r\nadd a reference to that issue as well.]\r\n\r\n-\r\n\r\n### When should this PR be merged\r\n\r\n[Please describe any preconditions that need to be addressed before we\r\ncan merge this pull request.]\r\n\r\n\r\n### Follow up actions\r\n\r\n[List any possible follow-up actions here; for instance, testing data\r\nmigrations, software that we need to install on staging and production\r\nenvironments.]\r\n\r\n-\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n"},"comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/comments/423030955","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/750#issuecomment-423030955","issue_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/750","id":423030955,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzAzMDk1NQ==","user":{"login":"thanujalk","id":1498339,"node_id":"MDQ6VXNlcjE0OTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1498339?v=4","gravatar_id":"","url":"https://api.github.com/users/thanujalk","html_url":"https://github.com/thanujalk","followers_url":"https://api.github.com/users/thanujalk/followers","following_url":"https://api.github.com/users/thanujalk/following{/other_user}","gists_url":"https://api.github.com/users/thanujalk/gists{/gist_id}","starred_url":"https://api.github.com/users/thanujalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanujalk/subscriptions","organizations_url":"https://api.github.com/users/thanujalk/orgs","repos_url":"https://api.github.com/users/thanujalk/repos","events_url":"https://api.github.com/users/thanujalk/events{/privacy}","received_events_url":"https://api.github.com/users/thanujalk/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T03:47:16Z","updated_at":"2018-09-20T03:47:16Z","author_association":"CONTRIBUTOR","body":"Fix is incomplete."}}
{"actor":{"display_login":"thanujalk"}}