{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/204501738","pull_request_review_id":139590617,"id":204501738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDUwMTczOA==","diff_hunk":"@@ -5,39 +5,29 @@ def http_login(username = 'username', password = 'password')\n         request.env['HTTP_AUTHORIZATION'] = ActionController::HttpAuthentication::Basic.encode_credentials(username, password)\n       end\n \n-      def login_as(user)\n+      def login_as(user, stub_controller: false)\n         User.current_user = user\n+        puts \"WARNING: double stubbing user - only use login_as or stub_user once\" if user != User.current_user\n         session[:userid]  = user.userid\n         session[:group]   = user.current_group_id\n+        allow(controller).to receive(:current_user).and_return(user) if stub_controller\n         user\n       end\n \n-      # TODO: Stub specific features, document use\n-      def stub_user(features:, user: FactoryGirl.build(:user_with_group))\n-        allow(controller).to receive(:current_user).and_return(user)\n-        allow(User).to receive(:current_user).and_return(user)\n+      # Stubs the user in context for a controller\n+      # @param features (:all|:none|Array<>,String,Symbol) features for a user","path":"spec/support/auth_helper.rb","position":19,"original_position":19,"commit_id":"5b77924d85234e002724d52405f18e76663dd9e1","original_commit_id":"72e4160d3d51e22ae8fc8fc85448420a283d2580","user":{"login":"kbrock","id":1930,"node_id":"MDQ6VXNlcjE5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1930?v=4","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"a) I would like to `s/all/everything` in a future PR. it is in many repos.\r\nb) `:none` seems to work very well. It creates all the joining models. The user ends up with feature(s), just features that aren't ones that affect us","created_at":"2018-07-23T18:06:02Z","updated_at":"2018-07-23T18:06:02Z","html_url":"https://github.com/ManageIQ/manageiq/pull/17575#discussion_r204501738","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/204501738"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17575#discussion_r204501738"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575"}},"in_reply_to_id":195156281},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575","id":194640740,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjQwNzQw","html_url":"https://github.com/ManageIQ/manageiq/pull/17575","diff_url":"https://github.com/ManageIQ/manageiq/pull/17575.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17575.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17575","number":17575,"state":"open","locked":false,"title":"remove most of test authentication stubbing","user":{"login":"kbrock","id":1930,"node_id":"MDQ6VXNlcjE5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1930?v=4","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"If we have fewer stubs, then we are testing more code and we are encouraged to pay attention to roles/miq_product_features and authorization.\r\n\r\nI can see the argument that this makes it more or less stable.\r\nSo I'm putting it out there and seeing what others thing.\r\n\r\nI just ran master classic-ui and all tests passed locally\r\n@himdel - thoughts?","created_at":"2018-06-13T16:12:29Z","updated_at":"2018-07-23T18:06:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33c3c7ad8e73fc62c922cfabaec7a45a834b79ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":124903180,"node_id":"MDU6TGFiZWwxMjQ5MDMxODA=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/test","name":"test","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17575/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5b77924d85234e002724d52405f18e76663dd9e1","head":{"label":"kbrock:authentication_helper_stubless","ref":"authentication_helper_stubless","sha":"5b77924d85234e002724d52405f18e76663dd9e1","user":{"login":"kbrock","id":1930,"node_id":"MDQ6VXNlcjE5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1930?v=4","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"repo":{"id":20886492,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NjQ5Mg==","name":"manageiq","full_name":"kbrock/manageiq","owner":{"login":"kbrock","id":1930,"node_id":"MDQ6VXNlcjE5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1930?v=4","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbrock/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/kbrock/manageiq","forks_url":"https://api.github.com/repos/kbrock/manageiq/forks","keys_url":"https://api.github.com/repos/kbrock/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbrock/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbrock/manageiq/teams","hooks_url":"https://api.github.com/repos/kbrock/manageiq/hooks","issue_events_url":"https://api.github.com/repos/kbrock/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/kbrock/manageiq/events","assignees_url":"https://api.github.com/repos/kbrock/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/kbrock/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/kbrock/manageiq/tags","blobs_url":"https://api.github.com/repos/kbrock/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbrock/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbrock/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbrock/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbrock/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/kbrock/manageiq/languages","stargazers_url":"https://api.github.com/repos/kbrock/manageiq/stargazers","contributors_url":"https://api.github.com/repos/kbrock/manageiq/contributors","subscribers_url":"https://api.github.com/repos/kbrock/manageiq/subscribers","subscription_url":"https://api.github.com/repos/kbrock/manageiq/subscription","commits_url":"https://api.github.com/repos/kbrock/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbrock/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbrock/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbrock/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbrock/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/kbrock/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbrock/manageiq/merges","archive_url":"https://api.github.com/repos/kbrock/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbrock/manageiq/downloads","issues_url":"https://api.github.com/repos/kbrock/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/kbrock/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/kbrock/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/kbrock/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbrock/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/kbrock/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/kbrock/manageiq/deployments","created_at":"2014-06-16T13:49:17Z","updated_at":"2018-06-13T16:14:04Z","pushed_at":"2018-07-13T20:38:29Z","git_url":"git://github.com/kbrock/manageiq.git","ssh_url":"git@github.com:kbrock/manageiq.git","clone_url":"https://github.com/kbrock/manageiq.git","svn_url":"https://github.com/kbrock/manageiq","homepage":null,"size":217580,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"84bec63df47fd680bd2d9b35b0bdc7cf913caa8f","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4OTc1Nw==","name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2018-07-20T17:59:47Z","pushed_at":"2018-07-23T17:51:56Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":254873,"stargazers_count":679,"watchers_count":679,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":651,"mirror_url":null,"archived":false,"open_issues_count":606,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":651,"open_issues":606,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17575"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17575"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17575/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17575/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5b77924d85234e002724d52405f18e76663dd9e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kbrock"}}