{"action":"created","issue":{"url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/5","repository_url":"https://api.github.com/repos/kristapsdz/kwebapp","labels_url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/5/comments","events_url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/5/events","html_url":"https://github.com/kristapsdz/kwebapp/issues/5","id":308779512,"number":5,"title":"Generated db.c is missing kcgi include","user":{"login":"mbucc","id":85849,"avatar_url":"https://avatars2.githubusercontent.com/u/85849?v=4","gravatar_id":"","url":"https://api.github.com/users/mbucc","html_url":"https://github.com/mbucc","followers_url":"https://api.github.com/users/mbucc/followers","following_url":"https://api.github.com/users/mbucc/following{/other_user}","gists_url":"https://api.github.com/users/mbucc/gists{/gist_id}","starred_url":"https://api.github.com/users/mbucc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbucc/subscriptions","organizations_url":"https://api.github.com/users/mbucc/orgs","repos_url":"https://api.github.com/users/mbucc/repos","events_url":"https://api.github.com/users/mbucc/events{/privacy}","received_events_url":"https://api.github.com/users/mbucc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-27T00:23:20Z","updated_at":"2018-03-29T03:48:31Z","closed_at":"2018-03-29T03:47:34Z","author_association":"NONE","body":"My C is a bit rusty, but I think this may be an issue.  If I generate c header and code with the -j option, the generated db.c does not include kcgi.h.  The compile fails with errors like this:\r\n\r\n```\r\nenum kcgi_err   kjson_open(struct kjsonreq *, struct kreq *);\r\n                                                     ^\r\ndb.c:168:2: error: calling 'kjson_putintp' with incomplete return type 'enum kcgi_err'\r\n        kjson_putintp(r, \"id\", p->id);\r\n        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/usr/local/include/kcgijson.h:61:15: note: 'kjson_putintp' declared here\r\n```\r\n\r\nApplying this patch to the generated db.c makes the compile succeed:\r\n\r\n```\r\n--- db.c.orig   Mon Mar 26 16:10:55 2018\r\n+++ db.c        Mon Mar 26 16:12:00 2018\r\n@@ -10,6 +10,7 @@\r\n #include <string.h>\r\n #include <unistd.h>\r\n \r\n+#include <kcgi.h>\r\n #include <ksql.h>\r\n #include <kcgijson.h>\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/comments/377112522","html_url":"https://github.com/kristapsdz/kwebapp/issues/5#issuecomment-377112522","issue_url":"https://api.github.com/repos/kristapsdz/kwebapp/issues/5","id":377112522,"user":{"login":"kristapsdz","id":884382,"avatar_url":"https://avatars1.githubusercontent.com/u/884382?v=4","gravatar_id":"","url":"https://api.github.com/users/kristapsdz","html_url":"https://github.com/kristapsdz","followers_url":"https://api.github.com/users/kristapsdz/followers","following_url":"https://api.github.com/users/kristapsdz/following{/other_user}","gists_url":"https://api.github.com/users/kristapsdz/gists{/gist_id}","starred_url":"https://api.github.com/users/kristapsdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristapsdz/subscriptions","organizations_url":"https://api.github.com/users/kristapsdz/orgs","repos_url":"https://api.github.com/users/kristapsdz/repos","events_url":"https://api.github.com/users/kristapsdz/events{/privacy}","received_events_url":"https://api.github.com/users/kristapsdz/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T03:48:31Z","updated_at":"2018-03-29T03:48:31Z","author_association":"OWNER","body":"Thank you!  Fixed, and will appear in the next release."}}
{"actor":{"display_login":"kristapsdz"}}