{"action":"closed","number":296,"pull_request":{"url":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296","id":196604438,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjA0NDM4","html_url":"https://github.com/YottaDB/YottaDB/pull/296","diff_url":"https://github.com/YottaDB/YottaDB/pull/296.diff","patch_url":"https://github.com/YottaDB/YottaDB/pull/296.patch","issue_url":"https://api.github.com/repos/YottaDB/YottaDB/issues/296","number":296,"state":"closed","locked":false,"title":"[#295] ZSTEP inside trigger should be ignored completely if TRIGGER_MOD restriction is in place","user":{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false},"body":"GTM-8842 fixed this issue in GT.M V6.3-003 but the fix seems incorrect. The change was\r\ndone in op_set_zbreak() to return if we are inside a trigger. But by the time op_set_zbreak()\r\nis invoked, the transfer table has already been changed by op_zstep.c in preparation for\r\nthe ZSTEP action. This undo happens much later when op_set_zbreak() is called after we\r\nfinish executing the trigger at which point, the current $ZSTEP action is executed too.\r\nThis is an unintended side effect which is considered incorrect. A ZSTEP action which was\r\nignored while inside a trigger should continue to be ignored after exiting the trigger too.\r\n\r\nThe fix is to remove the change done in op_set_zbreak() but move that check to op_zstep.c\r\nso we do not do any transfer table change while inside a trigger and if TRIGGER_MOD restriction\r\nis currently on. This change to op_zstep.c mirrors a change to op_zbreak.c done as part of\r\nGTM-8842.","created_at":"2018-06-21T23:43:25Z","updated_at":"2018-06-22T16:14:18Z","closed_at":"2018-06-22T16:14:18Z","merged_at":"2018-06-22T16:14:18Z","merge_commit_sha":"f29aaebf9fa2e80087ed2dc06dc63991ed0eb5e8","assignee":{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false},"assignees":[{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296/commits","review_comments_url":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296/comments","review_comment_url":"https://api.github.com/repos/YottaDB/YottaDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YottaDB/YottaDB/issues/296/comments","statuses_url":"https://api.github.com/repos/YottaDB/YottaDB/statuses/089c53067beb07e4b6d2b6014cd0ddc2ac4801d5","head":{"label":"nars1:zstep","ref":"zstep","sha":"089c53067beb07e4b6d2b6014cd0ddc2ac4801d5","user":{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false},"repo":{"id":96138855,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzODg1NQ==","name":"YottaDB","full_name":"nars1/YottaDB","owner":{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nars1/YottaDB","description":null,"fork":true,"url":"https://api.github.com/repos/nars1/YottaDB","forks_url":"https://api.github.com/repos/nars1/YottaDB/forks","keys_url":"https://api.github.com/repos/nars1/YottaDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nars1/YottaDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nars1/YottaDB/teams","hooks_url":"https://api.github.com/repos/nars1/YottaDB/hooks","issue_events_url":"https://api.github.com/repos/nars1/YottaDB/issues/events{/number}","events_url":"https://api.github.com/repos/nars1/YottaDB/events","assignees_url":"https://api.github.com/repos/nars1/YottaDB/assignees{/user}","branches_url":"https://api.github.com/repos/nars1/YottaDB/branches{/branch}","tags_url":"https://api.github.com/repos/nars1/YottaDB/tags","blobs_url":"https://api.github.com/repos/nars1/YottaDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nars1/YottaDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nars1/YottaDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/nars1/YottaDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nars1/YottaDB/statuses/{sha}","languages_url":"https://api.github.com/repos/nars1/YottaDB/languages","stargazers_url":"https://api.github.com/repos/nars1/YottaDB/stargazers","contributors_url":"https://api.github.com/repos/nars1/YottaDB/contributors","subscribers_url":"https://api.github.com/repos/nars1/YottaDB/subscribers","subscription_url":"https://api.github.com/repos/nars1/YottaDB/subscription","commits_url":"https://api.github.com/repos/nars1/YottaDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/nars1/YottaDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/nars1/YottaDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/nars1/YottaDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/nars1/YottaDB/contents/{+path}","compare_url":"https://api.github.com/repos/nars1/YottaDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nars1/YottaDB/merges","archive_url":"https://api.github.com/repos/nars1/YottaDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nars1/YottaDB/downloads","issues_url":"https://api.github.com/repos/nars1/YottaDB/issues{/number}","pulls_url":"https://api.github.com/repos/nars1/YottaDB/pulls{/number}","milestones_url":"https://api.github.com/repos/nars1/YottaDB/milestones{/number}","notifications_url":"https://api.github.com/repos/nars1/YottaDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nars1/YottaDB/labels{/name}","releases_url":"https://api.github.com/repos/nars1/YottaDB/releases{/id}","deployments_url":"https://api.github.com/repos/nars1/YottaDB/deployments","created_at":"2017-07-03T18:23:13Z","updated_at":"2018-06-21T21:23:47Z","pushed_at":"2018-06-21T23:38:54Z","git_url":"git://github.com/nars1/YottaDB.git","ssh_url":"git@github.com:nars1/YottaDB.git","clone_url":"https://github.com/nars1/YottaDB.git","svn_url":"https://github.com/nars1/YottaDB","homepage":null,"size":18745,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"YottaDB:master","ref":"master","sha":"9f46e54cd622e95327b108903c365d53384a8c6f","user":{"login":"YottaDB","id":29870125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODcwMTI1","avatar_url":"https://avatars0.githubusercontent.com/u/29870125?v=4","gravatar_id":"","url":"https://api.github.com/users/YottaDB","html_url":"https://github.com/YottaDB","followers_url":"https://api.github.com/users/YottaDB/followers","following_url":"https://api.github.com/users/YottaDB/following{/other_user}","gists_url":"https://api.github.com/users/YottaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/YottaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YottaDB/subscriptions","organizations_url":"https://api.github.com/users/YottaDB/orgs","repos_url":"https://api.github.com/users/YottaDB/repos","events_url":"https://api.github.com/users/YottaDB/events{/privacy}","received_events_url":"https://api.github.com/users/YottaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":96138741,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzODc0MQ==","name":"YottaDB","full_name":"YottaDB/YottaDB","owner":{"login":"YottaDB","id":29870125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODcwMTI1","avatar_url":"https://avatars0.githubusercontent.com/u/29870125?v=4","gravatar_id":"","url":"https://api.github.com/users/YottaDB","html_url":"https://github.com/YottaDB","followers_url":"https://api.github.com/users/YottaDB/followers","following_url":"https://api.github.com/users/YottaDB/following{/other_user}","gists_url":"https://api.github.com/users/YottaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/YottaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YottaDB/subscriptions","organizations_url":"https://api.github.com/users/YottaDB/orgs","repos_url":"https://api.github.com/users/YottaDB/repos","events_url":"https://api.github.com/users/YottaDB/events{/privacy}","received_events_url":"https://api.github.com/users/YottaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YottaDB/YottaDB","description":null,"fork":false,"url":"https://api.github.com/repos/YottaDB/YottaDB","forks_url":"https://api.github.com/repos/YottaDB/YottaDB/forks","keys_url":"https://api.github.com/repos/YottaDB/YottaDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YottaDB/YottaDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YottaDB/YottaDB/teams","hooks_url":"https://api.github.com/repos/YottaDB/YottaDB/hooks","issue_events_url":"https://api.github.com/repos/YottaDB/YottaDB/issues/events{/number}","events_url":"https://api.github.com/repos/YottaDB/YottaDB/events","assignees_url":"https://api.github.com/repos/YottaDB/YottaDB/assignees{/user}","branches_url":"https://api.github.com/repos/YottaDB/YottaDB/branches{/branch}","tags_url":"https://api.github.com/repos/YottaDB/YottaDB/tags","blobs_url":"https://api.github.com/repos/YottaDB/YottaDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YottaDB/YottaDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YottaDB/YottaDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/YottaDB/YottaDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YottaDB/YottaDB/statuses/{sha}","languages_url":"https://api.github.com/repos/YottaDB/YottaDB/languages","stargazers_url":"https://api.github.com/repos/YottaDB/YottaDB/stargazers","contributors_url":"https://api.github.com/repos/YottaDB/YottaDB/contributors","subscribers_url":"https://api.github.com/repos/YottaDB/YottaDB/subscribers","subscription_url":"https://api.github.com/repos/YottaDB/YottaDB/subscription","commits_url":"https://api.github.com/repos/YottaDB/YottaDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/YottaDB/YottaDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/YottaDB/YottaDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/YottaDB/YottaDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/YottaDB/YottaDB/contents/{+path}","compare_url":"https://api.github.com/repos/YottaDB/YottaDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YottaDB/YottaDB/merges","archive_url":"https://api.github.com/repos/YottaDB/YottaDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YottaDB/YottaDB/downloads","issues_url":"https://api.github.com/repos/YottaDB/YottaDB/issues{/number}","pulls_url":"https://api.github.com/repos/YottaDB/YottaDB/pulls{/number}","milestones_url":"https://api.github.com/repos/YottaDB/YottaDB/milestones{/number}","notifications_url":"https://api.github.com/repos/YottaDB/YottaDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YottaDB/YottaDB/labels{/name}","releases_url":"https://api.github.com/repos/YottaDB/YottaDB/releases{/id}","deployments_url":"https://api.github.com/repos/YottaDB/YottaDB/deployments","created_at":"2017-07-03T18:21:23Z","updated_at":"2018-06-21T20:28:32Z","pushed_at":"2018-06-22T16:14:17Z","git_url":"git://github.com/YottaDB/YottaDB.git","ssh_url":"git@github.com:YottaDB/YottaDB.git","clone_url":"https://github.com/YottaDB/YottaDB.git","svn_url":"https://github.com/YottaDB/YottaDB","homepage":null,"size":18692,"stargazers_count":24,"watchers_count":24,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":56,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296"},"html":{"href":"https://github.com/YottaDB/YottaDB/pull/296"},"issue":{"href":"https://api.github.com/repos/YottaDB/YottaDB/issues/296"},"comments":{"href":"https://api.github.com/repos/YottaDB/YottaDB/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/YottaDB/YottaDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YottaDB/YottaDB/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/YottaDB/YottaDB/statuses/089c53067beb07e4b6d2b6014cd0ddc2ac4801d5"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nars1","id":28790583,"node_id":"MDQ6VXNlcjI4NzkwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/28790583?v=4","gravatar_id":"","url":"https://api.github.com/users/nars1","html_url":"https://github.com/nars1","followers_url":"https://api.github.com/users/nars1/followers","following_url":"https://api.github.com/users/nars1/following{/other_user}","gists_url":"https://api.github.com/users/nars1/gists{/gist_id}","starred_url":"https://api.github.com/users/nars1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nars1/subscriptions","organizations_url":"https://api.github.com/users/nars1/orgs","repos_url":"https://api.github.com/users/nars1/repos","events_url":"https://api.github.com/users/nars1/events{/privacy}","received_events_url":"https://api.github.com/users/nars1/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"nars1"}}