{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-releng/services/pulls/comments/192059044","pull_request_review_id":124755786,"id":192059044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjA1OTA0NA==","diff_hunk":"@@ -4,7 +4,7 @@\n let\n \n   inherit (releng_pkgs.lib) mkTaskclusterHook mkTaskclusterMergeEnv mkPython fromRequirementsFile filterSource ;\n-  inherit (releng_pkgs.pkgs) writeScript gcc cacert gcc-unwrapped glibc glibcLocales xorg patch nodejs git python27 python35 coreutils shellcheck clang_5 zlib;\n+  inherit (releng_pkgs.pkgs) writeScript gcc cacert gcc-unwrapped glibc glibcLocales xorg patch nodejs-8_x git python27 python35 coreutils shellcheck clang_5 zlib;","path":"src/shipit_static_analysis/default.nix","position":5,"original_position":5,"commit_id":"16660b3117a76eba22aac0bfc1d5eb1de8bf3f17","original_commit_id":"16660b3117a76eba22aac0bfc1d5eb1de8bf3f17","user":{"login":"garbas","id":20208,"node_id":"MDQ6VXNlcjIwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/20208?v=4","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},"body":"maybe it would make sense to create a new assigment where you assign `nodejs-8_x` to `nodejs`.\r\nthen you:\r\n   (1) wouldn't have change every mention of `nodejs`\r\n   (2) also later updates become much easier and maybe less possibility to make mistakes.\r\n\r\nabove is just a personal taste so nothing you really have to fix, but maybe a good suggestion.","created_at":"2018-05-31T10:46:37Z","updated_at":"2018-05-31T10:46:44Z","html_url":"https://github.com/mozilla-releng/services/pull/1194#discussion_r192059044","pull_request_url":"https://api.github.com/repos/mozilla-releng/services/pulls/1194","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/comments/192059044"},"html":{"href":"https://github.com/mozilla-releng/services/pull/1194#discussion_r192059044"},"pull_request":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/1194"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-releng/services/pulls/1194","id":191178897,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTc4ODk3","html_url":"https://github.com/mozilla-releng/services/pull/1194","diff_url":"https://github.com/mozilla-releng/services/pull/1194.diff","patch_url":"https://github.com/mozilla-releng/services/pull/1194.patch","issue_url":"https://api.github.com/repos/mozilla-releng/services/issues/1194","number":1194,"state":"open","locked":false,"title":"shipit-static-analysis: Upgrade nodejs version to 8.9.4, fixes #1193.","user":{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false},"body":"Fixes #1193.","created_at":"2018-05-29T15:08:03Z","updated_at":"2018-05-31T10:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf7dd8389f1594a62c2172cb2131a0eefbe6335","assignee":{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false},"assignees":[{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"marco-c","id":1616846,"node_id":"MDQ6VXNlcjE2MTY4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1616846?v=4","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":608460070,"node_id":"MDU6TGFiZWw2MDg0NjAwNzA=","url":"https://api.github.com/repos/mozilla-releng/services/labels/app:shipit_static_analysis","name":"app:shipit_static_analysis","color":"fbca04","default":false},{"id":522043195,"node_id":"MDU6TGFiZWw1MjIwNDMxOTU=","url":"https://api.github.com/repos/mozilla-releng/services/labels/kind:regression","name":"kind:regression","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-releng/services/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/mozilla-releng/services/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/mozilla-releng/services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-releng/services/issues/1194/comments","statuses_url":"https://api.github.com/repos/mozilla-releng/services/statuses/16660b3117a76eba22aac0bfc1d5eb1de8bf3f17","head":{"label":"La0:nodejs","ref":"nodejs","sha":"16660b3117a76eba22aac0bfc1d5eb1de8bf3f17","user":{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false},"repo":{"id":61881468,"node_id":"MDEwOlJlcG9zaXRvcnk2MTg4MTQ2OA==","name":"mozilla-relengapi","full_name":"La0/mozilla-relengapi","owner":{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/La0/mozilla-relengapi","description":"Your Interface to Release Engineering Automation -","fork":true,"url":"https://api.github.com/repos/La0/mozilla-relengapi","forks_url":"https://api.github.com/repos/La0/mozilla-relengapi/forks","keys_url":"https://api.github.com/repos/La0/mozilla-relengapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/La0/mozilla-relengapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/La0/mozilla-relengapi/teams","hooks_url":"https://api.github.com/repos/La0/mozilla-relengapi/hooks","issue_events_url":"https://api.github.com/repos/La0/mozilla-relengapi/issues/events{/number}","events_url":"https://api.github.com/repos/La0/mozilla-relengapi/events","assignees_url":"https://api.github.com/repos/La0/mozilla-relengapi/assignees{/user}","branches_url":"https://api.github.com/repos/La0/mozilla-relengapi/branches{/branch}","tags_url":"https://api.github.com/repos/La0/mozilla-relengapi/tags","blobs_url":"https://api.github.com/repos/La0/mozilla-relengapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/La0/mozilla-relengapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/La0/mozilla-relengapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/La0/mozilla-relengapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/La0/mozilla-relengapi/statuses/{sha}","languages_url":"https://api.github.com/repos/La0/mozilla-relengapi/languages","stargazers_url":"https://api.github.com/repos/La0/mozilla-relengapi/stargazers","contributors_url":"https://api.github.com/repos/La0/mozilla-relengapi/contributors","subscribers_url":"https://api.github.com/repos/La0/mozilla-relengapi/subscribers","subscription_url":"https://api.github.com/repos/La0/mozilla-relengapi/subscription","commits_url":"https://api.github.com/repos/La0/mozilla-relengapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/La0/mozilla-relengapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/La0/mozilla-relengapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/La0/mozilla-relengapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/La0/mozilla-relengapi/contents/{+path}","compare_url":"https://api.github.com/repos/La0/mozilla-relengapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/La0/mozilla-relengapi/merges","archive_url":"https://api.github.com/repos/La0/mozilla-relengapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/La0/mozilla-relengapi/downloads","issues_url":"https://api.github.com/repos/La0/mozilla-relengapi/issues{/number}","pulls_url":"https://api.github.com/repos/La0/mozilla-relengapi/pulls{/number}","milestones_url":"https://api.github.com/repos/La0/mozilla-relengapi/milestones{/number}","notifications_url":"https://api.github.com/repos/La0/mozilla-relengapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/La0/mozilla-relengapi/labels{/name}","releases_url":"https://api.github.com/repos/La0/mozilla-relengapi/releases{/id}","deployments_url":"https://api.github.com/repos/La0/mozilla-relengapi/deployments","created_at":"2016-06-24T11:59:18Z","updated_at":"2018-05-25T09:19:57Z","pushed_at":"2018-05-31T10:19:31Z","git_url":"git://github.com/La0/mozilla-relengapi.git","ssh_url":"git@github.com:La0/mozilla-relengapi.git","clone_url":"https://github.com/La0/mozilla-relengapi.git","svn_url":"https://github.com/La0/mozilla-relengapi","homepage":"https://api.pub.build.mozilla.org","size":59705,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-releng:master","ref":"master","sha":"250e630db9504ed80e16e8b2442f9527413c9ef8","user":{"login":"mozilla-releng","id":19614164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE0MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/19614164?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"repo":{"id":51109207,"node_id":"MDEwOlJlcG9zaXRvcnk1MTEwOTIwNw==","name":"services","full_name":"mozilla-releng/services","owner":{"login":"mozilla-releng","id":19614164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE0MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/19614164?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-releng/services","description":"Mozilla Release Engineering Services","fork":false,"url":"https://api.github.com/repos/mozilla-releng/services","forks_url":"https://api.github.com/repos/mozilla-releng/services/forks","keys_url":"https://api.github.com/repos/mozilla-releng/services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-releng/services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-releng/services/teams","hooks_url":"https://api.github.com/repos/mozilla-releng/services/hooks","issue_events_url":"https://api.github.com/repos/mozilla-releng/services/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-releng/services/events","assignees_url":"https://api.github.com/repos/mozilla-releng/services/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-releng/services/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-releng/services/tags","blobs_url":"https://api.github.com/repos/mozilla-releng/services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-releng/services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-releng/services/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-releng/services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-releng/services/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-releng/services/languages","stargazers_url":"https://api.github.com/repos/mozilla-releng/services/stargazers","contributors_url":"https://api.github.com/repos/mozilla-releng/services/contributors","subscribers_url":"https://api.github.com/repos/mozilla-releng/services/subscribers","subscription_url":"https://api.github.com/repos/mozilla-releng/services/subscription","commits_url":"https://api.github.com/repos/mozilla-releng/services/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-releng/services/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-releng/services/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-releng/services/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-releng/services/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-releng/services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-releng/services/merges","archive_url":"https://api.github.com/repos/mozilla-releng/services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-releng/services/downloads","issues_url":"https://api.github.com/repos/mozilla-releng/services/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-releng/services/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-releng/services/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-releng/services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-releng/services/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-releng/services/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-releng/services/deployments","created_at":"2016-02-04T22:07:22Z","updated_at":"2018-05-31T10:05:33Z","pushed_at":"2018-05-31T10:19:32Z","git_url":"git://github.com/mozilla-releng/services.git","ssh_url":"git@github.com:mozilla-releng/services.git","clone_url":"https://github.com/mozilla-releng/services.git","svn_url":"https://github.com/mozilla-releng/services","homepage":"https://mozilla-releng.net","size":63613,"stargazers_count":19,"watchers_count":19,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":214,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":68,"open_issues":214,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/1194"},"html":{"href":"https://github.com/mozilla-releng/services/pull/1194"},"issue":{"href":"https://api.github.com/repos/mozilla-releng/services/issues/1194"},"comments":{"href":"https://api.github.com/repos/mozilla-releng/services/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-releng/services/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-releng/services/statuses/16660b3117a76eba22aac0bfc1d5eb1de8bf3f17"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"garbas"}}