{"action":"created","comment":{"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/comments/244681573","pull_request_review_id":188609414,"id":244681573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY4MTU3Mw==","diff_hunk":"@@ -45,13 +42,24 @@ public String getTerminal() {\n \n \t@Override\n \tpublic Point getLocation(Point reference) {\n-\t\tRectangle body = lifelinebodyFigure.getBounds().getCopy();\n-\t\tlifelinebodyFigure.translateToAbsolute(body);\n-\t\tint boundedHeight = Math.min(distance, body.height);\n-\t\tint realHeight = (int)Math.round(boundedHeight * getScale(lifelinebodyFigure));\n-\t\tPoint location = new Point(0, realHeight);\n-\t\tlocation.translate(body.getTopLeft());\n-\t\treturn location;\n+\t\treturn getReferencePoint();\n+\t}\n+\n+\t@Override\n+\tpublic Point getReferencePoint() {\n+\t\tif (getOwner() == null) {","path":"plugins/org.eclipse.papyrus.uml.diagram.sequence.figure/src/org/eclipse/papyrus/uml/diagram/sequence/figure/anchors/LifelineBodyAnchor.java","position":34,"original_position":34,"commit_id":"f68469bb935bda8df3cca7c6318a0f981b195b42","original_commit_id":"f68469bb935bda8df3cca7c6318a0f981b195b42","user":{"login":"rschnekenbu","id":3964263,"node_id":"MDQ6VXNlcjM5NjQyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3964263?v=4","gravatar_id":"","url":"https://api.github.com/users/rschnekenbu","html_url":"https://github.com/rschnekenbu","followers_url":"https://api.github.com/users/rschnekenbu/followers","following_url":"https://api.github.com/users/rschnekenbu/following{/other_user}","gists_url":"https://api.github.com/users/rschnekenbu/gists{/gist_id}","starred_url":"https://api.github.com/users/rschnekenbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschnekenbu/subscriptions","organizations_url":"https://api.github.com/users/rschnekenbu/orgs","repos_url":"https://api.github.com/users/rschnekenbu/repos","events_url":"https://api.github.com/users/rschnekenbu/events{/privacy}","received_events_url":"https://api.github.com/users/rschnekenbu/received_events","type":"User","site_admin":false},"body":"I duplicated the behavior of the overridden method here. I did not encounter this case during testing.","created_at":"2019-01-02T08:44:45Z","updated_at":"2019-01-02T08:44:45Z","html_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449#discussion_r244681573","pull_request_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/comments/244681573"},"html":{"href":"https://github.com/eclipsesource/papyrus-seqd/pull/449#discussion_r244681573"},"pull_request":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449"}},"in_reply_to_id":244012770},"pull_request":{"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449","id":240975886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTc1ODg2","html_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449","diff_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449.diff","patch_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449.patch","issue_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449","number":449,"state":"open","locked":false,"title":"Issue #389: Update self message router and feeback","user":{"login":"rschnekenbu","id":3964263,"node_id":"MDQ6VXNlcjM5NjQyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3964263?v=4","gravatar_id":"","url":"https://api.github.com/users/rschnekenbu","html_url":"https://github.com/rschnekenbu","followers_url":"https://api.github.com/users/rschnekenbu/followers","following_url":"https://api.github.com/users/rschnekenbu/following{/other_user}","gists_url":"https://api.github.com/users/rschnekenbu/gists{/gist_id}","starred_url":"https://api.github.com/users/rschnekenbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschnekenbu/subscriptions","organizations_url":"https://api.github.com/users/rschnekenbu/orgs","repos_url":"https://api.github.com/users/rschnekenbu/repos","events_url":"https://api.github.com/users/rschnekenbu/events{/privacy}","received_events_url":"https://api.github.com/users/rschnekenbu/received_events","type":"User","site_admin":false},"body":"- update the self router to not use bendpoints\r\n- update feedback to switch from self to oblique and vice versa\r\n- update management of start/end messages for execution specifications\r\n- add some tests for self messages corner cases\r\n- add some (weird) refresh method for tests, to get them green on remote\r\nbuild. working fine locally PDE and maven, but not on remote build\r\nserver\r\n- update anchors on executions to manage automatically the sides.\r\n\r\nChange-Id: Ieb479d5b1109c4f4b4a76c0df5e45b48c73192d2\r\nSigned-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>","created_at":"2018-12-26T12:49:52Z","updated_at":"2019-01-02T08:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c12f34cb94b66474b63147222d248ba0601b86a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449/commits","review_comments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449/comments","review_comment_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449/comments","statuses_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/statuses/f68469bb935bda8df3cca7c6318a0f981b195b42","head":{"label":"eclipsesource:rschnekenbu/389-messageRouting","ref":"rschnekenbu/389-messageRouting","sha":"f68469bb935bda8df3cca7c6318a0f981b195b42","user":{"login":"eclipsesource","id":525860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/525860?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"repo":{"id":118589542,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1ODk1NDI=","name":"papyrus-seqd","full_name":"eclipsesource/papyrus-seqd","private":false,"owner":{"login":"eclipsesource","id":525860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/525860?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipsesource/papyrus-seqd","description":null,"fork":false,"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd","forks_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/forks","keys_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/teams","hooks_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/hooks","issue_events_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/events{/number}","events_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/events","assignees_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/assignees{/user}","branches_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/branches{/branch}","tags_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/tags","blobs_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/languages","stargazers_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/stargazers","contributors_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/contributors","subscribers_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/subscribers","subscription_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/subscription","commits_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/contents/{+path}","compare_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/merges","archive_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/downloads","issues_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues{/number}","pulls_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/labels{/name}","releases_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/releases{/id}","deployments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/deployments","created_at":"2018-01-23T09:40:57Z","updated_at":"2018-12-26T08:37:23Z","pushed_at":"2018-12-28T22:43:07Z","git_url":"git://github.com/eclipsesource/papyrus-seqd.git","ssh_url":"git@github.com:eclipsesource/papyrus-seqd.git","clone_url":"https://github.com/eclipsesource/papyrus-seqd.git","svn_url":"https://github.com/eclipsesource/papyrus-seqd","homepage":null,"size":3192,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":217,"license":null,"forks":5,"open_issues":217,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipsesource:master","ref":"master","sha":"4e04c89ceb24790b833e7dfd3aca5e316f083853","user":{"login":"eclipsesource","id":525860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/525860?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"repo":{"id":118589542,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1ODk1NDI=","name":"papyrus-seqd","full_name":"eclipsesource/papyrus-seqd","private":false,"owner":{"login":"eclipsesource","id":525860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/525860?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipsesource/papyrus-seqd","description":null,"fork":false,"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd","forks_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/forks","keys_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/teams","hooks_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/hooks","issue_events_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/events{/number}","events_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/events","assignees_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/assignees{/user}","branches_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/branches{/branch}","tags_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/tags","blobs_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/languages","stargazers_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/stargazers","contributors_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/contributors","subscribers_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/subscribers","subscription_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/subscription","commits_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/contents/{+path}","compare_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/merges","archive_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/downloads","issues_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues{/number}","pulls_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/labels{/name}","releases_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/releases{/id}","deployments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/deployments","created_at":"2018-01-23T09:40:57Z","updated_at":"2018-12-26T08:37:23Z","pushed_at":"2018-12-28T22:43:07Z","git_url":"git://github.com/eclipsesource/papyrus-seqd.git","ssh_url":"git@github.com:eclipsesource/papyrus-seqd.git","clone_url":"https://github.com/eclipsesource/papyrus-seqd.git","svn_url":"https://github.com/eclipsesource/papyrus-seqd","homepage":null,"size":3192,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":217,"license":null,"forks":5,"open_issues":217,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449"},"html":{"href":"https://github.com/eclipsesource/papyrus-seqd/pull/449"},"issue":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449"},"comments":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/eclipsesource/papyrus-seqd/statuses/f68469bb935bda8df3cca7c6318a0f981b195b42"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rschnekenbu"}}