{"action":"created","issue":{"url":"https://api.github.com/repos/party98/pyDownload/issues/29","repository_url":"https://api.github.com/repos/party98/pyDownload","labels_url":"https://api.github.com/repos/party98/pyDownload/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/party98/pyDownload/issues/29/comments","events_url":"https://api.github.com/repos/party98/pyDownload/issues/29/events","html_url":"https://github.com/party98/pyDownload/pull/29","id":328534376,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDQ1NzIx","number":29,"title":"Multithreading","user":{"login":"party98","id":22412980,"node_id":"MDQ6VXNlcjIyNDEyOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/22412980?v=4","gravatar_id":"","url":"https://api.github.com/users/party98","html_url":"https://github.com/party98","followers_url":"https://api.github.com/users/party98/followers","following_url":"https://api.github.com/users/party98/following{/other_user}","gists_url":"https://api.github.com/users/party98/gists{/gist_id}","starred_url":"https://api.github.com/users/party98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/party98/subscriptions","organizations_url":"https://api.github.com/users/party98/orgs","repos_url":"https://api.github.com/users/party98/repos","events_url":"https://api.github.com/users/party98/events{/privacy}","received_events_url":"https://api.github.com/users/party98/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-01T14:08:47Z","updated_at":"2018-06-01T14:18:30Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/party98/pyDownload/pulls/29","html_url":"https://github.com/party98/pyDownload/pull/29","diff_url":"https://github.com/party98/pyDownload/pull/29.diff","patch_url":"https://github.com/party98/pyDownload/pull/29.patch"},"body":"## Checklist\r\n- [x] The PR is being made against the `development` branch.\r\n- [x] I have verified that there are no failing tests\r\n- [x] I have checked the formatting of the code with flake8\r\n- [x] I have changed the documentation and added comments wherever required\r\n- [x] I have updated and written tests for the proposed changes\r\n\r\n## Description\r\nAdded multiprocessing downloads that spawn new processes instead of creating new threads.\r\nAlso added the ability to specify the number of splits to be made and the number of workers to create.\r\n\r\n## What problem does it solve\r\nIt will provide faster downloads due to IO taking place in separate processes\r\n\r\n## Proposed changes\r\n\r\n- Added multi processing downloads\r\n\r\n- Added ability to specify number of splits to make\r\n\r\n- Refactored into ABC model and factory pattern while maintaining the same api interface\r\n\r\n\r\n## Issue Number (If any)\r\n#23 "},"comment":{"url":"https://api.github.com/repos/party98/pyDownload/issues/comments/393894853","html_url":"https://github.com/party98/pyDownload/pull/29#issuecomment-393894853","issue_url":"https://api.github.com/repos/party98/pyDownload/issues/29","id":393894853,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzg5NDg1Mw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-01T14:18:30Z","updated_at":"2018-06-01T14:18:30Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=h1) Report\n> Merging [#29](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=desc) into [development](https://codecov.io/gh/party98/pyDownload/commit/c9061b20d4327d113550886eaa9f2bcf92312cc5?src=pr&el=desc) will **decrease** coverage by `6.29%`.\n> The diff coverage is `80.34%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/party98/pyDownload/pull/29/graphs/tree.svg?height=150&src=pr&token=6ELUtsxEMN&width=650)](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=tree)\n\n```diff\n@@              Coverage Diff              @@\n##           development     #29     +/-   ##\n=============================================\n- Coverage        84.79%   78.5%   -6.3%     \n=============================================\n  Files                5       8      +3     \n  Lines              217     307     +90     \n  Branches            32      43     +11     \n=============================================\n+ Hits               184     241     +57     \n- Misses              32      64     +32     \n- Partials             1       2      +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pyDownload/\\_\\_main\\_\\_.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC9fX21haW5fXy5weQ==) | `0% <0%> (ø)` | :arrow_up: |\n| [pyDownload/\\_\\_init\\_\\_.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [pyDownload/downloader\\_factory.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC9kb3dubG9hZGVyX2ZhY3RvcnkucHk=) | `100% <100%> (ø)` | |\n| [pyDownload/process\\_downloader.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC9wcm9jZXNzX2Rvd25sb2FkZXIucHk=) | `62.29% <62.29%> (ø)` | |\n| [pyDownload/base\\_downloader.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC9iYXNlX2Rvd25sb2FkZXIucHk=) | `93.54% <85.71%> (ø)` | |\n| [pyDownload/thread\\_downloader.py](https://codecov.io/gh/party98/pyDownload/pull/29/diff?src=pr&el=tree#diff-cHlEb3dubG9hZC90aHJlYWRfZG93bmxvYWRlci5weQ==) | `95% <95%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=footer). Last update [c9061b2...60ddbba](https://codecov.io/gh/party98/pyDownload/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}