{"action":"created","comment":{"url":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments/243745101","pull_request_review_id":187601730,"id":243745101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc0NTEwMQ==","diff_hunk":"@@ -310,10 +326,15 @@ def _build_policy_loss(self, i):\n \n                     surr_vanilla = lr * adv_valid\n \n+            # Finalize objective function\n+            with tf.name_scope(\"final_loss\"):","path":"garage/tf/algos/npo.py","position":52,"original_position":52,"commit_id":"8dc84592bfc1e2a62a77949e4c609ae32a3abae0","original_commit_id":"8dc84592bfc1e2a62a77949e4c609ae32a3abae0","user":{"login":"ryanjulian","id":1376219,"node_id":"MDQ6VXNlcjEzNzYyMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1376219?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjulian","html_url":"https://github.com/ryanjulian","followers_url":"https://api.github.com/users/ryanjulian/followers","following_url":"https://api.github.com/users/ryanjulian/following{/other_user}","gists_url":"https://api.github.com/users/ryanjulian/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjulian/subscriptions","organizations_url":"https://api.github.com/users/ryanjulian/orgs","repos_url":"https://api.github.com/users/ryanjulian/repos","events_url":"https://api.github.com/users/ryanjulian/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjulian/received_events","type":"User","site_admin":false},"body":"just \"loss\"","created_at":"2018-12-22T20:04:15Z","updated_at":"2018-12-22T20:06:54Z","html_url":"https://github.com/rlworkgroup/garage/pull/447#discussion_r243745101","pull_request_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/447","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments/243745101"},"html":{"href":"https://github.com/rlworkgroup/garage/pull/447#discussion_r243745101"},"pull_request":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/447"}}},"pull_request":{"url":"https://api.github.com/repos/rlworkgroup/garage/pulls/447","id":240346383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzQ2Mzgz","html_url":"https://github.com/rlworkgroup/garage/pull/447","diff_url":"https://github.com/rlworkgroup/garage/pull/447.diff","patch_url":"https://github.com/rlworkgroup/garage/pull/447.patch","issue_url":"https://api.github.com/repos/rlworkgroup/garage/issues/447","number":447,"state":"open","locked":false,"title":"Add vanilla loss to NPO","user":{"login":"CatherineSue","id":8605658,"node_id":"MDQ6VXNlcjg2MDU2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8605658?v=4","gravatar_id":"","url":"https://api.github.com/users/CatherineSue","html_url":"https://github.com/CatherineSue","followers_url":"https://api.github.com/users/CatherineSue/followers","following_url":"https://api.github.com/users/CatherineSue/following{/other_user}","gists_url":"https://api.github.com/users/CatherineSue/gists{/gist_id}","starred_url":"https://api.github.com/users/CatherineSue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatherineSue/subscriptions","organizations_url":"https://api.github.com/users/CatherineSue/orgs","repos_url":"https://api.github.com/users/CatherineSue/repos","events_url":"https://api.github.com/users/CatherineSue/events{/privacy}","received_events_url":"https://api.github.com/users/CatherineSue/received_events","type":"User","site_admin":false},"body":"1. VPG uses a different loss function than NPO and its variants. VPG\r\nuses the vanilla loss, as VPG uses direct gradient estimator from policy\r\nscore function, NPO calculates the derivation using importance sampling.\r\nThus, we need to add the 'real' vanilla loss to NPO to inherit from NPO.\r\nThe Enum is kept in this commit instead of string.\r\n2. Update examples.","created_at":"2018-12-21T01:13:17Z","updated_at":"2018-12-22T20:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb462e75098ac889b38845f98536300f2db24050","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amolchanov86","id":9425205,"node_id":"MDQ6VXNlcjk0MjUyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9425205?v=4","gravatar_id":"","url":"https://api.github.com/users/amolchanov86","html_url":"https://github.com/amolchanov86","followers_url":"https://api.github.com/users/amolchanov86/followers","following_url":"https://api.github.com/users/amolchanov86/following{/other_user}","gists_url":"https://api.github.com/users/amolchanov86/gists{/gist_id}","starred_url":"https://api.github.com/users/amolchanov86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amolchanov86/subscriptions","organizations_url":"https://api.github.com/users/amolchanov86/orgs","repos_url":"https://api.github.com/users/amolchanov86/repos","events_url":"https://api.github.com/users/amolchanov86/events{/privacy}","received_events_url":"https://api.github.com/users/amolchanov86/received_events","type":"User","site_admin":false},{"login":"ahtsan","id":10270515,"node_id":"MDQ6VXNlcjEwMjcwNTE1","avatar_url":"https://avatars1.githubusercontent.com/u/10270515?v=4","gravatar_id":"","url":"https://api.github.com/users/ahtsan","html_url":"https://github.com/ahtsan","followers_url":"https://api.github.com/users/ahtsan/followers","following_url":"https://api.github.com/users/ahtsan/following{/other_user}","gists_url":"https://api.github.com/users/ahtsan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahtsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahtsan/subscriptions","organizations_url":"https://api.github.com/users/ahtsan/orgs","repos_url":"https://api.github.com/users/ahtsan/repos","events_url":"https://api.github.com/users/ahtsan/events{/privacy}","received_events_url":"https://api.github.com/users/ahtsan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/447/commits","review_comments_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/447/comments","review_comment_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/issues/447/comments","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/8dc84592bfc1e2a62a77949e4c609ae32a3abae0","head":{"label":"rlworkgroup:add_vanilla_loss","ref":"add_vanilla_loss","sha":"8dc84592bfc1e2a62a77949e4c609ae32a3abae0","user":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":136846372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NDYzNzI=","name":"garage","full_name":"rlworkgroup/garage","private":false,"owner":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rlworkgroup/garage","description":"A framework for reproducible reinforcement learning research","fork":false,"url":"https://api.github.com/repos/rlworkgroup/garage","forks_url":"https://api.github.com/repos/rlworkgroup/garage/forks","keys_url":"https://api.github.com/repos/rlworkgroup/garage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlworkgroup/garage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlworkgroup/garage/teams","hooks_url":"https://api.github.com/repos/rlworkgroup/garage/hooks","issue_events_url":"https://api.github.com/repos/rlworkgroup/garage/issues/events{/number}","events_url":"https://api.github.com/repos/rlworkgroup/garage/events","assignees_url":"https://api.github.com/repos/rlworkgroup/garage/assignees{/user}","branches_url":"https://api.github.com/repos/rlworkgroup/garage/branches{/branch}","tags_url":"https://api.github.com/repos/rlworkgroup/garage/tags","blobs_url":"https://api.github.com/repos/rlworkgroup/garage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlworkgroup/garage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlworkgroup/garage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlworkgroup/garage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/{sha}","languages_url":"https://api.github.com/repos/rlworkgroup/garage/languages","stargazers_url":"https://api.github.com/repos/rlworkgroup/garage/stargazers","contributors_url":"https://api.github.com/repos/rlworkgroup/garage/contributors","subscribers_url":"https://api.github.com/repos/rlworkgroup/garage/subscribers","subscription_url":"https://api.github.com/repos/rlworkgroup/garage/subscription","commits_url":"https://api.github.com/repos/rlworkgroup/garage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlworkgroup/garage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlworkgroup/garage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlworkgroup/garage/contents/{+path}","compare_url":"https://api.github.com/repos/rlworkgroup/garage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlworkgroup/garage/merges","archive_url":"https://api.github.com/repos/rlworkgroup/garage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlworkgroup/garage/downloads","issues_url":"https://api.github.com/repos/rlworkgroup/garage/issues{/number}","pulls_url":"https://api.github.com/repos/rlworkgroup/garage/pulls{/number}","milestones_url":"https://api.github.com/repos/rlworkgroup/garage/milestones{/number}","notifications_url":"https://api.github.com/repos/rlworkgroup/garage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlworkgroup/garage/labels{/name}","releases_url":"https://api.github.com/repos/rlworkgroup/garage/releases{/id}","deployments_url":"https://api.github.com/repos/rlworkgroup/garage/deployments","created_at":"2018-06-10T21:31:23Z","updated_at":"2018-12-22T05:56:28Z","pushed_at":"2018-12-22T18:56:23Z","git_url":"git://github.com/rlworkgroup/garage.git","ssh_url":"git@github.com:rlworkgroup/garage.git","clone_url":"https://github.com/rlworkgroup/garage.git","svn_url":"https://github.com/rlworkgroup/garage","homepage":"","size":9068,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":117,"watchers":154,"default_branch":"master"}},"base":{"label":"rlworkgroup:master","ref":"master","sha":"33349d9d41c0a8516291cdd60c96f2b4e14e89f5","user":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":136846372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NDYzNzI=","name":"garage","full_name":"rlworkgroup/garage","private":false,"owner":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rlworkgroup/garage","description":"A framework for reproducible reinforcement learning research","fork":false,"url":"https://api.github.com/repos/rlworkgroup/garage","forks_url":"https://api.github.com/repos/rlworkgroup/garage/forks","keys_url":"https://api.github.com/repos/rlworkgroup/garage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlworkgroup/garage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlworkgroup/garage/teams","hooks_url":"https://api.github.com/repos/rlworkgroup/garage/hooks","issue_events_url":"https://api.github.com/repos/rlworkgroup/garage/issues/events{/number}","events_url":"https://api.github.com/repos/rlworkgroup/garage/events","assignees_url":"https://api.github.com/repos/rlworkgroup/garage/assignees{/user}","branches_url":"https://api.github.com/repos/rlworkgroup/garage/branches{/branch}","tags_url":"https://api.github.com/repos/rlworkgroup/garage/tags","blobs_url":"https://api.github.com/repos/rlworkgroup/garage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlworkgroup/garage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlworkgroup/garage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlworkgroup/garage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/{sha}","languages_url":"https://api.github.com/repos/rlworkgroup/garage/languages","stargazers_url":"https://api.github.com/repos/rlworkgroup/garage/stargazers","contributors_url":"https://api.github.com/repos/rlworkgroup/garage/contributors","subscribers_url":"https://api.github.com/repos/rlworkgroup/garage/subscribers","subscription_url":"https://api.github.com/repos/rlworkgroup/garage/subscription","commits_url":"https://api.github.com/repos/rlworkgroup/garage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlworkgroup/garage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlworkgroup/garage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlworkgroup/garage/contents/{+path}","compare_url":"https://api.github.com/repos/rlworkgroup/garage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlworkgroup/garage/merges","archive_url":"https://api.github.com/repos/rlworkgroup/garage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlworkgroup/garage/downloads","issues_url":"https://api.github.com/repos/rlworkgroup/garage/issues{/number}","pulls_url":"https://api.github.com/repos/rlworkgroup/garage/pulls{/number}","milestones_url":"https://api.github.com/repos/rlworkgroup/garage/milestones{/number}","notifications_url":"https://api.github.com/repos/rlworkgroup/garage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlworkgroup/garage/labels{/name}","releases_url":"https://api.github.com/repos/rlworkgroup/garage/releases{/id}","deployments_url":"https://api.github.com/repos/rlworkgroup/garage/deployments","created_at":"2018-06-10T21:31:23Z","updated_at":"2018-12-22T05:56:28Z","pushed_at":"2018-12-22T18:56:23Z","git_url":"git://github.com/rlworkgroup/garage.git","ssh_url":"git@github.com:rlworkgroup/garage.git","clone_url":"https://github.com/rlworkgroup/garage.git","svn_url":"https://github.com/rlworkgroup/garage","homepage":"","size":9068,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":117,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/447"},"html":{"href":"https://github.com/rlworkgroup/garage/pull/447"},"issue":{"href":"https://api.github.com/repos/rlworkgroup/garage/issues/447"},"comments":{"href":"https://api.github.com/repos/rlworkgroup/garage/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/rlworkgroup/garage/statuses/8dc84592bfc1e2a62a77949e4c609ae32a3abae0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ryanjulian"}}