{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/169315063","pull_request_review_id":97787647,"id":169315063,"diff_hunk":"@@ -115,7 +115,7 @@ instance Buildable (SecureLog PtxCondition) where\n data PtxSubmitTiming = PtxSubmitTiming\n     { _pstNextSlot  :: SlotId\n     , _pstNextDelay :: FlatSlotId\n-    } deriving (Eq, Show)\n+    } deriving (Eq, Show, Generic)","path":"wallet/src/Pos/Wallet/Web/Pending/Types.hs","position":5,"original_position":5,"commit_id":"a0ec5863ab399cfae51b50924e61de4f026959f9","original_commit_id":"9be594d4d9263c7288643fc7326713b9f17dabd1","user":{"login":"adinapoli-iohk","id":29383371,"avatar_url":"https://avatars3.githubusercontent.com/u/29383371?v=4","gravatar_id":"","url":"https://api.github.com/users/adinapoli-iohk","html_url":"https://github.com/adinapoli-iohk","followers_url":"https://api.github.com/users/adinapoli-iohk/followers","following_url":"https://api.github.com/users/adinapoli-iohk/following{/other_user}","gists_url":"https://api.github.com/users/adinapoli-iohk/gists{/gist_id}","starred_url":"https://api.github.com/users/adinapoli-iohk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adinapoli-iohk/subscriptions","organizations_url":"https://api.github.com/users/adinapoli-iohk/orgs","repos_url":"https://api.github.com/users/adinapoli-iohk/repos","events_url":"https://api.github.com/users/adinapoli-iohk/events{/privacy}","received_events_url":"https://api.github.com/users/adinapoli-iohk/received_events","type":"User","site_admin":false},"body":"Why we need the `Generic` instance here?","created_at":"2018-02-20T13:22:00Z","updated_at":"2018-02-20T13:22:18Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2547#discussion_r169315063","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/169315063"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2547#discussion_r169315063"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547","id":170109380,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/2547","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/2547.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/2547.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2547","number":2547,"state":"open","locked":false,"title":"[CT-55] Test \"Pending transactions aren't removed with block application","user":{"login":"ksaric","id":6264437,"avatar_url":"https://avatars0.githubusercontent.com/u/6264437?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaric","html_url":"https://github.com/ksaric","followers_url":"https://api.github.com/users/ksaric/followers","following_url":"https://api.github.com/users/ksaric/following{/other_user}","gists_url":"https://api.github.com/users/ksaric/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaric/subscriptions","organizations_url":"https://api.github.com/users/ksaric/orgs","repos_url":"https://api.github.com/users/ksaric/repos","events_url":"https://api.github.com/users/ksaric/events{/privacy}","received_events_url":"https://api.github.com/users/ksaric/received_events","type":"User","site_admin":false},"body":"https://iohk.myjetbrains.com/youtrack/issue/CT-55\r\n\r\nTesting the basic conditions under which the code should work, refactored the code in order to be able to test it (easily?).\r\n\r\nShould be easy/easier to test other states now.\r\n\r\nPlease check that I didn't do something wrong while moving the code around :pray:\r\n\r\nAs discussed with @adinapoli-iohk, this PR was opened on `develop` so the PR on `release` can be closed - https://github.com/input-output-hk/cardano-sl/pull/2534","created_at":"2018-02-20T06:15:46Z","updated_at":"2018-02-20T13:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44df79bf9735ca99ca79a0ea086c6ec5399b8a91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"neongreen","id":1523306,"avatar_url":"https://avatars3.githubusercontent.com/u/1523306?v=4","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},{"login":"akegalj","id":2461951,"avatar_url":"https://avatars0.githubusercontent.com/u/2461951?v=4","gravatar_id":"","url":"https://api.github.com/users/akegalj","html_url":"https://github.com/akegalj","followers_url":"https://api.github.com/users/akegalj/followers","following_url":"https://api.github.com/users/akegalj/following{/other_user}","gists_url":"https://api.github.com/users/akegalj/gists{/gist_id}","starred_url":"https://api.github.com/users/akegalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akegalj/subscriptions","organizations_url":"https://api.github.com/users/akegalj/orgs","repos_url":"https://api.github.com/users/akegalj/repos","events_url":"https://api.github.com/users/akegalj/events{/privacy}","received_events_url":"https://api.github.com/users/akegalj/received_events","type":"User","site_admin":false},{"login":"gromakovsky","id":2556409,"avatar_url":"https://avatars0.githubusercontent.com/u/2556409?v=4","gravatar_id":"","url":"https://api.github.com/users/gromakovsky","html_url":"https://github.com/gromakovsky","followers_url":"https://api.github.com/users/gromakovsky/followers","following_url":"https://api.github.com/users/gromakovsky/following{/other_user}","gists_url":"https://api.github.com/users/gromakovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/gromakovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gromakovsky/subscriptions","organizations_url":"https://api.github.com/users/gromakovsky/orgs","repos_url":"https://api.github.com/users/gromakovsky/repos","events_url":"https://api.github.com/users/gromakovsky/events{/privacy}","received_events_url":"https://api.github.com/users/gromakovsky/received_events","type":"User","site_admin":false},{"login":"int-index","id":4061728,"avatar_url":"https://avatars1.githubusercontent.com/u/4061728?v=4","gravatar_id":"","url":"https://api.github.com/users/int-index","html_url":"https://github.com/int-index","followers_url":"https://api.github.com/users/int-index/followers","following_url":"https://api.github.com/users/int-index/following{/other_user}","gists_url":"https://api.github.com/users/int-index/gists{/gist_id}","starred_url":"https://api.github.com/users/int-index/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int-index/subscriptions","organizations_url":"https://api.github.com/users/int-index/orgs","repos_url":"https://api.github.com/users/int-index/repos","events_url":"https://api.github.com/users/int-index/events{/privacy}","received_events_url":"https://api.github.com/users/int-index/received_events","type":"User","site_admin":false},{"login":"Martoon-00","id":5394217,"avatar_url":"https://avatars3.githubusercontent.com/u/5394217?v=4","gravatar_id":"","url":"https://api.github.com/users/Martoon-00","html_url":"https://github.com/Martoon-00","followers_url":"https://api.github.com/users/Martoon-00/followers","following_url":"https://api.github.com/users/Martoon-00/following{/other_user}","gists_url":"https://api.github.com/users/Martoon-00/gists{/gist_id}","starred_url":"https://api.github.com/users/Martoon-00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martoon-00/subscriptions","organizations_url":"https://api.github.com/users/Martoon-00/orgs","repos_url":"https://api.github.com/users/Martoon-00/repos","events_url":"https://api.github.com/users/Martoon-00/events{/privacy}","received_events_url":"https://api.github.com/users/Martoon-00/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":704324632,"url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels/somebody%20review%20plz","name":"somebody review plz","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2547/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/a0ec5863ab399cfae51b50924e61de4f026959f9","head":{"label":"input-output-hk:ksaric/CT-55-develop","ref":"ksaric/CT-55-develop","sha":"a0ec5863ab399cfae51b50924e61de4f026959f9","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-02-20T09:34:08Z","pushed_at":"2018-02-20T13:19:09Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":84767,"stargazers_count":2044,"watchers_count":2044,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":288,"open_issues":129,"watchers":2044,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"a753095f908ee7d1f15c2f08f153dd659811130d","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-02-20T09:34:08Z","pushed_at":"2018-02-20T13:19:09Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":84767,"stargazers_count":2044,"watchers_count":2044,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":288,"open_issues":129,"watchers":2044,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2547"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2547"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2547/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2547/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/a0ec5863ab399cfae51b50924e61de4f026959f9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"adinapoli-iohk"}}