{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/217313131","pull_request_review_id":154992554,"id":217313131,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzMxMzEzMQ==","diff_hunk":"@@ -22,6 +22,4 @@ format({});\n \n // Invalid sub type\n // $ExpectError\n-format({\n-    messageType: 1\n-});\n+format({ messageType: 1 });","path":"types/parity-pmd/parity-pmd-tests.ts","position":7,"original_position":7,"commit_id":"5b2fbefbffe67ded39feae3793414b014f2ee007","original_commit_id":"5b2fbefbffe67ded39feae3793414b014f2ee007","user":{"login":"Flarna","id":18708370,"node_id":"MDQ6VXNlcjE4NzA4Mzcw","avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"body":"There were passing at the time the last change was done in this module but now they fail (see e.g. https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/428047718?utm_source=github_status&utm_medium=notification).\r\n\r\nThe cause why it fails now without any change in your type definition is that the typescript version used to test has been upgraded.\r\n","created_at":"2018-09-13T09:09:37Z","updated_at":"2018-09-13T09:09:37Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830#discussion_r217313131","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/217313131"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830#discussion_r217313131"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830"}},"in_reply_to_id":217302993},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830","id":215099158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDk5MTU4","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28830","number":28830,"state":"open","locked":false,"title":"[parity-pmd] Fix tests for ts@next","user":{"login":"Flarna","id":18708370,"node_id":"MDQ6VXNlcjE4NzA4Mzcw","avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"body":"- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nFix tests for typescript@next which reports errors on a differnt line. As tests are executed also with older typescript versions the only solution is to move everything on one line.\r\n\r\nNo change in exported type definitions.\r\n\r\nRefs: #28708","created_at":"2018-09-12T21:18:05Z","updated_at":"2018-09-13T09:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7367910647bcaee8a7ac32156883b9c0520182c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28830/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/5b2fbefbffe67ded39feae3793414b014f2ee007","head":{"label":"Flarna:parity-pmd_fix-test","ref":"parity-pmd_fix-test","sha":"5b2fbefbffe67ded39feae3793414b014f2ee007","user":{"login":"Flarna","id":18708370,"node_id":"MDQ6VXNlcjE4NzA4Mzcw","avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"repo":{"id":71938164,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzODE2NA==","name":"DefinitelyTyped","full_name":"Flarna/DefinitelyTyped","owner":{"login":"Flarna","id":18708370,"node_id":"MDQ6VXNlcjE4NzA4Mzcw","avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flarna/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/Flarna/DefinitelyTyped","forks_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/Flarna/DefinitelyTyped/deployments","created_at":"2016-10-25T20:53:30Z","updated_at":"2018-09-12T20:29:09Z","pushed_at":"2018-09-12T22:06:47Z","git_url":"git://github.com/Flarna/DefinitelyTyped.git","ssh_url":"git@github.com:Flarna/DefinitelyTyped.git","clone_url":"https://github.com/Flarna/DefinitelyTyped.git","svn_url":"https://github.com/Flarna/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":353386,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"5f7be1fd628aaa36a1414d6ba59df8ff03ca3f1e","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-09-13T09:01:53Z","pushed_at":"2018-09-13T09:03:16Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":353472,"stargazers_count":17387,"watchers_count":17387,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14515,"mirror_url":null,"archived":false,"open_issues_count":2411,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14515,"open_issues":2411,"watchers":17387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28830"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28830"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28830/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28830/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/5b2fbefbffe67ded39feae3793414b014f2ee007"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Flarna"}}