{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/61","repository_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro","labels_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/61/comments","events_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/61/events","html_url":"https://github.com/OpenLiberty/draft-guide-security-intro/issues/61","id":370800129,"node_id":"MDU6SXNzdWUzNzA4MDAxMjk=","number":61,"title":"Tommy's Feedback","user":{"login":"wojtczat","id":21010870,"node_id":"MDQ6VXNlcjIxMDEwODcw","avatar_url":"https://avatars3.githubusercontent.com/u/21010870?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtczat","html_url":"https://github.com/wojtczat","followers_url":"https://api.github.com/users/wojtczat/followers","following_url":"https://api.github.com/users/wojtczat/following{/other_user}","gists_url":"https://api.github.com/users/wojtczat/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtczat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtczat/subscriptions","organizations_url":"https://api.github.com/users/wojtczat/orgs","repos_url":"https://api.github.com/users/wojtczat/repos","events_url":"https://api.github.com/users/wojtczat/events{/privacy}","received_events_url":"https://api.github.com/users/wojtczat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"justineechen","id":18709242,"node_id":"MDQ6VXNlcjE4NzA5MjQy","avatar_url":"https://avatars3.githubusercontent.com/u/18709242?v=4","gravatar_id":"","url":"https://api.github.com/users/justineechen","html_url":"https://github.com/justineechen","followers_url":"https://api.github.com/users/justineechen/followers","following_url":"https://api.github.com/users/justineechen/following{/other_user}","gists_url":"https://api.github.com/users/justineechen/gists{/gist_id}","starred_url":"https://api.github.com/users/justineechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justineechen/subscriptions","organizations_url":"https://api.github.com/users/justineechen/orgs","repos_url":"https://api.github.com/users/justineechen/repos","events_url":"https://api.github.com/users/justineechen/events{/privacy}","received_events_url":"https://api.github.com/users/justineechen/received_events","type":"User","site_admin":false},"assignees":[{"login":"justineechen","id":18709242,"node_id":"MDQ6VXNlcjE4NzA5MjQy","avatar_url":"https://avatars3.githubusercontent.com/u/18709242?v=4","gravatar_id":"","url":"https://api.github.com/users/justineechen","html_url":"https://github.com/justineechen","followers_url":"https://api.github.com/users/justineechen/followers","following_url":"https://api.github.com/users/justineechen/following{/other_user}","gists_url":"https://api.github.com/users/justineechen/gists{/gist_id}","starred_url":"https://api.github.com/users/justineechen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justineechen/subscriptions","organizations_url":"https://api.github.com/users/justineechen/orgs","repos_url":"https://api.github.com/users/justineechen/repos","events_url":"https://api.github.com/users/justineechen/events{/privacy}","received_events_url":"https://api.github.com/users/justineechen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-16T21:07:26Z","updated_at":"2018-10-17T21:34:08Z","closed_at":null,"author_association":"NONE","body":"There is a lot of information in this guide and it is presented fairly well, but I do have a few issues. So depending on the browser the application did not automatically switch to https. In Safari it did, but with Chrome it never did no matter what I tried. I also found showing the final app first for this guide to be redundant because when you build your own later on you end up repeating the exact same steps which are already fairly short and quick to execute. Moreover, I still find the presentation of code breakdown amongst the guides to be poor. I extremely dislike this idea of pasting an entire file of code somewhere and then analyzing it afterwards when it is no longer at my full attention. Specifically for this guide I refer to the method descriptions for testAuthentication() in the test file and the annotations in the HomeServlet.java file. My last complaint has to do with the encoding passwords section. I saw no sentence instructing me to change back from the start directory to the finish one to then navigate to wlp/bin to test the encoder. This section should just be done after liberty is built and the target directory is present in the start directory. Besides my few issues, I was very happy with the information presented. It was delivered at an appropriate level and it probably only took me around 10 minutes to run through this whole guide. "},"comment":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/comments/430797726","html_url":"https://github.com/OpenLiberty/draft-guide-security-intro/issues/61#issuecomment-430797726","issue_url":"https://api.github.com/repos/OpenLiberty/draft-guide-security-intro/issues/61","id":430797726,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDc5NzcyNg==","user":{"login":"evelinec","id":33134427,"node_id":"MDQ6VXNlcjMzMTM0NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/33134427?v=4","gravatar_id":"","url":"https://api.github.com/users/evelinec","html_url":"https://github.com/evelinec","followers_url":"https://api.github.com/users/evelinec/followers","following_url":"https://api.github.com/users/evelinec/following{/other_user}","gists_url":"https://api.github.com/users/evelinec/gists{/gist_id}","starred_url":"https://api.github.com/users/evelinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evelinec/subscriptions","organizations_url":"https://api.github.com/users/evelinec/orgs","repos_url":"https://api.github.com/users/evelinec/repos","events_url":"https://api.github.com/users/evelinec/events{/privacy}","received_events_url":"https://api.github.com/users/evelinec/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T21:34:08Z","updated_at":"2018-10-17T21:34:08Z","author_association":"CONTRIBUTOR","body":"Clarified with Tommy about the three remaining points above. No must address issue for now. This issue should not block pre tests. "}}
{"actor":{"display_login":"evelinec"}}