{"action":"created","comment":{"url":"https://api.github.com/repos/eciis/web/pulls/comments/242319998","pull_request_review_id":185803279,"id":242319998,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMxOTk5OA==","diff_hunk":"@@ -127,18 +128,20 @@ function set_webchat_url {\n }\n \n function set_app_version_config {\n-    sed -i \"9s|.*|    APP_VERSION: '$1'|\" $FRONTEND_CONFIG_FILE\n+    tmpfile=$(mktemp)\n+    sed \"9s|.*|    APP_VERSION: '$1'|\" $FRONTEND_CONFIG_FILE > \"$tmpfile\" && mv \"$tmpfile\" $FRONTEND_CONFIG_FILE\n     catch_error $? \"APP VERSION on Frontend $1\"\n-    sed -i \"9s|.*|    APP_VERSION: '$1'|\" $SUPPORT_CONFIG_FILE\n+    sed \"9s|.*|    APP_VERSION: '$1'|\" $SUPPORT_CONFIG_FILE > \"$tmpfile\" && mv \"$tmpfile\" $SUPPORT_CONFIG_FILE","path":"ecis","position":34,"original_position":34,"commit_id":"6bd74c948442fc453c6b572758e9bec70f17123a","original_commit_id":"039b1ed137c21b94a15a462b54ac636fda97497d","user":{"login":"brobsc","id":39133539,"node_id":"MDQ6VXNlcjM5MTMzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/39133539?v=4","gravatar_id":"","url":"https://api.github.com/users/brobsc","html_url":"https://github.com/brobsc","followers_url":"https://api.github.com/users/brobsc/followers","following_url":"https://api.github.com/users/brobsc/following{/other_user}","gists_url":"https://api.github.com/users/brobsc/gists{/gist_id}","starred_url":"https://api.github.com/users/brobsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brobsc/subscriptions","organizations_url":"https://api.github.com/users/brobsc/orgs","repos_url":"https://api.github.com/users/brobsc/repos","events_url":"https://api.github.com/users/brobsc/events{/privacy}","received_events_url":"https://api.github.com/users/brobsc/received_events","type":"User","site_admin":false},"body":"`sed` has a different implemention on unix based systems (linux) and BSD systems (mac os). While on linux it simply edits the file in-place if we don't pass a backup extension (optional), on BSD it expects it as a *mandatory* argument.\r\n(`sed -i .bak ...` for instance)\r\nIn order to have a portable solution (and also one where we dont end up with several backup files cluterring the repository), we write sed output to a temp file, and then replace our original file with said temp file.\r\n\r\nLinux sed:\r\n```\r\n-i[SUFFIX], --in-place[=SUFFIX]\r\n    edit files in place (makes backup if extension supplied). The default operation mode is to break symbolic and hard links. This can be changed with --follow-symlinks and --copy. \r\n```\r\n\r\nBSD sed:\r\n```  \r\n-i[extension]\r\n    Edit files in place, saving backups with the specified extension. If a zero length extension is given, no backup will be saved. It is not recommended to give a zero length extension when in place editing files, as it risks corruption or partial content in situations where disk space is exhausted, etc. In -i mode, the hold space, line numbers, and ranges are reset between files.\r\n```","created_at":"2018-12-17T21:20:18Z","updated_at":"2018-12-17T21:20:18Z","html_url":"https://github.com/eciis/web/pull/1358#discussion_r242319998","pull_request_url":"https://api.github.com/repos/eciis/web/pulls/1358","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/comments/242319998"},"html":{"href":"https://github.com/eciis/web/pull/1358#discussion_r242319998"},"pull_request":{"href":"https://api.github.com/repos/eciis/web/pulls/1358"}},"in_reply_to_id":242133790},"pull_request":{"url":"https://api.github.com/repos/eciis/web/pulls/1358","id":238058675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDU4Njc1","html_url":"https://github.com/eciis/web/pull/1358","diff_url":"https://github.com/eciis/web/pull/1358.diff","patch_url":"https://github.com/eciis/web/pull/1358.patch","issue_url":"https://api.github.com/repos/eciis/web/issues/1358","number":1358,"state":"open","locked":false,"title":"Add webchat login page","user":{"login":"brobsc","id":39133539,"node_id":"MDQ6VXNlcjM5MTMzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/39133539?v=4","gravatar_id":"","url":"https://api.github.com/users/brobsc","html_url":"https://github.com/brobsc","followers_url":"https://api.github.com/users/brobsc/followers","following_url":"https://api.github.com/users/brobsc/following{/other_user}","gists_url":"https://api.github.com/users/brobsc/gists{/gist_id}","starred_url":"https://api.github.com/users/brobsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brobsc/subscriptions","organizations_url":"https://api.github.com/users/brobsc/orgs","repos_url":"https://api.github.com/users/brobsc/repos","events_url":"https://api.github.com/users/brobsc/events{/privacy}","received_events_url":"https://api.github.com/users/brobsc/received_events","type":"User","site_admin":false},"body":"**Feature/Bug description:** Add login page to webchat service\r\n**Solution:**\r\n![localhost_8084_](https://user-images.githubusercontent.com/39133539/49876213-cc00a800-fe1a-11e8-98a0-81b1cb9ad173.png)\r\n![localhost_8084_ nexus 5 1](https://user-images.githubusercontent.com/39133539/49876215-ce630200-fe1a-11e8-9f13-0b2236d42ee6.png)\r\n![localhost_8084_ nexus 5 2](https://user-images.githubusercontent.com/39133539/49876220-d15df280-fe1a-11e8-8c87-3444fcb2c2fe.png)\r\n![localhost_8084_ nexus 5 3](https://user-images.githubusercontent.com/39133539/49876231-d6bb3d00-fe1a-11e8-82ab-f7bc00d41270.png)\r\n\r\n\r\n**TODO/FIXME:**\r\n- [ ] Add AuthService (login functionality)\r\n- [ ] Add forgot password button\r\n- [ ] Add request invite button","created_at":"2018-12-12T14:34:39Z","updated_at":"2018-12-17T21:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ff558b4a765d9aeca7882c5c17a005d1fa86b87","assignee":{"login":"brobsc","id":39133539,"node_id":"MDQ6VXNlcjM5MTMzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/39133539?v=4","gravatar_id":"","url":"https://api.github.com/users/brobsc","html_url":"https://github.com/brobsc","followers_url":"https://api.github.com/users/brobsc/followers","following_url":"https://api.github.com/users/brobsc/following{/other_user}","gists_url":"https://api.github.com/users/brobsc/gists{/gist_id}","starred_url":"https://api.github.com/users/brobsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brobsc/subscriptions","organizations_url":"https://api.github.com/users/brobsc/orgs","repos_url":"https://api.github.com/users/brobsc/repos","events_url":"https://api.github.com/users/brobsc/events{/privacy}","received_events_url":"https://api.github.com/users/brobsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"brobsc","id":39133539,"node_id":"MDQ6VXNlcjM5MTMzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/39133539?v=4","gravatar_id":"","url":"https://api.github.com/users/brobsc","html_url":"https://github.com/brobsc","followers_url":"https://api.github.com/users/brobsc/followers","following_url":"https://api.github.com/users/brobsc/following{/other_user}","gists_url":"https://api.github.com/users/brobsc/gists{/gist_id}","starred_url":"https://api.github.com/users/brobsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brobsc/subscriptions","organizations_url":"https://api.github.com/users/brobsc/orgs","repos_url":"https://api.github.com/users/brobsc/repos","events_url":"https://api.github.com/users/brobsc/events{/privacy}","received_events_url":"https://api.github.com/users/brobsc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pedroespindula","id":38431219,"node_id":"MDQ6VXNlcjM4NDMxMjE5","avatar_url":"https://avatars1.githubusercontent.com/u/38431219?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroespindula","html_url":"https://github.com/pedroespindula","followers_url":"https://api.github.com/users/pedroespindula/followers","following_url":"https://api.github.com/users/pedroespindula/following{/other_user}","gists_url":"https://api.github.com/users/pedroespindula/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroespindula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroespindula/subscriptions","organizations_url":"https://api.github.com/users/pedroespindula/orgs","repos_url":"https://api.github.com/users/pedroespindula/repos","events_url":"https://api.github.com/users/pedroespindula/events{/privacy}","received_events_url":"https://api.github.com/users/pedroespindula/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eciis/web/pulls/1358/commits","review_comments_url":"https://api.github.com/repos/eciis/web/pulls/1358/comments","review_comment_url":"https://api.github.com/repos/eciis/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eciis/web/issues/1358/comments","statuses_url":"https://api.github.com/repos/eciis/web/statuses/6bd74c948442fc453c6b572758e9bec70f17123a","head":{"label":"eciis:webchat-login-page","ref":"webchat-login-page","sha":"6bd74c948442fc453c6b572758e9bec70f17123a","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-12-14T14:58:14Z","pushed_at":"2018-12-17T21:10:25Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":11026,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":13,"watchers":9,"default_branch":"dev"}},"base":{"label":"eciis:webchat-ui-router","ref":"webchat-ui-router","sha":"0a6bf18e998b555c93c9aa420dcb569b73b5b96b","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-12-14T14:58:14Z","pushed_at":"2018-12-17T21:10:25Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":11026,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":13,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/1358"},"html":{"href":"https://github.com/eciis/web/pull/1358"},"issue":{"href":"https://api.github.com/repos/eciis/web/issues/1358"},"comments":{"href":"https://api.github.com/repos/eciis/web/issues/1358/comments"},"review_comments":{"href":"https://api.github.com/repos/eciis/web/pulls/1358/comments"},"review_comment":{"href":"https://api.github.com/repos/eciis/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eciis/web/pulls/1358/commits"},"statuses":{"href":"https://api.github.com/repos/eciis/web/statuses/6bd74c948442fc453c6b572758e9bec70f17123a"}},"author_association":"NONE"}}
{"actor":{"display_login":"brobsc"}}