{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/13707","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/13707/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/13707/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/13707/events","html_url":"https://github.com/spring-projects/spring-boot/pull/13707","id":338433531,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzYzODk5","number":13707,"title":"Fix parameter order for RequestMatcherAssert.doesNotMatch()","user":{"login":"izeye","id":1059363,"node_id":"MDQ6VXNlcjEwNTkzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1059363?v=4","gravatar_id":"","url":"https://api.github.com/users/izeye","html_url":"https://github.com/izeye","followers_url":"https://api.github.com/users/izeye/followers","following_url":"https://api.github.com/users/izeye/following{/other_user}","gists_url":"https://api.github.com/users/izeye/gists{/gist_id}","starred_url":"https://api.github.com/users/izeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izeye/subscriptions","organizations_url":"https://api.github.com/users/izeye/orgs","repos_url":"https://api.github.com/users/izeye/repos","events_url":"https://api.github.com/users/izeye/events{/privacy}","received_events_url":"https://api.github.com/users/izeye/received_events","type":"User","site_admin":false},"labels":[{"id":293438798,"node_id":"MDU6TGFiZWwyOTM0Mzg3OTg=","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-triage","name":"status: waiting-for-triage","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-05T05:42:24Z","updated_at":"2018-07-05T08:31:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/13707","html_url":"https://github.com/spring-projects/spring-boot/pull/13707","diff_url":"https://github.com/spring-projects/spring-boot/pull/13707.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/13707.patch"},"body":"<!--\r\nThanks for contributing to Spring Boot. Please provide a brief description of your pull-request and reference any related issue numbers (prefix references with #).\r\n-->\r\nCallers for `RequestMatcherAssert.doesNotMatch()` have been updated to align with `RequestMatcherAssert.matches()` in fddc9e9c7e7300d93c0ba44ef702eb205326b3e2 but its signature itself hasn't been updated. This PR updates its parameter order to align with its callers."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/402646584","html_url":"https://github.com/spring-projects/spring-boot/pull/13707#issuecomment-402646584","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/13707","id":402646584,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjY0NjU4NA==","user":{"login":"wilkinsona","id":914682,"node_id":"MDQ6VXNlcjkxNDY4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T08:31:36Z","updated_at":"2018-07-05T08:31:36Z","author_association":"MEMBER","body":"I think the current order (`servletPath` then `pathInfo`) makes sense. Isn't it only reversed in the matches case to accommodate the use of varags?\r\n\r\nIf anything's to change, I think I'd prefer to see matches become (List<String> servletPaths, String pathInfo) instead, but I'll defer to @mbhave as she is more familiar with this code than I am."}}
{"actor":{"display_login":"wilkinsona"}}