{"action":"created","issue":{"url":"https://api.github.com/repos/keboola/runner-sync-api/issues/14","repository_url":"https://api.github.com/repos/keboola/runner-sync-api","labels_url":"https://api.github.com/repos/keboola/runner-sync-api/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/keboola/runner-sync-api/issues/14/comments","events_url":"https://api.github.com/repos/keboola/runner-sync-api/issues/14/events","html_url":"https://github.com/keboola/runner-sync-api/issues/14","id":364861325,"node_id":"MDU6SXNzdWUzNjQ4NjEzMjU=","number":14,"title":"review","user":{"login":"ondrejhlavacek","id":497675,"node_id":"MDQ6VXNlcjQ5NzY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/497675?v=4","gravatar_id":"","url":"https://api.github.com/users/ondrejhlavacek","html_url":"https://github.com/ondrejhlavacek","followers_url":"https://api.github.com/users/ondrejhlavacek/followers","following_url":"https://api.github.com/users/ondrejhlavacek/following{/other_user}","gists_url":"https://api.github.com/users/ondrejhlavacek/gists{/gist_id}","starred_url":"https://api.github.com/users/ondrejhlavacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondrejhlavacek/subscriptions","organizations_url":"https://api.github.com/users/ondrejhlavacek/orgs","repos_url":"https://api.github.com/users/ondrejhlavacek/repos","events_url":"https://api.github.com/users/ondrejhlavacek/events{/privacy}","received_events_url":"https://api.github.com/users/ondrejhlavacek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"odinuv","id":4319320,"node_id":"MDQ6VXNlcjQzMTkzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4319320?v=4","gravatar_id":"","url":"https://api.github.com/users/odinuv","html_url":"https://github.com/odinuv","followers_url":"https://api.github.com/users/odinuv/followers","following_url":"https://api.github.com/users/odinuv/following{/other_user}","gists_url":"https://api.github.com/users/odinuv/gists{/gist_id}","starred_url":"https://api.github.com/users/odinuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odinuv/subscriptions","organizations_url":"https://api.github.com/users/odinuv/orgs","repos_url":"https://api.github.com/users/odinuv/repos","events_url":"https://api.github.com/users/odinuv/events{/privacy}","received_events_url":"https://api.github.com/users/odinuv/received_events","type":"User","site_admin":false},"assignees":[{"login":"odinuv","id":4319320,"node_id":"MDQ6VXNlcjQzMTkzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4319320?v=4","gravatar_id":"","url":"https://api.github.com/users/odinuv","html_url":"https://github.com/odinuv","followers_url":"https://api.github.com/users/odinuv/followers","following_url":"https://api.github.com/users/odinuv/following{/other_user}","gists_url":"https://api.github.com/users/odinuv/gists{/gist_id}","starred_url":"https://api.github.com/users/odinuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odinuv/subscriptions","organizations_url":"https://api.github.com/users/odinuv/orgs","repos_url":"https://api.github.com/users/odinuv/repos","events_url":"https://api.github.com/users/odinuv/events{/privacy}","received_events_url":"https://api.github.com/users/odinuv/received_events","type":"User","site_admin":false}],"milestone":null,"comments":31,"created_at":"2018-09-28T12:06:01Z","updated_at":"2018-10-02T08:17:30Z","closed_at":null,"author_association":"MEMBER","body":"1) název package beru jako dočasnej\r\nhttps://github.com/keboola/runner-sync-api/blob/6226a6fd67d038b9f37d17e5969bd6c9152abb5a/composer.json#L18\r\n\r\n\r\n2) konstanta controlleru?\r\nhttps://github.com/keboola/runner-sync-api/blob/0afd5bca3898d218518f8c976206cfb490ccbd48/src/Controller/ActionController.php#L160-L168\r\n\r\n3) privátní metody controlleru - nešly by zase ty, co nemaj moc závislosti přímo na controlleru vyházet ven a otestovat? `getConfigData`, `createResponse` (potomek `JsonResponse`), další mi na první pohled přijdou provázanější s controllerem/dic. \r\n\r\n4) kde najdu logy? dostal jsem 500 a nemůžu najít o co jde, na stdout v `docker-compose run` mi to nic nevypsalo. pamatuju si, že jsem se k tomu nějak dostal nebo to rovnou někde viděl, ale nemůžu si vzpomenout\r\n\r\n5) ECS task má konstantní jméno - v jednom regionu asi nepůjde mít víc testovacích stacků\r\n\r\nhttps://github.com/keboola/runner-sync-api/blob/e90561d4abf8d90d398d27ad5761ba4cc2d1ed38/test-cf-stack.json#L358"},"comment":{"url":"https://api.github.com/repos/keboola/runner-sync-api/issues/comments/426188662","html_url":"https://github.com/keboola/runner-sync-api/issues/14#issuecomment-426188662","issue_url":"https://api.github.com/repos/keboola/runner-sync-api/issues/14","id":426188662,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjE4ODY2Mg==","user":{"login":"odinuv","id":4319320,"node_id":"MDQ6VXNlcjQzMTkzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4319320?v=4","gravatar_id":"","url":"https://api.github.com/users/odinuv","html_url":"https://github.com/odinuv","followers_url":"https://api.github.com/users/odinuv/followers","following_url":"https://api.github.com/users/odinuv/following{/other_user}","gists_url":"https://api.github.com/users/odinuv/gists{/gist_id}","starred_url":"https://api.github.com/users/odinuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odinuv/subscriptions","organizations_url":"https://api.github.com/users/odinuv/orgs","repos_url":"https://api.github.com/users/odinuv/repos","events_url":"https://api.github.com/users/odinuv/events{/privacy}","received_events_url":"https://api.github.com/users/odinuv/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T08:17:29Z","updated_at":"2018-10-02T08:17:29Z","author_association":"CONTRIBUTOR","body":"no pak uz je jen JSON formatter, muzes zkusit tady \r\nhttps://github.com/keboola/runner-sync-api/blob/master/config/packages/prod/monolog.yaml\r\nnacpat aby to misto na stderr psalo do souboru, pokud to bude fungovat, tak \r\nby to mozna mohlo souviset s timhle https://github.com/keboola/runner-sync-api/blob/master/Dockerfile#L62\r\n"}}
{"actor":{"display_login":"odinuv"}}