{"action":"created","comment":{"url":"https://api.github.com/repos/LIS/LISAv2/pulls/comments/208185028","pull_request_review_id":143941326,"id":208185028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE4NTAyOA==","diff_hunk":"@@ -0,0 +1,74 @@\n+#!/bin/bash\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the Apache License.\n+\n+#####################################################################\n+# Description:\n+#   This script verifies that the status of some values of with ethtool.\n+#\n+#   Steps:\n+#   1. Verify configuration file constants.sh\n+#   2. Determine interface(s) to check\n+#   3. Check TSO,  scatter-gather rx-checksumming and tx-checksumming\n+#\n+#   The test is successful if all interfaces are on.\n+#\n+#   No parameters required.\n+#\n+#   Optional parameters:\n+#       TC_COVERED\n+#\n+#   Parameter explanation:\n+#   TC_COVERED is the LIS testcase number\n+#\n+#############################################################################################################\n+declare __synth_iface\n+declare -a ETHTOOL_KEYS\n+ETHTOOL_KEYS=(\"tcp-segmentation-offload\" \"scatter-gather\" \"rx-checksumming\" \"tx-checksumming\")\n+\n+# Source utils.sh\n+. utils.sh || {\n+    echo \"Error: unable to source utils.sh!\"\n+    echo \"TestAborted\" > state.txt\n+    exit 0\n+}\n+\n+# Source constants file and initialize most common variables\n+UtilsInit\n+\n+# Check if ethtool exist and install it if not\n+VerifyIsEthtool\n+\n+GetSynthNetInterfaces\n+if ! GetSynthNetInterfaces; then\n+    msg=\"ERROR: No synthetic network interfaces found\"\n+    LogMsg \"$msg\"\n+    SetTestStateFailed\n+    exit 0\n+fi\n+\n+for __synth_iface in \"${SYNTH_NET_INTERFACES[@]}\"; do\n+    if ! ethtool -k \"$__synth_iface\"; then\n+        msg=\"Can't get the related value of synthetic network adapter with ethtool\"\n+        LogMsg \"${msg}\"\n+        SetTestStateFailed\n+        exit 0\n+    fi\n+\n+    for __key in \"${ETHTOOL_KEYS[@]}\"; do","path":"Testscripts/Linux/BVT-NET-ETHTOOL-CHECK-KEYS.sh","position":58,"original_position":58,"commit_id":"74ea78998c07255d1ece9e93248d8e1d4ae289dd","original_commit_id":"74ea78998c07255d1ece9e93248d8e1d4ae289dd","user":{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false},"body":"should have same indent as for above","created_at":"2018-08-07T10:55:03Z","updated_at":"2018-08-07T10:55:03Z","html_url":"https://github.com/LIS/LISAv2/pull/142#discussion_r208185028","pull_request_url":"https://api.github.com/repos/LIS/LISAv2/pulls/142","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/comments/208185028"},"html":{"href":"https://github.com/LIS/LISAv2/pull/142#discussion_r208185028"},"pull_request":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/LIS/LISAv2/pulls/142","id":206349893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzQ5ODkz","html_url":"https://github.com/LIS/LISAv2/pull/142","diff_url":"https://github.com/LIS/LISAv2/pull/142.diff","patch_url":"https://github.com/LIS/LISAv2/pull/142.patch","issue_url":"https://api.github.com/repos/LIS/LISAv2/issues/142","number":142,"state":"open","locked":false,"title":"hyper-v: Added 10 BVT tests","user":{"login":"ader1990","id":1412442,"node_id":"MDQ6VXNlcjE0MTI0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1412442?v=4","gravatar_id":"","url":"https://api.github.com/users/ader1990","html_url":"https://github.com/ader1990","followers_url":"https://api.github.com/users/ader1990/followers","following_url":"https://api.github.com/users/ader1990/following{/other_user}","gists_url":"https://api.github.com/users/ader1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ader1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ader1990/subscriptions","organizations_url":"https://api.github.com/users/ader1990/orgs","repos_url":"https://api.github.com/users/ader1990/repos","events_url":"https://api.github.com/users/ader1990/events{/privacy}","received_events_url":"https://api.github.com/users/ader1990/received_events","type":"User","site_admin":false},"body":"BVT Test cases added:\r\n- Basic LTP test\r\n- lsvmbus tool validation\r\n- lsvmbus detection for CPU cores spreading\r\n- KVP crash on pool 1 large size\r\n- Check Key with ethtool\r\n- Change ring buffer size\r\n- ethtool handler to set and get TCP hash levels \r\n- ethtool handler to set and get UDP hash levels\r\n- disable GRO/LRO using ethtool\r\n- Check number of channel\r\n- ifdown/ifup interface and check connectivity","created_at":"2018-08-06T10:08:32Z","updated_at":"2018-08-07T10:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a61572a76c531826b604c6b67110280b8c441e90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LIS/LISAv2/pulls/142/commits","review_comments_url":"https://api.github.com/repos/LIS/LISAv2/pulls/142/comments","review_comment_url":"https://api.github.com/repos/LIS/LISAv2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LIS/LISAv2/issues/142/comments","statuses_url":"https://api.github.com/repos/LIS/LISAv2/statuses/74ea78998c07255d1ece9e93248d8e1d4ae289dd","head":{"label":"adriansuhov:master","ref":"master","sha":"74ea78998c07255d1ece9e93248d8e1d4ae289dd","user":{"login":"adriansuhov","id":13692500,"node_id":"MDQ6VXNlcjEzNjkyNTAw","avatar_url":"https://avatars0.githubusercontent.com/u/13692500?v=4","gravatar_id":"","url":"https://api.github.com/users/adriansuhov","html_url":"https://github.com/adriansuhov","followers_url":"https://api.github.com/users/adriansuhov/followers","following_url":"https://api.github.com/users/adriansuhov/following{/other_user}","gists_url":"https://api.github.com/users/adriansuhov/gists{/gist_id}","starred_url":"https://api.github.com/users/adriansuhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriansuhov/subscriptions","organizations_url":"https://api.github.com/users/adriansuhov/orgs","repos_url":"https://api.github.com/users/adriansuhov/repos","events_url":"https://api.github.com/users/adriansuhov/events{/privacy}","received_events_url":"https://api.github.com/users/adriansuhov/received_events","type":"User","site_admin":false},"repo":{"id":142916034,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MTYwMzQ=","name":"LISAv2","full_name":"adriansuhov/LISAv2","owner":{"login":"adriansuhov","id":13692500,"node_id":"MDQ6VXNlcjEzNjkyNTAw","avatar_url":"https://avatars0.githubusercontent.com/u/13692500?v=4","gravatar_id":"","url":"https://api.github.com/users/adriansuhov","html_url":"https://github.com/adriansuhov","followers_url":"https://api.github.com/users/adriansuhov/followers","following_url":"https://api.github.com/users/adriansuhov/following{/other_user}","gists_url":"https://api.github.com/users/adriansuhov/gists{/gist_id}","starred_url":"https://api.github.com/users/adriansuhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriansuhov/subscriptions","organizations_url":"https://api.github.com/users/adriansuhov/orgs","repos_url":"https://api.github.com/users/adriansuhov/repos","events_url":"https://api.github.com/users/adriansuhov/events{/privacy}","received_events_url":"https://api.github.com/users/adriansuhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adriansuhov/LISAv2","description":null,"fork":true,"url":"https://api.github.com/repos/adriansuhov/LISAv2","forks_url":"https://api.github.com/repos/adriansuhov/LISAv2/forks","keys_url":"https://api.github.com/repos/adriansuhov/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adriansuhov/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adriansuhov/LISAv2/teams","hooks_url":"https://api.github.com/repos/adriansuhov/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/adriansuhov/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/adriansuhov/LISAv2/events","assignees_url":"https://api.github.com/repos/adriansuhov/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/adriansuhov/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/adriansuhov/LISAv2/tags","blobs_url":"https://api.github.com/repos/adriansuhov/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adriansuhov/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adriansuhov/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/adriansuhov/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adriansuhov/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/adriansuhov/LISAv2/languages","stargazers_url":"https://api.github.com/repos/adriansuhov/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/adriansuhov/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/adriansuhov/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/adriansuhov/LISAv2/subscription","commits_url":"https://api.github.com/repos/adriansuhov/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/adriansuhov/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/adriansuhov/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/adriansuhov/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/adriansuhov/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/adriansuhov/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adriansuhov/LISAv2/merges","archive_url":"https://api.github.com/repos/adriansuhov/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adriansuhov/LISAv2/downloads","issues_url":"https://api.github.com/repos/adriansuhov/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/adriansuhov/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/adriansuhov/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/adriansuhov/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adriansuhov/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/adriansuhov/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/adriansuhov/LISAv2/deployments","created_at":"2018-07-30T18:55:30Z","updated_at":"2018-08-02T12:20:38Z","pushed_at":"2018-08-02T12:20:34Z","git_url":"git://github.com/adriansuhov/LISAv2.git","ssh_url":"git@github.com:adriansuhov/LISAv2.git","clone_url":"https://github.com/adriansuhov/LISAv2.git","svn_url":"https://github.com/adriansuhov/LISAv2","homepage":null,"size":4784,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LIS:master","ref":"master","sha":"7a380ac2f0034b9c84d89df84fcfff7bd8017b8f","user":{"login":"LIS","id":930970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMDk3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/930970?v=4","gravatar_id":"","url":"https://api.github.com/users/LIS","html_url":"https://github.com/LIS","followers_url":"https://api.github.com/users/LIS/followers","following_url":"https://api.github.com/users/LIS/following{/other_user}","gists_url":"https://api.github.com/users/LIS/gists{/gist_id}","starred_url":"https://api.github.com/users/LIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LIS/subscriptions","organizations_url":"https://api.github.com/users/LIS/orgs","repos_url":"https://api.github.com/users/LIS/repos","events_url":"https://api.github.com/users/LIS/events{/privacy}","received_events_url":"https://api.github.com/users/LIS/received_events","type":"Organization","site_admin":false},"repo":{"id":133582416,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1ODI0MTY=","name":"LISAv2","full_name":"LIS/LISAv2","owner":{"login":"LIS","id":930970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMDk3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/930970?v=4","gravatar_id":"","url":"https://api.github.com/users/LIS","html_url":"https://github.com/LIS","followers_url":"https://api.github.com/users/LIS/followers","following_url":"https://api.github.com/users/LIS/following{/other_user}","gists_url":"https://api.github.com/users/LIS/gists{/gist_id}","starred_url":"https://api.github.com/users/LIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LIS/subscriptions","organizations_url":"https://api.github.com/users/LIS/orgs","repos_url":"https://api.github.com/users/LIS/repos","events_url":"https://api.github.com/users/LIS/events{/privacy}","received_events_url":"https://api.github.com/users/LIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LIS/LISAv2","description":null,"fork":false,"url":"https://api.github.com/repos/LIS/LISAv2","forks_url":"https://api.github.com/repos/LIS/LISAv2/forks","keys_url":"https://api.github.com/repos/LIS/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LIS/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LIS/LISAv2/teams","hooks_url":"https://api.github.com/repos/LIS/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/LIS/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/LIS/LISAv2/events","assignees_url":"https://api.github.com/repos/LIS/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/LIS/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/LIS/LISAv2/tags","blobs_url":"https://api.github.com/repos/LIS/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LIS/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LIS/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/LIS/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LIS/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/LIS/LISAv2/languages","stargazers_url":"https://api.github.com/repos/LIS/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/LIS/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/LIS/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/LIS/LISAv2/subscription","commits_url":"https://api.github.com/repos/LIS/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/LIS/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/LIS/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/LIS/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/LIS/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/LIS/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LIS/LISAv2/merges","archive_url":"https://api.github.com/repos/LIS/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LIS/LISAv2/downloads","issues_url":"https://api.github.com/repos/LIS/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/LIS/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/LIS/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/LIS/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LIS/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/LIS/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/LIS/LISAv2/deployments","created_at":"2018-05-15T23:04:25Z","updated_at":"2018-08-07T08:12:30Z","pushed_at":"2018-08-07T09:05:58Z","git_url":"git://github.com/LIS/LISAv2.git","ssh_url":"git@github.com:LIS/LISAv2.git","clone_url":"https://github.com/LIS/LISAv2.git","svn_url":"https://github.com/LIS/LISAv2","homepage":null,"size":5361,"stargazers_count":3,"watchers_count":3,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":42,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/142"},"html":{"href":"https://github.com/LIS/LISAv2/pull/142"},"issue":{"href":"https://api.github.com/repos/LIS/LISAv2/issues/142"},"comments":{"href":"https://api.github.com/repos/LIS/LISAv2/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/LIS/LISAv2/statuses/74ea78998c07255d1ece9e93248d8e1d4ae289dd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"asofron"}}