{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/aurelia/issues/139","repository_url":"https://api.github.com/repos/aurelia/aurelia","labels_url":"https://api.github.com/repos/aurelia/aurelia/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/aurelia/issues/139/comments","events_url":"https://api.github.com/repos/aurelia/aurelia/issues/139/events","html_url":"https://github.com/aurelia/aurelia/pull/139","id":357405682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDI5NDA0","number":139,"title":"fix(observer-locator): add collection length back in, fix precedence, add tests","user":{"login":"fkleuver","id":9655331,"node_id":"MDQ6VXNlcjk2NTUzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/9655331?v=4","gravatar_id":"","url":"https://api.github.com/users/fkleuver","html_url":"https://github.com/fkleuver","followers_url":"https://api.github.com/users/fkleuver/followers","following_url":"https://api.github.com/users/fkleuver/following{/other_user}","gists_url":"https://api.github.com/users/fkleuver/gists{/gist_id}","starred_url":"https://api.github.com/users/fkleuver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkleuver/subscriptions","organizations_url":"https://api.github.com/users/fkleuver/orgs","repos_url":"https://api.github.com/users/fkleuver/repos","events_url":"https://api.github.com/users/fkleuver/events{/privacy}","received_events_url":"https://api.github.com/users/fkleuver/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-05T21:12:34Z","updated_at":"2018-09-05T23:40:27Z","closed_at":"2018-09-05T23:00:18Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aurelia/aurelia/pulls/139","html_url":"https://github.com/aurelia/aurelia/pull/139","diff_url":"https://github.com/aurelia/aurelia/pull/139.diff","patch_url":"https://github.com/aurelia/aurelia/pull/139.patch"},"body":"\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/aurelia/aurelia/issues/comments/418915760","html_url":"https://github.com/aurelia/aurelia/pull/139#issuecomment-418915760","issue_url":"https://api.github.com/repos/aurelia/aurelia/issues/139","id":418915760,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODkxNTc2MA==","user":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T23:40:27Z","updated_at":"2018-09-05T23:40:27Z","author_association":"MEMBER","body":"I think this approach has its own issue too. This is what I meant https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag\r\n\r\nIn short, it will fail for:\r\n\r\n```js\r\nclass Collection extends Array {\r\n  [Symbol.toStringTag]() {\r\n    return 'Collection';\r\n  }\r\n}\r\n\r\nOjbect.prototype.toString.call(new Collection()) === '[object Collection]'\r\n```\r\n\r\n@fkleuver @EisenbergEffect \r\n\r\nInstance isn't 100% reliable and slower but I think it works fine for this."}}
{"actor":{"display_login":"bigopon"}}