{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11595","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11595/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11595/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11595/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/11595","id":351951019,"node_id":"MDU6SXNzdWUzNTE5NTEwMTk=","number":11595,"title":"Marlin 1.19 and filament width sensor","user":{"login":"stefi01","id":9444416,"node_id":"MDQ6VXNlcjk0NDQ0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9444416?v=4","gravatar_id":"","url":"https://api.github.com/users/stefi01","html_url":"https://github.com/stefi01","followers_url":"https://api.github.com/users/stefi01/followers","following_url":"https://api.github.com/users/stefi01/following{/other_user}","gists_url":"https://api.github.com/users/stefi01/gists{/gist_id}","starred_url":"https://api.github.com/users/stefi01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefi01/subscriptions","organizations_url":"https://api.github.com/users/stefi01/orgs","repos_url":"https://api.github.com/users/stefi01/repos","events_url":"https://api.github.com/users/stefi01/events{/privacy}","received_events_url":"https://api.github.com/users/stefi01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-20T00:54:05Z","updated_at":"2018-09-28T00:03:01Z","closed_at":null,"author_association":"NONE","body":"I transfered all the settings from marlin 1.18 to 1.19 and i get an error with the filament width sensor.\r\nworks as it should without problem in 1.18 and the settings were double checked against 1.18\r\n\r\ntemperature.cpp:1067: error: 'FILWIDTH_ERROR_MARGIN' was not declared in this scope\r\n\r\n if (ABS(filament_width_nominal - filament_width_meas) <= FILWIDTH_ERROR_MARGIN)\r\n\r\n                                                          ^\r\nsketch\\temperature.cpp: In static member function 'static void Temperature::readings_ready()':\r\n\r\ntemperature.cpp:1752: error: 'raw_filwidth_value' was not declared in this scope\r\n\r\n current_raw_filwidth = raw_filwidth_value >> 10;  // Divide to get to 0-16384 range since we used 1/128 IIR filter approach\r\n\r\nI use these settings in 1.18 without a problem, i have no idea what   #define FILWIDTH_ERROR_MARGIN        1  is ment to be set to but that also works pretty well as shown in 1.18\r\n\r\n[Configuration.txt](https://github.com/MarlinFirmware/Marlin/files/2300858/Configuration.txt)\r\n[Configuration_adv.txt](https://github.com/MarlinFirmware/Marlin/files/2300859/Configuration_adv.txt)\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/425279432","html_url":"https://github.com/MarlinFirmware/Marlin/issues/11595#issuecomment-425279432","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11595","id":425279432,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTI3OTQzMg==","user":{"login":"ve3sjk","id":7632604,"node_id":"MDQ6VXNlcjc2MzI2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7632604?v=4","gravatar_id":"","url":"https://api.github.com/users/ve3sjk","html_url":"https://github.com/ve3sjk","followers_url":"https://api.github.com/users/ve3sjk/followers","following_url":"https://api.github.com/users/ve3sjk/following{/other_user}","gists_url":"https://api.github.com/users/ve3sjk/gists{/gist_id}","starred_url":"https://api.github.com/users/ve3sjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ve3sjk/subscriptions","organizations_url":"https://api.github.com/users/ve3sjk/orgs","repos_url":"https://api.github.com/users/ve3sjk/repos","events_url":"https://api.github.com/users/ve3sjk/events{/privacy}","received_events_url":"https://api.github.com/users/ve3sjk/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T00:03:01Z","updated_at":"2018-09-28T00:03:01Z","author_association":"NONE","body":"You are correct , I also realized that the firmware is averaging the readings\r\nIn the subroutine so what I was seeing on my scope was just the rms\r\nValue at the instance I looked at it. I have recalibrated the sensor with\r\nThe proper calibration rod and its down to 0.02 now which is very\r\ngood and my prints look great.\r\n\r\n\r\n\r\nFrom: AnHardt [mailto:notifications@github.com]\r\nSent: Thursday, September 27, 2018 2:08 AM\r\nTo: MarlinFirmware/Marlin <Marlin@noreply.github.com>\r\nCc: Steve <deadman1966@outlook.com>; Comment <comment@noreply.github.com>\r\nSubject: Re: [MarlinFirmware/Marlin] Marlin 1.19 and filament width sensor (#11595)\r\n\r\n\r\n0.05-0.06V is at a 5V system about 0.1%. That's at a 10 bit ADC about 1 LSB. -> Much better than expected.\r\n\r\n—\r\nYou are receiving this because you commented.\r\nReply to this email directly, view it on GitHub<https://github.com/MarlinFirmware/Marlin/issues/11595#issuecomment-424969899>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHR23KkrITiyP_5_leHFW4XrYCdFAgrRks5ufGstgaJpZM4WDMas>.\r\n"}}
{"actor":{"display_login":"ve3sjk"}}