{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58677","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58677/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58677/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58677/events","html_url":"https://github.com/kubernetes/kubernetes/pull/58677","id":290774216,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0NTI4OTU4","number":58677,"title":"WIP initial work adding ctx to client-gen and informer-gen","user":{"login":"maleck13","id":304628,"node_id":"MDQ6VXNlcjMwNDYyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"labels":[{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false}],"milestone":null,"comments":65,"created_at":"2018-01-23T09:56:43Z","updated_at":"2018-07-05T09:22:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58677","html_url":"https://github.com/kubernetes/kubernetes/pull/58677","diff_url":"https://github.com/kubernetes/kubernetes/pull/58677.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58677.patch"},"body":"**What this PR does / why we need it**:\r\nAdds changes to the code generators to change the API to allow passing in context.Context as the first argument\r\nhttps://github.com/kubernetes/community/pull/1166\r\n**Special notes for your reviewer**:\r\npretty new to the code here so all guidance is appreciated. Fairly happy with the client gen changes and have tested those out on a CRD client I have, less certain about the Informer changes.\r\nWondered if perhaps trying them with the sample-controller would be a good approach.\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/402661036","html_url":"https://github.com/kubernetes/kubernetes/pull/58677#issuecomment-402661036","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58677","id":402661036,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjY2MTAzNg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T09:22:14Z","updated_at":"2018-07-05T09:22:14Z","author_association":"COLLABORATOR","body":"@maleck13: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-unit | 130323ad458681e40ea98e942d4493b1de4df275 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-unit/82281/) | `/test pull-kubernetes-unit`\npull-kubernetes-kubemark-e2e-gce | 5777226f8d7f2f283b415fe21af12e2dddcea2c0 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-kubemark-e2e-gce/94096/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-e2e-gce-100-performance | b81540c2a9636e96b76aedfde37bf2ae4b781fd5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-e2e-gce-100-performance/12155/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-local-e2e-containerized | b81540c2a9636e96b76aedfde37bf2ae4b781fd5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-local-e2e-containerized/1501/) | `/test pull-kubernetes-local-e2e-containerized`\npull-kubernetes-kubemark-e2e-gce-big | b81540c2a9636e96b76aedfde37bf2ae4b781fd5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-kubemark-e2e-gce-big/13423/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-e2e-gke | b81540c2a9636e96b76aedfde37bf2ae4b781fd5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-e2e-gke/1835/) | `/test pull-kubernetes-e2e-gke`\npull-kubernetes-e2e-gce | 14bd97315742701a4eab846f94e2bb8b2c947f9f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-e2e-gce/43363/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-kops-aws | 14bd97315742701a4eab846f94e2bb8b2c947f9f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-e2e-kops-aws/96044/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce-device-plugin-gpu | 14bd97315742701a4eab846f94e2bb8b2c947f9f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-e2e-gce-device-plugin-gpu/38948/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-verify | e1e0cc1a1ab90956393bd7cd7cf835c1992ab38a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58677/pull-kubernetes-verify/97709/) | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/58677). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/maleck13). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}