{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/222772707","pull_request_review_id":161741110,"id":222772707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjc3MjcwNw==","diff_hunk":"@@ -102,7 +103,7 @@ public function delete(Key $key)\n      */\n     public function putOffExpiration(Key $key, $ttl)\n     {\n-        // do nothing, the semaphore locks forever.\n+        throw new NotExpirableStoreException();","path":"src/Symfony/Component/Lock/Store/SemaphoreStore.php","position":13,"original_position":13,"commit_id":"07457f3a67cd700de6b60aaddc57ad865616ea91","original_commit_id":"07457f3a67cd700de6b60aaddc57ad865616ea91","user":{"login":"GaneshChandrasekaran","id":4956251,"node_id":"MDQ6VXNlcjQ5NTYyNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4956251?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshChandrasekaran","html_url":"https://github.com/GaneshChandrasekaran","followers_url":"https://api.github.com/users/GaneshChandrasekaran/followers","following_url":"https://api.github.com/users/GaneshChandrasekaran/following{/other_user}","gists_url":"https://api.github.com/users/GaneshChandrasekaran/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshChandrasekaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshChandrasekaran/subscriptions","organizations_url":"https://api.github.com/users/GaneshChandrasekaran/orgs","repos_url":"https://api.github.com/users/GaneshChandrasekaran/repos","events_url":"https://api.github.com/users/GaneshChandrasekaran/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshChandrasekaran/received_events","type":"User","site_admin":false},"body":"Okay - so `refresh` can be called outside of `save` as well since a lock can be refreshed at anytime. Yes, in that case I should catch and do nothing.","created_at":"2018-10-04T18:06:04Z","updated_at":"2018-10-04T18:06:04Z","html_url":"https://github.com/symfony/symfony/pull/28727#discussion_r222772707","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28727","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/222772707"},"html":{"href":"https://github.com/symfony/symfony/pull/28727#discussion_r222772707"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28727"}},"in_reply_to_id":222764814},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28727","id":220410254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDEwMjU0","html_url":"https://github.com/symfony/symfony/pull/28727","diff_url":"https://github.com/symfony/symfony/pull/28727.diff","patch_url":"https://github.com/symfony/symfony/pull/28727.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28727","number":28727,"state":"open","locked":false,"title":"Create new NotExpirableStoreException for stores which don't support expiration of locks","user":{"login":"GaneshChandrasekaran","id":4956251,"node_id":"MDQ6VXNlcjQ5NTYyNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4956251?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshChandrasekaran","html_url":"https://github.com/GaneshChandrasekaran","followers_url":"https://api.github.com/users/GaneshChandrasekaran/followers","following_url":"https://api.github.com/users/GaneshChandrasekaran/following{/other_user}","gists_url":"https://api.github.com/users/GaneshChandrasekaran/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshChandrasekaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshChandrasekaran/subscriptions","organizations_url":"https://api.github.com/users/GaneshChandrasekaran/orgs","repos_url":"https://api.github.com/users/GaneshChandrasekaran/repos","events_url":"https://api.github.com/users/GaneshChandrasekaran/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshChandrasekaran/received_events","type":"User","site_admin":false},"body":"Create new `NotExpirableStoreException` for stores which don't support expiration of locks.\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes \r\n| Fixed tickets | #28696 \r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\n\r\nSome of the stores do not support expiration of the lock resource. However, when a `ttl` is set on a lock, it attempts to `putOffExpiration`. In order to distinguish clearly between weather a store supports expiring locks and being able to putOffExpiration, a new exception class `NotExpirableStoreException` is introduced.\r\n\r\nAdditionally:\r\n- For stores that did not support expiration of locks, a `noop` in `putOffExpiration` will now `throw NotExpirableStoreException`\r\n- For `CombinedStores` only if all of the stores do not support expiration of locks, then the `NotExpirableStoreException` will be bubbled up, otherwise, it is ignored and continue as normal.\r\n- Fixed some tests where the lock factory was setting a `ttl` on stores that don't support expiration of locks\r\n- Added new test to cover the additional behaviour change in eligible stores\r\n","created_at":"2018-10-04T14:58:22Z","updated_at":"2018-10-04T18:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65a5136e9bb939cf1432824c407f0b8542c73b91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100079,"node_id":"MDU6TGFiZWwxMDAwNzk=","url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28727/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28727/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28727/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/07457f3a67cd700de6b60aaddc57ad865616ea91","head":{"label":"wayfair:gchandrasekaran_fixPutOffExpirationForZookeeperStore","ref":"gchandrasekaran_fixPutOffExpirationForZookeeperStore","sha":"07457f3a67cd700de6b60aaddc57ad865616ea91","user":{"login":"wayfair","id":1065892,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjU4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1065892?v=4","gravatar_id":"","url":"https://api.github.com/users/wayfair","html_url":"https://github.com/wayfair","followers_url":"https://api.github.com/users/wayfair/followers","following_url":"https://api.github.com/users/wayfair/following{/other_user}","gists_url":"https://api.github.com/users/wayfair/gists{/gist_id}","starred_url":"https://api.github.com/users/wayfair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayfair/subscriptions","organizations_url":"https://api.github.com/users/wayfair/orgs","repos_url":"https://api.github.com/users/wayfair/repos","events_url":"https://api.github.com/users/wayfair/events{/privacy}","received_events_url":"https://api.github.com/users/wayfair/received_events","type":"Organization","site_admin":false},"repo":{"id":140288592,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyODg1OTI=","name":"symfony","full_name":"wayfair/symfony","private":false,"owner":{"login":"wayfair","id":1065892,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjU4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1065892?v=4","gravatar_id":"","url":"https://api.github.com/users/wayfair","html_url":"https://github.com/wayfair","followers_url":"https://api.github.com/users/wayfair/followers","following_url":"https://api.github.com/users/wayfair/following{/other_user}","gists_url":"https://api.github.com/users/wayfair/gists{/gist_id}","starred_url":"https://api.github.com/users/wayfair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayfair/subscriptions","organizations_url":"https://api.github.com/users/wayfair/orgs","repos_url":"https://api.github.com/users/wayfair/repos","events_url":"https://api.github.com/users/wayfair/events{/privacy}","received_events_url":"https://api.github.com/users/wayfair/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wayfair/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/wayfair/symfony","forks_url":"https://api.github.com/repos/wayfair/symfony/forks","keys_url":"https://api.github.com/repos/wayfair/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wayfair/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wayfair/symfony/teams","hooks_url":"https://api.github.com/repos/wayfair/symfony/hooks","issue_events_url":"https://api.github.com/repos/wayfair/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/wayfair/symfony/events","assignees_url":"https://api.github.com/repos/wayfair/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/wayfair/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/wayfair/symfony/tags","blobs_url":"https://api.github.com/repos/wayfair/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wayfair/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wayfair/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/wayfair/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wayfair/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/wayfair/symfony/languages","stargazers_url":"https://api.github.com/repos/wayfair/symfony/stargazers","contributors_url":"https://api.github.com/repos/wayfair/symfony/contributors","subscribers_url":"https://api.github.com/repos/wayfair/symfony/subscribers","subscription_url":"https://api.github.com/repos/wayfair/symfony/subscription","commits_url":"https://api.github.com/repos/wayfair/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/wayfair/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/wayfair/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/wayfair/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/wayfair/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/wayfair/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wayfair/symfony/merges","archive_url":"https://api.github.com/repos/wayfair/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wayfair/symfony/downloads","issues_url":"https://api.github.com/repos/wayfair/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/wayfair/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/wayfair/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/wayfair/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wayfair/symfony/labels{/name}","releases_url":"https://api.github.com/repos/wayfair/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/wayfair/symfony/deployments","created_at":"2018-07-09T13:21:24Z","updated_at":"2018-10-03T16:10:26Z","pushed_at":"2018-10-04T16:45:05Z","git_url":"git://github.com/wayfair/symfony.git","ssh_url":"git@github.com:wayfair/symfony.git","clone_url":"https://github.com/wayfair/symfony.git","svn_url":"https://github.com/wayfair/symfony","homepage":"https://symfony.com","size":120690,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"5a0cad27ca82e54e2ed721f7910d436067fc2635","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-10-04T17:05:01Z","pushed_at":"2018-10-04T16:45:09Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":125725,"stargazers_count":18747,"watchers_count":18747,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6439,"mirror_url":null,"archived":false,"open_issues_count":852,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6439,"open_issues":852,"watchers":18747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28727"},"html":{"href":"https://github.com/symfony/symfony/pull/28727"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28727"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28727/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28727/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28727/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/07457f3a67cd700de6b60aaddc57ad865616ea91"}},"author_association":"NONE"}}
{"actor":{"display_login":"GaneshChandrasekaran"}}