{"action":"closed","issue":{"url":"https://api.github.com/repos/Microsoft/azuredatastudio/issues/2667","repository_url":"https://api.github.com/repos/Microsoft/azuredatastudio","labels_url":"https://api.github.com/repos/Microsoft/azuredatastudio/issues/2667/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/azuredatastudio/issues/2667/comments","events_url":"https://api.github.com/repos/Microsoft/azuredatastudio/issues/2667/events","html_url":"https://github.com/Microsoft/azuredatastudio/issues/2667","id":362855757,"node_id":"MDU6SXNzdWUzNjI4NTU3NTc=","number":2667,"title":"Undo doesn't work after unfocusing data edit cell","user":{"login":"AlexFsmn","id":11557675,"node_id":"MDQ6VXNlcjExNTU3Njc1","avatar_url":"https://avatars3.githubusercontent.com/u/11557675?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexFsmn","html_url":"https://github.com/AlexFsmn","followers_url":"https://api.github.com/users/AlexFsmn/followers","following_url":"https://api.github.com/users/AlexFsmn/following{/other_user}","gists_url":"https://api.github.com/users/AlexFsmn/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexFsmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexFsmn/subscriptions","organizations_url":"https://api.github.com/users/AlexFsmn/orgs","repos_url":"https://api.github.com/users/AlexFsmn/repos","events_url":"https://api.github.com/users/AlexFsmn/events{/privacy}","received_events_url":"https://api.github.com/users/AlexFsmn/received_events","type":"User","site_admin":false},"labels":[{"id":752613526,"node_id":"MDU6TGFiZWw3NTI2MTM1MjY=","url":"https://api.github.com/repos/Microsoft/azuredatastudio/labels/edit%20data","name":"edit data","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":{"login":"alanrenmsft","id":13777222,"node_id":"MDQ6VXNlcjEzNzc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13777222?v=4","gravatar_id":"","url":"https://api.github.com/users/alanrenmsft","html_url":"https://github.com/alanrenmsft","followers_url":"https://api.github.com/users/alanrenmsft/followers","following_url":"https://api.github.com/users/alanrenmsft/following{/other_user}","gists_url":"https://api.github.com/users/alanrenmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/alanrenmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanrenmsft/subscriptions","organizations_url":"https://api.github.com/users/alanrenmsft/orgs","repos_url":"https://api.github.com/users/alanrenmsft/repos","events_url":"https://api.github.com/users/alanrenmsft/events{/privacy}","received_events_url":"https://api.github.com/users/alanrenmsft/received_events","type":"User","site_admin":false},"assignees":[{"login":"alanrenmsft","id":13777222,"node_id":"MDQ6VXNlcjEzNzc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13777222?v=4","gravatar_id":"","url":"https://api.github.com/users/alanrenmsft","html_url":"https://github.com/alanrenmsft","followers_url":"https://api.github.com/users/alanrenmsft/followers","following_url":"https://api.github.com/users/alanrenmsft/following{/other_user}","gists_url":"https://api.github.com/users/alanrenmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/alanrenmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanrenmsft/subscriptions","organizations_url":"https://api.github.com/users/alanrenmsft/orgs","repos_url":"https://api.github.com/users/alanrenmsft/repos","events_url":"https://api.github.com/users/alanrenmsft/events{/privacy}","received_events_url":"https://api.github.com/users/alanrenmsft/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/azuredatastudio/milestones/19","html_url":"https://github.com/Microsoft/azuredatastudio/milestone/19","labels_url":"https://api.github.com/repos/Microsoft/azuredatastudio/milestones/19/labels","id":3734970,"node_id":"MDk6TWlsZXN0b25lMzczNDk3MA==","number":19,"title":"December Release","description":"","creator":{"login":"kburtram","id":599935,"node_id":"MDQ6VXNlcjU5OTkzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/599935?v=4","gravatar_id":"","url":"https://api.github.com/users/kburtram","html_url":"https://github.com/kburtram","followers_url":"https://api.github.com/users/kburtram/followers","following_url":"https://api.github.com/users/kburtram/following{/other_user}","gists_url":"https://api.github.com/users/kburtram/gists{/gist_id}","starred_url":"https://api.github.com/users/kburtram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kburtram/subscriptions","organizations_url":"https://api.github.com/users/kburtram/orgs","repos_url":"https://api.github.com/users/kburtram/repos","events_url":"https://api.github.com/users/kburtram/events{/privacy}","received_events_url":"https://api.github.com/users/kburtram/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2018-10-12T20:31:25Z","updated_at":"2018-10-12T22:52:06Z","due_on":"2018-12-11T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-09-22T13:05:57Z","updated_at":"2018-10-12T22:52:06Z","closed_at":"2018-10-12T22:52:05Z","author_association":"CONTRIBUTOR","body":"- SQL Operations Studio Version: `master`\r\n\r\nSteps to Reproduce:\r\n1. Edit a table\r\n2. Mark and edit cell A\r\n3. Mark cell B\r\n4. Go back to cell A and try pressing Ctrl+Z or right-click -> undo\r\n\r\nExpected: Undo should still function in cell A\r\nActual: Nothing happens\r\n\r\nThe real problem here is if you make a mistake when editing a cell and you input the incorrect format:\r\n_(Column testdt in this example is of type datetime)_\r\n![image](https://user-images.githubusercontent.com/11557675/45917426-34249b00-be77-11e8-827d-d610d46de70c.png)\r\n\r\nIf you edit a cell with the incorrect format like this:\r\n![image](https://user-images.githubusercontent.com/11557675/45917433-6209df80-be77-11e8-8be3-3422d6c86684.png)\r\n\r\nYou will end up with the following error in the log:\r\n![image](https://user-images.githubusercontent.com/11557675/45917435-7057fb80-be77-11e8-948a-d74f8f7e27e5.png)\r\n\r\nIf you then try to go back to that cell and undo your mistake it isn't possible at the moment.\r\nThe problem here is that if you forget the initial value you won't be able to unfocus that cell and expect it go back as normal as it will continue showing the error above.\r\n\r\nThe only current workaround I have found for this is to close the editing window and reopen it.\r\n"}}
{"actor":{"display_login":"alanrenmsft"}}