{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments/212373929","pull_request_review_id":148992721,"id":212373929,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM3MzkyOQ==","diff_hunk":"@@ -133,6 +133,14 @@ skydns_server_secondary: \"{{ kube_service_addresses|ipaddr('net')|ipaddr(4)|ipad\n dnsmasq_dns_server: \"{{ kube_service_addresses|ipaddr('net')|ipaddr(2)|ipaddr('address') }}\"\n dns_domain: \"{{ cluster_name }}\"\n \n+# Use docker as container runtime\n+# If you set manage_crio true, set manage_docker false.\n+manage_docker: true","path":"inventory/sample/group_vars/k8s-cluster.yml","position":6,"original_position":6,"commit_id":"fbd38f56947361d608e5653094152b0e4cb41c3e","original_commit_id":"fbd38f56947361d608e5653094152b0e4cb41c3e","user":{"login":"ant31","id":1044332,"node_id":"MDQ6VXNlcjEwNDQzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1044332?v=4","gravatar_id":"","url":"https://api.github.com/users/ant31","html_url":"https://github.com/ant31","followers_url":"https://api.github.com/users/ant31/followers","following_url":"https://api.github.com/users/ant31/following{/other_user}","gists_url":"https://api.github.com/users/ant31/gists{/gist_id}","starred_url":"https://api.github.com/users/ant31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant31/subscriptions","organizations_url":"https://api.github.com/users/ant31/orgs","repos_url":"https://api.github.com/users/ant31/repos","events_url":"https://api.github.com/users/ant31/events{/privacy}","received_events_url":"https://api.github.com/users/ant31/received_events","type":"User","site_admin":false},"body":"if they are mutually exclusive just make a variable:\r\n```\r\ncontainer_manager: [docker, crio]\r\n```","created_at":"2018-08-23T16:25:43Z","updated_at":"2018-08-23T16:25:43Z","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/3061#discussion_r212373929","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments/212373929"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/3061#discussion_r212373929"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061","id":206216839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjE2ODM5","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/3061","diff_url":"https://github.com/kubernetes-incubator/kubespray/pull/3061.diff","patch_url":"https://github.com/kubernetes-incubator/kubespray/pull/3061.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3061","number":3061,"state":"open","locked":false,"title":"[WIP]cri-o support ","user":{"login":"okamototk","id":310081,"node_id":"MDQ6VXNlcjMxMDA4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/310081?v=4","gravatar_id":"","url":"https://api.github.com/users/okamototk","html_url":"https://github.com/okamototk","followers_url":"https://api.github.com/users/okamototk/followers","following_url":"https://api.github.com/users/okamototk/following{/other_user}","gists_url":"https://api.github.com/users/okamototk/gists{/gist_id}","starred_url":"https://api.github.com/users/okamototk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okamototk/subscriptions","organizations_url":"https://api.github.com/users/okamototk/orgs","repos_url":"https://api.github.com/users/okamototk/repos","events_url":"https://api.github.com/users/okamototk/events{/privacy}","received_events_url":"https://api.github.com/users/okamototk/received_events","type":"User","site_admin":false},"body":"This PR attempts to fix #2450.\r\n\r\nCurrently, I tested with cri-o and kubeadm. \r\nSome of the commit should be separate to another PR.\r\nHowever I would like to send my PR for review and confirm design is acceptable or not.\r\n\r\nFollowing PR is related to this PR:\r\n\r\n* Upgrade kubernetes to V1.11.x #3078 or #3017\r\n* Fixed discoveryTokenCACertHashes #3045 \r\n\r\nThey should be closed to clean code.","created_at":"2018-08-05T01:09:34Z","updated_at":"2018-08-23T16:25:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"559ce505b4b1bd8bd658f6711f3544e7749923d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485769464,"node_id":"MDU6TGFiZWw0ODU3Njk0NjQ=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676269920,"node_id":"MDU6TGFiZWw2NzYyNjk5MjA=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3061/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/fbd38f56947361d608e5653094152b0e4cb41c3e","head":{"label":"okamototk:crio","ref":"crio","sha":"fbd38f56947361d608e5653094152b0e4cb41c3e","user":{"login":"okamototk","id":310081,"node_id":"MDQ6VXNlcjMxMDA4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/310081?v=4","gravatar_id":"","url":"https://api.github.com/users/okamototk","html_url":"https://github.com/okamototk","followers_url":"https://api.github.com/users/okamototk/followers","following_url":"https://api.github.com/users/okamototk/following{/other_user}","gists_url":"https://api.github.com/users/okamototk/gists{/gist_id}","starred_url":"https://api.github.com/users/okamototk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okamototk/subscriptions","organizations_url":"https://api.github.com/users/okamototk/orgs","repos_url":"https://api.github.com/users/okamototk/repos","events_url":"https://api.github.com/users/okamototk/events{/privacy}","received_events_url":"https://api.github.com/users/okamototk/received_events","type":"User","site_admin":false},"repo":{"id":140863966,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NjM5NjY=","name":"kubespray","full_name":"okamototk/kubespray","owner":{"login":"okamototk","id":310081,"node_id":"MDQ6VXNlcjMxMDA4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/310081?v=4","gravatar_id":"","url":"https://api.github.com/users/okamototk","html_url":"https://github.com/okamototk","followers_url":"https://api.github.com/users/okamototk/followers","following_url":"https://api.github.com/users/okamototk/following{/other_user}","gists_url":"https://api.github.com/users/okamototk/gists{/gist_id}","starred_url":"https://api.github.com/users/okamototk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okamototk/subscriptions","organizations_url":"https://api.github.com/users/okamototk/orgs","repos_url":"https://api.github.com/users/okamototk/repos","events_url":"https://api.github.com/users/okamototk/events{/privacy}","received_events_url":"https://api.github.com/users/okamototk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okamototk/kubespray","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/okamototk/kubespray","forks_url":"https://api.github.com/repos/okamototk/kubespray/forks","keys_url":"https://api.github.com/repos/okamototk/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okamototk/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okamototk/kubespray/teams","hooks_url":"https://api.github.com/repos/okamototk/kubespray/hooks","issue_events_url":"https://api.github.com/repos/okamototk/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/okamototk/kubespray/events","assignees_url":"https://api.github.com/repos/okamototk/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/okamototk/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/okamototk/kubespray/tags","blobs_url":"https://api.github.com/repos/okamototk/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okamototk/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okamototk/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/okamototk/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okamototk/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/okamototk/kubespray/languages","stargazers_url":"https://api.github.com/repos/okamototk/kubespray/stargazers","contributors_url":"https://api.github.com/repos/okamototk/kubespray/contributors","subscribers_url":"https://api.github.com/repos/okamototk/kubespray/subscribers","subscription_url":"https://api.github.com/repos/okamototk/kubespray/subscription","commits_url":"https://api.github.com/repos/okamototk/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/okamototk/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/okamototk/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/okamototk/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/okamototk/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/okamototk/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okamototk/kubespray/merges","archive_url":"https://api.github.com/repos/okamototk/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okamototk/kubespray/downloads","issues_url":"https://api.github.com/repos/okamototk/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/okamototk/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/okamototk/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/okamototk/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okamototk/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/okamototk/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/okamototk/kubespray/deployments","created_at":"2018-07-13T15:29:19Z","updated_at":"2018-08-09T13:53:39Z","pushed_at":"2018-08-21T19:17:46Z","git_url":"git://github.com/okamototk/kubespray.git","ssh_url":"git@github.com:okamototk/kubespray.git","clone_url":"https://github.com/okamototk/kubespray.git","svn_url":"https://github.com/okamototk/kubespray","homepage":"","size":8249,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"73988585722a110ab8b604fe76e227ea8886a567","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"node_id":"MDEwOlJlcG9zaXRvcnk0MzYxMzQwNA==","name":"kubespray","full_name":"kubernetes-incubator/kubespray","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kubespray","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kubespray","forks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2018-08-23T16:23:03Z","pushed_at":"2018-08-23T16:22:46Z","git_url":"git://github.com/kubernetes-incubator/kubespray.git","ssh_url":"git@github.com:kubernetes-incubator/kubespray.git","clone_url":"https://github.com/kubernetes-incubator/kubespray.git","svn_url":"https://github.com/kubernetes-incubator/kubespray","homepage":"","size":8209,"stargazers_count":3708,"watchers_count":3708,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1469,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1469,"open_issues":432,"watchers":3708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/3061"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3061"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3061/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3061/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/fbd38f56947361d608e5653094152b0e4cb41c3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ant31"}}