{"action":"created","comment":{"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments/168704822","pull_request_review_id":97116391,"id":168704822,"diff_hunk":"@@ -10,8 +10,8 @@ public interface IEntitySerializer\n     {\n         Dictionary<string, object> SerializeSelection<TEntity>(ISelection<TEntity> collection, Query<TEntity> query)\n             where TEntity : class, IEntityBase;\n-        List<Dictionary<string, object>> SerializeEntities<TEntity>(IEnumerable<TEntity> entities, Field<TEntity> fields);\n-        Dictionary<string, object> SerializeEntity<TEntity>(TEntity entity, Field<TEntity> fields);\n+        List<Dictionary<string, object>> SerializeEntities<TEntity>(IEnumerable<TEntity> entities, Field fields);\n+        Dictionary<string, object> SerializeEntity<TEntity>(TEntity entity, Field fields);","path":"Web/RDD.Web/IEntitySerializer.cs","position":7,"original_position":7,"commit_id":"6acec40775a1b6c7e32df42c36f60ebc6c54ac97","original_commit_id":"6acec40775a1b6c7e32df42c36f60ebc6c54ac97","user":{"login":"Poltuu","id":2751539,"avatar_url":"https://avatars2.githubusercontent.com/u/2751539?v=4","gravatar_id":"","url":"https://api.github.com/users/Poltuu","html_url":"https://github.com/Poltuu","followers_url":"https://api.github.com/users/Poltuu/followers","following_url":"https://api.github.com/users/Poltuu/following{/other_user}","gists_url":"https://api.github.com/users/Poltuu/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltuu/subscriptions","organizations_url":"https://api.github.com/users/Poltuu/orgs","repos_url":"https://api.github.com/users/Poltuu/repos","events_url":"https://api.github.com/users/Poltuu/events{/privacy}","received_events_url":"https://api.github.com/users/Poltuu/received_events","type":"User","site_admin":false},"body":"pas très satisfaisant ce changement je trouve, on a l'\"impressiond e perdre une contrainte forte. Le pb est-il lié aux contraintes sur le type générique Tentity ?","created_at":"2018-02-16T09:17:10Z","updated_at":"2018-02-16T09:18:45Z","html_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/90#discussion_r168704822","pull_request_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments/168704822"},"html":{"href":"https://github.com/LuccaSA/RestDrivenDomain/pull/90#discussion_r168704822"},"pull_request":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90","id":169497188,"html_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/90","diff_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/90.diff","patch_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/90.patch","issue_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/90","number":90,"state":"open","locked":false,"title":"MOD : Field<TEntity> => Field","user":{"login":"nfaugout","id":2686141,"avatar_url":"https://avatars0.githubusercontent.com/u/2686141?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaugout","html_url":"https://github.com/nfaugout","followers_url":"https://api.github.com/users/nfaugout/followers","following_url":"https://api.github.com/users/nfaugout/following{/other_user}","gists_url":"https://api.github.com/users/nfaugout/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaugout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaugout/subscriptions","organizations_url":"https://api.github.com/users/nfaugout/orgs","repos_url":"https://api.github.com/users/nfaugout/repos","events_url":"https://api.github.com/users/nfaugout/events{/privacy}","received_events_url":"https://api.github.com/users/nfaugout/received_events","type":"User","site_admin":false},"body":"Field can be used for under-classes or objects, so we don't want to keep TEntity when TEntity does not refer to the root API class\r\n\r\nFIX : under-classes that are value objects where not serialized at all. One had to provide precise fields in order for under-properties to be serialized","created_at":"2018-02-15T22:01:26Z","updated_at":"2018-02-16T09:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05ae16f0d005476b6de1617b5219085565a25654","assignee":{"login":"nfaugout","id":2686141,"avatar_url":"https://avatars0.githubusercontent.com/u/2686141?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaugout","html_url":"https://github.com/nfaugout","followers_url":"https://api.github.com/users/nfaugout/followers","following_url":"https://api.github.com/users/nfaugout/following{/other_user}","gists_url":"https://api.github.com/users/nfaugout/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaugout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaugout/subscriptions","organizations_url":"https://api.github.com/users/nfaugout/orgs","repos_url":"https://api.github.com/users/nfaugout/repos","events_url":"https://api.github.com/users/nfaugout/events{/privacy}","received_events_url":"https://api.github.com/users/nfaugout/received_events","type":"User","site_admin":false},"assignees":[{"login":"nfaugout","id":2686141,"avatar_url":"https://avatars0.githubusercontent.com/u/2686141?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaugout","html_url":"https://github.com/nfaugout","followers_url":"https://api.github.com/users/nfaugout/followers","following_url":"https://api.github.com/users/nfaugout/following{/other_user}","gists_url":"https://api.github.com/users/nfaugout/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaugout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaugout/subscriptions","organizations_url":"https://api.github.com/users/nfaugout/orgs","repos_url":"https://api.github.com/users/nfaugout/repos","events_url":"https://api.github.com/users/nfaugout/events{/privacy}","received_events_url":"https://api.github.com/users/nfaugout/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rducom","id":5228175,"avatar_url":"https://avatars3.githubusercontent.com/u/5228175?v=4","gravatar_id":"","url":"https://api.github.com/users/rducom","html_url":"https://github.com/rducom","followers_url":"https://api.github.com/users/rducom/followers","following_url":"https://api.github.com/users/rducom/following{/other_user}","gists_url":"https://api.github.com/users/rducom/gists{/gist_id}","starred_url":"https://api.github.com/users/rducom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rducom/subscriptions","organizations_url":"https://api.github.com/users/rducom/orgs","repos_url":"https://api.github.com/users/rducom/repos","events_url":"https://api.github.com/users/rducom/events{/privacy}","received_events_url":"https://api.github.com/users/rducom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90/commits","review_comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90/comments","review_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/90/comments","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/6acec40775a1b6c7e32df42c36f60ebc6c54ac97","head":{"label":"LuccaSA:MOD.Fields","ref":"MOD.Fields","sha":"6acec40775a1b6c7e32df42c36f60ebc6c54ac97","user":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":34167748,"name":"RestDrivenDomain","full_name":"LuccaSA/RestDrivenDomain","owner":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuccaSA/RestDrivenDomain","description":null,"fork":false,"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain","forks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/forks","keys_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/teams","hooks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/events","assignees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/tags","blobs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscription","commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/merges","archive_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/downloads","issues_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/deployments","created_at":"2015-04-18T13:56:51Z","updated_at":"2017-10-11T08:03:35Z","pushed_at":"2018-02-15T22:01:26Z","git_url":"git://github.com/LuccaSA/RestDrivenDomain.git","ssh_url":"git@github.com:LuccaSA/RestDrivenDomain.git","clone_url":"https://github.com/LuccaSA/RestDrivenDomain.git","svn_url":"https://github.com/LuccaSA/RestDrivenDomain","homepage":"http://www.restdrivendomain.fr/","size":658,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":1,"open_issues":29,"watchers":3,"default_branch":"master"}},"base":{"label":"LuccaSA:master","ref":"master","sha":"e888713cfb163bf7dad8f1f6f9f983322cf25e3d","user":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":34167748,"name":"RestDrivenDomain","full_name":"LuccaSA/RestDrivenDomain","owner":{"login":"LuccaSA","id":2686158,"avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuccaSA/RestDrivenDomain","description":null,"fork":false,"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain","forks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/forks","keys_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/teams","hooks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/events","assignees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/tags","blobs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscription","commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/merges","archive_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/downloads","issues_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/deployments","created_at":"2015-04-18T13:56:51Z","updated_at":"2017-10-11T08:03:35Z","pushed_at":"2018-02-15T22:01:26Z","git_url":"git://github.com/LuccaSA/RestDrivenDomain.git","ssh_url":"git@github.com:LuccaSA/RestDrivenDomain.git","clone_url":"https://github.com/LuccaSA/RestDrivenDomain.git","svn_url":"https://github.com/LuccaSA/RestDrivenDomain","homepage":"http://www.restdrivendomain.fr/","size":658,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":1,"open_issues":29,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90"},"html":{"href":"https://github.com/LuccaSA/RestDrivenDomain/pull/90"},"issue":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/90"},"comments":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/6acec40775a1b6c7e32df42c36f60ebc6c54ac97"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Poltuu"}}