{"action":"closed","number":3126,"pull_request":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126","id":164898752,"html_url":"https://github.com/STEllAR-GROUP/hpx/pull/3126","diff_url":"https://github.com/STEllAR-GROUP/hpx/pull/3126.diff","patch_url":"https://github.com/STEllAR-GROUP/hpx/pull/3126.patch","issue_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3126","number":3126,"state":"closed","locked":false,"title":"Cleaning up coroutine implementation","user":{"login":"sithhell","id":53655,"avatar_url":"https://avatars3.githubusercontent.com/u/53655?v=4","gravatar_id":"","url":"https://api.github.com/users/sithhell","html_url":"https://github.com/sithhell","followers_url":"https://api.github.com/users/sithhell/followers","following_url":"https://api.github.com/users/sithhell/following{/other_user}","gists_url":"https://api.github.com/users/sithhell/gists{/gist_id}","starred_url":"https://api.github.com/users/sithhell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sithhell/subscriptions","organizations_url":"https://api.github.com/users/sithhell/orgs","repos_url":"https://api.github.com/users/sithhell/repos","events_url":"https://api.github.com/users/sithhell/events{/privacy}","received_events_url":"https://api.github.com/users/sithhell/received_events","type":"User","site_admin":false},"body":"\r\n\r\n## Proposed Changes\r\n\r\n - Removing dynamic memory allocation\r\n - Removing intrusive ptr\r\n - Removing unused functions\r\n - Simplifying thread functions to be nullary\r\n - Using thread_data directly to get/set the state_ex value\r\n\r\n## Any background context you want to provide?\r\n\r\nThis patch both simplifies and cleans up current code. This patch gives a rough speedup of about 1.5x for small grain sizes leading to heavy contention in the thread scheduler.\r\n\r\nThere is a potential breaking change for third party code using thread functions directly. I think this code is minimal and should be mostly under our control.\r\n","created_at":"2018-01-24T16:34:12Z","updated_at":"2018-02-01T08:22:22Z","closed_at":"2018-02-01T08:22:22Z","merged_at":"2018-02-01T08:22:22Z","merge_commit_sha":"4df531ca0a7e52ed5488367126200ae292e186ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26","html_url":"https://github.com/STEllAR-GROUP/hpx/milestone/26","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26/labels","id":2254928,"number":26,"title":"1.1.0","description":"","creator":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":504,"state":"open","created_at":"2017-01-16T14:53:21Z","updated_at":"2018-02-01T08:22:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126/commits","review_comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126/comments","review_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3126/comments","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/9e1648c4682ec7b01a3ba5c7ad028d4b7a6f7fee","head":{"label":"STEllAR-GROUP:coroutine_cleanup","ref":"coroutine_cleanup","sha":"9e1648c4682ec7b01a3ba5c7ad028d4b7a6f7fee","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":4455628,"name":"hpx","full_name":"STEllAR-GROUP/hpx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/deployments","created_at":"2012-05-26T15:02:39Z","updated_at":"2018-02-01T03:06:07Z","pushed_at":"2018-02-01T08:22:22Z","git_url":"git://github.com/STEllAR-GROUP/hpx.git","ssh_url":"git@github.com:STEllAR-GROUP/hpx.git","clone_url":"https://github.com/STEllAR-GROUP/hpx.git","svn_url":"https://github.com/STEllAR-GROUP/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":686893,"stargazers_count":805,"watchers_count":805,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":194,"open_issues":146,"watchers":805,"default_branch":"master"}},"base":{"label":"STEllAR-GROUP:master","ref":"master","sha":"ff49251fdfe96ba022d92d13cc0a02d5f7b9d569","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":4455628,"name":"hpx","full_name":"STEllAR-GROUP/hpx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/deployments","created_at":"2012-05-26T15:02:39Z","updated_at":"2018-02-01T03:06:07Z","pushed_at":"2018-02-01T08:22:22Z","git_url":"git://github.com/STEllAR-GROUP/hpx.git","ssh_url":"git@github.com:STEllAR-GROUP/hpx.git","clone_url":"https://github.com/STEllAR-GROUP/hpx.git","svn_url":"https://github.com/STEllAR-GROUP/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":686893,"stargazers_count":805,"watchers_count":805,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":194,"open_issues":146,"watchers":805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126"},"html":{"href":"https://github.com/STEllAR-GROUP/hpx/pull/3126"},"issue":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3126"},"comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3126/comments"},"review_comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126/comments"},"review_comment":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3126/commits"},"statuses":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/9e1648c4682ec7b01a3ba5c7ad028d4b7a6f7fee"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"msimberg","id":42977,"avatar_url":"https://avatars0.githubusercontent.com/u/42977?v=4","gravatar_id":"","url":"https://api.github.com/users/msimberg","html_url":"https://github.com/msimberg","followers_url":"https://api.github.com/users/msimberg/followers","following_url":"https://api.github.com/users/msimberg/following{/other_user}","gists_url":"https://api.github.com/users/msimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/msimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimberg/subscriptions","organizations_url":"https://api.github.com/users/msimberg/orgs","repos_url":"https://api.github.com/users/msimberg/repos","events_url":"https://api.github.com/users/msimberg/events{/privacy}","received_events_url":"https://api.github.com/users/msimberg/received_events","type":"User","site_admin":false},"comments":3,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":157,"deletions":776,"changed_files":29}}
{"actor":{"display_login":"msimberg"}}