{"action":"created","issue":{"url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/3","repository_url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC","labels_url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/3/comments","events_url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/3/events","html_url":"https://github.com/ucb-art/BAG2_TEMPLATES_EC/pull/3","id":369871087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjk1MjA1","number":3,"title":"Gf14 compatibility","user":{"login":"ayan-biswas","id":31327482,"node_id":"MDQ6VXNlcjMxMzI3NDgy","avatar_url":"https://avatars2.githubusercontent.com/u/31327482?v=4","gravatar_id":"","url":"https://api.github.com/users/ayan-biswas","html_url":"https://github.com/ayan-biswas","followers_url":"https://api.github.com/users/ayan-biswas/followers","following_url":"https://api.github.com/users/ayan-biswas/following{/other_user}","gists_url":"https://api.github.com/users/ayan-biswas/gists{/gist_id}","starred_url":"https://api.github.com/users/ayan-biswas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayan-biswas/subscriptions","organizations_url":"https://api.github.com/users/ayan-biswas/orgs","repos_url":"https://api.github.com/users/ayan-biswas/repos","events_url":"https://api.github.com/users/ayan-biswas/events{/privacy}","received_events_url":"https://api.github.com/users/ayan-biswas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-14T06:01:06Z","updated_at":"2018-10-23T23:58:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/pulls/3","html_url":"https://github.com/ucb-art/BAG2_TEMPLATES_EC/pull/3","diff_url":"https://github.com/ucb-art/BAG2_TEMPLATES_EC/pull/3.diff","patch_url":"https://github.com/ucb-art/BAG2_TEMPLATES_EC/pull/3.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/comments/432463464","html_url":"https://github.com/ucb-art/BAG2_TEMPLATES_EC/pull/3#issuecomment-432463464","issue_url":"https://api.github.com/repos/ucb-art/BAG2_TEMPLATES_EC/issues/3","id":432463464,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ2MzQ2NA==","user":{"login":"pkerichang","id":7808212,"node_id":"MDQ6VXNlcjc4MDgyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7808212?v=4","gravatar_id":"","url":"https://api.github.com/users/pkerichang","html_url":"https://github.com/pkerichang","followers_url":"https://api.github.com/users/pkerichang/followers","following_url":"https://api.github.com/users/pkerichang/following{/other_user}","gists_url":"https://api.github.com/users/pkerichang/gists{/gist_id}","starred_url":"https://api.github.com/users/pkerichang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkerichang/subscriptions","organizations_url":"https://api.github.com/users/pkerichang/orgs","repos_url":"https://api.github.com/users/pkerichang/repos","events_url":"https://api.github.com/users/pkerichang/events{/privacy}","received_events_url":"https://api.github.com/users/pkerichang/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T23:58:45Z","updated_at":"2018-10-23T23:58:45Z","author_association":"COLLABORATOR","body":"Reproducing response from Ayan:\r\n\r\n```\r\nHi Eric,\r\n\r\nI noticed that you asked me to remove \"or is_sub_ring\" in 10 places in finfet.py. Things will not work if I do that.\r\n\r\nThere are some independent if-else checks based on only \"is_planar_sub\" or only \"is_sub_ring\". I removed the dependence of those 2 flags on each other, so essentially, these are the meanings of those 2 flags:\r\n\r\nis_planar_sub    is_sub_ring    Substrate type\r\nFalse                  False              transistor type (DigitalBase)\r\nTrue                    False             guard ring type (AnalogBase), NO poly\r\nFalse                  True               guard ring type (AnalogBase) with poly \r\nTrue                    True               NA\r\n\r\nline 517-525 in finfet.py shows the independent use of the 2 flags\r\n\r\nHence, the if-else clauses which check \"(is_planar_sub or is_sub_ring)\" cannot be replaced by only \"is_planar_sub\". The \"is_planar_sub\" is technically a misnomer since guard ring blocks actually have \"is_planar_sub = False\".\r\n\r\nPlease let me know if my understanding is wrong, and if you have a different implementation style in mind.\r\n```"}}
{"actor":{"display_login":"pkerichang"}}