{"action":"created","issue":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/520","repository_url":"https://api.github.com/repos/swift-nav/piksi_buildroot","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/520/labels{/name}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/520/comments","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/520/events","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/520","id":301139932,"number":520,"title":"[DEV] Refactor libpiksi settings for watchers","user":{"login":"benjaminaltieri","id":5225320,"avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-28T18:51:18Z","updated_at":"2018-02-28T19:34:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/520","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/520","diff_url":"https://github.com/swift-nav/piksi_buildroot/pull/520.diff","patch_url":"https://github.com/swift-nav/piksi_buildroot/pull/520.patch"},"body":"This is the dev PR for #506 with modifications to implement the write response changes from #397 which wasn't included in the v1.4.0-release\r\n\r\nFrom the dev PR:\r\n\r\nThe initial implementation of settings watchers for the health daemon was a bit copy-pasta.\r\n\r\nThis refactor covers lightly refactoring libpiksi/settings to allow settings nodes to be registered to a client that do not perform registration and only response to read responses as a way to 'watch' a particular setting.\r\n\r\nNotes:\r\n\r\n * Most code has merely been moved into smaller functions but the parse code has been\r\ntaken from health_daemon\r\n * Much of this code is functionally similar to that in the settings_daemon, the next step would be\r\nto condense that code as well\r\n * No implementation has been performed in this PR, I will refactor health_daemon and\r\nothers (like the simulation check in the rtcm3 bridge) as separate pull requests.\r\n * The commits are intentionally discrete, all will be squashed if/when merged"},"comment":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments/369356546","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/520#issuecomment-369356546","issue_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/520","id":369356546,"user":{"login":"anonymous-travis-swiftnav","id":21373101,"avatar_url":"https://avatars2.githubusercontent.com/u/21373101?v=4","gravatar_id":"","url":"https://api.github.com/users/anonymous-travis-swiftnav","html_url":"https://github.com/anonymous-travis-swiftnav","followers_url":"https://api.github.com/users/anonymous-travis-swiftnav/followers","following_url":"https://api.github.com/users/anonymous-travis-swiftnav/following{/other_user}","gists_url":"https://api.github.com/users/anonymous-travis-swiftnav/gists{/gist_id}","starred_url":"https://api.github.com/users/anonymous-travis-swiftnav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonymous-travis-swiftnav/subscriptions","organizations_url":"https://api.github.com/users/anonymous-travis-swiftnav/orgs","repos_url":"https://api.github.com/users/anonymous-travis-swiftnav/repos","events_url":"https://api.github.com/users/anonymous-travis-swiftnav/events{/privacy}","received_events_url":"https://api.github.com/users/anonymous-travis-swiftnav/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T19:34:59Z","updated_at":"2018-02-28T19:34:59Z","author_association":"COLLABORATOR","body":"## v1.3.0-develop-2018022417-6-ge13be16\n+ [Artifacts (HITL Dashboard Page)](http://hitl-dashboard.swiftnav.com/files/swiftnav-artifacts-pull-requests/piksi_buildroot/v1.3.0-develop-2018022417-6-ge13be16/)\n+ [Artifacts (S3 / AWS Console)](https://console.aws.amazon.com/s3/home?region=us-west-2&bucket=swiftnav-artifacts-pull-requests&prefix=piksi_buildroot/v1.3.0-develop-2018022417-6-ge13be16/)\n+ s3://swiftnav-artifacts-pull-requests/piksi_buildroot/v1.3.0-develop-2018022417-6-ge13be16"}}
{"actor":{"display_login":"anonymous-travis-swiftnav"}}