{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-iam/cis/pulls/comments/187495393","pull_request_review_id":119287899,"id":187495393,"diff_hunk":"@@ -218,130 +286,44 @@\n                 \"metadata\",\n                 \"value\"\n             ],\n-            \"title\": \"A key:value string\"\n+            \"title\": \"SimpleField\"\n         },\n-        \"DateValue\": {\n-            \"type\": \"object\",\n-            \"additionalProperties\": false,\n-            \"properties\": {\n-                \"metadata\": {\n-                    \"$ref\": \"#/definitions/Metadata\"\n-                },\n-                \"value\": {\n-                    \"type\": \"string\",\n-                    \"format\": \"date-time\"\n-                }\n-            },\n-            \"required\": [\n-                \"metadata\",\n-                \"value\"\n-            ],\n-            \"title\": \"A key:value string which contains a date\"\n-        },\n-        \"AccessInformation\": {\n-            \"type\": \"object\",\n-            \"additionalProperties\": false,\n-            \"properties\": {\n-                \"ldap\": {\n-                    \"$ref\": \"#/definitions/Auth0\"\n-                },\n-                \"mozilliansorg\": {\n-                    \"$ref\": \"#/definitions/Auth0\"\n-                },\n-                \"hris\": {\n-                    \"$ref\": \"#/definitions/Auth0\"\n-                },\n-                \"auth0\": {\n-                    \"$ref\": \"#/definitions/Auth0\"\n-                }\n-            },\n-            \"title\": \"AccessInformation\"\n-        },\n-        \"Auth0\": {\n-            \"type\": \"object\",\n-            \"additionalProperties\": false,\n-            \"properties\": {\n-                \"metadata\": {\n-                    \"$ref\": \"#/definitions/Metadata\"\n-                },\n-                \"value\": {\n-                    \"type\": \"array\",\n-                    \"items\": {\n-                        \"$ref\": \"#/definitions/Auth0Value\"\n-                    }\n-                }\n-            },\n-            \"required\": [\n-                \"metadata\",\n-                \"value\"\n+        \"Classification\": {\n+            \"type\": \"string\",\n+            \"enum\": [\n+                \"PUBLIC\",\n+                \"MOZILLA CONFIDENTIAL\",\n+                \"WORKGROUP CONFIDENTIAL: STAFF ONLY\",\n+                \"WORKGROUP CONFIDENTIAL\",\n+                \"INDIVIDUAL CONFIDENTIAL\"\n             ],\n-            \"title\": \"Auth0\"\n+            \"title\": \"Classification\"\n         },\n-        \"Auth0Value\": {\n-            \"type\": \"object\",\n-            \"additionalProperties\": false,\n-            \"properties\": {\n-                \"created\": {\n-                    \"type\": \"string\",\n-                    \"format\": \"date-time\"\n-                },\n-                \"lastUsed\": {\n-                    \"type\": \"string\",\n-                    \"format\": \"date-time\"\n-                },\n-                \"name\": {\n-                    \"type\": \"string\"\n-                },\n-                \"value\": {\n-                    \"oneOf\": [\n-                        {\n-                            \"type\": \"null\"\n-                        },\n-                        {\n-                            \"type\": \"string\"\n-                        }\n-                    ]\n-                }\n-            },\n-            \"required\": [\n-                \"name\",\n-                \"value\"\n+        \"Publisher\": {\n+            \"type\": \"string\",\n+            \"enum\": [\n+                \"auth0\",\n+                \"mozilliansorg\",\n+                \"ldap\",\n+                \"hris\"\n             ],\n-            \"title\": \"Auth0Value\"\n+            \"title\": \"Publisher\"\n         },\n-        \"ValueUnion\": {\n-            \"oneOf\": [\n-                {\n-                    \"type\": \"array\",\n-                    \"items\": {\n-                        \"$ref\": \"#/definitions/ValueValue\"\n-                    }\n-                },\n-                {\n-                    \"type\": \"null\"\n-                },\n-                {\n-                    \"type\": \"string\"\n-                }\n-            ],\n-            \"title\": \"ValueUnion\"\n+        \"Name\": {\n+            \"type\": \"string\",\n+            \"title\": \"Name\"\n         },\n-        \"Signature\": {\n+        \"Type\": {","path":"docs/rfcs/UserProfilesv2_schema.json","position":465,"original_position":465,"commit_id":"a6a0375e900955c0e19a5c745e3354ac24a6ee42","original_commit_id":"a6a0375e900955c0e19a5c745e3354ac24a6ee42","user":{"login":"gene1wood","id":1134034,"avatar_url":"https://avatars0.githubusercontent.com/u/1134034?v=4","gravatar_id":"","url":"https://api.github.com/users/gene1wood","html_url":"https://github.com/gene1wood","followers_url":"https://api.github.com/users/gene1wood/followers","following_url":"https://api.github.com/users/gene1wood/following{/other_user}","gists_url":"https://api.github.com/users/gene1wood/gists{/gist_id}","starred_url":"https://api.github.com/users/gene1wood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gene1wood/subscriptions","organizations_url":"https://api.github.com/users/gene1wood/orgs","repos_url":"https://api.github.com/users/gene1wood/repos","events_url":"https://api.github.com/users/gene1wood/events{/privacy}","received_events_url":"https://api.github.com/users/gene1wood/received_events","type":"User","site_admin":false},"body":"Is there any value in clarifying this schema type with instead of `Type` something like `SignatureType`?","created_at":"2018-05-11T00:32:07Z","updated_at":"2018-05-11T00:33:11Z","html_url":"https://github.com/mozilla-iam/cis/pull/110#discussion_r187495393","pull_request_url":"https://api.github.com/repos/mozilla-iam/cis/pulls/110","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/comments/187495393"},"html":{"href":"https://github.com/mozilla-iam/cis/pull/110#discussion_r187495393"},"pull_request":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-iam/cis/pulls/110","id":187334680,"html_url":"https://github.com/mozilla-iam/cis/pull/110","diff_url":"https://github.com/mozilla-iam/cis/pull/110.diff","patch_url":"https://github.com/mozilla-iam/cis/pull/110.patch","issue_url":"https://api.github.com/repos/mozilla-iam/cis/issues/110","number":110,"state":"open","locked":false,"title":"Profilev2","user":{"login":"gdestuynder","id":956866,"avatar_url":"https://avatars3.githubusercontent.com/u/956866?v=4","gravatar_id":"","url":"https://api.github.com/users/gdestuynder","html_url":"https://github.com/gdestuynder","followers_url":"https://api.github.com/users/gdestuynder/followers","following_url":"https://api.github.com/users/gdestuynder/following{/other_user}","gists_url":"https://api.github.com/users/gdestuynder/gists{/gist_id}","starred_url":"https://api.github.com/users/gdestuynder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdestuynder/subscriptions","organizations_url":"https://api.github.com/users/gdestuynder/orgs","repos_url":"https://api.github.com/users/gdestuynder/repos","events_url":"https://api.github.com/users/gdestuynder/events{/privacy}","received_events_url":"https://api.github.com/users/gdestuynder/received_events","type":"User","site_admin":false},"body":"Fixes discussed with gene and andrew\r\nthis needs squashing.\r\nhttps://github.com/gdestuynder/cis/blob/profilev2/docs/rfcs/UserProfilesv2.json\r\nhttps://github.com/gdestuynder/cis/blob/profilev2/docs/rfcs/UserProfilesv2_schema.json\r\n\r\nverify @ https://www.jsonschemavalidator.net/ draft 4-6-7 compatible\r\n\r\n","created_at":"2018-05-10T23:40:36Z","updated_at":"2018-05-11T00:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"887313acedb840a183f7d14680060429063374a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrewkrug","id":2502523,"avatar_url":"https://avatars3.githubusercontent.com/u/2502523?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkrug","html_url":"https://github.com/andrewkrug","followers_url":"https://api.github.com/users/andrewkrug/followers","following_url":"https://api.github.com/users/andrewkrug/following{/other_user}","gists_url":"https://api.github.com/users/andrewkrug/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkrug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkrug/subscriptions","organizations_url":"https://api.github.com/users/andrewkrug/orgs","repos_url":"https://api.github.com/users/andrewkrug/repos","events_url":"https://api.github.com/users/andrewkrug/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkrug/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-iam/cis/pulls/110/commits","review_comments_url":"https://api.github.com/repos/mozilla-iam/cis/pulls/110/comments","review_comment_url":"https://api.github.com/repos/mozilla-iam/cis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-iam/cis/issues/110/comments","statuses_url":"https://api.github.com/repos/mozilla-iam/cis/statuses/a6a0375e900955c0e19a5c745e3354ac24a6ee42","head":{"label":"gdestuynder:profilev2","ref":"profilev2","sha":"a6a0375e900955c0e19a5c745e3354ac24a6ee42","user":{"login":"gdestuynder","id":956866,"avatar_url":"https://avatars3.githubusercontent.com/u/956866?v=4","gravatar_id":"","url":"https://api.github.com/users/gdestuynder","html_url":"https://github.com/gdestuynder","followers_url":"https://api.github.com/users/gdestuynder/followers","following_url":"https://api.github.com/users/gdestuynder/following{/other_user}","gists_url":"https://api.github.com/users/gdestuynder/gists{/gist_id}","starred_url":"https://api.github.com/users/gdestuynder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdestuynder/subscriptions","organizations_url":"https://api.github.com/users/gdestuynder/orgs","repos_url":"https://api.github.com/users/gdestuynder/repos","events_url":"https://api.github.com/users/gdestuynder/events{/privacy}","received_events_url":"https://api.github.com/users/gdestuynder/received_events","type":"User","site_admin":false},"repo":{"id":90669940,"name":"cis","full_name":"gdestuynder/cis","owner":{"login":"gdestuynder","id":956866,"avatar_url":"https://avatars3.githubusercontent.com/u/956866?v=4","gravatar_id":"","url":"https://api.github.com/users/gdestuynder","html_url":"https://github.com/gdestuynder","followers_url":"https://api.github.com/users/gdestuynder/followers","following_url":"https://api.github.com/users/gdestuynder/following{/other_user}","gists_url":"https://api.github.com/users/gdestuynder/gists{/gist_id}","starred_url":"https://api.github.com/users/gdestuynder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdestuynder/subscriptions","organizations_url":"https://api.github.com/users/gdestuynder/orgs","repos_url":"https://api.github.com/users/gdestuynder/repos","events_url":"https://api.github.com/users/gdestuynder/events{/privacy}","received_events_url":"https://api.github.com/users/gdestuynder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdestuynder/cis","description":"Home of Mozilla IAM change integration service repository.","fork":true,"url":"https://api.github.com/repos/gdestuynder/cis","forks_url":"https://api.github.com/repos/gdestuynder/cis/forks","keys_url":"https://api.github.com/repos/gdestuynder/cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdestuynder/cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdestuynder/cis/teams","hooks_url":"https://api.github.com/repos/gdestuynder/cis/hooks","issue_events_url":"https://api.github.com/repos/gdestuynder/cis/issues/events{/number}","events_url":"https://api.github.com/repos/gdestuynder/cis/events","assignees_url":"https://api.github.com/repos/gdestuynder/cis/assignees{/user}","branches_url":"https://api.github.com/repos/gdestuynder/cis/branches{/branch}","tags_url":"https://api.github.com/repos/gdestuynder/cis/tags","blobs_url":"https://api.github.com/repos/gdestuynder/cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdestuynder/cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdestuynder/cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdestuynder/cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdestuynder/cis/statuses/{sha}","languages_url":"https://api.github.com/repos/gdestuynder/cis/languages","stargazers_url":"https://api.github.com/repos/gdestuynder/cis/stargazers","contributors_url":"https://api.github.com/repos/gdestuynder/cis/contributors","subscribers_url":"https://api.github.com/repos/gdestuynder/cis/subscribers","subscription_url":"https://api.github.com/repos/gdestuynder/cis/subscription","commits_url":"https://api.github.com/repos/gdestuynder/cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdestuynder/cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdestuynder/cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdestuynder/cis/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdestuynder/cis/contents/{+path}","compare_url":"https://api.github.com/repos/gdestuynder/cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdestuynder/cis/merges","archive_url":"https://api.github.com/repos/gdestuynder/cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdestuynder/cis/downloads","issues_url":"https://api.github.com/repos/gdestuynder/cis/issues{/number}","pulls_url":"https://api.github.com/repos/gdestuynder/cis/pulls{/number}","milestones_url":"https://api.github.com/repos/gdestuynder/cis/milestones{/number}","notifications_url":"https://api.github.com/repos/gdestuynder/cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdestuynder/cis/labels{/name}","releases_url":"https://api.github.com/repos/gdestuynder/cis/releases{/id}","deployments_url":"https://api.github.com/repos/gdestuynder/cis/deployments","created_at":"2017-05-08T20:32:29Z","updated_at":"2018-03-27T18:21:36Z","pushed_at":"2018-05-10T23:37:46Z","git_url":"git://github.com/gdestuynder/cis.git","ssh_url":"git@github.com:gdestuynder/cis.git","clone_url":"https://github.com/gdestuynder/cis.git","svn_url":"https://github.com/gdestuynder/cis","homepage":null,"size":323,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-iam:master","ref":"master","sha":"6a2e539a112e032b325330db6fb7da20a569ba60","user":{"login":"mozilla-iam","id":22923188,"avatar_url":"https://avatars1.githubusercontent.com/u/22923188?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iam","html_url":"https://github.com/mozilla-iam","followers_url":"https://api.github.com/users/mozilla-iam/followers","following_url":"https://api.github.com/users/mozilla-iam/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iam/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iam/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iam/orgs","repos_url":"https://api.github.com/users/mozilla-iam/repos","events_url":"https://api.github.com/users/mozilla-iam/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iam/received_events","type":"Organization","site_admin":false},"repo":{"id":87564246,"name":"cis","full_name":"mozilla-iam/cis","owner":{"login":"mozilla-iam","id":22923188,"avatar_url":"https://avatars1.githubusercontent.com/u/22923188?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iam","html_url":"https://github.com/mozilla-iam","followers_url":"https://api.github.com/users/mozilla-iam/followers","following_url":"https://api.github.com/users/mozilla-iam/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iam/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iam/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iam/orgs","repos_url":"https://api.github.com/users/mozilla-iam/repos","events_url":"https://api.github.com/users/mozilla-iam/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-iam/cis","description":"Home of Mozilla IAM change integration service repository.","fork":false,"url":"https://api.github.com/repos/mozilla-iam/cis","forks_url":"https://api.github.com/repos/mozilla-iam/cis/forks","keys_url":"https://api.github.com/repos/mozilla-iam/cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-iam/cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-iam/cis/teams","hooks_url":"https://api.github.com/repos/mozilla-iam/cis/hooks","issue_events_url":"https://api.github.com/repos/mozilla-iam/cis/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-iam/cis/events","assignees_url":"https://api.github.com/repos/mozilla-iam/cis/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-iam/cis/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-iam/cis/tags","blobs_url":"https://api.github.com/repos/mozilla-iam/cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-iam/cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-iam/cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-iam/cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-iam/cis/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-iam/cis/languages","stargazers_url":"https://api.github.com/repos/mozilla-iam/cis/stargazers","contributors_url":"https://api.github.com/repos/mozilla-iam/cis/contributors","subscribers_url":"https://api.github.com/repos/mozilla-iam/cis/subscribers","subscription_url":"https://api.github.com/repos/mozilla-iam/cis/subscription","commits_url":"https://api.github.com/repos/mozilla-iam/cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-iam/cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-iam/cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-iam/cis/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-iam/cis/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-iam/cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-iam/cis/merges","archive_url":"https://api.github.com/repos/mozilla-iam/cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-iam/cis/downloads","issues_url":"https://api.github.com/repos/mozilla-iam/cis/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-iam/cis/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-iam/cis/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-iam/cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-iam/cis/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-iam/cis/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-iam/cis/deployments","created_at":"2017-04-07T16:09:17Z","updated_at":"2018-05-09T21:59:40Z","pushed_at":"2018-05-10T23:40:36Z","git_url":"git://github.com/mozilla-iam/cis.git","ssh_url":"git@github.com:mozilla-iam/cis.git","clone_url":"https://github.com/mozilla-iam/cis.git","svn_url":"https://github.com/mozilla-iam/cis","homepage":null,"size":296,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":5,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/110"},"html":{"href":"https://github.com/mozilla-iam/cis/pull/110"},"issue":{"href":"https://api.github.com/repos/mozilla-iam/cis/issues/110"},"comments":{"href":"https://api.github.com/repos/mozilla-iam/cis/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-iam/cis/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-iam/cis/statuses/a6a0375e900955c0e19a5c745e3354ac24a6ee42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gene1wood"}}