{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/209105722","pull_request_review_id":145058505,"id":209105722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTEwNTcyMg==","diff_hunk":"@@ -12,9 +12,10 @@\n \n define([\n   'okta',\n-  'vendor/lib/q'\n+  'vendor/lib/q',\n+  'util/Enums',\n ],\n-function (Okta, Q) {\n+function (Okta, Q, Enums) {\n \n   var _ = Okta._;\n   var KNOWN_ERRORS = [","path":"src/models/BaseLoginModel.js","position":12,"original_position":12,"commit_id":"00c3fc347d230f0566e0f498a0a047a84b172117","original_commit_id":"00c3fc347d230f0566e0f498a0a047a84b172117","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"body":"Lol yeah this has to be cleaned up.  I checked its usage and seems like it doesnt make sense to add it to Known errors array.","created_at":"2018-08-09T23:10:40Z","updated_at":"2018-08-09T23:10:40Z","html_url":"https://github.com/okta/okta-signin-widget/pull/516#discussion_r209105722","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/209105722"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/516#discussion_r209105722"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516"}},"in_reply_to_id":209103337},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516","id":207118271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTE4Mjcx","html_url":"https://github.com/okta/okta-signin-widget/pull/516","diff_url":"https://github.com/okta/okta-signin-widget/pull/516.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/516.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/516","number":516,"state":"open","locked":false,"title":"Fix for Okta-165796 - cancel polling if factor was switched","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"body":"* If factor was switched before initial delay the poll still hapened.\r\nNow we listen on factor switch and then clear the timout causing the delay.\r\n\r\n* Once we go past the initial delay we stop listening on the factor change because\r\ncancelling poll is handled by AuthJS once the poll is initiated.\r\neg) Once previous is invoked as a result of switching factor AuthJS cancells poll.\r\n\r\n![pushfix](https://user-images.githubusercontent.com/17267130/43865898-c6c4c124-9b18-11e8-9215-2065bf66561e.gif)\r\n![pushfix2](https://user-images.githubusercontent.com/17267130/43865899-c6dfdde2-9b18-11e8-8640-a066ee7b5764.gif)\r\n\r\n\r\nOriginal issue \r\n\r\n![pushfix3](https://user-images.githubusercontent.com/17267130/43866007-22d4bcf8-9b19-11e8-964e-c7247ffd1c4c.gif)\r\n\r\n\r\nRejection of promise\r\n\r\n![pushfix4](https://user-images.githubusercontent.com/17267130/43929007-01d410d8-9be8-11e8-8488-ba7ee423ac18.gif)\r\n","created_at":"2018-08-08T19:49:53Z","updated_at":"2018-08-09T23:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46b3183245a8e7dd940a5285a4978f123f48c5ec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rchild-okta","id":2889612,"node_id":"MDQ6VXNlcjI4ODk2MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2889612?v=4","gravatar_id":"","url":"https://api.github.com/users/rchild-okta","html_url":"https://github.com/rchild-okta","followers_url":"https://api.github.com/users/rchild-okta/followers","following_url":"https://api.github.com/users/rchild-okta/following{/other_user}","gists_url":"https://api.github.com/users/rchild-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/rchild-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchild-okta/subscriptions","organizations_url":"https://api.github.com/users/rchild-okta/orgs","repos_url":"https://api.github.com/users/rchild-okta/repos","events_url":"https://api.github.com/users/rchild-okta/events{/privacy}","received_events_url":"https://api.github.com/users/rchild-okta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/516/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/00c3fc347d230f0566e0f498a0a047a84b172117","head":{"label":"magizh-okta:mt-okta-165796-polling-fix","ref":"mt-okta-165796-polling-fix","sha":"00c3fc347d230f0566e0f498a0a047a84b172117","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"repo":{"id":86117589,"node_id":"MDEwOlJlcG9zaXRvcnk4NjExNzU4OQ==","name":"okta-signin-widget","full_name":"magizh-okta/okta-signin-widget","owner":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magizh-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/magizh-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/deployments","created_at":"2017-03-24T23:07:17Z","updated_at":"2018-08-07T19:08:50Z","pushed_at":"2018-08-09T22:55:07Z","git_url":"git://github.com/magizh-okta/okta-signin-widget.git","ssh_url":"git@github.com:magizh-okta/okta-signin-widget.git","clone_url":"https://github.com/magizh-okta/okta-signin-widget.git","svn_url":"https://github.com/magizh-okta/okta-signin-widget","homepage":null,"size":19100,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"c408534fafa1f4d3bb36f64ec1ee01dcf98c0f6f","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-08-07T22:07:05Z","pushed_at":"2018-08-09T22:55:09Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":19359,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":87,"open_issues":45,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/516"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/516"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/00c3fc347d230f0566e0f498a0a047a84b172117"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"magizh-okta"}}