{"action":"created","comment":{"url":"https://api.github.com/repos/flatpak/flatpak/pulls/comments/233690032","pull_request_review_id":175163595,"id":233690032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY5MDAzMg==","diff_hunk":"@@ -3924,29 +3926,54 @@ flatpak_extension_matches_reason (const char *extension_id,\n     return FALSE;\n   extension_basename += 1;\n \n-  if (strcmp (reason, \"active-gl-driver\") == 0)\n+  reason_list = g_strsplit (reason, \";\", -1);\n+\n+  for (i = 0; reason_list[i]; ++i)\n     {\n-      /* handled below */\n-      const char **gl_drivers = flatpak_get_gl_drivers ();\n-      int i;\n+      const char *reason = reason_list[i];\n \n-      for (i = 0; gl_drivers[i] != NULL; i++)\n+      if (strcmp (reason, \"active-gl-driver\") == 0)\n         {\n-          if (strcmp (gl_drivers[i], extension_basename) == 0)\n+          /* handled below */\n+          const char **gl_drivers = flatpak_get_gl_drivers ();\n+          size_t j;\n+\n+          for (j = 0; gl_drivers[j] != NULL; j++)","path":"common/flatpak-utils.c","position":31,"original_position":31,"commit_id":"1b6924458537da259d1ce5721fde30bfde1c5824","original_commit_id":"1b6924458537da259d1ce5721fde30bfde1c5824","user":{"login":"matthiasclasen","id":4834845,"node_id":"MDQ6VXNlcjQ4MzQ4NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4834845?v=4","gravatar_id":"","url":"https://api.github.com/users/matthiasclasen","html_url":"https://github.com/matthiasclasen","followers_url":"https://api.github.com/users/matthiasclasen/followers","following_url":"https://api.github.com/users/matthiasclasen/following{/other_user}","gists_url":"https://api.github.com/users/matthiasclasen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasclasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasclasen/subscriptions","organizations_url":"https://api.github.com/users/matthiasclasen/orgs","repos_url":"https://api.github.com/users/matthiasclasen/repos","events_url":"https://api.github.com/users/matthiasclasen/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasclasen/received_events","type":"User","site_admin":false},"body":"...and here you have an != NULL in there. I guess this was copied from before","created_at":"2018-11-15T02:03:16Z","updated_at":"2018-11-15T02:03:17Z","html_url":"https://github.com/flatpak/flatpak/pull/1436#discussion_r233690032","pull_request_url":"https://api.github.com/repos/flatpak/flatpak/pulls/1436","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/comments/233690032"},"html":{"href":"https://github.com/flatpak/flatpak/pull/1436#discussion_r233690032"},"pull_request":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/1436"}}},"pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak/pulls/1436","id":170116042,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcwMTE2MDQy","html_url":"https://github.com/flatpak/flatpak/pull/1436","diff_url":"https://github.com/flatpak/flatpak/pull/1436.diff","patch_url":"https://github.com/flatpak/flatpak/pull/1436.patch","issue_url":"https://api.github.com/repos/flatpak/flatpak/issues/1436","number":1436,"state":"open","locked":false,"title":"Add \"on-xdg-desktop-\" check for Qt platform extension","user":{"login":"TingPing","id":798838,"node_id":"MDQ6VXNlcjc5ODgzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-20T07:13:56Z","updated_at":"2018-11-15T02:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfc53eb15aa8c0195e8012016e57c7ad85395736","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flatpak/flatpak/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/flatpak/flatpak/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/flatpak/flatpak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flatpak/flatpak/issues/1436/comments","statuses_url":"https://api.github.com/repos/flatpak/flatpak/statuses/1b6924458537da259d1ce5721fde30bfde1c5824","head":{"label":"TingPing:qt-platform","ref":"qt-platform","sha":"1b6924458537da259d1ce5721fde30bfde1c5824","user":{"login":"TingPing","id":798838,"node_id":"MDQ6VXNlcjc5ODgzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"repo":{"id":63713580,"node_id":"MDEwOlJlcG9zaXRvcnk2MzcxMzU4MA==","name":"flatpak","full_name":"TingPing/flatpak","private":false,"owner":{"login":"TingPing","id":798838,"node_id":"MDQ6VXNlcjc5ODgzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TingPing/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":true,"url":"https://api.github.com/repos/TingPing/flatpak","forks_url":"https://api.github.com/repos/TingPing/flatpak/forks","keys_url":"https://api.github.com/repos/TingPing/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TingPing/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TingPing/flatpak/teams","hooks_url":"https://api.github.com/repos/TingPing/flatpak/hooks","issue_events_url":"https://api.github.com/repos/TingPing/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/TingPing/flatpak/events","assignees_url":"https://api.github.com/repos/TingPing/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/TingPing/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/TingPing/flatpak/tags","blobs_url":"https://api.github.com/repos/TingPing/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TingPing/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TingPing/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/TingPing/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TingPing/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/TingPing/flatpak/languages","stargazers_url":"https://api.github.com/repos/TingPing/flatpak/stargazers","contributors_url":"https://api.github.com/repos/TingPing/flatpak/contributors","subscribers_url":"https://api.github.com/repos/TingPing/flatpak/subscribers","subscription_url":"https://api.github.com/repos/TingPing/flatpak/subscription","commits_url":"https://api.github.com/repos/TingPing/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/TingPing/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/TingPing/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/TingPing/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/TingPing/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/TingPing/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TingPing/flatpak/merges","archive_url":"https://api.github.com/repos/TingPing/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TingPing/flatpak/downloads","issues_url":"https://api.github.com/repos/TingPing/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/TingPing/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/TingPing/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/TingPing/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TingPing/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/TingPing/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/TingPing/flatpak/deployments","created_at":"2016-07-19T17:17:26Z","updated_at":"2016-07-19T17:17:28Z","pushed_at":"2018-11-14T22:00:56Z","git_url":"git://github.com/TingPing/flatpak.git","ssh_url":"git@github.com:TingPing/flatpak.git","clone_url":"https://github.com/TingPing/flatpak.git","svn_url":"https://github.com/TingPing/flatpak","homepage":"http://flatpak.org","size":15184,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flatpak:master","ref":"master","sha":"9e6287aa0eb461661ad88317e6b571cff99b8cd8","user":{"login":"flatpak","id":19473042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMDQy","avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"repo":{"id":59213200,"node_id":"MDEwOlJlcG9zaXRvcnk1OTIxMzIwMA==","name":"flatpak","full_name":"flatpak/flatpak","private":false,"owner":{"login":"flatpak","id":19473042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMDQy","avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flatpak/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":false,"url":"https://api.github.com/repos/flatpak/flatpak","forks_url":"https://api.github.com/repos/flatpak/flatpak/forks","keys_url":"https://api.github.com/repos/flatpak/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flatpak/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flatpak/flatpak/teams","hooks_url":"https://api.github.com/repos/flatpak/flatpak/hooks","issue_events_url":"https://api.github.com/repos/flatpak/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/flatpak/flatpak/events","assignees_url":"https://api.github.com/repos/flatpak/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/flatpak/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/flatpak/flatpak/tags","blobs_url":"https://api.github.com/repos/flatpak/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flatpak/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flatpak/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/flatpak/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flatpak/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/flatpak/flatpak/languages","stargazers_url":"https://api.github.com/repos/flatpak/flatpak/stargazers","contributors_url":"https://api.github.com/repos/flatpak/flatpak/contributors","subscribers_url":"https://api.github.com/repos/flatpak/flatpak/subscribers","subscription_url":"https://api.github.com/repos/flatpak/flatpak/subscription","commits_url":"https://api.github.com/repos/flatpak/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/flatpak/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/flatpak/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/flatpak/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/flatpak/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/flatpak/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flatpak/flatpak/merges","archive_url":"https://api.github.com/repos/flatpak/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flatpak/flatpak/downloads","issues_url":"https://api.github.com/repos/flatpak/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/flatpak/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/flatpak/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/flatpak/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flatpak/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/flatpak/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/flatpak/flatpak/deployments","created_at":"2016-05-19T14:19:21Z","updated_at":"2018-11-14T23:19:17Z","pushed_at":"2018-11-14T22:00:57Z","git_url":"git://github.com/flatpak/flatpak.git","ssh_url":"git@github.com:flatpak/flatpak.git","clone_url":"https://github.com/flatpak/flatpak.git","svn_url":"https://github.com/flatpak/flatpak","homepage":"http://flatpak.org","size":15894,"stargazers_count":1651,"watchers_count":1651,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":186,"open_issues":332,"watchers":1651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/1436"},"html":{"href":"https://github.com/flatpak/flatpak/pull/1436"},"issue":{"href":"https://api.github.com/repos/flatpak/flatpak/issues/1436"},"comments":{"href":"https://api.github.com/repos/flatpak/flatpak/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flatpak/flatpak/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/flatpak/flatpak/statuses/1b6924458537da259d1ce5721fde30bfde1c5824"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matthiasclasen"}}