{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/183425737","pull_request_review_id":114421254,"id":183425737,"diff_hunk":"@@ -742,6 +742,16 @@ def test_gaussian_mixture_verbose():\n             sys.stdout = old_stdout\n \n \n+def test_gaussian_mixture_n_iter():","path":"sklearn/mixture/tests/test_gaussian_mixture.py","position":4,"original_position":4,"commit_id":"320f3593be377e27e1a33b1fa37a76d3cbdb24d7","original_commit_id":"320f3593be377e27e1a33b1fa37a76d3cbdb24d7","user":{"login":"rth","id":630936,"avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"body":"Maybe merge both test function to a pytest parametrized test under `sklearn/mixture/tests/test_mixture.py` ","created_at":"2018-04-23T14:56:31Z","updated_at":"2018-04-23T14:57:17Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11015#discussion_r183425737","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/183425737"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11015#discussion_r183425737"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015","id":183460917,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/11015","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11015.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11015.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11015","number":11015,"state":"open","locked":false,"title":"[MRG] FIX make n_iter_ being the number of iteration performed","user":{"login":"glemaitre","id":7454015,"avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\nRelated to #10740 \r\n\r\n","created_at":"2018-04-23T14:52:15Z","updated_at":"2018-04-23T14:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"699e9a18347e80a7e0b57db882faaa24bb0209bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11015/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/320f3593be377e27e1a33b1fa37a76d3cbdb24d7","head":{"label":"glemaitre:is/10740","ref":"is/10740","sha":"320f3593be377e27e1a33b1fa37a76d3cbdb24d7","user":{"login":"glemaitre","id":7454015,"avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"repo":{"id":49886894,"name":"scikit-learn","full_name":"glemaitre/scikit-learn","owner":{"login":"glemaitre","id":7454015,"avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glemaitre/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/glemaitre/scikit-learn","forks_url":"https://api.github.com/repos/glemaitre/scikit-learn/forks","keys_url":"https://api.github.com/repos/glemaitre/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glemaitre/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glemaitre/scikit-learn/teams","hooks_url":"https://api.github.com/repos/glemaitre/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/glemaitre/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/glemaitre/scikit-learn/events","assignees_url":"https://api.github.com/repos/glemaitre/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/glemaitre/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/glemaitre/scikit-learn/tags","blobs_url":"https://api.github.com/repos/glemaitre/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glemaitre/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glemaitre/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/glemaitre/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glemaitre/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/glemaitre/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/glemaitre/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/glemaitre/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/glemaitre/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/glemaitre/scikit-learn/subscription","commits_url":"https://api.github.com/repos/glemaitre/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/glemaitre/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/glemaitre/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/glemaitre/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/glemaitre/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/glemaitre/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glemaitre/scikit-learn/merges","archive_url":"https://api.github.com/repos/glemaitre/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glemaitre/scikit-learn/downloads","issues_url":"https://api.github.com/repos/glemaitre/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/glemaitre/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/glemaitre/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/glemaitre/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glemaitre/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/glemaitre/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/glemaitre/scikit-learn/deployments","created_at":"2016-01-18T15:50:08Z","updated_at":"2016-01-18T15:50:14Z","pushed_at":"2018-04-23T14:50:43Z","git_url":"git://github.com/glemaitre/scikit-learn.git","ssh_url":"git@github.com:glemaitre/scikit-learn.git","clone_url":"https://github.com/glemaitre/scikit-learn.git","svn_url":"https://github.com/glemaitre/scikit-learn","homepage":"http://scikit-learn.org","size":89704,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"9ea723f07a9d50ce96cddc3d8da24f9a12109e09","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-04-23T14:53:57Z","pushed_at":"2018-04-23T14:52:15Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":90012,"stargazers_count":27616,"watchers_count":27616,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13808,"mirror_url":null,"archived":false,"open_issues_count":1629,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13808,"open_issues":1629,"watchers":27616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11015"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11015"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11015/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11015/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/320f3593be377e27e1a33b1fa37a76d3cbdb24d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rth"}}