{"action":"closed","issue":{"url":"https://api.github.com/repos/honeycombio/opencensus-exporter/issues/4","repository_url":"https://api.github.com/repos/honeycombio/opencensus-exporter","labels_url":"https://api.github.com/repos/honeycombio/opencensus-exporter/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/honeycombio/opencensus-exporter/issues/4/comments","events_url":"https://api.github.com/repos/honeycombio/opencensus-exporter/issues/4/events","html_url":"https://github.com/honeycombio/opencensus-exporter/issues/4","id":362884563,"node_id":"MDU6SXNzdWUzNjI4ODQ1NjM=","number":4,"title":"trace: consider batching in ExportSpan","user":{"login":"odeke-em","id":4898263,"node_id":"MDQ6VXNlcjQ4OTgyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4898263?v=4","gravatar_id":"","url":"https://api.github.com/users/odeke-em","html_url":"https://github.com/odeke-em","followers_url":"https://api.github.com/users/odeke-em/followers","following_url":"https://api.github.com/users/odeke-em/following{/other_user}","gists_url":"https://api.github.com/users/odeke-em/gists{/gist_id}","starred_url":"https://api.github.com/users/odeke-em/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeke-em/subscriptions","organizations_url":"https://api.github.com/users/odeke-em/orgs","repos_url":"https://api.github.com/users/odeke-em/repos","events_url":"https://api.github.com/users/odeke-em/events{/privacy}","received_events_url":"https://api.github.com/users/odeke-em/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-22T19:36:16Z","updated_at":"2018-09-25T17:27:31Z","closed_at":"2018-09-25T17:27:31Z","author_association":"NONE","body":"It's great to see this exporter for OpenCensus from Honeycomb, congratulations!\r\n\r\nI was just studying your exporter and noticed that in ExportSpan, per SpanData that's added it is converted immediately and then uploaded before ExportSpan returns.\r\n\r\nExportSpan is on the hot path and for example if we had 10K QPS all traces sampled say during a high latency spike, this would slow down the entire program since the number of SpanData being created will also be >=10K but also the network bandwidth from that upload of each span/event would spike too.\r\n\r\nThis is just a kind suggestion to perhaps perform some sort of batching. We talk about doing heavy work in a separate goroutine as per https://godoc.org/go.opencensus.io/trace#Exporter\r\n\r\nand some exporters like Stackdriver use this bundler https://godoc.org/google.golang.org/api/support/bundler can allow you to set a \"buffer time period\" as well as a \"batch max size\".\r\n\r\nThank you."}}
{"actor":{"display_login":"akvanhar"}}