{"action":"closed","number":4584,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4584","id":177898088,"html_url":"https://github.com/istio/istio/pull/4584","diff_url":"https://github.com/istio/istio/pull/4584.diff","patch_url":"https://github.com/istio/istio/pull/4584.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4584","number":4584,"state":"closed","locked":false,"title":"fix zipkin service name from istio-zipkin to zipkin","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"Name of the zipkin service is `zipkin`, not `istio-zipkin`.\r\nThis fixes the ingress and sidecar configuration to use `zipkin:9411`","created_at":"2018-03-28T00:10:53Z","updated_at":"2018-03-28T00:50:48Z","closed_at":"2018-03-28T00:50:48Z","merged_at":"2018-03-28T00:50:48Z","merge_commit_sha":"d0ddbf54df95d4eb452a9b7c292cd695e536cd6f","assignee":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"assignees":[{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4584/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4584/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4584/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/c6a60d96645b0cec1d6c6d3c3ec64d4f16efac5f","head":{"label":"mandarjog:zipkin_fix","ref":"zipkin_fix","sha":"c6a60d96645b0cec1d6c6d3c3ec64d4f16efac5f","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":76583321,"name":"istio","full_name":"mandarjog/istio","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/istio","description":"A Service Fabric for Polyglot Microservices","fork":true,"url":"https://api.github.com/repos/mandarjog/istio","forks_url":"https://api.github.com/repos/mandarjog/istio/forks","keys_url":"https://api.github.com/repos/mandarjog/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/istio/teams","hooks_url":"https://api.github.com/repos/mandarjog/istio/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/istio/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/istio/events","assignees_url":"https://api.github.com/repos/mandarjog/istio/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/istio/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/istio/tags","blobs_url":"https://api.github.com/repos/mandarjog/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/istio/languages","stargazers_url":"https://api.github.com/repos/mandarjog/istio/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/istio/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/istio/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/istio/subscription","commits_url":"https://api.github.com/repos/mandarjog/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/istio/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/istio/merges","archive_url":"https://api.github.com/repos/mandarjog/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/istio/downloads","issues_url":"https://api.github.com/repos/mandarjog/istio/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/istio/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/istio/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/istio/deployments","created_at":"2016-12-15T18:01:34Z","updated_at":"2017-10-30T13:15:26Z","pushed_at":"2018-03-28T00:08:33Z","git_url":"git://github.com/mandarjog/istio.git","ssh_url":"git@github.com:mandarjog/istio.git","clone_url":"https://github.com/mandarjog/istio.git","svn_url":"https://github.com/mandarjog/istio","homepage":null,"size":119487,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"ae3e20142be7cfa414eca6c6416e077423af5186","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-03-28T00:36:37Z","pushed_at":"2018-03-28T00:50:48Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":18773,"stargazers_count":6805,"watchers_count":6805,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":884,"mirror_url":null,"archived":false,"open_issues_count":783,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":884,"open_issues":783,"watchers":6805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4584"},"html":{"href":"https://github.com/istio/istio/pull/4584"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4584"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4584/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4584/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4584/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/c6a60d96645b0cec1d6c6d3c3ec64d4f16efac5f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"mandarjog"}}