{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/169850469","pull_request_review_id":98442986,"id":169850469,"diff_hunk":"@@ -1952,19 +1954,20 @@ If you prefer to tune security settings yourself, you might create\n a context from scratch (but beware that you might not get the settings\n right)::\n \n-   >>> context = ssl.SSLContext()\n-   >>> context.verify_mode = ssl.CERT_REQUIRED\n-   >>> context.check_hostname = True\n+   >>> context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)\n    >>> context.load_verify_locations(\"/etc/ssl/certs/ca-bundle.crt\")\n \n (this snippet assumes your operating system places a bundle of all CA\n certificates in ``/etc/ssl/certs/ca-bundle.crt``; if not, you'll get an\n error and have to adjust the location)\n \n When you use the context to connect to a server, :const:`CERT_REQUIRED`\n-validates the server certificate: it ensures that the server certificate\n-was signed with one of the CA certificates, and checks the signature for\n-correctness::\n+validates the server certificate and :meth:`~SSLContext.check_hostname`\n+matches the hostname. Both setting ensure that the server certificate","path":"Doc/library/ssl.rst","position":37,"original_position":37,"commit_id":"25960d0dece79ab91018e0e70ff94834478ec6f7","original_commit_id":"25960d0dece79ab91018e0e70ff94834478ec6f7","user":{"login":"benjaminp","id":219470,"avatar_url":"https://avatars1.githubusercontent.com/u/219470?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminp","html_url":"https://github.com/benjaminp","followers_url":"https://api.github.com/users/benjaminp/followers","following_url":"https://api.github.com/users/benjaminp/following{/other_user}","gists_url":"https://api.github.com/users/benjaminp/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminp/subscriptions","organizations_url":"https://api.github.com/users/benjaminp/orgs","repos_url":"https://api.github.com/users/benjaminp/repos","events_url":"https://api.github.com/users/benjaminp/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminp/received_events","type":"User","site_admin":false},"body":"setting**s**","created_at":"2018-02-22T04:06:26Z","updated_at":"2018-02-22T04:09:23Z","html_url":"https://github.com/python/cpython/pull/5797#discussion_r169850469","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/5797","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/169850469"},"html":{"href":"https://github.com/python/cpython/pull/5797#discussion_r169850469"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/5797"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/5797","id":170422787,"html_url":"https://github.com/python/cpython/pull/5797","diff_url":"https://github.com/python/cpython/pull/5797.diff","patch_url":"https://github.com/python/cpython/pull/5797.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/5797","number":5797,"state":"open","locked":false,"title":"bpo-32008: Prefer client or TLSv1_2 in examples","user":{"login":"tiran","id":444071,"avatar_url":"https://avatars3.githubusercontent.com/u/444071?v=4","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Christian Heimes <christian@python.org>\r\n\n\n<!-- issue-number: bpo-32008 -->\nhttps://bugs.python.org/issue32008\n<!-- /issue-number -->\n","created_at":"2018-02-21T10:01:53Z","updated_at":"2018-02-22T04:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b71fd8ca3c0b9280bb8c0821d0f5d6fc94fe9b78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":536945649,"url":"https://api.github.com/repos/python/cpython/labels/needs%20backport%20to%203.6","name":"needs backport to 3.6","color":"c2e0c6","default":false},{"id":823079334,"url":"https://api.github.com/repos/python/cpython/labels/needs%20backport%20to%203.7","name":"needs backport to 3.7","color":"c2e0c6","default":false},{"id":667924166,"url":"https://api.github.com/repos/python/cpython/labels/skip%20news","name":"skip news","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/5797/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/5797/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/5797/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/25960d0dece79ab91018e0e70ff94834478ec6f7","head":{"label":"tiran:bpo-32008","ref":"bpo-32008","sha":"25960d0dece79ab91018e0e70ff94834478ec6f7","user":{"login":"tiran","id":444071,"avatar_url":"https://avatars3.githubusercontent.com/u/444071?v=4","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"repo":{"id":81662187,"name":"cpython","full_name":"tiran/cpython","owner":{"login":"tiran","id":444071,"avatar_url":"https://avatars3.githubusercontent.com/u/444071?v=4","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiran/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/tiran/cpython","forks_url":"https://api.github.com/repos/tiran/cpython/forks","keys_url":"https://api.github.com/repos/tiran/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiran/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiran/cpython/teams","hooks_url":"https://api.github.com/repos/tiran/cpython/hooks","issue_events_url":"https://api.github.com/repos/tiran/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/tiran/cpython/events","assignees_url":"https://api.github.com/repos/tiran/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/tiran/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/tiran/cpython/tags","blobs_url":"https://api.github.com/repos/tiran/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiran/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiran/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiran/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiran/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/tiran/cpython/languages","stargazers_url":"https://api.github.com/repos/tiran/cpython/stargazers","contributors_url":"https://api.github.com/repos/tiran/cpython/contributors","subscribers_url":"https://api.github.com/repos/tiran/cpython/subscribers","subscription_url":"https://api.github.com/repos/tiran/cpython/subscription","commits_url":"https://api.github.com/repos/tiran/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiran/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiran/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiran/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiran/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/tiran/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiran/cpython/merges","archive_url":"https://api.github.com/repos/tiran/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiran/cpython/downloads","issues_url":"https://api.github.com/repos/tiran/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/tiran/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/tiran/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/tiran/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiran/cpython/labels{/name}","releases_url":"https://api.github.com/repos/tiran/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/tiran/cpython/deployments","created_at":"2017-02-11T15:36:33Z","updated_at":"2017-02-11T15:36:55Z","pushed_at":"2018-02-21T10:01:15Z","git_url":"git://github.com/tiran/cpython.git","ssh_url":"git@github.com:tiran/cpython.git","clone_url":"https://github.com/tiran/cpython.git","svn_url":"https://github.com/tiran/cpython","homepage":"https://www.python.org/","size":222621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"ba518804bf4c1ea01df5e622b333d3116cbaa3bd","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-02-22T03:20:17Z","pushed_at":"2018-02-22T03:49:47Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":226533,"stargazers_count":16196,"watchers_count":16196,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4403,"mirror_url":null,"archived":false,"open_issues_count":611,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4403,"open_issues":611,"watchers":16196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/5797"},"html":{"href":"https://github.com/python/cpython/pull/5797"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/5797"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/5797/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/5797/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/5797/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/25960d0dece79ab91018e0e70ff94834478ec6f7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjaminp"}}