{"action":"closed","number":860,"pull_request":{"url":"https://api.github.com/repos/dherges/ng-packagr/pulls/860","id":187329534,"html_url":"https://github.com/dherges/ng-packagr/pull/860","diff_url":"https://github.com/dherges/ng-packagr/pull/860.diff","patch_url":"https://github.com/dherges/ng-packagr/pull/860.patch","issue_url":"https://api.github.com/repos/dherges/ng-packagr/issues/860","number":860,"state":"closed","locked":false,"title":"fix: do not disable fullTemplateTypeCheck when ES5 downleveling","user":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"body":"## I'm submitting a...\r\n\r\n```\r\n[x] Bug Fix\r\n[ ] Feature\r\n[ ] Other (Refactoring, Added tests, Documentation, ...)\r\n```\r\n\r\n## Checklist\r\n\r\n- [x] Commit Messages follow the [Conventional Commits](https://conventionalcommits.org/) pattern\r\n  - A feature commit message is prefixed \"feat:\"\r\n  - A bugfix commit message is prefixed \"fix:\"\r\n- [ ] Tests for the changes have been added\r\n\r\n\r\n## Description\r\n\r\nIn #826 the option was enabled in tsconfig.ngc.json and then in #812 the option was disabled again when downleveling to ES5. This then causes #822 to resurface again, which was supposedly fixed by #826.\r\n\r\nNo integration test has been added at this moment, I'm hoping this can get in during the RCs to get real world feedback if the function calls in decorator bugs are now actually fully resolved. With the changes in this PR applied to 3.0.0-rc4 I have been able to successfully build my project that was also suffering from this issue after upgrading from 2.4 to the 3.0 RC.\r\n\r\n## More Information\r\n\r\nAfter some two hour debug session in the guts of Angular's compiler, I finally tracked down angular/angular#23609 to originate from [this piece of code when reading the metadata of a library](https://github.com/angular/angular/blob/117c7eebc388ccc7a138a468d79adcd314630471/packages/compiler/src/aot/static_symbol_resolver.ts#L381-L385). As can be seen there, with certain conditions Angular rejects most of the class metadata such that function calls cannot be resolved, resulting in the error.\r\n\r\nFollowing above condition [we follow the code into `summaryResolver.isLibraryFile`](https://github.com/angular/angular/blob/117c7eebc388ccc7a138a468d79adcd314630471/packages/compiler/src/aot/summary_resolver.ts#L52-L57) to find that it calls into [the compiler host to determine if the file not a source file](https://github.com/angular/angular/blob/117c7eebc388ccc7a138a468d79adcd314630471/packages/compiler-cli/src/transformers/compiler_host.ts#L480-L482) that is the actual culprit. Here we find that `skipTemplateCodegen` and `fullTemplateTypeCheck` ultimately affect the decision to elide some of the metadata.\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```","created_at":"2018-05-10T23:03:16Z","updated_at":"2018-05-11T14:13:05Z","closed_at":"2018-05-11T14:13:04Z","merged_at":"2018-05-11T14:13:04Z","merge_commit_sha":"dfa83f96bad1405f94bc431028544e1cfc47666c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/860/commits","review_comments_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/860/comments","review_comment_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/issues/860/comments","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/e26f377b33524daba7f64120fc8c3e77f6c45d31","head":{"label":"JoostK:gh-822-full-template-type-check","ref":"gh-822-full-template-type-check","sha":"e26f377b33524daba7f64120fc8c3e77f6c45d31","user":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"repo":{"id":110595957,"name":"ng-packagr","full_name":"JoostK/ng-packagr","owner":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoostK/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":true,"url":"https://api.github.com/repos/JoostK/ng-packagr","forks_url":"https://api.github.com/repos/JoostK/ng-packagr/forks","keys_url":"https://api.github.com/repos/JoostK/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoostK/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoostK/ng-packagr/teams","hooks_url":"https://api.github.com/repos/JoostK/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/JoostK/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/JoostK/ng-packagr/events","assignees_url":"https://api.github.com/repos/JoostK/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/JoostK/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/JoostK/ng-packagr/tags","blobs_url":"https://api.github.com/repos/JoostK/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoostK/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoostK/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoostK/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoostK/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/JoostK/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/JoostK/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/JoostK/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/JoostK/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/JoostK/ng-packagr/subscription","commits_url":"https://api.github.com/repos/JoostK/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoostK/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoostK/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoostK/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoostK/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/JoostK/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoostK/ng-packagr/merges","archive_url":"https://api.github.com/repos/JoostK/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoostK/ng-packagr/downloads","issues_url":"https://api.github.com/repos/JoostK/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/JoostK/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/JoostK/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/JoostK/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoostK/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/JoostK/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/JoostK/ng-packagr/deployments","created_at":"2017-11-13T20:05:26Z","updated_at":"2018-05-10T22:22:08Z","pushed_at":"2018-05-10T22:38:53Z","git_url":"git://github.com/JoostK/ng-packagr.git","ssh_url":"git@github.com:JoostK/ng-packagr.git","clone_url":"https://github.com/JoostK/ng-packagr.git","svn_url":"https://github.com/JoostK/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":10560,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dherges:master","ref":"master","sha":"1cdb0cfc8ea57a891db09a456da857cb1c5890c3","user":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"repo":{"id":91553810,"name":"ng-packagr","full_name":"dherges/ng-packagr","owner":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dherges/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":false,"url":"https://api.github.com/repos/dherges/ng-packagr","forks_url":"https://api.github.com/repos/dherges/ng-packagr/forks","keys_url":"https://api.github.com/repos/dherges/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dherges/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dherges/ng-packagr/teams","hooks_url":"https://api.github.com/repos/dherges/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/dherges/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/dherges/ng-packagr/events","assignees_url":"https://api.github.com/repos/dherges/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/dherges/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/dherges/ng-packagr/tags","blobs_url":"https://api.github.com/repos/dherges/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dherges/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dherges/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dherges/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/dherges/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/dherges/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/dherges/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/dherges/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/dherges/ng-packagr/subscription","commits_url":"https://api.github.com/repos/dherges/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dherges/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dherges/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dherges/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/dherges/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dherges/ng-packagr/merges","archive_url":"https://api.github.com/repos/dherges/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dherges/ng-packagr/downloads","issues_url":"https://api.github.com/repos/dherges/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/dherges/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/dherges/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/dherges/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dherges/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/dherges/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/dherges/ng-packagr/deployments","created_at":"2017-05-17T08:43:27Z","updated_at":"2018-05-11T14:12:18Z","pushed_at":"2018-05-11T14:13:04Z","git_url":"git://github.com/dherges/ng-packagr.git","ssh_url":"git@github.com:dherges/ng-packagr.git","clone_url":"https://github.com/dherges/ng-packagr.git","svn_url":"https://github.com/dherges/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":10798,"stargazers_count":886,"watchers_count":886,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":123,"open_issues":142,"watchers":886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/860"},"html":{"href":"https://github.com/dherges/ng-packagr/pull/860"},"issue":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/860"},"comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/dherges/ng-packagr/statuses/e26f377b33524daba7f64120fc8c3e77f6c45d31"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"dherges"}}