{"action":"created","comment":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/comments/213127178","pull_request_review_id":149898416,"id":213127178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzEyNzE3OA==","diff_hunk":"@@ -76,13 +79,24 @@ set(INCLUDE_INSTALL_DIR ${CMAKE_INSTALL_INCLUDEDIR})\n \n # We need to install headers manually as rocm_install_targets\n # does not support header-only libraries (INTERFACE targets)\n+if(rocprim_hc)","path":"rocprim/CMakeLists.txt","position":36,"original_position":36,"commit_id":"1dc3cb1ef1559636645e0a5f1d0b2205f0490aa5","original_commit_id":"1dc3cb1ef1559636645e0a5f1d0b2205f0490aa5","user":{"login":"jszuppe","id":2720260,"node_id":"MDQ6VXNlcjI3MjAyNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2720260?v=4","gravatar_id":"","url":"https://api.github.com/users/jszuppe","html_url":"https://github.com/jszuppe","followers_url":"https://api.github.com/users/jszuppe/followers","following_url":"https://api.github.com/users/jszuppe/following{/other_user}","gists_url":"https://api.github.com/users/jszuppe/gists{/gist_id}","starred_url":"https://api.github.com/users/jszuppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszuppe/subscriptions","organizations_url":"https://api.github.com/users/jszuppe/orgs","repos_url":"https://api.github.com/users/jszuppe/repos","events_url":"https://api.github.com/users/jszuppe/events{/privacy}","received_events_url":"https://api.github.com/users/jszuppe/received_events","type":"User","site_admin":false},"body":"`if(TARGET rocprim_hc)`. \r\n\r\nEverything else looks ok. We will test it tomorrow and merge if it works ok on our CI with `hcc`.","created_at":"2018-08-27T21:49:42Z","updated_at":"2018-08-27T21:53:50Z","html_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25#discussion_r213127178","pull_request_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/comments/213127178"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25#discussion_r213127178"},"pull_request":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25","id":210779598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzc5NTk4","html_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25","diff_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25.diff","patch_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25.patch","issue_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/25","number":25,"state":"open","locked":false,"title":"Add HIP-Clang CMake changes","user":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"body":"Add ifdefs to remove usage of hcc in cmake files, and remove hc tests on the hip path if using HIP-Clang as the compiler. Enable detection of the compiler into HIP_COMPILER cmake variable.","created_at":"2018-08-24T15:49:04Z","updated_at":"2018-08-27T21:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"883c02a70506380d8397de8732af518eddc5db3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yxsamliu","id":6145511,"node_id":"MDQ6VXNlcjYxNDU1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6145511?v=4","gravatar_id":"","url":"https://api.github.com/users/yxsamliu","html_url":"https://github.com/yxsamliu","followers_url":"https://api.github.com/users/yxsamliu/followers","following_url":"https://api.github.com/users/yxsamliu/following{/other_user}","gists_url":"https://api.github.com/users/yxsamliu/gists{/gist_id}","starred_url":"https://api.github.com/users/yxsamliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yxsamliu/subscriptions","organizations_url":"https://api.github.com/users/yxsamliu/orgs","repos_url":"https://api.github.com/users/yxsamliu/repos","events_url":"https://api.github.com/users/yxsamliu/events{/privacy}","received_events_url":"https://api.github.com/users/yxsamliu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/25/comments","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/statuses/1dc3cb1ef1559636645e0a5f1d0b2205f0490aa5","head":{"label":"aaronenyeshi:hip-clang-cmake","ref":"hip-clang-cmake","sha":"1dc3cb1ef1559636645e0a5f1d0b2205f0490aa5","user":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"repo":{"id":134758410,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3NTg0MTA=","name":"rocPRIM","full_name":"aaronenyeshi/rocPRIM","owner":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronenyeshi/rocPRIM","description":"ROCm Parallel Primitives   -  Developer Preview ","fork":true,"url":"https://api.github.com/repos/aaronenyeshi/rocPRIM","forks_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/forks","keys_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/teams","hooks_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/hooks","issue_events_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/issues/events{/number}","events_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/events","assignees_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/assignees{/user}","branches_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/branches{/branch}","tags_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/tags","blobs_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/languages","stargazers_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/stargazers","contributors_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/contributors","subscribers_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/subscribers","subscription_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/subscription","commits_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/contents/{+path}","compare_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/merges","archive_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/downloads","issues_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/issues{/number}","pulls_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/labels{/name}","releases_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/releases{/id}","deployments_url":"https://api.github.com/repos/aaronenyeshi/rocPRIM/deployments","created_at":"2018-05-24T19:12:50Z","updated_at":"2018-05-24T19:12:53Z","pushed_at":"2018-08-27T21:43:24Z","git_url":"git://github.com/aaronenyeshi/rocPRIM.git","ssh_url":"git@github.com:aaronenyeshi/rocPRIM.git","clone_url":"https://github.com/aaronenyeshi/rocPRIM.git","svn_url":"https://github.com/aaronenyeshi/rocPRIM","homepage":"","size":1798,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROCmSoftwarePlatform:develop","ref":"develop","sha":"575f8bea07d450459593009daf20b47e6c850051","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":114167580,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxNjc1ODA=","name":"rocPRIM","full_name":"ROCmSoftwarePlatform/rocPRIM","owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM","description":"ROCm Parallel Primitives","fork":false,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/deployments","created_at":"2017-12-13T20:51:12Z","updated_at":"2018-08-27T06:14:29Z","pushed_at":"2018-08-27T21:43:26Z","git_url":"git://github.com/ROCmSoftwarePlatform/rocPRIM.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/rocPRIM.git","clone_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM.git","svn_url":"https://github.com/ROCmSoftwarePlatform/rocPRIM","homepage":"","size":1782,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":8,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/rocPRIM/pull/25"},"issue":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/25"},"comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/statuses/1dc3cb1ef1559636645e0a5f1d0b2205f0490aa5"}},"author_association":"NONE"}}
{"actor":{"display_login":"jszuppe"}}