{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/222720018","pull_request_review_id":161675571,"id":222720018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjcyMDAxOA==","diff_hunk":"@@ -37,6 +38,9 @@ def start(self):\n         \"\"\"\n         if self.process is None:\n             command = self.command\n+            if shutil.which(command) is None:","path":"raiden/utils/http.py","position":10,"original_position":10,"commit_id":"42131141c63b2032b4b3dc43aea83178af45acc9","original_commit_id":"42131141c63b2032b4b3dc43aea83178af45acc9","user":{"login":"andrevmatos","id":587021,"node_id":"MDQ6VXNlcjU4NzAyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/587021?v=4","gravatar_id":"","url":"https://api.github.com/users/andrevmatos","html_url":"https://github.com/andrevmatos","followers_url":"https://api.github.com/users/andrevmatos/followers","following_url":"https://api.github.com/users/andrevmatos/following{/other_user}","gists_url":"https://api.github.com/users/andrevmatos/gists{/gist_id}","starred_url":"https://api.github.com/users/andrevmatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrevmatos/subscriptions","organizations_url":"https://api.github.com/users/andrevmatos/orgs","repos_url":"https://api.github.com/users/andrevmatos/repos","events_url":"https://api.github.com/users/andrevmatos/events{/privacy}","received_events_url":"https://api.github.com/users/andrevmatos/received_events","type":"User","site_admin":false},"body":"`command` doesn't need to be a executable or script, but may be a full shell command, to allow easy replacement of configuration/other parameters, and even redirection of synapse logs (i.e. `--local-matrix=\"STDOUT_SYNAPSE=1 ./.synapse/synapse > mylog.log\"` will work as intended). Won't it break with `which`?","created_at":"2018-10-04T15:35:06Z","updated_at":"2018-10-04T15:35:06Z","html_url":"https://github.com/raiden-network/raiden/pull/2668#discussion_r222720018","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2668","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/222720018"},"html":{"href":"https://github.com/raiden-network/raiden/pull/2668#discussion_r222720018"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2668"}}},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/2668","id":220406453,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDA2NDUz","html_url":"https://github.com/raiden-network/raiden/pull/2668","diff_url":"https://github.com/raiden-network/raiden/pull/2668.diff","patch_url":"https://github.com/raiden-network/raiden/pull/2668.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/2668","number":2668,"state":"open","locked":false,"title":"Fix smoketest matrix support","user":{"login":"konradkonrad","id":3705643,"node_id":"MDQ6VXNlcjM3MDU2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3705643?v=4","gravatar_id":"","url":"https://api.github.com/users/konradkonrad","html_url":"https://github.com/konradkonrad","followers_url":"https://api.github.com/users/konradkonrad/followers","following_url":"https://api.github.com/users/konradkonrad/following{/other_user}","gists_url":"https://api.github.com/users/konradkonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/konradkonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konradkonrad/subscriptions","organizations_url":"https://api.github.com/users/konradkonrad/orgs","repos_url":"https://api.github.com/users/konradkonrad/repos","events_url":"https://api.github.com/users/konradkonrad/events{/privacy}","received_events_url":"https://api.github.com/users/konradkonrad/received_events","type":"User","site_admin":false},"body":"Currently a local `smoketest` fails without proper logging, if `synapse` wasn't installed.\r\nThis PR documents the need for running `tools/install_synapse.sh` for developers and adds proper checks for starting `synapse`.","created_at":"2018-10-04T14:48:30Z","updated_at":"2018-10-04T15:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85eff9dbe4717920af59d0bbc8ae8b62b2bc4c9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":456350195,"node_id":"MDU6TGFiZWw0NTYzNTAxOTU=","url":"https://api.github.com/repos/raiden-network/raiden/labels/dev:%20Please%20Review","name":"dev: Please Review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2668/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2668/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/2668/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/42131141c63b2032b4b3dc43aea83178af45acc9","head":{"label":"konradkonrad:fix_smoketest_matrix","ref":"fix_smoketest_matrix","sha":"42131141c63b2032b4b3dc43aea83178af45acc9","user":{"login":"konradkonrad","id":3705643,"node_id":"MDQ6VXNlcjM3MDU2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3705643?v=4","gravatar_id":"","url":"https://api.github.com/users/konradkonrad","html_url":"https://github.com/konradkonrad","followers_url":"https://api.github.com/users/konradkonrad/followers","following_url":"https://api.github.com/users/konradkonrad/following{/other_user}","gists_url":"https://api.github.com/users/konradkonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/konradkonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konradkonrad/subscriptions","organizations_url":"https://api.github.com/users/konradkonrad/orgs","repos_url":"https://api.github.com/users/konradkonrad/repos","events_url":"https://api.github.com/users/konradkonrad/events{/privacy}","received_events_url":"https://api.github.com/users/konradkonrad/received_events","type":"User","site_admin":false},"repo":{"id":71461264,"node_id":"MDEwOlJlcG9zaXRvcnk3MTQ2MTI2NA==","name":"raiden","full_name":"konradkonrad/raiden","private":false,"owner":{"login":"konradkonrad","id":3705643,"node_id":"MDQ6VXNlcjM3MDU2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3705643?v=4","gravatar_id":"","url":"https://api.github.com/users/konradkonrad","html_url":"https://github.com/konradkonrad","followers_url":"https://api.github.com/users/konradkonrad/followers","following_url":"https://api.github.com/users/konradkonrad/following{/other_user}","gists_url":"https://api.github.com/users/konradkonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/konradkonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konradkonrad/subscriptions","organizations_url":"https://api.github.com/users/konradkonrad/orgs","repos_url":"https://api.github.com/users/konradkonrad/repos","events_url":"https://api.github.com/users/konradkonrad/events{/privacy}","received_events_url":"https://api.github.com/users/konradkonrad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/konradkonrad/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/konradkonrad/raiden","forks_url":"https://api.github.com/repos/konradkonrad/raiden/forks","keys_url":"https://api.github.com/repos/konradkonrad/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/konradkonrad/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/konradkonrad/raiden/teams","hooks_url":"https://api.github.com/repos/konradkonrad/raiden/hooks","issue_events_url":"https://api.github.com/repos/konradkonrad/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/konradkonrad/raiden/events","assignees_url":"https://api.github.com/repos/konradkonrad/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/konradkonrad/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/konradkonrad/raiden/tags","blobs_url":"https://api.github.com/repos/konradkonrad/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/konradkonrad/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/konradkonrad/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/konradkonrad/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/konradkonrad/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/konradkonrad/raiden/languages","stargazers_url":"https://api.github.com/repos/konradkonrad/raiden/stargazers","contributors_url":"https://api.github.com/repos/konradkonrad/raiden/contributors","subscribers_url":"https://api.github.com/repos/konradkonrad/raiden/subscribers","subscription_url":"https://api.github.com/repos/konradkonrad/raiden/subscription","commits_url":"https://api.github.com/repos/konradkonrad/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/konradkonrad/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/konradkonrad/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/konradkonrad/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/konradkonrad/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/konradkonrad/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/konradkonrad/raiden/merges","archive_url":"https://api.github.com/repos/konradkonrad/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/konradkonrad/raiden/downloads","issues_url":"https://api.github.com/repos/konradkonrad/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/konradkonrad/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/konradkonrad/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/konradkonrad/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/konradkonrad/raiden/labels{/name}","releases_url":"https://api.github.com/repos/konradkonrad/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/konradkonrad/raiden/deployments","created_at":"2016-10-20T12:33:32Z","updated_at":"2016-10-20T12:33:34Z","pushed_at":"2018-10-04T15:28:31Z","git_url":"git://github.com/konradkonrad/raiden.git","ssh_url":"git@github.com:konradkonrad/raiden.git","clone_url":"https://github.com/konradkonrad/raiden.git","svn_url":"https://github.com/konradkonrad/raiden","homepage":null,"size":10636,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"beebf8be1d77540eb35932332d3c41e07f91a1f9","user":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY0Njc2Nw==","name":"raiden","full_name":"raiden-network/raiden","private":false,"owner":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2018-10-04T13:59:18Z","pushed_at":"2018-10-04T15:28:32Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":10611,"stargazers_count":1556,"watchers_count":1556,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":318,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":318,"open_issues":177,"watchers":1556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2668"},"html":{"href":"https://github.com/raiden-network/raiden/pull/2668"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/2668"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/2668/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2668/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2668/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/42131141c63b2032b4b3dc43aea83178af45acc9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"andrevmatos"}}