{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168242036","pull_request_review_id":96577716,"id":168242036,"diff_hunk":"@@ -60,4 +60,40 @@ public int hashCode() {\n         return fullName.hashCode();\n     }\n \n+    @Override\n+    public int compareTo(Name otherName){\n+        int i = 0;","path":"src/seedu/addressbook/data/person/Name.java","position":15,"original_position":15,"commit_id":"e1f6ac3e92f3832310735656fc8d666320bfc677","original_commit_id":"e1f6ac3e92f3832310735656fc8d666320bfc677","user":{"login":"randypx","id":35571456,"avatar_url":"https://avatars1.githubusercontent.com/u/35571456?v=4","gravatar_id":"","url":"https://api.github.com/users/randypx","html_url":"https://github.com/randypx","followers_url":"https://api.github.com/users/randypx/followers","following_url":"https://api.github.com/users/randypx/following{/other_user}","gists_url":"https://api.github.com/users/randypx/gists{/gist_id}","starred_url":"https://api.github.com/users/randypx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randypx/subscriptions","organizations_url":"https://api.github.com/users/randypx/orgs","repos_url":"https://api.github.com/users/randypx/repos","events_url":"https://api.github.com/users/randypx/events{/privacy}","received_events_url":"https://api.github.com/users/randypx/received_events","type":"User","site_admin":false},"body":"While it is good that you can implement this. Why not simply use String.complareTo() method?","created_at":"2018-02-14T16:59:54Z","updated_at":"2018-02-14T16:59:55Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279#discussion_r168242036","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168242036"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279#discussion_r168242036"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279","id":168439294,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/279","number":279,"state":"open","locked":false,"title":"[W5.11][W14-A3]Wang Jinyi","user":{"login":"WJY-norainu","id":30021198,"avatar_url":"https://avatars1.githubusercontent.com/u/30021198?v=4","gravatar_id":"","url":"https://api.github.com/users/WJY-norainu","html_url":"https://github.com/WJY-norainu","followers_url":"https://api.github.com/users/WJY-norainu/followers","following_url":"https://api.github.com/users/WJY-norainu/following{/other_user}","gists_url":"https://api.github.com/users/WJY-norainu/gists{/gist_id}","starred_url":"https://api.github.com/users/WJY-norainu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WJY-norainu/subscriptions","organizations_url":"https://api.github.com/users/WJY-norainu/orgs","repos_url":"https://api.github.com/users/WJY-norainu/repos","events_url":"https://api.github.com/users/WJY-norainu/events{/privacy}","received_events_url":"https://api.github.com/users/WJY-norainu/received_events","type":"User","site_admin":false},"body":"Enhancement of AddressBook level2","created_at":"2018-02-11T06:33:42Z","updated_at":"2018-02-14T16:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c68f78493bc1edbe1b107120d0fedaec732954","assignee":{"login":"kowshik-sundararajan","id":14358565,"avatar_url":"https://avatars2.githubusercontent.com/u/14358565?v=4","gravatar_id":"","url":"https://api.github.com/users/kowshik-sundararajan","html_url":"https://github.com/kowshik-sundararajan","followers_url":"https://api.github.com/users/kowshik-sundararajan/followers","following_url":"https://api.github.com/users/kowshik-sundararajan/following{/other_user}","gists_url":"https://api.github.com/users/kowshik-sundararajan/gists{/gist_id}","starred_url":"https://api.github.com/users/kowshik-sundararajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowshik-sundararajan/subscriptions","organizations_url":"https://api.github.com/users/kowshik-sundararajan/orgs","repos_url":"https://api.github.com/users/kowshik-sundararajan/repos","events_url":"https://api.github.com/users/kowshik-sundararajan/events{/privacy}","received_events_url":"https://api.github.com/users/kowshik-sundararajan/received_events","type":"User","site_admin":false},"assignees":[{"login":"kowshik-sundararajan","id":14358565,"avatar_url":"https://avatars2.githubusercontent.com/u/14358565?v=4","gravatar_id":"","url":"https://api.github.com/users/kowshik-sundararajan","html_url":"https://github.com/kowshik-sundararajan","followers_url":"https://api.github.com/users/kowshik-sundararajan/followers","following_url":"https://api.github.com/users/kowshik-sundararajan/following{/other_user}","gists_url":"https://api.github.com/users/kowshik-sundararajan/gists{/gist_id}","starred_url":"https://api.github.com/users/kowshik-sundararajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowshik-sundararajan/subscriptions","organizations_url":"https://api.github.com/users/kowshik-sundararajan/orgs","repos_url":"https://api.github.com/users/kowshik-sundararajan/repos","events_url":"https://api.github.com/users/kowshik-sundararajan/events{/privacy}","received_events_url":"https://api.github.com/users/kowshik-sundararajan/received_events","type":"User","site_admin":false},{"login":"hwkchia","id":16570616,"avatar_url":"https://avatars2.githubusercontent.com/u/16570616?v=4","gravatar_id":"","url":"https://api.github.com/users/hwkchia","html_url":"https://github.com/hwkchia","followers_url":"https://api.github.com/users/hwkchia/followers","following_url":"https://api.github.com/users/hwkchia/following{/other_user}","gists_url":"https://api.github.com/users/hwkchia/gists{/gist_id}","starred_url":"https://api.github.com/users/hwkchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwkchia/subscriptions","organizations_url":"https://api.github.com/users/hwkchia/orgs","repos_url":"https://api.github.com/users/hwkchia/repos","events_url":"https://api.github.com/users/hwkchia/events{/privacy}","received_events_url":"https://api.github.com/users/hwkchia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873039,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A3","name":"team.A3","color":"ededed","default":false},{"id":784873319,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.W14","name":"tutorial.W14","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/279/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/e1f6ac3e92f3832310735656fc8d666320bfc677","head":{"label":"WJY-norainu:W5.11-Feature","ref":"W5.11-Feature","sha":"e1f6ac3e92f3832310735656fc8d666320bfc677","user":{"login":"WJY-norainu","id":30021198,"avatar_url":"https://avatars1.githubusercontent.com/u/30021198?v=4","gravatar_id":"","url":"https://api.github.com/users/WJY-norainu","html_url":"https://github.com/WJY-norainu","followers_url":"https://api.github.com/users/WJY-norainu/followers","following_url":"https://api.github.com/users/WJY-norainu/following{/other_user}","gists_url":"https://api.github.com/users/WJY-norainu/gists{/gist_id}","starred_url":"https://api.github.com/users/WJY-norainu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WJY-norainu/subscriptions","organizations_url":"https://api.github.com/users/WJY-norainu/orgs","repos_url":"https://api.github.com/users/WJY-norainu/repos","events_url":"https://api.github.com/users/WJY-norainu/events{/privacy}","received_events_url":"https://api.github.com/users/WJY-norainu/received_events","type":"User","site_admin":false},"repo":{"id":120604597,"name":"addressbook-level2","full_name":"WJY-norainu/addressbook-level2","owner":{"login":"WJY-norainu","id":30021198,"avatar_url":"https://avatars1.githubusercontent.com/u/30021198?v=4","gravatar_id":"","url":"https://api.github.com/users/WJY-norainu","html_url":"https://github.com/WJY-norainu","followers_url":"https://api.github.com/users/WJY-norainu/followers","following_url":"https://api.github.com/users/WJY-norainu/following{/other_user}","gists_url":"https://api.github.com/users/WJY-norainu/gists{/gist_id}","starred_url":"https://api.github.com/users/WJY-norainu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WJY-norainu/subscriptions","organizations_url":"https://api.github.com/users/WJY-norainu/orgs","repos_url":"https://api.github.com/users/WJY-norainu/repos","events_url":"https://api.github.com/users/WJY-norainu/events{/privacy}","received_events_url":"https://api.github.com/users/WJY-norainu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WJY-norainu/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/WJY-norainu/addressbook-level2","forks_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/forks","keys_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/events","assignees_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/merges","archive_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/WJY-norainu/addressbook-level2/deployments","created_at":"2018-02-07T11:08:01Z","updated_at":"2018-02-07T11:08:03Z","pushed_at":"2018-02-11T06:30:01Z","git_url":"git://github.com/WJY-norainu/addressbook-level2.git","ssh_url":"git@github.com:WJY-norainu/addressbook-level2.git","clone_url":"https://github.com/WJY-norainu/addressbook-level2.git","svn_url":"https://github.com/WJY-norainu/addressbook-level2","homepage":null,"size":3310,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-10T03:00:19Z","pushed_at":"2018-02-14T16:59:54Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"archived":false,"open_issues_count":406,"license":null,"forks":175,"open_issues":406,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/279"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/279"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/e1f6ac3e92f3832310735656fc8d666320bfc677"}},"author_association":"NONE"}}
{"actor":{"display_login":"randypx"}}