{"action":"opened","issue":{"url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb/issues/1","repository_url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb","labels_url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb/issues/1/comments","events_url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb/issues/1/events","html_url":"https://github.com/Adalab/e-s1-evaluacion-intermedia-trizgb/issues/1","id":377926477,"node_id":"MDU6SXNzdWUzNzc5MjY0Nzc=","number":1,"title":"Finish the exercise","user":{"login":"oneeyedman","id":1732678,"node_id":"MDQ6VXNlcjE3MzI2Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1732678?v=4","gravatar_id":"","url":"https://api.github.com/users/oneeyedman","html_url":"https://github.com/oneeyedman","followers_url":"https://api.github.com/users/oneeyedman/followers","following_url":"https://api.github.com/users/oneeyedman/following{/other_user}","gists_url":"https://api.github.com/users/oneeyedman/gists{/gist_id}","starred_url":"https://api.github.com/users/oneeyedman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneeyedman/subscriptions","organizations_url":"https://api.github.com/users/oneeyedman/orgs","repos_url":"https://api.github.com/users/oneeyedman/repos","events_url":"https://api.github.com/users/oneeyedman/events{/privacy}","received_events_url":"https://api.github.com/users/oneeyedman/received_events","type":"User","site_admin":false},"labels":[{"id":1113542130,"node_id":"MDU6TGFiZWwxMTEzNTQyMTMw","url":"https://api.github.com/repos/Adalab/e-s1-evaluacion-intermedia-trizgb/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"trizgb","id":44624286,"node_id":"MDQ6VXNlcjQ0NjI0Mjg2","avatar_url":"https://avatars2.githubusercontent.com/u/44624286?v=4","gravatar_id":"","url":"https://api.github.com/users/trizgb","html_url":"https://github.com/trizgb","followers_url":"https://api.github.com/users/trizgb/followers","following_url":"https://api.github.com/users/trizgb/following{/other_user}","gists_url":"https://api.github.com/users/trizgb/gists{/gist_id}","starred_url":"https://api.github.com/users/trizgb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trizgb/subscriptions","organizations_url":"https://api.github.com/users/trizgb/orgs","repos_url":"https://api.github.com/users/trizgb/repos","events_url":"https://api.github.com/users/trizgb/events{/privacy}","received_events_url":"https://api.github.com/users/trizgb/received_events","type":"User","site_admin":false},"assignees":[{"login":"trizgb","id":44624286,"node_id":"MDQ6VXNlcjQ0NjI0Mjg2","avatar_url":"https://avatars2.githubusercontent.com/u/44624286?v=4","gravatar_id":"","url":"https://api.github.com/users/trizgb","html_url":"https://github.com/trizgb","followers_url":"https://api.github.com/users/trizgb/followers","following_url":"https://api.github.com/users/trizgb/following{/other_user}","gists_url":"https://api.github.com/users/trizgb/gists{/gist_id}","starred_url":"https://api.github.com/users/trizgb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trizgb/subscriptions","organizations_url":"https://api.github.com/users/trizgb/orgs","repos_url":"https://api.github.com/users/trizgb/repos","events_url":"https://api.github.com/users/trizgb/events{/privacy}","received_events_url":"https://api.github.com/users/trizgb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-06T16:25:12Z","updated_at":"2018-11-06T16:25:12Z","closed_at":null,"author_association":"MEMBER","body":"Great job @trizgb. A clean and well-indented exercise. Great HTML semantics.\r\n\r\nHere you have some tips to improve it:\r\n\r\n- [ ] We should link external stylesheets before our own ones, just in case\r\n- [ ] Menu items should be anchors: `Nav > ul > li > a`\r\n- [ ] CSS selectors are free, let's use them instead of tag ones\r\n- [ ] `vh` units represent a percentage of the current browser viewport height as `vw` represent a percentage of the browser viewport width... but do we really need to set a 100% width to a block element? **style.css:63**\r\n- [ ] Move style.css to its proper folder\r\n- [ ] The `*` selector target every element of a web page, let's use it wisely and not include an inheritable CSS property like `font-family` inside, we can put it in the `body {}`\r\n- [ ] Once we set a position property we should specify a left/right and top/bottom ones so the fixed/absolute element displays properly\r\n\r\nOnce we have those fixed we can finish the tablet styles"}}
{"actor":{"display_login":"oneeyedman"}}