{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/176918249","pull_request_review_id":106708633,"id":176918249,"diff_hunk":"@@ -80,8 +80,10 @@ func init() {\n \t\t\tbootstrap.KubernetesRegistry, bootstrap.ConsulRegistry, bootstrap.EurekaRegistry, bootstrap.CloudFoundryRegistry, bootstrap.MockRegistry))\n \tdiscoveryCmd.PersistentFlags().StringVar(&serverArgs.Config.CFConfig, \"cfConfig\", \"\",\n \t\t\"Cloud Foundry config file\")\n-\tdiscoveryCmd.PersistentFlags().StringVar(&serverArgs.Config.ClusterRegistriesDir, \"clusterRegistriesDir\", \"\",\n-\t\t\"Directory for a file-based cluster config store\")\n+\tdiscoveryCmd.PersistentFlags().StringVar(&serverArgs.Config.ClusterRegistriesConfigmap, \"clusterRegistriesConfigMap\", \"\",","path":"pilot/cmd/pilot-discovery/main.go","position":6,"original_position":6,"commit_id":"fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4","original_commit_id":"fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"100% agree, the only reason I went for it because I was told that these were recently added and have not made into an official release.","created_at":"2018-03-24T19:51:56Z","updated_at":"2018-03-24T19:51:56Z","html_url":"https://github.com/istio/istio/pull/4370#discussion_r176918249","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/4370","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/176918249"},"html":{"href":"https://github.com/istio/istio/pull/4370#discussion_r176918249"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/4370"}},"in_reply_to_id":176887286},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4370","id":176014115,"html_url":"https://github.com/istio/istio/pull/4370","diff_url":"https://github.com/istio/istio/pull/4370.diff","patch_url":"https://github.com/istio/istio/pull/4370.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4370","number":4370,"state":"open","locked":false,"title":"Refactor cluster registry to use Secret to store kubeconf","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"WIP WIP WIP\r\nThis PR refactors cluster registry to use k8s Secret object to store kubeconf files of member clusters.  \r\n\r\n```\r\napiVersion: v1\r\nkind: ConfigMap\r\nmetadata:\r\n  name: clusterregistry\r\n  namespace: istio-system\r\ndata:\r\n  kube-3.yaml: |-\r\n    apiVersion: clusterregistry.k8s.io/v1alpha1\r\n    kind: Cluster\r\n    metadata:\r\n      name: \"kube-3\"\r\n      annotations:\r\n        config.istio.io/pilotEndpoint: \"192.168.80.234:9080\"\r\n        config.istio.io/platform: \"Kubernetes\"\r\n        config.istio.io/pilotCfgStore: True\r\n        config.istio.io/accessConfigSecret: \"kube-3.conf\"   < ---   Name of Secret which stores kube-3 kubeconf config \r\n        config.istio.io/accessConfigSecretNamespace: \"istio-system\"   < ---   Namespace where secrets will be stored.\r\n```","created_at":"2018-03-19T20:19:37Z","updated_at":"2018-03-24T19:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a832c1314bdfbc61475128cfac56f7f00db0cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":780123031,"url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4370/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4370/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4370/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4","head":{"label":"sbezverk:clusters_config_from_secret","ref":"clusters_config_from_secret","sha":"fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"repo":{"id":110725904,"name":"istio","full_name":"sbezverk/istio","owner":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbezverk/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/sbezverk/istio","forks_url":"https://api.github.com/repos/sbezverk/istio/forks","keys_url":"https://api.github.com/repos/sbezverk/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbezverk/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbezverk/istio/teams","hooks_url":"https://api.github.com/repos/sbezverk/istio/hooks","issue_events_url":"https://api.github.com/repos/sbezverk/istio/issues/events{/number}","events_url":"https://api.github.com/repos/sbezverk/istio/events","assignees_url":"https://api.github.com/repos/sbezverk/istio/assignees{/user}","branches_url":"https://api.github.com/repos/sbezverk/istio/branches{/branch}","tags_url":"https://api.github.com/repos/sbezverk/istio/tags","blobs_url":"https://api.github.com/repos/sbezverk/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbezverk/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbezverk/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbezverk/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbezverk/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/sbezverk/istio/languages","stargazers_url":"https://api.github.com/repos/sbezverk/istio/stargazers","contributors_url":"https://api.github.com/repos/sbezverk/istio/contributors","subscribers_url":"https://api.github.com/repos/sbezverk/istio/subscribers","subscription_url":"https://api.github.com/repos/sbezverk/istio/subscription","commits_url":"https://api.github.com/repos/sbezverk/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbezverk/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbezverk/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbezverk/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbezverk/istio/contents/{+path}","compare_url":"https://api.github.com/repos/sbezverk/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbezverk/istio/merges","archive_url":"https://api.github.com/repos/sbezverk/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbezverk/istio/downloads","issues_url":"https://api.github.com/repos/sbezverk/istio/issues{/number}","pulls_url":"https://api.github.com/repos/sbezverk/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/sbezverk/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/sbezverk/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbezverk/istio/labels{/name}","releases_url":"https://api.github.com/repos/sbezverk/istio/releases{/id}","deployments_url":"https://api.github.com/repos/sbezverk/istio/deployments","created_at":"2017-11-14T18:01:29Z","updated_at":"2017-11-14T18:01:34Z","pushed_at":"2018-03-23T20:45:18Z","git_url":"git://github.com/sbezverk/istio.git","ssh_url":"git@github.com:sbezverk/istio.git","clone_url":"https://github.com/sbezverk/istio.git","svn_url":"https://github.com/sbezverk/istio","homepage":"https://istio.io","size":17474,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"3988cfec1c590a5fcfbe75e985fbd7273f255320","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-03-24T19:30:03Z","pushed_at":"2018-03-24T19:29:49Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":18389,"stargazers_count":6761,"watchers_count":6761,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":877,"mirror_url":null,"archived":false,"open_issues_count":784,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":877,"open_issues":784,"watchers":6761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4370"},"html":{"href":"https://github.com/istio/istio/pull/4370"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4370"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4370/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4370/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4370/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sbezverk"}}