{"push_id":2502113717,"size":6,"distinct_size":4,"ref":"refs/heads/msbuildtestfailures","head":"8d514a3903439ee8bf12aec28c0ded8f23245abd","before":"62723be2b4e85bf652d8a2f93efc33baadef2cff","commits":[{"sha":"e937f9b444cc5d0c324cf21ba86b3e1baa3e4bc5","author":{"name":"Marek Habersack","email":"b0507016d1b41902ec9f231681636654cd7fb604@twistedcode.net"},"message":"[build] Generate source file with XA build paths (#1568)\n\nGenerate `bin/Test$(Configuration)/XABuildPaths.cs`, which contains\r\npaths to the top source directory, `xabuild`, `xabuild.exe`, current\r\n`bin` directory, current test output directory and a constant with\r\nthe current configuration name.\r\n\r\nThe paths can be useful in test projects to find various bits and\r\npieces which are currently referred to using paths relative to a\r\nspecific location and thus not really \"portable\" between various test\r\nprojects.","distinct":false,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/e937f9b444cc5d0c324cf21ba86b3e1baa3e4bc5"},{"sha":"b9eb4d39591630406b1c748e5ff466269c79457c","author":{"name":"Jonathan Peppers","email":"bada9c05996b779e3b1d99a9591d4bfcbe6ff4f4@gmail.com"},"message":"[tests] Fix Windows test failures (#1583)\n\nContext: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1605061&_a=summary&tab=details\r\n\r\nNoticed that the `CheckSignApk` tests are failing, and probably have\r\nbeen since 41bc8ff, but the build was not working overall on Windows\r\nat the time -- so we didn't catch it:\r\n\r\n\t##[error]EXEC(0,0): Error : Xamarin.Android.Build.Tests.PackagingTest.CheckSignApk(True,True)\r\n\tEXEC : 1) error : Xamarin.Android.Build.Tests.PackagingTest.CheckSignApk(True,True) [E:\\A\\_work\\2\\s\\Xamarin.Android.sln]\r\n\t  System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\\Users\\dlab\\Documents\\android-toolchain\\sdk\\build-tools'.\r\n\t     at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)\r\n\t     at System.IO.FileSystemEnumerableIterator`1.CommonInit()\r\n\t     at System.IO.Directory.EnumerateDirectories(String path)\r\n\t     at Xamarin.Android.Build.Tests.PackagingTest.CheckSignApk(Boolean useApkSigner, Boolean perAbiApk) in E:\\A\\_work\\2\\s\\src\\Xamarin.Android.Build.Tasks\\Tests\\Xamarin.Android.Build.Tests\\PackagingTest.cs:line 210\r\n\r\n\r\nThe `CheckSignApk()` test had a couple issues:\r\n\r\n  - `C:\\Users\\myuser\\Documents\\android-toolchain\\sdk` was being used\r\n    as the location of the Android SDK on Windows. `BaseTest` needed\r\n    to use `Environment.SpecialFolder.UserProfile` instead of\r\n    `Personal` so that it would instead use e.g.\r\n    `C:\\Users\\myuser\\android-toolchain\\sdk`.\r\n  - `apksigner` is `apksigner.bat` not `apksigner.exe` on Windows.","distinct":false,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/b9eb4d39591630406b1c748e5ff466269c79457c"},{"sha":"d66770c394737684dc29686e9a5ce793340d9fbd","author":{"name":"Dean Ellis","email":"049ca2a632b02fd8d7fb6fd36ea8779ff1a63a3d@googlemail.com"},"message":"[Xamarin.Android.Build.Tests] Use `MSBUILD` environment variable rather than `USE_MSBUILD`.\n\nIn our old unit test system we called into msbuild/xbuild\ndirectly. With our new system we make use of `xabuild`. This\nis a wrapper around msbuild/xbuild which sets up the\nxamarin-android environment.\n\nFor the old tests we passed `USE_MSBUILD` to control if we neeed\nto use msbuild or xbuild. However with `xabuild` we pass the\n`MSBUILD` environment varioable. This can be `msbuild` or `xbuild`\nrather than a `1` or `0`.\n\nThe problem is the old variable was still being used so there\nwas a mismatch between what the tests were expecting and what\nwas being used. So take\n\n\tMSBUILD=msbuild\n\tUSE_MSBUILD=0\n\nThe tests would expect to be using xbuild and will therefore check\nfor xbuild type messages and behaviour. But xabuild would be using\nmsbuild. This results in weird errors.\n\nSo lets get rid of the `USE_MSBUILD` usage and just use the `MSBUILD`\nenvionment variable to decide which system we are using.","distinct":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/d66770c394737684dc29686e9a5ce793340d9fbd"},{"sha":"6c7aba8f4b9a680743848e9c14e6023fd5592936","author":{"name":"Dean Ellis","email":"049ca2a632b02fd8d7fb6fd36ea8779ff1a63a3d@googlemail.com"},"message":"Fixed up variable name","distinct":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/6c7aba8f4b9a680743848e9c14e6023fd5592936"},{"sha":"0e539ba7ee631c010682880cc33a313a77e79e69","author":{"name":"Dean Ellis","email":"049ca2a632b02fd8d7fb6fd36ea8779ff1a63a3d@googlemail.com"},"message":"Removed ResolveLibraryProjectImports changes","distinct":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/0e539ba7ee631c010682880cc33a313a77e79e69"},{"sha":"8d514a3903439ee8bf12aec28c0ded8f23245abd","author":{"name":"Dean Ellis","email":"049ca2a632b02fd8d7fb6fd36ea8779ff1a63a3d@googlemail.com"},"message":"Remove all instances of `USE_MSBUILD`","distinct":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android/commits/8d514a3903439ee8bf12aec28c0ded8f23245abd"}]}
{"actor":{"display_login":"dellis1972"}}