{"action":"created","issue":{"url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/24","repository_url":"https://api.github.com/repos/Zwork101/tf2-trade-bot","labels_url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/24/comments","events_url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/24/events","html_url":"https://github.com/Zwork101/tf2-trade-bot/issues/24","id":285512107,"number":24,"title":"Request, and bugs report.","user":{"login":"JetPony","id":35027998,"avatar_url":"https://avatars3.githubusercontent.com/u/35027998?v=4","gravatar_id":"","url":"https://api.github.com/users/JetPony","html_url":"https://github.com/JetPony","followers_url":"https://api.github.com/users/JetPony/followers","following_url":"https://api.github.com/users/JetPony/following{/other_user}","gists_url":"https://api.github.com/users/JetPony/gists{/gist_id}","starred_url":"https://api.github.com/users/JetPony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetPony/subscriptions","organizations_url":"https://api.github.com/users/JetPony/orgs","repos_url":"https://api.github.com/users/JetPony/repos","events_url":"https://api.github.com/users/JetPony/events{/privacy}","received_events_url":"https://api.github.com/users/JetPony/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2018-01-02T19:11:11Z","updated_at":"2018-03-08T00:23:23Z","closed_at":null,"author_association":"NONE","body":"Sorry for bad english, not my language.\r\n\r\nbug 1.\r\nFor some reason sometimes bot rejects trade who have metal change.\r\nFor example. Someone is selling to bot item for 10.11 ref. The seller sees that the bot has run out scrap and rec, and instead of 10.11 ref he takes 11 ref, and adds 0.88 ref for his item as change.\r\n  In the ordinary situation, this is absolutely good deal and should be accepted. But the bot rejects such a trade as the wrong price.\r\n However, in situations where change only 1 scrap or 1 rec bot accepts. Something is more complicated than this, the bot rejects. I do not know exactly why and how this is happening, but it happens.\r\n \r\nbug 2.\r\nBot does not see a difference between regular trade and 15 days withholding trade. (For new  Steam users, who have not installed mobile phone protection.) So the bot accepts any 15 days hold trade who have the right price.\r\n I understand that any profitable trade is a good trade, but in the case of 15 days hold, it is wrong. \r\nFor example. I have 100 ref, as a good trader, I can turn these 100 ref into 200 ref less than 3 days. However, if these 100 ref got into 15 days hold trade, I can not do anything, and I can not get any profit. these 100 refs are simply frozen. So the bot should be learned to see the difference between regular trade and 15 days hold trade. \r\n And for users who want to accept such trades, in \"settings.json\" you can add an option, enable or disable 15 days hold trade. Аnd enable or disable 15 days hold  gift trade. In case if someone sends a gift with 15 days hold trade. (sometimes it happens)\r\n\r\nbug 3.\r\nBot does not see a difference between uncraftable and craftable items. \r\n Some uncraftable and craftable items have a big difference in price. And because the bot does not see the difference between them. this can be exploit. someone can buy cheap uncraftable items and sell them to the bot in price as craftable items. Or something  similar.\r\n So the bot should be learned to see the difference between uncraftable and craftable items.\r\nAnd in \"trade.csv\" user could set a price for uncraftable and craftable items separately.\r\nfor example:\r\n\\\\\r\nBackpack Expander, 0.0.16.0.0, buy\r\nNon-Craftable Backpack Expander, 0.0.13.0.0, buy\r\n\\\\\r\nor something similar.\r\n\r\n These are all the bugs that I found. I would be happy if they would been fix in the near future. Next will go a Request that I would be happy to see in future bot update. but they are not so important as bugs.\r\n\r\nRequest 1.\r\nPlease add a variable \"Do not cancel the trade with unknown items\" in \"settings.json\"\r\n For example. If someone buys a key and put the wrong number of ref or nothing, this obviously should be rejected. But if someone put unknown items? who knows, maybe this is a profitable trade. Of course, trade like this, will have to be checked by the user himself. But, this is better than if the bot will be reject all such a trades. of course this can be turned on or off,\r\n\r\nRequest 2.\r\nPlease add the possibility to set a limit for buying items.\r\nfor example. in \"trade.csv\"\r\n\\\\\r\nMann Co. Supply Crate Key, 0.0.38.0.0, buy (limit, 10)\r\n\\\\\r\nWhere (limit, 10) means that the bot will stop buying these items when their number in the backpack <= 10.\r\nor something similar. limit for sell items, it's necessary.\r\n\r\nRequest 3.\r\nPlease add a trade history. I know that a trade history can be check in Steam. But this section loads forever and super lag. Also the whole trade history is in the \"trade.log\" but there is literally everything (every bot tick.) after a day of work, i can not even check \"trade.log\" too much text inside.\r\n It would be nice if the bot recorded all processed trade in a separate text file. When creating a new text file, every time it \"bot.py\" starts. That would be enough.\r\n\r\nRequest 4.\r\nPlease make a different colors for processing  trade in the program console.\r\nWhen the trade is accepted.\r\nline \"Looks good\" make green.\r\nWhen the trade is rejected.\r\nline \"Not good\" make red.\r\nAnd When the trade is ignored. (if yu add a variable \"Do not cancel the trade with unknown items\")\r\nline \"Unknown items\" make yellow.\r\nI know that this is not important. But it be nice. =)\r\n\r\n                                                          From me.\r\n Thanks for creating this bot. I just started learning programming and do not know much. But your bot is the easiest to install and completely cantrols all config. Best bot. I sent a little donate on your Steam. I hope the bot will be evolve and gets better. If so, I will not forget it. Thank you for your time."},"comment":{"url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/comments/371333118","html_url":"https://github.com/Zwork101/tf2-trade-bot/issues/24#issuecomment-371333118","issue_url":"https://api.github.com/repos/Zwork101/tf2-trade-bot/issues/24","id":371333118,"user":{"login":"JetPony","id":35027998,"avatar_url":"https://avatars3.githubusercontent.com/u/35027998?v=4","gravatar_id":"","url":"https://api.github.com/users/JetPony","html_url":"https://github.com/JetPony","followers_url":"https://api.github.com/users/JetPony/followers","following_url":"https://api.github.com/users/JetPony/following{/other_user}","gists_url":"https://api.github.com/users/JetPony/gists{/gist_id}","starred_url":"https://api.github.com/users/JetPony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetPony/subscriptions","organizations_url":"https://api.github.com/users/JetPony/orgs","repos_url":"https://api.github.com/users/JetPony/repos","events_url":"https://api.github.com/users/JetPony/events{/privacy}","received_events_url":"https://api.github.com/users/JetPony/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T00:20:05Z","updated_at":"2018-03-08T00:20:05Z","author_association":"NONE","body":"And I remind you that i do not know English. I use Google translator to speak or understand what you are saying. it is possible on discord?"}}
{"actor":{"display_login":"JetPony"}}