{"action":"opened","number":25,"pull_request":{"url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25","id":239778958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Nzc4OTU4","html_url":"https://github.com/romix/java-concurrent-hash-trie-map/pull/25","diff_url":"https://github.com/romix/java-concurrent-hash-trie-map/pull/25.diff","patch_url":"https://github.com/romix/java-concurrent-hash-trie-map/pull/25.patch","issue_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/25","number":25,"state":"open","locked":false,"title":"Fix putIfAbsent / rec_insertif in case of an LNode and current node value is None (instead of null).","user":{"login":"mikesajak","id":9003064,"node_id":"MDQ6VXNlcjkwMDMwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9003064?v=4","gravatar_id":"","url":"https://api.github.com/users/mikesajak","html_url":"https://github.com/mikesajak","followers_url":"https://api.github.com/users/mikesajak/followers","following_url":"https://api.github.com/users/mikesajak/following{/other_user}","gists_url":"https://api.github.com/users/mikesajak/gists{/gist_id}","starred_url":"https://api.github.com/users/mikesajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikesajak/subscriptions","organizations_url":"https://api.github.com/users/mikesajak/orgs","repos_url":"https://api.github.com/users/mikesajak/repos","events_url":"https://api.github.com/users/mikesajak/events{/privacy}","received_events_url":"https://api.github.com/users/mikesajak/received_events","type":"User","site_admin":false},"body":"This small code change fixes the handling of LNode \"KEY_ABSENT\" case when adding element to TrieMap. The problem is that getting current value from node (from it's internal ListMap) can never return null. It will return either Some or None. So the current check for null will not add element to node if that get will return None falsely assuming that element already exists.\r\nIn the scala source version there is also only pattern match for None and Some.","created_at":"2018-12-19T10:12:22Z","updated_at":"2018-12-19T10:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25/commits","review_comments_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25/comments","review_comment_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/25/comments","statuses_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/statuses/a211287718754347d25b91bb6fbe19b9e984b76c","head":{"label":"mikesajak:fix-putIfAbsent","ref":"fix-putIfAbsent","sha":"a211287718754347d25b91bb6fbe19b9e984b76c","user":{"login":"mikesajak","id":9003064,"node_id":"MDQ6VXNlcjkwMDMwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9003064?v=4","gravatar_id":"","url":"https://api.github.com/users/mikesajak","html_url":"https://github.com/mikesajak","followers_url":"https://api.github.com/users/mikesajak/followers","following_url":"https://api.github.com/users/mikesajak/following{/other_user}","gists_url":"https://api.github.com/users/mikesajak/gists{/gist_id}","starred_url":"https://api.github.com/users/mikesajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikesajak/subscriptions","organizations_url":"https://api.github.com/users/mikesajak/orgs","repos_url":"https://api.github.com/users/mikesajak/repos","events_url":"https://api.github.com/users/mikesajak/events{/privacy}","received_events_url":"https://api.github.com/users/mikesajak/received_events","type":"User","site_admin":false},"repo":{"id":162311211,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzMTEyMTE=","name":"java-concurrent-hash-trie-map","full_name":"mikesajak/java-concurrent-hash-trie-map","private":false,"owner":{"login":"mikesajak","id":9003064,"node_id":"MDQ6VXNlcjkwMDMwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9003064?v=4","gravatar_id":"","url":"https://api.github.com/users/mikesajak","html_url":"https://github.com/mikesajak","followers_url":"https://api.github.com/users/mikesajak/followers","following_url":"https://api.github.com/users/mikesajak/following{/other_user}","gists_url":"https://api.github.com/users/mikesajak/gists{/gist_id}","starred_url":"https://api.github.com/users/mikesajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikesajak/subscriptions","organizations_url":"https://api.github.com/users/mikesajak/orgs","repos_url":"https://api.github.com/users/mikesajak/repos","events_url":"https://api.github.com/users/mikesajak/events{/privacy}","received_events_url":"https://api.github.com/users/mikesajak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikesajak/java-concurrent-hash-trie-map","description":"Java port of a concurrent trie hash map implementation from the Scala collections library","fork":true,"url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map","forks_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/forks","keys_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/teams","hooks_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/hooks","issue_events_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/issues/events{/number}","events_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/events","assignees_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/assignees{/user}","branches_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/branches{/branch}","tags_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/tags","blobs_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/statuses/{sha}","languages_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/languages","stargazers_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/stargazers","contributors_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/contributors","subscribers_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/subscribers","subscription_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/subscription","commits_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/contents/{+path}","compare_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/merges","archive_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/downloads","issues_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/issues{/number}","pulls_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/pulls{/number}","milestones_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/milestones{/number}","notifications_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/labels{/name}","releases_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/releases{/id}","deployments_url":"https://api.github.com/repos/mikesajak/java-concurrent-hash-trie-map/deployments","created_at":"2018-12-18T15:49:57Z","updated_at":"2018-12-18T15:49:59Z","pushed_at":"2018-12-18T16:26:15Z","git_url":"git://github.com/mikesajak/java-concurrent-hash-trie-map.git","ssh_url":"git@github.com:mikesajak/java-concurrent-hash-trie-map.git","clone_url":"https://github.com/mikesajak/java-concurrent-hash-trie-map.git","svn_url":"https://github.com/mikesajak/java-concurrent-hash-trie-map","homepage":null,"size":65,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"romix:master","ref":"master","sha":"1810db51acdb1c8b7048643b460c526933c95dae","user":{"login":"romix","id":1481811,"node_id":"MDQ6VXNlcjE0ODE4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1481811?v=4","gravatar_id":"","url":"https://api.github.com/users/romix","html_url":"https://github.com/romix","followers_url":"https://api.github.com/users/romix/followers","following_url":"https://api.github.com/users/romix/following{/other_user}","gists_url":"https://api.github.com/users/romix/gists{/gist_id}","starred_url":"https://api.github.com/users/romix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romix/subscriptions","organizations_url":"https://api.github.com/users/romix/orgs","repos_url":"https://api.github.com/users/romix/repos","events_url":"https://api.github.com/users/romix/events{/privacy}","received_events_url":"https://api.github.com/users/romix/received_events","type":"User","site_admin":false},"repo":{"id":5765579,"node_id":"MDEwOlJlcG9zaXRvcnk1NzY1NTc5","name":"java-concurrent-hash-trie-map","full_name":"romix/java-concurrent-hash-trie-map","private":false,"owner":{"login":"romix","id":1481811,"node_id":"MDQ6VXNlcjE0ODE4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1481811?v=4","gravatar_id":"","url":"https://api.github.com/users/romix","html_url":"https://github.com/romix","followers_url":"https://api.github.com/users/romix/followers","following_url":"https://api.github.com/users/romix/following{/other_user}","gists_url":"https://api.github.com/users/romix/gists{/gist_id}","starred_url":"https://api.github.com/users/romix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romix/subscriptions","organizations_url":"https://api.github.com/users/romix/orgs","repos_url":"https://api.github.com/users/romix/repos","events_url":"https://api.github.com/users/romix/events{/privacy}","received_events_url":"https://api.github.com/users/romix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romix/java-concurrent-hash-trie-map","description":"Java port of a concurrent trie hash map implementation from the Scala collections library","fork":false,"url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map","forks_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/forks","keys_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/teams","hooks_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/hooks","issue_events_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/events{/number}","events_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/events","assignees_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/assignees{/user}","branches_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/branches{/branch}","tags_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/tags","blobs_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/statuses/{sha}","languages_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/languages","stargazers_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/stargazers","contributors_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/contributors","subscribers_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/subscribers","subscription_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/subscription","commits_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/contents/{+path}","compare_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/merges","archive_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/downloads","issues_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues{/number}","pulls_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls{/number}","milestones_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/milestones{/number}","notifications_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/labels{/name}","releases_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/releases{/id}","deployments_url":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/deployments","created_at":"2012-09-11T13:43:17Z","updated_at":"2018-12-14T13:28:47Z","pushed_at":"2016-11-19T19:49:12Z","git_url":"git://github.com/romix/java-concurrent-hash-trie-map.git","ssh_url":"git@github.com:romix/java-concurrent-hash-trie-map.git","clone_url":"https://github.com/romix/java-concurrent-hash-trie-map.git","svn_url":"https://github.com/romix/java-concurrent-hash-trie-map","homepage":null,"size":487,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":6,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25"},"html":{"href":"https://github.com/romix/java-concurrent-hash-trie-map/pull/25"},"issue":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/25"},"comments":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/romix/java-concurrent-hash-trie-map/statuses/a211287718754347d25b91bb6fbe19b9e984b76c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mikesajak"}}