{"action":"created","issue":{"url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/350","repository_url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw","labels_url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/350/comments","events_url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/350/events","html_url":"https://github.com/connectivedx/fuzzy-chainsaw/pull/350","id":304844305,"number":350,"title":"add enableNotifier option to fc-config.js","user":{"login":"bstaruk","id":1264040,"avatar_url":"https://avatars0.githubusercontent.com/u/1264040?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaruk","html_url":"https://github.com/bstaruk","followers_url":"https://api.github.com/users/bstaruk/followers","following_url":"https://api.github.com/users/bstaruk/following{/other_user}","gists_url":"https://api.github.com/users/bstaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaruk/subscriptions","organizations_url":"https://api.github.com/users/bstaruk/orgs","repos_url":"https://api.github.com/users/bstaruk/repos","events_url":"https://api.github.com/users/bstaruk/events{/privacy}","received_events_url":"https://api.github.com/users/bstaruk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-13T16:41:10Z","updated_at":"2018-03-14T09:41:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/pulls/350","html_url":"https://github.com/connectivedx/fuzzy-chainsaw/pull/350","diff_url":"https://github.com/connectivedx/fuzzy-chainsaw/pull/350.diff","patch_url":"https://github.com/connectivedx/fuzzy-chainsaw/pull/350.patch"},"body":"Some folks love the notification toasts that we use on FC and some people don't. No one is right or wrong, and the best way to make everyone happy is to allow our users to toggle them as desired.\r\n\r\nThe code changes in this PR adds a new option to `/source/fc-config.js` called `enableNotifier` which is set to `true` by default. So out of the box, there is no change to the current behavior of FC.\r\n\r\nIf someone should want to disable these notifications, they can toggle that setting to false and the notifications will no longer appear.\r\n\r\nI was going to build options, such as allowing users to only see failure notifications (and not warnings or successes), but the only type of notification that can be suppressed with [webpack-notifier](https://github.com/Turbo87/webpack-notifier) is warnings... so I kept things simple.\r\n\r\n## How Has This Been Tested?\r\nThe three tasks that were modified (dll, build & dev) were thoroughly tested and no issues were found.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/comments/372960509","html_url":"https://github.com/connectivedx/fuzzy-chainsaw/pull/350#issuecomment-372960509","issue_url":"https://api.github.com/repos/connectivedx/fuzzy-chainsaw/issues/350","id":372960509,"user":{"login":"bstaruk","id":1264040,"avatar_url":"https://avatars0.githubusercontent.com/u/1264040?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaruk","html_url":"https://github.com/bstaruk","followers_url":"https://api.github.com/users/bstaruk/followers","following_url":"https://api.github.com/users/bstaruk/following{/other_user}","gists_url":"https://api.github.com/users/bstaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaruk/subscriptions","organizations_url":"https://api.github.com/users/bstaruk/orgs","repos_url":"https://api.github.com/users/bstaruk/repos","events_url":"https://api.github.com/users/bstaruk/events{/privacy}","received_events_url":"https://api.github.com/users/bstaruk/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T09:41:13Z","updated_at":"2018-03-14T09:41:13Z","author_association":"MEMBER","body":"I would really like a way to disable the notifications, personally -- I really just don't care for them (and quite strongly, at that).\r\n\r\nI am gonna review #322 today and hopefully we can get that merged in, then I can re-patch the work done here to accommodate the code changes."}}
{"actor":{"display_login":"bstaruk"}}