{"action":"created","issue":{"url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/238","repository_url":"https://api.github.com/repos/nystudio107/craft-seomatic","labels_url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/238/comments","events_url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/238/events","html_url":"https://github.com/nystudio107/craft-seomatic/pull/238","id":366635407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjU5NTkx","number":238,"title":"Fix #235","user":{"login":"glitchedmob","id":9029666,"node_id":"MDQ6VXNlcjkwMjk2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9029666?v=4","gravatar_id":"","url":"https://api.github.com/users/glitchedmob","html_url":"https://github.com/glitchedmob","followers_url":"https://api.github.com/users/glitchedmob/followers","following_url":"https://api.github.com/users/glitchedmob/following{/other_user}","gists_url":"https://api.github.com/users/glitchedmob/gists{/gist_id}","starred_url":"https://api.github.com/users/glitchedmob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glitchedmob/subscriptions","organizations_url":"https://api.github.com/users/glitchedmob/orgs","repos_url":"https://api.github.com/users/glitchedmob/repos","events_url":"https://api.github.com/users/glitchedmob/events{/privacy}","received_events_url":"https://api.github.com/users/glitchedmob/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-04T06:07:53Z","updated_at":"2018-10-04T06:10:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nystudio107/craft-seomatic/pulls/238","html_url":"https://github.com/nystudio107/craft-seomatic/pull/238","diff_url":"https://github.com/nystudio107/craft-seomatic/pull/238.diff","patch_url":"https://github.com/nystudio107/craft-seomatic/pull/238.patch"},"body":"This PR attempts to fix issue #235. \r\n\r\nLet me preface this with saying that I'm totally willing to make changes and take comments/criticism. I'm very new to Craft plugin development in general and trying to get better.\r\n\r\nNot real sure if this a good solution or not, but it's something I've seen other plugins do. This does feel a little gross with the global function, but it's a pattern that already exists in the same js file. I did prefix the global function with the seomatic to avoid potential collisions with other plugins that may have a function with the same name.\r\n\r\nI also tested this change with a brand new craft install with a couple of basic entry types.\r\n"},"comment":{"url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/comments/426896858","html_url":"https://github.com/nystudio107/craft-seomatic/pull/238#issuecomment-426896858","issue_url":"https://api.github.com/repos/nystudio107/craft-seomatic/issues/238","id":426896858,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjg5Njg1OA==","user":{"login":"glitchedmob","id":9029666,"node_id":"MDQ6VXNlcjkwMjk2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9029666?v=4","gravatar_id":"","url":"https://api.github.com/users/glitchedmob","html_url":"https://github.com/glitchedmob","followers_url":"https://api.github.com/users/glitchedmob/followers","following_url":"https://api.github.com/users/glitchedmob/following{/other_user}","gists_url":"https://api.github.com/users/glitchedmob/gists{/gist_id}","starred_url":"https://api.github.com/users/glitchedmob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glitchedmob/subscriptions","organizations_url":"https://api.github.com/users/glitchedmob/orgs","repos_url":"https://api.github.com/users/glitchedmob/repos","events_url":"https://api.github.com/users/glitchedmob/events{/privacy}","received_events_url":"https://api.github.com/users/glitchedmob/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T06:10:55Z","updated_at":"2018-10-04T06:10:55Z","author_association":"NONE","body":"Another note, I did not commit the built static assets. I ran a build before making any changes and it came back with some changed files. I didn't want to accidentally commit something that may have been caused by my environment not being 100% the same"}}
{"actor":{"display_login":"glitchedmob"}}