{"push_id":2812334047,"size":2,"distinct_size":1,"ref":"refs/heads/develop","head":"a557cf026d4cb5f640473ac634e9202837de61de","before":"440c66a1632b0d5a3059808a355722d4f606bd21","commits":[{"sha":"21dcda21f1e11c2e8210faa350814d60eb801d75","author":{"name":"Jonathan Poltak Samosir","email":"fa98151a98caca17fafe001492ec49b35ef427f8@gmail.com"},"message":"Refactor popup codebase - TS + redux + modularized\n\nPort popup `<Button>` comp. to TS\n\nCreate separate container for popup bookmark btn\n\n- move all related logic out of popup container\n- ported and simplified that to TS\n\nCreate separate container for blacklist btn\n\n- not everything moved out yet\n\nSet up + hook up redux store for popup UI\n\nWrite blacklist btn UI state modules\n\n- mainly porting from react to redux; still more to come but still lives in main popup container\n- made own feature dir in `popup/blacklist-button`\n\nPort all popup blacklist UI state to redux\n\nPort popup bookmark btn UI state to redux\n\nFix background's page blacklisted check\n\nMove popup tags button to own feature dir\n\nMove popup collections button to own feature dir\n\nPort HistoryPauser comp to TS\n\nRefactor popup pause button to own feature dir\n\nFix bug with infinity timeout\n\n- sending `Infinity` over the RPC connection results in `null` being received on the bg script end for some reason; now it defaults to `Infinity` if value not defined\n\nDRY-out pause button by extending common Button\n\nPort popup ToggleTooltip to TS\n\n- I don't see why there are 2 ToggleTooltip components (one more in `common-ui`), but I spent too much time trying to get the other one to style properly\n\nPort main tab-related popup states to redux\n\nMove popup tooltip button to own feature dir\n\nFix blacklist button state init timing\n\nPort notif button state to TS + redux\n\nCreate `index` modules for each popup feature dir\n\nMove remaining popup container state to redux\n\nMove bookmark async action to thunk\n\nPort smaller popup component modules to TS\n\nFix icon button styles\n\n- somehow I changed the ordering of the button icons (settings needs to be last)\n- also needs the margin-right offset on the settings icon\n- don't really understand what's happening with these styles\n\nPort remaining popup components to TS\n\nFix blacklist deleting by domain\n\n- wasn't sending the domain to the backend; sent whole URL instead\n\nFix up domain derivation in blacklist delete\n\nSplit up container props into dispatch+state+ownProps\n\n- this allows the containers to be properly used in another TS container (won't complain about missing types now that they are split properly)\n- main popup container ported to TS","distinct":false,"url":"https://api.github.com/repos/WorldBrain/Memex/commits/21dcda21f1e11c2e8210faa350814d60eb801d75"},{"sha":"a557cf026d4cb5f640473ac634e9202837de61de","author":{"name":"Jonathan Poltak Samosir","email":"fa98151a98caca17fafe001492ec49b35ef427f8@gmail.com"},"message":"Merge pull request #519 from WorldBrain/feature/popup-refactor\n\nPopup refactor","distinct":true,"url":"https://api.github.com/repos/WorldBrain/Memex/commits/a557cf026d4cb5f640473ac634e9202837de61de"}]}
{"actor":{"display_login":"poltak"}}