{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/217905467","pull_request_review_id":155735618,"id":217905467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkwNTQ2Nw==","diff_hunk":"@@ -168,20 +168,28 @@ find_match_case_label=Match case\n find_entire_word_label=Whole words\n find_reached_top=Reached top of document, continued from bottom\n find_reached_bottom=Reached end of document, continued from top\n-# LOCALIZATION NOTE (find_matches_count): The supported plural forms are\n+# LOCALIZATION NOTE (find_match_count): The supported plural forms are\n # [zero|one|two|few|many|other], with [other] as the default value.\n # \"{{current}}\" and \"{{total}}\" will be replaced by a number representing the\n # index of the currently active find result, respectively a number representing\n # the total number of matches in the document.\n-find_matches_count={[ plural(n) ]}\n-find_matches_count[one]={{current}} of {{total}} match\n-find_matches_count[other]={{current}} of {{total}} matches\n-# LOCALIZATION NOTE (find_matches_count_limit): The supported plural forms are\n+find_match_count={[ plural(n) ]}","path":"l10n/en-US/viewer.properties","position":14,"original_position":14,"commit_id":"e52f6158ef8583b610308f586f45417758e3b3a2","original_commit_id":"e52f6158ef8583b610308f586f45417758e3b3a2","user":{"login":"Snuffleupagus","id":2692120,"node_id":"MDQ6VXNlcjI2OTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Having looked at the Firefox findbar implementation again, [see here](https://searchfox.org/mozilla-central/rev/7a91966c106a3dde924e040b4e5b72d33eb77bf7/toolkit/content/widgets/findbar.js#1133-1142), I'm no longer convinced that there's any attempting to format these numbers according to locale.\r\nSo it might be possible to simply this by remove the `toLocaleString()` calls from the JS code, and then change this to just `plural(total)` (and `plural(limit` for for the other string below).","created_at":"2018-09-16T07:48:54Z","updated_at":"2018-09-16T07:48:54Z","html_url":"https://github.com/mozilla/pdf.js/pull/10078#discussion_r217905467","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/217905467"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/10078#discussion_r217905467"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078","id":215784336,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzg0MzM2","html_url":"https://github.com/mozilla/pdf.js/pull/10078","diff_url":"https://github.com/mozilla/pdf.js/pull/10078.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/10078.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10078","number":10078,"state":"open","locked":false,"title":"Improve plural support for the matches counter","user":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"body":"Fixes #10076. The string IDs are unique and all plural forms have been provided. I kept `plural(n)` as explained in https://github.com/mozilla/pdf.js/issues/10076#issuecomment-421613069.\r\n\r\n/cc @flodolo and @Snuffleupagus for review","created_at":"2018-09-15T19:02:28Z","updated_at":"2018-09-16T07:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf5721350a53d788b884574bd17bc66d1d9a886","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":164429,"node_id":"MDU6TGFiZWwxNjQ0Mjk=","url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10078/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/e52f6158ef8583b610308f586f45417758e3b3a2","head":{"label":"timvandermeij:l10n-fix","ref":"l10n-fix","sha":"e52f6158ef8583b610308f586f45417758e3b3a2","user":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"repo":{"id":6161909,"node_id":"MDEwOlJlcG9zaXRvcnk2MTYxOTA5","name":"pdf.js","full_name":"timvandermeij/pdf.js","private":false,"owner":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timvandermeij/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/timvandermeij/pdf.js","forks_url":"https://api.github.com/repos/timvandermeij/pdf.js/forks","keys_url":"https://api.github.com/repos/timvandermeij/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timvandermeij/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timvandermeij/pdf.js/teams","hooks_url":"https://api.github.com/repos/timvandermeij/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/timvandermeij/pdf.js/events","assignees_url":"https://api.github.com/repos/timvandermeij/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/timvandermeij/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/timvandermeij/pdf.js/tags","blobs_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timvandermeij/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/timvandermeij/pdf.js/languages","stargazers_url":"https://api.github.com/repos/timvandermeij/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/timvandermeij/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/timvandermeij/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/timvandermeij/pdf.js/subscription","commits_url":"https://api.github.com/repos/timvandermeij/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/timvandermeij/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/timvandermeij/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/timvandermeij/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timvandermeij/pdf.js/merges","archive_url":"https://api.github.com/repos/timvandermeij/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timvandermeij/pdf.js/downloads","issues_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/timvandermeij/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/timvandermeij/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/timvandermeij/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timvandermeij/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/timvandermeij/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/timvandermeij/pdf.js/deployments","created_at":"2012-10-10T18:16:22Z","updated_at":"2018-09-15T18:40:36Z","pushed_at":"2018-09-15T19:00:53Z","git_url":"git://github.com/timvandermeij/pdf.js.git","ssh_url":"git@github.com:timvandermeij/pdf.js.git","clone_url":"https://github.com/timvandermeij/pdf.js.git","svn_url":"https://github.com/timvandermeij/pdf.js","homepage":"","size":78995,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ed32f6a0827dd594941706dbef2a4d76acb934c5","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzNDY4","name":"pdf.js","full_name":"mozilla/pdf.js","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2018-09-16T02:07:15Z","pushed_at":"2018-09-16T06:55:48Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":81343,"stargazers_count":23401,"watchers_count":23401,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5727,"mirror_url":null,"archived":false,"open_issues_count":716,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5727,"open_issues":716,"watchers":23401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/10078"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/10078"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/10078/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/10078/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/e52f6158ef8583b610308f586f45417758e3b3a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Snuffleupagus"}}