{"action":"created","comment":{"url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/comments/186753723","pull_request_review_id":118394662,"id":186753723,"diff_hunk":"@@ -1,28 +1,24 @@\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n-<manifest xmlns:android=\"http://schemas.android.com/apk/res/android\"\n-    package=\"com.alamkanak.weekview.sample\">\n+<manifest xmlns:tools=\"http://schemas.android.com/tools\" package=\"com.alamkanak.weekview.sample\" xmlns:android=\"http://schemas.android.com/apk/res/android\">\n \n-    <uses-permission android:name=\"android.permission.INTERNET\" />\n+    <uses-permission android:name=\"android.permission.INTERNET\"/>\n \n     <application\n-        android:allowBackup=\"true\"\n-        android:icon=\"@drawable/ic_launcher\"\n-        android:label=\"@string/app_name\"\n-        android:theme=\"@style/AppTheme\">\n+        android:allowBackup=\"true\" android:icon=\"@drawable/ic_launcher\" android:label=\"@string/app_name\"\n+        android:theme=\"@style/AppTheme\" tools:ignore=\"AllowBackup,GoogleAppIndexingWarning\">","path":"sample/src/main/AndroidManifest.xml","position":15,"original_position":15,"commit_id":"1f9e199bc1c6716219fae4e17f1ca591ec6b6868","original_commit_id":"2b59062d24728f76d0979b84db1da36a8052ffe2","user":{"login":"SkyleKayma","id":17049216,"avatar_url":"https://avatars3.githubusercontent.com/u/17049216?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyleKayma","html_url":"https://github.com/SkyleKayma","followers_url":"https://api.github.com/users/SkyleKayma/followers","following_url":"https://api.github.com/users/SkyleKayma/following{/other_user}","gists_url":"https://api.github.com/users/SkyleKayma/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyleKayma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyleKayma/subscriptions","organizations_url":"https://api.github.com/users/SkyleKayma/orgs","repos_url":"https://api.github.com/users/SkyleKayma/repos","events_url":"https://api.github.com/users/SkyleKayma/events{/privacy}","received_events_url":"https://api.github.com/users/SkyleKayma/received_events","type":"User","site_admin":false},"body":"Yeah you are right.","created_at":"2018-05-08T14:45:31Z","updated_at":"2018-05-08T14:45:31Z","html_url":"https://github.com/Quivr/Android-Week-View/pull/97#discussion_r186753723","pull_request_url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/comments/186753723"},"html":{"href":"https://github.com/Quivr/Android-Week-View/pull/97#discussion_r186753723"},"pull_request":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97"}},"in_reply_to_id":186390903},"pull_request":{"url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97","id":186307466,"html_url":"https://github.com/Quivr/Android-Week-View/pull/97","diff_url":"https://github.com/Quivr/Android-Week-View/pull/97.diff","patch_url":"https://github.com/Quivr/Android-Week-View/pull/97.patch","issue_url":"https://api.github.com/repos/Quivr/Android-Week-View/issues/97","number":97,"state":"open","locked":false,"title":"A lot of changes: Kotlin, time/date formatting fixes, demo activity for whole view snapping...","user":{"login":"AndroidDeveloperLB","id":5357526,"avatar_url":"https://avatars0.githubusercontent.com/u/5357526?v=4","gravatar_id":"","url":"https://api.github.com/users/AndroidDeveloperLB","html_url":"https://github.com/AndroidDeveloperLB","followers_url":"https://api.github.com/users/AndroidDeveloperLB/followers","following_url":"https://api.github.com/users/AndroidDeveloperLB/following{/other_user}","gists_url":"https://api.github.com/users/AndroidDeveloperLB/gists{/gist_id}","starred_url":"https://api.github.com/users/AndroidDeveloperLB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndroidDeveloperLB/subscriptions","organizations_url":"https://api.github.com/users/AndroidDeveloperLB/orgs","repos_url":"https://api.github.com/users/AndroidDeveloperLB/repos","events_url":"https://api.github.com/users/AndroidDeveloperLB/events{/privacy}","received_events_url":"https://api.github.com/users/AndroidDeveloperLB/received_events","type":"User","site_admin":false},"body":"I've prepared a pull request that allows to snap by entire view (week by week, for example) based on [this pull request](https://github.com/Quivr/Android-Week-View/pull/88), together with some fixes of issues I've found, and conversion to 100% Kotlin code.\r\n\r\nSadly, some issues that I've found still exist:\r\n- https://github.com/Quivr/Android-Week-View/issues/31#issuecomment-387005542 - slow on the normal sample activities. No idea why they occur (maybe the dragging feature?), but the new activity doesn't have those.\r\n- https://github.com/alamkanak/Android-Week-View/issues/495 - the RTL direction issue.\r\n- https://github.com/alamkanak/Android-Week-View/issues/494 - shortened format even though there is enough space\r\n-https://github.com/Quivr/Android-Week-View/issues/31#issuecomment-387005542 - snapping can be to part of the day.","created_at":"2018-05-07T10:00:49Z","updated_at":"2018-05-08T14:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf926f107e7a311b8a1f5995bcbeb8870a62dc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97/commits","review_comments_url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97/comments","review_comment_url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Quivr/Android-Week-View/issues/97/comments","statuses_url":"https://api.github.com/repos/Quivr/Android-Week-View/statuses/1f9e199bc1c6716219fae4e17f1ca591ec6b6868","head":{"label":"AndroidDeveloperLB:develop","ref":"develop","sha":"1f9e199bc1c6716219fae4e17f1ca591ec6b6868","user":{"login":"AndroidDeveloperLB","id":5357526,"avatar_url":"https://avatars0.githubusercontent.com/u/5357526?v=4","gravatar_id":"","url":"https://api.github.com/users/AndroidDeveloperLB","html_url":"https://github.com/AndroidDeveloperLB","followers_url":"https://api.github.com/users/AndroidDeveloperLB/followers","following_url":"https://api.github.com/users/AndroidDeveloperLB/following{/other_user}","gists_url":"https://api.github.com/users/AndroidDeveloperLB/gists{/gist_id}","starred_url":"https://api.github.com/users/AndroidDeveloperLB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndroidDeveloperLB/subscriptions","organizations_url":"https://api.github.com/users/AndroidDeveloperLB/orgs","repos_url":"https://api.github.com/users/AndroidDeveloperLB/repos","events_url":"https://api.github.com/users/AndroidDeveloperLB/events{/privacy}","received_events_url":"https://api.github.com/users/AndroidDeveloperLB/received_events","type":"User","site_admin":false},"repo":{"id":132426832,"name":"Android-Week-View","full_name":"AndroidDeveloperLB/Android-Week-View","owner":{"login":"AndroidDeveloperLB","id":5357526,"avatar_url":"https://avatars0.githubusercontent.com/u/5357526?v=4","gravatar_id":"","url":"https://api.github.com/users/AndroidDeveloperLB","html_url":"https://github.com/AndroidDeveloperLB","followers_url":"https://api.github.com/users/AndroidDeveloperLB/followers","following_url":"https://api.github.com/users/AndroidDeveloperLB/following{/other_user}","gists_url":"https://api.github.com/users/AndroidDeveloperLB/gists{/gist_id}","starred_url":"https://api.github.com/users/AndroidDeveloperLB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndroidDeveloperLB/subscriptions","organizations_url":"https://api.github.com/users/AndroidDeveloperLB/orgs","repos_url":"https://api.github.com/users/AndroidDeveloperLB/repos","events_url":"https://api.github.com/users/AndroidDeveloperLB/events{/privacy}","received_events_url":"https://api.github.com/users/AndroidDeveloperLB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndroidDeveloperLB/Android-Week-View","description":"Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.","fork":true,"url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View","forks_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/forks","keys_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/teams","hooks_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/hooks","issue_events_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/issues/events{/number}","events_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/events","assignees_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/assignees{/user}","branches_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/branches{/branch}","tags_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/tags","blobs_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/statuses/{sha}","languages_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/languages","stargazers_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/stargazers","contributors_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/contributors","subscribers_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/subscribers","subscription_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/subscription","commits_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/contents/{+path}","compare_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/merges","archive_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/downloads","issues_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/issues{/number}","pulls_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/pulls{/number}","milestones_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/milestones{/number}","notifications_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/labels{/name}","releases_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/releases{/id}","deployments_url":"https://api.github.com/repos/AndroidDeveloperLB/Android-Week-View/deployments","created_at":"2018-05-07T07:58:30Z","updated_at":"2018-05-08T14:35:05Z","pushed_at":"2018-05-08T14:35:01Z","git_url":"git://github.com/AndroidDeveloperLB/Android-Week-View.git","ssh_url":"git@github.com:AndroidDeveloperLB/Android-Week-View.git","clone_url":"https://github.com/AndroidDeveloperLB/Android-Week-View.git","svn_url":"https://github.com/AndroidDeveloperLB/Android-Week-View","homepage":"","size":1180,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Quivr:develop","ref":"develop","sha":"2a5f09a6c6ccad3158491acb8c3b05eaf8150b1b","user":{"login":"Quivr","id":10599268,"avatar_url":"https://avatars2.githubusercontent.com/u/10599268?v=4","gravatar_id":"","url":"https://api.github.com/users/Quivr","html_url":"https://github.com/Quivr","followers_url":"https://api.github.com/users/Quivr/followers","following_url":"https://api.github.com/users/Quivr/following{/other_user}","gists_url":"https://api.github.com/users/Quivr/gists{/gist_id}","starred_url":"https://api.github.com/users/Quivr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quivr/subscriptions","organizations_url":"https://api.github.com/users/Quivr/orgs","repos_url":"https://api.github.com/users/Quivr/repos","events_url":"https://api.github.com/users/Quivr/events{/privacy}","received_events_url":"https://api.github.com/users/Quivr/received_events","type":"Organization","site_admin":false},"repo":{"id":50945787,"name":"Android-Week-View","full_name":"Quivr/Android-Week-View","owner":{"login":"Quivr","id":10599268,"avatar_url":"https://avatars2.githubusercontent.com/u/10599268?v=4","gravatar_id":"","url":"https://api.github.com/users/Quivr","html_url":"https://github.com/Quivr","followers_url":"https://api.github.com/users/Quivr/followers","following_url":"https://api.github.com/users/Quivr/following{/other_user}","gists_url":"https://api.github.com/users/Quivr/gists{/gist_id}","starred_url":"https://api.github.com/users/Quivr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quivr/subscriptions","organizations_url":"https://api.github.com/users/Quivr/orgs","repos_url":"https://api.github.com/users/Quivr/repos","events_url":"https://api.github.com/users/Quivr/events{/privacy}","received_events_url":"https://api.github.com/users/Quivr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Quivr/Android-Week-View","description":"Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.","fork":true,"url":"https://api.github.com/repos/Quivr/Android-Week-View","forks_url":"https://api.github.com/repos/Quivr/Android-Week-View/forks","keys_url":"https://api.github.com/repos/Quivr/Android-Week-View/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quivr/Android-Week-View/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quivr/Android-Week-View/teams","hooks_url":"https://api.github.com/repos/Quivr/Android-Week-View/hooks","issue_events_url":"https://api.github.com/repos/Quivr/Android-Week-View/issues/events{/number}","events_url":"https://api.github.com/repos/Quivr/Android-Week-View/events","assignees_url":"https://api.github.com/repos/Quivr/Android-Week-View/assignees{/user}","branches_url":"https://api.github.com/repos/Quivr/Android-Week-View/branches{/branch}","tags_url":"https://api.github.com/repos/Quivr/Android-Week-View/tags","blobs_url":"https://api.github.com/repos/Quivr/Android-Week-View/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quivr/Android-Week-View/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quivr/Android-Week-View/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quivr/Android-Week-View/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quivr/Android-Week-View/statuses/{sha}","languages_url":"https://api.github.com/repos/Quivr/Android-Week-View/languages","stargazers_url":"https://api.github.com/repos/Quivr/Android-Week-View/stargazers","contributors_url":"https://api.github.com/repos/Quivr/Android-Week-View/contributors","subscribers_url":"https://api.github.com/repos/Quivr/Android-Week-View/subscribers","subscription_url":"https://api.github.com/repos/Quivr/Android-Week-View/subscription","commits_url":"https://api.github.com/repos/Quivr/Android-Week-View/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quivr/Android-Week-View/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quivr/Android-Week-View/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quivr/Android-Week-View/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quivr/Android-Week-View/contents/{+path}","compare_url":"https://api.github.com/repos/Quivr/Android-Week-View/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quivr/Android-Week-View/merges","archive_url":"https://api.github.com/repos/Quivr/Android-Week-View/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quivr/Android-Week-View/downloads","issues_url":"https://api.github.com/repos/Quivr/Android-Week-View/issues{/number}","pulls_url":"https://api.github.com/repos/Quivr/Android-Week-View/pulls{/number}","milestones_url":"https://api.github.com/repos/Quivr/Android-Week-View/milestones{/number}","notifications_url":"https://api.github.com/repos/Quivr/Android-Week-View/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quivr/Android-Week-View/labels{/name}","releases_url":"https://api.github.com/repos/Quivr/Android-Week-View/releases{/id}","deployments_url":"https://api.github.com/repos/Quivr/Android-Week-View/deployments","created_at":"2016-02-02T19:24:44Z","updated_at":"2018-05-08T00:49:32Z","pushed_at":"2018-05-08T14:35:05Z","git_url":"git://github.com/Quivr/Android-Week-View.git","ssh_url":"git@github.com:Quivr/Android-Week-View.git","clone_url":"https://github.com/Quivr/Android-Week-View.git","svn_url":"https://github.com/Quivr/Android-Week-View","homepage":"","size":1152,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":43,"open_issues":32,"watchers":232,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97"},"html":{"href":"https://github.com/Quivr/Android-Week-View/pull/97"},"issue":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/issues/97"},"comments":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/Quivr/Android-Week-View/statuses/1f9e199bc1c6716219fae4e17f1ca591ec6b6868"}},"author_association":"NONE"}}
{"actor":{"display_login":"SkyleKayma"}}