{"action":"closed","number":2142,"pull_request":{"url":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142","id":174815252,"html_url":"https://github.com/circleci/circleci-docs/pull/2142","diff_url":"https://github.com/circleci/circleci-docs/pull/2142.diff","patch_url":"https://github.com/circleci/circleci-docs/pull/2142.patch","issue_url":"https://api.github.com/repos/circleci/circleci-docs/issues/2142","number":2142,"state":"closed","locked":false,"title":"Google Container Engine clarifications","user":{"login":"smart-alek","id":5043885,"avatar_url":"https://avatars0.githubusercontent.com/u/5043885?v=4","gravatar_id":"","url":"https://api.github.com/users/smart-alek","html_url":"https://github.com/smart-alek","followers_url":"https://api.github.com/users/smart-alek/followers","following_url":"https://api.github.com/users/smart-alek/following{/other_user}","gists_url":"https://api.github.com/users/smart-alek/gists{/gist_id}","starred_url":"https://api.github.com/users/smart-alek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smart-alek/subscriptions","organizations_url":"https://api.github.com/users/smart-alek/orgs","repos_url":"https://api.github.com/users/smart-alek/repos","events_url":"https://api.github.com/users/smart-alek/events{/privacy}","received_events_url":"https://api.github.com/users/smart-alek/received_events","type":"User","site_admin":false},"body":"Fixes #2134 and fixes #1670.\r\n\r\nWhile working on this document, I realized a couple of things:\r\n\r\n1. There is a lot of overlapping information between [this document](https://circleci.com/docs/2.0/google-container-engine/) and the [Authenticating Google Cloud](https://circleci.com/docs/2.0/google-auth/) document.\r\n\r\n2. Both documents are mostly focused on steps preceding the *actual deploy* (authentication, environment variables, etc.).\r\n\r\n3. The actual deploy instructions seem to be on the [deploy landing page](https://circleci.com/docs/2.0/deployment-integrations/#google-cloud), but these seem to be a bit lean.\r\n\r\n---\r\n\r\nAt the very least, we should consolidate [Authenticating Google Cloud Platform](https://circleci.com/docs/2.0/google-auth/) and [Deploying to Google Container Engine](https://circleci.com/docs/2.0/google-container-engine/).\r\n\r\nIf we're feeling ambitious, I would pull all relevant Google Cloud setup documentation into a single document that is linked to from the Deploy landing page. The other deploy platforms could benefit from their own spaces as well.","created_at":"2018-03-13T23:13:47Z","updated_at":"2018-03-14T19:17:36Z","closed_at":"2018-03-14T19:17:36Z","merged_at":"2018-03-14T19:17:35Z","merge_commit_sha":"18e00829ef0f4fbc9ac2fc3e53fe19fd2c7b75ce","assignee":{"login":"smart-alek","id":5043885,"avatar_url":"https://avatars0.githubusercontent.com/u/5043885?v=4","gravatar_id":"","url":"https://api.github.com/users/smart-alek","html_url":"https://github.com/smart-alek","followers_url":"https://api.github.com/users/smart-alek/followers","following_url":"https://api.github.com/users/smart-alek/following{/other_user}","gists_url":"https://api.github.com/users/smart-alek/gists{/gist_id}","starred_url":"https://api.github.com/users/smart-alek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smart-alek/subscriptions","organizations_url":"https://api.github.com/users/smart-alek/orgs","repos_url":"https://api.github.com/users/smart-alek/repos","events_url":"https://api.github.com/users/smart-alek/events{/privacy}","received_events_url":"https://api.github.com/users/smart-alek/received_events","type":"User","site_admin":false},"assignees":[{"login":"smart-alek","id":5043885,"avatar_url":"https://avatars0.githubusercontent.com/u/5043885?v=4","gravatar_id":"","url":"https://api.github.com/users/smart-alek","html_url":"https://github.com/smart-alek","followers_url":"https://api.github.com/users/smart-alek/followers","following_url":"https://api.github.com/users/smart-alek/following{/other_user}","gists_url":"https://api.github.com/users/smart-alek/gists{/gist_id}","starred_url":"https://api.github.com/users/smart-alek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smart-alek/subscriptions","organizations_url":"https://api.github.com/users/smart-alek/orgs","repos_url":"https://api.github.com/users/smart-alek/repos","events_url":"https://api.github.com/users/smart-alek/events{/privacy}","received_events_url":"https://api.github.com/users/smart-alek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":802183850,"url":"https://api.github.com/repos/circleci/circleci-docs/labels/Clarification","name":"Clarification","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142/commits","review_comments_url":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142/comments","review_comment_url":"https://api.github.com/repos/circleci/circleci-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circleci/circleci-docs/issues/2142/comments","statuses_url":"https://api.github.com/repos/circleci/circleci-docs/statuses/1df2102600d21720bd6631ae061c4042230dda6e","head":{"label":"circleci:elucidate-google-container-engine","ref":"elucidate-google-container-engine","sha":"1df2102600d21720bd6631ae061c4042230dda6e","user":{"login":"circleci","id":1231870,"avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":48750547,"name":"circleci-docs","full_name":"circleci/circleci-docs","owner":{"login":"circleci","id":1231870,"avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circleci/circleci-docs","description":"Documentation for CircleCI.","fork":false,"url":"https://api.github.com/repos/circleci/circleci-docs","forks_url":"https://api.github.com/repos/circleci/circleci-docs/forks","keys_url":"https://api.github.com/repos/circleci/circleci-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/circleci-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/circleci-docs/teams","hooks_url":"https://api.github.com/repos/circleci/circleci-docs/hooks","issue_events_url":"https://api.github.com/repos/circleci/circleci-docs/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/circleci-docs/events","assignees_url":"https://api.github.com/repos/circleci/circleci-docs/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/circleci-docs/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/circleci-docs/tags","blobs_url":"https://api.github.com/repos/circleci/circleci-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/circleci-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/circleci-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/circleci-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/circleci-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/circleci-docs/languages","stargazers_url":"https://api.github.com/repos/circleci/circleci-docs/stargazers","contributors_url":"https://api.github.com/repos/circleci/circleci-docs/contributors","subscribers_url":"https://api.github.com/repos/circleci/circleci-docs/subscribers","subscription_url":"https://api.github.com/repos/circleci/circleci-docs/subscription","commits_url":"https://api.github.com/repos/circleci/circleci-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/circleci-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/circleci-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/circleci-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/circleci-docs/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/circleci-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/circleci-docs/merges","archive_url":"https://api.github.com/repos/circleci/circleci-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/circleci-docs/downloads","issues_url":"https://api.github.com/repos/circleci/circleci-docs/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/circleci-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/circleci-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/circleci-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/circleci-docs/labels{/name}","releases_url":"https://api.github.com/repos/circleci/circleci-docs/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/circleci-docs/deployments","created_at":"2015-12-29T14:14:27Z","updated_at":"2018-03-14T18:32:15Z","pushed_at":"2018-03-14T19:17:35Z","git_url":"git://github.com/circleci/circleci-docs.git","ssh_url":"git@github.com:circleci/circleci-docs.git","clone_url":"https://github.com/circleci/circleci-docs.git","svn_url":"https://github.com/circleci/circleci-docs","homepage":"https://circleci.com/docs/","size":17869,"stargazers_count":158,"watchers_count":158,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":364,"open_issues":24,"watchers":158,"default_branch":"master"}},"base":{"label":"circleci:master","ref":"master","sha":"1fd7ccfa39447c298403cdba7ae55f9decfaf6e6","user":{"login":"circleci","id":1231870,"avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":48750547,"name":"circleci-docs","full_name":"circleci/circleci-docs","owner":{"login":"circleci","id":1231870,"avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circleci/circleci-docs","description":"Documentation for CircleCI.","fork":false,"url":"https://api.github.com/repos/circleci/circleci-docs","forks_url":"https://api.github.com/repos/circleci/circleci-docs/forks","keys_url":"https://api.github.com/repos/circleci/circleci-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/circleci-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/circleci-docs/teams","hooks_url":"https://api.github.com/repos/circleci/circleci-docs/hooks","issue_events_url":"https://api.github.com/repos/circleci/circleci-docs/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/circleci-docs/events","assignees_url":"https://api.github.com/repos/circleci/circleci-docs/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/circleci-docs/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/circleci-docs/tags","blobs_url":"https://api.github.com/repos/circleci/circleci-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/circleci-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/circleci-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/circleci-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/circleci-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/circleci-docs/languages","stargazers_url":"https://api.github.com/repos/circleci/circleci-docs/stargazers","contributors_url":"https://api.github.com/repos/circleci/circleci-docs/contributors","subscribers_url":"https://api.github.com/repos/circleci/circleci-docs/subscribers","subscription_url":"https://api.github.com/repos/circleci/circleci-docs/subscription","commits_url":"https://api.github.com/repos/circleci/circleci-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/circleci-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/circleci-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/circleci-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/circleci-docs/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/circleci-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/circleci-docs/merges","archive_url":"https://api.github.com/repos/circleci/circleci-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/circleci-docs/downloads","issues_url":"https://api.github.com/repos/circleci/circleci-docs/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/circleci-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/circleci-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/circleci-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/circleci-docs/labels{/name}","releases_url":"https://api.github.com/repos/circleci/circleci-docs/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/circleci-docs/deployments","created_at":"2015-12-29T14:14:27Z","updated_at":"2018-03-14T18:32:15Z","pushed_at":"2018-03-14T19:17:35Z","git_url":"git://github.com/circleci/circleci-docs.git","ssh_url":"git@github.com:circleci/circleci-docs.git","clone_url":"https://github.com/circleci/circleci-docs.git","svn_url":"https://github.com/circleci/circleci-docs","homepage":"https://circleci.com/docs/","size":17869,"stargazers_count":158,"watchers_count":158,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":364,"open_issues":24,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142"},"html":{"href":"https://github.com/circleci/circleci-docs/pull/2142"},"issue":{"href":"https://api.github.com/repos/circleci/circleci-docs/issues/2142"},"comments":{"href":"https://api.github.com/repos/circleci/circleci-docs/issues/2142/comments"},"review_comments":{"href":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142/comments"},"review_comment":{"href":"https://api.github.com/repos/circleci/circleci-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circleci/circleci-docs/pulls/2142/commits"},"statuses":{"href":"https://api.github.com/repos/circleci/circleci-docs/statuses/1df2102600d21720bd6631ae061c4042230dda6e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"smart-alek","id":5043885,"avatar_url":"https://avatars0.githubusercontent.com/u/5043885?v=4","gravatar_id":"","url":"https://api.github.com/users/smart-alek","html_url":"https://github.com/smart-alek","followers_url":"https://api.github.com/users/smart-alek/followers","following_url":"https://api.github.com/users/smart-alek/following{/other_user}","gists_url":"https://api.github.com/users/smart-alek/gists{/gist_id}","starred_url":"https://api.github.com/users/smart-alek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smart-alek/subscriptions","organizations_url":"https://api.github.com/users/smart-alek/orgs","repos_url":"https://api.github.com/users/smart-alek/repos","events_url":"https://api.github.com/users/smart-alek/events{/privacy}","received_events_url":"https://api.github.com/users/smart-alek/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":20,"additions":82,"deletions":46,"changed_files":2}}
{"actor":{"display_login":"smart-alek"}}