{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/196256691","pull_request_review_id":129774977,"id":196256691,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI1NjY5MQ==","diff_hunk":"@@ -16,8 +16,37 @@ if(NOT CLR_CMAKE_USE_SYSTEM_LIBUNWIND)\n   include_directories(${CMAKE_CURRENT_BINARY_DIR}/libunwind/include/tdep)\n \n   add_subdirectory(libunwind)\n-endif(NOT CLR_CMAKE_USE_SYSTEM_LIBUNWIND)\n+else()\n+    if(PAL_CMAKE_PLATFORM_ARCH_ARM)","path":"src/pal/src/CMakeLists.txt","position":6,"original_position":6,"commit_id":"2effde4a752cc64f0401dc7286b1ad01020ca036","original_commit_id":"2effde4a752cc64f0401dc7286b1ad01020ca036","user":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"This should not be enabled for OSX. I think it might be cause for the OSX test failure.","created_at":"2018-06-18T23:33:50Z","updated_at":"2018-06-18T23:33:50Z","html_url":"https://github.com/dotnet/coreclr/pull/18479#discussion_r196256691","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/18479","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/196256691"},"html":{"href":"https://github.com/dotnet/coreclr/pull/18479#discussion_r196256691"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/18479"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/18479","id":195083553,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDgzNTUz","html_url":"https://github.com/dotnet/coreclr/pull/18479","diff_url":"https://github.com/dotnet/coreclr/pull/18479.diff","patch_url":"https://github.com/dotnet/coreclr/pull/18479.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/18479","number":18479,"state":"open","locked":false,"title":"fixes for  sos on FreeBSD","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"add missing arch specific of libunwind so sos plugin can load.\r\nFix code for OS thread id so it does match with what lldb see. \r\n\r\nWith this clrstack works on FreeBSD\r\n\r\n```\r\n(lldb) clrstack\r\nGetTaskByOSThreadID:3452: 101422 th=000000080788E8C0\r\nPrintThread:12070: hr=0 osID=101422  pStackWalk=0x83c27a000\r\nOS Thread Id: 0x18c2e (16)\r\n        Child SP               IP Call Site\r\n00007FFFDF1AF8A8 00000008012a098a [Frame: 00007fffdf1af8a8] Interop+Sys.WaitForSocketEvents(IntPtr, SocketEvent*, Int32*)\r\n00007FFFDF1AF8A8 0000000804d2ecc8 [InlinedCallFrame: 00007fffdf1af8a8] Interop+Sys.WaitForSocketEvents(IntPtr, SocketEvent*, Int32*)\r\n00007FFFDF1AF8A0 0000000804D2ECC8 DomainBoundILStubClass.IL_STUB_PInvoke(IntPtr, SocketEvent*, Int32*)\r\n00007FFFDF1AF920 0000000804D2EAE1 System.Net.Sockets.SocketAsyncEngine.EventLoop()\r\n00007FFFDF1AF960 0000000804D2E469 System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef)\r\n00007FFFDF1AFCE0 000000080248897f [GCFrame: 00007fffdf1afce0]\r\n00007FFFDF1AFDB0 000000080248897f [DebuggerU2MCatchHandlerFrame: 00007fffdf1afdb0]\r\n```\r\n","created_at":"2018-06-15T05:55:54Z","updated_at":"2018-06-18T23:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a756f7f0410385a0cfdd383022cc6bb1d485d84b","assignee":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"assignees":[{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":193594626,"node_id":"MDU6TGFiZWwxOTM1OTQ2MjY=","url":"https://api.github.com/repos/dotnet/coreclr/labels/os-freebsd","name":"os-freebsd","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/18479/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/18479/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/18479/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/2effde4a752cc64f0401dc7286b1ad01020ca036","head":{"label":"wfurt:freebsd_sos","ref":"freebsd_sos","sha":"2effde4a752cc64f0401dc7286b1ad01020ca036","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"repo":{"id":91738882,"node_id":"MDEwOlJlcG9zaXRvcnk5MTczODg4Mg==","name":"coreclr","full_name":"wfurt/coreclr","owner":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wfurt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/wfurt/coreclr","forks_url":"https://api.github.com/repos/wfurt/coreclr/forks","keys_url":"https://api.github.com/repos/wfurt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wfurt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wfurt/coreclr/teams","hooks_url":"https://api.github.com/repos/wfurt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/wfurt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/wfurt/coreclr/events","assignees_url":"https://api.github.com/repos/wfurt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/wfurt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/wfurt/coreclr/tags","blobs_url":"https://api.github.com/repos/wfurt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wfurt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wfurt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/wfurt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wfurt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/wfurt/coreclr/languages","stargazers_url":"https://api.github.com/repos/wfurt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/wfurt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/wfurt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/wfurt/coreclr/subscription","commits_url":"https://api.github.com/repos/wfurt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/wfurt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/wfurt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/wfurt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/wfurt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/wfurt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wfurt/coreclr/merges","archive_url":"https://api.github.com/repos/wfurt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wfurt/coreclr/downloads","issues_url":"https://api.github.com/repos/wfurt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/wfurt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/wfurt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/wfurt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wfurt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/wfurt/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/wfurt/coreclr/deployments","created_at":"2017-05-18T21:24:37Z","updated_at":"2018-06-12T07:15:51Z","pushed_at":"2018-06-15T20:22:17Z","git_url":"git://github.com/wfurt/coreclr.git","ssh_url":"git@github.com:wfurt/coreclr.git","clone_url":"https://github.com/wfurt/coreclr.git","svn_url":"https://github.com/wfurt/coreclr","homepage":"https://github.com/dotnet/core","size":222792,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5bb221911996edeef0373ecf5c5fbfc235533ac8","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-06-18T21:52:20Z","pushed_at":"2018-06-18T21:50:13Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":225473,"stargazers_count":9423,"watchers_count":9423,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2361,"mirror_url":null,"archived":false,"open_issues_count":1662,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2361,"open_issues":1662,"watchers":9423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/18479"},"html":{"href":"https://github.com/dotnet/coreclr/pull/18479"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/18479"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/18479/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/18479/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/18479/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/2effde4a752cc64f0401dc7286b1ad01020ca036"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"janvorli"}}