{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/171466659","pull_request_review_id":100321015,"id":171466659,"diff_hunk":"@@ -14,15 +14,148 @@\n //\n //===----------------------------------------------------------------------===//\n \n-#define DEBUG_TYPE \"swift-basic\"\n+#define DEBUG_TYPE \"swift-ast\"\n #include \"swift/AST/DiagnosticConsumer.h\"\n #include \"swift/AST/DiagnosticEngine.h\"\n+#include \"swift/Basic/Defer.h\"\n+#include \"swift/Basic/SourceManager.h\"\n #include \"llvm/ADT/StringRef.h\"\n+#include \"llvm/ADT/StringSet.h\"\n #include \"llvm/Support/Debug.h\"\n #include \"llvm/Support/raw_ostream.h\"\n using namespace swift;\n \n-DiagnosticConsumer::~DiagnosticConsumer() { }\n+DiagnosticConsumer::~DiagnosticConsumer() = default;\n+\n+llvm::SMLoc DiagnosticConsumer::getRawLoc(SourceLoc loc) {\n+  return loc.Value;\n+}\n+\n+FileSpecificDiagnosticConsumer::FileSpecificDiagnosticConsumer(\n+    SmallVectorImpl<ConsumerPair> &consumers)\n+  : SubConsumers(std::move(consumers)) {\n+#ifndef NDEBUG\n+  llvm::StringSet<> seenFiles;\n+  for (const ConsumerPair &consumerPair : SubConsumers) {\n+    if (consumerPair.first.empty())\n+      continue;\n+    bool isUnique = seenFiles.insert(consumerPair.first).second;\n+    assert(isUnique &&","path":"lib/AST/DiagnosticConsumer.cpp","position":32,"original_position":32,"commit_id":"3d345a8260cee4834abef9c88020a7e7e47ebc33","original_commit_id":"3d345a8260cee4834abef9c88020a7e7e47ebc33","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"Why would duplicates be an error instead of just something to ignore?","created_at":"2018-03-01T05:33:06Z","updated_at":"2018-03-01T05:33:06Z","html_url":"https://github.com/apple/swift/pull/14900#discussion_r171466659","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/14900","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/171466659"},"html":{"href":"https://github.com/apple/swift/pull/14900#discussion_r171466659"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/14900"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/14900","id":172128345,"html_url":"https://github.com/apple/swift/pull/14900","diff_url":"https://github.com/apple/swift/pull/14900.diff","patch_url":"https://github.com/apple/swift/pull/14900.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/14900","number":14900,"state":"open","locked":false,"title":"Wire up FileSpecificDiagnosticConsumer for serialized diagnostics","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Now that most of @davidungar's batch mode work has landed in the frontend, I can actually use the RangeSpecificDiagnosticConsumer from #14844 to get us outputting multiple .dia files in batch mode. We want diagnostics that are definitely associated with a particular file to be emitted in that file's .dia output, while diagnostics that may be associated with other files (such as those that come from Clang) get emitted in all .dia outputs to make sure they show up everywhere they're needed.\r\n\r\nThis deserves some extra documentation somewhere about *why* this is safe and correct, but hey, it appears to work!","created_at":"2018-03-01T02:31:44Z","updated_at":"2018-03-01T05:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"269907f438e481cb2508fcb88ce531fee7ec2ed7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/14900/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/14900/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/14900/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/3d345a8260cee4834abef9c88020a7e7e47ebc33","head":{"label":"jrose-apple:mux","ref":"mux","sha":"3d345a8260cee4834abef9c88020a7e7e47ebc33","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"repo":{"id":47434397,"name":"swift","full_name":"jrose-apple/swift","owner":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrose-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jrose-apple/swift","forks_url":"https://api.github.com/repos/jrose-apple/swift/forks","keys_url":"https://api.github.com/repos/jrose-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrose-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrose-apple/swift/teams","hooks_url":"https://api.github.com/repos/jrose-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/jrose-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jrose-apple/swift/events","assignees_url":"https://api.github.com/repos/jrose-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jrose-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jrose-apple/swift/tags","blobs_url":"https://api.github.com/repos/jrose-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrose-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrose-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrose-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrose-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jrose-apple/swift/languages","stargazers_url":"https://api.github.com/repos/jrose-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/jrose-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/jrose-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/jrose-apple/swift/subscription","commits_url":"https://api.github.com/repos/jrose-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrose-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrose-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrose-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrose-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jrose-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrose-apple/swift/merges","archive_url":"https://api.github.com/repos/jrose-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrose-apple/swift/downloads","issues_url":"https://api.github.com/repos/jrose-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jrose-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jrose-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jrose-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrose-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/jrose-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jrose-apple/swift/deployments","created_at":"2015-12-04T23:42:49Z","updated_at":"2017-08-31T16:24:50Z","pushed_at":"2018-03-01T03:56:23Z","git_url":"git://github.com/jrose-apple/swift.git","ssh_url":"git@github.com:jrose-apple/swift.git","clone_url":"https://github.com/jrose-apple/swift.git","svn_url":"https://github.com/jrose-apple/swift","homepage":"","size":252143,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"f6f391b8873639d342b3d3c5bfde7f9798a34d02","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-03-01T05:10:29Z","pushed_at":"2018-03-01T05:30:50Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":267381,"stargazers_count":42778,"watchers_count":42778,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6721,"mirror_url":null,"archived":false,"open_issues_count":276,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6721,"open_issues":276,"watchers":42778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/14900"},"html":{"href":"https://github.com/apple/swift/pull/14900"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/14900"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/14900/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/14900/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/14900/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/3d345a8260cee4834abef9c88020a7e7e47ebc33"}},"author_association":"OWNER"}}
{"actor":{"display_login":"davidungar"}}