{"action":"closed","issue":{"url":"https://api.github.com/repos/EasyEngine/easyengine/issues/1210","repository_url":"https://api.github.com/repos/EasyEngine/easyengine","labels_url":"https://api.github.com/repos/EasyEngine/easyengine/issues/1210/labels{/name}","comments_url":"https://api.github.com/repos/EasyEngine/easyengine/issues/1210/comments","events_url":"https://api.github.com/repos/EasyEngine/easyengine/issues/1210/events","html_url":"https://github.com/EasyEngine/easyengine/issues/1210","id":357998070,"node_id":"MDU6SXNzdWUzNTc5OTgwNzA=","number":1210,"title":"Update container migration","user":{"login":"mrrobot47","id":25586785,"node_id":"MDQ6VXNlcjI1NTg2Nzg1","avatar_url":"https://avatars1.githubusercontent.com/u/25586785?v=4","gravatar_id":"","url":"https://api.github.com/users/mrrobot47","html_url":"https://github.com/mrrobot47","followers_url":"https://api.github.com/users/mrrobot47/followers","following_url":"https://api.github.com/users/mrrobot47/following{/other_user}","gists_url":"https://api.github.com/users/mrrobot47/gists{/gist_id}","starred_url":"https://api.github.com/users/mrrobot47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrrobot47/subscriptions","organizations_url":"https://api.github.com/users/mrrobot47/orgs","repos_url":"https://api.github.com/users/mrrobot47/repos","events_url":"https://api.github.com/users/mrrobot47/events{/privacy}","received_events_url":"https://api.github.com/users/mrrobot47/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"sagarnasit","id":25276905,"node_id":"MDQ6VXNlcjI1Mjc2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/25276905?v=4","gravatar_id":"","url":"https://api.github.com/users/sagarnasit","html_url":"https://github.com/sagarnasit","followers_url":"https://api.github.com/users/sagarnasit/followers","following_url":"https://api.github.com/users/sagarnasit/following{/other_user}","gists_url":"https://api.github.com/users/sagarnasit/gists{/gist_id}","starred_url":"https://api.github.com/users/sagarnasit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagarnasit/subscriptions","organizations_url":"https://api.github.com/users/sagarnasit/orgs","repos_url":"https://api.github.com/users/sagarnasit/repos","events_url":"https://api.github.com/users/sagarnasit/events{/privacy}","received_events_url":"https://api.github.com/users/sagarnasit/received_events","type":"User","site_admin":false},"assignees":[{"login":"sagarnasit","id":25276905,"node_id":"MDQ6VXNlcjI1Mjc2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/25276905?v=4","gravatar_id":"","url":"https://api.github.com/users/sagarnasit","html_url":"https://github.com/sagarnasit","followers_url":"https://api.github.com/users/sagarnasit/followers","following_url":"https://api.github.com/users/sagarnasit/following{/other_user}","gists_url":"https://api.github.com/users/sagarnasit/gists{/gist_id}","starred_url":"https://api.github.com/users/sagarnasit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagarnasit/subscriptions","organizations_url":"https://api.github.com/users/sagarnasit/orgs","repos_url":"https://api.github.com/users/sagarnasit/repos","events_url":"https://api.github.com/users/sagarnasit/events{/privacy}","received_events_url":"https://api.github.com/users/sagarnasit/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-07T09:49:52Z","updated_at":"2018-11-12T19:14:14Z","closed_at":"2018-11-12T19:14:14Z","author_association":"CONTRIBUTOR","body":"The container migration that has already been implemented contains the logic to simply run `docker-composer up -d` for all the sites. This won't work anymore as the site's `docker-composer.yml` is different now with new packages in place. Only, specific containers need to be brought up depending on the state of commands fired for that site stored in the `db`.\r\n\r\nPseudo code for implementation (One of the possible ways, discussion is welcome) :\r\n```bash\r\n\r\n# 1. Find which container (service name) is main for core site functionality for that site-type and bring it up.\r\n\r\ncd $site_fs_path\r\ndocker-composer up $main_container -d\r\n\r\n# 2. Check in db for admin-tools, mailhog etc.\r\n\r\nif (admin-tools ||/&& mailhog) { \r\n    Bring up admin-tools/mailhog using functional call to `ee admin-tools up` ||/&& `ee mailhog up` etc.\r\n}\r\n```\r\n\r\nTODOs for step this method to work properly:\r\n\r\n- [ ] Add postfix as a dependency for nginx/php container for `php` and `wp` site type which is missing.\r\n- [ ] Register the main container, e.g., `nginx` for site-type html/wp, in site-meta table.\r\n- [ ] Register mailhog status in site-meta table."}}
{"actor":{"display_login":"mbtamuli"}}