{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/comments/210748947","pull_request_review_id":147032652,"id":210748947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDc0ODk0Nw==","diff_hunk":"@@ -54,6 +54,18 @@\n         }\n     }\n \n+    /**\n+     * @author lcram\n+     */\n+    private class AlwaysTrueAtlasFilter implements Predicate<Resource>","path":"src/main/java/org/openstreetmap/atlas/geography/atlas/AtlasResourceLoader.java","position":7,"original_position":7,"commit_id":"a4926055b9a8c4f6ceea925c5db1013adf99f060","original_commit_id":"a4926055b9a8c4f6ceea925c5db1013adf99f060","user":{"login":"MikeGost","id":18317260,"node_id":"MDQ6VXNlcjE4MzE3MjYw","avatar_url":"https://avatars3.githubusercontent.com/u/18317260?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeGost","html_url":"https://github.com/MikeGost","followers_url":"https://api.github.com/users/MikeGost/followers","following_url":"https://api.github.com/users/MikeGost/following{/other_user}","gists_url":"https://api.github.com/users/MikeGost/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGost/subscriptions","organizations_url":"https://api.github.com/users/MikeGost/orgs","repos_url":"https://api.github.com/users/MikeGost/repos","events_url":"https://api.github.com/users/MikeGost/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGost/received_events","type":"User","site_admin":false},"body":"Nit: Instead of a class, why not just a `private final Predicate<Resource> alwaysTrueAtlasFilter = resource -> return true;`","created_at":"2018-08-16T21:34:08Z","updated_at":"2018-08-16T21:38:50Z","html_url":"https://github.com/osmlab/atlas/pull/198#discussion_r210748947","pull_request_url":"https://api.github.com/repos/osmlab/atlas/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments/210748947"},"html":{"href":"https://github.com/osmlab/atlas/pull/198#discussion_r210748947"},"pull_request":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/198","id":208925875,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTI1ODc1","html_url":"https://github.com/osmlab/atlas/pull/198","diff_url":"https://github.com/osmlab/atlas/pull/198.diff","patch_url":"https://github.com/osmlab/atlas/pull/198.patch","issue_url":"https://api.github.com/repos/osmlab/atlas/issues/198","number":198,"state":"open","locked":false,"title":"Added an always true filter for atlas loading","user":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"body":"### Description:\r\n\r\nCurrently, the `AtlasResourceLoader` automatically and silently skips loading an atlas resource if it does not have a `.atlas` extension. This PR provides a simple way to disable this behavior if required.\r\n\r\n```java\r\nnew AtlasResourceLoader().withAtlasFileExtensionFilterSetTo(false).load(myAtlasResource);\r\n```\r\n\r\nI have some upcoming changes to `atlas-generator` that add a `HadoopAtlasFileCache`, but these are blocked until the changes in this PR are integrated and I can update `atlas-generator` to depend on them.\r\n\r\n### Potential Impact:\r\n\r\nThis will have no downstream impact, as it is completely opt-in. All existing code will continue to function identically.\r\n\r\n### Unit Test Approach:\r\n\r\nI have added a unit test to `AtlasResourceLoaderTest` called `testAtlasFileExtensionFilter` that demonstrates proper functionality.\r\n\r\n### Test Results:\r\n\r\nAll tests in `AtlasResourceLoaderTest` pass.\r\n\r\n------\r\n\r\nIn doubt: [Contributing Guidelines](CONTRIBUTING.md)","created_at":"2018-08-16T17:09:32Z","updated_at":"2018-08-16T21:38:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a00313a91c6507c5fda82a087d8b94d666511287","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664543819,"node_id":"MDU6TGFiZWw2NjQ1NDM4MTk=","url":"https://api.github.com/repos/osmlab/atlas/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/atlas/pulls/198/commits","review_comments_url":"https://api.github.com/repos/osmlab/atlas/pulls/198/comments","review_comment_url":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/atlas/issues/198/comments","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/a4926055b9a8c4f6ceea925c5db1013adf99f060","head":{"label":"lucaspcram:resload","ref":"resload","sha":"a4926055b9a8c4f6ceea925c5db1013adf99f060","user":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"repo":{"id":127447366,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0NDczNjY=","name":"atlas","full_name":"lucaspcram/atlas","owner":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucaspcram/atlas","description":"OSM in memory","fork":true,"url":"https://api.github.com/repos/lucaspcram/atlas","forks_url":"https://api.github.com/repos/lucaspcram/atlas/forks","keys_url":"https://api.github.com/repos/lucaspcram/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucaspcram/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucaspcram/atlas/teams","hooks_url":"https://api.github.com/repos/lucaspcram/atlas/hooks","issue_events_url":"https://api.github.com/repos/lucaspcram/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/lucaspcram/atlas/events","assignees_url":"https://api.github.com/repos/lucaspcram/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/lucaspcram/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/lucaspcram/atlas/tags","blobs_url":"https://api.github.com/repos/lucaspcram/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucaspcram/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucaspcram/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucaspcram/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucaspcram/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/lucaspcram/atlas/languages","stargazers_url":"https://api.github.com/repos/lucaspcram/atlas/stargazers","contributors_url":"https://api.github.com/repos/lucaspcram/atlas/contributors","subscribers_url":"https://api.github.com/repos/lucaspcram/atlas/subscribers","subscription_url":"https://api.github.com/repos/lucaspcram/atlas/subscription","commits_url":"https://api.github.com/repos/lucaspcram/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucaspcram/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucaspcram/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucaspcram/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucaspcram/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/lucaspcram/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucaspcram/atlas/merges","archive_url":"https://api.github.com/repos/lucaspcram/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucaspcram/atlas/downloads","issues_url":"https://api.github.com/repos/lucaspcram/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/lucaspcram/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/lucaspcram/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/lucaspcram/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucaspcram/atlas/labels{/name}","releases_url":"https://api.github.com/repos/lucaspcram/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/lucaspcram/atlas/deployments","created_at":"2018-03-30T16:07:04Z","updated_at":"2018-08-16T18:20:59Z","pushed_at":"2018-08-16T20:58:43Z","git_url":"git://github.com/lucaspcram/atlas.git","ssh_url":"git@github.com:lucaspcram/atlas.git","clone_url":"https://github.com/lucaspcram/atlas.git","svn_url":"https://github.com/lucaspcram/atlas","homepage":null,"size":53358,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"osmlab:dev","ref":"dev","sha":"1686af6cda15bea36b525a1c6373453029c5dd73","user":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":99717758,"node_id":"MDEwOlJlcG9zaXRvcnk5OTcxNzc1OA==","name":"atlas","full_name":"osmlab/atlas","owner":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmlab/atlas","description":"OSM in memory","fork":false,"url":"https://api.github.com/repos/osmlab/atlas","forks_url":"https://api.github.com/repos/osmlab/atlas/forks","keys_url":"https://api.github.com/repos/osmlab/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/atlas/teams","hooks_url":"https://api.github.com/repos/osmlab/atlas/hooks","issue_events_url":"https://api.github.com/repos/osmlab/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/atlas/events","assignees_url":"https://api.github.com/repos/osmlab/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/atlas/tags","blobs_url":"https://api.github.com/repos/osmlab/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/atlas/languages","stargazers_url":"https://api.github.com/repos/osmlab/atlas/stargazers","contributors_url":"https://api.github.com/repos/osmlab/atlas/contributors","subscribers_url":"https://api.github.com/repos/osmlab/atlas/subscribers","subscription_url":"https://api.github.com/repos/osmlab/atlas/subscription","commits_url":"https://api.github.com/repos/osmlab/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/atlas/merges","archive_url":"https://api.github.com/repos/osmlab/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/atlas/downloads","issues_url":"https://api.github.com/repos/osmlab/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/atlas/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/atlas/deployments","created_at":"2017-08-08T17:14:27Z","updated_at":"2018-08-16T16:44:18Z","pushed_at":"2018-08-16T17:47:40Z","git_url":"git://github.com/osmlab/atlas.git","ssh_url":"git@github.com:osmlab/atlas.git","clone_url":"https://github.com/osmlab/atlas.git","svn_url":"https://github.com/osmlab/atlas","homepage":null,"size":53349,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":12,"watchers":81,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/198"},"html":{"href":"https://github.com/osmlab/atlas/pull/198"},"issue":{"href":"https://api.github.com/repos/osmlab/atlas/issues/198"},"comments":{"href":"https://api.github.com/repos/osmlab/atlas/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/atlas/statuses/a4926055b9a8c4f6ceea925c5db1013adf99f060"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MikeGost"}}