{"action":"created","issue":{"url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/15","repository_url":"https://api.github.com/repos/Psychopoulet/split-frames","labels_url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/15/comments","events_url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/15/events","html_url":"https://github.com/Psychopoulet/split-frames/issues/15","id":353978435,"node_id":"MDU6SXNzdWUzNTM5Nzg0MzU=","number":15,"title":"LRC","user":{"login":"juancarloslin","id":33756058,"node_id":"MDQ6VXNlcjMzNzU2MDU4","avatar_url":"https://avatars2.githubusercontent.com/u/33756058?v=4","gravatar_id":"","url":"https://api.github.com/users/juancarloslin","html_url":"https://github.com/juancarloslin","followers_url":"https://api.github.com/users/juancarloslin/followers","following_url":"https://api.github.com/users/juancarloslin/following{/other_user}","gists_url":"https://api.github.com/users/juancarloslin/gists{/gist_id}","starred_url":"https://api.github.com/users/juancarloslin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juancarloslin/subscriptions","organizations_url":"https://api.github.com/users/juancarloslin/orgs","repos_url":"https://api.github.com/users/juancarloslin/repos","events_url":"https://api.github.com/users/juancarloslin/events{/privacy}","received_events_url":"https://api.github.com/users/juancarloslin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-25T03:20:20Z","updated_at":"2018-08-27T02:02:59Z","closed_at":null,"author_association":"NONE","body":"We have a need to split-frames but also check LRC\r\nSo STX........ETX LRC \r\nLRC calculated without STX.\r\nWill be nice to allow checkLRC option in the start with / end with so take the ETX followed  byte to validate LRC, then emmit data."},"comment":{"url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/comments/416093817","html_url":"https://github.com/Psychopoulet/split-frames/issues/15#issuecomment-416093817","issue_url":"https://api.github.com/repos/Psychopoulet/split-frames/issues/15","id":416093817,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjA5MzgxNw==","user":{"login":"juancarloslin","id":33756058,"node_id":"MDQ6VXNlcjMzNzU2MDU4","avatar_url":"https://avatars2.githubusercontent.com/u/33756058?v=4","gravatar_id":"","url":"https://api.github.com/users/juancarloslin","html_url":"https://github.com/juancarloslin","followers_url":"https://api.github.com/users/juancarloslin/followers","following_url":"https://api.github.com/users/juancarloslin/following{/other_user}","gists_url":"https://api.github.com/users/juancarloslin/gists{/gist_id}","starred_url":"https://api.github.com/users/juancarloslin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juancarloslin/subscriptions","organizations_url":"https://api.github.com/users/juancarloslin/orgs","repos_url":"https://api.github.com/users/juancarloslin/repos","events_url":"https://api.github.com/users/juancarloslin/events{/privacy}","received_events_url":"https://api.github.com/users/juancarloslin/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T02:02:59Z","updated_at":"2018-08-27T02:02:59Z","author_association":"NONE","body":"Hi, \n\nThanks for your replay, \nI was thinking about a Generic LRC, as ANY, so then user can check on his own code. \nANY means any value, but, a byte., can be represented as 0x00 \n\n\nIf LRC is calculated at the end of ETX as our case should be \n\nStart with STX \nEnd with ETX, ANY \n\nso return STX,.......,ETX,LRC \n\nif LRC calculated at the start of STX and include ETX then \n\nStart with ANY, STX \nEnd with ETX \n\nso return LRC,STX,.......,ETX \n\nif LRC is 2 bytes, calculated at the start of STX and include ETX then \n\nStart with ANY, ANY, STX \nEnd with ETX \n\nso return LRC1, LRC2,STX,.......,ETX \n\nthis may works. \n\n\nThe ANY switch will be very powerfull for procesing frames. \n\n\nJuan Carlos Lin \nUnisoft SA \n+595-993-288330 \n\n\nDe: \"Sébastien Vidal\" <notifications@github.com> \nPara: \"Psychopoulet/split-frames\" <split-frames@noreply.github.com> \nCC: \"Juan Carlos Lin\" <lin@unisoft.com.py>, \"Author\" <author@noreply.github.com> \nEnviados: Domingo, 26 de Agosto 2018 16:44:20 \nAsunto: Re: [Psychopoulet/split-frames] LRC (#15) \n\n\n\nthe point is, I cannot add a specific comportment on it because it will no longer be generic. I work personaly with a lot of protocols, and each one works with its own way... \nfor your purpose, you need to check LRC, with ETX and without STX (Concert protocol, or something like this ?), but what about protocols with STX, or without ETX, or LRC before ETX (or after STX) ? \nand what about protocols which use MSB for double checking ? I think it may be more valuable to inherit this package to create a specific parser for a specific comportment... \n\nI was thinking about that (to add one or more bit after the and, for example, which can be parsed by inheritence), but I don't have enougth time at this moment for that... there is so much protocols ! so packages to create ! ^^ \n\n— \nYou are receiving this because you authored the thread. \nReply to this email directly, [ https://github.com/Psychopoulet/split-frames/issues/15#issuecomment-416070758 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AgMTmkDOuWkHR6z9RUm0x-svIUAHEBiFks5uUwikgaJpZM4WMOHT | mute the thread ] . \n\n"}}
{"actor":{"display_login":"juancarloslin"}}