{"action":"created","comment":{"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments/215994309","pull_request_review_id":153387314,"id":215994309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk5NDMwOQ==","diff_hunk":"@@ -11,23 +11,24 @@\n \n #include \"mo01_nmx_generated.h\"\n \n-#include <common/Producer.h>\n #include <common/Hists.h>\n-#include <libs/include/gccintel.h>\n+#include <common/Producer.h>\n \n class HistSerializer {\n public:\n-  /// \\todo document\n-  HistSerializer();\n+  /** \\todo document */","path":"prototype2/common/HistSerializer.h","position":13,"original_position":13,"commit_id":"8dba25df723811de47bab02e9ad5c0864f733aa9","original_commit_id":"8dba25df723811de47bab02e9ad5c0864f733aa9","user":{"login":"SkyToGround","id":58835,"node_id":"MDQ6VXNlcjU4ODM1","avatar_url":"https://avatars1.githubusercontent.com/u/58835?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyToGround","html_url":"https://github.com/SkyToGround","followers_url":"https://api.github.com/users/SkyToGround/followers","following_url":"https://api.github.com/users/SkyToGround/following{/other_user}","gists_url":"https://api.github.com/users/SkyToGround/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyToGround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyToGround/subscriptions","organizations_url":"https://api.github.com/users/SkyToGround/orgs","repos_url":"https://api.github.com/users/SkyToGround/repos","events_url":"https://api.github.com/users/SkyToGround/events{/privacy}","received_events_url":"https://api.github.com/users/SkyToGround/received_events","type":"User","site_admin":false},"body":"Naming the class \"HistogramSerializer\" makes it slightly more clear what it does.","created_at":"2018-09-07T15:17:39Z","updated_at":"2018-09-07T15:17:39Z","html_url":"https://github.com/ess-dmsc/event-formation-unit/pull/108#discussion_r215994309","pull_request_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments/215994309"},"html":{"href":"https://github.com/ess-dmsc/event-formation-unit/pull/108#discussion_r215994309"},"pull_request":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108","id":212225568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjI1NTY4","html_url":"https://github.com/ess-dmsc/event-formation-unit/pull/108","diff_url":"https://github.com/ess-dmsc/event-formation-unit/pull/108.diff","patch_url":"https://github.com/ess-dmsc/event-formation-unit/pull/108.patch","issue_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/108","number":108,"state":"open","locked":false,"title":"Multigrid improvements and other pleasures: DO NOT MERGE","user":{"login":"martukas","id":1972005,"node_id":"MDQ6VXNlcjE5NzIwMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1972005?v=4","gravatar_id":"","url":"https://api.github.com/users/martukas","html_url":"https://github.com/martukas","followers_url":"https://api.github.com/users/martukas/followers","following_url":"https://api.github.com/users/martukas/following{/other_user}","gists_url":"https://api.github.com/users/martukas/gists{/gist_id}","starred_url":"https://api.github.com/users/martukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martukas/subscriptions","organizations_url":"https://api.github.com/users/martukas/orgs","repos_url":"https://api.github.com/users/martukas/repos","events_url":"https://api.github.com/users/martukas/events{/privacy}","received_events_url":"https://api.github.com/users/martukas/received_events","type":"User","site_admin":false},"body":"### Issue reference / description\r\n\r\nThe branch you merge from should already reference an event-formation-unit github ticket number. You can add a descriptive title, but if an issue is referenced, you don't have to.\r\n\r\n## Checklist for submitter\r\n\r\n- [ ] Check for conflict with integration test\r\n- [x] Unit tests pass\r\n\r\n---\r\n\r\n## Nominate for Group Code Review (Anyone can nominate it)\r\nIndicate if you think the code should be reviewed in a Thursday code review session.\r\n\r\n- [ ] Recommend for group code review\r\n\r\nAlso, nominate it on the code_review Slack channel.\r\n","created_at":"2018-08-30T22:12:21Z","updated_at":"2018-09-07T15:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00230e7618eb74c5d3cdf07d81d75e35aa33a346","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108/commits","review_comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108/comments","review_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/108/comments","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/8dba25df723811de47bab02e9ad5c0864f733aa9","head":{"label":"ess-dmsc:issue_54","ref":"issue_54","sha":"8dba25df723811de47bab02e9ad5c0864f733aa9","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":80731668,"node_id":"MDEwOlJlcG9zaXRvcnk4MDczMTY2OA==","name":"event-formation-unit","full_name":"ess-dmsc/event-formation-unit","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/event-formation-unit","description":"Implementation of neutron event formation pipeline for ESS","fork":false,"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit","forks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/forks","keys_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/events","assignees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/merges","archive_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/deployments","created_at":"2017-02-02T14:17:01Z","updated_at":"2018-09-04T13:13:58Z","pushed_at":"2018-09-06T05:15:02Z","git_url":"git://github.com/ess-dmsc/event-formation-unit.git","ssh_url":"git@github.com:ess-dmsc/event-formation-unit.git","clone_url":"https://github.com/ess-dmsc/event-formation-unit.git","svn_url":"https://github.com/ess-dmsc/event-formation-unit","homepage":null,"size":13392,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"ess-dmsc:master","ref":"master","sha":"3e786475e17f94b3f15cd272afa9c5c3295a3180","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":80731668,"node_id":"MDEwOlJlcG9zaXRvcnk4MDczMTY2OA==","name":"event-formation-unit","full_name":"ess-dmsc/event-formation-unit","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/event-formation-unit","description":"Implementation of neutron event formation pipeline for ESS","fork":false,"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit","forks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/forks","keys_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/events","assignees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/merges","archive_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/deployments","created_at":"2017-02-02T14:17:01Z","updated_at":"2018-09-04T13:13:58Z","pushed_at":"2018-09-06T05:15:02Z","git_url":"git://github.com/ess-dmsc/event-formation-unit.git","ssh_url":"git@github.com:ess-dmsc/event-formation-unit.git","clone_url":"https://github.com/ess-dmsc/event-formation-unit.git","svn_url":"https://github.com/ess-dmsc/event-formation-unit","homepage":null,"size":13392,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108"},"html":{"href":"https://github.com/ess-dmsc/event-formation-unit/pull/108"},"issue":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/108"},"comments":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/8dba25df723811de47bab02e9ad5c0864f733aa9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SkyToGround"}}