{"action":"opened","number":10755,"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755","id":224084035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDg0MDM1","html_url":"https://github.com/WordPress/gutenberg/pull/10755","diff_url":"https://github.com/WordPress/gutenberg/pull/10755.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/10755.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10755","number":10755,"state":"open","locked":false,"title":"Fix: Inserter Search Results Not Announcing ","user":{"login":"LukePettway","id":3654512,"node_id":"MDQ6VXNlcjM2NTQ1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3654512?v=4","gravatar_id":"","url":"https://api.github.com/users/LukePettway","html_url":"https://github.com/LukePettway","followers_url":"https://api.github.com/users/LukePettway/followers","following_url":"https://api.github.com/users/LukePettway/following{/other_user}","gists_url":"https://api.github.com/users/LukePettway/gists{/gist_id}","starred_url":"https://api.github.com/users/LukePettway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukePettway/subscriptions","organizations_url":"https://api.github.com/users/LukePettway/orgs","repos_url":"https://api.github.com/users/LukePettway/repos","events_url":"https://api.github.com/users/LukePettway/events{/privacy}","received_events_url":"https://api.github.com/users/LukePettway/received_events","type":"User","site_admin":false},"body":"\r\n## Description\r\nThe inserter search results do not announce to screen readers the current number of filtered results. This implements some logic to calculate that number and announce to the user how many results have been found. \r\n\r\n## How has this been tested?\r\nFirst and foremost, I typed in various strings of text to change the number of results. Then I made sure the text in the live region calculated the correct number and matched up with the actual count. \r\n\r\nThen I used VoiceOver and Safari (there is a bug in other browsers where aria-live doesn't work) to test that the value of the aria-live region is read to a screen reader. At least from my initial testing everything seemed to work correctly. \r\n\r\n## Screenshots\r\n\r\n<img width=\"687\" alt=\"screen shot 2018-10-18 at 3 58 31 pm\" src=\"https://user-images.githubusercontent.com/3654512/47180780-5e8b3c00-d2ef-11e8-8f36-8b0df84b0a7e.png\">\r\n\r\n![screen shot 2018-10-18 at 3 59 26 pm](https://user-images.githubusercontent.com/3654512/47180856-7e226480-d2ef-11e8-9ea4-7a0d57208dbf.png)\r\n\r\n\r\n<img width=\"608\" alt=\"screen shot 2018-10-18 at 3 59 16 pm\" src=\"https://user-images.githubusercontent.com/3654512/47180846-78c51a00-d2ef-11e8-8194-2d672577f7d4.png\">\r\n\r\n![screen shot 2018-10-18 at 3 59 22 pm](https://user-images.githubusercontent.com/3654512/47180872-8aa6bd00-d2ef-11e8-8922-a8fc7044cf7d.png)\r\n\r\n\r\n<img width=\"197\" alt=\"screen shot 2018-10-18 at 3 58 04 pm\" src=\"https://user-images.githubusercontent.com/3654512/47180895-985c4280-d2ef-11e8-9453-2ffa398da81e.png\">\r\n\r\n\r\n## Types of changes\r\n\r\nMakes the inserter more accessible by fixing this issue: https://github.com/WordPress/gutenberg/issues/10583\r\n\r\n## Checklist:\r\n- [X] My code is tested.\r\n- [X] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [X] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [X] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->\r\n","created_at":"2018-10-18T20:12:21Z","updated_at":"2018-10-18T20:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10755/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/c57c27ac255c626e24fb2940000074cbd726c68c","head":{"label":"LukePettway:update/block-type-insterter-search-speak","ref":"update/block-type-insterter-search-speak","sha":"c57c27ac255c626e24fb2940000074cbd726c68c","user":{"login":"LukePettway","id":3654512,"node_id":"MDQ6VXNlcjM2NTQ1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3654512?v=4","gravatar_id":"","url":"https://api.github.com/users/LukePettway","html_url":"https://github.com/LukePettway","followers_url":"https://api.github.com/users/LukePettway/followers","following_url":"https://api.github.com/users/LukePettway/following{/other_user}","gists_url":"https://api.github.com/users/LukePettway/gists{/gist_id}","starred_url":"https://api.github.com/users/LukePettway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukePettway/subscriptions","organizations_url":"https://api.github.com/users/LukePettway/orgs","repos_url":"https://api.github.com/users/LukePettway/repos","events_url":"https://api.github.com/users/LukePettway/events{/privacy}","received_events_url":"https://api.github.com/users/LukePettway/received_events","type":"User","site_admin":false},"repo":{"id":153638280,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MzgyODA=","name":"gutenberg","full_name":"LukePettway/gutenberg","private":false,"owner":{"login":"LukePettway","id":3654512,"node_id":"MDQ6VXNlcjM2NTQ1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3654512?v=4","gravatar_id":"","url":"https://api.github.com/users/LukePettway","html_url":"https://github.com/LukePettway","followers_url":"https://api.github.com/users/LukePettway/followers","following_url":"https://api.github.com/users/LukePettway/following{/other_user}","gists_url":"https://api.github.com/users/LukePettway/gists{/gist_id}","starred_url":"https://api.github.com/users/LukePettway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukePettway/subscriptions","organizations_url":"https://api.github.com/users/LukePettway/orgs","repos_url":"https://api.github.com/users/LukePettway/repos","events_url":"https://api.github.com/users/LukePettway/events{/privacy}","received_events_url":"https://api.github.com/users/LukePettway/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LukePettway/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Plugin is available from the official WordPress repository.","fork":true,"url":"https://api.github.com/repos/LukePettway/gutenberg","forks_url":"https://api.github.com/repos/LukePettway/gutenberg/forks","keys_url":"https://api.github.com/repos/LukePettway/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukePettway/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukePettway/gutenberg/teams","hooks_url":"https://api.github.com/repos/LukePettway/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/LukePettway/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/LukePettway/gutenberg/events","assignees_url":"https://api.github.com/repos/LukePettway/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/LukePettway/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/LukePettway/gutenberg/tags","blobs_url":"https://api.github.com/repos/LukePettway/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukePettway/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukePettway/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukePettway/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukePettway/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/LukePettway/gutenberg/languages","stargazers_url":"https://api.github.com/repos/LukePettway/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/LukePettway/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/LukePettway/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/LukePettway/gutenberg/subscription","commits_url":"https://api.github.com/repos/LukePettway/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukePettway/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukePettway/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukePettway/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukePettway/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/LukePettway/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukePettway/gutenberg/merges","archive_url":"https://api.github.com/repos/LukePettway/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukePettway/gutenberg/downloads","issues_url":"https://api.github.com/repos/LukePettway/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/LukePettway/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/LukePettway/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/LukePettway/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukePettway/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/LukePettway/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/LukePettway/gutenberg/deployments","created_at":"2018-10-18T14:32:17Z","updated_at":"2018-10-18T14:32:23Z","pushed_at":"2018-10-18T19:55:31Z","git_url":"git://github.com/LukePettway/gutenberg.git","ssh_url":"git@github.com:LukePettway/gutenberg.git","clone_url":"https://github.com/LukePettway/gutenberg.git","svn_url":"https://github.com/LukePettway/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/","size":27953,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"c05ede75a490b5c8b911ad43c6d882a5e61f0a22","user":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg2MjU4NA==","name":"gutenberg","full_name":"WordPress/gutenberg","private":false,"owner":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-10-18T20:11:21Z","pushed_at":"2018-10-18T20:10:49Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/","size":28157,"stargazers_count":3567,"watchers_count":3567,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":967,"mirror_url":null,"archived":false,"open_issues_count":1432,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":967,"open_issues":1432,"watchers":3567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/10755"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/10755"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/10755/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/10755/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/c57c27ac255c626e24fb2940000074cbd726c68c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"LukePettway"}}