{"action":"created","comment":{"url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments/214890984","pull_request_review_id":152037075,"id":214890984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDg5MDk4NA==","diff_hunk":"@@ -358,11 +359,13 @@ SceUID load_self(Ptr<const void> &entry_point, KernelState &kernel, MemState &me\n     sceKernelModuleInfo->size = sizeof(*sceKernelModuleInfo);\n     strncpy(sceKernelModuleInfo->module_name, module_info->name, 28);\n     //unk28\n-    entry_point = module_info_segment_address + module_info->module_start;\n-    sceKernelModuleInfo->module_start = module_info->module_start ? entry_point : Ptr<const void>(0);\n+    if (module_info->module_start != 0xffffffff && module_info->module_start != 0)\n+        entry_point = module_info_segment_address + module_info->module_start;\n+    else\n+        entry_point = Ptr<const void>(0);\n     //unk30\n-    const Ptr<const void> module_stop = module_info_segment_address + module_info->module_stop;\n-    sceKernelModuleInfo->module_stop = module_info->module_stop ? module_stop : Ptr<const void>(0);\n+    if (module_info->module_stop != 0xffffffff && module_info->module_stop != 0)\n+        sceKernelModuleInfo->module_stop = module_info_segment_address + module_info->module_start;","path":"src/emulator/kernel/src/load_self.cpp","position":67,"original_position":67,"commit_id":"8eeae53e4a000230ac527d9b9a5d89a8cd278768","original_commit_id":"da7644fa8716fbdc381d538a60b9492cd0c39dc1","user":{"login":"VelocityRa","id":6632271,"node_id":"MDQ6VXNlcjY2MzIyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6632271?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityRa","html_url":"https://github.com/VelocityRa","followers_url":"https://api.github.com/users/VelocityRa/followers","following_url":"https://api.github.com/users/VelocityRa/following{/other_user}","gists_url":"https://api.github.com/users/VelocityRa/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityRa/subscriptions","organizations_url":"https://api.github.com/users/VelocityRa/orgs","repos_url":"https://api.github.com/users/VelocityRa/repos","events_url":"https://api.github.com/users/VelocityRa/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityRa/received_events","type":"User","site_admin":false},"body":"typo, thanks","created_at":"2018-09-04T12:17:26Z","updated_at":"2018-09-04T12:17:26Z","html_url":"https://github.com/Vita3K/Vita3K/pull/316#discussion_r214890984","pull_request_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments/214890984"},"html":{"href":"https://github.com/Vita3K/Vita3K/pull/316#discussion_r214890984"},"pull_request":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316"}},"in_reply_to_id":214806892},"pull_request":{"url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316","id":212594395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTk0Mzk1","html_url":"https://github.com/Vita3K/Vita3K/pull/316","diff_url":"https://github.com/Vita3K/Vita3K/pull/316.diff","patch_url":"https://github.com/Vita3K/Vita3K/pull/316.patch","issue_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/316","number":316,"state":"open","locked":false,"title":"[WIP] LLE support for decrypted modules & other fixes","user":{"login":"VelocityRa","id":6632271,"node_id":"MDQ6VXNlcjY2MzIyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6632271?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityRa","html_url":"https://github.com/VelocityRa","followers_url":"https://api.github.com/users/VelocityRa/followers","following_url":"https://api.github.com/users/VelocityRa/following{/other_user}","gists_url":"https://api.github.com/users/VelocityRa/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityRa/subscriptions","organizations_url":"https://api.github.com/users/VelocityRa/orgs","repos_url":"https://api.github.com/users/VelocityRa/repos","events_url":"https://api.github.com/users/VelocityRa/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityRa/received_events","type":"User","site_admin":false},"body":"Help message shows the following for the option:\r\n\r\n```\r\n  -m [ --lle-modules ] arg         Load given (decrypted) OS modules from disk.\r\n                                   Separate by commas to specify multiple\r\n                                   modules (no spaces). Full path and extension\r\n                                   should not be included, the following are\r\n                                   assumed: vs0:sys/external/<name>.suprx\r\n                                   Example: --lle-modules libscemp4,libngs\r\n```\r\n\r\nSee commits for the rest of the fixes.","created_at":"2018-09-02T14:03:50Z","updated_at":"2018-09-04T12:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eceb9da8ea4af2355a6669464e4f71d78a5cffa1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":895597373,"node_id":"MDU6TGFiZWw4OTU1OTczNzM=","url":"https://api.github.com/repos/Vita3K/Vita3K/labels/io","name":"io","color":"9ee874","default":false},{"id":908419155,"node_id":"MDU6TGFiZWw5MDg0MTkxNTU=","url":"https://api.github.com/repos/Vita3K/Vita3K/labels/kernel","name":"kernel","color":"fa1344","default":false},{"id":891045944,"node_id":"MDU6TGFiZWw4OTEwNDU5NDQ=","url":"https://api.github.com/repos/Vita3K/Vita3K/labels/modules","name":"modules","color":"c9f47a","default":false},{"id":1031200665,"node_id":"MDU6TGFiZWwxMDMxMjAwNjY1","url":"https://api.github.com/repos/Vita3K/Vita3K/labels/refactoring","name":"refactoring","color":"777777","default":false},{"id":895896730,"node_id":"MDU6TGFiZWw4OTU4OTY3MzA=","url":"https://api.github.com/repos/Vita3K/Vita3K/labels/threads","name":"threads","color":"a5af0c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316/commits","review_comments_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316/comments","review_comment_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/316/comments","statuses_url":"https://api.github.com/repos/Vita3K/Vita3K/statuses/8eeae53e4a000230ac527d9b9a5d89a8cd278768","head":{"label":"VelocityRa:lle-modules","ref":"lle-modules","sha":"8eeae53e4a000230ac527d9b9a5d89a8cd278768","user":{"login":"VelocityRa","id":6632271,"node_id":"MDQ6VXNlcjY2MzIyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6632271?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityRa","html_url":"https://github.com/VelocityRa","followers_url":"https://api.github.com/users/VelocityRa/followers","following_url":"https://api.github.com/users/VelocityRa/following{/other_user}","gists_url":"https://api.github.com/users/VelocityRa/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityRa/subscriptions","organizations_url":"https://api.github.com/users/VelocityRa/orgs","repos_url":"https://api.github.com/users/VelocityRa/repos","events_url":"https://api.github.com/users/VelocityRa/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityRa/received_events","type":"User","site_admin":false},"repo":{"id":120024298,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwMjQyOTg=","name":"Vita3K","full_name":"VelocityRa/Vita3K","owner":{"login":"VelocityRa","id":6632271,"node_id":"MDQ6VXNlcjY2MzIyNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6632271?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityRa","html_url":"https://github.com/VelocityRa","followers_url":"https://api.github.com/users/VelocityRa/followers","following_url":"https://api.github.com/users/VelocityRa/following{/other_user}","gists_url":"https://api.github.com/users/VelocityRa/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityRa/subscriptions","organizations_url":"https://api.github.com/users/VelocityRa/orgs","repos_url":"https://api.github.com/users/VelocityRa/repos","events_url":"https://api.github.com/users/VelocityRa/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityRa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VelocityRa/Vita3K","description":"Experimental PlayStation Vita emulator","fork":true,"url":"https://api.github.com/repos/VelocityRa/Vita3K","forks_url":"https://api.github.com/repos/VelocityRa/Vita3K/forks","keys_url":"https://api.github.com/repos/VelocityRa/Vita3K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VelocityRa/Vita3K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VelocityRa/Vita3K/teams","hooks_url":"https://api.github.com/repos/VelocityRa/Vita3K/hooks","issue_events_url":"https://api.github.com/repos/VelocityRa/Vita3K/issues/events{/number}","events_url":"https://api.github.com/repos/VelocityRa/Vita3K/events","assignees_url":"https://api.github.com/repos/VelocityRa/Vita3K/assignees{/user}","branches_url":"https://api.github.com/repos/VelocityRa/Vita3K/branches{/branch}","tags_url":"https://api.github.com/repos/VelocityRa/Vita3K/tags","blobs_url":"https://api.github.com/repos/VelocityRa/Vita3K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VelocityRa/Vita3K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VelocityRa/Vita3K/git/refs{/sha}","trees_url":"https://api.github.com/repos/VelocityRa/Vita3K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VelocityRa/Vita3K/statuses/{sha}","languages_url":"https://api.github.com/repos/VelocityRa/Vita3K/languages","stargazers_url":"https://api.github.com/repos/VelocityRa/Vita3K/stargazers","contributors_url":"https://api.github.com/repos/VelocityRa/Vita3K/contributors","subscribers_url":"https://api.github.com/repos/VelocityRa/Vita3K/subscribers","subscription_url":"https://api.github.com/repos/VelocityRa/Vita3K/subscription","commits_url":"https://api.github.com/repos/VelocityRa/Vita3K/commits{/sha}","git_commits_url":"https://api.github.com/repos/VelocityRa/Vita3K/git/commits{/sha}","comments_url":"https://api.github.com/repos/VelocityRa/Vita3K/comments{/number}","issue_comment_url":"https://api.github.com/repos/VelocityRa/Vita3K/issues/comments{/number}","contents_url":"https://api.github.com/repos/VelocityRa/Vita3K/contents/{+path}","compare_url":"https://api.github.com/repos/VelocityRa/Vita3K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VelocityRa/Vita3K/merges","archive_url":"https://api.github.com/repos/VelocityRa/Vita3K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VelocityRa/Vita3K/downloads","issues_url":"https://api.github.com/repos/VelocityRa/Vita3K/issues{/number}","pulls_url":"https://api.github.com/repos/VelocityRa/Vita3K/pulls{/number}","milestones_url":"https://api.github.com/repos/VelocityRa/Vita3K/milestones{/number}","notifications_url":"https://api.github.com/repos/VelocityRa/Vita3K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VelocityRa/Vita3K/labels{/name}","releases_url":"https://api.github.com/repos/VelocityRa/Vita3K/releases{/id}","deployments_url":"https://api.github.com/repos/VelocityRa/Vita3K/deployments","created_at":"2018-02-02T19:48:59Z","updated_at":"2018-08-31T13:39:40Z","pushed_at":"2018-09-03T12:55:26Z","git_url":"git://github.com/VelocityRa/Vita3K.git","ssh_url":"git@github.com:VelocityRa/Vita3K.git","clone_url":"https://github.com/VelocityRa/Vita3K.git","svn_url":"https://github.com/VelocityRa/Vita3K","homepage":"https://Vita3K.github.io/","size":58314,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Vita3K:master","ref":"master","sha":"a741c3af9d331031477a996753b3f9b3adc47acc","user":{"login":"Vita3K","id":34121543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTIxNTQz","avatar_url":"https://avatars1.githubusercontent.com/u/34121543?v=4","gravatar_id":"","url":"https://api.github.com/users/Vita3K","html_url":"https://github.com/Vita3K","followers_url":"https://api.github.com/users/Vita3K/followers","following_url":"https://api.github.com/users/Vita3K/following{/other_user}","gists_url":"https://api.github.com/users/Vita3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Vita3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vita3K/subscriptions","organizations_url":"https://api.github.com/users/Vita3K/orgs","repos_url":"https://api.github.com/users/Vita3K/repos","events_url":"https://api.github.com/users/Vita3K/events{/privacy}","received_events_url":"https://api.github.com/users/Vita3K/received_events","type":"Organization","site_admin":false},"repo":{"id":119111364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMTEzNjQ=","name":"Vita3K","full_name":"Vita3K/Vita3K","owner":{"login":"Vita3K","id":34121543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTIxNTQz","avatar_url":"https://avatars1.githubusercontent.com/u/34121543?v=4","gravatar_id":"","url":"https://api.github.com/users/Vita3K","html_url":"https://github.com/Vita3K","followers_url":"https://api.github.com/users/Vita3K/followers","following_url":"https://api.github.com/users/Vita3K/following{/other_user}","gists_url":"https://api.github.com/users/Vita3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Vita3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vita3K/subscriptions","organizations_url":"https://api.github.com/users/Vita3K/orgs","repos_url":"https://api.github.com/users/Vita3K/repos","events_url":"https://api.github.com/users/Vita3K/events{/privacy}","received_events_url":"https://api.github.com/users/Vita3K/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vita3K/Vita3K","description":"Experimental PlayStation Vita emulator","fork":false,"url":"https://api.github.com/repos/Vita3K/Vita3K","forks_url":"https://api.github.com/repos/Vita3K/Vita3K/forks","keys_url":"https://api.github.com/repos/Vita3K/Vita3K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vita3K/Vita3K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vita3K/Vita3K/teams","hooks_url":"https://api.github.com/repos/Vita3K/Vita3K/hooks","issue_events_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/events{/number}","events_url":"https://api.github.com/repos/Vita3K/Vita3K/events","assignees_url":"https://api.github.com/repos/Vita3K/Vita3K/assignees{/user}","branches_url":"https://api.github.com/repos/Vita3K/Vita3K/branches{/branch}","tags_url":"https://api.github.com/repos/Vita3K/Vita3K/tags","blobs_url":"https://api.github.com/repos/Vita3K/Vita3K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vita3K/Vita3K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vita3K/Vita3K/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vita3K/Vita3K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vita3K/Vita3K/statuses/{sha}","languages_url":"https://api.github.com/repos/Vita3K/Vita3K/languages","stargazers_url":"https://api.github.com/repos/Vita3K/Vita3K/stargazers","contributors_url":"https://api.github.com/repos/Vita3K/Vita3K/contributors","subscribers_url":"https://api.github.com/repos/Vita3K/Vita3K/subscribers","subscription_url":"https://api.github.com/repos/Vita3K/Vita3K/subscription","commits_url":"https://api.github.com/repos/Vita3K/Vita3K/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vita3K/Vita3K/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vita3K/Vita3K/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vita3K/Vita3K/contents/{+path}","compare_url":"https://api.github.com/repos/Vita3K/Vita3K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vita3K/Vita3K/merges","archive_url":"https://api.github.com/repos/Vita3K/Vita3K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vita3K/Vita3K/downloads","issues_url":"https://api.github.com/repos/Vita3K/Vita3K/issues{/number}","pulls_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls{/number}","milestones_url":"https://api.github.com/repos/Vita3K/Vita3K/milestones{/number}","notifications_url":"https://api.github.com/repos/Vita3K/Vita3K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vita3K/Vita3K/labels{/name}","releases_url":"https://api.github.com/repos/Vita3K/Vita3K/releases{/id}","deployments_url":"https://api.github.com/repos/Vita3K/Vita3K/deployments","created_at":"2018-01-26T22:45:05Z","updated_at":"2018-09-04T07:11:46Z","pushed_at":"2018-09-03T12:55:27Z","git_url":"git://github.com/Vita3K/Vita3K.git","ssh_url":"git@github.com:Vita3K/Vita3K.git","clone_url":"https://github.com/Vita3K/Vita3K.git","svn_url":"https://github.com/Vita3K/Vita3K","homepage":"https://vita3k.org/","size":58077,"stargazers_count":597,"watchers_count":597,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":68,"open_issues":44,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316"},"html":{"href":"https://github.com/Vita3K/Vita3K/pull/316"},"issue":{"href":"https://api.github.com/repos/Vita3K/Vita3K/issues/316"},"comments":{"href":"https://api.github.com/repos/Vita3K/Vita3K/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/Vita3K/Vita3K/statuses/8eeae53e4a000230ac527d9b9a5d89a8cd278768"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"VelocityRa"}}