{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/213146222","pull_request_review_id":149920740,"id":213146222,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzE0NjIyMg==","diff_hunk":"@@ -112,6 +112,19 @@ R_API void *r_vector_reserve(RVector *vec, size_t capacity);\n // shrink capacity to len.\n R_API void *r_vector_shrink(RVector *vec);\n \n+/*\n+ * example:\n+ *\n+ * RVector *v = ...; // <contains MyStruct>\n+ * MyStruct *it;\n+ * r_vector_foreach (v, it) {\n+ *     // Do something with it\n+ * }\n+ */\n+#define r_vector_foreach(vec, it) \\\n+\tif ((vec) && (vec)->a) \\","path":"libr/include/r_vector.h","position":14,"original_position":14,"commit_id":"7892e97b7271ba92849642484eccb1530a819348","original_commit_id":"7892e97b7271ba92849642484eccb1530a819348","user":{"login":"MaskRay","id":416322,"node_id":"MDQ6VXNlcjQxNjMyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/416322?v=4","gravatar_id":"","url":"https://api.github.com/users/MaskRay","html_url":"https://github.com/MaskRay","followers_url":"https://api.github.com/users/MaskRay/followers","following_url":"https://api.github.com/users/MaskRay/following{/other_user}","gists_url":"https://api.github.com/users/MaskRay/gists{/gist_id}","starred_url":"https://api.github.com/users/MaskRay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaskRay/subscriptions","organizations_url":"https://api.github.com/users/MaskRay/orgs","repos_url":"https://api.github.com/users/MaskRay/repos","events_url":"https://api.github.com/users/MaskRay/events{/privacy}","received_events_url":"https://api.github.com/users/MaskRay/received_events","type":"User","site_admin":false},"body":"the `(vec)` check seems redundant.","created_at":"2018-08-27T23:29:33Z","updated_at":"2018-08-27T23:29:33Z","html_url":"https://github.com/radare/radare2/pull/11273#discussion_r213146222","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/11273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/213146222"},"html":{"href":"https://github.com/radare/radare2/pull/11273#discussion_r213146222"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/11273"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/11273","id":211065051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDY1MDUx","html_url":"https://github.com/radare/radare2/pull/11273","diff_url":"https://github.com/radare/radare2/pull/11273.diff","patch_url":"https://github.com/radare/radare2/pull/11273.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/11273","number":11273,"state":"open","locked":false,"title":"RVector Update","user":{"login":"thestr4ng3r","id":1460997,"node_id":"MDQ6VXNlcjE0NjA5OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1460997?v=4","gravatar_id":"","url":"https://api.github.com/users/thestr4ng3r","html_url":"https://github.com/thestr4ng3r","followers_url":"https://api.github.com/users/thestr4ng3r/followers","following_url":"https://api.github.com/users/thestr4ng3r/following{/other_user}","gists_url":"https://api.github.com/users/thestr4ng3r/gists{/gist_id}","starred_url":"https://api.github.com/users/thestr4ng3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thestr4ng3r/subscriptions","organizations_url":"https://api.github.com/users/thestr4ng3r/orgs","repos_url":"https://api.github.com/users/thestr4ng3r/repos","events_url":"https://api.github.com/users/thestr4ng3r/events{/privacy}","received_events_url":"https://api.github.com/users/thestr4ng3r/received_events","type":"User","site_admin":false},"body":"Tests: https://github.com/radare/radare2-regressions/pull/1461","created_at":"2018-08-27T10:12:51Z","updated_at":"2018-08-27T23:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80676b7fd2b86c349a0761ca62d5b3ce8cd6046a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/11273/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/11273/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/11273/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/7892e97b7271ba92849642484eccb1530a819348","head":{"label":"radare:vector","ref":"vector","sha":"7892e97b7271ba92849642484eccb1530a819348","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-08-27T19:41:19Z","pushed_at":"2018-08-27T23:16:30Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":88878,"stargazers_count":8059,"watchers_count":8059,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1581,"mirror_url":null,"archived":false,"open_issues_count":990,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1581,"open_issues":990,"watchers":8059,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"634f7e54d0b4981f65d883e08ee8a646be05c065","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-08-27T19:41:19Z","pushed_at":"2018-08-27T23:16:30Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":88878,"stargazers_count":8059,"watchers_count":8059,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1581,"mirror_url":null,"archived":false,"open_issues_count":990,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1581,"open_issues":990,"watchers":8059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/11273"},"html":{"href":"https://github.com/radare/radare2/pull/11273"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/11273"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/11273/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/11273/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/11273/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/7892e97b7271ba92849642484eccb1530a819348"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MaskRay"}}