{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3889","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3889/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3889/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3889/events","html_url":"https://github.com/codice/ddf/pull/3889","id":370697794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzE3NTc4","number":3889,"title":"DDF-4228 List Items query local first","user":{"login":"Bdthomson","id":7236299,"node_id":"MDQ6VXNlcjcyMzYyOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7236299?v=4","gravatar_id":"","url":"https://api.github.com/users/Bdthomson","html_url":"https://github.com/Bdthomson","followers_url":"https://api.github.com/users/Bdthomson/followers","following_url":"https://api.github.com/users/Bdthomson/following{/other_user}","gists_url":"https://api.github.com/users/Bdthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/Bdthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bdthomson/subscriptions","organizations_url":"https://api.github.com/users/Bdthomson/orgs","repos_url":"https://api.github.com/users/Bdthomson/repos","events_url":"https://api.github.com/users/Bdthomson/events{/privacy}","received_events_url":"https://api.github.com/users/Bdthomson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-16T16:33:49Z","updated_at":"2018-10-18T20:00:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3889","html_url":"https://github.com/codice/ddf/pull/3889","diff_url":"https://github.com/codice/ddf/pull/3889.diff","patch_url":"https://github.com/codice/ddf/pull/3889.patch"},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### Notes\r\nhttps://github.com/codice/ddf/commit/eac285bcfb5b27cc6680985b28a2241caaa86ddb - Changing `Query.js` from define to using require statements. This also reduces all indentations, meaning the file looks like it has completely changed. To make it easy to review, all logic prevalent to this ticket is in 445e8e7a3d3e0c0344dbc85cb52306998d1fd62c.\r\n\r\nPlease only review 445e8e7a3d3e0c0344dbc85cb52306998d1fd62c.\r\n\r\n#### What does this PR do?\r\n\r\nWhen list queries are made, only local federation is used. If all items are not found, make a new request with enterprise federation.\r\n\r\nLists should query local before attempting to make a federated query because the majority of list items are stored locally.\r\n\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@millerw8 \r\n@bdeining \r\n@troymohl \r\n\r\n#### Select relevant component teams: \r\n@codice/ui \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@andrewkfiedler\r\n@djblue\r\n\r\n#### How should this be tested?\r\n\r\n1. Upload to a list by manually creating a metacard using the builder.\r\n2. Setup a remote source, search, and then add one of the items to the list.\r\n3. Verify that there are 2 sets of network requests, one for local and one for remote sources.\r\n\r\n<!--(List steps with links to updated documentation)-->\r\n#### Any background context you want to provide?\r\n\r\n\r\n#### What are the relevant tickets?\r\n[DDF-4228](https://codice.atlassian.net/browse/DDF-4228)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/431142493","html_url":"https://github.com/codice/ddf/pull/3889#issuecomment-431142493","issue_url":"https://api.github.com/repos/codice/ddf/issues/3889","id":431142493,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTE0MjQ5Mw==","user":{"login":"Bdthomson","id":7236299,"node_id":"MDQ6VXNlcjcyMzYyOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7236299?v=4","gravatar_id":"","url":"https://api.github.com/users/Bdthomson","html_url":"https://github.com/Bdthomson","followers_url":"https://api.github.com/users/Bdthomson/followers","following_url":"https://api.github.com/users/Bdthomson/following{/other_user}","gists_url":"https://api.github.com/users/Bdthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/Bdthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bdthomson/subscriptions","organizations_url":"https://api.github.com/users/Bdthomson/orgs","repos_url":"https://api.github.com/users/Bdthomson/repos","events_url":"https://api.github.com/users/Bdthomson/events{/privacy}","received_events_url":"https://api.github.com/users/Bdthomson/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T20:00:37Z","updated_at":"2018-10-18T20:00:37Z","author_association":"CONTRIBUTOR","body":"build now"}}
{"actor":{"display_login":"Bdthomson"}}