{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11","id":230787383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzg3Mzgz","html_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao/pull/11","diff_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao/pull/11.diff","patch_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao/pull/11.patch","issue_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/11","number":11,"state":"closed","locked":false,"title":"Week7 hw","user":{"login":"tingkao","id":37369103,"node_id":"MDQ6VXNlcjM3MzY5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/37369103?v=4","gravatar_id":"","url":"https://api.github.com/users/tingkao","html_url":"https://github.com/tingkao","followers_url":"https://api.github.com/users/tingkao/followers","following_url":"https://api.github.com/users/tingkao/following{/other_user}","gists_url":"https://api.github.com/users/tingkao/gists{/gist_id}","starred_url":"https://api.github.com/users/tingkao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tingkao/subscriptions","organizations_url":"https://api.github.com/users/tingkao/orgs","repos_url":"https://api.github.com/users/tingkao/repos","events_url":"https://api.github.com/users/tingkao/events{/privacy}","received_events_url":"https://api.github.com/users/tingkao/received_events","type":"User","site_admin":false},"body":"week6 的 PR 上老師提醒的一些問題，在 week7 有做修改與更正～\r\n之前為了趕上進度在 w5 和 w6 覺得有點囫圇吞棗，所以在 w7 整個再調整腳步跟把之前的課程再 review 了一次，加上上週的一對一檢討觀摩，陸續做了許多的修改，所以拖到現在才 PR 上來ＸＤ\r\n但是仍有一些需要再改進的地方，因為覺得一次一次改也不錯，可以看到修改的過程，所以還是先交一次作業。\r\n目前還可以改進的地方：\r\n1. 註冊後即登入\r\n2. 編輯留言的部分也改成 ajax (這部分還在研究ＱＱ)\r\n3. 編輯用 JS 的彈出視窗(跟 2 一起改進)\r\n4. delete 可改為有確認、取消的視窗\r\n5. 用 bootstrap 做好 RWD\r\n6. 提供可更改暱稱、密碼(寄信到信箱)、頭像之功能\r\n7. 其他優化(減少 SQL 指令，例如：父子留言一起撈; 單撈 nickname 的可省去，改存在 session 或 cookie)\r\n8. 參考同學的作業 ui，外觀美化","created_at":"2018-11-14T10:42:00Z","updated_at":"2018-11-14T11:37:14Z","closed_at":"2018-11-14T11:37:13Z","merged_at":"2018-11-14T11:37:13Z","merge_commit_sha":"6280d35c1b13d7af22e2472a57489cb4c08a4d78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/11/comments","statuses_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/statuses/146ecd1b7d0d686c7bc4c64edb988449bad3c7b1","head":{"label":"Lidemy:week7-hw","ref":"week7-hw","sha":"146ecd1b7d0d686c7bc4c64edb988449bad3c7b1","user":{"login":"Lidemy","id":29705873,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA1ODcz","avatar_url":"https://avatars0.githubusercontent.com/u/29705873?v=4","gravatar_id":"","url":"https://api.github.com/users/Lidemy","html_url":"https://github.com/Lidemy","followers_url":"https://api.github.com/users/Lidemy/followers","following_url":"https://api.github.com/users/Lidemy/following{/other_user}","gists_url":"https://api.github.com/users/Lidemy/gists{/gist_id}","starred_url":"https://api.github.com/users/Lidemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lidemy/subscriptions","organizations_url":"https://api.github.com/users/Lidemy/orgs","repos_url":"https://api.github.com/users/Lidemy/repos","events_url":"https://api.github.com/users/Lidemy/events{/privacy}","received_events_url":"https://api.github.com/users/Lidemy/received_events","type":"Organization","site_admin":false},"repo":{"id":147221162,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMjExNjI=","name":"mentor-program-2nd-tingkao","full_name":"Lidemy/mentor-program-2nd-tingkao","private":false,"owner":{"login":"Lidemy","id":29705873,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA1ODcz","avatar_url":"https://avatars0.githubusercontent.com/u/29705873?v=4","gravatar_id":"","url":"https://api.github.com/users/Lidemy","html_url":"https://github.com/Lidemy","followers_url":"https://api.github.com/users/Lidemy/followers","following_url":"https://api.github.com/users/Lidemy/following{/other_user}","gists_url":"https://api.github.com/users/Lidemy/gists{/gist_id}","starred_url":"https://api.github.com/users/Lidemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lidemy/subscriptions","organizations_url":"https://api.github.com/users/Lidemy/orgs","repos_url":"https://api.github.com/users/Lidemy/repos","events_url":"https://api.github.com/users/Lidemy/events{/privacy}","received_events_url":"https://api.github.com/users/Lidemy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao","description":"mentor-program-2nd-tingkao created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao","forks_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/forks","keys_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/teams","hooks_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/hooks","issue_events_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/events{/number}","events_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/events","assignees_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/assignees{/user}","branches_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/branches{/branch}","tags_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/tags","blobs_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/statuses/{sha}","languages_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/languages","stargazers_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/stargazers","contributors_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/contributors","subscribers_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/subscribers","subscription_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/subscription","commits_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/contents/{+path}","compare_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/merges","archive_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/downloads","issues_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues{/number}","pulls_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls{/number}","milestones_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/milestones{/number}","notifications_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/labels{/name}","releases_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/releases{/id}","deployments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/deployments","created_at":"2018-09-03T15:10:31Z","updated_at":"2018-10-17T15:18:07Z","pushed_at":"2018-11-14T11:37:13Z","git_url":"git://github.com/Lidemy/mentor-program-2nd-tingkao.git","ssh_url":"git@github.com:Lidemy/mentor-program-2nd-tingkao.git","clone_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao.git","svn_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao","homepage":null,"size":4747,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Lidemy:master","ref":"master","sha":"bb75c0bfb9010f5c11cf643002775ffb87c977f1","user":{"login":"Lidemy","id":29705873,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA1ODcz","avatar_url":"https://avatars0.githubusercontent.com/u/29705873?v=4","gravatar_id":"","url":"https://api.github.com/users/Lidemy","html_url":"https://github.com/Lidemy","followers_url":"https://api.github.com/users/Lidemy/followers","following_url":"https://api.github.com/users/Lidemy/following{/other_user}","gists_url":"https://api.github.com/users/Lidemy/gists{/gist_id}","starred_url":"https://api.github.com/users/Lidemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lidemy/subscriptions","organizations_url":"https://api.github.com/users/Lidemy/orgs","repos_url":"https://api.github.com/users/Lidemy/repos","events_url":"https://api.github.com/users/Lidemy/events{/privacy}","received_events_url":"https://api.github.com/users/Lidemy/received_events","type":"Organization","site_admin":false},"repo":{"id":147221162,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMjExNjI=","name":"mentor-program-2nd-tingkao","full_name":"Lidemy/mentor-program-2nd-tingkao","private":false,"owner":{"login":"Lidemy","id":29705873,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA1ODcz","avatar_url":"https://avatars0.githubusercontent.com/u/29705873?v=4","gravatar_id":"","url":"https://api.github.com/users/Lidemy","html_url":"https://github.com/Lidemy","followers_url":"https://api.github.com/users/Lidemy/followers","following_url":"https://api.github.com/users/Lidemy/following{/other_user}","gists_url":"https://api.github.com/users/Lidemy/gists{/gist_id}","starred_url":"https://api.github.com/users/Lidemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lidemy/subscriptions","organizations_url":"https://api.github.com/users/Lidemy/orgs","repos_url":"https://api.github.com/users/Lidemy/repos","events_url":"https://api.github.com/users/Lidemy/events{/privacy}","received_events_url":"https://api.github.com/users/Lidemy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao","description":"mentor-program-2nd-tingkao created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao","forks_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/forks","keys_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/teams","hooks_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/hooks","issue_events_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/events{/number}","events_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/events","assignees_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/assignees{/user}","branches_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/branches{/branch}","tags_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/tags","blobs_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/statuses/{sha}","languages_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/languages","stargazers_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/stargazers","contributors_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/contributors","subscribers_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/subscribers","subscription_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/subscription","commits_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/contents/{+path}","compare_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/merges","archive_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/downloads","issues_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues{/number}","pulls_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls{/number}","milestones_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/milestones{/number}","notifications_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/labels{/name}","releases_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/releases{/id}","deployments_url":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/deployments","created_at":"2018-09-03T15:10:31Z","updated_at":"2018-10-17T15:18:07Z","pushed_at":"2018-11-14T11:37:13Z","git_url":"git://github.com/Lidemy/mentor-program-2nd-tingkao.git","ssh_url":"git@github.com:Lidemy/mentor-program-2nd-tingkao.git","clone_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao.git","svn_url":"https://github.com/Lidemy/mentor-program-2nd-tingkao","homepage":null,"size":4747,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11"},"html":{"href":"https://github.com/Lidemy/mentor-program-2nd-tingkao/pull/11"},"issue":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/11"},"comments":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Lidemy/mentor-program-2nd-tingkao/statuses/146ecd1b7d0d686c7bc4c64edb988449bad3c7b1"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aszx87410","id":2755720,"node_id":"MDQ6VXNlcjI3NTU3MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2755720?v=4","gravatar_id":"","url":"https://api.github.com/users/aszx87410","html_url":"https://github.com/aszx87410","followers_url":"https://api.github.com/users/aszx87410/followers","following_url":"https://api.github.com/users/aszx87410/following{/other_user}","gists_url":"https://api.github.com/users/aszx87410/gists{/gist_id}","starred_url":"https://api.github.com/users/aszx87410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aszx87410/subscriptions","organizations_url":"https://api.github.com/users/aszx87410/orgs","repos_url":"https://api.github.com/users/aszx87410/repos","events_url":"https://api.github.com/users/aszx87410/events{/privacy}","received_events_url":"https://api.github.com/users/aszx87410/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":2,"additions":2208,"deletions":0,"changed_files":17}}
{"actor":{"display_login":"aszx87410"}}