{"action":"closed","number":316,"pull_request":{"url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316","id":232966662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTY2NjYy","html_url":"https://github.com/crossroads/stock.goodcity/pull/316","diff_url":"https://github.com/crossroads/stock.goodcity/pull/316.diff","patch_url":"https://github.com/crossroads/stock.goodcity/pull/316.patch","issue_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/316","number":316,"state":"closed","locked":false,"title":"FIX: Crash due to item removed from list during forEach","user":{"login":"patrixr","id":1822532,"node_id":"MDQ6VXNlcjE4MjI1MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1822532?v=4","gravatar_id":"","url":"https://api.github.com/users/patrixr","html_url":"https://github.com/patrixr","followers_url":"https://api.github.com/users/patrixr/followers","following_url":"https://api.github.com/users/patrixr/following{/other_user}","gists_url":"https://api.github.com/users/patrixr/gists{/gist_id}","starred_url":"https://api.github.com/users/patrixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrixr/subscriptions","organizations_url":"https://api.github.com/users/patrixr/orgs","repos_url":"https://api.github.com/users/patrixr/repos","events_url":"https://api.github.com/users/patrixr/events{/privacy}","received_events_url":"https://api.github.com/users/patrixr/received_events","type":"User","site_admin":false},"body":"Crash happening due to `data.removeObject(item);` within a forEach loop.\r\nItems in the following iterations would be undefined, which caused `item.get(\"quantity\");` to break\r\nTiny fix but I added a bit of refactoring while I'm at it :)","created_at":"2018-11-22T12:42:50Z","updated_at":"2018-11-22T13:16:11Z","closed_at":"2018-11-22T13:16:10Z","merged_at":"2018-11-22T13:16:10Z","merge_commit_sha":"7c6f4c2c2431b6a95f0dd0f172b397528107609f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"namrataukirde","id":8424592,"node_id":"MDQ6VXNlcjg0MjQ1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/8424592?v=4","gravatar_id":"","url":"https://api.github.com/users/namrataukirde","html_url":"https://github.com/namrataukirde","followers_url":"https://api.github.com/users/namrataukirde/followers","following_url":"https://api.github.com/users/namrataukirde/following{/other_user}","gists_url":"https://api.github.com/users/namrataukirde/gists{/gist_id}","starred_url":"https://api.github.com/users/namrataukirde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namrataukirde/subscriptions","organizations_url":"https://api.github.com/users/namrataukirde/orgs","repos_url":"https://api.github.com/users/namrataukirde/repos","events_url":"https://api.github.com/users/namrataukirde/events{/privacy}","received_events_url":"https://api.github.com/users/namrataukirde/received_events","type":"User","site_admin":false},{"login":"abhinav098","id":26408955,"node_id":"MDQ6VXNlcjI2NDA4OTU1","avatar_url":"https://avatars3.githubusercontent.com/u/26408955?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinav098","html_url":"https://github.com/abhinav098","followers_url":"https://api.github.com/users/abhinav098/followers","following_url":"https://api.github.com/users/abhinav098/following{/other_user}","gists_url":"https://api.github.com/users/abhinav098/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav098/subscriptions","organizations_url":"https://api.github.com/users/abhinav098/orgs","repos_url":"https://api.github.com/users/abhinav098/repos","events_url":"https://api.github.com/users/abhinav098/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav098/received_events","type":"User","site_admin":false},{"login":"abulsayyad123","id":37627094,"node_id":"MDQ6VXNlcjM3NjI3MDk0","avatar_url":"https://avatars3.githubusercontent.com/u/37627094?v=4","gravatar_id":"","url":"https://api.github.com/users/abulsayyad123","html_url":"https://github.com/abulsayyad123","followers_url":"https://api.github.com/users/abulsayyad123/followers","following_url":"https://api.github.com/users/abulsayyad123/following{/other_user}","gists_url":"https://api.github.com/users/abulsayyad123/gists{/gist_id}","starred_url":"https://api.github.com/users/abulsayyad123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abulsayyad123/subscriptions","organizations_url":"https://api.github.com/users/abulsayyad123/orgs","repos_url":"https://api.github.com/users/abulsayyad123/repos","events_url":"https://api.github.com/users/abulsayyad123/events{/privacy}","received_events_url":"https://api.github.com/users/abulsayyad123/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316/commits","review_comments_url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316/comments","review_comment_url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/316/comments","statuses_url":"https://api.github.com/repos/crossroads/stock.goodcity/statuses/aad91389d7dbe1fcbba0004e06f874b2342ed6cd","head":{"label":"crossroads:order-item-search-crash-fix","ref":"order-item-search-crash-fix","sha":"aad91389d7dbe1fcbba0004e06f874b2342ed6cd","user":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":55611097,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYxMTA5Nw==","name":"stock.goodcity","full_name":"crossroads/stock.goodcity","private":false,"owner":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crossroads/stock.goodcity","description":null,"fork":false,"url":"https://api.github.com/repos/crossroads/stock.goodcity","forks_url":"https://api.github.com/repos/crossroads/stock.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/stock.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/stock.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/stock.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/stock.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/stock.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/stock.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/stock.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/stock.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/stock.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/stock.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/stock.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/stock.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/stock.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/stock.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/stock.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/stock.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/stock.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/stock.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/stock.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/stock.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/stock.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/stock.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/stock.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/stock.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/stock.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/stock.goodcity/deployments","created_at":"2016-04-06T14:06:29Z","updated_at":"2018-11-22T12:32:42Z","pushed_at":"2018-11-22T13:16:10Z","git_url":"git://github.com/crossroads/stock.goodcity.git","ssh_url":"git@github.com:crossroads/stock.goodcity.git","clone_url":"https://github.com/crossroads/stock.goodcity.git","svn_url":"https://github.com/crossroads/stock.goodcity","homepage":null,"size":5688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"crossroads:master","ref":"master","sha":"3f09a09c1ef8f119006cbf16050e85ac70e460bd","user":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":55611097,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYxMTA5Nw==","name":"stock.goodcity","full_name":"crossroads/stock.goodcity","private":false,"owner":{"login":"crossroads","id":141971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/141971?v=4","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crossroads/stock.goodcity","description":null,"fork":false,"url":"https://api.github.com/repos/crossroads/stock.goodcity","forks_url":"https://api.github.com/repos/crossroads/stock.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/stock.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/stock.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/stock.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/stock.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/stock.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/stock.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/stock.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/stock.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/stock.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/stock.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/stock.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/stock.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/stock.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/stock.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/stock.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/stock.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/stock.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/stock.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/stock.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/stock.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/stock.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/stock.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/stock.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/stock.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/stock.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/stock.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/stock.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/stock.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/stock.goodcity/deployments","created_at":"2016-04-06T14:06:29Z","updated_at":"2018-11-22T12:32:42Z","pushed_at":"2018-11-22T13:16:10Z","git_url":"git://github.com/crossroads/stock.goodcity.git","ssh_url":"git@github.com:crossroads/stock.goodcity.git","clone_url":"https://github.com/crossroads/stock.goodcity.git","svn_url":"https://github.com/crossroads/stock.goodcity","homepage":null,"size":5688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316"},"html":{"href":"https://github.com/crossroads/stock.goodcity/pull/316"},"issue":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/issues/316"},"comments":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/crossroads/stock.goodcity/statuses/aad91389d7dbe1fcbba0004e06f874b2342ed6cd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"patrixr","id":1822532,"node_id":"MDQ6VXNlcjE4MjI1MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1822532?v=4","gravatar_id":"","url":"https://api.github.com/users/patrixr","html_url":"https://github.com/patrixr","followers_url":"https://api.github.com/users/patrixr/followers","following_url":"https://api.github.com/users/patrixr/following{/other_user}","gists_url":"https://api.github.com/users/patrixr/gists{/gist_id}","starred_url":"https://api.github.com/users/patrixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrixr/subscriptions","organizations_url":"https://api.github.com/users/patrixr/orgs","repos_url":"https://api.github.com/users/patrixr/repos","events_url":"https://api.github.com/users/patrixr/events{/privacy}","received_events_url":"https://api.github.com/users/patrixr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"patrixr"}}