{"action":"created","comment":{"url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/comments/229262559","pull_request_review_id":169716712,"id":229262559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI2MjU1OQ==","diff_hunk":"@@ -124,14 +124,24 @@ func (coin *Coin) Unit() string {\n \treturn coin.unit\n }\n \n+// Denomination implements coin.Coin.\n+func (coin *Coin) Denomination() *big.Int {\n+\treturn big.NewInt(unitSatoshi)\n+}\n+\n // FormatAmount implements coin.Coin.\n func (coin *Coin) FormatAmount(amount coinpkg.Amount) string {\n \treturn strings.TrimRight(\n-\t\tnew(big.Rat).SetFrac(amount.BigInt(), big.NewInt(unitSatoshi)).FloatString(8),\n+\t\tnew(big.Rat).SetFrac(amount.BigInt(), coin.Denomination()).FloatString(8),\n \t\t\"0.\",\n \t)\n }\n \n+// AccountBased implements coin.Coin.\n+func (coin *Coin) AccountBased() bool {\n+\treturn false\n+}","path":"backend/coins/btc/coin.go","position":32,"original_position":32,"commit_id":"c1072daf364ffa3fb3547c0e7b46cb4ad42bfe8c","original_commit_id":"c1072daf364ffa3fb3547c0e7b46cb4ad42bfe8c","user":{"login":"KasparEtter","id":16501371,"node_id":"MDQ6VXNlcjE2NTAxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/16501371?v=4","gravatar_id":"","url":"https://api.github.com/users/KasparEtter","html_url":"https://github.com/KasparEtter","followers_url":"https://api.github.com/users/KasparEtter/followers","following_url":"https://api.github.com/users/KasparEtter/following{/other_user}","gists_url":"https://api.github.com/users/KasparEtter/gists{/gist_id}","starred_url":"https://api.github.com/users/KasparEtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KasparEtter/subscriptions","organizations_url":"https://api.github.com/users/KasparEtter/orgs","repos_url":"https://api.github.com/users/KasparEtter/repos","events_url":"https://api.github.com/users/KasparEtter/events{/privacy}","received_events_url":"https://api.github.com/users/KasparEtter/received_events","type":"User","site_admin":false},"body":"TODO: Include with a check in the frontend on the receive address screen.","created_at":"2018-10-30T11:04:48Z","updated_at":"2018-10-30T11:04:48Z","html_url":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133#discussion_r229262559","pull_request_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/comments/229262559"},"html":{"href":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133#discussion_r229262559"},"pull_request":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133","id":224026469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDI2NDY5","html_url":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133","diff_url":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133.diff","patch_url":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133.patch","issue_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/133","number":133,"state":"open","locked":false,"title":"backend: move balance to coin pkg, improve coin interfaces, rename init","user":{"login":"KasparEtter","id":16501371,"node_id":"MDQ6VXNlcjE2NTAxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/16501371?v=4","gravatar_id":"","url":"https://api.github.com/users/KasparEtter","html_url":"https://github.com/KasparEtter","followers_url":"https://api.github.com/users/KasparEtter/followers","following_url":"https://api.github.com/users/KasparEtter/following{/other_user}","gists_url":"https://api.github.com/users/KasparEtter/gists{/gist_id}","starred_url":"https://api.github.com/users/KasparEtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KasparEtter/subscriptions","organizations_url":"https://api.github.com/users/KasparEtter/orgs","repos_url":"https://api.github.com/users/KasparEtter/repos","events_url":"https://api.github.com/users/KasparEtter/events{/privacy}","received_events_url":"https://api.github.com/users/KasparEtter/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-18T16:48:00Z","updated_at":"2018-10-30T11:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d648445b7b68fa27f7418d749cd1e005b35d5f76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133/commits","review_comments_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133/comments","review_comment_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/133/comments","statuses_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/statuses/c1072daf364ffa3fb3547c0e7b46cb4ad42bfe8c","head":{"label":"KasparEtter:accounts","ref":"accounts","sha":"c1072daf364ffa3fb3547c0e7b46cb4ad42bfe8c","user":{"login":"KasparEtter","id":16501371,"node_id":"MDQ6VXNlcjE2NTAxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/16501371?v=4","gravatar_id":"","url":"https://api.github.com/users/KasparEtter","html_url":"https://github.com/KasparEtter","followers_url":"https://api.github.com/users/KasparEtter/followers","following_url":"https://api.github.com/users/KasparEtter/following{/other_user}","gists_url":"https://api.github.com/users/KasparEtter/gists{/gist_id}","starred_url":"https://api.github.com/users/KasparEtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KasparEtter/subscriptions","organizations_url":"https://api.github.com/users/KasparEtter/orgs","repos_url":"https://api.github.com/users/KasparEtter/repos","events_url":"https://api.github.com/users/KasparEtter/events{/privacy}","received_events_url":"https://api.github.com/users/KasparEtter/received_events","type":"User","site_admin":false},"repo":{"id":143725333,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MjUzMzM=","name":"bitbox-wallet-app","full_name":"KasparEtter/bitbox-wallet-app","private":false,"owner":{"login":"KasparEtter","id":16501371,"node_id":"MDQ6VXNlcjE2NTAxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/16501371?v=4","gravatar_id":"","url":"https://api.github.com/users/KasparEtter","html_url":"https://github.com/KasparEtter","followers_url":"https://api.github.com/users/KasparEtter/followers","following_url":"https://api.github.com/users/KasparEtter/following{/other_user}","gists_url":"https://api.github.com/users/KasparEtter/gists{/gist_id}","starred_url":"https://api.github.com/users/KasparEtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KasparEtter/subscriptions","organizations_url":"https://api.github.com/users/KasparEtter/orgs","repos_url":"https://api.github.com/users/KasparEtter/repos","events_url":"https://api.github.com/users/KasparEtter/events{/privacy}","received_events_url":"https://api.github.com/users/KasparEtter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KasparEtter/bitbox-wallet-app","description":null,"fork":true,"url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app","forks_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/forks","keys_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/teams","hooks_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/hooks","issue_events_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/issues/events{/number}","events_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/events","assignees_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/assignees{/user}","branches_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/branches{/branch}","tags_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/tags","blobs_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/statuses/{sha}","languages_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/languages","stargazers_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/stargazers","contributors_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/contributors","subscribers_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/subscribers","subscription_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/subscription","commits_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/contents/{+path}","compare_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/merges","archive_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/downloads","issues_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/issues{/number}","pulls_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/pulls{/number}","milestones_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/milestones{/number}","notifications_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/labels{/name}","releases_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/releases{/id}","deployments_url":"https://api.github.com/repos/KasparEtter/bitbox-wallet-app/deployments","created_at":"2018-08-06T12:27:10Z","updated_at":"2018-10-01T15:59:45Z","pushed_at":"2018-10-30T10:58:29Z","git_url":"git://github.com/KasparEtter/bitbox-wallet-app.git","ssh_url":"git@github.com:KasparEtter/bitbox-wallet-app.git","clone_url":"https://github.com/KasparEtter/bitbox-wallet-app.git","svn_url":"https://github.com/KasparEtter/bitbox-wallet-app","homepage":"https://shiftcrypto.ch","size":24200,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"digitalbitbox:master","ref":"master","sha":"072bb0e3386acfac3b84680c04939ad44d124666","user":{"login":"digitalbitbox","id":12703801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzAzODAx","avatar_url":"https://avatars3.githubusercontent.com/u/12703801?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbitbox","html_url":"https://github.com/digitalbitbox","followers_url":"https://api.github.com/users/digitalbitbox/followers","following_url":"https://api.github.com/users/digitalbitbox/following{/other_user}","gists_url":"https://api.github.com/users/digitalbitbox/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbitbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbitbox/subscriptions","organizations_url":"https://api.github.com/users/digitalbitbox/orgs","repos_url":"https://api.github.com/users/digitalbitbox/repos","events_url":"https://api.github.com/users/digitalbitbox/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbitbox/received_events","type":"Organization","site_admin":false},"repo":{"id":143284695,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyODQ2OTU=","name":"bitbox-wallet-app","full_name":"digitalbitbox/bitbox-wallet-app","private":false,"owner":{"login":"digitalbitbox","id":12703801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzAzODAx","avatar_url":"https://avatars3.githubusercontent.com/u/12703801?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbitbox","html_url":"https://github.com/digitalbitbox","followers_url":"https://api.github.com/users/digitalbitbox/followers","following_url":"https://api.github.com/users/digitalbitbox/following{/other_user}","gists_url":"https://api.github.com/users/digitalbitbox/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbitbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbitbox/subscriptions","organizations_url":"https://api.github.com/users/digitalbitbox/orgs","repos_url":"https://api.github.com/users/digitalbitbox/repos","events_url":"https://api.github.com/users/digitalbitbox/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbitbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digitalbitbox/bitbox-wallet-app","description":null,"fork":false,"url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app","forks_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/forks","keys_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/teams","hooks_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/hooks","issue_events_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/events{/number}","events_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/events","assignees_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/assignees{/user}","branches_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/branches{/branch}","tags_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/tags","blobs_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/languages","stargazers_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/stargazers","contributors_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/contributors","subscribers_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/subscribers","subscription_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/subscription","commits_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/contents/{+path}","compare_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/merges","archive_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/downloads","issues_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues{/number}","pulls_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/labels{/name}","releases_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/releases{/id}","deployments_url":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/deployments","created_at":"2018-08-02T11:17:59Z","updated_at":"2018-10-30T09:37:02Z","pushed_at":"2018-10-30T10:58:49Z","git_url":"git://github.com/digitalbitbox/bitbox-wallet-app.git","ssh_url":"git@github.com:digitalbitbox/bitbox-wallet-app.git","clone_url":"https://github.com/digitalbitbox/bitbox-wallet-app.git","svn_url":"https://github.com/digitalbitbox/bitbox-wallet-app","homepage":"https://shiftcrypto.ch","size":24279,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":12,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133"},"html":{"href":"https://github.com/digitalbitbox/bitbox-wallet-app/pull/133"},"issue":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/133"},"comments":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/digitalbitbox/bitbox-wallet-app/statuses/c1072daf364ffa3fb3547c0e7b46cb4ad42bfe8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"KasparEtter"}}