{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/214263233","pull_request_review_id":151272549,"id":214263233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDI2MzIzMw==","diff_hunk":"@@ -179,3 +185,264 @@ suite('Symbol Provider', () => {\n         jediHandler.verifyAll();\n     });\n });\n+\n+function newDoc(\n+    uri?: Uri,","path":"src/test/providers/symbolProvider.unit.test.ts","position":127,"original_position":127,"commit_id":"4e1eb2a661b2e02104722326c3827ff1e3adb718","original_commit_id":"4e1eb2a661b2e02104722326c3827ff1e3adb718","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"body":"Please rename to createDoc or getDoc, or similar.","created_at":"2018-08-31T07:14:34Z","updated_at":"2018-08-31T07:15:26Z","html_url":"https://github.com/Microsoft/vscode-python/pull/2456#discussion_r214263233","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/214263233"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/2456#discussion_r214263233"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456","id":211546356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTQ2MzU2","html_url":"https://github.com/Microsoft/vscode-python/pull/2456","diff_url":"https://github.com/Microsoft/vscode-python/pull/2456.diff","patch_url":"https://github.com/Microsoft/vscode-python/pull/2456.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2456","number":2456,"state":"open","locked":false,"title":"Use symbol provider from new language server to place code lenses in tests.","user":{"login":"ericsnowcurrently","id":1152074,"node_id":"MDQ6VXNlcjExNTIwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"(fixes #1948)\r\n\r\n<!--\r\n  If an item below does not apply to you, then go ahead and check it off as \"done\" and strikethrough the text, e.g.:\r\n    - [x] ~Has unit tests & system/integration tests~\r\n-->\r\n- [x] Title summarizes what is changing\r\n- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)\r\n- [x] Has unit tests & system/integration tests\r\n- [x] ~~Any new/changed dependencies in [`package.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json) are pinned (e.g. `\"1.2.3\"`, not `\"^1.2.3\"` for the specified version)~~\r\n- [x] ~~[`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)~~\r\n\r\nThis is a derivative of @DonJayamanne's #2197.  Differences:\r\n\r\n* removes extra Jedi-related changes\r\n* `PythonSymbolProvider` -> `JediSymbolProvider`\r\n* `SymbolProvider` -> `LanguageServerSymbolProvider` (and moved to `src/client/providers/symbolProvider.ts`)\r\n* flattens the symbol data returned from the language server\r\n* works around a bug in the language server (off-by-one kind)\r\n* adds tests for `LanguageServerSymbolProvider`","created_at":"2018-08-28T20:22:57Z","updated_at":"2018-08-31T07:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afb7e3b38641d375ca7e5d07f93bb17decb82d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2456/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/4e1eb2a661b2e02104722326c3827ff1e3adb718","head":{"label":"ericsnowcurrently:fix-1948-ls-test-code-lenses","ref":"fix-1948-ls-test-code-lenses","sha":"4e1eb2a661b2e02104722326c3827ff1e3adb718","user":{"login":"ericsnowcurrently","id":1152074,"node_id":"MDQ6VXNlcjExNTIwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"repo":{"id":114281280,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQyODEyODA=","name":"vscode-python","full_name":"ericsnowcurrently/vscode-python","owner":{"login":"ericsnowcurrently","id":1152074,"node_id":"MDQ6VXNlcjExNTIwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericsnowcurrently/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/ericsnowcurrently/vscode-python","forks_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/forks","keys_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/teams","hooks_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/events","assignees_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/tags","blobs_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/languages","stargazers_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/subscription","commits_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/merges","archive_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/downloads","issues_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/ericsnowcurrently/vscode-python/deployments","created_at":"2017-12-14T18:04:49Z","updated_at":"2018-08-27T15:13:01Z","pushed_at":"2018-08-30T22:50:09Z","git_url":"git://github.com/ericsnowcurrently/vscode-python.git","ssh_url":"git@github.com:ericsnowcurrently/vscode-python.git","clone_url":"https://github.com/ericsnowcurrently/vscode-python.git","svn_url":"https://github.com/ericsnowcurrently/vscode-python","homepage":"","size":58326,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4bd6118e86a4c9e6a258cf7eebea4c9aceb4c736","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"Microsoft/vscode-python","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2018-08-30T22:27:55Z","pushed_at":"2018-08-30T22:50:11Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":58333,"stargazers_count":750,"watchers_count":750,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":462,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":134,"open_issues":462,"watchers":750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/2456"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/2456"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-python/statuses/4e1eb2a661b2e02104722326c3827ff1e3adb718"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DonJayamanne"}}