{"action":"opened","number":6398,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/6398","id":167659788,"html_url":"https://github.com/concrete5/concrete5/pull/6398","diff_url":"https://github.com/concrete5/concrete5/pull/6398.diff","patch_url":"https://github.com/concrete5/concrete5/pull/6398.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/6398","number":6398,"state":"open","locked":false,"title":"Add a delete key method to config","user":{"login":"marvinde","id":29543909,"avatar_url":"https://avatars3.githubusercontent.com/u/29543909?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinde","html_url":"https://github.com/marvinde","followers_url":"https://api.github.com/users/marvinde/followers","following_url":"https://api.github.com/users/marvinde/following{/other_user}","gists_url":"https://api.github.com/users/marvinde/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinde/subscriptions","organizations_url":"https://api.github.com/users/marvinde/orgs","repos_url":"https://api.github.com/users/marvinde/repos","events_url":"https://api.github.com/users/marvinde/events{/privacy}","received_events_url":"https://api.github.com/users/marvinde/received_events","type":"User","site_admin":false},"body":"I recently created a package for which I needed to override the config. For the installation I used the `save()` method of config, but for the uninstallation there is no `delete()` method to clean the file, why not add one ?\r\nThis may not be the best way to go, I'm waiting for your reviews !","created_at":"2018-02-07T10:57:07Z","updated_at":"2018-02-07T10:57:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5/pulls/6398/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5/pulls/6398/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/6398/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/307996481299ed217ac03d40e34a0fa07f3f9a41","head":{"label":"marvinde:config-delete-key","ref":"config-delete-key","sha":"307996481299ed217ac03d40e34a0fa07f3f9a41","user":{"login":"marvinde","id":29543909,"avatar_url":"https://avatars3.githubusercontent.com/u/29543909?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinde","html_url":"https://github.com/marvinde","followers_url":"https://api.github.com/users/marvinde/followers","following_url":"https://api.github.com/users/marvinde/following{/other_user}","gists_url":"https://api.github.com/users/marvinde/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinde/subscriptions","organizations_url":"https://api.github.com/users/marvinde/orgs","repos_url":"https://api.github.com/users/marvinde/repos","events_url":"https://api.github.com/users/marvinde/events{/privacy}","received_events_url":"https://api.github.com/users/marvinde/received_events","type":"User","site_admin":false},"repo":{"id":120602211,"name":"concrete5","full_name":"marvinde/concrete5","owner":{"login":"marvinde","id":29543909,"avatar_url":"https://avatars3.githubusercontent.com/u/29543909?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinde","html_url":"https://github.com/marvinde","followers_url":"https://api.github.com/users/marvinde/followers","following_url":"https://api.github.com/users/marvinde/following{/other_user}","gists_url":"https://api.github.com/users/marvinde/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinde/subscriptions","organizations_url":"https://api.github.com/users/marvinde/orgs","repos_url":"https://api.github.com/users/marvinde/repos","events_url":"https://api.github.com/users/marvinde/events{/privacy}","received_events_url":"https://api.github.com/users/marvinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marvinde/concrete5","description":"Official repository for concrete5 development","fork":true,"url":"https://api.github.com/repos/marvinde/concrete5","forks_url":"https://api.github.com/repos/marvinde/concrete5/forks","keys_url":"https://api.github.com/repos/marvinde/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marvinde/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marvinde/concrete5/teams","hooks_url":"https://api.github.com/repos/marvinde/concrete5/hooks","issue_events_url":"https://api.github.com/repos/marvinde/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/marvinde/concrete5/events","assignees_url":"https://api.github.com/repos/marvinde/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/marvinde/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/marvinde/concrete5/tags","blobs_url":"https://api.github.com/repos/marvinde/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marvinde/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marvinde/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/marvinde/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marvinde/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/marvinde/concrete5/languages","stargazers_url":"https://api.github.com/repos/marvinde/concrete5/stargazers","contributors_url":"https://api.github.com/repos/marvinde/concrete5/contributors","subscribers_url":"https://api.github.com/repos/marvinde/concrete5/subscribers","subscription_url":"https://api.github.com/repos/marvinde/concrete5/subscription","commits_url":"https://api.github.com/repos/marvinde/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/marvinde/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/marvinde/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/marvinde/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/marvinde/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/marvinde/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marvinde/concrete5/merges","archive_url":"https://api.github.com/repos/marvinde/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marvinde/concrete5/downloads","issues_url":"https://api.github.com/repos/marvinde/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/marvinde/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/marvinde/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/marvinde/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marvinde/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/marvinde/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/marvinde/concrete5/deployments","created_at":"2018-02-07T10:45:21Z","updated_at":"2018-02-07T10:45:33Z","pushed_at":"2018-02-07T10:49:19Z","git_url":"git://github.com/marvinde/concrete5.git","ssh_url":"git@github.com:marvinde/concrete5.git","clone_url":"https://github.com/marvinde/concrete5.git","svn_url":"https://github.com/marvinde/concrete5","homepage":"https://www.concrete5.org","size":97862,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"7622a6c2421e65b2088d4bf27da26d32ae28545d","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5","full_name":"concrete5/concrete5","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5","description":"Official repository for concrete5 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5","forks_url":"https://api.github.com/repos/concrete5/concrete5/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/concrete5/concrete5/deployments","created_at":"2014-04-22T18:12:28Z","updated_at":"2018-02-06T01:14:02Z","pushed_at":"2018-02-06T18:06:11Z","git_url":"git://github.com/concrete5/concrete5.git","ssh_url":"git@github.com:concrete5/concrete5.git","clone_url":"https://github.com/concrete5/concrete5.git","svn_url":"https://github.com/concrete5/concrete5","homepage":"https://www.concrete5.org","size":97862,"stargazers_count":424,"watchers_count":424,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":623,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":337,"open_issues":623,"watchers":424,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6398"},"html":{"href":"https://github.com/concrete5/concrete5/pull/6398"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/6398"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/6398/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6398/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6398/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5/statuses/307996481299ed217ac03d40e34a0fa07f3f9a41"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":93,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"marvinde"}}