{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/maccallumlab/meld/pulls/54","id":201540933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTQwOTMz","html_url":"https://github.com/maccallumlab/meld/pull/54","diff_url":"https://github.com/maccallumlab/meld/pull/54.diff","patch_url":"https://github.com/maccallumlab/meld/pull/54.patch","issue_url":"https://api.github.com/repos/maccallumlab/meld/issues/54","number":54,"state":"closed","locked":false,"title":"Support for building explicit water/ion boxes using tleap","user":{"login":"cing","id":116655,"node_id":"MDQ6VXNlcjExNjY1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/116655?v=4","gravatar_id":"","url":"https://api.github.com/users/cing","html_url":"https://github.com/cing","followers_url":"https://api.github.com/users/cing/followers","following_url":"https://api.github.com/users/cing/following{/other_user}","gists_url":"https://api.github.com/users/cing/gists{/gist_id}","starred_url":"https://api.github.com/users/cing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cing/subscriptions","organizations_url":"https://api.github.com/users/cing/orgs","repos_url":"https://api.github.com/users/cing/repos","events_url":"https://api.github.com/users/cing/events{/privacy}","received_events_url":"https://api.github.com/users/cing/received_events","type":"User","site_admin":false},"body":"Fixes #46\r\n\r\nThis PR essentially just adds new parameters to `SystemBuilder` to interface with already existing tleap functionality in AmberTools/ambermini. I didn't implement the proposed enhancement where a restraining potential should be used to collapse long chains before solvating to reduce box sizes. More discussion needs to be had about the best way to do that. Lots of hardcoded values for the system sizes in the new tests of explicit water boxes. The current water box and ion replacement protocol seems deterministic, but this could be a possible breaking point if tleap algorithms changes in the future.\r\n\r\nI'm planning to use this code for the subsequent REST2/AMAP scaling tests so we don't have to distribute as many mdcrd/top files in the test directories of the repo. ","created_at":"2018-07-16T05:00:09Z","updated_at":"2018-07-19T15:16:08Z","closed_at":"2018-07-19T15:16:08Z","merged_at":"2018-07-19T15:16:08Z","merge_commit_sha":"8e29e881ea2620e2f88380732cab60f3c0dd71cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maccallumlab/meld/pulls/54/commits","review_comments_url":"https://api.github.com/repos/maccallumlab/meld/pulls/54/comments","review_comment_url":"https://api.github.com/repos/maccallumlab/meld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maccallumlab/meld/issues/54/comments","statuses_url":"https://api.github.com/repos/maccallumlab/meld/statuses/8e29e881ea2620e2f88380732cab60f3c0dd71cc","head":{"label":"cing:explicit-builder","ref":"explicit-builder","sha":"8e29e881ea2620e2f88380732cab60f3c0dd71cc","user":{"login":"cing","id":116655,"node_id":"MDQ6VXNlcjExNjY1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/116655?v=4","gravatar_id":"","url":"https://api.github.com/users/cing","html_url":"https://github.com/cing","followers_url":"https://api.github.com/users/cing/followers","following_url":"https://api.github.com/users/cing/following{/other_user}","gists_url":"https://api.github.com/users/cing/gists{/gist_id}","starred_url":"https://api.github.com/users/cing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cing/subscriptions","organizations_url":"https://api.github.com/users/cing/orgs","repos_url":"https://api.github.com/users/cing/repos","events_url":"https://api.github.com/users/cing/events{/privacy}","received_events_url":"https://api.github.com/users/cing/received_events","type":"User","site_admin":false},"repo":{"id":133896195,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4OTYxOTU=","name":"meld","full_name":"cing/meld","owner":{"login":"cing","id":116655,"node_id":"MDQ6VXNlcjExNjY1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/116655?v=4","gravatar_id":"","url":"https://api.github.com/users/cing","html_url":"https://github.com/cing","followers_url":"https://api.github.com/users/cing/followers","following_url":"https://api.github.com/users/cing/following{/other_user}","gists_url":"https://api.github.com/users/cing/gists{/gist_id}","starred_url":"https://api.github.com/users/cing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cing/subscriptions","organizations_url":"https://api.github.com/users/cing/orgs","repos_url":"https://api.github.com/users/cing/repos","events_url":"https://api.github.com/users/cing/events{/privacy}","received_events_url":"https://api.github.com/users/cing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cing/meld","description":"Modeling with limited data","fork":true,"url":"https://api.github.com/repos/cing/meld","forks_url":"https://api.github.com/repos/cing/meld/forks","keys_url":"https://api.github.com/repos/cing/meld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cing/meld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cing/meld/teams","hooks_url":"https://api.github.com/repos/cing/meld/hooks","issue_events_url":"https://api.github.com/repos/cing/meld/issues/events{/number}","events_url":"https://api.github.com/repos/cing/meld/events","assignees_url":"https://api.github.com/repos/cing/meld/assignees{/user}","branches_url":"https://api.github.com/repos/cing/meld/branches{/branch}","tags_url":"https://api.github.com/repos/cing/meld/tags","blobs_url":"https://api.github.com/repos/cing/meld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cing/meld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cing/meld/git/refs{/sha}","trees_url":"https://api.github.com/repos/cing/meld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cing/meld/statuses/{sha}","languages_url":"https://api.github.com/repos/cing/meld/languages","stargazers_url":"https://api.github.com/repos/cing/meld/stargazers","contributors_url":"https://api.github.com/repos/cing/meld/contributors","subscribers_url":"https://api.github.com/repos/cing/meld/subscribers","subscription_url":"https://api.github.com/repos/cing/meld/subscription","commits_url":"https://api.github.com/repos/cing/meld/commits{/sha}","git_commits_url":"https://api.github.com/repos/cing/meld/git/commits{/sha}","comments_url":"https://api.github.com/repos/cing/meld/comments{/number}","issue_comment_url":"https://api.github.com/repos/cing/meld/issues/comments{/number}","contents_url":"https://api.github.com/repos/cing/meld/contents/{+path}","compare_url":"https://api.github.com/repos/cing/meld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cing/meld/merges","archive_url":"https://api.github.com/repos/cing/meld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cing/meld/downloads","issues_url":"https://api.github.com/repos/cing/meld/issues{/number}","pulls_url":"https://api.github.com/repos/cing/meld/pulls{/number}","milestones_url":"https://api.github.com/repos/cing/meld/milestones{/number}","notifications_url":"https://api.github.com/repos/cing/meld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cing/meld/labels{/name}","releases_url":"https://api.github.com/repos/cing/meld/releases{/id}","deployments_url":"https://api.github.com/repos/cing/meld/deployments","created_at":"2018-05-18T03:08:13Z","updated_at":"2018-06-28T04:42:47Z","pushed_at":"2018-07-16T04:42:39Z","git_url":"git://github.com/cing/meld.git","ssh_url":"git@github.com:cing/meld.git","clone_url":"https://github.com/cing/meld.git","svn_url":"https://github.com/cing/meld","homepage":null,"size":2687,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maccallumlab:master","ref":"master","sha":"440bf6a6d09516466cf87df62e42e6c798781448","user":{"login":"maccallumlab","id":7613511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTM1MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7613511?v=4","gravatar_id":"","url":"https://api.github.com/users/maccallumlab","html_url":"https://github.com/maccallumlab","followers_url":"https://api.github.com/users/maccallumlab/followers","following_url":"https://api.github.com/users/maccallumlab/following{/other_user}","gists_url":"https://api.github.com/users/maccallumlab/gists{/gist_id}","starred_url":"https://api.github.com/users/maccallumlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccallumlab/subscriptions","organizations_url":"https://api.github.com/users/maccallumlab/orgs","repos_url":"https://api.github.com/users/maccallumlab/repos","events_url":"https://api.github.com/users/maccallumlab/events{/privacy}","received_events_url":"https://api.github.com/users/maccallumlab/received_events","type":"Organization","site_admin":false},"repo":{"id":23021423,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAyMTQyMw==","name":"meld","full_name":"maccallumlab/meld","owner":{"login":"maccallumlab","id":7613511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTM1MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7613511?v=4","gravatar_id":"","url":"https://api.github.com/users/maccallumlab","html_url":"https://github.com/maccallumlab","followers_url":"https://api.github.com/users/maccallumlab/followers","following_url":"https://api.github.com/users/maccallumlab/following{/other_user}","gists_url":"https://api.github.com/users/maccallumlab/gists{/gist_id}","starred_url":"https://api.github.com/users/maccallumlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccallumlab/subscriptions","organizations_url":"https://api.github.com/users/maccallumlab/orgs","repos_url":"https://api.github.com/users/maccallumlab/repos","events_url":"https://api.github.com/users/maccallumlab/events{/privacy}","received_events_url":"https://api.github.com/users/maccallumlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maccallumlab/meld","description":"Modeling with limited data","fork":false,"url":"https://api.github.com/repos/maccallumlab/meld","forks_url":"https://api.github.com/repos/maccallumlab/meld/forks","keys_url":"https://api.github.com/repos/maccallumlab/meld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maccallumlab/meld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maccallumlab/meld/teams","hooks_url":"https://api.github.com/repos/maccallumlab/meld/hooks","issue_events_url":"https://api.github.com/repos/maccallumlab/meld/issues/events{/number}","events_url":"https://api.github.com/repos/maccallumlab/meld/events","assignees_url":"https://api.github.com/repos/maccallumlab/meld/assignees{/user}","branches_url":"https://api.github.com/repos/maccallumlab/meld/branches{/branch}","tags_url":"https://api.github.com/repos/maccallumlab/meld/tags","blobs_url":"https://api.github.com/repos/maccallumlab/meld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maccallumlab/meld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maccallumlab/meld/git/refs{/sha}","trees_url":"https://api.github.com/repos/maccallumlab/meld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maccallumlab/meld/statuses/{sha}","languages_url":"https://api.github.com/repos/maccallumlab/meld/languages","stargazers_url":"https://api.github.com/repos/maccallumlab/meld/stargazers","contributors_url":"https://api.github.com/repos/maccallumlab/meld/contributors","subscribers_url":"https://api.github.com/repos/maccallumlab/meld/subscribers","subscription_url":"https://api.github.com/repos/maccallumlab/meld/subscription","commits_url":"https://api.github.com/repos/maccallumlab/meld/commits{/sha}","git_commits_url":"https://api.github.com/repos/maccallumlab/meld/git/commits{/sha}","comments_url":"https://api.github.com/repos/maccallumlab/meld/comments{/number}","issue_comment_url":"https://api.github.com/repos/maccallumlab/meld/issues/comments{/number}","contents_url":"https://api.github.com/repos/maccallumlab/meld/contents/{+path}","compare_url":"https://api.github.com/repos/maccallumlab/meld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maccallumlab/meld/merges","archive_url":"https://api.github.com/repos/maccallumlab/meld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maccallumlab/meld/downloads","issues_url":"https://api.github.com/repos/maccallumlab/meld/issues{/number}","pulls_url":"https://api.github.com/repos/maccallumlab/meld/pulls{/number}","milestones_url":"https://api.github.com/repos/maccallumlab/meld/milestones{/number}","notifications_url":"https://api.github.com/repos/maccallumlab/meld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maccallumlab/meld/labels{/name}","releases_url":"https://api.github.com/repos/maccallumlab/meld/releases{/id}","deployments_url":"https://api.github.com/repos/maccallumlab/meld/deployments","created_at":"2014-08-16T15:55:04Z","updated_at":"2018-07-19T14:05:52Z","pushed_at":"2018-07-19T15:16:07Z","git_url":"git://github.com/maccallumlab/meld.git","ssh_url":"git@github.com:maccallumlab/meld.git","clone_url":"https://github.com/maccallumlab/meld.git","svn_url":"https://github.com/maccallumlab/meld","homepage":null,"size":2732,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":15,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maccallumlab/meld/pulls/54"},"html":{"href":"https://github.com/maccallumlab/meld/pull/54"},"issue":{"href":"https://api.github.com/repos/maccallumlab/meld/issues/54"},"comments":{"href":"https://api.github.com/repos/maccallumlab/meld/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/maccallumlab/meld/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/maccallumlab/meld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maccallumlab/meld/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/maccallumlab/meld/statuses/8e29e881ea2620e2f88380732cab60f3c0dd71cc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jlmaccal","id":108119,"node_id":"MDQ6VXNlcjEwODExOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/108119?v=4","gravatar_id":"","url":"https://api.github.com/users/jlmaccal","html_url":"https://github.com/jlmaccal","followers_url":"https://api.github.com/users/jlmaccal/followers","following_url":"https://api.github.com/users/jlmaccal/following{/other_user}","gists_url":"https://api.github.com/users/jlmaccal/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmaccal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmaccal/subscriptions","organizations_url":"https://api.github.com/users/jlmaccal/orgs","repos_url":"https://api.github.com/users/jlmaccal/repos","events_url":"https://api.github.com/users/jlmaccal/events{/privacy}","received_events_url":"https://api.github.com/users/jlmaccal/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":185,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"jlmaccal"}}