{"action":"closed","number":3085,"pull_request":{"url":"https://api.github.com/repos/gap-system/gap/pulls/3085","id":235820674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODIwNjc0","html_url":"https://github.com/gap-system/gap/pull/3085","diff_url":"https://github.com/gap-system/gap/pull/3085.diff","patch_url":"https://github.com/gap-system/gap/pull/3085.patch","issue_url":"https://api.github.com/repos/gap-system/gap/issues/3085","number":3085,"state":"closed","locked":false,"title":"kernel: cleanup src/integer.{c,h}","user":{"login":"fingolfin","id":241512,"node_id":"MDQ6VXNlcjI0MTUxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/241512?v=4","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"body":"* tweak the `RequireInt` macro to automatically deduce the argument name\r\n* rename function arguments from gmpL -> opL, gmpR -> opR, gmp -> op\r\n  especially in user visible places\r\n* remove other gratuitous references to \"GMP integer\"\r\n* sync comments in integer.h and integer.c\r\n\r\n... and then also did some `git clang-format`ing of the changed lines, to remove various whitespace etc. -- all of those can be ignored by viewing this PR with the \"Hide whitespace changes\" option enabled.","created_at":"2018-12-04T14:04:30Z","updated_at":"2018-12-13T10:37:35Z","closed_at":"2018-12-13T10:37:35Z","merged_at":"2018-12-13T10:37:35Z","merge_commit_sha":"4f68c6af1045a58732393018f08fba49a187caa6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":689248488,"node_id":"MDU6TGFiZWw2ODkyNDg0ODg=","url":"https://api.github.com/repos/gap-system/gap/labels/release%20notes:%20not%20needed","name":"release notes: not needed","color":"86d7e8","default":false},{"id":577472995,"node_id":"MDU6TGFiZWw1Nzc0NzI5OTU=","url":"https://api.github.com/repos/gap-system/gap/labels/topic:%20kernel","name":"topic: kernel","color":"c0d9f7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gap-system/gap/pulls/3085/commits","review_comments_url":"https://api.github.com/repos/gap-system/gap/pulls/3085/comments","review_comment_url":"https://api.github.com/repos/gap-system/gap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gap-system/gap/issues/3085/comments","statuses_url":"https://api.github.com/repos/gap-system/gap/statuses/f29f06d9a26c95a0c23686239d555432a3e4ba97","head":{"label":"fingolfin:mh/integer-cleanup","ref":"mh/integer-cleanup","sha":"f29f06d9a26c95a0c23686239d555432a3e4ba97","user":{"login":"fingolfin","id":241512,"node_id":"MDQ6VXNlcjI0MTUxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/241512?v=4","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"repo":{"id":31670364,"node_id":"MDEwOlJlcG9zaXRvcnkzMTY3MDM2NA==","name":"gap","full_name":"fingolfin/gap","private":false,"owner":{"login":"fingolfin","id":241512,"node_id":"MDQ6VXNlcjI0MTUxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/241512?v=4","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fingolfin/gap","description":"GAP - Groups, Algorithms, Programming - a System for Computational Discrete Algebra","fork":true,"url":"https://api.github.com/repos/fingolfin/gap","forks_url":"https://api.github.com/repos/fingolfin/gap/forks","keys_url":"https://api.github.com/repos/fingolfin/gap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fingolfin/gap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fingolfin/gap/teams","hooks_url":"https://api.github.com/repos/fingolfin/gap/hooks","issue_events_url":"https://api.github.com/repos/fingolfin/gap/issues/events{/number}","events_url":"https://api.github.com/repos/fingolfin/gap/events","assignees_url":"https://api.github.com/repos/fingolfin/gap/assignees{/user}","branches_url":"https://api.github.com/repos/fingolfin/gap/branches{/branch}","tags_url":"https://api.github.com/repos/fingolfin/gap/tags","blobs_url":"https://api.github.com/repos/fingolfin/gap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fingolfin/gap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fingolfin/gap/git/refs{/sha}","trees_url":"https://api.github.com/repos/fingolfin/gap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fingolfin/gap/statuses/{sha}","languages_url":"https://api.github.com/repos/fingolfin/gap/languages","stargazers_url":"https://api.github.com/repos/fingolfin/gap/stargazers","contributors_url":"https://api.github.com/repos/fingolfin/gap/contributors","subscribers_url":"https://api.github.com/repos/fingolfin/gap/subscribers","subscription_url":"https://api.github.com/repos/fingolfin/gap/subscription","commits_url":"https://api.github.com/repos/fingolfin/gap/commits{/sha}","git_commits_url":"https://api.github.com/repos/fingolfin/gap/git/commits{/sha}","comments_url":"https://api.github.com/repos/fingolfin/gap/comments{/number}","issue_comment_url":"https://api.github.com/repos/fingolfin/gap/issues/comments{/number}","contents_url":"https://api.github.com/repos/fingolfin/gap/contents/{+path}","compare_url":"https://api.github.com/repos/fingolfin/gap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fingolfin/gap/merges","archive_url":"https://api.github.com/repos/fingolfin/gap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fingolfin/gap/downloads","issues_url":"https://api.github.com/repos/fingolfin/gap/issues{/number}","pulls_url":"https://api.github.com/repos/fingolfin/gap/pulls{/number}","milestones_url":"https://api.github.com/repos/fingolfin/gap/milestones{/number}","notifications_url":"https://api.github.com/repos/fingolfin/gap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fingolfin/gap/labels{/name}","releases_url":"https://api.github.com/repos/fingolfin/gap/releases{/id}","deployments_url":"https://api.github.com/repos/fingolfin/gap/deployments","created_at":"2015-03-04T17:35:23Z","updated_at":"2018-08-28T13:32:41Z","pushed_at":"2018-12-12T13:38:22Z","git_url":"git://github.com/fingolfin/gap.git","ssh_url":"git@github.com:fingolfin/gap.git","clone_url":"https://github.com/fingolfin/gap.git","svn_url":"https://github.com/fingolfin/gap","homepage":"http://www.gap-system.org","size":393552,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"gap-system:master","ref":"master","sha":"2acdb158eb895aeb41d99516a67ee4b684c25aa9","user":{"login":"gap-system","id":5344223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDQyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5344223?v=4","gravatar_id":"","url":"https://api.github.com/users/gap-system","html_url":"https://github.com/gap-system","followers_url":"https://api.github.com/users/gap-system/followers","following_url":"https://api.github.com/users/gap-system/following{/other_user}","gists_url":"https://api.github.com/users/gap-system/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-system/subscriptions","organizations_url":"https://api.github.com/users/gap-system/orgs","repos_url":"https://api.github.com/users/gap-system/repos","events_url":"https://api.github.com/users/gap-system/events{/privacy}","received_events_url":"https://api.github.com/users/gap-system/received_events","type":"Organization","site_admin":false},"repo":{"id":31270208,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI3MDIwOA==","name":"gap","full_name":"gap-system/gap","private":false,"owner":{"login":"gap-system","id":5344223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDQyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5344223?v=4","gravatar_id":"","url":"https://api.github.com/users/gap-system","html_url":"https://github.com/gap-system","followers_url":"https://api.github.com/users/gap-system/followers","following_url":"https://api.github.com/users/gap-system/following{/other_user}","gists_url":"https://api.github.com/users/gap-system/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-system/subscriptions","organizations_url":"https://api.github.com/users/gap-system/orgs","repos_url":"https://api.github.com/users/gap-system/repos","events_url":"https://api.github.com/users/gap-system/events{/privacy}","received_events_url":"https://api.github.com/users/gap-system/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gap-system/gap","description":"Main development repository for GAP - Groups, Algorithms, Programming, a System for Computational Discrete Algebra","fork":false,"url":"https://api.github.com/repos/gap-system/gap","forks_url":"https://api.github.com/repos/gap-system/gap/forks","keys_url":"https://api.github.com/repos/gap-system/gap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gap-system/gap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gap-system/gap/teams","hooks_url":"https://api.github.com/repos/gap-system/gap/hooks","issue_events_url":"https://api.github.com/repos/gap-system/gap/issues/events{/number}","events_url":"https://api.github.com/repos/gap-system/gap/events","assignees_url":"https://api.github.com/repos/gap-system/gap/assignees{/user}","branches_url":"https://api.github.com/repos/gap-system/gap/branches{/branch}","tags_url":"https://api.github.com/repos/gap-system/gap/tags","blobs_url":"https://api.github.com/repos/gap-system/gap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gap-system/gap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gap-system/gap/git/refs{/sha}","trees_url":"https://api.github.com/repos/gap-system/gap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gap-system/gap/statuses/{sha}","languages_url":"https://api.github.com/repos/gap-system/gap/languages","stargazers_url":"https://api.github.com/repos/gap-system/gap/stargazers","contributors_url":"https://api.github.com/repos/gap-system/gap/contributors","subscribers_url":"https://api.github.com/repos/gap-system/gap/subscribers","subscription_url":"https://api.github.com/repos/gap-system/gap/subscription","commits_url":"https://api.github.com/repos/gap-system/gap/commits{/sha}","git_commits_url":"https://api.github.com/repos/gap-system/gap/git/commits{/sha}","comments_url":"https://api.github.com/repos/gap-system/gap/comments{/number}","issue_comment_url":"https://api.github.com/repos/gap-system/gap/issues/comments{/number}","contents_url":"https://api.github.com/repos/gap-system/gap/contents/{+path}","compare_url":"https://api.github.com/repos/gap-system/gap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gap-system/gap/merges","archive_url":"https://api.github.com/repos/gap-system/gap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gap-system/gap/downloads","issues_url":"https://api.github.com/repos/gap-system/gap/issues{/number}","pulls_url":"https://api.github.com/repos/gap-system/gap/pulls{/number}","milestones_url":"https://api.github.com/repos/gap-system/gap/milestones{/number}","notifications_url":"https://api.github.com/repos/gap-system/gap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gap-system/gap/labels{/name}","releases_url":"https://api.github.com/repos/gap-system/gap/releases{/id}","deployments_url":"https://api.github.com/repos/gap-system/gap/deployments","created_at":"2015-02-24T16:47:50Z","updated_at":"2018-12-12T20:57:57Z","pushed_at":"2018-12-13T10:37:35Z","git_url":"git://github.com/gap-system/gap.git","ssh_url":"git@github.com:gap-system/gap.git","clone_url":"https://github.com/gap-system/gap.git","svn_url":"https://github.com/gap-system/gap","homepage":"https://www.gap-system.org","size":405587,"stargazers_count":261,"watchers_count":261,"language":"GAP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":359,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":88,"open_issues":359,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gap-system/gap/pulls/3085"},"html":{"href":"https://github.com/gap-system/gap/pull/3085"},"issue":{"href":"https://api.github.com/repos/gap-system/gap/issues/3085"},"comments":{"href":"https://api.github.com/repos/gap-system/gap/issues/3085/comments"},"review_comments":{"href":"https://api.github.com/repos/gap-system/gap/pulls/3085/comments"},"review_comment":{"href":"https://api.github.com/repos/gap-system/gap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gap-system/gap/pulls/3085/commits"},"statuses":{"href":"https://api.github.com/repos/gap-system/gap/statuses/f29f06d9a26c95a0c23686239d555432a3e4ba97"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ChrisJefferson","id":811527,"node_id":"MDQ6VXNlcjgxMTUyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/811527?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisJefferson","html_url":"https://github.com/ChrisJefferson","followers_url":"https://api.github.com/users/ChrisJefferson/followers","following_url":"https://api.github.com/users/ChrisJefferson/following{/other_user}","gists_url":"https://api.github.com/users/ChrisJefferson/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisJefferson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisJefferson/subscriptions","organizations_url":"https://api.github.com/users/ChrisJefferson/orgs","repos_url":"https://api.github.com/users/ChrisJefferson/repos","events_url":"https://api.github.com/users/ChrisJefferson/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisJefferson/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":348,"deletions":366,"changed_files":5}}
{"actor":{"display_login":"ChrisJefferson"}}