{"action":"created","comment":{"url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/comments/207969680","pull_request_review_id":143687802,"id":207969680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk2OTY4MA==","diff_hunk":"@@ -1,217 +1,124 @@\n+open Sexplib.Std\n+\n let value_or_empty_str f = function\n   | None -> \"\"\n   | Some v -> f v\n \n-module Tag = struct\n-  type t = string * string (** (tag-name, value) *)\n-\n-  let datagram_fmt l =\n-    let format_tag (name, value) = Printf.sprintf \"%s:%s\" name value in\n-    Printf.sprintf \"|#%s\" (String.concat \",\" (List.map format_tag l))\n+(** https://docs.datadoghq.com/developers/dogstatsd/ *)\n+module type T = sig\n+  include Dogstatsd_types.Types\n end","path":"statsd-client/dogstatsd.ml","position":16,"original_position":16,"commit_id":"7c932e7b468aaeb5c3313a5f0ef082b4c2378606","original_commit_id":"7c932e7b468aaeb5c3313a5f0ef082b4c2378606","user":{"login":"acjay","id":1256382,"node_id":"MDQ6VXNlcjEyNTYzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1256382?v=4","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},"body":"Ah, interesting. Not having made it through RWO all the way yet, do you happen to know whether it will cover most of these conventsions, or whether there's a good source?\r\n\r\nThe DRY diff isn't pretty, but it's literally just the body of `T` in both files factored out. So this is the same `T` as before. Combining this with your comment below, would the idea be to do `module T = Dogstatsd_intf.S`, or should it have more appropriately been called `S` prior to this PR?","created_at":"2018-08-06T17:26:55Z","updated_at":"2018-08-06T17:26:56Z","html_url":"https://github.com/arenadotio/ocaml-statsd-client/pull/7#discussion_r207969680","pull_request_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/comments/207969680"},"html":{"href":"https://github.com/arenadotio/ocaml-statsd-client/pull/7#discussion_r207969680"},"pull_request":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7"}},"in_reply_to_id":207959944},"pull_request":{"url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7","id":206093852,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDkzODUy","html_url":"https://github.com/arenadotio/ocaml-statsd-client/pull/7","diff_url":"https://github.com/arenadotio/ocaml-statsd-client/pull/7.diff","patch_url":"https://github.com/arenadotio/ocaml-statsd-client/pull/7.patch","issue_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/7","number":7,"state":"open","locked":false,"title":"DON'T MERGE Expose type and sexp","user":{"login":"acjay","id":1256382,"node_id":"MDQ6VXNlcjEyNTYzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1256382?v=4","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},"body":"I _think_ this should do it.","created_at":"2018-08-03T17:34:10Z","updated_at":"2018-08-06T17:26:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08302fb480d218652c9668b6e17dcaa0aa9d0ba5","assignee":{"login":"kevinqiu","id":3165150,"node_id":"MDQ6VXNlcjMxNjUxNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3165150?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinqiu","html_url":"https://github.com/kevinqiu","followers_url":"https://api.github.com/users/kevinqiu/followers","following_url":"https://api.github.com/users/kevinqiu/following{/other_user}","gists_url":"https://api.github.com/users/kevinqiu/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinqiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinqiu/subscriptions","organizations_url":"https://api.github.com/users/kevinqiu/orgs","repos_url":"https://api.github.com/users/kevinqiu/repos","events_url":"https://api.github.com/users/kevinqiu/events{/privacy}","received_events_url":"https://api.github.com/users/kevinqiu/received_events","type":"User","site_admin":false},"assignees":[{"login":"kevinqiu","id":3165150,"node_id":"MDQ6VXNlcjMxNjUxNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3165150?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinqiu","html_url":"https://github.com/kevinqiu","followers_url":"https://api.github.com/users/kevinqiu/followers","following_url":"https://api.github.com/users/kevinqiu/following{/other_user}","gists_url":"https://api.github.com/users/kevinqiu/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinqiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinqiu/subscriptions","organizations_url":"https://api.github.com/users/kevinqiu/orgs","repos_url":"https://api.github.com/users/kevinqiu/repos","events_url":"https://api.github.com/users/kevinqiu/events{/privacy}","received_events_url":"https://api.github.com/users/kevinqiu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7/commits","review_comments_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7/comments","review_comment_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/7/comments","statuses_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/statuses/7c932e7b468aaeb5c3313a5f0ef082b4c2378606","head":{"label":"acjay:expose_type_and_sexp","ref":"expose_type_and_sexp","sha":"7c932e7b468aaeb5c3313a5f0ef082b4c2378606","user":{"login":"acjay","id":1256382,"node_id":"MDQ6VXNlcjEyNTYzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1256382?v=4","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},"repo":{"id":143201027,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMDEwMjc=","name":"ocaml-statsd-client","full_name":"acjay/ocaml-statsd-client","owner":{"login":"acjay","id":1256382,"node_id":"MDQ6VXNlcjEyNTYzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1256382?v=4","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acjay/ocaml-statsd-client","description":"Statsd client for OCaml","fork":true,"url":"https://api.github.com/repos/acjay/ocaml-statsd-client","forks_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/forks","keys_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/teams","hooks_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/hooks","issue_events_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/issues/events{/number}","events_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/events","assignees_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/assignees{/user}","branches_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/branches{/branch}","tags_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/tags","blobs_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/languages","stargazers_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/stargazers","contributors_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/contributors","subscribers_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/subscribers","subscription_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/subscription","commits_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/contents/{+path}","compare_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/merges","archive_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/downloads","issues_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/issues{/number}","pulls_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/labels{/name}","releases_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/releases{/id}","deployments_url":"https://api.github.com/repos/acjay/ocaml-statsd-client/deployments","created_at":"2018-08-01T19:41:01Z","updated_at":"2018-08-01T19:41:03Z","pushed_at":"2018-08-06T16:46:01Z","git_url":"git://github.com/acjay/ocaml-statsd-client.git","ssh_url":"git@github.com:acjay/ocaml-statsd-client.git","clone_url":"https://github.com/acjay/ocaml-statsd-client.git","svn_url":"https://github.com/acjay/ocaml-statsd-client","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arenadotio:master","ref":"master","sha":"cf70f1910e1ed7006569a10de11215895a00f738","user":{"login":"arenadotio","id":12241307,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQxMzA3","avatar_url":"https://avatars0.githubusercontent.com/u/12241307?v=4","gravatar_id":"","url":"https://api.github.com/users/arenadotio","html_url":"https://github.com/arenadotio","followers_url":"https://api.github.com/users/arenadotio/followers","following_url":"https://api.github.com/users/arenadotio/following{/other_user}","gists_url":"https://api.github.com/users/arenadotio/gists{/gist_id}","starred_url":"https://api.github.com/users/arenadotio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arenadotio/subscriptions","organizations_url":"https://api.github.com/users/arenadotio/orgs","repos_url":"https://api.github.com/users/arenadotio/repos","events_url":"https://api.github.com/users/arenadotio/events{/privacy}","received_events_url":"https://api.github.com/users/arenadotio/received_events","type":"Organization","site_admin":false},"repo":{"id":121422624,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MjI2MjQ=","name":"ocaml-statsd-client","full_name":"arenadotio/ocaml-statsd-client","owner":{"login":"arenadotio","id":12241307,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQxMzA3","avatar_url":"https://avatars0.githubusercontent.com/u/12241307?v=4","gravatar_id":"","url":"https://api.github.com/users/arenadotio","html_url":"https://github.com/arenadotio","followers_url":"https://api.github.com/users/arenadotio/followers","following_url":"https://api.github.com/users/arenadotio/following{/other_user}","gists_url":"https://api.github.com/users/arenadotio/gists{/gist_id}","starred_url":"https://api.github.com/users/arenadotio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arenadotio/subscriptions","organizations_url":"https://api.github.com/users/arenadotio/orgs","repos_url":"https://api.github.com/users/arenadotio/repos","events_url":"https://api.github.com/users/arenadotio/events{/privacy}","received_events_url":"https://api.github.com/users/arenadotio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arenadotio/ocaml-statsd-client","description":"Statsd client for OCaml","fork":true,"url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client","forks_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/forks","keys_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/teams","hooks_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/hooks","issue_events_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/events{/number}","events_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/events","assignees_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/assignees{/user}","branches_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/branches{/branch}","tags_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/tags","blobs_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/languages","stargazers_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/stargazers","contributors_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/contributors","subscribers_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/subscribers","subscription_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/subscription","commits_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/contents/{+path}","compare_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/merges","archive_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/downloads","issues_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues{/number}","pulls_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/labels{/name}","releases_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/releases{/id}","deployments_url":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/deployments","created_at":"2018-02-13T18:54:09Z","updated_at":"2018-07-27T21:12:03Z","pushed_at":"2018-08-06T16:46:02Z","git_url":"git://github.com/arenadotio/ocaml-statsd-client.git","ssh_url":"git@github.com:arenadotio/ocaml-statsd-client.git","clone_url":"https://github.com/arenadotio/ocaml-statsd-client.git","svn_url":"https://github.com/arenadotio/ocaml-statsd-client","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7"},"html":{"href":"https://github.com/arenadotio/ocaml-statsd-client/pull/7"},"issue":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/7"},"comments":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/arenadotio/ocaml-statsd-client/statuses/7c932e7b468aaeb5c3313a5f0ef082b4c2378606"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"acjay"}}