{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/23459","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/23459/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/23459/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/23459/events","html_url":"https://github.com/ceph/ceph/pull/23459","id":348138430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTU5Nzc5","number":23459,"title":"luminous: mgr/MgrClient: Protect daemon_health_metrics","user":{"login":"badone","id":1331115,"node_id":"MDQ6VXNlcjEzMzExMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1331115?v=4","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"labels":[{"id":1005871700,"node_id":"MDU6TGFiZWwxMDA1ODcxNzAw","url":"https://api.github.com/repos/ceph/ceph/labels/12.2.8","name":"12.2.8","color":"fef2c0","default":false},{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":641671496,"node_id":"MDU6TGFiZWw2NDE2NzE0OTY=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-yuri4-testing","name":"wip-yuri4-testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/10","html_url":"https://github.com/ceph/ceph/milestone/10","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/10/labels","id":2578591,"node_id":"MDk6TWlsZXN0b25lMjU3ODU5MQ==","number":10,"title":"luminous","description":"","creator":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":1308,"state":"open","created_at":"2017-06-12T18:30:16Z","updated_at":"2018-08-09T01:20:13Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-08-07T01:57:55Z","updated_at":"2018-08-09T01:37:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/23459","html_url":"https://github.com/ceph/ceph/pull/23459","diff_url":"https://github.com/ceph/ceph/pull/23459.diff","patch_url":"https://github.com/ceph/ceph/pull/23459.patch"},"body":"Without holding the lock update_daemon_health() can race with\r\nsend_report() corrupting the daemon_health_metrics vector.\r\n\r\nFixes: http://tracker.ceph.com/issues/23352\r\n\r\nSigned-off-by: Kjetil Joergensen <kjetil@medallia.com>\r\nSigned-off-by: Brad Hubbard <bhubbard@redhat.com>\r\n(cherry picked from commit 4996506a6b4ab309110039ea29a075f14d09a379)\r\n\r\nConflicts:\r\n\tsrc/mgr/MgrClient.cc Function name is different in luminous\r\n\r\n\r\n<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [x] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/411609104","html_url":"https://github.com/ceph/ceph/pull/23459#issuecomment-411609104","issue_url":"https://api.github.com/repos/ceph/ceph/issues/23459","id":411609104,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYwOTEwNA==","user":{"login":"neha-ojha","id":15874529,"node_id":"MDQ6VXNlcjE1ODc0NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/15874529?v=4","gravatar_id":"","url":"https://api.github.com/users/neha-ojha","html_url":"https://github.com/neha-ojha","followers_url":"https://api.github.com/users/neha-ojha/followers","following_url":"https://api.github.com/users/neha-ojha/following{/other_user}","gists_url":"https://api.github.com/users/neha-ojha/gists{/gist_id}","starred_url":"https://api.github.com/users/neha-ojha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neha-ojha/subscriptions","organizations_url":"https://api.github.com/users/neha-ojha/orgs","repos_url":"https://api.github.com/users/neha-ojha/repos","events_url":"https://api.github.com/users/neha-ojha/events{/privacy}","received_events_url":"https://api.github.com/users/neha-ojha/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T01:37:01Z","updated_at":"2018-08-09T01:37:01Z","author_association":"MEMBER","body":"@yuriw The branch in https://trello.com/c/D7QGdxAl/368-wip-yuri4-testing-2018-08-08-1634-luminous is not in sync with the rados run branch."}}
{"actor":{"display_login":"neha-ojha"}}