{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18881","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18881/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18881/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18881/events","html_url":"https://github.com/magento/magento2/pull/18881","id":374634749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mjg3NTg0","number":18881,"title":"[Backport] fixed Product Advanced Pricing design issue #18775","user":{"login":"gelanivishal","id":12389799,"node_id":"MDQ6VXNlcjEyMzg5Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12389799?v=4","gravatar_id":"","url":"https://api.github.com/users/gelanivishal","html_url":"https://github.com/gelanivishal","followers_url":"https://api.github.com/users/gelanivishal/followers","following_url":"https://api.github.com/users/gelanivishal/following{/other_user}","gists_url":"https://api.github.com/users/gelanivishal/gists{/gist_id}","starred_url":"https://api.github.com/users/gelanivishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelanivishal/subscriptions","organizations_url":"https://api.github.com/users/gelanivishal/orgs","repos_url":"https://api.github.com/users/gelanivishal/repos","events_url":"https://api.github.com/users/gelanivishal/events{/privacy}","received_events_url":"https://api.github.com/users/gelanivishal/received_events","type":"User","site_admin":false},"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":944460665,"node_id":"MDU6TGFiZWw5NDQ0NjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Ui","name":"Component: Ui","color":"7fb703","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-27T11:19:11Z","updated_at":"2018-10-27T11:19:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18881","html_url":"https://github.com/magento/magento2/pull/18881","diff_url":"https://github.com/magento/magento2/pull/18881.diff","patch_url":"https://github.com/magento/magento2/pull/18881.patch"},"body":"### Original PR \r\n#18790\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description (*)\r\nThere was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible=\"$data.labelVisible\" was on child element of the label, because of that parent was still visible even if the label visibility was false.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. magento/magento2#18775: Product Advanced Pricing design issue\r\n\r\n### Manual testing scenarios (*)\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. login magento admin\r\n2. goto catalog products\r\n3: click on Add Product button\r\n4: fill details then click on Advanced Pricing\r\n5: in customer group price click Add\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/433611997","html_url":"https://github.com/magento/magento2/pull/18881#issuecomment-433611997","issue_url":"https://api.github.com/repos/magento/magento2/issues/18881","id":433611997,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYxMTk5Nw==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T11:19:15Z","updated_at":"2018-10-27T11:19:15Z","author_association":"CONTRIBUTOR","body":"Hi @gelanivishal. Thank you for your contribution \nHere is some useful tips how you can test your changes using Magento test environment.\nAdd the comment under your pull request to deploy test or vanilla Magento instance:\n- `@magento-engcom-team give me test instance` - deploy test instance based on PR changes\n- `@magento-engcom-team give me $VERSION instance` - deploy vanilla Magento instance\n\nFor more details, please, review the [Magento Contributor Assistant](https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#contributor-assist) documentation"}}
{"actor":{"display_login":"magento-engcom-team"}}