{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/166197627","pull_request_review_id":94237129,"id":166197627,"diff_hunk":"@@ -215,25 +210,21 @@ def __call__(self, v1, v2):\n                               threshold_factor=1)\n \n \n-\n class FormatterDMS(object):\n-\n     deg_mark = \"^{\\circ}\"\n     min_mark = \"^{\\prime}\"\n     sec_mark = \"^{\\prime\\prime}\"\n \n-    fmt_d = \"$%d\"+deg_mark+\"$\"\n-    fmt_ds = r\"$%d.\\!\\!\"+deg_mark+\"%s$\"\n+    fmt_d = \"$%d\" + deg_mark + \"$\"\n+    fmt_ds = r\"$%d.%s\" + deg_mark + \"$\"\n \n     # %s for signe","path":"lib/mpl_toolkits/axisartist/angle_helper.py","position":51,"original_position":51,"commit_id":"bd36aa32e0279c9c2caa6d40ffff7af783d153c5","original_commit_id":"bd36aa32e0279c9c2caa6d40ffff7af783d153c5","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"I don't know why the e is there.","created_at":"2018-02-06T06:36:26Z","updated_at":"2018-02-06T06:36:26Z","html_url":"https://github.com/matplotlib/matplotlib/pull/7545#discussion_r166197627","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/166197627"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7545#discussion_r166197627"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545"}},"in_reply_to_id":166189271},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545","id":96180988,"html_url":"https://github.com/matplotlib/matplotlib/pull/7545","diff_url":"https://github.com/matplotlib/matplotlib/pull/7545.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/7545.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7545","number":7545,"state":"open","locked":false,"title":"Axisartist testing + bugfixes","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"The `axisartist` toolkit does not appear to have any testing done at all; it was still importing `matplotlib.externals.six`! There were a lot of tests written into the files themselves, so I just pulled them out and made them into real tests. There are some bugfixes in 2316a07cbd467dd41b75d9712668c369582b5c4f, a7dde13c5166dbc97355f02a4a5ebe76e6c6ad84, and 8062fe5135107bd28014bbd1acef52c6aab18db4; not sure if they're worth backporting.\r\n\r\nI also simplified the format of `FormatterDMS`/`FormatterHMS`; it didn't make any sense to me that the decimal place would go before the symbol and the fractional part after.\r\n\r\nThis will likely fail to pass due to some tick clipping bug that I haven't fixed yet; it's also possible that the flaky comparisons will arise here as well. I have an idea of how to fix that, but I thought I'd write the tests first.\r\n","created_at":"2016-12-01T22:10:16Z","updated_at":"2018-02-06T06:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f29423832273363ee3ece9b6e3f2d03298f0fe58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25","html_url":"https://github.com/matplotlib/matplotlib/milestone/25","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25/labels","id":2189521,"number":25,"title":"v2.2","description":"","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":860,"closed_issues":409,"state":"open","created_at":"2016-12-11T20:54:18Z","updated_at":"2018-02-06T05:45:23Z","due_on":"2018-01-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7545/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/bd36aa32e0279c9c2caa6d40ffff7af783d153c5","head":{"label":"QuLogic:axisartist-testing","ref":"axisartist-testing","sha":"bd36aa32e0279c9c2caa6d40ffff7af783d153c5","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"repo":{"id":21548241,"name":"matplotlib","full_name":"QuLogic/matplotlib","owner":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QuLogic/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/QuLogic/matplotlib","forks_url":"https://api.github.com/repos/QuLogic/matplotlib/forks","keys_url":"https://api.github.com/repos/QuLogic/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuLogic/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuLogic/matplotlib/teams","hooks_url":"https://api.github.com/repos/QuLogic/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/QuLogic/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/QuLogic/matplotlib/events","assignees_url":"https://api.github.com/repos/QuLogic/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/QuLogic/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/QuLogic/matplotlib/tags","blobs_url":"https://api.github.com/repos/QuLogic/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuLogic/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuLogic/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuLogic/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuLogic/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/QuLogic/matplotlib/languages","stargazers_url":"https://api.github.com/repos/QuLogic/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/QuLogic/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/QuLogic/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/QuLogic/matplotlib/subscription","commits_url":"https://api.github.com/repos/QuLogic/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuLogic/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuLogic/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuLogic/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuLogic/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/QuLogic/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuLogic/matplotlib/merges","archive_url":"https://api.github.com/repos/QuLogic/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuLogic/matplotlib/downloads","issues_url":"https://api.github.com/repos/QuLogic/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/QuLogic/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/QuLogic/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/QuLogic/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuLogic/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/QuLogic/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/QuLogic/matplotlib/deployments","created_at":"2014-07-06T20:41:46Z","updated_at":"2018-01-21T18:26:22Z","pushed_at":"2018-02-06T06:13:06Z","git_url":"git://github.com/QuLogic/matplotlib.git","ssh_url":"git@github.com:QuLogic/matplotlib.git","clone_url":"https://github.com/QuLogic/matplotlib.git","svn_url":"https://github.com/QuLogic/matplotlib","homepage":"http://matplotlib.org/","size":330931,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"2e83a8a89ecb8bb0d3467ffbe5f6a135ecbbcb49","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-02-06T03:09:56Z","pushed_at":"2018-02-06T05:45:23Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":321943,"stargazers_count":6705,"watchers_count":6705,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3155,"mirror_url":null,"archived":false,"open_issues_count":1352,"license":null,"forks":3155,"open_issues":1352,"watchers":6705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7545"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7545"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7545/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7545/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/bd36aa32e0279c9c2caa6d40ffff7af783d153c5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"QuLogic"}}