{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/991","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/991/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/991/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/991/events","html_url":"https://github.com/singularityware/singularity/issues/991","id":261960807,"number":991,"title":"Image Handler Redundancy","user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-02T00:56:33Z","updated_at":"2018-03-02T16:41:58Z","closed_at":null,"author_association":"OWNER","body":"We have image handlers defined here:\r\n\r\nhttps://github.com/singularityware/singularity/tree/development/libexec/handlers\r\n\r\nand then re-done in build.exec:\r\n\r\nhttps://github.com/singularityware/singularity/blob/development/libexec/cli/build.exec#L183\r\n\r\nmy concern is that there is copy pasted / redundant code, and that the \"same action\" (dumping docker layers) is performed in two different ways - one with permission changes, and one not. I think the files in handlers that are used by image-handler.sh should also be used by build.exec, which means:\r\n\r\n - deciding the appropriate base actions for each\r\n - moving higher level logic / specifics of the caller to the calling script\r\n - having the same file sourced from both places\r\n\r\nOtherwise, over time we will have inconsistent behavior, and a code base that is harder to manage because a change would warrant updates in two+ places."},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/369977423","html_url":"https://github.com/singularityware/singularity/issues/991#issuecomment-369977423","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/991","id":369977423,"user":{"login":"dctrud","id":4522799,"avatar_url":"https://avatars1.githubusercontent.com/u/4522799?v=4","gravatar_id":"","url":"https://api.github.com/users/dctrud","html_url":"https://github.com/dctrud","followers_url":"https://api.github.com/users/dctrud/followers","following_url":"https://api.github.com/users/dctrud/following{/other_user}","gists_url":"https://api.github.com/users/dctrud/gists{/gist_id}","starred_url":"https://api.github.com/users/dctrud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dctrud/subscriptions","organizations_url":"https://api.github.com/users/dctrud/orgs","repos_url":"https://api.github.com/users/dctrud/repos","events_url":"https://api.github.com/users/dctrud/events{/privacy}","received_events_url":"https://api.github.com/users/dctrud/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T16:41:58Z","updated_at":"2018-03-02T16:41:58Z","author_association":"CONTRIBUTOR","body":"Hi @vsoch @GodloveD  - I believe this will be addressed by the Golang builder structure that @bauerm97 has been sketching out for 3.0 - do we need to keep this open to track?"}}
{"actor":{"display_login":"dctrud"}}