{"action":"created","comment":{"url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/comments/231470508","pull_request_review_id":172446264,"id":231470508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ3MDUwOA==","diff_hunk":"@@ -221,7 +221,7 @@\n     },\n     \"ansi-escapes\": {\n       \"version\": \"3.1.0\",\n-      \"resolved\": \"https://registry.npmjs.org/ansi-escapes/-/ansi-escapes-3.1.0.tgz\",\n+      \"resolved\": \"http://registry.npmjs.org/ansi-escapes/-/ansi-escapes-3.1.0.tgz\",","path":"flowauth/frontend/package-lock.json","position":5,"original_position":5,"commit_id":"a9982e734234bfc6550e74c35a0f867cb0d1cf63","original_commit_id":"1560f91b186b8eff462ea390e6d816e3b32c182e","user":{"login":"greenape","id":472828,"node_id":"MDQ6VXNlcjQ3MjgyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/472828?v=4","gravatar_id":"","url":"https://api.github.com/users/greenape","html_url":"https://github.com/greenape","followers_url":"https://api.github.com/users/greenape/followers","following_url":"https://api.github.com/users/greenape/following{/other_user}","gists_url":"https://api.github.com/users/greenape/gists{/gist_id}","starred_url":"https://api.github.com/users/greenape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenape/subscriptions","organizations_url":"https://api.github.com/users/greenape/orgs","repos_url":"https://api.github.com/users/greenape/repos","events_url":"https://api.github.com/users/greenape/events{/privacy}","received_events_url":"https://api.github.com/users/greenape/received_events","type":"User","site_admin":false},"body":"This is a pretty good explainer: https://github.com/npm/npm/issues/16849#issuecomment-312442508 but the short version would seem to be that these links aren't actually used to download the packages, and the protection is afforded via the integrity hash.\r\n\r\nFwiw, there are ~70 http:// links in the lock file before this as well ;)","created_at":"2018-11-07T11:30:14Z","updated_at":"2018-11-07T11:30:15Z","html_url":"https://github.com/Flowminder/FlowKit/pull/28#discussion_r231470508","pull_request_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/comments/231470508"},"html":{"href":"https://github.com/Flowminder/FlowKit/pull/28#discussion_r231470508"},"pull_request":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28"}},"in_reply_to_id":231456360},"pull_request":{"url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28","id":228983498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTgzNDk4","html_url":"https://github.com/Flowminder/FlowKit/pull/28","diff_url":"https://github.com/Flowminder/FlowKit/pull/28.diff","patch_url":"https://github.com/Flowminder/FlowKit/pull/28.patch","issue_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/28","number":28,"state":"open","locked":false,"title":"Use require for logo instead of static serving. Fixes #25","user":{"login":"greenape","id":472828,"node_id":"MDQ6VXNlcjQ3MjgyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/472828?v=4","gravatar_id":"","url":"https://api.github.com/users/greenape","html_url":"https://github.com/greenape","followers_url":"https://api.github.com/users/greenape/followers","following_url":"https://api.github.com/users/greenape/following{/other_user}","gists_url":"https://api.github.com/users/greenape/gists{/gist_id}","starred_url":"https://api.github.com/users/greenape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenape/subscriptions","organizations_url":"https://api.github.com/users/greenape/orgs","repos_url":"https://api.github.com/users/greenape/repos","events_url":"https://api.github.com/users/greenape/events{/privacy}","received_events_url":"https://api.github.com/users/greenape/received_events","type":"User","site_admin":false},"body":"Closes #25\r\n\r\n### I have:\r\n\r\n- [ ] Formatted any Python files with [black](https://github.com/ambv/black)\r\n- [x] Brought the branch up to date with master\r\n- [x] Added any relevant Github labels\r\n- [ ] Added tests for any new additions\r\n- [ ] Added or updated any relevant documentation\r\n- [ ] Added an Architectural Decision Record (ADR), if appropriate\r\n- [ ] Added an [MPLv2 License Header](https://www.mozilla.org/en-US/MPL/headers/) if appropriate \r\n\r\n### Description\r\n\r\nThis makes the login screen logo be properly included in the build process, rather than stuck in a location not accessible via the web server when running in the docker container.","created_at":"2018-11-07T10:35:34Z","updated_at":"2018-11-07T11:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be79635859c89a783902ac815bc033bf86b6b748","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1117933364,"node_id":"MDU6TGFiZWwxMTE3OTMzMzY0","url":"https://api.github.com/repos/Flowminder/FlowKit/labels/FlowAuth","name":"FlowAuth","color":"f4eb6b","default":false},{"id":1112016359,"node_id":"MDU6TGFiZWwxMTEyMDE2MzU5","url":"https://api.github.com/repos/Flowminder/FlowKit/labels/bug","name":"bug","color":"d73a4a","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/28/comments","statuses_url":"https://api.github.com/repos/Flowminder/FlowKit/statuses/a9982e734234bfc6550e74c35a0f867cb0d1cf63","head":{"label":"Flowminder:fix-logo","ref":"fix-logo","sha":"a9982e734234bfc6550e74c35a0f867cb0d1cf63","user":{"login":"Flowminder","id":14016903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/14016903?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowminder","html_url":"https://github.com/Flowminder","followers_url":"https://api.github.com/users/Flowminder/followers","following_url":"https://api.github.com/users/Flowminder/following{/other_user}","gists_url":"https://api.github.com/users/Flowminder/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowminder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowminder/subscriptions","organizations_url":"https://api.github.com/users/Flowminder/orgs","repos_url":"https://api.github.com/users/Flowminder/repos","events_url":"https://api.github.com/users/Flowminder/events{/privacy}","received_events_url":"https://api.github.com/users/Flowminder/received_events","type":"Organization","site_admin":false},"repo":{"id":155638125,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2MzgxMjU=","name":"FlowKit","full_name":"Flowminder/FlowKit","private":false,"owner":{"login":"Flowminder","id":14016903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/14016903?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowminder","html_url":"https://github.com/Flowminder","followers_url":"https://api.github.com/users/Flowminder/followers","following_url":"https://api.github.com/users/Flowminder/following{/other_user}","gists_url":"https://api.github.com/users/Flowminder/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowminder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowminder/subscriptions","organizations_url":"https://api.github.com/users/Flowminder/orgs","repos_url":"https://api.github.com/users/Flowminder/repos","events_url":"https://api.github.com/users/Flowminder/events{/privacy}","received_events_url":"https://api.github.com/users/Flowminder/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Flowminder/FlowKit","description":"FlowKit: Flowminder CDR analytics toolkit","fork":false,"url":"https://api.github.com/repos/Flowminder/FlowKit","forks_url":"https://api.github.com/repos/Flowminder/FlowKit/forks","keys_url":"https://api.github.com/repos/Flowminder/FlowKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flowminder/FlowKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flowminder/FlowKit/teams","hooks_url":"https://api.github.com/repos/Flowminder/FlowKit/hooks","issue_events_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/events{/number}","events_url":"https://api.github.com/repos/Flowminder/FlowKit/events","assignees_url":"https://api.github.com/repos/Flowminder/FlowKit/assignees{/user}","branches_url":"https://api.github.com/repos/Flowminder/FlowKit/branches{/branch}","tags_url":"https://api.github.com/repos/Flowminder/FlowKit/tags","blobs_url":"https://api.github.com/repos/Flowminder/FlowKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flowminder/FlowKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flowminder/FlowKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flowminder/FlowKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flowminder/FlowKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Flowminder/FlowKit/languages","stargazers_url":"https://api.github.com/repos/Flowminder/FlowKit/stargazers","contributors_url":"https://api.github.com/repos/Flowminder/FlowKit/contributors","subscribers_url":"https://api.github.com/repos/Flowminder/FlowKit/subscribers","subscription_url":"https://api.github.com/repos/Flowminder/FlowKit/subscription","commits_url":"https://api.github.com/repos/Flowminder/FlowKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flowminder/FlowKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flowminder/FlowKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flowminder/FlowKit/contents/{+path}","compare_url":"https://api.github.com/repos/Flowminder/FlowKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flowminder/FlowKit/merges","archive_url":"https://api.github.com/repos/Flowminder/FlowKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flowminder/FlowKit/downloads","issues_url":"https://api.github.com/repos/Flowminder/FlowKit/issues{/number}","pulls_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Flowminder/FlowKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Flowminder/FlowKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flowminder/FlowKit/labels{/name}","releases_url":"https://api.github.com/repos/Flowminder/FlowKit/releases{/id}","deployments_url":"https://api.github.com/repos/Flowminder/FlowKit/deployments","created_at":"2018-10-31T23:59:44Z","updated_at":"2018-11-07T11:14:20Z","pushed_at":"2018-11-07T11:26:49Z","git_url":"git://github.com/Flowminder/FlowKit.git","ssh_url":"git@github.com:Flowminder/FlowKit.git","clone_url":"https://github.com/Flowminder/FlowKit.git","svn_url":"https://github.com/Flowminder/FlowKit","homepage":"https://flowminder.github.io/FlowKit/","size":88767,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":6,"watchers":9,"default_branch":"master"}},"base":{"label":"Flowminder:master","ref":"master","sha":"1f0cd37b68c6190080e1a03c62a1ab949896a45a","user":{"login":"Flowminder","id":14016903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/14016903?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowminder","html_url":"https://github.com/Flowminder","followers_url":"https://api.github.com/users/Flowminder/followers","following_url":"https://api.github.com/users/Flowminder/following{/other_user}","gists_url":"https://api.github.com/users/Flowminder/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowminder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowminder/subscriptions","organizations_url":"https://api.github.com/users/Flowminder/orgs","repos_url":"https://api.github.com/users/Flowminder/repos","events_url":"https://api.github.com/users/Flowminder/events{/privacy}","received_events_url":"https://api.github.com/users/Flowminder/received_events","type":"Organization","site_admin":false},"repo":{"id":155638125,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2MzgxMjU=","name":"FlowKit","full_name":"Flowminder/FlowKit","private":false,"owner":{"login":"Flowminder","id":14016903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/14016903?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowminder","html_url":"https://github.com/Flowminder","followers_url":"https://api.github.com/users/Flowminder/followers","following_url":"https://api.github.com/users/Flowminder/following{/other_user}","gists_url":"https://api.github.com/users/Flowminder/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowminder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowminder/subscriptions","organizations_url":"https://api.github.com/users/Flowminder/orgs","repos_url":"https://api.github.com/users/Flowminder/repos","events_url":"https://api.github.com/users/Flowminder/events{/privacy}","received_events_url":"https://api.github.com/users/Flowminder/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Flowminder/FlowKit","description":"FlowKit: Flowminder CDR analytics toolkit","fork":false,"url":"https://api.github.com/repos/Flowminder/FlowKit","forks_url":"https://api.github.com/repos/Flowminder/FlowKit/forks","keys_url":"https://api.github.com/repos/Flowminder/FlowKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flowminder/FlowKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flowminder/FlowKit/teams","hooks_url":"https://api.github.com/repos/Flowminder/FlowKit/hooks","issue_events_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/events{/number}","events_url":"https://api.github.com/repos/Flowminder/FlowKit/events","assignees_url":"https://api.github.com/repos/Flowminder/FlowKit/assignees{/user}","branches_url":"https://api.github.com/repos/Flowminder/FlowKit/branches{/branch}","tags_url":"https://api.github.com/repos/Flowminder/FlowKit/tags","blobs_url":"https://api.github.com/repos/Flowminder/FlowKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flowminder/FlowKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flowminder/FlowKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flowminder/FlowKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flowminder/FlowKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Flowminder/FlowKit/languages","stargazers_url":"https://api.github.com/repos/Flowminder/FlowKit/stargazers","contributors_url":"https://api.github.com/repos/Flowminder/FlowKit/contributors","subscribers_url":"https://api.github.com/repos/Flowminder/FlowKit/subscribers","subscription_url":"https://api.github.com/repos/Flowminder/FlowKit/subscription","commits_url":"https://api.github.com/repos/Flowminder/FlowKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flowminder/FlowKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flowminder/FlowKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flowminder/FlowKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flowminder/FlowKit/contents/{+path}","compare_url":"https://api.github.com/repos/Flowminder/FlowKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flowminder/FlowKit/merges","archive_url":"https://api.github.com/repos/Flowminder/FlowKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flowminder/FlowKit/downloads","issues_url":"https://api.github.com/repos/Flowminder/FlowKit/issues{/number}","pulls_url":"https://api.github.com/repos/Flowminder/FlowKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Flowminder/FlowKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Flowminder/FlowKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flowminder/FlowKit/labels{/name}","releases_url":"https://api.github.com/repos/Flowminder/FlowKit/releases{/id}","deployments_url":"https://api.github.com/repos/Flowminder/FlowKit/deployments","created_at":"2018-10-31T23:59:44Z","updated_at":"2018-11-07T11:14:20Z","pushed_at":"2018-11-07T11:26:49Z","git_url":"git://github.com/Flowminder/FlowKit.git","ssh_url":"git@github.com:Flowminder/FlowKit.git","clone_url":"https://github.com/Flowminder/FlowKit.git","svn_url":"https://github.com/Flowminder/FlowKit","homepage":"https://flowminder.github.io/FlowKit/","size":88767,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28"},"html":{"href":"https://github.com/Flowminder/FlowKit/pull/28"},"issue":{"href":"https://api.github.com/repos/Flowminder/FlowKit/issues/28"},"comments":{"href":"https://api.github.com/repos/Flowminder/FlowKit/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Flowminder/FlowKit/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Flowminder/FlowKit/statuses/a9982e734234bfc6550e74c35a0f867cb0d1cf63"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"greenape"}}