{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/comments/223259207","pull_request_review_id":162340766,"id":223259207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzI1OTIwNw==","diff_hunk":"@@ -8,7 +8,32 @@\n # The directory has to be writeable for the user that the container is running\n # under.\n \n-#NOTE:  periodically check https://ce-gitlab.usersys.redhat.com/ce/jboss-dockerfiles/blob/develop/scripts/os-java-run/added/java-default-options for updates\n+# NOTE:  periodically check https://ce-gitlab.usersys.redhat.com/ce/jboss-dockerfiles/blob/develop/scripts/os-java-run/added/java-default-options for updates\n+\n+validateConnection() {\n+  i=1\n+  echo \"INFO: $(date +%T)[$i]: Checking connection to $JENKINS_HOSTNAME\"\n+  until curl -L --max-time $INTERVAL --connect-timeout $INTERVAL \"$JENKINS_HOSTNAME\"; do","path":"slave-base/contrib/bin/run-jnlp-client","position":10,"original_position":10,"commit_id":"28db16a46d746811612e45442281c5498dd0b72f","original_commit_id":"28db16a46d746811612e45442281c5498dd0b72f","user":{"login":"sthaha","id":3005132,"node_id":"MDQ6VXNlcjMwMDUxMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"body":"JENKINS_URL instead of hostname","created_at":"2018-10-08T06:42:31Z","updated_at":"2018-10-08T06:42:31Z","html_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47#discussion_r223259207","pull_request_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/comments/223259207"},"html":{"href":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47#discussion_r223259207"},"pull_request":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47","id":221002544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDAyNTQ0","html_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47","diff_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47.diff","patch_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47.patch","issue_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/47","number":47,"state":"open","locked":false,"title":"Issue #4007 Check if master is reachable","user":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"body":"Due to OpenShift networking issue, sometime pods cannot reach each\r\nothers. This leads to a lot of problems.\r\n\r\nIn this particular case, if slave and master jenkins pods can't reach\r\neach others, it would make us believe us that no slave pod was created,\r\nresulting into trying to spin up a new slave pod. Since,\r\nkubernetes-client doesn't clean up pods reliably, we would end up with\r\ntoo many pods.\r\n\r\nSo, we check if master is reachable from slave. If not, we exit, thus\r\navoiding a situation with too many pods.","created_at":"2018-10-08T04:42:48Z","updated_at":"2018-10-08T06:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9d5a3b17bef585d00dcb2cde567a0757d3dca1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47/commits","review_comments_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47/comments","review_comment_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/47/comments","statuses_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/statuses/28db16a46d746811612e45442281c5498dd0b72f","head":{"label":"kishansagathiya:issue_4007","ref":"issue_4007","sha":"28db16a46d746811612e45442281c5498dd0b72f","user":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"repo":{"id":152019528,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwMTk1Mjg=","name":"jenkins-openshift-base","full_name":"kishansagathiya/jenkins-openshift-base","private":false,"owner":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kishansagathiya/jenkins-openshift-base","description":null,"fork":true,"url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base","forks_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/forks","keys_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/teams","hooks_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/hooks","issue_events_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/issues/events{/number}","events_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/events","assignees_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/assignees{/user}","branches_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/branches{/branch}","tags_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/tags","blobs_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/statuses/{sha}","languages_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/languages","stargazers_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/stargazers","contributors_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/contributors","subscribers_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/subscribers","subscription_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/subscription","commits_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/contents/{+path}","compare_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/merges","archive_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/downloads","issues_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/issues{/number}","pulls_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/pulls{/number}","milestones_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/milestones{/number}","notifications_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/labels{/name}","releases_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/releases{/id}","deployments_url":"https://api.github.com/repos/kishansagathiya/jenkins-openshift-base/deployments","created_at":"2018-10-08T04:42:07Z","updated_at":"2018-10-08T04:42:09Z","pushed_at":"2018-10-08T06:39:10Z","git_url":"git://github.com/kishansagathiya/jenkins-openshift-base.git","ssh_url":"git@github.com:kishansagathiya/jenkins-openshift-base.git","clone_url":"https://github.com/kishansagathiya/jenkins-openshift-base.git","svn_url":"https://github.com/kishansagathiya/jenkins-openshift-base","homepage":null,"size":3172,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-jenkins:master","ref":"master","sha":"5ff927d8786e9e43ed629236e932fe034e93958d","user":{"login":"fabric8-jenkins","id":32307697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzA3Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/32307697?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-jenkins","html_url":"https://github.com/fabric8-jenkins","followers_url":"https://api.github.com/users/fabric8-jenkins/followers","following_url":"https://api.github.com/users/fabric8-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-jenkins/subscriptions","organizations_url":"https://api.github.com/users/fabric8-jenkins/orgs","repos_url":"https://api.github.com/users/fabric8-jenkins/repos","events_url":"https://api.github.com/users/fabric8-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-jenkins/received_events","type":"Organization","site_admin":false},"repo":{"id":88973843,"node_id":"MDEwOlJlcG9zaXRvcnk4ODk3Mzg0Mw==","name":"jenkins-openshift-base","full_name":"fabric8-jenkins/jenkins-openshift-base","private":false,"owner":{"login":"fabric8-jenkins","id":32307697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzA3Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/32307697?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-jenkins","html_url":"https://github.com/fabric8-jenkins","followers_url":"https://api.github.com/users/fabric8-jenkins/followers","following_url":"https://api.github.com/users/fabric8-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-jenkins/subscriptions","organizations_url":"https://api.github.com/users/fabric8-jenkins/orgs","repos_url":"https://api.github.com/users/fabric8-jenkins/repos","events_url":"https://api.github.com/users/fabric8-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-jenkins/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base","description":null,"fork":true,"url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base","forks_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/forks","keys_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/teams","hooks_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/hooks","issue_events_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/events","assignees_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/tags","blobs_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/languages","stargazers_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/stargazers","contributors_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/contributors","subscribers_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/subscribers","subscription_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/subscription","commits_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/merges","archive_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/downloads","issues_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/deployments","created_at":"2017-04-21T10:43:24Z","updated_at":"2018-10-05T14:22:25Z","pushed_at":"2018-10-08T06:39:12Z","git_url":"git://github.com/fabric8-jenkins/jenkins-openshift-base.git","ssh_url":"git@github.com:fabric8-jenkins/jenkins-openshift-base.git","clone_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base.git","svn_url":"https://github.com/fabric8-jenkins/jenkins-openshift-base","homepage":null,"size":3173,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":12,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47"},"html":{"href":"https://github.com/fabric8-jenkins/jenkins-openshift-base/pull/47"},"issue":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/47"},"comments":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-jenkins/jenkins-openshift-base/statuses/28db16a46d746811612e45442281c5498dd0b72f"}},"author_association":"NONE"}}
{"actor":{"display_login":"sthaha"}}