{"action":"created","comment":{"url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/comments/205971129","pull_request_review_id":141344740,"id":205971129,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk3MTEyOQ==","diff_hunk":"@@ -49,19 +50,22 @@ export class AddressMapper {\n     )\n   }\n \n-  private _signIdentityMapping(from: Address, to: Address, privateKey: Uint8Array) {\n-    const hash = keccak256([from.toString(), to.toString()])\n-    return ecsign(hash, privateKey)\n-  }\n-\n-  async addIdentityMapping(from: Address, to: Address, privateKey: Uint8Array) {\n+  async addIdentityMapping(from: Address, to: Address, web3: Web3, ethAddress: string) {","path":"src/address_mapper.ts","position":null,"original_position":20,"commit_id":"a25d3e7b83120e51c1d0302eb88ffe2024e4b43a","original_commit_id":"a25d3e7b83120e51c1d0302eb88ffe2024e4b43a","user":{"login":"enlight","id":233003,"node_id":"MDQ6VXNlcjIzMzAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/233003?v=4","gravatar_id":"","url":"https://api.github.com/users/enlight","html_url":"https://github.com/enlight","followers_url":"https://api.github.com/users/enlight/followers","following_url":"https://api.github.com/users/enlight/following{/other_user}","gists_url":"https://api.github.com/users/enlight/gists{/gist_id}","starred_url":"https://api.github.com/users/enlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enlight/subscriptions","organizations_url":"https://api.github.com/users/enlight/orgs","repos_url":"https://api.github.com/users/enlight/repos","events_url":"https://api.github.com/users/enlight/events{/privacy}","received_events_url":"https://api.github.com/users/enlight/received_events","type":"User","site_admin":false},"body":"A `Web3Signer` instance should be passed in as a parameter, you shouldn't create it in here.","created_at":"2018-07-29T12:05:47Z","updated_at":"2018-07-29T12:14:27Z","html_url":"https://github.com/loomnetwork/loom-js/pull/69#discussion_r205971129","pull_request_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/comments/205971129"},"html":{"href":"https://github.com/loomnetwork/loom-js/pull/69#discussion_r205971129"},"pull_request":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69","id":204597359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTk3MzU5","html_url":"https://github.com/loomnetwork/loom-js/pull/69","diff_url":"https://github.com/loomnetwork/loom-js/pull/69.diff","patch_url":"https://github.com/loomnetwork/loom-js/pull/69.patch","issue_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/69","number":69,"state":"open","locked":false,"title":"[WIP] Implementing adding address","user":{"login":"eduardonunesp","id":582516,"node_id":"MDQ6VXNlcjU4MjUxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/582516?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardonunesp","html_url":"https://github.com/eduardonunesp","followers_url":"https://api.github.com/users/eduardonunesp/followers","following_url":"https://api.github.com/users/eduardonunesp/following{/other_user}","gists_url":"https://api.github.com/users/eduardonunesp/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardonunesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardonunesp/subscriptions","organizations_url":"https://api.github.com/users/eduardonunesp/orgs","repos_url":"https://api.github.com/users/eduardonunesp/repos","events_url":"https://api.github.com/users/eduardonunesp/events{/privacy}","received_events_url":"https://api.github.com/users/eduardonunesp/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-28T15:16:44Z","updated_at":"2018-07-29T12:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"394eb775c040b70c444e36889a22418e92ecfeda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69/commits","review_comments_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69/comments","review_comment_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/69/comments","statuses_url":"https://api.github.com/repos/loomnetwork/loom-js/statuses/a25d3e7b83120e51c1d0302eb88ffe2024e4b43a","head":{"label":"loomnetwork:address-mapper","ref":"address-mapper","sha":"a25d3e7b83120e51c1d0302eb88ffe2024e4b43a","user":{"login":"loomnetwork","id":32244595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ0NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32244595?v=4","gravatar_id":"","url":"https://api.github.com/users/loomnetwork","html_url":"https://github.com/loomnetwork","followers_url":"https://api.github.com/users/loomnetwork/followers","following_url":"https://api.github.com/users/loomnetwork/following{/other_user}","gists_url":"https://api.github.com/users/loomnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/loomnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomnetwork/subscriptions","organizations_url":"https://api.github.com/users/loomnetwork/orgs","repos_url":"https://api.github.com/users/loomnetwork/repos","events_url":"https://api.github.com/users/loomnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/loomnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":119220133,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkyMjAxMzM=","name":"loom-js","full_name":"loomnetwork/loom-js","owner":{"login":"loomnetwork","id":32244595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ0NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32244595?v=4","gravatar_id":"","url":"https://api.github.com/users/loomnetwork","html_url":"https://github.com/loomnetwork","followers_url":"https://api.github.com/users/loomnetwork/followers","following_url":"https://api.github.com/users/loomnetwork/following{/other_user}","gists_url":"https://api.github.com/users/loomnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/loomnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomnetwork/subscriptions","organizations_url":"https://api.github.com/users/loomnetwork/orgs","repos_url":"https://api.github.com/users/loomnetwork/repos","events_url":"https://api.github.com/users/loomnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/loomnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomnetwork/loom-js","description":"JS library for building browser apps & NodeJS services that interact with Loom DAppChains","fork":false,"url":"https://api.github.com/repos/loomnetwork/loom-js","forks_url":"https://api.github.com/repos/loomnetwork/loom-js/forks","keys_url":"https://api.github.com/repos/loomnetwork/loom-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomnetwork/loom-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomnetwork/loom-js/teams","hooks_url":"https://api.github.com/repos/loomnetwork/loom-js/hooks","issue_events_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/events{/number}","events_url":"https://api.github.com/repos/loomnetwork/loom-js/events","assignees_url":"https://api.github.com/repos/loomnetwork/loom-js/assignees{/user}","branches_url":"https://api.github.com/repos/loomnetwork/loom-js/branches{/branch}","tags_url":"https://api.github.com/repos/loomnetwork/loom-js/tags","blobs_url":"https://api.github.com/repos/loomnetwork/loom-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomnetwork/loom-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomnetwork/loom-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomnetwork/loom-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomnetwork/loom-js/statuses/{sha}","languages_url":"https://api.github.com/repos/loomnetwork/loom-js/languages","stargazers_url":"https://api.github.com/repos/loomnetwork/loom-js/stargazers","contributors_url":"https://api.github.com/repos/loomnetwork/loom-js/contributors","subscribers_url":"https://api.github.com/repos/loomnetwork/loom-js/subscribers","subscription_url":"https://api.github.com/repos/loomnetwork/loom-js/subscription","commits_url":"https://api.github.com/repos/loomnetwork/loom-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomnetwork/loom-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomnetwork/loom-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomnetwork/loom-js/contents/{+path}","compare_url":"https://api.github.com/repos/loomnetwork/loom-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomnetwork/loom-js/merges","archive_url":"https://api.github.com/repos/loomnetwork/loom-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomnetwork/loom-js/downloads","issues_url":"https://api.github.com/repos/loomnetwork/loom-js/issues{/number}","pulls_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls{/number}","milestones_url":"https://api.github.com/repos/loomnetwork/loom-js/milestones{/number}","notifications_url":"https://api.github.com/repos/loomnetwork/loom-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomnetwork/loom-js/labels{/name}","releases_url":"https://api.github.com/repos/loomnetwork/loom-js/releases{/id}","deployments_url":"https://api.github.com/repos/loomnetwork/loom-js/deployments","created_at":"2018-01-28T02:15:06Z","updated_at":"2018-07-22T03:28:28Z","pushed_at":"2018-07-29T11:28:28Z","git_url":"git://github.com/loomnetwork/loom-js.git","ssh_url":"git@github.com:loomnetwork/loom-js.git","clone_url":"https://github.com/loomnetwork/loom-js.git","svn_url":"https://github.com/loomnetwork/loom-js","homepage":"https://loomx.io","size":415,"stargazers_count":101,"watchers_count":101,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":12,"watchers":101,"default_branch":"master"}},"base":{"label":"loomnetwork:master","ref":"master","sha":"7eb3dd946203be30ea4689c0be057a8218d845a9","user":{"login":"loomnetwork","id":32244595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ0NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32244595?v=4","gravatar_id":"","url":"https://api.github.com/users/loomnetwork","html_url":"https://github.com/loomnetwork","followers_url":"https://api.github.com/users/loomnetwork/followers","following_url":"https://api.github.com/users/loomnetwork/following{/other_user}","gists_url":"https://api.github.com/users/loomnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/loomnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomnetwork/subscriptions","organizations_url":"https://api.github.com/users/loomnetwork/orgs","repos_url":"https://api.github.com/users/loomnetwork/repos","events_url":"https://api.github.com/users/loomnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/loomnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":119220133,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkyMjAxMzM=","name":"loom-js","full_name":"loomnetwork/loom-js","owner":{"login":"loomnetwork","id":32244595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ0NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32244595?v=4","gravatar_id":"","url":"https://api.github.com/users/loomnetwork","html_url":"https://github.com/loomnetwork","followers_url":"https://api.github.com/users/loomnetwork/followers","following_url":"https://api.github.com/users/loomnetwork/following{/other_user}","gists_url":"https://api.github.com/users/loomnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/loomnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomnetwork/subscriptions","organizations_url":"https://api.github.com/users/loomnetwork/orgs","repos_url":"https://api.github.com/users/loomnetwork/repos","events_url":"https://api.github.com/users/loomnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/loomnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomnetwork/loom-js","description":"JS library for building browser apps & NodeJS services that interact with Loom DAppChains","fork":false,"url":"https://api.github.com/repos/loomnetwork/loom-js","forks_url":"https://api.github.com/repos/loomnetwork/loom-js/forks","keys_url":"https://api.github.com/repos/loomnetwork/loom-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomnetwork/loom-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomnetwork/loom-js/teams","hooks_url":"https://api.github.com/repos/loomnetwork/loom-js/hooks","issue_events_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/events{/number}","events_url":"https://api.github.com/repos/loomnetwork/loom-js/events","assignees_url":"https://api.github.com/repos/loomnetwork/loom-js/assignees{/user}","branches_url":"https://api.github.com/repos/loomnetwork/loom-js/branches{/branch}","tags_url":"https://api.github.com/repos/loomnetwork/loom-js/tags","blobs_url":"https://api.github.com/repos/loomnetwork/loom-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomnetwork/loom-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomnetwork/loom-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomnetwork/loom-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomnetwork/loom-js/statuses/{sha}","languages_url":"https://api.github.com/repos/loomnetwork/loom-js/languages","stargazers_url":"https://api.github.com/repos/loomnetwork/loom-js/stargazers","contributors_url":"https://api.github.com/repos/loomnetwork/loom-js/contributors","subscribers_url":"https://api.github.com/repos/loomnetwork/loom-js/subscribers","subscription_url":"https://api.github.com/repos/loomnetwork/loom-js/subscription","commits_url":"https://api.github.com/repos/loomnetwork/loom-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomnetwork/loom-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomnetwork/loom-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomnetwork/loom-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomnetwork/loom-js/contents/{+path}","compare_url":"https://api.github.com/repos/loomnetwork/loom-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomnetwork/loom-js/merges","archive_url":"https://api.github.com/repos/loomnetwork/loom-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomnetwork/loom-js/downloads","issues_url":"https://api.github.com/repos/loomnetwork/loom-js/issues{/number}","pulls_url":"https://api.github.com/repos/loomnetwork/loom-js/pulls{/number}","milestones_url":"https://api.github.com/repos/loomnetwork/loom-js/milestones{/number}","notifications_url":"https://api.github.com/repos/loomnetwork/loom-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomnetwork/loom-js/labels{/name}","releases_url":"https://api.github.com/repos/loomnetwork/loom-js/releases{/id}","deployments_url":"https://api.github.com/repos/loomnetwork/loom-js/deployments","created_at":"2018-01-28T02:15:06Z","updated_at":"2018-07-22T03:28:28Z","pushed_at":"2018-07-29T11:28:28Z","git_url":"git://github.com/loomnetwork/loom-js.git","ssh_url":"git@github.com:loomnetwork/loom-js.git","clone_url":"https://github.com/loomnetwork/loom-js.git","svn_url":"https://github.com/loomnetwork/loom-js","homepage":"https://loomx.io","size":415,"stargazers_count":101,"watchers_count":101,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":12,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69"},"html":{"href":"https://github.com/loomnetwork/loom-js/pull/69"},"issue":{"href":"https://api.github.com/repos/loomnetwork/loom-js/issues/69"},"comments":{"href":"https://api.github.com/repos/loomnetwork/loom-js/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loomnetwork/loom-js/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/loomnetwork/loom-js/statuses/a25d3e7b83120e51c1d0302eb88ffe2024e4b43a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"enlight"}}