{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/183753253","pull_request_review_id":114810858,"id":183753253,"diff_hunk":"@@ -75,11 +103,7 @@ typedef NS_ENUM(NSInteger, TSGroupMetaMessage) {\n + (instancetype)outgoingMessageInThread:(nullable TSThread *)thread\n                        groupMetaMessage:(TSGroupMetaMessage)groupMetaMessage;\n \n-@property (atomic, readonly) TSOutgoingMessageState messageState;\n-\n-// The message has been sent to the service and received by at least one recipient client.\n-// A recipient may have more than one client, and group message may have more than one recipient.\n-@property (atomic, readonly) BOOL wasDelivered;\n+@property (readonly) TSOutgoingMessageState messageState;","path":"SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h","position":63,"original_position":63,"commit_id":"97ba0470430b4d0baaf07ad4e4b46e89e109d10d","original_commit_id":"97ba0470430b4d0baaf07ad4e4b46e89e109d10d","user":{"login":"charlesmchen-signal","id":36971147,"avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"This is now just a property calculated on the fly.  We consult this property a lot, so I might return to backing with an ivar that serves as a cache.","created_at":"2018-04-24T14:31:08Z","updated_at":"2018-04-24T14:31:08Z","html_url":"https://github.com/signalapp/Signal-iOS/pull/3331#discussion_r183753253","pull_request_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/183753253"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3331#discussion_r183753253"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331"}}},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331","id":183752452,"html_url":"https://github.com/signalapp/Signal-iOS/pull/3331","diff_url":"https://github.com/signalapp/Signal-iOS/pull/3331.diff","patch_url":"https://github.com/signalapp/Signal-iOS/pull/3331.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3331","number":3331,"state":"open","locked":false,"title":"Charlesmchen/outgoing message state","user":{"login":"charlesmchen-signal","id":36971147,"avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"PTAL @michaelkirk ","created_at":"2018-04-24T14:18:03Z","updated_at":"2018-04-24T14:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3331/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/97ba0470430b4d0baaf07ad4e4b46e89e109d10d","head":{"label":"signalapp:charlesmchen/outgoingMessageState","ref":"charlesmchen/outgoingMessageState","sha":"97ba0470430b4d0baaf07ad4e4b46e89e109d10d","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-04-24T13:11:42Z","pushed_at":"2018-04-24T14:24:41Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":467301,"stargazers_count":3365,"watchers_count":3365,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":795,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":795,"open_issues":382,"watchers":3365,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"e66e5b0b97ab8d99c2fa2a12c38794993fc0fb18","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-04-24T13:11:42Z","pushed_at":"2018-04-24T14:24:41Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":467301,"stargazers_count":3365,"watchers_count":3365,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":795,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":795,"open_issues":382,"watchers":3365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3331"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3331"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3331/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3331/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/97ba0470430b4d0baaf07ad4e4b46e89e109d10d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charlesmchen-signal"}}