{"action":"opened","issue":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/3362","repository_url":"https://api.github.com/repos/danielgindi/Charts","labels_url":"https://api.github.com/repos/danielgindi/Charts/issues/3362/labels{/name}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/3362/comments","events_url":"https://api.github.com/repos/danielgindi/Charts/issues/3362/events","html_url":"https://github.com/danielgindi/Charts/issues/3362","id":308154811,"number":3362,"title":"inconsistent include of UIKit vs AppKit","user":{"login":"solas","id":264101,"avatar_url":"https://avatars2.githubusercontent.com/u/264101?v=4","gravatar_id":"","url":"https://api.github.com/users/solas","html_url":"https://github.com/solas","followers_url":"https://api.github.com/users/solas/followers","following_url":"https://api.github.com/users/solas/following{/other_user}","gists_url":"https://api.github.com/users/solas/gists{/gist_id}","starred_url":"https://api.github.com/users/solas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solas/subscriptions","organizations_url":"https://api.github.com/users/solas/orgs","repos_url":"https://api.github.com/users/solas/repos","events_url":"https://api.github.com/users/solas/events{/privacy}","received_events_url":"https://api.github.com/users/solas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-23T19:35:42Z","updated_at":"2018-03-23T19:35:42Z","closed_at":null,"author_association":"NONE","body":"* [x ] I've read, understood, and done my best to follow the [*CONTRIBUTING guidelines](https://github.com/jjatie/Charts/blob/master/CONTRIBUTING.md).\r\n\r\n## What did you do?\r\n\r\nIt appears this project grabs many UI object definitions (e.g. NSTextAlignment) through Charts.h, yet includes for iOS UIKit separately in many files:\r\n\r\n#if !os(OSX)\r\n    import UIKit\r\n#endif \r\n\r\nEither Charts.h should include all, else the above swift import should be changed to the following, and perhaps imported in a separate included swift module to avoid duplication:\r\n\r\n#if !os(OSX)\r\n    import UIKit\r\n#else\r\n    import AppKit\r\n#endif\r\n\r\n## Charts Environment\r\n\r\n**Charts version/Branch/Commit Number:**\r\n3.1\r\n**Xcode version:**\r\n9.2\r\n**Swift version:**\r\n4.0\r\n**Platform(s) running Charts:**\r\nmacOS\r\n**macOS version running Xcode:**\r\n10.13.3\r\n\r\n"}}
{"actor":{"display_login":"solas"}}