{"action":"closed","number":1888,"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1888","id":203408929,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDA4OTI5","html_url":"https://github.com/alibaba/pouch/pull/1888","diff_url":"https://github.com/alibaba/pouch/pull/1888.diff","patch_url":"https://github.com/alibaba/pouch/pull/1888.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1888","number":1888,"state":"closed","locked":false,"title":"Unit test added for 'getConflictCongigurations' method","user":{"login":"sunzeyucmu","id":30520912,"node_id":"MDQ6VXNlcjMwNTIwOTEy","avatar_url":"https://avatars0.githubusercontent.com/u/30520912?v=4","gravatar_id":"","url":"https://api.github.com/users/sunzeyucmu","html_url":"https://github.com/sunzeyucmu","followers_url":"https://api.github.com/users/sunzeyucmu/followers","following_url":"https://api.github.com/users/sunzeyucmu/following{/other_user}","gists_url":"https://api.github.com/users/sunzeyucmu/gists{/gist_id}","starred_url":"https://api.github.com/users/sunzeyucmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunzeyucmu/subscriptions","organizations_url":"https://api.github.com/users/sunzeyucmu/orgs","repos_url":"https://api.github.com/users/sunzeyucmu/repos","events_url":"https://api.github.com/users/sunzeyucmu/events{/privacy}","received_events_url":"https://api.github.com/users/sunzeyucmu/received_events","type":"User","site_admin":false},"body":"<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nUnit test added for 'getConflictCongigurations' method in daemon/config package\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\nfixes #1759\r\n\r\n### Ⅲ. Describe how you did it\r\n/* 1. With Same Flag name(Same Value), Conflict */\r\n/* 2. With Same Flag name(Different Value), Conflict */\r\n/* 3. Two Configs's flag Intersects */\r\n/* 4. If commandLineFlagsSet contains 'Slice' type */\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n'Baiji' Group 1 (Another PR to fix pre PR under issue #1759)\r\n\r\n","created_at":"2018-07-24T04:47:30Z","updated_at":"2018-07-24T10:19:05Z","closed_at":"2018-07-24T10:19:05Z","merged_at":null,"merge_commit_sha":"88747ff9198b1ab627f32d3ba04cba6f694e6d62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722339975,"node_id":"MDU6TGFiZWw3MjIzMzk5NzU=","url":"https://api.github.com/repos/alibaba/pouch/labels/areas/test","name":"areas/test","color":"1d76db","default":false},{"id":722344260,"node_id":"MDU6TGFiZWw3MjIzNDQyNjA=","url":"https://api.github.com/repos/alibaba/pouch/labels/conflict/needs-rebase","name":"conflict/needs-rebase","color":"cccccc","default":false},{"id":729586101,"node_id":"MDU6TGFiZWw3Mjk1ODYxMDE=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/M","name":"size/M","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/1888/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/1888/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1888/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/7125fd5accee341f2c1c6453fe55fc14a1c82b2f","head":{"label":"sunzeyucmu:pre","ref":"pre","sha":"7125fd5accee341f2c1c6453fe55fc14a1c82b2f","user":{"login":"sunzeyucmu","id":30520912,"node_id":"MDQ6VXNlcjMwNTIwOTEy","avatar_url":"https://avatars0.githubusercontent.com/u/30520912?v=4","gravatar_id":"","url":"https://api.github.com/users/sunzeyucmu","html_url":"https://github.com/sunzeyucmu","followers_url":"https://api.github.com/users/sunzeyucmu/followers","following_url":"https://api.github.com/users/sunzeyucmu/following{/other_user}","gists_url":"https://api.github.com/users/sunzeyucmu/gists{/gist_id}","starred_url":"https://api.github.com/users/sunzeyucmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunzeyucmu/subscriptions","organizations_url":"https://api.github.com/users/sunzeyucmu/orgs","repos_url":"https://api.github.com/users/sunzeyucmu/repos","events_url":"https://api.github.com/users/sunzeyucmu/events{/privacy}","received_events_url":"https://api.github.com/users/sunzeyucmu/received_events","type":"User","site_admin":false},"repo":{"id":141802931,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4MDI5MzE=","name":"pouch","full_name":"sunzeyucmu/pouch","owner":{"login":"sunzeyucmu","id":30520912,"node_id":"MDQ6VXNlcjMwNTIwOTEy","avatar_url":"https://avatars0.githubusercontent.com/u/30520912?v=4","gravatar_id":"","url":"https://api.github.com/users/sunzeyucmu","html_url":"https://github.com/sunzeyucmu","followers_url":"https://api.github.com/users/sunzeyucmu/followers","following_url":"https://api.github.com/users/sunzeyucmu/following{/other_user}","gists_url":"https://api.github.com/users/sunzeyucmu/gists{/gist_id}","starred_url":"https://api.github.com/users/sunzeyucmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunzeyucmu/subscriptions","organizations_url":"https://api.github.com/users/sunzeyucmu/orgs","repos_url":"https://api.github.com/users/sunzeyucmu/repos","events_url":"https://api.github.com/users/sunzeyucmu/events{/privacy}","received_events_url":"https://api.github.com/users/sunzeyucmu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sunzeyucmu/pouch","description":"PouchContainer is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/sunzeyucmu/pouch","forks_url":"https://api.github.com/repos/sunzeyucmu/pouch/forks","keys_url":"https://api.github.com/repos/sunzeyucmu/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunzeyucmu/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunzeyucmu/pouch/teams","hooks_url":"https://api.github.com/repos/sunzeyucmu/pouch/hooks","issue_events_url":"https://api.github.com/repos/sunzeyucmu/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/sunzeyucmu/pouch/events","assignees_url":"https://api.github.com/repos/sunzeyucmu/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/sunzeyucmu/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/sunzeyucmu/pouch/tags","blobs_url":"https://api.github.com/repos/sunzeyucmu/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunzeyucmu/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunzeyucmu/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunzeyucmu/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunzeyucmu/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/sunzeyucmu/pouch/languages","stargazers_url":"https://api.github.com/repos/sunzeyucmu/pouch/stargazers","contributors_url":"https://api.github.com/repos/sunzeyucmu/pouch/contributors","subscribers_url":"https://api.github.com/repos/sunzeyucmu/pouch/subscribers","subscription_url":"https://api.github.com/repos/sunzeyucmu/pouch/subscription","commits_url":"https://api.github.com/repos/sunzeyucmu/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunzeyucmu/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunzeyucmu/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunzeyucmu/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunzeyucmu/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/sunzeyucmu/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunzeyucmu/pouch/merges","archive_url":"https://api.github.com/repos/sunzeyucmu/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunzeyucmu/pouch/downloads","issues_url":"https://api.github.com/repos/sunzeyucmu/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/sunzeyucmu/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/sunzeyucmu/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/sunzeyucmu/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunzeyucmu/pouch/labels{/name}","releases_url":"https://api.github.com/repos/sunzeyucmu/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/sunzeyucmu/pouch/deployments","created_at":"2018-07-21T10:31:24Z","updated_at":"2018-07-21T10:31:27Z","pushed_at":"2018-07-24T04:45:48Z","git_url":"git://github.com/sunzeyucmu/pouch.git","ssh_url":"git@github.com:sunzeyucmu/pouch.git","clone_url":"https://github.com/sunzeyucmu/pouch.git","svn_url":"https://github.com/sunzeyucmu/pouch","homepage":"","size":18395,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"afc7a218351b2a43e55eb1a327d40a8b94e74b90","user":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NTU5NjU=","name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"PouchContainer is an open-source project created to promote the container technology movement.","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-07-24T08:24:21Z","pushed_at":"2018-07-24T09:18:01Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"","size":18414,"stargazers_count":2883,"watchers_count":2883,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":664,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":664,"open_issues":188,"watchers":2883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1888"},"html":{"href":"https://github.com/alibaba/pouch/pull/1888"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1888"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1888/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1888/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1888/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/7125fd5accee341f2c1c6453fe55fc14a1c82b2f"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":53,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zhuangqh"}}