{"action":"created","issue":{"url":"https://api.github.com/repos/kraih/mojo/issues/1246","repository_url":"https://api.github.com/repos/kraih/mojo","labels_url":"https://api.github.com/repos/kraih/mojo/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/kraih/mojo/issues/1246/comments","events_url":"https://api.github.com/repos/kraih/mojo/issues/1246/events","html_url":"https://github.com/kraih/mojo/pull/1246","id":346716341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTEzMjU3","number":1246,"title":" Add max-age support to Mojolicious::Sessions","user":{"login":"srchulo","id":935847,"node_id":"MDQ6VXNlcjkzNTg0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/935847?v=4","gravatar_id":"","url":"https://api.github.com/users/srchulo","html_url":"https://github.com/srchulo","followers_url":"https://api.github.com/users/srchulo/followers","following_url":"https://api.github.com/users/srchulo/following{/other_user}","gists_url":"https://api.github.com/users/srchulo/gists{/gist_id}","starred_url":"https://api.github.com/users/srchulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srchulo/subscriptions","organizations_url":"https://api.github.com/users/srchulo/orgs","repos_url":"https://api.github.com/users/srchulo/repos","events_url":"https://api.github.com/users/srchulo/events{/privacy}","received_events_url":"https://api.github.com/users/srchulo/received_events","type":"User","site_admin":false},"labels":[{"id":140460065,"node_id":"MDU6TGFiZWwxNDA0NjAwNjU=","url":"https://api.github.com/repos/kraih/mojo/labels/feature","name":"feature","color":"0052cc","default":false},{"id":135720706,"node_id":"MDU6TGFiZWwxMzU3MjA3MDY=","url":"https://api.github.com/repos/kraih/mojo/labels/needs%20feedback","name":"needs feedback","color":"eeeeee","default":false},{"id":135721682,"node_id":"MDU6TGFiZWwxMzU3MjE2ODI=","url":"https://api.github.com/repos/kraih/mojo/labels/work%20in%20progress","name":"work in progress","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-01T18:29:31Z","updated_at":"2018-08-04T18:26:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kraih/mojo/pulls/1246","html_url":"https://github.com/kraih/mojo/pull/1246","diff_url":"https://github.com/kraih/mojo/pull/1246.diff","patch_url":"https://github.com/kraih/mojo/pull/1246.patch"},"body":"Proposed fix for https://github.com/kraih/mojo/issues/1244.\r\n\r\n### Summary\r\nAdding the equivalent max-age directive alongside any expires directives in cookies.\r\n\r\n### Motivation\r\nTo avoid issues with mismatching client/server clocks.\r\n\r\n### References\r\nhttps://github.com/kraih/mojo/issues/1244\r\n\r\nI can test this later tonight before submitting if this looks okay.\r\n"},"comment":{"url":"https://api.github.com/repos/kraih/mojo/issues/comments/410468542","html_url":"https://github.com/kraih/mojo/pull/1246#issuecomment-410468542","issue_url":"https://api.github.com/repos/kraih/mojo/issues/1246","id":410468542,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ2ODU0Mg==","user":{"login":"kraih","id":30094,"node_id":"MDQ6VXNlcjMwMDk0","avatar_url":"https://avatars3.githubusercontent.com/u/30094?v=4","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"created_at":"2018-08-04T18:26:15Z","updated_at":"2018-08-04T18:26:15Z","author_association":"OWNER","body":"And i should point out that i've given this pull request a `work in progress` tag. As long as that's active this pull request will not be considered (and mostly be left alone by everyone). If what you're looking for is help with your patch, please close the pull request and discuss your branch on IRC or the mailing-list. https://mojolicious.org/perldoc/Mojolicious/Guides/Contributing#CONTRIBUTING-CODE"}}
{"actor":{"display_login":"kraih"}}