{"action":"created","comment":{"url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/comments/236722795","pull_request_review_id":178856121,"id":236722795,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjcyMjc5NQ==","diff_hunk":"@@ -1,5 +1,49 @@\n+abstract class AbstractUnaryNode<E> {\n+  final E operand;\n+  const AbstractUnaryNode(this.operand);\n+}\n+\n+abstract class AbstractBinaryNode<E> extends AbstractUnaryNode<E> {\n+  final E operand2;\n+  const AbstractBinaryNode(E operand, this.operand2): super(operand);\n+}\n+\n+abstract class AbstractLeaf {}\n+\n+abstract class PredicateExpressionLeaf<E> {}\n+\n+abstract class UnaryOperantNode<E, O> extends AbstractUnaryNode<E> {\n+  final O operant;\n+\n+  const UnaryOperantNode(E lhs, this.operant) : super(lhs);\n+}\n+\n+abstract class BinaryOperantNode<E, O> extends AbstractBinaryNode<E> {\n+  final O operant;\n+\n+  const BinaryOperantNode(E lhs, E rhs, this.operant) : super(lhs, rhs);\n+}\n+\n+abstract class ComparisonBinaryNode<E> extends BinaryOperantNode<E, ComparisonOperant> {\n+  const ComparisonBinaryNode(E lhs, E rhs, ComparisonOperant operant) : super(lhs, rhs, operant);\n+}\n+\n+abstract class StringComparisonOperantNode<String> extends BinaryOperantNode<String, StringComparisonOperant> {","path":"aqueduct/lib/src/db/query/matcher_internal.dart","position":null,"original_position":31,"commit_id":"9e8f0fffb23ed2ec63ba4631404537dbc43a08fe","original_commit_id":"e1c9b4ff8462bc49b2f378fe972dd32d17eaeb85","user":{"login":"sudolibre","id":20878393,"node_id":"MDQ6VXNlcjIwODc4Mzkz","avatar_url":"https://avatars2.githubusercontent.com/u/20878393?v=4","gravatar_id":"","url":"https://api.github.com/users/sudolibre","html_url":"https://github.com/sudolibre","followers_url":"https://api.github.com/users/sudolibre/followers","following_url":"https://api.github.com/users/sudolibre/following{/other_user}","gists_url":"https://api.github.com/users/sudolibre/gists{/gist_id}","starred_url":"https://api.github.com/users/sudolibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudolibre/subscriptions","organizations_url":"https://api.github.com/users/sudolibre/orgs","repos_url":"https://api.github.com/users/sudolibre/repos","events_url":"https://api.github.com/users/sudolibre/events{/privacy}","received_events_url":"https://api.github.com/users/sudolibre/received_events","type":"User","site_admin":false},"body":"That makes sense. I went back in and discovered this class and a couple more weren't being used so I removed them.","created_at":"2018-11-27T15:46:23Z","updated_at":"2018-11-27T15:46:23Z","html_url":"https://github.com/stablekernel/aqueduct/pull/594#discussion_r236722795","pull_request_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/comments/236722795"},"html":{"href":"https://github.com/stablekernel/aqueduct/pull/594#discussion_r236722795"},"pull_request":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594"}},"in_reply_to_id":236444156},"pull_request":{"url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594","id":231669231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjY5MjMx","html_url":"https://github.com/stablekernel/aqueduct/pull/594","diff_url":"https://github.com/stablekernel/aqueduct/pull/594.diff","patch_url":"https://github.com/stablekernel/aqueduct/pull/594.patch","issue_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/594","number":594,"state":"open","locked":false,"title":"Query orWhere","user":{"login":"sudolibre","id":20878393,"node_id":"MDQ6VXNlcjIwODc4Mzkz","avatar_url":"https://avatars2.githubusercontent.com/u/20878393?v=4","gravatar_id":"","url":"https://api.github.com/users/sudolibre","html_url":"https://github.com/sudolibre","followers_url":"https://api.github.com/users/sudolibre/followers","following_url":"https://api.github.com/users/sudolibre/following{/other_user}","gists_url":"https://api.github.com/users/sudolibre/gists{/gist_id}","starred_url":"https://api.github.com/users/sudolibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudolibre/subscriptions","organizations_url":"https://api.github.com/users/sudolibre/orgs","repos_url":"https://api.github.com/users/sudolibre/repos","events_url":"https://api.github.com/users/sudolibre/events{/privacy}","received_events_url":"https://api.github.com/users/sudolibre/received_events","type":"User","site_admin":false},"body":"Issue: #545 \r\n\r\nAdded the following methods to Query\r\n* orWhere: \r\n    * will separate the expressions with an \"OR\" operator instead of \"AND\": a=a OR b=b\r\n* orWhereGroup\r\n    * will separate with an \"OR\" operator and group the contained expression with parens: a=a OR (b=b OR c=c)\r\n* whereGroup (implicit AND)\r\n    * will separate with an \"AND\" operator and group the contained expression with parens: a=a OR (b=b OR c=c)\r\n\r\nExample of call site:\r\n```\r\nvar r = Query<AnotherTestModel>(context)\r\n        ..where((o) => o.email).equalTo(\"founder@company.com\")\r\n        ..orWhereGroup((query) => query\r\n          ..where((o) => o.name).equalTo(\"Bob\")\r\n          ..where((o) => o.rank).greaterThan(\"9000\"))\r\n        ..sortBy((r) => r.name, QuerySortOrder.ascending);\r\n```","created_at":"2018-11-16T22:09:12Z","updated_at":"2018-11-27T15:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2139620cfa2a38b0ef172651d4fab4614ae650d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594/commits","review_comments_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594/comments","review_comment_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/594/comments","statuses_url":"https://api.github.com/repos/stablekernel/aqueduct/statuses/9e8f0fffb23ed2ec63ba4631404537dbc43a08fe","head":{"label":"stablekernel:jd/query-predicate-or","ref":"jd/query-predicate-or","sha":"9e8f0fffb23ed2ec63ba4631404537dbc43a08fe","user":{"login":"stablekernel","id":4998931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTg5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4998931?v=4","gravatar_id":"","url":"https://api.github.com/users/stablekernel","html_url":"https://github.com/stablekernel","followers_url":"https://api.github.com/users/stablekernel/followers","following_url":"https://api.github.com/users/stablekernel/following{/other_user}","gists_url":"https://api.github.com/users/stablekernel/gists{/gist_id}","starred_url":"https://api.github.com/users/stablekernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stablekernel/subscriptions","organizations_url":"https://api.github.com/users/stablekernel/orgs","repos_url":"https://api.github.com/users/stablekernel/repos","events_url":"https://api.github.com/users/stablekernel/events{/privacy}","received_events_url":"https://api.github.com/users/stablekernel/received_events","type":"Organization","site_admin":false},"repo":{"id":36523292,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUyMzI5Mg==","name":"aqueduct","full_name":"stablekernel/aqueduct","private":false,"owner":{"login":"stablekernel","id":4998931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTg5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4998931?v=4","gravatar_id":"","url":"https://api.github.com/users/stablekernel","html_url":"https://github.com/stablekernel","followers_url":"https://api.github.com/users/stablekernel/followers","following_url":"https://api.github.com/users/stablekernel/following{/other_user}","gists_url":"https://api.github.com/users/stablekernel/gists{/gist_id}","starred_url":"https://api.github.com/users/stablekernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stablekernel/subscriptions","organizations_url":"https://api.github.com/users/stablekernel/orgs","repos_url":"https://api.github.com/users/stablekernel/repos","events_url":"https://api.github.com/users/stablekernel/events{/privacy}","received_events_url":"https://api.github.com/users/stablekernel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stablekernel/aqueduct","description":"Dart HTTP server framework for building REST APIs. Includes PostgreSQL ORM and OAuth2 provider.","fork":false,"url":"https://api.github.com/repos/stablekernel/aqueduct","forks_url":"https://api.github.com/repos/stablekernel/aqueduct/forks","keys_url":"https://api.github.com/repos/stablekernel/aqueduct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stablekernel/aqueduct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stablekernel/aqueduct/teams","hooks_url":"https://api.github.com/repos/stablekernel/aqueduct/hooks","issue_events_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/events{/number}","events_url":"https://api.github.com/repos/stablekernel/aqueduct/events","assignees_url":"https://api.github.com/repos/stablekernel/aqueduct/assignees{/user}","branches_url":"https://api.github.com/repos/stablekernel/aqueduct/branches{/branch}","tags_url":"https://api.github.com/repos/stablekernel/aqueduct/tags","blobs_url":"https://api.github.com/repos/stablekernel/aqueduct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stablekernel/aqueduct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stablekernel/aqueduct/git/refs{/sha}","trees_url":"https://api.github.com/repos/stablekernel/aqueduct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stablekernel/aqueduct/statuses/{sha}","languages_url":"https://api.github.com/repos/stablekernel/aqueduct/languages","stargazers_url":"https://api.github.com/repos/stablekernel/aqueduct/stargazers","contributors_url":"https://api.github.com/repos/stablekernel/aqueduct/contributors","subscribers_url":"https://api.github.com/repos/stablekernel/aqueduct/subscribers","subscription_url":"https://api.github.com/repos/stablekernel/aqueduct/subscription","commits_url":"https://api.github.com/repos/stablekernel/aqueduct/commits{/sha}","git_commits_url":"https://api.github.com/repos/stablekernel/aqueduct/git/commits{/sha}","comments_url":"https://api.github.com/repos/stablekernel/aqueduct/comments{/number}","issue_comment_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/comments{/number}","contents_url":"https://api.github.com/repos/stablekernel/aqueduct/contents/{+path}","compare_url":"https://api.github.com/repos/stablekernel/aqueduct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stablekernel/aqueduct/merges","archive_url":"https://api.github.com/repos/stablekernel/aqueduct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stablekernel/aqueduct/downloads","issues_url":"https://api.github.com/repos/stablekernel/aqueduct/issues{/number}","pulls_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls{/number}","milestones_url":"https://api.github.com/repos/stablekernel/aqueduct/milestones{/number}","notifications_url":"https://api.github.com/repos/stablekernel/aqueduct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stablekernel/aqueduct/labels{/name}","releases_url":"https://api.github.com/repos/stablekernel/aqueduct/releases{/id}","deployments_url":"https://api.github.com/repos/stablekernel/aqueduct/deployments","created_at":"2015-05-29T18:56:06Z","updated_at":"2018-11-27T05:15:26Z","pushed_at":"2018-11-27T15:45:39Z","git_url":"git://github.com/stablekernel/aqueduct.git","ssh_url":"git@github.com:stablekernel/aqueduct.git","clone_url":"https://github.com/stablekernel/aqueduct.git","svn_url":"https://github.com/stablekernel/aqueduct","homepage":"https://aqueduct.io","size":17339,"stargazers_count":585,"watchers_count":585,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":37,"open_issues":43,"watchers":585,"default_branch":"master"}},"base":{"label":"stablekernel:master","ref":"master","sha":"99412cacf870d265ea6cae17b9fbedc850ffc863","user":{"login":"stablekernel","id":4998931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTg5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4998931?v=4","gravatar_id":"","url":"https://api.github.com/users/stablekernel","html_url":"https://github.com/stablekernel","followers_url":"https://api.github.com/users/stablekernel/followers","following_url":"https://api.github.com/users/stablekernel/following{/other_user}","gists_url":"https://api.github.com/users/stablekernel/gists{/gist_id}","starred_url":"https://api.github.com/users/stablekernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stablekernel/subscriptions","organizations_url":"https://api.github.com/users/stablekernel/orgs","repos_url":"https://api.github.com/users/stablekernel/repos","events_url":"https://api.github.com/users/stablekernel/events{/privacy}","received_events_url":"https://api.github.com/users/stablekernel/received_events","type":"Organization","site_admin":false},"repo":{"id":36523292,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUyMzI5Mg==","name":"aqueduct","full_name":"stablekernel/aqueduct","private":false,"owner":{"login":"stablekernel","id":4998931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTg5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4998931?v=4","gravatar_id":"","url":"https://api.github.com/users/stablekernel","html_url":"https://github.com/stablekernel","followers_url":"https://api.github.com/users/stablekernel/followers","following_url":"https://api.github.com/users/stablekernel/following{/other_user}","gists_url":"https://api.github.com/users/stablekernel/gists{/gist_id}","starred_url":"https://api.github.com/users/stablekernel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stablekernel/subscriptions","organizations_url":"https://api.github.com/users/stablekernel/orgs","repos_url":"https://api.github.com/users/stablekernel/repos","events_url":"https://api.github.com/users/stablekernel/events{/privacy}","received_events_url":"https://api.github.com/users/stablekernel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stablekernel/aqueduct","description":"Dart HTTP server framework for building REST APIs. Includes PostgreSQL ORM and OAuth2 provider.","fork":false,"url":"https://api.github.com/repos/stablekernel/aqueduct","forks_url":"https://api.github.com/repos/stablekernel/aqueduct/forks","keys_url":"https://api.github.com/repos/stablekernel/aqueduct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stablekernel/aqueduct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stablekernel/aqueduct/teams","hooks_url":"https://api.github.com/repos/stablekernel/aqueduct/hooks","issue_events_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/events{/number}","events_url":"https://api.github.com/repos/stablekernel/aqueduct/events","assignees_url":"https://api.github.com/repos/stablekernel/aqueduct/assignees{/user}","branches_url":"https://api.github.com/repos/stablekernel/aqueduct/branches{/branch}","tags_url":"https://api.github.com/repos/stablekernel/aqueduct/tags","blobs_url":"https://api.github.com/repos/stablekernel/aqueduct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stablekernel/aqueduct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stablekernel/aqueduct/git/refs{/sha}","trees_url":"https://api.github.com/repos/stablekernel/aqueduct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stablekernel/aqueduct/statuses/{sha}","languages_url":"https://api.github.com/repos/stablekernel/aqueduct/languages","stargazers_url":"https://api.github.com/repos/stablekernel/aqueduct/stargazers","contributors_url":"https://api.github.com/repos/stablekernel/aqueduct/contributors","subscribers_url":"https://api.github.com/repos/stablekernel/aqueduct/subscribers","subscription_url":"https://api.github.com/repos/stablekernel/aqueduct/subscription","commits_url":"https://api.github.com/repos/stablekernel/aqueduct/commits{/sha}","git_commits_url":"https://api.github.com/repos/stablekernel/aqueduct/git/commits{/sha}","comments_url":"https://api.github.com/repos/stablekernel/aqueduct/comments{/number}","issue_comment_url":"https://api.github.com/repos/stablekernel/aqueduct/issues/comments{/number}","contents_url":"https://api.github.com/repos/stablekernel/aqueduct/contents/{+path}","compare_url":"https://api.github.com/repos/stablekernel/aqueduct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stablekernel/aqueduct/merges","archive_url":"https://api.github.com/repos/stablekernel/aqueduct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stablekernel/aqueduct/downloads","issues_url":"https://api.github.com/repos/stablekernel/aqueduct/issues{/number}","pulls_url":"https://api.github.com/repos/stablekernel/aqueduct/pulls{/number}","milestones_url":"https://api.github.com/repos/stablekernel/aqueduct/milestones{/number}","notifications_url":"https://api.github.com/repos/stablekernel/aqueduct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stablekernel/aqueduct/labels{/name}","releases_url":"https://api.github.com/repos/stablekernel/aqueduct/releases{/id}","deployments_url":"https://api.github.com/repos/stablekernel/aqueduct/deployments","created_at":"2015-05-29T18:56:06Z","updated_at":"2018-11-27T05:15:26Z","pushed_at":"2018-11-27T15:45:39Z","git_url":"git://github.com/stablekernel/aqueduct.git","ssh_url":"git@github.com:stablekernel/aqueduct.git","clone_url":"https://github.com/stablekernel/aqueduct.git","svn_url":"https://github.com/stablekernel/aqueduct","homepage":"https://aqueduct.io","size":17339,"stargazers_count":585,"watchers_count":585,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":37,"open_issues":43,"watchers":585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594"},"html":{"href":"https://github.com/stablekernel/aqueduct/pull/594"},"issue":{"href":"https://api.github.com/repos/stablekernel/aqueduct/issues/594"},"comments":{"href":"https://api.github.com/repos/stablekernel/aqueduct/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stablekernel/aqueduct/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/stablekernel/aqueduct/statuses/9e8f0fffb23ed2ec63ba4631404537dbc43a08fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sudolibre"}}