{"action":"closed","number":4397,"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397","id":179933062,"html_url":"https://github.com/RPCS3/rpcs3/pull/4397","diff_url":"https://github.com/RPCS3/rpcs3/pull/4397.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/4397.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4397","number":4397,"state":"closed","locked":false,"title":"cellSaveData: don't return after funcStat was successful in savedata_op","user":{"login":"Megamouse","id":23019877,"avatar_url":"https://avatars1.githubusercontent.com/u/23019877?v=4","gravatar_id":"","url":"https://api.github.com/users/Megamouse","html_url":"https://github.com/Megamouse","followers_url":"https://api.github.com/users/Megamouse/followers","following_url":"https://api.github.com/users/Megamouse/following{/other_user}","gists_url":"https://api.github.com/users/Megamouse/gists{/gist_id}","starred_url":"https://api.github.com/users/Megamouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Megamouse/subscriptions","organizations_url":"https://api.github.com/users/Megamouse/orgs","repos_url":"https://api.github.com/users/Megamouse/repos","events_url":"https://api.github.com/users/Megamouse/events{/privacy}","received_events_url":"https://api.github.com/users/Megamouse/received_events","type":"User","site_admin":false},"body":"Apparently the game \"Battle Princess of Arcadias\" only proceeds when calling funcFile after funcStat.\r\nBut funcStat returns CELL_SAVEDATA_CBRESULT_OK_LAST_NOCONFIRM, which apparently means no consecutive callbacks will be called.\r\n\r\nWe completely skip the rest of the savedata op if that happens.\r\n\r\nBut I think what it means is that it should only skip the next funcStat call, which is only called once anyway.\r\nSo I guess CELL_SAVEDATA_CBRESULT_OK_LAST_NOCONFIRM and CELL_SAVEDATA_CBRESULT_OK_NEXT are actually equivalent in the case of funcStat and the gamedevs were supposed to use OK_NEXT.\r\n\r\nThe loop is probably unneccessary and I could only remove the check, but who knows... better safe than sorry?","created_at":"2018-04-06T12:21:50Z","updated_at":"2018-05-20T19:16:12Z","closed_at":"2018-05-20T19:16:12Z","merged_at":"2018-05-20T19:16:12Z","merge_commit_sha":"68fff54a8b9b048dde3bea1f0efb308e410e0800","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars2.githubusercontent.com/u/6028184?v=4","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":287007392,"url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Bugfix","name":"Bugfix","color":"80ff80","default":false},{"id":763620152,"url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Savedata","name":"Savedata","color":"0057a0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4397/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/995338fa5bb2f408952e0c2614662aff9b1f754f","head":{"label":"Megamouse:save_fix","ref":"save_fix","sha":"995338fa5bb2f408952e0c2614662aff9b1f754f","user":{"login":"Megamouse","id":23019877,"avatar_url":"https://avatars1.githubusercontent.com/u/23019877?v=4","gravatar_id":"","url":"https://api.github.com/users/Megamouse","html_url":"https://github.com/Megamouse","followers_url":"https://api.github.com/users/Megamouse/followers","following_url":"https://api.github.com/users/Megamouse/following{/other_user}","gists_url":"https://api.github.com/users/Megamouse/gists{/gist_id}","starred_url":"https://api.github.com/users/Megamouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Megamouse/subscriptions","organizations_url":"https://api.github.com/users/Megamouse/orgs","repos_url":"https://api.github.com/users/Megamouse/repos","events_url":"https://api.github.com/users/Megamouse/events{/privacy}","received_events_url":"https://api.github.com/users/Megamouse/received_events","type":"User","site_admin":false},"repo":{"id":85596930,"name":"rpcs3","full_name":"Megamouse/rpcs3","owner":{"login":"Megamouse","id":23019877,"avatar_url":"https://avatars1.githubusercontent.com/u/23019877?v=4","gravatar_id":"","url":"https://api.github.com/users/Megamouse","html_url":"https://github.com/Megamouse","followers_url":"https://api.github.com/users/Megamouse/followers","following_url":"https://api.github.com/users/Megamouse/following{/other_user}","gists_url":"https://api.github.com/users/Megamouse/gists{/gist_id}","starred_url":"https://api.github.com/users/Megamouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Megamouse/subscriptions","organizations_url":"https://api.github.com/users/Megamouse/orgs","repos_url":"https://api.github.com/users/Megamouse/repos","events_url":"https://api.github.com/users/Megamouse/events{/privacy}","received_events_url":"https://api.github.com/users/Megamouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Megamouse/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/Megamouse/rpcs3","forks_url":"https://api.github.com/repos/Megamouse/rpcs3/forks","keys_url":"https://api.github.com/repos/Megamouse/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Megamouse/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Megamouse/rpcs3/teams","hooks_url":"https://api.github.com/repos/Megamouse/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/Megamouse/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/Megamouse/rpcs3/events","assignees_url":"https://api.github.com/repos/Megamouse/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/Megamouse/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/Megamouse/rpcs3/tags","blobs_url":"https://api.github.com/repos/Megamouse/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Megamouse/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Megamouse/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Megamouse/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Megamouse/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/Megamouse/rpcs3/languages","stargazers_url":"https://api.github.com/repos/Megamouse/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/Megamouse/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/Megamouse/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/Megamouse/rpcs3/subscription","commits_url":"https://api.github.com/repos/Megamouse/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Megamouse/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Megamouse/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Megamouse/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Megamouse/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/Megamouse/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Megamouse/rpcs3/merges","archive_url":"https://api.github.com/repos/Megamouse/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Megamouse/rpcs3/downloads","issues_url":"https://api.github.com/repos/Megamouse/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/Megamouse/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/Megamouse/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/Megamouse/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Megamouse/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/Megamouse/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/Megamouse/rpcs3/deployments","created_at":"2017-03-20T15:57:12Z","updated_at":"2018-05-20T02:57:36Z","pushed_at":"2018-05-20T16:08:41Z","git_url":"git://github.com/Megamouse/rpcs3.git","ssh_url":"git@github.com:Megamouse/rpcs3.git","clone_url":"https://github.com/Megamouse/rpcs3.git","svn_url":"https://github.com/Megamouse/rpcs3","homepage":"https://rpcs3.net/","size":49737,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"c61049b76fd9cc743066b5f190576f8335e1b022","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2018-05-20T13:53:05Z","pushed_at":"2018-05-20T19:16:12Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":49619,"stargazers_count":4957,"watchers_count":4957,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":916,"mirror_url":null,"archived":false,"open_issues_count":360,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":916,"open_issues":360,"watchers":4957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4397"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4397"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4397/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4397/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/995338fa5bb2f408952e0c2614662aff9b1f754f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars2.githubusercontent.com/u/6028184?v=4","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":14,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"Nekotekina"}}