{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85","id":222986254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTg2MjU0","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/85","diff_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/85.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/85.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/85","number":85,"state":"closed","locked":false,"title":"DD-58: Fix Payment Plans with 1 Instalment Creation","user":{"login":"MiyaNoctem","id":21999940,"node_id":"MDQ6VXNlcjIxOTk5OTQw","avatar_url":"https://avatars0.githubusercontent.com/u/21999940?v=4","gravatar_id":"","url":"https://api.github.com/users/MiyaNoctem","html_url":"https://github.com/MiyaNoctem","followers_url":"https://api.github.com/users/MiyaNoctem/followers","following_url":"https://api.github.com/users/MiyaNoctem/following{/other_user}","gists_url":"https://api.github.com/users/MiyaNoctem/gists{/gist_id}","starred_url":"https://api.github.com/users/MiyaNoctem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiyaNoctem/subscriptions","organizations_url":"https://api.github.com/users/MiyaNoctem/orgs","repos_url":"https://api.github.com/users/MiyaNoctem/repos","events_url":"https://api.github.com/users/MiyaNoctem/events{/privacy}","received_events_url":"https://api.github.com/users/MiyaNoctem/received_events","type":"User","site_admin":false},"body":"## Overview\r\nCreation with payment plans with only one instalment was not creating the associated recurring contribution. This has been fixed in phase-3 workbranch by means of PR #80 , but we need to have this fix as part of forth-coming release.\r\n\r\n## Before\r\nCreation with payment plans with only one instalment was not creating the associated recurring contribution. This was because only payment plans with more than one instalment were being processed. \r\n\r\n##After\r\nFixed by changing condition to have at least one instalment.","created_at":"2018-10-15T17:36:49Z","updated_at":"2018-10-16T09:37:54Z","closed_at":"2018-10-16T09:37:54Z","merged_at":"2018-10-16T09:37:54Z","merge_commit_sha":"4b4630e2c2840a5c594786410e0550f9f85efced","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/85/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/8e66e6a8e16d74f23b039a2617a217469d73524e","head":{"label":"compucorp:DD-58-fix-single-instalment-pp-creation","ref":"DD-58-fix-single-instalment-pp-creation","sha":"8e66e6a8e16d74f23b039a2617a217469d73524e","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1NDMyODM=","name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-09-17T09:07:31Z","pushed_at":"2018-10-16T09:37:54Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":415,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":4,"watchers":1,"default_branch":"develop"}},"base":{"label":"compucorp:alpha-release","ref":"alpha-release","sha":"7b3ab282527fa5e3de25a4e241bd9fc337efd156","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1NDMyODM=","name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-09-17T09:07:31Z","pushed_at":"2018-10-16T09:37:54Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":415,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/85"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/85"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/8e66e6a8e16d74f23b039a2617a217469d73524e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"guanhuan","id":6278917,"node_id":"MDQ6VXNlcjYyNzg5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6278917?v=4","gravatar_id":"","url":"https://api.github.com/users/guanhuan","html_url":"https://github.com/guanhuan","followers_url":"https://api.github.com/users/guanhuan/followers","following_url":"https://api.github.com/users/guanhuan/following{/other_user}","gists_url":"https://api.github.com/users/guanhuan/gists{/gist_id}","starred_url":"https://api.github.com/users/guanhuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guanhuan/subscriptions","organizations_url":"https://api.github.com/users/guanhuan/orgs","repos_url":"https://api.github.com/users/guanhuan/repos","events_url":"https://api.github.com/users/guanhuan/events{/privacy}","received_events_url":"https://api.github.com/users/guanhuan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"guanhuan"}}