{"action":"created","issue":{"url":"https://api.github.com/repos/mercadopago/px-android/issues/1020","repository_url":"https://api.github.com/repos/mercadopago/px-android","labels_url":"https://api.github.com/repos/mercadopago/px-android/issues/1020/labels{/name}","comments_url":"https://api.github.com/repos/mercadopago/px-android/issues/1020/comments","events_url":"https://api.github.com/repos/mercadopago/px-android/issues/1020/events","html_url":"https://github.com/mercadopago/px-android/pull/1020","id":324588604,"number":1020,"title":"[concept] refactor networking","user":{"login":"zehemz","id":7827612,"avatar_url":"https://avatars0.githubusercontent.com/u/7827612?v=4","gravatar_id":"","url":"https://api.github.com/users/zehemz","html_url":"https://github.com/zehemz","followers_url":"https://api.github.com/users/zehemz/followers","following_url":"https://api.github.com/users/zehemz/following{/other_user}","gists_url":"https://api.github.com/users/zehemz/gists{/gist_id}","starred_url":"https://api.github.com/users/zehemz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zehemz/subscriptions","organizations_url":"https://api.github.com/users/zehemz/orgs","repos_url":"https://api.github.com/users/zehemz/repos","events_url":"https://api.github.com/users/zehemz/events{/privacy}","received_events_url":"https://api.github.com/users/zehemz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-19T01:01:08Z","updated_at":"2018-05-19T01:17:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mercadopago/px-android/pulls/1020","html_url":"https://github.com/mercadopago/px-android/pull/1020","diff_url":"https://github.com/mercadopago/px-android/pull/1020.diff","patch_url":"https://github.com/mercadopago/px-android/pull/1020.patch"},"body":"concepto, la idea es que devuelva los calls y se puedan encolar en el presenter, hoy por hoy se genera un callback del cual no tenemos control y si queremos testear eso estamos muy atados a los stub.\r\n\r\nDe paso aprovechar algunas cosas:\r\n- el contexto desde application para generar clientes de red\r\n- desacoplar individualmente requests\r\n- tener la posibilidad de aplicar políticas locales de cacheo"},"comment":{"url":"https://api.github.com/repos/mercadopago/px-android/issues/comments/390368044","html_url":"https://github.com/mercadopago/px-android/pull/1020#issuecomment-390368044","issue_url":"https://api.github.com/repos/mercadopago/px-android/issues/1020","id":390368044,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-19T01:17:38Z","updated_at":"2018-05-19T01:17:38Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`develop@5925bfa`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `50%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mercadopago/px-android/pull/1020/graphs/tree.svg?width=650&height=150&src=pr&token=ksLU5tHdUS)](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##             develop    #1020   +/-   ##\n==========================================\n  Coverage           ?   28.33%           \n==========================================\n  Files              ?      299           \n  Lines              ?    14585           \n  Branches           ?     1333           \n==========================================\n  Hits               ?     4132           \n  Misses             ?     9927           \n  Partials           ?      526\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...om/mercadopago/providers/CheckoutProviderImpl.java](https://codecov.io/gh/mercadopago/px-android/pull/1020/diff?src=pr&el=tree#diff-c2RrL3NyYy9tYWluL2phdmEvY29tL21lcmNhZG9wYWdvL3Byb3ZpZGVycy9DaGVja291dFByb3ZpZGVySW1wbC5qYXZh) | `0% <ø> (ø)` | |\n| [...rc/main/java/com/mercadopago/CheckoutActivity.java](https://codecov.io/gh/mercadopago/px-android/pull/1020/diff?src=pr&el=tree#diff-c2RrL3NyYy9tYWluL2phdmEvY29tL21lcmNhZG9wYWdvL0NoZWNrb3V0QWN0aXZpdHkuamF2YQ==) | `0% <0%> (ø)` | |\n| [.../com/mercadopago/presenters/CheckoutPresenter.java](https://codecov.io/gh/mercadopago/px-android/pull/1020/diff?src=pr&el=tree#diff-c2RrL3NyYy9tYWluL2phdmEvY29tL21lcmNhZG9wYWdvL3ByZXNlbnRlcnMvQ2hlY2tvdXRQcmVzZW50ZXIuamF2YQ==) | `60.16% <80%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=footer). Last update [5925bfa...15223b7](https://codecov.io/gh/mercadopago/px-android/pull/1020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}