{"action":"created","issue":{"url":"https://api.github.com/repos/WordImpress/Give/issues/3488","repository_url":"https://api.github.com/repos/WordImpress/Give","labels_url":"https://api.github.com/repos/WordImpress/Give/issues/3488/labels{/name}","comments_url":"https://api.github.com/repos/WordImpress/Give/issues/3488/comments","events_url":"https://api.github.com/repos/WordImpress/Give/issues/3488/events","html_url":"https://github.com/WordImpress/Give/issues/3488","id":341723873,"node_id":"MDU6SXNzdWUzNDE3MjM4NzM=","number":3488,"title":"fix(form-settings): Ensure prefixes works as described","user":{"login":"mathetos","id":930724,"node_id":"MDQ6VXNlcjkzMDcyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/930724?v=4","gravatar_id":"","url":"https://api.github.com/users/mathetos","html_url":"https://github.com/mathetos","followers_url":"https://api.github.com/users/mathetos/followers","following_url":"https://api.github.com/users/mathetos/following{/other_user}","gists_url":"https://api.github.com/users/mathetos/gists{/gist_id}","starred_url":"https://api.github.com/users/mathetos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathetos/subscriptions","organizations_url":"https://api.github.com/users/mathetos/orgs","repos_url":"https://api.github.com/users/mathetos/repos","events_url":"https://api.github.com/users/mathetos/events{/privacy}","received_events_url":"https://api.github.com/users/mathetos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mehul0810","id":1852711,"node_id":"MDQ6VXNlcjE4NTI3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1852711?v=4","gravatar_id":"","url":"https://api.github.com/users/mehul0810","html_url":"https://github.com/mehul0810","followers_url":"https://api.github.com/users/mehul0810/followers","following_url":"https://api.github.com/users/mehul0810/following{/other_user}","gists_url":"https://api.github.com/users/mehul0810/gists{/gist_id}","starred_url":"https://api.github.com/users/mehul0810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehul0810/subscriptions","organizations_url":"https://api.github.com/users/mehul0810/orgs","repos_url":"https://api.github.com/users/mehul0810/repos","events_url":"https://api.github.com/users/mehul0810/events{/privacy}","received_events_url":"https://api.github.com/users/mehul0810/received_events","type":"User","site_admin":false},"assignees":[{"login":"mehul0810","id":1852711,"node_id":"MDQ6VXNlcjE4NTI3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1852711?v=4","gravatar_id":"","url":"https://api.github.com/users/mehul0810","html_url":"https://github.com/mehul0810","followers_url":"https://api.github.com/users/mehul0810/followers","following_url":"https://api.github.com/users/mehul0810/following{/other_user}","gists_url":"https://api.github.com/users/mehul0810/gists{/gist_id}","starred_url":"https://api.github.com/users/mehul0810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehul0810/subscriptions","organizations_url":"https://api.github.com/users/mehul0810/orgs","repos_url":"https://api.github.com/users/mehul0810/repos","events_url":"https://api.github.com/users/mehul0810/events{/privacy}","received_events_url":"https://api.github.com/users/mehul0810/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordImpress/Give/milestones/71","html_url":"https://github.com/WordImpress/Give/milestone/71","labels_url":"https://api.github.com/repos/WordImpress/Give/milestones/71/labels","id":3486621,"node_id":"MDk6TWlsZXN0b25lMzQ4NjYyMQ==","number":71,"title":"Sprint: 2018/07/11 - 2018/07/24","description":"","creator":{"login":"DevinWalker","id":1571635,"node_id":"MDQ6VXNlcjE1NzE2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1571635?v=4","gravatar_id":"","url":"https://api.github.com/users/DevinWalker","html_url":"https://github.com/DevinWalker","followers_url":"https://api.github.com/users/DevinWalker/followers","following_url":"https://api.github.com/users/DevinWalker/following{/other_user}","gists_url":"https://api.github.com/users/DevinWalker/gists{/gist_id}","starred_url":"https://api.github.com/users/DevinWalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevinWalker/subscriptions","organizations_url":"https://api.github.com/users/DevinWalker/orgs","repos_url":"https://api.github.com/users/DevinWalker/repos","events_url":"https://api.github.com/users/DevinWalker/events{/privacy}","received_events_url":"https://api.github.com/users/DevinWalker/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":20,"state":"open","created_at":"2018-07-10T17:50:29Z","updated_at":"2018-07-17T22:57:48Z","due_on":"2018-07-24T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-07-17T00:28:13Z","updated_at":"2018-07-18T04:45:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## User Story\r\n<!-- Required. -->\r\nAs a `Give Admin` I want to be able to use the new Give 2.2 prefixes feature and for it to behave as expected based on the settings description.\r\n\r\nCurrently the description suggests several prefixes that don't seem to be available and there doesn't seem to be a way to add them either. \r\n\r\n## Current Behavior\r\n<!-- Required. Include any warnings or errors in the browser or console. -->\r\nI currently see the following description in the form settings \"Name Title Prefix\" option:\r\n\r\n> Do you want to add a name title prefix dropdown field before the donor's first name field? This will display a dropdown with options such as Mrs, Miss, Ms, Sir, and Dr for donor to choose from.\r\n\r\nBut the only options available are `Mr | Mrs | Ms`\r\n![image](https://user-images.githubusercontent.com/930724/42789915-c6baee28-891c-11e8-8bd0-fd3d33cb57a9.png)\r\n\r\n\r\n## Expected Behavior\r\n<!-- Required. -->\r\nI expect that inline documentation matches with the actual options available.\r\n\r\n## Possible Solution\r\nThere are two options to resolve this:\r\n\r\n1. Add the ability to add custom prefixes\r\n2. Update the form display settings description to be more accurate. \r\n\r\nIf choosing option 2, here's my suggested wording:\r\n\r\n`Enable a prefix to appear before the donor name. Options are \"Mr., Mrs., and Ms.\"\r\n\r\nAdditionally, there should always me a period (.) after each of those abbreviations. \r\n\r\n## Tasks\r\n<!-- Required. Additional tasks can be added later. -->\r\n- [ ] Either fix the form setting description; or add the ability to add custom prefixes\r\n- [ ] Ensure a period is placed after each existing prefix option\r\n- [ ] Ensure localization of this description will still be rendered correctly. \r\n- [ ] If adding custom prefixes, ensure they render in the form settings correctly, and are output on the form correctly, and are passed to the donation meta and donor emails correctly\r\n\r\n## Environment\r\n[Give branch 2.2](https://github.com/WordImpress/Give/tree/release/2.2)"},"comment":{"url":"https://api.github.com/repos/WordImpress/Give/issues/comments/405807354","html_url":"https://github.com/WordImpress/Give/issues/3488#issuecomment-405807354","issue_url":"https://api.github.com/repos/WordImpress/Give/issues/3488","id":405807354,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTgwNzM1NA==","user":{"login":"mehul0810","id":1852711,"node_id":"MDQ6VXNlcjE4NTI3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1852711?v=4","gravatar_id":"","url":"https://api.github.com/users/mehul0810","html_url":"https://github.com/mehul0810","followers_url":"https://api.github.com/users/mehul0810/followers","following_url":"https://api.github.com/users/mehul0810/following{/other_user}","gists_url":"https://api.github.com/users/mehul0810/gists{/gist_id}","starred_url":"https://api.github.com/users/mehul0810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehul0810/subscriptions","organizations_url":"https://api.github.com/users/mehul0810/orgs","repos_url":"https://api.github.com/users/mehul0810/repos","events_url":"https://api.github.com/users/mehul0810/events{/privacy}","received_events_url":"https://api.github.com/users/mehul0810/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T04:45:38Z","updated_at":"2018-07-18T04:45:38Z","author_association":"CONTRIBUTOR","body":"## Slack Call Summary\r\nParticipants: @ravinderk @mehul0810\r\nTopic: Discussion about the change requested to add period at the end of the title prefix by default\r\nResult: I'll not add period at the end of the title prefix automatically even if the title prefix selected in admin is not having a period in the end. Only the default title prefixes ( i.e. `Mr.`, `Mrs.`, and `Ms.` ) will have a period in the end."}}
{"actor":{"display_login":"mehul0810"}}