{"action":"opened","number":2356,"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356","id":232003029,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDAzMDI5","html_url":"https://github.com/mattermost/mattermost-mobile/pull/2356","diff_url":"https://github.com/mattermost/mattermost-mobile/pull/2356.diff","patch_url":"https://github.com/mattermost/mattermost-mobile/pull/2356.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/2356","number":2356,"state":"open","locked":false,"title":"[MM-12353] Add feature to render jumbo emoji and unwrapped Emoji component with Text when rendering message containing emoji/s only","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n1. unwrapped Emoji component with Text when rendering message containing emoji/s only.  This fixes the issue of clipping bottom part of emoji.\r\n2. Add feature to render jumbo emoji.\r\n\r\nNotable differences of how this renders jumbo emoji from the desktop:\r\n- Only render jumbo emoji when it has max 4 emojis.  Greater than that will render default (small) size \r\n(Desktop)\r\n![screen shot 2018-11-19 at 10 50 15 pm](https://user-images.githubusercontent.com/5334504/48714369-90285780-ec4d-11e8-9409-9669a8c39d11.png)\r\n(Mobile app)\r\n![screen shot 2018-11-19 at 10 50 33 pm](https://user-images.githubusercontent.com/5334504/48714426-aafacc00-ec4d-11e8-898f-e0e02b583664.png)\r\n\r\n- Message with invalid emoji or non-existing custom emoji will render default (small) size\r\n(Desktop)\r\n![screen shot 2018-11-19 at 10 54 03 pm](https://user-images.githubusercontent.com/5334504/48714816-80f5d980-ec4e-11e8-97ea-8541126dbb80.png)\r\n(Mobile app)\r\n![screen shot 2018-11-19 at 10 53 52 pm](https://user-images.githubusercontent.com/5334504/48714834-881ce780-ec4e-11e8-81ea-6a4126496eaa.png)\r\n\r\n\r\n#### Ticket Link\r\nJira ticket: [MM-12353](https://mattermost.atlassian.net/browse/MM-12353)\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Has UI changes\r\n\r\n#### Device Information\r\nThis PR was tested on: [iOS simulator and Android emulator] \r\n\r\n#### Screenshots\r\niOS screenshots (Mattermost theme):\r\n![screen shot 2018-11-19 at 10 08 29 pm](https://user-images.githubusercontent.com/5334504/48714011-ad105b00-ec4c-11e8-9983-a46b715f22aa.png)\r\n![screen shot 2018-11-19 at 10 08 42 pm](https://user-images.githubusercontent.com/5334504/48714035-b8638680-ec4c-11e8-9984-e8e8c90501b3.png)\r\n\r\nAndroid screenshots (Windows dark theme):\r\n![screen shot 2018-11-19 at 10 19 15 pm](https://user-images.githubusercontent.com/5334504/48714078-d4672800-ec4c-11e8-947a-b45ae5cb9e95.png)\r\n![screen shot 2018-11-19 at 10 19 31 pm](https://user-images.githubusercontent.com/5334504/48714080-da5d0900-ec4c-11e8-9e58-d7fdb5b8341b.png)\r\n","created_at":"2018-11-19T14:59:40Z","updated_at":"2018-11-19T14:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":460355330,"node_id":"MDU6TGFiZWw0NjAzNTUzMzA=","url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/15","html_url":"https://github.com/mattermost/mattermost-mobile/milestone/15","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/15/labels","id":3696667,"node_id":"MDk6TWlsZXN0b25lMzY5NjY2Nw==","number":15,"title":"1.15","description":"","creator":{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":20,"state":"open","created_at":"2018-09-28T13:49:30Z","updated_at":"2018-11-19T14:59:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/2356/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/da1c087994cb3b48ef63054b0da71b1fa7e9e31c","head":{"label":"saturninoabril:MM-12353","ref":"MM-12353","sha":"da1c087994cb3b48ef63054b0da71b1fa7e9e31c","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"repo":{"id":82983247,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk4MzI0Nw==","name":"mattermost-mobile","full_name":"saturninoabril/mattermost-mobile","private":false,"owner":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saturninoabril/mattermost-mobile","description":null,"fork":true,"url":"https://api.github.com/repos/saturninoabril/mattermost-mobile","forks_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/saturninoabril/mattermost-mobile/deployments","created_at":"2017-02-23T23:59:11Z","updated_at":"2018-11-15T11:00:37Z","pushed_at":"2018-11-19T14:30:05Z","git_url":"git://github.com/saturninoabril/mattermost-mobile.git","ssh_url":"git@github.com:saturninoabril/mattermost-mobile.git","clone_url":"https://github.com/saturninoabril/mattermost-mobile.git","svn_url":"https://github.com/saturninoabril/mattermost-mobile","homepage":null,"size":28157,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"ec58d9098038aefcef90016e804cd028bc25b246","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"node_id":"MDEwOlJlcG9zaXRvcnk3MDI2NTcyNA==","name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","private":false,"owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2018-11-19T10:49:03Z","pushed_at":"2018-11-19T14:36:49Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":29951,"stargazers_count":541,"watchers_count":541,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":265,"open_issues":25,"watchers":541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/2356"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/2356"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/2356/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/2356/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/da1c087994cb3b48ef63054b0da71b1fa7e9e31c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":564,"deletions":0,"changed_files":8}}
{"actor":{"display_login":"saturninoabril"}}