{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/241699593","pull_request_review_id":185037798,"id":241699593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY5OTU5Mw==","diff_hunk":"@@ -610,17 +615,12 @@ wait_request(time_t waittime, priority_socks *scks)\n #endif\n \t\t\tif(prio_sock_processed) {","path":"src/lib/Libnet/net_server.c","position":null,"original_position":96,"commit_id":"574eed4e557eed0b0e7e6cac28c96612f801a271","original_commit_id":"d08960a4411c4ca786fe21e240aa5494504001cb","user":{"login":"visheshh","id":18674605,"node_id":"MDQ6VXNlcjE4Njc0NjA1","avatar_url":"https://avatars0.githubusercontent.com/u/18674605?v=4","gravatar_id":"","url":"https://api.github.com/users/visheshh","html_url":"https://github.com/visheshh","followers_url":"https://api.github.com/users/visheshh/followers","following_url":"https://api.github.com/users/visheshh/following{/other_user}","gists_url":"https://api.github.com/users/visheshh/gists{/gist_id}","starred_url":"https://api.github.com/users/visheshh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visheshh/subscriptions","organizations_url":"https://api.github.com/users/visheshh/orgs","repos_url":"https://api.github.com/users/visheshh/repos","events_url":"https://api.github.com/users/visheshh/events{/privacy}","received_events_url":"https://api.github.com/users/visheshh/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-12-14T09:59:28Z","updated_at":"2018-12-14T09:59:28Z","html_url":"https://github.com/PBSPro/pbspro/pull/860#discussion_r241699593","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/860","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/241699593"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/860#discussion_r241699593"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/860"}},"in_reply_to_id":241692337},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/860","id":226027552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDI3NTUy","html_url":"https://github.com/PBSPro/pbspro/pull/860","diff_url":"https://github.com/PBSPro/pbspro/pull/860.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/860.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/860","number":860,"state":"open","locked":false,"title":"Interleave TCP/TPP better","user":{"login":"visheshh","id":18674605,"node_id":"MDQ6VXNlcjE4Njc0NjA1","avatar_url":"https://avatars0.githubusercontent.com/u/18674605?v=4","gravatar_id":"","url":"https://api.github.com/users/visheshh","html_url":"https://github.com/visheshh","followers_url":"https://api.github.com/users/visheshh/followers","following_url":"https://api.github.com/users/visheshh/following{/other_user}","gists_url":"https://api.github.com/users/visheshh/gists{/gist_id}","starred_url":"https://api.github.com/users/visheshh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visheshh/subscriptions","organizations_url":"https://api.github.com/users/visheshh/orgs","repos_url":"https://api.github.com/users/visheshh/repos","events_url":"https://api.github.com/users/visheshh/events{/privacy}","received_events_url":"https://api.github.com/users/visheshh/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\nInterleave TCP/TPP better\r\n#### Affected Platform(s)\r\nAll\r\n\r\n#### Cause / Analysis / Design\r\nRequests from front end commands, scheduler, server, and moms need to be treated at a different priority level to ensure that the high priority events are handled sooner instead of waiting on lower priority events.\r\n\r\nRPP messages at times can block commands and scheduler run commands until the server has processed all of the ones in the queue as do_rpp is called infinitely for a rpp_request\r\n\r\n#### Solution Description\r\ncheck for the active scheduler sockets and do a select read operation on the sockets to process them first .\r\ndo_rpp is only called 3 times for a rpp_request\r\n\r\n#### Testing logs/output\r\n[Test logs.txt](https://github.com/PBSPro/pbspro/files/2518542/Test.logs.txt)\r\n[multiple_sockets_test.txt](https://github.com/PBSPro/pbspro/files/2518911/multiple_sockets_test.txt)\r\n\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n   - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [x] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n   - [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n\r\n","created_at":"2018-10-26T09:12:37Z","updated_at":"2018-12-14T09:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dea52dc47c7e1179d8c703d047e19541b967f92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/860/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/860/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/860/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/574eed4e557eed0b0e7e6cac28c96612f801a271","head":{"label":"visheshh:priority_sockets","ref":"priority_sockets","sha":"574eed4e557eed0b0e7e6cac28c96612f801a271","user":{"login":"visheshh","id":18674605,"node_id":"MDQ6VXNlcjE4Njc0NjA1","avatar_url":"https://avatars0.githubusercontent.com/u/18674605?v=4","gravatar_id":"","url":"https://api.github.com/users/visheshh","html_url":"https://github.com/visheshh","followers_url":"https://api.github.com/users/visheshh/followers","following_url":"https://api.github.com/users/visheshh/following{/other_user}","gists_url":"https://api.github.com/users/visheshh/gists{/gist_id}","starred_url":"https://api.github.com/users/visheshh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visheshh/subscriptions","organizations_url":"https://api.github.com/users/visheshh/orgs","repos_url":"https://api.github.com/users/visheshh/repos","events_url":"https://api.github.com/users/visheshh/events{/privacy}","received_events_url":"https://api.github.com/users/visheshh/received_events","type":"User","site_admin":false},"repo":{"id":60754003,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc1NDAwMw==","name":"pbspro","full_name":"visheshh/pbspro","private":false,"owner":{"login":"visheshh","id":18674605,"node_id":"MDQ6VXNlcjE4Njc0NjA1","avatar_url":"https://avatars0.githubusercontent.com/u/18674605?v=4","gravatar_id":"","url":"https://api.github.com/users/visheshh","html_url":"https://github.com/visheshh","followers_url":"https://api.github.com/users/visheshh/followers","following_url":"https://api.github.com/users/visheshh/following{/other_user}","gists_url":"https://api.github.com/users/visheshh/gists{/gist_id}","starred_url":"https://api.github.com/users/visheshh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visheshh/subscriptions","organizations_url":"https://api.github.com/users/visheshh/orgs","repos_url":"https://api.github.com/users/visheshh/repos","events_url":"https://api.github.com/users/visheshh/events{/privacy}","received_events_url":"https://api.github.com/users/visheshh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/visheshh/pbspro","description":null,"fork":true,"url":"https://api.github.com/repos/visheshh/pbspro","forks_url":"https://api.github.com/repos/visheshh/pbspro/forks","keys_url":"https://api.github.com/repos/visheshh/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/visheshh/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/visheshh/pbspro/teams","hooks_url":"https://api.github.com/repos/visheshh/pbspro/hooks","issue_events_url":"https://api.github.com/repos/visheshh/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/visheshh/pbspro/events","assignees_url":"https://api.github.com/repos/visheshh/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/visheshh/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/visheshh/pbspro/tags","blobs_url":"https://api.github.com/repos/visheshh/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/visheshh/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/visheshh/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/visheshh/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/visheshh/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/visheshh/pbspro/languages","stargazers_url":"https://api.github.com/repos/visheshh/pbspro/stargazers","contributors_url":"https://api.github.com/repos/visheshh/pbspro/contributors","subscribers_url":"https://api.github.com/repos/visheshh/pbspro/subscribers","subscription_url":"https://api.github.com/repos/visheshh/pbspro/subscription","commits_url":"https://api.github.com/repos/visheshh/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/visheshh/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/visheshh/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/visheshh/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/visheshh/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/visheshh/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/visheshh/pbspro/merges","archive_url":"https://api.github.com/repos/visheshh/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/visheshh/pbspro/downloads","issues_url":"https://api.github.com/repos/visheshh/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/visheshh/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/visheshh/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/visheshh/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/visheshh/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/visheshh/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/visheshh/pbspro/deployments","created_at":"2016-06-09T06:24:51Z","updated_at":"2018-11-28T08:13:11Z","pushed_at":"2018-12-14T09:58:54Z","git_url":"git://github.com/visheshh/pbspro.git","ssh_url":"git@github.com:visheshh/pbspro.git","clone_url":"https://github.com/visheshh/pbspro.git","svn_url":"https://github.com/visheshh/pbspro","homepage":null,"size":16997,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"1133462e065e5378eb1d5ac91ab4a98a846972dc","user":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA4MjA3Mg==","name":"pbspro","full_name":"PBSPro/pbspro","private":false,"owner":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-12-14T07:36:08Z","pushed_at":"2018-12-14T09:58:56Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":16953,"stargazers_count":222,"watchers_count":222,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":169,"open_issues":21,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/860"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/860"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/860"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/574eed4e557eed0b0e7e6cac28c96612f801a271"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"visheshh"}}