{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/230938281","pull_request_review_id":171790575,"id":230938281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkzODI4MQ==","diff_hunk":"@@ -0,0 +1,54 @@\n+/* This file is part of VoltDB.\n+ * Copyright (C) 2008-2018 VoltDB Inc.\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License as\n+ * published by the Free Software Foundation, either version 3 of the\n+ * License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License\n+ * along with VoltDB.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+/* WARNING: THIS FILE IS AUTO-GENERATED\n+            DO NOT MODIFY THIS SOURCE\n+            ALL CHANGES MUST BE MADE IN THE CATALOG GENERATOR */\n+\n+package org.voltdb.catalog;\n+\n+/**\n+ * Command to make changes to a catalog.\n+ * @author Yiqun Zhang\n+ * @since 8.4\n+ */\n+public final class CatalogCommand {\n+    public final char cmd;\n+    public final String path;\n+    public final String arg1;\n+    public final String arg2;\n+\n+    /**\n+     * Create a catalog command from a serialized string.\n+     * @param cmdStr serialized command string.\n+     */\n+    public CatalogCommand(String cmdStr) {\n+        int pos = 0;\n+        cmdStr = cmdStr.trim();\n+        cmd = cmdStr.charAt(pos++);\n+        while (cmdStr.charAt(pos++) != ' ');","path":"src/catgen/in/javasrc/CatalogCommand.java","position":43,"original_position":43,"commit_id":"eabcde1496c3e13f19cdb0b799c26db454016b93","original_commit_id":"eabcde1496c3e13f19cdb0b799c26db454016b93","user":{"login":"n3world","id":4061525,"node_id":"MDQ6VXNlcjQwNjE1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4061525?v=4","gravatar_id":"","url":"https://api.github.com/users/n3world","html_url":"https://github.com/n3world","followers_url":"https://api.github.com/users/n3world/followers","following_url":"https://api.github.com/users/n3world/following{/other_user}","gists_url":"https://api.github.com/users/n3world/gists{/gist_id}","starred_url":"https://api.github.com/users/n3world/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3world/subscriptions","organizations_url":"https://api.github.com/users/n3world/orgs","repos_url":"https://api.github.com/users/n3world/repos","events_url":"https://api.github.com/users/n3world/events{/privacy}","received_events_url":"https://api.github.com/users/n3world/received_events","type":"User","site_admin":false},"body":"Wouldn't pos = cmdStr.indexOf(' ', pos) + 1; be a better way to do this?","created_at":"2018-11-05T22:30:36Z","updated_at":"2018-11-05T22:53:54Z","html_url":"https://github.com/VoltDB/voltdb/pull/5727#discussion_r230938281","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/230938281"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/5727#discussion_r230938281"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727","id":228489378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDg5Mzc4","html_url":"https://github.com/VoltDB/voltdb/pull/5727","diff_url":"https://github.com/VoltDB/voltdb/pull/5727.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/5727.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/5727","number":5727,"state":"open","locked":false,"title":"Catalog code refactor.","user":{"login":"yzhang1991","id":6643318,"node_id":"MDQ6VXNlcjY2NDMzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6643318?v=4","gravatar_id":"","url":"https://api.github.com/users/yzhang1991","html_url":"https://github.com/yzhang1991","followers_url":"https://api.github.com/users/yzhang1991/followers","following_url":"https://api.github.com/users/yzhang1991/following{/other_user}","gists_url":"https://api.github.com/users/yzhang1991/gists{/gist_id}","starred_url":"https://api.github.com/users/yzhang1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzhang1991/subscriptions","organizations_url":"https://api.github.com/users/yzhang1991/orgs","repos_url":"https://api.github.com/users/yzhang1991/repos","events_url":"https://api.github.com/users/yzhang1991/events{/privacy}","received_events_url":"https://api.github.com/users/yzhang1991/received_events","type":"User","site_admin":false},"body":"Catalog APIs are pulled out to separate classes \"CatalogOperator\" and \"CatalogSerializer\".\r\nThe next step will be making them into a JNI library so it will become a black box.","created_at":"2018-11-05T20:59:16Z","updated_at":"2018-11-05T22:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f01afabce6185fbbbf9e2c65e2f40e9e43da9a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/5727/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/eabcde1496c3e13f19cdb0b799c26db454016b93","head":{"label":"VoltDB:ENG-14805-licensing","ref":"ENG-14805-licensing","sha":"eabcde1496c3e13f19cdb0b799c26db454016b93","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","private":false,"owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2018-11-05T20:24:09Z","pushed_at":"2018-11-05T22:47:30Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":580158,"stargazers_count":1259,"watchers_count":1259,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":344,"open_issues":79,"watchers":1259,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"f147174f9149d1c7829f895f15809a5a92115434","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","private":false,"owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2018-11-05T20:24:09Z","pushed_at":"2018-11-05T22:47:30Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":580158,"stargazers_count":1259,"watchers_count":1259,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":344,"open_issues":79,"watchers":1259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/5727"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/5727"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/5727/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5727/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/eabcde1496c3e13f19cdb0b799c26db454016b93"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"n3world"}}