{"action":"created","comment":{"url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/comments/234145239","pull_request_review_id":175725899,"id":234145239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE0NTIzOQ==","diff_hunk":"@@ -62,11 +84,14 @@ module.exports = (event, context) => {\n     headers['Content-Type'] = 'text/html';\n     content = fs.readFileSync(`${__dirname}/dist/index.html`).toString();","path":"dashboard/of-cloud-dashboard/handler.js","position":38,"original_position":38,"commit_id":"6bc03c0398421f5e128fa636a8b1f50519ffd520","original_commit_id":"6bc03c0398421f5e128fa636a8b1f50519ffd520","user":{"login":"alexellis","id":6358735,"node_id":"MDQ6VXNlcjYzNTg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"body":"Please raise an Issue to move `fs.readFileSync` to `fs.readFile` everywhere in this file. ","created_at":"2018-11-16T09:49:49Z","updated_at":"2018-11-16T09:49:49Z","html_url":"https://github.com/openfaas/openfaas-cloud/pull/295#discussion_r234145239","pull_request_url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/comments/234145239"},"html":{"href":"https://github.com/openfaas/openfaas-cloud/pull/295#discussion_r234145239"},"pull_request":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295","id":222971583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTcxNTgz","html_url":"https://github.com/openfaas/openfaas-cloud/pull/295","diff_url":"https://github.com/openfaas/openfaas-cloud/pull/295.diff","patch_url":"https://github.com/openfaas/openfaas-cloud/pull/295.patch","issue_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/295","number":295,"state":"open","locked":false,"title":"Feature/logout","user":{"login":"bartsmykla","id":11655498,"node_id":"MDQ6VXNlcjExNjU1NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/11655498?v=4","gravatar_id":"","url":"https://api.github.com/users/bartsmykla","html_url":"https://github.com/bartsmykla","followers_url":"https://api.github.com/users/bartsmykla/followers","following_url":"https://api.github.com/users/bartsmykla/following{/other_user}","gists_url":"https://api.github.com/users/bartsmykla/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsmykla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsmykla/subscriptions","organizations_url":"https://api.github.com/users/bartsmykla/orgs","repos_url":"https://api.github.com/users/bartsmykla/repos","events_url":"https://api.github.com/users/bartsmykla/events{/privacy}","received_events_url":"https://api.github.com/users/bartsmykla/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdded `Logout` button in header's navbar which is calling `/logout` endpoint which is overriding `openfaas_cloud_token` cookie.\r\nCloses https://github.com/openfaas/openfaas-cloud/issues/283\r\nCloses https://github.com/openfaas/openfaas-cloud/issues/256\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nManually tried signing in and out few times using logout button in nav bar and also pure endpoint.\r\n\r\n## How are existing users impacted? What migration steps/scripts do we need?\r\nThere is no need to do migration.\r\n\r\n\r\n## Checklist:\r\n\r\nI have:\r\n\r\n- [ ] updated the documentation and/or roadmap (if required)\r\n- [x] read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] signed-off my commits with `git commit -s`\r\n- [ ] added unit tests\r\n","created_at":"2018-10-15T16:43:05Z","updated_at":"2018-11-16T09:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba1537c4660ea96a39ceb8668b771bb260df4e6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295/commits","review_comments_url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295/comments","review_comment_url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/295/comments","statuses_url":"https://api.github.com/repos/openfaas/openfaas-cloud/statuses/6bc03c0398421f5e128fa636a8b1f50519ffd520","head":{"label":"bartsmykla:feature/logout","ref":"feature/logout","sha":"6bc03c0398421f5e128fa636a8b1f50519ffd520","user":{"login":"bartsmykla","id":11655498,"node_id":"MDQ6VXNlcjExNjU1NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/11655498?v=4","gravatar_id":"","url":"https://api.github.com/users/bartsmykla","html_url":"https://github.com/bartsmykla","followers_url":"https://api.github.com/users/bartsmykla/followers","following_url":"https://api.github.com/users/bartsmykla/following{/other_user}","gists_url":"https://api.github.com/users/bartsmykla/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsmykla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsmykla/subscriptions","organizations_url":"https://api.github.com/users/bartsmykla/orgs","repos_url":"https://api.github.com/users/bartsmykla/repos","events_url":"https://api.github.com/users/bartsmykla/events{/privacy}","received_events_url":"https://api.github.com/users/bartsmykla/received_events","type":"User","site_admin":false},"repo":{"id":146741029,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3NDEwMjk=","name":"openfaas-cloud","full_name":"bartsmykla/openfaas-cloud","private":false,"owner":{"login":"bartsmykla","id":11655498,"node_id":"MDQ6VXNlcjExNjU1NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/11655498?v=4","gravatar_id":"","url":"https://api.github.com/users/bartsmykla","html_url":"https://github.com/bartsmykla","followers_url":"https://api.github.com/users/bartsmykla/followers","following_url":"https://api.github.com/users/bartsmykla/following{/other_user}","gists_url":"https://api.github.com/users/bartsmykla/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsmykla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsmykla/subscriptions","organizations_url":"https://api.github.com/users/bartsmykla/orgs","repos_url":"https://api.github.com/users/bartsmykla/repos","events_url":"https://api.github.com/users/bartsmykla/events{/privacy}","received_events_url":"https://api.github.com/users/bartsmykla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bartsmykla/openfaas-cloud","description":"OpenFaaS Cloud - GitOps for your functions with native GitHub integrations","fork":true,"url":"https://api.github.com/repos/bartsmykla/openfaas-cloud","forks_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/forks","keys_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/teams","hooks_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/hooks","issue_events_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/events","assignees_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/tags","blobs_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/languages","stargazers_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/stargazers","contributors_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/contributors","subscribers_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/subscribers","subscription_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/subscription","commits_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/merges","archive_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/downloads","issues_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/labels{/name}","releases_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/bartsmykla/openfaas-cloud/deployments","created_at":"2018-08-30T11:39:51Z","updated_at":"2018-10-30T09:24:18Z","pushed_at":"2018-11-01T15:53:10Z","git_url":"git://github.com/bartsmykla/openfaas-cloud.git","ssh_url":"git@github.com:bartsmykla/openfaas-cloud.git","clone_url":"https://github.com/bartsmykla/openfaas-cloud.git","svn_url":"https://github.com/bartsmykla/openfaas-cloud","homepage":"https://blog.alexellis.io/introducing-openfaas-cloud/","size":20592,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfaas:master","ref":"master","sha":"ce909db927fefe98038b41544e7f5f7855fe4933","user":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"repo":{"id":109512938,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1MTI5Mzg=","name":"openfaas-cloud","full_name":"openfaas/openfaas-cloud","private":false,"owner":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openfaas/openfaas-cloud","description":"OpenFaaS Cloud: multi-user serverless functions managed with git","fork":false,"url":"https://api.github.com/repos/openfaas/openfaas-cloud","forks_url":"https://api.github.com/repos/openfaas/openfaas-cloud/forks","keys_url":"https://api.github.com/repos/openfaas/openfaas-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfaas/openfaas-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfaas/openfaas-cloud/teams","hooks_url":"https://api.github.com/repos/openfaas/openfaas-cloud/hooks","issue_events_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/openfaas/openfaas-cloud/events","assignees_url":"https://api.github.com/repos/openfaas/openfaas-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/openfaas/openfaas-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/openfaas/openfaas-cloud/tags","blobs_url":"https://api.github.com/repos/openfaas/openfaas-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfaas/openfaas-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfaas/openfaas-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfaas/openfaas-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfaas/openfaas-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/openfaas/openfaas-cloud/languages","stargazers_url":"https://api.github.com/repos/openfaas/openfaas-cloud/stargazers","contributors_url":"https://api.github.com/repos/openfaas/openfaas-cloud/contributors","subscribers_url":"https://api.github.com/repos/openfaas/openfaas-cloud/subscribers","subscription_url":"https://api.github.com/repos/openfaas/openfaas-cloud/subscription","commits_url":"https://api.github.com/repos/openfaas/openfaas-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfaas/openfaas-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfaas/openfaas-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfaas/openfaas-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/openfaas/openfaas-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfaas/openfaas-cloud/merges","archive_url":"https://api.github.com/repos/openfaas/openfaas-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfaas/openfaas-cloud/downloads","issues_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/openfaas/openfaas-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/openfaas/openfaas-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfaas/openfaas-cloud/labels{/name}","releases_url":"https://api.github.com/repos/openfaas/openfaas-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/openfaas/openfaas-cloud/deployments","created_at":"2017-11-04T16:54:15Z","updated_at":"2018-11-16T09:10:56Z","pushed_at":"2018-11-16T09:10:53Z","git_url":"git://github.com/openfaas/openfaas-cloud.git","ssh_url":"git@github.com:openfaas/openfaas-cloud.git","clone_url":"https://github.com/openfaas/openfaas-cloud.git","svn_url":"https://github.com/openfaas/openfaas-cloud","homepage":"https://blog.alexellis.io/introducing-openfaas-cloud/","size":22691,"stargazers_count":202,"watchers_count":202,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":50,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295"},"html":{"href":"https://github.com/openfaas/openfaas-cloud/pull/295"},"issue":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/295"},"comments":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/openfaas/openfaas-cloud/statuses/6bc03c0398421f5e128fa636a8b1f50519ffd520"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexellis"}}