{"action":"created","issue":{"url":"https://api.github.com/repos/kolide/launcher/issues/338","repository_url":"https://api.github.com/repos/kolide/launcher","labels_url":"https://api.github.com/repos/kolide/launcher/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/kolide/launcher/issues/338/comments","events_url":"https://api.github.com/repos/kolide/launcher/issues/338/events","html_url":"https://github.com/kolide/launcher/pull/338","id":348093641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTI1ODI4","number":338,"title":"Fix - MacOS distribution package","user":{"login":"m6a-UdS","id":6933233,"node_id":"MDQ6VXNlcjY5MzMyMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/6933233?v=4","gravatar_id":"","url":"https://api.github.com/users/m6a-UdS","html_url":"https://github.com/m6a-UdS","followers_url":"https://api.github.com/users/m6a-UdS/followers","following_url":"https://api.github.com/users/m6a-UdS/following{/other_user}","gists_url":"https://api.github.com/users/m6a-UdS/gists{/gist_id}","starred_url":"https://api.github.com/users/m6a-UdS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m6a-UdS/subscriptions","organizations_url":"https://api.github.com/users/m6a-UdS/orgs","repos_url":"https://api.github.com/users/m6a-UdS/repos","events_url":"https://api.github.com/users/m6a-UdS/events{/privacy}","received_events_url":"https://api.github.com/users/m6a-UdS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-06T21:48:27Z","updated_at":"2018-08-07T15:50:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kolide/launcher/pulls/338","html_url":"https://github.com/kolide/launcher/pull/338","diff_url":"https://github.com/kolide/launcher/pull/338.diff","patch_url":"https://github.com/kolide/launcher/pull/338.patch"},"body":"Some MDMs (like SimpleMDM) require the OSX package (`.pkg`) to contain a \"distribution\" file, and therefore require the command `productbuild` to be run after `pkgbuild` in order for the package to be accepted by SimpleMDM.\r\n\r\nI was unsure whether it would be better to output both versions (with and without the distribution file), the choice is done at the line 553, but could be modified to include both.\r\n\r\nI can confirm it works and gets distributed and installed fine with SimpleMDM, but it would be a good idea to also check with other MDMs."},"comment":{"url":"https://api.github.com/repos/kolide/launcher/issues/comments/411105546","html_url":"https://github.com/kolide/launcher/pull/338#issuecomment-411105546","issue_url":"https://api.github.com/repos/kolide/launcher/issues/338","id":411105546,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTEwNTU0Ng==","user":{"login":"zwass","id":575602,"node_id":"MDQ6VXNlcjU3NTYwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/575602?v=4","gravatar_id":"","url":"https://api.github.com/users/zwass","html_url":"https://github.com/zwass","followers_url":"https://api.github.com/users/zwass/followers","following_url":"https://api.github.com/users/zwass/following{/other_user}","gists_url":"https://api.github.com/users/zwass/gists{/gist_id}","starred_url":"https://api.github.com/users/zwass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwass/subscriptions","organizations_url":"https://api.github.com/users/zwass/orgs","repos_url":"https://api.github.com/users/zwass/repos","events_url":"https://api.github.com/users/zwass/events{/privacy}","received_events_url":"https://api.github.com/users/zwass/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T15:50:22Z","updated_at":"2018-08-07T15:50:22Z","author_association":"CONTRIBUTOR","body":"Is it sufficient to include the `distribution.xml` in the generated package? Or must we also run `productbuild`?"}}
{"actor":{"display_login":"zwass"}}