{"action":"closed","number":4564,"pull_request":{"url":"https://api.github.com/repos/moment/moment/pulls/4564","id":181847217,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxODQ3MjE3","html_url":"https://github.com/moment/moment/pull/4564","diff_url":"https://github.com/moment/moment/pull/4564.diff","patch_url":"https://github.com/moment/moment/pull/4564.patch","issue_url":"https://api.github.com/repos/moment/moment/issues/4564","number":4564,"state":"closed","locked":false,"title":"[bugfix] Avoid using trim()","user":{"login":"ashsearle","id":1166814,"node_id":"MDQ6VXNlcjExNjY4MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1166814?v=4","gravatar_id":"","url":"https://api.github.com/users/ashsearle","html_url":"https://github.com/ashsearle","followers_url":"https://api.github.com/users/ashsearle/followers","following_url":"https://api.github.com/users/ashsearle/following{/other_user}","gists_url":"https://api.github.com/users/ashsearle/gists{/gist_id}","starred_url":"https://api.github.com/users/ashsearle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashsearle/subscriptions","organizations_url":"https://api.github.com/users/ashsearle/orgs","repos_url":"https://api.github.com/users/ashsearle/repos","events_url":"https://api.github.com/users/ashsearle/events{/privacy}","received_events_url":"https://api.github.com/users/ashsearle/received_events","type":"User","site_admin":false},"body":"Fixes #4547 - trim() isn't available in old IE / compatibility modes, and moment docs still claim support for IE 8.","created_at":"2018-04-16T12:39:38Z","updated_at":"2018-06-01T05:40:31Z","closed_at":"2018-06-01T05:40:31Z","merged_at":"2018-06-01T05:40:30Z","merge_commit_sha":"a831fc7e2694281ce31e4f090bbcf90a690f0277","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moment/moment/pulls/4564/commits","review_comments_url":"https://api.github.com/repos/moment/moment/pulls/4564/comments","review_comment_url":"https://api.github.com/repos/moment/moment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moment/moment/issues/4564/comments","statuses_url":"https://api.github.com/repos/moment/moment/statuses/f26432cff0ec494176de87b0ca0026fa0ea39b34","head":{"label":"ashsearle:fix/4547","ref":"fix/4547","sha":"f26432cff0ec494176de87b0ca0026fa0ea39b34","user":{"login":"ashsearle","id":1166814,"node_id":"MDQ6VXNlcjExNjY4MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1166814?v=4","gravatar_id":"","url":"https://api.github.com/users/ashsearle","html_url":"https://github.com/ashsearle","followers_url":"https://api.github.com/users/ashsearle/followers","following_url":"https://api.github.com/users/ashsearle/following{/other_user}","gists_url":"https://api.github.com/users/ashsearle/gists{/gist_id}","starred_url":"https://api.github.com/users/ashsearle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashsearle/subscriptions","organizations_url":"https://api.github.com/users/ashsearle/orgs","repos_url":"https://api.github.com/users/ashsearle/repos","events_url":"https://api.github.com/users/ashsearle/events{/privacy}","received_events_url":"https://api.github.com/users/ashsearle/received_events","type":"User","site_admin":false},"repo":{"id":96909931,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkwOTkzMQ==","name":"moment","full_name":"ashsearle/moment","owner":{"login":"ashsearle","id":1166814,"node_id":"MDQ6VXNlcjExNjY4MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1166814?v=4","gravatar_id":"","url":"https://api.github.com/users/ashsearle","html_url":"https://github.com/ashsearle","followers_url":"https://api.github.com/users/ashsearle/followers","following_url":"https://api.github.com/users/ashsearle/following{/other_user}","gists_url":"https://api.github.com/users/ashsearle/gists{/gist_id}","starred_url":"https://api.github.com/users/ashsearle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashsearle/subscriptions","organizations_url":"https://api.github.com/users/ashsearle/orgs","repos_url":"https://api.github.com/users/ashsearle/repos","events_url":"https://api.github.com/users/ashsearle/events{/privacy}","received_events_url":"https://api.github.com/users/ashsearle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashsearle/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":true,"url":"https://api.github.com/repos/ashsearle/moment","forks_url":"https://api.github.com/repos/ashsearle/moment/forks","keys_url":"https://api.github.com/repos/ashsearle/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashsearle/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashsearle/moment/teams","hooks_url":"https://api.github.com/repos/ashsearle/moment/hooks","issue_events_url":"https://api.github.com/repos/ashsearle/moment/issues/events{/number}","events_url":"https://api.github.com/repos/ashsearle/moment/events","assignees_url":"https://api.github.com/repos/ashsearle/moment/assignees{/user}","branches_url":"https://api.github.com/repos/ashsearle/moment/branches{/branch}","tags_url":"https://api.github.com/repos/ashsearle/moment/tags","blobs_url":"https://api.github.com/repos/ashsearle/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashsearle/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashsearle/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashsearle/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashsearle/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/ashsearle/moment/languages","stargazers_url":"https://api.github.com/repos/ashsearle/moment/stargazers","contributors_url":"https://api.github.com/repos/ashsearle/moment/contributors","subscribers_url":"https://api.github.com/repos/ashsearle/moment/subscribers","subscription_url":"https://api.github.com/repos/ashsearle/moment/subscription","commits_url":"https://api.github.com/repos/ashsearle/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashsearle/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashsearle/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashsearle/moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashsearle/moment/contents/{+path}","compare_url":"https://api.github.com/repos/ashsearle/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashsearle/moment/merges","archive_url":"https://api.github.com/repos/ashsearle/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashsearle/moment/downloads","issues_url":"https://api.github.com/repos/ashsearle/moment/issues{/number}","pulls_url":"https://api.github.com/repos/ashsearle/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/ashsearle/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/ashsearle/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashsearle/moment/labels{/name}","releases_url":"https://api.github.com/repos/ashsearle/moment/releases{/id}","deployments_url":"https://api.github.com/repos/ashsearle/moment/deployments","created_at":"2017-07-11T15:43:09Z","updated_at":"2018-05-30T09:25:21Z","pushed_at":"2018-05-30T09:25:10Z","git_url":"git://github.com/ashsearle/moment.git","ssh_url":"git@github.com:ashsearle/moment.git","clone_url":"https://github.com/ashsearle/moment.git","svn_url":"https://github.com/ashsearle/moment","homepage":"momentjs.com","size":16941,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"moment:develop","ref":"develop","sha":"ad49bd6666de707939e29e6ab4501555b2faaa09","user":{"login":"moment","id":4129662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjk2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4129662?v=4","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"repo":{"id":1424470,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NDcw","name":"moment","full_name":"moment/moment","owner":{"login":"moment","id":4129662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjk2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4129662?v=4","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moment/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":false,"url":"https://api.github.com/repos/moment/moment","forks_url":"https://api.github.com/repos/moment/moment/forks","keys_url":"https://api.github.com/repos/moment/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moment/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moment/moment/teams","hooks_url":"https://api.github.com/repos/moment/moment/hooks","issue_events_url":"https://api.github.com/repos/moment/moment/issues/events{/number}","events_url":"https://api.github.com/repos/moment/moment/events","assignees_url":"https://api.github.com/repos/moment/moment/assignees{/user}","branches_url":"https://api.github.com/repos/moment/moment/branches{/branch}","tags_url":"https://api.github.com/repos/moment/moment/tags","blobs_url":"https://api.github.com/repos/moment/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moment/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moment/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/moment/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moment/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/moment/moment/languages","stargazers_url":"https://api.github.com/repos/moment/moment/stargazers","contributors_url":"https://api.github.com/repos/moment/moment/contributors","subscribers_url":"https://api.github.com/repos/moment/moment/subscribers","subscription_url":"https://api.github.com/repos/moment/moment/subscription","commits_url":"https://api.github.com/repos/moment/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/moment/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/moment/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/moment/moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/moment/moment/contents/{+path}","compare_url":"https://api.github.com/repos/moment/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moment/moment/merges","archive_url":"https://api.github.com/repos/moment/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moment/moment/downloads","issues_url":"https://api.github.com/repos/moment/moment/issues{/number}","pulls_url":"https://api.github.com/repos/moment/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/moment/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/moment/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moment/moment/labels{/name}","releases_url":"https://api.github.com/repos/moment/moment/releases{/id}","deployments_url":"https://api.github.com/repos/moment/moment/deployments","created_at":"2011-03-01T02:46:06Z","updated_at":"2018-06-01T05:37:07Z","pushed_at":"2018-06-01T05:40:30Z","git_url":"git://github.com/moment/moment.git","ssh_url":"git@github.com:moment/moment.git","clone_url":"https://github.com/moment/moment.git","svn_url":"https://github.com/moment/moment","homepage":"momentjs.com","size":16656,"stargazers_count":37181,"watchers_count":37181,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5536,"mirror_url":null,"archived":false,"open_issues_count":283,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5536,"open_issues":283,"watchers":37181,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/moment/moment/pulls/4564"},"html":{"href":"https://github.com/moment/moment/pull/4564"},"issue":{"href":"https://api.github.com/repos/moment/moment/issues/4564"},"comments":{"href":"https://api.github.com/repos/moment/moment/issues/4564/comments"},"review_comments":{"href":"https://api.github.com/repos/moment/moment/pulls/4564/comments"},"review_comment":{"href":"https://api.github.com/repos/moment/moment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moment/moment/pulls/4564/commits"},"statuses":{"href":"https://api.github.com/repos/moment/moment/statuses/f26432cff0ec494176de87b0ca0026fa0ea39b34"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"marwahaha","id":2541209,"node_id":"MDQ6VXNlcjI1NDEyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2541209?v=4","gravatar_id":"","url":"https://api.github.com/users/marwahaha","html_url":"https://github.com/marwahaha","followers_url":"https://api.github.com/users/marwahaha/followers","following_url":"https://api.github.com/users/marwahaha/following{/other_user}","gists_url":"https://api.github.com/users/marwahaha/gists{/gist_id}","starred_url":"https://api.github.com/users/marwahaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marwahaha/subscriptions","organizations_url":"https://api.github.com/users/marwahaha/orgs","repos_url":"https://api.github.com/users/marwahaha/repos","events_url":"https://api.github.com/users/marwahaha/events{/privacy}","received_events_url":"https://api.github.com/users/marwahaha/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"marwahaha"}}