{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/21716","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/21716/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21716/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/21716/events","html_url":"https://github.com/dotnet/coreclr/pull/21716","id":394888819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTAxNTA1","number":21716,"title":"EventPipePayloadDecoder clean-up","user":{"login":"pentp","id":264426,"node_id":"MDQ6VXNlcjI2NDQyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/264426?v=4","gravatar_id":"","url":"https://api.github.com/users/pentp","html_url":"https://github.com/pentp","followers_url":"https://api.github.com/users/pentp/followers","following_url":"https://api.github.com/users/pentp/following{/other_user}","gists_url":"https://api.github.com/users/pentp/gists{/gist_id}","starred_url":"https://api.github.com/users/pentp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentp/subscriptions","organizations_url":"https://api.github.com/users/pentp/orgs","repos_url":"https://api.github.com/users/pentp/repos","events_url":"https://api.github.com/users/pentp/events{/privacy}","received_events_url":"https://api.github.com/users/pentp/received_events","type":"User","site_admin":false},"labels":[{"id":603931945,"node_id":"MDU6TGFiZWw2MDM5MzE5NDU=","url":"https://api.github.com/repos/dotnet/coreclr/labels/area-Tracing","name":"area-Tracing","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-30T17:38:00Z","updated_at":"2018-12-30T17:59:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21716","html_url":"https://github.com/dotnet/coreclr/pull/21716","diff_url":"https://github.com/dotnet/coreclr/pull/21716.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21716.patch"},"body":"Replaced one allocation with a stackalloc and cleaned up some code.\r\nBut the GUID reading code still looks a bit weird..."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/450576697","html_url":"https://github.com/dotnet/coreclr/pull/21716#issuecomment-450576697","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21716","id":450576697,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU3NjY5Nw==","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T17:59:02Z","updated_at":"2018-12-30T17:59:02Z","author_association":"MEMBER","body":"@vancem I see that the EventPipe format is documented at https://github.com/Microsoft/perfview/blob/master/src/TraceEvent/EventPipe/EventSerialization.md . It says \"types are C# type, thus int is a 4 byte little endian integer\". This is conflicting statement: C# types respect machine endianess, and thus they are little endian on little endian machines; and big endian on big endian machines.\r\n\r\nCould you please clarify whether the EventPipe format is supposed to be respect machine endianess; or whether it is supposed to be unconditionally little endian? "}}
{"actor":{"display_login":"jkotas"}}