{"action":"created","comment":{"url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/comments/206920894","pull_request_review_id":142428000,"id":206920894,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkyMDg5NA==","diff_hunk":"@@ -1,25 +1,74 @@\n+//https://techtutorialsx.com/2016/07/21/esp8266-post-requests/\n #include <hackPSUhttp.h>\n \n namespace hackPSU {\n-\tResponse HTTP::GET(String url) {\n-\t    HTTPClient http;\n-\t    Response response;\n-\t    http.begin(url);\n-\t    int httpCode = http.GET();\n-\t\t\n-\t    //httpCode will be negative (or zero) if there is an error\n-\t    if (httpCode > 0){ \t//If the GET call was successful\n-\t\t    response.payload = http.getString(); \n-\t\t    response.responseCode = httpCode;\n-\t    } else {\n-\t\t    response.payload = http.errorToString(httpCode).c_str();\n-\t\t    response.responseCode = httpCode;\n-\t    }\n-\thttp.end();\n-\treturn responseInfo;\n-\t};\n-}\n+\tResponse::GET(String url, String payload, struct headers){\n+\t\tHTTPClient http;","path":"sketch/hackPSUhttp.cpp","position":24,"original_position":24,"commit_id":"dd13a1f73353d4b7d96fe6560eb43e104b8a9ef5","original_commit_id":"dd13a1f73353d4b7d96fe6560eb43e104b8a9ef5","user":{"login":"jmm8046","id":35675433,"node_id":"MDQ6VXNlcjM1Njc1NDMz","avatar_url":"https://avatars1.githubusercontent.com/u/35675433?v=4","gravatar_id":"","url":"https://api.github.com/users/jmm8046","html_url":"https://github.com/jmm8046","followers_url":"https://api.github.com/users/jmm8046/followers","following_url":"https://api.github.com/users/jmm8046/following{/other_user}","gists_url":"https://api.github.com/users/jmm8046/gists{/gist_id}","starred_url":"https://api.github.com/users/jmm8046/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmm8046/subscriptions","organizations_url":"https://api.github.com/users/jmm8046/orgs","repos_url":"https://api.github.com/users/jmm8046/repos","events_url":"https://api.github.com/users/jmm8046/events{/privacy}","received_events_url":"https://api.github.com/users/jmm8046/received_events","type":"User","site_admin":false},"body":"I'm not sure what you mean by malloced so I have no idea if I should change this or not","created_at":"2018-08-01T15:15:27Z","updated_at":"2018-08-01T15:15:28Z","html_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5#discussion_r206920894","pull_request_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/comments/206920894"},"html":{"href":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5#discussion_r206920894"},"pull_request":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5"}},"in_reply_to_id":203592230},"pull_request":{"url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5","id":200085596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDg1NTk2","html_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5","diff_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5.diff","patch_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5.patch","issue_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/5","number":5,"state":"open","locked":false,"title":"Add more functions to HTTP wrapper","user":{"login":"jmm8046","id":35675433,"node_id":"MDQ6VXNlcjM1Njc1NDMz","avatar_url":"https://avatars1.githubusercontent.com/u/35675433?v=4","gravatar_id":"","url":"https://api.github.com/users/jmm8046","html_url":"https://github.com/jmm8046","followers_url":"https://api.github.com/users/jmm8046/followers","following_url":"https://api.github.com/users/jmm8046/following{/other_user}","gists_url":"https://api.github.com/users/jmm8046/gists{/gist_id}","starred_url":"https://api.github.com/users/jmm8046/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmm8046/subscriptions","organizations_url":"https://api.github.com/users/jmm8046/orgs","repos_url":"https://api.github.com/users/jmm8046/repos","events_url":"https://api.github.com/users/jmm8046/events{/privacy}","received_events_url":"https://api.github.com/users/jmm8046/received_events","type":"User","site_admin":false},"body":"what even is github did i do this right?","created_at":"2018-07-09T12:36:37Z","updated_at":"2018-08-01T15:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72522b6a103207c3e83069343ad474346f114724","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/5/comments","statuses_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/statuses/dd13a1f73353d4b7d96fe6560eb43e104b8a9ef5","head":{"label":"Hack-PSU:jmm8046-patch-2","ref":"jmm8046-patch-2","sha":"dd13a1f73353d4b7d96fe6560eb43e104b8a9ef5","user":{"login":"Hack-PSU","id":20320741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzIwNzQx","avatar_url":"https://avatars2.githubusercontent.com/u/20320741?v=4","gravatar_id":"","url":"https://api.github.com/users/Hack-PSU","html_url":"https://github.com/Hack-PSU","followers_url":"https://api.github.com/users/Hack-PSU/followers","following_url":"https://api.github.com/users/Hack-PSU/following{/other_user}","gists_url":"https://api.github.com/users/Hack-PSU/gists{/gist_id}","starred_url":"https://api.github.com/users/Hack-PSU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hack-PSU/subscriptions","organizations_url":"https://api.github.com/users/Hack-PSU/orgs","repos_url":"https://api.github.com/users/Hack-PSU/repos","events_url":"https://api.github.com/users/Hack-PSU/events{/privacy}","received_events_url":"https://api.github.com/users/Hack-PSU/received_events","type":"Organization","site_admin":false},"repo":{"id":133752383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3NTIzODM=","name":"hackPSUF2018-rfid","full_name":"Hack-PSU/hackPSUF2018-rfid","owner":{"login":"Hack-PSU","id":20320741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzIwNzQx","avatar_url":"https://avatars2.githubusercontent.com/u/20320741?v=4","gravatar_id":"","url":"https://api.github.com/users/Hack-PSU","html_url":"https://github.com/Hack-PSU","followers_url":"https://api.github.com/users/Hack-PSU/followers","following_url":"https://api.github.com/users/Hack-PSU/following{/other_user}","gists_url":"https://api.github.com/users/Hack-PSU/gists{/gist_id}","starred_url":"https://api.github.com/users/Hack-PSU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hack-PSU/subscriptions","organizations_url":"https://api.github.com/users/Hack-PSU/orgs","repos_url":"https://api.github.com/users/Hack-PSU/repos","events_url":"https://api.github.com/users/Hack-PSU/events{/privacy}","received_events_url":"https://api.github.com/users/Hack-PSU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid","description":"Nukt","fork":false,"url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid","forks_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/forks","keys_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/teams","hooks_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/hooks","issue_events_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/events{/number}","events_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/events","assignees_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/assignees{/user}","branches_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/branches{/branch}","tags_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/tags","blobs_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/statuses/{sha}","languages_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/languages","stargazers_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/stargazers","contributors_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/contributors","subscribers_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/subscribers","subscription_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/subscription","commits_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/contents/{+path}","compare_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/merges","archive_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/downloads","issues_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues{/number}","pulls_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls{/number}","milestones_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/milestones{/number}","notifications_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/labels{/name}","releases_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/releases{/id}","deployments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/deployments","created_at":"2018-05-17T03:14:19Z","updated_at":"2018-07-13T00:22:40Z","pushed_at":"2018-07-31T22:46:31Z","git_url":"git://github.com/Hack-PSU/hackPSUF2018-rfid.git","ssh_url":"git@github.com:Hack-PSU/hackPSUF2018-rfid.git","clone_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid.git","svn_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid","homepage":null,"size":287,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Hack-PSU:jmm8046-patch-1","ref":"jmm8046-patch-1","sha":"2e9bb94108866f1dd22b82bd7283a6f85875d3ff","user":{"login":"Hack-PSU","id":20320741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzIwNzQx","avatar_url":"https://avatars2.githubusercontent.com/u/20320741?v=4","gravatar_id":"","url":"https://api.github.com/users/Hack-PSU","html_url":"https://github.com/Hack-PSU","followers_url":"https://api.github.com/users/Hack-PSU/followers","following_url":"https://api.github.com/users/Hack-PSU/following{/other_user}","gists_url":"https://api.github.com/users/Hack-PSU/gists{/gist_id}","starred_url":"https://api.github.com/users/Hack-PSU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hack-PSU/subscriptions","organizations_url":"https://api.github.com/users/Hack-PSU/orgs","repos_url":"https://api.github.com/users/Hack-PSU/repos","events_url":"https://api.github.com/users/Hack-PSU/events{/privacy}","received_events_url":"https://api.github.com/users/Hack-PSU/received_events","type":"Organization","site_admin":false},"repo":{"id":133752383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3NTIzODM=","name":"hackPSUF2018-rfid","full_name":"Hack-PSU/hackPSUF2018-rfid","owner":{"login":"Hack-PSU","id":20320741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzIwNzQx","avatar_url":"https://avatars2.githubusercontent.com/u/20320741?v=4","gravatar_id":"","url":"https://api.github.com/users/Hack-PSU","html_url":"https://github.com/Hack-PSU","followers_url":"https://api.github.com/users/Hack-PSU/followers","following_url":"https://api.github.com/users/Hack-PSU/following{/other_user}","gists_url":"https://api.github.com/users/Hack-PSU/gists{/gist_id}","starred_url":"https://api.github.com/users/Hack-PSU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hack-PSU/subscriptions","organizations_url":"https://api.github.com/users/Hack-PSU/orgs","repos_url":"https://api.github.com/users/Hack-PSU/repos","events_url":"https://api.github.com/users/Hack-PSU/events{/privacy}","received_events_url":"https://api.github.com/users/Hack-PSU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid","description":"Nukt","fork":false,"url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid","forks_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/forks","keys_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/teams","hooks_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/hooks","issue_events_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/events{/number}","events_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/events","assignees_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/assignees{/user}","branches_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/branches{/branch}","tags_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/tags","blobs_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/statuses/{sha}","languages_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/languages","stargazers_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/stargazers","contributors_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/contributors","subscribers_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/subscribers","subscription_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/subscription","commits_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/contents/{+path}","compare_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/merges","archive_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/downloads","issues_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues{/number}","pulls_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls{/number}","milestones_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/milestones{/number}","notifications_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/labels{/name}","releases_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/releases{/id}","deployments_url":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/deployments","created_at":"2018-05-17T03:14:19Z","updated_at":"2018-07-13T00:22:40Z","pushed_at":"2018-07-31T22:46:31Z","git_url":"git://github.com/Hack-PSU/hackPSUF2018-rfid.git","ssh_url":"git@github.com:Hack-PSU/hackPSUF2018-rfid.git","clone_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid.git","svn_url":"https://github.com/Hack-PSU/hackPSUF2018-rfid","homepage":null,"size":287,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5"},"html":{"href":"https://github.com/Hack-PSU/hackPSUF2018-rfid/pull/5"},"issue":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/5"},"comments":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Hack-PSU/hackPSUF2018-rfid/statuses/dd13a1f73353d4b7d96fe6560eb43e104b8a9ef5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmm8046"}}