{"action":"closed","number":809,"pull_request":{"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809","id":174240703,"html_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/809","diff_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/809.diff","patch_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/809.patch","issue_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/809","number":809,"state":"closed","locked":false,"title":"Fix DB type to match core","user":{"login":"Rochet2","id":468816,"avatar_url":"https://avatars0.githubusercontent.com/u/468816?v=4","gravatar_id":"","url":"https://api.github.com/users/Rochet2","html_url":"https://github.com/Rochet2","followers_url":"https://api.github.com/users/Rochet2/followers","following_url":"https://api.github.com/users/Rochet2/following{/other_user}","gists_url":"https://api.github.com/users/Rochet2/gists{/gist_id}","starred_url":"https://api.github.com/users/Rochet2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rochet2/subscriptions","organizations_url":"https://api.github.com/users/Rochet2/orgs","repos_url":"https://api.github.com/users/Rochet2/repos","events_url":"https://api.github.com/users/Rochet2/events{/privacy}","received_events_url":"https://api.github.com/users/Rochet2/received_events","type":"User","site_admin":false},"body":"Reverts https://github.com/azerothcore/azerothcore-wotlk/pull/733\r\n\r\n**Changes proposed:**\r\n\r\nMost of the code in core assumes uint16 for mapid.\r\n\r\nSo either all core types need to be changed for handling the map\r\nOr just this one.\r\n\r\nExample of current errors before this fix:\r\n```\r\nWarning: GetUInt16() on non-smallint field. Using type: LONG.\r\nTable gameobject has gameobject (GUID: 153 Entry: 202188) that has wrong spawn mask 15 including not supported difficulty modes for map (Id: 0), s\r\nkip\r\n```\r\nHow to get the errors: Compile server with `-DWITH_COREDEBUG=1` and start the server.\r\n\r\n**Target branch(es):** 1.x/2.x etc.\r\n\r\n**Issues addressed:** Closes #\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc)\r\n\r\nBarbz tested to compile, start server and a few commands related to this.\r\n\r\n**Known issues and TODO list:**\r\n\r\n**NOTE** You no longer need to squash your commits, on merge we will squash it for you. (GitHub added a new feature)\r\n\r\n\r\n","created_at":"2018-03-11T20:32:01Z","updated_at":"2018-03-17T14:19:34Z","closed_at":"2018-03-17T14:19:34Z","merged_at":"2018-03-17T14:19:34Z","merge_commit_sha":"d1646aeb0f9e8922725e7391e6bbaaa120d7b0df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809/commits","review_comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809/comments","review_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/809/comments","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/f23224d4a3adeefc15c0f0bc08aa47ded46a332e","head":{"label":"azerothcore:Rochet-patch-4","ref":"Rochet-patch-4","sha":"f23224d4a3adeefc15c0f0bc08aa47ded46a332e","user":{"login":"azerothcore","id":20147732,"avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61980658,"name":"azerothcore-wotlk","full_name":"azerothcore/azerothcore-wotlk","owner":{"login":"azerothcore","id":20147732,"avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azerothcore/azerothcore-wotlk","description":"AZeroThCore - Continuing Sunwell Core Project! Based on MaNGOS -> TrinityCore -> SunwellCore","fork":false,"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk","forks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/deployments","created_at":"2016-06-26T08:40:05Z","updated_at":"2018-03-17T10:39:19Z","pushed_at":"2018-03-17T14:19:34Z","git_url":"git://github.com/azerothcore/azerothcore-wotlk.git","ssh_url":"git@github.com:azerothcore/azerothcore-wotlk.git","clone_url":"https://github.com/azerothcore/azerothcore-wotlk.git","svn_url":"https://github.com/azerothcore/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":255132,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":154,"license":null,"forks":200,"open_issues":154,"watchers":187,"default_branch":"master"}},"base":{"label":"azerothcore:master","ref":"master","sha":"bb70286d18b7a46bf41c50bb4447fa7f3e8260ff","user":{"login":"azerothcore","id":20147732,"avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61980658,"name":"azerothcore-wotlk","full_name":"azerothcore/azerothcore-wotlk","owner":{"login":"azerothcore","id":20147732,"avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azerothcore/azerothcore-wotlk","description":"AZeroThCore - Continuing Sunwell Core Project! Based on MaNGOS -> TrinityCore -> SunwellCore","fork":false,"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk","forks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/deployments","created_at":"2016-06-26T08:40:05Z","updated_at":"2018-03-17T10:39:19Z","pushed_at":"2018-03-17T14:19:34Z","git_url":"git://github.com/azerothcore/azerothcore-wotlk.git","ssh_url":"git@github.com:azerothcore/azerothcore-wotlk.git","clone_url":"https://github.com/azerothcore/azerothcore-wotlk.git","svn_url":"https://github.com/azerothcore/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":255132,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":154,"license":null,"forks":200,"open_issues":154,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809"},"html":{"href":"https://github.com/azerothcore/azerothcore-wotlk/pull/809"},"issue":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/809"},"comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/809/comments"},"review_comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809/comments"},"review_comment":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/809/commits"},"statuses":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/f23224d4a3adeefc15c0f0bc08aa47ded46a332e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"talamortis","id":6143065,"avatar_url":"https://avatars0.githubusercontent.com/u/6143065?v=4","gravatar_id":"","url":"https://api.github.com/users/talamortis","html_url":"https://github.com/talamortis","followers_url":"https://api.github.com/users/talamortis/followers","following_url":"https://api.github.com/users/talamortis/following{/other_user}","gists_url":"https://api.github.com/users/talamortis/gists{/gist_id}","starred_url":"https://api.github.com/users/talamortis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talamortis/subscriptions","organizations_url":"https://api.github.com/users/talamortis/orgs","repos_url":"https://api.github.com/users/talamortis/repos","events_url":"https://api.github.com/users/talamortis/events{/privacy}","received_events_url":"https://api.github.com/users/talamortis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":29,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"talamortis"}}