{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/175958614","pull_request_review_id":105578112,"id":175958614,"diff_hunk":"@@ -263,23 +265,64 @@ cudnnSetOpTensorDescriptor(opTensorDesc,\n                     writer.indent--;\n                     writer << \"}\\n\";\n                 }\n-                else if ((arg0_shape.size() == 2) && (arg1_shape.size() == 2) &&\n-                         (dot->get_reduction_axes_count() == 1))\n+                // cases that can be treat as matrix multiply\n+                else\n                 {\n-                    // GEMM Call\n-                    if (arg0_shape[0] != out[0].get_shape()[0] || // m\n-                        arg1_shape[1] != out[0].get_shape()[1] || // n\n-                        arg0_shape[1] != arg1_shape[0])           // k\n+                    // treat as out[m,n] = arg0[m,k] * arg1[k,n]","path":"src/ngraph/runtime/gpu/gpu_emitter.cpp","position":58,"original_position":58,"commit_id":"9dedc6a7f4b42bd560a5cc0aa72b823c210ca430","original_commit_id":"9dedc6a7f4b42bd560a5cc0aa72b823c210ca430","user":{"login":"csullivan","id":4804563,"avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false},"body":"Thanks, it reads better. I've been working through the mathematics of NumPy/Tensorflow tensordot and I realized that op::Dot is less general, is that correct? There isn't any mention of contraction in ngraph op::Dot so I assume so. The matrix multiplication impl. looks good.","created_at":"2018-03-21T00:01:50Z","updated_at":"2018-03-21T00:01:50Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/645#discussion_r175958614","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/175958614"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/645#discussion_r175958614"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645","id":175107407,"html_url":"https://github.com/NervanaSystems/ngraph/pull/645","diff_url":"https://github.com/NervanaSystems/ngraph/pull/645.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/645.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/645","number":645,"state":"open","locked":false,"title":"Dot op that can handle more than 2D on GPU","user":{"login":"fengleitian","id":35274053,"avatar_url":"https://avatars3.githubusercontent.com/u/35274053?v=4","gravatar_id":"","url":"https://api.github.com/users/fengleitian","html_url":"https://github.com/fengleitian","followers_url":"https://api.github.com/users/fengleitian/followers","following_url":"https://api.github.com/users/fengleitian/following{/other_user}","gists_url":"https://api.github.com/users/fengleitian/gists{/gist_id}","starred_url":"https://api.github.com/users/fengleitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengleitian/subscriptions","organizations_url":"https://api.github.com/users/fengleitian/orgs","repos_url":"https://api.github.com/users/fengleitian/repos","events_url":"https://api.github.com/users/fengleitian/events{/privacy}","received_events_url":"https://api.github.com/users/fengleitian/received_events","type":"User","site_admin":false},"body":"Dot that can handle more than 2D on GPU.\r\n\r\nlimitation:\r\n1. Still only support float point.","created_at":"2018-03-14T22:56:56Z","updated_at":"2018-03-21T00:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b44a0568f3f678b13a7161e0f8a9575b113caa6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":825174556,"url":"https://api.github.com/repos/NervanaSystems/ngraph/labels/GPU","name":"GPU","color":"3956cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/645/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/9dedc6a7f4b42bd560a5cc0aa72b823c210ca430","head":{"label":"NervanaSystems:tfl/gpu_dot_general","ref":"tfl/gpu_dot_general","sha":"9dedc6a7f4b42bd560a5cc0aa72b823c210ca430","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-03-20T23:32:34Z","pushed_at":"2018-03-20T23:48:13Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":15744,"stargazers_count":125,"watchers_count":125,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":22,"watchers":125,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"fc9018dc40e24563c3eb290669bb358d5889b936","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-03-20T23:32:34Z","pushed_at":"2018-03-20T23:48:13Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":15744,"stargazers_count":125,"watchers_count":125,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":22,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/645"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/645"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/9dedc6a7f4b42bd560a5cc0aa72b823c210ca430"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"csullivan"}}