{"action":"closed","number":4802,"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/4802","id":191972366,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTcyMzY2","html_url":"https://github.com/gocd/gocd/pull/4802","diff_url":"https://github.com/gocd/gocd/pull/4802.diff","patch_url":"https://github.com/gocd/gocd/pull/4802.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/4802","number":4802,"state":"closed","locked":false,"title":"Fixed issue of duplicate html elements showing up on new dashboard -#4775","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"body":"Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.\r\n\r\nSteps to reproduce:\r\nWe had two tabs with dashboard page opened up. From a third tab (or even an API) rename the pipeline group. Watch the console of the tabs with dashboard, they show up the foundation error - but nothing  goes wrong in the UI yet. Now, from one of the tabs trigger/pause a pipeline (or any other pipeline operation), you would start seeing duplicates in the other tabs. Removing admin access for the user from a different tab also leads to similar issue. Basically anything that leads to change in state after an element is supposed to have been replaced leads to this issue","created_at":"2018-06-01T08:54:40Z","updated_at":"2018-06-06T16:59:16Z","closed_at":"2018-06-06T16:59:16Z","merged_at":"2018-06-06T16:59:16Z","merge_commit_sha":"58e85fc5315ec01ff44d7677e598517eda8bc0c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/gocd/gocd/milestones/43","html_url":"https://github.com/gocd/gocd/milestone/43","labels_url":"https://api.github.com/repos/gocd/gocd/milestones/43/labels","id":3332665,"node_id":"MDk6TWlsZXN0b25lMzMzMjY2NQ==","number":43,"title":"Release 18.6","description":"","creator":{"login":"ketan","id":10598,"node_id":"MDQ6VXNlcjEwNTk4","avatar_url":"https://avatars3.githubusercontent.com/u/10598?v=4","gravatar_id":"","url":"https://api.github.com/users/ketan","html_url":"https://github.com/ketan","followers_url":"https://api.github.com/users/ketan/followers","following_url":"https://api.github.com/users/ketan/following{/other_user}","gists_url":"https://api.github.com/users/ketan/gists{/gist_id}","starred_url":"https://api.github.com/users/ketan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketan/subscriptions","organizations_url":"https://api.github.com/users/ketan/orgs","repos_url":"https://api.github.com/users/ketan/repos","events_url":"https://api.github.com/users/ketan/events{/privacy}","received_events_url":"https://api.github.com/users/ketan/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":67,"state":"open","created_at":"2018-05-09T09:34:10Z","updated_at":"2018-06-06T16:59:16Z","due_on":"2018-06-13T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/4802/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/4802/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/4802/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/89b7991d743b6728a4007af1e15974e09b6178ee","head":{"label":"jyotisingh:issue_4775","ref":"issue_4775","sha":"89b7991d743b6728a4007af1e15974e09b6178ee","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"repo":{"id":21679740,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY3OTc0MA==","name":"gocd","full_name":"jyotisingh/gocd","owner":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jyotisingh/gocd","description":"Main repository for Go Continuous Delivery","fork":true,"url":"https://api.github.com/repos/jyotisingh/gocd","forks_url":"https://api.github.com/repos/jyotisingh/gocd/forks","keys_url":"https://api.github.com/repos/jyotisingh/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jyotisingh/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jyotisingh/gocd/teams","hooks_url":"https://api.github.com/repos/jyotisingh/gocd/hooks","issue_events_url":"https://api.github.com/repos/jyotisingh/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/jyotisingh/gocd/events","assignees_url":"https://api.github.com/repos/jyotisingh/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/jyotisingh/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/jyotisingh/gocd/tags","blobs_url":"https://api.github.com/repos/jyotisingh/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jyotisingh/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jyotisingh/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jyotisingh/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jyotisingh/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/jyotisingh/gocd/languages","stargazers_url":"https://api.github.com/repos/jyotisingh/gocd/stargazers","contributors_url":"https://api.github.com/repos/jyotisingh/gocd/contributors","subscribers_url":"https://api.github.com/repos/jyotisingh/gocd/subscribers","subscription_url":"https://api.github.com/repos/jyotisingh/gocd/subscription","commits_url":"https://api.github.com/repos/jyotisingh/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jyotisingh/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jyotisingh/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jyotisingh/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jyotisingh/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/jyotisingh/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jyotisingh/gocd/merges","archive_url":"https://api.github.com/repos/jyotisingh/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jyotisingh/gocd/downloads","issues_url":"https://api.github.com/repos/jyotisingh/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/jyotisingh/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/jyotisingh/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/jyotisingh/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jyotisingh/gocd/labels{/name}","releases_url":"https://api.github.com/repos/jyotisingh/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/jyotisingh/gocd/deployments","created_at":"2014-07-10T04:52:59Z","updated_at":"2018-06-01T08:51:46Z","pushed_at":"2018-06-06T11:47:44Z","git_url":"git://github.com/jyotisingh/gocd.git","ssh_url":"git@github.com:jyotisingh/gocd.git","clone_url":"https://github.com/jyotisingh/gocd.git","svn_url":"https://github.com/jyotisingh/gocd","homepage":null,"size":264853,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"4b953d3c4dfcc20b489f195d869793cf4dc8cab4","user":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NTUzNA==","name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for GoCD - Continuous Delivery server","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/gocd/gocd/deployments","created_at":"2013-12-13T05:26:16Z","updated_at":"2018-06-06T12:24:50Z","pushed_at":"2018-06-06T16:59:16Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":"https://www.gocd.org","size":264423,"stargazers_count":4190,"watchers_count":4190,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":708,"mirror_url":null,"archived":false,"open_issues_count":844,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":708,"open_issues":844,"watchers":4190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4802"},"html":{"href":"https://github.com/gocd/gocd/pull/4802"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/4802"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/4802/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4802/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4802/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/89b7991d743b6728a4007af1e15974e09b6178ee"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":170,"deletions":56,"changed_files":6}}
{"actor":{"display_login":"jyotisingh"}}