{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/201911445","pull_request_review_id":136504810,"id":201911445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkxMTQ0NQ==","diff_hunk":"@@ -232,6 +238,25 @@ private static string TestColumnType(ColumnType type)\n             return \"Expected R4 or vector of R4 with known size\";\n         }\n \n+        /// <summary>\n+        /// Convenience constructor for public facing API.\n+        /// </summary>\n+        /// <param name=\"env\">Host Environment.</param>\n+        /// <param name=\"input\">Input <see cref=\"IDataView\"/>. This is the output from previous transform or loader.</param>\n+        /// <param name=\"name\">Name of the output column.</param>\n+        /// <param name=\"source\">Name of the column to be transformed. If this is null '<paramref name=\"name\"/>' will be used.</param>\n+        /// <param name=\"newDim\">The number of random Fourier features to create.</param>\n+        /// <param name=\"useSin\">create two features for every random Fourier frequency? (one for cos and one for sin).</param>","path":"src/Microsoft.ML.Transforms/RffTransform.cs","position":41,"original_position":41,"commit_id":"d9c4a297c790e6423fdd8077e8eaab44eaf04b8e","original_commit_id":"d9c4a297c790e6423fdd8077e8eaab44eaf04b8e","user":{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},"body":">create two features for every random Fourier frequency? [](start = 33, length = 55)\r\n\r\nSo, if `newDim` was 10, and I set this to `true`, does the output become 20 or something?","created_at":"2018-07-12T05:14:38Z","updated_at":"2018-07-12T05:14:38Z","html_url":"https://github.com/dotnet/machinelearning/pull/520#discussion_r201911445","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/520","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/201911445"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/520#discussion_r201911445"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/520","id":200513234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTEzMjM0","html_url":"https://github.com/dotnet/machinelearning/pull/520","diff_url":"https://github.com/dotnet/machinelearning/pull/520.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/520.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/520","number":520,"state":"open","locked":false,"title":"[Part 3] Added convenience constructors for set of transforms.","user":{"login":"zeahmed","id":38438266,"node_id":"MDQ6VXNlcjM4NDM4MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/38438266?v=4","gravatar_id":"","url":"https://api.github.com/users/zeahmed","html_url":"https://github.com/zeahmed","followers_url":"https://api.github.com/users/zeahmed/followers","following_url":"https://api.github.com/users/zeahmed/following{/other_user}","gists_url":"https://api.github.com/users/zeahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/zeahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeahmed/subscriptions","organizations_url":"https://api.github.com/users/zeahmed/orgs","repos_url":"https://api.github.com/users/zeahmed/repos","events_url":"https://api.github.com/users/zeahmed/events{/privacy}","received_events_url":"https://api.github.com/users/zeahmed/received_events","type":"User","site_admin":false},"body":"This PR fixes #518. The convenience constructors were added for following transforms.\r\n\r\n- GroupTransform.cs\r\n- HashJoinTransform.cs\r\n- KeyToBinaryVectorTransform.cs\r\n- LoadTransform.cs\r\n- MissingValueIndicatorTransform.cs\r\n- MutualInformationFeatureSelectionTransform.cs\r\n- NADropTransform.cs\r\n- NAHandleTransform.cs\r\n- NAIndicatorTransform.cs\r\n- NAReplaceTransform.cs\r\n- OptionalColumnTransform.cs\r\n- RffTransform.cs\r\n- UngroupTransform.cs\r\n- WhiteningTransform.cs","created_at":"2018-07-10T20:24:59Z","updated_at":"2018-07-12T05:14:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a86023366fd4f35d9143eadc07ae7db886137b87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codemzs","id":1211949,"node_id":"MDQ6VXNlcjEyMTE5NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/520/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/520/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/520/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/d9c4a297c790e6423fdd8077e8eaab44eaf04b8e","head":{"label":"zeahmed:convenience_constructor3","ref":"convenience_constructor3","sha":"d9c4a297c790e6423fdd8077e8eaab44eaf04b8e","user":{"login":"zeahmed","id":38438266,"node_id":"MDQ6VXNlcjM4NDM4MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/38438266?v=4","gravatar_id":"","url":"https://api.github.com/users/zeahmed","html_url":"https://github.com/zeahmed","followers_url":"https://api.github.com/users/zeahmed/followers","following_url":"https://api.github.com/users/zeahmed/following{/other_user}","gists_url":"https://api.github.com/users/zeahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/zeahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeahmed/subscriptions","organizations_url":"https://api.github.com/users/zeahmed/orgs","repos_url":"https://api.github.com/users/zeahmed/repos","events_url":"https://api.github.com/users/zeahmed/events{/privacy}","received_events_url":"https://api.github.com/users/zeahmed/received_events","type":"User","site_admin":false},"repo":{"id":134301619,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzMDE2MTk=","name":"machinelearning","full_name":"zeahmed/machinelearning","owner":{"login":"zeahmed","id":38438266,"node_id":"MDQ6VXNlcjM4NDM4MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/38438266?v=4","gravatar_id":"","url":"https://api.github.com/users/zeahmed","html_url":"https://github.com/zeahmed","followers_url":"https://api.github.com/users/zeahmed/followers","following_url":"https://api.github.com/users/zeahmed/following{/other_user}","gists_url":"https://api.github.com/users/zeahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/zeahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeahmed/subscriptions","organizations_url":"https://api.github.com/users/zeahmed/orgs","repos_url":"https://api.github.com/users/zeahmed/repos","events_url":"https://api.github.com/users/zeahmed/events{/privacy}","received_events_url":"https://api.github.com/users/zeahmed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeahmed/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/zeahmed/machinelearning","forks_url":"https://api.github.com/repos/zeahmed/machinelearning/forks","keys_url":"https://api.github.com/repos/zeahmed/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeahmed/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeahmed/machinelearning/teams","hooks_url":"https://api.github.com/repos/zeahmed/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/zeahmed/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/zeahmed/machinelearning/events","assignees_url":"https://api.github.com/repos/zeahmed/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/zeahmed/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/zeahmed/machinelearning/tags","blobs_url":"https://api.github.com/repos/zeahmed/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeahmed/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeahmed/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeahmed/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeahmed/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/zeahmed/machinelearning/languages","stargazers_url":"https://api.github.com/repos/zeahmed/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/zeahmed/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/zeahmed/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/zeahmed/machinelearning/subscription","commits_url":"https://api.github.com/repos/zeahmed/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeahmed/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeahmed/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeahmed/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeahmed/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/zeahmed/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeahmed/machinelearning/merges","archive_url":"https://api.github.com/repos/zeahmed/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeahmed/machinelearning/downloads","issues_url":"https://api.github.com/repos/zeahmed/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/zeahmed/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/zeahmed/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/zeahmed/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeahmed/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/zeahmed/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/zeahmed/machinelearning/deployments","created_at":"2018-05-21T17:22:47Z","updated_at":"2018-06-29T17:21:34Z","pushed_at":"2018-07-11T17:56:33Z","git_url":"git://github.com/zeahmed/machinelearning.git","ssh_url":"git@github.com:zeahmed/machinelearning.git","clone_url":"https://github.com/zeahmed/machinelearning.git","svn_url":"https://github.com/zeahmed/machinelearning","homepage":"http://dot.net/ml","size":19685,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f7a55268646363e625cfe8e40b30a9fc5cc6298e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-07-12T01:54:20Z","pushed_at":"2018-07-12T04:35:44Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":19725,"stargazers_count":3068,"watchers_count":3068,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":407,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":407,"open_issues":176,"watchers":3068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/520"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/520"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/520"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/d9c4a297c790e6423fdd8077e8eaab44eaf04b8e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TomFinley"}}