{"action":"closed","number":5710,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710","id":176572982,"html_url":"https://github.com/bbatsov/rubocop/pull/5710","diff_url":"https://github.com/bbatsov/rubocop/pull/5710.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/5710.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5710","number":5710,"state":"closed","locked":false,"title":"Fix rack-version related flaky test","user":{"login":"akhramov","id":5289700,"avatar_url":"https://avatars1.githubusercontent.com/u/5289700?v=4","gravatar_id":"","url":"https://api.github.com/users/akhramov","html_url":"https://github.com/akhramov","followers_url":"https://api.github.com/users/akhramov/followers","following_url":"https://api.github.com/users/akhramov/following{/other_user}","gists_url":"https://api.github.com/users/akhramov/gists{/gist_id}","starred_url":"https://api.github.com/users/akhramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhramov/subscriptions","organizations_url":"https://api.github.com/users/akhramov/orgs","repos_url":"https://api.github.com/users/akhramov/repos","events_url":"https://api.github.com/users/akhramov/events{/privacy}","received_events_url":"https://api.github.com/users/akhramov/received_events","type":"User","site_admin":false},"body":"Currently 2.1.0 tests fail sporadically on travis due to bundler\r\nunable to install rack dependency. ([an example](https://travis-ci.org/bbatsov/rubocop/jobs/356344273)).\r\nThis happens because rack is declared as an open dependency, but rack\r\n2.0+ [does not support Ruby 2.1.0](https://github.com/rack/rack/blob/1a408687493175250408fe87c5046bf1adfa6386/rack.gemspec#L29). However, sometimes tests pass,\r\nbecause, I believe, some nodes have correct version of rack cached.\r\n\r\nThis change adds an interval for rack dev dependency, ensuring that\r\nbundler won't try to install an inappropriate version of rack.\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [x] Squashed related commits together.\r\n* [ ] Added tests.\r\n* [ ] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [x] Run `rake default` or `rake parallel`. It executes all tests and RuboCop for itself, and generates the documentation.\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/\r\n","created_at":"2018-03-21T18:37:26Z","updated_at":"2018-03-23T02:36:38Z","closed_at":"2018-03-23T02:36:38Z","merged_at":"2018-03-23T02:36:38Z","merge_commit_sha":"1df6f7d29a9f5084a187a1ffa01af77fcd874db0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5710/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/f85c828ec9f0507a66de696781500f2c095d73f6","head":{"label":"akhramov:fix/flaky-2.1.0-test","ref":"fix/flaky-2.1.0-test","sha":"f85c828ec9f0507a66de696781500f2c095d73f6","user":{"login":"akhramov","id":5289700,"avatar_url":"https://avatars1.githubusercontent.com/u/5289700?v=4","gravatar_id":"","url":"https://api.github.com/users/akhramov","html_url":"https://github.com/akhramov","followers_url":"https://api.github.com/users/akhramov/followers","following_url":"https://api.github.com/users/akhramov/following{/other_user}","gists_url":"https://api.github.com/users/akhramov/gists{/gist_id}","starred_url":"https://api.github.com/users/akhramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhramov/subscriptions","organizations_url":"https://api.github.com/users/akhramov/orgs","repos_url":"https://api.github.com/users/akhramov/repos","events_url":"https://api.github.com/users/akhramov/events{/privacy}","received_events_url":"https://api.github.com/users/akhramov/received_events","type":"User","site_admin":false},"repo":{"id":101511292,"name":"rubocop","full_name":"akhramov/rubocop","owner":{"login":"akhramov","id":5289700,"avatar_url":"https://avatars1.githubusercontent.com/u/5289700?v=4","gravatar_id":"","url":"https://api.github.com/users/akhramov","html_url":"https://github.com/akhramov","followers_url":"https://api.github.com/users/akhramov/followers","following_url":"https://api.github.com/users/akhramov/following{/other_user}","gists_url":"https://api.github.com/users/akhramov/gists{/gist_id}","starred_url":"https://api.github.com/users/akhramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhramov/subscriptions","organizations_url":"https://api.github.com/users/akhramov/orgs","repos_url":"https://api.github.com/users/akhramov/repos","events_url":"https://api.github.com/users/akhramov/events{/privacy}","received_events_url":"https://api.github.com/users/akhramov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akhramov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/akhramov/rubocop","forks_url":"https://api.github.com/repos/akhramov/rubocop/forks","keys_url":"https://api.github.com/repos/akhramov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akhramov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akhramov/rubocop/teams","hooks_url":"https://api.github.com/repos/akhramov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/akhramov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/akhramov/rubocop/events","assignees_url":"https://api.github.com/repos/akhramov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/akhramov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/akhramov/rubocop/tags","blobs_url":"https://api.github.com/repos/akhramov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akhramov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akhramov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/akhramov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akhramov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/akhramov/rubocop/languages","stargazers_url":"https://api.github.com/repos/akhramov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/akhramov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/akhramov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/akhramov/rubocop/subscription","commits_url":"https://api.github.com/repos/akhramov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/akhramov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/akhramov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/akhramov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/akhramov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/akhramov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akhramov/rubocop/merges","archive_url":"https://api.github.com/repos/akhramov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akhramov/rubocop/downloads","issues_url":"https://api.github.com/repos/akhramov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/akhramov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/akhramov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/akhramov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akhramov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/akhramov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/akhramov/rubocop/deployments","created_at":"2017-08-26T20:25:38Z","updated_at":"2017-08-26T20:25:43Z","pushed_at":"2018-03-22T03:41:14Z","git_url":"git://github.com/akhramov/rubocop.git","ssh_url":"git@github.com:akhramov/rubocop.git","clone_url":"https://github.com/akhramov/rubocop.git","svn_url":"https://github.com/akhramov/rubocop","homepage":"http://rubocop.readthedocs.io","size":20640,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"824fd372b612181ff67a6c945cb8178b4012aa3f","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2018-03-22T09:14:08Z","pushed_at":"2018-03-23T02:36:38Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":20636,"stargazers_count":8836,"watchers_count":8836,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1682,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1682,"open_issues":329,"watchers":8836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/5710"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5710"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5710/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5710/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/f85c828ec9f0507a66de696781500f2c095d73f6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bbatsov"}}