{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/comments/184347046","pull_request_review_id":115522702,"id":184347046,"diff_hunk":"@@ -0,0 +1,80 @@\n+package com.kaltura.client.test;\n+\n+import com.kaltura.client.APIOkRequestsExecutor;\n+import com.kaltura.client.ILogger;\n+import com.kaltura.client.Logger;\n+import com.kaltura.client.utils.ErrorElement;\n+import com.kaltura.client.utils.request.ExecutedRequest;\n+import com.kaltura.client.utils.request.RequestElement;\n+import com.kaltura.client.utils.response.base.ResponseElement;\n+import okhttp3.Response;\n+import java.io.IOException;\n+import static io.restassured.module.jsv.JsonSchemaValidator.matchesJsonSchemaInClasspath;\n+import static org.hamcrest.MatcherAssert.assertThat;\n+\n+/**\n+ * @hide\n+ */\n+// that class was implemented to get access to full response body as it's superclass APIOkRequestsExecutor doesn't allow to do it\n+public class TestAPIOkRequestsExecutor extends APIOkRequestsExecutor {\n+\n+\n+    public static final String TAG = \"TestAPIOkRequestsExecutor\";\n+    private static ILogger logger = Logger.getLogger(TAG);\n+    protected static TestAPIOkRequestsExecutor self;\n+\n+    public static TestAPIOkRequestsExecutor getExecutor() {\n+        if (self == null) {\n+            self = new TestAPIOkRequestsExecutor();\n+        }\n+        return self;\n+    }\n+\n+    @SuppressWarnings(\"rawtypes\")\n+    @Override\n+    protected ResponseElement onGotResponse(Response response, RequestElement action) {","path":"src/test/java/com/kaltura/client/test/TestAPIOkRequestsExecutor.java","position":35,"original_position":35,"commit_id":"fd903f641014eef2d69fc47fc0a2177c2c4137ae","original_commit_id":"fd903f641014eef2d69fc47fc0a2177c2c4137ae","user":{"login":"maksimsuperfinkaltura","id":31406925,"avatar_url":"https://avatars1.githubusercontent.com/u/31406925?v=4","gravatar_id":"","url":"https://api.github.com/users/maksimsuperfinkaltura","html_url":"https://github.com/maksimsuperfinkaltura","followers_url":"https://api.github.com/users/maksimsuperfinkaltura/followers","following_url":"https://api.github.com/users/maksimsuperfinkaltura/following{/other_user}","gists_url":"https://api.github.com/users/maksimsuperfinkaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimsuperfinkaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimsuperfinkaltura/subscriptions","organizations_url":"https://api.github.com/users/maksimsuperfinkaltura/orgs","repos_url":"https://api.github.com/users/maksimsuperfinkaltura/repos","events_url":"https://api.github.com/users/maksimsuperfinkaltura/events{/privacy}","received_events_url":"https://api.github.com/users/maksimsuperfinkaltura/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-04-26T10:50:50Z","updated_at":"2018-04-26T10:50:50Z","html_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1#discussion_r184347046","pull_request_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/comments/184347046"},"html":{"href":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1#discussion_r184347046"},"pull_request":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1"}},"in_reply_to_id":184016808},"pull_request":{"url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1","id":183986099,"html_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1","diff_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1.diff","patch_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1.patch","issue_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/1","number":1,"state":"open","locked":false,"title":"OTT BE Testing ","user":{"login":"alonbasin-kaltura","id":35916900,"avatar_url":"https://avatars3.githubusercontent.com/u/35916900?v=4","gravatar_id":"","url":"https://api.github.com/users/alonbasin-kaltura","html_url":"https://github.com/alonbasin-kaltura","followers_url":"https://api.github.com/users/alonbasin-kaltura/followers","following_url":"https://api.github.com/users/alonbasin-kaltura/following{/other_user}","gists_url":"https://api.github.com/users/alonbasin-kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/alonbasin-kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonbasin-kaltura/subscriptions","organizations_url":"https://api.github.com/users/alonbasin-kaltura/orgs","repos_url":"https://api.github.com/users/alonbasin-kaltura/repos","events_url":"https://api.github.com/users/alonbasin-kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/alonbasin-kaltura/received_events","type":"User","site_admin":false},"body":"@tan-tan-kanarek \r\n\r\n1. \"All service impl classes can be auto-generated, I will do it for you when I have the time.\"\r\nThat will be great as it will save us a lot of maintenance time. Also wanted to ask you if in each impl function we need AtomicBoolean for parallel execution?   \r\n\r\n2. \"Try to delete any created object after the test is done, with success or error, that will enable us to run these tests also in production without trashing the DB too much.\"\r\nWill do, but only in case there's API for it. (I've been asked not to delete directly from the DB).\r\n\r\n3. \"All service specific utils could be implemented in a parent class of all tests of that service, would be much more elegant.\"\r\nIf you like I can do so, but we calling those utils from different services tests. For example createHousehold() being called almost in each test (not only in HouseholdTests). Let me know what you think.","created_at":"2018-04-25T10:13:06Z","updated_at":"2018-04-26T10:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa8df92d2c6399bed7c4b39bf3695a97e064fdff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/1/comments","statuses_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/statuses/fd903f641014eef2d69fc47fc0a2177c2c4137ae","head":{"label":"alonbasin-kaltura:master","ref":"master","sha":"fd903f641014eef2d69fc47fc0a2177c2c4137ae","user":{"login":"alonbasin-kaltura","id":35916900,"avatar_url":"https://avatars3.githubusercontent.com/u/35916900?v=4","gravatar_id":"","url":"https://api.github.com/users/alonbasin-kaltura","html_url":"https://github.com/alonbasin-kaltura","followers_url":"https://api.github.com/users/alonbasin-kaltura/followers","following_url":"https://api.github.com/users/alonbasin-kaltura/following{/other_user}","gists_url":"https://api.github.com/users/alonbasin-kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/alonbasin-kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonbasin-kaltura/subscriptions","organizations_url":"https://api.github.com/users/alonbasin-kaltura/orgs","repos_url":"https://api.github.com/users/alonbasin-kaltura/repos","events_url":"https://api.github.com/users/alonbasin-kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/alonbasin-kaltura/received_events","type":"User","site_admin":false},"repo":{"id":126175094,"name":"KalturaOttGeneratedAPIClientsJava","full_name":"alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava","owner":{"login":"alonbasin-kaltura","id":35916900,"avatar_url":"https://avatars3.githubusercontent.com/u/35916900?v=4","gravatar_id":"","url":"https://api.github.com/users/alonbasin-kaltura","html_url":"https://github.com/alonbasin-kaltura","followers_url":"https://api.github.com/users/alonbasin-kaltura/followers","following_url":"https://api.github.com/users/alonbasin-kaltura/following{/other_user}","gists_url":"https://api.github.com/users/alonbasin-kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/alonbasin-kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonbasin-kaltura/subscriptions","organizations_url":"https://api.github.com/users/alonbasin-kaltura/orgs","repos_url":"https://api.github.com/users/alonbasin-kaltura/repos","events_url":"https://api.github.com/users/alonbasin-kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/alonbasin-kaltura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava","description":null,"fork":true,"url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava","forks_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/forks","keys_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/teams","hooks_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/hooks","issue_events_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/issues/events{/number}","events_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/events","assignees_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/assignees{/user}","branches_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/branches{/branch}","tags_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/tags","blobs_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/statuses/{sha}","languages_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/languages","stargazers_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/stargazers","contributors_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/contributors","subscribers_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/subscribers","subscription_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/subscription","commits_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/contents/{+path}","compare_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/merges","archive_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/downloads","issues_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/issues{/number}","pulls_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/pulls{/number}","milestones_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/milestones{/number}","notifications_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/labels{/name}","releases_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/releases{/id}","deployments_url":"https://api.github.com/repos/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava/deployments","created_at":"2018-03-21T12:27:30Z","updated_at":"2018-04-24T14:13:50Z","pushed_at":"2018-04-26T10:49:39Z","git_url":"git://github.com/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava.git","ssh_url":"git@github.com:alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava.git","clone_url":"https://github.com/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava.git","svn_url":"https://github.com/alonbasin-kaltura/KalturaOttGeneratedAPIClientsJava","homepage":null,"size":1782,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"64253e3ca3160f4bf1cf554e32a27c9ca57cd5bf","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":96998095,"name":"KalturaOttGeneratedAPIClientsJava","full_name":"kaltura/KalturaOttGeneratedAPIClientsJava","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava","description":null,"fork":false,"url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava","forks_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/forks","keys_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/teams","hooks_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/hooks","issue_events_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/events","assignees_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/tags","blobs_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/languages","stargazers_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/stargazers","contributors_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/contributors","subscribers_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/subscribers","subscription_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/subscription","commits_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/merges","archive_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/downloads","issues_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/deployments","created_at":"2017-07-12T11:00:38Z","updated_at":"2018-04-26T00:00:04Z","pushed_at":"2018-04-26T00:00:02Z","git_url":"git://github.com/kaltura/KalturaOttGeneratedAPIClientsJava.git","ssh_url":"git@github.com:kaltura/KalturaOttGeneratedAPIClientsJava.git","clone_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava.git","svn_url":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava","homepage":null,"size":1567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1"},"html":{"href":"https://github.com/kaltura/KalturaOttGeneratedAPIClientsJava/pull/1"},"issue":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/1"},"comments":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/KalturaOttGeneratedAPIClientsJava/statuses/fd903f641014eef2d69fc47fc0a2177c2c4137ae"}},"author_association":"NONE"}}
{"actor":{"display_login":"maksimsuperfinkaltura"}}