{"action":"created","comment":{"url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/comments/181185618","pull_request_review_id":111748193,"id":181185618,"diff_hunk":"@@ -47,7 +45,7 @@ public ApplicableBuilderFieldExtractor(ClassFieldCollector classFieldCollector,\n \n     private boolean fieldDeclarationsContainConstructorField(List<? extends BuilderField> applicableFields, BuilderField field) {\n         for (BuilderField currentField : applicableFields) {\n-            if (currentField instanceof ConstructorParameterSetterBuilderField && currentField.getBuilderFieldName().equals(field.getBuilderFieldName())) {\n+            if (currentField.getBuilderFieldName().equals(field.getBuilderFieldName())) {","path":"SparkBuilderGeneratorPlugin/src/com/helospark/spark/builder/handlers/codegenerator/ApplicableBuilderFieldExtractor.java","position":51,"original_position":51,"commit_id":"2cd33d781ec4dee7fc136db82b7b9a3df92607ca","original_commit_id":"2cd33d781ec4dee7fc136db82b7b9a3df92607ca","user":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"body":"We cannot do that. We have to return true, if we found one that matches, but we only return false if none matched.","created_at":"2018-04-12T18:49:26Z","updated_at":"2018-04-12T18:49:27Z","html_url":"https://github.com/helospark/SparkBuilderGenerator/pull/36#discussion_r181185618","pull_request_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/comments/181185618"},"html":{"href":"https://github.com/helospark/SparkBuilderGenerator/pull/36#discussion_r181185618"},"pull_request":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36"}},"in_reply_to_id":181178953},"pull_request":{"url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36","id":181287063,"html_url":"https://github.com/helospark/SparkBuilderGenerator/pull/36","diff_url":"https://github.com/helospark/SparkBuilderGenerator/pull/36.diff","patch_url":"https://github.com/helospark/SparkBuilderGenerator/pull/36.patch","issue_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/36","number":36,"state":"open","locked":false,"title":"GitHub issue 35 add super setters","user":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"body":"PR for #35 ","created_at":"2018-04-12T18:23:47Z","updated_at":"2018-04-12T18:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1acbb029b5f4ed6cd4ff7d914a7bd458840d715b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36/commits","review_comments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36/comments","review_comment_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/36/comments","statuses_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/statuses/2cd33d781ec4dee7fc136db82b7b9a3df92607ca","head":{"label":"helospark:github-issue-35-add-super-setters","ref":"github-issue-35-add-super-setters","sha":"2cd33d781ec4dee7fc136db82b7b9a3df92607ca","user":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"repo":{"id":69391337,"name":"SparkBuilderGenerator","full_name":"helospark/SparkBuilderGenerator","owner":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helospark/SparkBuilderGenerator","description":"Eclipse plugin to generate builders","fork":false,"url":"https://api.github.com/repos/helospark/SparkBuilderGenerator","forks_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/forks","keys_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/teams","hooks_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/hooks","issue_events_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/events{/number}","events_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/events","assignees_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/assignees{/user}","branches_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/branches{/branch}","tags_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/tags","blobs_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/languages","stargazers_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/stargazers","contributors_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/contributors","subscribers_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/subscribers","subscription_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/subscription","commits_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/contents/{+path}","compare_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/merges","archive_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/downloads","issues_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues{/number}","pulls_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/labels{/name}","releases_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/releases{/id}","deployments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/deployments","created_at":"2016-09-27T19:29:59Z","updated_at":"2018-02-16T23:55:16Z","pushed_at":"2018-04-12T18:23:47Z","git_url":"git://github.com/helospark/SparkBuilderGenerator.git","ssh_url":"git@github.com:helospark/SparkBuilderGenerator.git","clone_url":"https://github.com/helospark/SparkBuilderGenerator.git","svn_url":"https://github.com/helospark/SparkBuilderGenerator","homepage":"","size":2784,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":2,"watchers":15,"default_branch":"master"}},"base":{"label":"helospark:master","ref":"master","sha":"9d5ae51814c755065d188099d6e02c9403abfc60","user":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"repo":{"id":69391337,"name":"SparkBuilderGenerator","full_name":"helospark/SparkBuilderGenerator","owner":{"login":"helospark","id":14263031,"avatar_url":"https://avatars3.githubusercontent.com/u/14263031?v=4","gravatar_id":"","url":"https://api.github.com/users/helospark","html_url":"https://github.com/helospark","followers_url":"https://api.github.com/users/helospark/followers","following_url":"https://api.github.com/users/helospark/following{/other_user}","gists_url":"https://api.github.com/users/helospark/gists{/gist_id}","starred_url":"https://api.github.com/users/helospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helospark/subscriptions","organizations_url":"https://api.github.com/users/helospark/orgs","repos_url":"https://api.github.com/users/helospark/repos","events_url":"https://api.github.com/users/helospark/events{/privacy}","received_events_url":"https://api.github.com/users/helospark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helospark/SparkBuilderGenerator","description":"Eclipse plugin to generate builders","fork":false,"url":"https://api.github.com/repos/helospark/SparkBuilderGenerator","forks_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/forks","keys_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/teams","hooks_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/hooks","issue_events_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/events{/number}","events_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/events","assignees_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/assignees{/user}","branches_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/branches{/branch}","tags_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/tags","blobs_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/languages","stargazers_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/stargazers","contributors_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/contributors","subscribers_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/subscribers","subscription_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/subscription","commits_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/contents/{+path}","compare_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/merges","archive_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/downloads","issues_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues{/number}","pulls_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/labels{/name}","releases_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/releases{/id}","deployments_url":"https://api.github.com/repos/helospark/SparkBuilderGenerator/deployments","created_at":"2016-09-27T19:29:59Z","updated_at":"2018-02-16T23:55:16Z","pushed_at":"2018-04-12T18:23:47Z","git_url":"git://github.com/helospark/SparkBuilderGenerator.git","ssh_url":"git@github.com:helospark/SparkBuilderGenerator.git","clone_url":"https://github.com/helospark/SparkBuilderGenerator.git","svn_url":"https://github.com/helospark/SparkBuilderGenerator","homepage":"","size":2784,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36"},"html":{"href":"https://github.com/helospark/SparkBuilderGenerator/pull/36"},"issue":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/36"},"comments":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/helospark/SparkBuilderGenerator/statuses/2cd33d781ec4dee7fc136db82b7b9a3df92607ca"}},"author_association":"OWNER"}}
{"actor":{"display_login":"helospark"}}