{"action":"created","comment":{"url":"https://api.github.com/repos/lcobucci/jwt/pulls/comments/197655206","pull_request_review_id":131438828,"id":197655206,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzY1NTIwNg==","diff_hunk":"@@ -0,0 +1,14 @@\n+<?php\n+declare(strict_types=1);\n+\n+namespace Lcobucci\\JWT\\Signer\\Ecdsa;\n+\n+/**\n+ * @internal\n+ */\n+interface PointsManipulator\n+{\n+    public function fromEcPoint(string $signature, int $length): string;","path":"src/Signer/Ecdsa/PointsManipulator.php","position":11,"original_position":11,"commit_id":"16e494c911c20ca5ad2592496b32492ce9050bc2","original_commit_id":"72337347fce883853b40d285dfddf1dcd230f3c1","user":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"body":"This is also bit weird in terms of naming, open to suggestions","created_at":"2018-06-24T22:40:02Z","updated_at":"2018-06-24T22:40:34Z","html_url":"https://github.com/lcobucci/jwt/pull/247#discussion_r197655206","pull_request_url":"https://api.github.com/repos/lcobucci/jwt/pulls/247","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/comments/197655206"},"html":{"href":"https://github.com/lcobucci/jwt/pull/247#discussion_r197655206"},"pull_request":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/lcobucci/jwt/pulls/247","id":196973434,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTczNDM0","html_url":"https://github.com/lcobucci/jwt/pull/247","diff_url":"https://github.com/lcobucci/jwt/pull/247.diff","patch_url":"https://github.com/lcobucci/jwt/pull/247.patch","issue_url":"https://api.github.com/repos/lcobucci/jwt/issues/247","number":247,"state":"open","locked":false,"title":"Use OpenSSL to handle ECDSA signature","user":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"body":"I finally found some energy to finish this, there're things that could/should be improved though.\r\n\r\nFixes #187 ","created_at":"2018-06-24T22:33:40Z","updated_at":"2018-06-24T22:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258d20a3d044057914c582fb1e4d87db06618076","assignee":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"assignees":[{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Ocramius","id":154256,"node_id":"MDQ6VXNlcjE1NDI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":84284463,"node_id":"MDU6TGFiZWw4NDI4NDQ2Mw==","url":"https://api.github.com/repos/lcobucci/jwt/labels/Improvement","name":"Improvement","color":"3a73af","default":false}],"milestone":{"url":"https://api.github.com/repos/lcobucci/jwt/milestones/3","html_url":"https://github.com/lcobucci/jwt/milestone/3","labels_url":"https://api.github.com/repos/lcobucci/jwt/milestones/3/labels","id":1281675,"node_id":"MDk6TWlsZXN0b25lMTI4MTY3NQ==","number":3,"title":"4.0.0","description":"","creator":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":58,"state":"open","created_at":"2015-08-31T12:03:18Z","updated_at":"2018-06-24T22:33:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lcobucci/jwt/pulls/247/commits","review_comments_url":"https://api.github.com/repos/lcobucci/jwt/pulls/247/comments","review_comment_url":"https://api.github.com/repos/lcobucci/jwt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lcobucci/jwt/issues/247/comments","statuses_url":"https://api.github.com/repos/lcobucci/jwt/statuses/16e494c911c20ca5ad2592496b32492ce9050bc2","head":{"label":"lcobucci:openssl-ecdsa","ref":"openssl-ecdsa","sha":"16e494c911c20ca5ad2592496b32492ce9050bc2","user":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"repo":{"id":17452080,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ1MjA4MA==","name":"jwt","full_name":"lcobucci/jwt","owner":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcobucci/jwt","description":"A simple library to work with JSON Web Token and JSON Web Signature","fork":false,"url":"https://api.github.com/repos/lcobucci/jwt","forks_url":"https://api.github.com/repos/lcobucci/jwt/forks","keys_url":"https://api.github.com/repos/lcobucci/jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcobucci/jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcobucci/jwt/teams","hooks_url":"https://api.github.com/repos/lcobucci/jwt/hooks","issue_events_url":"https://api.github.com/repos/lcobucci/jwt/issues/events{/number}","events_url":"https://api.github.com/repos/lcobucci/jwt/events","assignees_url":"https://api.github.com/repos/lcobucci/jwt/assignees{/user}","branches_url":"https://api.github.com/repos/lcobucci/jwt/branches{/branch}","tags_url":"https://api.github.com/repos/lcobucci/jwt/tags","blobs_url":"https://api.github.com/repos/lcobucci/jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcobucci/jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcobucci/jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcobucci/jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcobucci/jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/lcobucci/jwt/languages","stargazers_url":"https://api.github.com/repos/lcobucci/jwt/stargazers","contributors_url":"https://api.github.com/repos/lcobucci/jwt/contributors","subscribers_url":"https://api.github.com/repos/lcobucci/jwt/subscribers","subscription_url":"https://api.github.com/repos/lcobucci/jwt/subscription","commits_url":"https://api.github.com/repos/lcobucci/jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcobucci/jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcobucci/jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcobucci/jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcobucci/jwt/contents/{+path}","compare_url":"https://api.github.com/repos/lcobucci/jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcobucci/jwt/merges","archive_url":"https://api.github.com/repos/lcobucci/jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcobucci/jwt/downloads","issues_url":"https://api.github.com/repos/lcobucci/jwt/issues{/number}","pulls_url":"https://api.github.com/repos/lcobucci/jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/lcobucci/jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/lcobucci/jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcobucci/jwt/labels{/name}","releases_url":"https://api.github.com/repos/lcobucci/jwt/releases{/id}","deployments_url":"https://api.github.com/repos/lcobucci/jwt/deployments","created_at":"2014-03-05T19:23:23Z","updated_at":"2018-06-24T06:23:37Z","pushed_at":"2018-06-24T22:33:41Z","git_url":"git://github.com/lcobucci/jwt.git","ssh_url":"git@github.com:lcobucci/jwt.git","clone_url":"https://github.com/lcobucci/jwt.git","svn_url":"https://github.com/lcobucci/jwt","homepage":null,"size":618,"stargazers_count":2583,"watchers_count":2583,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":258,"open_issues":25,"watchers":2583,"default_branch":"master"}},"base":{"label":"lcobucci:master","ref":"master","sha":"3f75ff6140b13c305b6312881e4f9b1a56b9c8c6","user":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"repo":{"id":17452080,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ1MjA4MA==","name":"jwt","full_name":"lcobucci/jwt","owner":{"login":"lcobucci","id":201963,"node_id":"MDQ6VXNlcjIwMTk2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/201963?v=4","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcobucci/jwt","description":"A simple library to work with JSON Web Token and JSON Web Signature","fork":false,"url":"https://api.github.com/repos/lcobucci/jwt","forks_url":"https://api.github.com/repos/lcobucci/jwt/forks","keys_url":"https://api.github.com/repos/lcobucci/jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcobucci/jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcobucci/jwt/teams","hooks_url":"https://api.github.com/repos/lcobucci/jwt/hooks","issue_events_url":"https://api.github.com/repos/lcobucci/jwt/issues/events{/number}","events_url":"https://api.github.com/repos/lcobucci/jwt/events","assignees_url":"https://api.github.com/repos/lcobucci/jwt/assignees{/user}","branches_url":"https://api.github.com/repos/lcobucci/jwt/branches{/branch}","tags_url":"https://api.github.com/repos/lcobucci/jwt/tags","blobs_url":"https://api.github.com/repos/lcobucci/jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcobucci/jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcobucci/jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcobucci/jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcobucci/jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/lcobucci/jwt/languages","stargazers_url":"https://api.github.com/repos/lcobucci/jwt/stargazers","contributors_url":"https://api.github.com/repos/lcobucci/jwt/contributors","subscribers_url":"https://api.github.com/repos/lcobucci/jwt/subscribers","subscription_url":"https://api.github.com/repos/lcobucci/jwt/subscription","commits_url":"https://api.github.com/repos/lcobucci/jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcobucci/jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcobucci/jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcobucci/jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcobucci/jwt/contents/{+path}","compare_url":"https://api.github.com/repos/lcobucci/jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcobucci/jwt/merges","archive_url":"https://api.github.com/repos/lcobucci/jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcobucci/jwt/downloads","issues_url":"https://api.github.com/repos/lcobucci/jwt/issues{/number}","pulls_url":"https://api.github.com/repos/lcobucci/jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/lcobucci/jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/lcobucci/jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcobucci/jwt/labels{/name}","releases_url":"https://api.github.com/repos/lcobucci/jwt/releases{/id}","deployments_url":"https://api.github.com/repos/lcobucci/jwt/deployments","created_at":"2014-03-05T19:23:23Z","updated_at":"2018-06-24T06:23:37Z","pushed_at":"2018-06-24T22:33:41Z","git_url":"git://github.com/lcobucci/jwt.git","ssh_url":"git@github.com:lcobucci/jwt.git","clone_url":"https://github.com/lcobucci/jwt.git","svn_url":"https://github.com/lcobucci/jwt","homepage":null,"size":618,"stargazers_count":2583,"watchers_count":2583,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":258,"open_issues":25,"watchers":2583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/247"},"html":{"href":"https://github.com/lcobucci/jwt/pull/247"},"issue":{"href":"https://api.github.com/repos/lcobucci/jwt/issues/247"},"comments":{"href":"https://api.github.com/repos/lcobucci/jwt/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lcobucci/jwt/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/lcobucci/jwt/statuses/16e494c911c20ca5ad2592496b32492ce9050bc2"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lcobucci"}}