{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/126","repository_url":"https://api.github.com/repos/Microsoft/DirectXTex","labels_url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/126/comments","events_url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/126/events","html_url":"https://github.com/Microsoft/DirectXTex/pull/126","id":387520161,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTkxMjk1","number":126,"title":"Fix out of bound reads.","user":{"login":"malkia","id":51738,"node_id":"MDQ6VXNlcjUxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/51738?v=4","gravatar_id":"","url":"https://api.github.com/users/malkia","html_url":"https://github.com/malkia","followers_url":"https://api.github.com/users/malkia/followers","following_url":"https://api.github.com/users/malkia/following{/other_user}","gists_url":"https://api.github.com/users/malkia/gists{/gist_id}","starred_url":"https://api.github.com/users/malkia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malkia/subscriptions","organizations_url":"https://api.github.com/users/malkia/orgs","repos_url":"https://api.github.com/users/malkia/repos","events_url":"https://api.github.com/users/malkia/events{/privacy}","received_events_url":"https://api.github.com/users/malkia/received_events","type":"User","site_admin":false},"labels":[{"id":197766307,"node_id":"MDU6TGFiZWwxOTc3NjYzMDc=","url":"https://api.github.com/repos/Microsoft/DirectXTex/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-04T23:07:12Z","updated_at":"2018-12-05T05:39:14Z","closed_at":"2018-12-05T05:39:14Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectXTex/pulls/126","html_url":"https://github.com/Microsoft/DirectXTex/pull/126","diff_url":"https://github.com/Microsoft/DirectXTex/pull/126.diff","patch_url":"https://github.com/Microsoft/DirectXTex/pull/126.patch"},"body":"Our CI caught this while smoke testing one of our tools with App Verifier (AppVerif.exe). I believe just enabling the \"Heaps\" would repro the bug (it did for us, but I haven't bothered to uncheck the other flags that we have turned on).\r\n\r\nThe issue seems to be XMVECTOR v = func(sPtr++);\\\\ reading out of bounds, it's clear that if (dptr >= ePtr) the value read would be ignored, and hence (without further checking deeper) it lead me to believe that this was the cause.\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/comments/444365512","html_url":"https://github.com/Microsoft/DirectXTex/pull/126#issuecomment-444365512","issue_url":"https://api.github.com/repos/Microsoft/DirectXTex/issues/126","id":444365512,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDM2NTUxMg==","user":{"login":"walbourn","id":11866002,"node_id":"MDQ6VXNlcjExODY2MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/11866002?v=4","gravatar_id":"","url":"https://api.github.com/users/walbourn","html_url":"https://github.com/walbourn","followers_url":"https://api.github.com/users/walbourn/followers","following_url":"https://api.github.com/users/walbourn/following{/other_user}","gists_url":"https://api.github.com/users/walbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/walbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walbourn/subscriptions","organizations_url":"https://api.github.com/users/walbourn/orgs","repos_url":"https://api.github.com/users/walbourn/repos","events_url":"https://api.github.com/users/walbourn/events{/privacy}","received_events_url":"https://api.github.com/users/walbourn/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T05:39:14Z","updated_at":"2018-12-05T05:39:14Z","author_association":"MEMBER","body":"There are a number of other cases in the same file that have the same pattern. Would it make sense to update them?\r\n\r\n``LOAD_SCANLINE3`` and ``LOAD_SCANLINE2`` macros, some special cases in ``_LoadScanline``"}}
{"actor":{"display_login":"walbourn"}}