{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/ewoms/pulls/comments/193068636","pull_request_review_id":125965069,"id":193068636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA2ODYzNg==","diff_hunk":"@@ -37,57 +37,74 @@ namespace Ewoms {\n  *\n  * \\brief The primary variable and equation indices for the black-oil model.\n  */\n-template <unsigned numSolventsV, unsigned numPolymersV, unsigned PVOffset, unsigned disabledCanonicalCompIdx>\n+template <bool enableSolventV, bool enablePolymerV, bool enableEnergyV, unsigned PVOffset, unsigned disabledCanonicalCompIdx>","path":"ewoms/models/blackoil/blackoiltwophaseindices.hh","position":5,"original_position":5,"commit_id":"7ee76cb16360c8b173796f26a06abf7d68bb80a4","original_commit_id":"7ee76cb16360c8b173796f26a06abf7d68bb80a4","user":{"login":"andlaus","id":1837735,"node_id":"MDQ6VXNlcjE4Mzc3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"I mean what mother nature conserves. This could either be component mass, energy or momentum but not things like pressure, saturations, temperature or molecular weight. To me it sounds a lot like your new model uses two (pseudo-)components for the polymers and conserves the mass of each of them by tracking the total polymer mass plus their composition (via the average polymer mass). ","created_at":"2018-06-05T13:21:54Z","updated_at":"2018-06-05T13:21:54Z","html_url":"https://github.com/OPM/ewoms/pull/279#discussion_r193068636","pull_request_url":"https://api.github.com/repos/OPM/ewoms/pulls/279","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/comments/193068636"},"html":{"href":"https://github.com/OPM/ewoms/pull/279#discussion_r193068636"},"pull_request":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/279"}},"in_reply_to_id":193008021},"pull_request":{"url":"https://api.github.com/repos/OPM/ewoms/pulls/279","id":165946234,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY1OTQ2MjM0","html_url":"https://github.com/OPM/ewoms/pull/279","diff_url":"https://github.com/OPM/ewoms/pull/279.diff","patch_url":"https://github.com/OPM/ewoms/pull/279.patch","issue_url":"https://api.github.com/repos/OPM/ewoms/issues/279","number":279,"state":"closed","locked":false,"title":"Implement blackoil energy","user":{"login":"andlaus","id":1837735,"node_id":"MDQ6VXNlcjE4Mzc3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"this implements an energy conservation extension for the black-oil model. It requires some small downstream mop-up because the indices class expects an additional template argument which specifies if energy is enabled or not.\r\n\r\nI've verified that the performance of `flow` for norne does not change with this. Further testing is highly appreciated, though.\r\n\r\n","created_at":"2018-01-30T10:49:58Z","updated_at":"2018-06-05T13:21:54Z","closed_at":"2018-04-06T14:11:52Z","merged_at":"2018-04-06T14:11:52Z","merge_commit_sha":"2d7e0abe9bac69379484b67f4ed3fa0284f7d214","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/ewoms/pulls/279/commits","review_comments_url":"https://api.github.com/repos/OPM/ewoms/pulls/279/comments","review_comment_url":"https://api.github.com/repos/OPM/ewoms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/ewoms/issues/279/comments","statuses_url":"https://api.github.com/repos/OPM/ewoms/statuses/7ee76cb16360c8b173796f26a06abf7d68bb80a4","head":{"label":"andlaus:implement_blackoil_energy","ref":"implement_blackoil_energy","sha":"7ee76cb16360c8b173796f26a06abf7d68bb80a4","user":{"login":"andlaus","id":1837735,"node_id":"MDQ6VXNlcjE4Mzc3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"repo":{"id":24144469,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE0NDQ2OQ==","name":"ewoms","full_name":"andlaus/ewoms","owner":{"login":"andlaus","id":1837735,"node_id":"MDQ6VXNlcjE4Mzc3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andlaus/ewoms","description":"The eWoms Porous Media Simulation Framework","fork":true,"url":"https://api.github.com/repos/andlaus/ewoms","forks_url":"https://api.github.com/repos/andlaus/ewoms/forks","keys_url":"https://api.github.com/repos/andlaus/ewoms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andlaus/ewoms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andlaus/ewoms/teams","hooks_url":"https://api.github.com/repos/andlaus/ewoms/hooks","issue_events_url":"https://api.github.com/repos/andlaus/ewoms/issues/events{/number}","events_url":"https://api.github.com/repos/andlaus/ewoms/events","assignees_url":"https://api.github.com/repos/andlaus/ewoms/assignees{/user}","branches_url":"https://api.github.com/repos/andlaus/ewoms/branches{/branch}","tags_url":"https://api.github.com/repos/andlaus/ewoms/tags","blobs_url":"https://api.github.com/repos/andlaus/ewoms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andlaus/ewoms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andlaus/ewoms/git/refs{/sha}","trees_url":"https://api.github.com/repos/andlaus/ewoms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andlaus/ewoms/statuses/{sha}","languages_url":"https://api.github.com/repos/andlaus/ewoms/languages","stargazers_url":"https://api.github.com/repos/andlaus/ewoms/stargazers","contributors_url":"https://api.github.com/repos/andlaus/ewoms/contributors","subscribers_url":"https://api.github.com/repos/andlaus/ewoms/subscribers","subscription_url":"https://api.github.com/repos/andlaus/ewoms/subscription","commits_url":"https://api.github.com/repos/andlaus/ewoms/commits{/sha}","git_commits_url":"https://api.github.com/repos/andlaus/ewoms/git/commits{/sha}","comments_url":"https://api.github.com/repos/andlaus/ewoms/comments{/number}","issue_comment_url":"https://api.github.com/repos/andlaus/ewoms/issues/comments{/number}","contents_url":"https://api.github.com/repos/andlaus/ewoms/contents/{+path}","compare_url":"https://api.github.com/repos/andlaus/ewoms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andlaus/ewoms/merges","archive_url":"https://api.github.com/repos/andlaus/ewoms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andlaus/ewoms/downloads","issues_url":"https://api.github.com/repos/andlaus/ewoms/issues{/number}","pulls_url":"https://api.github.com/repos/andlaus/ewoms/pulls{/number}","milestones_url":"https://api.github.com/repos/andlaus/ewoms/milestones{/number}","notifications_url":"https://api.github.com/repos/andlaus/ewoms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andlaus/ewoms/labels{/name}","releases_url":"https://api.github.com/repos/andlaus/ewoms/releases{/id}","deployments_url":"https://api.github.com/repos/andlaus/ewoms/deployments","created_at":"2014-09-17T12:49:49Z","updated_at":"2018-04-26T19:19:19Z","pushed_at":"2018-05-02T09:36:34Z","git_url":"git://github.com/andlaus/ewoms.git","ssh_url":"git@github.com:andlaus/ewoms.git","clone_url":"https://github.com/andlaus/ewoms.git","svn_url":"https://github.com/andlaus/ewoms","homepage":null,"size":27048,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"b555ba527b6ca2e9ffda1430bca6a287d1473841","user":{"login":"OPM","id":1827197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjcxOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4859310,"node_id":"MDEwOlJlcG9zaXRvcnk0ODU5MzEw","name":"ewoms","full_name":"OPM/ewoms","owner":{"login":"OPM","id":1827197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjcxOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/ewoms","description":"The eWoms Porous Media Simulation Framework","fork":false,"url":"https://api.github.com/repos/OPM/ewoms","forks_url":"https://api.github.com/repos/OPM/ewoms/forks","keys_url":"https://api.github.com/repos/OPM/ewoms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/ewoms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/ewoms/teams","hooks_url":"https://api.github.com/repos/OPM/ewoms/hooks","issue_events_url":"https://api.github.com/repos/OPM/ewoms/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/ewoms/events","assignees_url":"https://api.github.com/repos/OPM/ewoms/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/ewoms/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/ewoms/tags","blobs_url":"https://api.github.com/repos/OPM/ewoms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/ewoms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/ewoms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/ewoms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/ewoms/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/ewoms/languages","stargazers_url":"https://api.github.com/repos/OPM/ewoms/stargazers","contributors_url":"https://api.github.com/repos/OPM/ewoms/contributors","subscribers_url":"https://api.github.com/repos/OPM/ewoms/subscribers","subscription_url":"https://api.github.com/repos/OPM/ewoms/subscription","commits_url":"https://api.github.com/repos/OPM/ewoms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/ewoms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/ewoms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/ewoms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/ewoms/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/ewoms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/ewoms/merges","archive_url":"https://api.github.com/repos/OPM/ewoms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/ewoms/downloads","issues_url":"https://api.github.com/repos/OPM/ewoms/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/ewoms/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/ewoms/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/ewoms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/ewoms/labels{/name}","releases_url":"https://api.github.com/repos/OPM/ewoms/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/ewoms/deployments","created_at":"2012-07-02T12:07:07Z","updated_at":"2018-06-01T09:46:59Z","pushed_at":"2018-06-01T09:46:56Z","git_url":"git://github.com/OPM/ewoms.git","ssh_url":"git@github.com:OPM/ewoms.git","clone_url":"https://github.com/OPM/ewoms.git","svn_url":"https://github.com/OPM/ewoms","homepage":null,"size":27084,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/279"},"html":{"href":"https://github.com/OPM/ewoms/pull/279"},"issue":{"href":"https://api.github.com/repos/OPM/ewoms/issues/279"},"comments":{"href":"https://api.github.com/repos/OPM/ewoms/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/ewoms/statuses/7ee76cb16360c8b173796f26a06abf7d68bb80a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andlaus"}}