{"action":"created","issue":{"url":"https://api.github.com/repos/apache/drill/issues/1446","repository_url":"https://api.github.com/repos/apache/drill","labels_url":"https://api.github.com/repos/apache/drill/issues/1446/labels{/name}","comments_url":"https://api.github.com/repos/apache/drill/issues/1446/comments","events_url":"https://api.github.com/repos/apache/drill/issues/1446/events","html_url":"https://github.com/apache/drill/pull/1446","id":354305864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDk5ODg5","number":1446,"title":"DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM","user":{"login":"oleg-zinovev","id":17238766,"node_id":"MDQ6VXNlcjE3MjM4NzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17238766?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-zinovev","html_url":"https://github.com/oleg-zinovev","followers_url":"https://api.github.com/users/oleg-zinovev/followers","following_url":"https://api.github.com/users/oleg-zinovev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-zinovev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-zinovev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-zinovev/subscriptions","organizations_url":"https://api.github.com/users/oleg-zinovev/orgs","repos_url":"https://api.github.com/users/oleg-zinovev/repos","events_url":"https://api.github.com/users/oleg-zinovev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-zinovev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-08-27T12:51:14Z","updated_at":"2018-11-01T12:21:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/1446","html_url":"https://github.com/apache/drill/pull/1446","diff_url":"https://github.com/apache/drill/pull/1446.diff","patch_url":"https://github.com/apache/drill/pull/1446.patch"},"body":"PR allows both build and run with JDK8, JDK 10 (and, likely, JDK9).\r\nAll tests, except HBase, Hive, Kafka Storage Plugin tests, works on JDK10:\r\n - HBase cannot start master: HMaster ctor fails with message \"Unexpected version format: 10.0.2\"\r\n - Hive cannot create HiveMetaStoreClient: ctor fails with \"java.base/[Ljava.lang.Object; cannot be cast to java.base/[Ljava.net.URI;\"\r\n - Kafka: KafkaFilterPushdownTest fails with errors \"java.lang.NoSuchMethodError: sun.nio.ch.DirectBuffer.cleaner()Lsun/misc/Cleaner;\"\r\n\r\nChanges:\r\n- Added a DrillPlatformDependent class, which tries to read maxDirectMemory from jdk.internal.misc.VM, otherwise fallbacks to netty PlatformDependent\r\n- asm dependency updated to 6.2.1, and ReplacingInterpreter fixed\r\n- fixed List.toArray() call in FileSystemPartitionDescriptor (in JDK10 this method return Object[] and cast fails)\r\n- surefire plugin updated to 2.21.0\r\n- surefire configuration changed: \r\n  1) added -XX:+IgnoreUnrecognizedVMOptions\r\n  2) added java.se module (mostly, for java.sql module)\r\n  3) added -Djdk.attach.allowAttachSelf=true, required by jmockit\r\n  4) added locale and country settings, because format tests fails with my system locale\r\n- compiler plugin updated to 3.8.0\r\n- JarBuilder fixed for JDK10 (target 1.5 and source 1.5 not supported by javac 10)\r\n- Drill2489CallsAfterCloseThrowExceptionsTest.ThrowsClosedBulkChecker skips new methods in JDK10 (JDK9 ?) jdbc api\r\n- added jaxb-api and javax.activation dependencies, because javax.xml.bind and javax.activation modules will be removed in JDK11 (javax.activation used by jersey)\r\n- drill-config.sh and sqlline.bat changed:\r\n  1) added -XX:+IgnoreUnrecognizedVMOptions\r\n  2) added --add-modules java.se (mostly, for java.sql module)\r\n  3) added --add-opens java.base/jdk.internal.misc=ALL-UNNAMED (allows access to jdk.internal.misc.VM)\r\n\r\nP.S. I am sorry for possible mistakes because of my bad English"},"comment":{"url":"https://api.github.com/repos/apache/drill/issues/comments/435024088","html_url":"https://github.com/apache/drill/pull/1446#issuecomment-435024088","issue_url":"https://api.github.com/repos/apache/drill/issues/1446","id":435024088,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTAyNDA4OA==","user":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T12:21:43Z","updated_at":"2018-11-01T12:21:43Z","author_association":"CONTRIBUTOR","body":"@oleg-zinovev, thanks for fixing this. I think it is ok to exclude this library from the shade, since there are no other transitive dependencies on this, and as you pointed, the single class, where it is used was also excluded."}}
{"actor":{"display_login":"vvysotskyi"}}