{"push_id":2768035011,"size":9,"distinct_size":1,"ref":"refs/heads/error-prone-suppress-immutable-enum-checker-for-enum-singletons","head":"4887dd61a81abf53217b3247c8ea16ceace318ba","before":"8c16f0bef9db24d22889791271fd1bd573f07ab0","commits":[{"sha":"57b36df825b40665cce0f0c892fc2cef91041c6a","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Prevent NPE during combat with edit mode enabled. (#3669)\n\n* Prevent NPE during combat with edit mode enabled.\r\n\r\nWhen edit mode is enabled the dice rolled comes in as null, this goes on to cause NPE's in DicePanel#setDiceRoll. Avoiding the null references and defaulting to zero works, combat proceeds to conclusion afterwards.\r\n\r\n* Shorten things up, refactor, use \"Optional#ifPresnent\" and avoid unnecessary casting\r\n\r\n* Fix unused import\r\n\r\n* Replace integer bounded for loop with \"IntStream\"","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/57b36df825b40665cce0f0c892fc2cef91041c6a"},{"sha":"025a2378a76b966cdfc140bc112e48e2999c75f1","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Migrate CliProperty 'gameStarted' to static state from System property. (#3665)\n\n- 'gameStarted' is not actually a CLI arg, we use it as a system property to communicate data state from one place to another. The update here moves that value from System prop to be behind a static method instead.","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/025a2378a76b966cdfc140bc112e48e2999c75f1"},{"sha":"3abff5fc4e82adc761090a1c29fffb9ba62765bb","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"ServerConnectionProps  simplify (#3671)\n\n* Use @Builder+@Getter with ServerConnectionProps to simplify\r\n\r\n* Reduce scope of class ServerConnectionProps","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/3abff5fc4e82adc761090a1c29fffb9ba62765bb"},{"sha":"5126b34c3a174f436946ba733e1ba0bbc279e963","author":{"name":"Steven Soloff","email":"384a94dadce6096f220017836e6b0b83e6eaefac@gmail.com"},"message":"Fix potential NPE (#3678)","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/5126b34c3a174f436946ba733e1ba0bbc279e963"},{"sha":"cb17fd48edf5461a5bd1e39bb6cebb071323dea1","author":{"name":"Steven Soloff","email":"384a94dadce6096f220017836e6b0b83e6eaefac@gmail.com"},"message":"Checkstyle: Fix final local variable violations (#3680)","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/cb17fd48edf5461a5bd1e39bb6cebb071323dea1"},{"sha":"76c7f64bff6a27d16f616ffd7ea6a460ebe512d7","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Remove write only system properties (#3676)\n\nWe have some code that comments we store some system props before clearing them in the headless case so we can load save games, but we never read those property values except only to save them. That implies this is actually dead functionality and the commentary is misleading (so we can remove this code)","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/76c7f64bff6a27d16f616ffd7ea6a460ebe512d7"},{"sha":"6c1d9c2a3bbbdb178e72bfd6c8571490f134a8a3","author":{"name":"tripleabuilderbot","email":"78994fdf3efccc9805bb5fbb9d9167872e45b475@gmail.com"},"message":"Bot: Update Checkstyle thresholds after build 10937 (#3682)","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/6c1d9c2a3bbbdb178e72bfd6c8571490f134a8a3"},{"sha":"6008abb6395b5ddc8d03f0633ce8222093ee6b1e","author":{"name":"Steven Soloff","email":"384a94dadce6096f220017836e6b0b83e6eaefac@gmail.com"},"message":"Clean up LobbyRunner (#3679)\n\n* Mark class final and prevent instantiation\r\n\r\n* Use Lombok @Log\r\n\r\n* Exit with nonzero status when failing to start lobby\r\n\r\n* Update Javadocs","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/6008abb6395b5ddc8d03f0633ce8222093ee6b1e"},{"sha":"4887dd61a81abf53217b3247c8ea16ceace318ba","author":{"name":"Steven Soloff","email":"384a94dadce6096f220017836e6b0b83e6eaefac@gmail.com"},"message":"Error Prone: Suppress ImmutableEnumChecker for Enum singletons","distinct":true,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits/4887dd61a81abf53217b3247c8ea16ceace318ba"}]}
{"actor":{"display_login":"ssoloff"}}