{"action":"created","comment":{"url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/comments/234153928","pull_request_review_id":175679831,"id":234153928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE1MzkyOA==","diff_hunk":"@@ -69,147 +87,205 @@ public function toArray() {\n   }\n \n   /**\n+   * Get the product name.\n+   *\n    * @return string\n+   *   The name.\n    */\n   public function getName() {\n     return $this->name;\n   }\n \n   /**\n+   * Set the product name.\n+   *\n    * @param string $name\n+   *   The name.\n    *\n-   * @return Product\n+   * @return Drupal\\commerce_google_tag_manager\\Product","path":"src/Product.php","position":96,"original_position":96,"commit_id":"f7165d1cdfe4005cc64bd2574b734a4c6d75077e","original_commit_id":"f7165d1cdfe4005cc64bd2574b734a4c6d75077e","user":{"login":"WengerK","id":1841592,"node_id":"MDQ6VXNlcjE4NDE1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1841592?v=4","gravatar_id":"","url":"https://api.github.com/users/WengerK","html_url":"https://github.com/WengerK","followers_url":"https://api.github.com/users/WengerK/followers","following_url":"https://api.github.com/users/WengerK/following{/other_user}","gists_url":"https://api.github.com/users/WengerK/gists{/gist_id}","starred_url":"https://api.github.com/users/WengerK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WengerK/subscriptions","organizations_url":"https://api.github.com/users/WengerK/orgs","repos_url":"https://api.github.com/users/WengerK/repos","events_url":"https://api.github.com/users/WengerK/events{/privacy}","received_events_url":"https://api.github.com/users/WengerK/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n   * @return \\Drupal\\commerce_google_tag_manager\\Product\r\n```","created_at":"2018-11-16T10:17:54Z","updated_at":"2018-11-16T10:18:16Z","html_url":"https://github.com/gridonic/commerce_google_tag_manager/pull/14#discussion_r234153928","pull_request_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/comments/234153928"},"html":{"href":"https://github.com/gridonic/commerce_google_tag_manager/pull/14#discussion_r234153928"},"pull_request":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14","id":230963170,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTYzMTcw","html_url":"https://github.com/gridonic/commerce_google_tag_manager/pull/14","diff_url":"https://github.com/gridonic/commerce_google_tag_manager/pull/14.diff","patch_url":"https://github.com/gridonic/commerce_google_tag_manager/pull/14.patch","issue_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/14","number":14,"state":"open","locked":false,"title":"add automated quality control & post-commit script","user":{"login":"WengerK","id":1841592,"node_id":"MDQ6VXNlcjE4NDE1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1841592?v=4","gravatar_id":"","url":"https://api.github.com/users/WengerK","html_url":"https://github.com/WengerK","followers_url":"https://api.github.com/users/WengerK/followers","following_url":"https://api.github.com/users/WengerK/following{/other_user}","gists_url":"https://api.github.com/users/WengerK/gists{/gist_id}","starred_url":"https://api.github.com/users/WengerK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WengerK/subscriptions","organizations_url":"https://api.github.com/users/WengerK/orgs","repos_url":"https://api.github.com/users/WengerK/repos","events_url":"https://api.github.com/users/WengerK/events{/privacy}","received_events_url":"https://api.github.com/users/WengerK/received_events","type":"User","site_admin":false},"body":"This PR make a lot of changes here why:\r\n\r\n### Automated Quality Control - Pareview\r\n\r\nI added a new Quality Control script which is the same as https://pareview.sh/ for Drupal.\r\n\r\nYou can use this scripts by:\r\n\r\n1. Install depencency\r\n\r\n```\r\ncomposer install\r\n```\r\n\r\n2. Add the post-commit script in your .git\r\n\r\n```\r\ncat ./scripts/hooks/post-commit >> ./.git/hooks/post-commit\r\n```\r\n\r\n3. Commit or use the script \r\n\r\n```\r\n./.git/hooks/post-commit\r\n```\r\n\r\nThis script will run:\r\n\r\n- phpcs: Code Sniffer Drupal & DrupalPractice\r\n- phpmd: PHP Mess Detector\r\n- phpcpd: PHP Copy/Paste Detector\r\n- phpcf: PhpCodeFixer\r\n\r\n### Refactoring to follow Drupal Coding Standard instead of Symfony ones\r\n\r\nAlso, by adding those, I had to change a lot of code - essential for the following reasons:\r\n\r\n- The code follows the Symfony Best Pratices (most of the time because variable's name was **camelCase** instead of **snake_case** @see https://www.drupal.org/docs/develop/standards/coding-standards\r\n- The code miss some comments (@wanze it could be great if you could review because I \"sometimes\" added some comment whiteout having a deep knowledge of what was the purpose of some feature/method/property).","created_at":"2018-11-14T20:00:49Z","updated_at":"2018-11-16T10:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d3f2ef78a3bbf670219eb1941f55aa4ea079ed7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14/commits","review_comments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14/comments","review_comment_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/14/comments","statuses_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/statuses/f7165d1cdfe4005cc64bd2574b734a4c6d75077e","head":{"label":"gridonic:automated-quality-control","ref":"automated-quality-control","sha":"f7165d1cdfe4005cc64bd2574b734a4c6d75077e","user":{"login":"gridonic","id":247297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/247297?v=4","gravatar_id":"","url":"https://api.github.com/users/gridonic","html_url":"https://github.com/gridonic","followers_url":"https://api.github.com/users/gridonic/followers","following_url":"https://api.github.com/users/gridonic/following{/other_user}","gists_url":"https://api.github.com/users/gridonic/gists{/gist_id}","starred_url":"https://api.github.com/users/gridonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridonic/subscriptions","organizations_url":"https://api.github.com/users/gridonic/orgs","repos_url":"https://api.github.com/users/gridonic/repos","events_url":"https://api.github.com/users/gridonic/events{/privacy}","received_events_url":"https://api.github.com/users/gridonic/received_events","type":"Organization","site_admin":false},"repo":{"id":154511911,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MTE5MTE=","name":"commerce_google_tag_manager","full_name":"gridonic/commerce_google_tag_manager","private":false,"owner":{"login":"gridonic","id":247297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/247297?v=4","gravatar_id":"","url":"https://api.github.com/users/gridonic","html_url":"https://github.com/gridonic","followers_url":"https://api.github.com/users/gridonic/followers","following_url":"https://api.github.com/users/gridonic/following{/other_user}","gists_url":"https://api.github.com/users/gridonic/gists{/gist_id}","starred_url":"https://api.github.com/users/gridonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridonic/subscriptions","organizations_url":"https://api.github.com/users/gridonic/orgs","repos_url":"https://api.github.com/users/gridonic/repos","events_url":"https://api.github.com/users/gridonic/events{/privacy}","received_events_url":"https://api.github.com/users/gridonic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridonic/commerce_google_tag_manager","description":" Provides Commerce integration for Enhanced Ecommerce via Google Tag Manager","fork":false,"url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager","forks_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/forks","keys_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/teams","hooks_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/hooks","issue_events_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/events{/number}","events_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/events","assignees_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/assignees{/user}","branches_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/branches{/branch}","tags_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/tags","blobs_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/languages","stargazers_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/stargazers","contributors_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/contributors","subscribers_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/subscribers","subscription_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/subscription","commits_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/contents/{+path}","compare_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/merges","archive_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/downloads","issues_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues{/number}","pulls_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/labels{/name}","releases_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/releases{/id}","deployments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/deployments","created_at":"2018-10-24T14:06:14Z","updated_at":"2018-11-14T12:01:14Z","pushed_at":"2018-11-15T13:52:04Z","git_url":"git://github.com/gridonic/commerce_google_tag_manager.git","ssh_url":"git@github.com:gridonic/commerce_google_tag_manager.git","clone_url":"https://github.com/gridonic/commerce_google_tag_manager.git","svn_url":"https://github.com/gridonic/commerce_google_tag_manager","homepage":"","size":50,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":2,"watchers":2,"default_branch":"8.x-1.x"}},"base":{"label":"gridonic:8.x-1.x","ref":"8.x-1.x","sha":"6f2615243e2b53a74047f079ffd7b549fd645800","user":{"login":"gridonic","id":247297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/247297?v=4","gravatar_id":"","url":"https://api.github.com/users/gridonic","html_url":"https://github.com/gridonic","followers_url":"https://api.github.com/users/gridonic/followers","following_url":"https://api.github.com/users/gridonic/following{/other_user}","gists_url":"https://api.github.com/users/gridonic/gists{/gist_id}","starred_url":"https://api.github.com/users/gridonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridonic/subscriptions","organizations_url":"https://api.github.com/users/gridonic/orgs","repos_url":"https://api.github.com/users/gridonic/repos","events_url":"https://api.github.com/users/gridonic/events{/privacy}","received_events_url":"https://api.github.com/users/gridonic/received_events","type":"Organization","site_admin":false},"repo":{"id":154511911,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MTE5MTE=","name":"commerce_google_tag_manager","full_name":"gridonic/commerce_google_tag_manager","private":false,"owner":{"login":"gridonic","id":247297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/247297?v=4","gravatar_id":"","url":"https://api.github.com/users/gridonic","html_url":"https://github.com/gridonic","followers_url":"https://api.github.com/users/gridonic/followers","following_url":"https://api.github.com/users/gridonic/following{/other_user}","gists_url":"https://api.github.com/users/gridonic/gists{/gist_id}","starred_url":"https://api.github.com/users/gridonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridonic/subscriptions","organizations_url":"https://api.github.com/users/gridonic/orgs","repos_url":"https://api.github.com/users/gridonic/repos","events_url":"https://api.github.com/users/gridonic/events{/privacy}","received_events_url":"https://api.github.com/users/gridonic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridonic/commerce_google_tag_manager","description":" Provides Commerce integration for Enhanced Ecommerce via Google Tag Manager","fork":false,"url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager","forks_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/forks","keys_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/teams","hooks_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/hooks","issue_events_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/events{/number}","events_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/events","assignees_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/assignees{/user}","branches_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/branches{/branch}","tags_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/tags","blobs_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/languages","stargazers_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/stargazers","contributors_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/contributors","subscribers_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/subscribers","subscription_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/subscription","commits_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/contents/{+path}","compare_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/merges","archive_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/downloads","issues_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues{/number}","pulls_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/labels{/name}","releases_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/releases{/id}","deployments_url":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/deployments","created_at":"2018-10-24T14:06:14Z","updated_at":"2018-11-14T12:01:14Z","pushed_at":"2018-11-15T13:52:04Z","git_url":"git://github.com/gridonic/commerce_google_tag_manager.git","ssh_url":"git@github.com:gridonic/commerce_google_tag_manager.git","clone_url":"https://github.com/gridonic/commerce_google_tag_manager.git","svn_url":"https://github.com/gridonic/commerce_google_tag_manager","homepage":"","size":50,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":2,"watchers":2,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14"},"html":{"href":"https://github.com/gridonic/commerce_google_tag_manager/pull/14"},"issue":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/14"},"comments":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/gridonic/commerce_google_tag_manager/statuses/f7165d1cdfe4005cc64bd2574b734a4c6d75077e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"WengerK"}}