{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/198949625","pull_request_review_id":132975790,"id":198949625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODk0OTYyNQ==","diff_hunk":"@@ -621,6 +621,22 @@\n       [ [ \"filament\", 20, \"LIST\" ], [ \"cordage\", 2, \"LIST\" ] ]\n     ]\n   },\n+  {\n+    \"result\": \"spearsling\",\n+    \"type\": \"recipe\",\n+    \"category\": \"CC_ARMOR\",\n+    \"subcategory\": \"CSC_ARMOR_STORAGE\",\n+    \"skill_used\": \"tailor\",\n+    \"difficulty\": 3,\n+    \"skills_required\": [ \"stabbing\", 2 ],","path":"data/json/recipes/armor/storage.json","position":11,"original_position":11,"commit_id":"8d5f2387aadc21af331a7d19b9584d4094f718ef","original_commit_id":"8d5f2387aadc21af331a7d19b9584d4094f718ef","user":{"login":"Xhuis","id":15898043,"node_id":"MDQ6VXNlcjE1ODk4MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/15898043?v=4","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"body":"Because it's a specialized sling made specifically for spears, I included minor skill in piercing weapons to represent the required knowledge.","created_at":"2018-06-28T18:54:59Z","updated_at":"2018-06-28T18:54:59Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120#discussion_r198949625","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/198949625"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120#discussion_r198949625"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120"}},"in_reply_to_id":198943490},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120","id":198112512,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTEyNTEy","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24120","number":24120,"state":"open","locked":false,"title":"Shows spears some love - homemade halfpike, spear strap, and stat tweaks","user":{"login":"Xhuis","id":15898043,"node_id":"MDQ6VXNlcjE1ODk4MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/15898043?v=4","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"body":"Since the series of PRs nerfing some of the spears, I've found that the early spears have been basically unusable. Knife spears, even with the adjustments made after the fact, break in around three hits, and just aren't worth making anymore. Forked spears are still okay for specialized uses, but not good combat weapons. I also saw a PR that added a spear holster that was closed by its author, who decided not to work on it. Here's my attempt at making them a little more fun.\r\n\r\nThis PR:\r\n* Adds the homemade halfpike! Make it like [this](https://i.imgur.com/bigLgGj.png). This is the \"properly-made knife spear with a seated tip and handle\" idea that got tossed around. Boasting an attack speed of 119, it's a slightly slow weapon, and functions as an early spear weapon that doesn't break super fast, filling the niche that the old knife spear did without making it very easy to acquire and not outclassing other weapons.\r\n  * Its stats are about equivalent to the knife spear, with 1 extra point of damage and a higher weight. It can't be obtained at the start of the game without a decent chunk of stat investment, bringing it more in line with other early combat spears like the pipe spear and wooden spear.\r\n* Adds the spear strap! This lets you holster spears like you can things such as katanas and broadswords. It can sheath any spear up to and including the awl pike, and has an encumbrance of 4. Craft it with 7 of any cloth material (rags, leather...) plus some cordage, tailoring 3, and piercing weapons 1.\r\n* Tweaks the descriptions of the knife spear and forked spear to represent their uses. The knife spear's fragility is highlighted to be a weapon for the desperate ala the rock in a sock, and the forked spear is emphasized as a disarming tool rather than an extended fighting weapon.\r\n* Reduces the knife spear's volume a tiny bit to make them more appealing despite their fragility.\r\n\r\nSuggestions, ideas, and criticism are welcome. If this PR is received well, I intend to make some more additions to the spear lineup to encourage variety and choosing different weapons, such as a pike that can make long reach attacks with less damage, or a partizan that deals split cut and pierce damage.","created_at":"2018-06-28T18:19:58Z","updated_at":"2018-06-28T18:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2c9a52229b4328e72e8f342fe99f94a35b7812","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24120/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/8d5f2387aadc21af331a7d19b9584d4094f718ef","head":{"label":"Xhuis:early_spears","ref":"early_spears","sha":"8d5f2387aadc21af331a7d19b9584d4094f718ef","user":{"login":"Xhuis","id":15898043,"node_id":"MDQ6VXNlcjE1ODk4MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/15898043?v=4","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"repo":{"id":110011483,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMTE0ODM=","name":"Cataclysm-DDA","full_name":"Xhuis/Cataclysm-DDA","owner":{"login":"Xhuis","id":15898043,"node_id":"MDQ6VXNlcjE1ODk4MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/15898043?v=4","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Xhuis/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/Xhuis/Cataclysm-DDA/deployments","created_at":"2017-11-08T18:01:11Z","updated_at":"2017-11-08T18:01:23Z","pushed_at":"2018-06-28T18:08:29Z","git_url":"git://github.com/Xhuis/Cataclysm-DDA.git","ssh_url":"git@github.com:Xhuis/Cataclysm-DDA.git","clone_url":"https://github.com/Xhuis/Cataclysm-DDA.git","svn_url":"https://github.com/Xhuis/Cataclysm-DDA","homepage":"http://cleverraven.github.io/Cataclysm-DDA/","size":1206939,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"1db1b62b57a38c18e5f118fb57dcb1290d42d9b9","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-06-28T09:43:30Z","pushed_at":"2018-06-28T18:19:58Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1229739,"stargazers_count":1913,"watchers_count":1913,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1319,"mirror_url":null,"archived":false,"open_issues_count":840,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1319,"open_issues":840,"watchers":1913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24120"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24120"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24120/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24120/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/8d5f2387aadc21af331a7d19b9584d4094f718ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Xhuis"}}