{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/release/pulls/comments/206123176","pull_request_review_id":141520681,"id":206123176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyMzE3Ng==","diff_hunk":"@@ -0,0 +1,130 @@\n+ci-operator templates\n+=====================\n+\n+\n+E2E tests\n+---------\n+\n+The preferred way to write e2e tests is using `ci-operator`.  See the\n+documentation for details on how to download, build, and execute it:\n+\n+https://github.com/openshift/ci-operator.git\n+\n+Many projects already have a `ci-operator` configuration file, which takes care\n+of most of the CI process: downloading the source, building binaries, building\n+RPMs, creating images, executing unit tests, etc.  These can be built upon for\n+e2e test, requiring little or no modification.\n+\n+\n+# Provisioning a cluster\n+\n+Contrary to other types of tests, E2E tests usually require a cluster, not just\n+a single container.  While there aren't yet native primitives in `ci-operator`\n+for cluster provisioning, it provides one open-ended feature that can be\n+leveraged to accomplish that: template steps.\n+\n+Template steps allow the creation of arbitrary objects (e.g. pods) in the\n+cluster where the CI pipeline is executed.  This directory already contains a\n+few templates that can be used either directly or (rarely necessary, in\n+practice) as a reference:\n+\n+TODO: describe these in detail: purpose, inputs, …\n+\n+- `cluster-launch-e2e.yaml`:\n+- `cluster-launch-installer-e2e.yaml`:\n+- `cluster-launch-src.yaml`:\n+- `master-sidecar.yaml`:\n+- `os.yaml`:\n+\n+\n+# Using a template\n+\n+A template can be used with the `--template` argument.  The name of the\n+template, or the name of the file without the extension, becomes the name of\n+the stage, so it can be used as an argument to `--target`.  This does not\n+require modifying the configuration file.\n+\n+When processing the template, `ci-operator` passes several parameters with\n+information about the tests (e.g. the job name, which namespace it's operating\n+into, URLs for images).  These parameters are described in its usage message.\n+\n+Logs from pods that fail will be fetched and stored if collection of artifacts\n+is enabled (using the `--artifacts-dir` flag).  If part of the output is\n+necessary even in case of success, it can be written to the artifact directory.\n+\n+Here is a sample job with descriptions of the relevant sections (for a complete\n+description of the fields, see prow's documentation).  This job uses the\n+`cluster-launch-src.yaml` template to provision a GCP cluster and run an e2e\n+test script.  Note that there currently is a lot of unnecessary complexity and\n+duplication, which should be cleared in the future.","path":"cluster/ci/config/prow/jobs/README.md","position":null,"original_position":59,"commit_id":"081843b3ee9308651d3dc96b99f5a61c2f26b141","original_commit_id":"64879b69f111a0152a1511a21d9c4032c3addac9","user":{"login":"bbguimaraes","id":934092,"node_id":"MDQ6VXNlcjkzNDA5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/934092?v=4","gravatar_id":"","url":"https://api.github.com/users/bbguimaraes","html_url":"https://github.com/bbguimaraes","followers_url":"https://api.github.com/users/bbguimaraes/followers","following_url":"https://api.github.com/users/bbguimaraes/following{/other_user}","gists_url":"https://api.github.com/users/bbguimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/bbguimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbguimaraes/subscriptions","organizations_url":"https://api.github.com/users/bbguimaraes/orgs","repos_url":"https://api.github.com/users/bbguimaraes/repos","events_url":"https://api.github.com/users/bbguimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/bbguimaraes/received_events","type":"User","site_admin":false},"body":"The should be the comments.  Updated the paragraph to make that clearer.","created_at":"2018-07-30T13:00:05Z","updated_at":"2018-07-30T13:00:05Z","html_url":"https://github.com/openshift/release/pull/1113#discussion_r206123176","pull_request_url":"https://api.github.com/repos/openshift/release/pulls/1113","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/release/pulls/comments/206123176"},"html":{"href":"https://github.com/openshift/release/pull/1113#discussion_r206123176"},"pull_request":{"href":"https://api.github.com/repos/openshift/release/pulls/1113"}},"in_reply_to_id":206081277},"pull_request":{"url":"https://api.github.com/repos/openshift/release/pulls/1113","id":204501199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTAxMTk5","html_url":"https://github.com/openshift/release/pull/1113","diff_url":"https://github.com/openshift/release/pull/1113.diff","patch_url":"https://github.com/openshift/release/pull/1113.patch","issue_url":"https://api.github.com/repos/openshift/release/issues/1113","number":1113,"state":"open","locked":false,"title":"WIP: E2E docs","user":{"login":"bbguimaraes","id":934092,"node_id":"MDQ6VXNlcjkzNDA5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/934092?v=4","gravatar_id":"","url":"https://api.github.com/users/bbguimaraes","html_url":"https://github.com/bbguimaraes","followers_url":"https://api.github.com/users/bbguimaraes/followers","following_url":"https://api.github.com/users/bbguimaraes/following{/other_user}","gists_url":"https://api.github.com/users/bbguimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/bbguimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbguimaraes/subscriptions","organizations_url":"https://api.github.com/users/bbguimaraes/orgs","repos_url":"https://api.github.com/users/bbguimaraes/repos","events_url":"https://api.github.com/users/bbguimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/bbguimaraes/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-27T18:04:00Z","updated_at":"2018-07-30T13:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e876487c056f0da5c9cd249cf21d44973b885ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"coverprice","id":2594816,"node_id":"MDQ6VXNlcjI1OTQ4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2594816?v=4","gravatar_id":"","url":"https://api.github.com/users/coverprice","html_url":"https://github.com/coverprice","followers_url":"https://api.github.com/users/coverprice/followers","following_url":"https://api.github.com/users/coverprice/following{/other_user}","gists_url":"https://api.github.com/users/coverprice/gists{/gist_id}","starred_url":"https://api.github.com/users/coverprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coverprice/subscriptions","organizations_url":"https://api.github.com/users/coverprice/orgs","repos_url":"https://api.github.com/users/coverprice/repos","events_url":"https://api.github.com/users/coverprice/events{/privacy}","received_events_url":"https://api.github.com/users/coverprice/received_events","type":"User","site_admin":false},{"login":"droslean","id":8650912,"node_id":"MDQ6VXNlcjg2NTA5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8650912?v=4","gravatar_id":"","url":"https://api.github.com/users/droslean","html_url":"https://github.com/droslean","followers_url":"https://api.github.com/users/droslean/followers","following_url":"https://api.github.com/users/droslean/following{/other_user}","gists_url":"https://api.github.com/users/droslean/gists{/gist_id}","starred_url":"https://api.github.com/users/droslean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droslean/subscriptions","organizations_url":"https://api.github.com/users/droslean/orgs","repos_url":"https://api.github.com/users/droslean/repos","events_url":"https://api.github.com/users/droslean/events{/privacy}","received_events_url":"https://api.github.com/users/droslean/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":686552817,"node_id":"MDU6TGFiZWw2ODY1NTI4MTc=","url":"https://api.github.com/repos/openshift/release/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":681779135,"node_id":"MDU6TGFiZWw2ODE3NzkxMzU=","url":"https://api.github.com/repos/openshift/release/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/release/pulls/1113/commits","review_comments_url":"https://api.github.com/repos/openshift/release/pulls/1113/comments","review_comment_url":"https://api.github.com/repos/openshift/release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/release/issues/1113/comments","statuses_url":"https://api.github.com/repos/openshift/release/statuses/081843b3ee9308651d3dc96b99f5a61c2f26b141","head":{"label":"bbguimaraes:e2e_doc","ref":"e2e_doc","sha":"081843b3ee9308651d3dc96b99f5a61c2f26b141","user":{"login":"bbguimaraes","id":934092,"node_id":"MDQ6VXNlcjkzNDA5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/934092?v=4","gravatar_id":"","url":"https://api.github.com/users/bbguimaraes","html_url":"https://github.com/bbguimaraes","followers_url":"https://api.github.com/users/bbguimaraes/followers","following_url":"https://api.github.com/users/bbguimaraes/following{/other_user}","gists_url":"https://api.github.com/users/bbguimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/bbguimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbguimaraes/subscriptions","organizations_url":"https://api.github.com/users/bbguimaraes/orgs","repos_url":"https://api.github.com/users/bbguimaraes/repos","events_url":"https://api.github.com/users/bbguimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/bbguimaraes/received_events","type":"User","site_admin":false},"repo":{"id":124421189,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjExODk=","name":"release","full_name":"bbguimaraes/release","owner":{"login":"bbguimaraes","id":934092,"node_id":"MDQ6VXNlcjkzNDA5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/934092?v=4","gravatar_id":"","url":"https://api.github.com/users/bbguimaraes","html_url":"https://github.com/bbguimaraes","followers_url":"https://api.github.com/users/bbguimaraes/followers","following_url":"https://api.github.com/users/bbguimaraes/following{/other_user}","gists_url":"https://api.github.com/users/bbguimaraes/gists{/gist_id}","starred_url":"https://api.github.com/users/bbguimaraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbguimaraes/subscriptions","organizations_url":"https://api.github.com/users/bbguimaraes/orgs","repos_url":"https://api.github.com/users/bbguimaraes/repos","events_url":"https://api.github.com/users/bbguimaraes/events{/privacy}","received_events_url":"https://api.github.com/users/bbguimaraes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbguimaraes/release","description":"Release tooling for OpenShift Origin","fork":true,"url":"https://api.github.com/repos/bbguimaraes/release","forks_url":"https://api.github.com/repos/bbguimaraes/release/forks","keys_url":"https://api.github.com/repos/bbguimaraes/release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbguimaraes/release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbguimaraes/release/teams","hooks_url":"https://api.github.com/repos/bbguimaraes/release/hooks","issue_events_url":"https://api.github.com/repos/bbguimaraes/release/issues/events{/number}","events_url":"https://api.github.com/repos/bbguimaraes/release/events","assignees_url":"https://api.github.com/repos/bbguimaraes/release/assignees{/user}","branches_url":"https://api.github.com/repos/bbguimaraes/release/branches{/branch}","tags_url":"https://api.github.com/repos/bbguimaraes/release/tags","blobs_url":"https://api.github.com/repos/bbguimaraes/release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbguimaraes/release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbguimaraes/release/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbguimaraes/release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbguimaraes/release/statuses/{sha}","languages_url":"https://api.github.com/repos/bbguimaraes/release/languages","stargazers_url":"https://api.github.com/repos/bbguimaraes/release/stargazers","contributors_url":"https://api.github.com/repos/bbguimaraes/release/contributors","subscribers_url":"https://api.github.com/repos/bbguimaraes/release/subscribers","subscription_url":"https://api.github.com/repos/bbguimaraes/release/subscription","commits_url":"https://api.github.com/repos/bbguimaraes/release/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbguimaraes/release/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbguimaraes/release/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbguimaraes/release/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbguimaraes/release/contents/{+path}","compare_url":"https://api.github.com/repos/bbguimaraes/release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbguimaraes/release/merges","archive_url":"https://api.github.com/repos/bbguimaraes/release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbguimaraes/release/downloads","issues_url":"https://api.github.com/repos/bbguimaraes/release/issues{/number}","pulls_url":"https://api.github.com/repos/bbguimaraes/release/pulls{/number}","milestones_url":"https://api.github.com/repos/bbguimaraes/release/milestones{/number}","notifications_url":"https://api.github.com/repos/bbguimaraes/release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbguimaraes/release/labels{/name}","releases_url":"https://api.github.com/repos/bbguimaraes/release/releases{/id}","deployments_url":"https://api.github.com/repos/bbguimaraes/release/deployments","created_at":"2018-03-08T16:51:10Z","updated_at":"2018-03-08T16:51:12Z","pushed_at":"2018-07-30T12:51:12Z","git_url":"git://github.com/bbguimaraes/release.git","ssh_url":"git@github.com:bbguimaraes/release.git","clone_url":"https://github.com/bbguimaraes/release.git","svn_url":"https://github.com/bbguimaraes/release","homepage":null,"size":24012,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"dffe14ff7cda8fbe6332a31d865c96332b2fd3df","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":75224144,"node_id":"MDEwOlJlcG9zaXRvcnk3NTIyNDE0NA==","name":"release","full_name":"openshift/release","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/release","description":"Release tooling for OpenShift Origin","fork":false,"url":"https://api.github.com/repos/openshift/release","forks_url":"https://api.github.com/repos/openshift/release/forks","keys_url":"https://api.github.com/repos/openshift/release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/release/teams","hooks_url":"https://api.github.com/repos/openshift/release/hooks","issue_events_url":"https://api.github.com/repos/openshift/release/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/release/events","assignees_url":"https://api.github.com/repos/openshift/release/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/release/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/release/tags","blobs_url":"https://api.github.com/repos/openshift/release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/release/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/release/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/release/languages","stargazers_url":"https://api.github.com/repos/openshift/release/stargazers","contributors_url":"https://api.github.com/repos/openshift/release/contributors","subscribers_url":"https://api.github.com/repos/openshift/release/subscribers","subscription_url":"https://api.github.com/repos/openshift/release/subscription","commits_url":"https://api.github.com/repos/openshift/release/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/release/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/release/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/release/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/release/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/release/merges","archive_url":"https://api.github.com/repos/openshift/release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/release/downloads","issues_url":"https://api.github.com/repos/openshift/release/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/release/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/release/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/release/labels{/name}","releases_url":"https://api.github.com/repos/openshift/release/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/release/deployments","created_at":"2016-11-30T20:25:21Z","updated_at":"2018-07-27T21:24:35Z","pushed_at":"2018-07-30T12:51:13Z","git_url":"git://github.com/openshift/release.git","ssh_url":"git@github.com:openshift/release.git","clone_url":"https://github.com/openshift/release.git","svn_url":"https://github.com/openshift/release","homepage":null,"size":24006,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":81,"open_issues":37,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/release/pulls/1113"},"html":{"href":"https://github.com/openshift/release/pull/1113"},"issue":{"href":"https://api.github.com/repos/openshift/release/issues/1113"},"comments":{"href":"https://api.github.com/repos/openshift/release/issues/1113/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/release/pulls/1113/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/release/pulls/1113/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/release/statuses/081843b3ee9308651d3dc96b99f5a61c2f26b141"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bbguimaraes"}}