{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/242711099","pull_request_review_id":186289148,"id":242711099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjcxMTA5OQ==","diff_hunk":"@@ -0,0 +1,18 @@\n+<?php","path":"src/StudyEntities/Candidate/ValidatableIdentifier.php","position":1,"original_position":1,"commit_id":"641c5a8c333f89dc5562ffe8ba7896bbb17348bc","original_commit_id":"0186776549116a41ede04e324308610cd7a22dad","user":{"login":"driusan","id":498329,"node_id":"MDQ6VXNlcjQ5ODMyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n<?php declare(strict_types=1);\r\n```","created_at":"2018-12-18T21:25:13Z","updated_at":"2018-12-18T21:33:34Z","html_url":"https://github.com/aces/Loris/pull/4055#discussion_r242711099","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/4055","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/242711099"},"html":{"href":"https://github.com/aces/Loris/pull/4055#discussion_r242711099"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/4055"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/4055","id":227963910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTYzOTEw","html_url":"https://github.com/aces/Loris/pull/4055","diff_url":"https://github.com/aces/Loris/pull/4055.diff","patch_url":"https://github.com/aces/Loris/pull/4055.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/4055","number":4055,"state":"open","locked":false,"title":"[Core] Adding CandID Value Object","user":{"login":"xlecours","id":12155214,"node_id":"MDQ6VXNlcjEyMTU1MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/12155214?v=4","gravatar_id":"","url":"https://api.github.com/users/xlecours","html_url":"https://github.com/xlecours","followers_url":"https://api.github.com/users/xlecours/followers","following_url":"https://api.github.com/users/xlecours/following{/other_user}","gists_url":"https://api.github.com/users/xlecours/gists{/gist_id}","starred_url":"https://api.github.com/users/xlecours/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlecours/subscriptions","organizations_url":"https://api.github.com/users/xlecours/orgs","repos_url":"https://api.github.com/users/xlecours/repos","events_url":"https://api.github.com/users/xlecours/events{/privacy}","received_events_url":"https://api.github.com/users/xlecours/received_events","type":"User","site_admin":false},"body":"This adds a CandID value object with unit test and a simple usage in the RestAPI.\r\n\r\nThe goal is to start using objects instead of array or scalar values to migrate toward a dependencies injection pattern. This will facilitate unit tests and further developments.\r\n\r\nTo test this change send a http request to the /api/v0.0.3-dev/candidates/<your-favorite-candid>\r\n\r\n- [ ] This still needs doc and function comments","created_at":"2018-11-02T14:59:03Z","updated_at":"2018-12-18T21:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18dc5be42cfdbcaa0a3b417aa3b74a649df5ba8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":263780092,"node_id":"MDU6TGFiZWwyNjM3ODAwOTI=","url":"https://api.github.com/repos/aces/Loris/labels/Needs%20Rebase","name":"Needs Rebase","color":"ff5050","default":false},{"id":345188265,"node_id":"MDU6TGFiZWwzNDUxODgyNjU=","url":"https://api.github.com/repos/aces/Loris/labels/Needs%20Work","name":"Needs Work","color":"eb6420","default":false},{"id":708896092,"node_id":"MDU6TGFiZWw3MDg4OTYwOTI=","url":"https://api.github.com/repos/aces/Loris/labels/[branch]%20major","name":"[branch] major","color":"4d3319","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aces/Loris/pulls/4055/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/4055/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/4055/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/641c5a8c333f89dc5562ffe8ba7896bbb17348bc","head":{"label":"xlecours:identifiers","ref":"identifiers","sha":"641c5a8c333f89dc5562ffe8ba7896bbb17348bc","user":{"login":"xlecours","id":12155214,"node_id":"MDQ6VXNlcjEyMTU1MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/12155214?v=4","gravatar_id":"","url":"https://api.github.com/users/xlecours","html_url":"https://github.com/xlecours","followers_url":"https://api.github.com/users/xlecours/followers","following_url":"https://api.github.com/users/xlecours/following{/other_user}","gists_url":"https://api.github.com/users/xlecours/gists{/gist_id}","starred_url":"https://api.github.com/users/xlecours/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlecours/subscriptions","organizations_url":"https://api.github.com/users/xlecours/orgs","repos_url":"https://api.github.com/users/xlecours/repos","events_url":"https://api.github.com/users/xlecours/events{/privacy}","received_events_url":"https://api.github.com/users/xlecours/received_events","type":"User","site_admin":false},"repo":{"id":34744886,"node_id":"MDEwOlJlcG9zaXRvcnkzNDc0NDg4Ng==","name":"Loris","full_name":"xlecours/Loris","private":false,"owner":{"login":"xlecours","id":12155214,"node_id":"MDQ6VXNlcjEyMTU1MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/12155214?v=4","gravatar_id":"","url":"https://api.github.com/users/xlecours","html_url":"https://github.com/xlecours","followers_url":"https://api.github.com/users/xlecours/followers","following_url":"https://api.github.com/users/xlecours/following{/other_user}","gists_url":"https://api.github.com/users/xlecours/gists{/gist_id}","starred_url":"https://api.github.com/users/xlecours/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlecours/subscriptions","organizations_url":"https://api.github.com/users/xlecours/orgs","repos_url":"https://api.github.com/users/xlecours/repos","events_url":"https://api.github.com/users/xlecours/events{/privacy}","received_events_url":"https://api.github.com/users/xlecours/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xlecours/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/xlecours/Loris","forks_url":"https://api.github.com/repos/xlecours/Loris/forks","keys_url":"https://api.github.com/repos/xlecours/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xlecours/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xlecours/Loris/teams","hooks_url":"https://api.github.com/repos/xlecours/Loris/hooks","issue_events_url":"https://api.github.com/repos/xlecours/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/xlecours/Loris/events","assignees_url":"https://api.github.com/repos/xlecours/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/xlecours/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/xlecours/Loris/tags","blobs_url":"https://api.github.com/repos/xlecours/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xlecours/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xlecours/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/xlecours/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xlecours/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/xlecours/Loris/languages","stargazers_url":"https://api.github.com/repos/xlecours/Loris/stargazers","contributors_url":"https://api.github.com/repos/xlecours/Loris/contributors","subscribers_url":"https://api.github.com/repos/xlecours/Loris/subscribers","subscription_url":"https://api.github.com/repos/xlecours/Loris/subscription","commits_url":"https://api.github.com/repos/xlecours/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/xlecours/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/xlecours/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/xlecours/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/xlecours/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/xlecours/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xlecours/Loris/merges","archive_url":"https://api.github.com/repos/xlecours/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xlecours/Loris/downloads","issues_url":"https://api.github.com/repos/xlecours/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/xlecours/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/xlecours/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/xlecours/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xlecours/Loris/labels{/name}","releases_url":"https://api.github.com/repos/xlecours/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/xlecours/Loris/deployments","created_at":"2015-04-28T17:18:07Z","updated_at":"2016-07-21T13:30:23Z","pushed_at":"2018-12-18T21:29:20Z","git_url":"git://github.com/xlecours/Loris.git","ssh_url":"git@github.com:xlecours/Loris.git","clone_url":"https://github.com/xlecours/Loris.git","svn_url":"https://github.com/xlecours/Loris","homepage":"","size":82503,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aces:major","ref":"major","sha":"2521378d7809ec45df6edc5eff2a6a584d4b2b4e","user":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1NjMw","name":"Loris","full_name":"aces/Loris","private":false,"owner":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2018-12-17T14:53:43Z","pushed_at":"2018-12-18T21:30:18Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":79340,"stargazers_count":68,"watchers_count":68,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":100,"open_issues":128,"watchers":68,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/4055"},"html":{"href":"https://github.com/aces/Loris/pull/4055"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/4055"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/4055/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/4055/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/4055/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/641c5a8c333f89dc5562ffe8ba7896bbb17348bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"driusan"}}