{"action":"created","issue":{"url":"https://api.github.com/repos/servo/euclid/issues/297","repository_url":"https://api.github.com/repos/servo/euclid","labels_url":"https://api.github.com/repos/servo/euclid/issues/297/labels{/name}","comments_url":"https://api.github.com/repos/servo/euclid/issues/297/comments","events_url":"https://api.github.com/repos/servo/euclid/issues/297/events","html_url":"https://github.com/servo/euclid/pull/297","id":339175871,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTE0MTM1","number":297,"title":"Handle infinite length during normalizing a vector.","user":{"login":"BorisChiou","id":1914903,"node_id":"MDQ6VXNlcjE5MTQ5MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1914903?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisChiou","html_url":"https://github.com/BorisChiou","followers_url":"https://api.github.com/users/BorisChiou/followers","following_url":"https://api.github.com/users/BorisChiou/following{/other_user}","gists_url":"https://api.github.com/users/BorisChiou/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisChiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisChiou/subscriptions","organizations_url":"https://api.github.com/users/BorisChiou/orgs","repos_url":"https://api.github.com/users/BorisChiou/repos","events_url":"https://api.github.com/users/BorisChiou/events{/privacy}","received_events_url":"https://api.github.com/users/BorisChiou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-07T21:23:45Z","updated_at":"2018-07-09T08:05:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/servo/euclid/pulls/297","html_url":"https://github.com/servo/euclid/pull/297","diff_url":"https://github.com/servo/euclid/pull/297.diff","patch_url":"https://github.com/servo/euclid/pull/297.patch"},"body":"Rotate3d may use some extremely large value in the rotate axis vector, and\r\nthis may cause infinite length, so the normalized vector becomes a zero vector.\r\nHere, we scale the vector first if its length is infinite, and then do the normalization.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/euclid/297)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/euclid/issues/comments/403395060","html_url":"https://github.com/servo/euclid/pull/297#issuecomment-403395060","issue_url":"https://api.github.com/repos/servo/euclid/issues/297","id":403395060,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzM5NTA2MA==","user":{"login":"BorisChiou","id":1914903,"node_id":"MDQ6VXNlcjE5MTQ5MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1914903?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisChiou","html_url":"https://github.com/BorisChiou","followers_url":"https://api.github.com/users/BorisChiou/followers","following_url":"https://api.github.com/users/BorisChiou/following{/other_user}","gists_url":"https://api.github.com/users/BorisChiou/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisChiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisChiou/subscriptions","organizations_url":"https://api.github.com/users/BorisChiou/orgs","repos_url":"https://api.github.com/users/BorisChiou/repos","events_url":"https://api.github.com/users/BorisChiou/events{/privacy}","received_events_url":"https://api.github.com/users/BorisChiou/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T08:05:43Z","updated_at":"2018-07-09T08:05:43Z","author_association":"NONE","body":"Cool! OK, let's add another method, `robust_normalize(self) -> T`. Thanks for the instructions."}}
{"actor":{"display_login":"BorisChiou"}}