{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/174","repository_url":"https://api.github.com/repos/guardian/zuora-auto-cancel","labels_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/174/comments","events_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/174/events","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/174","id":348281976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjY3NTU3","number":174,"title":"have a shared operation to set sf identity id","user":{"login":"johnduffell","id":7304387,"node_id":"MDQ6VXNlcjczMDQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/7304387?v=4","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-07T11:34:23Z","updated_at":"2018-08-07T11:47:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/pulls/174","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/174","diff_url":"https://github.com/guardian/zuora-auto-cancel/pull/174.diff","patch_url":"https://github.com/guardian/zuora-auto-cancel/pull/174.patch"},"body":"so after messing up being able to set the identity id in salesforce several times in the sf contact merge endpoint, I was about to write an effects test when I realised we already have the same operation together with tests in identity-backfill.\r\n\r\nSo rather than trying to copy it I decided to make a lib just for that operation, so we can pull it in exactly where it's needed.\r\n\r\n@pvighi @jacobwinch @twrichards "},"comment":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/comments/411028863","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/174#issuecomment-411028863","issue_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/174","id":411028863,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTAyODg2Mw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T11:47:07Z","updated_at":"2018-08-07T11:47:07Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 136](https://coveralls.io/builds/18361831)\n\n* **5** of **6**   **(83.33%)**  changed or added relevant lines in **2** files are covered.\n* **6** unchanged lines in **3** files lost coverage.\n* Overall coverage decreased (**-0.2%**) to **69.114%**\n\n---\n\n|  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |\n| :-----|--------------|--------|---: |\n| [lib/sf/updatesfidentity/src/main/scala/com/gu/identityBackfill/salesforce/UpdateSalesforceIdentityId.scala](https://coveralls.io/builds/18361831/source?filename=lib%2Fsf%2Fupdatesfidentity%2Fsrc%2Fmain%2Fscala%2Fcom%2Fgu%2FidentityBackfill%2Fsalesforce%2FUpdateSalesforceIdentityId.scala#L16) | 4 | 5 | 80.0%\n<!-- | **Total:** | **5** | **6** | **83.33%** | -->\n\n|  Files with Coverage Reduction | New Missed Lines | % |\n| :-----|--------------|--: |\n| [handlers/sf-contact-merge/src/main/scala/com/gu/sf_contact_merge/update/UpdateAccountSFLinks.scala](https://coveralls.io/builds/18361831/source?filename=handlers%2Fsf-contact-merge%2Fsrc%2Fmain%2Fscala%2Fcom%2Fgu%2Fsf_contact_merge%2Fupdate%2FUpdateAccountSFLinks.scala#L16) | 1 | 80.0% |\n| [handlers/sf-contact-merge/src/main/scala/com/gu/sf_contact_merge/getaccounts/GetContacts.scala](https://coveralls.io/builds/18361831/source?filename=handlers%2Fsf-contact-merge%2Fsrc%2Fmain%2Fscala%2Fcom%2Fgu%2Fsf_contact_merge%2Fgetaccounts%2FGetContacts.scala#L30) | 1 | 91.67% |\n| [lib/restHttp/src/main/scala/com/gu/util/resthttp/RestRequestMaker.scala](https://coveralls.io/builds/18361831/source?filename=lib%2FrestHttp%2Fsrc%2Fmain%2Fscala%2Fcom%2Fgu%2Futil%2Fresthttp%2FRestRequestMaker.scala#L19) | 4 | 74.07% |\n<!-- | **Total:** | **6** |  | -->\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/18361831/badge)](https://coveralls.io/builds/18361831) |\n| :-- | --: |\n| Change from base [Build 130](https://coveralls.io/builds/18341487): |  -0.2% |\n| Covered Lines: | 1271 |\n| Relevant Lines: | 1839 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}