{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/165934543","pull_request_review_id":93945199,"id":165934543,"diff_hunk":"@@ -0,0 +1,118 @@\n+//\n+// Wire\n+// Copyright (C) 2017 Wire Swiss GmbH\n+//\n+// This program is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+//\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU General Public License for more details.\n+//\n+// You should have received a copy of the GNU General Public License\n+// along with this program. If not, see http://www.gnu.org/licenses/.\n+//\n+\n+import XCTest\n+import Classy\n+import Cartography\n+import WireLinkPreview\n+@testable import Wire\n+\n+class ShareViewControllerTests: CoreDataSnapshotTestCase {\n+    \n+    var groupConversation: ZMConversation!\n+    \n+    override func setUp() {\n+        super.setUp()\n+        self.groupConversation = self.createGroupConversation()\n+        uiMOC.zm_imageAssetCache = ImageAssetCache(MBLimit: 50)\n+        uiMOC.saveOrRollback()\n+    }\n+    \n+    override func tearDown() {\n+        uiMOC.zm_imageAssetCache.wipeCache()\n+        super.tearDown()\n+    }\n+    \n+    func testThatItRendersCorrectlyShareViewController_OneLineTextMessage() {\n+        groupConversation.appendMessage(withText: \"This is a text message.\")\n+        makeTestForShareViewController()\n+    }\n+    \n+    func testThatItRendersCorrectlyShareViewController_MultiLineTextMessage() {\n+        groupConversation.appendMessage(withText: \"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempor nulla nec justo tincidunt iaculis. Suspendisse et viverra lacus. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Aliquam pretium suscipit purus, sed eleifend erat ullamcorper non. Sed non enim diam. Fusce pulvinar turpis sit amet pretium finibus. Donec ipsum massa, aliquam eget sollicitudin vel, fringilla eget arcu. Donec faucibus porttitor nisi ut fermentum. Donec sit amet massa sodales, facilisis neque et, condimentum leo. Maecenas quis vulputate libero, id suscipit magna.\")\n+        makeTestForShareViewController()\n+    }\n+    \n+    func testThatItRendersCorrectlyShareViewController_LocationMessage() {\n+        let location = LocationData.locationData(withLatitude: 43.94, longitude: 12.46, name: \"Stranger Place\", zoomLevel: 5)\n+        groupConversation.appendMessage(with: location)\n+        makeTestForShareViewController()\n+    }\n+    \n+    func testThatItRendersCorrectlyShareViewController_Photos() {\n+        /// TODO fix image loading","path":"Wire-iOS Tests/ShareViewControllerTests.swift","position":58,"original_position":58,"commit_id":"010c8cbe58175d8a2b613ef2424d465b9c2a9cf6","original_commit_id":"010c8cbe58175d8a2b613ef2424d465b9c2a9cf6","user":{"login":"vytis","id":33914,"avatar_url":"https://avatars2.githubusercontent.com/u/33914?v=4","gravatar_id":"","url":"https://api.github.com/users/vytis","html_url":"https://github.com/vytis","followers_url":"https://api.github.com/users/vytis/followers","following_url":"https://api.github.com/users/vytis/following{/other_user}","gists_url":"https://api.github.com/users/vytis/gists{/gist_id}","starred_url":"https://api.github.com/users/vytis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytis/subscriptions","organizations_url":"https://api.github.com/users/vytis/orgs","repos_url":"https://api.github.com/users/vytis/repos","events_url":"https://api.github.com/users/vytis/events{/privacy}","received_events_url":"https://api.github.com/users/vytis/received_events","type":"User","site_admin":false},"body":"Maybe it would be possible to introduce a similar approach as we do in sync engine - have a dispatch group everywhere so we could actually wait for these things to finish?","created_at":"2018-02-05T10:37:59Z","updated_at":"2018-02-05T10:38:00Z","html_url":"https://github.com/wireapp/wire-ios/pull/1678#discussion_r165934543","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/165934543"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/1678#discussion_r165934543"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678"}},"in_reply_to_id":165913896},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678","id":166836005,"html_url":"https://github.com/wireapp/wire-ios/pull/1678","diff_url":"https://github.com/wireapp/wire-ios/pull/1678.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/1678.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/1678","number":1678,"state":"open","locked":false,"title":"[WIP] Added tests for Share View Controller","user":{"login":"nicorsm","id":2906234,"avatar_url":"https://avatars0.githubusercontent.com/u/2906234?v=4","gravatar_id":"","url":"https://api.github.com/users/nicorsm","html_url":"https://github.com/nicorsm","followers_url":"https://api.github.com/users/nicorsm/followers","following_url":"https://api.github.com/users/nicorsm/following{/other_user}","gists_url":"https://api.github.com/users/nicorsm/gists{/gist_id}","starred_url":"https://api.github.com/users/nicorsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicorsm/subscriptions","organizations_url":"https://api.github.com/users/nicorsm/orgs","repos_url":"https://api.github.com/users/nicorsm/repos","events_url":"https://api.github.com/users/nicorsm/events{/privacy}","received_events_url":"https://api.github.com/users/nicorsm/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\nAdded some tests for Share View Controller. Work in progress.","created_at":"2018-02-02T15:51:39Z","updated_at":"2018-02-05T10:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09368237a6b186d2d613cc16ead4b61e727b571f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/1678/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/010c8cbe58175d8a2b613ef2424d465b9c2a9cf6","head":{"label":"wireapp:fix/share-view-controller-tests","ref":"fix/share-view-controller-tests","sha":"010c8cbe58175d8a2b613ef2424d465b9c2a9cf6","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2018-02-05T04:55:30Z","pushed_at":"2018-02-05T10:36:22Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":167038,"stargazers_count":2293,"watchers_count":2293,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":364,"open_issues":113,"watchers":2293,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"58b207ea8c8361c78d9deb3a8215909d9e9d6c90","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"name":"wire-ios","full_name":"wireapp/wire-ios","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2018-02-05T04:55:30Z","pushed_at":"2018-02-05T10:36:22Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":167038,"stargazers_count":2293,"watchers_count":2293,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":364,"open_issues":113,"watchers":2293,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/1678"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/1678"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios/statuses/010c8cbe58175d8a2b613ef2424d465b9c2a9cf6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vytis"}}