{"action":"created","issue":{"url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/72","repository_url":"https://api.github.com/repos/HBClab/NiBetaSeries","labels_url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/72/comments","events_url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/72/events","html_url":"https://github.com/HBClab/NiBetaSeries/pull/72","id":368771585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODcxODg3","number":72,"title":"[FIX] confound removal","user":{"login":"jdkent","id":12564882,"node_id":"MDQ6VXNlcjEyNTY0ODgy","avatar_url":"https://avatars0.githubusercontent.com/u/12564882?v=4","gravatar_id":"","url":"https://api.github.com/users/jdkent","html_url":"https://github.com/jdkent","followers_url":"https://api.github.com/users/jdkent/followers","following_url":"https://api.github.com/users/jdkent/following{/other_user}","gists_url":"https://api.github.com/users/jdkent/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkent/subscriptions","organizations_url":"https://api.github.com/users/jdkent/orgs","repos_url":"https://api.github.com/users/jdkent/repos","events_url":"https://api.github.com/users/jdkent/events{/privacy}","received_events_url":"https://api.github.com/users/jdkent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-10T17:28:06Z","updated_at":"2018-10-10T17:31:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/HBClab/NiBetaSeries/pulls/72","html_url":"https://github.com/HBClab/NiBetaSeries/pull/72","diff_url":"https://github.com/HBClab/NiBetaSeries/pull/72.diff","patch_url":"https://github.com/HBClab/NiBetaSeries/pull/72.patch"},"body":"<!--\r\n\r\nPull-request guidelines\r\n-----------------------\r\n\r\n1. If you would like to list yourself as a NiBetaSeries contributor and your name is not mentioned please modify .zenodo.json file.\r\n2. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)\r\n3. Run `tox` before submitting the PR.\r\n\r\n-->\r\n## Summary\r\n<!-- Please reference any related issue and use fixes/close to automatically\r\nclose them, if pertinent -->\r\nFixes #15. <!-- (e.g. Fixes #58.) -->\r\nThis pull request will combine the temporal filtering step and beta series estimation step into one, so that all the relevant confounds will be accounted for simultaneously, instead of sequentially (which is bad)\r\n## List of changes proposed in this PR (pull-request)\r\n- remove the possibility of a high pass filter\r\n    - this option isn't available in nistats, but the drift model should be able to care of low frequency noise\r\n- embed `low_pass` filter option into the `nistats` interface\r\n\r\n<!-- We suggest using bullets (indicated by * or -) and filled checkboxes [x] here -->\r\n"},"comment":{"url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/comments/428660894","html_url":"https://github.com/HBClab/NiBetaSeries/pull/72#issuecomment-428660894","issue_url":"https://api.github.com/repos/HBClab/NiBetaSeries/issues/72","id":428660894,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODY2MDg5NA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T17:31:20Z","updated_at":"2018-10-10T17:31:20Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=h1) Report\n> Merging [#72](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=desc) into [master](https://codecov.io/gh/HBClab/NiBetaSeries/commit/dbae69b1eb481c327f3b345da1d77b165b1b1511?src=pr&el=desc) will **decrease** coverage by `0.05%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72/graphs/tree.svg?width=650&token=zGZJ1u9HmJ&height=150&src=pr)](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master     #72      +/-   ##\n=========================================\n- Coverage    7.49%   7.44%   -0.06%     \n=========================================\n  Files          13      13              \n  Lines         627     618       -9     \n  Branches      110     111       +1     \n=========================================\n- Hits           47      46       -1     \n+ Misses        580     572       -8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/nibetaseries/workflows/model.py](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72/diff?src=pr&el=tree#diff-c3JjL25pYmV0YXNlcmllcy93b3JrZmxvd3MvbW9kZWwucHk=) | `0% <ø> (ø)` | :arrow_up: |\n| [src/nibetaseries/cli/run.py](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72/diff?src=pr&el=tree#diff-c3JjL25pYmV0YXNlcmllcy9jbGkvcnVuLnB5) | `53.12% <ø> (-0.73%)` | :arrow_down: |\n| [src/nibetaseries/workflows/base.py](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72/diff?src=pr&el=tree#diff-c3JjL25pYmV0YXNlcmllcy93b3JrZmxvd3MvYmFzZS5weQ==) | `0% <0%> (ø)` | :arrow_up: |\n| [src/nibetaseries/interfaces/nistats.py](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72/diff?src=pr&el=tree#diff-c3JjL25pYmV0YXNlcmllcy9pbnRlcmZhY2VzL25pc3RhdHMucHk=) | `0% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=footer). Last update [dbae69b...2b020a3](https://codecov.io/gh/HBClab/NiBetaSeries/pull/72?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}