{"action":"created","comment":{"url":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments/220412735","pull_request_review_id":158814574,"id":220412735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQxMjczNQ==","diff_hunk":"@@ -101,6 +101,11 @@ def variable_type(self):\n             feature = feature.base_features[0]\n             return_type = feature.return_type\n \n+            # only the original time index should exist\n+            # so make this feature's return type just a Datetime\n+            if return_type == DatetimeTimeIndex:","path":"featuretools/primitives/primitive_base.py","position":21,"original_position":15,"commit_id":"837f2682b456b24a1ec3532c625e95aa942e5353","original_commit_id":"429c7d887b812feeabcefa0b0f29317e8a7bc00d","user":{"login":"kmax12","id":371792,"node_id":"MDQ6VXNlcjM3MTc5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/371792?v=4","gravatar_id":"","url":"https://api.github.com/users/kmax12","html_url":"https://github.com/kmax12","followers_url":"https://api.github.com/users/kmax12/followers","following_url":"https://api.github.com/users/kmax12/following{/other_user}","gists_url":"https://api.github.com/users/kmax12/gists{/gist_id}","starred_url":"https://api.github.com/users/kmax12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmax12/subscriptions","organizations_url":"https://api.github.com/users/kmax12/orgs","repos_url":"https://api.github.com/users/kmax12/repos","events_url":"https://api.github.com/users/kmax12/events{/privacy}","received_events_url":"https://api.github.com/users/kmax12/received_events","type":"User","site_admin":false},"body":"you're right. added","created_at":"2018-09-26T02:46:32Z","updated_at":"2018-09-26T02:46:33Z","html_url":"https://github.com/Featuretools/featuretools/pull/266#discussion_r220412735","pull_request_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments/220412735"},"html":{"href":"https://github.com/Featuretools/featuretools/pull/266#discussion_r220412735"},"pull_request":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/266"}},"in_reply_to_id":220325266},"pull_request":{"url":"https://api.github.com/repos/Featuretools/featuretools/pulls/266","id":217700922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzAwOTIy","html_url":"https://github.com/Featuretools/featuretools/pull/266","diff_url":"https://github.com/Featuretools/featuretools/pull/266.diff","patch_url":"https://github.com/Featuretools/featuretools/pull/266.patch","issue_url":"https://api.github.com/repos/Featuretools/featuretools/issues/266","number":266,"state":"open","locked":false,"title":"Handling return type when creating features from DatetimeTimeIndex","user":{"login":"kmax12","id":371792,"node_id":"MDQ6VXNlcjM3MTc5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/371792?v=4","gravatar_id":"","url":"https://api.github.com/users/kmax12","html_url":"https://github.com/kmax12","followers_url":"https://api.github.com/users/kmax12/followers","following_url":"https://api.github.com/users/kmax12/following{/other_user}","gists_url":"https://api.github.com/users/kmax12/gists{/gist_id}","starred_url":"https://api.github.com/users/kmax12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmax12/subscriptions","organizations_url":"https://api.github.com/users/kmax12/orgs","repos_url":"https://api.github.com/users/kmax12/repos","events_url":"https://api.github.com/users/kmax12/events{/privacy}","received_events_url":"https://api.github.com/users/kmax12/received_events","type":"User","site_admin":false},"body":"This PR fixes the issue reported in #265. \n\nThat issue surfaced as a calculation error, but the the underlying problem was incorrectly stacking features that shouldn’t exist. This PR updates the return type so the invalid feature doesn’t get created. ","created_at":"2018-09-24T15:41:40Z","updated_at":"2018-09-26T02:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8439bdc63defe220dfc16f3a43c96233c7cbf019","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/266/commits","review_comments_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/266/comments","review_comment_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/issues/266/comments","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/837f2682b456b24a1ec3532c625e95aa942e5353","head":{"label":"Featuretools:return-type","ref":"return-type","sha":"837f2682b456b24a1ec3532c625e95aa942e5353","user":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"repo":{"id":102908804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDg4MDQ=","name":"featuretools","full_name":"Featuretools/featuretools","private":false,"owner":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Featuretools/featuretools","description":"automated feature engineering","fork":false,"url":"https://api.github.com/repos/Featuretools/featuretools","forks_url":"https://api.github.com/repos/Featuretools/featuretools/forks","keys_url":"https://api.github.com/repos/Featuretools/featuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Featuretools/featuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Featuretools/featuretools/teams","hooks_url":"https://api.github.com/repos/Featuretools/featuretools/hooks","issue_events_url":"https://api.github.com/repos/Featuretools/featuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Featuretools/featuretools/events","assignees_url":"https://api.github.com/repos/Featuretools/featuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Featuretools/featuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Featuretools/featuretools/tags","blobs_url":"https://api.github.com/repos/Featuretools/featuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Featuretools/featuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Featuretools/featuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Featuretools/featuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Featuretools/featuretools/languages","stargazers_url":"https://api.github.com/repos/Featuretools/featuretools/stargazers","contributors_url":"https://api.github.com/repos/Featuretools/featuretools/contributors","subscribers_url":"https://api.github.com/repos/Featuretools/featuretools/subscribers","subscription_url":"https://api.github.com/repos/Featuretools/featuretools/subscription","commits_url":"https://api.github.com/repos/Featuretools/featuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Featuretools/featuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Featuretools/featuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Featuretools/featuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Featuretools/featuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Featuretools/featuretools/merges","archive_url":"https://api.github.com/repos/Featuretools/featuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Featuretools/featuretools/downloads","issues_url":"https://api.github.com/repos/Featuretools/featuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Featuretools/featuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Featuretools/featuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Featuretools/featuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Featuretools/featuretools/labels{/name}","releases_url":"https://api.github.com/repos/Featuretools/featuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Featuretools/featuretools/deployments","created_at":"2017-09-08T22:15:17Z","updated_at":"2018-09-25T20:48:46Z","pushed_at":"2018-09-26T02:46:26Z","git_url":"git://github.com/Featuretools/featuretools.git","ssh_url":"git@github.com:Featuretools/featuretools.git","clone_url":"https://github.com/Featuretools/featuretools.git","svn_url":"https://github.com/Featuretools/featuretools","homepage":"https://www.featuretools.com","size":1815,"stargazers_count":2143,"watchers_count":2143,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":244,"open_issues":31,"watchers":2143,"default_branch":"master"}},"base":{"label":"Featuretools:master","ref":"master","sha":"d3db946ba475090c3476459f596bb96958835a8f","user":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"repo":{"id":102908804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDg4MDQ=","name":"featuretools","full_name":"Featuretools/featuretools","private":false,"owner":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Featuretools/featuretools","description":"automated feature engineering","fork":false,"url":"https://api.github.com/repos/Featuretools/featuretools","forks_url":"https://api.github.com/repos/Featuretools/featuretools/forks","keys_url":"https://api.github.com/repos/Featuretools/featuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Featuretools/featuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Featuretools/featuretools/teams","hooks_url":"https://api.github.com/repos/Featuretools/featuretools/hooks","issue_events_url":"https://api.github.com/repos/Featuretools/featuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Featuretools/featuretools/events","assignees_url":"https://api.github.com/repos/Featuretools/featuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Featuretools/featuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Featuretools/featuretools/tags","blobs_url":"https://api.github.com/repos/Featuretools/featuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Featuretools/featuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Featuretools/featuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Featuretools/featuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Featuretools/featuretools/languages","stargazers_url":"https://api.github.com/repos/Featuretools/featuretools/stargazers","contributors_url":"https://api.github.com/repos/Featuretools/featuretools/contributors","subscribers_url":"https://api.github.com/repos/Featuretools/featuretools/subscribers","subscription_url":"https://api.github.com/repos/Featuretools/featuretools/subscription","commits_url":"https://api.github.com/repos/Featuretools/featuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Featuretools/featuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Featuretools/featuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Featuretools/featuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Featuretools/featuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Featuretools/featuretools/merges","archive_url":"https://api.github.com/repos/Featuretools/featuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Featuretools/featuretools/downloads","issues_url":"https://api.github.com/repos/Featuretools/featuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Featuretools/featuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Featuretools/featuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Featuretools/featuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Featuretools/featuretools/labels{/name}","releases_url":"https://api.github.com/repos/Featuretools/featuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Featuretools/featuretools/deployments","created_at":"2017-09-08T22:15:17Z","updated_at":"2018-09-25T20:48:46Z","pushed_at":"2018-09-26T02:46:26Z","git_url":"git://github.com/Featuretools/featuretools.git","ssh_url":"git@github.com:Featuretools/featuretools.git","clone_url":"https://github.com/Featuretools/featuretools.git","svn_url":"https://github.com/Featuretools/featuretools","homepage":"https://www.featuretools.com","size":1815,"stargazers_count":2143,"watchers_count":2143,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":244,"open_issues":31,"watchers":2143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/266"},"html":{"href":"https://github.com/Featuretools/featuretools/pull/266"},"issue":{"href":"https://api.github.com/repos/Featuretools/featuretools/issues/266"},"comments":{"href":"https://api.github.com/repos/Featuretools/featuretools/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/Featuretools/featuretools/statuses/837f2682b456b24a1ec3532c625e95aa942e5353"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kmax12"}}