{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585","repository_url":"https://api.github.com/repos/jenkinsci/git-plugin","labels_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585/comments","events_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585/events","html_url":"https://github.com/jenkinsci/git-plugin/pull/585","id":317942252,"number":585,"title":"[WIP] [JENKINS-50621] Essentials Flow - Part 1","user":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-26T09:14:01Z","updated_at":"2018-04-28T20:01:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585","html_url":"https://github.com/jenkinsci/git-plugin/pull/585","diff_url":"https://github.com/jenkinsci/git-plugin/pull/585.diff","patch_url":"https://github.com/jenkinsci/git-plugin/pull/585.patch"},"body":"## JENKINS-50621 - Add ATH and PCT to the development flow\r\n\r\nSee the comments on JENKINS-50540,  this is going to be augmented via the Custom War Packager and JEP-305 in follow up PRs\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [X] I have read the [CONTRIBUTING](https://github.com/jenkinsci/git-plugin/blob/master/CONTRIBUTING.md) doc\r\n- [X] I have referenced the Jira issue related to my changes in one or more commit messages\r\n- [ ] I have added tests that verify my changes\r\n- [X] Unit tests pass locally with my changes\r\n- [ ] I have added documentation as necessary\r\n- [ ] No Javadoc warnings were introduced with my changes\r\n- [ ] No findbugs warnings were introduced with my changes\r\n- [X] I have interactively tested my changes\r\n- [ ] Any dependent changes have been merged and published in upstream modules (like git-client-plugin)\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce? _Put an `x` in the boxes that apply_\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [X] Development flow changes\r\n\r\n## Further comments\r\n\r\nThis PR can not be merged until [pipeline-library#48](https://github.com/jenkins-infra/pipeline-library/pull/48) is merged\r\n\r\n*Note that as I am not a trusted source the PR Builder is not going to use the changes in the Jenkinsfile, I hope for some maintainer to be able to do a Replay to test it, I have tested it successfully on my development environment*"},"comment":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/comments/385201942","html_url":"https://github.com/jenkinsci/git-plugin/pull/585#issuecomment-385201942","issue_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585","id":385201942,"user":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T20:01:12Z","updated_at":"2018-04-28T20:01:12Z","author_association":"NONE","body":"@MarkEWaite but I have just thought, I can duplicate the Jenkinsfile of\nthis PR in my plugin, where I am a trusted source so we can see it running\nin ci.jenkins.io, is not going to be perfect as is not using git sources\nbut should be a good check. Makes sense?\n\nEl sáb., 28 abr. 2018 21:56, Raúl Arabaolaza <raul.arabaolaza@gmail.com>\nescribió:\n\n> @markewaite I do not have rights to manage ci. jenkins. io, but if you are\n> worried about runPCT and runATH failing due to the lack of plugins take a\n> look at:\n>\n>\n> https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fpipeline-githubnotify-step-plugin/detail/INFRA-1489/34/pipeline\n>\n> Also the core is actually using runATH since some time now :)\n>\n> El 28 abr. 2018 9:42 p. m., \"Mark Waite\" <notifications@github.com>\n> escribió:\n>\n> @raul-arabaolaza <https://github.com/raul-arabaolaza> have you confirmed\n> that pipeline-utility-steps plugin is installed on ci.jenkins.io? I\n> didn't have it installed in my local Jenkins server.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jenkinsci/git-plugin/pull/585#issuecomment-385200910>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAnN470UvIKoxSi7BIzXGSq5vrTQGk0zks5ttMYtgaJpZM4TkzeU>\n> .\n>\n>\n>\n"}}
{"actor":{"display_login":"raul-arabaolaza"}}