{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic-product/pulls/comments/192807555","pull_request_review_id":125654560,"id":192807555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjgwNzU1NQ==","diff_hunk":"@@ -86,19 +86,71 @@ function usage {\n     \"\n }\n \n+# A plugin upgrade is a forced plugin install\n+function callPluginUpgradeEndpoint {\n+  local preset=$1\n+  local vc='{\"target\":\"'\"${VCENTER_TARGET}\"'\",\"user\":\"'\"${VCENTER_USERNAME}\"'\",\"password\":\"'\"${VCENTER_PASSWORD}\"'\",\"thumbprint\":\"'\"${VCENTER_FINGERPRINT}\"'\"}'\n+  local plugin='{\"preset\":\"'\"${preset}\"'\",\"force\":true}'\n+  local payload='{\"vc\":'${vc}',\"plugin\":'${plugin}'}'\n+  echo 'register payload - '${payload}'' | sed -e 's/'${VCENTER_PASSWORD}'/***/g' >> $upgrade_log_file 2>&1","path":"installer/build/scripts/upgrade/upgrade.sh","position":10,"original_position":10,"commit_id":"1d8496a26cfa3b07b460bd297591b7f6f5a9aedb","original_commit_id":"1d8496a26cfa3b07b460bd297591b7f6f5a9aedb","user":{"login":"zjs","id":408880,"node_id":"MDQ6VXNlcjQwODg4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/408880?v=4","gravatar_id":"","url":"https://api.github.com/users/zjs","html_url":"https://github.com/zjs","followers_url":"https://api.github.com/users/zjs/followers","following_url":"https://api.github.com/users/zjs/following{/other_user}","gists_url":"https://api.github.com/users/zjs/gists{/gist_id}","starred_url":"https://api.github.com/users/zjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjs/subscriptions","organizations_url":"https://api.github.com/users/zjs/orgs","repos_url":"https://api.github.com/users/zjs/repos","events_url":"https://api.github.com/users/zjs/events{/privacy}","received_events_url":"https://api.github.com/users/zjs/received_events","type":"User","site_admin":false},"body":"> `echo 'register payload - '${payload}''`\r\n\r\nThe way quoting works, I think this is equivalent to `echo \"register payload - ${payload}\"`, which seems slightly clearer.\r\n","created_at":"2018-06-04T16:42:48Z","updated_at":"2018-06-04T16:58:55Z","html_url":"https://github.com/vmware/vic-product/pull/1807#discussion_r192807555","pull_request_url":"https://api.github.com/repos/vmware/vic-product/pulls/1807","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/comments/192807555"},"html":{"href":"https://github.com/vmware/vic-product/pull/1807#discussion_r192807555"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1807"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic-product/pulls/1807","id":191246613,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjQ2NjEz","html_url":"https://github.com/vmware/vic-product/pull/1807","diff_url":"https://github.com/vmware/vic-product/pull/1807.diff","patch_url":"https://github.com/vmware/vic-product/pull/1807.patch","issue_url":"https://api.github.com/repos/vmware/vic-product/issues/1807","number":1807,"state":"open","locked":false,"title":"Preform a plugin install during the appliance upgrade","user":{"login":"morris-jason","id":10388115,"node_id":"MDQ6VXNlcjEwMzg4MTE1","avatar_url":"https://avatars0.githubusercontent.com/u/10388115?v=4","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"body":"Fixes #1702\r\n\r\nFinal change for 1702 to preform a plugin upgrade during the upgrade script.\r\nMerge after 1779.\r\n\r\n<!-- If cherry picking\r\nCherry picks: <commit hash>\r\nFrom PR: #<original PR to master>\r\n-->\r\n","created_at":"2018-05-29T19:27:57Z","updated_at":"2018-06-04T16:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2b86661d9e7fc573802924fd86fd5238febd76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":434930069,"node_id":"MDU6TGFiZWw0MzQ5MzAwNjk=","url":"https://api.github.com/repos/vmware/vic-product/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic-product/pulls/1807/commits","review_comments_url":"https://api.github.com/repos/vmware/vic-product/pulls/1807/comments","review_comment_url":"https://api.github.com/repos/vmware/vic-product/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic-product/issues/1807/comments","statuses_url":"https://api.github.com/repos/vmware/vic-product/statuses/1d8496a26cfa3b07b460bd297591b7f6f5a9aedb","head":{"label":"morris-jason:1702/upgrade-script","ref":"1702/upgrade-script","sha":"1d8496a26cfa3b07b460bd297591b7f6f5a9aedb","user":{"login":"morris-jason","id":10388115,"node_id":"MDQ6VXNlcjEwMzg4MTE1","avatar_url":"https://avatars0.githubusercontent.com/u/10388115?v=4","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"repo":{"id":94344300,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM0NDMwMA==","name":"vic-product","full_name":"morris-jason/vic-product","owner":{"login":"morris-jason","id":10388115,"node_id":"MDQ6VXNlcjEwMzg4MTE1","avatar_url":"https://avatars0.githubusercontent.com/u/10388115?v=4","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morris-jason/vic-product","description":null,"fork":true,"url":"https://api.github.com/repos/morris-jason/vic-product","forks_url":"https://api.github.com/repos/morris-jason/vic-product/forks","keys_url":"https://api.github.com/repos/morris-jason/vic-product/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morris-jason/vic-product/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morris-jason/vic-product/teams","hooks_url":"https://api.github.com/repos/morris-jason/vic-product/hooks","issue_events_url":"https://api.github.com/repos/morris-jason/vic-product/issues/events{/number}","events_url":"https://api.github.com/repos/morris-jason/vic-product/events","assignees_url":"https://api.github.com/repos/morris-jason/vic-product/assignees{/user}","branches_url":"https://api.github.com/repos/morris-jason/vic-product/branches{/branch}","tags_url":"https://api.github.com/repos/morris-jason/vic-product/tags","blobs_url":"https://api.github.com/repos/morris-jason/vic-product/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morris-jason/vic-product/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morris-jason/vic-product/git/refs{/sha}","trees_url":"https://api.github.com/repos/morris-jason/vic-product/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morris-jason/vic-product/statuses/{sha}","languages_url":"https://api.github.com/repos/morris-jason/vic-product/languages","stargazers_url":"https://api.github.com/repos/morris-jason/vic-product/stargazers","contributors_url":"https://api.github.com/repos/morris-jason/vic-product/contributors","subscribers_url":"https://api.github.com/repos/morris-jason/vic-product/subscribers","subscription_url":"https://api.github.com/repos/morris-jason/vic-product/subscription","commits_url":"https://api.github.com/repos/morris-jason/vic-product/commits{/sha}","git_commits_url":"https://api.github.com/repos/morris-jason/vic-product/git/commits{/sha}","comments_url":"https://api.github.com/repos/morris-jason/vic-product/comments{/number}","issue_comment_url":"https://api.github.com/repos/morris-jason/vic-product/issues/comments{/number}","contents_url":"https://api.github.com/repos/morris-jason/vic-product/contents/{+path}","compare_url":"https://api.github.com/repos/morris-jason/vic-product/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morris-jason/vic-product/merges","archive_url":"https://api.github.com/repos/morris-jason/vic-product/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morris-jason/vic-product/downloads","issues_url":"https://api.github.com/repos/morris-jason/vic-product/issues{/number}","pulls_url":"https://api.github.com/repos/morris-jason/vic-product/pulls{/number}","milestones_url":"https://api.github.com/repos/morris-jason/vic-product/milestones{/number}","notifications_url":"https://api.github.com/repos/morris-jason/vic-product/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morris-jason/vic-product/labels{/name}","releases_url":"https://api.github.com/repos/morris-jason/vic-product/releases{/id}","deployments_url":"https://api.github.com/repos/morris-jason/vic-product/deployments","created_at":"2017-06-14T15:11:02Z","updated_at":"2018-05-08T18:51:44Z","pushed_at":"2018-06-01T15:22:03Z","git_url":"git://github.com/morris-jason/vic-product.git","ssh_url":"git@github.com:morris-jason/vic-product.git","clone_url":"https://github.com/morris-jason/vic-product.git","svn_url":"https://github.com/morris-jason/vic-product","homepage":null,"size":56362,"stargazers_count":0,"watchers_count":0,"language":"RobotFramework","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:feature/auto-vic-ui-plugin","ref":"feature/auto-vic-ui-plugin","sha":"6be38653d8d28e9aaf5f54913f2acc016b13eb57","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":66033051,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAzMzA1MQ==","name":"vic-product","full_name":"vmware/vic-product","owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic-product","description":null,"fork":false,"url":"https://api.github.com/repos/vmware/vic-product","forks_url":"https://api.github.com/repos/vmware/vic-product/forks","keys_url":"https://api.github.com/repos/vmware/vic-product/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic-product/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic-product/teams","hooks_url":"https://api.github.com/repos/vmware/vic-product/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic-product/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic-product/events","assignees_url":"https://api.github.com/repos/vmware/vic-product/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic-product/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic-product/tags","blobs_url":"https://api.github.com/repos/vmware/vic-product/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic-product/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic-product/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic-product/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic-product/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic-product/languages","stargazers_url":"https://api.github.com/repos/vmware/vic-product/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic-product/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic-product/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic-product/subscription","commits_url":"https://api.github.com/repos/vmware/vic-product/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic-product/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic-product/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic-product/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic-product/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic-product/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic-product/merges","archive_url":"https://api.github.com/repos/vmware/vic-product/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic-product/downloads","issues_url":"https://api.github.com/repos/vmware/vic-product/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic-product/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic-product/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic-product/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic-product/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic-product/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic-product/deployments","created_at":"2016-08-18T21:52:44Z","updated_at":"2018-06-04T12:59:24Z","pushed_at":"2018-06-04T16:13:36Z","git_url":"git://github.com/vmware/vic-product.git","ssh_url":"git@github.com:vmware/vic-product.git","clone_url":"https://github.com/vmware/vic-product.git","svn_url":"https://github.com/vmware/vic-product","homepage":null,"size":85276,"stargazers_count":75,"watchers_count":75,"language":"RobotFramework","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":223,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":223,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1807"},"html":{"href":"https://github.com/vmware/vic-product/pull/1807"},"issue":{"href":"https://api.github.com/repos/vmware/vic-product/issues/1807"},"comments":{"href":"https://api.github.com/repos/vmware/vic-product/issues/1807/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1807/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1807/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic-product/statuses/1d8496a26cfa3b07b460bd297591b7f6f5a9aedb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zjs"}}