{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/180757649","pull_request_review_id":111176379,"id":180757649,"diff_hunk":"@@ -120,12 +198,22 @@ Bool_t THttpLongPollEngine::PreviewData(THttpCallArg &arg)\n /// Normally requests from client does not replied directly\n /// Therefore one can use it to send data with it\n \n-void THttpLongPollEngine::PostProcess(THttpCallArg &arg)\n+void THttpLongPollEngine::PostProcess(std::shared_ptr<THttpCallArg> &arg)\n {\n-   if ((fQueue.size() > 0) && arg.IsContentType(\"text/plain\") &&\n-       (arg.GetContentLength() == (Long_t)strlen(gLongPollNope)) &&\n-       (strcmp((const char *)arg.GetContent(), gLongPollNope) == 0)) {\n-      arg.SetContent(fQueue.front().c_str());\n-      fQueue.erase(fQueue.begin());\n+   if (arg->IsText() && (arg->GetContentLength() == (Long_t)strlen(gLongPollNope)) &&","path":"net/http/src/THttpLongPollEngine.cxx","position":205,"original_position":205,"commit_id":"8ee23ca08fb4d100608c111a02a1df07ee58b71f","original_commit_id":"8ee23ca08fb4d100608c111a02a1df07ee58b71f","user":{"login":"Axel-Naumann","id":144675,"avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false},"body":"Could you maybe use an early return instead of additional indentation? I.e.\r\n```\r\nif (!arg->IsText() || (arg->GetContentLength() != gLongPollNope.length()) ||\r\ngLongPollNope != (const char*)arg->GetContent())\r\n```","created_at":"2018-04-11T13:41:58Z","updated_at":"2018-04-11T13:49:20Z","html_url":"https://github.com/root-project/root/pull/1785#discussion_r180757649","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/1785","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/180757649"},"html":{"href":"https://github.com/root-project/root/pull/1785#discussion_r180757649"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/1785"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1785","id":177123407,"html_url":"https://github.com/root-project/root/pull/1785","diff_url":"https://github.com/root-project/root/pull/1785.diff","patch_url":"https://github.com/root-project/root/pull/1785.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1785","number":1785,"state":"open","locked":false,"title":"webgui: introduce binary interface for TWebWindow","user":{"login":"linev","id":4936580,"avatar_url":"https://avatars3.githubusercontent.com/u/4936580?v=4","gravatar_id":"","url":"https://api.github.com/users/linev","html_url":"https://github.com/linev","followers_url":"https://api.github.com/users/linev/followers","following_url":"https://api.github.com/users/linev/following{/other_user}","gists_url":"https://api.github.com/users/linev/gists{/gist_id}","starred_url":"https://api.github.com/users/linev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linev/subscriptions","organizations_url":"https://api.github.com/users/linev/orgs","repos_url":"https://api.github.com/users/linev/repos","events_url":"https://api.github.com/users/linev/events{/privacy}","received_events_url":"https://api.github.com/users/linev/received_events","type":"User","site_admin":false},"body":"Now binary data can be send from server to clients.\r\nIdea later use this functionality to send large blobs of data like vertices array for geometry display","created_at":"2018-03-23T16:35:47Z","updated_at":"2018-04-11T13:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6574c01c6d094e82fcbccdc8940babaeb4807412","assignee":{"login":"Axel-Naumann","id":144675,"avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false},"assignees":[{"login":"Axel-Naumann","id":144675,"avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gganis","id":1735130,"avatar_url":"https://avatars1.githubusercontent.com/u/1735130?v=4","gravatar_id":"","url":"https://api.github.com/users/gganis","html_url":"https://github.com/gganis","followers_url":"https://api.github.com/users/gganis/followers","following_url":"https://api.github.com/users/gganis/following{/other_user}","gists_url":"https://api.github.com/users/gganis/gists{/gist_id}","starred_url":"https://api.github.com/users/gganis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gganis/subscriptions","organizations_url":"https://api.github.com/users/gganis/orgs","repos_url":"https://api.github.com/users/gganis/repos","events_url":"https://api.github.com/users/gganis/events{/privacy}","received_events_url":"https://api.github.com/users/gganis/received_events","type":"User","site_admin":false},{"login":"pcanal","id":5175087,"avatar_url":"https://avatars3.githubusercontent.com/u/5175087?v=4","gravatar_id":"","url":"https://api.github.com/users/pcanal","html_url":"https://github.com/pcanal","followers_url":"https://api.github.com/users/pcanal/followers","following_url":"https://api.github.com/users/pcanal/following{/other_user}","gists_url":"https://api.github.com/users/pcanal/gists{/gist_id}","starred_url":"https://api.github.com/users/pcanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcanal/subscriptions","organizations_url":"https://api.github.com/users/pcanal/orgs","repos_url":"https://api.github.com/users/pcanal/repos","events_url":"https://api.github.com/users/pcanal/events{/privacy}","received_events_url":"https://api.github.com/users/pcanal/received_events","type":"User","site_admin":false},{"login":"bellenot","id":5236506,"avatar_url":"https://avatars1.githubusercontent.com/u/5236506?v=4","gravatar_id":"","url":"https://api.github.com/users/bellenot","html_url":"https://github.com/bellenot","followers_url":"https://api.github.com/users/bellenot/followers","following_url":"https://api.github.com/users/bellenot/following{/other_user}","gists_url":"https://api.github.com/users/bellenot/gists{/gist_id}","starred_url":"https://api.github.com/users/bellenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bellenot/subscriptions","organizations_url":"https://api.github.com/users/bellenot/orgs","repos_url":"https://api.github.com/users/bellenot/repos","events_url":"https://api.github.com/users/bellenot/events{/privacy}","received_events_url":"https://api.github.com/users/bellenot/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1785/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1785/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1785/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/8ee23ca08fb4d100608c111a02a1df07ee58b71f","head":{"label":"linev:webwin_binary","ref":"webwin_binary","sha":"8ee23ca08fb4d100608c111a02a1df07ee58b71f","user":{"login":"linev","id":4936580,"avatar_url":"https://avatars3.githubusercontent.com/u/4936580?v=4","gravatar_id":"","url":"https://api.github.com/users/linev","html_url":"https://github.com/linev","followers_url":"https://api.github.com/users/linev/followers","following_url":"https://api.github.com/users/linev/following{/other_user}","gists_url":"https://api.github.com/users/linev/gists{/gist_id}","starred_url":"https://api.github.com/users/linev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linev/subscriptions","organizations_url":"https://api.github.com/users/linev/orgs","repos_url":"https://api.github.com/users/linev/repos","events_url":"https://api.github.com/users/linev/events{/privacy}","received_events_url":"https://api.github.com/users/linev/received_events","type":"User","site_admin":false},"repo":{"id":85197448,"name":"root","full_name":"linev/root","owner":{"login":"linev","id":4936580,"avatar_url":"https://avatars3.githubusercontent.com/u/4936580?v=4","gravatar_id":"","url":"https://api.github.com/users/linev","html_url":"https://github.com/linev","followers_url":"https://api.github.com/users/linev/followers","following_url":"https://api.github.com/users/linev/following{/other_user}","gists_url":"https://api.github.com/users/linev/gists{/gist_id}","starred_url":"https://api.github.com/users/linev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linev/subscriptions","organizations_url":"https://api.github.com/users/linev/orgs","repos_url":"https://api.github.com/users/linev/repos","events_url":"https://api.github.com/users/linev/events{/privacy}","received_events_url":"https://api.github.com/users/linev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linev/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/linev/root","forks_url":"https://api.github.com/repos/linev/root/forks","keys_url":"https://api.github.com/repos/linev/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linev/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linev/root/teams","hooks_url":"https://api.github.com/repos/linev/root/hooks","issue_events_url":"https://api.github.com/repos/linev/root/issues/events{/number}","events_url":"https://api.github.com/repos/linev/root/events","assignees_url":"https://api.github.com/repos/linev/root/assignees{/user}","branches_url":"https://api.github.com/repos/linev/root/branches{/branch}","tags_url":"https://api.github.com/repos/linev/root/tags","blobs_url":"https://api.github.com/repos/linev/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linev/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linev/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/linev/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linev/root/statuses/{sha}","languages_url":"https://api.github.com/repos/linev/root/languages","stargazers_url":"https://api.github.com/repos/linev/root/stargazers","contributors_url":"https://api.github.com/repos/linev/root/contributors","subscribers_url":"https://api.github.com/repos/linev/root/subscribers","subscription_url":"https://api.github.com/repos/linev/root/subscription","commits_url":"https://api.github.com/repos/linev/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/linev/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/linev/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/linev/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/linev/root/contents/{+path}","compare_url":"https://api.github.com/repos/linev/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linev/root/merges","archive_url":"https://api.github.com/repos/linev/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linev/root/downloads","issues_url":"https://api.github.com/repos/linev/root/issues{/number}","pulls_url":"https://api.github.com/repos/linev/root/pulls{/number}","milestones_url":"https://api.github.com/repos/linev/root/milestones{/number}","notifications_url":"https://api.github.com/repos/linev/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linev/root/labels{/name}","releases_url":"https://api.github.com/repos/linev/root/releases{/id}","deployments_url":"https://api.github.com/repos/linev/root/deployments","created_at":"2017-03-16T13:12:48Z","updated_at":"2018-04-10T16:39:19Z","pushed_at":"2018-04-11T12:18:32Z","git_url":"git://github.com/linev/root.git","ssh_url":"git@github.com:linev/root.git","clone_url":"https://github.com/linev/root.git","svn_url":"https://github.com/linev/root","homepage":"","size":686378,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"4038c34a68cf74d02a64d56386cf78c5bbdf76ee","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-04-11T10:05:30Z","pushed_at":"2018-04-11T13:27:20Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":686468,"stargazers_count":556,"watchers_count":556,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":409,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":409,"open_issues":58,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1785"},"html":{"href":"https://github.com/root-project/root/pull/1785"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1785"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1785/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1785/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1785/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/8ee23ca08fb4d100608c111a02a1df07ee58b71f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Axel-Naumann"}}