{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/234391049","pull_request_review_id":176034826,"id":234391049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDM5MTA0OQ==","diff_hunk":"@@ -22,12 +22,11 @@\n \n namespace Microsoft.Azure.Commands.Management.Storage.StorageAccount\n {\n-    [GenericBreakingChange(\"Parameter 'Location' will change from optional to mandatory in a future release.\")]\n     [Cmdlet(\"Get\", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + \"StorageUsage\"), OutputType(typeof(PSUsage))]\n     public class GetAzureStorageUsageCommand : StorageAccountBaseCmdlet\n     {\n         [Parameter(\n-            Mandatory = false,\n+            Mandatory = true,","path":"src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/GetAzureStorageUsage.cs","position":10,"original_position":10,"commit_id":"cd8815cfdfe30e52dd80e460033a59d22909e0ce","original_commit_id":"cd8815cfdfe30e52dd80e460033a59d22909e0ce","user":{"login":"maddieclayton","id":8137559,"node_id":"MDQ6VXNlcjgxMzc1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8137559?v=4","gravatar_id":"","url":"https://api.github.com/users/maddieclayton","html_url":"https://github.com/maddieclayton","followers_url":"https://api.github.com/users/maddieclayton/followers","following_url":"https://api.github.com/users/maddieclayton/following{/other_user}","gists_url":"https://api.github.com/users/maddieclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/maddieclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddieclayton/subscriptions","organizations_url":"https://api.github.com/users/maddieclayton/orgs","repos_url":"https://api.github.com/users/maddieclayton/repos","events_url":"https://api.github.com/users/maddieclayton/events{/privacy}","received_events_url":"https://api.github.com/users/maddieclayton/received_events","type":"User","site_admin":false},"body":"Please update the help files for the two cmdlets affected by this PR.","created_at":"2018-11-17T01:49:16Z","updated_at":"2018-11-17T01:49:18Z","html_url":"https://github.com/Azure/azure-powershell/pull/7835#discussion_r234391049","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/234391049"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7835#discussion_r234391049"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835","id":231088351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDg4MzUx","html_url":"https://github.com/Azure/azure-powershell/pull/7835","diff_url":"https://github.com/Azure/azure-powershell/pull/7835.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7835.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7835","number":7835,"state":"open","locked":false,"title":"[Storage] Upgrade SRP SDK to 9.0.0 and fix some issue","user":{"login":"blueww","id":6926193,"node_id":"MDQ6VXNlcjY5MjYxOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6926193?v=4","gravatar_id":"","url":"https://api.github.com/users/blueww","html_url":"https://github.com/blueww","followers_url":"https://api.github.com/users/blueww/followers","following_url":"https://api.github.com/users/blueww/following{/other_user}","gists_url":"https://api.github.com/users/blueww/gists{/gist_id}","starred_url":"https://api.github.com/users/blueww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueww/subscriptions","organizations_url":"https://api.github.com/users/blueww/orgs","repos_url":"https://api.github.com/users/blueww/repos","events_url":"https://api.github.com/users/blueww/events{/privacy}","received_events_url":"https://api.github.com/users/blueww/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n<!-- Please add a brief description of the changes made in this PR -->\r\n\r\nThis PR targets 12/4 release.\r\n\r\n1. Upgrade SDK to 9.0.0 per issue https://github.com/Azure/azure-powershell/issues/7780\r\n2. (breaking) get global location is remove since SRP SDK upgrade, so -Location parameter become mandatory in Get-AzureRMStorageUsage\r\n3. (breaking) Change default parameter set to Oauth parameter set as the next release allows breaking https://github.com/Azure/azure-powershell/issues/7143\r\n4. Fix issue https://github.com/Azure/azure-powershell/issues/7805, but set Account name to \"[AccessToken]\" when Context is an Oauth Context (aligned with SAS context)\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [x] If applicable, the changes made in the PR have proper test coverage\r\n- [x] For public API changes to cmdlets:\r\n    - [x] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)\r\n    - [x] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-11-15T07:00:31Z","updated_at":"2018-11-17T01:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1b973af24a2140dfb2e368545bbdcf84b7aabe7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1130317786,"node_id":"MDU6TGFiZWwxMTMwMzE3Nzg2","url":"https://api.github.com/repos/Azure/azure-powershell/labels/Breaking%20Change%20Release","name":"Breaking Change Release","color":"d62f31","default":false},{"id":1056158818,"node_id":"MDU6TGFiZWwxMDU2MTU4ODE4","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7835/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/cd8815cfdfe30e52dd80e460033a59d22909e0ce","head":{"label":"wastoresh:sdk9","ref":"sdk9","sha":"cd8815cfdfe30e52dd80e460033a59d22909e0ce","user":{"login":"wastoresh","id":6927621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5Mjc2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6927621?v=4","gravatar_id":"","url":"https://api.github.com/users/wastoresh","html_url":"https://github.com/wastoresh","followers_url":"https://api.github.com/users/wastoresh/followers","following_url":"https://api.github.com/users/wastoresh/following{/other_user}","gists_url":"https://api.github.com/users/wastoresh/gists{/gist_id}","starred_url":"https://api.github.com/users/wastoresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wastoresh/subscriptions","organizations_url":"https://api.github.com/users/wastoresh/orgs","repos_url":"https://api.github.com/users/wastoresh/repos","events_url":"https://api.github.com/users/wastoresh/events{/privacy}","received_events_url":"https://api.github.com/users/wastoresh/received_events","type":"Organization","site_admin":false},"repo":{"id":26895254,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg5NTI1NA==","name":"azure-powershell","full_name":"wastoresh/azure-powershell","private":false,"owner":{"login":"wastoresh","id":6927621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5Mjc2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6927621?v=4","gravatar_id":"","url":"https://api.github.com/users/wastoresh","html_url":"https://github.com/wastoresh","followers_url":"https://api.github.com/users/wastoresh/followers","following_url":"https://api.github.com/users/wastoresh/following{/other_user}","gists_url":"https://api.github.com/users/wastoresh/gists{/gist_id}","starred_url":"https://api.github.com/users/wastoresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wastoresh/subscriptions","organizations_url":"https://api.github.com/users/wastoresh/orgs","repos_url":"https://api.github.com/users/wastoresh/repos","events_url":"https://api.github.com/users/wastoresh/events{/privacy}","received_events_url":"https://api.github.com/users/wastoresh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wastoresh/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/wastoresh/azure-powershell","forks_url":"https://api.github.com/repos/wastoresh/azure-powershell/forks","keys_url":"https://api.github.com/repos/wastoresh/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wastoresh/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wastoresh/azure-powershell/teams","hooks_url":"https://api.github.com/repos/wastoresh/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/wastoresh/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/wastoresh/azure-powershell/events","assignees_url":"https://api.github.com/repos/wastoresh/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/wastoresh/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/wastoresh/azure-powershell/tags","blobs_url":"https://api.github.com/repos/wastoresh/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wastoresh/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wastoresh/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/wastoresh/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wastoresh/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/wastoresh/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/wastoresh/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/wastoresh/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/wastoresh/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/wastoresh/azure-powershell/subscription","commits_url":"https://api.github.com/repos/wastoresh/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/wastoresh/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/wastoresh/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/wastoresh/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/wastoresh/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/wastoresh/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wastoresh/azure-powershell/merges","archive_url":"https://api.github.com/repos/wastoresh/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wastoresh/azure-powershell/downloads","issues_url":"https://api.github.com/repos/wastoresh/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/wastoresh/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/wastoresh/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/wastoresh/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wastoresh/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/wastoresh/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/wastoresh/azure-powershell/deployments","created_at":"2014-11-20T04:10:39Z","updated_at":"2017-08-21T06:53:53Z","pushed_at":"2018-11-17T01:28:36Z","git_url":"git://github.com/wastoresh/azure-powershell.git","ssh_url":"git@github.com:wastoresh/azure-powershell.git","clone_url":"https://github.com/wastoresh/azure-powershell.git","svn_url":"https://github.com/wastoresh/azure-powershell","homepage":null,"size":778667,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:preview","ref":"preview","sha":"622034f1177072edfc78aab53886e81d808d91ba","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-11-17T01:19:13Z","pushed_at":"2018-11-17T01:28:38Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":783086,"stargazers_count":1220,"watchers_count":1220,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1281,"mirror_url":null,"archived":false,"open_issues_count":747,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1281,"open_issues":747,"watchers":1220,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7835"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7835"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7835/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7835/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/cd8815cfdfe30e52dd80e460033a59d22909e0ce"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"maddieclayton"}}