{"action":"created","issue":{"url":"https://api.github.com/repos/satijalab/seurat/issues/1019","repository_url":"https://api.github.com/repos/satijalab/seurat","labels_url":"https://api.github.com/repos/satijalab/seurat/issues/1019/labels{/name}","comments_url":"https://api.github.com/repos/satijalab/seurat/issues/1019/comments","events_url":"https://api.github.com/repos/satijalab/seurat/issues/1019/events","html_url":"https://github.com/satijalab/seurat/issues/1019","id":392147222,"node_id":"MDU6SXNzdWUzOTIxNDcyMjI=","number":1019,"title":"FindAllMarkers() results are not saved into the object","user":{"login":"maximilianh","id":310861,"node_id":"MDQ6VXNlcjMxMDg2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/310861?v=4","gravatar_id":"","url":"https://api.github.com/users/maximilianh","html_url":"https://github.com/maximilianh","followers_url":"https://api.github.com/users/maximilianh/followers","following_url":"https://api.github.com/users/maximilianh/following{/other_user}","gists_url":"https://api.github.com/users/maximilianh/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianh/subscriptions","organizations_url":"https://api.github.com/users/maximilianh/orgs","repos_url":"https://api.github.com/users/maximilianh/repos","events_url":"https://api.github.com/users/maximilianh/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-18T13:03:37Z","updated_at":"2018-12-18T13:05:44Z","closed_at":null,"author_association":"NONE","body":"I believe that most of the Seurat functions add their results to the object. This is very handy, as one can save the object and send it to someone else. In many ways, the Seurat object itself has become a file format. Also, as a result, it can be easily converted to Cellranger, Bioconductor or Scanpy objects.\r\n\r\nHowever, the FindAllMarkers() function is different, it does not save the result. There is not even an option to save the result. This may be to save space, but it could save at least the top n genes.\r\n\r\nI wonder if it could be a good idea to add an option one day that adds the FindAllMarkers() and FindMarkers() result to the Seurat object."},"comment":{"url":"https://api.github.com/repos/satijalab/seurat/issues/comments/448214302","html_url":"https://github.com/satijalab/seurat/issues/1019#issuecomment-448214302","issue_url":"https://api.github.com/repos/satijalab/seurat/issues/1019","id":448214302,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODIxNDMwMg==","user":{"login":"maximilianh","id":310861,"node_id":"MDQ6VXNlcjMxMDg2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/310861?v=4","gravatar_id":"","url":"https://api.github.com/users/maximilianh","html_url":"https://github.com/maximilianh","followers_url":"https://api.github.com/users/maximilianh/followers","following_url":"https://api.github.com/users/maximilianh/following{/other_user}","gists_url":"https://api.github.com/users/maximilianh/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianh/subscriptions","organizations_url":"https://api.github.com/users/maximilianh/orgs","repos_url":"https://api.github.com/users/maximilianh/repos","events_url":"https://api.github.com/users/maximilianh/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianh/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T13:05:44Z","updated_at":"2018-12-18T13:05:44Z","author_association":"NONE","body":"One reason that this was a not a major issue originally may be that the runtime with the lower number of cells was not a big deal. These days with 10X datasets, calculating markers can take quite a while, so it may be good to keep the result."}}
{"actor":{"display_login":"maximilianh"}}