{"action":"created","comment":{"url":"https://api.github.com/repos/danliris/dl-module/pulls/comments/166541064","pull_request_review_id":94617459,"id":166541064,"diff_hunk":"@@ -127,14 +127,15 @@ module.exports = class BookingOrderManager extends BaseManager {\n                     valid.deliveryDate=new Date(valid.deliveryDate);\n                     valid.bookingDate=new Date(valid.bookingDate);\n                     valid.bookingDate.setHours(0,0,0,0);\n-                    valid.deliveryDate.setHours(7,0,0,0);\n+                    valid.deliveryDate.setHours(0,0,0,0);\n                     var today= new Date();\n                     today.setHours(0,0,0,0);\n-                    if(valid.bookingDate>valid.deliveryDate){\n-                        errors[\"deliveryDate\"] = i18n.__(\"BookingOrder.deliveryDate.shouldNot:%s should not be less than booking date\", i18n.__(\"BookingOrder.deliveryDate._:DeliveryDate\")); \n-                    }\n-                    else if(today>valid.deliveryDate){\n-                        errors[\"deliveryDate\"] = i18n.__(\"BookingOrder.DeliveryDate.shouldNot:%s should not be less than today date\", i18n.__(\"BookingOrder.deliveryDate._:DeliveryDate\")); \n+                    if(valid.bookingDate!=valid.deliveryDate){\n+                        if(valid.bookingDate>valid.deliveryDate){\n+                            errors[\"deliveryDate\"] = i18n.__(\"BookingOrder.DeliveryDate.shouldNot:%s should not be less than booking date\", i18n.__(\"BookingOrder.deliveryDate._:DeliveryDate\")); ","path":"src/managers/garment-master-plan/booking-order-manager.js","position":15,"original_position":15,"commit_id":"ea3a85c6b0dbdc867b71dc95f0eeb37f965cf268","original_commit_id":"ea3a85c6b0dbdc867b71dc95f0eeb37f965cf268","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"['deliveryDate'] is better written in dot notation.","created_at":"2018-02-07T08:01:32Z","updated_at":"2018-02-07T08:01:32Z","html_url":"https://github.com/danliris/dl-module/pull/1588#discussion_r166541064","pull_request_url":"https://api.github.com/repos/danliris/dl-module/pulls/1588","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/comments/166541064"},"html":{"href":"https://github.com/danliris/dl-module/pull/1588#discussion_r166541064"},"pull_request":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/1588"}}},"pull_request":{"url":"https://api.github.com/repos/danliris/dl-module/pulls/1588","id":167621629,"html_url":"https://github.com/danliris/dl-module/pull/1588","diff_url":"https://github.com/danliris/dl-module/pull/1588.diff","patch_url":"https://github.com/danliris/dl-module/pull/1588.patch","issue_url":"https://api.github.com/repos/danliris/dl-module/issues/1588","number":1588,"state":"open","locked":false,"title":"Fixed Booking Order Validation","user":{"login":"kharissuryandaru","id":35208779,"avatar_url":"https://avatars1.githubusercontent.com/u/35208779?v=4","gravatar_id":"","url":"https://api.github.com/users/kharissuryandaru","html_url":"https://github.com/kharissuryandaru","followers_url":"https://api.github.com/users/kharissuryandaru/followers","following_url":"https://api.github.com/users/kharissuryandaru/following{/other_user}","gists_url":"https://api.github.com/users/kharissuryandaru/gists{/gist_id}","starred_url":"https://api.github.com/users/kharissuryandaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kharissuryandaru/subscriptions","organizations_url":"https://api.github.com/users/kharissuryandaru/orgs","repos_url":"https://api.github.com/users/kharissuryandaru/repos","events_url":"https://api.github.com/users/kharissuryandaru/events{/privacy}","received_events_url":"https://api.github.com/users/kharissuryandaru/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-07T08:01:20Z","updated_at":"2018-02-07T08:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab61bd539f2a16cafdf52efdf2a7b0c155abc071","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/danliris/dl-module/pulls/1588/commits","review_comments_url":"https://api.github.com/repos/danliris/dl-module/pulls/1588/comments","review_comment_url":"https://api.github.com/repos/danliris/dl-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danliris/dl-module/issues/1588/comments","statuses_url":"https://api.github.com/repos/danliris/dl-module/statuses/ea3a85c6b0dbdc867b71dc95f0eeb37f965cf268","head":{"label":"kharissuryandaru:dev","ref":"dev","sha":"ea3a85c6b0dbdc867b71dc95f0eeb37f965cf268","user":{"login":"kharissuryandaru","id":35208779,"avatar_url":"https://avatars1.githubusercontent.com/u/35208779?v=4","gravatar_id":"","url":"https://api.github.com/users/kharissuryandaru","html_url":"https://github.com/kharissuryandaru","followers_url":"https://api.github.com/users/kharissuryandaru/followers","following_url":"https://api.github.com/users/kharissuryandaru/following{/other_user}","gists_url":"https://api.github.com/users/kharissuryandaru/gists{/gist_id}","starred_url":"https://api.github.com/users/kharissuryandaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kharissuryandaru/subscriptions","organizations_url":"https://api.github.com/users/kharissuryandaru/orgs","repos_url":"https://api.github.com/users/kharissuryandaru/repos","events_url":"https://api.github.com/users/kharissuryandaru/events{/privacy}","received_events_url":"https://api.github.com/users/kharissuryandaru/received_events","type":"User","site_admin":false},"repo":{"id":117806919,"name":"dl-module","full_name":"kharissuryandaru/dl-module","owner":{"login":"kharissuryandaru","id":35208779,"avatar_url":"https://avatars1.githubusercontent.com/u/35208779?v=4","gravatar_id":"","url":"https://api.github.com/users/kharissuryandaru","html_url":"https://github.com/kharissuryandaru","followers_url":"https://api.github.com/users/kharissuryandaru/followers","following_url":"https://api.github.com/users/kharissuryandaru/following{/other_user}","gists_url":"https://api.github.com/users/kharissuryandaru/gists{/gist_id}","starred_url":"https://api.github.com/users/kharissuryandaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kharissuryandaru/subscriptions","organizations_url":"https://api.github.com/users/kharissuryandaru/orgs","repos_url":"https://api.github.com/users/kharissuryandaru/repos","events_url":"https://api.github.com/users/kharissuryandaru/events{/privacy}","received_events_url":"https://api.github.com/users/kharissuryandaru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kharissuryandaru/dl-module","description":"Dan Liris Modules","fork":true,"url":"https://api.github.com/repos/kharissuryandaru/dl-module","forks_url":"https://api.github.com/repos/kharissuryandaru/dl-module/forks","keys_url":"https://api.github.com/repos/kharissuryandaru/dl-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kharissuryandaru/dl-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kharissuryandaru/dl-module/teams","hooks_url":"https://api.github.com/repos/kharissuryandaru/dl-module/hooks","issue_events_url":"https://api.github.com/repos/kharissuryandaru/dl-module/issues/events{/number}","events_url":"https://api.github.com/repos/kharissuryandaru/dl-module/events","assignees_url":"https://api.github.com/repos/kharissuryandaru/dl-module/assignees{/user}","branches_url":"https://api.github.com/repos/kharissuryandaru/dl-module/branches{/branch}","tags_url":"https://api.github.com/repos/kharissuryandaru/dl-module/tags","blobs_url":"https://api.github.com/repos/kharissuryandaru/dl-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kharissuryandaru/dl-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kharissuryandaru/dl-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/kharissuryandaru/dl-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kharissuryandaru/dl-module/statuses/{sha}","languages_url":"https://api.github.com/repos/kharissuryandaru/dl-module/languages","stargazers_url":"https://api.github.com/repos/kharissuryandaru/dl-module/stargazers","contributors_url":"https://api.github.com/repos/kharissuryandaru/dl-module/contributors","subscribers_url":"https://api.github.com/repos/kharissuryandaru/dl-module/subscribers","subscription_url":"https://api.github.com/repos/kharissuryandaru/dl-module/subscription","commits_url":"https://api.github.com/repos/kharissuryandaru/dl-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/kharissuryandaru/dl-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/kharissuryandaru/dl-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/kharissuryandaru/dl-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/kharissuryandaru/dl-module/contents/{+path}","compare_url":"https://api.github.com/repos/kharissuryandaru/dl-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kharissuryandaru/dl-module/merges","archive_url":"https://api.github.com/repos/kharissuryandaru/dl-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kharissuryandaru/dl-module/downloads","issues_url":"https://api.github.com/repos/kharissuryandaru/dl-module/issues{/number}","pulls_url":"https://api.github.com/repos/kharissuryandaru/dl-module/pulls{/number}","milestones_url":"https://api.github.com/repos/kharissuryandaru/dl-module/milestones{/number}","notifications_url":"https://api.github.com/repos/kharissuryandaru/dl-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kharissuryandaru/dl-module/labels{/name}","releases_url":"https://api.github.com/repos/kharissuryandaru/dl-module/releases{/id}","deployments_url":"https://api.github.com/repos/kharissuryandaru/dl-module/deployments","created_at":"2018-01-17T08:22:44Z","updated_at":"2018-01-17T08:22:47Z","pushed_at":"2018-02-07T08:00:17Z","git_url":"git://github.com/kharissuryandaru/dl-module.git","ssh_url":"git@github.com:kharissuryandaru/dl-module.git","clone_url":"https://github.com/kharissuryandaru/dl-module.git","svn_url":"https://github.com/kharissuryandaru/dl-module","homepage":null,"size":6766,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danliris:dev","ref":"dev","sha":"3bd9f88037002d431a5a07e766c15a5ea3567cbf","user":{"login":"danliris","id":20855729,"avatar_url":"https://avatars0.githubusercontent.com/u/20855729?v=4","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"repo":{"id":64628314,"name":"dl-module","full_name":"danliris/dl-module","owner":{"login":"danliris","id":20855729,"avatar_url":"https://avatars0.githubusercontent.com/u/20855729?v=4","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danliris/dl-module","description":"Dan Liris Modules","fork":false,"url":"https://api.github.com/repos/danliris/dl-module","forks_url":"https://api.github.com/repos/danliris/dl-module/forks","keys_url":"https://api.github.com/repos/danliris/dl-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danliris/dl-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danliris/dl-module/teams","hooks_url":"https://api.github.com/repos/danliris/dl-module/hooks","issue_events_url":"https://api.github.com/repos/danliris/dl-module/issues/events{/number}","events_url":"https://api.github.com/repos/danliris/dl-module/events","assignees_url":"https://api.github.com/repos/danliris/dl-module/assignees{/user}","branches_url":"https://api.github.com/repos/danliris/dl-module/branches{/branch}","tags_url":"https://api.github.com/repos/danliris/dl-module/tags","blobs_url":"https://api.github.com/repos/danliris/dl-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danliris/dl-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danliris/dl-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/danliris/dl-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danliris/dl-module/statuses/{sha}","languages_url":"https://api.github.com/repos/danliris/dl-module/languages","stargazers_url":"https://api.github.com/repos/danliris/dl-module/stargazers","contributors_url":"https://api.github.com/repos/danliris/dl-module/contributors","subscribers_url":"https://api.github.com/repos/danliris/dl-module/subscribers","subscription_url":"https://api.github.com/repos/danliris/dl-module/subscription","commits_url":"https://api.github.com/repos/danliris/dl-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/danliris/dl-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/danliris/dl-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/danliris/dl-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/danliris/dl-module/contents/{+path}","compare_url":"https://api.github.com/repos/danliris/dl-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danliris/dl-module/merges","archive_url":"https://api.github.com/repos/danliris/dl-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danliris/dl-module/downloads","issues_url":"https://api.github.com/repos/danliris/dl-module/issues{/number}","pulls_url":"https://api.github.com/repos/danliris/dl-module/pulls{/number}","milestones_url":"https://api.github.com/repos/danliris/dl-module/milestones{/number}","notifications_url":"https://api.github.com/repos/danliris/dl-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danliris/dl-module/labels{/name}","releases_url":"https://api.github.com/repos/danliris/dl-module/releases{/id}","deployments_url":"https://api.github.com/repos/danliris/dl-module/deployments","created_at":"2016-08-01T02:15:05Z","updated_at":"2016-08-08T03:27:08Z","pushed_at":"2018-02-07T08:01:21Z","git_url":"git://github.com/danliris/dl-module.git","ssh_url":"git@github.com:danliris/dl-module.git","clone_url":"https://github.com/danliris/dl-module.git","svn_url":"https://github.com/danliris/dl-module","homepage":null,"size":6795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":32,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/1588"},"html":{"href":"https://github.com/danliris/dl-module/pull/1588"},"issue":{"href":"https://api.github.com/repos/danliris/dl-module/issues/1588"},"comments":{"href":"https://api.github.com/repos/danliris/dl-module/issues/1588/comments"},"review_comments":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/1588/comments"},"review_comment":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danliris/dl-module/pulls/1588/commits"},"statuses":{"href":"https://api.github.com/repos/danliris/dl-module/statuses/ea3a85c6b0dbdc867b71dc95f0eeb37f965cf268"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}