{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes-csi/livenessprobe/issues/17","repository_url":"https://api.github.com/repos/kubernetes-csi/livenessprobe","labels_url":"https://api.github.com/repos/kubernetes-csi/livenessprobe/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-csi/livenessprobe/issues/17/comments","events_url":"https://api.github.com/repos/kubernetes-csi/livenessprobe/issues/17/events","html_url":"https://github.com/kubernetes-csi/livenessprobe/issues/17","id":375570400,"node_id":"MDU6SXNzdWUzNzU1NzA0MDA=","number":17,"title":"livenessprobe fails for controller only CSI driver","user":{"login":"sarjeet2013","id":4831267,"node_id":"MDQ6VXNlcjQ4MzEyNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/4831267?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjeet2013","html_url":"https://github.com/sarjeet2013","followers_url":"https://api.github.com/users/sarjeet2013/followers","following_url":"https://api.github.com/users/sarjeet2013/following{/other_user}","gists_url":"https://api.github.com/users/sarjeet2013/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjeet2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjeet2013/subscriptions","organizations_url":"https://api.github.com/users/sarjeet2013/orgs","repos_url":"https://api.github.com/users/sarjeet2013/repos","events_url":"https://api.github.com/users/sarjeet2013/events{/privacy}","received_events_url":"https://api.github.com/users/sarjeet2013/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T16:07:44Z","updated_at":"2018-11-02T00:12:32Z","closed_at":"2018-11-02T00:12:32Z","author_association":"NONE","body":"livenessprobe can be integrate to CSI driver which only implement Controller and Identity service, but no NodeServer service.\r\n\r\nThe following is making rpc call which is being implemented in NodeServer. We should make liveness probe universally common for CSI driver to only depend on Identity Service rpc calls.\r\n\r\nhttps://github.com/kubernetes-csi/livenessprobe/blob/master/cmd/main.go#L56:\r\ncsiDriverNodeID, err := csiConn.NodeGetId(ctx)\r\n\r\nHere is the log when integrated it to controller:\r\n\r\nI1030 04:17:27.965740       1 main.go:109] Serving requests to /healthz on: 0.0.0.0:9809\r\nI1030 04:17:40.913574       1 main.go:82] Request: /healthz from: 172.17.0.1:40302\r\nI1030 04:17:40.913607       1 main.go:72] Attempting to open a gRPC connection with: /var/lib/csi/sockets/pluginproxy/csi.sock\r\nI1030 04:17:40.913624       1 connection.go:70] Connecting to /var/lib/csi/sockets/pluginproxy/csi.sock\r\nI1030 04:17:40.936761       1 connection.go:97] Still trying, connection is CONNECTING\r\nI1030 04:17:40.937903       1 connection.go:94] Connected\r\nI1030 04:17:40.937922       1 main.go:47] Calling CSI driver to discover driver name.\r\nI1030 04:17:40.937933       1 connection.go:150] GRPC call: /csi.v0.Identity/GetPluginInfo\r\nI1030 04:17:40.937943       1 connection.go:151] GRPC request:\r\nI1030 04:17:40.950593       1 connection.go:153] GRPC response: name:\"com.mapr.csi-kdf\" vendor_version:\"0.3.0\"\r\nI1030 04:17:40.950671       1 connection.go:154] GRPC error: <nil>\r\nI1030 04:17:40.950680       1 main.go:52] CSI driver name: \"com.mapr.csi-kdf\"\r\nI1030 04:17:40.950690       1 main.go:55] Calling CSI driver to discover node ID.\r\nI1030 04:17:40.950699       1 connection.go:150] GRPC call: /csi.v0.Node/NodeGetId\r\nI1030 04:17:40.950706       1 connection.go:151] GRPC request:\r\nI1030 04:17:40.951186       1 connection.go:153] GRPC response:\r\nI1030 04:17:40.951226       1 connection.go:154] GRPC error: rpc error: code = Unimplemented desc = unknown service csi.v0.Node\r\nI1030 04:17:40.951289       1 main.go:95] Health check failed with: rpc error: code = Unimplemented desc = unknown service csi.v0.Node.\r\n\r\n@sbezverk As discussed in #wg-csi, Let me know if there are additional information required for it?"}}
{"actor":{"display_login":"k8s-ci-robot"}}