{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/189176637","pull_request_review_id":121304235,"id":189176637,"diff_hunk":"@@ -126,6 +126,134 @@ case class MapKeys(child: Expression)\n   override def prettyName: String = \"map_keys\"\n }\n \n+@ExpressionDescription(\n+  usage = \"\"\"_FUNC_(a1, a2, ...) - Returns a merged array containing in the N-th position the\n+  N-th value of each array given.\"\"\",\n+  examples = \"\"\"\n+    Examples:\n+      > SELECT _FUNC_(array(1, 2, 3), array(2, 3, 4));\n+        [[1, 2], [2, 3], [3, 4]]\n+      > SELECT _FUNC_(array(1, 2), array(2, 3), array(3, 4));\n+        [[1, 2, 3], [2, 3, 4]]\n+  \"\"\",\n+  since = \"2.4.0\")\n+case class Zip(children: Seq[Expression]) extends Expression with ExpectsInputTypes {\n+\n+  override def inputTypes: Seq[AbstractDataType] = Seq.fill(children.length)(ArrayType)\n+\n+  override def dataType: DataType = ArrayType(mountSchema)\n+\n+  override def prettyName: String = \"zip\"\n+\n+  override def nullable: Boolean = children.forall(_.nullable)\n+\n+  lazy val numberOfArrays: Int = children.length\n+\n+  def mountSchema: StructType = {\n+    val arrayAT = children.map(_.dataType.asInstanceOf[ArrayType])\n+    val fields = arrayAT.zipWithIndex.foldRight(List[StructField]()) { case ((arr, idx), list) =>\n+      StructField(s\"_$idx\", arr.elementType, children(idx).nullable || arr.containsNull) :: list\n+    }\n+    StructType(fields)\n+  }\n+\n+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {\n+    val genericArrayData = classOf[GenericArrayData].getName\n+    val genericInternalRow = classOf[GenericInternalRow].getName\n+\n+    val evals = children.map(_.genCode(ctx))\n+\n+    val arrayTypes = children.map(_.dataType.asInstanceOf[ArrayType].elementType)\n+\n+    val arrVals = ctx.freshName(\"arrVals\")\n+    val arrCardinality = ctx.freshName(\"arrCardinality\")\n+    val biggestCardinality = ctx.freshName(\"biggestCardinality\")\n+\n+    val inputs = evals.zipWithIndex.map { case (eval, index) =>\n+      s\"\"\"\n+        |${eval.code}\n+        |if (!${eval.isNull}) {\n+        |  $arrVals[$index] = ${eval.value};\n+        |  $arrCardinality[$index] = ${eval.value}.numElements();\n+        |} else {\n+        |  $arrVals[$index] = null;\n+        |  $arrCardinality[$index] = 0;\n+        |}\n+        |$biggestCardinality = Math.max($biggestCardinality, $arrCardinality[$index]);\n+      \"\"\".stripMargin\n+    }.mkString(\"\\n\")\n+\n+    val myobject = ctx.freshName(\"myobject\")\n+    val j = ctx.freshName(\"j\")\n+    val i = ctx.freshName(\"i\")\n+    val args = ctx.freshName(\"args\")\n+\n+    val fillValue = evals.zipWithIndex.map { case (eval, index) =>\n+      s\"\"\"\n+      |      if ($j == ${index}) {\n+      |        $myobject[$j] = ${CodeGenerator.getValue(s\"$arrVals[$j]\", arrayTypes(index), i)};\n+      |      }\n+      \"\"\".stripMargin\n+    }\n+\n+    val fillValueSplitted = ctx.splitExpressions(\n+      expressions = fillValue,\n+      funcName = \"fillValue\",\n+      arguments =\n+        (\"int\", j) ::\n+        (\"Array[] Object\", myobject) :: Nil)\n+\n+    ev.copy(s\"\"\"\n+      |ArrayData[] $arrVals = new ArrayData[$numberOfArrays];\n+      |int[] $arrCardinality = new int[$numberOfArrays];\n+      |int $biggestCardinality = 0;\n+      |$inputs\n+      |Object[] $args = new Object[$biggestCardinality];\n+      |for (int $i = 0; $i < $biggestCardinality; $i ++) {\n+      |  Object[] $myobject = new Object[$numberOfArrays];\n+      |  for (int $j = 0; $j < $numberOfArrays; $j ++) {\n+      |    if ($arrVals[$j] != null && $arrCardinality[$j] > $i && !$arrVals[$j].isNullAt($i)) {\n+      |      $fillValueSplitted","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala","position":91,"original_position":91,"commit_id":"be4f46d8f88fd7fc58c81b1471c547dcd0216aae","original_commit_id":"be4f46d8f88fd7fc58c81b1471c547dcd0216aae","user":{"login":"mgaido91","id":8821783,"avatar_url":"https://avatars1.githubusercontent.com/u/8821783?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaido91","html_url":"https://github.com/mgaido91","followers_url":"https://api.github.com/users/mgaido91/followers","following_url":"https://api.github.com/users/mgaido91/following{/other_user}","gists_url":"https://api.github.com/users/mgaido91/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaido91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaido91/subscriptions","organizations_url":"https://api.github.com/users/mgaido91/orgs","repos_url":"https://api.github.com/users/mgaido91/repos","events_url":"https://api.github.com/users/mgaido91/events{/privacy}","received_events_url":"https://api.github.com/users/mgaido91/received_events","type":"User","site_admin":false},"body":"can we find a way to avoid the lot of `if`s which we are generating here?","created_at":"2018-05-18T06:49:43Z","updated_at":"2018-05-18T06:53:46Z","html_url":"https://github.com/apache/spark/pull/21045#discussion_r189176637","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21045","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/189176637"},"html":{"href":"https://github.com/apache/spark/pull/21045#discussion_r189176637"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21045"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21045","id":181009876,"html_url":"https://github.com/apache/spark/pull/21045","diff_url":"https://github.com/apache/spark/pull/21045.diff","patch_url":"https://github.com/apache/spark/pull/21045.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21045","number":21045,"state":"open","locked":false,"title":"[SPARK-23931][SQL] Adds zip function to sparksql","user":{"login":"DylanGuedes","id":7079397,"avatar_url":"https://avatars3.githubusercontent.com/u/7079397?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanGuedes","html_url":"https://github.com/DylanGuedes","followers_url":"https://api.github.com/users/DylanGuedes/followers","following_url":"https://api.github.com/users/DylanGuedes/following{/other_user}","gists_url":"https://api.github.com/users/DylanGuedes/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanGuedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanGuedes/subscriptions","organizations_url":"https://api.github.com/users/DylanGuedes/orgs","repos_url":"https://api.github.com/users/DylanGuedes/repos","events_url":"https://api.github.com/users/DylanGuedes/events{/privacy}","received_events_url":"https://api.github.com/users/DylanGuedes/received_events","type":"User","site_admin":false},"body":"Signed-off-by: DylanGuedes <djmgguedes@gmail.com>\r\n\r\n## What changes were proposed in this pull request?\r\n\r\nAddition of zip function to spark sql functions.\r\n\r\n## How was this patch tested?\r\n\r\n(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)\r\nUnit tests that checks if the results are correct.\r\n","created_at":"2018-04-11T19:51:52Z","updated_at":"2018-05-18T06:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"267a1ccafc227459436db8fa22f41e2aabf6673a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21045/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21045/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21045/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/be4f46d8f88fd7fc58c81b1471c547dcd0216aae","head":{"label":"DylanGuedes:SPARK-23931","ref":"SPARK-23931","sha":"be4f46d8f88fd7fc58c81b1471c547dcd0216aae","user":{"login":"DylanGuedes","id":7079397,"avatar_url":"https://avatars3.githubusercontent.com/u/7079397?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanGuedes","html_url":"https://github.com/DylanGuedes","followers_url":"https://api.github.com/users/DylanGuedes/followers","following_url":"https://api.github.com/users/DylanGuedes/following{/other_user}","gists_url":"https://api.github.com/users/DylanGuedes/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanGuedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanGuedes/subscriptions","organizations_url":"https://api.github.com/users/DylanGuedes/orgs","repos_url":"https://api.github.com/users/DylanGuedes/repos","events_url":"https://api.github.com/users/DylanGuedes/events{/privacy}","received_events_url":"https://api.github.com/users/DylanGuedes/received_events","type":"User","site_admin":false},"repo":{"id":89616994,"name":"spark","full_name":"DylanGuedes/spark","owner":{"login":"DylanGuedes","id":7079397,"avatar_url":"https://avatars3.githubusercontent.com/u/7079397?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanGuedes","html_url":"https://github.com/DylanGuedes","followers_url":"https://api.github.com/users/DylanGuedes/followers","following_url":"https://api.github.com/users/DylanGuedes/following{/other_user}","gists_url":"https://api.github.com/users/DylanGuedes/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanGuedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanGuedes/subscriptions","organizations_url":"https://api.github.com/users/DylanGuedes/orgs","repos_url":"https://api.github.com/users/DylanGuedes/repos","events_url":"https://api.github.com/users/DylanGuedes/events{/privacy}","received_events_url":"https://api.github.com/users/DylanGuedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DylanGuedes/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/DylanGuedes/spark","forks_url":"https://api.github.com/repos/DylanGuedes/spark/forks","keys_url":"https://api.github.com/repos/DylanGuedes/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DylanGuedes/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DylanGuedes/spark/teams","hooks_url":"https://api.github.com/repos/DylanGuedes/spark/hooks","issue_events_url":"https://api.github.com/repos/DylanGuedes/spark/issues/events{/number}","events_url":"https://api.github.com/repos/DylanGuedes/spark/events","assignees_url":"https://api.github.com/repos/DylanGuedes/spark/assignees{/user}","branches_url":"https://api.github.com/repos/DylanGuedes/spark/branches{/branch}","tags_url":"https://api.github.com/repos/DylanGuedes/spark/tags","blobs_url":"https://api.github.com/repos/DylanGuedes/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DylanGuedes/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DylanGuedes/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/DylanGuedes/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DylanGuedes/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/DylanGuedes/spark/languages","stargazers_url":"https://api.github.com/repos/DylanGuedes/spark/stargazers","contributors_url":"https://api.github.com/repos/DylanGuedes/spark/contributors","subscribers_url":"https://api.github.com/repos/DylanGuedes/spark/subscribers","subscription_url":"https://api.github.com/repos/DylanGuedes/spark/subscription","commits_url":"https://api.github.com/repos/DylanGuedes/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/DylanGuedes/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/DylanGuedes/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/DylanGuedes/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/DylanGuedes/spark/contents/{+path}","compare_url":"https://api.github.com/repos/DylanGuedes/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DylanGuedes/spark/merges","archive_url":"https://api.github.com/repos/DylanGuedes/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DylanGuedes/spark/downloads","issues_url":"https://api.github.com/repos/DylanGuedes/spark/issues{/number}","pulls_url":"https://api.github.com/repos/DylanGuedes/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/DylanGuedes/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/DylanGuedes/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DylanGuedes/spark/labels{/name}","releases_url":"https://api.github.com/repos/DylanGuedes/spark/releases{/id}","deployments_url":"https://api.github.com/repos/DylanGuedes/spark/deployments","created_at":"2017-04-27T16:15:33Z","updated_at":"2017-04-27T16:16:01Z","pushed_at":"2018-05-17T19:34:08Z","git_url":"git://github.com/DylanGuedes/spark.git","ssh_url":"git@github.com:DylanGuedes/spark.git","clone_url":"https://github.com/DylanGuedes/spark.git","svn_url":"https://github.com/DylanGuedes/spark","homepage":null,"size":267027,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8a837bf4f3f2758f7825d2362cf9de209026651a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-05-18T06:51:30Z","pushed_at":"2018-05-18T06:43:58Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":270565,"stargazers_count":17322,"watchers_count":17322,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15845,"mirror_url":null,"archived":false,"open_issues_count":537,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15845,"open_issues":537,"watchers":17322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21045"},"html":{"href":"https://github.com/apache/spark/pull/21045"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21045"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21045/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21045/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21045/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/be4f46d8f88fd7fc58c81b1471c547dcd0216aae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mgaido91"}}