{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/189210043","pull_request_review_id":121345636,"id":189210043,"diff_hunk":"@@ -1,9 +1,34 @@\n-import { createInstance } from 'i18next';\n+import i18next, { createInstance } from 'i18next';\n import { setI18n, getI18n } from 'react-i18next';\n+import enLocale from 'date-fns/locale/en';\n+import frLocale from 'date-fns/locale/fr';\n+import jaLocale from 'date-fns/locale/ja';\n \n export default function getDefaultT() {\n \treturn getI18n().t.bind(getI18n());\n }\n \n+export function getCurrentLanguage() {\n+\tif (!i18next.language) {\n+\t\treturn 'en';\n+\t}\n+\n+\treturn i18next.language;\n+}","path":"packages/components/src/translate.js","position":18,"original_position":18,"commit_id":"d3a5ed099590fbef1aba143d6c3a26e01977bad0","original_commit_id":"d3a5ed099590fbef1aba143d6c3a26e01977bad0","user":{"login":"nicomaligne","id":4653573,"avatar_url":"https://avatars1.githubusercontent.com/u/4653573?v=4","gravatar_id":"","url":"https://api.github.com/users/nicomaligne","html_url":"https://github.com/nicomaligne","followers_url":"https://api.github.com/users/nicomaligne/followers","following_url":"https://api.github.com/users/nicomaligne/following{/other_user}","gists_url":"https://api.github.com/users/nicomaligne/gists{/gist_id}","starred_url":"https://api.github.com/users/nicomaligne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicomaligne/subscriptions","organizations_url":"https://api.github.com/users/nicomaligne/orgs","repos_url":"https://api.github.com/users/nicomaligne/repos","events_url":"https://api.github.com/users/nicomaligne/events{/privacy}","received_events_url":"https://api.github.com/users/nicomaligne/received_events","type":"User","site_admin":false},"body":"Add some test ?","created_at":"2018-05-18T09:18:16Z","updated_at":"2018-05-18T09:18:44Z","html_url":"https://github.com/Talend/ui/pull/1355#discussion_r189210043","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/1355","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/189210043"},"html":{"href":"https://github.com/Talend/ui/pull/1355#discussion_r189210043"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/1355"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1355","id":188788716,"html_url":"https://github.com/Talend/ui/pull/1355","diff_url":"https://github.com/Talend/ui/pull/1355.diff","patch_url":"https://github.com/Talend/ui/pull/1355.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/1355","number":1355,"state":"open","locked":false,"title":"fix(Component): i18n on the cellDateTime component","user":{"login":"jare-talend","id":20772261,"avatar_url":"https://avatars2.githubusercontent.com/u/20772261?v=4","gravatar_id":"","url":"https://api.github.com/users/jare-talend","html_url":"https://github.com/jare-talend","followers_url":"https://api.github.com/users/jare-talend/followers","following_url":"https://api.github.com/users/jare-talend/following{/other_user}","gists_url":"https://api.github.com/users/jare-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/jare-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jare-talend/subscriptions","organizations_url":"https://api.github.com/users/jare-talend/orgs","repos_url":"https://api.github.com/users/jare-talend/repos","events_url":"https://api.github.com/users/jare-talend/events{/privacy}","received_events_url":"https://api.github.com/users/jare-talend/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\ncellDateTime component isn't translated (10 month ago,..)\r\n\r\n**What is the chosen solution to this problem?**\r\nimport the locale from date-fns to translate it\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n* [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n* [x] Tests for the changes have been added (for bug fixes / features) And [non reg](./screenshots.md) done before need review\r\n* [ ] Docs have been added / updated (for bug fixes / features)\r\n* [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- if the PR introduces a breaking change, add the description here. So when you merge this PR, add this description into the [breaking change wiki](https://github.com/Talend/ui/wiki/BREAKING-CHANGE) in the next version -->\r\n\r\n<!-- **Original Template** -->\r\n\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n","created_at":"2018-05-17T16:09:40Z","updated_at":"2018-05-18T09:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"199cd0420cea5c948b6bf4b69c1b3c12f6a6b565","assignee":{"login":"jare-talend","id":20772261,"avatar_url":"https://avatars2.githubusercontent.com/u/20772261?v=4","gravatar_id":"","url":"https://api.github.com/users/jare-talend","html_url":"https://github.com/jare-talend","followers_url":"https://api.github.com/users/jare-talend/followers","following_url":"https://api.github.com/users/jare-talend/following{/other_user}","gists_url":"https://api.github.com/users/jare-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/jare-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jare-talend/subscriptions","organizations_url":"https://api.github.com/users/jare-talend/orgs","repos_url":"https://api.github.com/users/jare-talend/repos","events_url":"https://api.github.com/users/jare-talend/events{/privacy}","received_events_url":"https://api.github.com/users/jare-talend/received_events","type":"User","site_admin":false},"assignees":[{"login":"jare-talend","id":20772261,"avatar_url":"https://avatars2.githubusercontent.com/u/20772261?v=4","gravatar_id":"","url":"https://api.github.com/users/jare-talend","html_url":"https://github.com/jare-talend","followers_url":"https://api.github.com/users/jare-talend/followers","following_url":"https://api.github.com/users/jare-talend/following{/other_user}","gists_url":"https://api.github.com/users/jare-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/jare-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jare-talend/subscriptions","organizations_url":"https://api.github.com/users/jare-talend/orgs","repos_url":"https://api.github.com/users/jare-talend/repos","events_url":"https://api.github.com/users/jare-talend/events{/privacy}","received_events_url":"https://api.github.com/users/jare-talend/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":520978449,"url":"https://api.github.com/repos/Talend/ui/labels/bug","name":"bug","color":"ee0701","default":true},{"id":521021722,"url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1355/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/d3a5ed099590fbef1aba143d6c3a26e01977bad0","head":{"label":"Talend:jare/fix/i18n-list-date-cell","ref":"jare/fix/i18n-list-date-cell","sha":"d3a5ed099590fbef1aba143d6c3a26e01977bad0","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-05-18T08:57:45Z","pushed_at":"2018-05-18T08:57:43Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":26735,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":48,"watchers":52,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"44185ab065ddcb89cee06e5d3d98562e64ca9194","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-05-18T08:57:45Z","pushed_at":"2018-05-18T08:57:43Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":26735,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":48,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/1355"},"html":{"href":"https://github.com/Talend/ui/pull/1355"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/1355"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/d3a5ed099590fbef1aba143d6c3a26e01977bad0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicomaligne"}}