{"push_id":2852837442,"size":41,"distinct_size":0,"ref":"refs/heads/release-3.11","head":"f2e6b3ed56aa114cd263369fd626d6b0e493e6ed","before":"ae7fe33afbf0bf3b19bf77b0ce26ffb4c98cfe11","commits":[{"sha":"1360f6203c416cb0f66d79a168b1dab0e78f43fb","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"tests/run: Make IAM role changes optional\n\nI'm not authorized to assume roles in the teamcoreservices account,\nand the assume-role call errors out with:\n\n  An error occurred (AccessDenied) when calling the AssumeRole\n  operation: Not authorized to perform sts:AssumeRole\n\nThat's fine though; I can still launch the cluster with my usual\naccess.  This commit makes the role assumption optional.  I've made\nsetting up the AWS_* access variables conditional on successful role\nassumption, because setting them based on an empty $RES wouldn't work\n;).\n\nUsing the && chain with a terminal || keeps the script from dying on\nthis assume-role failure.  From the 'set -e' docs [1]:\n\n  The shell does not exit if the command that fails is ... part of any\n  command executed in a && or || list except the command following the\n  final && or ||...\n\nI'm also only setting iamRoleName configs if assume-role succeeded.\nWe've been setting iamRoleName since the script landed in a2405e4d\n(run smoke tests with bash script, 2018-06-18,\ncoreos/tectonic-installer#3284) and possibly before that since\n82daae14 (tests: add etcd role, 2018-03-14,\ncoreos/tectonic-installer#3074).  I don't see anything in those\ncommits or PRs to motivate the iamRoleName entries, but I'd guess\nthey, like the tf-tectonic-installer role, are specific to the Jenkins\nsetup.  I've tied them together with CONFIGURE_AWS_ROLES based on that\nsimilarity, although in theory you may be able to toggle the\niamRoleName settings independently of assume-role success.\n\nEven though the &&/|| chain sets CONFIGURE_AWS_ROLES=False when\nassume-role failes, I'm using ${CONFIGURE_AWS_ROLES:-False} in the\nPython script.  That way, future versions of this script that support\nlibvirt (or other backends) won't need to bother setting\nCONFIGURE_AWS_ROLES and will still get valid Python here.  The :-\nsyntax is specified in [2], and my expansion defaults to False if\nCONFIGURE_AWS_ROLES is unset or empty.\n\n[1]: https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html\n[2]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/1360f6203c416cb0f66d79a168b1dab0e78f43fb"},{"sha":"0ad03ed8420917de0725c35d10c71a5f2d4e37a9","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"tests/run: Shift AWS_REGION config down to the AWS role setup\n\nThis collects our AWS configuration to make it easier to toggle it\non/off all of our AWS-specific stuff, which we'll need as we add\nsupport for libvirt (and potentially other smoke-test backends) in the\nfuture.\n\nI've also added an `aws configure get region` fallback, so the logic\nis:\n\n1. If the user has set AWS_REGION, use what they set.  Otherwise...\n2. If we can extract a region from the user's config (with\n   `aws configure get region`), use that.  Otherwise...\n3. Fall back to eu-west-1.\n\nStep 2 is new in this commit, and makes life a bit more convenient for\ncallers who have a preferred region (because they have their\npreference respected without having to bother setting `AWS_REGION`).\n\nThe ${parameter:-[word]} syntax is specified in [1].\n\n[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/0ad03ed8420917de0725c35d10c71a5f2d4e37a9"},{"sha":"01339127e818a6514eb111064c5d0a3c736f9bf8","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"hack: Add :z to --volume mounts\n\nLike we did in bootkube.sh in 0fa4eb13 (Fix perm errors with selinux\nenabled, 2018-08-15, #134).  This gives us permission to access the\nmounted volume when SELinux is enabled (docs in [1]).\n\nI've also normalized these invocations for consistency between the\nvarious hack/ scripts:\n\n* Adding slash separators to put each option on its own line,\n  excepting the final command being run in the container.  This makes\n  the long commands slightly easier to skim.  It will also make it\n  easier to track down motivation for an option with 'git blame',\n  because commits touching options on other lines won't clutter the\n  blame.\n\n* Use long-form options (-v -> --volume, etc.).  This makes the\n  options a bit more accessible to newcomers, and now that each option\n  is on it's own line we have plenty of space.\n\n* Dropped single quotes from 'TRUE'.  There are no shell-sensitive\n  characters in TRUE, so there's no need to quote it.\n\n* Use ${PWD} consistently.  It's in POSIX [2], so there's no need to\n  execute a pwd process to get this value.\n\n* Drop -t.  None of these commands should need a pseudoterminal.\n\n* Drop explicit rw --volume options.  They're the default [3].\n\n[1]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L628\n[2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03\n[3]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L646","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/01339127e818a6514eb111064c5d0a3c736f9bf8"},{"sha":"4ba649b150219f8da550a314c171bcdd32f58865","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"hack: Drop /tmp mounts\n\nEric points out potential issues with relabeling /tmp [1], which is\nshared by several system-level consumers.\n\nFor the Bazel script, the /tmp mount is just since c483f597 (Move\nbazel build tarball test to prow, 2018-08-08, #117), so we can drop it\nto return to our previous approach.\n\nThe Terraform container seems to run fine without /tmp as well,\nalthough there's no clear history to point to on this front because we\nused to use Bazel for this.  See b8a9bbc5 (Remove bazel from test\nprocess, 2018-08-01, #97).\n\n[1]: https://github.com/openshift/installer/pull/174#discussion_r212764528","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/4ba649b150219f8da550a314c171bcdd32f58865"},{"sha":"a480782bc568eca3b906a781a5839e14f818998e","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"*: Replace '$(pwd)' with '${PWD}'\n\nPWD is in POSIX [1], so there's no need to execute a pwd process to\nget this value.  This fixes everthing found by:\n\n  $ git grep '\\(pwd\\)'\n\nexcept for hack/*.sh, which is being addressed by [2].\n\nI'm using $PWD instead of ${PWD} in the module files to avoid them\nbeing interpolated [3] on template rendering [4].\n\n[1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03\n[2]: https://github.com/openshift/installer/pull/174\n[3]: https://www.terraform.io/docs/configuration/interpolation.html\n[4]: https://www.terraform.io/docs/providers/template/d/file.html","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/a480782bc568eca3b906a781a5839e14f818998e"},{"sha":"e6535009202d5a73a85b59f958afd3859b1ae0ce","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"modules/bootkube/resources/bootkube.sh: Fix SC2034 for the signer ID\n\nSC2034 is \"appears unused\" [1].  ShellCheck was complaining because it\ndoesn't understand the $$ used to escape Terraform interpolation\n[2,3].  By dropping the braces and using $SIGNER, we get something\nthat ShellCheck understands and which Terraform's interpolation\nignores.  We can also enable SC2154 (referenced, but not assigned [4])\nwhen consuming $SIGNER.\n\nI've also enabled SC1083 (missing quoted [5]) now that I'm quoting\n$SIGNER on consumption.\n\n[1]: https://github.com/koalaman/shellcheck/blob/v0.5.0/src/ShellCheck/Analytics.hs#L1840-L1842\n[2]: https://www.terraform.io/docs/configuration/interpolation.html\n[3]: https://www.terraform.io/docs/providers/template/d/file.html\n[4]: https://github.com/koalaman/shellcheck/blob/v0.5.0/src/ShellCheck/Analytics.hs#L1915-L1917\n[5]: https://github.com/koalaman/shellcheck/blob/v0.5.0/src/ShellCheck/Parser.hs#L1022-L1023","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/e6535009202d5a73a85b59f958afd3859b1ae0ce"},{"sha":"da6286fb5292ebc73f31712a0b509ebf78f164fc","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"vendor: Update vendor for installconfig generation.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/da6286fb5292ebc73f31712a0b509ebf78f164fc"},{"sha":"dea396879c8c668d5d2e13f02273ec2f687d8d91","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"kubeconfig: Add asset generation for kubeconfigs\n\nGenerate kubeconfig and kubeconfig-kubelet based on tls assets\nand install config.\n\nAdded a Kubeconfig type to implement asset.Asset interface.\n\nKubeconfig type generates the admin kubeconfig and the short-lived\nkubelet kubeconfig based on tls assets and installconfig.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/dea396879c8c668d5d2e13f02273ec2f687d8d91"},{"sha":"a343bc3fa719a5ff03906bb9975f8eb80cd3308e","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"kubeconfig: Add tests for kubeconfig generation.\n\nAdd some tests to verify that kubeconfig asset will generate the\nexpected assets both in-memory and on-disk, also verify that it\nwill error out when the dependencies are not satisfied in parents.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/a343bc3fa719a5ff03906bb9975f8eb80cd3308e"},{"sha":"fc954ecf7e821eedb13cb75fefe2d931309483f8","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"tls: Export key and cert filenames in the tls package.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/fc954ecf7e821eedb13cb75fefe2d931309483f8"},{"sha":"dfd7deb6a7da7616433c809fdc051fc3a07a3119","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"graph: Update the dependency graph.\n\nRename \"kubeconfig\" to \"kubeconfig_admin\", and \"kubelet_kubeconfig\" to\n\"kubeconfig_kubelet\".","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/dfd7deb6a7da7616433c809fdc051fc3a07a3119"},{"sha":"30c6491fc620e42d95351aed09827ecd10c79c1c","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"modules/aws/vpc/vpc-public: Tag NAT gateways\n\nThis landed without tags in 3616172c (Working prototype for AWS with\nautoscaling groups, 2017-02-28).  We grew more tagging in this file in\n9c27ef31 (modules/aws: enforce tectonicClusterID tag on resources,\n2017-05-22, coreos/tectonic-installer#776) and e297548f\n(modules/aws/vpc/vpc-public: Tag new EIPs with tectonicClusterID,\n2018-07-26, #78), but hadn't got the NAT gateways tagged yet.\n\nDocs for aws_nat_gateway's tags property are in [1].\n\n[1]: https://www.terraform.io/docs/providers/aws/r/nat_gateway.html#tags\n\nReported-by: Joel Diaz <jdiaz@redhat.com>","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/30c6491fc620e42d95351aed09827ecd10c79c1c"},{"sha":"8b785fe85dc24ce9fbeb124941d77e3f9472da06","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #192 from wking/pwd-process-to-env-var\n\n*: Replace '$(pwd)' with '${PWD}'","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/8b785fe85dc24ce9fbeb124941d77e3f9472da06"},{"sha":"7eb413ece8ebd257a7a6ecb54e810a8b03835754","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #193 from wking/bootkube-shellcheck-2034\n\nmodules/bootkube/resources/bootkube.sh: Fix SC2034 for the signer ID","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/7eb413ece8ebd257a7a6ecb54e810a8b03835754"},{"sha":"1823ec269d235ff5e99688f57486f937999cab79","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #195 from wking/tag-nat-gateways\n\nmodules/aws/vpc/vpc-public: Tag NAT gateways","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/1823ec269d235ff5e99688f57486f937999cab79"},{"sha":"62f87acb46a92b43b28917524ef12d7c3357639d","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"OWNERS_ALIASES: Define aliases for reviewers and approvers\n\nThis will make it easier to add special-case OWNERS files to\nopenshift/release while still getting the members slurped up with the\npopulate-owners tooling.  That tooling pulls OWNERS_ALIASES since\nopenshift/release@e1f993fb (populate-owners: Also slurp\nOWNERS_ALIASES, 2018-08-25, openshift/release#1285).","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/62f87acb46a92b43b28917524ef12d7c3357639d"},{"sha":"4a32f5298b04edc579525a5742329e9749e24222","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #160 from yifan-gu/generate_kubeconfig\n\nasset: Add asset generation for kubeconfigs","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/4a32f5298b04edc579525a5742329e9749e24222"},{"sha":"1489bf55572efe90a45a3169474f2df9b1a09863","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"*: Drop the Tectonic license\n\nRed Hat no longer requires a Tectonic license now that this installer\nis being used to launch OpenShift clusters.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/1489bf55572efe90a45a3169474f2df9b1a09863"},{"sha":"2344af17ff000dc1a0a824c6ec2875cf088f0558","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"Documentation/design/resource_dep: Drop the Tectonic license\n\nRegenerate with:\n\n  $ dot -Tsvg Documentation/design/resource_dep.dot >Documentation/design/resource_dep.svg\n  $ dot -V\n  dot - graphviz version 2.30.1 (20170916.1124)","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/2344af17ff000dc1a0a824c6ec2875cf088f0558"},{"sha":"345d8431890f6c9f5e2643841ccf888226a69192","author":{"name":"Yifan Gu","email":"8bb630cb819df855a836d85a765ad9b9fc21612a@coreos.com"},"message":"asset: Only persistent data to disk for targetable assets.\n\nOnly assets that will be fetched by the command line will be written\nto the disk.","distinct":false,"url":"https://api.github.com/repos/openshift/installer/commits/345d8431890f6c9f5e2643841ccf888226a69192"}]}
{"actor":{"display_login":"smarterclayton"}}