{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/comments/209366636","pull_request_review_id":145375700,"id":209366636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM2NjYzNg==","diff_hunk":"@@ -86,37 +90,38 @@\n \t\t<property>${project.parent.artifactId}.openempi.globalIdentifierDomainId</property>\n \t\t<defaultValue></defaultValue>\n \t\t<description>\n-\t\t\tSpecifies main identifier on MPI server (e.g. \"xyz\" for OpenEMPI)\n+\t\t\tSpecifies main identifier on MPI server (e.g. \"xyz\" for OpenEMPI) (GSOC OpenEMPI Specific Implementation)\n \t\t</description>\n \t</globalProperty>\n \n \t<globalProperty>\n \t\t<property>${project.parent.artifactId}.mpi.implementation</property>\n-\t\t<defaultValue></defaultValue>\n+\t\t<defaultValue>registrationcore.mpi.implementation.PixPdq</defaultValue>\n \t\t<description>\n-\t\t\tWhich MPI to should we connect to? Specify a Spring bean name, or leave blank to disable MPI integration\n+\t\t\tWhich MPI to should we connect to? Specify a Spring bean name, or leave blank to disable MPI integration. Options include:\n+\t\t\t\"registrationcore.mpi.implementation.PixPdq\", \"registrationcore.mpi.implementation.OpenEMPI\".","path":"omod/src/main/resources/config.xml","position":16,"original_position":39,"commit_id":"a97068b0a6eb19e2fac070d277fb2d82d013ebd0","original_commit_id":"bc5fc51aa07e64e27321484284a871b0d6d1118f","user":{"login":"wluyima","id":1395907,"node_id":"MDQ6VXNlcjEzOTU5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1395907?v=4","gravatar_id":"","url":"https://api.github.com/users/wluyima","html_url":"https://github.com/wluyima","followers_url":"https://api.github.com/users/wluyima/followers","following_url":"https://api.github.com/users/wluyima/following{/other_user}","gists_url":"https://api.github.com/users/wluyima/gists{/gist_id}","starred_url":"https://api.github.com/users/wluyima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wluyima/subscriptions","organizations_url":"https://api.github.com/users/wluyima/orgs","repos_url":"https://api.github.com/users/wluyima/repos","events_url":"https://api.github.com/users/wluyima/events{/privacy}","received_events_url":"https://api.github.com/users/wluyima/received_events","type":"User","site_admin":false},"body":"PIXPDQ is the profile and OpenEMPI implements this profile, so there should be no such thing as a PIXPDQ and OpenMPI implementation because one is already the other anyways, does this make sense?\r\n\r\nIf this was done in a branch as part of GSoC, is there any release that was made off this branch? If not, which I guess is the case, then nobody can be dependent on it in the first place.","created_at":"2018-08-10T19:45:49Z","updated_at":"2018-08-10T19:45:49Z","html_url":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20#discussion_r209366636","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/comments/209366636"},"html":{"href":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20#discussion_r209366636"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20"}},"in_reply_to_id":206703997},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20","id":203341243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzQxMjQz","html_url":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20","diff_url":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20.diff","patch_url":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/20","number":20,"state":"open","locked":false,"title":"Integrating MPI Functionality","user":{"login":"shaoyuancc","id":22423519,"node_id":"MDQ6VXNlcjIyNDIzNTE5","avatar_url":"https://avatars2.githubusercontent.com/u/22423519?v=4","gravatar_id":"","url":"https://api.github.com/users/shaoyuancc","html_url":"https://github.com/shaoyuancc","followers_url":"https://api.github.com/users/shaoyuancc/followers","following_url":"https://api.github.com/users/shaoyuancc/following{/other_user}","gists_url":"https://api.github.com/users/shaoyuancc/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoyuancc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoyuancc/subscriptions","organizations_url":"https://api.github.com/users/shaoyuancc/orgs","repos_url":"https://api.github.com/users/shaoyuancc/repos","events_url":"https://api.github.com/users/shaoyuancc/events{/privacy}","received_events_url":"https://api.github.com/users/shaoyuancc/received_events","type":"User","site_admin":false},"body":"Hi All,\r\n\r\nThis merge is meant to bring in MPI functionality primarily developed by SolDevelo for iSantePlus back into the master branch. \r\n\r\nMuch of the discussion is recorded here: https://talk.openmrs.org/t/integration-with-openempi/11535/45\r\n\r\nJira Ticket: https://issues.openmrs.org/projects/RC/issues/RC-29\r\n\r\nThe commit is far from perfect, but it should not break anything and we have tested basic functionality such as registering a patient, updating a patient and importing a patient.","created_at":"2018-07-23T20:56:24Z","updated_at":"2018-08-10T19:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7654b31a905fea29cabcaba6ad1b7746ee35d42c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/20/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/statuses/a97068b0a6eb19e2fac070d277fb2d82d013ebd0","head":{"label":"shaoyuancc:master","ref":"master","sha":"a97068b0a6eb19e2fac070d277fb2d82d013ebd0","user":{"login":"shaoyuancc","id":22423519,"node_id":"MDQ6VXNlcjIyNDIzNTE5","avatar_url":"https://avatars2.githubusercontent.com/u/22423519?v=4","gravatar_id":"","url":"https://api.github.com/users/shaoyuancc","html_url":"https://github.com/shaoyuancc","followers_url":"https://api.github.com/users/shaoyuancc/followers","following_url":"https://api.github.com/users/shaoyuancc/following{/other_user}","gists_url":"https://api.github.com/users/shaoyuancc/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoyuancc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoyuancc/subscriptions","organizations_url":"https://api.github.com/users/shaoyuancc/orgs","repos_url":"https://api.github.com/users/shaoyuancc/repos","events_url":"https://api.github.com/users/shaoyuancc/events{/privacy}","received_events_url":"https://api.github.com/users/shaoyuancc/received_events","type":"User","site_admin":false},"repo":{"id":136983393,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5ODMzOTM=","name":"openmrs-module-registrationcore","full_name":"shaoyuancc/openmrs-module-registrationcore","owner":{"login":"shaoyuancc","id":22423519,"node_id":"MDQ6VXNlcjIyNDIzNTE5","avatar_url":"https://avatars2.githubusercontent.com/u/22423519?v=4","gravatar_id":"","url":"https://api.github.com/users/shaoyuancc","html_url":"https://github.com/shaoyuancc","followers_url":"https://api.github.com/users/shaoyuancc/followers","following_url":"https://api.github.com/users/shaoyuancc/following{/other_user}","gists_url":"https://api.github.com/users/shaoyuancc/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoyuancc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoyuancc/subscriptions","organizations_url":"https://api.github.com/users/shaoyuancc/orgs","repos_url":"https://api.github.com/users/shaoyuancc/repos","events_url":"https://api.github.com/users/shaoyuancc/events{/privacy}","received_events_url":"https://api.github.com/users/shaoyuancc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaoyuancc/openmrs-module-registrationcore","description":"Provides registration utilities and services for other modules to use.","fork":true,"url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore","forks_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/forks","keys_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/teams","hooks_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/hooks","issue_events_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/issues/events{/number}","events_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/events","assignees_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/assignees{/user}","branches_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/branches{/branch}","tags_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/tags","blobs_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/statuses/{sha}","languages_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/languages","stargazers_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/stargazers","contributors_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/contributors","subscribers_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/subscribers","subscription_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/subscription","commits_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/contents/{+path}","compare_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/merges","archive_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/downloads","issues_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/issues{/number}","pulls_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/pulls{/number}","milestones_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/milestones{/number}","notifications_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/labels{/name}","releases_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/releases{/id}","deployments_url":"https://api.github.com/repos/shaoyuancc/openmrs-module-registrationcore/deployments","created_at":"2018-06-11T21:34:24Z","updated_at":"2018-08-09T22:27:59Z","pushed_at":"2018-08-09T22:27:57Z","git_url":"git://github.com/shaoyuancc/openmrs-module-registrationcore.git","ssh_url":"git@github.com:shaoyuancc/openmrs-module-registrationcore.git","clone_url":"https://github.com/shaoyuancc/openmrs-module-registrationcore.git","svn_url":"https://github.com/shaoyuancc/openmrs-module-registrationcore","homepage":null,"size":1066,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"e7d2d6b773adc462899b7c1bccac87f0e69aa321","user":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":7151216,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUxMjE2","name":"openmrs-module-registrationcore","full_name":"openmrs/openmrs-module-registrationcore","owner":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-registrationcore","description":"Provides registration utilities and services for other modules to use.","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/deployments","created_at":"2012-12-13T16:17:23Z","updated_at":"2016-11-24T14:54:32Z","pushed_at":"2018-08-09T22:27:59Z","git_url":"git://github.com/openmrs/openmrs-module-registrationcore.git","ssh_url":"git@github.com:openmrs/openmrs-module-registrationcore.git","clone_url":"https://github.com/openmrs/openmrs-module-registrationcore.git","svn_url":"https://github.com/openmrs/openmrs-module-registrationcore","homepage":null,"size":636,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":36,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20"},"html":{"href":"https://github.com/openmrs/openmrs-module-registrationcore/pull/20"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/20"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-registrationcore/statuses/a97068b0a6eb19e2fac070d277fb2d82d013ebd0"}},"author_association":"NONE"}}
{"actor":{"display_login":"wluyima"}}