{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/191941296","pull_request_review_id":124615242,"id":191941296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTk0MTI5Ng==","diff_hunk":"@@ -789,31 +789,40 @@ include metadata about the response.\n }\n ```\n \n-The executed command is expected to print an `ExceCredential` to `stdout`. `k8s.io/client-go`\n-will then use the returned bearer token in the `status` when authenticating against the\n+The executed command is expected to print an `ExceCredential` to `stdout`.\n+`k8s.io/client-go` will then use the returned bearer token and/or client TLS\n+key and certificate from the `status` field when authenticating against the\n Kubernetes API.\n \n+TLS credentials and bearer token are not mutually exclusive. Output with only\n+`clientCertificateData` or only `clientKeyData` is an error.\n+\n ```json\n {\n   \"apiVersion\": \"client.authentication.k8s.io/v1alpha1\",\n   \"kind\": \"ExecCredential\",\n   \"status\": {\n     \"token\": \"my-bearer-token\"\n+    \"clientCertificateData\": \"certificate PEM blob\",","path":"content/en/docs/reference/access-authn-authz/authentication.md","position":20,"original_position":20,"commit_id":"1befe4d91be884e5aeb34174c2692d412a793b67","original_commit_id":"1befe4d91be884e5aeb34174c2692d412a793b67","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"make the examples look like\r\n```json\r\n\"clientCertificateData\":\"-----BEGIN CERTIFICATE-----\\n...\\n-----END CERTIFICATE-----\",\r\n\"clientKeyData\":\"-----BEGIN RSA PRIVATE KEY-----\\n...\\n-----END RSA PRIVATE KEY-----\"\r\n```\r\nto make it clear how the content is passed/encoded","created_at":"2018-05-30T22:22:25Z","updated_at":"2018-05-30T22:22:25Z","html_url":"https://github.com/kubernetes/website/pull/8826#discussion_r191941296","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/8826","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/191941296"},"html":{"href":"https://github.com/kubernetes/website/pull/8826#discussion_r191941296"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/8826"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/8826","id":191595578,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTk1NTc4","html_url":"https://github.com/kubernetes/website/pull/8826","diff_url":"https://github.com/kubernetes/website/pull/8826.diff","patch_url":"https://github.com/kubernetes/website/pull/8826.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/8826","number":8826,"state":"open","locked":false,"title":"Update exec plugin docs with TLS credentials","user":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"body":"kubernetes/kubernetes#61803 implements TLS client credential support for\r\n1.11.\r\n","created_at":"2018-05-30T22:13:19Z","updated_at":"2018-05-30T22:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d489d9d1ea9310d6004640a524fb9a23a2276c7b","assignee":{"login":"mistyhacks","id":7674613,"node_id":"MDQ6VXNlcjc2NzQ2MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7674613?v=4","gravatar_id":"","url":"https://api.github.com/users/mistyhacks","html_url":"https://github.com/mistyhacks","followers_url":"https://api.github.com/users/mistyhacks/followers","following_url":"https://api.github.com/users/mistyhacks/following{/other_user}","gists_url":"https://api.github.com/users/mistyhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/mistyhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistyhacks/subscriptions","organizations_url":"https://api.github.com/users/mistyhacks/orgs","repos_url":"https://api.github.com/users/mistyhacks/repos","events_url":"https://api.github.com/users/mistyhacks/events{/privacy}","received_events_url":"https://api.github.com/users/mistyhacks/received_events","type":"User","site_admin":false},"assignees":[{"login":"mistyhacks","id":7674613,"node_id":"MDQ6VXNlcjc2NzQ2MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7674613?v=4","gravatar_id":"","url":"https://api.github.com/users/mistyhacks","html_url":"https://github.com/mistyhacks","followers_url":"https://api.github.com/users/mistyhacks/followers","following_url":"https://api.github.com/users/mistyhacks/following{/other_user}","gists_url":"https://api.github.com/users/mistyhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/mistyhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistyhacks/subscriptions","organizations_url":"https://api.github.com/users/mistyhacks/orgs","repos_url":"https://api.github.com/users/mistyhacks/repos","events_url":"https://api.github.com/users/mistyhacks/events{/privacy}","received_events_url":"https://api.github.com/users/mistyhacks/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676075266,"node_id":"MDU6TGFiZWw2NzYwNzUyNjY=","url":"https://api.github.com/repos/kubernetes/website/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/8826/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/8826/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/8826/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/1befe4d91be884e5aeb34174c2692d412a793b67","head":{"label":"awly:exec-plugin-tls-credentials","ref":"exec-plugin-tls-credentials","sha":"1befe4d91be884e5aeb34174c2692d412a793b67","user":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"repo":{"id":135501670,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1MDE2NzA=","name":"website","full_name":"awly/website","owner":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awly/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/awly/website","forks_url":"https://api.github.com/repos/awly/website/forks","keys_url":"https://api.github.com/repos/awly/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awly/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awly/website/teams","hooks_url":"https://api.github.com/repos/awly/website/hooks","issue_events_url":"https://api.github.com/repos/awly/website/issues/events{/number}","events_url":"https://api.github.com/repos/awly/website/events","assignees_url":"https://api.github.com/repos/awly/website/assignees{/user}","branches_url":"https://api.github.com/repos/awly/website/branches{/branch}","tags_url":"https://api.github.com/repos/awly/website/tags","blobs_url":"https://api.github.com/repos/awly/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awly/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awly/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/awly/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awly/website/statuses/{sha}","languages_url":"https://api.github.com/repos/awly/website/languages","stargazers_url":"https://api.github.com/repos/awly/website/stargazers","contributors_url":"https://api.github.com/repos/awly/website/contributors","subscribers_url":"https://api.github.com/repos/awly/website/subscribers","subscription_url":"https://api.github.com/repos/awly/website/subscription","commits_url":"https://api.github.com/repos/awly/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/awly/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/awly/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/awly/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/awly/website/contents/{+path}","compare_url":"https://api.github.com/repos/awly/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awly/website/merges","archive_url":"https://api.github.com/repos/awly/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awly/website/downloads","issues_url":"https://api.github.com/repos/awly/website/issues{/number}","pulls_url":"https://api.github.com/repos/awly/website/pulls{/number}","milestones_url":"https://api.github.com/repos/awly/website/milestones{/number}","notifications_url":"https://api.github.com/repos/awly/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awly/website/labels{/name}","releases_url":"https://api.github.com/repos/awly/website/releases{/id}","deployments_url":"https://api.github.com/repos/awly/website/deployments","created_at":"2018-05-30T21:58:34Z","updated_at":"2018-05-30T21:58:42Z","pushed_at":"2018-05-30T22:11:59Z","git_url":"git://github.com/awly/website.git","ssh_url":"git@github.com:awly/website.git","clone_url":"https://github.com/awly/website.git","svn_url":"https://github.com/awly/website","homepage":"https://kubernetes.io","size":127457,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:release-1.11","ref":"release-1.11","sha":"6029cc3adfe1681f9adf5506efd96e508617683b","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2018-05-30T15:59:14Z","pushed_at":"2018-05-30T22:13:20Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":127457,"stargazers_count":506,"watchers_count":506,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2610,"mirror_url":null,"archived":false,"open_issues_count":457,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":2610,"open_issues":457,"watchers":506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/8826"},"html":{"href":"https://github.com/kubernetes/website/pull/8826"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/8826"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/8826/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/8826/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/8826/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/1befe4d91be884e5aeb34174c2692d412a793b67"}},"author_association":"NONE"}}
{"actor":{"display_login":"liggitt"}}