{"action":"created","issue":{"url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/458","repository_url":"https://api.github.com/repos/camptocamp/pyramid_oereb","labels_url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/458/comments","events_url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/458/events","html_url":"https://github.com/camptocamp/pyramid_oereb/issues/458","id":296664125,"number":458,"title":"About all the rounding of values","user":{"login":"vvmruder","id":3714179,"avatar_url":"https://avatars3.githubusercontent.com/u/3714179?v=4","gravatar_id":"","url":"https://api.github.com/users/vvmruder","html_url":"https://github.com/vvmruder","followers_url":"https://api.github.com/users/vvmruder/followers","following_url":"https://api.github.com/users/vvmruder/following{/other_user}","gists_url":"https://api.github.com/users/vvmruder/gists{/gist_id}","starred_url":"https://api.github.com/users/vvmruder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvmruder/subscriptions","organizations_url":"https://api.github.com/users/vvmruder/orgs","repos_url":"https://api.github.com/users/vvmruder/repos","events_url":"https://api.github.com/users/vvmruder/events{/privacy}","received_events_url":"https://api.github.com/users/vvmruder/received_events","type":"User","site_admin":false},"labels":[{"id":529138878,"url":"https://api.github.com/repos/camptocamp/pyramid_oereb/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-13T09:18:32Z","updated_at":"2018-02-15T12:50:11Z","closed_at":null,"author_association":"COLLABORATOR","body":"I want to summarize what my idea/opinion is about what we have in the moment: Its an chaos...\r\n\r\nAfter I had a detailed look on what goes on in the different places of the application I came to the point that we need to fix this centrally.\r\n\r\nWhat am I talking about?\r\nThe calculated values in the extract for every PLR. We calculate the values inside the application. We rely on the configured settings for precision. We pass the values through the renderers to produce the DataExtract in whether JSON or XML. Later in clients like PDF/dynamic client we sum up the different values and ROUND again. This shouldn't be. We need to clean this up. The clients shouldnt change anything on the values. Only summarize them is ok.\r\nOtherwise Iam afraid, we wont get any straight logic in this system :(\r\n\r\nI reference on the issues: #379, #350 an PR #445\r\n\r\n@voisardf @kdeininger @jwkaltz @sbrunner @ger-benjamin \r\nWhat are the other opinions?\r\n\r\n- [ ] fix int parsing in https://github.com/camptocamp/pyramid_oereb/blob/master/pyramid_oereb/contrib/print_proxy/mapfish_print.py#L354"},"comment":{"url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/comments/365917960","html_url":"https://github.com/camptocamp/pyramid_oereb/issues/458#issuecomment-365917960","issue_url":"https://api.github.com/repos/camptocamp/pyramid_oereb/issues/458","id":365917960,"user":{"login":"kdeininger","id":5467596,"avatar_url":"https://avatars3.githubusercontent.com/u/5467596?v=4","gravatar_id":"","url":"https://api.github.com/users/kdeininger","html_url":"https://github.com/kdeininger","followers_url":"https://api.github.com/users/kdeininger/followers","following_url":"https://api.github.com/users/kdeininger/following{/other_user}","gists_url":"https://api.github.com/users/kdeininger/gists{/gist_id}","starred_url":"https://api.github.com/users/kdeininger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdeininger/subscriptions","organizations_url":"https://api.github.com/users/kdeininger/orgs","repos_url":"https://api.github.com/users/kdeininger/repos","events_url":"https://api.github.com/users/kdeininger/events{/privacy}","received_events_url":"https://api.github.com/users/kdeininger/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T12:50:11Z","updated_at":"2018-02-15T12:50:11Z","author_association":"COLLABORATOR","body":"The land registry area is passed as string to Mapfish Print:\r\nhttps://github.com/camptocamp/pyramid_oereb/blob/d7b6dacd605b9979afc22950c4ebfbc217e4a9f8/print/print-apps/oereb/config.yaml#L68\r\nhttps://github.com/camptocamp/pyramid_oereb/blob/d7b6dacd605b9979afc22950c4ebfbc217e4a9f8/print/print-apps/oereb/mainpage.jrxml#L33\r\n\r\nThis should be changed to integer."}}
{"actor":{"display_login":"kdeininger"}}