{"action":"opened","issue":{"url":"https://api.github.com/repos/hardmaru/WorldModelsExperiments/issues/13","repository_url":"https://api.github.com/repos/hardmaru/WorldModelsExperiments","labels_url":"https://api.github.com/repos/hardmaru/WorldModelsExperiments/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/hardmaru/WorldModelsExperiments/issues/13/comments","events_url":"https://api.github.com/repos/hardmaru/WorldModelsExperiments/issues/13/events","html_url":"https://github.com/hardmaru/WorldModelsExperiments/issues/13","id":394050990,"node_id":"MDU6SXNzdWUzOTQwNTA5OTA=","number":13,"title":"Memory leak and potential fix","user":{"login":"davidsandberg","id":15169058,"node_id":"MDQ6VXNlcjE1MTY5MDU4","avatar_url":"https://avatars0.githubusercontent.com/u/15169058?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsandberg","html_url":"https://github.com/davidsandberg","followers_url":"https://api.github.com/users/davidsandberg/followers","following_url":"https://api.github.com/users/davidsandberg/following{/other_user}","gists_url":"https://api.github.com/users/davidsandberg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsandberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsandberg/subscriptions","organizations_url":"https://api.github.com/users/davidsandberg/orgs","repos_url":"https://api.github.com/users/davidsandberg/repos","events_url":"https://api.github.com/users/davidsandberg/events{/privacy}","received_events_url":"https://api.github.com/users/davidsandberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-25T21:41:26Z","updated_at":"2018-12-25T21:41:26Z","closed_at":null,"author_association":"NONE","body":"Hi @hardmaru!\r\nThanks for a great repo and a really cool project!!\r\nI was running the 'carracing' experiment but experienced memory problems. This was caused by new tensorflow assign operations being created every time set_model_params (in rnn.py and vae.py). \r\nI implemented a fix where the assign operations were created when the graph was built and used when setting the parameters.\r\nIf you are interested in a fix I can make a PR, or you simply just copy and paste the fix from [here](https://github.com/davidsandberg/WorldModelsExperiments/compare/c31e8d84bcfdbebf12513ccdef9800d20477542d...e759ffc140925b324b6fac28f9e23cc1789709bc) (look at the diffs in rnn.py and vae.py)."}}
{"actor":{"display_login":"davidsandberg"}}