{"action":"created","comment":{"url":"https://api.github.com/repos/Nordstrom/artillery/pulls/comments/194927250","pull_request_review_id":128194170,"id":194927250,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDkyNzI1MA==","diff_hunk":"@@ -144,25 +144,27 @@ function run(targetScript, options) {\n         report.phases = _.get(script, 'config.phases', []);\n \n         if (options.output) {\n-          let logfile = getLogFilename(\n-            options.output,\n-            defaultOptions.logFilenameFormat\n-          );\n-          if (!options.quiet) {\n-            console.log('Log file: %s', logfile);\n+          const output = {\n+            aggregate: report,\n+            intermediate: intermediates\n+          }\n+\n+          if (_.isString(options.output)) {","path":"lib/commands/run.js","position":39,"original_position":15,"commit_id":"1d898ea8371f88d4dc0dd1ed278a0e2b2c3cc622","original_commit_id":"1d898ea8371f88d4dc0dd1ed278a0e2b2c3cc622","user":{"login":"gwsii","id":1920378,"node_id":"MDQ6VXNlcjE5MjAzNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1920378?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false},"body":"Previous logic presumed all truthy values were strings. Not clear how to properly process booleans, numbers or objects in the alternative case. Any suggestions? ","created_at":"2018-06-13T00:32:21Z","updated_at":"2018-06-13T00:32:21Z","html_url":"https://github.com/Nordstrom/artillery/pull/1#discussion_r194927250","pull_request_url":"https://api.github.com/repos/Nordstrom/artillery/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/comments/194927250"},"html":{"href":"https://github.com/Nordstrom/artillery/pull/1#discussion_r194927250"},"pull_request":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/1"}},"in_reply_to_id":194925731},"pull_request":{"url":"https://api.github.com/repos/Nordstrom/artillery/pulls/1","id":192158164,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTU4MTY0","html_url":"https://github.com/Nordstrom/artillery/pull/1","diff_url":"https://github.com/Nordstrom/artillery/pull/1.diff","patch_url":"https://github.com/Nordstrom/artillery/pull/1.patch","issue_url":"https://api.github.com/repos/Nordstrom/artillery/issues/1","number":1,"state":"open","locked":false,"title":"Enable passing pre-parsed script object to run command.","user":{"login":"gwsii","id":1920378,"node_id":"MDQ6VXNlcjE5MjAzNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1920378?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false},"body":"Creating this PR for discussion purposes: the real deal will happen over in the shoreditch-ops repo.","created_at":"2018-06-01T22:40:22Z","updated_at":"2018-06-13T00:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebd5d8fd4f5d9a1b6f8ed15d71adbcd1e3ae3849","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nordstrom/artillery/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Nordstrom/artillery/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Nordstrom/artillery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nordstrom/artillery/issues/1/comments","statuses_url":"https://api.github.com/repos/Nordstrom/artillery/statuses/1d898ea8371f88d4dc0dd1ed278a0e2b2c3cc622","head":{"label":"Nordstrom:script-as-object","ref":"script-as-object","sha":"1d898ea8371f88d4dc0dd1ed278a0e2b2c3cc622","user":{"login":"Nordstrom","id":2488485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"repo":{"id":135760037,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjAwMzc=","name":"artillery","full_name":"Nordstrom/artillery","owner":{"login":"Nordstrom","id":2488485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nordstrom/artillery","description":"Flexible and powerful toolkit for load and functional testing. HTTP, Socket.io, WebSockets, Kinesis - you bring it, Artillery will blast it! Make your systems indestructible! 👩‍💻 🏰","fork":true,"url":"https://api.github.com/repos/Nordstrom/artillery","forks_url":"https://api.github.com/repos/Nordstrom/artillery/forks","keys_url":"https://api.github.com/repos/Nordstrom/artillery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nordstrom/artillery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nordstrom/artillery/teams","hooks_url":"https://api.github.com/repos/Nordstrom/artillery/hooks","issue_events_url":"https://api.github.com/repos/Nordstrom/artillery/issues/events{/number}","events_url":"https://api.github.com/repos/Nordstrom/artillery/events","assignees_url":"https://api.github.com/repos/Nordstrom/artillery/assignees{/user}","branches_url":"https://api.github.com/repos/Nordstrom/artillery/branches{/branch}","tags_url":"https://api.github.com/repos/Nordstrom/artillery/tags","blobs_url":"https://api.github.com/repos/Nordstrom/artillery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nordstrom/artillery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nordstrom/artillery/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nordstrom/artillery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nordstrom/artillery/statuses/{sha}","languages_url":"https://api.github.com/repos/Nordstrom/artillery/languages","stargazers_url":"https://api.github.com/repos/Nordstrom/artillery/stargazers","contributors_url":"https://api.github.com/repos/Nordstrom/artillery/contributors","subscribers_url":"https://api.github.com/repos/Nordstrom/artillery/subscribers","subscription_url":"https://api.github.com/repos/Nordstrom/artillery/subscription","commits_url":"https://api.github.com/repos/Nordstrom/artillery/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nordstrom/artillery/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nordstrom/artillery/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nordstrom/artillery/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nordstrom/artillery/contents/{+path}","compare_url":"https://api.github.com/repos/Nordstrom/artillery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nordstrom/artillery/merges","archive_url":"https://api.github.com/repos/Nordstrom/artillery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nordstrom/artillery/downloads","issues_url":"https://api.github.com/repos/Nordstrom/artillery/issues{/number}","pulls_url":"https://api.github.com/repos/Nordstrom/artillery/pulls{/number}","milestones_url":"https://api.github.com/repos/Nordstrom/artillery/milestones{/number}","notifications_url":"https://api.github.com/repos/Nordstrom/artillery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nordstrom/artillery/labels{/name}","releases_url":"https://api.github.com/repos/Nordstrom/artillery/releases{/id}","deployments_url":"https://api.github.com/repos/Nordstrom/artillery/deployments","created_at":"2018-06-01T20:22:04Z","updated_at":"2018-06-01T20:22:07Z","pushed_at":"2018-06-12T23:48:28Z","git_url":"git://github.com/Nordstrom/artillery.git","ssh_url":"git@github.com:Nordstrom/artillery.git","clone_url":"https://github.com/Nordstrom/artillery.git","svn_url":"https://github.com/Nordstrom/artillery","homepage":"https://artillery.io","size":14484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Nordstrom:master","ref":"master","sha":"ef413cb8c7a3e4d4566972906e2fabea43f400fc","user":{"login":"Nordstrom","id":2488485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"repo":{"id":135760037,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjAwMzc=","name":"artillery","full_name":"Nordstrom/artillery","owner":{"login":"Nordstrom","id":2488485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2488485?v=4","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nordstrom/artillery","description":"Flexible and powerful toolkit for load and functional testing. HTTP, Socket.io, WebSockets, Kinesis - you bring it, Artillery will blast it! Make your systems indestructible! 👩‍💻 🏰","fork":true,"url":"https://api.github.com/repos/Nordstrom/artillery","forks_url":"https://api.github.com/repos/Nordstrom/artillery/forks","keys_url":"https://api.github.com/repos/Nordstrom/artillery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nordstrom/artillery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nordstrom/artillery/teams","hooks_url":"https://api.github.com/repos/Nordstrom/artillery/hooks","issue_events_url":"https://api.github.com/repos/Nordstrom/artillery/issues/events{/number}","events_url":"https://api.github.com/repos/Nordstrom/artillery/events","assignees_url":"https://api.github.com/repos/Nordstrom/artillery/assignees{/user}","branches_url":"https://api.github.com/repos/Nordstrom/artillery/branches{/branch}","tags_url":"https://api.github.com/repos/Nordstrom/artillery/tags","blobs_url":"https://api.github.com/repos/Nordstrom/artillery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nordstrom/artillery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nordstrom/artillery/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nordstrom/artillery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nordstrom/artillery/statuses/{sha}","languages_url":"https://api.github.com/repos/Nordstrom/artillery/languages","stargazers_url":"https://api.github.com/repos/Nordstrom/artillery/stargazers","contributors_url":"https://api.github.com/repos/Nordstrom/artillery/contributors","subscribers_url":"https://api.github.com/repos/Nordstrom/artillery/subscribers","subscription_url":"https://api.github.com/repos/Nordstrom/artillery/subscription","commits_url":"https://api.github.com/repos/Nordstrom/artillery/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nordstrom/artillery/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nordstrom/artillery/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nordstrom/artillery/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nordstrom/artillery/contents/{+path}","compare_url":"https://api.github.com/repos/Nordstrom/artillery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nordstrom/artillery/merges","archive_url":"https://api.github.com/repos/Nordstrom/artillery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nordstrom/artillery/downloads","issues_url":"https://api.github.com/repos/Nordstrom/artillery/issues{/number}","pulls_url":"https://api.github.com/repos/Nordstrom/artillery/pulls{/number}","milestones_url":"https://api.github.com/repos/Nordstrom/artillery/milestones{/number}","notifications_url":"https://api.github.com/repos/Nordstrom/artillery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nordstrom/artillery/labels{/name}","releases_url":"https://api.github.com/repos/Nordstrom/artillery/releases{/id}","deployments_url":"https://api.github.com/repos/Nordstrom/artillery/deployments","created_at":"2018-06-01T20:22:04Z","updated_at":"2018-06-01T20:22:07Z","pushed_at":"2018-06-12T23:48:28Z","git_url":"git://github.com/Nordstrom/artillery.git","ssh_url":"git@github.com:Nordstrom/artillery.git","clone_url":"https://github.com/Nordstrom/artillery.git","svn_url":"https://github.com/Nordstrom/artillery","homepage":"https://artillery.io","size":14484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/1"},"html":{"href":"https://github.com/Nordstrom/artillery/pull/1"},"issue":{"href":"https://api.github.com/repos/Nordstrom/artillery/issues/1"},"comments":{"href":"https://api.github.com/repos/Nordstrom/artillery/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nordstrom/artillery/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Nordstrom/artillery/statuses/1d898ea8371f88d4dc0dd1ed278a0e2b2c3cc622"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gwsii"}}