{"action":"created","comment":{"url":"https://api.github.com/repos/18F/calc/pulls/comments/180572197","pull_request_review_id":111014703,"id":180572197,"diff_hunk":"@@ -0,0 +1,50 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import Loadable from 'react-loadable';\n+\n+export const Loading = ({ error, pastDelay }) => {\n+  if (error) {\n+    return (\n+      <div className=\"usa-alert usa-alert-error\" role=\"alert\">","path":"frontend/source/js/data-explorer/components/loadable-wrapper.jsx","position":8,"original_position":8,"commit_id":"69c8b6c3215b266478a5115f7148859dea3c1555","original_commit_id":"69c8b6c3215b266478a5115f7148859dea3c1555","user":{"login":"hbillings","id":509309,"avatar_url":"https://avatars0.githubusercontent.com/u/509309?v=4","gravatar_id":"","url":"https://api.github.com/users/hbillings","html_url":"https://github.com/hbillings","followers_url":"https://api.github.com/users/hbillings/followers","following_url":"https://api.github.com/users/hbillings/following{/other_user}","gists_url":"https://api.github.com/users/hbillings/gists{/gist_id}","starred_url":"https://api.github.com/users/hbillings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbillings/subscriptions","organizations_url":"https://api.github.com/users/hbillings/orgs","repos_url":"https://api.github.com/users/hbillings/repos","events_url":"https://api.github.com/users/hbillings/events{/privacy}","received_events_url":"https://api.github.com/users/hbillings/received_events","type":"User","site_admin":false},"body":"Does this wrap around the entire Loadable container, or each filter? If the former, I think it's fine; if the latter, we have some form error classes we could apply that would probably look less weird.","created_at":"2018-04-10T21:24:01Z","updated_at":"2018-04-10T21:30:23Z","html_url":"https://github.com/18F/calc/pull/1736#discussion_r180572197","pull_request_url":"https://api.github.com/repos/18F/calc/pulls/1736","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/comments/180572197"},"html":{"href":"https://github.com/18F/calc/pull/1736#discussion_r180572197"},"pull_request":{"href":"https://api.github.com/repos/18F/calc/pulls/1736"}},"in_reply_to_id":180540200},"pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/1736","id":180427445,"html_url":"https://github.com/18F/calc/pull/1736","diff_url":"https://github.com/18F/calc/pull/1736.diff","patch_url":"https://github.com/18F/calc/pull/1736.patch","issue_url":"https://api.github.com/repos/18F/calc/issues/1736","number":1736,"state":"open","locked":false,"title":"Add React-Loadable and analyze webpack","user":{"login":"jseppi","id":697848,"avatar_url":"https://avatars2.githubusercontent.com/u/697848?v=4","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"body":"ref #1724.\r\n\r\nThis PR adds support for using [`react-loadable`](https://github.com/jamiebuilds/react-loadable), and uses that code to make the Data Explorer's `OptionalFilters` \"loadable\" as a new higher-order component called `LoadableOptionalFilters`. It also adds `webpack-bundle-analyzer` and an `npm` script for visualizing our bundle sizes.\r\n\r\n`react-loadable` makes it pretty easy to generate webpack chunks/bundles based that are split at the component-level. Then, those chunks can be loaded asynchronously instead of having to everything in a single bundle. In practice, this means the initial load of the Data Explorer app will be faster (due to a smaller initial bundle size).\r\n\r\nUnfortunately `webpack-bundle-analyzer` seems to have a problem with analyzing the fully-transformed chunks that are generated by React-Loadable and `import` (ref https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/166) so we can only see the `stat` size of our bundle modules. The `stat` size, while not what actually will get transmitted to a client over the wire, appears to at least be representative of the relative size of modules to each other, so it should still help identify large modules/dependencies.","created_at":"2018-04-09T21:05:40Z","updated_at":"2018-04-10T21:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a9d0e3cbd240acd2b0b5a34808700907f2d9606","assignee":{"login":"jseppi","id":697848,"avatar_url":"https://avatars2.githubusercontent.com/u/697848?v=4","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jseppi","id":697848,"avatar_url":"https://avatars2.githubusercontent.com/u/697848?v=4","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"toolness","id":124687,"avatar_url":"https://avatars2.githubusercontent.com/u/124687?v=4","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/calc/pulls/1736/commits","review_comments_url":"https://api.github.com/repos/18F/calc/pulls/1736/comments","review_comment_url":"https://api.github.com/repos/18F/calc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/calc/issues/1736/comments","statuses_url":"https://api.github.com/repos/18F/calc/statuses/69c8b6c3215b266478a5115f7148859dea3c1555","head":{"label":"18F:1724-analyze-webpack","ref":"1724-analyze-webpack","sha":"69c8b6c3215b266478a5115f7148859dea3c1555","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2018-04-10T21:11:21Z","pushed_at":"2018-04-10T21:11:22Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":37071,"stargazers_count":96,"watchers_count":96,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":50,"open_issues":155,"watchers":96,"default_branch":"develop"}},"base":{"label":"18F:develop","ref":"develop","sha":"30057446460f4e1ed53a8aa962698a8194e4fe3b","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2018-04-10T21:11:21Z","pushed_at":"2018-04-10T21:11:22Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":37071,"stargazers_count":96,"watchers_count":96,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":50,"open_issues":155,"watchers":96,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/1736"},"html":{"href":"https://github.com/18F/calc/pull/1736"},"issue":{"href":"https://api.github.com/repos/18F/calc/issues/1736"},"comments":{"href":"https://api.github.com/repos/18F/calc/issues/1736/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/calc/pulls/1736/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/calc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/calc/pulls/1736/commits"},"statuses":{"href":"https://api.github.com/repos/18F/calc/statuses/69c8b6c3215b266478a5115f7148859dea3c1555"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hbillings"}}