{"action":"closed","number":762,"pull_request":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762","id":226302334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzAyMzM0","html_url":"https://github.com/Zilliqa/Zilliqa/pull/762","diff_url":"https://github.com/Zilliqa/Zilliqa/pull/762.diff","patch_url":"https://github.com/Zilliqa/Zilliqa/pull/762.patch","issue_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/762","number":762,"state":"closed","locked":false,"title":"[testnetv3-dev] Added tests for primitives in libMessage","user":{"login":"ansnunez","id":19547037,"node_id":"MDQ6VXNlcjE5NTQ3MDM3","avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!-- What is the overall goal of your pull request? -->\r\n<!-- What is the context of your pull request? -->\r\n<!-- What are the related issues and pull requests? -->\r\n\r\nMinor modification of the test functions comparing to the previous pull request because of the separation of the test data generator functions into the standalone library testLib.\r\n...............................\r\nThis PR adds tests for the functions under the \"Primitives\" section in Messenger.h.\r\n\r\nIt also removes the unused files Message.proto and Test_Message.cpp, which were only used during initial stage of protobuf work.\r\n\r\n## Review Suggestion\r\n<!-- How should the reviewers get started on reviewing your pull request-->\r\n<!-- How can the reviewers verify the pull request is working as expected -->\r\n\r\n## Status\r\n\r\n### Implementation\r\n<!-- Add more TODOs before \"ready for review\", if any  -->\r\n- [x] **ready for review**\r\n\r\n### Integration Test (Core Team)\r\n<!-- This is for core team only, ignore this if you are a community contributor -->\r\n\r\n<!-- append the commit digest to inform the others of the versions you have tested -->\r\n- [ ] local machine test\r\n<!-- - [ ] local machine test (commit: bbbbbbbb) -->\r\n<!-- - [ ] local machine test (commit: cccccccc) -->\r\n<!-- - [ ] local machine test (commit: dddddddd) -->\r\n- [ ] small-scale cloud test\r\n<!-- - [ ] small-scale cloud test (commit: bbbbbbbb) -->\r\n<!-- - [ ] small-scale cloud test (commit: cccccccc) -->\r\n<!-- - [ ] small-scale cloud test (commit: dddddddd) -->\r\n","created_at":"2018-10-27T15:29:31Z","updated_at":"2018-11-01T02:34:16Z","closed_at":"2018-11-01T02:34:16Z","merged_at":"2018-11-01T02:34:16Z","merge_commit_sha":"c5e15677f8fa88b1ba54636df2d80b459c35d89e","assignee":{"login":"ansnunez","id":19547037,"node_id":"MDQ6VXNlcjE5NTQ3MDM3","avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false},"assignees":[{"login":"ansnunez","id":19547037,"node_id":"MDQ6VXNlcjE5NTQ3MDM3","avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":990370924,"node_id":"MDU6TGFiZWw5OTAzNzA5MjQ=","url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels/Ready","name":"Ready","color":"8ded6a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762/commits","review_comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762/comments","review_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/762/comments","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/c5e15677f8fa88b1ba54636df2d80b459c35d89e","head":{"label":"Zilliqa:test/libmessage_primitives","ref":"test/libmessage_primitives","sha":"c5e15677f8fa88b1ba54636df2d80b459c35d89e","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-11-01T02:16:24Z","pushed_at":"2018-11-01T02:34:16Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":22006,"stargazers_count":675,"watchers_count":675,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":143,"open_issues":82,"watchers":675,"default_branch":"master"}},"base":{"label":"Zilliqa:testnetv3-dev","ref":"testnetv3-dev","sha":"15827df188611661b16068be4f8bf6df135d88ca","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-11-01T02:16:24Z","pushed_at":"2018-11-01T02:34:16Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":22006,"stargazers_count":675,"watchers_count":675,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":143,"open_issues":82,"watchers":675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/762"},"issue":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/762"},"comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/762/comments"},"review_comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762/comments"},"review_comment":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/762/commits"},"statuses":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/c5e15677f8fa88b1ba54636df2d80b459c35d89e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ansnunez","id":19547037,"node_id":"MDQ6VXNlcjE5NTQ3MDM3","avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":13,"additions":503,"deletions":218,"changed_files":9}}
{"actor":{"display_login":"ansnunez"}}