{"action":"created","comment":{"url":"https://api.github.com/repos/sonm-io/market/pulls/comments/189305700","pull_request_review_id":121462379,"id":189305700,"diff_hunk":"@@ -352,11 +353,13 @@ contract Market is Ownable {\n         require(msg.sender == deals[dealID].supplierID || msg.sender == deals[dealID].consumerID || msg.sender == deals[dealID].masterID);\n         var deal = deals[dealID];\n \n-        if (deal.duration > 0 && block.timestamp > deal.endTime) {\n+        if (!IsSpot(dealID) && deal.lastBillTS >= deal.endTime) {","path":"contracts/Market.sol","position":22,"original_position":22,"commit_id":"0e4372c9087c16f428989161e16b75701b743b59","original_commit_id":"0e4372c9087c16f428989161e16b75701b743b59","user":{"login":"Sokel","id":3659920,"avatar_url":"https://avatars1.githubusercontent.com/u/3659920?v=4","gravatar_id":"","url":"https://api.github.com/users/Sokel","html_url":"https://github.com/Sokel","followers_url":"https://api.github.com/users/Sokel/followers","following_url":"https://api.github.com/users/Sokel/following{/other_user}","gists_url":"https://api.github.com/users/Sokel/gists{/gist_id}","starred_url":"https://api.github.com/users/Sokel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sokel/subscriptions","organizations_url":"https://api.github.com/users/Sokel/orgs","repos_url":"https://api.github.com/users/Sokel/repos","events_url":"https://api.github.com/users/Sokel/events{/privacy}","received_events_url":"https://api.github.com/users/Sokel/received_events","type":"User","site_admin":false},"body":"if `deal.lastBillTS >= deal.endTime`, but totalPayout > 0? \r\nwhy you checks this params? ","created_at":"2018-05-18T15:24:51Z","updated_at":"2018-05-18T15:30:58Z","html_url":"https://github.com/sonm-io/market/pull/45#discussion_r189305700","pull_request_url":"https://api.github.com/repos/sonm-io/market/pulls/45","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonm-io/market/pulls/comments/189305700"},"html":{"href":"https://github.com/sonm-io/market/pull/45#discussion_r189305700"},"pull_request":{"href":"https://api.github.com/repos/sonm-io/market/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/sonm-io/market/pulls/45","id":187791535,"html_url":"https://github.com/sonm-io/market/pull/45","diff_url":"https://github.com/sonm-io/market/pull/45.diff","patch_url":"https://github.com/sonm-io/market/pull/45.patch","issue_url":"https://api.github.com/repos/sonm-io/market/issues/45","number":45,"state":"open","locked":false,"title":"Fix/bug remove","user":{"login":"quasisamurai","id":26491894,"avatar_url":"https://avatars0.githubusercontent.com/u/26491894?v=4","gravatar_id":"","url":"https://api.github.com/users/quasisamurai","html_url":"https://github.com/quasisamurai","followers_url":"https://api.github.com/users/quasisamurai/followers","following_url":"https://api.github.com/users/quasisamurai/following{/other_user}","gists_url":"https://api.github.com/users/quasisamurai/gists{/gist_id}","starred_url":"https://api.github.com/users/quasisamurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasisamurai/subscriptions","organizations_url":"https://api.github.com/users/quasisamurai/orgs","repos_url":"https://api.github.com/users/quasisamurai/repos","events_url":"https://api.github.com/users/quasisamurai/events{/privacy}","received_events_url":"https://api.github.com/users/quasisamurai/received_events","type":"User","site_admin":false},"body":"Here is:\r\n\r\n- Fix of bug that takes action when deal billed after endTime (deals didn't close if billed after endtime)\r\n\r\n- Changing order of operations in CalculatePayment \r\n\r\n- Fixing counterparty bug when anyone can start deal regardless of counterparty field in ASK.","created_at":"2018-05-14T11:05:07Z","updated_at":"2018-05-18T15:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ea5b2fbfb1d48b34940ed8444d7c5eb765ec5ea","assignee":{"login":"quasisamurai","id":26491894,"avatar_url":"https://avatars0.githubusercontent.com/u/26491894?v=4","gravatar_id":"","url":"https://api.github.com/users/quasisamurai","html_url":"https://github.com/quasisamurai","followers_url":"https://api.github.com/users/quasisamurai/followers","following_url":"https://api.github.com/users/quasisamurai/following{/other_user}","gists_url":"https://api.github.com/users/quasisamurai/gists{/gist_id}","starred_url":"https://api.github.com/users/quasisamurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasisamurai/subscriptions","organizations_url":"https://api.github.com/users/quasisamurai/orgs","repos_url":"https://api.github.com/users/quasisamurai/repos","events_url":"https://api.github.com/users/quasisamurai/events{/privacy}","received_events_url":"https://api.github.com/users/quasisamurai/received_events","type":"User","site_admin":false},"assignees":[{"login":"quasisamurai","id":26491894,"avatar_url":"https://avatars0.githubusercontent.com/u/26491894?v=4","gravatar_id":"","url":"https://api.github.com/users/quasisamurai","html_url":"https://github.com/quasisamurai","followers_url":"https://api.github.com/users/quasisamurai/followers","following_url":"https://api.github.com/users/quasisamurai/following{/other_user}","gists_url":"https://api.github.com/users/quasisamurai/gists{/gist_id}","starred_url":"https://api.github.com/users/quasisamurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasisamurai/subscriptions","organizations_url":"https://api.github.com/users/quasisamurai/orgs","repos_url":"https://api.github.com/users/quasisamurai/repos","events_url":"https://api.github.com/users/quasisamurai/events{/privacy}","received_events_url":"https://api.github.com/users/quasisamurai/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonm-io/market/pulls/45/commits","review_comments_url":"https://api.github.com/repos/sonm-io/market/pulls/45/comments","review_comment_url":"https://api.github.com/repos/sonm-io/market/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonm-io/market/issues/45/comments","statuses_url":"https://api.github.com/repos/sonm-io/market/statuses/0e4372c9087c16f428989161e16b75701b743b59","head":{"label":"sonm-io:fix/bug-remove","ref":"fix/bug-remove","sha":"0e4372c9087c16f428989161e16b75701b743b59","user":{"login":"sonm-io","id":25040195,"avatar_url":"https://avatars1.githubusercontent.com/u/25040195?v=4","gravatar_id":"","url":"https://api.github.com/users/sonm-io","html_url":"https://github.com/sonm-io","followers_url":"https://api.github.com/users/sonm-io/followers","following_url":"https://api.github.com/users/sonm-io/following{/other_user}","gists_url":"https://api.github.com/users/sonm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sonm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonm-io/subscriptions","organizations_url":"https://api.github.com/users/sonm-io/orgs","repos_url":"https://api.github.com/users/sonm-io/repos","events_url":"https://api.github.com/users/sonm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sonm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":125392020,"name":"market","full_name":"sonm-io/market","owner":{"login":"sonm-io","id":25040195,"avatar_url":"https://avatars1.githubusercontent.com/u/25040195?v=4","gravatar_id":"","url":"https://api.github.com/users/sonm-io","html_url":"https://github.com/sonm-io","followers_url":"https://api.github.com/users/sonm-io/followers","following_url":"https://api.github.com/users/sonm-io/following{/other_user}","gists_url":"https://api.github.com/users/sonm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sonm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonm-io/subscriptions","organizations_url":"https://api.github.com/users/sonm-io/orgs","repos_url":"https://api.github.com/users/sonm-io/repos","events_url":"https://api.github.com/users/sonm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sonm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonm-io/market","description":"SONM smart-contracts market","fork":false,"url":"https://api.github.com/repos/sonm-io/market","forks_url":"https://api.github.com/repos/sonm-io/market/forks","keys_url":"https://api.github.com/repos/sonm-io/market/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonm-io/market/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonm-io/market/teams","hooks_url":"https://api.github.com/repos/sonm-io/market/hooks","issue_events_url":"https://api.github.com/repos/sonm-io/market/issues/events{/number}","events_url":"https://api.github.com/repos/sonm-io/market/events","assignees_url":"https://api.github.com/repos/sonm-io/market/assignees{/user}","branches_url":"https://api.github.com/repos/sonm-io/market/branches{/branch}","tags_url":"https://api.github.com/repos/sonm-io/market/tags","blobs_url":"https://api.github.com/repos/sonm-io/market/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonm-io/market/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonm-io/market/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonm-io/market/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonm-io/market/statuses/{sha}","languages_url":"https://api.github.com/repos/sonm-io/market/languages","stargazers_url":"https://api.github.com/repos/sonm-io/market/stargazers","contributors_url":"https://api.github.com/repos/sonm-io/market/contributors","subscribers_url":"https://api.github.com/repos/sonm-io/market/subscribers","subscription_url":"https://api.github.com/repos/sonm-io/market/subscription","commits_url":"https://api.github.com/repos/sonm-io/market/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonm-io/market/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonm-io/market/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonm-io/market/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonm-io/market/contents/{+path}","compare_url":"https://api.github.com/repos/sonm-io/market/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonm-io/market/merges","archive_url":"https://api.github.com/repos/sonm-io/market/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonm-io/market/downloads","issues_url":"https://api.github.com/repos/sonm-io/market/issues{/number}","pulls_url":"https://api.github.com/repos/sonm-io/market/pulls{/number}","milestones_url":"https://api.github.com/repos/sonm-io/market/milestones{/number}","notifications_url":"https://api.github.com/repos/sonm-io/market/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonm-io/market/labels{/name}","releases_url":"https://api.github.com/repos/sonm-io/market/releases{/id}","deployments_url":"https://api.github.com/repos/sonm-io/market/deployments","created_at":"2018-03-15T15:58:49Z","updated_at":"2018-05-14T14:24:22Z","pushed_at":"2018-05-17T15:04:33Z","git_url":"git://github.com/sonm-io/market.git","ssh_url":"git@github.com:sonm-io/market.git","clone_url":"https://github.com/sonm-io/market.git","svn_url":"https://github.com/sonm-io/market","homepage":null,"size":876,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"sonm-io:master","ref":"master","sha":"b8b740fa0fd1a78f240a637adfd6288ad78718f6","user":{"login":"sonm-io","id":25040195,"avatar_url":"https://avatars1.githubusercontent.com/u/25040195?v=4","gravatar_id":"","url":"https://api.github.com/users/sonm-io","html_url":"https://github.com/sonm-io","followers_url":"https://api.github.com/users/sonm-io/followers","following_url":"https://api.github.com/users/sonm-io/following{/other_user}","gists_url":"https://api.github.com/users/sonm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sonm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonm-io/subscriptions","organizations_url":"https://api.github.com/users/sonm-io/orgs","repos_url":"https://api.github.com/users/sonm-io/repos","events_url":"https://api.github.com/users/sonm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sonm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":125392020,"name":"market","full_name":"sonm-io/market","owner":{"login":"sonm-io","id":25040195,"avatar_url":"https://avatars1.githubusercontent.com/u/25040195?v=4","gravatar_id":"","url":"https://api.github.com/users/sonm-io","html_url":"https://github.com/sonm-io","followers_url":"https://api.github.com/users/sonm-io/followers","following_url":"https://api.github.com/users/sonm-io/following{/other_user}","gists_url":"https://api.github.com/users/sonm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sonm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonm-io/subscriptions","organizations_url":"https://api.github.com/users/sonm-io/orgs","repos_url":"https://api.github.com/users/sonm-io/repos","events_url":"https://api.github.com/users/sonm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sonm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonm-io/market","description":"SONM smart-contracts market","fork":false,"url":"https://api.github.com/repos/sonm-io/market","forks_url":"https://api.github.com/repos/sonm-io/market/forks","keys_url":"https://api.github.com/repos/sonm-io/market/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonm-io/market/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonm-io/market/teams","hooks_url":"https://api.github.com/repos/sonm-io/market/hooks","issue_events_url":"https://api.github.com/repos/sonm-io/market/issues/events{/number}","events_url":"https://api.github.com/repos/sonm-io/market/events","assignees_url":"https://api.github.com/repos/sonm-io/market/assignees{/user}","branches_url":"https://api.github.com/repos/sonm-io/market/branches{/branch}","tags_url":"https://api.github.com/repos/sonm-io/market/tags","blobs_url":"https://api.github.com/repos/sonm-io/market/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonm-io/market/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonm-io/market/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonm-io/market/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonm-io/market/statuses/{sha}","languages_url":"https://api.github.com/repos/sonm-io/market/languages","stargazers_url":"https://api.github.com/repos/sonm-io/market/stargazers","contributors_url":"https://api.github.com/repos/sonm-io/market/contributors","subscribers_url":"https://api.github.com/repos/sonm-io/market/subscribers","subscription_url":"https://api.github.com/repos/sonm-io/market/subscription","commits_url":"https://api.github.com/repos/sonm-io/market/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonm-io/market/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonm-io/market/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonm-io/market/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonm-io/market/contents/{+path}","compare_url":"https://api.github.com/repos/sonm-io/market/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonm-io/market/merges","archive_url":"https://api.github.com/repos/sonm-io/market/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonm-io/market/downloads","issues_url":"https://api.github.com/repos/sonm-io/market/issues{/number}","pulls_url":"https://api.github.com/repos/sonm-io/market/pulls{/number}","milestones_url":"https://api.github.com/repos/sonm-io/market/milestones{/number}","notifications_url":"https://api.github.com/repos/sonm-io/market/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonm-io/market/labels{/name}","releases_url":"https://api.github.com/repos/sonm-io/market/releases{/id}","deployments_url":"https://api.github.com/repos/sonm-io/market/deployments","created_at":"2018-03-15T15:58:49Z","updated_at":"2018-05-14T14:24:22Z","pushed_at":"2018-05-17T15:04:33Z","git_url":"git://github.com/sonm-io/market.git","ssh_url":"git@github.com:sonm-io/market.git","clone_url":"https://github.com/sonm-io/market.git","svn_url":"https://github.com/sonm-io/market","homepage":null,"size":876,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonm-io/market/pulls/45"},"html":{"href":"https://github.com/sonm-io/market/pull/45"},"issue":{"href":"https://api.github.com/repos/sonm-io/market/issues/45"},"comments":{"href":"https://api.github.com/repos/sonm-io/market/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/sonm-io/market/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/sonm-io/market/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonm-io/market/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/sonm-io/market/statuses/0e4372c9087c16f428989161e16b75701b743b59"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Sokel"}}