{"action":"created","comment":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/214279268","pull_request_review_id":151300628,"id":214279268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDI3OTI2OA==","diff_hunk":"@@ -38,6 +38,17 @@ class ProcessCapture(workingDir: File?, environment: Map<String, String>, vararg\n     companion object {\n         private const val MAX_LOG_LINES = 20\n         private const val MAX_LOG_LINES_MESSAGE = \"(Above output is limited to $MAX_LOG_LINES lines.)\"\n+\n+        private fun logLinesLimited(prefix: String, lines: Sequence<String>, limit: Int, logLine: (String) -> Unit) {\n+            var count = 0\n+            val i = lines.iterator()\n+\n+            while (i.hasNext() && count++ < limit) {\n+                logLine(\"$prefix: ${i.next()}\")\n+            }\n+\n+            if (i.hasNext()) logLine(MAX_LOG_LINES_MESSAGE)","path":"utils/src/main/kotlin/ProcessCapture.kt","position":null,"original_position":13,"commit_id":"db06d581ce700a8af8cc7972f75e61753729fb6c","original_commit_id":"b01f77a252d6146442e959f69b93fe09be109324","user":{"login":"mnonnenmacher","id":2741977,"node_id":"MDQ6VXNlcjI3NDE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2741977?v=4","gravatar_id":"","url":"https://api.github.com/users/mnonnenmacher","html_url":"https://github.com/mnonnenmacher","followers_url":"https://api.github.com/users/mnonnenmacher/followers","following_url":"https://api.github.com/users/mnonnenmacher/following{/other_user}","gists_url":"https://api.github.com/users/mnonnenmacher/gists{/gist_id}","starred_url":"https://api.github.com/users/mnonnenmacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnonnenmacher/subscriptions","organizations_url":"https://api.github.com/users/mnonnenmacher/orgs","repos_url":"https://api.github.com/users/mnonnenmacher/repos","events_url":"https://api.github.com/users/mnonnenmacher/events{/privacy}","received_events_url":"https://api.github.com/users/mnonnenmacher/received_events","type":"User","site_admin":false},"body":"I does create the `next()` element only when required, but after only shortly looking at the code it wasn't clear to me if calling `hasNext()` also creates the next element already. Did you find out?","created_at":"2018-08-31T08:27:41Z","updated_at":"2018-08-31T08:27:41Z","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/826#discussion_r214279268","pull_request_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/214279268"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/826#discussion_r214279268"},"pull_request":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826"}},"in_reply_to_id":214269407},"pull_request":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826","id":212295153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjk1MTUz","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/826","diff_url":"https://github.com/heremaps/oss-review-toolkit/pull/826.diff","patch_url":"https://github.com/heremaps/oss-review-toolkit/pull/826.patch","issue_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/826","number":826,"state":"open","locked":false,"title":"Logging","user":{"login":"sschuberth","id":349154,"node_id":"MDQ6VXNlcjM0OTE1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"Please have a look at the individual commit messages for the details.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/heremaps/oss-review-toolkit/826)\n<!-- Reviewable:end -->\n","created_at":"2018-08-31T07:19:07Z","updated_at":"2018-08-31T08:27:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5f6af4867636d88dad7d7eb27816efefd38d206","assignee":null,"assignees":[],"requested_reviewers":[{"login":"haikoschol","id":539509,"node_id":"MDQ6VXNlcjUzOTUwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/539509?v=4","gravatar_id":"","url":"https://api.github.com/users/haikoschol","html_url":"https://github.com/haikoschol","followers_url":"https://api.github.com/users/haikoschol/followers","following_url":"https://api.github.com/users/haikoschol/following{/other_user}","gists_url":"https://api.github.com/users/haikoschol/gists{/gist_id}","starred_url":"https://api.github.com/users/haikoschol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikoschol/subscriptions","organizations_url":"https://api.github.com/users/haikoschol/orgs","repos_url":"https://api.github.com/users/haikoschol/repos","events_url":"https://api.github.com/users/haikoschol/events{/privacy}","received_events_url":"https://api.github.com/users/haikoschol/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826/commits","review_comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826/comments","review_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/826/comments","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/db06d581ce700a8af8cc7972f75e61753729fb6c","head":{"label":"heremaps:logging","ref":"logging","sha":"db06d581ce700a8af8cc7972f75e61753729fb6c","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-08-30T22:31:06Z","pushed_at":"2018-08-31T08:08:06Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":54990,"stargazers_count":86,"watchers_count":86,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":47,"watchers":86,"default_branch":"master"}},"base":{"label":"heremaps:master","ref":"master","sha":"b07edfa0e8aaacce9fd395249e9b8f4f4ff1c5d8","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-08-30T22:31:06Z","pushed_at":"2018-08-31T08:08:06Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":54990,"stargazers_count":86,"watchers_count":86,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":47,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/826"},"issue":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/826"},"comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/826/comments"},"review_comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826/comments"},"review_comment":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/826/commits"},"statuses":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/db06d581ce700a8af8cc7972f75e61753729fb6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mnonnenmacher"}}