{"action":"created","issue":{"url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/1343","repository_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager","labels_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/1343/labels{/name}","comments_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/1343/comments","events_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/1343/events","html_url":"https://github.com/TeamAmaze/AmazeFileManager/pull/1343","id":338224217,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjA5MzEz","number":1343,"title":"Fix parsing SSH URLs with special characters included","user":{"login":"TranceLove","id":251819,"node_id":"MDQ6VXNlcjI1MTgxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/251819?v=4","gravatar_id":"","url":"https://api.github.com/users/TranceLove","html_url":"https://github.com/TranceLove","followers_url":"https://api.github.com/users/TranceLove/followers","following_url":"https://api.github.com/users/TranceLove/following{/other_user}","gists_url":"https://api.github.com/users/TranceLove/gists{/gist_id}","starred_url":"https://api.github.com/users/TranceLove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TranceLove/subscriptions","organizations_url":"https://api.github.com/users/TranceLove/orgs","repos_url":"https://api.github.com/users/TranceLove/repos","events_url":"https://api.github.com/users/TranceLove/events{/privacy}","received_events_url":"https://api.github.com/users/TranceLove/received_events","type":"User","site_admin":false},"labels":[{"id":913069910,"node_id":"MDU6TGFiZWw5MTMwNjk5MTA=","url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/labels/do%20not%20merge","name":"do not merge","color":"111111","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/milestones/1","html_url":"https://github.com/TeamAmaze/AmazeFileManager/milestone/1","labels_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/milestones/1/labels","id":2863757,"node_id":"MDk6TWlsZXN0b25lMjg2Mzc1Nw==","number":1,"title":"v3.3.0-RC2","description":"","creator":{"login":"EmmanuelMess","id":10991116,"node_id":"MDQ6VXNlcjEwOTkxMTE2","avatar_url":"https://avatars1.githubusercontent.com/u/10991116?v=4","gravatar_id":"","url":"https://api.github.com/users/EmmanuelMess","html_url":"https://github.com/EmmanuelMess","followers_url":"https://api.github.com/users/EmmanuelMess/followers","following_url":"https://api.github.com/users/EmmanuelMess/following{/other_user}","gists_url":"https://api.github.com/users/EmmanuelMess/gists{/gist_id}","starred_url":"https://api.github.com/users/EmmanuelMess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmmanuelMess/subscriptions","organizations_url":"https://api.github.com/users/EmmanuelMess/orgs","repos_url":"https://api.github.com/users/EmmanuelMess/repos","events_url":"https://api.github.com/users/EmmanuelMess/events{/privacy}","received_events_url":"https://api.github.com/users/EmmanuelMess/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":53,"state":"open","created_at":"2017-10-25T02:41:00Z","updated_at":"2018-07-07T21:53:37Z","due_on":"2018-07-08T07:00:00Z","closed_at":null},"comments":10,"created_at":"2018-07-04T10:40:52Z","updated_at":"2018-07-08T21:47:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/pulls/1343","html_url":"https://github.com/TeamAmaze/AmazeFileManager/pull/1343","diff_url":"https://github.com/TeamAmaze/AmazeFileManager/pull/1343.diff","patch_url":"https://github.com/TeamAmaze/AmazeFileManager/pull/1343.patch"},"body":"Fixes #1333 (hopefully) and fixes #1290. At places where `Uri.parse()` cannot properly split the SSH server URI for authentication credentials, it is done by hand instead.\r\n\r\n~~Writing~~Robolectric test case ~~was not possible due to #1290, and~~ included since Apache Sshd cannot be run on Android devices (physical/emulator) ~~so Espresso tests aren't possible either~~. ~~I had to test with the hard way - t~~Tested with Oneplus One running Slim7 (7.1.2) and Galaxy S2 running SlimLP (5.1.1), connecting to OpenSSH server running on Fedora Atomic Host.\r\n\r\nEspresso test for `UtilsHandler` to make sure data saved to database is not truncated is included however.\r\n\r\nNote: I suspect SMB implementation would be affected by such problem too, but since nobody is complaining so far, I'm following the rule of \"if it ain't broken, don't fix it\" - or in separate PR for next milestone."},"comment":{"url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/comments/403319767","html_url":"https://github.com/TeamAmaze/AmazeFileManager/pull/1343#issuecomment-403319767","issue_url":"https://api.github.com/repos/TeamAmaze/AmazeFileManager/issues/1343","id":403319767,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzMxOTc2Nw==","user":{"login":"EmmanuelMess","id":10991116,"node_id":"MDQ6VXNlcjEwOTkxMTE2","avatar_url":"https://avatars1.githubusercontent.com/u/10991116?v=4","gravatar_id":"","url":"https://api.github.com/users/EmmanuelMess","html_url":"https://github.com/EmmanuelMess","followers_url":"https://api.github.com/users/EmmanuelMess/followers","following_url":"https://api.github.com/users/EmmanuelMess/following{/other_user}","gists_url":"https://api.github.com/users/EmmanuelMess/gists{/gist_id}","starred_url":"https://api.github.com/users/EmmanuelMess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmmanuelMess/subscriptions","organizations_url":"https://api.github.com/users/EmmanuelMess/orgs","repos_url":"https://api.github.com/users/EmmanuelMess/repos","events_url":"https://api.github.com/users/EmmanuelMess/events{/privacy}","received_events_url":"https://api.github.com/users/EmmanuelMess/received_events","type":"User","site_admin":false},"created_at":"2018-07-08T21:47:55Z","updated_at":"2018-07-08T21:47:55Z","author_association":"MEMBER","body":"I added the \"do not merge\" tag because the PR has two approvals, but it seemed you found a bug, do remove when the problem is no more."}}
{"actor":{"display_login":"EmmanuelMess"}}