{"action":"closed","number":20353,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20353","id":184591355,"html_url":"https://github.com/nodejs/node/pull/20353","diff_url":"https://github.com/nodejs/node/pull/20353.diff","patch_url":"https://github.com/nodejs/node/pull/20353.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20353","number":20353,"state":"closed","locked":false,"title":"stream: only check options once in Duplex ctor","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"This commit updates the Duplex constructor adding an if statement\r\nchecking if options is undefined, and removes the check from the\r\nfollowing three if statements.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-04-27T11:05:46Z","updated_at":"2018-04-28T15:14:25Z","closed_at":"2018-04-28T15:14:25Z","merged_at":null,"merge_commit_sha":"f497c1b73d3ba6051e7b9313b795b9f036c715fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":746808418,"url":"https://api.github.com/repos/nodejs/node/labels/fast-track","name":"fast-track","color":"a989e5","default":false},{"id":155435883,"url":"https://api.github.com/repos/nodejs/node/labels/stream","name":"stream","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20353/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20353/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20353/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/9fe915a3f9bf13992ed3d61ae1b88ee87a0726a4","head":{"label":"danbev:_stream_duplex_constructor_options_check","ref":"_stream_duplex_constructor_options_check","sha":"9fe915a3f9bf13992ed3d61ae1b88ee87a0726a4","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":60841866,"name":"node","full_name":"danbev/node","owner":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbev/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/danbev/node","forks_url":"https://api.github.com/repos/danbev/node/forks","keys_url":"https://api.github.com/repos/danbev/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/node/teams","hooks_url":"https://api.github.com/repos/danbev/node/hooks","issue_events_url":"https://api.github.com/repos/danbev/node/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/node/events","assignees_url":"https://api.github.com/repos/danbev/node/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/node/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/node/tags","blobs_url":"https://api.github.com/repos/danbev/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/node/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/node/languages","stargazers_url":"https://api.github.com/repos/danbev/node/stargazers","contributors_url":"https://api.github.com/repos/danbev/node/contributors","subscribers_url":"https://api.github.com/repos/danbev/node/subscribers","subscription_url":"https://api.github.com/repos/danbev/node/subscription","commits_url":"https://api.github.com/repos/danbev/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbev/node/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/node/merges","archive_url":"https://api.github.com/repos/danbev/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/node/downloads","issues_url":"https://api.github.com/repos/danbev/node/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/node/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/node/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/node/labels{/name}","releases_url":"https://api.github.com/repos/danbev/node/releases{/id}","deployments_url":"https://api.github.com/repos/danbev/node/deployments","created_at":"2016-06-10T11:03:24Z","updated_at":"2018-04-27T05:41:30Z","pushed_at":"2018-04-27T11:04:56Z","git_url":"git://github.com/danbev/node.git","ssh_url":"git@github.com:danbev/node.git","clone_url":"https://github.com/danbev/node.git","svn_url":"https://github.com/danbev/node","homepage":"https://nodejs.org","size":351009,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a1fc52884b98acab3d3f0b66c3b5ac9eb0728b8b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-28T14:53:54Z","pushed_at":"2018-04-28T15:14:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":375921,"stargazers_count":48166,"watchers_count":48166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10148,"mirror_url":null,"archived":false,"open_issues_count":723,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10148,"open_issues":723,"watchers":48166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20353"},"html":{"href":"https://github.com/nodejs/node/pull/20353"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20353"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20353/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20353/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20353/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/9fe915a3f9bf13992ed3d61ae1b88ee87a0726a4"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"BridgeAR"}}