{"push_id":2584712209,"size":7,"distinct_size":7,"ref":"refs/heads/master","head":"ef774cc468ac82cba04d7f4d6b322b1891101c90","before":"58c768b5f30324564a0178a2c1b7f7a88ccff352","commits":[{"sha":"0e9149e47f4faac9776b973bd7e4237bcc0874e0","author":{"name":"Jose Dapena Paz","email":"b5088db3fada4757e1f7efee9638369134c6a04c@lge.com"},"message":"GCC: constexpr should not include NOTREACHED.\n\nfido_constants.h device::to_string was declared as constexpr,\nbut NOTREACHED expands in non-official builds to calls that cannot\nbe used inside a constexpr in GCC.\n\nWe take the opportunity to rename the method to CredentialTypeToString\nto avoid namespace polution (and match style guide).\n\nChange-Id: I9b166ce9a3d7a2213fd81fb045e4a0709f62e426\nReviewed-on: https://chromium-review.googlesource.com/1065895\nReviewed-by: Reilly Grant <reillyg@chromium.org>\nCommit-Queue: José Dapena Paz <jose.dapena@lge.com>\nCr-Commit-Position: refs/heads/master@{#560700}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/0e9149e47f4faac9776b973bd7e4237bcc0874e0"},{"sha":"0ba5d72d6e2fac815d26544f4bda7d123e01b4e8","author":{"name":"kylechar","email":"cf3bdd7db9860193ed55dfb573a6e9e1886a5838@chromium.org"},"message":"Delete video plane resources of wrong size.\n\nHave VideoResourceUpdater delete recycled video plane resources if\nthey're the wrong size. This is mainly an issue for software compositing\nwhere VideoResourceUpdater always has to allocate plane resources\nitself, but if the video size changes then we'd have extra plane\nresources that aren't freed until the user navigates away from the\nvideo.\n\nBug: none\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel\nChange-Id: I09e39eec246c1304ae72cf9aad1486abedbcd7c1\nReviewed-on: https://chromium-review.googlesource.com/1003215\nCommit-Queue: kylechar <kylechar@chromium.org>\nReviewed-by: danakj <danakj@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560701}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/0ba5d72d6e2fac815d26544f4bda7d123e01b4e8"},{"sha":"c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e","author":{"name":"Maria Khomenko","email":"e2cea6e10aea1ee9580fbf03c2b53787a69701bd@chromium.org"},"message":"Remove StartupMetrics.java\n\nThese metrics are incorrect because they detect MAIN vs non-MAIN behaviour wrong\nsince the intent gets updated in onNewIntent(), but we set the intent in\nonStart(). These are also incorrect because they get recorded every time\nwe call onStart(), which means that when we go to settings and come back\nwe would record the metric again.\n\nBug: 838388\nChange-Id: Id8bb7b3401c8103029d5b397a57bb1f07dc56b26\nReviewed-on: https://chromium-review.googlesource.com/1062937\nReviewed-by: Ted Choc <tedchoc@chromium.org>\nReviewed-by: Ilya Sherman <isherman@chromium.org>\nCommit-Queue: Maria Khomenko <mariakhomenko@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560702}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e"},{"sha":"44f61c439253aa1ec2a11d298c832e2210eabe5c","author":{"name":"Annie Sullivan","email":"259f984aa3b2892f452a20facda15d22b94ee4f8@chromium.org"},"message":"Disable failing blink_perf.bindings stories on Nexus 5X.\n\nBug: 845555\nChange-Id: I029cf1f8e916b41febc69824d637a459c0d38921\nTBR: charliea@chromium.org\nNOTRY: true\nReviewed-on: https://chromium-review.googlesource.com/1069313\nReviewed-by: Annie Sullivan <sullivan@chromium.org>\nCommit-Queue: Annie Sullivan <sullivan@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560703}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/44f61c439253aa1ec2a11d298c832e2210eabe5c"},{"sha":"5ec205887a0b04bb100bd3eb07b432c1b378367c","author":{"name":"Gabriel Charette","email":"41ae41107f68c5f6cb83171614f7cf276b0b3572@chromium.org"},"message":"[Metrics] Introduce High-resolution timing histograms/macros.\n\nMigrated two metrics to use new APIs and flagged other identified\nhistograms' descriptions to highlight issue on dashboards (I will\nemail relevant owners after this lands).\nRelevant metrics list extracted from https://crbug.com/807615#c19\n\nR=asvitkine@chromium.org, fdoray@chromium.org\n\nBug: 807615\nChange-Id: I84f0f8fb5ca7fd3c5b43ba7209693b89928ade07\nReviewed-on: https://chromium-review.googlesource.com/1062830\nCommit-Queue: Gabriel Charette <gab@chromium.org>\nReviewed-by: Scott Violet <sky@chromium.org>\nReviewed-by: Alexei Svitkine <asvitkine@chromium.org>\nReviewed-by: François Doray <fdoray@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560704}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/5ec205887a0b04bb100bd3eb07b432c1b378367c"},{"sha":"2509cef9702fbb5ef677bdc43d2142ac34f95bcc","author":{"name":"rbpotter","email":"d3fa462b5af7bedecb31c9641c08373f0b7e8c42@chromium.org"},"message":"Print Preview Componentization: Fix possible null dereference\n\nBug: 772928\nCq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation\nChange-Id: I3bab99696087bb61e33bc75a4168a84bceee9ba1\nReviewed-on: https://chromium-review.googlesource.com/1062202\nCommit-Queue: Rebekah Potter <rbpotter@chromium.org>\nReviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560705}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/2509cef9702fbb5ef677bdc43d2142ac34f95bcc"},{"sha":"ef774cc468ac82cba04d7f4d6b322b1891101c90","author":{"name":"Justin Cohen","email":"45f934f548b3ee92957d72fd2179b802430e9402@chromium.org"},"message":"Revert \"Reland \"Add blink effect to the PopupMenu\"\"\n\nThis reverts commit 4753267be8640779700dc46c4289cc1cc7e4eda5.\n\nReason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/33343 started to fail at PopupMenuMediatorTest.TestElementsTabGrid*\n\nOriginal change's description:\n> Reland \"Add blink effect to the PopupMenu\"\n> \n> This reverts commit 33c637fd83f41e7050e7fb33f92f745aae02e7fa.\n> \n> Original change's description:\n> > Revert \"Add blink effect to the PopupMenu\"\n> >\n> > This reverts commit 20a94e7f7494f90da6be4593ef85ae482c58e89f.\n> >\n> > Reason for revert:\n> > https://bugs.chromium.org/p/chromium/issues/detail?id=844753\n> >\n> > Bug: 844753\n> >\n> > Original change's description:\n> > > Add blink effect to the PopupMenu\n> > >\n> > > This CL adds an effect to make the \"New Incognito Tab\" row of the tools\n> > > menu blink a selected state when the in product help requires it.\n> > >\n> > > Bug: 829344\n> > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\n> > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef\n> > > Reviewed-on: https://chromium-review.googlesource.com/1057708\n> > > Commit-Queue: Gauthier Ambard <gambard@chromium.org>\n> > > Reviewed-by: edchin <edchin@chromium.org>\n> > > Cr-Commit-Position: refs/heads/master@{#559481}\n> >\n> > TBR=edchin@chromium.org,gambard@chromium.org\n> >\n> > # Not skipping CQ checks because original CL landed > 1 day ago.\n> >\n> > Bug: 829344\n> > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d\n> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\n> > Reviewed-on: https://chromium-review.googlesource.com/1066334\n> > Commit-Queue: Eugene But <eugenebut@chromium.org>\n> > Reviewed-by: edchin <edchin@chromium.org>\n> > Reviewed-by: Eugene But <eugenebut@chromium.org>\n> > Cr-Commit-Position: refs/heads/master@{#560106}\n> \n> Bug: 844753, 829344\n> Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06\n> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\n> Reviewed-on: https://chromium-review.googlesource.com/1068727\n> Reviewed-by: edchin <edchin@chromium.org>\n> Commit-Queue: Gauthier Ambard <gambard@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#560632}\n\nTBR=edchin@chromium.org,gambard@chromium.org\n\nChange-Id: If2d2bea1069e682ec4e747d6790f68a9e289d7cf\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 844753, 829344\nCq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\nReviewed-on: https://chromium-review.googlesource.com/1067644\nReviewed-by: Justin Cohen <justincohen@chromium.org>\nCommit-Queue: Justin Cohen <justincohen@chromium.org>\nCr-Commit-Position: refs/heads/master@{#560706}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/ef774cc468ac82cba04d7f4d6b322b1891101c90"}]}
{"actor":{"display_login":"aarongable"}}