{"action":"created","issue":{"url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/263","repository_url":"https://api.github.com/repos/anthofflab/Mimi.jl","labels_url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/263/comments","events_url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/263/events","html_url":"https://github.com/anthofflab/Mimi.jl/pull/263","id":339574418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTk0NDg3","number":263,"title":"Change add_dimension to add_dimension","user":{"login":"lrennels","id":31779240,"node_id":"MDQ6VXNlcjMxNzc5MjQw","avatar_url":"https://avatars0.githubusercontent.com/u/31779240?v=4","gravatar_id":"","url":"https://api.github.com/users/lrennels","html_url":"https://github.com/lrennels","followers_url":"https://api.github.com/users/lrennels/followers","following_url":"https://api.github.com/users/lrennels/following{/other_user}","gists_url":"https://api.github.com/users/lrennels/gists{/gist_id}","starred_url":"https://api.github.com/users/lrennels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrennels/subscriptions","organizations_url":"https://api.github.com/users/lrennels/orgs","repos_url":"https://api.github.com/users/lrennels/repos","events_url":"https://api.github.com/users/lrennels/events{/privacy}","received_events_url":"https://api.github.com/users/lrennels/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-09T19:18:33Z","updated_at":"2018-07-09T19:56:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/anthofflab/Mimi.jl/pulls/263","html_url":"https://github.com/anthofflab/Mimi.jl/pull/263","diff_url":"https://github.com/anthofflab/Mimi.jl/pull/263.diff","patch_url":"https://github.com/anthofflab/Mimi.jl/pull/263.patch"},"body":"For constancy, since `add_dimension` modifies the model definition, change the name to `add_dimension!`.  "},"comment":{"url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/comments/403600681","html_url":"https://github.com/anthofflab/Mimi.jl/pull/263#issuecomment-403600681","issue_url":"https://api.github.com/repos/anthofflab/Mimi.jl/issues/263","id":403600681,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYwMDY4MQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T19:56:22Z","updated_at":"2018-07-09T19:56:22Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=h1) Report\n> Merging [#263](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=desc) into [master](https://codecov.io/gh/anthofflab/Mimi.jl/commit/0d719db5f8c221aa161e7ebd0a601f6223af32b8?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `50%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263/graphs/tree.svg?height=150&width=650&src=pr&token=yI3iGyhLFv)](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master     #263   +/-   ##\n=======================================\n  Coverage   73.32%   73.32%           \n=======================================\n  Files          25       25           \n  Lines        1683     1683           \n=======================================\n  Hits         1234     1234           \n  Misses        449      449\n```\n\n\n| [Impacted Files](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/Mimi.jl](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263/diff?src=pr&el=tree#diff-c3JjL01pbWkuamw=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/core/types.jl](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdHlwZXMuamw=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/core/defs.jl](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263/diff?src=pr&el=tree#diff-c3JjL2NvcmUvZGVmcy5qbA==) | `80.43% <0%> (ø)` | :arrow_up: |\n| [src/core/defcomp.jl](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263/diff?src=pr&el=tree#diff-c3JjL2NvcmUvZGVmY29tcC5qbA==) | `76.38% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=footer). Last update [0d719db...8e2d2a0](https://codecov.io/gh/anthofflab/Mimi.jl/pull/263?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}