{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/spaniel/pulls/comments/170134951","pull_request_review_id":98777256,"id":170134951,"diff_hunk":"@@ -28,26 +28,45 @@ const TOKEN_SEED = 'xxxx'.replace(/[xy]/g, function(c) {\n   return v.toString(16);\n });\n let tokenCounter = 0;\n-\n-function generateRandomToken() {\n-  return Math.floor(Math.random() * (9999999 - 0o0)).toString(16);\n-}\n+let elementSchedulerCounter = 0;\n \n export class Frame implements FrameInterface {\n   constructor(\n     public timestamp: number,\n     public scrollTop: number,\n     public scrollLeft: number,\n     public width: number,\n-    public height: number\n+    public height: number,\n+    public x: number,\n+    public y: number,\n+    public top: number,\n+    public left: number\n   ) {}\n-  static generate(): Frame {\n+  static generate(root?: Element): Frame {\n+    if (root && document.documentElement.contains(root)) {\n+      let rootClientRect = getBoundingClientRect(root);","path":"src/metal/scheduler.ts","position":26,"original_position":26,"commit_id":"061d492e25728531c20813cf6040c11dddc40f33","original_commit_id":"061d492e25728531c20813cf6040c11dddc40f33","user":{"login":"asakusuma","id":597574,"avatar_url":"https://avatars2.githubusercontent.com/u/597574?v=4","gravatar_id":"","url":"https://api.github.com/users/asakusuma","html_url":"https://github.com/asakusuma","followers_url":"https://api.github.com/users/asakusuma/followers","following_url":"https://api.github.com/users/asakusuma/following{/other_user}","gists_url":"https://api.github.com/users/asakusuma/gists{/gist_id}","starred_url":"https://api.github.com/users/asakusuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asakusuma/subscriptions","organizations_url":"https://api.github.com/users/asakusuma/orgs","repos_url":"https://api.github.com/users/asakusuma/repos","events_url":"https://api.github.com/users/asakusuma/events{/privacy}","received_events_url":"https://api.github.com/users/asakusuma/received_events","type":"User","site_admin":false},"body":"Can this be a `const`?","created_at":"2018-02-23T00:22:54Z","updated_at":"2018-02-23T00:31:45Z","html_url":"https://github.com/linkedin/spaniel/pull/80#discussion_r170134951","pull_request_url":"https://api.github.com/repos/linkedin/spaniel/pulls/80","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/comments/170134951"},"html":{"href":"https://github.com/linkedin/spaniel/pull/80#discussion_r170134951"},"pull_request":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/spaniel/pulls/80","id":170335291,"html_url":"https://github.com/linkedin/spaniel/pull/80","diff_url":"https://github.com/linkedin/spaniel/pull/80.diff","patch_url":"https://github.com/linkedin/spaniel/pull/80.patch","issue_url":"https://api.github.com/repos/linkedin/spaniel/issues/80","number":80,"state":"open","locked":false,"title":"backporting the root implementation with memoize feature","user":{"login":"lynchbomb","id":10506014,"avatar_url":"https://avatars1.githubusercontent.com/u/10506014?v=4","gravatar_id":"","url":"https://api.github.com/users/lynchbomb","html_url":"https://github.com/lynchbomb","followers_url":"https://api.github.com/users/lynchbomb/followers","following_url":"https://api.github.com/users/lynchbomb/following{/other_user}","gists_url":"https://api.github.com/users/lynchbomb/gists{/gist_id}","starred_url":"https://api.github.com/users/lynchbomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynchbomb/subscriptions","organizations_url":"https://api.github.com/users/lynchbomb/orgs","repos_url":"https://api.github.com/users/lynchbomb/repos","events_url":"https://api.github.com/users/lynchbomb/events{/privacy}","received_events_url":"https://api.github.com/users/lynchbomb/received_events","type":"User","site_admin":false},"body":"- Spike for back-porting the v3 `root` implementation within `Intersection-Observer`.\r\n- Handling occluded elements and child scroll containers.","created_at":"2018-02-20T23:10:48Z","updated_at":"2018-02-23T00:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4285397739685753ffe21e7934771fa90440922","assignee":null,"assignees":[],"requested_reviewers":[{"login":"krisselden","id":61024,"avatar_url":"https://avatars1.githubusercontent.com/u/61024?v=4","gravatar_id":"","url":"https://api.github.com/users/krisselden","html_url":"https://github.com/krisselden","followers_url":"https://api.github.com/users/krisselden/followers","following_url":"https://api.github.com/users/krisselden/following{/other_user}","gists_url":"https://api.github.com/users/krisselden/gists{/gist_id}","starred_url":"https://api.github.com/users/krisselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisselden/subscriptions","organizations_url":"https://api.github.com/users/krisselden/orgs","repos_url":"https://api.github.com/users/krisselden/repos","events_url":"https://api.github.com/users/krisselden/events{/privacy}","received_events_url":"https://api.github.com/users/krisselden/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/spaniel/pulls/80/commits","review_comments_url":"https://api.github.com/repos/linkedin/spaniel/pulls/80/comments","review_comment_url":"https://api.github.com/repos/linkedin/spaniel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/spaniel/issues/80/comments","statuses_url":"https://api.github.com/repos/linkedin/spaniel/statuses/061d492e25728531c20813cf6040c11dddc40f33","head":{"label":"linkedin:lynchbomb","ref":"lynchbomb","sha":"061d492e25728531c20813cf6040c11dddc40f33","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":69604542,"name":"spaniel","full_name":"linkedin/spaniel","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/spaniel","description":"LinkedIn's JavaScript viewport tracking library and IntersectionObserver polyfill","fork":false,"url":"https://api.github.com/repos/linkedin/spaniel","forks_url":"https://api.github.com/repos/linkedin/spaniel/forks","keys_url":"https://api.github.com/repos/linkedin/spaniel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/spaniel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/spaniel/teams","hooks_url":"https://api.github.com/repos/linkedin/spaniel/hooks","issue_events_url":"https://api.github.com/repos/linkedin/spaniel/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/spaniel/events","assignees_url":"https://api.github.com/repos/linkedin/spaniel/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/spaniel/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/spaniel/tags","blobs_url":"https://api.github.com/repos/linkedin/spaniel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/spaniel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/spaniel/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/spaniel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/spaniel/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/spaniel/languages","stargazers_url":"https://api.github.com/repos/linkedin/spaniel/stargazers","contributors_url":"https://api.github.com/repos/linkedin/spaniel/contributors","subscribers_url":"https://api.github.com/repos/linkedin/spaniel/subscribers","subscription_url":"https://api.github.com/repos/linkedin/spaniel/subscription","commits_url":"https://api.github.com/repos/linkedin/spaniel/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/spaniel/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/spaniel/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/spaniel/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/spaniel/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/spaniel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/spaniel/merges","archive_url":"https://api.github.com/repos/linkedin/spaniel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/spaniel/downloads","issues_url":"https://api.github.com/repos/linkedin/spaniel/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/spaniel/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/spaniel/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/spaniel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/spaniel/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/spaniel/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/spaniel/deployments","created_at":"2016-09-29T20:18:52Z","updated_at":"2018-02-15T07:13:53Z","pushed_at":"2018-02-20T23:10:48Z","git_url":"git://github.com/linkedin/spaniel.git","ssh_url":"git@github.com:linkedin/spaniel.git","clone_url":"https://github.com/linkedin/spaniel.git","svn_url":"https://github.com/linkedin/spaniel","homepage":"","size":1255,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":17,"watchers":50,"default_branch":"master"}},"base":{"label":"linkedin:v2-release","ref":"v2-release","sha":"b10891c04a7a88bb191bbd5ec10a47e01cce6e81","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":69604542,"name":"spaniel","full_name":"linkedin/spaniel","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/spaniel","description":"LinkedIn's JavaScript viewport tracking library and IntersectionObserver polyfill","fork":false,"url":"https://api.github.com/repos/linkedin/spaniel","forks_url":"https://api.github.com/repos/linkedin/spaniel/forks","keys_url":"https://api.github.com/repos/linkedin/spaniel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/spaniel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/spaniel/teams","hooks_url":"https://api.github.com/repos/linkedin/spaniel/hooks","issue_events_url":"https://api.github.com/repos/linkedin/spaniel/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/spaniel/events","assignees_url":"https://api.github.com/repos/linkedin/spaniel/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/spaniel/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/spaniel/tags","blobs_url":"https://api.github.com/repos/linkedin/spaniel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/spaniel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/spaniel/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/spaniel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/spaniel/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/spaniel/languages","stargazers_url":"https://api.github.com/repos/linkedin/spaniel/stargazers","contributors_url":"https://api.github.com/repos/linkedin/spaniel/contributors","subscribers_url":"https://api.github.com/repos/linkedin/spaniel/subscribers","subscription_url":"https://api.github.com/repos/linkedin/spaniel/subscription","commits_url":"https://api.github.com/repos/linkedin/spaniel/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/spaniel/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/spaniel/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/spaniel/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/spaniel/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/spaniel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/spaniel/merges","archive_url":"https://api.github.com/repos/linkedin/spaniel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/spaniel/downloads","issues_url":"https://api.github.com/repos/linkedin/spaniel/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/spaniel/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/spaniel/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/spaniel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/spaniel/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/spaniel/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/spaniel/deployments","created_at":"2016-09-29T20:18:52Z","updated_at":"2018-02-15T07:13:53Z","pushed_at":"2018-02-20T23:10:48Z","git_url":"git://github.com/linkedin/spaniel.git","ssh_url":"git@github.com:linkedin/spaniel.git","clone_url":"https://github.com/linkedin/spaniel.git","svn_url":"https://github.com/linkedin/spaniel","homepage":"","size":1255,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":17,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/80"},"html":{"href":"https://github.com/linkedin/spaniel/pull/80"},"issue":{"href":"https://api.github.com/repos/linkedin/spaniel/issues/80"},"comments":{"href":"https://api.github.com/repos/linkedin/spaniel/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/spaniel/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/spaniel/statuses/061d492e25728531c20813cf6040c11dddc40f33"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"asakusuma"}}