{"action":"closed","number":2953,"pull_request":{"url":"https://api.github.com/repos/realm/realm-core/pulls/2953","id":158954367,"html_url":"https://github.com/realm/realm-core/pull/2953","diff_url":"https://github.com/realm/realm-core/pull/2953.diff","patch_url":"https://github.com/realm/realm-core/pull/2953.patch","issue_url":"https://api.github.com/repos/realm/realm-core/issues/2953","number":2953,"state":"closed","locked":false,"title":"Fix bug in Queries with two OR nodes at different nesting levels","user":{"login":"rrrlasse","id":1110156,"avatar_url":"https://avatars1.githubusercontent.com/u/1110156?v=4","gravatar_id":"","url":"https://api.github.com/users/rrrlasse","html_url":"https://github.com/rrrlasse","followers_url":"https://api.github.com/users/rrrlasse/followers","following_url":"https://api.github.com/users/rrrlasse/following{/other_user}","gists_url":"https://api.github.com/users/rrrlasse/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrlasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrlasse/subscriptions","organizations_url":"https://api.github.com/users/rrrlasse/orgs","repos_url":"https://api.github.com/users/rrrlasse/repos","events_url":"https://api.github.com/users/rrrlasse/events{/privacy}","received_events_url":"https://api.github.com/users/rrrlasse/received_events","type":"User","site_admin":false},"body":"@bdash can you verify this fix? It's a bit hard to see what's going on.\r\n\r\nIn the old code, the `or_node` variable was true when the second Or() was invoked (because it saw the first Or() node in `current_group.m_root_node.get()`. So all three conditions of the query ended up in `m_conditions` of the first Or().\r\n\r\n@kneth @beeender please carefully read the source code comment I have added to table.hpp for the link() and backlink() methods.","created_at":"2017-12-18T16:12:09Z","updated_at":"2018-02-21T12:33:21Z","closed_at":"2018-02-21T12:33:21Z","merged_at":"2018-02-21T12:33:21Z","merge_commit_sha":"f6561efc9489edd9be118a06ce75c309fde131f6","assignee":{"login":"rrrlasse","id":1110156,"avatar_url":"https://avatars1.githubusercontent.com/u/1110156?v=4","gravatar_id":"","url":"https://api.github.com/users/rrrlasse","html_url":"https://github.com/rrrlasse","followers_url":"https://api.github.com/users/rrrlasse/followers","following_url":"https://api.github.com/users/rrrlasse/following{/other_user}","gists_url":"https://api.github.com/users/rrrlasse/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrlasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrlasse/subscriptions","organizations_url":"https://api.github.com/users/rrrlasse/orgs","repos_url":"https://api.github.com/users/rrrlasse/repos","events_url":"https://api.github.com/users/rrrlasse/events{/privacy}","received_events_url":"https://api.github.com/users/rrrlasse/received_events","type":"User","site_admin":false},"assignees":[{"login":"rrrlasse","id":1110156,"avatar_url":"https://avatars1.githubusercontent.com/u/1110156?v=4","gravatar_id":"","url":"https://api.github.com/users/rrrlasse","html_url":"https://github.com/rrrlasse","followers_url":"https://api.github.com/users/rrrlasse/followers","following_url":"https://api.github.com/users/rrrlasse/following{/other_user}","gists_url":"https://api.github.com/users/rrrlasse/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrlasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrlasse/subscriptions","organizations_url":"https://api.github.com/users/rrrlasse/orgs","repos_url":"https://api.github.com/users/rrrlasse/repos","events_url":"https://api.github.com/users/rrrlasse/events{/privacy}","received_events_url":"https://api.github.com/users/rrrlasse/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":3772949,"url":"https://api.github.com/repos/realm/realm-core/labels/T:Bug","name":"T:Bug","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-core/pulls/2953/commits","review_comments_url":"https://api.github.com/repos/realm/realm-core/pulls/2953/comments","review_comment_url":"https://api.github.com/repos/realm/realm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-core/issues/2953/comments","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/ad97884da7665e88b78076ca52b5b2cae0ad8104","head":{"label":"realm:lr/query_fix","ref":"lr/query_fix","sha":"ad97884da7665e88b78076ca52b5b2cae0ad8104","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":1917262,"name":"realm-core","full_name":"realm/realm-core","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-core","description":"Core database component for the Realm Mobile Database SDKs","fork":false,"url":"https://api.github.com/repos/realm/realm-core","forks_url":"https://api.github.com/repos/realm/realm-core/forks","keys_url":"https://api.github.com/repos/realm/realm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-core/teams","hooks_url":"https://api.github.com/repos/realm/realm-core/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-core/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-core/events","assignees_url":"https://api.github.com/repos/realm/realm-core/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-core/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-core/tags","blobs_url":"https://api.github.com/repos/realm/realm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-core/languages","stargazers_url":"https://api.github.com/repos/realm/realm-core/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-core/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-core/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-core/subscription","commits_url":"https://api.github.com/repos/realm/realm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-core/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-core/merges","archive_url":"https://api.github.com/repos/realm/realm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-core/downloads","issues_url":"https://api.github.com/repos/realm/realm-core/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-core/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-core/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-core/deployments","created_at":"2011-06-18T21:18:46Z","updated_at":"2018-02-21T10:59:36Z","pushed_at":"2018-02-21T12:33:21Z","git_url":"git://github.com/realm/realm-core.git","ssh_url":"git@github.com:realm/realm-core.git","clone_url":"https://github.com/realm/realm-core.git","svn_url":"https://github.com/realm/realm-core","homepage":"https://realm.io","size":54921,"stargazers_count":634,"watchers_count":634,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":51,"open_issues":192,"watchers":634,"default_branch":"master"}},"base":{"label":"realm:develop","ref":"develop","sha":"ccc07b2d7cc080d5466270136c4062dd732398a4","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":1917262,"name":"realm-core","full_name":"realm/realm-core","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-core","description":"Core database component for the Realm Mobile Database SDKs","fork":false,"url":"https://api.github.com/repos/realm/realm-core","forks_url":"https://api.github.com/repos/realm/realm-core/forks","keys_url":"https://api.github.com/repos/realm/realm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-core/teams","hooks_url":"https://api.github.com/repos/realm/realm-core/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-core/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-core/events","assignees_url":"https://api.github.com/repos/realm/realm-core/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-core/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-core/tags","blobs_url":"https://api.github.com/repos/realm/realm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-core/languages","stargazers_url":"https://api.github.com/repos/realm/realm-core/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-core/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-core/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-core/subscription","commits_url":"https://api.github.com/repos/realm/realm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-core/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-core/merges","archive_url":"https://api.github.com/repos/realm/realm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-core/downloads","issues_url":"https://api.github.com/repos/realm/realm-core/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-core/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-core/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-core/deployments","created_at":"2011-06-18T21:18:46Z","updated_at":"2018-02-21T10:59:36Z","pushed_at":"2018-02-21T12:33:21Z","git_url":"git://github.com/realm/realm-core.git","ssh_url":"git@github.com:realm/realm-core.git","clone_url":"https://github.com/realm/realm-core.git","svn_url":"https://github.com/realm/realm-core","homepage":"https://realm.io","size":54921,"stargazers_count":634,"watchers_count":634,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":51,"open_issues":192,"watchers":634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2953"},"html":{"href":"https://github.com/realm/realm-core/pull/2953"},"issue":{"href":"https://api.github.com/repos/realm/realm-core/issues/2953"},"comments":{"href":"https://api.github.com/repos/realm/realm-core/issues/2953/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2953/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-core/pulls/2953/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-core/statuses/ad97884da7665e88b78076ca52b5b2cae0ad8104"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rrrlasse","id":1110156,"avatar_url":"https://avatars1.githubusercontent.com/u/1110156?v=4","gravatar_id":"","url":"https://api.github.com/users/rrrlasse","html_url":"https://github.com/rrrlasse","followers_url":"https://api.github.com/users/rrrlasse/followers","following_url":"https://api.github.com/users/rrrlasse/following{/other_user}","gists_url":"https://api.github.com/users/rrrlasse/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrlasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrlasse/subscriptions","organizations_url":"https://api.github.com/users/rrrlasse/orgs","repos_url":"https://api.github.com/users/rrrlasse/repos","events_url":"https://api.github.com/users/rrrlasse/events{/privacy}","received_events_url":"https://api.github.com/users/rrrlasse/received_events","type":"User","site_admin":false},"comments":11,"review_comments":6,"maintainer_can_modify":false,"commits":2,"additions":106,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"rrrlasse"}}