{"action":"closed","issue":{"url":"https://api.github.com/repos/cds-snc/nrcan-energuide-api-poc/issues/53","repository_url":"https://api.github.com/repos/cds-snc/nrcan-energuide-api-poc","labels_url":"https://api.github.com/repos/cds-snc/nrcan-energuide-api-poc/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/cds-snc/nrcan-energuide-api-poc/issues/53/comments","events_url":"https://api.github.com/repos/cds-snc/nrcan-energuide-api-poc/issues/53/events","html_url":"https://github.com/cds-snc/nrcan-energuide-api-poc/issues/53","id":313031368,"number":53,"title":"Accessibility Review","user":{"login":"dsamojlenko","id":1187115,"avatar_url":"https://avatars1.githubusercontent.com/u/1187115?v=4","gravatar_id":"","url":"https://api.github.com/users/dsamojlenko","html_url":"https://github.com/dsamojlenko","followers_url":"https://api.github.com/users/dsamojlenko/followers","following_url":"https://api.github.com/users/dsamojlenko/following{/other_user}","gists_url":"https://api.github.com/users/dsamojlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dsamojlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsamojlenko/subscriptions","organizations_url":"https://api.github.com/users/dsamojlenko/orgs","repos_url":"https://api.github.com/users/dsamojlenko/repos","events_url":"https://api.github.com/users/dsamojlenko/events{/privacy}","received_events_url":"https://api.github.com/users/dsamojlenko/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-10T18:04:20Z","updated_at":"2018-04-13T17:35:27Z","closed_at":"2018-04-13T17:35:27Z","author_association":"CONTRIBUTOR","body":"Results of a preliminary accessibility review conducted using Axe and Chrome Audits.\r\n\r\n## All Pages\r\n- ~~`<html>` element must have a lang attribute~~ https://dequeuniversity.com/rules/axe/3.0/html-has-lang\r\n- ~~`<meta>` Zooming and scaling must not be disabled~~ https://dequeuniversity.com/rules/axe/3.0/meta-viewport\r\n- ~~Content should be contained in a landmark region~~ https://dequeuniversity.com/rules/axe/3.0/region\r\n- ~~Language link should have lang attribute describing the language of the text (ie, `<a lang=\"fr\">Francais</a>`, `<a lang=\"en\">English</a>`)~~\r\n- ~~Tabindex seems to be used incorrectly~~  http://www.punkchip.com/correct-use-of-tabindex/\r\n- Colour contrast ratio issues (there are a bunch - check with Axe)\r\n\r\n## Home Page\r\n- ~~#pageWrap ID attribute must be unique~~ https://dequeuniversity.com/rules/axe/3.0/duplicate-id\r\n- ~~`<img>` Images must have alternate text or set as decorative~~ https://dequeuniversity.com/rules/axe/3.0/image-alt\r\n\r\n## Search\r\n- ~~#info ID attribute must be unique~~ https://dequeuniversity.com/rules/axe/3.0/duplicate-id\r\n- ~~Heading levels should only increase by one~~\r\n- ~~Help (?) icons - text reads as \"Question. A location refers to a region...\"  - should set the ? to invisible~~\r\n- ~~Help text should be associated with the form control (possibly with aria-describedby)~~ https://accessibility.18f.gov/forms/\r\n\r\n## Search by file ID\r\n- ~~\"aria-labelledby\" ARIA attributes must conform to valid values (seems like the id \"search-by-description\" doesn't exist?)~~\r\n\t- https://dequeuniversity.com/rules/axe/3.0/aria-valid-attr-value  \r\n\t- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute\r\n\r\n## Results-location\r\n- ~~Heading levels should only increase by one~~ https://dequeuniversity.com/rules/axe/3.0/heading-order\r\n- ~~Table data on this page is incomprehensible - should probably just use proper table markup with accessibility features~~\r\n\r\n# Non-accessibility-related comments\r\n\r\n## Performance Audit Score: 36/100\r\nRecommendations:\r\n- Enable text compression (server config)\r\n- Minify javascript (vendor.js)\r\n\r\n## General Comments\r\n- Page does not have a meta description (SEO)\r\n- Impossible to link directly to french language page equivalents?\r\n- Mailto link at the top goes to Paul\r\n- Should the image on the home page be loaded from Nick's personal github?"}}
{"actor":{"display_login":"dsamojlenko"}}