{"action":"created","comment":{"url":"https://api.github.com/repos/uber/prototool/pulls/comments/214632939","pull_request_review_id":151729626,"id":214632939,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDYzMjkzOQ==","diff_hunk":"@@ -63,6 +64,10 @@ func (f *flags) bindCallTimeout(flagSet *pflag.FlagSet) {\n \tflagSet.StringVar(&f.callTimeout, \"call-timeout\", \"60s\", \"The maximum time to for all calls to be completed.\")\n }\n \n+func (f *flags) bindCertificateFile(flagSet *pflag.FlagSet) {\n+\tflagSet.StringVar(&f.certificateFile, \"certificate\", \"\", \"SSL Certificate to make requests with.\")","path":"internal/cmd/flags.go","position":61,"original_position":61,"commit_id":"7bd642a49d7dd9ac463c4e3b9c0e9dcc2ce86eb2","original_commit_id":"7bd642a49d7dd9ac463c4e3b9c0e9dcc2ce86eb2","user":{"login":"peter-edge","id":4228796,"node_id":"MDQ6VXNlcjQyMjg3OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4228796?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"body":"Flag should either be named `--certificate-file` or variable should be named `certificate`.","created_at":"2018-09-03T09:49:27Z","updated_at":"2018-09-03T09:50:33Z","html_url":"https://github.com/uber/prototool/pull/216#discussion_r214632939","pull_request_url":"https://api.github.com/repos/uber/prototool/pulls/216","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uber/prototool/pulls/comments/214632939"},"html":{"href":"https://github.com/uber/prototool/pull/216#discussion_r214632939"},"pull_request":{"href":"https://api.github.com/repos/uber/prototool/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/uber/prototool/pulls/216","id":212352340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzUyMzQw","html_url":"https://github.com/uber/prototool/pull/216","diff_url":"https://github.com/uber/prototool/pull/216.diff","patch_url":"https://github.com/uber/prototool/pull/216.patch","issue_url":"https://api.github.com/repos/uber/prototool/issues/216","number":216,"state":"open","locked":false,"title":"Add support for transport credentials","user":{"login":"Willyham","id":169475,"node_id":"MDQ6VXNlcjE2OTQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/169475?v=4","gravatar_id":"","url":"https://api.github.com/users/Willyham","html_url":"https://github.com/Willyham","followers_url":"https://api.github.com/users/Willyham/followers","following_url":"https://api.github.com/users/Willyham/following{/other_user}","gists_url":"https://api.github.com/users/Willyham/gists{/gist_id}","starred_url":"https://api.github.com/users/Willyham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Willyham/subscriptions","organizations_url":"https://api.github.com/users/Willyham/orgs","repos_url":"https://api.github.com/users/Willyham/repos","events_url":"https://api.github.com/users/Willyham/events{/privacy}","received_events_url":"https://api.github.com/users/Willyham/received_events","type":"User","site_admin":false},"body":"This adds the ability to configure transport credentials from a file for `prototool grpc`. I'd appreciate some help testing this as I wasn't able to run it against one of our services due to (what I believe is) an unrelated error. However, running without the `--certificate` flag gives a connection error, and running with it just gives me one related to the method, so I believe that it is working correctly.","created_at":"2018-08-31T11:19:05Z","updated_at":"2018-09-03T09:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff2d24f0c58d86737e61225cf7e64c0b944bef3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/prototool/pulls/216/commits","review_comments_url":"https://api.github.com/repos/uber/prototool/pulls/216/comments","review_comment_url":"https://api.github.com/repos/uber/prototool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/prototool/issues/216/comments","statuses_url":"https://api.github.com/repos/uber/prototool/statuses/7bd642a49d7dd9ac463c4e3b9c0e9dcc2ce86eb2","head":{"label":"Willyham:dev","ref":"dev","sha":"7bd642a49d7dd9ac463c4e3b9c0e9dcc2ce86eb2","user":{"login":"Willyham","id":169475,"node_id":"MDQ6VXNlcjE2OTQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/169475?v=4","gravatar_id":"","url":"https://api.github.com/users/Willyham","html_url":"https://github.com/Willyham","followers_url":"https://api.github.com/users/Willyham/followers","following_url":"https://api.github.com/users/Willyham/following{/other_user}","gists_url":"https://api.github.com/users/Willyham/gists{/gist_id}","starred_url":"https://api.github.com/users/Willyham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Willyham/subscriptions","organizations_url":"https://api.github.com/users/Willyham/orgs","repos_url":"https://api.github.com/users/Willyham/repos","events_url":"https://api.github.com/users/Willyham/events{/privacy}","received_events_url":"https://api.github.com/users/Willyham/received_events","type":"User","site_admin":false},"repo":{"id":146878914,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4Nzg5MTQ=","name":"prototool","full_name":"Willyham/prototool","owner":{"login":"Willyham","id":169475,"node_id":"MDQ6VXNlcjE2OTQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/169475?v=4","gravatar_id":"","url":"https://api.github.com/users/Willyham","html_url":"https://github.com/Willyham","followers_url":"https://api.github.com/users/Willyham/followers","following_url":"https://api.github.com/users/Willyham/following{/other_user}","gists_url":"https://api.github.com/users/Willyham/gists{/gist_id}","starred_url":"https://api.github.com/users/Willyham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Willyham/subscriptions","organizations_url":"https://api.github.com/users/Willyham/orgs","repos_url":"https://api.github.com/users/Willyham/repos","events_url":"https://api.github.com/users/Willyham/events{/privacy}","received_events_url":"https://api.github.com/users/Willyham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Willyham/prototool","description":"Your Swiss Army Knife for Protocol Buffers","fork":true,"url":"https://api.github.com/repos/Willyham/prototool","forks_url":"https://api.github.com/repos/Willyham/prototool/forks","keys_url":"https://api.github.com/repos/Willyham/prototool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Willyham/prototool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Willyham/prototool/teams","hooks_url":"https://api.github.com/repos/Willyham/prototool/hooks","issue_events_url":"https://api.github.com/repos/Willyham/prototool/issues/events{/number}","events_url":"https://api.github.com/repos/Willyham/prototool/events","assignees_url":"https://api.github.com/repos/Willyham/prototool/assignees{/user}","branches_url":"https://api.github.com/repos/Willyham/prototool/branches{/branch}","tags_url":"https://api.github.com/repos/Willyham/prototool/tags","blobs_url":"https://api.github.com/repos/Willyham/prototool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Willyham/prototool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Willyham/prototool/git/refs{/sha}","trees_url":"https://api.github.com/repos/Willyham/prototool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Willyham/prototool/statuses/{sha}","languages_url":"https://api.github.com/repos/Willyham/prototool/languages","stargazers_url":"https://api.github.com/repos/Willyham/prototool/stargazers","contributors_url":"https://api.github.com/repos/Willyham/prototool/contributors","subscribers_url":"https://api.github.com/repos/Willyham/prototool/subscribers","subscription_url":"https://api.github.com/repos/Willyham/prototool/subscription","commits_url":"https://api.github.com/repos/Willyham/prototool/commits{/sha}","git_commits_url":"https://api.github.com/repos/Willyham/prototool/git/commits{/sha}","comments_url":"https://api.github.com/repos/Willyham/prototool/comments{/number}","issue_comment_url":"https://api.github.com/repos/Willyham/prototool/issues/comments{/number}","contents_url":"https://api.github.com/repos/Willyham/prototool/contents/{+path}","compare_url":"https://api.github.com/repos/Willyham/prototool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Willyham/prototool/merges","archive_url":"https://api.github.com/repos/Willyham/prototool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Willyham/prototool/downloads","issues_url":"https://api.github.com/repos/Willyham/prototool/issues{/number}","pulls_url":"https://api.github.com/repos/Willyham/prototool/pulls{/number}","milestones_url":"https://api.github.com/repos/Willyham/prototool/milestones{/number}","notifications_url":"https://api.github.com/repos/Willyham/prototool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Willyham/prototool/labels{/name}","releases_url":"https://api.github.com/repos/Willyham/prototool/releases{/id}","deployments_url":"https://api.github.com/repos/Willyham/prototool/deployments","created_at":"2018-08-31T10:42:27Z","updated_at":"2018-08-31T11:43:44Z","pushed_at":"2018-08-31T11:43:43Z","git_url":"git://github.com/Willyham/prototool.git","ssh_url":"git@github.com:Willyham/prototool.git","clone_url":"https://github.com/Willyham/prototool.git","svn_url":"https://github.com/Willyham/prototool","homepage":"","size":600,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"uber:dev","ref":"dev","sha":"26b9512c4847d5b64d0ac7a9613c4fc7aeb36e10","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":120625155,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2MjUxNTU=","name":"prototool","full_name":"uber/prototool","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/prototool","description":"Your Swiss Army Knife for Protocol Buffers","fork":false,"url":"https://api.github.com/repos/uber/prototool","forks_url":"https://api.github.com/repos/uber/prototool/forks","keys_url":"https://api.github.com/repos/uber/prototool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/prototool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/prototool/teams","hooks_url":"https://api.github.com/repos/uber/prototool/hooks","issue_events_url":"https://api.github.com/repos/uber/prototool/issues/events{/number}","events_url":"https://api.github.com/repos/uber/prototool/events","assignees_url":"https://api.github.com/repos/uber/prototool/assignees{/user}","branches_url":"https://api.github.com/repos/uber/prototool/branches{/branch}","tags_url":"https://api.github.com/repos/uber/prototool/tags","blobs_url":"https://api.github.com/repos/uber/prototool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/prototool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/prototool/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/prototool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/prototool/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/prototool/languages","stargazers_url":"https://api.github.com/repos/uber/prototool/stargazers","contributors_url":"https://api.github.com/repos/uber/prototool/contributors","subscribers_url":"https://api.github.com/repos/uber/prototool/subscribers","subscription_url":"https://api.github.com/repos/uber/prototool/subscription","commits_url":"https://api.github.com/repos/uber/prototool/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/prototool/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/prototool/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/prototool/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/prototool/contents/{+path}","compare_url":"https://api.github.com/repos/uber/prototool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/prototool/merges","archive_url":"https://api.github.com/repos/uber/prototool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/prototool/downloads","issues_url":"https://api.github.com/repos/uber/prototool/issues{/number}","pulls_url":"https://api.github.com/repos/uber/prototool/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/prototool/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/prototool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/prototool/labels{/name}","releases_url":"https://api.github.com/repos/uber/prototool/releases{/id}","deployments_url":"https://api.github.com/repos/uber/prototool/deployments","created_at":"2018-02-07T14:25:02Z","updated_at":"2018-09-03T08:20:36Z","pushed_at":"2018-08-31T17:46:27Z","git_url":"git://github.com/uber/prototool.git","ssh_url":"git@github.com:uber/prototool.git","clone_url":"https://github.com/uber/prototool.git","svn_url":"https://github.com/uber/prototool","homepage":"","size":618,"stargazers_count":2378,"watchers_count":2378,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":67,"open_issues":17,"watchers":2378,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/prototool/pulls/216"},"html":{"href":"https://github.com/uber/prototool/pull/216"},"issue":{"href":"https://api.github.com/repos/uber/prototool/issues/216"},"comments":{"href":"https://api.github.com/repos/uber/prototool/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/prototool/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/prototool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/prototool/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/uber/prototool/statuses/7bd642a49d7dd9ac463c4e3b9c0e9dcc2ce86eb2"}},"author_association":"NONE"}}
{"actor":{"display_login":"peter-edge"}}