{"action":"created","issue":{"url":"https://api.github.com/repos/iov-one/bcp-redux/issues/154","repository_url":"https://api.github.com/repos/iov-one/bcp-redux","labels_url":"https://api.github.com/repos/iov-one/bcp-redux/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/iov-one/bcp-redux/issues/154/comments","events_url":"https://api.github.com/repos/iov-one/bcp-redux/issues/154/events","html_url":"https://github.com/iov-one/bcp-redux/pull/154","id":365240311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjE0MjM1","number":154,"title":"Higher","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-30T16:47:09Z","updated_at":"2018-09-30T17:31:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/iov-one/bcp-redux/pulls/154","html_url":"https://github.com/iov-one/bcp-redux/pull/154","diff_url":"https://github.com/iov-one/bcp-redux/pull/154.diff","patch_url":"https://github.com/iov-one/bcp-redux/pull/154.patch"},"body":"This is from a follow-up on #153 about circular dependencies.\r\n\r\nWe would like a clean line/tree view.\r\n\r\nWe currently agree on this import direction (left imports right)\r\n`reducer -> actions -> prom -> selector -> {sync, util, helper...}`\r\n\r\nThere were a few items (only a few) that violated this rule, and it was agreed it was a good idea.\r\nI pulled these items into two new directories `boot`, which mixes promises and actions for the boot sequence. And `ai`, which is a auto-suggest selector that creates actions.\r\n\r\nThe code compiles with webpack and I greped imports to ensure the dependency chain is met.\r\nI am not sure if the new location names are proper, and am happy for feedback (or a PR on top of this), which reorganizes/renames these pieces.\r\n\r\nI am mainly interested in pulling out anything that violates `reducer -> actions -> prom -> selector`\r\n"},"comment":{"url":"https://api.github.com/repos/iov-one/bcp-redux/issues/comments/425737185","html_url":"https://github.com/iov-one/bcp-redux/pull/154#issuecomment-425737185","issue_url":"https://api.github.com/repos/iov-one/bcp-redux/issues/154","id":425737185,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTczNzE4NQ==","user":{"login":"rudi-cilibrasi","id":9170568,"node_id":"MDQ6VXNlcjkxNzA1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/9170568?v=4","gravatar_id":"","url":"https://api.github.com/users/rudi-cilibrasi","html_url":"https://github.com/rudi-cilibrasi","followers_url":"https://api.github.com/users/rudi-cilibrasi/followers","following_url":"https://api.github.com/users/rudi-cilibrasi/following{/other_user}","gists_url":"https://api.github.com/users/rudi-cilibrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudi-cilibrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudi-cilibrasi/subscriptions","organizations_url":"https://api.github.com/users/rudi-cilibrasi/orgs","repos_url":"https://api.github.com/users/rudi-cilibrasi/repos","events_url":"https://api.github.com/users/rudi-cilibrasi/events{/privacy}","received_events_url":"https://api.github.com/users/rudi-cilibrasi/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T17:31:54Z","updated_at":"2018-09-30T17:31:54Z","author_association":"MEMBER","body":"i noticed we can't necessarily consider selector basic level because it depends on reducers and actions. to be exact we need to split prom into those that depend on redux state and those that don't. one we have that then selector is inbetween those two kinds of prom so that is what i will try to split."}}
{"actor":{"display_login":"rudi-cilibrasi"}}