{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/186625325","pull_request_review_id":118237845,"id":186625325,"diff_hunk":"@@ -94,6 +97,45 @@ a list like so::\n Configuration\n -------------\n \n+SSL/TLS Support\n+^^^^^^^^^^^^^^^\n+\n+All HTTP connections to the dashboard are secured with SSL/TLS. \n+\n+You can generate a self-signed certificate with the command::\n+\n+  $ ceph dashboard create-self-signed-cert\n+\n+Note that most web browsers will complain about self-signed certificates and\n+require explicit confirmation before establishing a secure connection to the\n+dashboard.\n+\n+To properly secure a deployment, a certificate that is signed by your\n+organization's certificate authority should be used.\n+\n+For example, a key pair can be generated with a command similar to::\n+\n+  $ openssl req -new -nodes -x509 \\\n+    -subj \"/O=IT/CN=ceph-mgr-dashboard\" -days 3650 \\\n+    -keyout dashboard.key -out dashboard.crt -extensions v3_ca\n+\n+The ``dashboard.crt`` file should then be signed by your organization's CA\n+(certificate authority). Once that is done, you can set it with::\n+\n+  $ ceph config-key set mgr mgr/dashboard/$name/crt -i dashboard.crt\n+  $ ceph config-key set mgr mgr/dashboard/$name/key -i dashboard.key\n+\n+where ``$name`` is the name of the ``ceph-mgr`` instance (usually the\n+hostname). If all manager instances are to share the same certificate,\n+you can leave off the ``$name`` portion::\n+\n+  $ ceph config-key set mgr mgr/dashboard/crt -i dashboard.crt\n+  $ ceph config-key set mgr mgr/dashboard/key -i dashboard.key\n+\n+.. note::\n+  You need to restart the Ceph manager processes after changing the","path":"doc/mgr/dashboard.rst","position":50,"original_position":50,"commit_id":"52701fad2d7ca05420ad5f887b3552b8fdb2a42a","original_commit_id":"52701fad2d7ca05420ad5f887b3552b8fdb2a42a","user":{"login":"rjfd","id":17119885,"avatar_url":"https://avatars0.githubusercontent.com/u/17119885?v=4","gravatar_id":"","url":"https://api.github.com/users/rjfd","html_url":"https://github.com/rjfd","followers_url":"https://api.github.com/users/rjfd/followers","following_url":"https://api.github.com/users/rjfd/following{/other_user}","gists_url":"https://api.github.com/users/rjfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rjfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjfd/subscriptions","organizations_url":"https://api.github.com/users/rjfd/orgs","repos_url":"https://api.github.com/users/rjfd/repos","events_url":"https://api.github.com/users/rjfd/events{/privacy}","received_events_url":"https://api.github.com/users/rjfd/received_events","type":"User","site_admin":false},"body":"This is only true if you run the above `config-key` commands after enabling the dashboard module.\r\nMaybe we can add that \"If dashboard module is already running, then you need to reload the dashboard module ...\"","created_at":"2018-05-08T06:12:08Z","updated_at":"2018-05-08T06:12:08Z","html_url":"https://github.com/ceph/ceph/pull/21865#discussion_r186625325","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/21865","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/186625325"},"html":{"href":"https://github.com/ceph/ceph/pull/21865#discussion_r186625325"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21865"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21865","id":186458195,"html_url":"https://github.com/ceph/ceph/pull/21865","diff_url":"https://github.com/ceph/ceph/pull/21865.diff","patch_url":"https://github.com/ceph/ceph/pull/21865.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21865","number":21865,"state":"open","locked":false,"title":"doc: Updated dashboard documentation (features, SSL config)","user":{"login":"LenzGr","id":263427,"avatar_url":"https://avatars3.githubusercontent.com/u/263427?v=4","gravatar_id":"","url":"https://api.github.com/users/LenzGr","html_url":"https://github.com/LenzGr","followers_url":"https://api.github.com/users/LenzGr/followers","following_url":"https://api.github.com/users/LenzGr/following{/other_user}","gists_url":"https://api.github.com/users/LenzGr/gists{/gist_id}","starred_url":"https://api.github.com/users/LenzGr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenzGr/subscriptions","organizations_url":"https://api.github.com/users/LenzGr/orgs","repos_url":"https://api.github.com/users/LenzGr/repos","events_url":"https://api.github.com/users/LenzGr/events{/privacy}","received_events_url":"https://api.github.com/users/LenzGr/received_events","type":"User","site_admin":false},"body":"Updated Ceph manager dashboard documentation: added SSL to the feature overview, added new section about configuring SSL certificates.\r\n\r\nSigned-off-by: Lenz Grimmer <lgrimmer@suse.com>","created_at":"2018-05-07T20:39:49Z","updated_at":"2018-05-08T06:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"985fec0c9a7fec13e4aeae601c31858c2315852b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jcsp","id":944640,"avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":850326757,"url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":141186344,"url":"https://api.github.com/repos/ceph/ceph/labels/documentation","name":"documentation","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/11","html_url":"https://github.com/ceph/ceph/milestone/11","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/11/labels","id":3257614,"number":11,"title":"mimic","description":"","creator":{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":156,"state":"open","created_at":"2018-04-11T02:37:16Z","updated_at":"2018-05-07T23:00:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21865/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21865/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21865/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/52701fad2d7ca05420ad5f887b3552b8fdb2a42a","head":{"label":"LenzGr:mgr-dashboard-documentation","ref":"mgr-dashboard-documentation","sha":"52701fad2d7ca05420ad5f887b3552b8fdb2a42a","user":{"login":"LenzGr","id":263427,"avatar_url":"https://avatars3.githubusercontent.com/u/263427?v=4","gravatar_id":"","url":"https://api.github.com/users/LenzGr","html_url":"https://github.com/LenzGr","followers_url":"https://api.github.com/users/LenzGr/followers","following_url":"https://api.github.com/users/LenzGr/following{/other_user}","gists_url":"https://api.github.com/users/LenzGr/gists{/gist_id}","starred_url":"https://api.github.com/users/LenzGr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenzGr/subscriptions","organizations_url":"https://api.github.com/users/LenzGr/orgs","repos_url":"https://api.github.com/users/LenzGr/repos","events_url":"https://api.github.com/users/LenzGr/events{/privacy}","received_events_url":"https://api.github.com/users/LenzGr/received_events","type":"User","site_admin":false},"repo":{"id":37581630,"name":"ceph","full_name":"LenzGr/ceph","owner":{"login":"LenzGr","id":263427,"avatar_url":"https://avatars3.githubusercontent.com/u/263427?v=4","gravatar_id":"","url":"https://api.github.com/users/LenzGr","html_url":"https://github.com/LenzGr","followers_url":"https://api.github.com/users/LenzGr/followers","following_url":"https://api.github.com/users/LenzGr/following{/other_user}","gists_url":"https://api.github.com/users/LenzGr/gists{/gist_id}","starred_url":"https://api.github.com/users/LenzGr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenzGr/subscriptions","organizations_url":"https://api.github.com/users/LenzGr/orgs","repos_url":"https://api.github.com/users/LenzGr/repos","events_url":"https://api.github.com/users/LenzGr/events{/privacy}","received_events_url":"https://api.github.com/users/LenzGr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LenzGr/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/LenzGr/ceph","forks_url":"https://api.github.com/repos/LenzGr/ceph/forks","keys_url":"https://api.github.com/repos/LenzGr/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LenzGr/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LenzGr/ceph/teams","hooks_url":"https://api.github.com/repos/LenzGr/ceph/hooks","issue_events_url":"https://api.github.com/repos/LenzGr/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/LenzGr/ceph/events","assignees_url":"https://api.github.com/repos/LenzGr/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/LenzGr/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/LenzGr/ceph/tags","blobs_url":"https://api.github.com/repos/LenzGr/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LenzGr/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LenzGr/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/LenzGr/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LenzGr/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/LenzGr/ceph/languages","stargazers_url":"https://api.github.com/repos/LenzGr/ceph/stargazers","contributors_url":"https://api.github.com/repos/LenzGr/ceph/contributors","subscribers_url":"https://api.github.com/repos/LenzGr/ceph/subscribers","subscription_url":"https://api.github.com/repos/LenzGr/ceph/subscription","commits_url":"https://api.github.com/repos/LenzGr/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/LenzGr/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/LenzGr/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/LenzGr/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/LenzGr/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/LenzGr/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LenzGr/ceph/merges","archive_url":"https://api.github.com/repos/LenzGr/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LenzGr/ceph/downloads","issues_url":"https://api.github.com/repos/LenzGr/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/LenzGr/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/LenzGr/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/LenzGr/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LenzGr/ceph/labels{/name}","releases_url":"https://api.github.com/repos/LenzGr/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/LenzGr/ceph/deployments","created_at":"2015-06-17T08:10:23Z","updated_at":"2018-05-07T20:41:53Z","pushed_at":"2018-05-07T20:41:46Z","git_url":"git://github.com/LenzGr/ceph.git","ssh_url":"git@github.com:LenzGr/ceph.git","clone_url":"https://github.com/LenzGr/ceph.git","svn_url":"https://github.com/LenzGr/ceph","homepage":"http://ceph.com","size":253743,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"42258c637add92deae14f7bd32806f835db07a80","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-05-08T06:05:15Z","pushed_at":"2018-05-08T06:03:14Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":281851,"stargazers_count":4464,"watchers_count":4464,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2432,"mirror_url":null,"archived":false,"open_issues_count":683,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2432,"open_issues":683,"watchers":4464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21865"},"html":{"href":"https://github.com/ceph/ceph/pull/21865"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21865"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21865/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21865/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21865/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/52701fad2d7ca05420ad5f887b3552b8fdb2a42a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rjfd"}}