{"action":"created","comment":{"url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/comments/198554474","pull_request_review_id":132504113,"id":198554474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODU1NDQ3NA==","diff_hunk":"@@ -18,14 +25,34 @@ namespace ADAFRUIT_SI7021 {\n         }\n     }\n \n-    float readTemperature()\n+    bool start()\n+    {\n+        return true;\n+    }\n+\n+    size_t read(char* buf, int len)\n+    {\n+        float temp = sensor.readTemperature() * 1.8 + 32;","path":"lib/KnightLab_Sensors/src/KL_ADAFRUIT_SI7021.cpp","position":33,"original_position":33,"commit_id":"edf55b3ea8b9fd893628f99717e91b2fb9a23abb","original_commit_id":"edf55b3ea8b9fd893628f99717e91b2fb9a23abb","user":{"login":"scott2b","id":307713,"node_id":"MDQ6VXNlcjMwNzcxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/307713?v=4","gravatar_id":"","url":"https://api.github.com/users/scott2b","html_url":"https://github.com/scott2b","followers_url":"https://api.github.com/users/scott2b/followers","following_url":"https://api.github.com/users/scott2b/following{/other_user}","gists_url":"https://api.github.com/users/scott2b/gists{/gist_id}","starred_url":"https://api.github.com/users/scott2b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott2b/subscriptions","organizations_url":"https://api.github.com/users/scott2b/orgs","repos_url":"https://api.github.com/users/scott2b/repos","events_url":"https://api.github.com/users/scott2b/events{/privacy}","received_events_url":"https://api.github.com/users/scott2b/received_events","type":"User","site_admin":false},"body":"is this compiling. Should be pulling readTemperature and readHumidity from the local namespace of this driver\r\n","created_at":"2018-06-27T16:13:23Z","updated_at":"2018-06-27T16:13:24Z","html_url":"https://github.com/NUKnightLab/SensorGrid/pull/52#discussion_r198554474","pull_request_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/comments/198554474"},"html":{"href":"https://github.com/NUKnightLab/SensorGrid/pull/52#discussion_r198554474"},"pull_request":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52","id":197780280,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzgwMjgw","html_url":"https://github.com/NUKnightLab/SensorGrid/pull/52","diff_url":"https://github.com/NUKnightLab/SensorGrid/pull/52.diff","patch_url":"https://github.com/NUKnightLab/SensorGrid/pull/52.patch","issue_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/52","number":52,"state":"open","locked":false,"title":"Implemented sensor API for honeywell and humidty/temp","user":{"login":"jdk27","id":33162136,"node_id":"MDQ6VXNlcjMzMTYyMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/33162136?v=4","gravatar_id":"","url":"https://api.github.com/users/jdk27","html_url":"https://github.com/jdk27","followers_url":"https://api.github.com/users/jdk27/followers","following_url":"https://api.github.com/users/jdk27/following{/other_user}","gists_url":"https://api.github.com/users/jdk27/gists{/gist_id}","starred_url":"https://api.github.com/users/jdk27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdk27/subscriptions","organizations_url":"https://api.github.com/users/jdk27/orgs","repos_url":"https://api.github.com/users/jdk27/repos","events_url":"https://api.github.com/users/jdk27/events{/privacy}","received_events_url":"https://api.github.com/users/jdk27/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-27T16:00:39Z","updated_at":"2018-06-27T16:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e518b0d27d6338f561959492396d846a8eb2c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52/commits","review_comments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52/comments","review_comment_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/52/comments","statuses_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/statuses/edf55b3ea8b9fd893628f99717e91b2fb9a23abb","head":{"label":"NUKnightLab:josh.sensorAPI","ref":"josh.sensorAPI","sha":"edf55b3ea8b9fd893628f99717e91b2fb9a23abb","user":{"login":"NUKnightLab","id":1273909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzM5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1273909?v=4","gravatar_id":"","url":"https://api.github.com/users/NUKnightLab","html_url":"https://github.com/NUKnightLab","followers_url":"https://api.github.com/users/NUKnightLab/followers","following_url":"https://api.github.com/users/NUKnightLab/following{/other_user}","gists_url":"https://api.github.com/users/NUKnightLab/gists{/gist_id}","starred_url":"https://api.github.com/users/NUKnightLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NUKnightLab/subscriptions","organizations_url":"https://api.github.com/users/NUKnightLab/orgs","repos_url":"https://api.github.com/users/NUKnightLab/repos","events_url":"https://api.github.com/users/NUKnightLab/events{/privacy}","received_events_url":"https://api.github.com/users/NUKnightLab/received_events","type":"Organization","site_admin":false},"repo":{"id":81235519,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIzNTUxOQ==","name":"SensorGrid","full_name":"NUKnightLab/SensorGrid","owner":{"login":"NUKnightLab","id":1273909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzM5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1273909?v=4","gravatar_id":"","url":"https://api.github.com/users/NUKnightLab","html_url":"https://github.com/NUKnightLab","followers_url":"https://api.github.com/users/NUKnightLab/followers","following_url":"https://api.github.com/users/NUKnightLab/following{/other_user}","gists_url":"https://api.github.com/users/NUKnightLab/gists{/gist_id}","starred_url":"https://api.github.com/users/NUKnightLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NUKnightLab/subscriptions","organizations_url":"https://api.github.com/users/NUKnightLab/orgs","repos_url":"https://api.github.com/users/NUKnightLab/repos","events_url":"https://api.github.com/users/NUKnightLab/events{/privacy}","received_events_url":"https://api.github.com/users/NUKnightLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NUKnightLab/SensorGrid","description":null,"fork":false,"url":"https://api.github.com/repos/NUKnightLab/SensorGrid","forks_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/forks","keys_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/teams","hooks_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/hooks","issue_events_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/events{/number}","events_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/events","assignees_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/assignees{/user}","branches_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/branches{/branch}","tags_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/tags","blobs_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/statuses/{sha}","languages_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/languages","stargazers_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/stargazers","contributors_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/contributors","subscribers_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/subscribers","subscription_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/subscription","commits_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/contents/{+path}","compare_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/merges","archive_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/downloads","issues_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues{/number}","pulls_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls{/number}","milestones_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/milestones{/number}","notifications_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/labels{/name}","releases_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/releases{/id}","deployments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/deployments","created_at":"2017-02-07T17:35:59Z","updated_at":"2018-06-26T21:44:35Z","pushed_at":"2018-06-27T16:07:11Z","git_url":"git://github.com/NUKnightLab/SensorGrid.git","ssh_url":"git@github.com:NUKnightLab/SensorGrid.git","clone_url":"https://github.com/NUKnightLab/SensorGrid.git","svn_url":"https://github.com/NUKnightLab/SensorGrid","homepage":null,"size":24715,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"base":{"label":"NUKnightLab:master","ref":"master","sha":"326c8108dde7bc9f0d3f7ec4f2c9de1ff07550e4","user":{"login":"NUKnightLab","id":1273909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzM5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1273909?v=4","gravatar_id":"","url":"https://api.github.com/users/NUKnightLab","html_url":"https://github.com/NUKnightLab","followers_url":"https://api.github.com/users/NUKnightLab/followers","following_url":"https://api.github.com/users/NUKnightLab/following{/other_user}","gists_url":"https://api.github.com/users/NUKnightLab/gists{/gist_id}","starred_url":"https://api.github.com/users/NUKnightLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NUKnightLab/subscriptions","organizations_url":"https://api.github.com/users/NUKnightLab/orgs","repos_url":"https://api.github.com/users/NUKnightLab/repos","events_url":"https://api.github.com/users/NUKnightLab/events{/privacy}","received_events_url":"https://api.github.com/users/NUKnightLab/received_events","type":"Organization","site_admin":false},"repo":{"id":81235519,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIzNTUxOQ==","name":"SensorGrid","full_name":"NUKnightLab/SensorGrid","owner":{"login":"NUKnightLab","id":1273909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzM5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1273909?v=4","gravatar_id":"","url":"https://api.github.com/users/NUKnightLab","html_url":"https://github.com/NUKnightLab","followers_url":"https://api.github.com/users/NUKnightLab/followers","following_url":"https://api.github.com/users/NUKnightLab/following{/other_user}","gists_url":"https://api.github.com/users/NUKnightLab/gists{/gist_id}","starred_url":"https://api.github.com/users/NUKnightLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NUKnightLab/subscriptions","organizations_url":"https://api.github.com/users/NUKnightLab/orgs","repos_url":"https://api.github.com/users/NUKnightLab/repos","events_url":"https://api.github.com/users/NUKnightLab/events{/privacy}","received_events_url":"https://api.github.com/users/NUKnightLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NUKnightLab/SensorGrid","description":null,"fork":false,"url":"https://api.github.com/repos/NUKnightLab/SensorGrid","forks_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/forks","keys_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/teams","hooks_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/hooks","issue_events_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/events{/number}","events_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/events","assignees_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/assignees{/user}","branches_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/branches{/branch}","tags_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/tags","blobs_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/statuses/{sha}","languages_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/languages","stargazers_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/stargazers","contributors_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/contributors","subscribers_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/subscribers","subscription_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/subscription","commits_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/contents/{+path}","compare_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/merges","archive_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/downloads","issues_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues{/number}","pulls_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls{/number}","milestones_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/milestones{/number}","notifications_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/labels{/name}","releases_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/releases{/id}","deployments_url":"https://api.github.com/repos/NUKnightLab/SensorGrid/deployments","created_at":"2017-02-07T17:35:59Z","updated_at":"2018-06-26T21:44:35Z","pushed_at":"2018-06-27T16:07:11Z","git_url":"git://github.com/NUKnightLab/SensorGrid.git","ssh_url":"git@github.com:NUKnightLab/SensorGrid.git","clone_url":"https://github.com/NUKnightLab/SensorGrid.git","svn_url":"https://github.com/NUKnightLab/SensorGrid","homepage":null,"size":24715,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52"},"html":{"href":"https://github.com/NUKnightLab/SensorGrid/pull/52"},"issue":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/52"},"comments":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/NUKnightLab/SensorGrid/statuses/edf55b3ea8b9fd893628f99717e91b2fb9a23abb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scott2b"}}