{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/AspNetCore/issues/4628","repository_url":"https://api.github.com/repos/aspnet/AspNetCore","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/4628/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/4628/comments","events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/4628/events","html_url":"https://github.com/aspnet/AspNetCore/pull/4628","id":390449058,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjEzOTU2","number":4628,"title":"Remove many `CompatibilitySwitch<T>` properties","user":{"login":"dougbu","id":6431421,"node_id":"MDQ6VXNlcjY0MzE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-12T23:11:25Z","updated_at":"2018-12-14T23:42:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/4628","html_url":"https://github.com/aspnet/AspNetCore/pull/4628","diff_url":"https://github.com/aspnet/AspNetCore/pull/4628.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/4628.patch"},"body":"- #4866 2 of 3\r\n- will leave one `IEnumerable<ICompatibilitySwitch>` implementation: `MvcOptions`\r\n- will leave one `ConfigureCompatibilityOptions<MvcOptions>` subclass: `MvcOptionsConfigureCompatibilityOptions`\r\n- a few options remain as regular properties:\r\n  - `ApiBehaviorOptions.SuppressMapClientErrors` (default `false`)\r\n  - `MvcOptions.EnableEndpointRouting` (default `true`)\r\n  - `MvcOptions.MaxValidationDepth` (default `32`)\r\n  - `MvcJsonOptions.AllowInputFormatterExceptionMessages` (default `true`)\r\n- remains possible to disable many features\r\n  - e.g. replace `IModelBinderProvider`s with ones that pass `allowValidatingTopLevelNodes: false`"},"comment":{"url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments/447511404","html_url":"https://github.com/aspnet/AspNetCore/pull/4628#issuecomment-447511404","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/4628","id":447511404,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzUxMTQwNA==","user":{"login":"dougbu","id":6431421,"node_id":"MDQ6VXNlcjY0MzE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T23:42:41Z","updated_at":"2018-12-14T23:42:41Z","author_association":"MEMBER","body":"@pranavkm I couldn't understand a couple of your comments&hellip;\r\n\r\nFor `ApiBehaviorOptionsSetup`:\r\n> In 3.0, `InvalidModelStateResponseFactory` would default to returning a `ProblemDetails` instance (i.e. `options.InvalidModelStateResponseFactory = ProblemDetailsFactory;`) and `SuppressMapClientErrors` would have no bearing on it. Any user configured factory would take precedence over the default\r\n\r\nFor `GlobalAuthorizationFilterTest`:\r\n> `[Authorize]`"}}
{"actor":{"display_login":"dougbu"}}