{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/181697971","pull_request_review_id":112369630,"id":181697971,"diff_hunk":"@@ -73,8 +73,8 @@ void auto_init_io1_xplained(void)\n \n         /* GPIOs */\n         for (unsigned j = 1; j < 4; j++) {\n-            saul_entries[i * 4 + j].dev = &(io1_xplained_saul_gpios[j]);\n-            saul_entries[i * 4 + j].name = io1_xplained_saul_info[i][j].name;\n+            saul_entries[i * 4 + j].dev = &(io1_xplained_saul_gpios[j - 1]);\n+            saul_entries[i * 4 + j].name = io1_xplained_saul_info[i][j - 1].name;","path":"sys/auto_init/saul/auto_init_io1_xplained.c","position":7,"original_position":7,"commit_id":"4c36321ca07f5d1f1610d0a436d714ef173f3a0d","original_commit_id":"4c36321ca07f5d1f1610d0a436d714ef173f3a0d","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"`IO1_XPLAINED_NUM` is number of extension boards (device) with 4 sub-devices (temperature and gpios). So no, we can't use this.","created_at":"2018-04-16T11:09:17Z","updated_at":"2018-04-16T11:09:17Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8960#discussion_r181697971","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/181697971"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8960#discussion_r181697971"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960"}},"in_reply_to_id":181674912},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960","id":181792460,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8960","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8960.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8960.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8960","number":8960,"state":"open","locked":false,"title":"drivers/io1_xplained: fix gpios devices initialization","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nThis PR fixes the GPIOs auto initalizers for the IO1 Xplained pro extension.\r\n\r\nThere were several issues:\r\n- the gpio index used to set the saul registry were not pointing to the right device (in sys/auto_init)\r\n- the configured params were using the gpio pins directly instead of using `saul_gpio_params` structs\r\n- the previous points requires to exclude the `saul_gpio_params` struct initializer in case `saul_gpio` module is not loaded\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n\r\n### Issues/PRs references\r\n\r\nFixes #8766\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2018-04-16T08:55:12Z","updated_at":"2018-04-16T11:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c05fbbe96687c2b38ff6f8b4a18f4e9f8e2afa5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":23399098,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/bug","name":"bug","color":"fc2929","default":true},{"id":135467271,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false}],"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/22","html_url":"https://github.com/RIOT-OS/RIOT/milestone/22","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/22/labels","id":3030855,"number":22,"title":"Release 2018.04","description":"","creator":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":97,"state":"open","created_at":"2018-01-12T08:24:04Z","updated_at":"2018-04-16T10:34:26Z","due_on":"2018-04-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8960/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/4c36321ca07f5d1f1610d0a436d714ef173f3a0d","head":{"label":"aabadie:pr/drivers/io1_xplained_gpio_fix","ref":"pr/drivers/io1_xplained_gpio_fix","sha":"4c36321ca07f5d1f1610d0a436d714ef173f3a0d","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"repo":{"id":44016379,"name":"RIOT","full_name":"aabadie/RIOT","owner":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aabadie/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/aabadie/RIOT","forks_url":"https://api.github.com/repos/aabadie/RIOT/forks","keys_url":"https://api.github.com/repos/aabadie/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aabadie/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aabadie/RIOT/teams","hooks_url":"https://api.github.com/repos/aabadie/RIOT/hooks","issue_events_url":"https://api.github.com/repos/aabadie/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/aabadie/RIOT/events","assignees_url":"https://api.github.com/repos/aabadie/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/aabadie/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/aabadie/RIOT/tags","blobs_url":"https://api.github.com/repos/aabadie/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aabadie/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aabadie/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/aabadie/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aabadie/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/aabadie/RIOT/languages","stargazers_url":"https://api.github.com/repos/aabadie/RIOT/stargazers","contributors_url":"https://api.github.com/repos/aabadie/RIOT/contributors","subscribers_url":"https://api.github.com/repos/aabadie/RIOT/subscribers","subscription_url":"https://api.github.com/repos/aabadie/RIOT/subscription","commits_url":"https://api.github.com/repos/aabadie/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/aabadie/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/aabadie/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/aabadie/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/aabadie/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/aabadie/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aabadie/RIOT/merges","archive_url":"https://api.github.com/repos/aabadie/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aabadie/RIOT/downloads","issues_url":"https://api.github.com/repos/aabadie/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/aabadie/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/aabadie/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/aabadie/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aabadie/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/aabadie/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/aabadie/RIOT/deployments","created_at":"2015-10-10T15:36:27Z","updated_at":"2016-10-29T18:27:28Z","pushed_at":"2018-04-16T09:26:17Z","git_url":"git://github.com/aabadie/RIOT.git","ssh_url":"git@github.com:aabadie/RIOT.git","clone_url":"https://github.com/aabadie/RIOT.git","svn_url":"https://github.com/aabadie/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":51741,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"6089910e6efd733c1789bd12effdc118ac118666","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-04-16T10:50:07Z","pushed_at":"2018-04-16T11:08:14Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":51011,"stargazers_count":1737,"watchers_count":1737,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1037,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1037,"open_issues":721,"watchers":1737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8960"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8960"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8960/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8960/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/4c36321ca07f5d1f1610d0a436d714ef173f3a0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aabadie"}}