{"action":"created","comment":{"url":"https://api.github.com/repos/cloudreach/sceptre/pulls/comments/234962810","pull_request_review_id":176703049,"id":234962810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk2MjgxMA==","diff_hunk":"@@ -376,11 +386,12 @@ def _collect_s3_details(stack_name, config):\n \n     def _construct_stack(self, rel_path, stack_group_config=None):\n         \"\"\"\n-        Construct a Stack object from a config path and a base config.\n+        Constructs an individual Stack object from a config path and a\n+        base config.\n \n         :param rel_path: A relative config file path.\n         :type rel_path: str\n-        :param config: Base config to use as defaults.\n+        :param stack_group_config: The Stack group config to use as defaults.\n         :type config: dict","path":"sceptre/config/reader.py","position":107,"original_position":107,"commit_id":"66c3dc7d38f76bdc70ae7a25f140aee38969e02c","original_commit_id":"66c3dc7d38f76bdc70ae7a25f140aee38969e02c","user":{"login":"connec","id":160652,"node_id":"MDQ6VXNlcjE2MDY1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/160652?v=4","gravatar_id":"","url":"https://api.github.com/users/connec","html_url":"https://github.com/connec","followers_url":"https://api.github.com/users/connec/followers","following_url":"https://api.github.com/users/connec/following{/other_user}","gists_url":"https://api.github.com/users/connec/gists{/gist_id}","starred_url":"https://api.github.com/users/connec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connec/subscriptions","organizations_url":"https://api.github.com/users/connec/orgs","repos_url":"https://api.github.com/users/connec/repos","events_url":"https://api.github.com/users/connec/events{/privacy}","received_events_url":"https://api.github.com/users/connec/received_events","type":"User","site_admin":false},"body":"This name needs update as well to `stack_group_config`.","created_at":"2018-11-20T11:18:49Z","updated_at":"2018-11-20T11:40:34Z","html_url":"https://github.com/cloudreach/sceptre/pull/506#discussion_r234962810","pull_request_url":"https://api.github.com/repos/cloudreach/sceptre/pulls/506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/comments/234962810"},"html":{"href":"https://github.com/cloudreach/sceptre/pull/506#discussion_r234962810"},"pull_request":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/506"}}},"pull_request":{"url":"https://api.github.com/repos/cloudreach/sceptre/pulls/506","id":232137872,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTM3ODcy","html_url":"https://github.com/cloudreach/sceptre/pull/506","diff_url":"https://github.com/cloudreach/sceptre/pull/506.diff","patch_url":"https://github.com/cloudreach/sceptre/pull/506.patch","issue_url":"https://api.github.com/repos/cloudreach/sceptre/issues/506","number":506,"state":"open","locked":false,"title":"Update docstrings","user":{"login":"ngfgrant","id":6362273,"node_id":"MDQ6VXNlcjYzNjIyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6362273?v=4","gravatar_id":"","url":"https://api.github.com/users/ngfgrant","html_url":"https://github.com/ngfgrant","followers_url":"https://api.github.com/users/ngfgrant/followers","following_url":"https://api.github.com/users/ngfgrant/following{/other_user}","gists_url":"https://api.github.com/users/ngfgrant/gists{/gist_id}","starred_url":"https://api.github.com/users/ngfgrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngfgrant/subscriptions","organizations_url":"https://api.github.com/users/ngfgrant/orgs","repos_url":"https://api.github.com/users/ngfgrant/repos","events_url":"https://api.github.com/users/ngfgrant/events{/privacy}","received_events_url":"https://api.github.com/users/ngfgrant/received_events","type":"User","site_admin":false},"body":"Update Docstrings\r\n\r\nThis PR goes reviewed each file in the project to make sure the docstrings were accurate and consistent for the upcoming v2 release. \r\n\r\n-----------------\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] [Squashed related commits together][2] after the changes have been approved.\r\n* [x] Commit message starts with `[Resolve #issue-number]` (if a related issue exists).\r\n* [x] Added unit tests.\r\n* [x] Added integration tests (if applicable).\r\n* [x] All unit tests (`make test`) are passing.\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] The new code doesn't generate flake8 (`make lint`) offenses.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.","created_at":"2018-11-19T22:52:24Z","updated_at":"2018-11-20T11:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d49a8761fff543ab4f4612178e4666548bf980d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudreach/sceptre/pulls/506/commits","review_comments_url":"https://api.github.com/repos/cloudreach/sceptre/pulls/506/comments","review_comment_url":"https://api.github.com/repos/cloudreach/sceptre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudreach/sceptre/issues/506/comments","statuses_url":"https://api.github.com/repos/cloudreach/sceptre/statuses/66c3dc7d38f76bdc70ae7a25f140aee38969e02c","head":{"label":"cloudreach:update-doc-string-merged","ref":"update-doc-string-merged","sha":"66c3dc7d38f76bdc70ae7a25f140aee38969e02c","user":{"login":"cloudreach","id":104136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/104136?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudreach","html_url":"https://github.com/cloudreach","followers_url":"https://api.github.com/users/cloudreach/followers","following_url":"https://api.github.com/users/cloudreach/following{/other_user}","gists_url":"https://api.github.com/users/cloudreach/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudreach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudreach/subscriptions","organizations_url":"https://api.github.com/users/cloudreach/orgs","repos_url":"https://api.github.com/users/cloudreach/repos","events_url":"https://api.github.com/users/cloudreach/events{/privacy}","received_events_url":"https://api.github.com/users/cloudreach/received_events","type":"Organization","site_admin":false},"repo":{"id":80561803,"node_id":"MDEwOlJlcG9zaXRvcnk4MDU2MTgwMw==","name":"sceptre","full_name":"cloudreach/sceptre","private":false,"owner":{"login":"cloudreach","id":104136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/104136?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudreach","html_url":"https://github.com/cloudreach","followers_url":"https://api.github.com/users/cloudreach/followers","following_url":"https://api.github.com/users/cloudreach/following{/other_user}","gists_url":"https://api.github.com/users/cloudreach/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudreach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudreach/subscriptions","organizations_url":"https://api.github.com/users/cloudreach/orgs","repos_url":"https://api.github.com/users/cloudreach/repos","events_url":"https://api.github.com/users/cloudreach/events{/privacy}","received_events_url":"https://api.github.com/users/cloudreach/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudreach/sceptre","description":"Build better AWS infrastructure","fork":false,"url":"https://api.github.com/repos/cloudreach/sceptre","forks_url":"https://api.github.com/repos/cloudreach/sceptre/forks","keys_url":"https://api.github.com/repos/cloudreach/sceptre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudreach/sceptre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudreach/sceptre/teams","hooks_url":"https://api.github.com/repos/cloudreach/sceptre/hooks","issue_events_url":"https://api.github.com/repos/cloudreach/sceptre/issues/events{/number}","events_url":"https://api.github.com/repos/cloudreach/sceptre/events","assignees_url":"https://api.github.com/repos/cloudreach/sceptre/assignees{/user}","branches_url":"https://api.github.com/repos/cloudreach/sceptre/branches{/branch}","tags_url":"https://api.github.com/repos/cloudreach/sceptre/tags","blobs_url":"https://api.github.com/repos/cloudreach/sceptre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudreach/sceptre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudreach/sceptre/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudreach/sceptre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudreach/sceptre/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudreach/sceptre/languages","stargazers_url":"https://api.github.com/repos/cloudreach/sceptre/stargazers","contributors_url":"https://api.github.com/repos/cloudreach/sceptre/contributors","subscribers_url":"https://api.github.com/repos/cloudreach/sceptre/subscribers","subscription_url":"https://api.github.com/repos/cloudreach/sceptre/subscription","commits_url":"https://api.github.com/repos/cloudreach/sceptre/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudreach/sceptre/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudreach/sceptre/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudreach/sceptre/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudreach/sceptre/contents/{+path}","compare_url":"https://api.github.com/repos/cloudreach/sceptre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudreach/sceptre/merges","archive_url":"https://api.github.com/repos/cloudreach/sceptre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudreach/sceptre/downloads","issues_url":"https://api.github.com/repos/cloudreach/sceptre/issues{/number}","pulls_url":"https://api.github.com/repos/cloudreach/sceptre/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudreach/sceptre/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudreach/sceptre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudreach/sceptre/labels{/name}","releases_url":"https://api.github.com/repos/cloudreach/sceptre/releases{/id}","deployments_url":"https://api.github.com/repos/cloudreach/sceptre/deployments","created_at":"2017-01-31T21:00:39Z","updated_at":"2018-11-20T00:27:59Z","pushed_at":"2018-11-19T22:56:03Z","git_url":"git://github.com/cloudreach/sceptre.git","ssh_url":"git@github.com:cloudreach/sceptre.git","clone_url":"https://github.com/cloudreach/sceptre.git","svn_url":"https://github.com/cloudreach/sceptre","homepage":"https://sceptre.cloudreach.com","size":916,"stargazers_count":632,"watchers_count":632,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":161,"open_issues":98,"watchers":632,"default_branch":"master"}},"base":{"label":"cloudreach:v2-rc-merged","ref":"v2-rc-merged","sha":"9c40e12f720f331c0efb2c0974e5f97acee7e714","user":{"login":"cloudreach","id":104136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/104136?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudreach","html_url":"https://github.com/cloudreach","followers_url":"https://api.github.com/users/cloudreach/followers","following_url":"https://api.github.com/users/cloudreach/following{/other_user}","gists_url":"https://api.github.com/users/cloudreach/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudreach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudreach/subscriptions","organizations_url":"https://api.github.com/users/cloudreach/orgs","repos_url":"https://api.github.com/users/cloudreach/repos","events_url":"https://api.github.com/users/cloudreach/events{/privacy}","received_events_url":"https://api.github.com/users/cloudreach/received_events","type":"Organization","site_admin":false},"repo":{"id":80561803,"node_id":"MDEwOlJlcG9zaXRvcnk4MDU2MTgwMw==","name":"sceptre","full_name":"cloudreach/sceptre","private":false,"owner":{"login":"cloudreach","id":104136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDEzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/104136?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudreach","html_url":"https://github.com/cloudreach","followers_url":"https://api.github.com/users/cloudreach/followers","following_url":"https://api.github.com/users/cloudreach/following{/other_user}","gists_url":"https://api.github.com/users/cloudreach/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudreach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudreach/subscriptions","organizations_url":"https://api.github.com/users/cloudreach/orgs","repos_url":"https://api.github.com/users/cloudreach/repos","events_url":"https://api.github.com/users/cloudreach/events{/privacy}","received_events_url":"https://api.github.com/users/cloudreach/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudreach/sceptre","description":"Build better AWS infrastructure","fork":false,"url":"https://api.github.com/repos/cloudreach/sceptre","forks_url":"https://api.github.com/repos/cloudreach/sceptre/forks","keys_url":"https://api.github.com/repos/cloudreach/sceptre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudreach/sceptre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudreach/sceptre/teams","hooks_url":"https://api.github.com/repos/cloudreach/sceptre/hooks","issue_events_url":"https://api.github.com/repos/cloudreach/sceptre/issues/events{/number}","events_url":"https://api.github.com/repos/cloudreach/sceptre/events","assignees_url":"https://api.github.com/repos/cloudreach/sceptre/assignees{/user}","branches_url":"https://api.github.com/repos/cloudreach/sceptre/branches{/branch}","tags_url":"https://api.github.com/repos/cloudreach/sceptre/tags","blobs_url":"https://api.github.com/repos/cloudreach/sceptre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudreach/sceptre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudreach/sceptre/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudreach/sceptre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudreach/sceptre/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudreach/sceptre/languages","stargazers_url":"https://api.github.com/repos/cloudreach/sceptre/stargazers","contributors_url":"https://api.github.com/repos/cloudreach/sceptre/contributors","subscribers_url":"https://api.github.com/repos/cloudreach/sceptre/subscribers","subscription_url":"https://api.github.com/repos/cloudreach/sceptre/subscription","commits_url":"https://api.github.com/repos/cloudreach/sceptre/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudreach/sceptre/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudreach/sceptre/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudreach/sceptre/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudreach/sceptre/contents/{+path}","compare_url":"https://api.github.com/repos/cloudreach/sceptre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudreach/sceptre/merges","archive_url":"https://api.github.com/repos/cloudreach/sceptre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudreach/sceptre/downloads","issues_url":"https://api.github.com/repos/cloudreach/sceptre/issues{/number}","pulls_url":"https://api.github.com/repos/cloudreach/sceptre/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudreach/sceptre/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudreach/sceptre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudreach/sceptre/labels{/name}","releases_url":"https://api.github.com/repos/cloudreach/sceptre/releases{/id}","deployments_url":"https://api.github.com/repos/cloudreach/sceptre/deployments","created_at":"2017-01-31T21:00:39Z","updated_at":"2018-11-20T00:27:59Z","pushed_at":"2018-11-19T22:56:03Z","git_url":"git://github.com/cloudreach/sceptre.git","ssh_url":"git@github.com:cloudreach/sceptre.git","clone_url":"https://github.com/cloudreach/sceptre.git","svn_url":"https://github.com/cloudreach/sceptre","homepage":"https://sceptre.cloudreach.com","size":916,"stargazers_count":632,"watchers_count":632,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":161,"open_issues":98,"watchers":632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/506"},"html":{"href":"https://github.com/cloudreach/sceptre/pull/506"},"issue":{"href":"https://api.github.com/repos/cloudreach/sceptre/issues/506"},"comments":{"href":"https://api.github.com/repos/cloudreach/sceptre/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudreach/sceptre/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/cloudreach/sceptre/statuses/66c3dc7d38f76bdc70ae7a25f140aee38969e02c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"connec"}}