{"action":"created","issue":{"url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/607","repository_url":"https://api.github.com/repos/KiCad/kicad-footprints","labels_url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/607/comments","events_url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/607/events","html_url":"https://github.com/KiCad/kicad-footprints/pull/607","id":326614797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNjU3NzQ0","number":607,"title":"Add TE 282834 terminal blocks","user":{"login":"Ratfink","id":320472,"node_id":"MDQ6VXNlcjMyMDQ3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/320472?v=4","gravatar_id":"","url":"https://api.github.com/users/Ratfink","html_url":"https://github.com/Ratfink","followers_url":"https://api.github.com/users/Ratfink/followers","following_url":"https://api.github.com/users/Ratfink/following{/other_user}","gists_url":"https://api.github.com/users/Ratfink/gists{/gist_id}","starred_url":"https://api.github.com/users/Ratfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ratfink/subscriptions","organizations_url":"https://api.github.com/users/Ratfink/orgs","repos_url":"https://api.github.com/users/Ratfink/repos","events_url":"https://api.github.com/users/Ratfink/events{/privacy}","received_events_url":"https://api.github.com/users/Ratfink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"evanshultz","id":1936989,"node_id":"MDQ6VXNlcjE5MzY5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false},"assignees":[{"login":"evanshultz","id":1936989,"node_id":"MDQ6VXNlcjE5MzY5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-25T18:00:23Z","updated_at":"2018-06-05T16:16:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-footprints/pulls/607","html_url":"https://github.com/KiCad/kicad-footprints/pull/607","diff_url":"https://github.com/KiCad/kicad-footprints/pull/607.diff","patch_url":"https://github.com/KiCad/kicad-footprints/pull/607.patch"},"body":"Generated using the scripts at https://github.com/pointhi/kicad-footprint-generator/pull/131\r\n\r\nBased on the datasheet\r\nhttp://www.te.com/commerce/DocumentDelivery/DDEController?Action=showdoc&DocId=Customer+Drawing%7F282834%7FC1%7Fpdf%7FEnglish%7FENG_CD_282834_C1.pdf\r\n\r\n![screenshot from 2018-05-25 13-57-25](https://user-images.githubusercontent.com/320472/40559167-d7b25b20-6023-11e8-9c9e-5cc458c2f4d9.png)\r\n![screenshot from 2018-05-25 13-57-36](https://user-images.githubusercontent.com/320472/40559168-d7cbce66-6023-11e8-9a78-917b0a5e49ab.png)\r\n\r\n------------\r\n\r\nThanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:\r\n\r\n- [X] Provide a URL to a datasheet for the footprint(s) you are contributing\r\n- [X] An example screenshot image is very helpful \r\n- [X] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate\r\n- [X] Check the output of the Travis automated check scripts - fix any errors as required\r\n"},"comment":{"url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/comments/394770460","html_url":"https://github.com/KiCad/kicad-footprints/pull/607#issuecomment-394770460","issue_url":"https://api.github.com/repos/KiCad/kicad-footprints/issues/607","id":394770460,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDc3MDQ2MA==","user":{"login":"evanshultz","id":1936989,"node_id":"MDQ6VXNlcjE5MzY5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T16:16:02Z","updated_at":"2018-06-05T16:16:02Z","author_association":"CONTRIBUTOR","body":"- We have `Connector_TE-Connectivity` so should this be `TerminalBlock_TE-Connectivity`?\r\n- There is no README.md file in this folder.\r\n- http://kicad-pcb.org/libraries/klc/F3.6/ indicates that the `Modifiers` field is required for **Manufacturer Specific Connectors**, but I don't think that's true. It should be optional. It also doesn't mention putting `TerminalBlock` at the beginning of the footprint name; that's not done in the Connector libraries but for some reason it is on all footprints in TerminalBlock libraries I could find.\r\n- Silk is only 0.06mm offset from fab lines.\r\n- As mentioned at https://github.com/KiCad/kicad-footprints/issues/595, a 1mm oversize on the drill holes should be adequate. Would you consider 2.1mm instead of 2.2mm? That also allows mask between pins which should help to avoid bridging during wave solder.\r\n- It's not clear which direction the wires go into and out of this terminal block. Should we use an arrow or text or some indicator so users don't accidentally place this 180 degrees rotated from the desired orientation? I realize this one has the pins in the middle of the body so it will looks fine either way, but not all terminal blocks are this way. (This is a problem for all our terminal blocks, it appears.)\r\n- How did you determine the placement of the horizontal lines at -2.25mm and +2.85mm?\r\n\r\nDimensioned drawing:\r\n![image](https://user-images.githubusercontent.com/1936989/40988584-54a76bdc-68a0-11e8-9ead-38b94fffc875.png)\r\n\r\nFor completeness and discoverability later, you have also fixed a mix-up between RND and Phoenix library descriptions in sym-lib-table.\r\n\r\nAs an aside, it's never been really clear to me what demarcates `Connector` and `TerminalBlock` libraries..."}}
{"actor":{"display_login":"evanshultz"}}