{"action":"created","comment":{"url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/comments/175930699","pull_request_review_id":105545847,"id":175930699,"diff_hunk":"@@ -151,13 +153,20 @@ const makeMapStateToProps = () => {\n // Leaning heavily on the default shallow equality checking\n // that `connect` provides.\n // It avoids needing to do it own within `Droppable`\n-// $ExpectError - no idea how to type this correctly\n-export default connect(\n+const connectedDroppable: OwnProps => Node = (connect(\n   // returning a function to ensure each\n   // Droppable gets its own selector\n-  makeMapStateToProps,\n+  (makeMapStateToProps: any),\n   null,\n   null,\n   { storeKey },\n-)(Droppable);\n+): any)(Droppable);\n \n+connectedDroppable.defaultProps = ({","path":"src/view/droppable/connected-droppable.js","position":31,"original_position":31,"commit_id":"7aad9644d116743d8b86eee87280b50908150aab","original_commit_id":"7aad9644d116743d8b86eee87280b50908150aab","user":{"login":"TrySound","id":5635476,"avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"body":"This is more honest. This is the component used outside,  so keeping all props required is incorrect.","created_at":"2018-03-20T21:36:22Z","updated_at":"2018-03-20T21:36:22Z","html_url":"https://github.com/atlassian/react-beautiful-dnd/pull/386#discussion_r175930699","pull_request_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/comments/175930699"},"html":{"href":"https://github.com/atlassian/react-beautiful-dnd/pull/386#discussion_r175930699"},"pull_request":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386"}},"in_reply_to_id":175928090},"pull_request":{"url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386","id":175232163,"html_url":"https://github.com/atlassian/react-beautiful-dnd/pull/386","diff_url":"https://github.com/atlassian/react-beautiful-dnd/pull/386.diff","patch_url":"https://github.com/atlassian/react-beautiful-dnd/pull/386.patch","issue_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/386","number":386,"state":"open","locked":false,"title":"Upgrade flow","user":{"login":"TrySound","id":5635476,"avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"body":"- upgraded flow\r\n- upgraded definitions with `flow-typed install --skip`\r\n- fixed opaque types of `requestAnimationFrame` and `setTimeout`\r\n- removed $ExpectError suppressions which may not exists in user config\r\n- removed $FlowFixMe suppressions because sometimes they force flow recheck infinitely (personal experience)\r\n- fixed a few suppressed errors\r\n- prevented react-redux errors with more safe `any`, I think it's ok since you annotate so much\r\n\r\nP.S. New react-redux definitions are still broken, probably because they do not cover all cases","created_at":"2018-03-15T12:16:06Z","updated_at":"2018-03-20T21:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea1f6b62b9bdf71ae031d19ec76c1bc5bc606366","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386/commits","review_comments_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386/comments","review_comment_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/386/comments","statuses_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/statuses/7aad9644d116743d8b86eee87280b50908150aab","head":{"label":"TrySound:upgrade-flow","ref":"upgrade-flow","sha":"7aad9644d116743d8b86eee87280b50908150aab","user":{"login":"TrySound","id":5635476,"avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"repo":{"id":122868835,"name":"react-beautiful-dnd","full_name":"TrySound/react-beautiful-dnd","owner":{"login":"TrySound","id":5635476,"avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TrySound/react-beautiful-dnd","description":"Beautiful, accessible drag and drop for lists with React.js","fork":true,"url":"https://api.github.com/repos/TrySound/react-beautiful-dnd","forks_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/forks","keys_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/teams","hooks_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/hooks","issue_events_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/issues/events{/number}","events_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/events","assignees_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/assignees{/user}","branches_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/branches{/branch}","tags_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/tags","blobs_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/statuses/{sha}","languages_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/languages","stargazers_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/stargazers","contributors_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/contributors","subscribers_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/subscribers","subscription_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/subscription","commits_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/contents/{+path}","compare_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/merges","archive_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/downloads","issues_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/issues{/number}","pulls_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/pulls{/number}","milestones_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/milestones{/number}","notifications_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/labels{/name}","releases_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/releases{/id}","deployments_url":"https://api.github.com/repos/TrySound/react-beautiful-dnd/deployments","created_at":"2018-02-25T19:32:08Z","updated_at":"2018-02-25T19:32:10Z","pushed_at":"2018-03-17T10:06:24Z","git_url":"git://github.com/TrySound/react-beautiful-dnd.git","ssh_url":"git@github.com:TrySound/react-beautiful-dnd.git","clone_url":"https://github.com/TrySound/react-beautiful-dnd.git","svn_url":"https://github.com/TrySound/react-beautiful-dnd","homepage":"","size":1739,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atlassian:master","ref":"master","sha":"645eee5de2d96b934aa8574bdfb4377d85e2a67d","user":{"login":"atlassian","id":168166,"avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":99761907,"name":"react-beautiful-dnd","full_name":"atlassian/react-beautiful-dnd","owner":{"login":"atlassian","id":168166,"avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atlassian/react-beautiful-dnd","description":"Beautiful, accessible drag and drop for lists with React.js","fork":false,"url":"https://api.github.com/repos/atlassian/react-beautiful-dnd","forks_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/forks","keys_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/teams","hooks_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/hooks","issue_events_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/events","assignees_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/tags","blobs_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/languages","stargazers_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/stargazers","contributors_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/contributors","subscribers_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/subscribers","subscription_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/subscription","commits_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/merges","archive_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/downloads","issues_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/deployments","created_at":"2017-08-09T03:37:15Z","updated_at":"2018-03-20T20:57:41Z","pushed_at":"2018-03-20T11:22:46Z","git_url":"git://github.com/atlassian/react-beautiful-dnd.git","ssh_url":"git@github.com:atlassian/react-beautiful-dnd.git","clone_url":"https://github.com/atlassian/react-beautiful-dnd.git","svn_url":"https://github.com/atlassian/react-beautiful-dnd","homepage":"","size":1730,"stargazers_count":5806,"watchers_count":5806,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":264,"open_issues":53,"watchers":5806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386"},"html":{"href":"https://github.com/atlassian/react-beautiful-dnd/pull/386"},"issue":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/386"},"comments":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/atlassian/react-beautiful-dnd/statuses/7aad9644d116743d8b86eee87280b50908150aab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TrySound"}}