{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/196572652","pull_request_review_id":130152755,"id":196572652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU3MjY1Mg==","diff_hunk":"@@ -329,6 +329,12 @@ func (si *ServiceInstance) GetAZ() string {\n \treturn si.Labels[AZLabel]\n }\n \n+// ServiceAttributes represents a group of custom attributes of the service.\n+type ServiceAttributes struct {\n+\tName      string\n+\tNamespace string\n+}","path":"pilot/pkg/model/service.go","position":8,"original_position":8,"commit_id":"7bd5a1af4bb2c4a5d03edd36fd09d45b1b07267c","original_commit_id":"7bd5a1af4bb2c4a5d03edd36fd09d45b1b07267c","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"Service accounts are attributes on workloads, not services...","created_at":"2018-06-19T20:47:02Z","updated_at":"2018-06-19T20:47:02Z","html_url":"https://github.com/istio/istio/pull/6310#discussion_r196572652","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6310","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/196572652"},"html":{"href":"https://github.com/istio/istio/pull/6310#discussion_r196572652"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6310"}},"in_reply_to_id":196572296},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6310","id":195040257,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDQwMjU3","html_url":"https://github.com/istio/istio/pull/6310","diff_url":"https://github.com/istio/istio/pull/6310.diff","patch_url":"https://github.com/istio/istio/pull/6310.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6310","number":6310,"state":"open","locked":false,"title":"add GetServiceNamespace() to service/model","user":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"body":"I'm not sure what would be the proper return value for debug and memory case, let me know if you have preferences. Also will update the auth code to use it in a later PR.\r\nThank you!","created_at":"2018-06-14T23:02:08Z","updated_at":"2018-06-19T20:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a033b87cf273dce21624e4f06f0a1ba6408bec7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6310/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6310/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6310/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/7bd5a1af4bb2c4a5d03edd36fd09d45b1b07267c","head":{"label":"yangminzhu:refactor_ns","ref":"refactor_ns","sha":"7bd5a1af4bb2c4a5d03edd36fd09d45b1b07267c","user":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"repo":{"id":122268122,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyNjgxMjI=","name":"istio","full_name":"yangminzhu/istio","owner":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yangminzhu/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/yangminzhu/istio","forks_url":"https://api.github.com/repos/yangminzhu/istio/forks","keys_url":"https://api.github.com/repos/yangminzhu/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yangminzhu/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yangminzhu/istio/teams","hooks_url":"https://api.github.com/repos/yangminzhu/istio/hooks","issue_events_url":"https://api.github.com/repos/yangminzhu/istio/issues/events{/number}","events_url":"https://api.github.com/repos/yangminzhu/istio/events","assignees_url":"https://api.github.com/repos/yangminzhu/istio/assignees{/user}","branches_url":"https://api.github.com/repos/yangminzhu/istio/branches{/branch}","tags_url":"https://api.github.com/repos/yangminzhu/istio/tags","blobs_url":"https://api.github.com/repos/yangminzhu/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yangminzhu/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yangminzhu/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/yangminzhu/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yangminzhu/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/yangminzhu/istio/languages","stargazers_url":"https://api.github.com/repos/yangminzhu/istio/stargazers","contributors_url":"https://api.github.com/repos/yangminzhu/istio/contributors","subscribers_url":"https://api.github.com/repos/yangminzhu/istio/subscribers","subscription_url":"https://api.github.com/repos/yangminzhu/istio/subscription","commits_url":"https://api.github.com/repos/yangminzhu/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/yangminzhu/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/yangminzhu/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/yangminzhu/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/yangminzhu/istio/contents/{+path}","compare_url":"https://api.github.com/repos/yangminzhu/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yangminzhu/istio/merges","archive_url":"https://api.github.com/repos/yangminzhu/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yangminzhu/istio/downloads","issues_url":"https://api.github.com/repos/yangminzhu/istio/issues{/number}","pulls_url":"https://api.github.com/repos/yangminzhu/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/yangminzhu/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/yangminzhu/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yangminzhu/istio/labels{/name}","releases_url":"https://api.github.com/repos/yangminzhu/istio/releases{/id}","deployments_url":"https://api.github.com/repos/yangminzhu/istio/deployments","created_at":"2018-02-20T23:07:28Z","updated_at":"2018-02-20T23:07:34Z","pushed_at":"2018-06-19T01:06:35Z","git_url":"git://github.com/yangminzhu/istio.git","ssh_url":"git@github.com:yangminzhu/istio.git","clone_url":"https://github.com/yangminzhu/istio.git","svn_url":"https://github.com/yangminzhu/istio","homepage":"https://istio.io","size":38114,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"a2374947cc55c98accb2d95581db9eecabad67e6","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-19T20:14:49Z","pushed_at":"2018-06-19T20:45:53Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":39354,"stargazers_count":8775,"watchers_count":8775,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1193,"mirror_url":null,"archived":false,"open_issues_count":791,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1193,"open_issues":791,"watchers":8775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6310"},"html":{"href":"https://github.com/istio/istio/pull/6310"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6310"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6310/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6310/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6310/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/7bd5a1af4bb2c4a5d03edd36fd09d45b1b07267c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kyessenov"}}