{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3935","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3935/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3935/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3935/events","html_url":"https://github.com/codice/ddf/pull/3935","id":374063867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODUxMTk1","number":3935,"title":"DDF-4269 Read/Write sharing permissions","user":{"login":"rymach","id":37838624,"node_id":"MDQ6VXNlcjM3ODM4NjI0","avatar_url":"https://avatars2.githubusercontent.com/u/37838624?v=4","gravatar_id":"","url":"https://api.github.com/users/rymach","html_url":"https://github.com/rymach","followers_url":"https://api.github.com/users/rymach/followers","following_url":"https://api.github.com/users/rymach/following{/other_user}","gists_url":"https://api.github.com/users/rymach/gists{/gist_id}","starred_url":"https://api.github.com/users/rymach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rymach/subscriptions","organizations_url":"https://api.github.com/users/rymach/orgs","repos_url":"https://api.github.com/users/rymach/repos","events_url":"https://api.github.com/users/rymach/events{/privacy}","received_events_url":"https://api.github.com/users/rymach/received_events","type":"User","site_admin":false},"labels":[{"id":1117154312,"node_id":"MDU6TGFiZWwxMTE3MTU0MzEy","url":"https://api.github.com/repos/codice/ddf/labels/%E2%9C%A8New%20Feature","name":"✨New Feature","color":"8480fc","default":false},{"id":1112998962,"node_id":"MDU6TGFiZWwxMTEyOTk4OTYy","url":"https://api.github.com/repos/codice/ddf/labels/%F0%9F%91%A4%20UI","name":"👤 UI","color":"dcc9ff","default":false}],"state":"open","locked":false,"assignee":{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2018-10-25T18:00:09Z","updated_at":"2018-11-20T23:37:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3935","html_url":"https://github.com/codice/ddf/pull/3935","diff_url":"https://github.com/codice/ddf/pull/3935.diff","patch_url":"https://github.com/codice/ddf/pull/3935.patch"},"body":"Adds read-only permission to the sharing UI\r\n\r\n#### Who is reviewing it? \r\n@Schachte \r\n@leo-sakh \r\n@gjvera \r\n@djblue \r\n\r\n#### Select relevant component teams: \r\n@codice/ui \r\n@codice/security \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@andrewkfiedler\r\n@bdeining\r\n\r\n#### How should this be tested?\r\n\r\nFor both workspaces and search forms test each possible permission:\r\nGroup: none, read, write \r\nIndividual: none, read, write, share\r\n\r\nEnsure interaction menu (three dot) displays the correct options in each case (edit, delete, share)\r\nEnsure saving works (or is not allowed in the case of readonly) \r\netc. \r\n#### What are the relevant tickets?\r\n[DDF-4269](https://codice.atlassian.net/browse/DDF-4269)\r\n#### Screenshots\r\nindividual dropdown options\r\n<img width=\"996\" alt=\"screen shot 2018-10-25 at 1 38 32 pm\" src=\"https://user-images.githubusercontent.com/37838624/47520073-2f2f7e80-d85d-11e8-94e4-fa79e4b3e465.png\">\r\nrole dropdown options\r\n<img width=\"856\" alt=\"screen shot 2018-10-25 at 1 38 52 pm\" src=\"https://user-images.githubusercontent.com/37838624/47520074-2f2f7e80-d85d-11e8-89c4-bd4d507c5b86.png\">\r\nwarning when attempting to save a readonly workspace. We only block on save (instead of blocking any changes at all) because many actions (e.g. changing search criteria) count as an edit in the UI. \r\n<img width=\"827\" alt=\"screen shot 2018-10-25 at 1 37 24 pm\" src=\"https://user-images.githubusercontent.com/37838624/47520075-2f2f7e80-d85d-11e8-8fff-84acfe6e0685.png\">\r\n\r\n#### Checklist:\r\n- [x] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/440468031","html_url":"https://github.com/codice/ddf/pull/3935#issuecomment-440468031","issue_url":"https://api.github.com/repos/codice/ddf/issues/3935","id":440468031,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDQ2ODAzMQ==","user":{"login":"cxbot","id":21088360,"node_id":"MDQ6VXNlcjIxMDg4MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T23:37:34Z","updated_at":"2018-11-20T23:37:34Z","author_association":"COLLABORATOR","body":"Internal build has been scheduled, your results will be available at build completion."}}
{"actor":{"display_login":"cxbot"}}