{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/182475663","pull_request_review_id":113278522,"id":182475663,"diff_hunk":"@@ -0,0 +1,22 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+include \"pal_types.h\"\n+\n+/**\n+ * Get states of serial line.\n+ */\n+extern \"C\" int32_t SystemNative_TermiosGetDcd(int fd);","path":"src/Native/Unix/System.Native/pal_termios.h","position":10,"original_position":10,"commit_id":"cbb5838bae399137c86ca17511cb90cacef654f6","original_commit_id":"cbb5838bae399137c86ca17511cb90cacef654f6","user":{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false},"body":"You still need to be able to be included in C++ files, thus the need for `extern \"C\"`. My comment is only to help you reduce repetition, it's not a mandated or required change.","created_at":"2018-04-18T15:44:39Z","updated_at":"2018-04-18T15:44:40Z","html_url":"https://github.com/dotnet/corefx/pull/29033#discussion_r182475663","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/29033","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/182475663"},"html":{"href":"https://github.com/dotnet/corefx/pull/29033#discussion_r182475663"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29033"}},"in_reply_to_id":182131785},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/29033","id":180980698,"html_url":"https://github.com/dotnet/corefx/pull/29033","diff_url":"https://github.com/dotnet/corefx/pull/29033.diff","patch_url":"https://github.com/dotnet/corefx/pull/29033.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/29033","number":29033,"state":"open","locked":false,"title":"bottom part of serial port support on Unix","user":{"login":"wfurt","id":14356188,"avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"This is part of original #28415 after addressing feedback. We publish System.IO.Ports as separate package so we can iterate on upper parts later. \r\n\r\nI'm at the point where I can run Serial port tests and I still get 20-30 failures (out of few hundred) depending in what HW I uses. The upper part still may need some polishing so as the test suite. \r\n\r\nIn general issues seems to be in two areas:\r\n- discarding sent data when using USB/Serial adapter does not work well. That seems to be know limitation with Linux drivers. (or possibly USB)\r\n- manipulating buffer sizes does not work as on Windows. That breaks tests.\r\n\r\n\r\n","created_at":"2018-04-11T17:51:38Z","updated_at":"2018-04-18T15:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6de087ae95dc7edfda26b6dea1c1aed85554b100","assignee":{"login":"wfurt","id":14356188,"avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"assignees":[{"login":"wfurt","id":14356188,"avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pjanotti","id":5600755,"avatar_url":"https://avatars3.githubusercontent.com/u/5600755?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanotti","html_url":"https://github.com/pjanotti","followers_url":"https://api.github.com/users/pjanotti/followers","following_url":"https://api.github.com/users/pjanotti/following{/other_user}","gists_url":"https://api.github.com/users/pjanotti/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanotti/subscriptions","organizations_url":"https://api.github.com/users/pjanotti/orgs","repos_url":"https://api.github.com/users/pjanotti/repos","events_url":"https://api.github.com/users/pjanotti/events{/privacy}","received_events_url":"https://api.github.com/users/pjanotti/received_events","type":"User","site_admin":false},{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},{"login":"janvorli","id":10758568,"avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":154422420,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.IO","name":"area-System.IO","color":"d4c5f9","default":false},{"id":205613977,"url":"https://api.github.com/repos/dotnet/corefx/labels/os-linux","name":"os-linux","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/21","html_url":"https://github.com/dotnet/corefx/milestone/21","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/21/labels","id":3242632,"number":21,"title":"2.2.0","description":"Placeholder name for next major release after 2.1. [Official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) are TBD.\r\n\r\nWe will move important issues from Future to 2.2.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":13,"state":"open","created_at":"2018-04-04T16:40:10Z","updated_at":"2018-04-18T15:36:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/29033/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/29033/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/29033/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/cbb5838bae399137c86ca17511cb90cacef654f6","head":{"label":"wfurt:serial2","ref":"serial2","sha":"cbb5838bae399137c86ca17511cb90cacef654f6","user":{"login":"wfurt","id":14356188,"avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"repo":{"id":91738855,"name":"corefx","full_name":"wfurt/corefx","owner":{"login":"wfurt","id":14356188,"avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wfurt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/wfurt/corefx","forks_url":"https://api.github.com/repos/wfurt/corefx/forks","keys_url":"https://api.github.com/repos/wfurt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wfurt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wfurt/corefx/teams","hooks_url":"https://api.github.com/repos/wfurt/corefx/hooks","issue_events_url":"https://api.github.com/repos/wfurt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/wfurt/corefx/events","assignees_url":"https://api.github.com/repos/wfurt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/wfurt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/wfurt/corefx/tags","blobs_url":"https://api.github.com/repos/wfurt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wfurt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wfurt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/wfurt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wfurt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/wfurt/corefx/languages","stargazers_url":"https://api.github.com/repos/wfurt/corefx/stargazers","contributors_url":"https://api.github.com/repos/wfurt/corefx/contributors","subscribers_url":"https://api.github.com/repos/wfurt/corefx/subscribers","subscription_url":"https://api.github.com/repos/wfurt/corefx/subscription","commits_url":"https://api.github.com/repos/wfurt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/wfurt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/wfurt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/wfurt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/wfurt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/wfurt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wfurt/corefx/merges","archive_url":"https://api.github.com/repos/wfurt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wfurt/corefx/downloads","issues_url":"https://api.github.com/repos/wfurt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/wfurt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/wfurt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/wfurt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wfurt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/wfurt/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/wfurt/corefx/deployments","created_at":"2017-05-18T21:24:08Z","updated_at":"2018-04-10T20:08:49Z","pushed_at":"2018-04-11T17:25:26Z","git_url":"git://github.com/wfurt/corefx.git","ssh_url":"git@github.com:wfurt/corefx.git","clone_url":"https://github.com/wfurt/corefx.git","svn_url":"https://github.com/wfurt/corefx","homepage":"https://github.com/dotnet/core","size":174938,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"aeda6ab039f8d6e6041379ab156d51410b679c13","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-04-18T15:00:05Z","pushed_at":"2018-04-18T14:41:56Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":177270,"stargazers_count":13772,"watchers_count":13772,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3946,"mirror_url":null,"archived":false,"open_issues_count":2234,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3946,"open_issues":2234,"watchers":13772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29033"},"html":{"href":"https://github.com/dotnet/corefx/pull/29033"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29033"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29033/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29033/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29033/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/cbb5838bae399137c86ca17511cb90cacef654f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"luhenry"}}