{"action":"reopened","issue":{"url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/issues/129","repository_url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror","labels_url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/issues/129/comments","events_url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/issues/129/events","html_url":"https://github.com/spaulaus/paass-laughing-conqueror/issues/129","id":301611434,"number":129,"title":"Firmware 34455 does not decode trace length properly","user":{"login":"spaulaus","id":1553042,"avatar_url":"https://avatars1.githubusercontent.com/u/1553042?v=4","gravatar_id":"","url":"https://api.github.com/users/spaulaus","html_url":"https://github.com/spaulaus","followers_url":"https://api.github.com/users/spaulaus/followers","following_url":"https://api.github.com/users/spaulaus/following{/other_user}","gists_url":"https://api.github.com/users/spaulaus/gists{/gist_id}","starred_url":"https://api.github.com/users/spaulaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaulaus/subscriptions","organizations_url":"https://api.github.com/users/spaulaus/orgs","repos_url":"https://api.github.com/users/spaulaus/repos","events_url":"https://api.github.com/users/spaulaus/events{/privacy}","received_events_url":"https://api.github.com/users/spaulaus/received_events","type":"User","site_admin":false},"labels":[{"id":623904632,"url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/labels/Analysis","name":"Analysis","color":"bfd4f2","default":false},{"id":623348864,"url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":907150630,"url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/labels/Done","name":"Done","color":"51ea23","default":false},{"id":819391289,"url":"https://api.github.com/repos/spaulaus/paass-laughing-conqueror/labels/Testing","name":"Testing","color":"61d3cf","default":false}],"state":"open","locked":false,"assignee":{"login":"spaulaus","id":1553042,"avatar_url":"https://avatars1.githubusercontent.com/u/1553042?v=4","gravatar_id":"","url":"https://api.github.com/users/spaulaus","html_url":"https://github.com/spaulaus","followers_url":"https://api.github.com/users/spaulaus/followers","following_url":"https://api.github.com/users/spaulaus/following{/other_user}","gists_url":"https://api.github.com/users/spaulaus/gists{/gist_id}","starred_url":"https://api.github.com/users/spaulaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaulaus/subscriptions","organizations_url":"https://api.github.com/users/spaulaus/orgs","repos_url":"https://api.github.com/users/spaulaus/repos","events_url":"https://api.github.com/users/spaulaus/events{/privacy}","received_events_url":"https://api.github.com/users/spaulaus/received_events","type":"User","site_admin":false},"assignees":[{"login":"spaulaus","id":1553042,"avatar_url":"https://avatars1.githubusercontent.com/u/1553042?v=4","gravatar_id":"","url":"https://api.github.com/users/spaulaus","html_url":"https://github.com/spaulaus","followers_url":"https://api.github.com/users/spaulaus/followers","following_url":"https://api.github.com/users/spaulaus/following{/other_user}","gists_url":"https://api.github.com/users/spaulaus/gists{/gist_id}","starred_url":"https://api.github.com/users/spaulaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaulaus/subscriptions","organizations_url":"https://api.github.com/users/spaulaus/orgs","repos_url":"https://api.github.com/users/spaulaus/repos","events_url":"https://api.github.com/users/spaulaus/events{/privacy}","received_events_url":"https://api.github.com/users/spaulaus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-02T00:32:45Z","updated_at":"2018-04-19T11:10:16Z","closed_at":null,"author_association":"OWNER","body":"<!--- Provide a general summary of the issue in the Title above -->\r\n## Expected Behavior\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\nTrace lengths are decoded properly while unpacking the XIA data buffers. \r\n## Current Behavior\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\nFirmware 34455 doesn't seem to be decoding the trace properly. When the scan runs we get inundated with error messages. They're all from `XiaListModeDataDecoder::ReadBuffer()` method. The error occurs when the trace length + header doesn't match the event length. \r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\nWell, I'm missing big swaths of data, as seen in Issue #120. What's interesting is that this error doesn't kill the scan all the time, which means that sometimes it's decoding properly, but other times its not. I have a feeling this is a symptom of the issue described in Issue #18. \r\n## Possible Solution (optional)\r\n<!--- Not obligatory, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\nFix the trace length decoding for that firmware revision. \r\n## Acceptance Criteria\r\n<!-- This will help determine if a PR is accepted or not. -->\r\n1. The scan code doesn't get the wrong trace length for 34455\r\n2. The scan code decodes other firmware properly\r\n3. \r\n\r\n## Bug Report\r\n### Your Environment\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n| Component | Value  |\r\n|--|--|\r\n|Operating system | ubuntu |\r\n|Kernel Version   | 4.4.0-43-Microsoft  |\r\n|CMake Version    | 3.5.1 |\r\n|GCC Version      | gcc (Ubuntu 5.4.0-6ubuntu1~16.04.6) 5.4.0 20160609 |\r\n|ROOT Version     | 6.13/01 |\r\n|GSL Version      | 2.4 |\r\n\r\n### Steps to Reproduce\r\n<!--- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!--- reproduce this bug. Include code to reproduce, if relevant -->\r\n1. Try scanning some data taken with 34455 \r\n\r\n### Error Logs\r\n```\r\nXiaListModeDataDecoder::ReadBuffer : Eventlength (4) does not correspond to header length (4) and trace length (16384). Skipped a total of 7 buffers in this file. \r\n```"}}
{"actor":{"display_login":"spaulaus"}}