{"action":"created","issue":{"url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/2","repository_url":"https://api.github.com/repos/windingtree/wt-booking-api","labels_url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/2/comments","events_url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/2/events","html_url":"https://github.com/windingtree/wt-booking-api/pull/2","id":365434368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzU0ODEy","number":2,"title":"[WIP] feat: Adds booking API data structure","user":{"login":"JirkaChadima","id":375483,"node_id":"MDQ6VXNlcjM3NTQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/375483?v=4","gravatar_id":"","url":"https://api.github.com/users/JirkaChadima","html_url":"https://github.com/JirkaChadima","followers_url":"https://api.github.com/users/JirkaChadima/followers","following_url":"https://api.github.com/users/JirkaChadima/following{/other_user}","gists_url":"https://api.github.com/users/JirkaChadima/gists{/gist_id}","starred_url":"https://api.github.com/users/JirkaChadima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JirkaChadima/subscriptions","organizations_url":"https://api.github.com/users/JirkaChadima/orgs","repos_url":"https://api.github.com/users/JirkaChadima/repos","events_url":"https://api.github.com/users/JirkaChadima/events{/privacy}","received_events_url":"https://api.github.com/users/JirkaChadima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-01T12:17:45Z","updated_at":"2018-10-01T13:00:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/windingtree/wt-booking-api/pulls/2","html_url":"https://github.com/windingtree/wt-booking-api/pull/2","diff_url":"https://github.com/windingtree/wt-booking-api/pull/2.diff","patch_url":"https://github.com/windingtree/wt-booking-api/pull/2.patch"},"body":"This PR aims to flesh out the booking data structure. It will get polished a bit (mandatory fields, descriptions etc.), the general idea will remain the same though. The latest version should be visible on https://app.swaggerhub.com/apis-docs/jirkachadima/wt-booking-api/will-be-set-at-runtime\r\n\r\n**What is missing:**\r\n\r\n- paid amenities or additional paid services\r\n- billing information\r\n- guarantee\r\n\r\n@hynek-urban @czervenka Am I missing something important?"},"comment":{"url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/comments/425898599","html_url":"https://github.com/windingtree/wt-booking-api/pull/2#issuecomment-425898599","issue_url":"https://api.github.com/repos/windingtree/wt-booking-api/issues/2","id":425898599,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTg5ODU5OQ==","user":{"login":"JirkaChadima","id":375483,"node_id":"MDQ6VXNlcjM3NTQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/375483?v=4","gravatar_id":"","url":"https://api.github.com/users/JirkaChadima","html_url":"https://github.com/JirkaChadima","followers_url":"https://api.github.com/users/JirkaChadima/followers","following_url":"https://api.github.com/users/JirkaChadima/following{/other_user}","gists_url":"https://api.github.com/users/JirkaChadima/gists{/gist_id}","starred_url":"https://api.github.com/users/JirkaChadima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JirkaChadima/subscriptions","organizations_url":"https://api.github.com/users/JirkaChadima/orgs","repos_url":"https://api.github.com/users/JirkaChadima/repos","events_url":"https://api.github.com/users/JirkaChadima/events{/privacy}","received_events_url":"https://api.github.com/users/JirkaChadima/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T13:00:24Z","updated_at":"2018-10-01T13:00:24Z","author_association":"MEMBER","body":"Thanks for the comment\r\n\r\n1. I'll add it, the error list is not exhaustive ATM. I'll check with the code before submitting the final draft.\r\n2. Do you mean `reseller.reference`? If you are an OTA, it might be useful to pair your record with the hotel record and vice versa.\r\n3. I agree, but I don't know how to do `one of the two is required` in OAS.\r\n4. Because I haven't done it yet :-) I'll add a revision that deals with that in an hour or so.\r\n5. It's redundant. I think that in some cases `guestInfo` might actually not be necessary. You would then be unable to tell the actual number of guests."}}
{"actor":{"display_login":"JirkaChadima"}}