{"action":"created","comment":{"url":"https://api.github.com/repos/mewna/catnip/pulls/comments/215448533","pull_request_review_id":152716747,"id":215448533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ0ODUzMw==","diff_hunk":"@@ -162,16 +177,31 @@ public Embed build() {\n             builder.thumbnail(thumbnail);\n         }\n         if(author != null) {\n+            if (author.name().length() > 256){\n+                throw new IllegalStateException(\"Author's name exceeds 256 characters!\");\n+            }\n+            len += author.name().length();\n             builder.author(author);\n         }\n-        if(fields.isEmpty()) {\n-            builder.fields(Collections.emptyList());\n-        } else {\n+        if(!fields.isEmpty()) {\n             if(fields.size() > 25) {\n                 throw new IllegalStateException(\"Tried to add an embed field, but we're at the cap (25)!\");\n             }\n+            for (Field item : fields) {\n+                if (item.name().length() > 256){\n+                throw new IllegalStateException(\"Field name exceeds 256 characters!\");\n+            }\n+            if (item.value().length() > 1024){\n+                throw new IllegalStateException(\"Field value exceeds 1024 characters!\");\n+            }\n+                len += item.name().length();\n+                len += item.value().length();\n+}","path":"src/main/java/com/mewna/catnip/entity/builder/EmbedBuilder.java","position":69,"original_position":69,"commit_id":"424c83957ef981f104ee8262f040654c4e2f4b63","original_commit_id":"424c83957ef981f104ee8262f040654c4e2f4b63","user":{"login":"natanbc","id":22461307,"node_id":"MDQ6VXNlcjIyNDYxMzA3","avatar_url":"https://avatars1.githubusercontent.com/u/22461307?v=4","gravatar_id":"","url":"https://api.github.com/users/natanbc","html_url":"https://github.com/natanbc","followers_url":"https://api.github.com/users/natanbc/followers","following_url":"https://api.github.com/users/natanbc/following{/other_user}","gists_url":"https://api.github.com/users/natanbc/gists{/gist_id}","starred_url":"https://api.github.com/users/natanbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natanbc/subscriptions","organizations_url":"https://api.github.com/users/natanbc/orgs","repos_url":"https://api.github.com/users/natanbc/repos","events_url":"https://api.github.com/users/natanbc/events{/privacy}","received_events_url":"https://api.github.com/users/natanbc/received_events","type":"User","site_admin":false},"body":"smells like tabs","created_at":"2018-09-05T22:45:42Z","updated_at":"2018-09-05T22:45:42Z","html_url":"https://github.com/mewna/catnip/pull/25#discussion_r215448533","pull_request_url":"https://api.github.com/repos/mewna/catnip/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mewna/catnip/pulls/comments/215448533"},"html":{"href":"https://github.com/mewna/catnip/pull/25#discussion_r215448533"},"pull_request":{"href":"https://api.github.com/repos/mewna/catnip/pulls/25"}},"in_reply_to_id":215445090},"pull_request":{"url":"https://api.github.com/repos/mewna/catnip/pulls/25","id":213445440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDQ1NDQw","html_url":"https://github.com/mewna/catnip/pull/25","diff_url":"https://github.com/mewna/catnip/pull/25.diff","patch_url":"https://github.com/mewna/catnip/pull/25.patch","issue_url":"https://api.github.com/repos/mewna/catnip/issues/25","number":25,"state":"open","locked":false,"title":"added length checking for EmbedBuilder","user":{"login":"MaxGrosshandler","id":13258241,"node_id":"MDQ6VXNlcjEzMjU4MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/13258241?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGrosshandler","html_url":"https://github.com/MaxGrosshandler","followers_url":"https://api.github.com/users/MaxGrosshandler/followers","following_url":"https://api.github.com/users/MaxGrosshandler/following{/other_user}","gists_url":"https://api.github.com/users/MaxGrosshandler/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGrosshandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGrosshandler/subscriptions","organizations_url":"https://api.github.com/users/MaxGrosshandler/orgs","repos_url":"https://api.github.com/users/MaxGrosshandler/repos","events_url":"https://api.github.com/users/MaxGrosshandler/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGrosshandler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-05T22:25:57Z","updated_at":"2018-09-05T22:45:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0fea19ddf5ae043d2346954c37d6bbd70c7f2e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mewna/catnip/pulls/25/commits","review_comments_url":"https://api.github.com/repos/mewna/catnip/pulls/25/comments","review_comment_url":"https://api.github.com/repos/mewna/catnip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mewna/catnip/issues/25/comments","statuses_url":"https://api.github.com/repos/mewna/catnip/statuses/424c83957ef981f104ee8262f040654c4e2f4b63","head":{"label":"MaxGrosshandler:master","ref":"master","sha":"424c83957ef981f104ee8262f040654c4e2f4b63","user":{"login":"MaxGrosshandler","id":13258241,"node_id":"MDQ6VXNlcjEzMjU4MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/13258241?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGrosshandler","html_url":"https://github.com/MaxGrosshandler","followers_url":"https://api.github.com/users/MaxGrosshandler/followers","following_url":"https://api.github.com/users/MaxGrosshandler/following{/other_user}","gists_url":"https://api.github.com/users/MaxGrosshandler/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGrosshandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGrosshandler/subscriptions","organizations_url":"https://api.github.com/users/MaxGrosshandler/orgs","repos_url":"https://api.github.com/users/MaxGrosshandler/repos","events_url":"https://api.github.com/users/MaxGrosshandler/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGrosshandler/received_events","type":"User","site_admin":false},"repo":{"id":147582891,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1ODI4OTE=","name":"catnip","full_name":"MaxGrosshandler/catnip","owner":{"login":"MaxGrosshandler","id":13258241,"node_id":"MDQ6VXNlcjEzMjU4MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/13258241?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGrosshandler","html_url":"https://github.com/MaxGrosshandler","followers_url":"https://api.github.com/users/MaxGrosshandler/followers","following_url":"https://api.github.com/users/MaxGrosshandler/following{/other_user}","gists_url":"https://api.github.com/users/MaxGrosshandler/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGrosshandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGrosshandler/subscriptions","organizations_url":"https://api.github.com/users/MaxGrosshandler/orgs","repos_url":"https://api.github.com/users/MaxGrosshandler/repos","events_url":"https://api.github.com/users/MaxGrosshandler/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGrosshandler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaxGrosshandler/catnip","description":"A fully reactive / async Discord API wrapper for the JVM, built on vert.x","fork":true,"url":"https://api.github.com/repos/MaxGrosshandler/catnip","forks_url":"https://api.github.com/repos/MaxGrosshandler/catnip/forks","keys_url":"https://api.github.com/repos/MaxGrosshandler/catnip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaxGrosshandler/catnip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaxGrosshandler/catnip/teams","hooks_url":"https://api.github.com/repos/MaxGrosshandler/catnip/hooks","issue_events_url":"https://api.github.com/repos/MaxGrosshandler/catnip/issues/events{/number}","events_url":"https://api.github.com/repos/MaxGrosshandler/catnip/events","assignees_url":"https://api.github.com/repos/MaxGrosshandler/catnip/assignees{/user}","branches_url":"https://api.github.com/repos/MaxGrosshandler/catnip/branches{/branch}","tags_url":"https://api.github.com/repos/MaxGrosshandler/catnip/tags","blobs_url":"https://api.github.com/repos/MaxGrosshandler/catnip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaxGrosshandler/catnip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaxGrosshandler/catnip/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaxGrosshandler/catnip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaxGrosshandler/catnip/statuses/{sha}","languages_url":"https://api.github.com/repos/MaxGrosshandler/catnip/languages","stargazers_url":"https://api.github.com/repos/MaxGrosshandler/catnip/stargazers","contributors_url":"https://api.github.com/repos/MaxGrosshandler/catnip/contributors","subscribers_url":"https://api.github.com/repos/MaxGrosshandler/catnip/subscribers","subscription_url":"https://api.github.com/repos/MaxGrosshandler/catnip/subscription","commits_url":"https://api.github.com/repos/MaxGrosshandler/catnip/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaxGrosshandler/catnip/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaxGrosshandler/catnip/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaxGrosshandler/catnip/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaxGrosshandler/catnip/contents/{+path}","compare_url":"https://api.github.com/repos/MaxGrosshandler/catnip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaxGrosshandler/catnip/merges","archive_url":"https://api.github.com/repos/MaxGrosshandler/catnip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaxGrosshandler/catnip/downloads","issues_url":"https://api.github.com/repos/MaxGrosshandler/catnip/issues{/number}","pulls_url":"https://api.github.com/repos/MaxGrosshandler/catnip/pulls{/number}","milestones_url":"https://api.github.com/repos/MaxGrosshandler/catnip/milestones{/number}","notifications_url":"https://api.github.com/repos/MaxGrosshandler/catnip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaxGrosshandler/catnip/labels{/name}","releases_url":"https://api.github.com/repos/MaxGrosshandler/catnip/releases{/id}","deployments_url":"https://api.github.com/repos/MaxGrosshandler/catnip/deployments","created_at":"2018-09-05T21:44:03Z","updated_at":"2018-09-05T22:00:32Z","pushed_at":"2018-09-05T22:00:30Z","git_url":"git://github.com/MaxGrosshandler/catnip.git","ssh_url":"git@github.com:MaxGrosshandler/catnip.git","clone_url":"https://github.com/MaxGrosshandler/catnip.git","svn_url":"https://github.com/MaxGrosshandler/catnip","homepage":"https://discord.gg/kCsBCjK","size":141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mewna:master","ref":"master","sha":"de13351b669ed44c4f5802b2da02f8db77233f56","user":{"login":"mewna","id":38661753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjYxNzUz","avatar_url":"https://avatars3.githubusercontent.com/u/38661753?v=4","gravatar_id":"","url":"https://api.github.com/users/mewna","html_url":"https://github.com/mewna","followers_url":"https://api.github.com/users/mewna/followers","following_url":"https://api.github.com/users/mewna/following{/other_user}","gists_url":"https://api.github.com/users/mewna/gists{/gist_id}","starred_url":"https://api.github.com/users/mewna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mewna/subscriptions","organizations_url":"https://api.github.com/users/mewna/orgs","repos_url":"https://api.github.com/users/mewna/repos","events_url":"https://api.github.com/users/mewna/events{/privacy}","received_events_url":"https://api.github.com/users/mewna/received_events","type":"Organization","site_admin":false},"repo":{"id":147063521,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcwNjM1MjE=","name":"catnip","full_name":"mewna/catnip","owner":{"login":"mewna","id":38661753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjYxNzUz","avatar_url":"https://avatars3.githubusercontent.com/u/38661753?v=4","gravatar_id":"","url":"https://api.github.com/users/mewna","html_url":"https://github.com/mewna","followers_url":"https://api.github.com/users/mewna/followers","following_url":"https://api.github.com/users/mewna/following{/other_user}","gists_url":"https://api.github.com/users/mewna/gists{/gist_id}","starred_url":"https://api.github.com/users/mewna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mewna/subscriptions","organizations_url":"https://api.github.com/users/mewna/orgs","repos_url":"https://api.github.com/users/mewna/repos","events_url":"https://api.github.com/users/mewna/events{/privacy}","received_events_url":"https://api.github.com/users/mewna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mewna/catnip","description":"A fully reactive / async Discord API wrapper for the JVM, built on vert.x","fork":false,"url":"https://api.github.com/repos/mewna/catnip","forks_url":"https://api.github.com/repos/mewna/catnip/forks","keys_url":"https://api.github.com/repos/mewna/catnip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mewna/catnip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mewna/catnip/teams","hooks_url":"https://api.github.com/repos/mewna/catnip/hooks","issue_events_url":"https://api.github.com/repos/mewna/catnip/issues/events{/number}","events_url":"https://api.github.com/repos/mewna/catnip/events","assignees_url":"https://api.github.com/repos/mewna/catnip/assignees{/user}","branches_url":"https://api.github.com/repos/mewna/catnip/branches{/branch}","tags_url":"https://api.github.com/repos/mewna/catnip/tags","blobs_url":"https://api.github.com/repos/mewna/catnip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mewna/catnip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mewna/catnip/git/refs{/sha}","trees_url":"https://api.github.com/repos/mewna/catnip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mewna/catnip/statuses/{sha}","languages_url":"https://api.github.com/repos/mewna/catnip/languages","stargazers_url":"https://api.github.com/repos/mewna/catnip/stargazers","contributors_url":"https://api.github.com/repos/mewna/catnip/contributors","subscribers_url":"https://api.github.com/repos/mewna/catnip/subscribers","subscription_url":"https://api.github.com/repos/mewna/catnip/subscription","commits_url":"https://api.github.com/repos/mewna/catnip/commits{/sha}","git_commits_url":"https://api.github.com/repos/mewna/catnip/git/commits{/sha}","comments_url":"https://api.github.com/repos/mewna/catnip/comments{/number}","issue_comment_url":"https://api.github.com/repos/mewna/catnip/issues/comments{/number}","contents_url":"https://api.github.com/repos/mewna/catnip/contents/{+path}","compare_url":"https://api.github.com/repos/mewna/catnip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mewna/catnip/merges","archive_url":"https://api.github.com/repos/mewna/catnip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mewna/catnip/downloads","issues_url":"https://api.github.com/repos/mewna/catnip/issues{/number}","pulls_url":"https://api.github.com/repos/mewna/catnip/pulls{/number}","milestones_url":"https://api.github.com/repos/mewna/catnip/milestones{/number}","notifications_url":"https://api.github.com/repos/mewna/catnip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mewna/catnip/labels{/name}","releases_url":"https://api.github.com/repos/mewna/catnip/releases{/id}","deployments_url":"https://api.github.com/repos/mewna/catnip/deployments","created_at":"2018-09-02T07:16:40Z","updated_at":"2018-09-05T22:27:02Z","pushed_at":"2018-09-05T22:27:01Z","git_url":"git://github.com/mewna/catnip.git","ssh_url":"git@github.com:mewna/catnip.git","clone_url":"https://github.com/mewna/catnip.git","svn_url":"https://github.com/mewna/catnip","homepage":"https://discord.gg/kCsBCjK","size":151,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":5,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mewna/catnip/pulls/25"},"html":{"href":"https://github.com/mewna/catnip/pull/25"},"issue":{"href":"https://api.github.com/repos/mewna/catnip/issues/25"},"comments":{"href":"https://api.github.com/repos/mewna/catnip/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/mewna/catnip/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/mewna/catnip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mewna/catnip/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/mewna/catnip/statuses/424c83957ef981f104ee8262f040654c4e2f4b63"}},"author_association":"NONE"}}
{"actor":{"display_login":"natanbc"}}