{"action":"closed","issue":{"url":"https://api.github.com/repos/GluuFederation/oxAuth/issues/799","repository_url":"https://api.github.com/repos/GluuFederation/oxAuth","labels_url":"https://api.github.com/repos/GluuFederation/oxAuth/issues/799/labels{/name}","comments_url":"https://api.github.com/repos/GluuFederation/oxAuth/issues/799/comments","events_url":"https://api.github.com/repos/GluuFederation/oxAuth/issues/799/events","html_url":"https://github.com/GluuFederation/oxAuth/issues/799","id":318078165,"number":799,"title":"If custom script getPageForStep throws error Authenticator shoudl redirect to error page","user":{"login":"yurem","id":6104200,"avatar_url":"https://avatars1.githubusercontent.com/u/6104200?v=4","gravatar_id":"","url":"https://api.github.com/users/yurem","html_url":"https://github.com/yurem","followers_url":"https://api.github.com/users/yurem/followers","following_url":"https://api.github.com/users/yurem/following{/other_user}","gists_url":"https://api.github.com/users/yurem/gists{/gist_id}","starred_url":"https://api.github.com/users/yurem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurem/subscriptions","organizations_url":"https://api.github.com/users/yurem/orgs","repos_url":"https://api.github.com/users/yurem/repos","events_url":"https://api.github.com/users/yurem/events{/privacy}","received_events_url":"https://api.github.com/users/yurem/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"yurem","id":6104200,"avatar_url":"https://avatars1.githubusercontent.com/u/6104200?v=4","gravatar_id":"","url":"https://api.github.com/users/yurem","html_url":"https://github.com/yurem","followers_url":"https://api.github.com/users/yurem/followers","following_url":"https://api.github.com/users/yurem/following{/other_user}","gists_url":"https://api.github.com/users/yurem/gists{/gist_id}","starred_url":"https://api.github.com/users/yurem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurem/subscriptions","organizations_url":"https://api.github.com/users/yurem/orgs","repos_url":"https://api.github.com/users/yurem/repos","events_url":"https://api.github.com/users/yurem/events{/privacy}","received_events_url":"https://api.github.com/users/yurem/received_events","type":"User","site_admin":false},"assignees":[{"login":"yurem","id":6104200,"avatar_url":"https://avatars1.githubusercontent.com/u/6104200?v=4","gravatar_id":"","url":"https://api.github.com/users/yurem","html_url":"https://github.com/yurem","followers_url":"https://api.github.com/users/yurem/followers","following_url":"https://api.github.com/users/yurem/following{/other_user}","gists_url":"https://api.github.com/users/yurem/gists{/gist_id}","starred_url":"https://api.github.com/users/yurem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurem/subscriptions","organizations_url":"https://api.github.com/users/yurem/orgs","repos_url":"https://api.github.com/users/yurem/repos","events_url":"https://api.github.com/users/yurem/events{/privacy}","received_events_url":"https://api.github.com/users/yurem/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/GluuFederation/oxAuth/milestones/16","html_url":"https://github.com/GluuFederation/oxAuth/milestone/16","labels_url":"https://api.github.com/repos/GluuFederation/oxAuth/milestones/16/labels","id":3145415,"number":16,"title":"3.1.4","description":"","creator":{"login":"willow9886","id":5271048,"avatar_url":"https://avatars0.githubusercontent.com/u/5271048?v=4","gravatar_id":"","url":"https://api.github.com/users/willow9886","html_url":"https://github.com/willow9886","followers_url":"https://api.github.com/users/willow9886/followers","following_url":"https://api.github.com/users/willow9886/following{/other_user}","gists_url":"https://api.github.com/users/willow9886/gists{/gist_id}","starred_url":"https://api.github.com/users/willow9886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willow9886/subscriptions","organizations_url":"https://api.github.com/users/willow9886/orgs","repos_url":"https://api.github.com/users/willow9886/repos","events_url":"https://api.github.com/users/willow9886/events{/privacy}","received_events_url":"https://api.github.com/users/willow9886/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":1,"state":"open","created_at":"2018-02-26T21:48:31Z","updated_at":"2018-04-26T15:31:11Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-04-26T15:19:55Z","updated_at":"2018-04-26T15:31:11Z","closed_at":"2018-04-26T15:31:11Z","author_association":"CONTRIBUTOR","body":"According to current code Authenticator redirects to login page instead of error page on `getPageForStep ` method execution error:\r\n```\r\n    public String executeExternalGetPageForStep(CustomScriptConfiguration customScriptConfiguration, int step) {\r\n        try {\r\n            log.debug(\"Executing python 'getPageForStep' authenticator method\");\r\n            PersonAuthenticationType externalAuthenticator = (PersonAuthenticationType) customScriptConfiguration.getExternalType();\r\n            Map<String, SimpleCustomProperty> configurationAttributes = customScriptConfiguration.getConfigurationAttributes();\r\n            return externalAuthenticator.getPageForStep(configurationAttributes, step);\r\n        } catch (Exception ex) {\r\n            log.error(ex.getMessage(), ex);\r\n        }\r\n\r\n        return null;\r\n    }\r\n```\r\n\r\nIt should redirect to `erorr` page.\r\n\r\nWe also need to check if other script which provides page has sum issue."}}
{"actor":{"display_login":"yurem"}}