{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/175985401","pull_request_review_id":105607635,"id":175985401,"diff_hunk":"@@ -433,6 +433,22 @@ func resourceAwsInstance() *schema.Resource {\n \t\t\t\t\t},\n \t\t\t\t},\n \t\t\t},\n+\n+\t\t\t\"credit_specification\": {\n+\t\t\t\tType:     schema.TypeList,\n+\t\t\t\tOptional: true,\n+\t\t\t\tComputed: true,\n+\t\t\t\tMaxItems: 1,\n+\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\"cpu_credits\": {\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tComputed: true,","path":"aws/resource_aws_instance.go","position":15,"original_position":15,"commit_id":"ac3d2acbd36e63fc4af9f44ad13392e304d5f6ec","original_commit_id":"ac3d2acbd36e63fc4af9f44ad13392e304d5f6ec","user":{"login":"omeid","id":1453118,"avatar_url":"https://avatars1.githubusercontent.com/u/1453118?v=4","gravatar_id":"","url":"https://api.github.com/users/omeid","html_url":"https://github.com/omeid","followers_url":"https://api.github.com/users/omeid/followers","following_url":"https://api.github.com/users/omeid/following{/other_user}","gists_url":"https://api.github.com/users/omeid/gists{/gist_id}","starred_url":"https://api.github.com/users/omeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omeid/subscriptions","organizations_url":"https://api.github.com/users/omeid/orgs","repos_url":"https://api.github.com/users/omeid/repos","events_url":"https://api.github.com/users/omeid/events{/privacy}","received_events_url":"https://api.github.com/users/omeid/received_events","type":"User","site_admin":false},"body":"I believe the API complains if you use something other than `unlimited` and `standard`, leaving this opaque in terraform gives _out of the box_ support for new `cpu_credit` types in the future.","created_at":"2018-03-21T05:02:04Z","updated_at":"2018-03-21T05:02:05Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619#discussion_r175985401","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/175985401"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619#discussion_r175985401"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619"}},"in_reply_to_id":175499418},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619","id":157453284,"html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/2619","number":2619,"state":"open","locked":false,"title":"r/aws_instance: add T2 unlimited to aws instance resources","user":{"login":"kl4w","id":1169346,"avatar_url":"https://avatars3.githubusercontent.com/u/1169346?v=4","gravatar_id":"","url":"https://api.github.com/users/kl4w","html_url":"https://github.com/kl4w","followers_url":"https://api.github.com/users/kl4w/followers","following_url":"https://api.github.com/users/kl4w/following{/other_user}","gists_url":"https://api.github.com/users/kl4w/gists{/gist_id}","starred_url":"https://api.github.com/users/kl4w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl4w/subscriptions","organizations_url":"https://api.github.com/users/kl4w/orgs","repos_url":"https://api.github.com/users/kl4w/repos","events_url":"https://api.github.com/users/kl4w/events{/privacy}","received_events_url":"https://api.github.com/users/kl4w/received_events","type":"User","site_admin":false},"body":"I think this should cover: https://github.com/terraform-providers/terraform-provider-aws/issues/2491\r\n\r\n```bash\r\nmake testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_t2Unlimited'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws -v -run=TestAccAWSInstance_t2Unlimited -timeout 120m\r\n=== RUN   TestAccAWSInstance_t2Unlimited_invalidInstanceType\r\n--- PASS: TestAccAWSInstance_t2Unlimited_invalidInstanceType (24.21s)\r\n=== RUN   TestAccAWSInstance_t2Unlimited_unlimitedCredits\r\n--- PASS: TestAccAWSInstance_t2Unlimited_unlimitedCredits (127.75s)\r\nPASS\r\nok  \tgithub.com/terraform-providers/terraform-provider-aws/aws\t151.986s\r\n\r\nmake testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_t2Unlimited'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws -v -run=TestAccAWSInstanceDataSource_t2Unlimited -timeout 120m\r\n=== RUN   TestAccAWSInstanceDataSource_t2Unlimited\r\n--- PASS: TestAccAWSInstanceDataSource_t2Unlimited (147.84s)\r\nPASS\r\nok  \tgithub.com/terraform-providers/terraform-provider-aws/aws\t147.866s\r\n```","created_at":"2017-12-10T22:24:13Z","updated_at":"2018-03-21T05:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60eb4a67620da257c55b8eb6b072ea07bd36d22a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316241,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/enhancement","name":"enhancement","color":"d4c5f9","default":true},{"id":794043766,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/ec2","name":"service/ec2","color":"bfd4f2","default":false},{"id":737832189,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/L","name":"size/L","color":"ffffff","default":false}],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/14","html_url":"https://github.com/terraform-providers/terraform-provider-aws/milestone/14","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/14/labels","id":3039709,"number":14,"title":"v1.12.0","description":"","creator":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars1.githubusercontent.com/u/287584?v=4","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":93,"state":"open","created_at":"2018-01-16T16:37:06Z","updated_at":"2018-03-21T00:38:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/2619/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/ac3d2acbd36e63fc4af9f44ad13392e304d5f6ec","head":{"label":"kl4w:t2_unlimited","ref":"t2_unlimited","sha":"ac3d2acbd36e63fc4af9f44ad13392e304d5f6ec","user":{"login":"kl4w","id":1169346,"avatar_url":"https://avatars3.githubusercontent.com/u/1169346?v=4","gravatar_id":"","url":"https://api.github.com/users/kl4w","html_url":"https://github.com/kl4w","followers_url":"https://api.github.com/users/kl4w/followers","following_url":"https://api.github.com/users/kl4w/following{/other_user}","gists_url":"https://api.github.com/users/kl4w/gists{/gist_id}","starred_url":"https://api.github.com/users/kl4w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl4w/subscriptions","organizations_url":"https://api.github.com/users/kl4w/orgs","repos_url":"https://api.github.com/users/kl4w/repos","events_url":"https://api.github.com/users/kl4w/events{/privacy}","received_events_url":"https://api.github.com/users/kl4w/received_events","type":"User","site_admin":false},"repo":{"id":100524710,"name":"terraform-provider-aws","full_name":"kl4w/terraform-provider-aws","owner":{"login":"kl4w","id":1169346,"avatar_url":"https://avatars3.githubusercontent.com/u/1169346?v=4","gravatar_id":"","url":"https://api.github.com/users/kl4w","html_url":"https://github.com/kl4w","followers_url":"https://api.github.com/users/kl4w/followers","following_url":"https://api.github.com/users/kl4w/following{/other_user}","gists_url":"https://api.github.com/users/kl4w/gists{/gist_id}","starred_url":"https://api.github.com/users/kl4w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl4w/subscriptions","organizations_url":"https://api.github.com/users/kl4w/orgs","repos_url":"https://api.github.com/users/kl4w/repos","events_url":"https://api.github.com/users/kl4w/events{/privacy}","received_events_url":"https://api.github.com/users/kl4w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kl4w/terraform-provider-aws","description":"Terraform aws provider","fork":true,"url":"https://api.github.com/repos/kl4w/terraform-provider-aws","forks_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/kl4w/terraform-provider-aws/deployments","created_at":"2017-08-16T19:23:11Z","updated_at":"2017-08-16T19:23:16Z","pushed_at":"2018-03-19T16:23:52Z","git_url":"git://github.com/kl4w/terraform-provider-aws.git","ssh_url":"git@github.com:kl4w/terraform-provider-aws.git","clone_url":"https://github.com/kl4w/terraform-provider-aws.git","svn_url":"https://github.com/kl4w/terraform-provider-aws","homepage":"","size":31784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"80d66ecb1be2e969b562f1ec84be029ae3918a20","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-03-20T23:27:46Z","pushed_at":"2018-03-21T02:59:53Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":32181,"stargazers_count":926,"watchers_count":926,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":842,"mirror_url":null,"archived":false,"open_issues_count":1779,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":842,"open_issues":1779,"watchers":926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/2619"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/2619"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/2619/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/2619/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/ac3d2acbd36e63fc4af9f44ad13392e304d5f6ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"omeid"}}