{"action":"created","issue":{"url":"https://api.github.com/repos/chadwhitacre/go/issues/2","repository_url":"https://api.github.com/repos/chadwhitacre/go","labels_url":"https://api.github.com/repos/chadwhitacre/go/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/chadwhitacre/go/issues/2/comments","events_url":"https://api.github.com/repos/chadwhitacre/go/issues/2/events","html_url":"https://github.com/chadwhitacre/go/pull/2","id":385438767,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDA5ODg2","number":2,"title":"[-v] cmd/compile: incorrect package initialization order for spec example","user":{"login":"chadwhitacre","id":134455,"node_id":"MDQ6VXNlcjEzNDQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134455?v=4","gravatar_id":"","url":"https://api.github.com/users/chadwhitacre","html_url":"https://github.com/chadwhitacre","followers_url":"https://api.github.com/users/chadwhitacre/followers","following_url":"https://api.github.com/users/chadwhitacre/following{/other_user}","gists_url":"https://api.github.com/users/chadwhitacre/gists{/gist_id}","starred_url":"https://api.github.com/users/chadwhitacre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadwhitacre/subscriptions","organizations_url":"https://api.github.com/users/chadwhitacre/orgs","repos_url":"https://api.github.com/users/chadwhitacre/repos","events_url":"https://api.github.com/users/chadwhitacre/events{/privacy}","received_events_url":"https://api.github.com/users/chadwhitacre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":94,"created_at":"2018-11-28T20:14:45Z","updated_at":"2018-12-26T18:20:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/chadwhitacre/go/pulls/2","html_url":"https://github.com/chadwhitacre/go/pull/2","diff_url":"https://github.com/chadwhitacre/go/pull/2.diff","patch_url":"https://github.com/chadwhitacre/go/pull/2.patch"},"body":"Picking up from #1 ...\r\n\r\n### Todo\r\n\r\n- [x] determine state needed in walk in order to generate `lout` properly\r\n- [x] populate the state!\r\n- [ ] generate `lout` properly\r\n- [ ] clean up any code elsewhere in Go that depends on this buggy behavior\r\n\r\n#### Then\r\n\r\n- [ ] find a nicer way to initialize `Deps`\r\n- [ ] [consider](https://blog.golang.org/go-maps-in-action#TOC_4.) `bool` instead of `struct{}` for deps\r\n- [ ] unit test Deps\r\n- [ ] I guess static variables are added directly so shouldn't be included?\r\n- [ ] ensure all sorts of assignments are covered, expand test suite\r\n- [ ] make sure pointer usage is correct\r\n- [ ] protect against infinite looping\r\n- [ ] check performance\r\n- [ ] sort dcls by number of deps?\r\n- [ ] test traversing across multiple functions\r\n\r\n#### Meanwhile\r\n\r\n- [ ] https://tour.golang.org/methods/18\r\n- [ ] https://golang.org/doc/code.html\r\n- [ ] https://golang.org/doc/effective_go.html\r\n- [ ] https://github.com/golang/go/wiki/SliceTricks\r\n\r\n#### Finally\r\n\r\n- [ ] https://github.com/golang/go/wiki/CodeReviewComments\r\n- [ ] https://golang.org/doc/contribute.html\r\n\r\n#### Further\r\n\r\n- [ ] investigate `OAS2` and `OASOP`—what happens if I `x,y = 1,2` or `x = 1; x += 1` in `xtop`?\r\n- [ ] investigate `Ninit`—does `initreorder` ever actually recurse? Can we get some test coverage reporting?\r\n- [ ] investigate `nf`—what if we have init functions but no statements? really return early?"},"comment":{"url":"https://api.github.com/repos/chadwhitacre/go/issues/comments/450004399","html_url":"https://github.com/chadwhitacre/go/pull/2#issuecomment-450004399","issue_url":"https://api.github.com/repos/chadwhitacre/go/issues/2","id":450004399,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDAwNDM5OQ==","user":{"login":"chadwhitacre","id":134455,"node_id":"MDQ6VXNlcjEzNDQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134455?v=4","gravatar_id":"","url":"https://api.github.com/users/chadwhitacre","html_url":"https://github.com/chadwhitacre","followers_url":"https://api.github.com/users/chadwhitacre/followers","following_url":"https://api.github.com/users/chadwhitacre/following{/other_user}","gists_url":"https://api.github.com/users/chadwhitacre/gists{/gist_id}","starred_url":"https://api.github.com/users/chadwhitacre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadwhitacre/subscriptions","organizations_url":"https://api.github.com/users/chadwhitacre/orgs","repos_url":"https://api.github.com/users/chadwhitacre/repos","events_url":"https://api.github.com/users/chadwhitacre/events{/privacy}","received_events_url":"https://api.github.com/users/chadwhitacre/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T18:20:19Z","updated_at":"2018-12-26T18:20:19Z","author_association":"OWNER","body":"Ooooh ... we're not going to have to rewrite programs, are we? 🙈\r\n\r\nhttps://github.com/chadwhitacre/go/blob/048c9164a0c5572df18325e377473e7893dbfb07/src/cmd/internal/obj/x86/obj6.go#L299\r\n\r\nhttps://github.com/chadwhitacre/go/blob/048c9164a0c5572df18325e377473e7893dbfb07/src/cmd/internal/obj/x86/obj6.go#L488"}}
{"actor":{"display_login":"chadwhitacre"}}