{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments/205993070","pull_request_review_id":141366333,"id":205993070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk5MzA3MA==","diff_hunk":"@@ -0,0 +1,90 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.gobblin.service.modules.dataset;\n+\n+import com.google.common.base.Joiner;\n+import com.typesafe.config.Config;\n+\n+import lombok.Getter;\n+\n+import org.apache.gobblin.service.modules.flowgraph.DatasetDescriptorConfigKeys;\n+import org.apache.gobblin.util.ConfigUtils;\n+\n+\n+public class EncryptionConfig {\n+  @Getter\n+  private final String encryptionAlgorithm;\n+  @Getter\n+  private final String keystoreType;\n+  @Getter\n+  private final String keystoreEncoding;\n+\n+  public EncryptionConfig(Config encryptionConfig) {\n+    this.encryptionAlgorithm = ConfigUtils.getString(encryptionConfig, DatasetDescriptorConfigKeys.ENCRYPTION_ALGORITHM_KEY,\n+        DatasetDescriptorConfigKeys.DATASET_DESCRIPTOR_CONFIG_ANY);\n+    this.keystoreType = ConfigUtils.getString(encryptionConfig, DatasetDescriptorConfigKeys.ENCRYPTION_KEYSTORE_TYPE_KEY,\n+        DatasetDescriptorConfigKeys.DATASET_DESCRIPTOR_CONFIG_ANY);\n+    this.keystoreEncoding = ConfigUtils.getString(encryptionConfig, DatasetDescriptorConfigKeys.ENCRYPTION_KEYSTORE_ENCODING_KEY,\n+        DatasetDescriptorConfigKeys.DATASET_DESCRIPTOR_CONFIG_ANY);\n+  }\n+\n+  public boolean contains(EncryptionConfig other) {","path":"gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/EncryptionConfig.java","position":46,"original_position":46,"commit_id":"4c6a9f01f5c2085582d6d8a6db7ed789f8d28fc6","original_commit_id":"4c6a9f01f5c2085582d6d8a6db7ed789f8d28fc6","user":{"login":"sv2000","id":6979567,"node_id":"MDQ6VXNlcjY5Nzk1Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/6979567?v=4","gravatar_id":"","url":"https://api.github.com/users/sv2000","html_url":"https://github.com/sv2000","followers_url":"https://api.github.com/users/sv2000/followers","following_url":"https://api.github.com/users/sv2000/following{/other_user}","gists_url":"https://api.github.com/users/sv2000/gists{/gist_id}","starred_url":"https://api.github.com/users/sv2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv2000/subscriptions","organizations_url":"https://api.github.com/users/sv2000/orgs","repos_url":"https://api.github.com/users/sv2000/repos","events_url":"https://api.github.com/users/sv2000/events{/privacy}","received_events_url":"https://api.github.com/users/sv2000/received_events","type":"User","site_admin":false},"body":"EncryptionConfig is part of DatasetConfig. It is not an implementation of DatasetConfig.","created_at":"2018-07-30T00:19:11Z","updated_at":"2018-07-30T00:19:11Z","html_url":"https://github.com/apache/incubator-gobblin/pull/2393#discussion_r205993070","pull_request_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments/205993070"},"html":{"href":"https://github.com/apache/incubator-gobblin/pull/2393#discussion_r205993070"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393"}},"in_reply_to_id":205986976},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393","id":199991549,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTkxNTQ5","html_url":"https://github.com/apache/incubator-gobblin/pull/2393","diff_url":"https://github.com/apache/incubator-gobblin/pull/2393.diff","patch_url":"https://github.com/apache/incubator-gobblin/pull/2393.patch","issue_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/2393","number":2393,"state":"open","locked":false,"title":"GOBBLIN-528: Multihop Flow Compiler for Gobblin-as-a-Service (GaaS).","user":{"login":"sv2000","id":6979567,"node_id":"MDQ6VXNlcjY5Nzk1Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/6979567?v=4","gravatar_id":"","url":"https://api.github.com/users/sv2000","html_url":"https://github.com/sv2000","followers_url":"https://api.github.com/users/sv2000/followers","following_url":"https://api.github.com/users/sv2000/following{/other_user}","gists_url":"https://api.github.com/users/sv2000/gists{/gist_id}","starred_url":"https://api.github.com/users/sv2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv2000/subscriptions","organizations_url":"https://api.github.com/users/sv2000/orgs","repos_url":"https://api.github.com/users/sv2000/repos","events_url":"https://api.github.com/users/sv2000/events{/privacy}","received_events_url":"https://api.github.com/users/sv2000/received_events","type":"User","site_admin":false},"body":"Dear Gobblin maintainers,\r\n\r\nPlease accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!\r\n\r\n\r\n### JIRA\r\n- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, \"[GOBBLIN-XXX] My Gobblin PR\"\r\n    - https://issues.apache.org/jira/browse/GOBBLIN-528\r\n\r\n\r\n### Description\r\n- [x] Here are some details about my PR, including screenshots (if applicable):\r\nCreate a new flow compiler that can compile flows into a DAG of JobSpecs. \r\n\r\n### Tests\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\nAmong other unit tests, added unit test FlowGraphPathFinderTest for testing flow compilation.\r\n\r\n### Commits\r\n- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n    1. Subject is separated from body by a blank line\r\n    2. Subject is limited to 50 characters\r\n    3. Subject does not end with a period\r\n    4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n    5. Body wraps at 72 characters\r\n    6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n","created_at":"2018-07-09T04:55:49Z","updated_at":"2018-07-30T00:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a428b2ab8fcef5f47d8a69a6c2820d6ee5d590c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/2393/comments","statuses_url":"https://api.github.com/repos/apache/incubator-gobblin/statuses/4c6a9f01f5c2085582d6d8a6db7ed789f8d28fc6","head":{"label":"sv2000:multiHopCompiler","ref":"multiHopCompiler","sha":"4c6a9f01f5c2085582d6d8a6db7ed789f8d28fc6","user":{"login":"sv2000","id":6979567,"node_id":"MDQ6VXNlcjY5Nzk1Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/6979567?v=4","gravatar_id":"","url":"https://api.github.com/users/sv2000","html_url":"https://github.com/sv2000","followers_url":"https://api.github.com/users/sv2000/followers","following_url":"https://api.github.com/users/sv2000/following{/other_user}","gists_url":"https://api.github.com/users/sv2000/gists{/gist_id}","starred_url":"https://api.github.com/users/sv2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv2000/subscriptions","organizations_url":"https://api.github.com/users/sv2000/orgs","repos_url":"https://api.github.com/users/sv2000/repos","events_url":"https://api.github.com/users/sv2000/events{/privacy}","received_events_url":"https://api.github.com/users/sv2000/received_events","type":"User","site_admin":false},"repo":{"id":110619744,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MTk3NDQ=","name":"incubator-gobblin","full_name":"sv2000/incubator-gobblin","owner":{"login":"sv2000","id":6979567,"node_id":"MDQ6VXNlcjY5Nzk1Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/6979567?v=4","gravatar_id":"","url":"https://api.github.com/users/sv2000","html_url":"https://github.com/sv2000","followers_url":"https://api.github.com/users/sv2000/followers","following_url":"https://api.github.com/users/sv2000/following{/other_user}","gists_url":"https://api.github.com/users/sv2000/gists{/gist_id}","starred_url":"https://api.github.com/users/sv2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sv2000/subscriptions","organizations_url":"https://api.github.com/users/sv2000/orgs","repos_url":"https://api.github.com/users/sv2000/repos","events_url":"https://api.github.com/users/sv2000/events{/privacy}","received_events_url":"https://api.github.com/users/sv2000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sv2000/incubator-gobblin","description":"Gobblin is a distributed big data integration framework (ingestion, replication, compliance, retention)  for batch and streaming systems. Gobblin features integrations with Apache Hadoop, Apache Kafka, Salesforce, S3, MySQL, Google etc.","fork":true,"url":"https://api.github.com/repos/sv2000/incubator-gobblin","forks_url":"https://api.github.com/repos/sv2000/incubator-gobblin/forks","keys_url":"https://api.github.com/repos/sv2000/incubator-gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sv2000/incubator-gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sv2000/incubator-gobblin/teams","hooks_url":"https://api.github.com/repos/sv2000/incubator-gobblin/hooks","issue_events_url":"https://api.github.com/repos/sv2000/incubator-gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/sv2000/incubator-gobblin/events","assignees_url":"https://api.github.com/repos/sv2000/incubator-gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/sv2000/incubator-gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/sv2000/incubator-gobblin/tags","blobs_url":"https://api.github.com/repos/sv2000/incubator-gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sv2000/incubator-gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sv2000/incubator-gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sv2000/incubator-gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sv2000/incubator-gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/sv2000/incubator-gobblin/languages","stargazers_url":"https://api.github.com/repos/sv2000/incubator-gobblin/stargazers","contributors_url":"https://api.github.com/repos/sv2000/incubator-gobblin/contributors","subscribers_url":"https://api.github.com/repos/sv2000/incubator-gobblin/subscribers","subscription_url":"https://api.github.com/repos/sv2000/incubator-gobblin/subscription","commits_url":"https://api.github.com/repos/sv2000/incubator-gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sv2000/incubator-gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sv2000/incubator-gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sv2000/incubator-gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sv2000/incubator-gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/sv2000/incubator-gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sv2000/incubator-gobblin/merges","archive_url":"https://api.github.com/repos/sv2000/incubator-gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sv2000/incubator-gobblin/downloads","issues_url":"https://api.github.com/repos/sv2000/incubator-gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/sv2000/incubator-gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/sv2000/incubator-gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/sv2000/incubator-gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sv2000/incubator-gobblin/labels{/name}","releases_url":"https://api.github.com/repos/sv2000/incubator-gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/sv2000/incubator-gobblin/deployments","created_at":"2017-11-14T00:36:11Z","updated_at":"2018-07-18T04:05:39Z","pushed_at":"2018-07-29T16:47:27Z","git_url":"git://github.com/sv2000/incubator-gobblin.git","ssh_url":"git@github.com:sv2000/incubator-gobblin.git","clone_url":"https://github.com/sv2000/incubator-gobblin.git","svn_url":"https://github.com/sv2000/incubator-gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":123073,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f543a39a4e69ebbdf4b948323892bdd6efe8c54a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"node_id":"MDEwOlJlcG9zaXRvcnkyNzM5MjU0Mw==","name":"incubator-gobblin","full_name":"apache/incubator-gobblin","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-gobblin","description":"Gobblin is a distributed big data integration framework (ingestion, replication, compliance, retention)  for batch and streaming systems. Gobblin features integrations with Apache Hadoop, Apache Kafka, Salesforce, S3, MySQL, Google etc.","fork":false,"url":"https://api.github.com/repos/apache/incubator-gobblin","forks_url":"https://api.github.com/repos/apache/incubator-gobblin/forks","keys_url":"https://api.github.com/repos/apache/incubator-gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-gobblin/teams","hooks_url":"https://api.github.com/repos/apache/incubator-gobblin/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-gobblin/events","assignees_url":"https://api.github.com/repos/apache/incubator-gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-gobblin/tags","blobs_url":"https://api.github.com/repos/apache/incubator-gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-gobblin/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-gobblin/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-gobblin/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-gobblin/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-gobblin/subscription","commits_url":"https://api.github.com/repos/apache/incubator-gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-gobblin/merges","archive_url":"https://api.github.com/repos/apache/incubator-gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-gobblin/downloads","issues_url":"https://api.github.com/repos/apache/incubator-gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-gobblin/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2018-07-29T15:32:48Z","pushed_at":"2018-07-29T16:47:29Z","git_url":"git://github.com/apache/incubator-gobblin.git","ssh_url":"git@github.com:apache/incubator-gobblin.git","clone_url":"https://github.com/apache/incubator-gobblin.git","svn_url":"https://github.com/apache/incubator-gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":122855,"stargazers_count":1338,"watchers_count":1338,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":522,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":522,"open_issues":30,"watchers":1338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393"},"html":{"href":"https://github.com/apache/incubator-gobblin/pull/2393"},"issue":{"href":"https://api.github.com/repos/apache/incubator-gobblin/issues/2393"},"comments":{"href":"https://api.github.com/repos/apache/incubator-gobblin/issues/2393/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-gobblin/pulls/2393/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-gobblin/statuses/4c6a9f01f5c2085582d6d8a6db7ed789f8d28fc6"}},"author_association":"NONE"}}
{"actor":{"display_login":"sv2000"}}