{"action":"created","comment":{"url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/comments/166655840","pull_request_review_id":94753656,"id":166655840,"diff_hunk":"@@ -39,37 +24,48 @@ module.exports = {\n     }\n     this.app = app;\n \n-    for (let i = 0; i < FONT_FILES.length; i++) {\n-      app.import(fontPath(app, FONT_FILES[i]), {\n-        destDir: 'assets'\n-      });\n-    }\n-\n     if (!(app.options['materialize-shim'] || {}).omitJS) {\n       app.import('vendor/materialize/materialize.js');\n-      app.import('vendor/materialize-shim.js', {\n-        exports: {","path":"index.js","position":53,"original_position":53,"commit_id":"487269c26a56aecc5e9c80f078ba78cb23646c4d","original_commit_id":"487269c26a56aecc5e9c80f078ba78cb23646c4d","user":{"login":"jacobq","id":1633459,"avatar_url":"https://avatars3.githubusercontent.com/u/1633459?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobq","html_url":"https://github.com/jacobq","followers_url":"https://api.github.com/users/jacobq/followers","following_url":"https://api.github.com/users/jacobq/following{/other_user}","gists_url":"https://api.github.com/users/jacobq/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobq/subscriptions","organizations_url":"https://api.github.com/users/jacobq/orgs","repos_url":"https://api.github.com/users/jacobq/repos","events_url":"https://api.github.com/users/jacobq/events{/privacy}","received_events_url":"https://api.github.com/users/jacobq/received_events","type":"User","site_admin":false},"body":"(for my own reference) I just found the [docs that mention this](https://guides.emberjs.com/v2.18.0/addons-and-dependencies/managing-dependencies/#toc_amd-javascript-modules), but it's still not clear to me why/when one would want to use this. Also, I would expect this to be defined somewhere in the `ember-cli` docs, but [this is the closest thing I've found](https://ember-cli.com/api/classes/EmberApp.html#method_import).","created_at":"2018-02-07T15:37:14Z","updated_at":"2018-02-07T15:37:14Z","html_url":"https://github.com/mike-north/ember-materialize-shim/pull/109#discussion_r166655840","pull_request_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/comments/166655840"},"html":{"href":"https://github.com/mike-north/ember-materialize-shim/pull/109#discussion_r166655840"},"pull_request":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109","id":165589542,"html_url":"https://github.com/mike-north/ember-materialize-shim/pull/109","diff_url":"https://github.com/mike-north/ember-materialize-shim/pull/109.diff","patch_url":"https://github.com/mike-north/ember-materialize-shim/pull/109.patch","issue_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/109","number":109,"state":"open","locked":false,"title":"[WIP] Drop bower","user":{"login":"mike-north","id":558005,"avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"body":"First spike at pulling materialize from npm instead of bower. Anyone who depends on something like \r\n```\r\n\"ember-materialize-shim\": \"^0.5.0\"\r\n```\r\nwill not automatically pull this in.\r\n\r\n#### TODO\r\n- [ ] Add in checks and assertions to ensure that `<= v0.5.x` users are able to smoothly migrate to this version\r\n- [ ] Add in a `npm postinstall` script informing users that they can pin `materialize` to an older version if they wish\r\n- [ ] Add in assertions to `index.js` clearly telling the user what to do if `ember-cli-sass` is not found\r\n- [ ] Update README to reflect new Sass include path.\r\n- [ ] Add section to [ember-cli-materialize](https://github.com/mike-north/ember-cli-materialize) README, informing consumers of the ability to pin versions of materialize, this library, and ember-cli-materialize, and ember-material-design-icons-shim independently.","created_at":"2018-01-28T21:51:36Z","updated_at":"2018-02-07T15:37:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd46c969e6604e2dccdb931513e757e80b610916","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109/commits","review_comments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109/comments","review_comment_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/109/comments","statuses_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/statuses/487269c26a56aecc5e9c80f078ba78cb23646c4d","head":{"label":"mike-north:npm-materialize","ref":"npm-materialize","sha":"487269c26a56aecc5e9c80f078ba78cb23646c4d","user":{"login":"mike-north","id":558005,"avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"repo":{"id":53716418,"name":"ember-materialize-shim","full_name":"mike-north/ember-materialize-shim","owner":{"login":"mike-north","id":558005,"avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-north/ember-materialize-shim","description":"A simple shim for using Materialize in Ember.js apps","fork":false,"url":"https://api.github.com/repos/mike-north/ember-materialize-shim","forks_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/forks","keys_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/teams","hooks_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/hooks","issue_events_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/events{/number}","events_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/events","assignees_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/assignees{/user}","branches_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/branches{/branch}","tags_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/tags","blobs_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/languages","stargazers_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/stargazers","contributors_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/contributors","subscribers_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/subscribers","subscription_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/subscription","commits_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/contents/{+path}","compare_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/merges","archive_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/downloads","issues_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues{/number}","pulls_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/labels{/name}","releases_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/releases{/id}","deployments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/deployments","created_at":"2016-03-12T06:07:25Z","updated_at":"2017-06-20T15:53:56Z","pushed_at":"2018-02-05T10:43:01Z","git_url":"git://github.com/mike-north/ember-materialize-shim.git","ssh_url":"git@github.com:mike-north/ember-materialize-shim.git","clone_url":"https://github.com/mike-north/ember-materialize-shim.git","svn_url":"https://github.com/mike-north/ember-materialize-shim","homepage":null,"size":511,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":3,"watchers":18,"default_branch":"master"}},"base":{"label":"mike-north:master","ref":"master","sha":"376f0984ebdea277033908fa037a0275df23b75a","user":{"login":"mike-north","id":558005,"avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"repo":{"id":53716418,"name":"ember-materialize-shim","full_name":"mike-north/ember-materialize-shim","owner":{"login":"mike-north","id":558005,"avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-north/ember-materialize-shim","description":"A simple shim for using Materialize in Ember.js apps","fork":false,"url":"https://api.github.com/repos/mike-north/ember-materialize-shim","forks_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/forks","keys_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/teams","hooks_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/hooks","issue_events_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/events{/number}","events_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/events","assignees_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/assignees{/user}","branches_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/branches{/branch}","tags_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/tags","blobs_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/languages","stargazers_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/stargazers","contributors_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/contributors","subscribers_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/subscribers","subscription_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/subscription","commits_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/contents/{+path}","compare_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/merges","archive_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/downloads","issues_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues{/number}","pulls_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/labels{/name}","releases_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/releases{/id}","deployments_url":"https://api.github.com/repos/mike-north/ember-materialize-shim/deployments","created_at":"2016-03-12T06:07:25Z","updated_at":"2017-06-20T15:53:56Z","pushed_at":"2018-02-05T10:43:01Z","git_url":"git://github.com/mike-north/ember-materialize-shim.git","ssh_url":"git@github.com:mike-north/ember-materialize-shim.git","clone_url":"https://github.com/mike-north/ember-materialize-shim.git","svn_url":"https://github.com/mike-north/ember-materialize-shim","homepage":null,"size":511,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":3,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109"},"html":{"href":"https://github.com/mike-north/ember-materialize-shim/pull/109"},"issue":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/109"},"comments":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/mike-north/ember-materialize-shim/statuses/487269c26a56aecc5e9c80f078ba78cb23646c4d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jacobq"}}