{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11689","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11689/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11689/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11689/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11689","id":344920133,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjAxMjg0","number":11689,"title":"[MRG+1] Make _hstack a staticmethod on ColumnTransformer","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-26T16:40:08Z","updated_at":"2018-07-26T17:00:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11689","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11689","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11689.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11689.patch"},"body":"This lets subclasses re-use more of sklearn.compose._column_transformer.\r\n\r\nThe `dask_ml` implementation went from 170 lines of code to 30 by being able to override just `_hstack`.\r\n\r\nxref https://github.com/dask/dask-ml/pull/315\r\n\r\ncc @ogrisel "},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/408165092","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11689#issuecomment-408165092","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11689","id":408165092,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODE2NTA5Mg==","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T17:00:07Z","updated_at":"2018-07-26T17:00:07Z","author_association":"CONTRIBUTOR","body":"I'd say it's \"you *probably* aint gonna need it\" :) But since it's an easy change let's it a regular method."}}
{"actor":{"display_login":"TomAugspurger"}}