{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36","id":217720372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzIwMzcy","html_url":"https://github.com/mrmr1993/coq-of-ocaml/pull/36","diff_url":"https://github.com/mrmr1993/coq-of-ocaml/pull/36.diff","patch_url":"https://github.com/mrmr1993/coq-of-ocaml/pull/36.patch","issue_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/36","number":36,"state":"open","locked":false,"title":"Simplify FullEnvi, carry constructor/field types more sensibly","user":{"login":"mrmr1993","id":1847343,"node_id":"MDQ6VXNlcjE4NDczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1847343?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"body":"This PR\r\n* moves `Mod.Value.t`, `Type.t` and `TypeDefinition.t` into a new `Kerneltypes` module, so that the environment can contain `TypeDefinition.t` values\r\n* reworks the `FullEnvi` values interface to have a much simpler backend\r\n* rewrites inductive types and their constructors more tidily using `TypeDefinition.update_env` in `PervasivesModule`\r\n* updates the interface format so that types carry their whole `TypeDefinition.t`, instead of having separate constructors and fields\r\n* adds `TypeDefinition.t` to `Type` values in the environment\r\n* simplifies the data carried with constructors and fields in the environment, using the `TypeDefinition.t` with the corresponding type to find the necessary information\r\n* updates the expected test output to use the new interface format.","created_at":"2018-09-24T16:47:38Z","updated_at":"2018-09-24T16:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36/commits","review_comments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36/comments","review_comment_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/36/comments","statuses_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/statuses/87abfcadf837026ec80768b9dd56a54e44b4d260","head":{"label":"mrmr1993:tidy-values","ref":"tidy-values","sha":"87abfcadf837026ec80768b9dd56a54e44b4d260","user":{"login":"mrmr1993","id":1847343,"node_id":"MDQ6VXNlcjE4NDczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1847343?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"repo":{"id":114308863,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQzMDg4NjM=","name":"coq-of-ocaml","full_name":"mrmr1993/coq-of-ocaml","private":false,"owner":{"login":"mrmr1993","id":1847343,"node_id":"MDQ6VXNlcjE4NDczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1847343?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrmr1993/coq-of-ocaml","description":"Compile OCaml to Coq.","fork":true,"url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml","forks_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/forks","keys_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/teams","hooks_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/hooks","issue_events_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/events","assignees_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/tags","blobs_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/languages","stargazers_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/stargazers","contributors_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/contributors","subscribers_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/subscribers","subscription_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/subscription","commits_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/merges","archive_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/downloads","issues_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/labels{/name}","releases_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/deployments","created_at":"2017-12-15T00:17:57Z","updated_at":"2018-09-24T11:20:32Z","pushed_at":"2018-09-24T16:39:48Z","git_url":"git://github.com/mrmr1993/coq-of-ocaml.git","ssh_url":"git@github.com:mrmr1993/coq-of-ocaml.git","clone_url":"https://github.com/mrmr1993/coq-of-ocaml.git","svn_url":"https://github.com/mrmr1993/coq-of-ocaml","homepage":"","size":2543,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mrmr1993:master","ref":"master","sha":"2a876391e1d59e9cde2971cc32231130f07a4ebd","user":{"login":"mrmr1993","id":1847343,"node_id":"MDQ6VXNlcjE4NDczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1847343?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"repo":{"id":114308863,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQzMDg4NjM=","name":"coq-of-ocaml","full_name":"mrmr1993/coq-of-ocaml","private":false,"owner":{"login":"mrmr1993","id":1847343,"node_id":"MDQ6VXNlcjE4NDczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1847343?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrmr1993/coq-of-ocaml","description":"Compile OCaml to Coq.","fork":true,"url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml","forks_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/forks","keys_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/teams","hooks_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/hooks","issue_events_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/events","assignees_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/tags","blobs_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/languages","stargazers_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/stargazers","contributors_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/contributors","subscribers_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/subscribers","subscription_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/subscription","commits_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/merges","archive_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/downloads","issues_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/labels{/name}","releases_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/deployments","created_at":"2017-12-15T00:17:57Z","updated_at":"2018-09-24T11:20:32Z","pushed_at":"2018-09-24T16:39:48Z","git_url":"git://github.com/mrmr1993/coq-of-ocaml.git","ssh_url":"git@github.com:mrmr1993/coq-of-ocaml.git","clone_url":"https://github.com/mrmr1993/coq-of-ocaml.git","svn_url":"https://github.com/mrmr1993/coq-of-ocaml","homepage":"","size":2543,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36"},"html":{"href":"https://github.com/mrmr1993/coq-of-ocaml/pull/36"},"issue":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/36"},"comments":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/mrmr1993/coq-of-ocaml/statuses/87abfcadf837026ec80768b9dd56a54e44b4d260"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":499,"deletions":642,"changed_files":21}}
{"actor":{"display_login":"mrmr1993"}}