{"action":"closed","issue":{"url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/185","repository_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign","labels_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/185/comments","events_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/185/events","html_url":"https://github.com/DeclareDesign/DeclareDesign/issues/185","id":326004946,"node_id":"MDU6SXNzdWUzMjYwMDQ5NDY=","number":185,"title":"get_estimates() get_estimands() on multiple designs","user":{"login":"macartan","id":12734205,"node_id":"MDQ6VXNlcjEyNzM0MjA1","avatar_url":"https://avatars1.githubusercontent.com/u/12734205?v=4","gravatar_id":"","url":"https://api.github.com/users/macartan","html_url":"https://github.com/macartan","followers_url":"https://api.github.com/users/macartan/followers","following_url":"https://api.github.com/users/macartan/following{/other_user}","gists_url":"https://api.github.com/users/macartan/gists{/gist_id}","starred_url":"https://api.github.com/users/macartan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macartan/subscriptions","organizations_url":"https://api.github.com/users/macartan/orgs","repos_url":"https://api.github.com/users/macartan/repos","events_url":"https://api.github.com/users/macartan/events{/privacy}","received_events_url":"https://api.github.com/users/macartan/received_events","type":"User","site_admin":false},"labels":[{"id":952411650,"node_id":"MDU6TGFiZWw5NTI0MTE2NTA=","url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/labels/quick-win","name":"quick-win","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/milestones/1","html_url":"https://github.com/DeclareDesign/DeclareDesign/milestone/1","labels_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/milestones/1/labels","id":2722066,"node_id":"MDk6TWlsZXN0b25lMjcyMjA2Ng==","number":1,"title":"CRAN v1 release","description":null,"creator":{"login":"graemeblair","id":3320015,"node_id":"MDQ6VXNlcjMzMjAwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3320015?v=4","gravatar_id":"","url":"https://api.github.com/users/graemeblair","html_url":"https://github.com/graemeblair","followers_url":"https://api.github.com/users/graemeblair/followers","following_url":"https://api.github.com/users/graemeblair/following{/other_user}","gists_url":"https://api.github.com/users/graemeblair/gists{/gist_id}","starred_url":"https://api.github.com/users/graemeblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemeblair/subscriptions","organizations_url":"https://api.github.com/users/graemeblair/orgs","repos_url":"https://api.github.com/users/graemeblair/repos","events_url":"https://api.github.com/users/graemeblair/events{/privacy}","received_events_url":"https://api.github.com/users/graemeblair/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":17,"state":"open","created_at":"2017-08-24T22:30:40Z","updated_at":"2018-06-04T02:03:02Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-24T07:56:55Z","updated_at":"2018-06-04T02:03:02Z","closed_at":"2018-06-04T02:03:01Z","author_association":"CONTRIBUTOR","body":"If we have multiple designs:\r\n```\r\ndesigns <- expand_design(\r\n  simple_two_arm_designer,\r\n  N = c(10:12))\r\n```\r\n`get_estimates(designs[[1]])` works  but this does not \r\n\r\n```\r\n> get_estimates(designs)\r\nError in if (step_type %in% names(results)) { : \r\n  argument is of length zero\r\n```\r\nOne can do essentially this using diagnose_design:\r\n\r\n```\r\ndiagnose_design(designs, sims =1)[[1]]\r\n```\r\nBut seems more natural to have get_estimates and get_estimands run on a list.\r\n\r\nNote currently wanting this for a metaanalysis design where multiple designs are simultaneously declared and an estimator then takes an estimate from each. \r\n\r\nAside -- there is a relation here to the diagnose_design(simulations_df...) request: currently diagnose design really does two distinct things that are useful separately (1) run the design one or many times and make a simulations_df (2) calculate diagnosands from a simulations_df;\r\n\r\nA structure like this might make this more flexible:\r\n\r\n```\r\nrun_design <- function(design, sims) {....}\r\ndiagnose_design <- function(simulations = NULL, design = NULL, diagnosands, sims = 500,...) {...\r\n  if(is.null(simulations) & is.null(design)) stop(\"Must specify either a design or a simulations data frame\")\r\n  if(is.null(simulations)) simulations <- run_design(design, sims)\r\n  ....\r\n  } \r\n```\r\n \r\n"}}
{"actor":{"display_login":"graemeblair"}}