{"action":"created","comment":{"url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/comments/200580730","pull_request_review_id":134924479,"id":200580730,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU4MDczMA==","diff_hunk":"@@ -29,6 +35,10 @@ function makeCallback(options) {\n     if (error) {\n       reject(error);\n       return;\n+    } else if (stats && stats.hasErrors() && !watch) {\n+      process.exitCode = getErrorCount(stats);","path":"lib/compiler.js","position":18,"original_position":18,"commit_id":"fed3dbe299efafe6a3c8ac5c2f048c18a77b9b6d","original_commit_id":"fed3dbe299efafe6a3c8ac5c2f048c18a77b9b6d","user":{"login":"MrMamen","id":5688606,"node_id":"MDQ6VXNlcjU2ODg2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/5688606?v=4","gravatar_id":"","url":"https://api.github.com/users/MrMamen","html_url":"https://github.com/MrMamen","followers_url":"https://api.github.com/users/MrMamen/followers","following_url":"https://api.github.com/users/MrMamen/following{/other_user}","gists_url":"https://api.github.com/users/MrMamen/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMamen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMamen/subscriptions","organizations_url":"https://api.github.com/users/MrMamen/orgs","repos_url":"https://api.github.com/users/MrMamen/repos","events_url":"https://api.github.com/users/MrMamen/events{/privacy}","received_events_url":"https://api.github.com/users/MrMamen/received_events","type":"User","site_admin":false},"body":"https://people.cs.pitt.edu/~alanjawi/cs449/code/shell/UnixSignals.htm","created_at":"2018-07-06T08:16:33Z","updated_at":"2018-07-06T08:16:33Z","html_url":"https://github.com/webpack-contrib/webpack-command/pull/44#discussion_r200580730","pull_request_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/comments/200580730"},"html":{"href":"https://github.com/webpack-contrib/webpack-command/pull/44#discussion_r200580730"},"pull_request":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44"}},"in_reply_to_id":200564239},"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44","id":199540647,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTQwNjQ3","html_url":"https://github.com/webpack-contrib/webpack-command/pull/44","diff_url":"https://github.com/webpack-contrib/webpack-command/pull/44.diff","patch_url":"https://github.com/webpack-contrib/webpack-command/pull/44.patch","issue_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/44","number":44,"state":"open","locked":false,"title":"fix: exitCodes, reporters and bail, better error logging","user":{"login":"shellscape","id":76371,"node_id":"MDQ6VXNlcjc2Mzcx","avatar_url":"https://avatars1.githubusercontent.com/u/76371?v=4","gravatar_id":"","url":"https://api.github.com/users/shellscape","html_url":"https://github.com/shellscape","followers_url":"https://api.github.com/users/shellscape/followers","following_url":"https://api.github.com/users/shellscape/following{/other_user}","gists_url":"https://api.github.com/users/shellscape/gists{/gist_id}","starred_url":"https://api.github.com/users/shellscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellscape/subscriptions","organizations_url":"https://api.github.com/users/shellscape/orgs","repos_url":"https://api.github.com/users/shellscape/repos","events_url":"https://api.github.com/users/shellscape/events{/privacy}","received_events_url":"https://api.github.com/users/shellscape/received_events","type":"User","site_admin":false},"body":"<!--\r\n  HOLY CRAP a Pull Request. We ❤️ those!\r\n\r\n  If you remove or skip this template, you'll make the 🐼 sad and the mighty god\r\n  of Github will appear and pile-drive the close button from a great height\r\n  while making animal noises.\r\n\r\n  Please place an x (no spaces!) in all [ ] that apply\r\n-->\r\n\r\nThis PR contains a:\r\n\r\n- [x] **bugfix**\r\n- [ ] new **feature**\r\n- [ ] **code refactor**\r\n- [x] **test update** <!-- if bug or feature is checked, this should be too -->\r\n- [ ] **typo fix**\r\n- [ ] **metadata update**\r\n\r\n### Motivation / Use-Case\r\n\r\nIt's been reported that #35 didn't do enough to address exit codes in the event of a build failure or error. During discovery, it was also found that the `--bail` flag will cause errors in the reporters as well, as they were not anticipating `stats` being `undefined` in the event that `--bail` was used. \r\n\r\nAdditionally, the logic for how an error is displayed when one occurs at the program level (outside of reporters) has been improved greatly and gives users more options to display additional info.\r\n\r\n### Breaking Changes\r\n\r\nNone\r\n\r\n### Additional Info\r\n\r\n/cc @ankurk91 @MrMamen","created_at":"2018-07-05T17:37:30Z","updated_at":"2018-07-06T08:16:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19e59a8b2899e0752f4fded592dd5f536c58357d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"evilebottnawi","id":4567934,"node_id":"MDQ6VXNlcjQ1Njc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/44/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-command/statuses/fed3dbe299efafe6a3c8ac5c2f048c18a77b9b6d","head":{"label":"webpack-contrib:fix/exitcode-bail-log","ref":"fix/exitcode-bail-log","sha":"fed3dbe299efafe6a3c8ac5c2f048c18a77b9b6d","user":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":122840320,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI4NDAzMjA=","name":"webpack-command","full_name":"webpack-contrib/webpack-command","owner":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/webpack-command","description":"Lightweight, modular, and opinionated webpack CLI that provides a superior experience","fork":false,"url":"https://api.github.com/repos/webpack-contrib/webpack-command","forks_url":"https://api.github.com/repos/webpack-contrib/webpack-command/forks","keys_url":"https://api.github.com/repos/webpack-contrib/webpack-command/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/webpack-command/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/webpack-command/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/webpack-command/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/webpack-command/events","assignees_url":"https://api.github.com/repos/webpack-contrib/webpack-command/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/webpack-command/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/webpack-command/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-command/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/webpack-command/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/webpack-command/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/webpack-command/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/webpack-command/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/webpack-command/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/webpack-command/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/webpack-command/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/webpack-command/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/webpack-command/merges","archive_url":"https://api.github.com/repos/webpack-contrib/webpack-command/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/webpack-command/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/webpack-command/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/webpack-command/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/webpack-command/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/webpack-command/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/deployments","created_at":"2018-02-25T13:50:50Z","updated_at":"2018-07-06T03:10:39Z","pushed_at":"2018-07-05T21:09:55Z","git_url":"git://github.com/webpack-contrib/webpack-command.git","ssh_url":"git@github.com:webpack-contrib/webpack-command.git","clone_url":"https://github.com/webpack-contrib/webpack-command.git","svn_url":"https://github.com/webpack-contrib/webpack-command","homepage":"","size":875,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":3,"watchers":167,"default_branch":"master"}},"base":{"label":"webpack-contrib:master","ref":"master","sha":"fcfca27f4be912ed15f1477a37ba52bd222e2613","user":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":122840320,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI4NDAzMjA=","name":"webpack-command","full_name":"webpack-contrib/webpack-command","owner":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/webpack-command","description":"Lightweight, modular, and opinionated webpack CLI that provides a superior experience","fork":false,"url":"https://api.github.com/repos/webpack-contrib/webpack-command","forks_url":"https://api.github.com/repos/webpack-contrib/webpack-command/forks","keys_url":"https://api.github.com/repos/webpack-contrib/webpack-command/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/webpack-command/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/webpack-command/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/webpack-command/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/webpack-command/events","assignees_url":"https://api.github.com/repos/webpack-contrib/webpack-command/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/webpack-command/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/webpack-command/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-command/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/webpack-command/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/webpack-command/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/webpack-command/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/webpack-command/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/webpack-command/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/webpack-command/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/webpack-command/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/webpack-command/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/webpack-command/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/webpack-command/merges","archive_url":"https://api.github.com/repos/webpack-contrib/webpack-command/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/webpack-command/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/webpack-command/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/webpack-command/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/webpack-command/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/webpack-command/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/webpack-command/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/webpack-command/deployments","created_at":"2018-02-25T13:50:50Z","updated_at":"2018-07-06T03:10:39Z","pushed_at":"2018-07-05T21:09:55Z","git_url":"git://github.com/webpack-contrib/webpack-command.git","ssh_url":"git@github.com:webpack-contrib/webpack-command.git","clone_url":"https://github.com/webpack-contrib/webpack-command.git","svn_url":"https://github.com/webpack-contrib/webpack-command","homepage":"","size":875,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":3,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44"},"html":{"href":"https://github.com/webpack-contrib/webpack-command/pull/44"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/44"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/webpack-command/statuses/fed3dbe299efafe6a3c8ac5c2f048c18a77b9b6d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MrMamen"}}