{"action":"closed","number":4948,"pull_request":{"url":"https://api.github.com/repos/netdata/netdata/pulls/4948","id":237015134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDE1MTM0","html_url":"https://github.com/netdata/netdata/pull/4948","diff_url":"https://github.com/netdata/netdata/pull/4948.diff","patch_url":"https://github.com/netdata/netdata/pull/4948.patch","issue_url":"https://api.github.com/repos/netdata/netdata/issues/4948","number":4948,"state":"closed","locked":false,"title":"Fix link in streaming hosts list","user":{"login":"adherzog","id":1744181,"node_id":"MDQ6VXNlcjE3NDQxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1744181?v=4","gravatar_id":"","url":"https://api.github.com/users/adherzog","html_url":"https://github.com/adherzog","followers_url":"https://api.github.com/users/adherzog/followers","following_url":"https://api.github.com/users/adherzog/following{/other_user}","gists_url":"https://api.github.com/users/adherzog/gists{/gist_id}","starred_url":"https://api.github.com/users/adherzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adherzog/subscriptions","organizations_url":"https://api.github.com/users/adherzog/orgs","repos_url":"https://api.github.com/users/adherzog/repos","events_url":"https://api.github.com/users/adherzog/events{/privacy}","received_events_url":"https://api.github.com/users/adherzog/received_events","type":"User","site_admin":false},"body":"<!--\r\nDescribe the change in summary section, including rationale and degin decisions.\r\nInclude \"Fixes #nnn\" if you are fixing an existing issue.\r\n\r\nIn \"Component Name\" section write which component is changed in this PR. This\r\nwill help us review your PR quicker.\r\n\r\nIf you have more information you want to add, write them in \"Additional\r\nInformation\" section. This is usually used to help others understand your\r\nmotivation behind this change. A step-by-step reproduction of the problem is\r\nhelpful if there is no related issue.\r\n-->\r\n\r\n##### Summary\r\n\r\nIn the 'my-netdata' menu, under the list of streamed hosts, the URL for the 'master' host is incorrect. This fixes the URL so that the link works as intended.\r\n\r\n##### Component Name\r\n\r\nweb\r\n\r\n##### Additional Information\r\n\r\nThis looks like it was just incorrectly interpolating vars when building URL. The diff here is straightforward enough that I don't think it warrants much more explanation.\r\n\r\nThe list of streamed hosts only appears on hosts that receive streaming data.\r\n\r\nI believe this bug was introduced as part of #4590.","created_at":"2018-12-07T22:49:41Z","updated_at":"2018-12-11T08:21:15Z","closed_at":"2018-12-11T08:21:15Z","merged_at":"2018-12-11T08:21:15Z","merge_commit_sha":"f16827d145d87e9273fe6312860b97ed8b70698a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cakrit","id":43294513,"node_id":"MDQ6VXNlcjQzMjk0NTEz","avatar_url":"https://avatars0.githubusercontent.com/u/43294513?v=4","gravatar_id":"","url":"https://api.github.com/users/cakrit","html_url":"https://github.com/cakrit","followers_url":"https://api.github.com/users/cakrit/followers","following_url":"https://api.github.com/users/cakrit/following{/other_user}","gists_url":"https://api.github.com/users/cakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/cakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakrit/subscriptions","organizations_url":"https://api.github.com/users/cakrit/orgs","repos_url":"https://api.github.com/users/cakrit/repos","events_url":"https://api.github.com/users/cakrit/events{/privacy}","received_events_url":"https://api.github.com/users/cakrit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":351419251,"node_id":"MDU6TGFiZWwzNTE0MTkyNTE=","url":"https://api.github.com/repos/netdata/netdata/labels/area/docs","name":"area/docs","color":"0f34c6","default":false},{"id":1065924531,"node_id":"MDU6TGFiZWwxMDY1OTI0NTMx","url":"https://api.github.com/repos/netdata/netdata/labels/area/web","name":"area/web","color":"0f34c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/netdata/netdata/pulls/4948/commits","review_comments_url":"https://api.github.com/repos/netdata/netdata/pulls/4948/comments","review_comment_url":"https://api.github.com/repos/netdata/netdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netdata/netdata/issues/4948/comments","statuses_url":"https://api.github.com/repos/netdata/netdata/statuses/559135d848c3304555322ae45db020307bb9f83e","head":{"label":"adherzog:fix-link-in-streaming-hosts-list","ref":"fix-link-in-streaming-hosts-list","sha":"559135d848c3304555322ae45db020307bb9f83e","user":{"login":"adherzog","id":1744181,"node_id":"MDQ6VXNlcjE3NDQxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1744181?v=4","gravatar_id":"","url":"https://api.github.com/users/adherzog","html_url":"https://github.com/adherzog","followers_url":"https://api.github.com/users/adherzog/followers","following_url":"https://api.github.com/users/adherzog/following{/other_user}","gists_url":"https://api.github.com/users/adherzog/gists{/gist_id}","starred_url":"https://api.github.com/users/adherzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adherzog/subscriptions","organizations_url":"https://api.github.com/users/adherzog/orgs","repos_url":"https://api.github.com/users/adherzog/repos","events_url":"https://api.github.com/users/adherzog/events{/privacy}","received_events_url":"https://api.github.com/users/adherzog/received_events","type":"User","site_admin":false},"repo":{"id":160882299,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4ODIyOTk=","name":"netdata","full_name":"adherzog/netdata","private":false,"owner":{"login":"adherzog","id":1744181,"node_id":"MDQ6VXNlcjE3NDQxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1744181?v=4","gravatar_id":"","url":"https://api.github.com/users/adherzog","html_url":"https://github.com/adherzog","followers_url":"https://api.github.com/users/adherzog/followers","following_url":"https://api.github.com/users/adherzog/following{/other_user}","gists_url":"https://api.github.com/users/adherzog/gists{/gist_id}","starred_url":"https://api.github.com/users/adherzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adherzog/subscriptions","organizations_url":"https://api.github.com/users/adherzog/orgs","repos_url":"https://api.github.com/users/adherzog/repos","events_url":"https://api.github.com/users/adherzog/events{/privacy}","received_events_url":"https://api.github.com/users/adherzog/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adherzog/netdata","description":"Real-time performance monitoring, done right! https://my-netdata.io/","fork":true,"url":"https://api.github.com/repos/adherzog/netdata","forks_url":"https://api.github.com/repos/adherzog/netdata/forks","keys_url":"https://api.github.com/repos/adherzog/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adherzog/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adherzog/netdata/teams","hooks_url":"https://api.github.com/repos/adherzog/netdata/hooks","issue_events_url":"https://api.github.com/repos/adherzog/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/adherzog/netdata/events","assignees_url":"https://api.github.com/repos/adherzog/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/adherzog/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/adherzog/netdata/tags","blobs_url":"https://api.github.com/repos/adherzog/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adherzog/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adherzog/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/adherzog/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adherzog/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/adherzog/netdata/languages","stargazers_url":"https://api.github.com/repos/adherzog/netdata/stargazers","contributors_url":"https://api.github.com/repos/adherzog/netdata/contributors","subscribers_url":"https://api.github.com/repos/adherzog/netdata/subscribers","subscription_url":"https://api.github.com/repos/adherzog/netdata/subscription","commits_url":"https://api.github.com/repos/adherzog/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/adherzog/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/adherzog/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/adherzog/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/adherzog/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/adherzog/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adherzog/netdata/merges","archive_url":"https://api.github.com/repos/adherzog/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adherzog/netdata/downloads","issues_url":"https://api.github.com/repos/adherzog/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/adherzog/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/adherzog/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/adherzog/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adherzog/netdata/labels{/name}","releases_url":"https://api.github.com/repos/adherzog/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/adherzog/netdata/deployments","created_at":"2018-12-07T22:35:18Z","updated_at":"2018-12-07T22:35:23Z","pushed_at":"2018-12-07T22:39:47Z","git_url":"git://github.com/adherzog/netdata.git","ssh_url":"git@github.com:adherzog/netdata.git","clone_url":"https://github.com/adherzog/netdata.git","svn_url":"https://github.com/adherzog/netdata","homepage":"","size":28084,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netdata:master","ref":"master","sha":"4648cf4707a3b59f674e179cc1fed1426c847399","user":{"login":"netdata","id":43390781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzkwNzgx","avatar_url":"https://avatars1.githubusercontent.com/u/43390781?v=4","gravatar_id":"","url":"https://api.github.com/users/netdata","html_url":"https://github.com/netdata","followers_url":"https://api.github.com/users/netdata/followers","following_url":"https://api.github.com/users/netdata/following{/other_user}","gists_url":"https://api.github.com/users/netdata/gists{/gist_id}","starred_url":"https://api.github.com/users/netdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netdata/subscriptions","organizations_url":"https://api.github.com/users/netdata/orgs","repos_url":"https://api.github.com/users/netdata/repos","events_url":"https://api.github.com/users/netdata/events{/privacy}","received_events_url":"https://api.github.com/users/netdata/received_events","type":"Organization","site_admin":false},"repo":{"id":10744183,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0NDE4Mw==","name":"netdata","full_name":"netdata/netdata","private":false,"owner":{"login":"netdata","id":43390781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzkwNzgx","avatar_url":"https://avatars1.githubusercontent.com/u/43390781?v=4","gravatar_id":"","url":"https://api.github.com/users/netdata","html_url":"https://github.com/netdata","followers_url":"https://api.github.com/users/netdata/followers","following_url":"https://api.github.com/users/netdata/following{/other_user}","gists_url":"https://api.github.com/users/netdata/gists{/gist_id}","starred_url":"https://api.github.com/users/netdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netdata/subscriptions","organizations_url":"https://api.github.com/users/netdata/orgs","repos_url":"https://api.github.com/users/netdata/repos","events_url":"https://api.github.com/users/netdata/events{/privacy}","received_events_url":"https://api.github.com/users/netdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/netdata/netdata","description":"Real-time performance monitoring, done right! https://my-netdata.io/","fork":false,"url":"https://api.github.com/repos/netdata/netdata","forks_url":"https://api.github.com/repos/netdata/netdata/forks","keys_url":"https://api.github.com/repos/netdata/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netdata/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netdata/netdata/teams","hooks_url":"https://api.github.com/repos/netdata/netdata/hooks","issue_events_url":"https://api.github.com/repos/netdata/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/netdata/netdata/events","assignees_url":"https://api.github.com/repos/netdata/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/netdata/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/netdata/netdata/tags","blobs_url":"https://api.github.com/repos/netdata/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netdata/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netdata/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/netdata/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netdata/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/netdata/netdata/languages","stargazers_url":"https://api.github.com/repos/netdata/netdata/stargazers","contributors_url":"https://api.github.com/repos/netdata/netdata/contributors","subscribers_url":"https://api.github.com/repos/netdata/netdata/subscribers","subscription_url":"https://api.github.com/repos/netdata/netdata/subscription","commits_url":"https://api.github.com/repos/netdata/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/netdata/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/netdata/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/netdata/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/netdata/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/netdata/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netdata/netdata/merges","archive_url":"https://api.github.com/repos/netdata/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netdata/netdata/downloads","issues_url":"https://api.github.com/repos/netdata/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/netdata/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/netdata/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/netdata/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netdata/netdata/labels{/name}","releases_url":"https://api.github.com/repos/netdata/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/netdata/netdata/deployments","created_at":"2013-06-17T18:39:10Z","updated_at":"2018-12-11T08:04:04Z","pushed_at":"2018-12-11T08:21:15Z","git_url":"git://github.com/netdata/netdata.git","ssh_url":"git@github.com:netdata/netdata.git","clone_url":"https://github.com/netdata/netdata.git","svn_url":"https://github.com/netdata/netdata","homepage":"","size":27905,"stargazers_count":33645,"watchers_count":33645,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2901,"mirror_url":null,"archived":false,"open_issues_count":483,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2901,"open_issues":483,"watchers":33645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netdata/netdata/pulls/4948"},"html":{"href":"https://github.com/netdata/netdata/pull/4948"},"issue":{"href":"https://api.github.com/repos/netdata/netdata/issues/4948"},"comments":{"href":"https://api.github.com/repos/netdata/netdata/issues/4948/comments"},"review_comments":{"href":"https://api.github.com/repos/netdata/netdata/pulls/4948/comments"},"review_comment":{"href":"https://api.github.com/repos/netdata/netdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netdata/netdata/pulls/4948/commits"},"statuses":{"href":"https://api.github.com/repos/netdata/netdata/statuses/559135d848c3304555322ae45db020307bb9f83e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gmosx","id":37342,"node_id":"MDQ6VXNlcjM3MzQy","avatar_url":"https://avatars1.githubusercontent.com/u/37342?v=4","gravatar_id":"","url":"https://api.github.com/users/gmosx","html_url":"https://github.com/gmosx","followers_url":"https://api.github.com/users/gmosx/followers","following_url":"https://api.github.com/users/gmosx/following{/other_user}","gists_url":"https://api.github.com/users/gmosx/gists{/gist_id}","starred_url":"https://api.github.com/users/gmosx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmosx/subscriptions","organizations_url":"https://api.github.com/users/gmosx/orgs","repos_url":"https://api.github.com/users/gmosx/repos","events_url":"https://api.github.com/users/gmosx/events{/privacy}","received_events_url":"https://api.github.com/users/gmosx/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"gmosx"}}