{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/web-ext/issues/1310","repository_url":"https://api.github.com/repos/mozilla/web-ext","labels_url":"https://api.github.com/repos/mozilla/web-ext/issues/1310/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/web-ext/issues/1310/comments","events_url":"https://api.github.com/repos/mozilla/web-ext/issues/1310/events","html_url":"https://github.com/mozilla/web-ext/pull/1310","id":318823080,"number":1310,"title":"fix(test): Fixed remaining issues for run test successfully on node >= 8","user":{"login":"rpl","id":11484,"avatar_url":"https://avatars1.githubusercontent.com/u/11484?v=4","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-30T08:54:33Z","updated_at":"2018-04-30T15:14:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla/web-ext/pulls/1310","html_url":"https://github.com/mozilla/web-ext/pull/1310","diff_url":"https://github.com/mozilla/web-ext/pull/1310.diff","patch_url":"https://github.com/mozilla/web-ext/pull/1310.patch"},"body":"This PR contains some additional changes to the test units needed to successfully run all the tests on node >= 8 (and fix the remaining issues from #1129).\r\n\r\nIn particular it fixes the ` RangeError [ERR_INVALID_FD]: \"fd\" must be a positive integer: undefined` errors due to the ReadStream/WriteStream instances created in tests (e.g. to mock the stdin stream).\r\n\r\nOn this fixes we currently need to suppress some flow type errors (due to the nodejs type definitions already defined in flow not yet including this changes between node6 and node8).\r\n\r\nOnce ReadStream/WriteStream type definitions are updated in flow itself, flow is going to complain that these suppress comments are not suppressing any actual error and we will know that we can remove the suppress comments from there."},"comment":{"url":"https://api.github.com/repos/mozilla/web-ext/issues/comments/385429650","html_url":"https://github.com/mozilla/web-ext/pull/1310#issuecomment-385429650","issue_url":"https://api.github.com/repos/mozilla/web-ext/issues/1310","id":385429650,"user":{"login":"Rob--W","id":1365071,"avatar_url":"https://avatars2.githubusercontent.com/u/1365071?v=4","gravatar_id":"","url":"https://api.github.com/users/Rob--W","html_url":"https://github.com/Rob--W","followers_url":"https://api.github.com/users/Rob--W/followers","following_url":"https://api.github.com/users/Rob--W/following{/other_user}","gists_url":"https://api.github.com/users/Rob--W/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob--W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob--W/subscriptions","organizations_url":"https://api.github.com/users/Rob--W/orgs","repos_url":"https://api.github.com/users/Rob--W/repos","events_url":"https://api.github.com/users/Rob--W/events{/privacy}","received_events_url":"https://api.github.com/users/Rob--W/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T15:14:02Z","updated_at":"2018-04-30T15:14:02Z","author_association":"MEMBER","body":"@rpl Reprodued in a Windows 7 VM. Investigating."}}
{"actor":{"display_login":"Rob--W"}}