{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/comments/188933813","pull_request_review_id":121010425,"id":188933813,"diff_hunk":"@@ -93,7 +99,7 @@ type binaryPropagator struct {\n \tbuffers sync.Pool\n }\n \n-func newBinaryPropagator(tracer *Tracer) *binaryPropagator {\n+func NewBinaryPropagator(tracer *Tracer) *binaryPropagator {","path":"propagation.go","position":36,"original_position":36,"commit_id":"243aee7dc28b1c7cdbd998dd4633184d8d55b1f4","original_commit_id":"243aee7dc28b1c7cdbd998dd4633184d8d55b1f4","user":{"login":"golangci","id":35628013,"avatar_url":"https://avatars3.githubusercontent.com/u/35628013?v=4","gravatar_id":"","url":"https://api.github.com/users/golangci","html_url":"https://github.com/golangci","followers_url":"https://api.github.com/users/golangci/followers","following_url":"https://api.github.com/users/golangci/following{/other_user}","gists_url":"https://api.github.com/users/golangci/gists{/gist_id}","starred_url":"https://api.github.com/users/golangci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangci/subscriptions","organizations_url":"https://api.github.com/users/golangci/orgs","repos_url":"https://api.github.com/users/golangci/repos","events_url":"https://api.github.com/users/golangci/events{/privacy}","received_events_url":"https://api.github.com/users/golangci/received_events","type":"User","site_admin":false},"body":"exported func NewBinaryPropagator returns unexported type *jaeger.binaryPropagator, which can be annoying to use","created_at":"2018-05-17T12:07:49Z","updated_at":"2018-05-17T12:07:49Z","html_url":"https://github.com/jaegertracing/jaeger-client-go/pull/312#discussion_r188933813","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/comments/188933813"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-go/pull/312#discussion_r188933813"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312","id":188715165,"html_url":"https://github.com/jaegertracing/jaeger-client-go/pull/312","diff_url":"https://github.com/jaegertracing/jaeger-client-go/pull/312.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-go/pull/312.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/312","number":312,"state":"open","locked":false,"title":"WIP: Create composite propagator (#311)","user":{"login":"HugoMFernandes","id":6650985,"avatar_url":"https://avatars2.githubusercontent.com/u/6650985?v=4","gravatar_id":"","url":"https://api.github.com/users/HugoMFernandes","html_url":"https://github.com/HugoMFernandes","followers_url":"https://api.github.com/users/HugoMFernandes/followers","following_url":"https://api.github.com/users/HugoMFernandes/following{/other_user}","gists_url":"https://api.github.com/users/HugoMFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoMFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoMFernandes/subscriptions","organizations_url":"https://api.github.com/users/HugoMFernandes/orgs","repos_url":"https://api.github.com/users/HugoMFernandes/repos","events_url":"https://api.github.com/users/HugoMFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/HugoMFernandes/received_events","type":"User","site_admin":false},"body":"Exposed textMapPropagator and all its constructors.\r\n\r\nExposed getDefaultHeadersConfig to ease the creation of new\r\ntextMapPropagators.\r\n\r\nUnified textMapPropagator and zipkinB3HTTPHeaderPropagator through a\r\ncommon interface.\r\n\r\nCreate a new compositePropagator adhering to the new interface.\r\n\r\nSigned-off-by: Hugo Fernandes <hugof225@gmail.com>\r\n","created_at":"2018-05-17T12:07:28Z","updated_at":"2018-05-17T12:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32afe592611a831370a7cb764296970b00942d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/312/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/statuses/243aee7dc28b1c7cdbd998dd4633184d8d55b1f4","head":{"label":"HugoMFernandes:master","ref":"master","sha":"243aee7dc28b1c7cdbd998dd4633184d8d55b1f4","user":{"login":"HugoMFernandes","id":6650985,"avatar_url":"https://avatars2.githubusercontent.com/u/6650985?v=4","gravatar_id":"","url":"https://api.github.com/users/HugoMFernandes","html_url":"https://github.com/HugoMFernandes","followers_url":"https://api.github.com/users/HugoMFernandes/followers","following_url":"https://api.github.com/users/HugoMFernandes/following{/other_user}","gists_url":"https://api.github.com/users/HugoMFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoMFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoMFernandes/subscriptions","organizations_url":"https://api.github.com/users/HugoMFernandes/orgs","repos_url":"https://api.github.com/users/HugoMFernandes/repos","events_url":"https://api.github.com/users/HugoMFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/HugoMFernandes/received_events","type":"User","site_admin":false},"repo":{"id":133680946,"name":"jaeger-client-go","full_name":"HugoMFernandes/jaeger-client-go","owner":{"login":"HugoMFernandes","id":6650985,"avatar_url":"https://avatars2.githubusercontent.com/u/6650985?v=4","gravatar_id":"","url":"https://api.github.com/users/HugoMFernandes","html_url":"https://github.com/HugoMFernandes","followers_url":"https://api.github.com/users/HugoMFernandes/followers","following_url":"https://api.github.com/users/HugoMFernandes/following{/other_user}","gists_url":"https://api.github.com/users/HugoMFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoMFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoMFernandes/subscriptions","organizations_url":"https://api.github.com/users/HugoMFernandes/orgs","repos_url":"https://api.github.com/users/HugoMFernandes/repos","events_url":"https://api.github.com/users/HugoMFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/HugoMFernandes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HugoMFernandes/jaeger-client-go","description":"Jaeger Bindings for Go OpenTracing API.","fork":true,"url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go","forks_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/forks","keys_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/teams","hooks_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/hooks","issue_events_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/issues/events{/number}","events_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/events","assignees_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/assignees{/user}","branches_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/branches{/branch}","tags_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/tags","blobs_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/statuses/{sha}","languages_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/languages","stargazers_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/stargazers","contributors_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/contributors","subscribers_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/subscribers","subscription_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/subscription","commits_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/contents/{+path}","compare_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/merges","archive_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/downloads","issues_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/issues{/number}","pulls_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/pulls{/number}","milestones_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/milestones{/number}","notifications_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/labels{/name}","releases_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/releases{/id}","deployments_url":"https://api.github.com/repos/HugoMFernandes/jaeger-client-go/deployments","created_at":"2018-05-16T14:47:51Z","updated_at":"2018-05-17T12:04:12Z","pushed_at":"2018-05-17T12:04:10Z","git_url":"git://github.com/HugoMFernandes/jaeger-client-go.git","ssh_url":"git@github.com:HugoMFernandes/jaeger-client-go.git","clone_url":"https://github.com/HugoMFernandes/jaeger-client-go.git","svn_url":"https://github.com/HugoMFernandes/jaeger-client-go","homepage":"https://jaegertracing.io/","size":926,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"55be93cfcfabf92430cc142ddb6e896ea2402f2c","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56550961,"name":"jaeger-client-go","full_name":"jaegertracing/jaeger-client-go","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-go","description":"Jaeger Bindings for Go OpenTracing API.","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-go","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-go/deployments","created_at":"2016-04-19T00:09:28Z","updated_at":"2018-05-17T11:51:37Z","pushed_at":"2018-05-17T12:07:29Z","git_url":"git://github.com/jaegertracing/jaeger-client-go.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-go.git","clone_url":"https://github.com/jaegertracing/jaeger-client-go.git","svn_url":"https://github.com/jaegertracing/jaeger-client-go","homepage":"https://jaegertracing.io/","size":926,"stargazers_count":246,"watchers_count":246,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":96,"open_issues":39,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-go/pull/312"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/312"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-go/statuses/243aee7dc28b1c7cdbd998dd4633184d8d55b1f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"golangci"}}