{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5380","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5380/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5380/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5380/events","html_url":"https://github.com/MetaMask/metamask-extension/pull/5380","id":364507146,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Njc2MjA5","number":5380,"title":"Allow sending transactions with hex data and no recipient","user":{"login":"whymarrh","id":1623628,"node_id":"MDQ6VXNlcjE2MjM2Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1623628?v=4","gravatar_id":"","url":"https://api.github.com/users/whymarrh","html_url":"https://github.com/whymarrh","followers_url":"https://api.github.com/users/whymarrh/followers","following_url":"https://api.github.com/users/whymarrh/following{/other_user}","gists_url":"https://api.github.com/users/whymarrh/gists{/gist_id}","starred_url":"https://api.github.com/users/whymarrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whymarrh/subscriptions","organizations_url":"https://api.github.com/users/whymarrh/orgs","repos_url":"https://api.github.com/users/whymarrh/repos","events_url":"https://api.github.com/users/whymarrh/events{/privacy}","received_events_url":"https://api.github.com/users/whymarrh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-27T14:33:57Z","updated_at":"2018-09-28T19:20:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/5380","html_url":"https://github.com/MetaMask/metamask-extension/pull/5380","diff_url":"https://github.com/MetaMask/metamask-extension/pull/5380.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/5380.patch"},"body":"Fixes #5195"},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/425539882","html_url":"https://github.com/MetaMask/metamask-extension/pull/5380#issuecomment-425539882","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5380","id":425539882,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTUzOTg4Mg==","user":{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T19:20:48Z","updated_at":"2018-09-28T19:20:48Z","author_association":"CONTRIBUTOR","body":"Found during QA: if you set the recipient, then the hex data, then unset the recipient, you can't click \"Next\"\r\n\r\n![hexrecipientqa](https://user-images.githubusercontent.com/7499938/46228871-1014fe00-c33e-11e8-8c1a-75da66e5f284.gif)\r\n\r\nHas to do with the `inError` in the `formShouldBeDisabled` method in `send-footer.component.js`. Shouldn't get to the error state if the hex data is set.\r\n\r\nThat this bug was possible within this PR suggests to me that something in the codebase (as it was before this PR) needs to be improved: either the way we handle errors or tests or something. It should have been easier for you as a developer to discover this..."}}
{"actor":{"display_login":"danjm"}}