{"action":"closed","number":34595,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/34595","id":235271601,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjcxNjAx","html_url":"https://github.com/rails/rails/pull/34595","diff_url":"https://github.com/rails/rails/pull/34595.diff","patch_url":"https://github.com/rails/rails/pull/34595.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/34595","number":34595,"state":"closed","locked":false,"title":"Remove unnecessary variable route","user":{"login":"albertoalmagro","id":671550,"node_id":"MDQ6VXNlcjY3MTU1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/671550?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoalmagro","html_url":"https://github.com/albertoalmagro","followers_url":"https://api.github.com/users/albertoalmagro/followers","following_url":"https://api.github.com/users/albertoalmagro/following{/other_user}","gists_url":"https://api.github.com/users/albertoalmagro/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoalmagro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoalmagro/subscriptions","organizations_url":"https://api.github.com/users/albertoalmagro/orgs","repos_url":"https://api.github.com/users/albertoalmagro/repos","events_url":"https://api.github.com/users/albertoalmagro/events{/privacy}","received_events_url":"https://api.github.com/users/albertoalmagro/received_events","type":"User","site_admin":false},"body":"### Summary\r\nThe variable `route` was only allocated to hold an object that was immediately returned. This patch removes that variable.","created_at":"2018-12-02T17:12:22Z","updated_at":"2018-12-02T20:01:29Z","closed_at":"2018-12-02T20:01:28Z","merged_at":"2018-12-02T20:01:28Z","merge_commit_sha":"01d38996952f6ed689ada9ae611d1fc325db3c37","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":107189,"node_id":"MDU6TGFiZWwxMDcxODk=","url":"https://api.github.com/repos/rails/rails/labels/actionpack","name":"actionpack","color":"FFF700","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/34595/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/34595/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/34595/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/c93bad207087ab656b27c559012b5e8eb31ed20d","head":{"label":"albertoalmagro:remove-unnecessary-variable","ref":"remove-unnecessary-variable","sha":"c93bad207087ab656b27c559012b5e8eb31ed20d","user":{"login":"albertoalmagro","id":671550,"node_id":"MDQ6VXNlcjY3MTU1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/671550?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoalmagro","html_url":"https://github.com/albertoalmagro","followers_url":"https://api.github.com/users/albertoalmagro/followers","following_url":"https://api.github.com/users/albertoalmagro/following{/other_user}","gists_url":"https://api.github.com/users/albertoalmagro/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoalmagro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoalmagro/subscriptions","organizations_url":"https://api.github.com/users/albertoalmagro/orgs","repos_url":"https://api.github.com/users/albertoalmagro/repos","events_url":"https://api.github.com/users/albertoalmagro/events{/privacy}","received_events_url":"https://api.github.com/users/albertoalmagro/received_events","type":"User","site_admin":false},"repo":{"id":98908304,"node_id":"MDEwOlJlcG9zaXRvcnk5ODkwODMwNA==","name":"rails","full_name":"albertoalmagro/rails","private":false,"owner":{"login":"albertoalmagro","id":671550,"node_id":"MDQ6VXNlcjY3MTU1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/671550?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoalmagro","html_url":"https://github.com/albertoalmagro","followers_url":"https://api.github.com/users/albertoalmagro/followers","following_url":"https://api.github.com/users/albertoalmagro/following{/other_user}","gists_url":"https://api.github.com/users/albertoalmagro/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoalmagro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoalmagro/subscriptions","organizations_url":"https://api.github.com/users/albertoalmagro/orgs","repos_url":"https://api.github.com/users/albertoalmagro/repos","events_url":"https://api.github.com/users/albertoalmagro/events{/privacy}","received_events_url":"https://api.github.com/users/albertoalmagro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/albertoalmagro/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/albertoalmagro/rails","forks_url":"https://api.github.com/repos/albertoalmagro/rails/forks","keys_url":"https://api.github.com/repos/albertoalmagro/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertoalmagro/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertoalmagro/rails/teams","hooks_url":"https://api.github.com/repos/albertoalmagro/rails/hooks","issue_events_url":"https://api.github.com/repos/albertoalmagro/rails/issues/events{/number}","events_url":"https://api.github.com/repos/albertoalmagro/rails/events","assignees_url":"https://api.github.com/repos/albertoalmagro/rails/assignees{/user}","branches_url":"https://api.github.com/repos/albertoalmagro/rails/branches{/branch}","tags_url":"https://api.github.com/repos/albertoalmagro/rails/tags","blobs_url":"https://api.github.com/repos/albertoalmagro/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertoalmagro/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertoalmagro/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertoalmagro/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertoalmagro/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/albertoalmagro/rails/languages","stargazers_url":"https://api.github.com/repos/albertoalmagro/rails/stargazers","contributors_url":"https://api.github.com/repos/albertoalmagro/rails/contributors","subscribers_url":"https://api.github.com/repos/albertoalmagro/rails/subscribers","subscription_url":"https://api.github.com/repos/albertoalmagro/rails/subscription","commits_url":"https://api.github.com/repos/albertoalmagro/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertoalmagro/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertoalmagro/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertoalmagro/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertoalmagro/rails/contents/{+path}","compare_url":"https://api.github.com/repos/albertoalmagro/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertoalmagro/rails/merges","archive_url":"https://api.github.com/repos/albertoalmagro/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertoalmagro/rails/downloads","issues_url":"https://api.github.com/repos/albertoalmagro/rails/issues{/number}","pulls_url":"https://api.github.com/repos/albertoalmagro/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/albertoalmagro/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/albertoalmagro/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertoalmagro/rails/labels{/name}","releases_url":"https://api.github.com/repos/albertoalmagro/rails/releases{/id}","deployments_url":"https://api.github.com/repos/albertoalmagro/rails/deployments","created_at":"2017-07-31T16:15:42Z","updated_at":"2018-11-27T17:57:52Z","pushed_at":"2018-12-02T17:11:38Z","git_url":"git://github.com/albertoalmagro/rails.git","ssh_url":"git@github.com:albertoalmagro/rails.git","clone_url":"https://github.com/albertoalmagro/rails.git","svn_url":"https://github.com/albertoalmagro/rails","homepage":"http://rubyonrails.org","size":166716,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"aa1ba9cb244b1e03d36aaa941ae4e91c6713b77e","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","private":false,"owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-12-02T19:52:34Z","pushed_at":"2018-12-02T20:01:28Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"https://rubyonrails.org","size":168469,"stargazers_count":41526,"watchers_count":41526,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16778,"mirror_url":null,"archived":false,"open_issues_count":1018,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16778,"open_issues":1018,"watchers":41526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/34595"},"html":{"href":"https://github.com/rails/rails/pull/34595"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/34595"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/34595/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/34595/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/34595/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/c93bad207087ab656b27c559012b5e8eb31ed20d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kamipo","id":12642,"node_id":"MDQ6VXNlcjEyNjQy","avatar_url":"https://avatars0.githubusercontent.com/u/12642?v=4","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"kamipo"}}