{"action":"created","issue":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2252","repository_url":"https://api.github.com/repos/paparazzi/paparazzi","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2252/labels{/name}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2252/comments","events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2252/events","html_url":"https://github.com/paparazzi/paparazzi/issues/2252","id":315025099,"node_id":"MDU6SXNzdWUzMTUwMjUwOTk=","number":2252,"title":"[Airframe] \"unit' with a define only sometiimes converts value","user":{"login":"EwoudSmeur","id":2464596,"node_id":"MDQ6VXNlcjI0NjQ1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2464596?v=4","gravatar_id":"","url":"https://api.github.com/users/EwoudSmeur","html_url":"https://github.com/EwoudSmeur","followers_url":"https://api.github.com/users/EwoudSmeur/followers","following_url":"https://api.github.com/users/EwoudSmeur/following{/other_user}","gists_url":"https://api.github.com/users/EwoudSmeur/gists{/gist_id}","starred_url":"https://api.github.com/users/EwoudSmeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EwoudSmeur/subscriptions","organizations_url":"https://api.github.com/users/EwoudSmeur/orgs","repos_url":"https://api.github.com/users/EwoudSmeur/repos","events_url":"https://api.github.com/users/EwoudSmeur/events{/privacy}","received_events_url":"https://api.github.com/users/EwoudSmeur/received_events","type":"User","site_admin":false},"labels":[{"id":144191683,"node_id":"MDU6TGFiZWwxNDQxOTE2ODM=","url":"https://api.github.com/repos/paparazzi/paparazzi/labels/Major","name":"Major","color":"CC0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/paparazzi/paparazzi/milestones/15","html_url":"https://github.com/paparazzi/paparazzi/milestone/15","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones/15/labels","id":2878306,"node_id":"MDk6TWlsZXN0b25lMjg3ODMwNg==","number":15,"title":"v5.14","description":"The focus could be on:\r\n\r\n* Add Parrot Bebop and Bebop 2 camera fixes\r\n* Airframe cleanup\r\n* More honored Pull requests\r\n* Tagging of flown aircraft option","creator":{"login":"OpenUAS","id":483944,"node_id":"MDQ6VXNlcjQ4Mzk0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483944?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenUAS","html_url":"https://github.com/OpenUAS","followers_url":"https://api.github.com/users/OpenUAS/followers","following_url":"https://api.github.com/users/OpenUAS/following{/other_user}","gists_url":"https://api.github.com/users/OpenUAS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenUAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenUAS/subscriptions","organizations_url":"https://api.github.com/users/OpenUAS/orgs","repos_url":"https://api.github.com/users/OpenUAS/repos","events_url":"https://api.github.com/users/OpenUAS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenUAS/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":11,"state":"open","created_at":"2017-10-31T13:57:46Z","updated_at":"2018-08-02T13:01:09Z","due_on":"2017-12-29T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-04-17T11:50:57Z","updated_at":"2018-08-02T13:02:00Z","closed_at":null,"author_association":"MEMBER","body":"For things like the body to IMU rotation defines, it is custom to put the value in degrees (which makes sense from my point of view), and add unit=\"deg\". This converts the value to radians, as the C code takes a value in radians.\r\n\r\nNow I want to use a magnetometer to IMU rotation in the same way. I define for instance:\r\n`<define name=\"HMC58XX_MAG_TO_IMU_PHI\" value=\"6.5\" unit=\"deg\"/>`\r\nBut now the value is not converted to radians (nor do I get a warning that I am trying to use a rotation larger than 2pi)!\r\n\r\nI think the behaviour of adding a unit should be uniform over the airframe file, as otherwise it is very confusing. "},"comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments/409918003","html_url":"https://github.com/paparazzi/paparazzi/issues/2252#issuecomment-409918003","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2252","id":409918003,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTkxODAwMw==","user":{"login":"OpenUAS","id":483944,"node_id":"MDQ6VXNlcjQ4Mzk0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483944?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenUAS","html_url":"https://github.com/OpenUAS","followers_url":"https://api.github.com/users/OpenUAS/followers","following_url":"https://api.github.com/users/OpenUAS/following{/other_user}","gists_url":"https://api.github.com/users/OpenUAS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenUAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenUAS/subscriptions","organizations_url":"https://api.github.com/users/OpenUAS/orgs","repos_url":"https://api.github.com/users/OpenUAS/repos","events_url":"https://api.github.com/users/OpenUAS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenUAS/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T13:02:00Z","updated_at":"2018-08-02T13:02:00Z","author_association":"CONTRIBUTOR","body":"This is indeed quite an issue if the plan is to move the modules to firmware section. Major label since it could crash you aircraft.\r\n\r\nCannot assign to self before there is some form of agreemen as a PPRZ team on how we want to handle it."}}
{"actor":{"display_login":"OpenUAS"}}