{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/218604924","pull_request_review_id":156581728,"id":218604924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODYwNDkyNA==","diff_hunk":"@@ -29,3 +29,11 @@ cake1: Func S1.foo3() is now static\n cake1: Struct C6 is now with @_fixed_layout\n cake1: Var C1.CIIns1 changes from weak to strong\n cake1: Var C1.CIIns2 changes from strong to weak\n+\n+/* Fixed-layout Type changes */\n+cake1: EnumElement FrozenKind.Fixed in a fixed layout type changes position from 1 to 2\n+cake1: EnumElement FrozenKind.Rigid in a fixed layout type changes position from 2 to 1\n+cake1: Func fixedLayoutStruct.foo() in a fixed layout type changes position from 0 to 1","path":"test/api-digester/Outputs/Cake-abi.txt","position":8,"original_position":8,"commit_id":"1a234e54c5750f57eba851cedb391f3bac5c4928","original_commit_id":"1a234e54c5750f57eba851cedb391f3bac5c4928","user":{"login":"nkcsgexi","id":2191945,"node_id":"MDQ6VXNlcjIxOTE5NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2191945?v=4","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"body":"is `VAD->hasStorage() && !VAD->isStatic()` sufficient to check this?  frozen enums don't need this constraint, right?","created_at":"2018-09-18T21:42:03Z","updated_at":"2018-09-18T21:42:03Z","html_url":"https://github.com/apple/swift/pull/19373#discussion_r218604924","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/218604924"},"html":{"href":"https://github.com/apple/swift/pull/19373#discussion_r218604924"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19373"}},"in_reply_to_id":218602252},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19373","id":216427648,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDI3NjQ4","html_url":"https://github.com/apple/swift/pull/19373","diff_url":"https://github.com/apple/swift/pull/19373.diff","patch_url":"https://github.com/apple/swift/pull/19373.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19373","number":19373,"state":"open","locked":false,"title":"swift-module-digester: diagnose reordering and adding decls in fixed layout types.","user":{"login":"nkcsgexi","id":2191945,"node_id":"MDQ6VXNlcjIxOTE5NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2191945?v=4","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-18T20:05:43Z","updated_at":"2018-09-18T21:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e6a2f97d042a86f3b5bd55fe9ed122d9e5bb012","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19373/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19373/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19373/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1a234e54c5750f57eba851cedb391f3bac5c4928","head":{"label":"nkcsgexi:diagnose-reorder","ref":"diagnose-reorder","sha":"1a234e54c5750f57eba851cedb391f3bac5c4928","user":{"login":"nkcsgexi","id":2191945,"node_id":"MDQ6VXNlcjIxOTE5NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2191945?v=4","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"repo":{"id":133553669,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NTM2Njk=","name":"swift","full_name":"nkcsgexi/swift","private":false,"owner":{"login":"nkcsgexi","id":2191945,"node_id":"MDQ6VXNlcjIxOTE5NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2191945?v=4","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nkcsgexi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/nkcsgexi/swift","forks_url":"https://api.github.com/repos/nkcsgexi/swift/forks","keys_url":"https://api.github.com/repos/nkcsgexi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkcsgexi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkcsgexi/swift/teams","hooks_url":"https://api.github.com/repos/nkcsgexi/swift/hooks","issue_events_url":"https://api.github.com/repos/nkcsgexi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/nkcsgexi/swift/events","assignees_url":"https://api.github.com/repos/nkcsgexi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/nkcsgexi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/nkcsgexi/swift/tags","blobs_url":"https://api.github.com/repos/nkcsgexi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkcsgexi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkcsgexi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkcsgexi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkcsgexi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/nkcsgexi/swift/languages","stargazers_url":"https://api.github.com/repos/nkcsgexi/swift/stargazers","contributors_url":"https://api.github.com/repos/nkcsgexi/swift/contributors","subscribers_url":"https://api.github.com/repos/nkcsgexi/swift/subscribers","subscription_url":"https://api.github.com/repos/nkcsgexi/swift/subscription","commits_url":"https://api.github.com/repos/nkcsgexi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkcsgexi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkcsgexi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkcsgexi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkcsgexi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/nkcsgexi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkcsgexi/swift/merges","archive_url":"https://api.github.com/repos/nkcsgexi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkcsgexi/swift/downloads","issues_url":"https://api.github.com/repos/nkcsgexi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/nkcsgexi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/nkcsgexi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/nkcsgexi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkcsgexi/swift/labels{/name}","releases_url":"https://api.github.com/repos/nkcsgexi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/nkcsgexi/swift/deployments","created_at":"2018-05-15T17:57:24Z","updated_at":"2018-08-14T06:49:19Z","pushed_at":"2018-09-18T21:17:56Z","git_url":"git://github.com/nkcsgexi/swift.git","ssh_url":"git@github.com:nkcsgexi/swift.git","clone_url":"https://github.com/nkcsgexi/swift.git","svn_url":"https://github.com/nkcsgexi/swift","homepage":"https://swift.org/","size":331824,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"3f787a1ad2d6774dfb9bf231e443fd771085efd4","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-18T21:33:52Z","pushed_at":"2018-09-18T21:32:26Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":339222,"stargazers_count":45234,"watchers_count":45234,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7143,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7143,"open_issues":379,"watchers":45234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19373"},"html":{"href":"https://github.com/apple/swift/pull/19373"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19373"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19373/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19373/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19373/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1a234e54c5750f57eba851cedb391f3bac5c4928"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nkcsgexi"}}