{"action":"created","issue":{"url":"https://api.github.com/repos/apache/geode/issues/2368","repository_url":"https://api.github.com/repos/apache/geode","labels_url":"https://api.github.com/repos/apache/geode/issues/2368/labels{/name}","comments_url":"https://api.github.com/repos/apache/geode/issues/2368/comments","events_url":"https://api.github.com/repos/apache/geode/issues/2368/events","html_url":"https://github.com/apache/geode/pull/2368","id":353495842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTMyODc2","number":2368,"title":"GEODE-5590: Containerize AcceptanceTest","user":{"login":"pdxrunner","id":16668768,"node_id":"MDQ6VXNlcjE2NjY4NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/16668768?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxrunner","html_url":"https://github.com/pdxrunner","followers_url":"https://api.github.com/users/pdxrunner/followers","following_url":"https://api.github.com/users/pdxrunner/following{/other_user}","gists_url":"https://api.github.com/users/pdxrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxrunner/subscriptions","organizations_url":"https://api.github.com/users/pdxrunner/orgs","repos_url":"https://api.github.com/users/pdxrunner/repos","events_url":"https://api.github.com/users/pdxrunner/events{/privacy}","received_events_url":"https://api.github.com/users/pdxrunner/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-23T18:15:17Z","updated_at":"2018-08-28T22:33:40Z","closed_at":"2018-08-28T22:33:40Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2368","html_url":"https://github.com/apache/geode/pull/2368","diff_url":"https://github.com/apache/geode/pull/2368.diff","patch_url":"https://github.com/apache/geode/pull/2368.patch"},"body":"AcceptanceTests were run in parallel but not in containers in the CI\r\npipeline. This caused intermittent port conflicts for tests using\r\ndefault ports. However, the connector tests use database instances in\r\ndocker containers, so to avoid docker in docker issues, the connector\r\ntests can't be run in containers in the pipeline.\r\n\r\n* Create new test category, DockerComposedTest. Test using the SqlDatabaseConnectionRule \r\nare annotated with this Category.\r\n* docker-in-docker is avoided by creating a new test task,\r\nacceptanceTestWithDockerCompose for DockerComposedTests. Tests run\r\nserially and non-containerized for this task.\r\n* Add depenedency for acceptancetest on acceptanceTestWithDockerCompose\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [X] Is your initial contribution a single, squashed commit?\r\n\r\n- [X] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/geode/issues/comments/416762505","html_url":"https://github.com/apache/geode/pull/2368#issuecomment-416762505","issue_url":"https://api.github.com/repos/apache/geode/issues/2368","id":416762505,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjc2MjUwNQ==","user":{"login":"pdxrunner","id":16668768,"node_id":"MDQ6VXNlcjE2NjY4NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/16668768?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxrunner","html_url":"https://github.com/pdxrunner","followers_url":"https://api.github.com/users/pdxrunner/followers","following_url":"https://api.github.com/users/pdxrunner/following{/other_user}","gists_url":"https://api.github.com/users/pdxrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxrunner/subscriptions","organizations_url":"https://api.github.com/users/pdxrunner/orgs","repos_url":"https://api.github.com/users/pdxrunner/repos","events_url":"https://api.github.com/users/pdxrunner/events{/privacy}","received_events_url":"https://api.github.com/users/pdxrunner/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T22:33:40Z","updated_at":"2018-08-28T22:33:40Z","author_association":"CONTRIBUTOR","body":"Closing this in favor of a simpler fix (PR#2389, GEODE-5601). After many tweaks to the this I am still getting many precheckin failures, including port conflicts on the default ports and many failures in IntegrationTests that shouldn't have been affected."}}
{"actor":{"display_login":"pdxrunner"}}