{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2","id":172268078,"html_url":"https://github.com/boucherv/charm-keepalived/pull/2","diff_url":"https://github.com/boucherv/charm-keepalived/pull/2.diff","patch_url":"https://github.com/boucherv/charm-keepalived/pull/2.patch","issue_url":"https://api.github.com/repos/boucherv/charm-keepalived/issues/2","number":2,"state":"open","locked":false,"title":"First review/clean-up pass","user":{"login":"ktsakalozos","id":11489452,"avatar_url":"https://avatars2.githubusercontent.com/u/11489452?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsakalozos","html_url":"https://github.com/ktsakalozos","followers_url":"https://api.github.com/users/ktsakalozos/followers","following_url":"https://api.github.com/users/ktsakalozos/following{/other_user}","gists_url":"https://api.github.com/users/ktsakalozos/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsakalozos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsakalozos/subscriptions","organizations_url":"https://api.github.com/users/ktsakalozos/orgs","repos_url":"https://api.github.com/users/ktsakalozos/repos","events_url":"https://api.github.com/users/ktsakalozos/events{/privacy}","received_events_url":"https://api.github.com/users/ktsakalozos/received_events","type":"User","site_admin":false},"body":"Hi @boucherv , I went through the charm and did some cleanup/rewrite.\r\n\r\nThere are a lot of changes but the end result is rewarding - I think.\r\n\r\nHave a look at the layers.yaml. That file shows all the layers and interface we are using. During charm build the layers & interfaces are fetched from  https://github.com/juju/layer-index . This means you do not need the hooks directory as it is automatically built.\r\n\r\nLet me know if you would like to catch up on IRC/hangouts to go through the changes.\r\n\r\nThis code deploys but not that it is not well tested.  ","created_at":"2018-03-01T15:26:23Z","updated_at":"2018-03-01T15:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2/commits","review_comments_url":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2/comments","review_comment_url":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boucherv/charm-keepalived/issues/2/comments","statuses_url":"https://api.github.com/repos/boucherv/charm-keepalived/statuses/22915017bd89325208a68122bac76facba5ac485","head":{"label":"ktsakalozos:master","ref":"master","sha":"22915017bd89325208a68122bac76facba5ac485","user":{"login":"ktsakalozos","id":11489452,"avatar_url":"https://avatars2.githubusercontent.com/u/11489452?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsakalozos","html_url":"https://github.com/ktsakalozos","followers_url":"https://api.github.com/users/ktsakalozos/followers","following_url":"https://api.github.com/users/ktsakalozos/following{/other_user}","gists_url":"https://api.github.com/users/ktsakalozos/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsakalozos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsakalozos/subscriptions","organizations_url":"https://api.github.com/users/ktsakalozos/orgs","repos_url":"https://api.github.com/users/ktsakalozos/repos","events_url":"https://api.github.com/users/ktsakalozos/events{/privacy}","received_events_url":"https://api.github.com/users/ktsakalozos/received_events","type":"User","site_admin":false},"repo":{"id":123104798,"name":"charm-keepalived","full_name":"ktsakalozos/charm-keepalived","owner":{"login":"ktsakalozos","id":11489452,"avatar_url":"https://avatars2.githubusercontent.com/u/11489452?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsakalozos","html_url":"https://github.com/ktsakalozos","followers_url":"https://api.github.com/users/ktsakalozos/followers","following_url":"https://api.github.com/users/ktsakalozos/following{/other_user}","gists_url":"https://api.github.com/users/ktsakalozos/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsakalozos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsakalozos/subscriptions","organizations_url":"https://api.github.com/users/ktsakalozos/orgs","repos_url":"https://api.github.com/users/ktsakalozos/repos","events_url":"https://api.github.com/users/ktsakalozos/events{/privacy}","received_events_url":"https://api.github.com/users/ktsakalozos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktsakalozos/charm-keepalived","description":null,"fork":true,"url":"https://api.github.com/repos/ktsakalozos/charm-keepalived","forks_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/forks","keys_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/teams","hooks_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/hooks","issue_events_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/issues/events{/number}","events_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/events","assignees_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/assignees{/user}","branches_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/branches{/branch}","tags_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/tags","blobs_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/statuses/{sha}","languages_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/languages","stargazers_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/stargazers","contributors_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/contributors","subscribers_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/subscribers","subscription_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/subscription","commits_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/contents/{+path}","compare_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/merges","archive_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/downloads","issues_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/issues{/number}","pulls_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/pulls{/number}","milestones_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/milestones{/number}","notifications_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/labels{/name}","releases_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/releases{/id}","deployments_url":"https://api.github.com/repos/ktsakalozos/charm-keepalived/deployments","created_at":"2018-02-27T09:23:53Z","updated_at":"2018-02-27T09:23:55Z","pushed_at":"2018-03-01T15:13:34Z","git_url":"git://github.com/ktsakalozos/charm-keepalived.git","ssh_url":"git@github.com:ktsakalozos/charm-keepalived.git","clone_url":"https://github.com/ktsakalozos/charm-keepalived.git","svn_url":"https://github.com/ktsakalozos/charm-keepalived","homepage":null,"size":4133,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boucherv:master","ref":"master","sha":"f82cb9a93259430cd8134755b3c51a1ecce65277","user":{"login":"boucherv","id":13995481,"avatar_url":"https://avatars1.githubusercontent.com/u/13995481?v=4","gravatar_id":"","url":"https://api.github.com/users/boucherv","html_url":"https://github.com/boucherv","followers_url":"https://api.github.com/users/boucherv/followers","following_url":"https://api.github.com/users/boucherv/following{/other_user}","gists_url":"https://api.github.com/users/boucherv/gists{/gist_id}","starred_url":"https://api.github.com/users/boucherv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boucherv/subscriptions","organizations_url":"https://api.github.com/users/boucherv/orgs","repos_url":"https://api.github.com/users/boucherv/repos","events_url":"https://api.github.com/users/boucherv/events{/privacy}","received_events_url":"https://api.github.com/users/boucherv/received_events","type":"User","site_admin":false},"repo":{"id":114926934,"name":"charm-keepalived","full_name":"boucherv/charm-keepalived","owner":{"login":"boucherv","id":13995481,"avatar_url":"https://avatars1.githubusercontent.com/u/13995481?v=4","gravatar_id":"","url":"https://api.github.com/users/boucherv","html_url":"https://github.com/boucherv","followers_url":"https://api.github.com/users/boucherv/followers","following_url":"https://api.github.com/users/boucherv/following{/other_user}","gists_url":"https://api.github.com/users/boucherv/gists{/gist_id}","starred_url":"https://api.github.com/users/boucherv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boucherv/subscriptions","organizations_url":"https://api.github.com/users/boucherv/orgs","repos_url":"https://api.github.com/users/boucherv/repos","events_url":"https://api.github.com/users/boucherv/events{/privacy}","received_events_url":"https://api.github.com/users/boucherv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boucherv/charm-keepalived","description":null,"fork":false,"url":"https://api.github.com/repos/boucherv/charm-keepalived","forks_url":"https://api.github.com/repos/boucherv/charm-keepalived/forks","keys_url":"https://api.github.com/repos/boucherv/charm-keepalived/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boucherv/charm-keepalived/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boucherv/charm-keepalived/teams","hooks_url":"https://api.github.com/repos/boucherv/charm-keepalived/hooks","issue_events_url":"https://api.github.com/repos/boucherv/charm-keepalived/issues/events{/number}","events_url":"https://api.github.com/repos/boucherv/charm-keepalived/events","assignees_url":"https://api.github.com/repos/boucherv/charm-keepalived/assignees{/user}","branches_url":"https://api.github.com/repos/boucherv/charm-keepalived/branches{/branch}","tags_url":"https://api.github.com/repos/boucherv/charm-keepalived/tags","blobs_url":"https://api.github.com/repos/boucherv/charm-keepalived/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boucherv/charm-keepalived/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boucherv/charm-keepalived/git/refs{/sha}","trees_url":"https://api.github.com/repos/boucherv/charm-keepalived/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boucherv/charm-keepalived/statuses/{sha}","languages_url":"https://api.github.com/repos/boucherv/charm-keepalived/languages","stargazers_url":"https://api.github.com/repos/boucherv/charm-keepalived/stargazers","contributors_url":"https://api.github.com/repos/boucherv/charm-keepalived/contributors","subscribers_url":"https://api.github.com/repos/boucherv/charm-keepalived/subscribers","subscription_url":"https://api.github.com/repos/boucherv/charm-keepalived/subscription","commits_url":"https://api.github.com/repos/boucherv/charm-keepalived/commits{/sha}","git_commits_url":"https://api.github.com/repos/boucherv/charm-keepalived/git/commits{/sha}","comments_url":"https://api.github.com/repos/boucherv/charm-keepalived/comments{/number}","issue_comment_url":"https://api.github.com/repos/boucherv/charm-keepalived/issues/comments{/number}","contents_url":"https://api.github.com/repos/boucherv/charm-keepalived/contents/{+path}","compare_url":"https://api.github.com/repos/boucherv/charm-keepalived/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boucherv/charm-keepalived/merges","archive_url":"https://api.github.com/repos/boucherv/charm-keepalived/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boucherv/charm-keepalived/downloads","issues_url":"https://api.github.com/repos/boucherv/charm-keepalived/issues{/number}","pulls_url":"https://api.github.com/repos/boucherv/charm-keepalived/pulls{/number}","milestones_url":"https://api.github.com/repos/boucherv/charm-keepalived/milestones{/number}","notifications_url":"https://api.github.com/repos/boucherv/charm-keepalived/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boucherv/charm-keepalived/labels{/name}","releases_url":"https://api.github.com/repos/boucherv/charm-keepalived/releases{/id}","deployments_url":"https://api.github.com/repos/boucherv/charm-keepalived/deployments","created_at":"2017-12-20T20:11:05Z","updated_at":"2017-12-20T20:12:35Z","pushed_at":"2018-02-14T13:22:22Z","git_url":"git://github.com/boucherv/charm-keepalived.git","ssh_url":"git@github.com:boucherv/charm-keepalived.git","clone_url":"https://github.com/boucherv/charm-keepalived.git","svn_url":"https://github.com/boucherv/charm-keepalived","homepage":null,"size":4133,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2"},"html":{"href":"https://github.com/boucherv/charm-keepalived/pull/2"},"issue":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/issues/2"},"comments":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/boucherv/charm-keepalived/statuses/22915017bd89325208a68122bac76facba5ac485"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":105,"deletions":921,"changed_files":37}}
{"actor":{"display_login":"ktsakalozos"}}