{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/208640242","pull_request_review_id":144491761,"id":208640242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODY0MDI0Mg==","diff_hunk":"@@ -100,32 +102,39 @@ public static boolean enabled() {\n    * <p>Caution should be exercised when executing code as system. Results from querying as system\n    * are never returned to the client or cached. This means there is no risk of data leak.\n    *\n-   * @param framework the catalog framework, for creating system templates.\n+   * @param catalogFramework the catalog framework, for creating system templates.\n    * @param util for querying the catalog.\n    * @param systemTemplates system templates loaded from config.\n    */\n   public static void bootstrap(\n-      CatalogFramework framework, EndpointUtil util, List<Metacard> systemTemplates) {\n-    Set<String> queryTitles =\n-        executeAsSystem(() -> titlesTransform(util.getMetacardsByFilter(QUERY_TEMPLATE_TAG)));\n-    Set<String> resultTitles =\n-        executeAsSystem(() -> titlesTransform(util.getMetacardsByFilter(ATTRIBUTE_GROUP_TAG)));\n+      CatalogFramework catalogFramework, EndpointUtil util, List<Metacard> systemTemplates) {\n+    Subject systemSubject = SECURITY.runAsAdmin(SECURITY::getSystemSubject);\n+    if (systemSubject == null) {\n+      throw new SecurityException(\"Could not get systemSubject to initialize system templates\");\n+    }\n \n-    List<Metacard> dedupedTemplateMetacards =\n-        Stream.concat(\n-                systemTemplates\n-                    .stream()\n-                    .filter(QueryTemplateMetacard::isQueryTemplateMetacard)\n-                    .filter(metacard -> !queryTitles.contains(metacard.getTitle())),\n-                systemTemplates\n-                    .stream()\n-                    .filter(AttributeGroupMetacard::isAttributeGroupMetacard)\n-                    .filter(metacard -> !resultTitles.contains(metacard.getTitle())))\n-            .collect(Collectors.toList());\n+    ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(4);","path":"catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/forms/SearchFormsLoader.java","position":50,"original_position":50,"commit_id":"a8ebf2d6450cfa41f72f840e57806d4f6aa21947","original_commit_id":"a8ebf2d6450cfa41f72f840e57806d4f6aa21947","user":{"login":"rzwiefel","id":9013416,"node_id":"MDQ6VXNlcjkwMTM0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"body":"I prefer 7 but i suppose that makes me pretty casual since its such a popular number","created_at":"2018-08-08T16:02:56Z","updated_at":"2018-08-08T16:02:57Z","html_url":"https://github.com/codice/ddf/pull/3566#discussion_r208640242","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3566","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/208640242"},"html":{"href":"https://github.com/codice/ddf/pull/3566#discussion_r208640242"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3566"}},"in_reply_to_id":208633251},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3566","id":206849563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODQ5NTYz","html_url":"https://github.com/codice/ddf/pull/3566","diff_url":"https://github.com/codice/ddf/pull/3566.diff","patch_url":"https://github.com/codice/ddf/pull/3566.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3566","number":3566,"state":"open","locked":false,"title":"DDF-4036 Made Failsafe Asynchronous","user":{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\n Made Failsafe Asynchronous which fixes downstream itest failures\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@GabrielFabian @Bdthomson \r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@pklinef\r\n@millerw8 \r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\nBuild / Unzip / make etc forms directory / Install / turn on experimental features / verify search form crud\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4036](https://codice.atlassian.net/browse/DDF-4036)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-08-07T23:00:18Z","updated_at":"2018-08-08T16:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feb7a69942fab30d7bc3c3e7d4aef8d17f639793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3566/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3566/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3566/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/a8ebf2d6450cfa41f72f840e57806d4f6aa21947","head":{"label":"bdeining:fix_failsafe","ref":"fix_failsafe","sha":"a8ebf2d6450cfa41f72f840e57806d4f6aa21947","user":{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"repo":{"id":40979396,"node_id":"MDEwOlJlcG9zaXRvcnk0MDk3OTM5Ng==","name":"ddf","full_name":"bdeining/ddf","owner":{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdeining/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/bdeining/ddf","forks_url":"https://api.github.com/repos/bdeining/ddf/forks","keys_url":"https://api.github.com/repos/bdeining/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdeining/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdeining/ddf/teams","hooks_url":"https://api.github.com/repos/bdeining/ddf/hooks","issue_events_url":"https://api.github.com/repos/bdeining/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/bdeining/ddf/events","assignees_url":"https://api.github.com/repos/bdeining/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/bdeining/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/bdeining/ddf/tags","blobs_url":"https://api.github.com/repos/bdeining/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdeining/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdeining/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdeining/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdeining/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/bdeining/ddf/languages","stargazers_url":"https://api.github.com/repos/bdeining/ddf/stargazers","contributors_url":"https://api.github.com/repos/bdeining/ddf/contributors","subscribers_url":"https://api.github.com/repos/bdeining/ddf/subscribers","subscription_url":"https://api.github.com/repos/bdeining/ddf/subscription","commits_url":"https://api.github.com/repos/bdeining/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdeining/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdeining/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdeining/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdeining/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/bdeining/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdeining/ddf/merges","archive_url":"https://api.github.com/repos/bdeining/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdeining/ddf/downloads","issues_url":"https://api.github.com/repos/bdeining/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/bdeining/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/bdeining/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/bdeining/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdeining/ddf/labels{/name}","releases_url":"https://api.github.com/repos/bdeining/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/bdeining/ddf/deployments","created_at":"2015-08-18T15:16:49Z","updated_at":"2018-08-03T18:25:03Z","pushed_at":"2018-08-08T14:09:38Z","git_url":"git://github.com/bdeining/ddf.git","ssh_url":"git@github.com:bdeining/ddf.git","clone_url":"https://github.com/bdeining/ddf.git","svn_url":"https://github.com/bdeining/ddf","homepage":"","size":204905,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"11c944bdebf26de452df745aeb934915476a7041","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-08-07T23:56:31Z","pushed_at":"2018-08-08T15:53:39Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":400265,"stargazers_count":86,"watchers_count":86,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":151,"open_issues":39,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3566"},"html":{"href":"https://github.com/codice/ddf/pull/3566"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3566"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3566/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3566/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3566/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/a8ebf2d6450cfa41f72f840e57806d4f6aa21947"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rzwiefel"}}