{"action":"created","comment":{"url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/comments/211190817","pull_request_review_id":147559020,"id":211190817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTE5MDgxNw==","diff_hunk":"@@ -11,392 +11,51 @@ define(function(require) {\n \n             restrict: \"A\",\n             templateUrl: templateUrl,\n-            link: function(scope, element, attrs) {\n-                var graphPreviewDiv = element.find(\".graph-preview\");\n-\n-                var b = require('../../../lib/graph_sketcher/bezier.js');\n-                var f = require('../../../lib/graph_sketcher/func.js');\n-                var s = require('../../../lib/graph_sketcher/sampler.js');\n+            link: function(scope, element, _attrs) {\n+                let graphPreviewDiv = element.find(\".graph-preview\");\n \n                 scope.canvasID = scope.questionDoc.id;\n \n+                function reDraw() {\n+                    scope.graphView.drawBackground(canvasWidth, canvasHeight);\n+                    scope.graphView.drawCurves(curves);\n+                }","path":"app/js/app/directives/graph_sketcher/GraphPreview.js","position":30,"original_position":30,"commit_id":"9e310c9af250d76968c383d1cf97ae6cdd00fed6","original_commit_id":"9e310c9af250d76968c383d1cf97ae6cdd00fed6","user":{"login":"bh412","id":20041074,"node_id":"MDQ6VXNlcjIwMDQxMDc0","avatar_url":"https://avatars1.githubusercontent.com/u/20041074?v=4","gravatar_id":"","url":"https://api.github.com/users/bh412","html_url":"https://github.com/bh412","followers_url":"https://api.github.com/users/bh412/followers","following_url":"https://api.github.com/users/bh412/following{/other_user}","gists_url":"https://api.github.com/users/bh412/gists{/gist_id}","starred_url":"https://api.github.com/users/bh412/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bh412/subscriptions","organizations_url":"https://api.github.com/users/bh412/orgs","repos_url":"https://api.github.com/users/bh412/repos","events_url":"https://api.github.com/users/bh412/events{/privacy}","received_events_url":"https://api.github.com/users/bh412/received_events","type":"User","site_admin":false},"body":"Good spot, I've removed the out of sketch duplicate function","created_at":"2018-08-20T09:10:07Z","updated_at":"2018-08-20T09:10:07Z","html_url":"https://github.com/ucam-cl-dtg/isaac-app/pull/975#discussion_r211190817","pull_request_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/comments/211190817"},"html":{"href":"https://github.com/ucam-cl-dtg/isaac-app/pull/975#discussion_r211190817"},"pull_request":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975"}},"in_reply_to_id":211156487},"pull_request":{"url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975","id":208021233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDIxMjMz","html_url":"https://github.com/ucam-cl-dtg/isaac-app/pull/975","diff_url":"https://github.com/ucam-cl-dtg/isaac-app/pull/975.diff","patch_url":"https://github.com/ucam-cl-dtg/isaac-app/pull/975.patch","issue_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/975","number":975,"state":"open","locked":false,"title":"Feature/refactor graph sketcher - includes some of the password reset things","user":{"login":"bh412","id":20041074,"node_id":"MDQ6VXNlcjIwMDQxMDc0","avatar_url":"https://avatars1.githubusercontent.com/u/20041074?v=4","gravatar_id":"","url":"https://api.github.com/users/bh412","html_url":"https://github.com/bh412","followers_url":"https://api.github.com/users/bh412/followers","following_url":"https://api.github.com/users/bh412/following{/other_user}","gists_url":"https://api.github.com/users/bh412/gists{/gist_id}","starred_url":"https://api.github.com/users/bh412/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bh412/subscriptions","organizations_url":"https://api.github.com/users/bh412/orgs","repos_url":"https://api.github.com/users/bh412/repos","events_url":"https://api.github.com/users/bh412/events{/privacy}","received_events_url":"https://api.github.com/users/bh412/received_events","type":"User","site_admin":false},"body":"---\r\n\r\n**Pull Request Check List**\r\n- [ ] Unit Tests & Regression Tests Added (Optional)\r\n- [ ] Removed Unnecessary Logs/System.Outs/Comments/TODOs\r\n- [ ] Added enough Logging to monitor expected behaviour change\r\n- [ ] Security - XSS/Injection - All user input validated or encoded before being used in page or URL\r\n- [ ] Security - Data Exposure - PII is not sent in URL or query params\r\n- [ ] Security - Access Control - Suitable authorisation added to new pages\r\n- [ ] Security - New dependency - Searched for any known vulnerabilities\r\n- [ ] Security - New dependency - Signed up team to mailing list\r\n- [ ] Security - New dependency - Added to dependency list\r\n- [ ] Updated Release Procedure & Documentation\r\n- [ ] Peer-Reviewed","created_at":"2018-08-13T15:46:20Z","updated_at":"2018-08-20T09:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3665c80c7fa7c72bc993badbf0a9b8290eac7df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Morpheu5","id":411507,"node_id":"MDQ6VXNlcjQxMTUwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/411507?v=4","gravatar_id":"","url":"https://api.github.com/users/Morpheu5","html_url":"https://github.com/Morpheu5","followers_url":"https://api.github.com/users/Morpheu5/followers","following_url":"https://api.github.com/users/Morpheu5/following{/other_user}","gists_url":"https://api.github.com/users/Morpheu5/gists{/gist_id}","starred_url":"https://api.github.com/users/Morpheu5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morpheu5/subscriptions","organizations_url":"https://api.github.com/users/Morpheu5/orgs","repos_url":"https://api.github.com/users/Morpheu5/repos","events_url":"https://api.github.com/users/Morpheu5/events{/privacy}","received_events_url":"https://api.github.com/users/Morpheu5/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975/commits","review_comments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975/comments","review_comment_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/975/comments","statuses_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/statuses/9e310c9af250d76968c383d1cf97ae6cdd00fed6","head":{"label":"ucam-cl-dtg:feature/refactor-graph-sketcher","ref":"feature/refactor-graph-sketcher","sha":"9e310c9af250d76968c383d1cf97ae6cdd00fed6","user":{"login":"ucam-cl-dtg","id":1140917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDA5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1140917?v=4","gravatar_id":"","url":"https://api.github.com/users/ucam-cl-dtg","html_url":"https://github.com/ucam-cl-dtg","followers_url":"https://api.github.com/users/ucam-cl-dtg/followers","following_url":"https://api.github.com/users/ucam-cl-dtg/following{/other_user}","gists_url":"https://api.github.com/users/ucam-cl-dtg/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-cl-dtg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-cl-dtg/subscriptions","organizations_url":"https://api.github.com/users/ucam-cl-dtg/orgs","repos_url":"https://api.github.com/users/ucam-cl-dtg/repos","events_url":"https://api.github.com/users/ucam-cl-dtg/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-cl-dtg/received_events","type":"Organization","site_admin":false},"repo":{"id":19943563,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0MzU2Mw==","name":"isaac-app","full_name":"ucam-cl-dtg/isaac-app","owner":{"login":"ucam-cl-dtg","id":1140917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDA5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1140917?v=4","gravatar_id":"","url":"https://api.github.com/users/ucam-cl-dtg","html_url":"https://github.com/ucam-cl-dtg","followers_url":"https://api.github.com/users/ucam-cl-dtg/followers","following_url":"https://api.github.com/users/ucam-cl-dtg/following{/other_user}","gists_url":"https://api.github.com/users/ucam-cl-dtg/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-cl-dtg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-cl-dtg/subscriptions","organizations_url":"https://api.github.com/users/ucam-cl-dtg/orgs","repos_url":"https://api.github.com/users/ucam-cl-dtg/repos","events_url":"https://api.github.com/users/ucam-cl-dtg/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-cl-dtg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucam-cl-dtg/isaac-app","description":"Isaac front-end project, based on Angular JS","fork":false,"url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app","forks_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/forks","keys_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/teams","hooks_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/hooks","issue_events_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/events{/number}","events_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/events","assignees_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/assignees{/user}","branches_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/branches{/branch}","tags_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/tags","blobs_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/statuses/{sha}","languages_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/languages","stargazers_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/stargazers","contributors_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/contributors","subscribers_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/subscribers","subscription_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/subscription","commits_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/contents/{+path}","compare_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/merges","archive_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/downloads","issues_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues{/number}","pulls_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls{/number}","milestones_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/milestones{/number}","notifications_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/labels{/name}","releases_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/releases{/id}","deployments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/deployments","created_at":"2014-05-19T13:49:07Z","updated_at":"2018-08-16T15:09:01Z","pushed_at":"2018-08-17T11:22:36Z","git_url":"git://github.com/ucam-cl-dtg/isaac-app.git","ssh_url":"git@github.com:ucam-cl-dtg/isaac-app.git","clone_url":"https://github.com/ucam-cl-dtg/isaac-app.git","svn_url":"https://github.com/ucam-cl-dtg/isaac-app","homepage":"https://isaacphysics.org","size":30372,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":87,"watchers":5,"default_branch":"master"}},"base":{"label":"ucam-cl-dtg:master","ref":"master","sha":"34e2d86aedfa0556869d4d589fccb0b972a55d4e","user":{"login":"ucam-cl-dtg","id":1140917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDA5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1140917?v=4","gravatar_id":"","url":"https://api.github.com/users/ucam-cl-dtg","html_url":"https://github.com/ucam-cl-dtg","followers_url":"https://api.github.com/users/ucam-cl-dtg/followers","following_url":"https://api.github.com/users/ucam-cl-dtg/following{/other_user}","gists_url":"https://api.github.com/users/ucam-cl-dtg/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-cl-dtg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-cl-dtg/subscriptions","organizations_url":"https://api.github.com/users/ucam-cl-dtg/orgs","repos_url":"https://api.github.com/users/ucam-cl-dtg/repos","events_url":"https://api.github.com/users/ucam-cl-dtg/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-cl-dtg/received_events","type":"Organization","site_admin":false},"repo":{"id":19943563,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0MzU2Mw==","name":"isaac-app","full_name":"ucam-cl-dtg/isaac-app","owner":{"login":"ucam-cl-dtg","id":1140917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDA5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1140917?v=4","gravatar_id":"","url":"https://api.github.com/users/ucam-cl-dtg","html_url":"https://github.com/ucam-cl-dtg","followers_url":"https://api.github.com/users/ucam-cl-dtg/followers","following_url":"https://api.github.com/users/ucam-cl-dtg/following{/other_user}","gists_url":"https://api.github.com/users/ucam-cl-dtg/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-cl-dtg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-cl-dtg/subscriptions","organizations_url":"https://api.github.com/users/ucam-cl-dtg/orgs","repos_url":"https://api.github.com/users/ucam-cl-dtg/repos","events_url":"https://api.github.com/users/ucam-cl-dtg/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-cl-dtg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucam-cl-dtg/isaac-app","description":"Isaac front-end project, based on Angular JS","fork":false,"url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app","forks_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/forks","keys_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/teams","hooks_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/hooks","issue_events_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/events{/number}","events_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/events","assignees_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/assignees{/user}","branches_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/branches{/branch}","tags_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/tags","blobs_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/statuses/{sha}","languages_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/languages","stargazers_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/stargazers","contributors_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/contributors","subscribers_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/subscribers","subscription_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/subscription","commits_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/contents/{+path}","compare_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/merges","archive_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/downloads","issues_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues{/number}","pulls_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls{/number}","milestones_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/milestones{/number}","notifications_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/labels{/name}","releases_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/releases{/id}","deployments_url":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/deployments","created_at":"2014-05-19T13:49:07Z","updated_at":"2018-08-16T15:09:01Z","pushed_at":"2018-08-17T11:22:36Z","git_url":"git://github.com/ucam-cl-dtg/isaac-app.git","ssh_url":"git@github.com:ucam-cl-dtg/isaac-app.git","clone_url":"https://github.com/ucam-cl-dtg/isaac-app.git","svn_url":"https://github.com/ucam-cl-dtg/isaac-app","homepage":"https://isaacphysics.org","size":30372,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":87,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975"},"html":{"href":"https://github.com/ucam-cl-dtg/isaac-app/pull/975"},"issue":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/975"},"comments":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/issues/975/comments"},"review_comments":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975/comments"},"review_comment":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/pulls/975/commits"},"statuses":{"href":"https://api.github.com/repos/ucam-cl-dtg/isaac-app/statuses/9e310c9af250d76968c383d1cf97ae6cdd00fed6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bh412"}}