{"action":"created","issue":{"url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/46","repository_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js","labels_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/46/comments","events_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/46/events","html_url":"https://github.com/MARKETProtocol/MARKET.js/issues/46","id":334874191,"node_id":"MDU6SXNzdWUzMzQ4NzQxOTE=","number":46,"title":"[Order] add getQtyFilledOrCancelledFromOrderAsync methods","user":{"login":"pelsasser","id":15096737,"node_id":"MDQ6VXNlcjE1MDk2NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/15096737?v=4","gravatar_id":"","url":"https://api.github.com/users/pelsasser","html_url":"https://github.com/pelsasser","followers_url":"https://api.github.com/users/pelsasser/followers","following_url":"https://api.github.com/users/pelsasser/following{/other_user}","gists_url":"https://api.github.com/users/pelsasser/gists{/gist_id}","starred_url":"https://api.github.com/users/pelsasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelsasser/subscriptions","organizations_url":"https://api.github.com/users/pelsasser/orgs","repos_url":"https://api.github.com/users/pelsasser/repos","events_url":"https://api.github.com/users/pelsasser/events{/privacy}","received_events_url":"https://api.github.com/users/pelsasser/received_events","type":"User","site_admin":false},"labels":[{"id":918425231,"node_id":"MDU6TGFiZWw5MTg0MjUyMzE=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Bounty%20Attached","name":"Bounty Attached","color":"87edaa","default":false},{"id":918385848,"node_id":"MDU6TGFiZWw5MTgzODU4NDg=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Good%20First%20Issue","name":"Good First Issue","color":"7057ff","default":false},{"id":918385846,"node_id":"MDU6TGFiZWw5MTgzODU4NDY=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Help%20Wanted","name":"Help Wanted","color":"008672","default":false},{"id":918425252,"node_id":"MDU6TGFiZWw5MTg0MjUyNTI=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Priority:%20High","name":"Priority: High","color":"eb6420","default":false},{"id":918425234,"node_id":"MDU6TGFiZWw5MTg0MjUyMzQ=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Status:%20Available","name":"Status: Available","color":"bfe5bf","default":false},{"id":918425246,"node_id":"MDU6TGFiZWw5MTg0MjUyNDY=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/milestones/1","html_url":"https://github.com/MARKETProtocol/MARKET.js/milestone/1","labels_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/milestones/1/labels","id":3385889,"node_id":"MDk6TWlsZXN0b25lMzM4NTg4OQ==","number":1,"title":"Alpha Release","description":"","creator":{"login":"pelsasser","id":15096737,"node_id":"MDQ6VXNlcjE1MDk2NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/15096737?v=4","gravatar_id":"","url":"https://api.github.com/users/pelsasser","html_url":"https://github.com/pelsasser","followers_url":"https://api.github.com/users/pelsasser/followers","following_url":"https://api.github.com/users/pelsasser/following{/other_user}","gists_url":"https://api.github.com/users/pelsasser/gists{/gist_id}","starred_url":"https://api.github.com/users/pelsasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelsasser/subscriptions","organizations_url":"https://api.github.com/users/pelsasser/orgs","repos_url":"https://api.github.com/users/pelsasser/repos","events_url":"https://api.github.com/users/pelsasser/events{/privacy}","received_events_url":"https://api.github.com/users/pelsasser/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":13,"state":"open","created_at":"2018-05-30T00:23:03Z","updated_at":"2018-06-22T23:13:50Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-06-22T13:16:10Z","updated_at":"2018-06-24T17:44:38Z","closed_at":null,"author_association":"MEMBER","body":"## Before you `start work`\r\n\r\nPlease read our contribution [guidelines](https://docs.marketprotocol.io/#contributing) and if there is a bounty involved  please also see [here](https://docs.marketprotocol.io/#gitcoin-and-bounties)\r\n\r\nIf you have ongoing work from other bounties with us where funding has not been released, please do not pick up a new issue.  We would like to involve as many contributors as possible and parallelize the work flow as much as possible.\r\n\r\nPlease make sure to comment in the issue here immediately after starting work so we know your plans for implementation and a timeline.\r\n\r\nPlease also note that in order for work to be accepted, all code must be accompanied by test cases as well.\r\n\r\n### User Story\r\n\r\nAs a user I need the ability to find the qty of an order that is no longer available. \r\n\r\n### Why Is this Needed?\r\n\r\n*Summary*: Better tracking of order state for order books\r\n\r\n### Description\r\n*Type*: Feature\r\n\r\n\r\n### Solution\r\n[comment]: # (Provide a summary of the solution and a task list on what needs to be fixed.)\r\n*Summary*: Add `getQtyFilledOrCancelledFromOrderAsync` method to Order.ts.  See `getQtyFilledOrCancelledFromOrder` in MarketContract.sol [here](https://github.com/MARKETProtocol/MARKETProtocol/blob/39144c424dfb4f034a53415e1532d492716e8e4a/contracts/MarketContract.sol#L311) for the corresponding solidity call.\r\n\r\n### Definition of Done\r\n\r\n- [ ] Create needed method for `getQtyFilledOrCancelledFromOrderAsync` in Order.ts\r\n- [ ] Add needed functions to Market.ts to allow access to the function call through the main entry point\r\n- [ ] Add testing to cover all code written (this is harder than the implementation itself)\r\n\r\n\r\n#### This task will probably need for whomever picks it up to do a little research into our whitepaper and our [solidity repo](https://github.com/MARKETProtocol/MARKETProtocol) as well. Please only pick this issue up if your willing to put in the work and get the tests running.  We are adding some extra ETH here for the bounty to facilitate the needed research and time spent.  Some experience with TypeScript is helpful, and even more helpful would be experience with 0x or financial markets and orders. \r\n\r\n#### We will accept bounty hunters who explain why the believe they are able to successfully complete this task and a timeline to do so."},"comment":{"url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/comments/399774056","html_url":"https://github.com/MARKETProtocol/MARKET.js/issues/46#issuecomment-399774056","issue_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/46","id":399774056,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTc3NDA1Ng==","user":{"login":"gitcoinbot","id":27903976,"node_id":"MDQ6VXNlcjI3OTAzOTc2","avatar_url":"https://avatars2.githubusercontent.com/u/27903976?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinbot","html_url":"https://github.com/gitcoinbot","followers_url":"https://api.github.com/users/gitcoinbot/followers","following_url":"https://api.github.com/users/gitcoinbot/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinbot/subscriptions","organizations_url":"https://api.github.com/users/gitcoinbot/orgs","repos_url":"https://api.github.com/users/gitcoinbot/repos","events_url":"https://api.github.com/users/gitcoinbot/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-24T17:44:38Z","updated_at":"2018-06-24T17:44:38Z","author_association":"NONE","body":"Issue Status: 1. Open 2. Started 3. **Submitted** 4. Done \n\n<hr>\n\n__Work for 0.35 ETH (152.9 USD @ $436.85/ETH) has been submitted by__:\n\n 1. [@StevenJNPearce](https://gitcoin.co/profile/StevenJNPearce)\n\n\n\n@pelsasser please take a look at the submitted work:\n* [PR](https://github.com/MARKETProtocol/MARKET.js/pull/50) by @StevenJNPearce\n\n<hr>\n\n* Learn more [on the Gitcoin Issue Details page](https://gitcoin.co/issue/MARKETProtocol/MARKET.js/46/682)\n* Questions? Checkout <a href='https://gitcoin.co/help'>Gitcoin Help</a> or the <a href='https://gitcoin.co/slack'>Gitcoin Slack</a>\n$27,383.77 more funded OSS Work available on the [Gitcoin Issue Explorer](https://gitcoin.co/explorer)\n"}}
{"actor":{"display_login":"gitcoinbot"}}