{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/7590","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/7590/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7590/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/7590/events","html_url":"https://github.com/minetest/minetest/issues/7590","id":345405780,"node_id":"MDU6SXNzdWUzNDU0MDU3ODA=","number":7590,"title":"Lua_api.txt: Clarifying 'deprecated' note in entity definition table. Remove legacy code and use of 'initial properties'","user":{"login":"paramat","id":3686677,"node_id":"MDQ6VXNlcjM2ODY2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"labels":[{"id":73369122,"node_id":"MDU6TGFiZWw3MzM2OTEyMg==","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Documentation","name":"@ Documentation","color":"0e8a16","default":false},{"id":91854503,"node_id":"MDU6TGFiZWw5MTg1NDUwMw==","url":"https://api.github.com/repos/minetest/minetest/labels/Maintenance","name":"Maintenance","color":"0e8a16","default":false},{"id":285897422,"node_id":"MDU6TGFiZWwyODU4OTc0MjI=","url":"https://api.github.com/repos/minetest/minetest/labels/Request%20/%20Suggestion","name":"Request / Suggestion","color":"8db4e0","default":false}],"state":"open","locked":false,"assignee":{"login":"paramat","id":3686677,"node_id":"MDQ6VXNlcjM2ODY2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"assignees":[{"login":"paramat","id":3686677,"node_id":"MDQ6VXNlcjM2ODY2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-28T01:25:39Z","updated_at":"2018-07-28T01:55:57Z","closed_at":null,"author_association":"MEMBER","body":"This documentation has always confused me: https://github.com/minetest/minetest/blob/d7d451c647f1fff7983178a9817888f4d0bab695/doc/lua_api.txt#L5283\r\nDoes it refer to 'initial properties' below? My guess is yes because the Lua entity table now directly contains all object properties.\r\n\r\nLooking in code, this deprecation has been in place for 6 years since bdbdeab, since we are moving to 5.0.0 i think we can now remove the legacy code at:\r\nhttps://github.com/minetest/minetest/blob/eef62c82a2e58700fc1216b0b8c03e421bc77995/src/script/cpp_api/s_entity.cpp#L190\r\nSpecifically:\r\nhttps://github.com/minetest/minetest/blob/eef62c82a2e58700fc1216b0b8c03e421bc77995/src/script/cpp_api/s_entity.cpp#L194\r\nIt reads object poperties directly from the entity definition table, then afterwards attempts to read them from 'initial properties' if it exists.\r\n\r\nNote that the 'deprecation' comment seems to be placed wrongly here, surely it should be referring to 'initial properties' as deprecated?"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/408574877","html_url":"https://github.com/minetest/minetest/issues/7590#issuecomment-408574877","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7590","id":408574877,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODU3NDg3Nw==","user":{"login":"paramat","id":3686677,"node_id":"MDQ6VXNlcjM2ODY2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T01:55:57Z","updated_at":"2018-07-28T01:55:57Z","author_association":"MEMBER","body":"My suggestion:\r\nRemove legacy code that supports the use of 'initial properties'.\r\nremove the deprecation comment from docs and clarify that the object properties listed above are to be added to the entity definition table."}}
{"actor":{"display_login":"paramat"}}