{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/189545113","pull_request_review_id":121742706,"id":189545113,"diff_hunk":"@@ -1,4 +1,4 @@\n-// Type definitions for react-navigation 1.5\n+// Type definitions for react-navigation 2.0.1","path":"types/react-navigation/index.d.ts","position":null,"original_position":2,"commit_id":"bc24e50bc1d814d64f05880583cf515b03ca7086","original_commit_id":"ef1a48d2b220485a52437d332f82e6784befae85","user":{"login":"magrinj","id":3551795,"avatar_url":"https://avatars1.githubusercontent.com/u/3551795?v=4","gravatar_id":"","url":"https://api.github.com/users/magrinj","html_url":"https://github.com/magrinj","followers_url":"https://api.github.com/users/magrinj/followers","following_url":"https://api.github.com/users/magrinj/following{/other_user}","gists_url":"https://api.github.com/users/magrinj/gists{/gist_id}","starred_url":"https://api.github.com/users/magrinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magrinj/subscriptions","organizations_url":"https://api.github.com/users/magrinj/orgs","repos_url":"https://api.github.com/users/magrinj/repos","events_url":"https://api.github.com/users/magrinj/events{/privacy}","received_events_url":"https://api.github.com/users/magrinj/received_events","type":"User","site_admin":false},"body":"I made a new push following your documentation, I hope it will be fine :)","created_at":"2018-05-21T09:56:27Z","updated_at":"2018-05-21T09:56:27Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843#discussion_r189545113","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/189545113"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843#discussion_r189545113"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843"}},"in_reply_to_id":189415910},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843","id":188723336,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25843","number":25843,"state":"open","locked":false,"title":"Try to update type definition to new version of react-navigation 2.0.1","user":{"login":"magrinj","id":3551795,"avatar_url":"https://avatars1.githubusercontent.com/u/3551795?v=4","gravatar_id":"","url":"https://api.github.com/users/magrinj","html_url":"https://github.com/magrinj","followers_url":"https://api.github.com/users/magrinj/followers","following_url":"https://api.github.com/users/magrinj/following{/other_user}","gists_url":"https://api.github.com/users/magrinj/gists{/gist_id}","starred_url":"https://api.github.com/users/magrinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magrinj/subscriptions","organizations_url":"https://api.github.com/users/magrinj/orgs","repos_url":"https://api.github.com/users/magrinj/repos","events_url":"https://api.github.com/users/magrinj/events{/privacy}","received_events_url":"https://api.github.com/users/magrinj/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI'm new in type declaration with typescript, so I just try to update the `.d.ts` to the new version of react-navigation, I'm pretty sure it's not enough and I did some mistake, but if that can help... \r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [ ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.","created_at":"2018-05-17T12:40:07Z","updated_at":"2018-05-21T09:56:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8546447751c1366b34b89a1ea1b9af7c01d29153","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":395679059,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false},{"id":57534397,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25843/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/bc24e50bc1d814d64f05880583cf515b03ca7086","head":{"label":"magrinj:master","ref":"master","sha":"bc24e50bc1d814d64f05880583cf515b03ca7086","user":{"login":"magrinj","id":3551795,"avatar_url":"https://avatars1.githubusercontent.com/u/3551795?v=4","gravatar_id":"","url":"https://api.github.com/users/magrinj","html_url":"https://github.com/magrinj","followers_url":"https://api.github.com/users/magrinj/followers","following_url":"https://api.github.com/users/magrinj/following{/other_user}","gists_url":"https://api.github.com/users/magrinj/gists{/gist_id}","starred_url":"https://api.github.com/users/magrinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magrinj/subscriptions","organizations_url":"https://api.github.com/users/magrinj/orgs","repos_url":"https://api.github.com/users/magrinj/repos","events_url":"https://api.github.com/users/magrinj/events{/privacy}","received_events_url":"https://api.github.com/users/magrinj/received_events","type":"User","site_admin":false},"repo":{"id":133808474,"name":"DefinitelyTyped","full_name":"magrinj/DefinitelyTyped","owner":{"login":"magrinj","id":3551795,"avatar_url":"https://avatars1.githubusercontent.com/u/3551795?v=4","gravatar_id":"","url":"https://api.github.com/users/magrinj","html_url":"https://github.com/magrinj","followers_url":"https://api.github.com/users/magrinj/followers","following_url":"https://api.github.com/users/magrinj/following{/other_user}","gists_url":"https://api.github.com/users/magrinj/gists{/gist_id}","starred_url":"https://api.github.com/users/magrinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magrinj/subscriptions","organizations_url":"https://api.github.com/users/magrinj/orgs","repos_url":"https://api.github.com/users/magrinj/repos","events_url":"https://api.github.com/users/magrinj/events{/privacy}","received_events_url":"https://api.github.com/users/magrinj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magrinj/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/magrinj/DefinitelyTyped","forks_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/magrinj/DefinitelyTyped/deployments","created_at":"2018-05-17T12:12:55Z","updated_at":"2018-05-21T09:53:59Z","pushed_at":"2018-05-21T09:53:42Z","git_url":"git://github.com/magrinj/DefinitelyTyped.git","ssh_url":"git@github.com:magrinj/DefinitelyTyped.git","clone_url":"https://github.com/magrinj/DefinitelyTyped.git","svn_url":"https://github.com/magrinj/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":315854,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"131650c616402fd8227098129d5fcacf9e4d15f4","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-05-21T07:56:38Z","pushed_at":"2018-05-21T09:53:55Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":317456,"stargazers_count":15592,"watchers_count":15592,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13023,"mirror_url":null,"archived":false,"open_issues_count":2169,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13023,"open_issues":2169,"watchers":15592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25843"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25843"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25843/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25843/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/bc24e50bc1d814d64f05880583cf515b03ca7086"}},"author_association":"NONE"}}
{"actor":{"display_login":"magrinj"}}