{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/806","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/806/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/806/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/806/events","html_url":"https://github.com/StrikeNP/trac_test/issues/806","id":334665367,"node_id":"MDU6SXNzdWUzMzQ2NjUzNjc=","number":806,"title":"Add within-Gaussian correlations involving w to PDF closure. (Trac #806)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":971577014,"node_id":"MDU6TGFiZWw5NzE1NzcwMTQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":971577865,"node_id":"MDU6TGFiZWw5NzE1Nzc4NjU=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/bmg2@uwm.edu","name":"bmg2@uwm.edu","color":"FFFFFF","default":false},{"id":971577274,"node_id":"MDU6TGFiZWw5NzE1NzcyNzQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":971577163,"node_id":"MDU6TGFiZWw5NzE1NzcxNjM=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/task","name":"task","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/26","html_url":"https://github.com/StrikeNP/trac_test/milestone/26","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/26/labels","id":3443175,"node_id":"MDk6TWlsZXN0b25lMzQ0MzE3NQ==","number":26,"title":"Create and implement a new trivariate analytic double Gaussian PDF in CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-06-21T21:28:15Z","updated_at":"2018-06-21T21:32:00Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-06-21T21:30:51Z","updated_at":"2018-06-24T13:35:06Z","closed_at":null,"author_association":"OWNER","body":"The new PDF will allow for within-component correlations involving w (the correlation of w and rt and the correlation of w and theta-l).  We should add these correlations to the code now and set them to 0 (since ADG1 requires them to have a value of 0).\n\nThe correlation of rt and theta-l is already found within the PDF closure.  It is currently denoted ```rrtthl```.  We should rename this variable ```corr_rt_thl``` within CLUBB and in any host models where necessary.  We should name the new correlations ```corr_w_rt``` and ```corr_w_thl```.\n\nWe could even go a step farther and name them ```corr_w_rt_1```, ```corr_w_rt_2```, ```corr_w_thl_1```, ```corr_w_thl_2```, ```corr_rt_thl_1```, and ```corr_rt_thl_2```.  This would be consistent with the code in other parts of CLUBB.  However, ```corr_rt_thl_1 = corr_rt_thl_2```, etc.\n\nAttachments:\n\n[plot_explicit_ta_configs.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_explicit_ta_configs.maff)\n[plot_new_pdf_config_1_plot_2.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_config_1_plot_2.maff)\n[plot_combo_pdf_run_3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_combo_pdf_run_3.maff)\n[plot_input_fields_rtp3_thlp3_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_input_fields_rtp3_thlp3_1.maff)\n[plot_new_pdf_20180522_test_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_20180522_test_1.maff)\n[plot_attempts_8_10.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempts_8_10.maff)\n[plot_attempt_8_only.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempt_8_only.maff)\n[plot_beta_1p3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3.maff)\n[plot_beta_1p3_all.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3_all.maff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/806\n```json\n{\n    \"status\": \"new\", \n    \"changetime\": \"2018-05-08T19:56:18\", \n    \"description\": \"The new PDF will allow for within-component correlations involving w (the correlation of w and rt and the correlation of w and theta-l).  We should add these correlations to the code now and set them to 0 (since ADG1 requires them to have a value of 0).\\n\\nThe correlation of rt and theta-l is already found within the PDF closure.  It is currently denoted {{{rrtthl}}}.  We should rename this variable {{{corr_rt_thl}}} within CLUBB and in any host models where necessary.  We should name the new correlations {{{corr_w_rt}}} and {{{corr_w_thl}}}.\\n\\nWe could even go a step farther and name them {{{corr_w_rt_1}}}, {{{corr_w_rt_2}}}, {{{corr_w_thl_1}}}, {{{corr_w_thl_2}}}, {{{corr_rt_thl_1}}}, and {{{corr_rt_thl_2}}}.  This would be consistent with the code in other parts of CLUBB.  However, {{{corr_rt_thl_1 = corr_rt_thl_2}}}, etc.\", \n    \"reporter\": \"bmg2@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, huebler@uwm.edu\", \n    \"resolution\": \"\", \n    \"_ts\": \"1525809378190507\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Add within-Gaussian correlations involving w to PDF closure.\", \n    \"priority\": \"major\", \n    \"keywords\": \"correlations, PDF closure\", \n    \"time\": \"2017-07-13T19:07:52\", \n    \"milestone\": \"Create and implement a new trivariate analytic double Gaussian PDF in CLUBB\", \n    \"owner\": \"bmg2@uwm.edu\", \n    \"type\": \"task\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/399757197","html_url":"https://github.com/StrikeNP/trac_test/issues/806#issuecomment-399757197","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/806","id":399757197,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTc1NzE5Nw==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-24T13:35:06Z","updated_at":"2018-06-24T13:35:06Z","author_association":"OWNER","body":"**Trac update on 2017/08/02 at 21:26**\n**bmg2@uwm.edu commented:**\n\nCommit comment from clubb:r8412:\n\nI am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type\npdf_parameter.\n\nThe results in GrADS output files from this revision are an exact match to the\nresults in GrADS output files from the previous revision for all cases.\n\nCLUBB Trac ticket reference: https://github.com/larson-group/clubb/issues/806.\n\n\n\n"}}
{"actor":{"display_login":"StrikeNP"}}