{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/huntc/landlord/pulls/49","id":193233455,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjMzNDU1","html_url":"https://github.com/huntc/landlord/pull/49","diff_url":"https://github.com/huntc/landlord/pull/49.diff","patch_url":"https://github.com/huntc/landlord/pull/49.patch","issue_url":"https://api.github.com/repos/huntc/landlord/issues/49","number":49,"state":"closed","locked":false,"title":"A process was not shutdown upon losing a connection","user":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Due to a more recent change, the process was not being shut down upon having lost its client connection. If a client shuts down ungracefully then the process would continue to run. This commit re-instates the issuing of a SIGINT signal upon the client connection having been lost.\r\n\r\nStopping has also been improved such that checks for unrelinquished resources are always made, whether stopping via a signal or not.\r\n\r\nAnother big one was waiting for termination. We must wait for threads to terminate before removing the class loader in particular. Prior to my change here, the shutdown of a process could suddenly have its class loader removed from underneath it. Not pretty!\r\n\r\nLastly, some strengthening of best-effort actions i.e. attempting to invoke a trap handler and signalling EOT.","created_at":"2018-06-07T07:56:30Z","updated_at":"2018-06-08T00:10:33Z","closed_at":"2018-06-08T00:10:33Z","merged_at":"2018-06-08T00:10:33Z","merge_commit_sha":"2c2e55b41eb79a89f6a18f1e0d6793de77873483","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/huntc/landlord/pulls/49/commits","review_comments_url":"https://api.github.com/repos/huntc/landlord/pulls/49/comments","review_comment_url":"https://api.github.com/repos/huntc/landlord/pulls/comments{/number}","comments_url":"https://api.github.com/repos/huntc/landlord/issues/49/comments","statuses_url":"https://api.github.com/repos/huntc/landlord/statuses/9daec1cafc9f8c58983d51496d1af94b562415d3","head":{"label":"huntc:auto-shutdown","ref":"auto-shutdown","sha":"9daec1cafc9f8c58983d51496d1af94b562415d3","user":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"repo":{"id":97435542,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQzNTU0Mg==","name":"landlord","full_name":"huntc/landlord","owner":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huntc/landlord","description":"Provides the ability to run multiple JVM based applications on the one JVM","fork":false,"url":"https://api.github.com/repos/huntc/landlord","forks_url":"https://api.github.com/repos/huntc/landlord/forks","keys_url":"https://api.github.com/repos/huntc/landlord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huntc/landlord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huntc/landlord/teams","hooks_url":"https://api.github.com/repos/huntc/landlord/hooks","issue_events_url":"https://api.github.com/repos/huntc/landlord/issues/events{/number}","events_url":"https://api.github.com/repos/huntc/landlord/events","assignees_url":"https://api.github.com/repos/huntc/landlord/assignees{/user}","branches_url":"https://api.github.com/repos/huntc/landlord/branches{/branch}","tags_url":"https://api.github.com/repos/huntc/landlord/tags","blobs_url":"https://api.github.com/repos/huntc/landlord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huntc/landlord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huntc/landlord/git/refs{/sha}","trees_url":"https://api.github.com/repos/huntc/landlord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huntc/landlord/statuses/{sha}","languages_url":"https://api.github.com/repos/huntc/landlord/languages","stargazers_url":"https://api.github.com/repos/huntc/landlord/stargazers","contributors_url":"https://api.github.com/repos/huntc/landlord/contributors","subscribers_url":"https://api.github.com/repos/huntc/landlord/subscribers","subscription_url":"https://api.github.com/repos/huntc/landlord/subscription","commits_url":"https://api.github.com/repos/huntc/landlord/commits{/sha}","git_commits_url":"https://api.github.com/repos/huntc/landlord/git/commits{/sha}","comments_url":"https://api.github.com/repos/huntc/landlord/comments{/number}","issue_comment_url":"https://api.github.com/repos/huntc/landlord/issues/comments{/number}","contents_url":"https://api.github.com/repos/huntc/landlord/contents/{+path}","compare_url":"https://api.github.com/repos/huntc/landlord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huntc/landlord/merges","archive_url":"https://api.github.com/repos/huntc/landlord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huntc/landlord/downloads","issues_url":"https://api.github.com/repos/huntc/landlord/issues{/number}","pulls_url":"https://api.github.com/repos/huntc/landlord/pulls{/number}","milestones_url":"https://api.github.com/repos/huntc/landlord/milestones{/number}","notifications_url":"https://api.github.com/repos/huntc/landlord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huntc/landlord/labels{/name}","releases_url":"https://api.github.com/repos/huntc/landlord/releases{/id}","deployments_url":"https://api.github.com/repos/huntc/landlord/deployments","created_at":"2017-07-17T04:34:22Z","updated_at":"2018-06-07T23:15:38Z","pushed_at":"2018-06-08T00:10:32Z","git_url":"git://github.com/huntc/landlord.git","ssh_url":"git@github.com:huntc/landlord.git","clone_url":"https://github.com/huntc/landlord.git","svn_url":"https://github.com/huntc/landlord","homepage":null,"size":190,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":8,"watchers":17,"default_branch":"master"}},"base":{"label":"huntc:master","ref":"master","sha":"9e3fad25f1f58062ca979f29ab3b8fb14e137927","user":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"repo":{"id":97435542,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQzNTU0Mg==","name":"landlord","full_name":"huntc/landlord","owner":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huntc/landlord","description":"Provides the ability to run multiple JVM based applications on the one JVM","fork":false,"url":"https://api.github.com/repos/huntc/landlord","forks_url":"https://api.github.com/repos/huntc/landlord/forks","keys_url":"https://api.github.com/repos/huntc/landlord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huntc/landlord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huntc/landlord/teams","hooks_url":"https://api.github.com/repos/huntc/landlord/hooks","issue_events_url":"https://api.github.com/repos/huntc/landlord/issues/events{/number}","events_url":"https://api.github.com/repos/huntc/landlord/events","assignees_url":"https://api.github.com/repos/huntc/landlord/assignees{/user}","branches_url":"https://api.github.com/repos/huntc/landlord/branches{/branch}","tags_url":"https://api.github.com/repos/huntc/landlord/tags","blobs_url":"https://api.github.com/repos/huntc/landlord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huntc/landlord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huntc/landlord/git/refs{/sha}","trees_url":"https://api.github.com/repos/huntc/landlord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huntc/landlord/statuses/{sha}","languages_url":"https://api.github.com/repos/huntc/landlord/languages","stargazers_url":"https://api.github.com/repos/huntc/landlord/stargazers","contributors_url":"https://api.github.com/repos/huntc/landlord/contributors","subscribers_url":"https://api.github.com/repos/huntc/landlord/subscribers","subscription_url":"https://api.github.com/repos/huntc/landlord/subscription","commits_url":"https://api.github.com/repos/huntc/landlord/commits{/sha}","git_commits_url":"https://api.github.com/repos/huntc/landlord/git/commits{/sha}","comments_url":"https://api.github.com/repos/huntc/landlord/comments{/number}","issue_comment_url":"https://api.github.com/repos/huntc/landlord/issues/comments{/number}","contents_url":"https://api.github.com/repos/huntc/landlord/contents/{+path}","compare_url":"https://api.github.com/repos/huntc/landlord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huntc/landlord/merges","archive_url":"https://api.github.com/repos/huntc/landlord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huntc/landlord/downloads","issues_url":"https://api.github.com/repos/huntc/landlord/issues{/number}","pulls_url":"https://api.github.com/repos/huntc/landlord/pulls{/number}","milestones_url":"https://api.github.com/repos/huntc/landlord/milestones{/number}","notifications_url":"https://api.github.com/repos/huntc/landlord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huntc/landlord/labels{/name}","releases_url":"https://api.github.com/repos/huntc/landlord/releases{/id}","deployments_url":"https://api.github.com/repos/huntc/landlord/deployments","created_at":"2017-07-17T04:34:22Z","updated_at":"2018-06-07T23:15:38Z","pushed_at":"2018-06-08T00:10:32Z","git_url":"git://github.com/huntc/landlord.git","ssh_url":"git@github.com:huntc/landlord.git","clone_url":"https://github.com/huntc/landlord.git","svn_url":"https://github.com/huntc/landlord","homepage":null,"size":190,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":8,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/huntc/landlord/pulls/49"},"html":{"href":"https://github.com/huntc/landlord/pull/49"},"issue":{"href":"https://api.github.com/repos/huntc/landlord/issues/49"},"comments":{"href":"https://api.github.com/repos/huntc/landlord/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/huntc/landlord/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/huntc/landlord/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/huntc/landlord/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/huntc/landlord/statuses/9daec1cafc9f8c58983d51496d1af94b562415d3"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"huntc","id":694893,"node_id":"MDQ6VXNlcjY5NDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/694893?v=4","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"comments":2,"review_comments":11,"maintainer_can_modify":false,"commits":5,"additions":88,"deletions":49,"changed_files":4}}
{"actor":{"display_login":"huntc"}}