{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/comments/173494454","pull_request_review_id":102694913,"id":173494454,"diff_hunk":"@@ -173,10 +175,10 @@ describeApplication('CustomerResourceCustomCoverage', () => {\n \n       describe('entering an invalid date range', () => {\n         beforeEach(() => {\n-          return convergeOn(() => {\n-            expect(CustomerResourceCoverage.dateRangeRowList[0].$beginCoverageField).to.exist;\n-            expect(CustomerResourceCoverage.dateRangeRowList[0].$endCoverageField).to.exist;\n-          });\n+          return new Convergence()\n+            .once(() => expect(CustomerResourceCoverage.dateRangeRowList[0].$beginCoverageField).to.exist)\n+            .once(() => expect(CustomerResourceCoverage.dateRangeRowList[0].$endCoverageField).to.exist)","path":"tests/customer-resource-custom-coverage-test.js","position":66,"original_position":66,"commit_id":"478a3e653fafedc14a6759ccc7755ac3fb938b53","original_commit_id":"478a3e653fafedc14a6759ccc7755ac3fb938b53","user":{"login":"wwilsman","id":5005153,"avatar_url":"https://avatars2.githubusercontent.com/u/5005153?v=4","gravatar_id":"","url":"https://api.github.com/users/wwilsman","html_url":"https://github.com/wwilsman","followers_url":"https://api.github.com/users/wwilsman/followers","following_url":"https://api.github.com/users/wwilsman/following{/other_user}","gists_url":"https://api.github.com/users/wwilsman/gists{/gist_id}","starred_url":"https://api.github.com/users/wwilsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwilsman/subscriptions","organizations_url":"https://api.github.com/users/wwilsman/orgs","repos_url":"https://api.github.com/users/wwilsman/repos","events_url":"https://api.github.com/users/wwilsman/events{/privacy}","received_events_url":"https://api.github.com/users/wwilsman/received_events","type":"User","site_admin":false},"body":"Instead of `.once().once()` we can just lump these expectations into a single `.once()`","created_at":"2018-03-09T16:14:24Z","updated_at":"2018-03-09T16:18:11Z","html_url":"https://github.com/folio-org/ui-eholdings/pull/268#discussion_r173494454","pull_request_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/comments/173494454"},"html":{"href":"https://github.com/folio-org/ui-eholdings/pull/268#discussion_r173494454"},"pull_request":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268","id":174005911,"html_url":"https://github.com/folio-org/ui-eholdings/pull/268","diff_url":"https://github.com/folio-org/ui-eholdings/pull/268.diff","patch_url":"https://github.com/folio-org/ui-eholdings/pull/268.patch","issue_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/268","number":268,"state":"open","locked":false,"title":" Replace uses of convergeOn()","user":{"login":"cherewaty","id":230597,"avatar_url":"https://avatars0.githubusercontent.com/u/230597?v=4","gravatar_id":"","url":"https://api.github.com/users/cherewaty","html_url":"https://github.com/cherewaty","followers_url":"https://api.github.com/users/cherewaty/followers","following_url":"https://api.github.com/users/cherewaty/following{/other_user}","gists_url":"https://api.github.com/users/cherewaty/gists{/gist_id}","starred_url":"https://api.github.com/users/cherewaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherewaty/subscriptions","organizations_url":"https://api.github.com/users/cherewaty/orgs","repos_url":"https://api.github.com/users/cherewaty/repos","events_url":"https://api.github.com/users/cherewaty/events{/privacy}","received_events_url":"https://api.github.com/users/cherewaty/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n`convergeOn()` is an [intimate API](https://github.com/thefrontside/bigtest/tree/master/packages/convergence#advanced) of bigtest/convergence. We should instead be creating `Convergence` objects.\r\n\r\n## Next Steps\r\n- Using BigTest page objects makes most of this refactor irrelevant. Very few of these direct uses of `Convergence` will need to remain.\r\n- I skipped a couple of failing assertions re: custom embargo editing. I'll revisit those when refactoring that test to use BigTest page objects.\r\n\r\n## Learning\r\nMore on bigtest/convergence: https://github.com/thefrontside/bigtest/tree/master/packages/convergence\r\n","created_at":"2018-03-09T13:33:01Z","updated_at":"2018-03-09T16:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fb8246c814339ad0f1d015b0edf8f564f665fea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268/commits","review_comments_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268/comments","review_comment_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/268/comments","statuses_url":"https://api.github.com/repos/folio-org/ui-eholdings/statuses/478a3e653fafedc14a6759ccc7755ac3fb938b53","head":{"label":"folio-org:jc/converge-on","ref":"jc/converge-on","sha":"478a3e653fafedc14a6759ccc7755ac3fb938b53","user":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":96354162,"name":"ui-eholdings","full_name":"folio-org/ui-eholdings","owner":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/ui-eholdings","description":"FOLIO eholdings App","fork":false,"url":"https://api.github.com/repos/folio-org/ui-eholdings","forks_url":"https://api.github.com/repos/folio-org/ui-eholdings/forks","keys_url":"https://api.github.com/repos/folio-org/ui-eholdings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/ui-eholdings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/ui-eholdings/teams","hooks_url":"https://api.github.com/repos/folio-org/ui-eholdings/hooks","issue_events_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/ui-eholdings/events","assignees_url":"https://api.github.com/repos/folio-org/ui-eholdings/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/ui-eholdings/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/ui-eholdings/tags","blobs_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/ui-eholdings/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/ui-eholdings/languages","stargazers_url":"https://api.github.com/repos/folio-org/ui-eholdings/stargazers","contributors_url":"https://api.github.com/repos/folio-org/ui-eholdings/contributors","subscribers_url":"https://api.github.com/repos/folio-org/ui-eholdings/subscribers","subscription_url":"https://api.github.com/repos/folio-org/ui-eholdings/subscription","commits_url":"https://api.github.com/repos/folio-org/ui-eholdings/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/ui-eholdings/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/ui-eholdings/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/ui-eholdings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/ui-eholdings/merges","archive_url":"https://api.github.com/repos/folio-org/ui-eholdings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/ui-eholdings/downloads","issues_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/ui-eholdings/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/ui-eholdings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/ui-eholdings/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/ui-eholdings/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/ui-eholdings/deployments","created_at":"2017-07-05T19:28:47Z","updated_at":"2018-02-24T02:01:40Z","pushed_at":"2018-03-09T13:33:01Z","git_url":"git://github.com/folio-org/ui-eholdings.git","ssh_url":"git@github.com:folio-org/ui-eholdings.git","clone_url":"https://github.com/folio-org/ui-eholdings.git","svn_url":"https://github.com/folio-org/ui-eholdings","homepage":"https://folio.frontside.io","size":1895,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"c31f8e05c9ffe303b142ee065eef22692d7243de","user":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":96354162,"name":"ui-eholdings","full_name":"folio-org/ui-eholdings","owner":{"login":"folio-org","id":16495055,"avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/ui-eholdings","description":"FOLIO eholdings App","fork":false,"url":"https://api.github.com/repos/folio-org/ui-eholdings","forks_url":"https://api.github.com/repos/folio-org/ui-eholdings/forks","keys_url":"https://api.github.com/repos/folio-org/ui-eholdings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/ui-eholdings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/ui-eholdings/teams","hooks_url":"https://api.github.com/repos/folio-org/ui-eholdings/hooks","issue_events_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/ui-eholdings/events","assignees_url":"https://api.github.com/repos/folio-org/ui-eholdings/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/ui-eholdings/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/ui-eholdings/tags","blobs_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/ui-eholdings/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/ui-eholdings/languages","stargazers_url":"https://api.github.com/repos/folio-org/ui-eholdings/stargazers","contributors_url":"https://api.github.com/repos/folio-org/ui-eholdings/contributors","subscribers_url":"https://api.github.com/repos/folio-org/ui-eholdings/subscribers","subscription_url":"https://api.github.com/repos/folio-org/ui-eholdings/subscription","commits_url":"https://api.github.com/repos/folio-org/ui-eholdings/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/ui-eholdings/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/ui-eholdings/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/ui-eholdings/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/ui-eholdings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/ui-eholdings/merges","archive_url":"https://api.github.com/repos/folio-org/ui-eholdings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/ui-eholdings/downloads","issues_url":"https://api.github.com/repos/folio-org/ui-eholdings/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/ui-eholdings/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/ui-eholdings/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/ui-eholdings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/ui-eholdings/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/ui-eholdings/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/ui-eholdings/deployments","created_at":"2017-07-05T19:28:47Z","updated_at":"2018-02-24T02:01:40Z","pushed_at":"2018-03-09T13:33:01Z","git_url":"git://github.com/folio-org/ui-eholdings.git","ssh_url":"git@github.com:folio-org/ui-eholdings.git","clone_url":"https://github.com/folio-org/ui-eholdings.git","svn_url":"https://github.com/folio-org/ui-eholdings","homepage":"https://folio.frontside.io","size":1895,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268"},"html":{"href":"https://github.com/folio-org/ui-eholdings/pull/268"},"issue":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/issues/268"},"comments":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/ui-eholdings/statuses/478a3e653fafedc14a6759ccc7755ac3fb938b53"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wwilsman"}}