{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/210825902","pull_request_review_id":147122628,"id":210825902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDgyNTkwMg==","diff_hunk":"@@ -1429,3 +1429,94 @@ IGCToCLREventSink* GCToEEInterface::EventSink()\n \n     return &g_gcToClrEventSink;\n }\n+\n+bool GCToEEInterface::CanEnableGCNumaAware()\n+{\n+    LIMITED_METHOD_CONTRACT;\n+\n+    return NumaNodeInfo::CanEnableGCNumaAware();\n+}\n+\n+bool GCToEEInterface::GetNumaProcessorNodeEx(PPROCESSOR_NUMBER proc_no, uint16_t *node_no)\n+{\n+    LIMITED_METHOD_CONTRACT;\n+\n+    return NumaNodeInfo::GetNumaProcessorNodeEx(proc_no, node_no);\n+}\n+\n+void* GCToEEInterface::VirtualAllocExNuma(void *lpAddr, size_t dwSize, uint32_t allocType, uint32_t prot, uint32_t node)\n+{\n+    LIMITED_METHOD_CONTRACT;\n+\n+    return NumaNodeInfo::VirtualAllocExNuma(GetCurrentProcess(), lpAddr, dwSize, allocType, prot, node);","path":"src/vm/gcenv.ee.cpp","position":32,"original_position":32,"commit_id":"67b7fc6829cdef6d01698080eb5e2421db910524","original_commit_id":"67b7fc6829cdef6d01698080eb5e2421db910524","user":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"That's why I've suggested that this method should go to the GCToOSInterface too.","created_at":"2018-08-17T07:29:33Z","updated_at":"2018-08-17T07:29:33Z","html_url":"https://github.com/dotnet/coreclr/pull/19500#discussion_r210825902","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19500","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/210825902"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19500#discussion_r210825902"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19500"}},"in_reply_to_id":210804205},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19500","id":208499137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDk5MTM3","html_url":"https://github.com/dotnet/coreclr/pull/19500","diff_url":"https://github.com/dotnet/coreclr/pull/19500.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19500.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19500","number":19500,"state":"open","locked":false,"title":"Remove NumaNodeInfo, CPUGroupInfo, AppDomain, SystemDomain, and EEConfig stubs from local gc","user":{"login":"davmason","id":12141819,"node_id":"MDQ6VXNlcjEyMTQxODE5","avatar_url":"https://avatars1.githubusercontent.com/u/12141819?v=4","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"body":"Everything except EEConfig is moved to the interface. EEConfig is only used for STRESS_HEAP which is disabled for local gc, so my plan is to delete EEConfig for now and fix it at the same time as STRESS_HEAP.","created_at":"2018-08-15T08:14:24Z","updated_at":"2018-08-17T07:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d95aeaab58b98260f021909969a019ad932d1598","assignee":{"login":"davmason","id":12141819,"node_id":"MDQ6VXNlcjEyMTQxODE5","avatar_url":"https://avatars1.githubusercontent.com/u/12141819?v=4","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"assignees":[{"login":"davmason","id":12141819,"node_id":"MDQ6VXNlcjEyMTQxODE5","avatar_url":"https://avatars1.githubusercontent.com/u/12141819?v=4","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Maoni0","id":10837357,"node_id":"MDQ6VXNlcjEwODM3MzU3","avatar_url":"https://avatars1.githubusercontent.com/u/10837357?v=4","gravatar_id":"","url":"https://api.github.com/users/Maoni0","html_url":"https://github.com/Maoni0","followers_url":"https://api.github.com/users/Maoni0/followers","following_url":"https://api.github.com/users/Maoni0/following{/other_user}","gists_url":"https://api.github.com/users/Maoni0/gists{/gist_id}","starred_url":"https://api.github.com/users/Maoni0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maoni0/subscriptions","organizations_url":"https://api.github.com/users/Maoni0/orgs","repos_url":"https://api.github.com/users/Maoni0/repos","events_url":"https://api.github.com/users/Maoni0/events{/privacy}","received_events_url":"https://api.github.com/users/Maoni0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196940648,"node_id":"MDU6TGFiZWwxOTY5NDA2NDg=","url":"https://api.github.com/repos/dotnet/coreclr/labels/area-GC","name":"area-GC","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19500/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19500/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19500/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/67b7fc6829cdef6d01698080eb5e2421db910524","head":{"label":"davmason:numa","ref":"numa","sha":"67b7fc6829cdef6d01698080eb5e2421db910524","user":{"login":"davmason","id":12141819,"node_id":"MDQ6VXNlcjEyMTQxODE5","avatar_url":"https://avatars1.githubusercontent.com/u/12141819?v=4","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"repo":{"id":110173349,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxNzMzNDk=","name":"coreclr","full_name":"davmason/coreclr","owner":{"login":"davmason","id":12141819,"node_id":"MDQ6VXNlcjEyMTQxODE5","avatar_url":"https://avatars1.githubusercontent.com/u/12141819?v=4","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davmason/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/davmason/coreclr","forks_url":"https://api.github.com/repos/davmason/coreclr/forks","keys_url":"https://api.github.com/repos/davmason/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davmason/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davmason/coreclr/teams","hooks_url":"https://api.github.com/repos/davmason/coreclr/hooks","issue_events_url":"https://api.github.com/repos/davmason/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/davmason/coreclr/events","assignees_url":"https://api.github.com/repos/davmason/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/davmason/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/davmason/coreclr/tags","blobs_url":"https://api.github.com/repos/davmason/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davmason/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davmason/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/davmason/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davmason/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/davmason/coreclr/languages","stargazers_url":"https://api.github.com/repos/davmason/coreclr/stargazers","contributors_url":"https://api.github.com/repos/davmason/coreclr/contributors","subscribers_url":"https://api.github.com/repos/davmason/coreclr/subscribers","subscription_url":"https://api.github.com/repos/davmason/coreclr/subscription","commits_url":"https://api.github.com/repos/davmason/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/davmason/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/davmason/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/davmason/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/davmason/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/davmason/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davmason/coreclr/merges","archive_url":"https://api.github.com/repos/davmason/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davmason/coreclr/downloads","issues_url":"https://api.github.com/repos/davmason/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/davmason/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/davmason/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/davmason/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davmason/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/davmason/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/davmason/coreclr/deployments","created_at":"2017-11-09T22:28:04Z","updated_at":"2018-08-14T20:02:50Z","pushed_at":"2018-08-17T03:45:47Z","git_url":"git://github.com/davmason/coreclr.git","ssh_url":"git@github.com:davmason/coreclr.git","clone_url":"https://github.com/davmason/coreclr.git","svn_url":"https://github.com/davmason/coreclr","homepage":"https://github.com/dotnet/core","size":235661,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3b6210ecb565847dc5e6b5bb01a97e9b09f56a15","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-08-17T07:18:53Z","pushed_at":"2018-08-17T04:59:13Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":236666,"stargazers_count":9748,"watchers_count":9748,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2404,"mirror_url":null,"archived":false,"open_issues_count":1777,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2404,"open_issues":1777,"watchers":9748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19500"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19500"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19500"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19500/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19500/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19500/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/67b7fc6829cdef6d01698080eb5e2421db910524"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"janvorli"}}