{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/232630640","pull_request_review_id":173867094,"id":232630640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjYzMDY0MA==","diff_hunk":"@@ -438,6 +440,59 @@ func SmallCloudConfigS3URL(customObject v1alpha1.AWSConfig, accountID string, ro\n \treturn fmt.Sprintf(\"s3://%s\", SmallCloudConfigPath(customObject, accountID, role))\n }\n \n+// SubnetID generates Crockford Base32 (http://www.crockford.com/wrmg/base32.html)\n+// encoded representation of subnet CIDR to be used as a shared identifier for\n+// specific network e.g. in CloudFormation template resource names.\n+func SubnetID(cidr string) (string, error) {","path":"service/controller/v19/key/key.go","position":23,"original_position":23,"commit_id":"b61728bea9fc61297558e1fe2aaf62fa3e95774e","original_commit_id":"b61728bea9fc61297558e1fe2aaf62fa3e95774e","user":{"login":"tuommaki","id":1947505,"node_id":"MDQ6VXNlcjE5NDc1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1947505?v=4","gravatar_id":"","url":"https://api.github.com/users/tuommaki","html_url":"https://github.com/tuommaki","followers_url":"https://api.github.com/users/tuommaki/followers","following_url":"https://api.github.com/users/tuommaki/following{/other_user}","gists_url":"https://api.github.com/users/tuommaki/gists{/gist_id}","starred_url":"https://api.github.com/users/tuommaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuommaki/subscriptions","organizations_url":"https://api.github.com/users/tuommaki/orgs","repos_url":"https://api.github.com/users/tuommaki/repos","events_url":"https://api.github.com/users/tuommaki/events{/privacy}","received_events_url":"https://api.github.com/users/tuommaki/received_events","type":"User","site_admin":false},"body":"I considered `base58` but this made me turn towards base32:\r\n> In contrast to Base64, the digits of the encoding do not line up well with byte boundaries of the original data. For this reason, the method is well-suited to encode large integers, but not designed to encode longer portions of binary data.","created_at":"2018-11-12T11:57:24Z","updated_at":"2018-11-12T11:57:24Z","html_url":"https://github.com/giantswarm/aws-operator/pull/1268#discussion_r232630640","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/232630640"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/1268#discussion_r232630640"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268"}},"in_reply_to_id":232611757},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268","id":230089947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDg5OTQ3","html_url":"https://github.com/giantswarm/aws-operator/pull/1268","diff_url":"https://github.com/giantswarm/aws-operator/pull/1268.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/1268.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/1268","number":1268,"state":"open","locked":false,"title":"Add Subnet ID generator for CloudFormation template","user":{"login":"tuommaki","id":1947505,"node_id":"MDQ6VXNlcjE5NDc1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1947505?v=4","gravatar_id":"","url":"https://api.github.com/users/tuommaki","html_url":"https://github.com/tuommaki","followers_url":"https://api.github.com/users/tuommaki/followers","following_url":"https://api.github.com/users/tuommaki/following{/other_user}","gists_url":"https://api.github.com/users/tuommaki/gists{/gist_id}","starred_url":"https://api.github.com/users/tuommaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuommaki/subscriptions","organizations_url":"https://api.github.com/users/tuommaki/orgs","repos_url":"https://api.github.com/users/tuommaki/repos","events_url":"https://api.github.com/users/tuommaki/events{/privacy}","received_events_url":"https://api.github.com/users/tuommaki/received_events","type":"User","site_admin":false},"body":"When generated multiple subnets separated from routing tables with a\r\nneed to refer to specific subnet's routing table and other way round,\r\nthere must be consistent way to identify specific subnet. This change\r\nproposes use of Crockfords Base32 encoding over subnet network IP + mask\r\nto be used as such.\r\n\r\nThere are several encoding algorithms available that could be used for\r\nthis, but Crockfords Base32 felt suitable for following reasons:\r\n\r\n  - It produces human and machine interpretable string.\r\n  - It avoids non-alphanumeric characters.\r\n  - It is relatively compact.\r\n    - IPv4 IP+Mask produces 12 character string.","created_at":"2018-11-12T10:44:27Z","updated_at":"2018-11-12T11:57:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b36b8f84eb63b2e8390d5a7b13e2f14d331d966d","assignee":{"login":"tuommaki","id":1947505,"node_id":"MDQ6VXNlcjE5NDc1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1947505?v=4","gravatar_id":"","url":"https://api.github.com/users/tuommaki","html_url":"https://github.com/tuommaki","followers_url":"https://api.github.com/users/tuommaki/followers","following_url":"https://api.github.com/users/tuommaki/following{/other_user}","gists_url":"https://api.github.com/users/tuommaki/gists{/gist_id}","starred_url":"https://api.github.com/users/tuommaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuommaki/subscriptions","organizations_url":"https://api.github.com/users/tuommaki/orgs","repos_url":"https://api.github.com/users/tuommaki/repos","events_url":"https://api.github.com/users/tuommaki/events{/privacy}","received_events_url":"https://api.github.com/users/tuommaki/received_events","type":"User","site_admin":false},"assignees":[{"login":"tuommaki","id":1947505,"node_id":"MDQ6VXNlcjE5NDc1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1947505?v=4","gravatar_id":"","url":"https://api.github.com/users/tuommaki","html_url":"https://github.com/tuommaki","followers_url":"https://api.github.com/users/tuommaki/followers","following_url":"https://api.github.com/users/tuommaki/following{/other_user}","gists_url":"https://api.github.com/users/tuommaki/gists{/gist_id}","starred_url":"https://api.github.com/users/tuommaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuommaki/subscriptions","organizations_url":"https://api.github.com/users/tuommaki/orgs","repos_url":"https://api.github.com/users/tuommaki/repos","events_url":"https://api.github.com/users/tuommaki/events{/privacy}","received_events_url":"https://api.github.com/users/tuommaki/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/1268/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/b61728bea9fc61297558e1fe2aaf62fa3e95774e","head":{"label":"giantswarm:add-subnet-id-generator","ref":"add-subnet-id-generator","sha":"b61728bea9fc61297558e1fe2aaf62fa3e95774e","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxOTI3NQ==","name":"aws-operator","full_name":"giantswarm/aws-operator","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-11-12T10:45:38Z","pushed_at":"2018-11-12T11:16:36Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":84551,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":59,"default_branch":"master"}},"base":{"label":"giantswarm:multi-az-cloudformation","ref":"multi-az-cloudformation","sha":"5220f4c566bf313fda48a790427916a23a567589","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxOTI3NQ==","name":"aws-operator","full_name":"giantswarm/aws-operator","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-11-12T10:45:38Z","pushed_at":"2018-11-12T11:16:36Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":84551,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/1268"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/1268"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/1268/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1268/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/b61728bea9fc61297558e1fe2aaf62fa3e95774e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tuommaki"}}