{"action":"closed","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1507","repository_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1507/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1507/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1507/events","html_url":"https://github.com/rust-lang-nursery/rustfmt/issues/1507","id":226639077,"number":1507,"title":"Setting array_layout to non-default \"Block\" resulted in funky indenting","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"labels":[{"id":519120048,"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/labels/only-with-option","name":"only-with-option","color":"c5def5","default":false},{"id":254427039,"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/labels/poor-formatting","name":"poor-formatting","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-05T17:24:58Z","updated_at":"2018-02-15T12:42:09Z","closed_at":"2018-02-15T12:42:09Z","author_association":"NONE","body":"```\r\nDiff in /home/mulhern/my-contributions/stratisd/src/dbus_api/api.rs at line 144:\r\n           I: Iterator<Item = T>⏎\r\n {⏎\r\n     let msg_vec = iter.map(|item| {⏎\r\n-                               MessageItem::Struct(vec![MessageItem::Str(format!(\"{}\", item)),⏎\r\n-                                                        MessageItem::UInt16(item.into())])⏎\r\n+                               MessageItem::Struct(vec![⏎\r\n+                MessageItem::Str(format!(\"{}\", item)),⏎\r\n+                MessageItem::UInt16(item.into()),⏎\r\n+            ])⏎\r\n                            })⏎\r\n         .collect::<Vec<MessageItem>>();⏎\r\n     i.append(MessageItem::Array(msg_vec, Cow::Borrowed(\"(sq)\")));⏎\r\nDiff in /home/mulhern/my-contributions/stratisd/src/dbus_api/pool.rs at line 72:\r\n             let return_value = return_value⏎\r\n                 .iter()⏎\r\n                 .map(|x| {⏎\r\n-                         MessageItem::Struct(vec![MessageItem::ObjectPath(x.0.clone()),⏎\r\n-                                                  MessageItem::Str((*x.1).into())])⏎\r\n+                         MessageItem::Struct(vec![⏎\r\n+                        MessageItem::ObjectPath(x.0.clone()),⏎\r\n+                        MessageItem::Str((*x.1).into()),⏎\r\n+                    ])⏎\r\n                      })⏎\r\n                 .collect();⏎\r\n             let return_value = MessageItem::Array(return_value, return_sig.into());⏎\r\nDiff in /home/mulhern/my-contributions/stratisd/src/engine/strat_engine/metadata.rs at line 183:\r\n ⏎\r\n     /// Try to find a valid StaticHeader in a buffer.⏎\r\n     pub fn setup_from_buf(buf: &[u8; _BDA_STATIC_HDR_SIZE]) -> EngineResult<StaticHeader> {⏎\r\n-        let sigblock_spots = [&buf[SECTOR_SIZE..2 * SECTOR_SIZE],⏎\r\n-                              &buf[9 * SECTOR_SIZE..10 * SECTOR_SIZE]];⏎\r\n+        let sigblock_spots = [⏎\r\n+            &buf[SECTOR_SIZE..2 * SECTOR_SIZE],⏎\r\n+            &buf[9 * SECTOR_SIZE..10 * SECTOR_SIZE],⏎\r\n+        ];⏎\r\n ⏎\r\n         // Check both copies of sigblock for validity⏎\r\n         for buf in &sigblock_spots {⏎\r\nDiff in /home/mulhern/my-contributions/stratisd/src/engine/strat_engine/metadata.rs at line 304:\r\n ⏎\r\n         Ok(MDARegions {⏎\r\n                region_size: region_size,⏎\r\n-               mdas: [MDAHeader::new(per_region_size),⏎\r\n-                      MDAHeader::new(per_region_size)],⏎\r\n+               mdas: [⏎\r\n+            MDAHeader::new(per_region_size),⏎\r\n+            MDAHeader::new(per_region_size),⏎\r\n+        ],⏎\r\n            })⏎\r\n     }⏎\r\n ⏎\r\nMakefile:10: recipe for target 'fmt' failed\r\nmake: *** [fmt] Error 4\r\n[mulhern@localhost stratisd]$ \r\n\r\n```\r\n\r\nIn diff immediately above, elements of the vec are not indented as far as the name of the vec to which they belong.\r\n\r\nInstalled today using\r\n```\r\ncargo install rustfmt\r\n```"}}
{"actor":{"display_login":"topecongiro"}}