{"action":"created","comment":{"url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/comments/174774721","pull_request_review_id":104191918,"id":174774721,"diff_hunk":"@@ -0,0 +1,58 @@\n+<?php\n+\n+namespace CurrencyPlatform\\CurrencyRates\\Provider;\n+\n+use CurrencyPlatform\\CurrencyRates\\Currency;\n+use CurrencyPlatform\\CurrencyRates\\CurrencyRate;\n+use CurrencyPlatform\\CurrencyRates\\Exception\\RateNotFound;\n+use CurrencyPlatform\\CurrencyRates\\Interfaces\\HttpClient;\n+use Noodlehaus\\Config;\n+\n+class CurrencyLayerProvider implements CurrencyRatesProvider\n+{\n+    /**\n+     * @var HttpClient\n+     */\n+    private $httpClient;\n+    /**\n+     * @var Config\n+     */\n+    private $config;\n+    private $currencyLayerUrl = 'http://apilayer.net/api/live';\n+    private $targetCurrencies = [","path":"src/CurrencyRates/Provider/CurrencyLayerProvider.php","position":22,"original_position":22,"commit_id":"800ab42f043df5c0906a730152f93325fe253ca2","original_commit_id":"800ab42f043df5c0906a730152f93325fe253ca2","user":{"login":"mheki","id":2435655,"avatar_url":"https://avatars0.githubusercontent.com/u/2435655?v=4","gravatar_id":"","url":"https://api.github.com/users/mheki","html_url":"https://github.com/mheki","followers_url":"https://api.github.com/users/mheki/followers","following_url":"https://api.github.com/users/mheki/following{/other_user}","gists_url":"https://api.github.com/users/mheki/gists{/gist_id}","starred_url":"https://api.github.com/users/mheki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheki/subscriptions","organizations_url":"https://api.github.com/users/mheki/orgs","repos_url":"https://api.github.com/users/mheki/repos","events_url":"https://api.github.com/users/mheki/events{/privacy}","received_events_url":"https://api.github.com/users/mheki/received_events","type":"User","site_admin":false},"body":"as spoken before, if we proceed with currency layer, this should be extracted. It's OK for now.","created_at":"2018-03-15T13:08:43Z","updated_at":"2018-03-15T13:08:43Z","html_url":"https://github.com/rushpartners/currency-platform/pull/3#discussion_r174774721","pull_request_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/comments/174774721"},"html":{"href":"https://github.com/rushpartners/currency-platform/pull/3#discussion_r174774721"},"pull_request":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3","id":175191862,"html_url":"https://github.com/rushpartners/currency-platform/pull/3","diff_url":"https://github.com/rushpartners/currency-platform/pull/3.diff","patch_url":"https://github.com/rushpartners/currency-platform/pull/3.patch","issue_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/3","number":3,"state":"open","locked":false,"title":"Adding CurrencyLayer Provider / Extracting Zttp","user":{"login":"vikkio88","id":248805,"avatar_url":"https://avatars0.githubusercontent.com/u/248805?v=4","gravatar_id":"","url":"https://api.github.com/users/vikkio88","html_url":"https://github.com/vikkio88","followers_url":"https://api.github.com/users/vikkio88/followers","following_url":"https://api.github.com/users/vikkio88/following{/other_user}","gists_url":"https://api.github.com/users/vikkio88/gists{/gist_id}","starred_url":"https://api.github.com/users/vikkio88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikkio88/subscriptions","organizations_url":"https://api.github.com/users/vikkio88/orgs","repos_url":"https://api.github.com/users/vikkio88/repos","events_url":"https://api.github.com/users/vikkio88/events{/privacy}","received_events_url":"https://api.github.com/users/vikkio88/received_events","type":"User","site_admin":false},"body":"- adding wercker build checks\r\n- Extracting Zttp to its own wrapper and injecting it on provider\r\n- Spec-ing class for CurrencyLayer (probably not going to use it at all)\r\n- Using extracted Zttp wrapper on FixerRates Provider\r\n- Getting ready Fixer Rates provider to being able to get env api_key form config","created_at":"2018-03-15T09:33:16Z","updated_at":"2018-03-15T13:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9194aa1a962f315ff95e6c4e789b0a837dd52fbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidianbonner","id":534654,"avatar_url":"https://avatars1.githubusercontent.com/u/534654?v=4","gravatar_id":"","url":"https://api.github.com/users/davidianbonner","html_url":"https://github.com/davidianbonner","followers_url":"https://api.github.com/users/davidianbonner/followers","following_url":"https://api.github.com/users/davidianbonner/following{/other_user}","gists_url":"https://api.github.com/users/davidianbonner/gists{/gist_id}","starred_url":"https://api.github.com/users/davidianbonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidianbonner/subscriptions","organizations_url":"https://api.github.com/users/davidianbonner/orgs","repos_url":"https://api.github.com/users/davidianbonner/repos","events_url":"https://api.github.com/users/davidianbonner/events{/privacy}","received_events_url":"https://api.github.com/users/davidianbonner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3/commits","review_comments_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3/comments","review_comment_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/3/comments","statuses_url":"https://api.github.com/repos/rushpartners/currency-platform/statuses/800ab42f043df5c0906a730152f93325fe253ca2","head":{"label":"rushpartners:feature/currency-layer-provider","ref":"feature/currency-layer-provider","sha":"800ab42f043df5c0906a730152f93325fe253ca2","user":{"login":"rushpartners","id":36901768,"avatar_url":"https://avatars1.githubusercontent.com/u/36901768?v=4","gravatar_id":"","url":"https://api.github.com/users/rushpartners","html_url":"https://github.com/rushpartners","followers_url":"https://api.github.com/users/rushpartners/followers","following_url":"https://api.github.com/users/rushpartners/following{/other_user}","gists_url":"https://api.github.com/users/rushpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/rushpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushpartners/subscriptions","organizations_url":"https://api.github.com/users/rushpartners/orgs","repos_url":"https://api.github.com/users/rushpartners/repos","events_url":"https://api.github.com/users/rushpartners/events{/privacy}","received_events_url":"https://api.github.com/users/rushpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":123420998,"name":"currency-platform","full_name":"rushpartners/currency-platform","owner":{"login":"rushpartners","id":36901768,"avatar_url":"https://avatars1.githubusercontent.com/u/36901768?v=4","gravatar_id":"","url":"https://api.github.com/users/rushpartners","html_url":"https://github.com/rushpartners","followers_url":"https://api.github.com/users/rushpartners/followers","following_url":"https://api.github.com/users/rushpartners/following{/other_user}","gists_url":"https://api.github.com/users/rushpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/rushpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushpartners/subscriptions","organizations_url":"https://api.github.com/users/rushpartners/orgs","repos_url":"https://api.github.com/users/rushpartners/repos","events_url":"https://api.github.com/users/rushpartners/events{/privacy}","received_events_url":"https://api.github.com/users/rushpartners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rushpartners/currency-platform","description":"a small microservice to get useful info about currencies","fork":false,"url":"https://api.github.com/repos/rushpartners/currency-platform","forks_url":"https://api.github.com/repos/rushpartners/currency-platform/forks","keys_url":"https://api.github.com/repos/rushpartners/currency-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushpartners/currency-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushpartners/currency-platform/teams","hooks_url":"https://api.github.com/repos/rushpartners/currency-platform/hooks","issue_events_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/events{/number}","events_url":"https://api.github.com/repos/rushpartners/currency-platform/events","assignees_url":"https://api.github.com/repos/rushpartners/currency-platform/assignees{/user}","branches_url":"https://api.github.com/repos/rushpartners/currency-platform/branches{/branch}","tags_url":"https://api.github.com/repos/rushpartners/currency-platform/tags","blobs_url":"https://api.github.com/repos/rushpartners/currency-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushpartners/currency-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushpartners/currency-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushpartners/currency-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushpartners/currency-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/rushpartners/currency-platform/languages","stargazers_url":"https://api.github.com/repos/rushpartners/currency-platform/stargazers","contributors_url":"https://api.github.com/repos/rushpartners/currency-platform/contributors","subscribers_url":"https://api.github.com/repos/rushpartners/currency-platform/subscribers","subscription_url":"https://api.github.com/repos/rushpartners/currency-platform/subscription","commits_url":"https://api.github.com/repos/rushpartners/currency-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushpartners/currency-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushpartners/currency-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushpartners/currency-platform/contents/{+path}","compare_url":"https://api.github.com/repos/rushpartners/currency-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushpartners/currency-platform/merges","archive_url":"https://api.github.com/repos/rushpartners/currency-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushpartners/currency-platform/downloads","issues_url":"https://api.github.com/repos/rushpartners/currency-platform/issues{/number}","pulls_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/rushpartners/currency-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/rushpartners/currency-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushpartners/currency-platform/labels{/name}","releases_url":"https://api.github.com/repos/rushpartners/currency-platform/releases{/id}","deployments_url":"https://api.github.com/repos/rushpartners/currency-platform/deployments","created_at":"2018-03-01T10:39:35Z","updated_at":"2018-03-15T09:26:58Z","pushed_at":"2018-03-15T12:22:51Z","git_url":"git://github.com/rushpartners/currency-platform.git","ssh_url":"git@github.com:rushpartners/currency-platform.git","clone_url":"https://github.com/rushpartners/currency-platform.git","svn_url":"https://github.com/rushpartners/currency-platform","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rushpartners:master","ref":"master","sha":"04f26385cfc0812db68b3e0ec72da964b38a1b3f","user":{"login":"rushpartners","id":36901768,"avatar_url":"https://avatars1.githubusercontent.com/u/36901768?v=4","gravatar_id":"","url":"https://api.github.com/users/rushpartners","html_url":"https://github.com/rushpartners","followers_url":"https://api.github.com/users/rushpartners/followers","following_url":"https://api.github.com/users/rushpartners/following{/other_user}","gists_url":"https://api.github.com/users/rushpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/rushpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushpartners/subscriptions","organizations_url":"https://api.github.com/users/rushpartners/orgs","repos_url":"https://api.github.com/users/rushpartners/repos","events_url":"https://api.github.com/users/rushpartners/events{/privacy}","received_events_url":"https://api.github.com/users/rushpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":123420998,"name":"currency-platform","full_name":"rushpartners/currency-platform","owner":{"login":"rushpartners","id":36901768,"avatar_url":"https://avatars1.githubusercontent.com/u/36901768?v=4","gravatar_id":"","url":"https://api.github.com/users/rushpartners","html_url":"https://github.com/rushpartners","followers_url":"https://api.github.com/users/rushpartners/followers","following_url":"https://api.github.com/users/rushpartners/following{/other_user}","gists_url":"https://api.github.com/users/rushpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/rushpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushpartners/subscriptions","organizations_url":"https://api.github.com/users/rushpartners/orgs","repos_url":"https://api.github.com/users/rushpartners/repos","events_url":"https://api.github.com/users/rushpartners/events{/privacy}","received_events_url":"https://api.github.com/users/rushpartners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rushpartners/currency-platform","description":"a small microservice to get useful info about currencies","fork":false,"url":"https://api.github.com/repos/rushpartners/currency-platform","forks_url":"https://api.github.com/repos/rushpartners/currency-platform/forks","keys_url":"https://api.github.com/repos/rushpartners/currency-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushpartners/currency-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushpartners/currency-platform/teams","hooks_url":"https://api.github.com/repos/rushpartners/currency-platform/hooks","issue_events_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/events{/number}","events_url":"https://api.github.com/repos/rushpartners/currency-platform/events","assignees_url":"https://api.github.com/repos/rushpartners/currency-platform/assignees{/user}","branches_url":"https://api.github.com/repos/rushpartners/currency-platform/branches{/branch}","tags_url":"https://api.github.com/repos/rushpartners/currency-platform/tags","blobs_url":"https://api.github.com/repos/rushpartners/currency-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushpartners/currency-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushpartners/currency-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushpartners/currency-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushpartners/currency-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/rushpartners/currency-platform/languages","stargazers_url":"https://api.github.com/repos/rushpartners/currency-platform/stargazers","contributors_url":"https://api.github.com/repos/rushpartners/currency-platform/contributors","subscribers_url":"https://api.github.com/repos/rushpartners/currency-platform/subscribers","subscription_url":"https://api.github.com/repos/rushpartners/currency-platform/subscription","commits_url":"https://api.github.com/repos/rushpartners/currency-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushpartners/currency-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushpartners/currency-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushpartners/currency-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushpartners/currency-platform/contents/{+path}","compare_url":"https://api.github.com/repos/rushpartners/currency-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushpartners/currency-platform/merges","archive_url":"https://api.github.com/repos/rushpartners/currency-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushpartners/currency-platform/downloads","issues_url":"https://api.github.com/repos/rushpartners/currency-platform/issues{/number}","pulls_url":"https://api.github.com/repos/rushpartners/currency-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/rushpartners/currency-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/rushpartners/currency-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushpartners/currency-platform/labels{/name}","releases_url":"https://api.github.com/repos/rushpartners/currency-platform/releases{/id}","deployments_url":"https://api.github.com/repos/rushpartners/currency-platform/deployments","created_at":"2018-03-01T10:39:35Z","updated_at":"2018-03-15T09:26:58Z","pushed_at":"2018-03-15T12:22:51Z","git_url":"git://github.com/rushpartners/currency-platform.git","ssh_url":"git@github.com:rushpartners/currency-platform.git","clone_url":"https://github.com/rushpartners/currency-platform.git","svn_url":"https://github.com/rushpartners/currency-platform","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3"},"html":{"href":"https://github.com/rushpartners/currency-platform/pull/3"},"issue":{"href":"https://api.github.com/repos/rushpartners/currency-platform/issues/3"},"comments":{"href":"https://api.github.com/repos/rushpartners/currency-platform/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rushpartners/currency-platform/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/rushpartners/currency-platform/statuses/800ab42f043df5c0906a730152f93325fe253ca2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mheki"}}