{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/186400692","pull_request_review_id":117969587,"id":186400692,"diff_hunk":"@@ -224,33 +229,150 @@ public Response handle(final String method,\n         //\n         // https://cloud.google.com/storage/docs/json_api/v1/objects/insert\n         handlers.insert(\"POST \" + endpoint + \"/upload/storage/v1/b/{bucket}/o\", (params, headers, body) -> {\n-            if (\"resumable\".equals(params.get(\"uploadType\")) == false) {\n-                return newError(RestStatus.INTERNAL_SERVER_ERROR, \"upload type must be resumable\");\n-            }\n-\n-            final String objectName = params.get(\"name\");\n-            if (Strings.hasText(objectName) == false) {\n-                return newError(RestStatus.INTERNAL_SERVER_ERROR, \"object name is missing\");\n-            }\n-\n-            final Bucket bucket = buckets.get(params.get(\"bucket\"));\n-            if (bucket == null) {\n-                return newError(RestStatus.NOT_FOUND, \"bucket not found\");\n-            }\n-\n-            if (bucket.objects.put(objectName, EMPTY_BYTE) == null) {\n-                String location = endpoint + \"/upload/storage/v1/b/\" + bucket.name + \"/o?uploadType=resumable&upload_id=\" + objectName;\n-                return new Response(RestStatus.CREATED, singletonMap(\"Location\", location), XContentType.JSON.mediaType(), EMPTY_BYTE);\n+            final String uploadType = params.get(\"uploadType\");\n+            if (\"resumable\".equals(uploadType)) {\n+                final String objectName = params.get(\"name\");\n+                if (Strings.hasText(objectName) == false) {\n+                    return newError(RestStatus.INTERNAL_SERVER_ERROR, \"object name is missing\");\n+                }\n+                final Bucket bucket = buckets.get(params.get(\"bucket\"));\n+                if (bucket == null) {\n+                    return newError(RestStatus.NOT_FOUND, \"bucket not found\");\n+                }\n+                if (bucket.objects.put(objectName, EMPTY_BYTE) == null) {\n+                    final String location = endpoint + \"/upload/storage/v1/b/\" + bucket.name + \"/o?uploadType=resumable&upload_id=\"\n+                            + objectName;\n+                    return new Response(RestStatus.CREATED, singletonMap(\"Location\", location), XContentType.JSON.mediaType(), EMPTY_BYTE);\n+                } else {\n+                    return newError(RestStatus.CONFLICT, \"object already exist\");\n+                }\n+            } else if (\"multipart\".equals(uploadType)) {\n+/* A multipart/related request body looks like this (note the binary dump inside a text blob! nice!):\n+*--__END_OF_PART__\n+*Content-Length: 135\n+*Content-Type: application/json; charset=UTF-8\n+*content-transfer-encoding: binary\n+*\n+*{\"bucket\":\"bucket_test\",\"crc32c\":\"7XacHQ==\",\"md5Hash\":\"fVztGkklMlUamsSmJK7W+w==\",\"name\":\"tests-KEwE3bU4TuyetBgQIghmUw/master.dat-temp\"}\n+*--__END_OF_PART__\n+*content-transfer-encoding: binary\n+*\n+*KEwE3bU4TuyetBgQIghmUw\n+*--__END_OF_PART__--\n+*/\n+                String boundary = \"__END_OF_PART__\";\n+                // Determine the multipart boundary\n+                final List<String> contentTypes = headers.getOrDefault(\"Content-Type\", headers.get(\"Content-type\"));\n+                if (contentTypes != null) {\n+                    final String contentType = contentTypes.get(0);\n+                    if ((contentType != null) && contentType.contains(\"multipart/related; boundary=\")) {\n+                        boundary = contentType.replace(\"multipart/related; boundary=\", \"\");\n+                    }\n+                }\n+                InputStream inputStreamBody = new ByteArrayInputStream(body);\n+                final List<String> contentEncodings = headers.getOrDefault(\"Content-Encoding\", headers.get(\"Content-encoding\"));\n+                if (contentEncodings != null) {\n+                    if (contentEncodings.stream().anyMatch(x -> \"gzip\".equalsIgnoreCase(x))) {\n+                        inputStreamBody = new GZIPInputStream(inputStreamBody);\n+                    }\n+                }\n+                // Read line by line ?both? parts of the multipart\n+                try (BufferedReader reader = new BufferedReader(new InputStreamReader(inputStreamBody, StandardCharsets.ISO_8859_1))) {","path":"plugins/repository-gcs/qa/google-cloud-storage/src/test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageTestServer.java","position":124,"original_position":124,"commit_id":"b97abf44564b315f925f2b0c0734c872acf750ef","original_commit_id":"b97abf44564b315f925f2b0c0734c872acf750ef","user":{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false},"body":"Mixing UTF-8 encoded text (variable length encoding) with binary data in the same entity is a sure source of bugs and headaches 💯 \r\nDecoding text as ISO_8859_1 simplifies the parsing.","created_at":"2018-05-07T11:53:23Z","updated_at":"2018-05-07T11:53:23Z","html_url":"https://github.com/elastic/elasticsearch/pull/30168#discussion_r186400692","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/186400692"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/30168#discussion_r186400692"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168","id":184272153,"html_url":"https://github.com/elastic/elasticsearch/pull/30168","diff_url":"https://github.com/elastic/elasticsearch/pull/30168.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/30168.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/30168","number":30168,"state":"open","locked":false,"title":"Repository GCS plugin new client library","user":{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false},"body":"This does away with the `com.google.api-client:google-api-client:1.23` and replaces it with `com.google.cloud:google-cloud-storage:1.27.0` . It also changes security permissions for this plugin.\r\n\r\nThe API of the new library is indeed easier to use, but the configuration requires uncovering internals which most likely will change in the new versions (because the internals are actually the old library that will go away). This should be easy to change when it will happen, although some configuration options might go away (eg `applicationName` or `projectId`)\r\n\r\nDISCLAIMER: This is not turnkey ready. The REST integ test `./gradlew :plugins:repository-gcs:integTest` does not work so I have tested the plugin manually with my Google Cloud account. I have tested it using the Service Account JSON file.\r\n\r\nThe reason the integration test does not work is that the Service Account JSON file, that we contrive to direct the cluster to the mock cloud, does not allow to override the `oauth/token` endpoint, which is the first endpoint called in the flow. So, even if the subsequent API calls should be compatible with our existing mock, to obtain the token, there is a call to 'googleapis' which obviously gets 'unauthorized'. I don't think this is intended, just a sloppiness in the transition.\r\n\r\nAnother worry is that the [Application Default Credentials](https://cloud.google.com/docs/authentication/production) used to authenticate when ES runs on a VM provisioned inside google cloud, reads files from various places (ENV vars, user home, ... other heuristics), so a snap-in `security-permission.policy` is not an option. We could mimic what we do with our config dir, but in this case we would have to duplicate their credentials search logic.\r\n\r\nCloses: https://github.com/elastic/elasticsearch/issues/29259\r\n","created_at":"2018-04-26T09:05:48Z","updated_at":"2018-05-07T11:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"787e535ce854e8ad27ae68eefd592fddfb8f80cb","assignee":{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false},"assignees":[{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rjernst","id":289412,"avatar_url":"https://avatars3.githubusercontent.com/u/289412?v=4","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":143077482,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Distributed/Snapshot/Restore","name":":Distributed/Snapshot/Restore","color":"0e8a16","default":false},{"id":23174,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false},{"id":94283388,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc","default":false},{"id":912911731,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.4.0","name":"v6.4.0","color":"DDDDDD","default":false},{"id":484855464,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/30168/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/b97abf44564b315f925f2b0c0734c872acf750ef","head":{"label":"albertzaharovits:gcs-new-libs","ref":"gcs-new-libs","sha":"b97abf44564b315f925f2b0c0734c872acf750ef","user":{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false},"repo":{"id":98969280,"name":"elasticsearch","full_name":"albertzaharovits/elasticsearch","owner":{"login":"albertzaharovits","id":4568420,"avatar_url":"https://avatars2.githubusercontent.com/u/4568420?v=4","gravatar_id":"","url":"https://api.github.com/users/albertzaharovits","html_url":"https://github.com/albertzaharovits","followers_url":"https://api.github.com/users/albertzaharovits/followers","following_url":"https://api.github.com/users/albertzaharovits/following{/other_user}","gists_url":"https://api.github.com/users/albertzaharovits/gists{/gist_id}","starred_url":"https://api.github.com/users/albertzaharovits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertzaharovits/subscriptions","organizations_url":"https://api.github.com/users/albertzaharovits/orgs","repos_url":"https://api.github.com/users/albertzaharovits/repos","events_url":"https://api.github.com/users/albertzaharovits/events{/privacy}","received_events_url":"https://api.github.com/users/albertzaharovits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertzaharovits/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/albertzaharovits/elasticsearch","forks_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/forks","keys_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/teams","hooks_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/events","assignees_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/tags","blobs_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/subscription","commits_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/merges","archive_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/downloads","issues_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/albertzaharovits/elasticsearch/deployments","created_at":"2017-08-01T06:49:47Z","updated_at":"2017-08-01T06:50:23Z","pushed_at":"2018-05-07T10:31:39Z","git_url":"git://github.com/albertzaharovits/elasticsearch.git","ssh_url":"git@github.com:albertzaharovits/elasticsearch.git","clone_url":"https://github.com/albertzaharovits/elasticsearch.git","svn_url":"https://github.com/albertzaharovits/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":436894,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1987d6261ff1ef302be90241a68f8a688381a907","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-05-07T11:48:07Z","pushed_at":"2018-05-07T11:47:32Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":477303,"stargazers_count":30741,"watchers_count":30741,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10645,"mirror_url":null,"archived":false,"open_issues_count":1450,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10645,"open_issues":1450,"watchers":30741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/30168"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/30168"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/30168/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/30168/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/b97abf44564b315f925f2b0c0734c872acf750ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"albertzaharovits"}}