{"action":"opened","number":1026,"pull_request":{"url":"https://api.github.com/repos/pika/pika/pulls/1026","id":184552567,"html_url":"https://github.com/pika/pika/pull/1026","diff_url":"https://github.com/pika/pika/pull/1026.diff","patch_url":"https://github.com/pika/pika/pull/1026.patch","issue_url":"https://api.github.com/repos/pika/pika/issues/1026","number":1026,"state":"open","locked":false,"title":"Cleaned up \"on channel closed\" callback and ChannelClosed exception scenarios","user":{"login":"vitaly-krugl","id":1441066,"avatar_url":"https://avatars2.githubusercontent.com/u/1441066?v=4","gravatar_id":"","url":"https://api.github.com/users/vitaly-krugl","html_url":"https://github.com/vitaly-krugl","followers_url":"https://api.github.com/users/vitaly-krugl/followers","following_url":"https://api.github.com/users/vitaly-krugl/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-krugl/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-krugl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-krugl/subscriptions","organizations_url":"https://api.github.com/users/vitaly-krugl/orgs","repos_url":"https://api.github.com/users/vitaly-krugl/repos","events_url":"https://api.github.com/users/vitaly-krugl/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-krugl/received_events","type":"User","site_admin":false},"body":"## Backward-incompatible improvements:\r\n- Raise ChannelWrongStateError instead of ChannelClosed and ChannelAlreadyClosing when requesting channel operation incompatible with channel state. For consistency with ConnectionWrongStateError.\r\n- Get rid of pika.channel.ClientChannelErrors.\r\n- \"_on_channel_close\" callback registered via Channel.add_on_close_callback() passes\r\nexception as reason instead of reply_code/reply_text. For consistency with \"on connection closed\" callback.\r\n- Removed Channel.is_closed_by_broker property (which was added not long ago for v1.0.0).\r\n\r\n## Other improvements for v1.0.0:\r\n- Added ChannelClosed-based exceptions ChannelClosedByClient and ChannelClosedByBroker to help user distinguish between the scenarios.","created_at":"2018-04-27T08:11:37Z","updated_at":"2018-04-27T08:11:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pika/pika/pulls/1026/commits","review_comments_url":"https://api.github.com/repos/pika/pika/pulls/1026/comments","review_comment_url":"https://api.github.com/repos/pika/pika/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pika/pika/issues/1026/comments","statuses_url":"https://api.github.com/repos/pika/pika/statuses/322fc79cd5c863ecc604f671eeddc8e246407a06","head":{"label":"vitaly-krugl:channel-closed-cleanup","ref":"channel-closed-cleanup","sha":"322fc79cd5c863ecc604f671eeddc8e246407a06","user":{"login":"vitaly-krugl","id":1441066,"avatar_url":"https://avatars2.githubusercontent.com/u/1441066?v=4","gravatar_id":"","url":"https://api.github.com/users/vitaly-krugl","html_url":"https://github.com/vitaly-krugl","followers_url":"https://api.github.com/users/vitaly-krugl/followers","following_url":"https://api.github.com/users/vitaly-krugl/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-krugl/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-krugl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-krugl/subscriptions","organizations_url":"https://api.github.com/users/vitaly-krugl/orgs","repos_url":"https://api.github.com/users/vitaly-krugl/repos","events_url":"https://api.github.com/users/vitaly-krugl/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-krugl/received_events","type":"User","site_admin":false},"repo":{"id":32773342,"name":"pika","full_name":"vitaly-krugl/pika","owner":{"login":"vitaly-krugl","id":1441066,"avatar_url":"https://avatars2.githubusercontent.com/u/1441066?v=4","gravatar_id":"","url":"https://api.github.com/users/vitaly-krugl","html_url":"https://github.com/vitaly-krugl","followers_url":"https://api.github.com/users/vitaly-krugl/followers","following_url":"https://api.github.com/users/vitaly-krugl/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-krugl/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-krugl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-krugl/subscriptions","organizations_url":"https://api.github.com/users/vitaly-krugl/orgs","repos_url":"https://api.github.com/users/vitaly-krugl/repos","events_url":"https://api.github.com/users/vitaly-krugl/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-krugl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitaly-krugl/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":true,"url":"https://api.github.com/repos/vitaly-krugl/pika","forks_url":"https://api.github.com/repos/vitaly-krugl/pika/forks","keys_url":"https://api.github.com/repos/vitaly-krugl/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitaly-krugl/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitaly-krugl/pika/teams","hooks_url":"https://api.github.com/repos/vitaly-krugl/pika/hooks","issue_events_url":"https://api.github.com/repos/vitaly-krugl/pika/issues/events{/number}","events_url":"https://api.github.com/repos/vitaly-krugl/pika/events","assignees_url":"https://api.github.com/repos/vitaly-krugl/pika/assignees{/user}","branches_url":"https://api.github.com/repos/vitaly-krugl/pika/branches{/branch}","tags_url":"https://api.github.com/repos/vitaly-krugl/pika/tags","blobs_url":"https://api.github.com/repos/vitaly-krugl/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitaly-krugl/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitaly-krugl/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitaly-krugl/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitaly-krugl/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/vitaly-krugl/pika/languages","stargazers_url":"https://api.github.com/repos/vitaly-krugl/pika/stargazers","contributors_url":"https://api.github.com/repos/vitaly-krugl/pika/contributors","subscribers_url":"https://api.github.com/repos/vitaly-krugl/pika/subscribers","subscription_url":"https://api.github.com/repos/vitaly-krugl/pika/subscription","commits_url":"https://api.github.com/repos/vitaly-krugl/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitaly-krugl/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitaly-krugl/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitaly-krugl/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitaly-krugl/pika/contents/{+path}","compare_url":"https://api.github.com/repos/vitaly-krugl/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitaly-krugl/pika/merges","archive_url":"https://api.github.com/repos/vitaly-krugl/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitaly-krugl/pika/downloads","issues_url":"https://api.github.com/repos/vitaly-krugl/pika/issues{/number}","pulls_url":"https://api.github.com/repos/vitaly-krugl/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/vitaly-krugl/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/vitaly-krugl/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitaly-krugl/pika/labels{/name}","releases_url":"https://api.github.com/repos/vitaly-krugl/pika/releases{/id}","deployments_url":"https://api.github.com/repos/vitaly-krugl/pika/deployments","created_at":"2015-03-24T03:14:18Z","updated_at":"2018-04-27T04:51:05Z","pushed_at":"2018-04-27T08:09:47Z","git_url":"git://github.com/vitaly-krugl/pika.git","ssh_url":"git@github.com:vitaly-krugl/pika.git","clone_url":"https://github.com/vitaly-krugl/pika.git","svn_url":"https://github.com/vitaly-krugl/pika","homepage":"http://pika.readthedocs.org","size":7025,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pika:master","ref":"master","sha":"16cdb80b4c0aacc9766abf033fccecb2c1ccb1a3","user":{"login":"pika","id":660428,"avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"repo":{"id":342869,"name":"pika","full_name":"pika/pika","owner":{"login":"pika","id":660428,"avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pika/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":false,"url":"https://api.github.com/repos/pika/pika","forks_url":"https://api.github.com/repos/pika/pika/forks","keys_url":"https://api.github.com/repos/pika/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pika/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pika/pika/teams","hooks_url":"https://api.github.com/repos/pika/pika/hooks","issue_events_url":"https://api.github.com/repos/pika/pika/issues/events{/number}","events_url":"https://api.github.com/repos/pika/pika/events","assignees_url":"https://api.github.com/repos/pika/pika/assignees{/user}","branches_url":"https://api.github.com/repos/pika/pika/branches{/branch}","tags_url":"https://api.github.com/repos/pika/pika/tags","blobs_url":"https://api.github.com/repos/pika/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pika/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pika/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/pika/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pika/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/pika/pika/languages","stargazers_url":"https://api.github.com/repos/pika/pika/stargazers","contributors_url":"https://api.github.com/repos/pika/pika/contributors","subscribers_url":"https://api.github.com/repos/pika/pika/subscribers","subscription_url":"https://api.github.com/repos/pika/pika/subscription","commits_url":"https://api.github.com/repos/pika/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/pika/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/pika/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/pika/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/pika/pika/contents/{+path}","compare_url":"https://api.github.com/repos/pika/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pika/pika/merges","archive_url":"https://api.github.com/repos/pika/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pika/pika/downloads","issues_url":"https://api.github.com/repos/pika/pika/issues{/number}","pulls_url":"https://api.github.com/repos/pika/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/pika/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/pika/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pika/pika/labels{/name}","releases_url":"https://api.github.com/repos/pika/pika/releases{/id}","deployments_url":"https://api.github.com/repos/pika/pika/deployments","created_at":"2009-10-19T23:22:02Z","updated_at":"2018-04-26T17:58:16Z","pushed_at":"2018-04-26T17:16:57Z","git_url":"git://github.com/pika/pika.git","ssh_url":"git@github.com:pika/pika.git","clone_url":"https://github.com/pika/pika.git","svn_url":"https://github.com/pika/pika","homepage":"https://pika.readthedocs.io","size":6373,"stargazers_count":1577,"watchers_count":1577,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":484,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":484,"open_issues":28,"watchers":1577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/1026"},"html":{"href":"https://github.com/pika/pika/pull/1026"},"issue":{"href":"https://api.github.com/repos/pika/pika/issues/1026"},"comments":{"href":"https://api.github.com/repos/pika/pika/issues/1026/comments"},"review_comments":{"href":"https://api.github.com/repos/pika/pika/pulls/1026/comments"},"review_comment":{"href":"https://api.github.com/repos/pika/pika/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pika/pika/pulls/1026/commits"},"statuses":{"href":"https://api.github.com/repos/pika/pika/statuses/322fc79cd5c863ecc604f671eeddc8e246407a06"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":196,"deletions":257,"changed_files":9}}
{"actor":{"display_login":"vitaly-krugl"}}