{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1678","repository_url":"https://api.github.com/repos/ipfs/js-ipfs","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1678/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1678/comments","events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1678/events","html_url":"https://github.com/ipfs/js-ipfs/pull/1678","id":375050093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTg2NjUz","number":1678,"title":"fix: remove example eslint config","user":{"login":"hugomrdias","id":314190,"node_id":"MDQ6VXNlcjMxNDE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false},"labels":[{"id":259619775,"node_id":"MDU6TGFiZWwyNTk2MTk3NzU=","url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"hugomrdias","id":314190,"node_id":"MDQ6VXNlcjMxNDE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false},"assignees":[{"login":"hugomrdias","id":314190,"node_id":"MDQ6VXNlcjMxNDE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-29T14:42:46Z","updated_at":"2018-10-29T14:47:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1678","html_url":"https://github.com/ipfs/js-ipfs/pull/1678","diff_url":"https://github.com/ipfs/js-ipfs/pull/1678.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1678.patch"},"body":"This PR removes eslint config from webpack example to solve the missing esling-config-react when running `aegir lint`. \r\n\r\nThis is one way to go, and IMO the best one because examples should pass our normal eslint config.\r\n\r\nAnother option is to stop linting examples with aegir, and have them setup specific eslint configs.\r\n\r\nPlease give feedback about these two options and which one we should adopt.\r\n\r\n\r\nRelated:\r\nhttps://github.com/ipfs/aegir/pull/293/files\r\nhttps://github.com/ipfs/js-ipfs/pull/1665#issuecomment-433896935"},"comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments/433938434","html_url":"https://github.com/ipfs/js-ipfs/pull/1678#issuecomment-433938434","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1678","id":433938434,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzkzODQzNA==","user":{"login":"hugomrdias","id":314190,"node_id":"MDQ6VXNlcjMxNDE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/314190?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomrdias","html_url":"https://github.com/hugomrdias","followers_url":"https://api.github.com/users/hugomrdias/followers","following_url":"https://api.github.com/users/hugomrdias/following{/other_user}","gists_url":"https://api.github.com/users/hugomrdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomrdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomrdias/subscriptions","organizations_url":"https://api.github.com/users/hugomrdias/orgs","repos_url":"https://api.github.com/users/hugomrdias/repos","events_url":"https://api.github.com/users/hugomrdias/events{/privacy}","received_events_url":"https://api.github.com/users/hugomrdias/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T14:47:57Z","updated_at":"2018-10-29T14:47:57Z","author_association":"CONTRIBUTOR","body":"There's already a this PR https://github.com/ipfs/aegir/pull/250 about custom eslint configs support"}}
{"actor":{"display_login":"hugomrdias"}}