{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/169537331","pull_request_review_id":98077915,"id":169537331,"diff_hunk":"@@ -245,20 +245,21 @@ private void closeReaders(Collection<FileSKVIterator> filesToClose) {\n   }\n \n   private List<String> takeOpenFiles(Collection<String> files, Map<FileSKVIterator,String> readersReserved) {\n-    List<String> filesToOpen = new LinkedList<>(files);\n-    for (Iterator<String> iterator = filesToOpen.iterator(); iterator.hasNext();) {\n-      String file = iterator.next();\n-\n+    List<String> filesToOpen = Collections.emptyList();\n+    for (String file : files) {\n       List<OpenReader> ofl = openFiles.get(file);\n       if (ofl != null && ofl.size() > 0) {\n         OpenReader openReader = ofl.remove(ofl.size() - 1);\n         readersReserved.put(openReader.reader, file);\n         if (ofl.size() == 0) {\n           openFiles.remove(file);\n         }\n-        iterator.remove();\n+      } else {\n+        if(filesToOpen.size() == 0) {","path":"server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java","position":19,"original_position":19,"commit_id":"e4d651341d3b4c430ab7023920c1dec2482385ec","original_commit_id":"e4d651341d3b4c430ab7023920c1dec2482385ec","user":{"login":"keith-turner","id":1268739,"avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"body":"yeah","created_at":"2018-02-21T05:20:34Z","updated_at":"2018-02-21T05:20:34Z","html_url":"https://github.com/apache/accumulo/pull/389#discussion_r169537331","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/169537331"},"html":{"href":"https://github.com/apache/accumulo/pull/389#discussion_r169537331"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/389"}},"in_reply_to_id":169520320},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/389","id":170273860,"html_url":"https://github.com/apache/accumulo/pull/389","diff_url":"https://github.com/apache/accumulo/pull/389.diff","patch_url":"https://github.com/apache/accumulo/pull/389.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/389","number":389,"state":"open","locked":false,"title":"ACCUMULO-4805 Optimize file manager when no files to open","user":{"login":"keith-turner","id":1268739,"avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-20T18:34:23Z","updated_at":"2018-02-21T05:20:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0e1ccdeb28fcce81b3f26d9360d9f9a28fbe99a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/389/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/389/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/389/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/e4d651341d3b4c430ab7023920c1dec2482385ec","head":{"label":"keith-turner:ACCUMULO-4805","ref":"ACCUMULO-4805","sha":"e4d651341d3b4c430ab7023920c1dec2482385ec","user":{"login":"keith-turner","id":1268739,"avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"repo":{"id":4228808,"name":"accumulo","full_name":"keith-turner/accumulo","owner":{"login":"keith-turner","id":1268739,"avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keith-turner/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/keith-turner/accumulo","forks_url":"https://api.github.com/repos/keith-turner/accumulo/forks","keys_url":"https://api.github.com/repos/keith-turner/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keith-turner/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keith-turner/accumulo/teams","hooks_url":"https://api.github.com/repos/keith-turner/accumulo/hooks","issue_events_url":"https://api.github.com/repos/keith-turner/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/keith-turner/accumulo/events","assignees_url":"https://api.github.com/repos/keith-turner/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/keith-turner/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/keith-turner/accumulo/tags","blobs_url":"https://api.github.com/repos/keith-turner/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keith-turner/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keith-turner/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/keith-turner/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keith-turner/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/keith-turner/accumulo/languages","stargazers_url":"https://api.github.com/repos/keith-turner/accumulo/stargazers","contributors_url":"https://api.github.com/repos/keith-turner/accumulo/contributors","subscribers_url":"https://api.github.com/repos/keith-turner/accumulo/subscribers","subscription_url":"https://api.github.com/repos/keith-turner/accumulo/subscription","commits_url":"https://api.github.com/repos/keith-turner/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/keith-turner/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/keith-turner/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/keith-turner/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/keith-turner/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/keith-turner/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keith-turner/accumulo/merges","archive_url":"https://api.github.com/repos/keith-turner/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keith-turner/accumulo/downloads","issues_url":"https://api.github.com/repos/keith-turner/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/keith-turner/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/keith-turner/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/keith-turner/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keith-turner/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/keith-turner/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/keith-turner/accumulo/deployments","created_at":"2012-05-04T20:22:00Z","updated_at":"2015-08-28T21:58:49Z","pushed_at":"2018-02-20T18:32:51Z","git_url":"git://github.com/keith-turner/accumulo.git","ssh_url":"git@github.com:keith-turner/accumulo.git","clone_url":"https://github.com/keith-turner/accumulo.git","svn_url":"https://github.com/keith-turner/accumulo","homepage":"","size":64751,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:1.8","ref":"1.8","sha":"155a713a45cf444f10e0afe6c95962e6e0232001","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2018-02-16T08:24:33Z","pushed_at":"2018-02-20T18:34:24Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"https://accumulo.apache.org","size":58912,"stargazers_count":343,"watchers_count":343,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":197,"open_issues":8,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/389"},"html":{"href":"https://github.com/apache/accumulo/pull/389"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/389"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/e4d651341d3b4c430ab7023920c1dec2482385ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keith-turner"}}