{"action":"created","issue":{"url":"https://api.github.com/repos/apache/geode/issues/2741","repository_url":"https://api.github.com/repos/apache/geode","labels_url":"https://api.github.com/repos/apache/geode/issues/2741/labels{/name}","comments_url":"https://api.github.com/repos/apache/geode/issues/2741/comments","events_url":"https://api.github.com/repos/apache/geode/issues/2741/events","html_url":"https://github.com/apache/geode/pull/2741","id":375142052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjU2NjE4","number":2741,"title":"GEODE-5595: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException","user":{"login":"mhansonp","id":26558973,"node_id":"MDQ6VXNlcjI2NTU4OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/26558973?v=4","gravatar_id":"","url":"https://api.github.com/users/mhansonp","html_url":"https://github.com/mhansonp","followers_url":"https://api.github.com/users/mhansonp/followers","following_url":"https://api.github.com/users/mhansonp/following{/other_user}","gists_url":"https://api.github.com/users/mhansonp/gists{/gist_id}","starred_url":"https://api.github.com/users/mhansonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhansonp/subscriptions","organizations_url":"https://api.github.com/users/mhansonp/orgs","repos_url":"https://api.github.com/users/mhansonp/repos","events_url":"https://api.github.com/users/mhansonp/events{/privacy}","received_events_url":"https://api.github.com/users/mhansonp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-29T17:53:28Z","updated_at":"2018-10-29T17:54:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2741","html_url":"https://github.com/apache/geode/pull/2741","diff_url":"https://github.com/apache/geode/pull/2741.diff","patch_url":"https://github.com/apache/geode/pull/2741.patch"},"body":"The basic problem with this code was that it was declaring an exception in one part of the code and later \"picking up\" that error and throwing it. This messed with the time and handling of errors as one might imagine... QueueManagerImpl.java was the source of that problem. Then there were timing issues in the DeltaPropogationDUnitTests themselves. So I alleviated that in part moving to awaitility and to the new GeodeAwaitility. There was also a little more synchronization added in the form of atomic booleans..\r\n\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n- [ ] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/geode/issues/comments/434012992","html_url":"https://github.com/apache/geode/pull/2741#issuecomment-434012992","issue_url":"https://api.github.com/repos/apache/geode/issues/2741","id":434012992,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDAxMjk5Mg==","user":{"login":"mhansonp","id":26558973,"node_id":"MDQ6VXNlcjI2NTU4OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/26558973?v=4","gravatar_id":"","url":"https://api.github.com/users/mhansonp","html_url":"https://github.com/mhansonp","followers_url":"https://api.github.com/users/mhansonp/followers","following_url":"https://api.github.com/users/mhansonp/following{/other_user}","gists_url":"https://api.github.com/users/mhansonp/gists{/gist_id}","starred_url":"https://api.github.com/users/mhansonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhansonp/subscriptions","organizations_url":"https://api.github.com/users/mhansonp/orgs","repos_url":"https://api.github.com/users/mhansonp/repos","events_url":"https://api.github.com/users/mhansonp/events{/privacy}","received_events_url":"https://api.github.com/users/mhansonp/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T17:54:01Z","updated_at":"2018-10-29T17:54:01Z","author_association":"CONTRIBUTOR","body":"@WireBaron @galen-pivotal @balesh2 Please review this when you get the chance."}}
{"actor":{"display_login":"mhansonp"}}