{"action":"closed","number":5989,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989","id":192784510,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzg0NTEw","html_url":"https://github.com/salesagility/SuiteCRM/pull/5989","diff_url":"https://github.com/salesagility/SuiteCRM/pull/5989.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/5989.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5989","number":5989,"state":"closed","locked":false,"title":"templateParser.php - render 'wysiwyg' fields in PDFs","user":{"login":"ApatheticCosmos","id":16560296,"node_id":"MDQ6VXNlcjE2NTYwMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16560296?v=4","gravatar_id":"","url":"https://api.github.com/users/ApatheticCosmos","html_url":"https://github.com/ApatheticCosmos","followers_url":"https://api.github.com/users/ApatheticCosmos/followers","following_url":"https://api.github.com/users/ApatheticCosmos/following{/other_user}","gists_url":"https://api.github.com/users/ApatheticCosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/ApatheticCosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApatheticCosmos/subscriptions","organizations_url":"https://api.github.com/users/ApatheticCosmos/orgs","repos_url":"https://api.github.com/users/ApatheticCosmos/repos","events_url":"https://api.github.com/users/ApatheticCosmos/events{/privacy}","received_events_url":"https://api.github.com/users/ApatheticCosmos/received_events","type":"User","site_admin":false},"body":"This makes fields from thw 'wysiwyg' addon field render in PDFs\r\nproperly.\r\nThis commit is the 2nd one I've done. The first was to my\r\n'master' branch and had to be reverted and put into it's\r\nown branch, in the hopes that it will be accepted upstream.\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nSee issue #241 which is currently closed.\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nWhen using the Wysiwyg field module, PDF templates would render the html code. \r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\nAdd these four lines to the file, then include a wysiwyg field to a PDF template.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://suitecrm.com/wiki/index.php/Coding_Standards).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://suitecrm.com/wiki/index.php/Contributing_to_SuiteCRM) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-06-05T17:39:06Z","updated_at":"2018-12-17T15:11:04Z","closed_at":"2018-12-17T15:11:04Z","merged_at":null,"merge_commit_sha":"a5821ea58e93242e78f3f5e7cb93d3c68e0a47e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1148555079,"node_id":"MDU6TGFiZWwxMTQ4NTU1MDc5","url":"https://api.github.com/repos/salesagility/SuiteCRM/labels/Community%20Contribution","name":"Community Contribution","color":"108bb5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5989/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/4d356f016a1c5deaad0c0c81b82969c0aa59ad5b","head":{"label":"ApatheticCosmos:render_wysiwyg_fields_in_pdfs","ref":"render_wysiwyg_fields_in_pdfs","sha":"4d356f016a1c5deaad0c0c81b82969c0aa59ad5b","user":{"login":"ApatheticCosmos","id":16560296,"node_id":"MDQ6VXNlcjE2NTYwMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16560296?v=4","gravatar_id":"","url":"https://api.github.com/users/ApatheticCosmos","html_url":"https://github.com/ApatheticCosmos","followers_url":"https://api.github.com/users/ApatheticCosmos/followers","following_url":"https://api.github.com/users/ApatheticCosmos/following{/other_user}","gists_url":"https://api.github.com/users/ApatheticCosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/ApatheticCosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApatheticCosmos/subscriptions","organizations_url":"https://api.github.com/users/ApatheticCosmos/orgs","repos_url":"https://api.github.com/users/ApatheticCosmos/repos","events_url":"https://api.github.com/users/ApatheticCosmos/events{/privacy}","received_events_url":"https://api.github.com/users/ApatheticCosmos/received_events","type":"User","site_admin":false},"repo":{"id":122366552,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNjY1NTI=","name":"SuiteCRM","full_name":"ApatheticCosmos/SuiteCRM","private":false,"owner":{"login":"ApatheticCosmos","id":16560296,"node_id":"MDQ6VXNlcjE2NTYwMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16560296?v=4","gravatar_id":"","url":"https://api.github.com/users/ApatheticCosmos","html_url":"https://github.com/ApatheticCosmos","followers_url":"https://api.github.com/users/ApatheticCosmos/followers","following_url":"https://api.github.com/users/ApatheticCosmos/following{/other_user}","gists_url":"https://api.github.com/users/ApatheticCosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/ApatheticCosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApatheticCosmos/subscriptions","organizations_url":"https://api.github.com/users/ApatheticCosmos/orgs","repos_url":"https://api.github.com/users/ApatheticCosmos/repos","events_url":"https://api.github.com/users/ApatheticCosmos/events{/privacy}","received_events_url":"https://api.github.com/users/ApatheticCosmos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ApatheticCosmos/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM","forks_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/forks","keys_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/events","assignees_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/merges","archive_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/ApatheticCosmos/SuiteCRM/deployments","created_at":"2018-02-21T17:07:24Z","updated_at":"2018-11-21T17:16:59Z","pushed_at":"2018-12-14T23:21:18Z","git_url":"git://github.com/ApatheticCosmos/SuiteCRM.git","ssh_url":"git@github.com:ApatheticCosmos/SuiteCRM.git","clone_url":"https://github.com/ApatheticCosmos/SuiteCRM.git","svn_url":"https://github.com/ApatheticCosmos/SuiteCRM","homepage":"http://www.suitecrm.com","size":110466,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"2a881af35ebcb84335fd91e37347110737b749e5","user":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0NDYwMA==","name":"SuiteCRM","full_name":"salesagility/SuiteCRM","private":false,"owner":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-12-17T09:33:43Z","pushed_at":"2018-12-17T14:51:37Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"https://www.suitecrm.com","size":110961,"stargazers_count":1235,"watchers_count":1235,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":934,"mirror_url":null,"archived":false,"open_issues_count":1064,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":934,"open_issues":1064,"watchers":1235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5989"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5989"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5989/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5989/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/4d356f016a1c5deaad0c0c81b82969c0aa59ad5b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"samus-aran"}}