{"action":"created","issue":{"url":"https://api.github.com/repos/systers/systers.github.io/issues/191","repository_url":"https://api.github.com/repos/systers/systers.github.io","labels_url":"https://api.github.com/repos/systers/systers.github.io/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/systers/systers.github.io/issues/191/comments","events_url":"https://api.github.com/repos/systers/systers.github.io/issues/191/events","html_url":"https://github.com/systers/systers.github.io/pull/191","id":328206405,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODA1NzMx","number":191,"title":"Issue#190 Create Project Page","user":{"login":"BaaniLeen","id":22029744,"node_id":"MDQ6VXNlcjIyMDI5NzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/22029744?v=4","gravatar_id":"","url":"https://api.github.com/users/BaaniLeen","html_url":"https://github.com/BaaniLeen","followers_url":"https://api.github.com/users/BaaniLeen/followers","following_url":"https://api.github.com/users/BaaniLeen/following{/other_user}","gists_url":"https://api.github.com/users/BaaniLeen/gists{/gist_id}","starred_url":"https://api.github.com/users/BaaniLeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaaniLeen/subscriptions","organizations_url":"https://api.github.com/users/BaaniLeen/orgs","repos_url":"https://api.github.com/users/BaaniLeen/repos","events_url":"https://api.github.com/users/BaaniLeen/events{/privacy}","received_events_url":"https://api.github.com/users/BaaniLeen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-05-31T16:17:15Z","updated_at":"2018-06-08T03:59:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/systers/systers.github.io/pulls/191","html_url":"https://github.com/systers/systers.github.io/pull/191","diff_url":"https://github.com/systers/systers.github.io/pull/191.diff","patch_url":"https://github.com/systers/systers.github.io/pull/191.patch"},"body":"### Description\r\n\r\nAdded a Project page to the current code base, which takes the information from an array and loads in it separate cards. Ensured high modularity & no redundancy of code.\r\nAlso updated the README file, as discussed with @ancyp .\r\n\r\nFixes #190 \r\n\r\n### Type of Change:\r\n**Delete irrelevant options.**\r\n\r\n- Code\r\n- Quality Assurance\r\n- User Interface\r\n- Outreach\r\n- Documentation\r\n  \r\n\r\n**Code/Quality Assurance Only**\r\n- New feature (non-breaking change which adds functionality pre-approved by mentors)\r\n\r\n### How Has This Been Tested?\r\n\r\n### Mockups\r\n![screen shot 2018-05-31 at 9 40 07 pm](https://user-images.githubusercontent.com/22029744/40794145-f42b0386-651b-11e8-8fe6-40d325d3057c.png)\r\n![screen shot 2018-05-31 at 9 40 22 pm](https://user-images.githubusercontent.com/22029744/40794147-f5c270bc-651b-11e8-86e8-c8e42b32fcd2.png)\r\n\r\n### Mobile Responsiveness : Tested.\r\nDemo : https://drive.google.com/file/d/1LMnNaByHhZp-dtFwPZOfhlgdTOUHqvi7/view?usp=sharing\r\n\r\n### Checklist:\r\n**Delete irrelevant options.**\r\n\r\n- [ ] My PR follows the style guidelines of this project\r\n- [ ] I have performed a self-review of my own code or materials\r\n- [ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n  \r\n**Code/Quality Assurance Only**\r\n- [ ] My changes generate no new warnings \r\n- [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] New and existing unit tests pass locally with my changes\r\n- [ ] Any dependent changes have been published in downstream modules"},"comment":{"url":"https://api.github.com/repos/systers/systers.github.io/issues/comments/395639603","html_url":"https://github.com/systers/systers.github.io/pull/191#issuecomment-395639603","issue_url":"https://api.github.com/repos/systers/systers.github.io/issues/191","id":395639603,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTYzOTYwMw==","user":{"login":"BaaniLeen","id":22029744,"node_id":"MDQ6VXNlcjIyMDI5NzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/22029744?v=4","gravatar_id":"","url":"https://api.github.com/users/BaaniLeen","html_url":"https://github.com/BaaniLeen","followers_url":"https://api.github.com/users/BaaniLeen/followers","following_url":"https://api.github.com/users/BaaniLeen/following{/other_user}","gists_url":"https://api.github.com/users/BaaniLeen/gists{/gist_id}","starred_url":"https://api.github.com/users/BaaniLeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaaniLeen/subscriptions","organizations_url":"https://api.github.com/users/BaaniLeen/orgs","repos_url":"https://api.github.com/users/BaaniLeen/repos","events_url":"https://api.github.com/users/BaaniLeen/events{/privacy}","received_events_url":"https://api.github.com/users/BaaniLeen/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T03:59:52Z","updated_at":"2018-06-08T03:59:52Z","author_association":"MEMBER","body":"@ancyp By the alignment of the Github icons do you mean, cards should be of the same sizes too?\r\nI will change the colour of the Github icons to black. :)\r\nShall I switch to a tabbed pane for peace Corps and Systers projects? I felt the problem with this would be that the user would not be aware which of those categories of projects, he/she wants to look for. What are your views about it?\r\nRegarding the slack icon, since the github icon too is at the bottom, I can incorporate both of them in a single line itself. Regarding making the entire card clickable, that is actually a great idea! :)\r\nBut since we are adding the slack symbol, so making the entire card clickable here would not make much sense.\r\nOr maybe, I can just have the description and the project name on the cards, make it clickable and a modal opens up, with details including Github symbol and slack symbol - which should redirect to the project specific channel.\r\nWhich one suits better? @ancyp @Janiceilene "}}
{"actor":{"display_login":"BaaniLeen"}}