{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/206692358","pull_request_review_id":142155268,"id":206692358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY5MjM1OA==","diff_hunk":"@@ -20,7 +20,18 @@\n     private final static String ZEROES = \"0000000000000\";\n \n     /*\n-     * Creates the next sequence number string\n+     * Creates the next sequence number\n+     */\n+    public long getRawSequenceNumber() {\n+        return seq.incrementAndGet();\n+    }\n+\n+    public String formatSequenceNumber(long date, long n) {\n+        return date + \"_\" + toPaddedHex(n);\n+    }\n+\n+    /*\n+     * Creates the next sequence number formatted string\n      */\n     public String next(long date) {","path":"dev/com.ibm.ws.logging/src/com/ibm/ws/logging/utils/SequenceNumber.java","position":18,"original_position":18,"commit_id":"536359bd679d2acf513cdfff739aeb41f300af90","original_commit_id":"536359bd679d2acf513cdfff739aeb41f300af90","user":{"login":"donbourne","id":17110503,"node_id":"MDQ6VXNlcjE3MTEwNTAz","avatar_url":"https://avatars2.githubusercontent.com/u/17110503?v=4","gravatar_id":"","url":"https://api.github.com/users/donbourne","html_url":"https://github.com/donbourne","followers_url":"https://api.github.com/users/donbourne/followers","following_url":"https://api.github.com/users/donbourne/following{/other_user}","gists_url":"https://api.github.com/users/donbourne/gists{/gist_id}","starred_url":"https://api.github.com/users/donbourne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donbourne/subscriptions","organizations_url":"https://api.github.com/users/donbourne/orgs","repos_url":"https://api.github.com/users/donbourne/repos","events_url":"https://api.github.com/users/donbourne/events{/privacy}","received_events_url":"https://api.github.com/users/donbourne/received_events","type":"User","site_admin":false},"body":"this method should be refactored:\r\n```\r\n    public String next(long date) {\r\n        long n = seq.incrementAndGet();\r\n        return formatSequenceNumber(date, n);\r\n     }\r\n```","created_at":"2018-07-31T21:39:16Z","updated_at":"2018-07-31T21:57:58Z","html_url":"https://github.com/OpenLiberty/open-liberty/pull/3957#discussion_r206692358","pull_request_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/206692358"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3957#discussion_r206692358"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957","id":194600049,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjAwMDQ5","html_url":"https://github.com/OpenLiberty/open-liberty/pull/3957","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/3957.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/3957.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3957","number":3957,"state":"open","locked":false,"title":"Issue #2416 moving computation for sequence and message id","user":{"login":"aarb1","id":29636058,"node_id":"MDQ6VXNlcjI5NjM2MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/29636058?v=4","gravatar_id":"","url":"https://api.github.com/users/aarb1","html_url":"https://github.com/aarb1","followers_url":"https://api.github.com/users/aarb1/followers","following_url":"https://api.github.com/users/aarb1/following{/other_user}","gists_url":"https://api.github.com/users/aarb1/gists{/gist_id}","starred_url":"https://api.github.com/users/aarb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarb1/subscriptions","organizations_url":"https://api.github.com/users/aarb1/orgs","repos_url":"https://api.github.com/users/aarb1/repos","events_url":"https://api.github.com/users/aarb1/events{/privacy}","received_events_url":"https://api.github.com/users/aarb1/received_events","type":"User","site_admin":false},"body":"fixes #2416","created_at":"2018-06-13T14:10:24Z","updated_at":"2018-07-31T21:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ee8c5ab137a1b304014e037649bd7fb789a13f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706052599,"node_id":"MDU6TGFiZWw3MDYwNTI1OTk=","url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3957/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/536359bd679d2acf513cdfff739aeb41f300af90","head":{"label":"aarb1:2416-computation-seq-msg-id","ref":"2416-computation-seq-msg-id","sha":"536359bd679d2acf513cdfff739aeb41f300af90","user":{"login":"aarb1","id":29636058,"node_id":"MDQ6VXNlcjI5NjM2MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/29636058?v=4","gravatar_id":"","url":"https://api.github.com/users/aarb1","html_url":"https://github.com/aarb1","followers_url":"https://api.github.com/users/aarb1/followers","following_url":"https://api.github.com/users/aarb1/following{/other_user}","gists_url":"https://api.github.com/users/aarb1/gists{/gist_id}","starred_url":"https://api.github.com/users/aarb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarb1/subscriptions","organizations_url":"https://api.github.com/users/aarb1/orgs","repos_url":"https://api.github.com/users/aarb1/repos","events_url":"https://api.github.com/users/aarb1/events{/privacy}","received_events_url":"https://api.github.com/users/aarb1/received_events","type":"User","site_admin":false},"repo":{"id":105579673,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1Nzk2NzM=","name":"open-liberty","full_name":"aarb1/open-liberty","owner":{"login":"aarb1","id":29636058,"node_id":"MDQ6VXNlcjI5NjM2MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/29636058?v=4","gravatar_id":"","url":"https://api.github.com/users/aarb1","html_url":"https://github.com/aarb1","followers_url":"https://api.github.com/users/aarb1/followers","following_url":"https://api.github.com/users/aarb1/following{/other_user}","gists_url":"https://api.github.com/users/aarb1/gists{/gist_id}","starred_url":"https://api.github.com/users/aarb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarb1/subscriptions","organizations_url":"https://api.github.com/users/aarb1/orgs","repos_url":"https://api.github.com/users/aarb1/repos","events_url":"https://api.github.com/users/aarb1/events{/privacy}","received_events_url":"https://api.github.com/users/aarb1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aarb1/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/aarb1/open-liberty","forks_url":"https://api.github.com/repos/aarb1/open-liberty/forks","keys_url":"https://api.github.com/repos/aarb1/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aarb1/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aarb1/open-liberty/teams","hooks_url":"https://api.github.com/repos/aarb1/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/aarb1/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/aarb1/open-liberty/events","assignees_url":"https://api.github.com/repos/aarb1/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/aarb1/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/aarb1/open-liberty/tags","blobs_url":"https://api.github.com/repos/aarb1/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aarb1/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aarb1/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/aarb1/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aarb1/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/aarb1/open-liberty/languages","stargazers_url":"https://api.github.com/repos/aarb1/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/aarb1/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/aarb1/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/aarb1/open-liberty/subscription","commits_url":"https://api.github.com/repos/aarb1/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/aarb1/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/aarb1/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/aarb1/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/aarb1/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/aarb1/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aarb1/open-liberty/merges","archive_url":"https://api.github.com/repos/aarb1/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aarb1/open-liberty/downloads","issues_url":"https://api.github.com/repos/aarb1/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/aarb1/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/aarb1/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/aarb1/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aarb1/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/aarb1/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/aarb1/open-liberty/deployments","created_at":"2017-10-02T20:08:07Z","updated_at":"2017-10-02T20:09:10Z","pushed_at":"2018-07-31T14:24:30Z","git_url":"git://github.com/aarb1/open-liberty.git","ssh_url":"git@github.com:aarb1/open-liberty.git","clone_url":"https://github.com/aarb1/open-liberty.git","svn_url":"https://github.com/aarb1/open-liberty","homepage":"http://openliberty.io","size":137088,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"831650de4fc59d8d40ab912446aacf7c37b719ac","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM2OTQzNzc=","name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-07-31T18:52:49Z","pushed_at":"2018-07-31T21:26:02Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":137236,"stargazers_count":323,"watchers_count":323,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"archived":false,"open_issues_count":520,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":259,"open_issues":520,"watchers":323,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3957"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3957"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3957/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3957/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/536359bd679d2acf513cdfff739aeb41f300af90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"donbourne"}}