{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/sagansystems/argo/pulls/2","id":174819262,"html_url":"https://github.com/sagansystems/argo/pull/2","diff_url":"https://github.com/sagansystems/argo/pull/2.diff","patch_url":"https://github.com/sagansystems/argo/pull/2.patch","issue_url":"https://api.github.com/repos/sagansystems/argo/issues/2","number":2,"state":"closed","locked":false,"title":"Add ability to pass pod annotations and labels at the template level","user":{"login":"wookasz","id":14184925,"avatar_url":"https://avatars1.githubusercontent.com/u/14184925?v=4","gravatar_id":"","url":"https://api.github.com/users/wookasz","html_url":"https://github.com/wookasz","followers_url":"https://api.github.com/users/wookasz/followers","following_url":"https://api.github.com/users/wookasz/following{/other_user}","gists_url":"https://api.github.com/users/wookasz/gists{/gist_id}","starred_url":"https://api.github.com/users/wookasz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wookasz/subscriptions","organizations_url":"https://api.github.com/users/wookasz/orgs","repos_url":"https://api.github.com/users/wookasz/repos","events_url":"https://api.github.com/users/wookasz/events{/privacy}","received_events_url":"https://api.github.com/users/wookasz/received_events","type":"User","site_admin":false},"body":"**What**\r\n- Add ability to set `template.metadata.annotations` and `template.metadata.labels` as pod metadata\r\n\r\n**Why**\r\nLabels are helpful when searching for k8s resources.\r\n\r\nAnnotations are another type of metadata k8s supports. They can be used by various tools like [kube2iam](https://github.com/jtblin/kube2iam).\r\n\r\n**Testing**\r\nAdd metadata to templates. Submit job. Test annotations and labels were added with `kubectl describe pod <pod-name>`. See `examples/pod-metadata.yaml`.\r\n\r\n**Who**\r\n@malexovi @yayalice \r\ncc: @darend @dominicbueno ","created_at":"2018-03-13T23:40:34Z","updated_at":"2018-03-14T23:10:11Z","closed_at":"2018-03-14T23:10:11Z","merged_at":"2018-03-14T23:10:11Z","merge_commit_sha":"8a572af364321fabddde12100d4df61043895c84","assignee":null,"assignees":[],"requested_reviewers":[{"login":"malexovi","id":1429340,"avatar_url":"https://avatars3.githubusercontent.com/u/1429340?v=4","gravatar_id":"","url":"https://api.github.com/users/malexovi","html_url":"https://github.com/malexovi","followers_url":"https://api.github.com/users/malexovi/followers","following_url":"https://api.github.com/users/malexovi/following{/other_user}","gists_url":"https://api.github.com/users/malexovi/gists{/gist_id}","starred_url":"https://api.github.com/users/malexovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malexovi/subscriptions","organizations_url":"https://api.github.com/users/malexovi/orgs","repos_url":"https://api.github.com/users/malexovi/repos","events_url":"https://api.github.com/users/malexovi/events{/privacy}","received_events_url":"https://api.github.com/users/malexovi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sagansystems/argo/pulls/2/commits","review_comments_url":"https://api.github.com/repos/sagansystems/argo/pulls/2/comments","review_comment_url":"https://api.github.com/repos/sagansystems/argo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sagansystems/argo/issues/2/comments","statuses_url":"https://api.github.com/repos/sagansystems/argo/statuses/f6dc27430bddf399f05ca1f7563c16cf00a4e07f","head":{"label":"sagansystems:wookasz/ch8116/add-pod-annotations-and-labels-to-argo","ref":"wookasz/ch8116/add-pod-annotations-and-labels-to-argo","sha":"f6dc27430bddf399f05ca1f7563c16cf00a4e07f","user":{"login":"sagansystems","id":9491187,"avatar_url":"https://avatars0.githubusercontent.com/u/9491187?v=4","gravatar_id":"","url":"https://api.github.com/users/sagansystems","html_url":"https://github.com/sagansystems","followers_url":"https://api.github.com/users/sagansystems/followers","following_url":"https://api.github.com/users/sagansystems/following{/other_user}","gists_url":"https://api.github.com/users/sagansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/sagansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagansystems/subscriptions","organizations_url":"https://api.github.com/users/sagansystems/orgs","repos_url":"https://api.github.com/users/sagansystems/repos","events_url":"https://api.github.com/users/sagansystems/events{/privacy}","received_events_url":"https://api.github.com/users/sagansystems/received_events","type":"Organization","site_admin":false},"repo":{"id":124976923,"name":"argo","full_name":"sagansystems/argo","owner":{"login":"sagansystems","id":9491187,"avatar_url":"https://avatars0.githubusercontent.com/u/9491187?v=4","gravatar_id":"","url":"https://api.github.com/users/sagansystems","html_url":"https://github.com/sagansystems","followers_url":"https://api.github.com/users/sagansystems/followers","following_url":"https://api.github.com/users/sagansystems/following{/other_user}","gists_url":"https://api.github.com/users/sagansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/sagansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagansystems/subscriptions","organizations_url":"https://api.github.com/users/sagansystems/orgs","repos_url":"https://api.github.com/users/sagansystems/repos","events_url":"https://api.github.com/users/sagansystems/events{/privacy}","received_events_url":"https://api.github.com/users/sagansystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sagansystems/argo","description":"Get stuff done with container-native workflows for Kubernetes.","fork":true,"url":"https://api.github.com/repos/sagansystems/argo","forks_url":"https://api.github.com/repos/sagansystems/argo/forks","keys_url":"https://api.github.com/repos/sagansystems/argo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagansystems/argo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagansystems/argo/teams","hooks_url":"https://api.github.com/repos/sagansystems/argo/hooks","issue_events_url":"https://api.github.com/repos/sagansystems/argo/issues/events{/number}","events_url":"https://api.github.com/repos/sagansystems/argo/events","assignees_url":"https://api.github.com/repos/sagansystems/argo/assignees{/user}","branches_url":"https://api.github.com/repos/sagansystems/argo/branches{/branch}","tags_url":"https://api.github.com/repos/sagansystems/argo/tags","blobs_url":"https://api.github.com/repos/sagansystems/argo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagansystems/argo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagansystems/argo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagansystems/argo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagansystems/argo/statuses/{sha}","languages_url":"https://api.github.com/repos/sagansystems/argo/languages","stargazers_url":"https://api.github.com/repos/sagansystems/argo/stargazers","contributors_url":"https://api.github.com/repos/sagansystems/argo/contributors","subscribers_url":"https://api.github.com/repos/sagansystems/argo/subscribers","subscription_url":"https://api.github.com/repos/sagansystems/argo/subscription","commits_url":"https://api.github.com/repos/sagansystems/argo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagansystems/argo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagansystems/argo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagansystems/argo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagansystems/argo/contents/{+path}","compare_url":"https://api.github.com/repos/sagansystems/argo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagansystems/argo/merges","archive_url":"https://api.github.com/repos/sagansystems/argo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagansystems/argo/downloads","issues_url":"https://api.github.com/repos/sagansystems/argo/issues{/number}","pulls_url":"https://api.github.com/repos/sagansystems/argo/pulls{/number}","milestones_url":"https://api.github.com/repos/sagansystems/argo/milestones{/number}","notifications_url":"https://api.github.com/repos/sagansystems/argo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagansystems/argo/labels{/name}","releases_url":"https://api.github.com/repos/sagansystems/argo/releases{/id}","deployments_url":"https://api.github.com/repos/sagansystems/argo/deployments","created_at":"2018-03-13T01:57:54Z","updated_at":"2018-03-13T02:35:54Z","pushed_at":"2018-03-14T23:10:11Z","git_url":"git://github.com/sagansystems/argo.git","ssh_url":"git@github.com:sagansystems/argo.git","clone_url":"https://github.com/sagansystems/argo.git","svn_url":"https://github.com/sagansystems/argo","homepage":"","size":17997,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sagansystems:master","ref":"master","sha":"624f0f48306183da33e2ef3aecf9566bb0ad8ad3","user":{"login":"sagansystems","id":9491187,"avatar_url":"https://avatars0.githubusercontent.com/u/9491187?v=4","gravatar_id":"","url":"https://api.github.com/users/sagansystems","html_url":"https://github.com/sagansystems","followers_url":"https://api.github.com/users/sagansystems/followers","following_url":"https://api.github.com/users/sagansystems/following{/other_user}","gists_url":"https://api.github.com/users/sagansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/sagansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagansystems/subscriptions","organizations_url":"https://api.github.com/users/sagansystems/orgs","repos_url":"https://api.github.com/users/sagansystems/repos","events_url":"https://api.github.com/users/sagansystems/events{/privacy}","received_events_url":"https://api.github.com/users/sagansystems/received_events","type":"Organization","site_admin":false},"repo":{"id":124976923,"name":"argo","full_name":"sagansystems/argo","owner":{"login":"sagansystems","id":9491187,"avatar_url":"https://avatars0.githubusercontent.com/u/9491187?v=4","gravatar_id":"","url":"https://api.github.com/users/sagansystems","html_url":"https://github.com/sagansystems","followers_url":"https://api.github.com/users/sagansystems/followers","following_url":"https://api.github.com/users/sagansystems/following{/other_user}","gists_url":"https://api.github.com/users/sagansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/sagansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagansystems/subscriptions","organizations_url":"https://api.github.com/users/sagansystems/orgs","repos_url":"https://api.github.com/users/sagansystems/repos","events_url":"https://api.github.com/users/sagansystems/events{/privacy}","received_events_url":"https://api.github.com/users/sagansystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sagansystems/argo","description":"Get stuff done with container-native workflows for Kubernetes.","fork":true,"url":"https://api.github.com/repos/sagansystems/argo","forks_url":"https://api.github.com/repos/sagansystems/argo/forks","keys_url":"https://api.github.com/repos/sagansystems/argo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagansystems/argo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagansystems/argo/teams","hooks_url":"https://api.github.com/repos/sagansystems/argo/hooks","issue_events_url":"https://api.github.com/repos/sagansystems/argo/issues/events{/number}","events_url":"https://api.github.com/repos/sagansystems/argo/events","assignees_url":"https://api.github.com/repos/sagansystems/argo/assignees{/user}","branches_url":"https://api.github.com/repos/sagansystems/argo/branches{/branch}","tags_url":"https://api.github.com/repos/sagansystems/argo/tags","blobs_url":"https://api.github.com/repos/sagansystems/argo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagansystems/argo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagansystems/argo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagansystems/argo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagansystems/argo/statuses/{sha}","languages_url":"https://api.github.com/repos/sagansystems/argo/languages","stargazers_url":"https://api.github.com/repos/sagansystems/argo/stargazers","contributors_url":"https://api.github.com/repos/sagansystems/argo/contributors","subscribers_url":"https://api.github.com/repos/sagansystems/argo/subscribers","subscription_url":"https://api.github.com/repos/sagansystems/argo/subscription","commits_url":"https://api.github.com/repos/sagansystems/argo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagansystems/argo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagansystems/argo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagansystems/argo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagansystems/argo/contents/{+path}","compare_url":"https://api.github.com/repos/sagansystems/argo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagansystems/argo/merges","archive_url":"https://api.github.com/repos/sagansystems/argo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagansystems/argo/downloads","issues_url":"https://api.github.com/repos/sagansystems/argo/issues{/number}","pulls_url":"https://api.github.com/repos/sagansystems/argo/pulls{/number}","milestones_url":"https://api.github.com/repos/sagansystems/argo/milestones{/number}","notifications_url":"https://api.github.com/repos/sagansystems/argo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagansystems/argo/labels{/name}","releases_url":"https://api.github.com/repos/sagansystems/argo/releases{/id}","deployments_url":"https://api.github.com/repos/sagansystems/argo/deployments","created_at":"2018-03-13T01:57:54Z","updated_at":"2018-03-13T02:35:54Z","pushed_at":"2018-03-14T23:10:11Z","git_url":"git://github.com/sagansystems/argo.git","ssh_url":"git@github.com:sagansystems/argo.git","clone_url":"https://github.com/sagansystems/argo.git","svn_url":"https://github.com/sagansystems/argo","homepage":"","size":17997,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sagansystems/argo/pulls/2"},"html":{"href":"https://github.com/sagansystems/argo/pull/2"},"issue":{"href":"https://api.github.com/repos/sagansystems/argo/issues/2"},"comments":{"href":"https://api.github.com/repos/sagansystems/argo/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/sagansystems/argo/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/sagansystems/argo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sagansystems/argo/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/sagansystems/argo/statuses/f6dc27430bddf399f05ca1f7563c16cf00a4e07f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wookasz","id":14184925,"avatar_url":"https://avatars1.githubusercontent.com/u/14184925?v=4","gravatar_id":"","url":"https://api.github.com/users/wookasz","html_url":"https://github.com/wookasz","followers_url":"https://api.github.com/users/wookasz/followers","following_url":"https://api.github.com/users/wookasz/following{/other_user}","gists_url":"https://api.github.com/users/wookasz/gists{/gist_id}","starred_url":"https://api.github.com/users/wookasz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wookasz/subscriptions","organizations_url":"https://api.github.com/users/wookasz/orgs","repos_url":"https://api.github.com/users/wookasz/repos","events_url":"https://api.github.com/users/wookasz/events{/privacy}","received_events_url":"https://api.github.com/users/wookasz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":82,"deletions":0,"changed_files":6}}
{"actor":{"display_login":"wookasz"}}