{"action":"created","comment":{"url":"https://api.github.com/repos/hishamhm/htop/pulls/comments/229468270","pull_request_review_id":169977871,"id":229468270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ2ODI3MA==","diff_hunk":"@@ -209,7 +209,7 @@ void OpenBSDProcess_writeField(Process* this, RichString* str, ProcessField fiel\n       Process_writeField(this, str, field);\n       return;\n    }\n-   RichString_append(str, attr, buffer);\n+   // RichString_append(str, attr, buffer); // <!-- unreachable","path":"openbsd/OpenBSDProcess.c","position":5,"original_position":5,"commit_id":"517a8a09544ee3769a6f75bb820a3d4d7f101b35","original_commit_id":"517a8a09544ee3769a6f75bb820a3d4d7f101b35","user":{"login":"hishamhm","id":245621,"node_id":"MDQ6VXNlcjI0NTYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"body":"for this one, it looks like the entire `OpenBSDProcess_writeField function` is there just as a placeholder to make it easier to add OpenBSD-specific fields in the future. The whole function could be removed and just replaced with `Process_writeField` in the definition of `OpenBSDProcess_class`. Did you add these comments to silence warnings in some specific platform?","created_at":"2018-10-30T20:13:41Z","updated_at":"2018-10-30T20:13:41Z","html_url":"https://github.com/hishamhm/htop/pull/838#discussion_r229468270","pull_request_url":"https://api.github.com/repos/hishamhm/htop/pulls/838","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/comments/229468270"},"html":{"href":"https://github.com/hishamhm/htop/pull/838#discussion_r229468270"},"pull_request":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/838"}}},"pull_request":{"url":"https://api.github.com/repos/hishamhm/htop/pulls/838","id":215843287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODQzMjg3","html_url":"https://github.com/hishamhm/htop/pull/838","diff_url":"https://github.com/hishamhm/htop/pull/838.diff","patch_url":"https://github.com/hishamhm/htop/pull/838.patch","issue_url":"https://api.github.com/repos/hishamhm/htop/issues/838","number":838,"state":"open","locked":false,"title":"*bsd: mark unreachable code with comment","user":{"login":"zebastian","id":7888201,"node_id":"MDQ6VXNlcjc4ODgyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7888201?v=4","gravatar_id":"","url":"https://api.github.com/users/zebastian","html_url":"https://github.com/zebastian","followers_url":"https://api.github.com/users/zebastian/followers","following_url":"https://api.github.com/users/zebastian/following{/other_user}","gists_url":"https://api.github.com/users/zebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/zebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebastian/subscriptions","organizations_url":"https://api.github.com/users/zebastian/orgs","repos_url":"https://api.github.com/users/zebastian/repos","events_url":"https://api.github.com/users/zebastian/events{/privacy}","received_events_url":"https://api.github.com/users/zebastian/received_events","type":"User","site_admin":false},"body":"This may be undesired and the code should be revisited by the maintainers of these two occurances.","created_at":"2018-09-16T20:26:23Z","updated_at":"2018-10-30T20:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a7eed2c58cd8d47467540c2da15ff8e7e133e97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hishamhm/htop/pulls/838/commits","review_comments_url":"https://api.github.com/repos/hishamhm/htop/pulls/838/comments","review_comment_url":"https://api.github.com/repos/hishamhm/htop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hishamhm/htop/issues/838/comments","statuses_url":"https://api.github.com/repos/hishamhm/htop/statuses/517a8a09544ee3769a6f75bb820a3d4d7f101b35","head":{"label":"zebastian:master","ref":"master","sha":"517a8a09544ee3769a6f75bb820a3d4d7f101b35","user":{"login":"zebastian","id":7888201,"node_id":"MDQ6VXNlcjc4ODgyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7888201?v=4","gravatar_id":"","url":"https://api.github.com/users/zebastian","html_url":"https://github.com/zebastian","followers_url":"https://api.github.com/users/zebastian/followers","following_url":"https://api.github.com/users/zebastian/following{/other_user}","gists_url":"https://api.github.com/users/zebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/zebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebastian/subscriptions","organizations_url":"https://api.github.com/users/zebastian/orgs","repos_url":"https://api.github.com/users/zebastian/repos","events_url":"https://api.github.com/users/zebastian/events{/privacy}","received_events_url":"https://api.github.com/users/zebastian/received_events","type":"User","site_admin":false},"repo":{"id":144463241,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NjMyNDE=","name":"htop","full_name":"zebastian/htop","private":false,"owner":{"login":"zebastian","id":7888201,"node_id":"MDQ6VXNlcjc4ODgyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7888201?v=4","gravatar_id":"","url":"https://api.github.com/users/zebastian","html_url":"https://github.com/zebastian","followers_url":"https://api.github.com/users/zebastian/followers","following_url":"https://api.github.com/users/zebastian/following{/other_user}","gists_url":"https://api.github.com/users/zebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/zebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebastian/subscriptions","organizations_url":"https://api.github.com/users/zebastian/orgs","repos_url":"https://api.github.com/users/zebastian/repos","events_url":"https://api.github.com/users/zebastian/events{/privacy}","received_events_url":"https://api.github.com/users/zebastian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zebastian/htop","description":"htop is an interactive text-mode process viewer for Unix systems. It aims to be a better 'top'.","fork":true,"url":"https://api.github.com/repos/zebastian/htop","forks_url":"https://api.github.com/repos/zebastian/htop/forks","keys_url":"https://api.github.com/repos/zebastian/htop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zebastian/htop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zebastian/htop/teams","hooks_url":"https://api.github.com/repos/zebastian/htop/hooks","issue_events_url":"https://api.github.com/repos/zebastian/htop/issues/events{/number}","events_url":"https://api.github.com/repos/zebastian/htop/events","assignees_url":"https://api.github.com/repos/zebastian/htop/assignees{/user}","branches_url":"https://api.github.com/repos/zebastian/htop/branches{/branch}","tags_url":"https://api.github.com/repos/zebastian/htop/tags","blobs_url":"https://api.github.com/repos/zebastian/htop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zebastian/htop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zebastian/htop/git/refs{/sha}","trees_url":"https://api.github.com/repos/zebastian/htop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zebastian/htop/statuses/{sha}","languages_url":"https://api.github.com/repos/zebastian/htop/languages","stargazers_url":"https://api.github.com/repos/zebastian/htop/stargazers","contributors_url":"https://api.github.com/repos/zebastian/htop/contributors","subscribers_url":"https://api.github.com/repos/zebastian/htop/subscribers","subscription_url":"https://api.github.com/repos/zebastian/htop/subscription","commits_url":"https://api.github.com/repos/zebastian/htop/commits{/sha}","git_commits_url":"https://api.github.com/repos/zebastian/htop/git/commits{/sha}","comments_url":"https://api.github.com/repos/zebastian/htop/comments{/number}","issue_comment_url":"https://api.github.com/repos/zebastian/htop/issues/comments{/number}","contents_url":"https://api.github.com/repos/zebastian/htop/contents/{+path}","compare_url":"https://api.github.com/repos/zebastian/htop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zebastian/htop/merges","archive_url":"https://api.github.com/repos/zebastian/htop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zebastian/htop/downloads","issues_url":"https://api.github.com/repos/zebastian/htop/issues{/number}","pulls_url":"https://api.github.com/repos/zebastian/htop/pulls{/number}","milestones_url":"https://api.github.com/repos/zebastian/htop/milestones{/number}","notifications_url":"https://api.github.com/repos/zebastian/htop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zebastian/htop/labels{/name}","releases_url":"https://api.github.com/repos/zebastian/htop/releases{/id}","deployments_url":"https://api.github.com/repos/zebastian/htop/deployments","created_at":"2018-08-12T12:03:26Z","updated_at":"2018-09-16T20:10:07Z","pushed_at":"2018-09-16T20:10:02Z","git_url":"git://github.com/zebastian/htop.git","ssh_url":"git@github.com:zebastian/htop.git","clone_url":"https://github.com/zebastian/htop.git","svn_url":"https://github.com/zebastian/htop","homepage":"","size":2610,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hishamhm:master","ref":"master","sha":"67e368914a1b03cbf18c4c7b678f424f5e18ad2e","user":{"login":"hishamhm","id":245621,"node_id":"MDQ6VXNlcjI0NTYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"repo":{"id":15884926,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4NDkyNg==","name":"htop","full_name":"hishamhm/htop","private":false,"owner":{"login":"hishamhm","id":245621,"node_id":"MDQ6VXNlcjI0NTYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hishamhm/htop","description":"htop is an interactive text-mode process viewer for Unix systems. It aims to be a better 'top'.","fork":false,"url":"https://api.github.com/repos/hishamhm/htop","forks_url":"https://api.github.com/repos/hishamhm/htop/forks","keys_url":"https://api.github.com/repos/hishamhm/htop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hishamhm/htop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hishamhm/htop/teams","hooks_url":"https://api.github.com/repos/hishamhm/htop/hooks","issue_events_url":"https://api.github.com/repos/hishamhm/htop/issues/events{/number}","events_url":"https://api.github.com/repos/hishamhm/htop/events","assignees_url":"https://api.github.com/repos/hishamhm/htop/assignees{/user}","branches_url":"https://api.github.com/repos/hishamhm/htop/branches{/branch}","tags_url":"https://api.github.com/repos/hishamhm/htop/tags","blobs_url":"https://api.github.com/repos/hishamhm/htop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hishamhm/htop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hishamhm/htop/git/refs{/sha}","trees_url":"https://api.github.com/repos/hishamhm/htop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hishamhm/htop/statuses/{sha}","languages_url":"https://api.github.com/repos/hishamhm/htop/languages","stargazers_url":"https://api.github.com/repos/hishamhm/htop/stargazers","contributors_url":"https://api.github.com/repos/hishamhm/htop/contributors","subscribers_url":"https://api.github.com/repos/hishamhm/htop/subscribers","subscription_url":"https://api.github.com/repos/hishamhm/htop/subscription","commits_url":"https://api.github.com/repos/hishamhm/htop/commits{/sha}","git_commits_url":"https://api.github.com/repos/hishamhm/htop/git/commits{/sha}","comments_url":"https://api.github.com/repos/hishamhm/htop/comments{/number}","issue_comment_url":"https://api.github.com/repos/hishamhm/htop/issues/comments{/number}","contents_url":"https://api.github.com/repos/hishamhm/htop/contents/{+path}","compare_url":"https://api.github.com/repos/hishamhm/htop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hishamhm/htop/merges","archive_url":"https://api.github.com/repos/hishamhm/htop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hishamhm/htop/downloads","issues_url":"https://api.github.com/repos/hishamhm/htop/issues{/number}","pulls_url":"https://api.github.com/repos/hishamhm/htop/pulls{/number}","milestones_url":"https://api.github.com/repos/hishamhm/htop/milestones{/number}","notifications_url":"https://api.github.com/repos/hishamhm/htop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hishamhm/htop/labels{/name}","releases_url":"https://api.github.com/repos/hishamhm/htop/releases{/id}","deployments_url":"https://api.github.com/repos/hishamhm/htop/deployments","created_at":"2014-01-13T22:58:20Z","updated_at":"2018-10-30T19:56:10Z","pushed_at":"2018-10-30T19:55:56Z","git_url":"git://github.com/hishamhm/htop.git","ssh_url":"git@github.com:hishamhm/htop.git","clone_url":"https://github.com/hishamhm/htop.git","svn_url":"https://github.com/hishamhm/htop","homepage":"","size":2624,"stargazers_count":3578,"watchers_count":3578,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":408,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":408,"open_issues":177,"watchers":3578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/838"},"html":{"href":"https://github.com/hishamhm/htop/pull/838"},"issue":{"href":"https://api.github.com/repos/hishamhm/htop/issues/838"},"comments":{"href":"https://api.github.com/repos/hishamhm/htop/issues/838/comments"},"review_comments":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/838/comments"},"review_comment":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hishamhm/htop/pulls/838/commits"},"statuses":{"href":"https://api.github.com/repos/hishamhm/htop/statuses/517a8a09544ee3769a6f75bb820a3d4d7f101b35"}},"author_association":"NONE"}}
{"actor":{"display_login":"hishamhm"}}