{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/comments/218760843","pull_request_review_id":156767048,"id":218760843,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc2MDg0Mw==","diff_hunk":"@@ -112,8 +112,10 @@ sub collect_data {\n     upload_logs('/var/tmp/var_log.tar.gz');\n \n     # Run eos-diagnostics and upload its results\n-    assert_script_run('eos-diagnostics /var/tmp/eos-diagnostics.txt');\n-    upload_logs('/var/tmp/eos-diagnostics.txt');\n+    # Older versions of it can fail if $DISPLAY isn’t set","path":"lib/installedtest.pm","position":null,"original_position":6,"commit_id":"6cb5ba2edbabea3cf0869ab04c6ae67a4f8cf34e","original_commit_id":"941b6239f8e0931170fc7b4527324d0d89869118","user":{"login":"pwithnall","id":53172,"node_id":"MDQ6VXNlcjUzMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"body":"I don’t think it’s worth doing the more-elaborate workaround, since this code is mainly used to diagnose test failures — which we will typically see on nightly images which already contain the `eos-diagnostics` fix. It might be useful for diagnosing test failures on newly-tested old releases (e.g. when testing the 3.3 → 3.4 upgrade path) but I’m happy to burn that bridge when we come to it.","created_at":"2018-09-19T11:08:24Z","updated_at":"2018-09-19T11:08:25Z","html_url":"https://github.com/endlessm/eos-openqa-tests/pull/5#discussion_r218760843","pull_request_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/comments/218760843"},"html":{"href":"https://github.com/endlessm/eos-openqa-tests/pull/5#discussion_r218760843"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5"}},"in_reply_to_id":218499812},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5","id":215011450,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDExNDUw","html_url":"https://github.com/endlessm/eos-openqa-tests/pull/5","diff_url":"https://github.com/endlessm/eos-openqa-tests/pull/5.diff","patch_url":"https://github.com/endlessm/eos-openqa-tests/pull/5.patch","issue_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/5","number":5,"state":"open","locked":false,"title":"T23739 Release smoketests","user":{"login":"pwithnall","id":53172,"node_id":"MDQ6VXNlcjUzMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"body":"Ready for review. The encyclopedia test works now.\r\n\r\nhttps://phabricator.endlessm.com/T23739","created_at":"2018-09-12T15:49:57Z","updated_at":"2018-09-19T11:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d71338b4a242d0c9d7aff7b050155cb540be344a","assignee":{"login":"pwithnall","id":53172,"node_id":"MDQ6VXNlcjUzMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwithnall","id":53172,"node_id":"MDQ6VXNlcjUzMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ramcq","id":254468,"node_id":"MDQ6VXNlcjI1NDQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/254468?v=4","gravatar_id":"","url":"https://api.github.com/users/ramcq","html_url":"https://github.com/ramcq","followers_url":"https://api.github.com/users/ramcq/followers","following_url":"https://api.github.com/users/ramcq/following{/other_user}","gists_url":"https://api.github.com/users/ramcq/gists{/gist_id}","starred_url":"https://api.github.com/users/ramcq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramcq/subscriptions","organizations_url":"https://api.github.com/users/ramcq/orgs","repos_url":"https://api.github.com/users/ramcq/repos","events_url":"https://api.github.com/users/ramcq/events{/privacy}","received_events_url":"https://api.github.com/users/ramcq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/5/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/statuses/6cb5ba2edbabea3cf0869ab04c6ae67a4f8cf34e","head":{"label":"endlessm:T23739-release-tests","ref":"T23739-release-tests","sha":"6cb5ba2edbabea3cf0869ab04c6ae67a4f8cf34e","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":140021797,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjE3OTc=","name":"eos-openqa-tests","full_name":"endlessm/eos-openqa-tests","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/eos-openqa-tests","description":"Integration tests to run on Endless OS in OpenQA","fork":false,"url":"https://api.github.com/repos/endlessm/eos-openqa-tests","forks_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/forks","keys_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/events","assignees_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/merges","archive_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/deployments","created_at":"2018-07-06T19:15:07Z","updated_at":"2018-09-12T03:58:58Z","pushed_at":"2018-09-19T11:06:28Z","git_url":"git://github.com/endlessm/eos-openqa-tests.git","ssh_url":"git@github.com:endlessm/eos-openqa-tests.git","clone_url":"https://github.com/endlessm/eos-openqa-tests.git","svn_url":"https://github.com/endlessm/eos-openqa-tests","homepage":"","size":35828,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"659ece9793b4582c0bfe0489c04558b5354585f2","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":140021797,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjE3OTc=","name":"eos-openqa-tests","full_name":"endlessm/eos-openqa-tests","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/eos-openqa-tests","description":"Integration tests to run on Endless OS in OpenQA","fork":false,"url":"https://api.github.com/repos/endlessm/eos-openqa-tests","forks_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/forks","keys_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/events","assignees_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/merges","archive_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-openqa-tests/deployments","created_at":"2018-07-06T19:15:07Z","updated_at":"2018-09-12T03:58:58Z","pushed_at":"2018-09-19T11:06:28Z","git_url":"git://github.com/endlessm/eos-openqa-tests.git","ssh_url":"git@github.com:endlessm/eos-openqa-tests.git","clone_url":"https://github.com/endlessm/eos-openqa-tests.git","svn_url":"https://github.com/endlessm/eos-openqa-tests","homepage":"","size":35828,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5"},"html":{"href":"https://github.com/endlessm/eos-openqa-tests/pull/5"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/5"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-openqa-tests/statuses/6cb5ba2edbabea3cf0869ab04c6ae67a4f8cf34e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pwithnall"}}