{"action":"created","issue":{"url":"https://api.github.com/repos/heptio/ark/issues/455","repository_url":"https://api.github.com/repos/heptio/ark","labels_url":"https://api.github.com/repos/heptio/ark/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/heptio/ark/issues/455/comments","events_url":"https://api.github.com/repos/heptio/ark/issues/455/events","html_url":"https://github.com/heptio/ark/pull/455","id":317365940,"number":455,"title":"AWS: remove region requirement from config for backupStorageProvider","user":{"login":"skriss","id":5241206,"avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"labels":[{"id":808831320,"url":"https://api.github.com/repos/heptio/ark/labels/cloudprovider/aws","name":"cloudprovider/aws","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-24T19:36:05Z","updated_at":"2018-04-24T19:59:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/455","html_url":"https://github.com/heptio/ark/pull/455","diff_url":"https://github.com/heptio/ark/pull/455.diff","patch_url":"https://github.com/heptio/ark/pull/455.patch"},"body":"Signed-off-by: Steve Kriss <steve@heptio.com>\r\n\r\nI learned yesterday that we can do this! See https://docs.aws.amazon.com/sdk-for-go/api/service/s3/s3manager/#GetBucketRegion\r\n\r\nI'm going to suggest leaving the examples/docs as-is for now so we don't get the usual slew of questions due to folks using master docs but an older Ark version."},"comment":{"url":"https://api.github.com/repos/heptio/ark/issues/comments/384060218","html_url":"https://github.com/heptio/ark/pull/455#issuecomment-384060218","issue_url":"https://api.github.com/repos/heptio/ark/issues/455","id":384060218,"user":{"login":"skriss","id":5241206,"avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T19:59:01Z","updated_at":"2018-04-24T19:59:01Z","author_association":"CONTRIBUTOR","body":"I think we could do it without the `GenericAWS` struct:\r\n- if `s3Url` is empty, that means it's really AWS. Use this code to get the bucket's region\r\n- if `s3Url` is not empty, it's some other AWS-compatible API. The user can specify `region` in their config if it's needed (e.g. IBM) and it'll flow through; if it's not needed, it doesn't have to be specified in config."}}
{"actor":{"display_login":"skriss"}}