{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/comments/208249047","pull_request_review_id":144015667,"id":208249047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI0OTA0Nw==","diff_hunk":"@@ -106,14 +105,19 @@ func (c *client) GetPrimaryVNICForInstance(ctx context.Context, compartmentID, i\n \n \t\tfor _, attachment := range resp.Items {\n \t\t\tif attachment.LifecycleState != core.VnicAttachmentLifecycleStateAttached {\n-\t\t\t\tglog.Infof(\"VNIC attachment %q for instance %q has a state of %q (not %q)\",\n-\t\t\t\t\t*attachment.Id, instanceID, attachment.LifecycleState, core.VnicAttachmentLifecycleStateAttached)\n+\t\t\t\tc.logger.With(","path":"pkg/oci/client/compute.go","position":14,"original_position":14,"commit_id":"17c1e34d4d067ec26d3b7def749ce1b856e2c7d8","original_commit_id":"17c1e34d4d067ec26d3b7def749ce1b856e2c7d8","user":{"login":"jhorwit2","id":3876739,"node_id":"MDQ6VXNlcjM4NzY3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3876739?v=4","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},"body":"You should create a context logger at the beginning of this method call with instance (and maybe compartment id) as fields. ","created_at":"2018-08-07T14:18:08Z","updated_at":"2018-08-07T14:26:44Z","html_url":"https://github.com/oracle/oci-cloud-controller-manager/pull/223#discussion_r208249047","pull_request_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/comments/208249047"},"html":{"href":"https://github.com/oracle/oci-cloud-controller-manager/pull/223#discussion_r208249047"},"pull_request":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223","id":205072684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDcyNjg0","html_url":"https://github.com/oracle/oci-cloud-controller-manager/pull/223","diff_url":"https://github.com/oracle/oci-cloud-controller-manager/pull/223.diff","patch_url":"https://github.com/oracle/oci-cloud-controller-manager/pull/223.patch","issue_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/223","number":223,"state":"open","locked":false,"title":"Migrate to zap logger","user":{"login":"prydie","id":244160,"node_id":"MDQ6VXNlcjI0NDE2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/244160?v=4","gravatar_id":"","url":"https://api.github.com/users/prydie","html_url":"https://github.com/prydie","followers_url":"https://api.github.com/users/prydie/followers","following_url":"https://api.github.com/users/prydie/following{/other_user}","gists_url":"https://api.github.com/users/prydie/gists{/gist_id}","starred_url":"https://api.github.com/users/prydie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydie/subscriptions","organizations_url":"https://api.github.com/users/prydie/orgs","repos_url":"https://api.github.com/users/prydie/repos","events_url":"https://api.github.com/users/prydie/events{/privacy}","received_events_url":"https://api.github.com/users/prydie/received_events","type":"User","site_admin":false},"body":"Migrates logging from to `go.uber.org/zap` from `github.com/golang/glog` and adds the following flags:\r\n\r\n```\r\n--log-level=debug  # control log level\r\n--log-json  # output log as json\r\n--logfile-path  # if provided reload\r\n```\r\n\r\n```\r\n❯ dist/oci-cloud-controller-manager         \\\r\n    --kubeconfig=${KUBECONFIG}              \\\r\n    --cloud-config=${CLOUD_PROVIDER_CFG}    \\\r\n    --cluster-cidr=10.244.0.0/16            \\\r\n    --leader-elect-resource-lock=configmaps \\\r\n    --cloud-provider=oci                    \\\r\n    --log-json                              \\\r\n    --logfile-path=\"test.log\" &\r\n❯ head -n 1 test.log\r\n{\"level\":\"info\",\"ts\":\"2018-07-31T09:54:33.504+0100\",\"caller\":\"oci/ccm.go:220\",\"msg\":\"Using raw configuration provider\"}\r\n```","created_at":"2018-07-31T10:54:52Z","updated_at":"2018-08-07T14:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea59fd419fb384a8d607535c1fe369c5008dd1f3","assignee":{"login":"owainlewis","id":733944,"node_id":"MDQ6VXNlcjczMzk0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/733944?v=4","gravatar_id":"","url":"https://api.github.com/users/owainlewis","html_url":"https://github.com/owainlewis","followers_url":"https://api.github.com/users/owainlewis/followers","following_url":"https://api.github.com/users/owainlewis/following{/other_user}","gists_url":"https://api.github.com/users/owainlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/owainlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owainlewis/subscriptions","organizations_url":"https://api.github.com/users/owainlewis/orgs","repos_url":"https://api.github.com/users/owainlewis/repos","events_url":"https://api.github.com/users/owainlewis/events{/privacy}","received_events_url":"https://api.github.com/users/owainlewis/received_events","type":"User","site_admin":false},"assignees":[{"login":"owainlewis","id":733944,"node_id":"MDQ6VXNlcjczMzk0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/733944?v=4","gravatar_id":"","url":"https://api.github.com/users/owainlewis","html_url":"https://github.com/owainlewis","followers_url":"https://api.github.com/users/owainlewis/followers","following_url":"https://api.github.com/users/owainlewis/following{/other_user}","gists_url":"https://api.github.com/users/owainlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/owainlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owainlewis/subscriptions","organizations_url":"https://api.github.com/users/owainlewis/orgs","repos_url":"https://api.github.com/users/owainlewis/repos","events_url":"https://api.github.com/users/owainlewis/events{/privacy}","received_events_url":"https://api.github.com/users/owainlewis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":684479759,"node_id":"MDU6TGFiZWw2ODQ0Nzk3NTk=","url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223/commits","review_comments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223/comments","review_comment_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/223/comments","statuses_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/statuses/17c1e34d4d067ec26d3b7def749ce1b856e2c7d8","head":{"label":"oracle:ap/zap","ref":"ap/zap","sha":"17c1e34d4d067ec26d3b7def749ce1b856e2c7d8","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":102544030,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDQwMzA=","name":"oci-cloud-controller-manager","full_name":"oracle/oci-cloud-controller-manager","owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/oci-cloud-controller-manager","description":"Kubernetes Cloud Controller Manager implementation for Oracle Cloud Infrastucture","fork":false,"url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager","forks_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/forks","keys_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/teams","hooks_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/hooks","issue_events_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/events","assignees_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/tags","blobs_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/languages","stargazers_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/stargazers","contributors_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/contributors","subscribers_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/subscribers","subscription_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/subscription","commits_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/merges","archive_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/downloads","issues_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/labels{/name}","releases_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/deployments","created_at":"2017-09-06T00:40:07Z","updated_at":"2018-08-07T14:02:48Z","pushed_at":"2018-08-07T14:11:53Z","git_url":"git://github.com/oracle/oci-cloud-controller-manager.git","ssh_url":"git@github.com:oracle/oci-cloud-controller-manager.git","clone_url":"https://github.com/oracle/oci-cloud-controller-manager.git","svn_url":"https://github.com/oracle/oci-cloud-controller-manager","homepage":"","size":83382,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":26,"watchers":16,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"0c1466ee8c5c2a0fe0d5709a64c8a8f531d44842","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":102544030,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDQwMzA=","name":"oci-cloud-controller-manager","full_name":"oracle/oci-cloud-controller-manager","owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/oci-cloud-controller-manager","description":"Kubernetes Cloud Controller Manager implementation for Oracle Cloud Infrastucture","fork":false,"url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager","forks_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/forks","keys_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/teams","hooks_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/hooks","issue_events_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/events","assignees_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/tags","blobs_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/languages","stargazers_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/stargazers","contributors_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/contributors","subscribers_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/subscribers","subscription_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/subscription","commits_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/merges","archive_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/downloads","issues_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/labels{/name}","releases_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/deployments","created_at":"2017-09-06T00:40:07Z","updated_at":"2018-08-07T14:02:48Z","pushed_at":"2018-08-07T14:11:53Z","git_url":"git://github.com/oracle/oci-cloud-controller-manager.git","ssh_url":"git@github.com:oracle/oci-cloud-controller-manager.git","clone_url":"https://github.com/oracle/oci-cloud-controller-manager.git","svn_url":"https://github.com/oracle/oci-cloud-controller-manager","homepage":"","size":83382,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":26,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223"},"html":{"href":"https://github.com/oracle/oci-cloud-controller-manager/pull/223"},"issue":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/223"},"comments":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/oci-cloud-controller-manager/statuses/17c1e34d4d067ec26d3b7def749ce1b856e2c7d8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jhorwit2"}}