{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/14710","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/14710/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/14710/comments","events_url":"https://api.github.com/repos/apple/swift/issues/14710/events","html_url":"https://github.com/apple/swift/pull/14710","id":298135756,"number":14710,"title":"IRGen: adjust protocol conformance references in PE/COFF","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-19T00:50:19Z","updated_at":"2018-02-28T23:39:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/14710","html_url":"https://github.com/apple/swift/pull/14710","diff_url":"https://github.com/apple/swift/pull/14710.diff","patch_url":"https://github.com/apple/swift/pull/14710.patch"},"body":"There is no GOT on PE/COFF.  However, the IAT entries serve the same\r\npurpose.  Use the synthetic symbol which will be initialized externally\r\nby the loader to compute the address.  This allows for cross-module\r\nprotocol references on Windows.\r\n\r\n<!-- What's in this pull request? -->\r\nReplace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/369422293","html_url":"https://github.com/apple/swift/pull/14710#issuecomment-369422293","issue_url":"https://api.github.com/repos/apple/swift/issues/14710","id":369422293,"user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T23:39:22Z","updated_at":"2018-02-28T23:39:22Z","author_association":"COLLABORATOR","body":"@swift-ci please test and merge"}}
{"actor":{"display_login":"compnerd"}}