{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70494","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70494/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70494/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70494/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70494","id":376062137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzY0NjY1","number":70494,"title":"Ignore non socket files in the kubelet plugin watcher","user":{"login":"RenaudWasTaken","id":2519571,"node_id":"MDQ6VXNlcjI1MTk1NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/2519571?v=4","gravatar_id":"","url":"https://api.github.com/users/RenaudWasTaken","html_url":"https://github.com/RenaudWasTaken","followers_url":"https://api.github.com/users/RenaudWasTaken/followers","following_url":"https://api.github.com/users/RenaudWasTaken/following{/other_user}","gists_url":"https://api.github.com/users/RenaudWasTaken/gists{/gist_id}","starred_url":"https://api.github.com/users/RenaudWasTaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RenaudWasTaken/subscriptions","organizations_url":"https://api.github.com/users/RenaudWasTaken/orgs","repos_url":"https://api.github.com/users/RenaudWasTaken/repos","events_url":"https://api.github.com/users/RenaudWasTaken/events{/privacy}","received_events_url":"https://api.github.com/users/RenaudWasTaken/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40","html_url":"https://github.com/kubernetes/kubernetes/milestone/40","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40/labels","id":2913713,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMw==","number":40,"title":"v1.13","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":254,"state":"open","created_at":"2017-11-15T06:32:59Z","updated_at":"2018-11-17T00:41:04Z","due_on":null,"closed_at":null},"comments":36,"created_at":"2018-10-31T16:52:43Z","updated_at":"2018-11-17T00:58:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70494","html_url":"https://github.com/kubernetes/kubernetes/pull/70494","diff_url":"https://github.com/kubernetes/kubernetes/pull/70494.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70494.patch"},"body":"**What type of PR is this?**\r\n/kind bug\r\n/sig node\r\n\r\n**What this PR does / why we need it**: Makes sure the pluginwatcher ignores non socket files.\r\n\r\n**Which issue(s) this PR fixes** : Fixes https://github.com/kubernetes/kubernetes/issues/69015\r\n\r\n**Special notes for your reviewer**:\r\nWill post a list of plugins using the pluginwatcher mechanism and where they place the socket.\r\ncc @vladimirvivien @vikaschoudhary16 @figo \r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nKubelet Device Plugin Registration directory changed from from `{kubelet_root_dir}/plugins/` to `{kubelet_root_dir}/plugins_registry/`. Any drivers (CSI or device plugin) that were using the old path must be updated to work with this version.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/439572641","html_url":"https://github.com/kubernetes/kubernetes/pull/70494#issuecomment-439572641","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70494","id":439572641,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU3MjY0MQ==","user":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T00:58:53Z","updated_at":"2018-11-17T00:58:53Z","author_association":"MEMBER","body":"/priority critical-urgent"}}
{"actor":{"display_login":"saad-ali"}}