{"action":"created","issue":{"url":"https://api.github.com/repos/ODM2/ODM2/issues/142","repository_url":"https://api.github.com/repos/ODM2/ODM2","labels_url":"https://api.github.com/repos/ODM2/ODM2/issues/142/labels{/name}","comments_url":"https://api.github.com/repos/ODM2/ODM2/issues/142/comments","events_url":"https://api.github.com/repos/ODM2/ODM2/issues/142/events","html_url":"https://github.com/ODM2/ODM2/issues/142","id":251307656,"number":142,"title":"Resolve inconsistencies between SamplingFeatureTypeCV & SiteTypeCV","user":{"login":"aufdenkampe","id":5166036,"avatar_url":"https://avatars0.githubusercontent.com/u/5166036?v=4","gravatar_id":"","url":"https://api.github.com/users/aufdenkampe","html_url":"https://github.com/aufdenkampe","followers_url":"https://api.github.com/users/aufdenkampe/followers","following_url":"https://api.github.com/users/aufdenkampe/following{/other_user}","gists_url":"https://api.github.com/users/aufdenkampe/gists{/gist_id}","starred_url":"https://api.github.com/users/aufdenkampe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aufdenkampe/subscriptions","organizations_url":"https://api.github.com/users/aufdenkampe/orgs","repos_url":"https://api.github.com/users/aufdenkampe/repos","events_url":"https://api.github.com/users/aufdenkampe/events{/privacy}","received_events_url":"https://api.github.com/users/aufdenkampe/received_events","type":"User","site_admin":false},"labels":[{"id":90013808,"url":"https://api.github.com/repos/ODM2/ODM2/labels/ODM2.1?","name":"ODM2.1?","color":"fef2c0","default":false},{"id":181299072,"url":"https://api.github.com/repos/ODM2/ODM2/labels/ODM2CV","name":"ODM2CV","color":"bfe5bf","default":false},{"id":83193046,"url":"https://api.github.com/repos/ODM2/ODM2/labels/priority","name":"priority","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-18T17:18:14Z","updated_at":"2018-05-02T15:12:09Z","closed_at":null,"author_association":"OWNER","body":"Issues persistently arise because of overlap and inconsistencies between the ODM2 [SamplingFeatureType](http://vocabulary.odm2.org/samplingfeaturetype/) & [SiteType](http://vocabulary.odm2.org/sitetype/) vocabularies, that we've been aware of since we made the choice in November 2014 to adopt USGS Site Types and OGC O&M Sampling Feature Types (see #64), which we had to do in haste to focus on other priorities. We described some of the issues in our [2015-10-09 BiGCZ Notes, item 3 on ODM2 Vocabularies that we need to revisit](https://docs.google.com/document/d/1Ok_lN37hdDXjD8H_ElOIRYbAHJ4_WPAPyxx0iiuSR8k/edit#bookmark=id.hmtel9nnfwn6), and the issue is raising it's head again as we use SiteTypes for Data.EnviroDIY (see https://github.com/ODM2/ODM2WebSDL/issues/28) and as we consider developing a Feature of Interest schema for ODM2.1 (see #132).\r\n\r\nHere is a recap of the issues, adapted from our our [2015-10-09 BiGCZ Notes](https://docs.google.com/document/d/1Ok_lN37hdDXjD8H_ElOIRYbAHJ4_WPAPyxx0iiuSR8k/edit#bookmark=id.hmtel9nnfwn6). For context, it is helpful to see the [Entity Relation Diagram for our ODM2SamplingFeatures](http://odm2.github.io/ODM2/schemas/ODM2_Current/diagrams/ODM2SamplingFeatures.html) schema: \r\n![Image of ODM2SamplingFeatures](http://odm2.github.io/ODM2/schemas/ODM2_Current/diagrams/ODM2SamplingFeatures.png)\r\n\r\n### [SiteType](http://vocabulary.odm2.org/sitetype/)\r\nFor additional info also see in our [ODM2_SiteTypeCV](https://docs.google.com/spreadsheets/d/1WkoVWlK22aoaO4tnsYF7coEZK2GUe1x1NKGlzb3sP9A/edit#gid=276228256) Google Sheet.\r\n\r\nIssues: \r\n* The purpose of having the special “Sites” subclass of Sampling Features was to explicitly add a Lat & Lon (and to be able to attach a more specific site vocabulary). \r\n* Existing terms were taken from [USGS NWIS Site Types](https://maps.waterdata.usgs.gov/mapper/help/sitetype.html) and most of these are really Feature of Interest Types. Most of these terms do not readily fit to a Sampling Feature that can have a single Lat/Lon. In addition, note that we excluded many of the [USGS NWIS Site Types](https://maps.waterdata.usgs.gov/mapper/help/sitetype.html) that were clearly Sampling Features, because we considered them for the [ODM2_SamplingFeatureTypeCV](https://docs.google.com/spreadsheets/d/1mZBAMghH3sJx-botrEno83q5qTVC_C6nMMUmNZxLu3w/edit#gid=276228256).\r\n\r\n### [SamplingFeatureType](http://vocabulary.odm2.org/samplingfeaturetype/)\r\nFor additional info also see in our [ODM2_SamplingFeatureTypeCV](https://docs.google.com/spreadsheets/d/1mZBAMghH3sJx-botrEno83q5qTVC_C6nMMUmNZxLu3w/edit#gid=276228256) Google Sheet.\r\n\r\nIssues:\r\n* This CV was primarily populated from [OGC O&M Sampling Features classified by shape](https://www.seegrid.csiro.au/wiki/AppSchemas/ObservationsAndSampling#Sampling_features_classified_by_shape), with terms assigned to one of these four categories: Specimen, SamplingPoint, SamplingCurve, SamplingSurface, or SamplingSolid. Note in our [ODM2_SamplingFeatureTypeCV](https://docs.google.com/spreadsheets/d/1mZBAMghH3sJx-botrEno83q5qTVC_C6nMMUmNZxLu3w/edit#gid=276228256) Google Sheet (rows highlighted red at bottom) that we did not adopt many of the terms used in the O&M examples. Also there were many USGS Site Types that initially considered, because they were clearly sampling features, but then ultimately excluded because we were worried about overlap with the OGC O&M list.\r\n* Many of these could be considered as a Type of Site (i.e Borehole, Stream gage, Water quality station, Weather station), with a single Lat/Lon, or Type of Specimen (i.e. Depth Interval)\r\n\r\n### Summary\r\nWe developed the ODM2 Sampling Features schema asynchronously with the related ODM2 Vocabularies, somewhat in haste and due to many other pressing priorities. Our desire to use [USGS NWIS Site Types](https://maps.waterdata.usgs.gov/mapper/help/sitetype.html) for ease of integration, clashed with the fact that NWIS Site Types have a lot of conceptual overloading and inconsistency (like their Parameters!). All of this resulted in a bit of a mess, but one that should be readily fixable by changing the terms in the CV, without needing to change the ODM2 schema (at least until we want to add in a new FeaturesOfInterest table, but that can happen later and probably won't change existing tables).\r\n\r\n### Solution?\r\n1. We might move out of the SamplingFeatureTypeCV all the terms that are categorized as SamplingPoints, and move these terms into the ODM2 SiteTypeCV.\r\n2. Most of the USGS NWIS Site Types presently in the ODM2 SiteTypeCV should be moved into a draft ODM2 FeaturesOfInterestTypeCV.\r\n  a. Candidates would be any term that doesn't define a SamplingFeatureType (remember that ODM2 Sites are a subclass of ODM2 Sampling Features) and can't easily be assigned a single Lat/Lon.\r\n  b. See issue #132 that requests a new Feature of Interest extension (for ODM2.1?).\r\n3. Add to the ODM2 SiteTypeCV the terms from USGS NWIS Site Types that we had once considered as SamplingFeatures (see rows highlighted red at bottom of our [ODM2_SamplingFeatureTypeCV](https://docs.google.com/spreadsheets/d/1mZBAMghH3sJx-botrEno83q5qTVC_C6nMMUmNZxLu3w/edit#gid=276228256) Google Sheet.\r\n\r\nI think we could all of this soon, without needing to wait for ODM2.1, because it doesn't change the ODM2 schema. It will break some of our existing code, but I think we are presently in a position where we desperately need to fix the code anyways, and why do work arounds in our various apps. Let's just fix the issue at it's root, in the vocabularies.\r\n\r\nLooping in @horsburgh, @emiliom, @smrgeoinfo, @SRGDamia1, @dr-shorthair, @sreeder "},"comment":{"url":"https://api.github.com/repos/ODM2/ODM2/issues/comments/386012734","html_url":"https://github.com/ODM2/ODM2/issues/142#issuecomment-386012734","issue_url":"https://api.github.com/repos/ODM2/ODM2/issues/142","id":386012734,"user":{"login":"aufdenkampe","id":5166036,"avatar_url":"https://avatars0.githubusercontent.com/u/5166036?v=4","gravatar_id":"","url":"https://api.github.com/users/aufdenkampe","html_url":"https://github.com/aufdenkampe","followers_url":"https://api.github.com/users/aufdenkampe/followers","following_url":"https://api.github.com/users/aufdenkampe/following{/other_user}","gists_url":"https://api.github.com/users/aufdenkampe/gists{/gist_id}","starred_url":"https://api.github.com/users/aufdenkampe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aufdenkampe/subscriptions","organizations_url":"https://api.github.com/users/aufdenkampe/orgs","repos_url":"https://api.github.com/users/aufdenkampe/repos","events_url":"https://api.github.com/users/aufdenkampe/events{/privacy}","received_events_url":"https://api.github.com/users/aufdenkampe/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T15:12:09Z","updated_at":"2018-05-02T15:12:09Z","author_association":"OWNER","body":"@PleiadesAustralia, I think your points are quite valid. We want to strive for a flexible and extensible approach that allows for all geospatial scales of sampling features and all types of relationships between sampling features. That's the motivation for reworking these vocabularies and possibly tweaking ODM2 structures themselves.\r\n\r\nI'm hoping to finally have time to work on these needs over the next month.\r\n\r\n@PleiadesAustralia, what is your interest and use of ODM2. Are you interested in contributing ideas to this effort?"}}
{"actor":{"display_login":"aufdenkampe"}}