{"action":"created","comment":{"url":"https://api.github.com/repos/OpenXT/installer/pulls/comments/194476643","pull_request_review_id":127656790,"id":194476643,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQ3NjY0Mw==","diff_hunk":"@@ -398,23 +401,6 @@ partition_mode_is_unique()\n             fi\n             ;;\n \n-        erase-entire-disk)\n-            # Check if equivalent to \"overwrite\".\n-            if [ \"${XC_PARTITION}\" -a \\\n-                 -z \"${OEM_PARTITIONS}\" -a \\\n-                 -z \"${OTHER_PARTITIONS}\" -a \\\n-                 \"${HAVE_FREE_SPACE}\" != \"true\" ] ; then\n-                return 1\n-            fi\n-\n-            # Check if equivalent to \"use-free-space\".","path":"part2/stages/Configure-partitions","position":116,"original_position":47,"commit_id":"0d54992c683dcda538eb68e29b55c58c6d6154ad","original_commit_id":"86242803de16d5341b76c222f2e8ba785c48ce76","user":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"body":"I remember erase-entire-disk was not showing up in the installer as an option so we tried a bunch of tweaks and ultimately had to specify the partition-mode in the answer-file specific to UEFI to get it to work. We never got it to show up in the interactive installer as an option so this might just have been one of the tweaks we never reverted after we tried it.","created_at":"2018-06-11T17:05:35Z","updated_at":"2018-06-11T17:05:35Z","html_url":"https://github.com/OpenXT/installer/pull/63#discussion_r194476643","pull_request_url":"https://api.github.com/repos/OpenXT/installer/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/comments/194476643"},"html":{"href":"https://github.com/OpenXT/installer/pull/63#discussion_r194476643"},"pull_request":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/63"}},"in_reply_to_id":194395961},"pull_request":{"url":"https://api.github.com/repos/OpenXT/installer/pulls/63","id":173597902,"node_id":"MDExOlB1bGxSZXF1ZXN0MTczNTk3OTAy","html_url":"https://github.com/OpenXT/installer/pull/63","diff_url":"https://github.com/OpenXT/installer/pull/63.diff","patch_url":"https://github.com/OpenXT/installer/pull/63.patch","issue_url":"https://api.github.com/repos/OpenXT/installer/issues/63","number":63,"state":"closed","locked":false,"title":"OXT-1280: GPT and UEFI support","user":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"body":"This PR includes changes to the installer scripts necessary to partition the disk using GPT and to install OpenXT on UEFI systems.\r\n\r\nRelated PRs:\r\nhttps://github.com/OpenXT/xenclient-oe/pull/828\r\nhttps://github.com/OpenXT/openxt/pull/285","created_at":"2018-03-07T22:56:59Z","updated_at":"2018-06-11T17:05:35Z","closed_at":"2018-03-22T23:49:01Z","merged_at":"2018-03-22T23:49:01Z","merge_commit_sha":"d10cfd0ecb350b9b17bbc425e8bc158e1fe901ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenXT/installer/pulls/63/commits","review_comments_url":"https://api.github.com/repos/OpenXT/installer/pulls/63/comments","review_comment_url":"https://api.github.com/repos/OpenXT/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenXT/installer/issues/63/comments","statuses_url":"https://api.github.com/repos/OpenXT/installer/statuses/0d54992c683dcda538eb68e29b55c58c6d6154ad","head":{"label":"tklengyel:uefi","ref":"uefi","sha":"0d54992c683dcda538eb68e29b55c58c6d6154ad","user":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"OpenXT:master","ref":"master","sha":"88b55f277b5d9d88fb34b12cb4cf61b580d8e8c3","user":{"login":"OpenXT","id":7283187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyODMxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7283187?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"repo":{"id":20778866,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3ODg2Ng==","name":"installer","full_name":"OpenXT/installer","owner":{"login":"OpenXT","id":7283187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyODMxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7283187?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenXT/installer","description":null,"fork":false,"url":"https://api.github.com/repos/OpenXT/installer","forks_url":"https://api.github.com/repos/OpenXT/installer/forks","keys_url":"https://api.github.com/repos/OpenXT/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenXT/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenXT/installer/teams","hooks_url":"https://api.github.com/repos/OpenXT/installer/hooks","issue_events_url":"https://api.github.com/repos/OpenXT/installer/issues/events{/number}","events_url":"https://api.github.com/repos/OpenXT/installer/events","assignees_url":"https://api.github.com/repos/OpenXT/installer/assignees{/user}","branches_url":"https://api.github.com/repos/OpenXT/installer/branches{/branch}","tags_url":"https://api.github.com/repos/OpenXT/installer/tags","blobs_url":"https://api.github.com/repos/OpenXT/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenXT/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenXT/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenXT/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenXT/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenXT/installer/languages","stargazers_url":"https://api.github.com/repos/OpenXT/installer/stargazers","contributors_url":"https://api.github.com/repos/OpenXT/installer/contributors","subscribers_url":"https://api.github.com/repos/OpenXT/installer/subscribers","subscription_url":"https://api.github.com/repos/OpenXT/installer/subscription","commits_url":"https://api.github.com/repos/OpenXT/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenXT/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenXT/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenXT/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenXT/installer/contents/{+path}","compare_url":"https://api.github.com/repos/OpenXT/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenXT/installer/merges","archive_url":"https://api.github.com/repos/OpenXT/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenXT/installer/downloads","issues_url":"https://api.github.com/repos/OpenXT/installer/issues{/number}","pulls_url":"https://api.github.com/repos/OpenXT/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenXT/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenXT/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenXT/installer/labels{/name}","releases_url":"https://api.github.com/repos/OpenXT/installer/releases{/id}","deployments_url":"https://api.github.com/repos/OpenXT/installer/deployments","created_at":"2014-06-12T18:45:11Z","updated_at":"2018-05-21T22:26:16Z","pushed_at":"2018-06-08T20:43:33Z","git_url":"git://github.com/OpenXT/installer.git","ssh_url":"git@github.com:OpenXT/installer.git","clone_url":"https://github.com/OpenXT/installer.git","svn_url":"https://github.com/OpenXT/installer","homepage":null,"size":272,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":23,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/63"},"html":{"href":"https://github.com/OpenXT/installer/pull/63"},"issue":{"href":"https://api.github.com/repos/OpenXT/installer/issues/63"},"comments":{"href":"https://api.github.com/repos/OpenXT/installer/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenXT/installer/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/OpenXT/installer/statuses/0d54992c683dcda538eb68e29b55c58c6d6154ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tklengyel"}}