{"action":"opened","number":6208,"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208","id":205676821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Njc2ODIx","html_url":"https://github.com/yarnpkg/yarn/pull/6208","diff_url":"https://github.com/yarnpkg/yarn/pull/6208.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/6208.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/6208","number":6208,"state":"open","locked":false,"title":"deps: upgrade deps to get rid of Buffer constructor","user":{"login":"aduh95","id":14309773,"node_id":"MDQ6VXNlcjE0MzA5Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/14309773?v=4","gravatar_id":"","url":"https://api.github.com/users/aduh95","html_url":"https://github.com/aduh95","followers_url":"https://api.github.com/users/aduh95/followers","following_url":"https://api.github.com/users/aduh95/following{/other_user}","gists_url":"https://api.github.com/users/aduh95/gists{/gist_id}","starred_url":"https://api.github.com/users/aduh95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduh95/subscriptions","organizations_url":"https://api.github.com/users/aduh95/orgs","repos_url":"https://api.github.com/users/aduh95/repos","events_url":"https://api.github.com/users/aduh95/events{/privacy}","received_events_url":"https://api.github.com/users/aduh95/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->\r\n\r\n**Summary**\r\n\r\nNode 10 is about to become LTS and Yarn users are still receiving warnings from the use of the deprecated `Buffer` constructor. This PR updates the dependencies triggering those warnings.\r\n\r\nMotivated by https://github.com/yarnpkg/yarn/pull/5934#issuecomment-406346724 (thank you @jacobq).\r\n\r\nWe've come from a long way to get rid of those warnings in yarn. Here the list of the packages which have been upgraded related to the issue #5477:\r\n\r\n- [x] yarn (Fixed by: https://github.com/yarnpkg/yarn/pull/5731)\r\n- [x] tar-fs (Fixed by: https://github.com/yarnpkg/yarn/pull/5752)\r\n- [x] tar-stream (Fixed by: https://github.com/yarnpkg/yarn/pull/5752)\r\n- [x] v8-compile-cache (Fixed by: https://github.com/yarnpkg/yarn/pull/5763)\r\n- [x] natives (Fixed by: https://github.com/yarnpkg/yarn/pull/5763)\r\n- [x] sshpk (Fixed by: https://github.com/yarnpkg/yarn/pull/5934)\r\n\r\nThe list of dependencies that are fixed by this PR:\r\n\r\n- [x] bl (BufferList) (1.2.1 -> 1.2.2)\r\n- [x] buffer-alloc (1.1.0 -> 1.2.0)\r\n- [x] duplexify (3.5.0 -> 3.6.0)\r\n- [x] ecc-jsbn (0.1.1 -> 0.2.0)\r\n- [x] peek-stream (1.1.2 -> 1.1.3)\r\n\r\nWhen running `yarn build-bundle` then searching for all the occurrences of `new Buffer(`, there are now 14 search results:\r\n\r\n- 2 are comments\r\n- 7 are compatibility fallback\r\n- 1 is from `buffer-fill`, but the code is not used by any of the `yarn` command\r\n- 3 are from `asn1`\r\n- 1 is from `http-signature`\r\n\r\nTo sum up, here are the PR we are waiting to merge to be done with this deprecation warning in yarn:\r\n\r\n* [ ] asn1 (Refs: https://github.com/joyent/node-asn1/pull/30)\r\n* [ ] http-signature (Refs: https://github.com/joyent/node-http-signature/pull/67)\r\n\r\n**Test plan**\r\n\r\nCI\r\n","created_at":"2018-08-02T09:46:07Z","updated_at":"2018-08-02T09:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/6208/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/66ce7e1ef9ddca49e1140089b137326d24715510","head":{"label":"aduh95:no_more_buffer_constructor","ref":"no_more_buffer_constructor","sha":"66ce7e1ef9ddca49e1140089b137326d24715510","user":{"login":"aduh95","id":14309773,"node_id":"MDQ6VXNlcjE0MzA5Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/14309773?v=4","gravatar_id":"","url":"https://api.github.com/users/aduh95","html_url":"https://github.com/aduh95","followers_url":"https://api.github.com/users/aduh95/followers","following_url":"https://api.github.com/users/aduh95/following{/other_user}","gists_url":"https://api.github.com/users/aduh95/gists{/gist_id}","starred_url":"https://api.github.com/users/aduh95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduh95/subscriptions","organizations_url":"https://api.github.com/users/aduh95/orgs","repos_url":"https://api.github.com/users/aduh95/repos","events_url":"https://api.github.com/users/aduh95/events{/privacy}","received_events_url":"https://api.github.com/users/aduh95/received_events","type":"User","site_admin":false},"repo":{"id":131025084,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwMjUwODQ=","name":"yarn","full_name":"aduh95/yarn","owner":{"login":"aduh95","id":14309773,"node_id":"MDQ6VXNlcjE0MzA5Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/14309773?v=4","gravatar_id":"","url":"https://api.github.com/users/aduh95","html_url":"https://github.com/aduh95","followers_url":"https://api.github.com/users/aduh95/followers","following_url":"https://api.github.com/users/aduh95/following{/other_user}","gists_url":"https://api.github.com/users/aduh95/gists{/gist_id}","starred_url":"https://api.github.com/users/aduh95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduh95/subscriptions","organizations_url":"https://api.github.com/users/aduh95/orgs","repos_url":"https://api.github.com/users/aduh95/repos","events_url":"https://api.github.com/users/aduh95/events{/privacy}","received_events_url":"https://api.github.com/users/aduh95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aduh95/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/aduh95/yarn","forks_url":"https://api.github.com/repos/aduh95/yarn/forks","keys_url":"https://api.github.com/repos/aduh95/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aduh95/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aduh95/yarn/teams","hooks_url":"https://api.github.com/repos/aduh95/yarn/hooks","issue_events_url":"https://api.github.com/repos/aduh95/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/aduh95/yarn/events","assignees_url":"https://api.github.com/repos/aduh95/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/aduh95/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/aduh95/yarn/tags","blobs_url":"https://api.github.com/repos/aduh95/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aduh95/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aduh95/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aduh95/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aduh95/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/aduh95/yarn/languages","stargazers_url":"https://api.github.com/repos/aduh95/yarn/stargazers","contributors_url":"https://api.github.com/repos/aduh95/yarn/contributors","subscribers_url":"https://api.github.com/repos/aduh95/yarn/subscribers","subscription_url":"https://api.github.com/repos/aduh95/yarn/subscription","commits_url":"https://api.github.com/repos/aduh95/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aduh95/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aduh95/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aduh95/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/aduh95/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/aduh95/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aduh95/yarn/merges","archive_url":"https://api.github.com/repos/aduh95/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aduh95/yarn/downloads","issues_url":"https://api.github.com/repos/aduh95/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/aduh95/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/aduh95/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/aduh95/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aduh95/yarn/labels{/name}","releases_url":"https://api.github.com/repos/aduh95/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/aduh95/yarn/deployments","created_at":"2018-04-25T15:14:29Z","updated_at":"2018-04-25T15:14:36Z","pushed_at":"2018-08-01T20:29:55Z","git_url":"git://github.com/aduh95/yarn.git","ssh_url":"git@github.com:aduh95/yarn.git","clone_url":"https://github.com/aduh95/yarn.git","svn_url":"https://github.com/aduh95/yarn","homepage":"https://yarnpkg.com","size":116925,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"308b9f067c9a929cce29671466f341b2af0aa697","user":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDY0Mg==","name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-08-02T09:44:21Z","pushed_at":"2018-08-02T09:44:11Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":117831,"stargazers_count":32587,"watchers_count":32587,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1854,"mirror_url":null,"archived":false,"open_issues_count":1328,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1854,"open_issues":1328,"watchers":32587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/6208"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/6208"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/6208/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6208/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/66ce7e1ef9ddca49e1140089b137326d24715510"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":744,"deletions":823,"changed_files":2}}
{"actor":{"display_login":"aduh95"}}