{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/2607","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/2607/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2607/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/2607/events","html_url":"https://github.com/eclipse/omr/pull/2607","id":328023568,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjY1Nzk4","number":2607,"title":"Fix tril's Xcall related tests","user":{"login":"samolisov","id":134115,"node_id":"MDQ6VXNlcjEzNDExNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"labels":[{"id":634457134,"node_id":"MDU6TGFiZWw2MzQ0NTcxMzQ=","url":"https://api.github.com/repos/eclipse/omr/labels/tril","name":"tril","color":"FF8300","default":false}],"state":"open","locked":false,"assignee":{"login":"fjeremic","id":16259104,"node_id":"MDQ6VXNlcjE2MjU5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"assignees":[{"login":"fjeremic","id":16259104,"node_id":"MDQ6VXNlcjE2MjU5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-05-31T07:25:29Z","updated_at":"2018-06-06T19:05:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2607","html_url":"https://github.com/eclipse/omr/pull/2607","diff_url":"https://github.com/eclipse/omr/pull/2607.diff","patch_url":"https://github.com/eclipse/omr/pull/2607.patch"},"body":"Tril parses hexadecimal numbers if and only if they start with the `0x`\r\nprefix. Unfortunately, some C/C++ compilers put the prefix for the `%p`\r\nformat specifier (so, they translate `%p` to something like\r\n`0x0123456789ABCDEF`) while others don't. If the `0x` prefix is absent\r\nbefore the address attribute value of the `Xcall` node, tril\r\ninterprets leading digits as a decimal number and the rest starting from\r\nnot a digital symbol (A,B,C,D,E or F) as an anonymous attribute. As a\r\nresult, the formed `Xcall` node will try to invoke a function by a wrong\r\naddress and an Access Violation Error appears.\r\n\r\nThe commit fixes the problem explicitly adding the `0x` prefix before the\r\nformat specifier in all code for `Xcall` tests. Output for the ilgen trace\r\nof the `Xcall` opcode is fixed too.\r\n\r\nSigned-off-by: Pavel Samolysov <samolisov@gmail.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/395179413","html_url":"https://github.com/eclipse/omr/pull/2607#issuecomment-395179413","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2607","id":395179413,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTE3OTQxMw==","user":{"login":"Leonardo2718","id":6710130,"node_id":"MDQ6VXNlcjY3MTAxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6710130?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonardo2718","html_url":"https://github.com/Leonardo2718","followers_url":"https://api.github.com/users/Leonardo2718/followers","following_url":"https://api.github.com/users/Leonardo2718/following{/other_user}","gists_url":"https://api.github.com/users/Leonardo2718/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonardo2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonardo2718/subscriptions","organizations_url":"https://api.github.com/users/Leonardo2718/orgs","repos_url":"https://api.github.com/users/Leonardo2718/repos","events_url":"https://api.github.com/users/Leonardo2718/events{/privacy}","received_events_url":"https://api.github.com/users/Leonardo2718/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T19:05:31Z","updated_at":"2018-06-06T19:05:31Z","author_association":"CONTRIBUTOR","body":"Oh! In that case, try using two casts (newlines added for readability):\r\n\r\n```c++\r\nreinterpret_cast<reinterpret_cast>(\r\n  static_cast<TypeParam (*)(TypeParam,TypeParam,TypeParam,TypeParam)>(\r\n    fourthArg<TypeParam>\r\n  )\r\n)\r\n```\r\n\r\nIt's ugly, but this might be one of those awkward cases where you really have to hold the compilers hand (often happens with older compilers)."}}
{"actor":{"display_login":"Leonardo2718"}}