{"action":"created","issue":{"url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/164","repository_url":"https://api.github.com/repos/smooth-code/jest-puppeteer","labels_url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/164/comments","events_url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/164/events","html_url":"https://github.com/smooth-code/jest-puppeteer/pull/164","id":387653182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDkyMzAx","number":164,"title":"fix: skip closing external browser on teardown","user":{"login":"donovan-graham","id":1104135,"node_id":"MDQ6VXNlcjExMDQxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1104135?v=4","gravatar_id":"","url":"https://api.github.com/users/donovan-graham","html_url":"https://github.com/donovan-graham","followers_url":"https://api.github.com/users/donovan-graham/followers","following_url":"https://api.github.com/users/donovan-graham/following{/other_user}","gists_url":"https://api.github.com/users/donovan-graham/gists{/gist_id}","starred_url":"https://api.github.com/users/donovan-graham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donovan-graham/subscriptions","organizations_url":"https://api.github.com/users/donovan-graham/orgs","repos_url":"https://api.github.com/users/donovan-graham/repos","events_url":"https://api.github.com/users/donovan-graham/events{/privacy}","received_events_url":"https://api.github.com/users/donovan-graham/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-05T08:56:29Z","updated_at":"2018-12-13T08:46:09Z","closed_at":"2018-12-06T22:34:36Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/smooth-code/jest-puppeteer/pulls/164","html_url":"https://github.com/smooth-code/jest-puppeteer/pull/164","diff_url":"https://github.com/smooth-code/jest-puppeteer/pull/164.diff","patch_url":"https://github.com/smooth-code/jest-puppeteer/pull/164.patch"},"body":"Use `.disconnect` method in teardown phase, as a complement to the `.connect` method in the setup phase.\r\n\r\n## Summary\r\n\r\nThis allows long-running external instances of chromium to be managed independently of the jest test runner, and/or possible reuse of the chromium instances across different test runs and projects.\r\n\r\nFor example, our use case it to run multiple chromium instances (similar to selenium's grid) and allow different projects to `connect` and run their test suites against the grid. \r\n\r\nSee pptr docs:\r\nhttps://pptr.dev/#?product=Puppeteer&version=v1.11.0&show=api-browserdisconnect\r\n\r\n## Test plan\r\n\r\nRunning an external browser, which jest-puppeteer can connect to and at the end of the test suite, the browser remains open.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/comments/446887700","html_url":"https://github.com/smooth-code/jest-puppeteer/pull/164#issuecomment-446887700","issue_url":"https://api.github.com/repos/smooth-code/jest-puppeteer/issues/164","id":446887700,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njg4NzcwMA==","user":{"login":"ohana54","id":3693735,"node_id":"MDQ6VXNlcjM2OTM3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3693735?v=4","gravatar_id":"","url":"https://api.github.com/users/ohana54","html_url":"https://github.com/ohana54","followers_url":"https://api.github.com/users/ohana54/followers","following_url":"https://api.github.com/users/ohana54/following{/other_user}","gists_url":"https://api.github.com/users/ohana54/gists{/gist_id}","starred_url":"https://api.github.com/users/ohana54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohana54/subscriptions","organizations_url":"https://api.github.com/users/ohana54/orgs","repos_url":"https://api.github.com/users/ohana54/repos","events_url":"https://api.github.com/users/ohana54/events{/privacy}","received_events_url":"https://api.github.com/users/ohana54/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T08:46:09Z","updated_at":"2018-12-13T08:46:09Z","author_association":"NONE","body":"@neoziro on a similar subject, is there a reason why we don't `disconnect` on suite teardown?\r\nI'll open a new issue if needed :)"}}
{"actor":{"display_login":"ohana54"}}