{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/237354914","pull_request_review_id":179630840,"id":237354914,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM1NDkxNA==","diff_hunk":"@@ -389,7 +392,10 @@ def get_oper(module, filter=None):\n \n     if filter is not None:\n         try:\n-            response = conn.get(filter)\n+            if is_netconf(module):\n+                response = conn.get(filter, remove_ns=True)","path":"lib/ansible/module_utils/network/iosxr/iosxr.py","position":30,"original_position":30,"commit_id":"0f8f6324f6c527a772eeef66505ca3ffa0126dc6","original_commit_id":"0f8f6324f6c527a772eeef66505ca3ffa0126dc6","user":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"body":"The issue is fixed on devel, however, I will change as you suggested since same iosxr plugin will be copied in yang role that is currently dependent on 2.7 Ansible version.","created_at":"2018-11-29T05:11:47Z","updated_at":"2018-11-29T05:11:48Z","html_url":"https://github.com/ansible/ansible/pull/49238#discussion_r237354914","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/49238","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/237354914"},"html":{"href":"https://github.com/ansible/ansible/pull/49238#discussion_r237354914"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49238"}},"in_reply_to_id":237183611},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49238","id":234277270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mjc3Mjcw","html_url":"https://github.com/ansible/ansible/pull/49238","diff_url":"https://github.com/ansible/ansible/pull/49238.diff","patch_url":"https://github.com/ansible/ansible/pull/49238.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49238","number":49238,"state":"open","locked":false,"title":"Fix iosxr netconf plugin response namespace","user":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"body":"\r\n##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\n*  iosxr netconf plugin removes namespace by default\r\n   for all the responses as parsing of xml is easier without namespace in iosxr module. However, to \r\n   validate the response received from the device against yang model requires namespace to be \r\n   present.\r\n*  Add a parameter in iosxr netconf plugin API's to control if the namespace\r\n    should be removed from the response or not.\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue -->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Write the short name of the module, plugin, task or feature below -->\r\nnetconf/iosxr.py\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here -->\r\n<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```paste below\r\n\r\n```\r\n","created_at":"2018-11-28T13:31:38Z","updated_at":"2018-11-29T05:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29f09aec8adabf7617fde84cb702e99f6ec78e5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"c7def8","default":false},{"id":669761792,"node_id":"MDU6TGFiZWw2Njk3NjE3OTI=","url":"https://api.github.com/repos/ansible/ansible/labels/support:network","name":"support:network","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/49238/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/49238/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49238/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/0f8f6324f6c527a772eeef66505ca3ffa0126dc6","head":{"label":"ganeshrn:iosxr_netconf_fix","ref":"iosxr_netconf_fix","sha":"0f8f6324f6c527a772eeef66505ca3ffa0126dc6","user":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"repo":{"id":74120864,"node_id":"MDEwOlJlcG9zaXRvcnk3NDEyMDg2NA==","name":"ansible","full_name":"ganeshrn/ansible","private":false,"owner":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ganeshrn/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/ganeshrn/ansible","forks_url":"https://api.github.com/repos/ganeshrn/ansible/forks","keys_url":"https://api.github.com/repos/ganeshrn/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ganeshrn/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ganeshrn/ansible/teams","hooks_url":"https://api.github.com/repos/ganeshrn/ansible/hooks","issue_events_url":"https://api.github.com/repos/ganeshrn/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ganeshrn/ansible/events","assignees_url":"https://api.github.com/repos/ganeshrn/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ganeshrn/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ganeshrn/ansible/tags","blobs_url":"https://api.github.com/repos/ganeshrn/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ganeshrn/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ganeshrn/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ganeshrn/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ganeshrn/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ganeshrn/ansible/languages","stargazers_url":"https://api.github.com/repos/ganeshrn/ansible/stargazers","contributors_url":"https://api.github.com/repos/ganeshrn/ansible/contributors","subscribers_url":"https://api.github.com/repos/ganeshrn/ansible/subscribers","subscription_url":"https://api.github.com/repos/ganeshrn/ansible/subscription","commits_url":"https://api.github.com/repos/ganeshrn/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ganeshrn/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ganeshrn/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ganeshrn/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ganeshrn/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ganeshrn/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ganeshrn/ansible/merges","archive_url":"https://api.github.com/repos/ganeshrn/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ganeshrn/ansible/downloads","issues_url":"https://api.github.com/repos/ganeshrn/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ganeshrn/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ganeshrn/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ganeshrn/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ganeshrn/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ganeshrn/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ganeshrn/ansible/deployments","created_at":"2016-11-18T10:41:28Z","updated_at":"2018-11-28T12:39:37Z","pushed_at":"2018-11-28T14:05:39Z","git_url":"git://github.com/ganeshrn/ansible.git","ssh_url":"git@github.com:ganeshrn/ansible.git","clone_url":"https://github.com/ganeshrn/ansible.git","svn_url":"https://github.com/ganeshrn/ansible","homepage":"http://ansible.com/","size":136215,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"d9a17e098c9875fab39b530e6f498ee8e3514cf2","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-11-29T05:11:39Z","pushed_at":"2018-11-29T05:08:43Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":146157,"stargazers_count":34002,"watchers_count":34002,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13617,"mirror_url":null,"archived":false,"open_issues_count":5620,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13617,"open_issues":5620,"watchers":34002,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49238"},"html":{"href":"https://github.com/ansible/ansible/pull/49238"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/49238"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/49238/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49238/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49238/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/0f8f6324f6c527a772eeef66505ca3ffa0126dc6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ganeshrn"}}