{"action":"created","issue":{"url":"https://api.github.com/repos/golang/dep/issues/1890","repository_url":"https://api.github.com/repos/golang/dep","labels_url":"https://api.github.com/repos/golang/dep/issues/1890/labels{/name}","comments_url":"https://api.github.com/repos/golang/dep/issues/1890/comments","events_url":"https://api.github.com/repos/golang/dep/issues/1890/events","html_url":"https://github.com/golang/dep/issues/1890","id":330753161,"node_id":"MDU6SXNzdWUzMzA3NTMxNjE=","number":1890,"title":"dep ensure produces incomplete vendor results","user":{"login":"syphoxy","id":234569,"node_id":"MDQ6VXNlcjIzNDU2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/234569?v=4","gravatar_id":"","url":"https://api.github.com/users/syphoxy","html_url":"https://github.com/syphoxy","followers_url":"https://api.github.com/users/syphoxy/followers","following_url":"https://api.github.com/users/syphoxy/following{/other_user}","gists_url":"https://api.github.com/users/syphoxy/gists{/gist_id}","starred_url":"https://api.github.com/users/syphoxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syphoxy/subscriptions","organizations_url":"https://api.github.com/users/syphoxy/orgs","repos_url":"https://api.github.com/users/syphoxy/repos","events_url":"https://api.github.com/users/syphoxy/events{/privacy}","received_events_url":"https://api.github.com/users/syphoxy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-08T18:08:01Z","updated_at":"2018-07-09T20:47:50Z","closed_at":null,"author_association":"NONE","body":"I believe this explains itself. my code won't compile if I use dep as my vendor appears to be missing source files. I've checked that the missing directories do actually contain `.go` files.\r\n\r\nthis is how I check out a working vendor dependency:\r\n\r\n```\r\ngit clone https://github.com/moby/moby.git vendor/github.com/docker/docker\r\ngit -C vendor/github.com/docker/docker checkout -b api/v1.32 05121d555475b3d7cfa5b29f22dc85262cd1a1a8\r\n```\r\n\r\nthis is what I have in `Gopkg.toml`:\r\n\r\n```\r\n[[constraint]]\r\n  name = \"github.com/docker/docker\"\r\n  revision = \"05121d555475b3d7cfa5b29f22dc85262cd1a1a8\"\r\n  source = \"https://github.com/moby/moby.git\"\r\n```\r\n\r\nI've verified using `api/common.go` that in both instances the code is checked out from the correct revision. it appears that dep simply just didn't get some `.go` files.\r\n\r\nfor example, common.go has no differences:\r\n\r\n```\r\n% diff -u vendor/github.com/docker/docker{,2}/api/common.go\r\n%\r\n```\r\n\r\nI've also used `go ensure -v` to see additional output but unfortunately the output does not detail exactly what occurred here.\r\n\r\nany help would be appreciated. thank you.\r\n\r\n**also:** I realize that constraining to a revision is an anti-pattern but unfortunately docker/moby upstream developers have failed to properly add a tag for the API version I need to use in my software. please don't remind me.\r\n\r\n### What version of `dep` are you using (`dep version`)?\r\n\r\n```\r\ndep:\r\n version     : v0.4.1\r\n build date  : 2018-01-27\r\n git hash    : 37d9ea0\r\n go version  : go1.9.3\r\n go compiler : gc\r\n platform    : darwin/amd64\r\n```\r\n\r\n### What `dep` command did you run?\r\n\r\n`dep ensure`\r\n\r\n### What did you expect to see?\r\n\r\n```\r\ndocker % ls -l\r\ntotal 824\r\n-rw-r--r--    1 dariorusso  staff   74397  8 Jun 13:55 AUTHORS\r\n-rw-r--r--    1 dariorusso  staff  206320  8 Jun 13:55 CHANGELOG.md\r\n-rw-r--r--    1 dariorusso  staff   19924  8 Jun 13:55 CONTRIBUTING.md\r\n-rw-r--r--    1 dariorusso  staff    9121  8 Jun 13:55 Dockerfile\r\n-rw-r--r--    1 dariorusso  staff    2631  8 Jun 13:55 Dockerfile.e2e\r\n-rw-r--r--    1 dariorusso  staff    1987  8 Jun 13:55 Dockerfile.simple\r\n-rw-r--r--    1 dariorusso  staff   11376  8 Jun 13:55 Dockerfile.windows\r\n-rw-r--r--    1 dariorusso  staff   10765  8 Jun 13:55 LICENSE\r\n-rw-r--r--    1 dariorusso  staff   15157  8 Jun 13:55 MAINTAINERS\r\n-rw-r--r--    1 dariorusso  staff    9878  8 Jun 13:55 Makefile\r\n-rw-r--r--    1 dariorusso  staff     638  8 Jun 13:55 NOTICE\r\n-rw-r--r--    1 dariorusso  staff    3395  8 Jun 13:55 README.md\r\n-rw-r--r--    1 dariorusso  staff    3776  8 Jun 13:55 ROADMAP.md\r\n-rw-r--r--    1 dariorusso  staff    2664  8 Jun 13:55 TESTING.md\r\n-rw-r--r--    1 dariorusso  staff    1952  8 Jun 13:55 VENDORING.md\r\ndrwxr-xr-x   11 dariorusso  staff     374  8 Jun 13:55 api/\r\ndrwxr-xr-x    7 dariorusso  staff     238  8 Jun 13:55 builder/\r\ndrwxr-xr-x    7 dariorusso  staff     238  8 Jun 13:55 cli/\r\ndrwxr-xr-x  214 dariorusso  staff    7276  8 Jun 13:55 client/\r\ndrwxr-xr-x    3 dariorusso  staff     102  8 Jun 13:55 cmd/\r\n-rw-r--r--    1 dariorusso  staff     359  8 Jun 13:55 codecov.yml\r\ndrwxr-xr-x   22 dariorusso  staff     748  8 Jun 13:55 container/\r\ndrwxr-xr-x   33 dariorusso  staff    1122  8 Jun 13:55 contrib/\r\ndrwxr-xr-x  148 dariorusso  staff    5032  8 Jun 13:55 daemon/\r\ndrwxr-xr-x   21 dariorusso  staff     714  8 Jun 13:55 distribution/\r\ndrwxr-xr-x    4 dariorusso  staff     136  8 Jun 13:55 dockerversion/\r\ndrwxr-xr-x    5 dariorusso  staff     170  8 Jun 13:55 docs/\r\ndrwxr-xr-x    7 dariorusso  staff     238  8 Jun 13:55 errdefs/\r\ndrwxr-xr-x   15 dariorusso  staff     510  8 Jun 13:55 hack/\r\ndrwxr-xr-x   13 dariorusso  staff     442  8 Jun 13:55 image/\r\ndrwxr-xr-x   16 dariorusso  staff     544  8 Jun 13:55 integration/\r\ndrwxr-xr-x  115 dariorusso  staff    3910  8 Jun 13:55 integration-cli/\r\ndrwxr-xr-x    4 dariorusso  staff     136  8 Jun 13:55 internal/\r\ndrwxr-xr-x   21 dariorusso  staff     714  8 Jun 13:55 layer/\r\ndrwxr-xr-x   22 dariorusso  staff     748  8 Jun 13:55 libcontainerd/\r\ndrwxr-xr-x    3 dariorusso  staff     102  8 Jun 13:55 migrate/\r\ndrwxr-xr-x    6 dariorusso  staff     204  8 Jun 13:55 oci/\r\ndrwxr-xr-x   21 dariorusso  staff     714  8 Jun 13:55 opts/\r\ndrwxr-xr-x   47 dariorusso  staff    1598  8 Jun 13:55 pkg/\r\ndrwxr-xr-x   18 dariorusso  staff     612  8 Jun 13:55 plugin/\r\n-rw-r--r--    1 dariorusso  staff    4667  8 Jun 13:55 poule.yml\r\ndrwxr-xr-x    4 dariorusso  staff     136  8 Jun 13:55 profiles/\r\ndrwxr-xr-x   16 dariorusso  staff     544  8 Jun 13:55 project/\r\ndrwxr-xr-x    5 dariorusso  staff     170  8 Jun 13:55 reference/\r\ndrwxr-xr-x   21 dariorusso  staff     714  8 Jun 13:55 registry/\r\ndrwxr-xr-x    9 dariorusso  staff     306  8 Jun 13:55 reports/\r\ndrwxr-xr-x    4 dariorusso  staff     136  8 Jun 13:55 restartmanager/\r\ndrwxr-xr-x   14 dariorusso  staff     476  8 Jun 13:55 runconfig/\r\ndrwxr-xr-x    8 dariorusso  staff     272  8 Jun 13:55 vendor/\r\n-rw-r--r--    1 dariorusso  staff    7813  8 Jun 13:55 vendor.conf\r\ndrwxr-xr-x    8 dariorusso  staff     272  8 Jun 13:55 volume/\r\n```\r\n\r\n```\r\n% rg DefaultVersion vendor/github.com/docker/docker/api/common.go\r\n17:\t// DefaultVersion of Current REST API\r\n18:\tDefaultVersion string = \"1.32\"\r\n```\r\n\r\n### What did you see instead?\r\n\r\n```\r\ndocker % ls -l\r\ntotal 176\r\n-rw-r--r--    1 dariorusso  staff  70478  8 Jun 13:47 AUTHORS\r\n-rw-r--r--    1 dariorusso  staff  10765  8 Jun 13:47 LICENSE\r\n-rw-r--r--    1 dariorusso  staff    638  8 Jun 13:47 NOTICE\r\ndrwxr-xr-x   10 dariorusso  staff    340  8 Jun 13:47 api/\r\ndrwxr-xr-x  117 dariorusso  staff   3978  8 Jun 13:47 client/\r\ndrwxr-xr-x    5 dariorusso  staff    170  8 Jun 13:47 contrib/\r\ndrwxr-xr-x    3 dariorusso  staff    102  8 Jun 13:47 docs/\r\ndrwxr-xr-x    4 dariorusso  staff    136  8 Jun 13:47 hack/\r\ndrwxr-xr-x    8 dariorusso  staff    272  8 Jun 13:47 pkg/\r\ndrwxr-xr-x    3 dariorusso  staff    102  8 Jun 13:47 project/\r\n```\r\n\r\n```\r\n% rg DefaultVersion vendor/github.com/docker/docker/api/common.go\r\n17:\t// DefaultVersion of Current REST API\r\n18:\tDefaultVersion string = \"1.32\"\r\n```"},"comment":{"url":"https://api.github.com/repos/golang/dep/issues/comments/403615098","html_url":"https://github.com/golang/dep/issues/1890#issuecomment-403615098","issue_url":"https://api.github.com/repos/golang/dep/issues/1890","id":403615098,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYxNTA5OA==","user":{"login":"sdboyer","id":21599,"node_id":"MDQ6VXNlcjIxNTk5","avatar_url":"https://avatars0.githubusercontent.com/u/21599?v=4","gravatar_id":"","url":"https://api.github.com/users/sdboyer","html_url":"https://github.com/sdboyer","followers_url":"https://api.github.com/users/sdboyer/followers","following_url":"https://api.github.com/users/sdboyer/following{/other_user}","gists_url":"https://api.github.com/users/sdboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/sdboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdboyer/subscriptions","organizations_url":"https://api.github.com/users/sdboyer/orgs","repos_url":"https://api.github.com/users/sdboyer/repos","events_url":"https://api.github.com/users/sdboyer/events{/privacy}","received_events_url":"https://api.github.com/users/sdboyer/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T20:47:50Z","updated_at":"2018-07-09T20:47:50Z","author_association":"MEMBER","body":"I'm glad it helped! but, this is actually a big concern - could you tell me what compilation errors you were getting prior to changing the pruning options? "}}
{"actor":{"display_login":"sdboyer"}}