{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments/167719963","pull_request_review_id":95980592,"id":167719963,"diff_hunk":"@@ -0,0 +1,48 @@\n+/*!\n+ * Copyright 2018 Hitachi Vantara. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+/**\n+ * The `spec.ITypeDescriptor` interface describes a type descriptor in _object_ form.","path":"impl/client/src/main/doc-js/pentaho/type/spec/ITypeDescriptor.jsdoc","position":18,"original_position":18,"commit_id":"7dcdfc1c8e180dab99cc6a508d10f38525e93b83","original_commit_id":"f633b5f8f5e64002d4580d74c0eef682424b5c5d","user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars2.githubusercontent.com/u/284983?v=4","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"body":"`TypeDescriptor` is `Simple` type which wraps a `pentaho.type.Type` instance. It allows a property of a complex type to hold a type. The use case is that of `pentaho.visual.role.Mode#dataType`. Then `pentaho.visual.role.Property.Type#modes` — a type attribute — holds a list of `Mode` instances. Up until now, we didn't have a use case like this; types always referenced other types directly and not through a complex value.","created_at":"2018-02-12T23:29:51Z","updated_at":"2018-02-12T23:29:51Z","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246#discussion_r167719963","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments/167719963"},"html":{"href":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246#discussion_r167719963"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246"}},"in_reply_to_id":167629879},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246","id":167657613,"html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246","diff_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246.diff","patch_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1246","number":1246,"state":"open","locked":false,"title":" [BACKLOG-21192] VizAPI 3.0: Visual Roles working modes and mapping strategies","user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars2.githubusercontent.com/u/284983?v=4","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"body":"@pentaho/millenniumfalcon please review.\r\n\r\nThere's a unit test related with the ccc/visual which is failing, but will only be fixed in a later story.","created_at":"2018-02-07T10:48:20Z","updated_at":"2018-02-12T23:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c2e78510c0ad1fed2caabd03bdaa527e16c266f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1246/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/7dcdfc1c8e180dab99cc6a508d10f38525e93b83","head":{"label":"dcleao:BACKLOG-21192","ref":"BACKLOG-21192","sha":"7dcdfc1c8e180dab99cc6a508d10f38525e93b83","user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars2.githubusercontent.com/u/284983?v=4","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"repo":{"id":17474118,"name":"pentaho-platform-plugin-common-ui","full_name":"dcleao/pentaho-platform-plugin-common-ui","owner":{"login":"dcleao","id":284983,"avatar_url":"https://avatars2.githubusercontent.com/u/284983?v=4","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcleao/pentaho-platform-plugin-common-ui","description":null,"fork":true,"url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcleao/pentaho-platform-plugin-common-ui/deployments","created_at":"2014-03-06T10:28:52Z","updated_at":"2016-01-25T23:57:09Z","pushed_at":"2018-02-12T18:33:59Z","git_url":"git://github.com/dcleao/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:dcleao/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/dcleao/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/dcleao/pentaho-platform-plugin-common-ui","homepage":null,"size":29963,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:BACKLOG-21192","ref":"BACKLOG-21192","sha":"8dc483a3d18b38dfee2bac883849f7f6dcdee762","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":4597815,"name":"pentaho-platform-plugin-common-ui","full_name":"pentaho/pentaho-platform-plugin-common-ui","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui","description":null,"fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/deployments","created_at":"2012-06-08T13:53:13Z","updated_at":"2017-11-10T02:20:27Z","pushed_at":"2018-02-12T21:49:49Z","git_url":"git://github.com/pentaho/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:pentaho/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui","homepage":null,"size":29361,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":105,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246"},"html":{"href":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1246"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1246"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1246/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1246/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/7dcdfc1c8e180dab99cc6a508d10f38525e93b83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dcleao"}}