{"action":"created","issue":{"url":"https://api.github.com/repos/wazery/ratyrate/issues/160","repository_url":"https://api.github.com/repos/wazery/ratyrate","labels_url":"https://api.github.com/repos/wazery/ratyrate/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/wazery/ratyrate/issues/160/comments","events_url":"https://api.github.com/repos/wazery/ratyrate/issues/160/events","html_url":"https://github.com/wazery/ratyrate/pull/160","id":350815317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTY3MjM3","number":160,"title":"Fix for Directly inheriting from ActiveRecord::Migration is not supported","user":{"login":"an-nasir","id":4173058,"node_id":"MDQ6VXNlcjQxNzMwNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4173058?v=4","gravatar_id":"","url":"https://api.github.com/users/an-nasir","html_url":"https://github.com/an-nasir","followers_url":"https://api.github.com/users/an-nasir/followers","following_url":"https://api.github.com/users/an-nasir/following{/other_user}","gists_url":"https://api.github.com/users/an-nasir/gists{/gist_id}","starred_url":"https://api.github.com/users/an-nasir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/an-nasir/subscriptions","organizations_url":"https://api.github.com/users/an-nasir/orgs","repos_url":"https://api.github.com/users/an-nasir/repos","events_url":"https://api.github.com/users/an-nasir/events{/privacy}","received_events_url":"https://api.github.com/users/an-nasir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-15T13:47:14Z","updated_at":"2018-10-03T17:44:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wazery/ratyrate/pulls/160","html_url":"https://github.com/wazery/ratyrate/pull/160","diff_url":"https://github.com/wazery/ratyrate/pull/160.diff","patch_url":"https://github.com/wazery/ratyrate/pull/160.patch"},"body":"Added migration version to handle 'Directly inheriting from ActiveRecord::Migration is not supported\" while running rails/rake db:migrate"},"comment":{"url":"https://api.github.com/repos/wazery/ratyrate/issues/comments/426730753","html_url":"https://github.com/wazery/ratyrate/pull/160#issuecomment-426730753","issue_url":"https://api.github.com/repos/wazery/ratyrate/issues/160","id":426730753,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjczMDc1Mw==","user":{"login":"an-nasir","id":4173058,"node_id":"MDQ6VXNlcjQxNzMwNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4173058?v=4","gravatar_id":"","url":"https://api.github.com/users/an-nasir","html_url":"https://github.com/an-nasir","followers_url":"https://api.github.com/users/an-nasir/followers","following_url":"https://api.github.com/users/an-nasir/following{/other_user}","gists_url":"https://api.github.com/users/an-nasir/gists{/gist_id}","starred_url":"https://api.github.com/users/an-nasir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/an-nasir/subscriptions","organizations_url":"https://api.github.com/users/an-nasir/orgs","repos_url":"https://api.github.com/users/an-nasir/repos","events_url":"https://api.github.com/users/an-nasir/events{/privacy}","received_events_url":"https://api.github.com/users/an-nasir/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T17:44:46Z","updated_at":"2018-10-03T17:44:46Z","author_association":"NONE","body":"In else case it'll remain to same versions.\nThis is how it is done in devise BTW\n\nOn Wed, 3 Oct 2018, 22:02 Yih Yang, <notifications@github.com> wrote:\n\n> *@yihyang* commented on this pull request.\n> ------------------------------\n>\n> In lib/generators/ratyrate/ratyrate_generator.rb\n> <https://github.com/wazery/ratyrate/pull/160#discussion_r222389616>:\n>\n> >    end\n> +\n> +  def rails5?\n> +    Rails.version.start_with? '5'\n> +  end\n> +  def migration_version\n> +    if rails5?\n> +      \"[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]\"\n> +    else\n> +      \"[#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}]\"\n>\n> is this needed? I saw some of the gems didn't include this for Rails lower\n> than v5 though\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/wazery/ratyrate/pull/160#pullrequestreview-161265031>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AD-tAkNEjbAQxgw6R3M5N6i-ilhpdjeEks5uhO2hgaJpZM4V-Ii8>\n> .\n>\n"}}
{"actor":{"display_login":"an-nasir"}}