{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/230585346","pull_request_review_id":171359026,"id":230585346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU4NTM0Ng==","diff_hunk":"@@ -77,6 +76,10 @@ var config = {\n         format: 'progressive'\n       }\n     ]\n+  },\n+  abr: {\n+    fpsDroppedFramesInterval: 5000,\n+    fpsDroppedMonitoringThreshold: 0.2","path":"docs/configuration.md","position":26,"original_position":26,"commit_id":"920e3ca05af7f1e1413ccbe2545ce64bb0b91420","original_commit_id":"920e3ca05af7f1e1413ccbe2545ce64bb0b91420","user":{"login":"OrenMe","id":5461862,"node_id":"MDQ6VXNlcjU0NjE4NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false},"body":"missing `capLevelOnFPSDrop`","created_at":"2018-11-04T11:41:03Z","updated_at":"2018-11-04T11:43:14Z","html_url":"https://github.com/kaltura/playkit-js/pull/299#discussion_r230585346","pull_request_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/299","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/230585346"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/299#discussion_r230585346"},"pull_request":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/299","id":227653074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjUzMDc0","html_url":"https://github.com/kaltura/playkit-js/pull/299","diff_url":"https://github.com/kaltura/playkit-js/pull/299.diff","patch_url":"https://github.com/kaltura/playkit-js/pull/299.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-js/issues/299","number":299,"state":"open","locked":false,"title":"feat(FEC-7808): added the option to disable cap level on fps drop","user":{"login":"odedhutzler","id":31587052,"node_id":"MDQ6VXNlcjMxNTg3MDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"body":"added the option to disable cap level on fps drop\r\nand added new abr configuration:\r\n```\r\nabr: {\r\n fpsDroppedMonitoringThreshold: number,\r\n fpsDroppedFramesInterval: number,\r\n  capLevelOnFPSDrop: boolean\r\n}\r\n```\r\n\r\n### Description of the Changes\r\n\r\nPlease add a detailed description of the change, weather it's an enhancement or a bugfix.\r\nIf the PR is related to an open issue please link to it.\r\n\r\n### CheckLists\r\n\r\n- [ ] changes have been done against master branch, and PR does not conflict\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] test are passing in local environment \r\n- [ ] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] Docs have been updated\r\n","created_at":"2018-11-01T15:12:53Z","updated_at":"2018-11-04T11:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"856927728e4e1ebb615cbebadaf161ca4230173e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yairans","id":17685520,"node_id":"MDQ6VXNlcjE3Njg1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/17685520?v=4","gravatar_id":"","url":"https://api.github.com/users/yairans","html_url":"https://github.com/yairans","followers_url":"https://api.github.com/users/yairans/followers","following_url":"https://api.github.com/users/yairans/following{/other_user}","gists_url":"https://api.github.com/users/yairans/gists{/gist_id}","starred_url":"https://api.github.com/users/yairans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairans/subscriptions","organizations_url":"https://api.github.com/users/yairans/orgs","repos_url":"https://api.github.com/users/yairans/repos","events_url":"https://api.github.com/users/yairans/events{/privacy}","received_events_url":"https://api.github.com/users/yairans/received_events","type":"User","site_admin":false},{"login":"dan-ziv","id":21081590,"node_id":"MDQ6VXNlcjIxMDgxNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/21081590?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-ziv","html_url":"https://github.com/dan-ziv","followers_url":"https://api.github.com/users/dan-ziv/followers","following_url":"https://api.github.com/users/dan-ziv/following{/other_user}","gists_url":"https://api.github.com/users/dan-ziv/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-ziv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-ziv/subscriptions","organizations_url":"https://api.github.com/users/dan-ziv/orgs","repos_url":"https://api.github.com/users/dan-ziv/repos","events_url":"https://api.github.com/users/dan-ziv/events{/privacy}","received_events_url":"https://api.github.com/users/dan-ziv/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/299/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/299/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/issues/299/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/920e3ca05af7f1e1413ccbe2545ce64bb0b91420","head":{"label":"kaltura:FEC-7808-disable-abr","ref":"FEC-7808-disable-abr","sha":"920e3ca05af7f1e1413ccbe2545ce64bb0b91420","user":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQwNzYyOQ==","name":"playkit-js","full_name":"kaltura/playkit-js","private":false,"owner":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kaltura/playkit-js","description":"State of the Art HTML5 Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2018-11-01T08:22:03Z","pushed_at":"2018-11-04T09:14:13Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":49663,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":10,"open_issues":5,"watchers":26,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"c0e294f3393c235bc2b23dd6534931a4a4dd0653","user":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQwNzYyOQ==","name":"playkit-js","full_name":"kaltura/playkit-js","private":false,"owner":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kaltura/playkit-js","description":"State of the Art HTML5 Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2018-11-01T08:22:03Z","pushed_at":"2018-11-04T09:14:13Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":49663,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":10,"open_issues":5,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/299"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/299"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/299"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-js/statuses/920e3ca05af7f1e1413ccbe2545ce64bb0b91420"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OrenMe"}}