{"action":"created","issue":{"url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/36","repository_url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend","labels_url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/36/comments","events_url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/36/events","html_url":"https://github.com/Tour-Collective-Devs/tc_backend/pull/36","id":355778891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjMwMjY1","number":36,"title":"added boolean fields upon registration","user":{"login":"RileyMathews","id":37124104,"node_id":"MDQ6VXNlcjM3MTI0MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/37124104?v=4","gravatar_id":"","url":"https://api.github.com/users/RileyMathews","html_url":"https://github.com/RileyMathews","followers_url":"https://api.github.com/users/RileyMathews/followers","following_url":"https://api.github.com/users/RileyMathews/following{/other_user}","gists_url":"https://api.github.com/users/RileyMathews/gists{/gist_id}","starred_url":"https://api.github.com/users/RileyMathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RileyMathews/subscriptions","organizations_url":"https://api.github.com/users/RileyMathews/orgs","repos_url":"https://api.github.com/users/RileyMathews/repos","events_url":"https://api.github.com/users/RileyMathews/events{/privacy}","received_events_url":"https://api.github.com/users/RileyMathews/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-30T22:38:54Z","updated_at":"2018-09-01T22:30:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/pulls/36","html_url":"https://github.com/Tour-Collective-Devs/tc_backend/pull/36","diff_url":"https://github.com/Tour-Collective-Devs/tc_backend/pull/36.diff","patch_url":"https://github.com/Tour-Collective-Devs/tc_backend/pull/36.patch"},"body":"## Link to Ticket\r\n\r\nAutolink format: hashtag and number, ex: #1094\r\n\r\nCloses #35 \r\n\r\n## Description of Proposed Changes\r\nEdited user registration serializer to take in information to fill the two boolean fields for is crew member or is employer\r\n\r\n## Steps to Test\r\n\r\nOutline the steps to test\r\n\r\n```sh\r\ngit fetch --all\r\ngit checkout rm-user-boolean-fields\r\n```\r\n1. load up api\r\n1. navigate to the registration page and see the new boolean fields\r\n1. try to register a new user and check one of these boolean fields\r\n1. the new user should have that information saved onto the user model\r\n1. it is currently possible to create a user that is both a crew member and employer, we will have to take measures on the front end to make sure there is no way for a user to submit a registration form with both fields checked. \r\n\r\n## Impacted Areas in Application\r\nuser registration serializer\r\n\r\nList general components of the application that this PR will affect:\r\n\r\n## Mentions @username\r\n\r\nTag users that need to review this code\r\n\r\n## Testing\r\n\r\n[ ] There are new unit tests in this PR, and I verify that there is full coverage of all new code.\r\n[ ] I certify that all existing tests pass\r\n\r\n## Deploy Notes\r\n\r\nNotes regarding deployment the contained body of work.  These should note any\r\ndb migrations, etc.\r\n\r\n## Definition of Done\r\n\r\n1. The project must be fully documented. This includes the following:\r\n1. Complete README that documents the steps to install the code, how to install any dependencies, or system configuration needed.\r\n1. Every class must be documented with purpose, author, and methods.\r\n1. Every method must be documented with purpose and argument list - which itself must contain a short purpose for each argument.\r\n1. The project must be able to run fully, and without errors, on each teammate's system.\r\n1. Fulfills every requirement.\r\n1. Every line of code has been peer reviewed.\r\n1. For projects that require unit testing, core functionality must be identified and have at least one test for each\r\n"},"comment":{"url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/comments/417891759","html_url":"https://github.com/Tour-Collective-Devs/tc_backend/pull/36#issuecomment-417891759","issue_url":"https://api.github.com/repos/Tour-Collective-Devs/tc_backend/issues/36","id":417891759,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzg5MTc1OQ==","user":{"login":"JacobAndrewSmith92","id":15852908,"node_id":"MDQ6VXNlcjE1ODUyOTA4","avatar_url":"https://avatars1.githubusercontent.com/u/15852908?v=4","gravatar_id":"","url":"https://api.github.com/users/JacobAndrewSmith92","html_url":"https://github.com/JacobAndrewSmith92","followers_url":"https://api.github.com/users/JacobAndrewSmith92/followers","following_url":"https://api.github.com/users/JacobAndrewSmith92/following{/other_user}","gists_url":"https://api.github.com/users/JacobAndrewSmith92/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobAndrewSmith92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobAndrewSmith92/subscriptions","organizations_url":"https://api.github.com/users/JacobAndrewSmith92/orgs","repos_url":"https://api.github.com/users/JacobAndrewSmith92/repos","events_url":"https://api.github.com/users/JacobAndrewSmith92/events{/privacy}","received_events_url":"https://api.github.com/users/JacobAndrewSmith92/received_events","type":"User","site_admin":false},"created_at":"2018-09-01T22:30:09Z","updated_at":"2018-09-01T22:30:09Z","author_association":"CONTRIBUTOR","body":"It lives!!"}}
{"actor":{"display_login":"JacobAndrewSmith92"}}