{"action":"created","issue":{"url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/11","repository_url":"https://api.github.com/repos/Sterc/SimpleSearch","labels_url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/11/comments","events_url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/11/events","html_url":"https://github.com/Sterc/SimpleSearch/pull/11","id":375928570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjU4ODA0","number":11,"title":"Fixing issue when searching with includedTVs","user":{"login":"sdrenth","id":7802465,"node_id":"MDQ6VXNlcjc4MDI0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7802465?v=4","gravatar_id":"","url":"https://api.github.com/users/sdrenth","html_url":"https://github.com/sdrenth","followers_url":"https://api.github.com/users/sdrenth/followers","following_url":"https://api.github.com/users/sdrenth/following{/other_user}","gists_url":"https://api.github.com/users/sdrenth/gists{/gist_id}","starred_url":"https://api.github.com/users/sdrenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdrenth/subscriptions","organizations_url":"https://api.github.com/users/sdrenth/orgs","repos_url":"https://api.github.com/users/sdrenth/repos","events_url":"https://api.github.com/users/sdrenth/events{/privacy}","received_events_url":"https://api.github.com/users/sdrenth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-31T12:01:02Z","updated_at":"2018-11-03T12:37:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Sterc/SimpleSearch/pulls/11","html_url":"https://github.com/Sterc/SimpleSearch/pull/11","diff_url":"https://github.com/Sterc/SimpleSearch/pull/11.diff","patch_url":"https://github.com/Sterc/SimpleSearch/pull/11.patch"},"body":"Fixing leftJoin when using includeTVs"},"comment":{"url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/comments/435584670","html_url":"https://github.com/Sterc/SimpleSearch/pull/11#issuecomment-435584670","issue_url":"https://api.github.com/repos/Sterc/SimpleSearch/issues/11","id":435584670,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTU4NDY3MA==","user":{"login":"travisbotello","id":1157380,"node_id":"MDQ6VXNlcjExNTczODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1157380?v=4","gravatar_id":"","url":"https://api.github.com/users/travisbotello","html_url":"https://github.com/travisbotello","followers_url":"https://api.github.com/users/travisbotello/followers","following_url":"https://api.github.com/users/travisbotello/following{/other_user}","gists_url":"https://api.github.com/users/travisbotello/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbotello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbotello/subscriptions","organizations_url":"https://api.github.com/users/travisbotello/orgs","repos_url":"https://api.github.com/users/travisbotello/repos","events_url":"https://api.github.com/users/travisbotello/events{/privacy}","received_events_url":"https://api.github.com/users/travisbotello/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T12:37:24Z","updated_at":"2018-11-03T12:37:24Z","author_association":"CONTRIBUTOR","body":"This would revert the already tested and merged fix for #3. When I test your commit I have access to all TVs no matter if I set them via `includeTVList` or not. IMHO when you first `leftJoin` all TVs without a condition and later add another `leftJoin` with `includeTVList` condition the query returns all TVs. That's why I used an `if else` to only `leftJoin` the TVs in `includeTVList` or when empty include all TVs."}}
{"actor":{"display_login":"travisbotello"}}