{"action":"opened","number":506,"pull_request":{"url":"https://api.github.com/repos/omisego/ewallet/pulls/506","id":227571147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTcxMTQ3","html_url":"https://github.com/omisego/ewallet/pull/506","diff_url":"https://github.com/omisego/ewallet/pull/506.diff","patch_url":"https://github.com/omisego/ewallet/pull/506.patch","issue_url":"https://api.github.com/repos/omisego/ewallet/issues/506","number":506,"state":"open","locked":false,"title":"Fix internal server error when trying to filter a field that's not allowed","user":{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false},"body":"Closes #505\r\n\r\n# Overview\r\n\r\nThis PR fixes the internal server error that is returned when attempting to filter records with a field that's not allowed.\r\n\r\nThis PR is based on the changes in #501 so it's based out of #501 until merged.\r\n\r\n# Changes\r\n\r\n- Handles when `{:error, :not_allowed, field}` is returned by the parser in `EWallet.Web.Orchestrator`\r\n\r\n# Implementation Details\r\n\r\nN/A\r\n\r\n# Usage\r\n\r\n```\r\ncurl 10.5.10.10:4000/api/admin/transaction.all -H \"Accept: application/vnd.omisego.v1+json\" -H \"Authorization: OMGAdmin <truncated>\" -H \"Content-Type: application/json\" -d '{\r\n  \"match_all\": [\r\n    {\r\n      \"comparator\": \"eq\",\r\n      \"field\": \"1232131\",\r\n      \"value\": true\r\n    }\r\n  ],\r\n  \"page\": 1,\r\n  \"per_page\": 10,\r\n  \"sort_by\": \"name\",\r\n  \"sort_dir\": \"asc\"\r\n}' -v -w \"\\n\"\r\n```\r\n\r\nShould now return a `client:invalid_parameter` error rather than an `internal_server_error` error.\r\n\r\n# Impact\r\n\r\nNo DB or API changes.","created_at":"2018-11-01T10:15:23Z","updated_at":"2018-11-01T10:15:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false},"assignees":[{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false},{"login":"mederic-p","id":32560642,"node_id":"MDQ6VXNlcjMyNTYwNjQy","avatar_url":"https://avatars3.githubusercontent.com/u/32560642?v=4","gravatar_id":"","url":"https://api.github.com/users/mederic-p","html_url":"https://github.com/mederic-p","followers_url":"https://api.github.com/users/mederic-p/followers","following_url":"https://api.github.com/users/mederic-p/following{/other_user}","gists_url":"https://api.github.com/users/mederic-p/gists{/gist_id}","starred_url":"https://api.github.com/users/mederic-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mederic-p/subscriptions","organizations_url":"https://api.github.com/users/mederic-p/orgs","repos_url":"https://api.github.com/users/mederic-p/repos","events_url":"https://api.github.com/users/mederic-p/events{/privacy}","received_events_url":"https://api.github.com/users/mederic-p/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omisego/ewallet/pulls/506/commits","review_comments_url":"https://api.github.com/repos/omisego/ewallet/pulls/506/comments","review_comment_url":"https://api.github.com/repos/omisego/ewallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omisego/ewallet/issues/506/comments","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/64ab05637c3652804a4fb8f7ba2ba4e2d888c837","head":{"label":"omisego:505-filter-not-allowed","ref":"505-filter-not-allowed","sha":"64ab05637c3652804a4fb8f7ba2ba4e2d888c837","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":116826798,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjY3OTg=","name":"ewallet","full_name":"omisego/ewallet","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/ewallet","description":"eWallet Backend for the OmiseGO SDKs.","fork":false,"url":"https://api.github.com/repos/omisego/ewallet","forks_url":"https://api.github.com/repos/omisego/ewallet/forks","keys_url":"https://api.github.com/repos/omisego/ewallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/ewallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/ewallet/teams","hooks_url":"https://api.github.com/repos/omisego/ewallet/hooks","issue_events_url":"https://api.github.com/repos/omisego/ewallet/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/ewallet/events","assignees_url":"https://api.github.com/repos/omisego/ewallet/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/ewallet/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/ewallet/tags","blobs_url":"https://api.github.com/repos/omisego/ewallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/ewallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/ewallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/ewallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/ewallet/languages","stargazers_url":"https://api.github.com/repos/omisego/ewallet/stargazers","contributors_url":"https://api.github.com/repos/omisego/ewallet/contributors","subscribers_url":"https://api.github.com/repos/omisego/ewallet/subscribers","subscription_url":"https://api.github.com/repos/omisego/ewallet/subscription","commits_url":"https://api.github.com/repos/omisego/ewallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/ewallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/ewallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/ewallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/ewallet/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/ewallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/ewallet/merges","archive_url":"https://api.github.com/repos/omisego/ewallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/ewallet/downloads","issues_url":"https://api.github.com/repos/omisego/ewallet/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/ewallet/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/ewallet/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/ewallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/ewallet/labels{/name}","releases_url":"https://api.github.com/repos/omisego/ewallet/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/ewallet/deployments","created_at":"2018-01-09T14:31:13Z","updated_at":"2018-11-01T07:39:02Z","pushed_at":"2018-11-01T10:10:24Z","git_url":"git://github.com/omisego/ewallet.git","ssh_url":"git@github.com:omisego/ewallet.git","clone_url":"https://github.com/omisego/ewallet.git","svn_url":"https://github.com/omisego/ewallet","homepage":"https://omisego.network/","size":23360,"stargazers_count":239,"watchers_count":239,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":56,"watchers":239,"default_branch":"master"}},"base":{"label":"omisego:501-match-any","ref":"501-match-any","sha":"cf863107d6ca9481af84c5ad2c549434570b1f3a","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":116826798,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjY3OTg=","name":"ewallet","full_name":"omisego/ewallet","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/ewallet","description":"eWallet Backend for the OmiseGO SDKs.","fork":false,"url":"https://api.github.com/repos/omisego/ewallet","forks_url":"https://api.github.com/repos/omisego/ewallet/forks","keys_url":"https://api.github.com/repos/omisego/ewallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/ewallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/ewallet/teams","hooks_url":"https://api.github.com/repos/omisego/ewallet/hooks","issue_events_url":"https://api.github.com/repos/omisego/ewallet/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/ewallet/events","assignees_url":"https://api.github.com/repos/omisego/ewallet/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/ewallet/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/ewallet/tags","blobs_url":"https://api.github.com/repos/omisego/ewallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/ewallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/ewallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/ewallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/ewallet/languages","stargazers_url":"https://api.github.com/repos/omisego/ewallet/stargazers","contributors_url":"https://api.github.com/repos/omisego/ewallet/contributors","subscribers_url":"https://api.github.com/repos/omisego/ewallet/subscribers","subscription_url":"https://api.github.com/repos/omisego/ewallet/subscription","commits_url":"https://api.github.com/repos/omisego/ewallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/ewallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/ewallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/ewallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/ewallet/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/ewallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/ewallet/merges","archive_url":"https://api.github.com/repos/omisego/ewallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/ewallet/downloads","issues_url":"https://api.github.com/repos/omisego/ewallet/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/ewallet/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/ewallet/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/ewallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/ewallet/labels{/name}","releases_url":"https://api.github.com/repos/omisego/ewallet/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/ewallet/deployments","created_at":"2018-01-09T14:31:13Z","updated_at":"2018-11-01T07:39:02Z","pushed_at":"2018-11-01T10:10:24Z","git_url":"git://github.com/omisego/ewallet.git","ssh_url":"git@github.com:omisego/ewallet.git","clone_url":"https://github.com/omisego/ewallet.git","svn_url":"https://github.com/omisego/ewallet","homepage":"https://omisego.network/","size":23360,"stargazers_count":239,"watchers_count":239,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":56,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/506"},"html":{"href":"https://github.com/omisego/ewallet/pull/506"},"issue":{"href":"https://api.github.com/repos/omisego/ewallet/issues/506"},"comments":{"href":"https://api.github.com/repos/omisego/ewallet/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/omisego/ewallet/statuses/64ab05637c3652804a4fb8f7ba2ba4e2d888c837"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":29,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"unnawut"}}