{"action":"created","issue":{"url":"https://api.github.com/repos/badges/shields/issues/2232","repository_url":"https://api.github.com/repos/badges/shields","labels_url":"https://api.github.com/repos/badges/shields/issues/2232/labels{/name}","comments_url":"https://api.github.com/repos/badges/shields/issues/2232/comments","events_url":"https://api.github.com/repos/badges/shields/issues/2232/events","html_url":"https://github.com/badges/shields/pull/2232","id":375217943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzE0NjQz","number":2232,"title":"Refactor [Jetbrains] service; affects [eclipse-marketplace]","user":{"login":"platan","id":1526000,"node_id":"MDQ6VXNlcjE1MjYwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1526000?v=4","gravatar_id":"","url":"https://api.github.com/users/platan","html_url":"https://github.com/platan","followers_url":"https://api.github.com/users/platan/followers","following_url":"https://api.github.com/users/platan/following{/other_user}","gists_url":"https://api.github.com/users/platan/gists{/gist_id}","starred_url":"https://api.github.com/users/platan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platan/subscriptions","organizations_url":"https://api.github.com/users/platan/orgs","repos_url":"https://api.github.com/users/platan/repos","events_url":"https://api.github.com/users/platan/events{/privacy}","received_events_url":"https://api.github.com/users/platan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-29T21:10:00Z","updated_at":"2018-10-31T06:38:48Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/badges/shields/pulls/2232","html_url":"https://github.com/badges/shields/pull/2232","diff_url":"https://github.com/badges/shields/pull/2232.diff","patch_url":"https://github.com/badges/shields/pull/2232.patch"},"body":"Jetbrains service gets data from XML. Downloads value is stored in an attribute. [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser#readme) ignores attributes by default. Version value is stored in an element, but all elements are parsed by default (`Parse the value of text node to float, integer, or boolean.`) - this causes a problem if version value is `1.0` - it's parsed to `1`. I had to change default parser options for this service. I've added an option `parserOptions` in `_requestXml` to pass parser options. \r\nI've left service tests in one file - it should be easier to review changes (in a separate PR I can split them). \r\nDo you have an idea how to test `parserOptions` in unit test (`base-xml.spec.js`)?"},"comment":{"url":"https://api.github.com/repos/badges/shields/issues/comments/434577797","html_url":"https://github.com/badges/shields/pull/2232#issuecomment-434577797","issue_url":"https://api.github.com/repos/badges/shields/issues/2232","id":434577797,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDU3Nzc5Nw==","user":{"login":"TagnumElite","id":6497721,"node_id":"MDQ6VXNlcjY0OTc3MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6497721?v=4","gravatar_id":"","url":"https://api.github.com/users/TagnumElite","html_url":"https://github.com/TagnumElite","followers_url":"https://api.github.com/users/TagnumElite/followers","following_url":"https://api.github.com/users/TagnumElite/following{/other_user}","gists_url":"https://api.github.com/users/TagnumElite/gists{/gist_id}","starred_url":"https://api.github.com/users/TagnumElite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TagnumElite/subscriptions","organizations_url":"https://api.github.com/users/TagnumElite/orgs","repos_url":"https://api.github.com/users/TagnumElite/repos","events_url":"https://api.github.com/users/TagnumElite/events{/privacy}","received_events_url":"https://api.github.com/users/TagnumElite/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T06:38:48Z","updated_at":"2018-10-31T06:38:48Z","author_association":"CONTRIBUTOR","body":"I would like to, however, my exams have just started so right now till 20th\nNovember is a bad time for anything. I will only have available time over\nthe weekend. I do also live in South Africa, so my late responses may come\nfrom differentiating timezones.\n\nOn Tue, 30 Oct 2018 at 20:37, Pierre-Yves B. <notifications@github.com>\nwrote:\n\n> @TagnumElite <https://github.com/TagnumElite> you've recently submitted a\n> few service refactoring pull requests. Would you like to tackle a review\n> and have a look at the work done by @platan <https://github.com/platan>?\n> No pressure though, just ping me if you're not comfortable doing this just\n> yet or if you're short on time at the moment! 😉\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/badges/shields/pull/2232#issuecomment-434417449>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AGMluX2Km7sPRRw8SbBXYt3eIqmuW-A-ks5uqJx6gaJpZM4YAaXs>\n> .\n>\n"}}
{"actor":{"display_login":"TagnumElite"}}