{"action":"created","comment":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/comments/200150869","pull_request_review_id":134410006,"id":200150869,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDE1MDg2OQ==","diff_hunk":"@@ -93,6 +134,9 @@ export class QuerySummary extends Component {\n     $$(this.textContainer).empty();\n     this.show();\n \n+    this.hideCustomNoResultsPage();\n+    this.updateQueryTagsInNoResultsContainer();","path":"src/ui/QuerySummary/QuerySummary.ts","position":110,"original_position":110,"commit_id":"f9c6b7bbe0655cb06df3a3898265b703ba9f0ad8","original_commit_id":"f9c6b7bbe0655cb06df3a3898265b703ba9f0ad8","user":{"login":"huppeje","id":39059543,"node_id":"MDQ6VXNlcjM5MDU5NTQz","avatar_url":"https://avatars0.githubusercontent.com/u/39059543?v=4","gravatar_id":"","url":"https://api.github.com/users/huppeje","html_url":"https://github.com/huppeje","followers_url":"https://api.github.com/users/huppeje/followers","following_url":"https://api.github.com/users/huppeje/following{/other_user}","gists_url":"https://api.github.com/users/huppeje/gists{/gist_id}","starred_url":"https://api.github.com/users/huppeje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huppeje/subscriptions","organizations_url":"https://api.github.com/users/huppeje/orgs","repos_url":"https://api.github.com/users/huppeje/repos","events_url":"https://api.github.com/users/huppeje/events{/privacy}","received_events_url":"https://api.github.com/users/huppeje/received_events","type":"User","site_admin":false},"body":"Good point this function could be moved under the condition `(queryResults.results.length == 0)` with the function `displayInfoOnNoResults()`\r\n\r\n`updateQueryTagsInNoResultsContainer()` takes care of updating multiple queries with this logic : \r\n```\r\n\r\n     $$(noResultsContainer)\r\n        .findAll(`.${queryTagCssClass}`)\r\n        .forEach(queryTagContainer => {\r\n          queryTagContainer.innerHTML = this.queryEscaped;\r\n        });\r\n\r\n```\r\n (see the response to the other comment below). ","created_at":"2018-07-04T14:53:39Z","updated_at":"2018-07-04T14:53:39Z","html_url":"https://github.com/coveo/search-ui/pull/843#discussion_r200150869","pull_request_url":"https://api.github.com/repos/coveo/search-ui/pulls/843","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments/200150869"},"html":{"href":"https://github.com/coveo/search-ui/pull/843#discussion_r200150869"},"pull_request":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/843"}},"in_reply_to_id":199945701},"pull_request":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/843","id":193650826,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjUwODI2","html_url":"https://github.com/coveo/search-ui/pull/843","diff_url":"https://github.com/coveo/search-ui/pull/843.diff","patch_url":"https://github.com/coveo/search-ui/pull/843.patch","issue_url":"https://api.github.com/repos/coveo/search-ui/issues/843","number":843,"state":"open","locked":false,"title":"JSUI-2112: Added options to QuerySummary ","user":{"login":"huppeje","id":39059543,"node_id":"MDQ6VXNlcjM5MDU5NTQz","avatar_url":"https://avatars0.githubusercontent.com/u/39059543?v=4","gravatar_id":"","url":"https://api.github.com/users/huppeje","html_url":"https://github.com/huppeje","followers_url":"https://api.github.com/users/huppeje/followers","following_url":"https://api.github.com/users/huppeje/following{/other_user}","gists_url":"https://api.github.com/users/huppeje/gists{/gist_id}","starred_url":"https://api.github.com/users/huppeje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huppeje/subscriptions","organizations_url":"https://api.github.com/users/huppeje/orgs","repos_url":"https://api.github.com/users/huppeje/repos","events_url":"https://api.github.com/users/huppeje/events{/privacy}","received_events_url":"https://api.github.com/users/huppeje/received_events","type":"User","site_admin":false},"body":"https://coveord.atlassian.net/browse/JSUI-2112\r\n\r\nJSUI-2112: Added options to QuerySummary \r\n\r\n\r\n","created_at":"2018-06-08T15:35:04Z","updated_at":"2018-07-04T14:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"dms1lva","id":6422665,"node_id":"MDQ6VXNlcjY0MjI2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6422665?v=4","gravatar_id":"","url":"https://api.github.com/users/dms1lva","html_url":"https://github.com/dms1lva","followers_url":"https://api.github.com/users/dms1lva/followers","following_url":"https://api.github.com/users/dms1lva/following{/other_user}","gists_url":"https://api.github.com/users/dms1lva/gists{/gist_id}","starred_url":"https://api.github.com/users/dms1lva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dms1lva/subscriptions","organizations_url":"https://api.github.com/users/dms1lva/orgs","repos_url":"https://api.github.com/users/dms1lva/repos","events_url":"https://api.github.com/users/dms1lva/events{/privacy}","received_events_url":"https://api.github.com/users/dms1lva/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coveo/search-ui/pulls/843/commits","review_comments_url":"https://api.github.com/repos/coveo/search-ui/pulls/843/comments","review_comment_url":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coveo/search-ui/issues/843/comments","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/f9c6b7bbe0655cb06df3a3898265b703ba9f0ad8","head":{"label":"coveo:JSUI-2112","ref":"JSUI-2112","sha":"f9c6b7bbe0655cb06df3a3898265b703ba9f0ad8","user":{"login":"coveo","id":8632328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"node_id":"MDEwOlJlcG9zaXRvcnk1ODEzMzQ3MQ==","name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2018-07-04T12:56:54Z","pushed_at":"2018-07-04T12:56:52Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":146318,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":4,"watchers":47,"default_branch":"master"}},"base":{"label":"coveo:master","ref":"master","sha":"6c0abe3fab35a137da726d84f034111e3d9fbcc4","user":{"login":"coveo","id":8632328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"node_id":"MDEwOlJlcG9zaXRvcnk1ODEzMzQ3MQ==","name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2018-07-04T12:56:54Z","pushed_at":"2018-07-04T12:56:52Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":146318,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":4,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/843"},"html":{"href":"https://github.com/coveo/search-ui/pull/843"},"issue":{"href":"https://api.github.com/repos/coveo/search-ui/issues/843"},"comments":{"href":"https://api.github.com/repos/coveo/search-ui/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/coveo/search-ui/statuses/f9c6b7bbe0655cb06df3a3898265b703ba9f0ad8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"huppeje"}}