{"action":"created","issue":{"url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2936","repository_url":"https://api.github.com/repos/GafferHQ/gaffer","labels_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2936/labels{/name}","comments_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2936/comments","events_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2936/events","html_url":"https://github.com/GafferHQ/gaffer/issues/2936","id":389586128,"node_id":"MDU6SXNzdWUzODk1ODYxMjg=","number":2936,"title":"Update TAB-menu for modern NSI","user":{"login":"pberto","id":254052,"node_id":"MDQ6VXNlcjI1NDA1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/254052?v=4","gravatar_id":"","url":"https://api.github.com/users/pberto","html_url":"https://github.com/pberto","followers_url":"https://api.github.com/users/pberto/followers","following_url":"https://api.github.com/users/pberto/following{/other_user}","gists_url":"https://api.github.com/users/pberto/gists{/gist_id}","starred_url":"https://api.github.com/users/pberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pberto/subscriptions","organizations_url":"https://api.github.com/users/pberto/orgs","repos_url":"https://api.github.com/users/pberto/repos","events_url":"https://api.github.com/users/pberto/events{/privacy}","received_events_url":"https://api.github.com/users/pberto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-11T03:53:12Z","updated_at":"2018-12-11T11:40:54Z","closed_at":null,"author_association":"NONE","body":"This is based on Gaffer 0.52.3.1.\r\n\r\n~~First I would change the name of the Menu, it should be `3DelightNSI`, not `3Delight` to put some emphasis this is the new 3DelightNSI v1.x~~ \r\n\r\n## TAB Menu\r\n\r\nThe tools should to be reorganized:\r\n\r\n### Shaders\r\n\r\nThe list in the Shaders submenu should to be updated:\r\n\r\n- Standard (3DelightMaterial) is deprecated, `Principled` replaces that (dlPrincipled)\r\n- Hair should be renamed to `Hair&Fur` (dlHairAndFur)\r\n- `Substance` should be added to the list (dlSubstance)\r\n- `Layered` should be added to the list (dlLayered)\r\n- `RandomMaterial` should be added to the list (dlRandomMaterial)\r\n\r\n### Lights\r\n\r\nIn the Lights submenu:\r\n\r\n- `Area` should really be added (how can one light without area lights)\r\n- `Incandescent` should be added (this is a emissive light connected to a shape). I am not fully sure here as in Gaffer maybe there is another way to make incandescent lights, but nevertheless the shader should be listed here.\r\n\r\nA sub-submenu \"Light Filters\" could be added with:\r\n\r\n- Gobo (dlGoboFilterShape) -- I dont see Light filters in Arnold so I am not sure how you envision it in the node graph\r\n- Decay (dlDecayFilterShape)  -- I dont see Light filters in Arnold so I am not sure how you envision it in the node graph\r\n\r\n\r\n\r\n### Textures\r\n\r\nA **Textures** section should be added with:\r\n\r\n- Flakes3D (dlFlakes)\r\n- Worley3D (dlWorleyNoise)\r\n\r\n### Utilities\r\n\r\nA **Utilities** section should be added with:\r\n\r\n- Color Blend (dlColorBlend)\r\n- Color Correction (dlColorCorrection)\r\n- Facing Ration (dlFacingRatio)\r\n- Primitive Attribute (dlPrimitiveAttribute)\r\n- RandomInputColor (dlRandomInputColor)\r\n\r\n### Volumes \r\n\r\nA **Volumes** section should be added with:\r\n\r\n- Atmosphere (dlAtmpshere) -- In addition here you need to add a VDB3Delight node similar to the ArnoldVDB node\r\n- OpenVDB (dlOpenVDBShader) -- In addition here you need to add a 3DelightAtmosphere node similar to the Arnold one, where the user can pipe in this shader. \r\n\r\n### Environment\r\n\r\nAn **Environment** section should be added with:\r\n\r\n- sky (dlSky)\r\n\r\n### Attributes\r\n\r\nThe Attributes lack a lot of attributes, just FYI in Maya now there is:\r\n\r\n<img width=\"427\" alt=\"screen shot 2018-12-11 at 12 29 18 pm\" src=\"https://user-images.githubusercontent.com/254052/49790070-b5057b80-fd70-11e8-91d8-21717c9d5136.png\">\r\n\r\n### Options\r\n\r\nThe Options node lacks the following attributes:\r\n\r\n- Quality> volume samples (int 64)\r\n- Quality> max distance (float 1000)\r\n- Quality> Motion Blur (bool ON) \r\n\r\n### Cloud Render\r\n\r\nA could rendering node should be added once possible.\r\n\r\n### Displacement \r\n\r\nA displacement node souped be added mimicking the Maya one.\r\n\r\n###  Shader Ball\r\n\r\nI like what you have done with the shader ball in Arnold. Adding one for NSI would be nice."},"comment":{"url":"https://api.github.com/repos/GafferHQ/gaffer/issues/comments/446172969","html_url":"https://github.com/GafferHQ/gaffer/issues/2936#issuecomment-446172969","issue_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2936","id":446172969,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjE3Mjk2OQ==","user":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T11:40:54Z","updated_at":"2018-12-11T11:40:54Z","author_association":"MEMBER","body":"Arnold->**Shader**->Light->LightDecay"}}
{"actor":{"display_login":"johnhaddon"}}