{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/213901386","pull_request_review_id":150834662,"id":213901386,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzkwMTM4Ng==","diff_hunk":"@@ -359,25 +387,29 @@ public void Remove(object key)\n                 return;\n             }\n \n-            objectsTable.Remove(key);\n-            objectsArray.RemoveAt(index);\n+            EnsureObjectsTable();\n+            EnsureObjectsArray();\n+            _objectsTable.Remove(key);\n+            _objectsArray.RemoveAt(index);\n         }\n \n #region IDictionary implementation\n         public virtual IDictionaryEnumerator GetEnumerator()\n         {\n-            return new OrderedDictionaryEnumerator(objectsArray, OrderedDictionaryEnumerator.DictionaryEntry);\n+            EnsureObjectsArray();\n+            return new OrderedDictionaryEnumerator(_objectsArray, OrderedDictionaryEnumerator.DictionaryEntry);\n         }\n #endregion\n \n #region IEnumerable implementation\n         IEnumerator IEnumerable.GetEnumerator()\n         {\n-            return new OrderedDictionaryEnumerator(objectsArray, OrderedDictionaryEnumerator.DictionaryEntry);\n+            EnsureObjectsArray();\n+            return new OrderedDictionaryEnumerator(_objectsArray, OrderedDictionaryEnumerator.DictionaryEntry);\n         }\n #endregion\n \n-#region ISerializable implementation \n+#region ISerializable implementation","path":"src/System.Collections.Specialized/src/System/Collections/Specialized/OrderedDictionary.cs","position":265,"original_position":265,"commit_id":"551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a","original_commit_id":"551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a","user":{"login":"iSazonov","id":22290914,"node_id":"MDQ6VXNlcjIyMjkwOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/22290914?v=4","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"body":"I can not open your link - I see only progress bar :-(","created_at":"2018-08-30T04:36:49Z","updated_at":"2018-08-30T04:36:49Z","html_url":"https://github.com/dotnet/corefx/pull/32001#discussion_r213901386","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/32001","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/213901386"},"html":{"href":"https://github.com/dotnet/corefx/pull/32001#discussion_r213901386"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32001"}},"in_reply_to_id":213777221},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/32001","id":211469288,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDY5Mjg4","html_url":"https://github.com/dotnet/corefx/pull/32001","diff_url":"https://github.com/dotnet/corefx/pull/32001.diff","patch_url":"https://github.com/dotnet/corefx/pull/32001.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/32001","number":32001,"state":"open","locked":false,"title":"Exclude extra allocations in OrderedDictionary","user":{"login":"iSazonov","id":22290914,"node_id":"MDQ6VXNlcjIyMjkwOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/22290914?v=4","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"body":"Address #31972.\r\n\r\nAdd checks in properties to exclude allocations internal HashTable and ArrayList if they are not needed.\r\n\r\n","created_at":"2018-08-28T15:43:20Z","updated_at":"2018-08-30T04:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"831544c5dba05b57d764337e1a90d98d33f9ab95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/32001/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/32001/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/32001/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a","head":{"label":"iSazonov:fix-ordereddictionary","ref":"fix-ordereddictionary","sha":"551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a","user":{"login":"iSazonov","id":22290914,"node_id":"MDQ6VXNlcjIyMjkwOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/22290914?v=4","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"repo":{"id":146419663,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0MTk2NjM=","name":"corefx","full_name":"iSazonov/corefx","owner":{"login":"iSazonov","id":22290914,"node_id":"MDQ6VXNlcjIyMjkwOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/22290914?v=4","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iSazonov/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/iSazonov/corefx","forks_url":"https://api.github.com/repos/iSazonov/corefx/forks","keys_url":"https://api.github.com/repos/iSazonov/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iSazonov/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iSazonov/corefx/teams","hooks_url":"https://api.github.com/repos/iSazonov/corefx/hooks","issue_events_url":"https://api.github.com/repos/iSazonov/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/iSazonov/corefx/events","assignees_url":"https://api.github.com/repos/iSazonov/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/iSazonov/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/iSazonov/corefx/tags","blobs_url":"https://api.github.com/repos/iSazonov/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iSazonov/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iSazonov/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/iSazonov/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iSazonov/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/iSazonov/corefx/languages","stargazers_url":"https://api.github.com/repos/iSazonov/corefx/stargazers","contributors_url":"https://api.github.com/repos/iSazonov/corefx/contributors","subscribers_url":"https://api.github.com/repos/iSazonov/corefx/subscribers","subscription_url":"https://api.github.com/repos/iSazonov/corefx/subscription","commits_url":"https://api.github.com/repos/iSazonov/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/iSazonov/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/iSazonov/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/iSazonov/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/iSazonov/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/iSazonov/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iSazonov/corefx/merges","archive_url":"https://api.github.com/repos/iSazonov/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iSazonov/corefx/downloads","issues_url":"https://api.github.com/repos/iSazonov/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/iSazonov/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/iSazonov/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/iSazonov/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iSazonov/corefx/labels{/name}","releases_url":"https://api.github.com/repos/iSazonov/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/iSazonov/corefx/deployments","created_at":"2018-08-28T08:55:33Z","updated_at":"2018-08-28T08:56:28Z","pushed_at":"2018-08-29T04:51:45Z","git_url":"git://github.com/iSazonov/corefx.git","ssh_url":"git@github.com:iSazonov/corefx.git","clone_url":"https://github.com/iSazonov/corefx.git","svn_url":"https://github.com/iSazonov/corefx","homepage":"https://github.com/dotnet/core","size":186359,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7bb3ad18a7882e7067ee9e08240431a320c65482","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-08-30T00:44:54Z","pushed_at":"2018-08-30T02:26:23Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":186521,"stargazers_count":14692,"watchers_count":14692,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4276,"mirror_url":null,"archived":false,"open_issues_count":2537,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4276,"open_issues":2537,"watchers":14692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32001"},"html":{"href":"https://github.com/dotnet/corefx/pull/32001"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32001"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32001/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32001/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32001/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a"}},"author_association":"NONE"}}
{"actor":{"display_login":"iSazonov"}}