{"action":"created","comment":{"url":"https://api.github.com/repos/aragon/aragon.js/pulls/comments/224039049","pull_request_review_id":163309159,"id":224039049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDAzOTA0OQ==","diff_hunk":"@@ -11,13 +12,39 @@ export function addressesEqual (first, second) {\n   return first === second\n }\n \n+export function makeAddressLookupProxy (target) {\n+  return new Proxy(target, {\n+    get (target, property, receiver) {","path":"packages/aragon-wrapper/src/utils/index.js","position":13,"original_position":13,"commit_id":"9081df3296c7b13dc837b0b8165a61e2e4dab5c2","original_commit_id":"9081df3296c7b13dc837b0b8165a61e2e4dab5c2","user":{"login":"izqui","id":447328,"node_id":"MDQ6VXNlcjQ0NzMyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/447328?v=4","gravatar_id":"","url":"https://api.github.com/users/izqui","html_url":"https://github.com/izqui","followers_url":"https://api.github.com/users/izqui/followers","following_url":"https://api.github.com/users/izqui/following{/other_user}","gists_url":"https://api.github.com/users/izqui/gists{/gist_id}","starred_url":"https://api.github.com/users/izqui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izqui/subscriptions","organizations_url":"https://api.github.com/users/izqui/orgs","repos_url":"https://api.github.com/users/izqui/repos","events_url":"https://api.github.com/users/izqui/events{/privacy}","received_events_url":"https://api.github.com/users/izqui/received_events","type":"User","site_admin":false},"body":"Wouldn't it be simpler to also capture `set` and make sure all addresses are in the same format (lowercased)? Then the getter would only need to convert to lowercase and always use that as the key.","created_at":"2018-10-10T11:38:13Z","updated_at":"2018-10-10T11:39:24Z","html_url":"https://github.com/aragon/aragon.js/pull/173#discussion_r224039049","pull_request_url":"https://api.github.com/repos/aragon/aragon.js/pulls/173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/comments/224039049"},"html":{"href":"https://github.com/aragon/aragon.js/pull/173#discussion_r224039049"},"pull_request":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/aragon/aragon.js/pulls/173","id":221733644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzMzNjQ0","html_url":"https://github.com/aragon/aragon.js/pull/173","diff_url":"https://github.com/aragon/aragon.js/pull/173.diff","patch_url":"https://github.com/aragon/aragon.js/pull/173.patch","issue_url":"https://api.github.com/repos/aragon/aragon.js/issues/173","number":173,"state":"open","locked":false,"title":"Wrapper: add address lookup proxy","user":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"body":"A headache when dealing with addresses is the fact that they can be checksummed, all lowercase, or all uppercase. This makes it especially painful when doing comparisons and fetching information stored in key value maps.\r\n\r\nThis attempts to alleviate this by adding a [native `Proxy`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy) that wraps the exposed `permissions` observable's values so that property accesses will check all possible variations of an address.\r\n\r\nFixes issues with the Permissions app in aragon/aragon, where some apps are not being fetched properly due to the checksum variations.\r\n\r\n----------------------\r\n\r\nAs further steps, we could attempt to introduce checksum purity (we ensure that we either always or never have checksums) into internal state, start using some sort of `Address` type, etc.","created_at":"2018-10-10T10:18:59Z","updated_at":"2018-10-10T11:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b346e1d16c68cd729e48889c0d8bb9c769c5ad3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Quazia","id":6549550,"node_id":"MDQ6VXNlcjY1NDk1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6549550?v=4","gravatar_id":"","url":"https://api.github.com/users/Quazia","html_url":"https://github.com/Quazia","followers_url":"https://api.github.com/users/Quazia/followers","following_url":"https://api.github.com/users/Quazia/following{/other_user}","gists_url":"https://api.github.com/users/Quazia/gists{/gist_id}","starred_url":"https://api.github.com/users/Quazia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quazia/subscriptions","organizations_url":"https://api.github.com/users/Quazia/orgs","repos_url":"https://api.github.com/users/Quazia/repos","events_url":"https://api.github.com/users/Quazia/events{/privacy}","received_events_url":"https://api.github.com/users/Quazia/received_events","type":"User","site_admin":false},{"login":"0x6431346e","id":26041347,"node_id":"MDQ6VXNlcjI2MDQxMzQ3","avatar_url":"https://avatars1.githubusercontent.com/u/26041347?v=4","gravatar_id":"","url":"https://api.github.com/users/0x6431346e","html_url":"https://github.com/0x6431346e","followers_url":"https://api.github.com/users/0x6431346e/followers","following_url":"https://api.github.com/users/0x6431346e/following{/other_user}","gists_url":"https://api.github.com/users/0x6431346e/gists{/gist_id}","starred_url":"https://api.github.com/users/0x6431346e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0x6431346e/subscriptions","organizations_url":"https://api.github.com/users/0x6431346e/orgs","repos_url":"https://api.github.com/users/0x6431346e/repos","events_url":"https://api.github.com/users/0x6431346e/events{/privacy}","received_events_url":"https://api.github.com/users/0x6431346e/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/aragon/aragon.js/milestones/5","html_url":"https://github.com/aragon/aragon.js/milestone/5","labels_url":"https://api.github.com/repos/aragon/aragon.js/milestones/5/labels","id":3691073,"node_id":"MDk6TWlsZXN0b25lMzY5MTA3Mw==","number":5,"title":"Sprint: 2.2","description":"","creator":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-09-26T18:14:43Z","updated_at":"2018-10-10T10:19:11Z","due_on":"2018-10-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/aragon/aragon.js/pulls/173/commits","review_comments_url":"https://api.github.com/repos/aragon/aragon.js/pulls/173/comments","review_comment_url":"https://api.github.com/repos/aragon/aragon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aragon/aragon.js/issues/173/comments","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/9081df3296c7b13dc837b0b8165a61e2e4dab5c2","head":{"label":"aragon:add-address-lookup-proxy","ref":"add-address-lookup-proxy","sha":"9081df3296c7b13dc837b0b8165a61e2e4dab5c2","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":98191281,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE5MTI4MQ==","name":"aragon.js","full_name":"aragon/aragon.js","private":false,"owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aragon/aragon.js","description":"A JavaScript library for interacting with Aragon","fork":false,"url":"https://api.github.com/repos/aragon/aragon.js","forks_url":"https://api.github.com/repos/aragon/aragon.js/forks","keys_url":"https://api.github.com/repos/aragon/aragon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon.js/teams","hooks_url":"https://api.github.com/repos/aragon/aragon.js/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon.js/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon.js/events","assignees_url":"https://api.github.com/repos/aragon/aragon.js/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon.js/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon.js/tags","blobs_url":"https://api.github.com/repos/aragon/aragon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon.js/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon.js/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon.js/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon.js/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon.js/subscription","commits_url":"https://api.github.com/repos/aragon/aragon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon.js/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon.js/merges","archive_url":"https://api.github.com/repos/aragon/aragon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon.js/downloads","issues_url":"https://api.github.com/repos/aragon/aragon.js/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon.js/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon.js/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon.js/deployments","created_at":"2017-07-24T13:03:16Z","updated_at":"2018-10-09T22:26:30Z","pushed_at":"2018-10-10T11:27:25Z","git_url":"git://github.com/aragon/aragon.js.git","ssh_url":"git@github.com:aragon/aragon.js.git","clone_url":"https://github.com/aragon/aragon.js.git","svn_url":"https://github.com/aragon/aragon.js","homepage":"https://aragon.one","size":1835,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":23,"open_issues":54,"watchers":54,"default_branch":"master"}},"base":{"label":"aragon:master","ref":"master","sha":"ddff579a5d3d0789f82a26bcbbd17ec53d2c249d","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":98191281,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE5MTI4MQ==","name":"aragon.js","full_name":"aragon/aragon.js","private":false,"owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aragon/aragon.js","description":"A JavaScript library for interacting with Aragon","fork":false,"url":"https://api.github.com/repos/aragon/aragon.js","forks_url":"https://api.github.com/repos/aragon/aragon.js/forks","keys_url":"https://api.github.com/repos/aragon/aragon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon.js/teams","hooks_url":"https://api.github.com/repos/aragon/aragon.js/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon.js/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon.js/events","assignees_url":"https://api.github.com/repos/aragon/aragon.js/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon.js/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon.js/tags","blobs_url":"https://api.github.com/repos/aragon/aragon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon.js/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon.js/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon.js/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon.js/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon.js/subscription","commits_url":"https://api.github.com/repos/aragon/aragon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon.js/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon.js/merges","archive_url":"https://api.github.com/repos/aragon/aragon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon.js/downloads","issues_url":"https://api.github.com/repos/aragon/aragon.js/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon.js/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon.js/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon.js/deployments","created_at":"2017-07-24T13:03:16Z","updated_at":"2018-10-09T22:26:30Z","pushed_at":"2018-10-10T11:27:25Z","git_url":"git://github.com/aragon/aragon.js.git","ssh_url":"git@github.com:aragon/aragon.js.git","clone_url":"https://github.com/aragon/aragon.js.git","svn_url":"https://github.com/aragon/aragon.js","homepage":"https://aragon.one","size":1835,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":23,"open_issues":54,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/173"},"html":{"href":"https://github.com/aragon/aragon.js/pull/173"},"issue":{"href":"https://api.github.com/repos/aragon/aragon.js/issues/173"},"comments":{"href":"https://api.github.com/repos/aragon/aragon.js/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/aragon/aragon.js/statuses/9081df3296c7b13dc837b0b8165a61e2e4dab5c2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"izqui"}}