{"action":"created","comment":{"url":"https://api.github.com/repos/gonum/gonum/pulls/comments/200549056","pull_request_review_id":134886844,"id":200549056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU0OTA1Ng==","diff_hunk":"@@ -1180,7 +1180,9 @@ func testLocal(t *testing.T, tests []unconstrainedTest, method Method) {\n \t\t}\n \t\tsettings.GradientThreshold = test.gradTol\n \n-\t\tresult, err := Local(test.p, test.x, settings, method)","path":"optimize/unconstrained_test.go","position":13,"original_position":13,"commit_id":"d1590c8131adf50b4a8bc49ef41e27eaa65755de","original_commit_id":"d1590c8131adf50b4a8bc49ef41e27eaa65755de","user":{"login":"vladimir-ch","id":1837502,"node_id":"MDQ6VXNlcjE4Mzc1MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1837502?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-ch","html_url":"https://github.com/vladimir-ch","followers_url":"https://api.github.com/users/vladimir-ch/followers","following_url":"https://api.github.com/users/vladimir-ch/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-ch/subscriptions","organizations_url":"https://api.github.com/users/vladimir-ch/orgs","repos_url":"https://api.github.com/users/vladimir-ch/repos","events_url":"https://api.github.com/users/vladimir-ch/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-ch/received_events","type":"User","site_admin":false},"body":"> I imagine that's a reasonable default for a lot of problems\r\n\r\nThis is the point that I'm not so sure about in practice. Having a mandatory `initX` slice would send a clear message that the starting location determines the local minimum in case there are more of them.\r\n\r\n> I also don't think it's true that global methods have an initial location\r\n\r\nHere I meant a starting location in a more general sense, that's why I wrote \"where they are started\". All your examples have a starting something that determines where the minima will be searched for. `ListOpt` is a bit of an outlier, it satisfies `GlobalMethod` but I would not call it a _method_.\r\n\r\nAnyway, my comment was just a comment, I'm fine with the change.","created_at":"2018-07-06T04:54:29Z","updated_at":"2018-07-06T04:54:30Z","html_url":"https://github.com/gonum/gonum/pull/538#discussion_r200549056","pull_request_url":"https://api.github.com/repos/gonum/gonum/pulls/538","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments/200549056"},"html":{"href":"https://github.com/gonum/gonum/pull/538#discussion_r200549056"},"pull_request":{"href":"https://api.github.com/repos/gonum/gonum/pulls/538"}},"in_reply_to_id":200235215},"pull_request":{"url":"https://api.github.com/repos/gonum/gonum/pulls/538","id":198195647,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTk1NjQ3","html_url":"https://github.com/gonum/gonum/pull/538","diff_url":"https://github.com/gonum/gonum/pull/538.diff","patch_url":"https://github.com/gonum/gonum/pull/538.patch","issue_url":"https://api.github.com/repos/gonum/gonum/issues/538","number":538,"state":"open","locked":false,"title":"optimize: Remove Local function","user":{"login":"btracey","id":3680859,"node_id":"MDQ6VXNlcjM2ODA4NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3680859?v=4","gravatar_id":"","url":"https://api.github.com/users/btracey","html_url":"https://github.com/btracey","followers_url":"https://api.github.com/users/btracey/followers","following_url":"https://api.github.com/users/btracey/following{/other_user}","gists_url":"https://api.github.com/users/btracey/gists{/gist_id}","starred_url":"https://api.github.com/users/btracey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btracey/subscriptions","organizations_url":"https://api.github.com/users/btracey/orgs","repos_url":"https://api.github.com/users/btracey/repos","events_url":"https://api.github.com/users/btracey/events{/privacy}","received_events_url":"https://api.github.com/users/btracey/received_events","type":"User","site_admin":false},"body":"This change removes the Local function. In order to do so, this changes the previous LocalGlobal wrapper to LocalController to allow Local methods to be used as a Global optimizer. This adds methods to all of the Local methods in order to implement GlobalMethod, and changes the tests accordingly. The next commit will fix all of the names\r\n\r\nPlease take a look.\r\n\r\n<!--\r\nChecklist:\r\n\r\n- API changes have been discussed\r\n- code is goformated correctly (goimports)\r\n- packages with generated code have had code generation run\r\n- tests pass locally\r\n- linked to relevant issues\r\n\r\nPlease make sure your commit message summary line and pull request\r\ntitle match the Go convention; a one-line summary of the change,\r\nprefixed by the primary affected package that should complete the\r\nsentence, \"This change modifies Gonum to _____.\"\r\n-->\r\n","created_at":"2018-06-29T01:50:40Z","updated_at":"2018-07-06T04:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f209d16b0e823f04702f8e1409c69583f68490","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gonum/gonum/pulls/538/commits","review_comments_url":"https://api.github.com/repos/gonum/gonum/pulls/538/comments","review_comment_url":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gonum/gonum/issues/538/comments","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/d1590c8131adf50b4a8bc49ef41e27eaa65755de","head":{"label":"gonum:removelocal","ref":"removelocal","sha":"d1590c8131adf50b4a8bc49ef41e27eaa65755de","user":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE2NDk4Mg==","name":"gonum","full_name":"gonum/gonum","owner":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2018-07-06T04:42:17Z","pushed_at":"2018-07-05T23:35:11Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":11028,"stargazers_count":1811,"watchers_count":1811,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":118,"open_issues":96,"watchers":1811,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"e9e56344e335b77c52738092530a60fd12db0351","user":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE2NDk4Mg==","name":"gonum","full_name":"gonum/gonum","owner":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2018-07-06T04:42:17Z","pushed_at":"2018-07-05T23:35:11Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":11028,"stargazers_count":1811,"watchers_count":1811,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":118,"open_issues":96,"watchers":1811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/538"},"html":{"href":"https://github.com/gonum/gonum/pull/538"},"issue":{"href":"https://api.github.com/repos/gonum/gonum/issues/538"},"comments":{"href":"https://api.github.com/repos/gonum/gonum/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/gonum/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gonum/gonum/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/gonum/statuses/d1590c8131adf50b4a8bc49ef41e27eaa65755de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vladimir-ch"}}