{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18524","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18524/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18524/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18524/events","html_url":"https://github.com/magento/magento2/pull/18524","id":369048110,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDc5OTIy","number":18524,"title":"Added option to exclude discount amount from minimum order amount calculation","user":{"login":"ccasciotti","id":4273323,"node_id":"MDQ6VXNlcjQyNzMzMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4273323?v=4","gravatar_id":"","url":"https://api.github.com/users/ccasciotti","html_url":"https://github.com/ccasciotti","followers_url":"https://api.github.com/users/ccasciotti/followers","following_url":"https://api.github.com/users/ccasciotti/following{/other_user}","gists_url":"https://api.github.com/users/ccasciotti/gists{/gist_id}","starred_url":"https://api.github.com/users/ccasciotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccasciotti/subscriptions","organizations_url":"https://api.github.com/users/ccasciotti/orgs","repos_url":"https://api.github.com/users/ccasciotti/repos","events_url":"https://api.github.com/users/ccasciotti/events{/privacy}","received_events_url":"https://api.github.com/users/ccasciotti/received_events","type":"User","site_admin":false},"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":947887501,"node_id":"MDU6TGFiZWw5NDc4ODc1MDE=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Quote","name":"Component: Quote","color":"7fb703","default":false},{"id":375313023,"node_id":"MDU6TGFiZWwzNzUzMTMwMjM=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Sales","name":"Component: Sales","color":"7fb703","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-11T10:09:56Z","updated_at":"2018-10-23T22:17:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18524","html_url":"https://github.com/magento/magento2/pull/18524","diff_url":"https://github.com/magento/magento2/pull/18524.diff","patch_url":"https://github.com/magento/magento2/pull/18524.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\nThis PR adds option for store manager to include or exclude discount amount from minimum order amount calculation. Sometimes client wants to exclude discount amount from minimum order and want that only subtotal is used. The default option is set to \"Yes\" so Magento will use the current behavior.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\nnone\r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. Access backend\r\n2. Go to Stores > Configuration > Sales > Sales > Minimum Order Amount\r\n3. Leave \"Yes\" in \"Include Discount Amount\" field to test normal behavior.\r\n4. Set \"No\" in \"Include Discount Amount\" field to test new behavior without discount.\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/432442048","html_url":"https://github.com/magento/magento2/pull/18524#issuecomment-432442048","issue_url":"https://api.github.com/repos/magento/magento2/issues/18524","id":432442048,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ0MjA0OA==","user":{"login":"ccasciotti","id":4273323,"node_id":"MDQ6VXNlcjQyNzMzMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4273323?v=4","gravatar_id":"","url":"https://api.github.com/users/ccasciotti","html_url":"https://github.com/ccasciotti","followers_url":"https://api.github.com/users/ccasciotti/followers","following_url":"https://api.github.com/users/ccasciotti/following{/other_user}","gists_url":"https://api.github.com/users/ccasciotti/gists{/gist_id}","starred_url":"https://api.github.com/users/ccasciotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccasciotti/subscriptions","organizations_url":"https://api.github.com/users/ccasciotti/orgs","repos_url":"https://api.github.com/users/ccasciotti/repos","events_url":"https://api.github.com/users/ccasciotti/events{/privacy}","received_events_url":"https://api.github.com/users/ccasciotti/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T22:17:21Z","updated_at":"2018-10-23T22:17:21Z","author_association":"CONTRIBUTOR","body":"@magento-engcom-team manual test was successful, please review code"}}
{"actor":{"display_login":"ccasciotti"}}