{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1","id":170452667,"html_url":"https://github.com/googlefonts/francoisoneFont/pull/1","diff_url":"https://github.com/googlefonts/francoisoneFont/pull/1.diff","patch_url":"https://github.com/googlefonts/francoisoneFont/pull/1.patch","issue_url":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/1","number":1,"state":"open","locked":false,"title":"v3.000 mastering","user":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"body":"Updated from the Google Summer of Type project.\r\n\r\nComparsions against version hosted on GF\r\n\r\n**Waterfall Win7 IE9**\r\n![desktop_windows_7_ie_9 0_](https://user-images.githubusercontent.com/7525512/36479263-f4099b20-16ff-11e8-8070-f08b901ac5d9.gif)\r\n\r\n\r\n**Glyphs-all win7 IE9**\r\n![desktop_windows_7_ie_9 0_](https://user-images.githubusercontent.com/7525512/36479280-02442368-1700-11e8-885b-7c7b7a556c39.gif)\r\n\r\n**Glyphs-Modified OSX**\r\n![desktop_os_x_el_capitan_safari_9 1_](https://user-images.githubusercontent.com/7525512/36479299-126cef7c-1700-11e8-8122-0f58fbe30b80.gif)\r\n\r\n**Glyphs-new OSX**\r\n![screen shot 2018-02-21 at 12 10 58](https://user-images.githubusercontent.com/7525512/36479356-4c58bfc2-1700-11e8-81b2-1fda060d8caf.png)\r\n\r\n\r\n**FB Report**\r\n```\r\n(env)Marc:fontbakery marc$ fontbakery check-googlefonts /Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf -l FAIL -C\r\nThere is a total of 127 checks on <Section: Default>.\r\nStart ... running 127 individual check executions.\r\n>> com.google.fonts/check/028\r\n   Check font has a license.\r\n * FAIL: No license file was found. Please add an OFL.txt or a LICENSE.txt file. If you are running fontbakery on a Google Fonts upstream repo, which is fine, just make sure there is a temporary license file in the same folder. [code: none]\r\n\r\n   Result: FAIL\r\n\r\n>> com.google.fonts/check/037 with ((u'font[0]', '/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf'),)\r\n   Checking with Microsoft Font Validator.\r\n * ERROR: Failed with IOError: [Errno 2] No such file or directory: u'/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf.report.xml'\r\n         Traceback (most recent call last):\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/checkrunner.py\", line 307, in _exec_check_generator\r\n             for sub_result in gen:\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/specifications/googlefonts.py\", line 1294, in com_google_fonts_check_037\r\n             xml_report = open(\"{}.report.xml\".format(font), \"r\").read()\r\n         IOError: [Errno 2] No such file or directory: u'/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf.report.xml'\r\n\r\n\r\n   Result: ERROR\r\n\r\n>> com.google.fonts/check/065 with ((u'font[0]', '/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf'),)\r\n   Is there kerning info for non-ligated sequences?\r\n * ERROR: Failed with KeyError: 'f'\r\n         Traceback (most recent call last):\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/checkrunner.py\", line 307, in _exec_check_generator\r\n             for sub_result in gen:\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/specifications/googlefonts.py\", line 2591, in com_google_fonts_check_065\r\n             look_for_nonligated_kern_info(lookup)\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/specifications/googlefonts.py\", line 2571, in look_for_nonligated_kern_info\r\n             if pairvalue.SecondGlyph in ligatures[glyph]:\r\n         KeyError: 'f'\r\n\r\n\r\n   Result: ERROR\r\n\r\n>> com.google.fonts/check/117 with ((u'font[0]', '/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf'),)\r\n   Version number has increased since previous release on Google Fonts?\r\n * ERROR: The condition <FontBakeryCondition:github_gfonts_ttFont> had an error: KeyError: None\r\n         Traceback (most recent call last):\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/checkrunner.py\", line 383, in _evaluate_condition\r\n             return None, condition(**args)\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/callable.py\", line 78, in __call__\r\n             return self._func(*args, **kwds)\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/specifications/googlefonts.py\", line 4260, in github_gfonts_ttFont\r\n             \"/{}/{}/{}\").format(LICENSE_DIRECTORY[license],\r\n         KeyError: None\r\n\r\n\r\n   Result: ERROR\r\n\r\n>> com.google.fonts/check/166 with ((u'font[0]', '/Users/marc/Documents/googlefonts/manual_font_cleaning/francoisone/fonts/FrancoisOne-Regular.ttf'),)\r\n   Check for font-v versioning\r\n * ERROR: Failed with AttributeError: 'FontVersion' object has no attribute 'get_name_id5_version_string'\r\n         Traceback (most recent call last):\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/checkrunner.py\", line 307, in _exec_check_generator\r\n             for sub_result in gen:\r\n           File \"/Users/marc/Documents/googlefonts/fontbakery/Lib/fontbakery/specifications/googlefonts.py\", line 5172, in com_google_fonts_check_166\r\n             \"\").format(fv.get_name_id5_version_string())\r\n         AttributeError: 'FontVersion' object has no attribute 'get_name_id5_version_string'\r\n\r\n\r\n   Result: ERROR\r\n\r\n======== <Section: Default> ========\r\n127 checks in section\r\n\r\n\r\nSection results:\r\n\r\n    ERROR: 4\r\n    FAIL: 1\r\n    WARN: 5\r\n    SKIP: 48\r\n    INFO: 4\r\n    PASS: 65\r\n\r\n======== END <Section: Default> ========\r\n\r\nTotal:\r\n\r\n    ERROR: 4\r\n    FAIL: 1\r\n    WARN: 5\r\n    SKIP: 48\r\n    INFO: 4\r\n    PASS: 65\r\n\r\n[PSSSSSPPPPPPPFSSSSSSSSSSSSPPPWPPSPPPPWPPESSPPPPPPWPPPPIPIPIPPPPIPPWEPPPPPPPPPPPPPSSSSSSSSSSSSSSSSSSSSSSSSPESSPPPPWSSPPPPPPPPPPE] 100%\r\n\r\nDONE!\r\n\r\n```\r\nSummary: no license fail will be solved once its packaged for a pr to google/fonts\r\n","created_at":"2018-02-21T12:13:33Z","updated_at":"2018-02-21T12:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1/commits","review_comments_url":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1/comments","review_comment_url":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/1/comments","statuses_url":"https://api.github.com/repos/googlefonts/francoisoneFont/statuses/4628fb926327a449b3bd3d5f304b83b4343bc79c","head":{"label":"m4rc1e:gf","ref":"gf","sha":"4628fb926327a449b3bd3d5f304b83b4343bc79c","user":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"repo":{"id":122331235,"name":"francoisoneFont","full_name":"m4rc1e/francoisoneFont","owner":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m4rc1e/francoisoneFont","description":"Francois One Font by Vernon Adams","fork":true,"url":"https://api.github.com/repos/m4rc1e/francoisoneFont","forks_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/forks","keys_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/teams","hooks_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/hooks","issue_events_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/issues/events{/number}","events_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/events","assignees_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/assignees{/user}","branches_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/branches{/branch}","tags_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/tags","blobs_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/git/refs{/sha}","trees_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/statuses/{sha}","languages_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/languages","stargazers_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/stargazers","contributors_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/contributors","subscribers_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/subscribers","subscription_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/subscription","commits_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/commits{/sha}","git_commits_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/git/commits{/sha}","comments_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/comments{/number}","issue_comment_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/issues/comments{/number}","contents_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/contents/{+path}","compare_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/merges","archive_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/downloads","issues_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/issues{/number}","pulls_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/pulls{/number}","milestones_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/milestones{/number}","notifications_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/labels{/name}","releases_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/releases{/id}","deployments_url":"https://api.github.com/repos/m4rc1e/francoisoneFont/deployments","created_at":"2018-02-21T12:04:33Z","updated_at":"2018-02-21T12:04:35Z","pushed_at":"2018-02-21T12:05:24Z","git_url":"git://github.com/m4rc1e/francoisoneFont.git","ssh_url":"git@github.com:m4rc1e/francoisoneFont.git","clone_url":"https://github.com/m4rc1e/francoisoneFont.git","svn_url":"https://github.com/m4rc1e/francoisoneFont","homepage":null,"size":742,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlefonts:master","ref":"master","sha":"f93620ca5499417b8523bd5f634fd4d7744b9b52","user":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars2.githubusercontent.com/u/6466306?v=4","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"repo":{"id":84833215,"name":"francoisoneFont","full_name":"googlefonts/francoisoneFont","owner":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars2.githubusercontent.com/u/6466306?v=4","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlefonts/francoisoneFont","description":"Francois One Font by Vernon Adams","fork":false,"url":"https://api.github.com/repos/googlefonts/francoisoneFont","forks_url":"https://api.github.com/repos/googlefonts/francoisoneFont/forks","keys_url":"https://api.github.com/repos/googlefonts/francoisoneFont/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlefonts/francoisoneFont/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlefonts/francoisoneFont/teams","hooks_url":"https://api.github.com/repos/googlefonts/francoisoneFont/hooks","issue_events_url":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/events{/number}","events_url":"https://api.github.com/repos/googlefonts/francoisoneFont/events","assignees_url":"https://api.github.com/repos/googlefonts/francoisoneFont/assignees{/user}","branches_url":"https://api.github.com/repos/googlefonts/francoisoneFont/branches{/branch}","tags_url":"https://api.github.com/repos/googlefonts/francoisoneFont/tags","blobs_url":"https://api.github.com/repos/googlefonts/francoisoneFont/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlefonts/francoisoneFont/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlefonts/francoisoneFont/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlefonts/francoisoneFont/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlefonts/francoisoneFont/statuses/{sha}","languages_url":"https://api.github.com/repos/googlefonts/francoisoneFont/languages","stargazers_url":"https://api.github.com/repos/googlefonts/francoisoneFont/stargazers","contributors_url":"https://api.github.com/repos/googlefonts/francoisoneFont/contributors","subscribers_url":"https://api.github.com/repos/googlefonts/francoisoneFont/subscribers","subscription_url":"https://api.github.com/repos/googlefonts/francoisoneFont/subscription","commits_url":"https://api.github.com/repos/googlefonts/francoisoneFont/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlefonts/francoisoneFont/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlefonts/francoisoneFont/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlefonts/francoisoneFont/contents/{+path}","compare_url":"https://api.github.com/repos/googlefonts/francoisoneFont/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlefonts/francoisoneFont/merges","archive_url":"https://api.github.com/repos/googlefonts/francoisoneFont/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlefonts/francoisoneFont/downloads","issues_url":"https://api.github.com/repos/googlefonts/francoisoneFont/issues{/number}","pulls_url":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls{/number}","milestones_url":"https://api.github.com/repos/googlefonts/francoisoneFont/milestones{/number}","notifications_url":"https://api.github.com/repos/googlefonts/francoisoneFont/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlefonts/francoisoneFont/labels{/name}","releases_url":"https://api.github.com/repos/googlefonts/francoisoneFont/releases{/id}","deployments_url":"https://api.github.com/repos/googlefonts/francoisoneFont/deployments","created_at":"2017-03-13T14:01:55Z","updated_at":"2017-03-13T14:02:36Z","pushed_at":"2017-03-13T14:02:33Z","git_url":"git://github.com/googlefonts/francoisoneFont.git","ssh_url":"git@github.com:googlefonts/francoisoneFont.git","clone_url":"https://github.com/googlefonts/francoisoneFont.git","svn_url":"https://github.com/googlefonts/francoisoneFont","homepage":null,"size":742,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":6,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1"},"html":{"href":"https://github.com/googlefonts/francoisoneFont/pull/1"},"issue":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/1"},"comments":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/googlefonts/francoisoneFont/statuses/4628fb926327a449b3bd3d5f304b83b4343bc79c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":36,"additions":20468,"deletions":9901,"changed_files":13}}
{"actor":{"display_login":"m4rc1e"}}