{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66839","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66839/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66839/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66839/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66839","id":346360943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjQ0NDU1","number":66839,"title":"[WIP] generates register.go for the external types","user":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"labels":[{"id":732478758,"node_id":"MDU6TGFiZWw3MzI0Nzg3NTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/code-generation","name":"area/code-generation","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-07-31T21:15:13Z","updated_at":"2018-08-21T19:46:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66839","html_url":"https://github.com/kubernetes/kubernetes/pull/66839","diff_url":"https://github.com/kubernetes/kubernetes/pull/66839.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66839.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThe purpose of this pull is to use the new generator `register-gen` to generate register.go files for the external types.\r\n\r\n**Special notes for your reviewer**:\r\nI renamed all `register.go` files to `zz_generated.register.go` and then I run the generator. Thanks to this you can easily compare what has changed.\r\n\r\nSee also:\r\nhttps://github.com/kubernetes/kubernetes/issues/65612 \r\nhttps://github.com/kubernetes/kubernetes/pull/66251\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/414798529","html_url":"https://github.com/kubernetes/kubernetes/pull/66839#issuecomment-414798529","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66839","id":414798529,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc5ODUyOQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T19:46:36Z","updated_at":"2018-08-21T19:46:36Z","author_association":"NONE","body":"@p0lyn0mial: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-cross | cd79d3fd0edbfb526aacea45a7c6d672ad90879c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66839/pull-kubernetes-cross/8726/) | `/test pull-kubernetes-cross`\npull-kubernetes-bazel-build | f6cb97e27a8d5ff94b6c84f67eac354b2879a36d | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66839/pull-kubernetes-bazel-build/54760/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-bazel-test | f6cb97e27a8d5ff94b6c84f67eac354b2879a36d | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66839/pull-kubernetes-bazel-test/57294/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | f6cb97e27a8d5ff94b6c84f67eac354b2879a36d | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66839/pull-kubernetes-e2e-kops-aws/102451/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/66839). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/p0lyn0mial). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}