{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/218190141","pull_request_review_id":156070679,"id":218190141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODE5MDE0MQ==","diff_hunk":"@@ -201,8 +189,8 @@ func (m *csiBlockMapper) MapDevice(devicePath, globalMapPath, volumeMapPath, vol\n \tdefer cancel()\n \n \tglobalMapPathBlockFile := devicePath\n-\tdir, _ := m.GetPodDeviceMapPath()\n-\ttargetBlockFilePath := filepath.Join(dir, \"file\")\n+\tdir, file := m.GetPodDeviceMapPath()","path":"pkg/volume/csi/csi_block.go","position":51,"original_position":51,"commit_id":"73820085896ee5527258278505eab69868a2ed3d","original_commit_id":"73820085896ee5527258278505eab69868a2ed3d","user":{"login":"mkimuram","id":36450643,"node_id":"MDQ6VXNlcjM2NDUwNjQz","avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"body":"I will rename ```file``` to ```volumeID``` when ```GetPodDeviceMapPath``` is changed to return ```volumeID```.","created_at":"2018-09-17T19:03:29Z","updated_at":"2018-09-17T19:19:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/68635#discussion_r218190141","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/218190141"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68635#discussion_r218190141"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635"}},"in_reply_to_id":217802964},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635","id":215418889,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDE4ODg5","html_url":"https://github.com/kubernetes/kubernetes/pull/68635","diff_url":"https://github.com/kubernetes/kubernetes/pull/68635.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68635.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68635","number":68635,"state":"open","locked":false,"title":"Fix for adding block volume support to CSI RBD driver","user":{"login":"mkimuram","id":36450643,"node_id":"MDQ6VXNlcjM2NDUwNjQz","avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nFix for adding block volume support to CSI RBD driver\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #68424 \r\n\r\n**Special notes for your reviewer**:\r\n/sig storage\r\n\r\nThis PR fixes following 3 issues:\r\n[Issues]\r\n1. ```symlinkPath``` used in ```MapDevice``` doesn't match to the one ```makeBlockVolumes``` expects\r\n2. No need to create file in neither ```targetBlockFilePath``` nor ```globalMapPathBlockFile```\r\n3. ```EvalHostSymlinksdevice``` fails for csi drivers that don't implement ```NodeStageVolume```\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-09-13T21:16:48Z","updated_at":"2018-09-17T19:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ba30e90d213aed7cb1f2d03a4ed1e743fda4c56","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"screeley44","id":6773375,"node_id":"MDQ6VXNlcjY3NzMzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68635/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73820085896ee5527258278505eab69868a2ed3d","head":{"label":"mkimuram:issue/68424","ref":"issue/68424","sha":"73820085896ee5527258278505eab69868a2ed3d","user":{"login":"mkimuram","id":36450643,"node_id":"MDQ6VXNlcjM2NDUwNjQz","avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"repo":{"id":121439175,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MzkxNzU=","name":"kubernetes","full_name":"mkimuram/kubernetes","private":false,"owner":{"login":"mkimuram","id":36450643,"node_id":"MDQ6VXNlcjM2NDUwNjQz","avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mkimuram/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mkimuram/kubernetes","forks_url":"https://api.github.com/repos/mkimuram/kubernetes/forks","keys_url":"https://api.github.com/repos/mkimuram/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkimuram/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkimuram/kubernetes/teams","hooks_url":"https://api.github.com/repos/mkimuram/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mkimuram/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mkimuram/kubernetes/events","assignees_url":"https://api.github.com/repos/mkimuram/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mkimuram/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mkimuram/kubernetes/tags","blobs_url":"https://api.github.com/repos/mkimuram/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkimuram/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkimuram/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkimuram/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkimuram/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mkimuram/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mkimuram/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mkimuram/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mkimuram/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mkimuram/kubernetes/subscription","commits_url":"https://api.github.com/repos/mkimuram/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkimuram/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkimuram/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkimuram/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkimuram/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mkimuram/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkimuram/kubernetes/merges","archive_url":"https://api.github.com/repos/mkimuram/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkimuram/kubernetes/downloads","issues_url":"https://api.github.com/repos/mkimuram/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mkimuram/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mkimuram/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mkimuram/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkimuram/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mkimuram/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mkimuram/kubernetes/deployments","created_at":"2018-02-13T21:33:13Z","updated_at":"2018-02-13T21:33:49Z","pushed_at":"2018-09-13T18:59:22Z","git_url":"git://github.com/mkimuram/kubernetes.git","ssh_url":"git@github.com:mkimuram/kubernetes.git","clone_url":"https://github.com/mkimuram/kubernetes.git","svn_url":"https://github.com/mkimuram/kubernetes","homepage":"http://kubernetes.io","size":584073,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fe72bd20b5b9ccc1f5b2ca5a951b78715164122c","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-09-17T19:13:01Z","pushed_at":"2018-09-17T18:56:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":809347,"stargazers_count":41498,"watchers_count":41498,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14416,"mirror_url":null,"archived":false,"open_issues_count":3204,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14416,"open_issues":3204,"watchers":41498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68635"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68635"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68635/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68635/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73820085896ee5527258278505eab69868a2ed3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mkimuram"}}