{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/168682389","pull_request_review_id":97090574,"id":168682389,"diff_hunk":"@@ -24,6 +24,9 @@ const common = require('../common');\n if (!common.hasCrypto)\n   common.skip('missing crypto');\n \n+// This test ensures that the data throught tls over http tunnel","path":"test/parallel/test-tls-over-http-tunnel.js","position":null,"original_position":4,"commit_id":"3809d59d1d0a9fe4af00ab3252de0c437f2ae961","original_commit_id":"6bbb1725288f2b880c5c14134e8a8cb069ee0795","user":{"login":"juggernaut451","id":5015212,"avatar_url":"https://avatars2.githubusercontent.com/u/5015212?v=4","gravatar_id":"","url":"https://api.github.com/users/juggernaut451","html_url":"https://github.com/juggernaut451","followers_url":"https://api.github.com/users/juggernaut451/followers","following_url":"https://api.github.com/users/juggernaut451/following{/other_user}","gists_url":"https://api.github.com/users/juggernaut451/gists{/gist_id}","starred_url":"https://api.github.com/users/juggernaut451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juggernaut451/subscriptions","organizations_url":"https://api.github.com/users/juggernaut451/orgs","repos_url":"https://api.github.com/users/juggernaut451/repos","events_url":"https://api.github.com/users/juggernaut451/events{/privacy}","received_events_url":"https://api.github.com/users/juggernaut451/received_events","type":"User","site_admin":false},"body":"changes made. Thank you @Trott for feedback","created_at":"2018-02-16T06:18:51Z","updated_at":"2018-02-16T06:18:51Z","html_url":"https://github.com/nodejs/node/pull/18784#discussion_r168682389","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/18784","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/168682389"},"html":{"href":"https://github.com/nodejs/node/pull/18784#discussion_r168682389"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/18784"}},"in_reply_to_id":168642716},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18784","id":169166406,"html_url":"https://github.com/nodejs/node/pull/18784","diff_url":"https://github.com/nodejs/node/pull/18784.diff","patch_url":"https://github.com/nodejs/node/pull/18784.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18784","number":18784,"state":"open","locked":false,"title":"Refactor of test-tls-over-http-tunnel","user":{"login":"juggernaut451","id":5015212,"avatar_url":"https://avatars2.githubusercontent.com/u/5015212?v=4","gravatar_id":"","url":"https://api.github.com/users/juggernaut451","html_url":"https://github.com/juggernaut451","followers_url":"https://api.github.com/users/juggernaut451/followers","following_url":"https://api.github.com/users/juggernaut451/following{/other_user}","gists_url":"https://api.github.com/users/juggernaut451/gists{/gist_id}","starred_url":"https://api.github.com/users/juggernaut451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juggernaut451/subscriptions","organizations_url":"https://api.github.com/users/juggernaut451/orgs","repos_url":"https://api.github.com/users/juggernaut451/repos","events_url":"https://api.github.com/users/juggernaut451/events{/privacy}","received_events_url":"https://api.github.com/users/juggernaut451/received_events","type":"User","site_admin":false},"body":"\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ntest\r\n\r\nChanges that are done in file are : \r\n - replaced function with arrow function\r\n - adding descripiton about test\r\n - repalced callback with common.mustCall\r\n\r\nnodejs#14544  \r\n","created_at":"2018-02-14T16:59:24Z","updated_at":"2018-02-16T06:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a7b0bd559b587bfadb859093e47180ddc757206","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18784/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18784/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18784/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/3809d59d1d0a9fe4af00ab3252de0c437f2ae961","head":{"label":"juggernaut451:refactorTlsOverHttpTunnel","ref":"refactorTlsOverHttpTunnel","sha":"3809d59d1d0a9fe4af00ab3252de0c437f2ae961","user":{"login":"juggernaut451","id":5015212,"avatar_url":"https://avatars2.githubusercontent.com/u/5015212?v=4","gravatar_id":"","url":"https://api.github.com/users/juggernaut451","html_url":"https://github.com/juggernaut451","followers_url":"https://api.github.com/users/juggernaut451/followers","following_url":"https://api.github.com/users/juggernaut451/following{/other_user}","gists_url":"https://api.github.com/users/juggernaut451/gists{/gist_id}","starred_url":"https://api.github.com/users/juggernaut451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juggernaut451/subscriptions","organizations_url":"https://api.github.com/users/juggernaut451/orgs","repos_url":"https://api.github.com/users/juggernaut451/repos","events_url":"https://api.github.com/users/juggernaut451/events{/privacy}","received_events_url":"https://api.github.com/users/juggernaut451/received_events","type":"User","site_admin":false},"repo":{"id":118640457,"name":"node","full_name":"juggernaut451/node","owner":{"login":"juggernaut451","id":5015212,"avatar_url":"https://avatars2.githubusercontent.com/u/5015212?v=4","gravatar_id":"","url":"https://api.github.com/users/juggernaut451","html_url":"https://github.com/juggernaut451","followers_url":"https://api.github.com/users/juggernaut451/followers","following_url":"https://api.github.com/users/juggernaut451/following{/other_user}","gists_url":"https://api.github.com/users/juggernaut451/gists{/gist_id}","starred_url":"https://api.github.com/users/juggernaut451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juggernaut451/subscriptions","organizations_url":"https://api.github.com/users/juggernaut451/orgs","repos_url":"https://api.github.com/users/juggernaut451/repos","events_url":"https://api.github.com/users/juggernaut451/events{/privacy}","received_events_url":"https://api.github.com/users/juggernaut451/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juggernaut451/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/juggernaut451/node","forks_url":"https://api.github.com/repos/juggernaut451/node/forks","keys_url":"https://api.github.com/repos/juggernaut451/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juggernaut451/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juggernaut451/node/teams","hooks_url":"https://api.github.com/repos/juggernaut451/node/hooks","issue_events_url":"https://api.github.com/repos/juggernaut451/node/issues/events{/number}","events_url":"https://api.github.com/repos/juggernaut451/node/events","assignees_url":"https://api.github.com/repos/juggernaut451/node/assignees{/user}","branches_url":"https://api.github.com/repos/juggernaut451/node/branches{/branch}","tags_url":"https://api.github.com/repos/juggernaut451/node/tags","blobs_url":"https://api.github.com/repos/juggernaut451/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juggernaut451/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juggernaut451/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/juggernaut451/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juggernaut451/node/statuses/{sha}","languages_url":"https://api.github.com/repos/juggernaut451/node/languages","stargazers_url":"https://api.github.com/repos/juggernaut451/node/stargazers","contributors_url":"https://api.github.com/repos/juggernaut451/node/contributors","subscribers_url":"https://api.github.com/repos/juggernaut451/node/subscribers","subscription_url":"https://api.github.com/repos/juggernaut451/node/subscription","commits_url":"https://api.github.com/repos/juggernaut451/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/juggernaut451/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/juggernaut451/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/juggernaut451/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/juggernaut451/node/contents/{+path}","compare_url":"https://api.github.com/repos/juggernaut451/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juggernaut451/node/merges","archive_url":"https://api.github.com/repos/juggernaut451/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juggernaut451/node/downloads","issues_url":"https://api.github.com/repos/juggernaut451/node/issues{/number}","pulls_url":"https://api.github.com/repos/juggernaut451/node/pulls{/number}","milestones_url":"https://api.github.com/repos/juggernaut451/node/milestones{/number}","notifications_url":"https://api.github.com/repos/juggernaut451/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juggernaut451/node/labels{/name}","releases_url":"https://api.github.com/repos/juggernaut451/node/releases{/id}","deployments_url":"https://api.github.com/repos/juggernaut451/node/deployments","created_at":"2018-01-23T16:54:23Z","updated_at":"2018-01-23T16:54:49Z","pushed_at":"2018-02-16T06:18:24Z","git_url":"git://github.com/juggernaut451/node.git","ssh_url":"git@github.com:juggernaut451/node.git","clone_url":"https://github.com/juggernaut451/node.git","svn_url":"https://github.com/juggernaut451/node","homepage":"https://nodejs.org","size":348585,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"92c86fd84d5f9be1a22388dd5ebb91ee8039e839","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-02-16T06:06:12Z","pushed_at":"2018-02-16T06:18:31Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":348008,"stargazers_count":45517,"watchers_count":45517,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9550,"mirror_url":null,"archived":false,"open_issues_count":818,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9550,"open_issues":818,"watchers":45517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18784"},"html":{"href":"https://github.com/nodejs/node/pull/18784"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18784"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18784/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18784/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18784/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/3809d59d1d0a9fe4af00ab3252de0c437f2ae961"}},"author_association":"NONE"}}
{"actor":{"display_login":"juggernaut451"}}