{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/3770","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3770/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3770/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3770/events","html_url":"https://github.com/envoyproxy/envoy/pull/3770","id":337319137,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTQwODU5","number":3770,"title":"fuzz: server config validation fuzz test.","user":{"login":"anirudhmurali","id":3096325,"node_id":"MDQ6VXNlcjMwOTYzMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3096325?v=4","gravatar_id":"","url":"https://api.github.com/users/anirudhmurali","html_url":"https://github.com/anirudhmurali","followers_url":"https://api.github.com/users/anirudhmurali/followers","following_url":"https://api.github.com/users/anirudhmurali/following{/other_user}","gists_url":"https://api.github.com/users/anirudhmurali/gists{/gist_id}","starred_url":"https://api.github.com/users/anirudhmurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anirudhmurali/subscriptions","organizations_url":"https://api.github.com/users/anirudhmurali/orgs","repos_url":"https://api.github.com/users/anirudhmurali/repos","events_url":"https://api.github.com/users/anirudhmurali/events{/privacy}","received_events_url":"https://api.github.com/users/anirudhmurali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-01T20:22:30Z","updated_at":"2018-07-10T16:02:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3770","html_url":"https://github.com/envoyproxy/envoy/pull/3770","diff_url":"https://github.com/envoyproxy/envoy/pull/3770.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3770.patch"},"body":"*Title:* fuzz: server config validation fuzz test\r\n\r\n*Description:* This fuzzes the bootstrap config message on server validation mode.\r\n\r\n*Risk Level:* Low\r\n\r\n*Testing:* Tested under oss-fuzz\r\n\r\nSigned-off-by: Anirudh M m.anirudh18@gmail.com"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/403876630","html_url":"https://github.com/envoyproxy/envoy/pull/3770#issuecomment-403876630","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3770","id":403876630,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzg3NjYzMA==","user":{"login":"anirudhmurali","id":3096325,"node_id":"MDQ6VXNlcjMwOTYzMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3096325?v=4","gravatar_id":"","url":"https://api.github.com/users/anirudhmurali","html_url":"https://github.com/anirudhmurali","followers_url":"https://api.github.com/users/anirudhmurali/followers","following_url":"https://api.github.com/users/anirudhmurali/following{/other_user}","gists_url":"https://api.github.com/users/anirudhmurali/gists{/gist_id}","starred_url":"https://api.github.com/users/anirudhmurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anirudhmurali/subscriptions","organizations_url":"https://api.github.com/users/anirudhmurali/orgs","repos_url":"https://api.github.com/users/anirudhmurali/repos","events_url":"https://api.github.com/users/anirudhmurali/events{/privacy}","received_events_url":"https://api.github.com/users/anirudhmurali/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T16:02:08Z","updated_at":"2018-07-10T16:02:08Z","author_association":"MEMBER","body":"Running `bazel test //test/server/config_validation:config_fuzz_test -config=clang-tsan --runs_per_test=2000` shows like few (3-7) failing tests out of 2000. All with the same message: `Didn't find a registered implementation for name: 'tls'`.\r\nI tried linking all extensions, and tested, it throws:\r\n\r\n`[critical][assert] external/envoy/source/common/thread_local/thread_local_impl.cc:19] assert failure: shutdown_`. Same reason why tsan failed in the previous commits.\r\n\r\nThe `ASSERT(shutdown_);` statement  in ~InstanceImpl() is what is causing this failure. `shutdown_` seems to be a atomic boolean object. Which part of the code might have set shutdown_ to false?"}}
{"actor":{"display_login":"anirudhmurali"}}