{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/221468961","pull_request_review_id":160124127,"id":221468961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ2ODk2MQ==","diff_hunk":"@@ -303,9 +303,16 @@ NODE_EXTERN void RunAtExit(Environment* env);\n NODE_EXTERN struct uv_loop_s* GetCurrentEventLoop(v8::Isolate* isolate);\n \n /* Converts a unixtime to V8 Date */\n-#define NODE_UNIXTIME_V8(t) v8::Date::New(v8::Isolate::GetCurrent(),          \\\n-    1000 * static_cast<double>(t))\n-#define NODE_V8_UNIXTIME(v) (static_cast<double>((v)->NumberValue())/1000.0);\n+NODE_DEPRECATED(\"Use v8::Date::New() directly\",\n+                inline v8::Local<v8::Value> NODE_UNIXTIME_V8(double time) {","path":"src/node.h","position":8,"original_position":8,"commit_id":"8bd23b5da10fb7ec08a7da6ac6c38ffcdc0d7f0f","original_commit_id":"8bd23b5da10fb7ec08a7da6ac6c38ffcdc0d7f0f","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"This is not equivalent.\r\nIn this case I could imagine a user define time related struct, with no implicit cast to `double`, e.g.\r\n```c++\r\nstruct Timestamp {\r\n    double _val;\r\n    explicit operator double() { return _val; };\r\n};\r\n```","created_at":"2018-09-30T18:41:19Z","updated_at":"2018-09-30T18:41:57Z","html_url":"https://github.com/nodejs/node/pull/23179#discussion_r221468961","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/23179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/221468961"},"html":{"href":"https://github.com/nodejs/node/pull/23179#discussion_r221468961"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/23179"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23179","id":219214668,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjE0NjY4","html_url":"https://github.com/nodejs/node/pull/23179","diff_url":"https://github.com/nodejs/node/pull/23179.diff","patch_url":"https://github.com/nodejs/node/pull/23179.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/23179","number":23179,"state":"open","locked":false,"title":"src: deprecate V8 date conversion helpers","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"body":"These helpers provide no benefit over the existing V8 API,\r\nand at least one of them fetches the current `Isolate` through\r\n`Isolate::GetCurrent()` (which should be avoided).\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-09-30T16:56:32Z","updated_at":"2018-09-30T18:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b33d093759f8fbbd20fc396e6eb96d5b370871ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":916977180,"node_id":"MDU6TGFiZWw5MTY5NzcxODA=","url":"https://api.github.com/repos/nodejs/node/labels/deprecations","name":"deprecations","color":"ea8a8d","default":false},{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/23179/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/23179/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23179/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8bd23b5da10fb7ec08a7da6ac6c38ffcdc0d7f0f","head":{"label":"addaleax:deprecate-unixtime","ref":"deprecate-unixtime","sha":"8bd23b5da10fb7ec08a7da6ac6c38ffcdc0d7f0f","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"repo":{"id":47707342,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcwNzM0Mg==","name":"node","full_name":"addaleax/node","private":false,"owner":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/addaleax/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/addaleax/node","forks_url":"https://api.github.com/repos/addaleax/node/forks","keys_url":"https://api.github.com/repos/addaleax/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addaleax/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addaleax/node/teams","hooks_url":"https://api.github.com/repos/addaleax/node/hooks","issue_events_url":"https://api.github.com/repos/addaleax/node/issues/events{/number}","events_url":"https://api.github.com/repos/addaleax/node/events","assignees_url":"https://api.github.com/repos/addaleax/node/assignees{/user}","branches_url":"https://api.github.com/repos/addaleax/node/branches{/branch}","tags_url":"https://api.github.com/repos/addaleax/node/tags","blobs_url":"https://api.github.com/repos/addaleax/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addaleax/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addaleax/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/addaleax/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addaleax/node/statuses/{sha}","languages_url":"https://api.github.com/repos/addaleax/node/languages","stargazers_url":"https://api.github.com/repos/addaleax/node/stargazers","contributors_url":"https://api.github.com/repos/addaleax/node/contributors","subscribers_url":"https://api.github.com/repos/addaleax/node/subscribers","subscription_url":"https://api.github.com/repos/addaleax/node/subscription","commits_url":"https://api.github.com/repos/addaleax/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/addaleax/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/addaleax/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/addaleax/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/addaleax/node/contents/{+path}","compare_url":"https://api.github.com/repos/addaleax/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addaleax/node/merges","archive_url":"https://api.github.com/repos/addaleax/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addaleax/node/downloads","issues_url":"https://api.github.com/repos/addaleax/node/issues{/number}","pulls_url":"https://api.github.com/repos/addaleax/node/pulls{/number}","milestones_url":"https://api.github.com/repos/addaleax/node/milestones{/number}","notifications_url":"https://api.github.com/repos/addaleax/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addaleax/node/labels{/name}","releases_url":"https://api.github.com/repos/addaleax/node/releases{/id}","deployments_url":"https://api.github.com/repos/addaleax/node/deployments","created_at":"2015-12-09T17:26:30Z","updated_at":"2018-08-21T13:05:00Z","pushed_at":"2018-09-30T18:00:39Z","git_url":"git://github.com/addaleax/node.git","ssh_url":"git@github.com:addaleax/node.git","clone_url":"https://github.com/addaleax/node.git","svn_url":"https://github.com/addaleax/node","homepage":"https://nodejs.org","size":413193,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"aba7677e826065fc1f1025ee2db5faee035fd515","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-09-30T18:09:29Z","pushed_at":"2018-09-30T18:00:44Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":420761,"stargazers_count":53890,"watchers_count":53890,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11471,"mirror_url":null,"archived":false,"open_issues_count":925,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11471,"open_issues":925,"watchers":53890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/23179"},"html":{"href":"https://github.com/nodejs/node/pull/23179"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/23179"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/23179/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/23179/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/23179/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8bd23b5da10fb7ec08a7da6ac6c38ffcdc0d7f0f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"refack"}}