{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/208338869","pull_request_review_id":144127856,"id":208338869,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMzODg2OQ==","diff_hunk":"@@ -0,0 +1,246 @@\n+{\n+  \"sign\": [\n+    {\n+      \"certificate\": \"MicrosoftSHA2\",\n+      \"values\": [\n+        \"bin/Microsoft.AspNetCore.Blazor.Analyzers/netstandard1.3/Microsoft.AspNetCore.Blazor.Analyzers.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Browser.JS/netcoreapp2.1/Microsoft.AspNetCore.Blazor.Browser.JS.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Browser/netstandard2.0/Microsoft.AspNetCore.Blazor.Browser.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Server/netstandard2.0/Microsoft.AspNetCore.Blazor.Server.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Build/netcoreapp2.1/Microsoft.AspNetCore.Blazor.Build.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Cli/netcoreapp2.1/dotnet-blazor.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Razor.Extensions/net461/Microsoft.AspNetCore.Blazor.Razor.Extensions.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor.Razor.Extensions/netstandard2.0/Microsoft.AspNetCore.Blazor.Razor.Extensions.dll\",\n+        \"bin/Microsoft.AspNetCore.Blazor/netstandard2.0/Microsoft.AspNetCore.Blazor.dll\",\n+        \"bin/Microsoft.JSInterop/netstandard2.0/Microsoft.JSInterop.dll\",\n+        \"bin/Microsoft.VisualStudio.BlazorExtension/Microsoft.VisualStudio.BlazorExtension.dll\",\n+        \"bin/Microsoft.VisualStudio.LanguageServices.Blazor/net461/Microsoft.VisualStudio.LanguageServices.Blazor.dll\",\n+      ]\n+    },\n+    {\n+      \"certificate\": \"3PartySHA2\",\n+      \"values\": [\n+        \"bin/Microsoft.AspNetCore.Blazor.Build/netcoreapp2.1/AngleSharp.dll\",\n+        \"bin/Microsoft.VisualStudio.BlazorExtension/AngleSharp.dll\"\n+      ]\n+    },\n+    {\n+      \"certificate\": \"VsixSHA2\",\n+      \"values\": [\n+        \"bin/Microsoft.VisualStudio.BlazorExtension/Microsoft.VisualStudio.BlazorExtension.vsix\"\n+      ]\n+    },\n+    {\n+      \"certificate\": \"NuGet\",\n+      \"strongName\": null,\n+      \"values\": [\n+        \"packages/*.nupkg\"\n+      ]\n+    }\n+  ],\n+  \"exclude\": [","path":"build/SignToolData.json","position":41,"original_position":41,"commit_id":"c0e1f6316a01463e90bedc3f966524fd442ee88b","original_commit_id":"c93ed05fc835212725e44b65b24e11589460c1fd","user":{"login":"rynowak","id":1430011,"node_id":"MDQ6VXNlcjE0MzAwMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"what's the ETA on this being reasonable?","created_at":"2018-08-07T18:31:10Z","updated_at":"2018-08-07T18:31:10Z","html_url":"https://github.com/aspnet/Blazor/pull/1278#discussion_r208338869","pull_request_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1278","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/208338869"},"html":{"href":"https://github.com/aspnet/Blazor/pull/1278#discussion_r208338869"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1278"}},"in_reply_to_id":208300032},"pull_request":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/1278","id":206754429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzU0NDI5","html_url":"https://github.com/aspnet/Blazor/pull/1278","diff_url":"https://github.com/aspnet/Blazor/pull/1278.diff","patch_url":"https://github.com/aspnet/Blazor/pull/1278.patch","issue_url":"https://api.github.com/repos/aspnet/Blazor/issues/1278","number":1278,"state":"open","locked":false,"title":"Automate authenticode code-signing using Roslyn sign tool","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"This automates authenticode code-signing using the Roslyn's SignTool (which is currently being ported to Arcade) and MicroBuild (the *real* MicroBuild, not the aspnet namesake).\r\n\r\nThe biggest change here is that obj and bin folders are relocated. This is part of the upcoming convergence of KoreBuild and Arcade. It was easier to do this now to make code-signing work better with the SignTool.\r\n\r\nChanges:\r\n* Change project layout to match the expectations of Arcade and sign-tool\r\n* Add signtool config file to configure OPC, NuGet, and Authenticode signing\r\n* Fix a bug when BaseIntermediateOutputPath is set to an absolute path\r\n* Split the build definition into ci-public and ci-official. ci-public does not code-sign.\r\n\r\nTODO: flip from 'test' to 'real' signing once ticket 79507967 is approved.\r\n\r\nResolves #1269 ","created_at":"2018-08-07T16:21:07Z","updated_at":"2018-08-07T18:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c381631b00fd381fef54362abc4c89712af82d27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Blazor/issues/1278/comments","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/c0e1f6316a01463e90bedc3f966524fd442ee88b","head":{"label":"aspnet:namc/vsts","ref":"namc/vsts","sha":"c0e1f6316a01463e90bedc3f966524fd442ee88b","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjA3NTU=","name":"Blazor","full_name":"aspnet/Blazor","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-08-07T15:08:24Z","pushed_at":"2018-08-07T17:59:30Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"https://blazor.net/","size":161172,"stargazers_count":6018,"watchers_count":6018,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":506,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":506,"open_issues":152,"watchers":6018,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"cd37db5ccf699d77131779c6996276e41857bd6d","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjA3NTU=","name":"Blazor","full_name":"aspnet/Blazor","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-08-07T15:08:24Z","pushed_at":"2018-08-07T17:59:30Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"https://blazor.net/","size":161172,"stargazers_count":6018,"watchers_count":6018,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":506,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":506,"open_issues":152,"watchers":6018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1278"},"html":{"href":"https://github.com/aspnet/Blazor/pull/1278"},"issue":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/1278"},"comments":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Blazor/statuses/c0e1f6316a01463e90bedc3f966524fd442ee88b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rynowak"}}