{"action":"created","comment":{"url":"https://api.github.com/repos/dondi/GRNsight/pulls/comments/190120938","pull_request_review_id":122430781,"id":190120938,"diff_hunk":"@@ -5,7 +5,11 @@ import {\n     GREY_EDGES_DASHED_SIDEBAR\n } from \"./constants\";\n \n+import { setupLoadAndImportHandlers } from \"./setup-load-and-import-handlers\";","path":"web-client/public/js/setup-handlers.js","position":4,"original_position":4,"commit_id":"ddc448ae9802658e4c26347bce5cfa9e29c5dc2b","original_commit_id":"ddc448ae9802658e4c26347bce5cfa9e29c5dc2b","user":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"body":"We started by putting all of the load and import code right in _setup-handlers_ (see the individual commits), but when the main work was done, it made sense to separate them into their own module. Thus, the details are hidden away unless someone wants to look into that file, and here you only need the single high-level setup function.","created_at":"2018-05-23T04:37:56Z","updated_at":"2018-05-23T04:37:56Z","html_url":"https://github.com/dondi/GRNsight/pull/633#discussion_r190120938","pull_request_url":"https://api.github.com/repos/dondi/GRNsight/pulls/633","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/comments/190120938"},"html":{"href":"https://github.com/dondi/GRNsight/pull/633#discussion_r190120938"},"pull_request":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/633"}}},"pull_request":{"url":"https://api.github.com/repos/dondi/GRNsight/pulls/633","id":189854196,"html_url":"https://github.com/dondi/GRNsight/pull/633","diff_url":"https://github.com/dondi/GRNsight/pull/633.diff","patch_url":"https://github.com/dondi/GRNsight/pull/633.patch","issue_url":"https://api.github.com/repos/dondi/GRNsight/issues/633","number":633,"state":"open","locked":false,"title":"Beta consolidation Round 2","user":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"body":"OK, here's what I was able to throw together. I'll add some commentary here and there so please scan the entire change log for any notes. This PR will be helpful for both @mihirsamdarshi and @johnllopez616, I'd say.\r\n\r\nThe TL;DR of this is that all of the loading/importing code has been moved to the new MVC cycle. The current network is now completely housed in `grnState`, loading/importing triggers are in `setupHandlers`, and there is more network redrawing code in `updateApp` now.\r\n\r\nIf you guys are good with these changes, you can go ahead and merge and _now_ try the gray threshold stuff. @mihirsamdarshi you probably can't really merge your git stash anymore, but you can potentially `git stash apply` it temporarily (merge conflicts and all) just as a frame of reference. Once you sort of get back what you need, then you can just discard those changes. (`git stash apply` instead of `pop` keeps the stash in your list so that you don't lose the code permanently)\r\n\r\nNext note is that this PR is relatively large, but it does consist of multiple commits. I suggest that you also go over what changed one commit at a time, so that you can see the evolution from where we were Tuesday afternoon up to this point. Observing the phases I chose may be helpful to both of you in terms of your own choices in staging your work, so that the pieces stay small and manageable but the sum total is substantive but progressive.","created_at":"2018-05-23T04:32:16Z","updated_at":"2018-05-23T04:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea2c5c670b4a162c75e85d2ce7642286aa68a1fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dondi/GRNsight/pulls/633/commits","review_comments_url":"https://api.github.com/repos/dondi/GRNsight/pulls/633/comments","review_comment_url":"https://api.github.com/repos/dondi/GRNsight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dondi/GRNsight/issues/633/comments","statuses_url":"https://api.github.com/repos/dondi/GRNsight/statuses/ddc448ae9802658e4c26347bce5cfa9e29c5dc2b","head":{"label":"dondi:beta-consolidation-dondi","ref":"beta-consolidation-dondi","sha":"ddc448ae9802658e4c26347bce5cfa9e29c5dc2b","user":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"repo":{"id":16195791,"name":"GRNsight","full_name":"dondi/GRNsight","owner":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dondi/GRNsight","description":"Web app and service for modeling and visualizing gene regulatory networks.","fork":false,"url":"https://api.github.com/repos/dondi/GRNsight","forks_url":"https://api.github.com/repos/dondi/GRNsight/forks","keys_url":"https://api.github.com/repos/dondi/GRNsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dondi/GRNsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dondi/GRNsight/teams","hooks_url":"https://api.github.com/repos/dondi/GRNsight/hooks","issue_events_url":"https://api.github.com/repos/dondi/GRNsight/issues/events{/number}","events_url":"https://api.github.com/repos/dondi/GRNsight/events","assignees_url":"https://api.github.com/repos/dondi/GRNsight/assignees{/user}","branches_url":"https://api.github.com/repos/dondi/GRNsight/branches{/branch}","tags_url":"https://api.github.com/repos/dondi/GRNsight/tags","blobs_url":"https://api.github.com/repos/dondi/GRNsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dondi/GRNsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dondi/GRNsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/dondi/GRNsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dondi/GRNsight/statuses/{sha}","languages_url":"https://api.github.com/repos/dondi/GRNsight/languages","stargazers_url":"https://api.github.com/repos/dondi/GRNsight/stargazers","contributors_url":"https://api.github.com/repos/dondi/GRNsight/contributors","subscribers_url":"https://api.github.com/repos/dondi/GRNsight/subscribers","subscription_url":"https://api.github.com/repos/dondi/GRNsight/subscription","commits_url":"https://api.github.com/repos/dondi/GRNsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/dondi/GRNsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/dondi/GRNsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/dondi/GRNsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/dondi/GRNsight/contents/{+path}","compare_url":"https://api.github.com/repos/dondi/GRNsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dondi/GRNsight/merges","archive_url":"https://api.github.com/repos/dondi/GRNsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dondi/GRNsight/downloads","issues_url":"https://api.github.com/repos/dondi/GRNsight/issues{/number}","pulls_url":"https://api.github.com/repos/dondi/GRNsight/pulls{/number}","milestones_url":"https://api.github.com/repos/dondi/GRNsight/milestones{/number}","notifications_url":"https://api.github.com/repos/dondi/GRNsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dondi/GRNsight/labels{/name}","releases_url":"https://api.github.com/repos/dondi/GRNsight/releases{/id}","deployments_url":"https://api.github.com/repos/dondi/GRNsight/deployments","created_at":"2014-01-24T05:16:11Z","updated_at":"2018-05-21T17:18:33Z","pushed_at":"2018-05-23T04:32:17Z","git_url":"git://github.com/dondi/GRNsight.git","ssh_url":"git@github.com:dondi/GRNsight.git","clone_url":"https://github.com/dondi/GRNsight.git","svn_url":"https://github.com/dondi/GRNsight","homepage":"http://dondi.github.io/GRNsight","size":171118,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":6,"open_issues":63,"watchers":11,"default_branch":"master"}},"base":{"label":"dondi:beta-consolidation","ref":"beta-consolidation","sha":"c02045b5de125b4fbff9283b36af2d10121b257f","user":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"repo":{"id":16195791,"name":"GRNsight","full_name":"dondi/GRNsight","owner":{"login":"dondi","id":382242,"avatar_url":"https://avatars2.githubusercontent.com/u/382242?v=4","gravatar_id":"","url":"https://api.github.com/users/dondi","html_url":"https://github.com/dondi","followers_url":"https://api.github.com/users/dondi/followers","following_url":"https://api.github.com/users/dondi/following{/other_user}","gists_url":"https://api.github.com/users/dondi/gists{/gist_id}","starred_url":"https://api.github.com/users/dondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dondi/subscriptions","organizations_url":"https://api.github.com/users/dondi/orgs","repos_url":"https://api.github.com/users/dondi/repos","events_url":"https://api.github.com/users/dondi/events{/privacy}","received_events_url":"https://api.github.com/users/dondi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dondi/GRNsight","description":"Web app and service for modeling and visualizing gene regulatory networks.","fork":false,"url":"https://api.github.com/repos/dondi/GRNsight","forks_url":"https://api.github.com/repos/dondi/GRNsight/forks","keys_url":"https://api.github.com/repos/dondi/GRNsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dondi/GRNsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dondi/GRNsight/teams","hooks_url":"https://api.github.com/repos/dondi/GRNsight/hooks","issue_events_url":"https://api.github.com/repos/dondi/GRNsight/issues/events{/number}","events_url":"https://api.github.com/repos/dondi/GRNsight/events","assignees_url":"https://api.github.com/repos/dondi/GRNsight/assignees{/user}","branches_url":"https://api.github.com/repos/dondi/GRNsight/branches{/branch}","tags_url":"https://api.github.com/repos/dondi/GRNsight/tags","blobs_url":"https://api.github.com/repos/dondi/GRNsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dondi/GRNsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dondi/GRNsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/dondi/GRNsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dondi/GRNsight/statuses/{sha}","languages_url":"https://api.github.com/repos/dondi/GRNsight/languages","stargazers_url":"https://api.github.com/repos/dondi/GRNsight/stargazers","contributors_url":"https://api.github.com/repos/dondi/GRNsight/contributors","subscribers_url":"https://api.github.com/repos/dondi/GRNsight/subscribers","subscription_url":"https://api.github.com/repos/dondi/GRNsight/subscription","commits_url":"https://api.github.com/repos/dondi/GRNsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/dondi/GRNsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/dondi/GRNsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/dondi/GRNsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/dondi/GRNsight/contents/{+path}","compare_url":"https://api.github.com/repos/dondi/GRNsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dondi/GRNsight/merges","archive_url":"https://api.github.com/repos/dondi/GRNsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dondi/GRNsight/downloads","issues_url":"https://api.github.com/repos/dondi/GRNsight/issues{/number}","pulls_url":"https://api.github.com/repos/dondi/GRNsight/pulls{/number}","milestones_url":"https://api.github.com/repos/dondi/GRNsight/milestones{/number}","notifications_url":"https://api.github.com/repos/dondi/GRNsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dondi/GRNsight/labels{/name}","releases_url":"https://api.github.com/repos/dondi/GRNsight/releases{/id}","deployments_url":"https://api.github.com/repos/dondi/GRNsight/deployments","created_at":"2014-01-24T05:16:11Z","updated_at":"2018-05-21T17:18:33Z","pushed_at":"2018-05-23T04:32:17Z","git_url":"git://github.com/dondi/GRNsight.git","ssh_url":"git@github.com:dondi/GRNsight.git","clone_url":"https://github.com/dondi/GRNsight.git","svn_url":"https://github.com/dondi/GRNsight","homepage":"http://dondi.github.io/GRNsight","size":171118,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":6,"open_issues":63,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/633"},"html":{"href":"https://github.com/dondi/GRNsight/pull/633"},"issue":{"href":"https://api.github.com/repos/dondi/GRNsight/issues/633"},"comments":{"href":"https://api.github.com/repos/dondi/GRNsight/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dondi/GRNsight/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/dondi/GRNsight/statuses/ddc448ae9802658e4c26347bce5cfa9e29c5dc2b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dondi"}}