{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/190274934","pull_request_review_id":122618854,"id":190274934,"diff_hunk":"@@ -837,16 +837,19 @@ public final void checkTotalOrderSupported() {\n       Address excludedTarget = deliverOrder == DeliverOrder.TOTAL ? null : getAddress();\n       MultiTargetRequest<T> request =\n             new MultiTargetRequest<>(collector, requestId, requests, targets, excludedTarget);\n-      try {\n-         addRequest(request);\n-         boolean checkView = request.onNewView(clusterView.getMembersSet());\n-         sendCommand(targets, command, requestId, deliverOrder, isRsvpCommand(command), checkView);\n-      } catch (Throwable t) {\n-         request.cancel(true);\n-         throw t;\n-      }\n-      if (timeout > 0) {\n-         request.setTimeout(timeoutExecutor, timeout, unit);\n+      // Request may be completed due to exclusion of target nodes, so only send it if it isn't complete\n+      if (!request.isDone()) {","path":"core/src/main/java/org/infinispan/remoting/transport/jgroups/JGroupsTransport.java","position":15,"original_position":15,"commit_id":"122798f3e7804baca6bc07aaee455222fdc38746","original_commit_id":"122798f3e7804baca6bc07aaee455222fdc38746","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars2.githubusercontent.com/u/504907?v=4","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"I would suggest `if (request.isDone() return request;` to avoid indenting the rest of the method.","created_at":"2018-05-23T14:42:57Z","updated_at":"2018-05-23T14:44:29Z","html_url":"https://github.com/infinispan/infinispan/pull/6005#discussion_r190274934","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6005","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/190274934"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6005#discussion_r190274934"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6005"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/6005","id":189972574,"html_url":"https://github.com/infinispan/infinispan/pull/6005","diff_url":"https://github.com/infinispan/infinispan/pull/6005.diff","patch_url":"https://github.com/infinispan/infinispan/pull/6005.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/6005","number":6005,"state":"open","locked":false,"title":"ISPN-9204 Single node JgroupsTransport invoke* methods that take a","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"collection leak memory\r\n\r\n* Add check to only send command it not already complete\r\n\r\nhttps://issues.jboss.org/browse/ISPN-9204","created_at":"2018-05-23T13:20:02Z","updated_at":"2018-05-23T14:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60100e44be7e814632fa2e8db479d404ca1fe211","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118839332,"url":"https://api.github.com/repos/infinispan/infinispan/labels/Trivial%20:-)","name":"Trivial :-)","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/infinispan/infinispan/milestones/102","html_url":"https://github.com/infinispan/infinispan/milestone/102","labels_url":"https://api.github.com/repos/infinispan/infinispan/milestones/102/labels","id":3332955,"number":102,"title":"9.3.0.CR1","description":"","creator":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars0.githubusercontent.com/u/392478?v=4","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2018-05-09T11:54:53Z","updated_at":"2018-05-23T13:20:02Z","due_on":"2018-06-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6005/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6005/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/6005/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/122798f3e7804baca6bc07aaee455222fdc38746","head":{"label":"wburns:ISPN-9204_invoke_leak","ref":"ISPN-9204_invoke_leak","sha":"122798f3e7804baca6bc07aaee455222fdc38746","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"repo":{"id":2681545,"name":"infinispan","full_name":"wburns/infinispan","owner":{"login":"wburns","id":648175,"avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wburns/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/wburns/infinispan","forks_url":"https://api.github.com/repos/wburns/infinispan/forks","keys_url":"https://api.github.com/repos/wburns/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wburns/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wburns/infinispan/teams","hooks_url":"https://api.github.com/repos/wburns/infinispan/hooks","issue_events_url":"https://api.github.com/repos/wburns/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/wburns/infinispan/events","assignees_url":"https://api.github.com/repos/wburns/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/wburns/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/wburns/infinispan/tags","blobs_url":"https://api.github.com/repos/wburns/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wburns/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wburns/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/wburns/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wburns/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/wburns/infinispan/languages","stargazers_url":"https://api.github.com/repos/wburns/infinispan/stargazers","contributors_url":"https://api.github.com/repos/wburns/infinispan/contributors","subscribers_url":"https://api.github.com/repos/wburns/infinispan/subscribers","subscription_url":"https://api.github.com/repos/wburns/infinispan/subscription","commits_url":"https://api.github.com/repos/wburns/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/wburns/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/wburns/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/wburns/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/wburns/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/wburns/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wburns/infinispan/merges","archive_url":"https://api.github.com/repos/wburns/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wburns/infinispan/downloads","issues_url":"https://api.github.com/repos/wburns/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/wburns/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/wburns/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/wburns/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wburns/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/wburns/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/wburns/infinispan/deployments","created_at":"2011-10-31T15:31:04Z","updated_at":"2018-03-27T12:30:32Z","pushed_at":"2018-05-23T13:33:51Z","git_url":"git://github.com/wburns/infinispan.git","ssh_url":"git@github.com:wburns/infinispan.git","clone_url":"https://github.com/wburns/infinispan.git","svn_url":"https://github.com/wburns/infinispan","homepage":"http://www.infinispan.org","size":100536,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"8fd20db173c74fe2338a18b226d567571c43be8a","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2018-05-23T08:51:53Z","pushed_at":"2018-05-23T13:33:53Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":107634,"stargazers_count":657,"watchers_count":657,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":446,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":446,"open_issues":25,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6005"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6005"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6005"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6005/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6005/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6005/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/122798f3e7804baca6bc07aaee455222fdc38746"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danberindei"}}