{"action":"created","comment":{"url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/comments/173635209","pull_request_review_id":102863327,"id":173635209,"diff_hunk":"@@ -13,38 +13,42 @@ export function MarketCapList({ coinData, handleCoinIconClick, title }: MarketCa\n \n   const renderCryptoMarketCapListTableHeader = (): JSX.Element => {\n     return (\n-      <div className={'flexrow'}>\n-        <div className=\"flexcol-icon\">\n+      <div className={'flex-row'}>\n+        <div className=\"flex-col-icon\">\n           <h2 className=\"item\">{''}</h2>\n         </div>\n-        <div className=\"flexcol\">\n+        <div className=\"flex-col\">\n           <h2 className=\"item\">{'Ticker'}</h2>\n         </div>\n-        <div className=\"flexcol\">\n+        <div className=\"flex-col\">\n           <h2 className=\"item\">{'Full Name'}</h2>\n         </div>\n-        <div className=\"flexcol\">\n+        <div className=\"flex-col\">\n           <h2 className=\"item\">{'Total Supply'}</h2>\n         </div>\n-        <div className=\"flexcol\">\n+        <div className=\"flex-col\">\n           <h2 className=\"item\">{'Current Price'}</h2>\n         </div>\n-        <div className=\"flexcol\">\n+        <div className=\"flex-col\">\n           <h2 className=\"item\">{'Market Cap'}</h2>\n         </div>\n       </div>\n     );\n   };\n \n+  const mapCoinDataToCoinRow = (coins: FlattenedCoinData[]): CoinRow[] =>\n+    coins.map(coin => Object.assign({ coinData: coin, isRowExpanded: false }));\n+\n   const renderCryptoMarketCapList = (): JSX.Element[] => {\n     const cryptoRows = coinData.map((coin, index) => {\n+      const coinRow: CoinRow | undefined =\n+        mapCoinDataToCoinRow(coinData).find(element => element.coinData.name === coin.name);","path":"src/components/MarketCapList.tsx","position":49,"original_position":49,"commit_id":"23aefca99ff58eb1e9100ec67206bc385f449603","original_commit_id":"23aefca99ff58eb1e9100ec67206bc385f449603","user":{"login":"drevie","id":16968773,"avatar_url":"https://avatars3.githubusercontent.com/u/16968773?v=4","gravatar_id":"","url":"https://api.github.com/users/drevie","html_url":"https://github.com/drevie","followers_url":"https://api.github.com/users/drevie/followers","following_url":"https://api.github.com/users/drevie/following{/other_user}","gists_url":"https://api.github.com/users/drevie/gists{/gist_id}","starred_url":"https://api.github.com/users/drevie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drevie/subscriptions","organizations_url":"https://api.github.com/users/drevie/orgs","repos_url":"https://api.github.com/users/drevie/repos","events_url":"https://api.github.com/users/drevie/events{/privacy}","received_events_url":"https://api.github.com/users/drevie/received_events","type":"User","site_admin":false},"body":"Here we can find the actual coin data that we care about for this row and pass it directly rather than sending the whole list for it to figure it out","created_at":"2018-03-10T21:19:12Z","updated_at":"2018-03-10T21:19:12Z","html_url":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2#discussion_r173635209","pull_request_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/comments/173635209"},"html":{"href":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2#discussion_r173635209"},"pull_request":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2","id":174189978,"html_url":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2","diff_url":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2.diff","patch_url":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2.patch","issue_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/2","number":2,"state":"open","locked":false,"title":"adding expandable prop and refactoring row component","user":{"login":"drevie","id":16968773,"avatar_url":"https://avatars3.githubusercontent.com/u/16968773?v=4","gravatar_id":"","url":"https://api.github.com/users/drevie","html_url":"https://github.com/drevie","followers_url":"https://api.github.com/users/drevie/followers","following_url":"https://api.github.com/users/drevie/following{/other_user}","gists_url":"https://api.github.com/users/drevie/gists{/gist_id}","starred_url":"https://api.github.com/users/drevie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drevie/subscriptions","organizations_url":"https://api.github.com/users/drevie/orgs","repos_url":"https://api.github.com/users/drevie/repos","events_url":"https://api.github.com/users/drevie/events{/privacy}","received_events_url":"https://api.github.com/users/drevie/received_events","type":"User","site_admin":false},"body":"1. Converted Row Component from a functional component to a class component. This way we can store the expanded prop in the state. \r\n2. Passing down the specific coin data to the component rather then the entire list. Previously we were passing down the entire data and making the row find its data inside the list. \r\n2. Refactoring the scss naming\r\n3. Adding shell component for a detailed coin view \r\n","created_at":"2018-03-10T21:16:36Z","updated_at":"2018-03-10T21:19:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b73410d841ebabe1a50f0fb5bf071efbc91b523","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jefabrah","id":17343660,"avatar_url":"https://avatars3.githubusercontent.com/u/17343660?v=4","gravatar_id":"","url":"https://api.github.com/users/jefabrah","html_url":"https://github.com/jefabrah","followers_url":"https://api.github.com/users/jefabrah/followers","following_url":"https://api.github.com/users/jefabrah/following{/other_user}","gists_url":"https://api.github.com/users/jefabrah/gists{/gist_id}","starred_url":"https://api.github.com/users/jefabrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefabrah/subscriptions","organizations_url":"https://api.github.com/users/jefabrah/orgs","repos_url":"https://api.github.com/users/jefabrah/repos","events_url":"https://api.github.com/users/jefabrah/events{/privacy}","received_events_url":"https://api.github.com/users/jefabrah/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2/commits","review_comments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2/comments","review_comment_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/2/comments","statuses_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/statuses/23aefca99ff58eb1e9100ec67206bc385f449603","head":{"label":"CryptoTacos:expandable-crypto-information","ref":"expandable-crypto-information","sha":"23aefca99ff58eb1e9100ec67206bc385f449603","user":{"login":"CryptoTacos","id":37244050,"avatar_url":"https://avatars3.githubusercontent.com/u/37244050?v=4","gravatar_id":"","url":"https://api.github.com/users/CryptoTacos","html_url":"https://github.com/CryptoTacos","followers_url":"https://api.github.com/users/CryptoTacos/followers","following_url":"https://api.github.com/users/CryptoTacos/following{/other_user}","gists_url":"https://api.github.com/users/CryptoTacos/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptoTacos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptoTacos/subscriptions","organizations_url":"https://api.github.com/users/CryptoTacos/orgs","repos_url":"https://api.github.com/users/CryptoTacos/repos","events_url":"https://api.github.com/users/CryptoTacos/events{/privacy}","received_events_url":"https://api.github.com/users/CryptoTacos/received_events","type":"Organization","site_admin":false},"repo":{"id":123745336,"name":"crypto-react-redux-ts","full_name":"CryptoTacos/crypto-react-redux-ts","owner":{"login":"CryptoTacos","id":37244050,"avatar_url":"https://avatars3.githubusercontent.com/u/37244050?v=4","gravatar_id":"","url":"https://api.github.com/users/CryptoTacos","html_url":"https://github.com/CryptoTacos","followers_url":"https://api.github.com/users/CryptoTacos/followers","following_url":"https://api.github.com/users/CryptoTacos/following{/other_user}","gists_url":"https://api.github.com/users/CryptoTacos/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptoTacos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptoTacos/subscriptions","organizations_url":"https://api.github.com/users/CryptoTacos/orgs","repos_url":"https://api.github.com/users/CryptoTacos/repos","events_url":"https://api.github.com/users/CryptoTacos/events{/privacy}","received_events_url":"https://api.github.com/users/CryptoTacos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CryptoTacos/crypto-react-redux-ts","description":null,"fork":false,"url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts","forks_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/forks","keys_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/teams","hooks_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/hooks","issue_events_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/events{/number}","events_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/events","assignees_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/assignees{/user}","branches_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/branches{/branch}","tags_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/tags","blobs_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/refs{/sha}","trees_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/statuses/{sha}","languages_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/languages","stargazers_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/stargazers","contributors_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/contributors","subscribers_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/subscribers","subscription_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/subscription","commits_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/commits{/sha}","git_commits_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/commits{/sha}","comments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/comments{/number}","issue_comment_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/comments{/number}","contents_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/contents/{+path}","compare_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/merges","archive_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/downloads","issues_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues{/number}","pulls_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls{/number}","milestones_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/milestones{/number}","notifications_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/labels{/name}","releases_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/releases{/id}","deployments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/deployments","created_at":"2018-03-04T01:09:43Z","updated_at":"2018-03-10T13:59:12Z","pushed_at":"2018-03-10T21:16:36Z","git_url":"git://github.com/CryptoTacos/crypto-react-redux-ts.git","ssh_url":"git@github.com:CryptoTacos/crypto-react-redux-ts.git","clone_url":"https://github.com/CryptoTacos/crypto-react-redux-ts.git","svn_url":"https://github.com/CryptoTacos/crypto-react-redux-ts","homepage":null,"size":4408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CryptoTacos:master","ref":"master","sha":"caefb4d610c554ce25d2feb790a785b7846fa6a4","user":{"login":"CryptoTacos","id":37244050,"avatar_url":"https://avatars3.githubusercontent.com/u/37244050?v=4","gravatar_id":"","url":"https://api.github.com/users/CryptoTacos","html_url":"https://github.com/CryptoTacos","followers_url":"https://api.github.com/users/CryptoTacos/followers","following_url":"https://api.github.com/users/CryptoTacos/following{/other_user}","gists_url":"https://api.github.com/users/CryptoTacos/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptoTacos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptoTacos/subscriptions","organizations_url":"https://api.github.com/users/CryptoTacos/orgs","repos_url":"https://api.github.com/users/CryptoTacos/repos","events_url":"https://api.github.com/users/CryptoTacos/events{/privacy}","received_events_url":"https://api.github.com/users/CryptoTacos/received_events","type":"Organization","site_admin":false},"repo":{"id":123745336,"name":"crypto-react-redux-ts","full_name":"CryptoTacos/crypto-react-redux-ts","owner":{"login":"CryptoTacos","id":37244050,"avatar_url":"https://avatars3.githubusercontent.com/u/37244050?v=4","gravatar_id":"","url":"https://api.github.com/users/CryptoTacos","html_url":"https://github.com/CryptoTacos","followers_url":"https://api.github.com/users/CryptoTacos/followers","following_url":"https://api.github.com/users/CryptoTacos/following{/other_user}","gists_url":"https://api.github.com/users/CryptoTacos/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptoTacos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptoTacos/subscriptions","organizations_url":"https://api.github.com/users/CryptoTacos/orgs","repos_url":"https://api.github.com/users/CryptoTacos/repos","events_url":"https://api.github.com/users/CryptoTacos/events{/privacy}","received_events_url":"https://api.github.com/users/CryptoTacos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CryptoTacos/crypto-react-redux-ts","description":null,"fork":false,"url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts","forks_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/forks","keys_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/teams","hooks_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/hooks","issue_events_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/events{/number}","events_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/events","assignees_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/assignees{/user}","branches_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/branches{/branch}","tags_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/tags","blobs_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/refs{/sha}","trees_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/statuses/{sha}","languages_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/languages","stargazers_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/stargazers","contributors_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/contributors","subscribers_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/subscribers","subscription_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/subscription","commits_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/commits{/sha}","git_commits_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/git/commits{/sha}","comments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/comments{/number}","issue_comment_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/comments{/number}","contents_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/contents/{+path}","compare_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/merges","archive_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/downloads","issues_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues{/number}","pulls_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls{/number}","milestones_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/milestones{/number}","notifications_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/labels{/name}","releases_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/releases{/id}","deployments_url":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/deployments","created_at":"2018-03-04T01:09:43Z","updated_at":"2018-03-10T13:59:12Z","pushed_at":"2018-03-10T21:16:36Z","git_url":"git://github.com/CryptoTacos/crypto-react-redux-ts.git","ssh_url":"git@github.com:CryptoTacos/crypto-react-redux-ts.git","clone_url":"https://github.com/CryptoTacos/crypto-react-redux-ts.git","svn_url":"https://github.com/CryptoTacos/crypto-react-redux-ts","homepage":null,"size":4408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2"},"html":{"href":"https://github.com/CryptoTacos/crypto-react-redux-ts/pull/2"},"issue":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/2"},"comments":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/CryptoTacos/crypto-react-redux-ts/statuses/23aefca99ff58eb1e9100ec67206bc385f449603"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"drevie"}}