{"action":"created","issue":{"url":"https://api.github.com/repos/micromatch/micromatch/issues/121","repository_url":"https://api.github.com/repos/micromatch/micromatch","labels_url":"https://api.github.com/repos/micromatch/micromatch/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/micromatch/micromatch/issues/121/comments","events_url":"https://api.github.com/repos/micromatch/micromatch/issues/121/events","html_url":"https://github.com/micromatch/micromatch/issues/121","id":306831667,"number":121,"title":"unable to bundle micromatch to browser using webpack","user":{"login":"amir-arad","id":6019373,"avatar_url":"https://avatars1.githubusercontent.com/u/6019373?v=4","gravatar_id":"","url":"https://api.github.com/users/amir-arad","html_url":"https://github.com/amir-arad","followers_url":"https://api.github.com/users/amir-arad/followers","following_url":"https://api.github.com/users/amir-arad/following{/other_user}","gists_url":"https://api.github.com/users/amir-arad/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-arad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-arad/subscriptions","organizations_url":"https://api.github.com/users/amir-arad/orgs","repos_url":"https://api.github.com/users/amir-arad/repos","events_url":"https://api.github.com/users/amir-arad/events{/privacy}","received_events_url":"https://api.github.com/users/amir-arad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-03-20T11:46:04Z","updated_at":"2018-05-02T23:43:47Z","closed_at":"2018-03-21T05:39:28Z","author_association":"NONE","body":"## The **minimum necessary steps** to reproduce this issue:\r\ntry to bundle a file which `require`s micromatch, using webpack.\r\n…\r\n## What is happening (but shouldn't):\r\n[Link](https://ci.appveyor.com/project/amir-arad/kissfs/build/1.0.53#L608)\r\n```\r\nERROR in ./node_modules/snapdragon/lib/source-maps.js\r\nModule not found: Error: Can't resolve 'fs' in '...\\node_modules\\snapdragon\\lib'\r\n @ ./node_modules/snapdragon/lib/source-maps.js 3:9-22\r\n @ ./node_modules/snapdragon/lib/compiler.js\r\n @ ./node_modules/snapdragon/index.js\r\n @ ./node_modules/micromatch/lib/utils.js\r\n @ ./node_modules/micromatch/index.js\r\n```\r\n…\r\n\r\n## What should be happening instead?\r\nIn my opinion, It should bundle with no dependency in nodejs API. There shouldn't be a need to use the `fs` module just to match javascript strings. \r\n…\r\n"},"comment":{"url":"https://api.github.com/repos/micromatch/micromatch/issues/comments/386154449","html_url":"https://github.com/micromatch/micromatch/issues/121#issuecomment-386154449","issue_url":"https://api.github.com/repos/micromatch/micromatch/issues/121","id":386154449,"user":{"login":"dxinteractive","id":345320,"avatar_url":"https://avatars2.githubusercontent.com/u/345320?v=4","gravatar_id":"","url":"https://api.github.com/users/dxinteractive","html_url":"https://github.com/dxinteractive","followers_url":"https://api.github.com/users/dxinteractive/followers","following_url":"https://api.github.com/users/dxinteractive/following{/other_user}","gists_url":"https://api.github.com/users/dxinteractive/gists{/gist_id}","starred_url":"https://api.github.com/users/dxinteractive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxinteractive/subscriptions","organizations_url":"https://api.github.com/users/dxinteractive/orgs","repos_url":"https://api.github.com/users/dxinteractive/repos","events_url":"https://api.github.com/users/dxinteractive/events{/privacy}","received_events_url":"https://api.github.com/users/dxinteractive/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T23:43:47Z","updated_at":"2018-05-02T23:43:47Z","author_association":"NONE","body":"Ah, just bundle my libraries dependencies together with my library code, so the dependency doesn't need to be bundled by the end user? Yeah, that would work, thanks. @jonschlinkert I think I get your point now."}}
{"actor":{"display_login":"dxinteractive"}}