{"action":"created","comment":{"url":"https://api.github.com/repos/disco-lang/disco/pulls/comments/205840125","pull_request_review_id":141195189,"id":205840125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg0MDEyNQ==","diff_hunk":"@@ -697,13 +706,18 @@ parseAtomicType = label \"type\" $\n     -- eventually things like Set), this can't cause any ambiguity.\n   <|> TyList <$> (reserved \"List\" *> parseAtomicType)\n   <|> TySet <$> (reserved \"Set\" *> parseAtomicType)\n+  <|> TyDef <$> parseTyDef\n   <|> TyVar <$> parseTyVar\n   <|> parens parseType\n \n parseTyFin :: Parser Type\n parseTyFin = TyFin  <$> (reserved \"Fin\" *> natural)\n          <|> TyFin  <$> (lexeme (string \"Z\" <|> string \"ℤ\") *> natural)\n \n+-- | Need to change identifier to take an extra parser argument\n+parseTyDef :: Parser String\n+parseTyDef =  ((:) <$> upperChar <*> identifier)","path":"src/Disco/Parser.hs","position":75,"original_position":75,"commit_id":"214695380343f3d303a96ad4160338ed26e721c8","original_commit_id":"214695380343f3d303a96ad4160338ed26e721c8","user":{"login":"byorgey","id":533859,"node_id":"MDQ6VXNlcjUzMzg1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/533859?v=4","gravatar_id":"","url":"https://api.github.com/users/byorgey","html_url":"https://github.com/byorgey","followers_url":"https://api.github.com/users/byorgey/followers","following_url":"https://api.github.com/users/byorgey/following{/other_user}","gists_url":"https://api.github.com/users/byorgey/gists{/gist_id}","starred_url":"https://api.github.com/users/byorgey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byorgey/subscriptions","organizations_url":"https://api.github.com/users/byorgey/orgs","repos_url":"https://api.github.com/users/byorgey/repos","events_url":"https://api.github.com/users/byorgey/events{/privacy}","received_events_url":"https://api.github.com/users/byorgey/received_events","type":"User","site_admin":false},"body":"It looks like this isn't finished yet (it won't allow single-character names).  I forget what we discussed---something about modifying `identifier` to take a parser as an argument to specify what kind of first character to accept?","created_at":"2018-07-27T17:09:46Z","updated_at":"2018-07-27T17:09:46Z","html_url":"https://github.com/disco-lang/disco/pull/122#discussion_r205840125","pull_request_url":"https://api.github.com/repos/disco-lang/disco/pulls/122","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/comments/205840125"},"html":{"href":"https://github.com/disco-lang/disco/pull/122#discussion_r205840125"},"pull_request":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/disco-lang/disco/pulls/122","id":203397607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzk3NjA3","html_url":"https://github.com/disco-lang/disco/pull/122","diff_url":"https://github.com/disco-lang/disco/pull/122.diff","patch_url":"https://github.com/disco-lang/disco/pull/122.patch","issue_url":"https://api.github.com/repos/disco-lang/disco/issues/122","number":122,"state":"open","locked":false,"title":"Type definitions","user":{"login":"SanjitKal","id":24357926,"node_id":"MDQ6VXNlcjI0MzU3OTI2","avatar_url":"https://avatars0.githubusercontent.com/u/24357926?v=4","gravatar_id":"","url":"https://api.github.com/users/SanjitKal","html_url":"https://github.com/SanjitKal","followers_url":"https://api.github.com/users/SanjitKal/followers","following_url":"https://api.github.com/users/SanjitKal/following{/other_user}","gists_url":"https://api.github.com/users/SanjitKal/gists{/gist_id}","starred_url":"https://api.github.com/users/SanjitKal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SanjitKal/subscriptions","organizations_url":"https://api.github.com/users/SanjitKal/orgs","repos_url":"https://api.github.com/users/SanjitKal/repos","events_url":"https://api.github.com/users/SanjitKal/events{/privacy}","received_events_url":"https://api.github.com/users/SanjitKal/received_events","type":"User","site_admin":false},"body":"This branch introduces recursive type definitions into the Disco language. I resolved merge conflicts with master. Let me know if this is good to go/if there needs to be other work done.","created_at":"2018-07-24T03:08:19Z","updated_at":"2018-07-27T17:09:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90db1d9daba8ae68fdb34ea45de62bd89d980132","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/disco-lang/disco/pulls/122/commits","review_comments_url":"https://api.github.com/repos/disco-lang/disco/pulls/122/comments","review_comment_url":"https://api.github.com/repos/disco-lang/disco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/disco-lang/disco/issues/122/comments","statuses_url":"https://api.github.com/repos/disco-lang/disco/statuses/214695380343f3d303a96ad4160338ed26e721c8","head":{"label":"disco-lang:algebraic-data-types","ref":"algebraic-data-types","sha":"214695380343f3d303a96ad4160338ed26e721c8","user":{"login":"disco-lang","id":23236411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM2NDEx","avatar_url":"https://avatars3.githubusercontent.com/u/23236411?v=4","gravatar_id":"","url":"https://api.github.com/users/disco-lang","html_url":"https://github.com/disco-lang","followers_url":"https://api.github.com/users/disco-lang/followers","following_url":"https://api.github.com/users/disco-lang/following{/other_user}","gists_url":"https://api.github.com/users/disco-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/disco-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disco-lang/subscriptions","organizations_url":"https://api.github.com/users/disco-lang/orgs","repos_url":"https://api.github.com/users/disco-lang/repos","events_url":"https://api.github.com/users/disco-lang/events{/privacy}","received_events_url":"https://api.github.com/users/disco-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":60778492,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc3ODQ5Mg==","name":"disco","full_name":"disco-lang/disco","owner":{"login":"disco-lang","id":23236411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM2NDEx","avatar_url":"https://avatars3.githubusercontent.com/u/23236411?v=4","gravatar_id":"","url":"https://api.github.com/users/disco-lang","html_url":"https://github.com/disco-lang","followers_url":"https://api.github.com/users/disco-lang/followers","following_url":"https://api.github.com/users/disco-lang/following{/other_user}","gists_url":"https://api.github.com/users/disco-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/disco-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disco-lang/subscriptions","organizations_url":"https://api.github.com/users/disco-lang/orgs","repos_url":"https://api.github.com/users/disco-lang/repos","events_url":"https://api.github.com/users/disco-lang/events{/privacy}","received_events_url":"https://api.github.com/users/disco-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/disco-lang/disco","description":"Functional teaching language for use in a discrete mathematics course","fork":false,"url":"https://api.github.com/repos/disco-lang/disco","forks_url":"https://api.github.com/repos/disco-lang/disco/forks","keys_url":"https://api.github.com/repos/disco-lang/disco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/disco-lang/disco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/disco-lang/disco/teams","hooks_url":"https://api.github.com/repos/disco-lang/disco/hooks","issue_events_url":"https://api.github.com/repos/disco-lang/disco/issues/events{/number}","events_url":"https://api.github.com/repos/disco-lang/disco/events","assignees_url":"https://api.github.com/repos/disco-lang/disco/assignees{/user}","branches_url":"https://api.github.com/repos/disco-lang/disco/branches{/branch}","tags_url":"https://api.github.com/repos/disco-lang/disco/tags","blobs_url":"https://api.github.com/repos/disco-lang/disco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/disco-lang/disco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/disco-lang/disco/git/refs{/sha}","trees_url":"https://api.github.com/repos/disco-lang/disco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/disco-lang/disco/statuses/{sha}","languages_url":"https://api.github.com/repos/disco-lang/disco/languages","stargazers_url":"https://api.github.com/repos/disco-lang/disco/stargazers","contributors_url":"https://api.github.com/repos/disco-lang/disco/contributors","subscribers_url":"https://api.github.com/repos/disco-lang/disco/subscribers","subscription_url":"https://api.github.com/repos/disco-lang/disco/subscription","commits_url":"https://api.github.com/repos/disco-lang/disco/commits{/sha}","git_commits_url":"https://api.github.com/repos/disco-lang/disco/git/commits{/sha}","comments_url":"https://api.github.com/repos/disco-lang/disco/comments{/number}","issue_comment_url":"https://api.github.com/repos/disco-lang/disco/issues/comments{/number}","contents_url":"https://api.github.com/repos/disco-lang/disco/contents/{+path}","compare_url":"https://api.github.com/repos/disco-lang/disco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/disco-lang/disco/merges","archive_url":"https://api.github.com/repos/disco-lang/disco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/disco-lang/disco/downloads","issues_url":"https://api.github.com/repos/disco-lang/disco/issues{/number}","pulls_url":"https://api.github.com/repos/disco-lang/disco/pulls{/number}","milestones_url":"https://api.github.com/repos/disco-lang/disco/milestones{/number}","notifications_url":"https://api.github.com/repos/disco-lang/disco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/disco-lang/disco/labels{/name}","releases_url":"https://api.github.com/repos/disco-lang/disco/releases{/id}","deployments_url":"https://api.github.com/repos/disco-lang/disco/deployments","created_at":"2016-06-09T13:51:41Z","updated_at":"2018-07-22T05:00:07Z","pushed_at":"2018-07-27T16:58:15Z","git_url":"git://github.com/disco-lang/disco.git","ssh_url":"git@github.com:disco-lang/disco.git","clone_url":"https://github.com/disco-lang/disco.git","svn_url":"https://github.com/disco-lang/disco","homepage":"","size":10912,"stargazers_count":22,"watchers_count":22,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":43,"watchers":22,"default_branch":"master"}},"base":{"label":"disco-lang:master","ref":"master","sha":"daa78ea07883675d1fcc468deb7a04e51a605f02","user":{"login":"disco-lang","id":23236411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM2NDEx","avatar_url":"https://avatars3.githubusercontent.com/u/23236411?v=4","gravatar_id":"","url":"https://api.github.com/users/disco-lang","html_url":"https://github.com/disco-lang","followers_url":"https://api.github.com/users/disco-lang/followers","following_url":"https://api.github.com/users/disco-lang/following{/other_user}","gists_url":"https://api.github.com/users/disco-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/disco-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disco-lang/subscriptions","organizations_url":"https://api.github.com/users/disco-lang/orgs","repos_url":"https://api.github.com/users/disco-lang/repos","events_url":"https://api.github.com/users/disco-lang/events{/privacy}","received_events_url":"https://api.github.com/users/disco-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":60778492,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc3ODQ5Mg==","name":"disco","full_name":"disco-lang/disco","owner":{"login":"disco-lang","id":23236411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM2NDEx","avatar_url":"https://avatars3.githubusercontent.com/u/23236411?v=4","gravatar_id":"","url":"https://api.github.com/users/disco-lang","html_url":"https://github.com/disco-lang","followers_url":"https://api.github.com/users/disco-lang/followers","following_url":"https://api.github.com/users/disco-lang/following{/other_user}","gists_url":"https://api.github.com/users/disco-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/disco-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disco-lang/subscriptions","organizations_url":"https://api.github.com/users/disco-lang/orgs","repos_url":"https://api.github.com/users/disco-lang/repos","events_url":"https://api.github.com/users/disco-lang/events{/privacy}","received_events_url":"https://api.github.com/users/disco-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/disco-lang/disco","description":"Functional teaching language for use in a discrete mathematics course","fork":false,"url":"https://api.github.com/repos/disco-lang/disco","forks_url":"https://api.github.com/repos/disco-lang/disco/forks","keys_url":"https://api.github.com/repos/disco-lang/disco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/disco-lang/disco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/disco-lang/disco/teams","hooks_url":"https://api.github.com/repos/disco-lang/disco/hooks","issue_events_url":"https://api.github.com/repos/disco-lang/disco/issues/events{/number}","events_url":"https://api.github.com/repos/disco-lang/disco/events","assignees_url":"https://api.github.com/repos/disco-lang/disco/assignees{/user}","branches_url":"https://api.github.com/repos/disco-lang/disco/branches{/branch}","tags_url":"https://api.github.com/repos/disco-lang/disco/tags","blobs_url":"https://api.github.com/repos/disco-lang/disco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/disco-lang/disco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/disco-lang/disco/git/refs{/sha}","trees_url":"https://api.github.com/repos/disco-lang/disco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/disco-lang/disco/statuses/{sha}","languages_url":"https://api.github.com/repos/disco-lang/disco/languages","stargazers_url":"https://api.github.com/repos/disco-lang/disco/stargazers","contributors_url":"https://api.github.com/repos/disco-lang/disco/contributors","subscribers_url":"https://api.github.com/repos/disco-lang/disco/subscribers","subscription_url":"https://api.github.com/repos/disco-lang/disco/subscription","commits_url":"https://api.github.com/repos/disco-lang/disco/commits{/sha}","git_commits_url":"https://api.github.com/repos/disco-lang/disco/git/commits{/sha}","comments_url":"https://api.github.com/repos/disco-lang/disco/comments{/number}","issue_comment_url":"https://api.github.com/repos/disco-lang/disco/issues/comments{/number}","contents_url":"https://api.github.com/repos/disco-lang/disco/contents/{+path}","compare_url":"https://api.github.com/repos/disco-lang/disco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/disco-lang/disco/merges","archive_url":"https://api.github.com/repos/disco-lang/disco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/disco-lang/disco/downloads","issues_url":"https://api.github.com/repos/disco-lang/disco/issues{/number}","pulls_url":"https://api.github.com/repos/disco-lang/disco/pulls{/number}","milestones_url":"https://api.github.com/repos/disco-lang/disco/milestones{/number}","notifications_url":"https://api.github.com/repos/disco-lang/disco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/disco-lang/disco/labels{/name}","releases_url":"https://api.github.com/repos/disco-lang/disco/releases{/id}","deployments_url":"https://api.github.com/repos/disco-lang/disco/deployments","created_at":"2016-06-09T13:51:41Z","updated_at":"2018-07-22T05:00:07Z","pushed_at":"2018-07-27T16:58:15Z","git_url":"git://github.com/disco-lang/disco.git","ssh_url":"git@github.com:disco-lang/disco.git","clone_url":"https://github.com/disco-lang/disco.git","svn_url":"https://github.com/disco-lang/disco","homepage":"","size":10912,"stargazers_count":22,"watchers_count":22,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":43,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/122"},"html":{"href":"https://github.com/disco-lang/disco/pull/122"},"issue":{"href":"https://api.github.com/repos/disco-lang/disco/issues/122"},"comments":{"href":"https://api.github.com/repos/disco-lang/disco/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/disco-lang/disco/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/disco-lang/disco/statuses/214695380343f3d303a96ad4160338ed26e721c8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"byorgey"}}