{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/208528994","pull_request_review_id":144352609,"id":208528994,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUyODk5NA==","diff_hunk":"@@ -514,6 +514,138 @@ def elements(self):\n         P, T = self._to_perm_group()\n         return T.invert(P._elements)\n \n+def subgroup_quotient(G, H, parent_group=None, homomorphism=False):\n+    '''\n+    Compute the quotient group G/H.\n+    The quotient group is computed on a new FreeGroup when\n+    `G` list of the elements of parent_group.","path":"sympy/combinatorics/fp_groups.py","position":8,"original_position":8,"commit_id":"4aef3d0aad5e5316ca0c7141c69543fd320d2fe0","original_commit_id":"4aef3d0aad5e5316ca0c7141c69543fd320d2fe0","user":{"login":"valglad","id":20492235,"node_id":"MDQ6VXNlcjIwNDkyMjM1","avatar_url":"https://avatars0.githubusercontent.com/u/20492235?v=4","gravatar_id":"","url":"https://api.github.com/users/valglad","html_url":"https://github.com/valglad","followers_url":"https://api.github.com/users/valglad/followers","following_url":"https://api.github.com/users/valglad/following{/other_user}","gists_url":"https://api.github.com/users/valglad/gists{/gist_id}","starred_url":"https://api.github.com/users/valglad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valglad/subscriptions","organizations_url":"https://api.github.com/users/valglad/orgs","repos_url":"https://api.github.com/users/valglad/repos","events_url":"https://api.github.com/users/valglad/events{/privacy}","received_events_url":"https://api.github.com/users/valglad/received_events","type":"User","site_admin":false},"body":"\"is a list\" - typo","created_at":"2018-08-08T10:17:37Z","updated_at":"2018-08-08T10:29:54Z","html_url":"https://github.com/sympy/sympy/pull/14981#discussion_r208528994","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/14981","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/208528994"},"html":{"href":"https://github.com/sympy/sympy/pull/14981#discussion_r208528994"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14981"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14981","id":204378794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzc4Nzk0","html_url":"https://github.com/sympy/sympy/pull/14981","diff_url":"https://github.com/sympy/sympy/pull/14981.diff","patch_url":"https://github.com/sympy/sympy/pull/14981.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14981","number":14981,"state":"open","locked":false,"title":"Add quotient methods","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\n\r\n\r\n#### Brief description of what is fixed or changed\r\nAdd quotient methods for `FpGroup`s. \r\n\r\n\r\n#### To-do\r\n* Add methods for epimorphism quotients. \r\n* Add tests. \r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. If there is no release notes entry for this PR,\r\nwrite \"NO ENTRY\". The bot will check your release notes automatically to see\r\nif they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* combinatorics\r\n   * It is now possible to compute subgroup quotient and the maximal abelian quotients of an `FpGroup`. \r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2018-07-27T09:33:01Z","updated_at":"2018-08-08T10:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56e6b75b552eaa2f2af88f79cd474cc4d376c4f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222449974,"node_id":"MDU6TGFiZWwyMjI0NDk5NzQ=","url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn","name":"PR: author's turn","color":"ffff80","default":false},{"id":84627391,"node_id":"MDU6TGFiZWw4NDYyNzM5MQ==","url":"https://api.github.com/repos/sympy/sympy/labels/combinatorics","name":"combinatorics","color":"0000FF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/14981/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/14981/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14981/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/4aef3d0aad5e5316ca0c7141c69543fd320d2fe0","head":{"label":"RavicharanN:quotient-methods","ref":"quotient-methods","sha":"4aef3d0aad5e5316ca0c7141c69543fd320d2fe0","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"repo":{"id":118352566,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNTI1NjY=","name":"sympy","full_name":"RavicharanN/sympy","owner":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RavicharanN/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/RavicharanN/sympy","forks_url":"https://api.github.com/repos/RavicharanN/sympy/forks","keys_url":"https://api.github.com/repos/RavicharanN/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RavicharanN/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RavicharanN/sympy/teams","hooks_url":"https://api.github.com/repos/RavicharanN/sympy/hooks","issue_events_url":"https://api.github.com/repos/RavicharanN/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/RavicharanN/sympy/events","assignees_url":"https://api.github.com/repos/RavicharanN/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/RavicharanN/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/RavicharanN/sympy/tags","blobs_url":"https://api.github.com/repos/RavicharanN/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RavicharanN/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RavicharanN/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/RavicharanN/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RavicharanN/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/RavicharanN/sympy/languages","stargazers_url":"https://api.github.com/repos/RavicharanN/sympy/stargazers","contributors_url":"https://api.github.com/repos/RavicharanN/sympy/contributors","subscribers_url":"https://api.github.com/repos/RavicharanN/sympy/subscribers","subscription_url":"https://api.github.com/repos/RavicharanN/sympy/subscription","commits_url":"https://api.github.com/repos/RavicharanN/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/RavicharanN/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/RavicharanN/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/RavicharanN/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/RavicharanN/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/RavicharanN/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RavicharanN/sympy/merges","archive_url":"https://api.github.com/repos/RavicharanN/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RavicharanN/sympy/downloads","issues_url":"https://api.github.com/repos/RavicharanN/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/RavicharanN/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/RavicharanN/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/RavicharanN/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RavicharanN/sympy/labels{/name}","releases_url":"https://api.github.com/repos/RavicharanN/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/RavicharanN/sympy/deployments","created_at":"2018-01-21T16:33:46Z","updated_at":"2018-06-18T17:31:39Z","pushed_at":"2018-08-08T10:04:10Z","git_url":"git://github.com/RavicharanN/sympy.git","ssh_url":"git@github.com:RavicharanN/sympy.git","clone_url":"https://github.com/RavicharanN/sympy.git","svn_url":"https://github.com/RavicharanN/sympy","homepage":"http://sympy.org/","size":94158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"bc1d1d92dbc3df75d19ce60faf359eff2d755ad9","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-08-08T08:14:08Z","pushed_at":"2018-08-08T10:24:48Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":94279,"stargazers_count":5004,"watchers_count":5004,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2316,"mirror_url":null,"archived":false,"open_issues_count":3392,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2316,"open_issues":3392,"watchers":5004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14981"},"html":{"href":"https://github.com/sympy/sympy/pull/14981"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/14981"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/14981/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14981/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14981/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/4aef3d0aad5e5316ca0c7141c69543fd320d2fe0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"valglad"}}