{"action":"opened","issue":{"url":"https://api.github.com/repos/EdwardMcveigh/prj-rev-bwfs-dasmoto/issues/4","repository_url":"https://api.github.com/repos/EdwardMcveigh/prj-rev-bwfs-dasmoto","labels_url":"https://api.github.com/repos/EdwardMcveigh/prj-rev-bwfs-dasmoto/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/EdwardMcveigh/prj-rev-bwfs-dasmoto/issues/4/comments","events_url":"https://api.github.com/repos/EdwardMcveigh/prj-rev-bwfs-dasmoto/issues/4/events","html_url":"https://github.com/EdwardMcveigh/prj-rev-bwfs-dasmoto/issues/4","id":315591898,"number":4,"title":"CSS Source","user":{"login":"sdhunt","id":8562159,"avatar_url":"https://avatars3.githubusercontent.com/u/8562159?v=4","gravatar_id":"","url":"https://api.github.com/users/sdhunt","html_url":"https://github.com/sdhunt","followers_url":"https://api.github.com/users/sdhunt/followers","following_url":"https://api.github.com/users/sdhunt/following{/other_user}","gists_url":"https://api.github.com/users/sdhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/sdhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdhunt/subscriptions","organizations_url":"https://api.github.com/users/sdhunt/orgs","repos_url":"https://api.github.com/users/sdhunt/repos","events_url":"https://api.github.com/users/sdhunt/events{/privacy}","received_events_url":"https://api.github.com/users/sdhunt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-18T18:26:44Z","updated_at":"2018-04-18T18:26:44Z","closed_at":null,"author_association":"NONE","body":"The CSS is formatted nicely with appropriate indentation of, and whitespace between, each of the CSS rules.\r\n\r\nThere is, however, unnecessary duplication that should be removed:\r\nhttps://github.com/EdwardMcveigh/prj-rev-bwfs-dasmoto/blob/master/dasmotos/css/style.css#L18-L37\r\n\r\nYou can define a common CSS class with the styles to apply to each `<h2>` elements, in addition to the distinct styles for each. For example:\r\n```\r\n.section h2 {\r\n  font-size: 32px;\r\n  font-weight: bold;\r\n  color: white;\r\n}\r\n\r\n.brushes h2 {\r\n  background-color: mediumspringgreen;\r\n}\r\n\r\n.frames h2 {\r\n  background-color: lightcoral;\r\n}\r\n\r\n.paint h2 {\r\n  background-color: skyblue;\r\n}\r\n```\r\nAnd adding the common `section` class to each of the sections in the HTML:\r\n```\r\n    <div class=\"brushes section\">\r\n      <h2>Brushes</h2>\r\n      ...\r\n    </div>\r\n\r\n    <div class=\"frames section\">\r\n      <h2>Frames</h2>\r\n      ...\r\n    </div>\r\n\r\n    <div class=\"paint section\">\r\n      <h2>Paint</h2>\r\n      ...\r\n    </div>\r\n```\r\nNote that the value of the `class` attribute, when space-delimited, is treated as a list of CSS classes to apply to that element."}}
{"actor":{"display_login":"sdhunt"}}