{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244","id":234173163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTczMTYz","html_url":"https://github.com/jdalrymple/node-gitlab/pull/244","diff_url":"https://github.com/jdalrymple/node-gitlab/pull/244.diff","patch_url":"https://github.com/jdalrymple/node-gitlab/pull/244.patch","issue_url":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/244","number":244,"state":"closed","locked":false,"title":"WIP: Add unit tests to next","user":{"login":"beaverusiv","id":4149031,"node_id":"MDQ6VXNlcjQxNDkwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4149031?v=4","gravatar_id":"","url":"https://api.github.com/users/beaverusiv","html_url":"https://github.com/beaverusiv","followers_url":"https://api.github.com/users/beaverusiv/followers","following_url":"https://api.github.com/users/beaverusiv/following{/other_user}","gists_url":"https://api.github.com/users/beaverusiv/gists{/gist_id}","starred_url":"https://api.github.com/users/beaverusiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaverusiv/subscriptions","organizations_url":"https://api.github.com/users/beaverusiv/orgs","repos_url":"https://api.github.com/users/beaverusiv/repos","events_url":"https://api.github.com/users/beaverusiv/events{/privacy}","received_events_url":"https://api.github.com/users/beaverusiv/received_events","type":"User","site_admin":false},"body":"This is an experiment to add unit tests to the repository. I see you have setup rigging for integration testing which is nice but I am of the opinion that unit testing should not be left out.\r\n\r\nThe big change needed is to make `RequestHelper` non-static so that we can mock it. This current batch of tests look pretty trivial and a great many will be but they still come together to provide a safety net for changes and even help development when the Gitlab API changes as you can change the unit tests first to expect the new formats.\r\n\r\nAs you can see at `src/services/Projects.ts:31` adding the tests already exposed the fact that `userId` was a required parameter when it should be optional.\r\n\r\nI'm not expecting to have this accepted as-is but I am looking for feedback as to if this is something that is welcome so I can move forward.","created_at":"2018-11-28T07:25:18Z","updated_at":"2018-12-03T21:31:00Z","closed_at":"2018-12-03T21:31:00Z","merged_at":"2018-12-03T21:31:00Z","merge_commit_sha":"44dbfd48c42c90d912fe8f5e9c4655550cbe8504","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244/commits","review_comments_url":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244/comments","review_comment_url":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/244/comments","statuses_url":"https://api.github.com/repos/jdalrymple/node-gitlab/statuses/44dbfd48c42c90d912fe8f5e9c4655550cbe8504","head":{"label":"beaverusiv:add-tests-next","ref":"add-tests-next","sha":"44dbfd48c42c90d912fe8f5e9c4655550cbe8504","user":{"login":"beaverusiv","id":4149031,"node_id":"MDQ6VXNlcjQxNDkwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4149031?v=4","gravatar_id":"","url":"https://api.github.com/users/beaverusiv","html_url":"https://github.com/beaverusiv","followers_url":"https://api.github.com/users/beaverusiv/followers","following_url":"https://api.github.com/users/beaverusiv/following{/other_user}","gists_url":"https://api.github.com/users/beaverusiv/gists{/gist_id}","starred_url":"https://api.github.com/users/beaverusiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaverusiv/subscriptions","organizations_url":"https://api.github.com/users/beaverusiv/orgs","repos_url":"https://api.github.com/users/beaverusiv/repos","events_url":"https://api.github.com/users/beaverusiv/events{/privacy}","received_events_url":"https://api.github.com/users/beaverusiv/received_events","type":"User","site_admin":false},"repo":{"id":159459260,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0NTkyNjA=","name":"node-gitlab","full_name":"beaverusiv/node-gitlab","private":false,"owner":{"login":"beaverusiv","id":4149031,"node_id":"MDQ6VXNlcjQxNDkwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4149031?v=4","gravatar_id":"","url":"https://api.github.com/users/beaverusiv","html_url":"https://github.com/beaverusiv","followers_url":"https://api.github.com/users/beaverusiv/followers","following_url":"https://api.github.com/users/beaverusiv/following{/other_user}","gists_url":"https://api.github.com/users/beaverusiv/gists{/gist_id}","starred_url":"https://api.github.com/users/beaverusiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaverusiv/subscriptions","organizations_url":"https://api.github.com/users/beaverusiv/orgs","repos_url":"https://api.github.com/users/beaverusiv/repos","events_url":"https://api.github.com/users/beaverusiv/events{/privacy}","received_events_url":"https://api.github.com/users/beaverusiv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/beaverusiv/node-gitlab","description":"🤖 GitLab API NodeJS library with full support of all the Gitlab API services.","fork":true,"url":"https://api.github.com/repos/beaverusiv/node-gitlab","forks_url":"https://api.github.com/repos/beaverusiv/node-gitlab/forks","keys_url":"https://api.github.com/repos/beaverusiv/node-gitlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beaverusiv/node-gitlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beaverusiv/node-gitlab/teams","hooks_url":"https://api.github.com/repos/beaverusiv/node-gitlab/hooks","issue_events_url":"https://api.github.com/repos/beaverusiv/node-gitlab/issues/events{/number}","events_url":"https://api.github.com/repos/beaverusiv/node-gitlab/events","assignees_url":"https://api.github.com/repos/beaverusiv/node-gitlab/assignees{/user}","branches_url":"https://api.github.com/repos/beaverusiv/node-gitlab/branches{/branch}","tags_url":"https://api.github.com/repos/beaverusiv/node-gitlab/tags","blobs_url":"https://api.github.com/repos/beaverusiv/node-gitlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beaverusiv/node-gitlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beaverusiv/node-gitlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/beaverusiv/node-gitlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beaverusiv/node-gitlab/statuses/{sha}","languages_url":"https://api.github.com/repos/beaverusiv/node-gitlab/languages","stargazers_url":"https://api.github.com/repos/beaverusiv/node-gitlab/stargazers","contributors_url":"https://api.github.com/repos/beaverusiv/node-gitlab/contributors","subscribers_url":"https://api.github.com/repos/beaverusiv/node-gitlab/subscribers","subscription_url":"https://api.github.com/repos/beaverusiv/node-gitlab/subscription","commits_url":"https://api.github.com/repos/beaverusiv/node-gitlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/beaverusiv/node-gitlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/beaverusiv/node-gitlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/beaverusiv/node-gitlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/beaverusiv/node-gitlab/contents/{+path}","compare_url":"https://api.github.com/repos/beaverusiv/node-gitlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beaverusiv/node-gitlab/merges","archive_url":"https://api.github.com/repos/beaverusiv/node-gitlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beaverusiv/node-gitlab/downloads","issues_url":"https://api.github.com/repos/beaverusiv/node-gitlab/issues{/number}","pulls_url":"https://api.github.com/repos/beaverusiv/node-gitlab/pulls{/number}","milestones_url":"https://api.github.com/repos/beaverusiv/node-gitlab/milestones{/number}","notifications_url":"https://api.github.com/repos/beaverusiv/node-gitlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beaverusiv/node-gitlab/labels{/name}","releases_url":"https://api.github.com/repos/beaverusiv/node-gitlab/releases{/id}","deployments_url":"https://api.github.com/repos/beaverusiv/node-gitlab/deployments","created_at":"2018-11-28T07:09:20Z","updated_at":"2018-11-28T07:09:22Z","pushed_at":"2018-12-03T03:23:26Z","git_url":"git://github.com/beaverusiv/node-gitlab.git","ssh_url":"git@github.com:beaverusiv/node-gitlab.git","clone_url":"https://github.com/beaverusiv/node-gitlab.git","svn_url":"https://github.com/beaverusiv/node-gitlab","homepage":"","size":2358,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdalrymple:next","ref":"next","sha":"e3db58cb50e015d1cf764a1e34fa205aa8f5dabc","user":{"login":"jdalrymple","id":3743662,"node_id":"MDQ6VXNlcjM3NDM2NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3743662?v=4","gravatar_id":"","url":"https://api.github.com/users/jdalrymple","html_url":"https://github.com/jdalrymple","followers_url":"https://api.github.com/users/jdalrymple/followers","following_url":"https://api.github.com/users/jdalrymple/following{/other_user}","gists_url":"https://api.github.com/users/jdalrymple/gists{/gist_id}","starred_url":"https://api.github.com/users/jdalrymple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdalrymple/subscriptions","organizations_url":"https://api.github.com/users/jdalrymple/orgs","repos_url":"https://api.github.com/users/jdalrymple/repos","events_url":"https://api.github.com/users/jdalrymple/events{/privacy}","received_events_url":"https://api.github.com/users/jdalrymple/received_events","type":"User","site_admin":false},"repo":{"id":95022732,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMjczMg==","name":"node-gitlab","full_name":"jdalrymple/node-gitlab","private":false,"owner":{"login":"jdalrymple","id":3743662,"node_id":"MDQ6VXNlcjM3NDM2NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3743662?v=4","gravatar_id":"","url":"https://api.github.com/users/jdalrymple","html_url":"https://github.com/jdalrymple","followers_url":"https://api.github.com/users/jdalrymple/followers","following_url":"https://api.github.com/users/jdalrymple/following{/other_user}","gists_url":"https://api.github.com/users/jdalrymple/gists{/gist_id}","starred_url":"https://api.github.com/users/jdalrymple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdalrymple/subscriptions","organizations_url":"https://api.github.com/users/jdalrymple/orgs","repos_url":"https://api.github.com/users/jdalrymple/repos","events_url":"https://api.github.com/users/jdalrymple/events{/privacy}","received_events_url":"https://api.github.com/users/jdalrymple/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdalrymple/node-gitlab","description":"🤖 GitLab API NodeJS library with full support of all the Gitlab API services.","fork":false,"url":"https://api.github.com/repos/jdalrymple/node-gitlab","forks_url":"https://api.github.com/repos/jdalrymple/node-gitlab/forks","keys_url":"https://api.github.com/repos/jdalrymple/node-gitlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdalrymple/node-gitlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdalrymple/node-gitlab/teams","hooks_url":"https://api.github.com/repos/jdalrymple/node-gitlab/hooks","issue_events_url":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/events{/number}","events_url":"https://api.github.com/repos/jdalrymple/node-gitlab/events","assignees_url":"https://api.github.com/repos/jdalrymple/node-gitlab/assignees{/user}","branches_url":"https://api.github.com/repos/jdalrymple/node-gitlab/branches{/branch}","tags_url":"https://api.github.com/repos/jdalrymple/node-gitlab/tags","blobs_url":"https://api.github.com/repos/jdalrymple/node-gitlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdalrymple/node-gitlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdalrymple/node-gitlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdalrymple/node-gitlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdalrymple/node-gitlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jdalrymple/node-gitlab/languages","stargazers_url":"https://api.github.com/repos/jdalrymple/node-gitlab/stargazers","contributors_url":"https://api.github.com/repos/jdalrymple/node-gitlab/contributors","subscribers_url":"https://api.github.com/repos/jdalrymple/node-gitlab/subscribers","subscription_url":"https://api.github.com/repos/jdalrymple/node-gitlab/subscription","commits_url":"https://api.github.com/repos/jdalrymple/node-gitlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdalrymple/node-gitlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdalrymple/node-gitlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdalrymple/node-gitlab/contents/{+path}","compare_url":"https://api.github.com/repos/jdalrymple/node-gitlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdalrymple/node-gitlab/merges","archive_url":"https://api.github.com/repos/jdalrymple/node-gitlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdalrymple/node-gitlab/downloads","issues_url":"https://api.github.com/repos/jdalrymple/node-gitlab/issues{/number}","pulls_url":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jdalrymple/node-gitlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jdalrymple/node-gitlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdalrymple/node-gitlab/labels{/name}","releases_url":"https://api.github.com/repos/jdalrymple/node-gitlab/releases{/id}","deployments_url":"https://api.github.com/repos/jdalrymple/node-gitlab/deployments","created_at":"2017-06-21T16:11:31Z","updated_at":"2018-11-30T23:26:44Z","pushed_at":"2018-12-03T21:31:00Z","git_url":"git://github.com/jdalrymple/node-gitlab.git","ssh_url":"git@github.com:jdalrymple/node-gitlab.git","clone_url":"https://github.com/jdalrymple/node-gitlab.git","svn_url":"https://github.com/jdalrymple/node-gitlab","homepage":"","size":2254,"stargazers_count":182,"watchers_count":182,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":77,"open_issues":12,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244"},"html":{"href":"https://github.com/jdalrymple/node-gitlab/pull/244"},"issue":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/244"},"comments":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/jdalrymple/node-gitlab/statuses/44dbfd48c42c90d912fe8f5e9c4655550cbe8504"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jdalrymple","id":3743662,"node_id":"MDQ6VXNlcjM3NDM2NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3743662?v=4","gravatar_id":"","url":"https://api.github.com/users/jdalrymple","html_url":"https://github.com/jdalrymple","followers_url":"https://api.github.com/users/jdalrymple/followers","following_url":"https://api.github.com/users/jdalrymple/following{/other_user}","gists_url":"https://api.github.com/users/jdalrymple/gists{/gist_id}","starred_url":"https://api.github.com/users/jdalrymple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdalrymple/subscriptions","organizations_url":"https://api.github.com/users/jdalrymple/orgs","repos_url":"https://api.github.com/users/jdalrymple/repos","events_url":"https://api.github.com/users/jdalrymple/events{/privacy}","received_events_url":"https://api.github.com/users/jdalrymple/received_events","type":"User","site_admin":false},"comments":22,"review_comments":0,"maintainer_can_modify":false,"commits":19,"additions":297,"deletions":160,"changed_files":61}}
{"actor":{"display_login":"jdalrymple"}}