{"action":"created","issue":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1440","repository_url":"https://api.github.com/repos/firebase/firebase-js-sdk","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1440/labels{/name}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1440/comments","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1440/events","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1440","id":393519774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTIxOTYy","number":1440,"title":"Collection Group Queries w/ indexing [WIP -- not ready for submission]","user":{"login":"mikelehen","id":206364,"node_id":"MDQ6VXNlcjIwNjM2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/206364?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelehen","html_url":"https://github.com/mikelehen","followers_url":"https://api.github.com/users/mikelehen/followers","following_url":"https://api.github.com/users/mikelehen/following{/other_user}","gists_url":"https://api.github.com/users/mikelehen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelehen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelehen/subscriptions","organizations_url":"https://api.github.com/users/mikelehen/orgs","repos_url":"https://api.github.com/users/mikelehen/repos","events_url":"https://api.github.com/users/mikelehen/events{/privacy}","received_events_url":"https://api.github.com/users/mikelehen/received_events","type":"User","site_admin":false},"labels":[{"id":710626490,"node_id":"MDU6TGFiZWw3MTA2MjY0OTA=","url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels/Component-Firestore","name":"Component-Firestore","color":"e881d1","default":false},{"id":606552212,"node_id":"MDU6TGFiZWw2MDY1NTIyMTI=","url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-12-21T16:37:26Z","updated_at":"2018-12-21T19:22:43Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1440","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1440","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/1440.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/1440.patch"},"body":"@wilhuff If you have time can you do an initial sanity-check review of this before the holiday?  I was hoping to have it 100% ready, but have been too randomized.  The feature works, but it's missing the schema migration to populate the index and I need to add more tests.  In particular, this PR contains:\r\n* API surface area for Collection Group queries.\r\n* New QueryIndexes component to maintain a collectionParents index for CG queries.\r\n* The plumbing changes to serializer, Query execution, LocalDocumentsView, etc. to make CG queries work with the new index.\r\n"},"comment":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments/449476341","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1440#issuecomment-449476341","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1440","id":449476341,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQ3NjM0MQ==","user":{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T19:22:43Z","updated_at":"2018-12-21T19:22:43Z","author_association":"MEMBER","body":"One other thought: could it be useful to have a possibly disabled by default test that exercises collection groups in combination with filters/order by?"}}
{"actor":{"display_login":"wilhuff"}}