{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/console/issues/162","repository_url":"https://api.github.com/repos/openshift/console","labels_url":"https://api.github.com/repos/openshift/console/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/openshift/console/issues/162/comments","events_url":"https://api.github.com/repos/openshift/console/issues/162/events","html_url":"https://github.com/openshift/console/pull/162","id":335434936,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTM0MTQ0","number":162,"title":"Null secret value","user":{"login":"jhadvig","id":1668218,"node_id":"MDQ6VXNlcjE2NjgyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1668218?v=4","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"labels":[{"id":926926783,"node_id":"MDU6TGFiZWw5MjY5MjY3ODM=","url":"https://api.github.com/repos/openshift/console/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"assignees":[{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-25T14:35:40Z","updated_at":"2018-06-25T14:53:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/162","html_url":"https://github.com/openshift/console/pull/162","diff_url":"https://github.com/openshift/console/pull/162.diff","patch_url":"https://github.com/openshift/console/pull/162.patch"},"body":"SecretData component is not handling properly secrets without value - where value is set to `null`.\r\n![2](https://user-images.githubusercontent.com/1668218/41856477-7f1cd366-7895-11e8-88f8-e5ed5fbf577e.png)\r\n\r\nFixing this by showing `No value` in italic tag:\r\n![1](https://user-images.githubusercontent.com/1668218/41856563-aebe42da-7895-11e8-8c5e-ac79d5d37f0f.png)\r\n\r\n@benjaminapetersen PTAL"},"comment":{"url":"https://api.github.com/repos/openshift/console/issues/comments/399980600","html_url":"https://github.com/openshift/console/pull/162#issuecomment-399980600","issue_url":"https://api.github.com/repos/openshift/console/issues/162","id":399980600,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTk4MDYwMA==","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T14:53:40Z","updated_at":"2018-06-25T14:53:40Z","author_association":"MEMBER","body":"Yeah, per our conversation earlier, I don't see a reason to mask null values."}}
{"actor":{"display_login":"spadgett"}}