{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/guides/pulls/comments/198133859","pull_request_review_id":132007229,"id":198133859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODEzMzg1OQ==","diff_hunk":"@@ -264,6 +264,15 @@ The logic in this class has\n quite strong assumptions on the data being stored. It assumes that it has the tree structure and each entity contains its kids as a nested hash.\n If you are able to achieve that structure in the `refresh_parser.rb`, you are halfway done. Otherwise, good luck :]\n \n+### Defining Inventory\n+\n+Basically, refresh process consists of Collector, Persister and Parser classes (in most providers).\n+When Collector loads data from external provider (like AWS), Persister defines structure of Inventory by InventoryCollection objects.  \n+Inventory is then saved to VMDB (ManageIQ (also CFME) app database). Each inventory belons to certain ActiveRecord model.\n+Parser maps collected data to these inventories.","path":"providers/dev-guide.md","position":9,"original_position":9,"commit_id":"361224145632063b68a1c8f721e9b8a423f05f17","original_commit_id":"361224145632063b68a1c8f721e9b8a423f05f17","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"How about `Parser maps data collected from the provider to the common format defined by the ActiveRecord model` or something like that?","created_at":"2018-06-26T13:03:41Z","updated_at":"2018-06-26T13:03:41Z","html_url":"https://github.com/ManageIQ/guides/pull/316#discussion_r198133859","pull_request_url":"https://api.github.com/repos/ManageIQ/guides/pulls/316","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/comments/198133859"},"html":{"href":"https://github.com/ManageIQ/guides/pull/316#discussion_r198133859"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/guides/pulls/316","id":195780778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzgwNzc4","html_url":"https://github.com/ManageIQ/guides/pull/316","diff_url":"https://github.com/ManageIQ/guides/pull/316.diff","patch_url":"https://github.com/ManageIQ/guides/pull/316.patch","issue_url":"https://api.github.com/repos/ManageIQ/guides/issues/316","number":316,"state":"open","locked":false,"title":"InventoryCollection definition ","user":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"body":"**Issue** https://github.com/ManageIQ/manageiq/issues/17396\r\n\r\nDescription of ```ManagerRefresh::Inventory::Persister#add_collection()``` and builder classes for definition of InventoryCollection\r\n\r\nCc @agrare \r\n\r\n\r\n","created_at":"2018-06-19T10:29:15Z","updated_at":"2018-06-26T13:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"247a480d3e6b594ceded15d9bb4d482088896e41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/guides/pulls/316/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/guides/pulls/316/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/guides/issues/316/comments","statuses_url":"https://api.github.com/repos/ManageIQ/guides/statuses/361224145632063b68a1c8f721e9b8a423f05f17","head":{"label":"slemrmartin:inventory-collection-builder","ref":"inventory-collection-builder","sha":"361224145632063b68a1c8f721e9b8a423f05f17","user":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"repo":{"id":124360634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzNjA2MzQ=","name":"guides","full_name":"slemrmartin/guides","owner":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slemrmartin/guides","description":"ManageIQ guides and developer documentation","fork":true,"url":"https://api.github.com/repos/slemrmartin/guides","forks_url":"https://api.github.com/repos/slemrmartin/guides/forks","keys_url":"https://api.github.com/repos/slemrmartin/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slemrmartin/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slemrmartin/guides/teams","hooks_url":"https://api.github.com/repos/slemrmartin/guides/hooks","issue_events_url":"https://api.github.com/repos/slemrmartin/guides/issues/events{/number}","events_url":"https://api.github.com/repos/slemrmartin/guides/events","assignees_url":"https://api.github.com/repos/slemrmartin/guides/assignees{/user}","branches_url":"https://api.github.com/repos/slemrmartin/guides/branches{/branch}","tags_url":"https://api.github.com/repos/slemrmartin/guides/tags","blobs_url":"https://api.github.com/repos/slemrmartin/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slemrmartin/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slemrmartin/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/slemrmartin/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slemrmartin/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/slemrmartin/guides/languages","stargazers_url":"https://api.github.com/repos/slemrmartin/guides/stargazers","contributors_url":"https://api.github.com/repos/slemrmartin/guides/contributors","subscribers_url":"https://api.github.com/repos/slemrmartin/guides/subscribers","subscription_url":"https://api.github.com/repos/slemrmartin/guides/subscription","commits_url":"https://api.github.com/repos/slemrmartin/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/slemrmartin/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/slemrmartin/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/slemrmartin/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/slemrmartin/guides/contents/{+path}","compare_url":"https://api.github.com/repos/slemrmartin/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slemrmartin/guides/merges","archive_url":"https://api.github.com/repos/slemrmartin/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slemrmartin/guides/downloads","issues_url":"https://api.github.com/repos/slemrmartin/guides/issues{/number}","pulls_url":"https://api.github.com/repos/slemrmartin/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/slemrmartin/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/slemrmartin/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slemrmartin/guides/labels{/name}","releases_url":"https://api.github.com/repos/slemrmartin/guides/releases{/id}","deployments_url":"https://api.github.com/repos/slemrmartin/guides/deployments","created_at":"2018-03-08T08:26:33Z","updated_at":"2018-03-08T08:26:35Z","pushed_at":"2018-06-19T10:30:40Z","git_url":"git://github.com/slemrmartin/guides.git","ssh_url":"git@github.com:slemrmartin/guides.git","clone_url":"https://github.com/slemrmartin/guides.git","svn_url":"https://github.com/slemrmartin/guides","homepage":"http://manageiq.org","size":1521,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"ad3da818887f5dde0280f232ad041a45a77d99f1","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":10948289,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0ODI4OQ==","name":"guides","full_name":"ManageIQ/guides","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/guides","description":"ManageIQ guides and developer documentation","fork":false,"url":"https://api.github.com/repos/ManageIQ/guides","forks_url":"https://api.github.com/repos/ManageIQ/guides/forks","keys_url":"https://api.github.com/repos/ManageIQ/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/guides/teams","hooks_url":"https://api.github.com/repos/ManageIQ/guides/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/guides/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/guides/events","assignees_url":"https://api.github.com/repos/ManageIQ/guides/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/guides/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/guides/tags","blobs_url":"https://api.github.com/repos/ManageIQ/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/guides/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/guides/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/guides/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/guides/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/guides/subscription","commits_url":"https://api.github.com/repos/ManageIQ/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/guides/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/guides/merges","archive_url":"https://api.github.com/repos/ManageIQ/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/guides/downloads","issues_url":"https://api.github.com/repos/ManageIQ/guides/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/guides/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/guides/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/guides/deployments","created_at":"2013-06-25T19:45:28Z","updated_at":"2018-06-19T20:05:38Z","pushed_at":"2018-06-19T11:25:08Z","git_url":"git://github.com/ManageIQ/guides.git","ssh_url":"git@github.com:ManageIQ/guides.git","clone_url":"https://github.com/ManageIQ/guides.git","svn_url":"https://github.com/ManageIQ/guides","homepage":"http://manageiq.org","size":1538,"stargazers_count":46,"watchers_count":46,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":114,"open_issues":20,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/316"},"html":{"href":"https://github.com/ManageIQ/guides/pull/316"},"issue":{"href":"https://api.github.com/repos/ManageIQ/guides/issues/316"},"comments":{"href":"https://api.github.com/repos/ManageIQ/guides/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/guides/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/guides/statuses/361224145632063b68a1c8f721e9b8a423f05f17"}},"author_association":"NONE"}}
{"actor":{"display_login":"agrare"}}