{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/comments/173867487","pull_request_review_id":103127243,"id":173867487,"diff_hunk":"@@ -28,10 +28,9 @@ func peerToPeerInfo(p *pb.CircuitRelay_Peer) (pstore.PeerInfo, error) {\n \taddrs := make([]ma.Multiaddr, len(p.Addrs))\n \tfor i := 0; i < len(addrs); i++ {\n \t\ta, err := ma.NewMultiaddrBytes(p.Addrs[i])\n-\t\tif err != nil {\n-\t\t\treturn pstore.PeerInfo{}, err\n+\t\tif err == nil {\n+\t\t\taddrs[i] = a","path":"util.go","position":7,"original_position":7,"commit_id":"0a039d0260063fc9bb4967dfb2cbc880e93ea1bd","original_commit_id":"0a039d0260063fc9bb4967dfb2cbc880e93ea1bd","user":{"login":"Stebalien","id":310393,"avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"body":"Good catch. I believe so but we still shouldn't do this.","created_at":"2018-03-12T16:49:05Z","updated_at":"2018-03-12T16:49:05Z","html_url":"https://github.com/libp2p/go-libp2p-circuit/pull/30#discussion_r173867487","pull_request_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/comments/173867487"},"html":{"href":"https://github.com/libp2p/go-libp2p-circuit/pull/30#discussion_r173867487"},"pull_request":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30"}},"in_reply_to_id":173844246},"pull_request":{"url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30","id":174235228,"html_url":"https://github.com/libp2p/go-libp2p-circuit/pull/30","diff_url":"https://github.com/libp2p/go-libp2p-circuit/pull/30.diff","patch_url":"https://github.com/libp2p/go-libp2p-circuit/pull/30.patch","issue_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/30","number":30,"state":"closed","locked":false,"title":"fix: dont error out on unknown addrs in peer info","user":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"body":"This PR tries to fix the `browser-browser-go` case reported in https://github.com/ipfs/interop/issues/16. The js circuit will send all the addrs it knows of the src and dst peers, but go will error out if it doesn't know one, since we have addrs that are valid only in some implementations, it causes this error. In this case, the websocket start addr was being sent (code 479).","created_at":"2018-03-11T18:36:37Z","updated_at":"2018-03-12T16:49:05Z","closed_at":"2018-03-11T20:17:37Z","merged_at":"2018-03-11T20:17:37Z","merge_commit_sha":"f5d03cbfd78da0bbdf0c84064c1162609747b5d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30/commits","review_comments_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30/comments","review_comment_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/30/comments","statuses_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/statuses/0a039d0260063fc9bb4967dfb2cbc880e93ea1bd","head":{"label":"dryajov:fix/parse-src-addrs","ref":"fix/parse-src-addrs","sha":"0a039d0260063fc9bb4967dfb2cbc880e93ea1bd","user":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"repo":{"id":86639537,"name":"go-libp2p-circuit","full_name":"dryajov/go-libp2p-circuit","owner":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dryajov/go-libp2p-circuit","description":"Circuit Switching for libp2p","fork":true,"url":"https://api.github.com/repos/dryajov/go-libp2p-circuit","forks_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/forks","keys_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/teams","hooks_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/hooks","issue_events_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/issues/events{/number}","events_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/events","assignees_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/assignees{/user}","branches_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/branches{/branch}","tags_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/tags","blobs_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/statuses/{sha}","languages_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/languages","stargazers_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/stargazers","contributors_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/contributors","subscribers_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/subscribers","subscription_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/subscription","commits_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/contents/{+path}","compare_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/merges","archive_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/downloads","issues_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/issues{/number}","pulls_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/pulls{/number}","milestones_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/milestones{/number}","notifications_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/labels{/name}","releases_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/releases{/id}","deployments_url":"https://api.github.com/repos/dryajov/go-libp2p-circuit/deployments","created_at":"2017-03-29T23:48:54Z","updated_at":"2017-03-29T23:48:56Z","pushed_at":"2018-03-11T19:25:29Z","git_url":"git://github.com/dryajov/go-libp2p-circuit.git","ssh_url":"git@github.com:dryajov/go-libp2p-circuit.git","clone_url":"https://github.com/dryajov/go-libp2p-circuit.git","svn_url":"https://github.com/dryajov/go-libp2p-circuit","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"6f62b1dea761a407e48e8ea32742e1b6a2a24deb","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":79306601,"name":"go-libp2p-circuit","full_name":"libp2p/go-libp2p-circuit","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/go-libp2p-circuit","description":"Circuit Switching for libp2p","fork":false,"url":"https://api.github.com/repos/libp2p/go-libp2p-circuit","forks_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/forks","keys_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/teams","hooks_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/hooks","issue_events_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/events","assignees_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/tags","blobs_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/languages","stargazers_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/stargazers","contributors_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/contributors","subscribers_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/subscribers","subscription_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/subscription","commits_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/merges","archive_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/downloads","issues_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/go-libp2p-circuit/deployments","created_at":"2017-01-18T05:26:21Z","updated_at":"2018-03-12T15:44:34Z","pushed_at":"2018-03-11T20:17:38Z","git_url":"git://github.com/libp2p/go-libp2p-circuit.git","ssh_url":"git@github.com:libp2p/go-libp2p-circuit.git","clone_url":"https://github.com/libp2p/go-libp2p-circuit.git","svn_url":"https://github.com/libp2p/go-libp2p-circuit","homepage":null,"size":69,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30"},"html":{"href":"https://github.com/libp2p/go-libp2p-circuit/pull/30"},"issue":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/30"},"comments":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/go-libp2p-circuit/statuses/0a039d0260063fc9bb4967dfb2cbc880e93ea1bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Stebalien"}}