{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hive/pulls/comments/224776307","pull_request_review_id":164231373,"id":224776307,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc3NjMwNw==","diff_hunk":"@@ -858,19 +859,65 @@ private void addNotificationLog(NotificationEvent event, ListenerEvent listenerE\n       long nextNLId = getNextNLId(stmt, sqlGenerator,\n               \"org.apache.hadoop.hive.metastore.model.MNotificationLog\");\n \n-      String insertVal = \"(\" + nextNLId + \",\" + nextEventId + \",\" + now() + \", ?, ?,\" +\n-              quoteString(\" \") + \",?, ?)\";\n+      String insertVal;\n+      String columns;\n+      List<String> params = new ArrayList<String>();\n+\n+      // Construct the values string, parameters and column string step by step simultaneously so\n+      // that the positions of columns and of their corresponding values do not go out of sync.\n+\n+      // Notification log id\n+      columns = \"\\\"NL_ID\\\"\";","path":"hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java","position":22,"original_position":22,"commit_id":"d3a319c5fd347018572c13b40e1e8f7cdbe72050","original_commit_id":"d3a319c5fd347018572c13b40e1e8f7cdbe72050","user":{"login":"sankarh","id":25001186,"node_id":"MDQ6VXNlcjI1MDAxMTg2","avatar_url":"https://avatars2.githubusercontent.com/u/25001186?v=4","gravatar_id":"","url":"https://api.github.com/users/sankarh","html_url":"https://github.com/sankarh","followers_url":"https://api.github.com/users/sankarh/followers","following_url":"https://api.github.com/users/sankarh/following{/other_user}","gists_url":"https://api.github.com/users/sankarh/gists{/gist_id}","starred_url":"https://api.github.com/users/sankarh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sankarh/subscriptions","organizations_url":"https://api.github.com/users/sankarh/orgs","repos_url":"https://api.github.com/users/sankarh/repos","events_url":"https://api.github.com/users/sankarh/events{/privacy}","received_events_url":"https://api.github.com/users/sankarh/received_events","type":"User","site_admin":false},"body":"Can combine all compulsory columns in one line instead of concatenating individually.","created_at":"2018-10-12T13:04:45Z","updated_at":"2018-10-12T13:20:11Z","html_url":"https://github.com/apache/hive/pull/445#discussion_r224776307","pull_request_url":"https://api.github.com/repos/apache/hive/pulls/445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/comments/224776307"},"html":{"href":"https://github.com/apache/hive/pull/445#discussion_r224776307"},"pull_request":{"href":"https://api.github.com/repos/apache/hive/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/apache/hive/pulls/445","id":222012489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDEyNDg5","html_url":"https://github.com/apache/hive/pull/445","diff_url":"https://github.com/apache/hive/pull/445.diff","patch_url":"https://github.com/apache/hive/pull/445.patch","issue_url":"https://api.github.com/repos/apache/hive/issues/445","number":445,"state":"open","locked":false,"title":"HIVE-20542","user":{"login":"ashutosh-bapat","id":39807482,"node_id":"MDQ6VXNlcjM5ODA3NDgy","avatar_url":"https://avatars2.githubusercontent.com/u/39807482?v=4","gravatar_id":"","url":"https://api.github.com/users/ashutosh-bapat","html_url":"https://github.com/ashutosh-bapat","followers_url":"https://api.github.com/users/ashutosh-bapat/followers","following_url":"https://api.github.com/users/ashutosh-bapat/following{/other_user}","gists_url":"https://api.github.com/users/ashutosh-bapat/gists{/gist_id}","starred_url":"https://api.github.com/users/ashutosh-bapat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashutosh-bapat/subscriptions","organizations_url":"https://api.github.com/users/ashutosh-bapat/orgs","repos_url":"https://api.github.com/users/ashutosh-bapat/repos","events_url":"https://api.github.com/users/ashutosh-bapat/events{/privacy}","received_events_url":"https://api.github.com/users/ashutosh-bapat/received_events","type":"User","site_admin":false},"body":"Changes for HIVE-20542. There are three separate commits, with each commit message explaining purpose of that commit. They all should be pulled together as a single commit into Apache hive repository. ","created_at":"2018-10-11T05:42:33Z","updated_at":"2018-10-12T13:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e70ee07bcca9fc6ba1f9084bad39a2d23d59de06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hive/pulls/445/commits","review_comments_url":"https://api.github.com/repos/apache/hive/pulls/445/comments","review_comment_url":"https://api.github.com/repos/apache/hive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hive/issues/445/comments","statuses_url":"https://api.github.com/repos/apache/hive/statuses/d3a319c5fd347018572c13b40e1e8f7cdbe72050","head":{"label":"ashutosh-bapat:hive20542","ref":"hive20542","sha":"d3a319c5fd347018572c13b40e1e8f7cdbe72050","user":{"login":"ashutosh-bapat","id":39807482,"node_id":"MDQ6VXNlcjM5ODA3NDgy","avatar_url":"https://avatars2.githubusercontent.com/u/39807482?v=4","gravatar_id":"","url":"https://api.github.com/users/ashutosh-bapat","html_url":"https://github.com/ashutosh-bapat","followers_url":"https://api.github.com/users/ashutosh-bapat/followers","following_url":"https://api.github.com/users/ashutosh-bapat/following{/other_user}","gists_url":"https://api.github.com/users/ashutosh-bapat/gists{/gist_id}","starred_url":"https://api.github.com/users/ashutosh-bapat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashutosh-bapat/subscriptions","organizations_url":"https://api.github.com/users/ashutosh-bapat/orgs","repos_url":"https://api.github.com/users/ashutosh-bapat/repos","events_url":"https://api.github.com/users/ashutosh-bapat/events{/privacy}","received_events_url":"https://api.github.com/users/ashutosh-bapat/received_events","type":"User","site_admin":false},"repo":{"id":150566502,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1NjY1MDI=","name":"hive","full_name":"ashutosh-bapat/hive","private":false,"owner":{"login":"ashutosh-bapat","id":39807482,"node_id":"MDQ6VXNlcjM5ODA3NDgy","avatar_url":"https://avatars2.githubusercontent.com/u/39807482?v=4","gravatar_id":"","url":"https://api.github.com/users/ashutosh-bapat","html_url":"https://github.com/ashutosh-bapat","followers_url":"https://api.github.com/users/ashutosh-bapat/followers","following_url":"https://api.github.com/users/ashutosh-bapat/following{/other_user}","gists_url":"https://api.github.com/users/ashutosh-bapat/gists{/gist_id}","starred_url":"https://api.github.com/users/ashutosh-bapat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashutosh-bapat/subscriptions","organizations_url":"https://api.github.com/users/ashutosh-bapat/orgs","repos_url":"https://api.github.com/users/ashutosh-bapat/repos","events_url":"https://api.github.com/users/ashutosh-bapat/events{/privacy}","received_events_url":"https://api.github.com/users/ashutosh-bapat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashutosh-bapat/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/ashutosh-bapat/hive","forks_url":"https://api.github.com/repos/ashutosh-bapat/hive/forks","keys_url":"https://api.github.com/repos/ashutosh-bapat/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashutosh-bapat/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashutosh-bapat/hive/teams","hooks_url":"https://api.github.com/repos/ashutosh-bapat/hive/hooks","issue_events_url":"https://api.github.com/repos/ashutosh-bapat/hive/issues/events{/number}","events_url":"https://api.github.com/repos/ashutosh-bapat/hive/events","assignees_url":"https://api.github.com/repos/ashutosh-bapat/hive/assignees{/user}","branches_url":"https://api.github.com/repos/ashutosh-bapat/hive/branches{/branch}","tags_url":"https://api.github.com/repos/ashutosh-bapat/hive/tags","blobs_url":"https://api.github.com/repos/ashutosh-bapat/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashutosh-bapat/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashutosh-bapat/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashutosh-bapat/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashutosh-bapat/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/ashutosh-bapat/hive/languages","stargazers_url":"https://api.github.com/repos/ashutosh-bapat/hive/stargazers","contributors_url":"https://api.github.com/repos/ashutosh-bapat/hive/contributors","subscribers_url":"https://api.github.com/repos/ashutosh-bapat/hive/subscribers","subscription_url":"https://api.github.com/repos/ashutosh-bapat/hive/subscription","commits_url":"https://api.github.com/repos/ashutosh-bapat/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashutosh-bapat/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashutosh-bapat/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashutosh-bapat/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashutosh-bapat/hive/contents/{+path}","compare_url":"https://api.github.com/repos/ashutosh-bapat/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashutosh-bapat/hive/merges","archive_url":"https://api.github.com/repos/ashutosh-bapat/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashutosh-bapat/hive/downloads","issues_url":"https://api.github.com/repos/ashutosh-bapat/hive/issues{/number}","pulls_url":"https://api.github.com/repos/ashutosh-bapat/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/ashutosh-bapat/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/ashutosh-bapat/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashutosh-bapat/hive/labels{/name}","releases_url":"https://api.github.com/repos/ashutosh-bapat/hive/releases{/id}","deployments_url":"https://api.github.com/repos/ashutosh-bapat/hive/deployments","created_at":"2018-09-27T10:01:18Z","updated_at":"2018-09-28T05:25:43Z","pushed_at":"2018-10-11T05:20:07Z","git_url":"git://github.com/ashutosh-bapat/hive.git","ssh_url":"git@github.com:ashutosh-bapat/hive.git","clone_url":"https://github.com/ashutosh-bapat/hive.git","svn_url":"https://github.com/ashutosh-bapat/hive","homepage":null,"size":431478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"37c7fd7833eba087eadd8048dbc63b403b272104","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206444,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0NDQ=","name":"hive","full_name":"apache/hive","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/hive","description":"Mirror of Apache Hive","fork":false,"url":"https://api.github.com/repos/apache/hive","forks_url":"https://api.github.com/repos/apache/hive/forks","keys_url":"https://api.github.com/repos/apache/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hive/teams","hooks_url":"https://api.github.com/repos/apache/hive/hooks","issue_events_url":"https://api.github.com/repos/apache/hive/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hive/events","assignees_url":"https://api.github.com/repos/apache/hive/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hive/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hive/tags","blobs_url":"https://api.github.com/repos/apache/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hive/languages","stargazers_url":"https://api.github.com/repos/apache/hive/stargazers","contributors_url":"https://api.github.com/repos/apache/hive/contributors","subscribers_url":"https://api.github.com/repos/apache/hive/subscribers","subscription_url":"https://api.github.com/repos/apache/hive/subscription","commits_url":"https://api.github.com/repos/apache/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hive/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hive/merges","archive_url":"https://api.github.com/repos/apache/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hive/downloads","issues_url":"https://api.github.com/repos/apache/hive/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hive/labels{/name}","releases_url":"https://api.github.com/repos/apache/hive/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hive/deployments","created_at":"2009-05-21T02:31:01Z","updated_at":"2018-10-12T12:29:06Z","pushed_at":"2018-10-12T12:28:36Z","git_url":"git://github.com/apache/hive.git","ssh_url":"git@github.com:apache/hive.git","clone_url":"https://github.com/apache/hive.git","svn_url":"https://github.com/apache/hive","homepage":null,"size":448121,"stargazers_count":2149,"watchers_count":2149,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2177,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2177,"open_issues":190,"watchers":2149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/445"},"html":{"href":"https://github.com/apache/hive/pull/445"},"issue":{"href":"https://api.github.com/repos/apache/hive/issues/445"},"comments":{"href":"https://api.github.com/repos/apache/hive/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hive/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hive/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hive/statuses/d3a319c5fd347018572c13b40e1e8f7cdbe72050"}},"author_association":"NONE"}}
{"actor":{"display_login":"sankarh"}}