{"action":"closed","number":14451,"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/14451","id":193901827,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTAxODI3","html_url":"https://github.com/frappe/erpnext/pull/14451","diff_url":"https://github.com/frappe/erpnext/pull/14451.diff","patch_url":"https://github.com/frappe/erpnext/pull/14451.patch","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/14451","number":14451,"state":"closed","locked":false,"title":"Add cost center from Journal Entry","user":{"login":"shreyashah115","id":17617465,"node_id":"MDQ6VXNlcjE3NjE3NDY1","avatar_url":"https://avatars3.githubusercontent.com/u/17617465?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyashah115","html_url":"https://github.com/shreyashah115","followers_url":"https://api.github.com/users/shreyashah115/followers","following_url":"https://api.github.com/users/shreyashah115/following{/other_user}","gists_url":"https://api.github.com/users/shreyashah115/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyashah115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyashah115/subscriptions","organizations_url":"https://api.github.com/users/shreyashah115/orgs","repos_url":"https://api.github.com/users/shreyashah115/repos","events_url":"https://api.github.com/users/shreyashah115/events{/privacy}","received_events_url":"https://api.github.com/users/shreyashah115/received_events","type":"User","site_admin":false},"body":"On submitting a Journal Entry, while GL entry creation, it makes `cost_center = None` and hence its not visible in the GL Report. \r\n\r\nPull-Request\r\n\r\n- [x] Have you followed the guidelines in our Contributing document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?\r\n- [x] Have you lint your code locally prior to submission?\r\n- [x] Have you successfully run tests with your changes locally?\r\n- [x] Does your commit message have an explanation for your changes and why you'd like us to include them?\r\n- [ ] Docs have been added / updated\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Did you modify the existing test cases? If yes, why?\r\n\r\n---\r\n\r\nWhat type of a PR is this? \r\n\r\n- [x] Changes to Existing Features\r\n- [ ] New Feature Submissions\r\n- [x] Bug Fix\r\n- [ ] Breaking Change\r\n\r\n--- \r\n\r\n- Motivation and Context (What existing problem does the pull request solve):\r\n- Related Issue: \r\n- Screenshots (if applicable, remember, a picture tells a thousand words): \r\n\r\n**Please don't be intimidated by the long list of options you've to fill. Try to fill out as much as you can. Remember, the more the information the easier it is for us to test and get your pull request merged** :grin: \r\n\r\n","created_at":"2018-06-11T08:03:19Z","updated_at":"2018-06-11T12:10:17Z","closed_at":"2018-06-11T12:10:17Z","merged_at":null,"merge_commit_sha":"11eedc32f75a2f5b730f725f7d2c28cb1373d97d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":482548201,"node_id":"MDU6TGFiZWw0ODI1NDgyMDE=","url":"https://api.github.com/repos/frappe/erpnext/labels/hotfix","name":"hotfix","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/erpnext/pulls/14451/commits","review_comments_url":"https://api.github.com/repos/frappe/erpnext/pulls/14451/comments","review_comment_url":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/14451/comments","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/f23e55f3eb60ed48ef45bc9757caf6558327bba4","head":{"label":"shreyashah115:add-cost-center","ref":"add-cost-center","sha":"f23e55f3eb60ed48ef45bc9757caf6558327bba4","user":{"login":"shreyashah115","id":17617465,"node_id":"MDQ6VXNlcjE3NjE3NDY1","avatar_url":"https://avatars3.githubusercontent.com/u/17617465?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyashah115","html_url":"https://github.com/shreyashah115","followers_url":"https://api.github.com/users/shreyashah115/followers","following_url":"https://api.github.com/users/shreyashah115/following{/other_user}","gists_url":"https://api.github.com/users/shreyashah115/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyashah115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyashah115/subscriptions","organizations_url":"https://api.github.com/users/shreyashah115/orgs","repos_url":"https://api.github.com/users/shreyashah115/repos","events_url":"https://api.github.com/users/shreyashah115/events{/privacy}","received_events_url":"https://api.github.com/users/shreyashah115/received_events","type":"User","site_admin":false},"repo":{"id":98530371,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUzMDM3MQ==","name":"erpnext","full_name":"shreyashah115/erpnext","owner":{"login":"shreyashah115","id":17617465,"node_id":"MDQ6VXNlcjE3NjE3NDY1","avatar_url":"https://avatars3.githubusercontent.com/u/17617465?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyashah115","html_url":"https://github.com/shreyashah115","followers_url":"https://api.github.com/users/shreyashah115/followers","following_url":"https://api.github.com/users/shreyashah115/following{/other_user}","gists_url":"https://api.github.com/users/shreyashah115/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyashah115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyashah115/subscriptions","organizations_url":"https://api.github.com/users/shreyashah115/orgs","repos_url":"https://api.github.com/users/shreyashah115/repos","events_url":"https://api.github.com/users/shreyashah115/events{/privacy}","received_events_url":"https://api.github.com/users/shreyashah115/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shreyashah115/erpnext","description":"Business Made Simple","fork":true,"url":"https://api.github.com/repos/shreyashah115/erpnext","forks_url":"https://api.github.com/repos/shreyashah115/erpnext/forks","keys_url":"https://api.github.com/repos/shreyashah115/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shreyashah115/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shreyashah115/erpnext/teams","hooks_url":"https://api.github.com/repos/shreyashah115/erpnext/hooks","issue_events_url":"https://api.github.com/repos/shreyashah115/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/shreyashah115/erpnext/events","assignees_url":"https://api.github.com/repos/shreyashah115/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/shreyashah115/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/shreyashah115/erpnext/tags","blobs_url":"https://api.github.com/repos/shreyashah115/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shreyashah115/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shreyashah115/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/shreyashah115/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shreyashah115/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/shreyashah115/erpnext/languages","stargazers_url":"https://api.github.com/repos/shreyashah115/erpnext/stargazers","contributors_url":"https://api.github.com/repos/shreyashah115/erpnext/contributors","subscribers_url":"https://api.github.com/repos/shreyashah115/erpnext/subscribers","subscription_url":"https://api.github.com/repos/shreyashah115/erpnext/subscription","commits_url":"https://api.github.com/repos/shreyashah115/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/shreyashah115/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/shreyashah115/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/shreyashah115/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/shreyashah115/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/shreyashah115/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shreyashah115/erpnext/merges","archive_url":"https://api.github.com/repos/shreyashah115/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shreyashah115/erpnext/downloads","issues_url":"https://api.github.com/repos/shreyashah115/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/shreyashah115/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/shreyashah115/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/shreyashah115/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shreyashah115/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/shreyashah115/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/shreyashah115/erpnext/deployments","created_at":"2017-07-27T11:57:37Z","updated_at":"2018-05-16T06:36:59Z","pushed_at":"2018-06-11T10:10:23Z","git_url":"git://github.com/shreyashah115/erpnext.git","ssh_url":"git@github.com:shreyashah115/erpnext.git","clone_url":"https://github.com/shreyashah115/erpnext.git","svn_url":"https://github.com/shreyashah115/erpnext","homepage":"http://erpnext.com","size":591683,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:hotfix","ref":"hotfix","sha":"b9399d878196f1f71d5fe49e190a9111bf29c899","user":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864233,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MjMz","name":"erpnext","full_name":"frappe/erpnext","owner":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/erpnext","description":"Open Source ERP built for the web","fork":false,"url":"https://api.github.com/repos/frappe/erpnext","forks_url":"https://api.github.com/repos/frappe/erpnext/forks","keys_url":"https://api.github.com/repos/frappe/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/erpnext/teams","hooks_url":"https://api.github.com/repos/frappe/erpnext/hooks","issue_events_url":"https://api.github.com/repos/frappe/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/erpnext/events","assignees_url":"https://api.github.com/repos/frappe/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/erpnext/tags","blobs_url":"https://api.github.com/repos/frappe/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/erpnext/languages","stargazers_url":"https://api.github.com/repos/frappe/erpnext/stargazers","contributors_url":"https://api.github.com/repos/frappe/erpnext/contributors","subscribers_url":"https://api.github.com/repos/frappe/erpnext/subscribers","subscription_url":"https://api.github.com/repos/frappe/erpnext/subscription","commits_url":"https://api.github.com/repos/frappe/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/erpnext/merges","archive_url":"https://api.github.com/repos/frappe/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/erpnext/downloads","issues_url":"https://api.github.com/repos/frappe/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/frappe/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/erpnext/deployments","created_at":"2011-06-08T08:20:56Z","updated_at":"2018-06-11T12:02:25Z","pushed_at":"2018-06-11T12:09:52Z","git_url":"git://github.com/frappe/erpnext.git","ssh_url":"git@github.com:frappe/erpnext.git","clone_url":"https://github.com/frappe/erpnext.git","svn_url":"https://github.com/frappe/erpnext","homepage":"http://erpnext.com","size":592238,"stargazers_count":3169,"watchers_count":3169,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1605,"mirror_url":null,"archived":false,"open_issues_count":1542,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1605,"open_issues":1542,"watchers":3169,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14451"},"html":{"href":"https://github.com/frappe/erpnext/pull/14451"},"issue":{"href":"https://api.github.com/repos/frappe/erpnext/issues/14451"},"comments":{"href":"https://api.github.com/repos/frappe/erpnext/issues/14451/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14451/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14451/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/erpnext/statuses/f23e55f3eb60ed48ef45bc9757caf6558327bba4"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"shreyashah115"}}