{"action":"created","issue":{"url":"https://api.github.com/repos/OpenFeign/feign/issues/675","repository_url":"https://api.github.com/repos/OpenFeign/feign","labels_url":"https://api.github.com/repos/OpenFeign/feign/issues/675/labels{/name}","comments_url":"https://api.github.com/repos/OpenFeign/feign/issues/675/comments","events_url":"https://api.github.com/repos/OpenFeign/feign/issues/675/events","html_url":"https://github.com/OpenFeign/feign/issues/675","id":312102946,"node_id":"MDU6SXNzdWUzMTIxMDI5NDY=","number":675,"title":"RequestTemplate.encodeIfNotVariable needs improvement.","user":{"login":"omi2012","id":19717818,"node_id":"MDQ6VXNlcjE5NzE3ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/19717818?v=4","gravatar_id":"","url":"https://api.github.com/users/omi2012","html_url":"https://github.com/omi2012","followers_url":"https://api.github.com/users/omi2012/followers","following_url":"https://api.github.com/users/omi2012/following{/other_user}","gists_url":"https://api.github.com/users/omi2012/gists{/gist_id}","starred_url":"https://api.github.com/users/omi2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omi2012/subscriptions","organizations_url":"https://api.github.com/users/omi2012/orgs","repos_url":"https://api.github.com/users/omi2012/repos","events_url":"https://api.github.com/users/omi2012/events{/privacy}","received_events_url":"https://api.github.com/users/omi2012/received_events","type":"User","site_admin":false},"labels":[{"id":1005079866,"node_id":"MDU6TGFiZWwxMDA1MDc5ODY2","url":"https://api.github.com/repos/OpenFeign/feign/labels/documentation","name":"documentation","color":"bfdadc","default":false},{"id":1000677337,"node_id":"MDU6TGFiZWwxMDAwNjc3MzM3","url":"https://api.github.com/repos/OpenFeign/feign/labels/help%20wanted","name":"help wanted","color":"76c442","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-06T20:12:46Z","updated_at":"2018-07-26T01:46:39Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nSubstitution of parameter doesn't work when the parameter is preceded by text.\r\n\r\n\r\n```\r\n@RequestLine(\"GET \"+BASEURI+\"endpoint?param=sometext{paramname}\")\r\n Returntype myQuery(@Param(\"paramname\") String paramname)\r\n```\r\n\r\nas { would not be the first char, see\r\n\r\n```\r\n private static String encodeIfNotVariable(String in) {\r\n\r\n    if (in == null || in.indexOf('{') == 0) {\r\n\r\n      return in;\r\n\r\n    }\r\n\r\n    return urlEncode(in);\r\n\r\n  }\r\n```\r\n\r\nThe {paramname} would get encoded into %7Bparamname%7D, which would not get replaced further up in the code."},"comment":{"url":"https://api.github.com/repos/OpenFeign/feign/issues/comments/407949713","html_url":"https://github.com/OpenFeign/feign/issues/675#issuecomment-407949713","issue_url":"https://api.github.com/repos/OpenFeign/feign/issues/675","id":407949713,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzk0OTcxMw==","user":{"login":"omi2012","id":19717818,"node_id":"MDQ6VXNlcjE5NzE3ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/19717818?v=4","gravatar_id":"","url":"https://api.github.com/users/omi2012","html_url":"https://github.com/omi2012","followers_url":"https://api.github.com/users/omi2012/followers","following_url":"https://api.github.com/users/omi2012/following{/other_user}","gists_url":"https://api.github.com/users/omi2012/gists{/gist_id}","starred_url":"https://api.github.com/users/omi2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omi2012/subscriptions","organizations_url":"https://api.github.com/users/omi2012/orgs","repos_url":"https://api.github.com/users/omi2012/repos","events_url":"https://api.github.com/users/omi2012/events{/privacy}","received_events_url":"https://api.github.com/users/omi2012/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T01:46:39Z","updated_at":"2018-07-26T01:46:39Z","author_association":"NONE","body":"We use Infoblox. One of it's API requests for lookup of networks uses\nparam~=value\nFrom cursory look at OpenFeign code, there is some tokenization happening\non key=value which gets disassembled t hen reassembled. If that can be\navoided, then such lookups would work.\n\nOn Wed, Jul 25, 2018 at 8:20 PM, Kevin Davis <notifications@github.com>\nwrote:\n\n> I think this could be better solved by updating the documentation to\n> indicate that our URI template handling is very simple and only supports\n> simple string replacement and is not the same as doing a regular expression\n> match and replace.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/OpenFeign/feign/issues/675#issuecomment-407936767>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ASzeutTtJJ2h7ActZ5fHSeBvbQiQhKPXks5uKQtbgaJpZM4TKpAN>\n> .\n>\n\n\n\n-- \nBest regards,\n\nOleg Mitsura\nomitsura@gmail.com\n"}}
{"actor":{"display_login":"omi2012"}}