{"action":"created","comment":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/comments/166772093","pull_request_review_id":94888935,"id":166772093,"diff_hunk":"@@ -0,0 +1,54 @@\n+import { Component, OnInit, Input, Inject } from '@angular/core';\n+import { trigger, state, style, transition, animate } from '@angular/animations';\n+import { IconModule } from '../../icon/icon.module';\n+import { IAppSwitcherService, IDiscoveryApplication } from '../../app-switcher/app-switcher-interfaces';\n+import { Subscription } from 'rxjs/Subscription';\n+import { Subject } from 'rxjs/Subject';\n+\n+@Component({\n+    selector: 'hc-navbar-menu',\n+    templateUrl: './navbar-menu.component.html',\n+    styleUrls: ['./navbar-menu.component.scss'],\n+    animations: [\n+        trigger('slideInOut', [\n+            state('in', style({\n+                transform: 'translate3d(0, -100%, 0)'\n+            })),\n+            state('out', style({\n+                transform: 'translate3d(0, 0, 0)'\n+            })),\n+            transition('in => out', animate('400ms ease-in-out')),","path":"lib/src/navbar/navbar-menu/navbar-menu.component.ts","position":20,"original_position":20,"commit_id":"9a3b802d71c785b3e794129701f6f128195668d0","original_commit_id":"9a3b802d71c785b3e794129701f6f128195668d0","user":{"login":"corytak","id":9749465,"avatar_url":"https://avatars2.githubusercontent.com/u/9749465?v=4","gravatar_id":"","url":"https://api.github.com/users/corytak","html_url":"https://github.com/corytak","followers_url":"https://api.github.com/users/corytak/followers","following_url":"https://api.github.com/users/corytak/following{/other_user}","gists_url":"https://api.github.com/users/corytak/gists{/gist_id}","starred_url":"https://api.github.com/users/corytak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corytak/subscriptions","organizations_url":"https://api.github.com/users/corytak/orgs","repos_url":"https://api.github.com/users/corytak/repos","events_url":"https://api.github.com/users/corytak/events{/privacy}","received_events_url":"https://api.github.com/users/corytak/received_events","type":"User","site_admin":false},"body":"Look at these fancy angular animations. Bravo. :) ","created_at":"2018-02-07T22:09:12Z","updated_at":"2018-02-07T22:16:22Z","html_url":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106#discussion_r166772093","pull_request_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/comments/166772093"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106#discussion_r166772093"},"pull_request":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106","id":167818467,"html_url":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106","diff_url":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106.diff","patch_url":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106.patch","issue_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/106","number":106,"state":"open","locked":false,"title":"Responsive Navbar","user":{"login":"andrew-frueh","id":22795893,"avatar_url":"https://avatars3.githubusercontent.com/u/22795893?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-frueh","html_url":"https://github.com/andrew-frueh","followers_url":"https://api.github.com/users/andrew-frueh/followers","following_url":"https://api.github.com/users/andrew-frueh/following{/other_user}","gists_url":"https://api.github.com/users/andrew-frueh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-frueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-frueh/subscriptions","organizations_url":"https://api.github.com/users/andrew-frueh/orgs","repos_url":"https://api.github.com/users/andrew-frueh/repos","events_url":"https://api.github.com/users/andrew-frueh/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-frueh/received_events","type":"User","site_admin":false},"body":"Phew, this one pushed me a bit - but many thanks to @benjanderson for helping me think my approach through.  Resolves #94.  The documentation page has also been updated to explain usage.  For the hamburger menu that drops down on smaller screens, we talked it through and it seemed best to give the developer the flexibility of deciding what they do/don't want in that menu.  For example, they might have hc-icons with popover content that needs to be spelled out in the menu, or they want want to leave items off when being viewed on small screens, etc.  For the content of the responsive menu, I'm making use of @jtrujill's hc-list component, which also gives developers plenty of options on formatting their menu rows.\r\n\r\nTwo open items for discussion beyond this pull request:\r\n- There are two included media queries for tablet (740px) and phone sizes (420px).  These are hard coded, but for apps with lots of navbar links they might want to flip to the hamburger menu sooner.  So we should discuss if/how we allow the developer to specify their responsive steps.\r\n- @benjanderson it wasn't immediately obvious to me how to disable the tri-flame button when we go to tablet size.  As we discussed in the issue thread, once we go mobile, we only want one menu with everything.  But until we get down to mobile size, I still like the tri-flame as a design element, but we just need to disable it as soon as that 740px media query kicks in.","created_at":"2018-02-07T21:49:00Z","updated_at":"2018-02-07T22:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61d2e08e436a477be89802acd0f9f8d1e206cff0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjanderson","id":1934453,"avatar_url":"https://avatars2.githubusercontent.com/u/1934453?v=4","gravatar_id":"","url":"https://api.github.com/users/benjanderson","html_url":"https://github.com/benjanderson","followers_url":"https://api.github.com/users/benjanderson/followers","following_url":"https://api.github.com/users/benjanderson/following{/other_user}","gists_url":"https://api.github.com/users/benjanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/benjanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjanderson/subscriptions","organizations_url":"https://api.github.com/users/benjanderson/orgs","repos_url":"https://api.github.com/users/benjanderson/repos","events_url":"https://api.github.com/users/benjanderson/events{/privacy}","received_events_url":"https://api.github.com/users/benjanderson/received_events","type":"User","site_admin":false},{"login":"corykon","id":12416432,"avatar_url":"https://avatars1.githubusercontent.com/u/12416432?v=4","gravatar_id":"","url":"https://api.github.com/users/corykon","html_url":"https://github.com/corykon","followers_url":"https://api.github.com/users/corykon/followers","following_url":"https://api.github.com/users/corykon/following{/other_user}","gists_url":"https://api.github.com/users/corykon/gists{/gist_id}","starred_url":"https://api.github.com/users/corykon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corykon/subscriptions","organizations_url":"https://api.github.com/users/corykon/orgs","repos_url":"https://api.github.com/users/corykon/repos","events_url":"https://api.github.com/users/corykon/events{/privacy}","received_events_url":"https://api.github.com/users/corykon/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106/commits","review_comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106/comments","review_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/106/comments","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/statuses/9a3b802d71c785b3e794129701f6f128195668d0","head":{"label":"andrew-frueh:responsive","ref":"responsive","sha":"9a3b802d71c785b3e794129701f6f128195668d0","user":{"login":"andrew-frueh","id":22795893,"avatar_url":"https://avatars3.githubusercontent.com/u/22795893?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-frueh","html_url":"https://github.com/andrew-frueh","followers_url":"https://api.github.com/users/andrew-frueh/followers","following_url":"https://api.github.com/users/andrew-frueh/following{/other_user}","gists_url":"https://api.github.com/users/andrew-frueh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-frueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-frueh/subscriptions","organizations_url":"https://api.github.com/users/andrew-frueh/orgs","repos_url":"https://api.github.com/users/andrew-frueh/repos","events_url":"https://api.github.com/users/andrew-frueh/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-frueh/received_events","type":"User","site_admin":false},"repo":{"id":117884853,"name":"Fabric.Cashmere","full_name":"andrew-frueh/Fabric.Cashmere","owner":{"login":"andrew-frueh","id":22795893,"avatar_url":"https://avatars3.githubusercontent.com/u/22795893?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-frueh","html_url":"https://github.com/andrew-frueh","followers_url":"https://api.github.com/users/andrew-frueh/followers","following_url":"https://api.github.com/users/andrew-frueh/following{/other_user}","gists_url":"https://api.github.com/users/andrew-frueh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-frueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-frueh/subscriptions","organizations_url":"https://api.github.com/users/andrew-frueh/orgs","repos_url":"https://api.github.com/users/andrew-frueh/repos","events_url":"https://api.github.com/users/andrew-frueh/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-frueh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrew-frueh/Fabric.Cashmere","description":null,"fork":true,"url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere","forks_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/forks","keys_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/teams","hooks_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/hooks","issue_events_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/issues/events{/number}","events_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/events","assignees_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/assignees{/user}","branches_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/branches{/branch}","tags_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/tags","blobs_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/statuses/{sha}","languages_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/languages","stargazers_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/stargazers","contributors_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/contributors","subscribers_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/subscribers","subscription_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/subscription","commits_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/contents/{+path}","compare_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/merges","archive_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/downloads","issues_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/issues{/number}","pulls_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/pulls{/number}","milestones_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/milestones{/number}","notifications_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/labels{/name}","releases_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/releases{/id}","deployments_url":"https://api.github.com/repos/andrew-frueh/Fabric.Cashmere/deployments","created_at":"2018-01-17T19:48:09Z","updated_at":"2018-01-17T19:48:11Z","pushed_at":"2018-02-07T21:33:20Z","git_url":"git://github.com/andrew-frueh/Fabric.Cashmere.git","ssh_url":"git@github.com:andrew-frueh/Fabric.Cashmere.git","clone_url":"https://github.com/andrew-frueh/Fabric.Cashmere.git","svn_url":"https://github.com/andrew-frueh/Fabric.Cashmere","homepage":null,"size":1088,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HealthCatalyst:master","ref":"master","sha":"8f157c824bf8d445df1364d4e6273c58b0f5d50f","user":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":113457211,"name":"Fabric.Cashmere","full_name":"HealthCatalyst/Fabric.Cashmere","owner":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalyst/Fabric.Cashmere","description":"Health Catalyst's living style guide for Angular","fork":false,"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere","forks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/forks","keys_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/teams","hooks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/events","assignees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/tags","blobs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/languages","stargazers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/subscription","commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/merges","archive_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/downloads","issues_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/deployments","created_at":"2017-12-07T13:57:28Z","updated_at":"2018-02-06T16:57:40Z","pushed_at":"2018-02-07T21:49:01Z","git_url":"git://github.com/HealthCatalyst/Fabric.Cashmere.git","ssh_url":"git@github.com:HealthCatalyst/Fabric.Cashmere.git","clone_url":"https://github.com/HealthCatalyst/Fabric.Cashmere.git","svn_url":"https://github.com/HealthCatalyst/Fabric.Cashmere","homepage":"http://cashmere.azurewebsites.net","size":1091,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":31,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Cashmere/pull/106"},"issue":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/106"},"comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Cashmere/statuses/9a3b802d71c785b3e794129701f6f128195668d0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"corytak"}}