{"action":"created","issue":{"url":"https://api.github.com/repos/mratsim/Arraymancer/issues/246","repository_url":"https://api.github.com/repos/mratsim/Arraymancer","labels_url":"https://api.github.com/repos/mratsim/Arraymancer/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/mratsim/Arraymancer/issues/246/comments","events_url":"https://api.github.com/repos/mratsim/Arraymancer/issues/246/events","html_url":"https://github.com/mratsim/Arraymancer/pull/246","id":331396164,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTM3ODQy","number":246,"title":"Add a transform boolean parameter to pca; update unit test.","user":{"login":"metasyn","id":1719730,"node_id":"MDQ6VXNlcjE3MTk3MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1719730?v=4","gravatar_id":"","url":"https://api.github.com/users/metasyn","html_url":"https://github.com/metasyn","followers_url":"https://api.github.com/users/metasyn/followers","following_url":"https://api.github.com/users/metasyn/following{/other_user}","gists_url":"https://api.github.com/users/metasyn/gists{/gist_id}","starred_url":"https://api.github.com/users/metasyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasyn/subscriptions","organizations_url":"https://api.github.com/users/metasyn/orgs","repos_url":"https://api.github.com/users/metasyn/repos","events_url":"https://api.github.com/users/metasyn/events{/privacy}","received_events_url":"https://api.github.com/users/metasyn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-12T00:32:19Z","updated_at":"2018-06-12T08:06:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mratsim/Arraymancer/pulls/246","html_url":"https://github.com/mratsim/Arraymancer/pull/246","diff_url":"https://github.com/mratsim/Arraymancer/pull/246.diff","patch_url":"https://github.com/mratsim/Arraymancer/pull/246.patch"},"body":"Add a simple boolean parameter to the pca proc, so that users can get the principal components in addition to transforming the input data.\r\n\r\nI updated the unit tests as well.\r\n\r\n@mratsim Originally you suggested `static[bool]` - which I can still try to add if you want? I was not sure how to call the method appropriately with that signature, in the test. "},"comment":{"url":"https://api.github.com/repos/mratsim/Arraymancer/issues/comments/396503236","html_url":"https://github.com/mratsim/Arraymancer/pull/246#issuecomment-396503236","issue_url":"https://api.github.com/repos/mratsim/Arraymancer/issues/246","id":396503236,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjUwMzIzNg==","user":{"login":"bluenote10","id":3620703,"node_id":"MDQ6VXNlcjM2MjA3MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/3620703?v=4","gravatar_id":"","url":"https://api.github.com/users/bluenote10","html_url":"https://github.com/bluenote10","followers_url":"https://api.github.com/users/bluenote10/followers","following_url":"https://api.github.com/users/bluenote10/following{/other_user}","gists_url":"https://api.github.com/users/bluenote10/gists{/gist_id}","starred_url":"https://api.github.com/users/bluenote10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluenote10/subscriptions","organizations_url":"https://api.github.com/users/bluenote10/orgs","repos_url":"https://api.github.com/users/bluenote10/repos","events_url":"https://api.github.com/users/bluenote10/events{/privacy}","received_events_url":"https://api.github.com/users/bluenote10/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T08:06:24Z","updated_at":"2018-06-12T08:06:24Z","author_association":"CONTRIBUTOR","body":"In my opinion an API that changes the semantics of the return value depending on a switch is always a bit confusing. Why not return both and let the user decide what to use/discard?"}}
{"actor":{"display_login":"bluenote10"}}