{"action":"created","issue":{"url":"https://api.github.com/repos/FRRouting/frr/issues/1817","repository_url":"https://api.github.com/repos/FRRouting/frr","labels_url":"https://api.github.com/repos/FRRouting/frr/issues/1817/labels{/name}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/1817/comments","events_url":"https://api.github.com/repos/FRRouting/frr/issues/1817/events","html_url":"https://github.com/FRRouting/frr/pull/1817","id":301734273,"number":1817,"title":"Flowspec client","user":{"login":"pguibert6WIND","id":16295538,"avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-03-02T11:19:03Z","updated_at":"2018-03-14T19:01:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/1817","html_url":"https://github.com/FRRouting/frr/pull/1817","diff_url":"https://github.com/FRRouting/frr/pull/1817.diff","patch_url":"https://github.com/FRRouting/frr/pull/1817.patch"},"body":"This set of commits introduces BGP flowspec protocol in frr.\r\nIt handles the possibility to:\r\n- activate BGP flowspec feature on vty\r\n- handle incoming BGP FS NLRI entries by storing it into BGP RIB.\r\n- display it through show bgp ipv4 flowspec [detail]\r\n- introduce [no] debug bgp flowspec for dumping incoming NLRI.\r\n\r\nThis is first set of test.\r\nothers will come.\r\nHaving FS protocol is not enough.\r\nNext step is to convert FS entries into policy route entries, so that the incoming NLRI will be configured by the underlying system.\r\n\r\nCheers,"},"comment":{"url":"https://api.github.com/repos/FRRouting/frr/issues/comments/373138573","html_url":"https://github.com/FRRouting/frr/pull/1817#issuecomment-373138573","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/1817","id":373138573,"user":{"login":"NetDEF-CI","id":19297776,"avatar_url":"https://avatars3.githubusercontent.com/u/19297776?v=4","gravatar_id":"","url":"https://api.github.com/users/NetDEF-CI","html_url":"https://github.com/NetDEF-CI","followers_url":"https://api.github.com/users/NetDEF-CI/followers","following_url":"https://api.github.com/users/NetDEF-CI/following{/other_user}","gists_url":"https://api.github.com/users/NetDEF-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/NetDEF-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetDEF-CI/subscriptions","organizations_url":"https://api.github.com/users/NetDEF-CI/orgs","repos_url":"https://api.github.com/users/NetDEF-CI/repos","events_url":"https://api.github.com/users/NetDEF-CI/events{/privacy}","received_events_url":"https://api.github.com/users/NetDEF-CI/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T19:01:51Z","updated_at":"2018-03-14T19:01:51Z","author_association":"COLLABORATOR","body":"# Continuous Integration Result: SUCCESSFUL\n\nCongratulations, this patch passed basic tests\n\nTested-by: NetDEF / OpenSourceRouting.org CI System\n\nCI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2900/\n\nThis is a comment from an EXPERIMENTAL automated CI system.\nFor questions and feedback in regards to this CI system, please feel free to email\nMartin Winter - mwinter (at) opensourcerouting.org.\n\n\n-----------------------------\n## Warnings Generated during build:\n\n\n### Checkout code: Successful with additional warnings:\n\n    Report for bgp_flowspec_util.h\n    ===============================================\n    WARNING: do not add new typedefs\n    #26: FILE: /tmp/f1/bgp_flowspec_util.h:26:\n    +typedef enum {\n    Report for bgp_flowspec_vty.c\n    ===============================================\n    ERROR: code indent should use tabs where possible\n    #112: FILE: /tmp/f1/bgp_flowspec_vty.c:112:\n    +^I^I^I^I^I        type_util,$\n    \n    ERROR: code indent should use tabs where possible\n    #175: FILE: /tmp/f1/bgp_flowspec_vty.c:175:\n    +^I^I^I^I^I        type_util,$\n    Report for prefix.h\n    ===============================================\n    < WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))\n    < #197: FILE: /tmp/f1/prefix.h:197:\n    ---\n    > #180: FILE: /tmp/f2/prefix.h:180:\n    --\n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #316: FILE: /tmp/f1/prefix.h:316:\n    < +extern int prefix_opaque_cmp(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #317: FILE: /tmp/f1/prefix.h:317:\n    ---\n    > #296: FILE: /tmp/f2/prefix.h:296:\n    Report for table.c\n    ===============================================\n    --\n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #222: FILE: /tmp/f1/table.c:222:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #222: FILE: /tmp/f1/table.c:222:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    --\n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #314: FILE: /tmp/f1/table.c:314:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #314: FILE: /tmp/f1/table.c:314:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    --\n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #576: FILE: /tmp/f1/table.c:576:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #576: FILE: /tmp/f1/table.c:576:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #658: FILE: /tmp/f1/table.c:658:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    < WARNING: function definition argument 'const struct prefix *' should also have an identifier name\n    < #658: FILE: /tmp/f1/table.c:658:\n    < +\tint (*func_match)(const struct prefix *, const struct prefix *);\n    < \n    Report for table.h\n    ===============================================\n    < WARNING: function definition argument 'route_table_delegate_t *' should also have an identifier name\n    < #181: FILE: /tmp/f1/table.h:181:\n    ---\n    > #179: FILE: /tmp/f2/table.h:179:\n\n\n-----------------------------\n### CLANG Static Analyzer Summary\n- Github Pull Request 1817, comparing to Git base SHA 6ca96cc\n- Base image data for Git 6ca96cc does not exist - compare skipped\n#### 20 Static Analyzer issues remaining.\nSee details at\nhttps://ci1.netdef.org/browse/FRR-FRRPULLREQ-2900/artifact/shared/static_analysis/index.html\n"}}
{"actor":{"display_login":"NetDEF-CI"}}