{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/234722468","pull_request_review_id":176424944,"id":234722468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDcyMjQ2OA==","diff_hunk":"@@ -90,6 +90,24 @@ onkyo:onkyoAVR:avr-livingroom [ipAddress=\"192.168.1.100\", port=60128, volumeLimi\n \n Binding then automatically scale the volume level in both directions (100% = 50 = 100%).\n \n+You can also change the way volume scaling works. This can be necessary if your receiver uses a different scaling system than 0-100.","path":"addons/binding/org.openhab.binding.onkyo/README.md","position":null,"original_position":4,"commit_id":"ad0cd5caaee86c8a1ef82cfff1028ed8d758c070","original_commit_id":"0aeaf85f5ab1d7fe66a02e0f180a6b17fa56fe7e","user":{"login":"cguedel","id":818878,"node_id":"MDQ6VXNlcjgxODg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/818878?v=4","gravatar_id":"","url":"https://api.github.com/users/cguedel","html_url":"https://github.com/cguedel","followers_url":"https://api.github.com/users/cguedel/followers","following_url":"https://api.github.com/users/cguedel/following{/other_user}","gists_url":"https://api.github.com/users/cguedel/gists{/gist_id}","starred_url":"https://api.github.com/users/cguedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguedel/subscriptions","organizations_url":"https://api.github.com/users/cguedel/orgs","repos_url":"https://api.github.com/users/cguedel/repos","events_url":"https://api.github.com/users/cguedel/events{/privacy}","received_events_url":"https://api.github.com/users/cguedel/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-11-19T18:00:41Z","updated_at":"2018-11-19T18:00:41Z","html_url":"https://github.com/openhab/openhab2-addons/pull/4223#discussion_r234722468","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/234722468"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4223#discussion_r234722468"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223"}},"in_reply_to_id":234461203},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223","id":230264372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjY0Mzcy","html_url":"https://github.com/openhab/openhab2-addons/pull/4223","diff_url":"https://github.com/openhab/openhab2-addons/pull/4223.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/4223.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4223","number":4223,"state":"open","locked":false,"title":"[onkyo] Add volume scaling variants","user":{"login":"cguedel","id":818878,"node_id":"MDQ6VXNlcjgxODg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/818878?v=4","gravatar_id":"","url":"https://api.github.com/users/cguedel","html_url":"https://github.com/cguedel","followers_url":"https://api.github.com/users/cguedel/followers","following_url":"https://api.github.com/users/cguedel/following{/other_user}","gists_url":"https://api.github.com/users/cguedel/gists{/gist_id}","starred_url":"https://api.github.com/users/cguedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguedel/subscriptions","organizations_url":"https://api.github.com/users/cguedel/orgs","repos_url":"https://api.github.com/users/cguedel/repos","events_url":"https://api.github.com/users/cguedel/events{/privacy}","received_events_url":"https://api.github.com/users/cguedel/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing to the openHAB project!\r\nPlease describe the goal and effect of your PR here.\r\nPay attention to the below notes and to *the guidelines* for this repository.\r\nFeel free to delete any comment sections in the template (starting with \"<!--\").\r\n-->\r\n\r\n<!-- TITLE -->\r\n\r\n<!--\r\nPlease provide a PR summary in the *Title* above, according to the following schema:\r\n- If related to one specific addon: Mention the addon shortname in square brackets\r\n  e.g. \"[exec]\", \"[netatmo]\" or \"[tesla]\"\r\n- If the PR is work in progress: Add \"[WIP]\"\r\n- Give a short meaningful description in imperative mood\r\n  e.g. \"Add support for device XYZ\" or \"Fix wrongly handled exception\"\r\n  for a new add-on/binding: \"Initial contribution\"\r\nExamples:\r\n- \"[homematic] Improve communication with weak signal devices\"\r\n- \"[timemachine][WIP] Initial contribution\"\r\n- \"Update contribution guidelines on new signing rules\"\r\n-->\r\n\r\n<!-- DESCRIPTION -->\r\n\r\nThis adds a configuration parameter to the onkyo receiver thing that allows to control volume scaling. The following 4 variants are supported:\r\n\r\n- 0-100 -> no scaling\r\n- 0-200 -> 0.5 increments for volume, scale by 2\r\n- 0-80  -> volume goes from 0-80, scale by 0.8\r\n- 0-50  -> volume goes from 0-50, scale by 0.5\r\n\r\nThe default behavior remains unchanged. Volume limiting is applied before the scaling, so should still be ok.\r\n\r\n<!--\r\nPlease give a few sentences describing the overall goals of the pull request.\r\nGive enough details to make the improvement and changes of the PR understandable\r\nto both developers and tech-savy users.\r\n\r\nPlease keep the following in mind:\r\n- What is the classification of the PR, e.g. Bugfix, Improvement, Novel Addition, ... ?\r\n- Did you describe the PRs motivation and goal?\r\n- Did you provide a link to any prior discussion, e.g. an issue or community forum thread?\r\n- Did you describe new features for the end user?\r\n- Did you describe any noteworthy changes in usage for the end user?\r\n- Was the documentation updated accordingly, e.g. the addon README?\r\n- Does your contribution follow the coding guidelines:\r\n  https://www.openhab.org/docs/developer/development/guidelines.html\r\n- Did you check for any (relevant) issues from the static code analysis:\r\n  https://www.openhab.org/docs/developer/development/bindings.html#static-code-analysis\r\n- Did you sign-off your work:\r\n  https://www.openhab.org/docs/developer/contributing/contributing.html#sign-your-work\r\n-->\r\n\r\n<!-- TESTING -->\r\n\r\n<!--\r\nYour Pull Request will automatically be built and available under the following folder:\r\nhttps://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/\r\n\r\nIt's a good practice to add an URL to your built JAR in this Pull Request description,\r\nso it's easier for the community to test your Add-on.\r\nIf your Pull Request contains a new binding, it will likely take some time\r\nbefore it's reviewed and processed by maintainers.\r\nThat said, consider submitting your Add-on in the Eclipse IoT Marketplace\r\nSee this thread for more info:\r\nhttps://community.openhab.org/t/24491\r\n\r\nDon't forget to submit a thread about your Add-on in the openHAB community:\r\nhttps://community.openhab.org/c/add-ons \r\n-->\r\n","created_at":"2018-11-12T20:50:31Z","updated_at":"2018-11-19T18:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f55a64fc78b788ee20ac4532b294e0d5f0579798","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4223/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/ad0cd5caaee86c8a1ef82cfff1028ed8d758c070","head":{"label":"cguedel:onkyo-volume-scaling","ref":"onkyo-volume-scaling","sha":"ad0cd5caaee86c8a1ef82cfff1028ed8d758c070","user":{"login":"cguedel","id":818878,"node_id":"MDQ6VXNlcjgxODg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/818878?v=4","gravatar_id":"","url":"https://api.github.com/users/cguedel","html_url":"https://github.com/cguedel","followers_url":"https://api.github.com/users/cguedel/followers","following_url":"https://api.github.com/users/cguedel/following{/other_user}","gists_url":"https://api.github.com/users/cguedel/gists{/gist_id}","starred_url":"https://api.github.com/users/cguedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguedel/subscriptions","organizations_url":"https://api.github.com/users/cguedel/orgs","repos_url":"https://api.github.com/users/cguedel/repos","events_url":"https://api.github.com/users/cguedel/events{/privacy}","received_events_url":"https://api.github.com/users/cguedel/received_events","type":"User","site_admin":false},"repo":{"id":132879797,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4Nzk3OTc=","name":"openhab2-addons","full_name":"cguedel/openhab2-addons","private":false,"owner":{"login":"cguedel","id":818878,"node_id":"MDQ6VXNlcjgxODg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/818878?v=4","gravatar_id":"","url":"https://api.github.com/users/cguedel","html_url":"https://github.com/cguedel","followers_url":"https://api.github.com/users/cguedel/followers","following_url":"https://api.github.com/users/cguedel/following{/other_user}","gists_url":"https://api.github.com/users/cguedel/gists{/gist_id}","starred_url":"https://api.github.com/users/cguedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguedel/subscriptions","organizations_url":"https://api.github.com/users/cguedel/orgs","repos_url":"https://api.github.com/users/cguedel/repos","events_url":"https://api.github.com/users/cguedel/events{/privacy}","received_events_url":"https://api.github.com/users/cguedel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cguedel/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/cguedel/openhab2-addons","forks_url":"https://api.github.com/repos/cguedel/openhab2-addons/forks","keys_url":"https://api.github.com/repos/cguedel/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cguedel/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cguedel/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/cguedel/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/cguedel/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/cguedel/openhab2-addons/events","assignees_url":"https://api.github.com/repos/cguedel/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/cguedel/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/cguedel/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/cguedel/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cguedel/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cguedel/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/cguedel/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cguedel/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/cguedel/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/cguedel/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/cguedel/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/cguedel/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/cguedel/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/cguedel/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/cguedel/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/cguedel/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/cguedel/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/cguedel/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/cguedel/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cguedel/openhab2-addons/merges","archive_url":"https://api.github.com/repos/cguedel/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cguedel/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/cguedel/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/cguedel/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/cguedel/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/cguedel/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cguedel/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/cguedel/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/cguedel/openhab2-addons/deployments","created_at":"2018-05-10T09:37:59Z","updated_at":"2018-11-10T09:05:23Z","pushed_at":"2018-11-19T18:00:05Z","git_url":"git://github.com/cguedel/openhab2-addons.git","ssh_url":"git@github.com:cguedel/openhab2-addons.git","clone_url":"https://github.com/cguedel/openhab2-addons.git","svn_url":"https://github.com/cguedel/openhab2-addons","homepage":"","size":301078,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"6844182abb2cb90b4e4575de1c51f2b29c7f3d62","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1MzE5NQ==","name":"openhab2-addons","full_name":"openhab/openhab2-addons","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2018-11-19T17:42:25Z","pushed_at":"2018-11-19T18:00:08Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":304144,"stargazers_count":900,"watchers_count":900,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1656,"mirror_url":null,"archived":false,"open_issues_count":462,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1656,"open_issues":462,"watchers":900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4223"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4223"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4223/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4223/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/ad0cd5caaee86c8a1ef82cfff1028ed8d758c070"}},"author_association":"NONE"}}
{"actor":{"display_login":"cguedel"}}