{"action":"created","issue":{"url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/11","repository_url":"https://api.github.com/repos/l2isbad/go.d.plugin","labels_url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/11/comments","events_url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/11/events","html_url":"https://github.com/l2isbad/go.d.plugin/issues/11","id":343547799,"node_id":"MDU6SXNzdWUzNDM1NDc3OTk=","number":11,"title":"NewXXX shoud be pointer of XXX","user":{"login":"Wing924","id":8895721,"node_id":"MDQ6VXNlcjg4OTU3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/8895721?v=4","gravatar_id":"","url":"https://api.github.com/users/Wing924","html_url":"https://github.com/Wing924","followers_url":"https://api.github.com/users/Wing924/followers","following_url":"https://api.github.com/users/Wing924/following{/other_user}","gists_url":"https://api.github.com/users/Wing924/gists{/gist_id}","starred_url":"https://api.github.com/users/Wing924/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wing924/subscriptions","organizations_url":"https://api.github.com/users/Wing924/orgs","repos_url":"https://api.github.com/users/Wing924/repos","events_url":"https://api.github.com/users/Wing924/events{/privacy}","received_events_url":"https://api.github.com/users/Wing924/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-23T09:06:26Z","updated_at":"2018-07-23T09:19:21Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/l2isbad/go.d.plugin/blob/cc2db8145867b61054d686449b038837508ac414/internal/pkg/charts/raw/chart.go#L29\r\n\r\n<https://golang.org/doc/effective_go.html#package-names>\r\n\r\nGo don't have constructor, we use `NewXXX(...)` and `New(...)` as constructor.\r\nWe expect constructor return a pointer, not value.\r\nLet's change it to `*Chart`"},"comment":{"url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/comments/406994174","html_url":"https://github.com/l2isbad/go.d.plugin/issues/11#issuecomment-406994174","issue_url":"https://api.github.com/repos/l2isbad/go.d.plugin/issues/11","id":406994174,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjk5NDE3NA==","user":{"login":"l2isbad","id":22274335,"node_id":"MDQ6VXNlcjIyMjc0MzM1","avatar_url":"https://avatars3.githubusercontent.com/u/22274335?v=4","gravatar_id":"","url":"https://api.github.com/users/l2isbad","html_url":"https://github.com/l2isbad","followers_url":"https://api.github.com/users/l2isbad/followers","following_url":"https://api.github.com/users/l2isbad/following{/other_user}","gists_url":"https://api.github.com/users/l2isbad/gists{/gist_id}","starred_url":"https://api.github.com/users/l2isbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2isbad/subscriptions","organizations_url":"https://api.github.com/users/l2isbad/orgs","repos_url":"https://api.github.com/users/l2isbad/repos","events_url":"https://api.github.com/users/l2isbad/events{/privacy}","received_events_url":"https://api.github.com/users/l2isbad/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T09:19:21Z","updated_at":"2018-07-23T09:19:21Z","author_association":"OWNER","body":"> We expect constructor return a pointer, not value.\r\n\r\nI feel it was the reason i did in that way. Don't remember why now :smile: \r\nGive me some time, i will check it later (later today or even yesterday, will be very busy today)"}}
{"actor":{"display_login":"l2isbad"}}