{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/228008225","pull_request_review_id":168177828,"id":228008225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODAwODIyNQ==","diff_hunk":"@@ -2195,14 +2190,11 @@ HALF_@kind@(char **args, npy_intp *dimensions, npy_intp *steps, void *NPY_UNUSED\n {\n     /*  */\n     BINARY_LOOP {\n-        npy_half in1 = *(npy_half *)ip1;\n+        const npy_half in1 = *(npy_half *)ip1;\n         const npy_half in2 = *(npy_half *)ip2;\n-        in1 = (@OP@(in1, in2) || npy_half_isnan(in1)) ? in1 : in2;\n-        if (npy_half_isnan(in1)) {\n-            npy_set_floatstatus_invalid();\n-        } \n-        *((npy_half *)op1) = in1;\n+        *((npy_half *)op1) = (@OP@(in1, in2) || npy_half_isnan(in1)) ? in1 : in2;\n     }\n+    /* npy_half_isnan will never set floatstatus_invalid, so do not clear */","path":"numpy/core/src/umath/loops.c.src","position":38,"original_position":38,"commit_id":"da3d162650abbf5cba096e6dacd5596397c1d23f","original_commit_id":"da3d162650abbf5cba096e6dacd5596397c1d23f","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"body":"when *do* we set floatstatus_invalid? is that set at the C level?","created_at":"2018-10-25T01:10:33Z","updated_at":"2018-10-25T01:10:41Z","html_url":"https://github.com/numpy/numpy/pull/12236#discussion_r228008225","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/12236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/228008225"},"html":{"href":"https://github.com/numpy/numpy/pull/12236#discussion_r228008225"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12236"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/12236","id":224557346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTU3MzQ2","html_url":"https://github.com/numpy/numpy/pull/12236","diff_url":"https://github.com/numpy/numpy/pull/12236.diff","patch_url":"https://github.com/numpy/numpy/pull/12236.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/12236","number":12236,"state":"open","locked":false,"title":"BUG: maximum, minimum no longer emit warnings on NAN","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"body":"Fixes #12038.\r\n\r\nStarting with the sse code in simd.inc.src in PR #3419, then completed in PRs #9020, #11043, #11595, we adopted behaviour that warned when encountering a NAN on `np.maximum`, `np.minimum`, as well as ensuring we return a NAN value. This PR reverts emitting a warning, while preserving the tests to show we always propogate the NAN value to the output.","created_at":"2018-10-21T17:48:23Z","updated_at":"2018-10-25T01:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5246eed32bf1b971aceb3ea540c62901d7836f08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359214,"node_id":"MDU6TGFiZWw2MzU5MjE0","url":"https://api.github.com/repos/numpy/numpy/labels/00%20-%20Bug","name":"00 - Bug","color":"fef2c0","default":false},{"id":6394859,"node_id":"MDU6TGFiZWw2Mzk0ODU5","url":"https://api.github.com/repos/numpy/numpy/labels/06%20-%20Regression","name":"06 - Regression","color":"fef2c0","default":false},{"id":546378754,"node_id":"MDU6TGFiZWw1NDYzNzg3NTQ=","url":"https://api.github.com/repos/numpy/numpy/labels/09%20-%20Backport-Candidate","name":"09 - Backport-Candidate","color":"fef2c0","default":false},{"id":30180279,"node_id":"MDU6TGFiZWwzMDE4MDI3OQ==","url":"https://api.github.com/repos/numpy/numpy/labels/54%20-%20Needs%20decision","name":"54 - Needs decision","color":"207de5","default":false},{"id":959099844,"node_id":"MDU6TGFiZWw5NTkwOTk4NDQ=","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.ufunc","name":"component: numpy.ufunc","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/58","html_url":"https://github.com/numpy/numpy/milestone/58","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/58/labels","id":3353003,"node_id":"MDk6TWlsZXN0b25lMzM1MzAwMw==","number":58,"title":"1.16.0 release","description":"","creator":{"login":"charris","id":77272,"node_id":"MDQ6VXNlcjc3Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":39,"state":"open","created_at":"2018-05-16T21:13:27Z","updated_at":"2018-10-24T23:45:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/12236/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/12236/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/12236/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/da3d162650abbf5cba096e6dacd5596397c1d23f","head":{"label":"mattip:nan-warnings","ref":"nan-warnings","sha":"da3d162650abbf5cba096e6dacd5596397c1d23f","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"repo":{"id":101918527,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTg1Mjc=","name":"numpy","full_name":"mattip/numpy","private":false,"owner":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattip/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/mattip/numpy","forks_url":"https://api.github.com/repos/mattip/numpy/forks","keys_url":"https://api.github.com/repos/mattip/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattip/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattip/numpy/teams","hooks_url":"https://api.github.com/repos/mattip/numpy/hooks","issue_events_url":"https://api.github.com/repos/mattip/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/mattip/numpy/events","assignees_url":"https://api.github.com/repos/mattip/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/mattip/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/mattip/numpy/tags","blobs_url":"https://api.github.com/repos/mattip/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattip/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattip/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattip/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattip/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mattip/numpy/languages","stargazers_url":"https://api.github.com/repos/mattip/numpy/stargazers","contributors_url":"https://api.github.com/repos/mattip/numpy/contributors","subscribers_url":"https://api.github.com/repos/mattip/numpy/subscribers","subscription_url":"https://api.github.com/repos/mattip/numpy/subscription","commits_url":"https://api.github.com/repos/mattip/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattip/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattip/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattip/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattip/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/mattip/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattip/numpy/merges","archive_url":"https://api.github.com/repos/mattip/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattip/numpy/downloads","issues_url":"https://api.github.com/repos/mattip/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/mattip/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mattip/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mattip/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattip/numpy/labels{/name}","releases_url":"https://api.github.com/repos/mattip/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/mattip/numpy/deployments","created_at":"2017-08-30T19:01:59Z","updated_at":"2018-10-11T06:45:35Z","pushed_at":"2018-10-23T12:55:26Z","git_url":"git://github.com/mattip/numpy.git","ssh_url":"git@github.com:mattip/numpy.git","clone_url":"https://github.com/mattip/numpy.git","svn_url":"https://github.com/mattip/numpy","homepage":"http://www.numpy.org/","size":60176,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"7fbcc4eaf22a01ac3282179b49c6363485263fbf","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-10-24T21:48:27Z","pushed_at":"2018-10-24T23:16:15Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":61566,"stargazers_count":8450,"watchers_count":8450,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3069,"mirror_url":null,"archived":false,"open_issues_count":2005,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3069,"open_issues":2005,"watchers":8450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12236"},"html":{"href":"https://github.com/numpy/numpy/pull/12236"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/12236"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/12236/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12236/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12236/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/da3d162650abbf5cba096e6dacd5596397c1d23f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shoyer"}}