{"action":"created","issue":{"url":"https://api.github.com/repos/allegro/turnilo/issues/185","repository_url":"https://api.github.com/repos/allegro/turnilo","labels_url":"https://api.github.com/repos/allegro/turnilo/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/allegro/turnilo/issues/185/comments","events_url":"https://api.github.com/repos/allegro/turnilo/issues/185/events","html_url":"https://github.com/allegro/turnilo/issues/185","id":359327850,"node_id":"MDU6SXNzdWUzNTkzMjc4NTA=","number":185,"title":"Export to CSV/TSV not working","user":{"login":"akalajee","id":8980219,"node_id":"MDQ6VXNlcjg5ODAyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8980219?v=4","gravatar_id":"","url":"https://api.github.com/users/akalajee","html_url":"https://github.com/akalajee","followers_url":"https://api.github.com/users/akalajee/followers","following_url":"https://api.github.com/users/akalajee/following{/other_user}","gists_url":"https://api.github.com/users/akalajee/gists{/gist_id}","starred_url":"https://api.github.com/users/akalajee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalajee/subscriptions","organizations_url":"https://api.github.com/users/akalajee/orgs","repos_url":"https://api.github.com/users/akalajee/repos","events_url":"https://api.github.com/users/akalajee/events{/privacy}","received_events_url":"https://api.github.com/users/akalajee/received_events","type":"User","site_admin":false},"labels":[{"id":765443949,"node_id":"MDU6TGFiZWw3NjU0NDM5NDk=","url":"https://api.github.com/repos/allegro/turnilo/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-12T06:04:29Z","updated_at":"2018-09-12T08:28:51Z","closed_at":null,"author_association":"NONE","body":"When trying to export raw data to CSV/TSV, it generates the following error on Master. Bug is not on 1.6.0\r\n\r\nClient Error: {\"message\":\"Uncaught TypeError: Cannot read property 'toJS' of undefined\",\"file\":\"http://localhost:9091/main.js?v=1.7.0\",\"line\":40,\"column\":3446,\"stack\":\"TypeError: Cannot read property 'toJS' of undefined\\n    at o (http://localhost:9091/app.0e38de4b4fd0e6e017b3.js:28:107673)\\n    at n.r (http://localhost:9091/app.0e38de4b4fd0e6e017b3.js:28:107515)\\n    at Object.l (http://localhost:9091/main.js?v=1.7.0:40:3325)\\n    at Object.invokeGuardedCallback (http://localhost:9091/main.js?v=1.7.0:48:4486)\\n    at Object.invokeGuardedCallbackAndCatchFirstError (http://localhost:9091/main.js?v=1.7.0:48:4603)\\n    at h (http://localhost:9091/main.js?v=1.7.0:40:4250)\\n    at y (http://localhost:9091/main.js?v=1.7.0:40:4718)\\n    at b (http://localhost:9091/main.js?v=1.7.0:40:4875)\\n    at Array.forEach (<anonymous>)\\n    at g (http://localhost:9091/main.js?v=1.7.0:40:4519)\"}\r\n\r\nI debugged the code in download.ts:\r\nexport function download({ dataset, options }: DataSetWithTabOptions, fileFormat: FileFormat, fileName?: string): void \r\n and I am receiving dataset = null\r\n "},"comment":{"url":"https://api.github.com/repos/allegro/turnilo/issues/comments/420559466","html_url":"https://github.com/allegro/turnilo/issues/185#issuecomment-420559466","issue_url":"https://api.github.com/repos/allegro/turnilo/issues/185","id":420559466,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDU1OTQ2Ng==","user":{"login":"adrianmroz","id":14370131,"node_id":"MDQ6VXNlcjE0MzcwMTMx","avatar_url":"https://avatars1.githubusercontent.com/u/14370131?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianmroz","html_url":"https://github.com/adrianmroz","followers_url":"https://api.github.com/users/adrianmroz/followers","following_url":"https://api.github.com/users/adrianmroz/following{/other_user}","gists_url":"https://api.github.com/users/adrianmroz/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianmroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianmroz/subscriptions","organizations_url":"https://api.github.com/users/adrianmroz/orgs","repos_url":"https://api.github.com/users/adrianmroz/repos","events_url":"https://api.github.com/users/adrianmroz/events{/privacy}","received_events_url":"https://api.github.com/users/adrianmroz/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T08:28:51Z","updated_at":"2018-09-12T08:28:51Z","author_association":"NONE","body":"So issue is with this line:\r\n\r\nhttps://github.com/allegro/turnilo/blob/master/src/client/modals/raw-data-modal/raw-data-modal.tsx#L280\r\n\r\nBecause of bind and loose type of `Dataset`, I didn't notice error. `download` accepts object with dataset inside and options. Options are of type `TabulatorOptions` from `plywood`. For header button we create them from `Essence` with function: \r\n\r\nhttps://github.com/allegro/turnilo/blob/master/src/client/utils/tabular-options/tabular-options.ts"}}
{"actor":{"display_login":"adrianmroz"}}