{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/381","repository_url":"https://api.github.com/repos/PowerShell/xWebAdministration","labels_url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/381/comments","events_url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/381/events","html_url":"https://github.com/PowerShell/xWebAdministration/pull/381","id":340649950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDEwNjcw","number":381,"title":"xWebsite: Compare LogTruncateSize parameter correctly (Fixes #380)","user":{"login":"nickgw","id":1992398,"node_id":"MDQ6VXNlcjE5OTIzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1992398?v=4","gravatar_id":"","url":"https://api.github.com/users/nickgw","html_url":"https://github.com/nickgw","followers_url":"https://api.github.com/users/nickgw/followers","following_url":"https://api.github.com/users/nickgw/following{/other_user}","gists_url":"https://api.github.com/users/nickgw/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgw/subscriptions","organizations_url":"https://api.github.com/users/nickgw/orgs","repos_url":"https://api.github.com/users/nickgw/repos","events_url":"https://api.github.com/users/nickgw/events{/privacy}","received_events_url":"https://api.github.com/users/nickgw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-12T13:58:03Z","updated_at":"2018-07-12T15:19:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/PowerShell/xWebAdministration/pulls/381","html_url":"https://github.com/PowerShell/xWebAdministration/pull/381","diff_url":"https://github.com/PowerShell/xWebAdministration/pull/381.diff","patch_url":"https://github.com/PowerShell/xWebAdministration/pull/381.patch"},"body":"xWebsite attempts to compare the passed `$LogTruncateSize` to (essentially) `(Get-Website -Name $name).logFile.LogTruncateSize` except, the parameter is `truncatesize`. This causes the comparison to always fail.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xwebadministration/381)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/comments/404549222","html_url":"https://github.com/PowerShell/xWebAdministration/pull/381#issuecomment-404549222","issue_url":"https://api.github.com/repos/PowerShell/xWebAdministration/issues/381","id":404549222,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDU0OTIyMg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T15:19:17Z","updated_at":"2018-07-12T15:19:17Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=h1) Report\n> Merging [#381](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=desc) into [dev](https://codecov.io/gh/PowerShell/xWebAdministration/commit/a07d02c295f49efd5a608f0915a7dfdf19d6da2b?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381/graphs/tree.svg?src=pr&token=kRBf4t66Il&width=650&height=150)](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##              dev     #381   +/-   ##\n=======================================\n  Coverage   90.44%   90.44%           \n=======================================\n  Files          17       17           \n  Lines        2450     2450           \n=======================================\n  Hits         2216     2216           \n  Misses        234      234\n```\n\n\n| [Impacted Files](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [DSCResources/MSFT\\_xWebsite/MSFT\\_xWebsite.psm1](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381/diff?src=pr&el=tree#diff-RFNDUmVzb3VyY2VzL01TRlRfeFdlYnNpdGUvTVNGVF94V2Vic2l0ZS5wc20x) | `95.63% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=footer). Last update [a07d02c...e739797](https://codecov.io/gh/PowerShell/xWebAdministration/pull/381?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}