{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/226630706","pull_request_review_id":166501984,"id":226630706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjYzMDcwNg==","diff_hunk":"@@ -23,8 +26,38 @@ public ConnectivityTests()\n         }\n \n         [Fact]\n-        public async Task WhenConnectingWithAddnodeConnectToPeerAndAnyPeersInTheAddressManager()\n+        public void WhenStartingNodeWithAListOfIPAddressesTheAddressesArePropagatedToAnotherPeer()\n         {\n+            // TS100_Connectivity_CanGetIPList.\n+\n+            using (NodeBuilder builder = NodeBuilder.Create(this))\n+            {\n+                CoreNode node1 = builder.CreateStratisPosNode(this.Network).NotInIBD().Start();","path":"src/Stratis.Bitcoin.IntegrationTests/Connectivity/ConnectivityTests.cs","position":26,"original_position":26,"commit_id":"7ebff1f174c658d90989290c2ecf7260b7742268","original_commit_id":"7ebff1f174c658d90989290c2ecf7260b7742268","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2018-10-19T12:35:27Z","updated_at":"2018-10-19T12:35:27Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561#discussion_r226630706","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/226630706"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561#discussion_r226630706"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561"}},"in_reply_to_id":226616853},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561","id":224253716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjUzNzE2","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2561","number":2561,"state":"open","locked":false,"title":"[Integration Tests] Connection - 4 final tests.","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"body":"Fixes #2390.\r\n\r\nCovers :-\r\n\r\n- TS100_Connectivity_CanGetIPList\r\n- TS102_Connectivity_CallConnect\r\n- TS105_Connectivity_PreventConnectingToBannedNodes\r\n- TS106_Connectivity_CanErrorHandleConnectionToNonExistingNodes\r\n\r\nNote :-\r\n\r\n- TS101_Connectivity_CallAddNode - Done in a previous PR.\r\n- TS103_Connectivity_ListenDisabled - Ignored, as Listen Mode not implemented.\r\n- TS104_Connectivity_IBD - Ignored, as Listen Mode not implemented.\r\n\r\n\r\n","created_at":"2018-10-19T11:21:25Z","updated_at":"2018-10-19T12:35:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"113b5df72fe70d9ad634064e2ee3a41222c35a2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1083107450,"node_id":"MDU6TGFiZWwxMDgzMTA3NDUw","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/Integration/Unit%20Test","name":"Integration/Unit Test","color":"bef6f7","default":false},{"id":1026215802,"node_id":"MDU6TGFiZWwxMDI2MjE1ODAy","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/Test%20Coverage","name":"Test Coverage","color":"f7d07b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2561/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/7ebff1f174c658d90989290c2ecf7260b7742268","head":{"label":"ferdeen:int_test_connectivity","ref":"int_test_connectivity","sha":"7ebff1f174c658d90989290c2ecf7260b7742268","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"repo":{"id":123270487,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyNzA0ODc=","name":"StratisBitcoinFullNode","full_name":"ferdeen/StratisBitcoinFullNode","private":false,"owner":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ferdeen/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/deployments","created_at":"2018-02-28T10:40:08Z","updated_at":"2018-10-19T11:09:10Z","pushed_at":"2018-10-19T11:09:44Z","git_url":"git://github.com/ferdeen/StratisBitcoinFullNode.git","ssh_url":"git@github.com:ferdeen/StratisBitcoinFullNode.git","clone_url":"https://github.com/ferdeen/StratisBitcoinFullNode.git","svn_url":"https://github.com/ferdeen/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":34542,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"52c183c10fe402a370b1a727697d9589deea6cf4","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","private":false,"owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-10-19T10:01:31Z","pushed_at":"2018-10-19T12:30:22Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":34783,"stargazers_count":585,"watchers_count":585,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":256,"open_issues":195,"watchers":585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2561"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2561"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2561/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2561/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/7ebff1f174c658d90989290c2ecf7260b7742268"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ferdeen"}}