{"action":"created","issue":{"url":"https://api.github.com/repos/gahansen/Albany/issues/399","repository_url":"https://api.github.com/repos/gahansen/Albany","labels_url":"https://api.github.com/repos/gahansen/Albany/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/gahansen/Albany/issues/399/comments","events_url":"https://api.github.com/repos/gahansen/Albany/issues/399/events","html_url":"https://github.com/gahansen/Albany/issues/399","id":388704883,"node_id":"MDU6SXNzdWUzODg3MDQ4ODM=","number":399,"title":"Make sure no two evaluators evaluate the same field","user":{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},"labels":[{"id":1153920665,"node_id":"MDU6TGFiZWwxMTUzOTIwNjY1","url":"https://api.github.com/repos/gahansen/Albany/labels/Phalanx","name":"Phalanx","color":"c9f6ff","default":false},{"id":575424843,"node_id":"MDU6TGFiZWw1NzU0MjQ4NDM=","url":"https://api.github.com/repos/gahansen/Albany/labels/build","name":"build","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},"assignees":[{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},{"login":"ikalash","id":7018124,"node_id":"MDQ6VXNlcjcwMTgxMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7018124?v=4","gravatar_id":"","url":"https://api.github.com/users/ikalash","html_url":"https://github.com/ikalash","followers_url":"https://api.github.com/users/ikalash/followers","following_url":"https://api.github.com/users/ikalash/following{/other_user}","gists_url":"https://api.github.com/users/ikalash/gists{/gist_id}","starred_url":"https://api.github.com/users/ikalash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikalash/subscriptions","organizations_url":"https://api.github.com/users/ikalash/orgs","repos_url":"https://api.github.com/users/ikalash/repos","events_url":"https://api.github.com/users/ikalash/events{/privacy}","received_events_url":"https://api.github.com/users/ikalash/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gahansen/Albany/milestones/2","html_url":"https://github.com/gahansen/Albany/milestone/2","labels_url":"https://api.github.com/repos/gahansen/Albany/milestones/2/labels","id":3569625,"node_id":"MDk6TWlsZXN0b25lMzU2OTYyNQ==","number":2,"title":"Clean build","description":null,"creator":{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-08-14T19:18:58Z","updated_at":"2018-12-07T15:40:43Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-12-07T15:39:51Z","updated_at":"2018-12-10T20:07:12Z","closed_at":null,"author_association":"COLLABORATOR","body":"Following trilinos/Trilinos#4005, we should now make sure that each field is evaluated by exactly one evaluator (1). This is currently a problem in at least Aeras and LandIce. It's going to take some work to clean these up, but I do think it's worth it. It was me who opened the issue requesting this feature, since I already spent 4h of debugging (twice!) to find out I had two evaluators evaluating the same field.\r\n\r\nIn most cases (and I think all the failing tests on the dashboard that fail for this reason), the two evaluators are in fact two copies of the same evaluator. In this case, it would be _safe_ to overlook the repetition, and allow PHX to discard one of the two. However, there are cases (as I said, it happened to me twice), where two _different_ evaluators evaluate the same field. Perhaps you refactored the code, but left a piece of the old one in, and now you have ev1 and ev2 both evaluating the same field. Or even worse: you _always_ had two evaluators evaluating almost the same field: the two fields just differ because of their dimensions, but changing mesh element type (or the vector dimension) will make them clash, and you would not notice it.\r\n\r\nIn short, I think that, despite being annoying to fix things that basically worked, this is after all a useful improvement to the library. I will take care of fixing all the LandIce tests in the next few days. @ikalash do you think you have time to look at the Aeras ones? If it is the same source of error as in LandIce, there is probably an interpolation evaluator that is registered multiple times.\r\n\r\n\r\n\r\n(1) Note: _contributed_ fields are ok."},"comment":{"url":"https://api.github.com/repos/gahansen/Albany/issues/comments/445954176","html_url":"https://github.com/gahansen/Albany/issues/399#issuecomment-445954176","issue_url":"https://api.github.com/repos/gahansen/Albany/issues/399","id":445954176,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTk1NDE3Ng==","user":{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T20:07:12Z","updated_at":"2018-12-10T20:07:12Z","author_association":"COLLABORATOR","body":"If the two evaluators are _the same_, the issue is more like a warning: in practice, we could ignore it. However, there's a risk that a more real problem could sneak in, in which _different_ evaluators evaluate the same field (which is more likely to be wrong).\r\n\r\nI'm taking care of LandIce, so if you take care of Aeras and LCM, we should be good."}}
{"actor":{"display_login":"bartgol"}}