{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/50249","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/50249/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/50249/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/50249/events","html_url":"https://github.com/Microsoft/vscode/issues/50249","id":325089771,"node_id":"MDU6SXNzdWUzMjUwODk3NzE=","number":50249,"title":"New settings editor feedback","user":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"labels":[{"id":529237263,"node_id":"MDU6TGFiZWw1MjkyMzcyNjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/settings-editor","name":"settings-editor","color":"c5def5","default":false},{"id":578047123,"node_id":"MDU6TGFiZWw1NzgwNDcxMjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/under-discussion","name":"under-discussion","color":"dcdcdc","default":false}],"state":"open","locked":false,"assignee":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"assignees":[{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/69","html_url":"https://github.com/Microsoft/vscode/milestone/69","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/69/labels","id":3314596,"node_id":"MDk6TWlsZXN0b25lMzMxNDU5Ng==","number":69,"title":"June 2018","description":"","creator":{"login":"joaomoreno","id":22350,"node_id":"MDQ6VXNlcjIyMzUw","avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"open_issues":159,"closed_issues":391,"state":"open","created_at":"2018-05-02T13:46:37Z","updated_at":"2018-06-24T01:08:47Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"comments":77,"created_at":"2018-05-21T23:19:21Z","updated_at":"2018-06-24T02:33:38Z","closed_at":null,"author_association":"MEMBER","body":"This is a general issue for discussing the new settings editor. The feedback button in Insiders links here. Please leave any feedback here!"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/399724238","html_url":"https://github.com/Microsoft/vscode/issues/50249#issuecomment-399724238","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/50249","id":399724238,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTcyNDIzOA==","user":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"created_at":"2018-06-24T02:33:38Z","updated_at":"2018-06-24T02:33:38Z","author_association":"MEMBER","body":"Thanks everyone for the feedback! Let me try to respond to all of this...\r\n\r\n@beastdestroyer \r\n\r\n> 1. Make categories in the main viewing area (not the list of settings) collapsible - Just one for the people who like to click or scroll but not have it take a while?\r\n\r\nThis is what the list of categories on the left is for. If someone wants to jump ahead, they can click a category.\r\n\r\n> 2. I notice that there is a small white border when selecting a settings' box, however the padding - especially for headings and text is very off\r\n\r\nI actually tuned up the padding a bit yesterday, it will be a little better in Monday's build.\r\n\r\n> 3. For settings with longer descriptions, make the implicit 'Show all' toggleable, so people can just click on it and hide it again\r\n\r\nThe model is that you're selecting a row in a tree, so you have to click somewhere else or press esc to deselect the row and collapse it. Some people might prefer having something to click on to collapse the row... will think about it.\r\n\r\n> 4. It also doesn't look like the GUI supports smooth scrolling, at least for me it is jagged scrolling. (Not lag though)\r\n\r\nThe rendering is not nearly as optimized as it could be. It's smooth on my laptop, but thanks for letting me know.\r\n\r\n> 5. Also, the dropdown boxes seem oddly long although they only contain values that barely fit it, possibly shortening the length to make it fitting, or making it auto-scale eith the value selected? This also ties in to my earlier comment about the 'reset' buttons being more obscure too.\r\n\r\nI like the visual effect of having all them all line up. The native controls are sized to the width of the longest option in the list, not the selected option, which makes them look randomly sized.\r\n\r\n> The sub-category 'Keyboard' under 'Application' has a dropdown marker, but nothing shows and. instead, it scrolls to the. section.\r\n\r\nShould be fixed, thanks.\r\n\r\n@paror \r\n\r\nI think the documentation is important for understanding what the settings are.\r\n\r\n> 2 - put the checkbox before the label (its the most common design)\r\n\r\nI actually just did that yesterday. Here's a sneak preview:\r\n![image](https://user-images.githubusercontent.com/323878/41815223-36945f10-7719-11e8-9a82-3078a1eec14f.png)\r\n\r\nWe decided to put it next to the description instead of the title. If it's next to the title, we can either let it hang into the margin or let it push the title in. I don't like the way the second option makes the title not line up with the other setting titles. Both options make those settings stand out next to other settings, just like @beastdestroyer says in the next message. I think this is a fair compromise that fits in with the rest of the UI so we'll try it to see how it goes.\r\n\r\n> 3 - select box with the same size then text input (a small and a large one)\r\n\r\nI talked about this above\r\n\r\n> 4 - I like outline but not so close to settings. What about this?\r\n\r\nIf the settings list is centered, I think the category list needs to be anchored to the settings list. It feels weird to have a centered element and a left-aligned element on the same page.\r\n\r\n---\r\n\r\n@TomSputz Good suggestions, at first I'm focusing on the most common scenarios for new users so I'm not working too much on improving editing complex settings. Extension groups will show up under the \"Extensions\" category though.\r\n\r\n"}}
{"actor":{"display_login":"roblourens"}}