{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/218368007","pull_request_review_id":156287280,"id":218368007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM2ODAwNw==","diff_hunk":"@@ -1010,57 +1007,25 @@\n                 </configuration>\n             </plugin>\n             <plugin>\n-                <groupId>com.spotify</groupId>\n-                <artifactId>dockerfile-maven-plugin</artifactId>\n-                <version>${dockerfile-maven-plugin.version}</version>\n-                <executions>\n-                    <!--\n-                     Uncomment the section below to build the docker image with mvn package and and push it with mvn deploy\n-                    <execution>\n-                        <id>default</id>\n-                        <goals>\n-                            <goal>build</goal>\n-                            <goal>push</goal>\n-                        </goals>\n-                    </execution>\n-                    -->\n-                    <execution>\n-                        <id>tag-latest</id>\n-                        <phase>none</phase>\n-                        <goals>\n-                            <goal>build</goal>\n-                            <goal>tag</goal>\n-                            <goal>push</goal>\n-                        </goals>\n-                    </execution>\n-                    <execution>\n-                        <id>version</id>\n-                        <phase>none</phase>\n-                        <goals>\n-                            <goal>build</goal>\n-                            <goal>tag</goal>\n-                            <goal>push</goal>\n-                        </goals>\n-                        <configuration>\n-                            <tag>${project.version}</tag>\n-                        </configuration>\n-                    </execution>\n-                    <execution>\n-                        <id>commit</id>\n-                        <phase>none</phase>\n-                        <goals>\n-                            <goal>build</goal>\n-                            <goal>tag</goal>\n-                            <goal>push</goal>\n-                        </goals>\n-                        <configuration>\n-                            <tag>${git.commit.id.describe}</tag>\n-                        </configuration>\n-                    </execution>\n-                </executions>\n+                <groupId>com.google.cloud.tools</groupId>\n+                <artifactId>jib-maven-plugin</artifactId>\n+                <version>${jib-maven-plugin.version}</version>\n                 <configuration>\n-                    <repository><%= baseName.toLowerCase()%></repository>\n-                    <contextDirectory>${project.build.directory}</contextDirectory>\n+                    <from>\n+                        <image>openjdk:8-jre-alpine</image>\n+                    </from>\n+                    <to>\n+                        <image><%= baseName.toLowerCase() %>:latest</image>\n+                    </to>\n+                    <container>\n+                        <jvmFlags>\n+                            <jvmFlag>-Djava.security.egd=file:/dev/./urandom</jvmFlag>\n+                        </jvmFlags>\n+                        <ports>\n+                            <port>8080</port>","path":"generators/server/templates/pom.xml.ejs","position":101,"original_position":101,"commit_id":"87913088b0a63b01dabd639c8f8430606a30b32a","original_commit_id":"542fa0ce7a7caca2fa6e66e4d95490df6906730f","user":{"login":"pascalgrimaud","id":9156882,"node_id":"MDQ6VXNlcjkxNTY4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/9156882?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalgrimaud","html_url":"https://github.com/pascalgrimaud","followers_url":"https://api.github.com/users/pascalgrimaud/followers","following_url":"https://api.github.com/users/pascalgrimaud/following{/other_user}","gists_url":"https://api.github.com/users/pascalgrimaud/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalgrimaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalgrimaud/subscriptions","organizations_url":"https://api.github.com/users/pascalgrimaud/orgs","repos_url":"https://api.github.com/users/pascalgrimaud/repos","events_url":"https://api.github.com/users/pascalgrimaud/events{/privacy}","received_events_url":"https://api.github.com/users/pascalgrimaud/received_events","type":"User","site_admin":false},"body":"See https://github.com/jhipster/generator-jhipster/blob/master/generators/server/templates/src/main/docker/Dockerfile.ejs#L37\r\n\r\nAnd we should add another line for hazelcast too.\r\nI think it should be something like that:\r\n\r\n```\r\n<ports>\r\n    <port><%= serverPort %></port>\r\n    <port>5701/udp</port> <--- need to check if the syntax is correct\r\n</ports>\r\n```","created_at":"2018-09-18T09:50:58Z","updated_at":"2018-09-18T09:50:58Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/8352#discussion_r218368007","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/218368007"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/8352#discussion_r218368007"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352"}},"in_reply_to_id":218308781},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352","id":216097129,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDk3MTI5","html_url":"https://github.com/jhipster/generator-jhipster/pull/8352","diff_url":"https://github.com/jhipster/generator-jhipster/pull/8352.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/8352.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/8352","number":8352,"state":"open","locked":false,"title":"Initial jib integration","user":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"body":"- Please make sure the below checklist is followed for Pull Requests.\r\n\r\n- [ ] [Travis tests](https://travis-ci.org/jhipster/generator-jhipster/pull_requests) are green\r\n- [ ] Tests are added where necessary\r\n- [ ] Documentation is added/updated where necessary\r\n- [ ] Coding Rules & Commit Guidelines as per our [CONTRIBUTING.md document](https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md) are followed\r\n\r\n<!--\r\nPlease also reference the issue number in a commit message to [automatically close the related Github issue](https://help.github.com/articles/closing-issues-via-commit-messages/)\r\n\r\nNote: It is also possible to add `[skip ci]` to your commit message to skip Travis tests\r\n-->\r\n","created_at":"2018-09-17T19:59:25Z","updated_at":"2018-09-18T09:50:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f53b2da377378ce13d0e2c6a7f95307cf87e5f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/8352/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/87913088b0a63b01dabd639c8f8430606a30b32a","head":{"label":"danielpetisme:jib","ref":"jib","sha":"87913088b0a63b01dabd639c8f8430606a30b32a","user":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"repo":{"id":74416013,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQxNjAxMw==","name":"generator-jhipster","full_name":"danielpetisme/generator-jhipster","private":false,"owner":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielpetisme/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":true,"url":"https://api.github.com/repos/danielpetisme/generator-jhipster","forks_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/forks","keys_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/events","assignees_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/merges","archive_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/danielpetisme/generator-jhipster/deployments","created_at":"2016-11-21T23:46:13Z","updated_at":"2018-09-17T19:16:14Z","pushed_at":"2018-09-18T08:24:08Z","git_url":"git://github.com/danielpetisme/generator-jhipster.git","ssh_url":"git@github.com:danielpetisme/generator-jhipster.git","clone_url":"https://github.com/danielpetisme/generator-jhipster.git","svn_url":"https://github.com/danielpetisme/generator-jhipster","homepage":"http://jhipster.github.io","size":33626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"70c0551b6ae1fa97907201bf70fa552cb8d3a2c6","user":{"login":"jhipster","id":6059488,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTk0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MzYzNg==","name":"generator-jhipster","full_name":"jhipster/generator-jhipster","private":false,"owner":{"login":"jhipster","id":6059488,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTk0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular/React projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2018-09-18T08:25:25Z","pushed_at":"2018-09-18T09:21:34Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"https://www.jhipster.tech","size":33646,"stargazers_count":11535,"watchers_count":11535,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2435,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2435,"open_issues":47,"watchers":11535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/8352"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/8352"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/8352/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/8352/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/87913088b0a63b01dabd639c8f8430606a30b32a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pascalgrimaud"}}