{"action":"closed","number":11641,"pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641","id":232255615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjU1NjE1","html_url":"https://github.com/Yoast/wordpress-seo/pull/11641","diff_url":"https://github.com/Yoast/wordpress-seo/pull/11641.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/11641.patch","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11641","number":11641,"state":"closed","locked":false,"title":"Fix overlapping primary category label","user":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Fixes a bug where the 'Select primary category' label in the primary taxonomy picker would overlap the 'Add new category' button.\r\n\r\n## Relevant technical choices:\r\n\r\n* I've added an extra `<div>` around the select (=dropdown) to add padding between the label and the dropdown, because:\r\n     - adding padding/margin to the label above select didn't do anything\r\n    -  styled-components can't add padding/margin to a `<select>`\r\n* I've tested this with a screenreader, which seems to handle the added `<div>` well (i.e. not announcing it/not requiring extra tabs to reach the actual `<select>`)\r\n\r\n\r\n## Test instructions\r\n<!--\r\nPlease follow these guidelines when creating test instructions:\r\n- Please provide step-by-step instructions how to reproduce the issue, if applicable.\r\n- Write step-by-step test instructions aimed at non-tech-savvy users, even if the PR is not user-facing.\r\n-->\r\nThis PR can be tested by following these steps:\r\n\r\nOn trunk:\r\n* Open the document panel in the Gutenberg sidebar. \r\n* Open the categories collapsible\r\n* Select multiple categories, now the \"Select the primary category\" option appears. \r\n* Inspect the `select the primary category` label. Its padding overlaps the `Add new category` button, which makes it very hard to click the button (you have to click the top part).\r\n<img width=\"245\" alt=\"screen shot 2018-11-20 at 10 48 33\" src=\"https://user-images.githubusercontent.com/17744553/48765581-b59b7c80-ecb2-11e8-8208-21f8af121f10.png\">\r\n\r\n* Click `Add new category` (Good luck 😉)\r\n* Type in a category name and click the `Add new category` button\r\n* Inspect the `select the primary category` label. It overlaps the `Add new category` button:\r\n<img width=\"257\" alt=\"screen shot 2018-11-19 at 11 42 35\" src=\"https://user-images.githubusercontent.com/5389513/48702080-3f364600-ebf0-11e8-8dc0-b564381d842a.png\">\r\n\r\nOn this branch:\r\n* Repeat the above steps. Inspect the `select the primary category` label. It doesn't overlap the `Add new category` link or `Add new category` button anymore:\r\n<img width=\"265\" alt=\"schermafbeelding 2018-11-20 om 11 02 30\" src=\"https://user-images.githubusercontent.com/17744553/48766075-e62fe600-ecb3-11e8-9a6a-40b3f4489709.png\">\r\n<img width=\"362\" alt=\"schermafbeelding 2018-11-20 om 10 31 40\" src=\"https://user-images.githubusercontent.com/17744553/48765023-9bad6a00-ecb1-11e8-891b-afa5988f0fb6.png\">\r\n\r\n* Also notice the pretty whitespace between the label and the dropdown.\r\n* Use VoiceOver (in Safari!) to navigate to the `select the primary category` dropdown. Make sure it is announced correctly (and the `<div>` isn't announced).\r\n\r\n## Quality assurance\r\n\r\n* [x] I have tested this code to the best of my abilities\r\n* [ ] I have added unittests to verify the code works as intended\r\n\r\nFixes #11632\r\n","created_at":"2018-11-20T10:01:16Z","updated_at":"2018-11-20T11:59:21Z","closed_at":"2018-11-20T11:59:21Z","merged_at":"2018-11-20T11:59:21Z","merge_commit_sha":"535696f14616861a85b8a64df962365a9cae46e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/137","html_url":"https://github.com/Yoast/wordpress-seo/milestone/137","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/137/labels","id":3799570,"node_id":"MDk6TWlsZXN0b25lMzc5OTU3MA==","number":137,"title":"9.3","description":null,"creator":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":29,"state":"open","created_at":"2018-11-06T09:19:32Z","updated_at":"2018-11-20T11:59:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641/commits","review_comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641/comments","review_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11641/comments","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/3328d0076f2ccce5cb03924322c3981850cf0f19","head":{"label":"Yoast:11632-overlapping-orimary-category-label","ref":"11632-overlapping-orimary-category-label","sha":"3328d0076f2ccce5cb03924322c3981850cf0f19","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2018-11-20T10:32:59Z","pushed_at":"2018-11-20T11:59:21Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":690239,"stargazers_count":1009,"watchers_count":1009,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":590,"mirror_url":null,"archived":false,"open_issues_count":1071,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":590,"open_issues":1071,"watchers":1009,"default_branch":"trunk"}},"base":{"label":"Yoast:trunk","ref":"trunk","sha":"2cfc5903751cf02af4b25611d4c313537688ad66","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2018-11-20T10:32:59Z","pushed_at":"2018-11-20T11:59:21Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":690239,"stargazers_count":1009,"watchers_count":1009,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":590,"mirror_url":null,"archived":false,"open_issues_count":1071,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":590,"open_issues":1071,"watchers":1009,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/11641"},"issue":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11641"},"comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11641/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11641/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/3328d0076f2ccce5cb03924322c3981850cf0f19"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Xyfi","id":5389513,"node_id":"MDQ6VXNlcjUzODk1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5389513?v=4","gravatar_id":"","url":"https://api.github.com/users/Xyfi","html_url":"https://github.com/Xyfi","followers_url":"https://api.github.com/users/Xyfi/followers","following_url":"https://api.github.com/users/Xyfi/following{/other_user}","gists_url":"https://api.github.com/users/Xyfi/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyfi/subscriptions","organizations_url":"https://api.github.com/users/Xyfi/orgs","repos_url":"https://api.github.com/users/Xyfi/repos","events_url":"https://api.github.com/users/Xyfi/events{/privacy}","received_events_url":"https://api.github.com/users/Xyfi/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":33,"deletions":26,"changed_files":2}}
{"actor":{"display_login":"Xyfi"}}