{"action":"created","issue":{"url":"https://api.github.com/repos/edrlab/readium-desktop/issues/20","repository_url":"https://api.github.com/repos/edrlab/readium-desktop","labels_url":"https://api.github.com/repos/edrlab/readium-desktop/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/edrlab/readium-desktop/issues/20/comments","events_url":"https://api.github.com/repos/edrlab/readium-desktop/issues/20/events","html_url":"https://github.com/edrlab/readium-desktop/issues/20","id":244125451,"number":20,"title":"[UI/UX] Page numbers (`epub:type=\"pagebreak\"`)","user":{"login":"JayPanoz","id":12599652,"avatar_url":"https://avatars3.githubusercontent.com/u/12599652?v=4","gravatar_id":"","url":"https://api.github.com/users/JayPanoz","html_url":"https://github.com/JayPanoz","followers_url":"https://api.github.com/users/JayPanoz/followers","following_url":"https://api.github.com/users/JayPanoz/following{/other_user}","gists_url":"https://api.github.com/users/JayPanoz/gists{/gist_id}","starred_url":"https://api.github.com/users/JayPanoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayPanoz/subscriptions","organizations_url":"https://api.github.com/users/JayPanoz/orgs","repos_url":"https://api.github.com/users/JayPanoz/repos","events_url":"https://api.github.com/users/JayPanoz/events{/privacy}","received_events_url":"https://api.github.com/users/JayPanoz/received_events","type":"User","site_admin":false},"labels":[{"id":851258481,"url":"https://api.github.com/repos/edrlab/readium-desktop/labels/accessibility","name":"accessibility","color":"e8e558","default":false},{"id":851263210,"url":"https://api.github.com/repos/edrlab/readium-desktop/labels/user-interface","name":"user-interface","color":"89e87a","default":false}],"state":"open","locked":false,"assignee":{"login":"clebeaupin","id":9804486,"avatar_url":"https://avatars2.githubusercontent.com/u/9804486?v=4","gravatar_id":"","url":"https://api.github.com/users/clebeaupin","html_url":"https://github.com/clebeaupin","followers_url":"https://api.github.com/users/clebeaupin/followers","following_url":"https://api.github.com/users/clebeaupin/following{/other_user}","gists_url":"https://api.github.com/users/clebeaupin/gists{/gist_id}","starred_url":"https://api.github.com/users/clebeaupin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebeaupin/subscriptions","organizations_url":"https://api.github.com/users/clebeaupin/orgs","repos_url":"https://api.github.com/users/clebeaupin/repos","events_url":"https://api.github.com/users/clebeaupin/events{/privacy}","received_events_url":"https://api.github.com/users/clebeaupin/received_events","type":"User","site_admin":false},"assignees":[{"login":"clebeaupin","id":9804486,"avatar_url":"https://avatars2.githubusercontent.com/u/9804486?v=4","gravatar_id":"","url":"https://api.github.com/users/clebeaupin","html_url":"https://github.com/clebeaupin","followers_url":"https://api.github.com/users/clebeaupin/followers","following_url":"https://api.github.com/users/clebeaupin/following{/other_user}","gists_url":"https://api.github.com/users/clebeaupin/gists{/gist_id}","starred_url":"https://api.github.com/users/clebeaupin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebeaupin/subscriptions","organizations_url":"https://api.github.com/users/clebeaupin/orgs","repos_url":"https://api.github.com/users/clebeaupin/repos","events_url":"https://api.github.com/users/clebeaupin/events{/privacy}","received_events_url":"https://api.github.com/users/clebeaupin/received_events","type":"User","site_admin":false},{"login":"Scarsniik","id":15014810,"avatar_url":"https://avatars2.githubusercontent.com/u/15014810?v=4","gravatar_id":"","url":"https://api.github.com/users/Scarsniik","html_url":"https://github.com/Scarsniik","followers_url":"https://api.github.com/users/Scarsniik/followers","following_url":"https://api.github.com/users/Scarsniik/following{/other_user}","gists_url":"https://api.github.com/users/Scarsniik/gists{/gist_id}","starred_url":"https://api.github.com/users/Scarsniik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scarsniik/subscriptions","organizations_url":"https://api.github.com/users/Scarsniik/orgs","repos_url":"https://api.github.com/users/Scarsniik/repos","events_url":"https://api.github.com/users/Scarsniik/events{/privacy}","received_events_url":"https://api.github.com/users/Scarsniik/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/edrlab/readium-desktop/milestones/2","html_url":"https://github.com/edrlab/readium-desktop/milestone/2","labels_url":"https://api.github.com/repos/edrlab/readium-desktop/milestones/2/labels","id":3149979,"number":2,"title":"Second public release","description":"Updated installers for Windows, Linux and MacOS","creator":{"login":"danielweck","id":625201,"avatar_url":"https://avatars3.githubusercontent.com/u/625201?v=4","gravatar_id":"","url":"https://api.github.com/users/danielweck","html_url":"https://github.com/danielweck","followers_url":"https://api.github.com/users/danielweck/followers","following_url":"https://api.github.com/users/danielweck/following{/other_user}","gists_url":"https://api.github.com/users/danielweck/gists{/gist_id}","starred_url":"https://api.github.com/users/danielweck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielweck/subscriptions","organizations_url":"https://api.github.com/users/danielweck/orgs","repos_url":"https://api.github.com/users/danielweck/repos","events_url":"https://api.github.com/users/danielweck/events{/privacy}","received_events_url":"https://api.github.com/users/danielweck/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":1,"state":"open","created_at":"2018-02-28T08:58:12Z","updated_at":"2018-03-26T08:57:16Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2017-07-19T18:03:48Z","updated_at":"2018-04-24T10:54:25Z","closed_at":null,"author_association":"NONE","body":"We’re collecting feedback for Readium CSS and some requests may exceed the project’s scope (designing a CSS baseline).\r\n\r\nManaging page numbers is a critical issue, especially in education. Users may search for page numbers, check which page they are scanning/reading/referring to (so page number should be displayed), etc.\r\n\r\nSomething as simple as having the page number displayed inline would already be judged some kind of progress, extra points if displayed in the margin. I guess it shouldn’t reflow with font-size but I may be wrong.\r\n\r\nThe streamer is already taking care of the pagelist/navdoc so this is probably more of an UI/UX-focused issue that a dev issue. Correct me if I’m wrong. "},"comment":{"url":"https://api.github.com/repos/edrlab/readium-desktop/issues/comments/383889416","html_url":"https://github.com/edrlab/readium-desktop/issues/20#issuecomment-383889416","issue_url":"https://api.github.com/repos/edrlab/readium-desktop/issues/20","id":383889416,"user":{"login":"JayPanoz","id":12599652,"avatar_url":"https://avatars3.githubusercontent.com/u/12599652?v=4","gravatar_id":"","url":"https://api.github.com/users/JayPanoz","html_url":"https://github.com/JayPanoz","followers_url":"https://api.github.com/users/JayPanoz/followers","following_url":"https://api.github.com/users/JayPanoz/following{/other_user}","gists_url":"https://api.github.com/users/JayPanoz/gists{/gist_id}","starred_url":"https://api.github.com/users/JayPanoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayPanoz/subscriptions","organizations_url":"https://api.github.com/users/JayPanoz/orgs","repos_url":"https://api.github.com/users/JayPanoz/repos","events_url":"https://api.github.com/users/JayPanoz/events{/privacy}","received_events_url":"https://api.github.com/users/JayPanoz/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T10:54:25Z","updated_at":"2018-04-24T10:54:25Z","author_association":"NONE","body":"Out of curiosity, I did a quick search about `epub:type=\"pagebreak\"` and two markups seem to coexist in the real world 😞 \r\n\r\nMarkup 1:\r\n\r\n```\r\n<span id=\"page001\" title=\"1\" epub:type=\"pagebreak\"/>\r\n```\r\n\r\nand Markup 2:\r\n\r\n```\r\n<span epub:type=\"pagebreak\" id=\"page001\" class=\"whatever\">1</span>\r\n```\r\n\r\nWith the second one even being handled in [a plugin to automate ncx pagelist](http://www.mobileread.mobi/forums/showthread.php?t=265237). We may want to take that into account, I guess. \r\n\r\nSo now, pure CSS solution for markup 1: \r\n\r\n![capture d ecran 2018-04-24 a 12 32 07](https://user-images.githubusercontent.com/12599652/39182184-59196cc4-47bc-11e8-838f-88118ff99b2e.png)\r\n\r\nI can’t use anything else than and `::after` pseudo element and as you can see, it isn’t displayed after the empty `span` but at the very end of the paragraph (consistent between browsers). And when you start trying to put it into margins, you obviously get extra issues:\r\n\r\n![capture d ecran 2018-04-24 a 12 32 48](https://user-images.githubusercontent.com/12599652/39182438-36269754-47bd-11e8-9b33-8039412a1dfe.png)\r\n\r\nOverlapped page numbers.\r\n\r\n![capture d ecran 2018-04-24 a 12 33 00](https://user-images.githubusercontent.com/12599652/39182441-3929f52c-47bd-11e8-93c5-22ee75f07952.png)\r\n\r\nInconsistent positioning (see page number 3 and 4). \r\n\r\nIn other words, the positioning (offset) of the page number in the text node is simply lost in that case – I don’t necessarily know why yet, I must research the spec because it doesn’t work like that for non-empty elements (e.g. `abbr` for which you display the `title` using the same declaration…).\r\n\r\nOn a related note, authors have been very wary of styling page numbers, because they deem displaying the responsibility of the Reading System, considering their viable options (e.g. inline, disrupting the reading flow). "}}
{"actor":{"display_login":"JayPanoz"}}