{"action":"created","comment":{"url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/comments/197925531","pull_request_review_id":131764058,"id":197925531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzkyNTUzMQ==","diff_hunk":"@@ -242,11 +242,11 @@ if uname -a | grep -i  darwin > /dev/null 2>&1; then\n \n   # Fix for non-English Unicode systems on MAC\n   if [ -z ${LC_ALL} ]; then\n-    echo \"export LC_ALL=en_US.UTF-8\" >> ~/.bash_profile\n+    export LC_ALL=en_US.UTF-8","path":"install_sct","position":null,"original_position":5,"commit_id":"3f7f4b465794cb1807d8838a984ee5445aada310","original_commit_id":"47efcb9d918b5e107ef9d6235ccfb75fbbefd5a1","user":{"login":"jcohenadad","id":2482071,"node_id":"MDQ6VXNlcjI0ODIwNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/2482071?v=4","gravatar_id":"","url":"https://api.github.com/users/jcohenadad","html_url":"https://github.com/jcohenadad","followers_url":"https://api.github.com/users/jcohenadad/followers","following_url":"https://api.github.com/users/jcohenadad/following{/other_user}","gists_url":"https://api.github.com/users/jcohenadad/gists{/gist_id}","starred_url":"https://api.github.com/users/jcohenadad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcohenadad/subscriptions","organizations_url":"https://api.github.com/users/jcohenadad/orgs","repos_url":"https://api.github.com/users/jcohenadad/repos","events_url":"https://api.github.com/users/jcohenadad/events{/privacy}","received_events_url":"https://api.github.com/users/jcohenadad/received_events","type":"User","site_admin":false},"body":"@abtahizadeh as mentioned in https://github.com/neuropoly/spinalcordtoolbox/pull/1881#discussion_r197626836, this PR needs to be tested before merging. You mentioned you had issues with pip that you will be fixing.","created_at":"2018-06-25T20:08:55Z","updated_at":"2018-06-25T20:08:55Z","html_url":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881#discussion_r197925531","pull_request_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/comments/197925531"},"html":{"href":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881#discussion_r197925531"},"pull_request":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881"}},"in_reply_to_id":197626685},"pull_request":{"url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881","id":196759376,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzU5Mzc2","html_url":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881","diff_url":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881.diff","patch_url":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881.patch","issue_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/1881","number":1881,"state":"open","locked":false,"title":"Local language support (LC_ALL) added to installation& launcher on macOS","user":{"login":"abtahizadeh","id":12260844,"node_id":"MDQ6VXNlcjEyMjYwODQ0","avatar_url":"https://avatars0.githubusercontent.com/u/12260844?v=4","gravatar_id":"","url":"https://api.github.com/users/abtahizadeh","html_url":"https://github.com/abtahizadeh","followers_url":"https://api.github.com/users/abtahizadeh/followers","following_url":"https://api.github.com/users/abtahizadeh/following{/other_user}","gists_url":"https://api.github.com/users/abtahizadeh/gists{/gist_id}","starred_url":"https://api.github.com/users/abtahizadeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abtahizadeh/subscriptions","organizations_url":"https://api.github.com/users/abtahizadeh/orgs","repos_url":"https://api.github.com/users/abtahizadeh/repos","events_url":"https://api.github.com/users/abtahizadeh/events{/privacy}","received_events_url":"https://api.github.com/users/abtahizadeh/received_events","type":"User","site_admin":false},"body":"### Requirements\r\n\r\n* [* ] Is there a issue open describing the motivation for this pull request ?\r\n* [ ] Does the pull request need an update of the documentation ?\r\n* [ *] Does the pull request need additional test(s) ?\r\nTested on macOS\r\n* [ ] Clean up the warnings generated by the [style guide](https://www.jetbrains.com/help/pycharm/2017.1/code-inspection.html)\r\n\r\n### Description of the Change\r\n\r\nAdding support for non-English language local Unicode during the installation.\r\nPlease note that `LC_ALL` overwrites `LANG`\r\n\r\n### Steps and Constraints\r\n\r\n`install_sct` updated\r\n\r\n### Applicable Issues\r\n\r\nImplements or Fixes #1880  and #1851 (duplicate)\r\n","created_at":"2018-06-22T14:44:33Z","updated_at":"2018-06-25T20:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a89ecd8dbf1da8f95b80da3ab446cf8fd31a8a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"perone","id":412328,"node_id":"MDQ6VXNlcjQxMjMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/412328?v=4","gravatar_id":"","url":"https://api.github.com/users/perone","html_url":"https://github.com/perone","followers_url":"https://api.github.com/users/perone/followers","following_url":"https://api.github.com/users/perone/following{/other_user}","gists_url":"https://api.github.com/users/perone/gists{/gist_id}","starred_url":"https://api.github.com/users/perone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perone/subscriptions","organizations_url":"https://api.github.com/users/perone/orgs","repos_url":"https://api.github.com/users/perone/repos","events_url":"https://api.github.com/users/perone/events{/privacy}","received_events_url":"https://api.github.com/users/perone/received_events","type":"User","site_admin":false},{"login":"tanguyduval","id":7785316,"node_id":"MDQ6VXNlcjc3ODUzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7785316?v=4","gravatar_id":"","url":"https://api.github.com/users/tanguyduval","html_url":"https://github.com/tanguyduval","followers_url":"https://api.github.com/users/tanguyduval/followers","following_url":"https://api.github.com/users/tanguyduval/following{/other_user}","gists_url":"https://api.github.com/users/tanguyduval/gists{/gist_id}","starred_url":"https://api.github.com/users/tanguyduval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanguyduval/subscriptions","organizations_url":"https://api.github.com/users/tanguyduval/orgs","repos_url":"https://api.github.com/users/tanguyduval/repos","events_url":"https://api.github.com/users/tanguyduval/events{/privacy}","received_events_url":"https://api.github.com/users/tanguyduval/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":105947385,"node_id":"MDU6TGFiZWwxMDU5NDczODU=","url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/labels/installation","name":"installation","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881/commits","review_comments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881/comments","review_comment_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/1881/comments","statuses_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/statuses/3f7f4b465794cb1807d8838a984ee5445aada310","head":{"label":"neuropoly:feature/1880","ref":"feature/1880","sha":"3f7f4b465794cb1807d8838a984ee5445aada310","user":{"login":"neuropoly","id":7755716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTU3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7755716?v=4","gravatar_id":"","url":"https://api.github.com/users/neuropoly","html_url":"https://github.com/neuropoly","followers_url":"https://api.github.com/users/neuropoly/followers","following_url":"https://api.github.com/users/neuropoly/following{/other_user}","gists_url":"https://api.github.com/users/neuropoly/gists{/gist_id}","starred_url":"https://api.github.com/users/neuropoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neuropoly/subscriptions","organizations_url":"https://api.github.com/users/neuropoly/orgs","repos_url":"https://api.github.com/users/neuropoly/repos","events_url":"https://api.github.com/users/neuropoly/events{/privacy}","received_events_url":"https://api.github.com/users/neuropoly/received_events","type":"Organization","site_admin":false},"repo":{"id":20361729,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM2MTcyOQ==","name":"spinalcordtoolbox","full_name":"neuropoly/spinalcordtoolbox","owner":{"login":"neuropoly","id":7755716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTU3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7755716?v=4","gravatar_id":"","url":"https://api.github.com/users/neuropoly","html_url":"https://github.com/neuropoly","followers_url":"https://api.github.com/users/neuropoly/followers","following_url":"https://api.github.com/users/neuropoly/following{/other_user}","gists_url":"https://api.github.com/users/neuropoly/gists{/gist_id}","starred_url":"https://api.github.com/users/neuropoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neuropoly/subscriptions","organizations_url":"https://api.github.com/users/neuropoly/orgs","repos_url":"https://api.github.com/users/neuropoly/repos","events_url":"https://api.github.com/users/neuropoly/events{/privacy}","received_events_url":"https://api.github.com/users/neuropoly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neuropoly/spinalcordtoolbox","description":"Comprehensive and open-source library of analysis tools for MRI of the spinal cord.","fork":false,"url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox","forks_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/forks","keys_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/teams","hooks_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/hooks","issue_events_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/events{/number}","events_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/events","assignees_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/assignees{/user}","branches_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/branches{/branch}","tags_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/tags","blobs_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/languages","stargazers_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/stargazers","contributors_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/contributors","subscribers_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/subscribers","subscription_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/subscription","commits_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/contents/{+path}","compare_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/merges","archive_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/downloads","issues_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues{/number}","pulls_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/labels{/name}","releases_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/releases{/id}","deployments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/deployments","created_at":"2014-05-31T18:01:05Z","updated_at":"2018-06-25T05:09:36Z","pushed_at":"2018-06-25T05:17:39Z","git_url":"git://github.com/neuropoly/spinalcordtoolbox.git","ssh_url":"git@github.com:neuropoly/spinalcordtoolbox.git","clone_url":"https://github.com/neuropoly/spinalcordtoolbox.git","svn_url":"https://github.com/neuropoly/spinalcordtoolbox","homepage":"http://www.neuro.polymtl.ca/home","size":157948,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":250,"watchers":38,"default_branch":"master"}},"base":{"label":"neuropoly:master","ref":"master","sha":"b24ef4bcfd72b80d265c2d0aac13416646157b16","user":{"login":"neuropoly","id":7755716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTU3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7755716?v=4","gravatar_id":"","url":"https://api.github.com/users/neuropoly","html_url":"https://github.com/neuropoly","followers_url":"https://api.github.com/users/neuropoly/followers","following_url":"https://api.github.com/users/neuropoly/following{/other_user}","gists_url":"https://api.github.com/users/neuropoly/gists{/gist_id}","starred_url":"https://api.github.com/users/neuropoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neuropoly/subscriptions","organizations_url":"https://api.github.com/users/neuropoly/orgs","repos_url":"https://api.github.com/users/neuropoly/repos","events_url":"https://api.github.com/users/neuropoly/events{/privacy}","received_events_url":"https://api.github.com/users/neuropoly/received_events","type":"Organization","site_admin":false},"repo":{"id":20361729,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM2MTcyOQ==","name":"spinalcordtoolbox","full_name":"neuropoly/spinalcordtoolbox","owner":{"login":"neuropoly","id":7755716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTU3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7755716?v=4","gravatar_id":"","url":"https://api.github.com/users/neuropoly","html_url":"https://github.com/neuropoly","followers_url":"https://api.github.com/users/neuropoly/followers","following_url":"https://api.github.com/users/neuropoly/following{/other_user}","gists_url":"https://api.github.com/users/neuropoly/gists{/gist_id}","starred_url":"https://api.github.com/users/neuropoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neuropoly/subscriptions","organizations_url":"https://api.github.com/users/neuropoly/orgs","repos_url":"https://api.github.com/users/neuropoly/repos","events_url":"https://api.github.com/users/neuropoly/events{/privacy}","received_events_url":"https://api.github.com/users/neuropoly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neuropoly/spinalcordtoolbox","description":"Comprehensive and open-source library of analysis tools for MRI of the spinal cord.","fork":false,"url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox","forks_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/forks","keys_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/teams","hooks_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/hooks","issue_events_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/events{/number}","events_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/events","assignees_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/assignees{/user}","branches_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/branches{/branch}","tags_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/tags","blobs_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/languages","stargazers_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/stargazers","contributors_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/contributors","subscribers_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/subscribers","subscription_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/subscription","commits_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/contents/{+path}","compare_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/merges","archive_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/downloads","issues_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues{/number}","pulls_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/labels{/name}","releases_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/releases{/id}","deployments_url":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/deployments","created_at":"2014-05-31T18:01:05Z","updated_at":"2018-06-25T05:09:36Z","pushed_at":"2018-06-25T05:17:39Z","git_url":"git://github.com/neuropoly/spinalcordtoolbox.git","ssh_url":"git@github.com:neuropoly/spinalcordtoolbox.git","clone_url":"https://github.com/neuropoly/spinalcordtoolbox.git","svn_url":"https://github.com/neuropoly/spinalcordtoolbox","homepage":"http://www.neuro.polymtl.ca/home","size":157948,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":250,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881"},"html":{"href":"https://github.com/neuropoly/spinalcordtoolbox/pull/1881"},"issue":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/1881"},"comments":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/issues/1881/comments"},"review_comments":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881/comments"},"review_comment":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/pulls/1881/commits"},"statuses":{"href":"https://api.github.com/repos/neuropoly/spinalcordtoolbox/statuses/3f7f4b465794cb1807d8838a984ee5445aada310"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jcohenadad"}}