{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/210848015","pull_request_review_id":147149376,"id":210848015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg0ODAxNQ==","diff_hunk":"@@ -127,8 +127,15 @@ <h2 class=\"card-pf-title\">\n       <footer class=\"container-fluid\">\n         <div class=\"row\">\n           <div class=\"col-sm-12 code-imports--step_toolbar\">\n-            <button #cancelImportsButton id=\"cancelImportsButton\" class=\"btn btn-primary\" aria-label=\"Continue\" [disabled]=\"selectedFlow === '' || projectName === '' || isProjectNameValid === false || isProjectNameAvailable === false || isProjectNameValid === undefined || isProjectNameAvailable === undefined\"\n-              (click)=\"routeToLaunchApp()\">Continue</button>\n+            <button #cancelImportsButton id=\"cancelImportsButton\" class=\"btn btn-primary\" aria-label=\"Continue\"\n+              [disabled]=\"selectedFlow === ''\n+                || projectName === ''\n+                || isProjectNameValid === false\n+                || isProjectNameAvailable === false\n+                || isProjectNameValid === undefined\n+                || isProjectNameAvailable === undefined","path":"src/app/space/add-app-overlay/add-app-overlay.component.html","position":12,"original_position":12,"commit_id":"de9c963baefffb864100f865a953e9e86600a656","original_commit_id":"de9c963baefffb864100f865a953e9e86600a656","user":{"login":"bartoszmajsak","id":719616,"node_id":"MDQ6VXNlcjcxOTYxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/719616?v=4","gravatar_id":"","url":"https://api.github.com/users/bartoszmajsak","html_url":"https://github.com/bartoszmajsak","followers_url":"https://api.github.com/users/bartoszmajsak/followers","following_url":"https://api.github.com/users/bartoszmajsak/following{/other_user}","gists_url":"https://api.github.com/users/bartoszmajsak/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszmajsak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszmajsak/subscriptions","organizations_url":"https://api.github.com/users/bartoszmajsak/orgs","repos_url":"https://api.github.com/users/bartoszmajsak/repos","events_url":"https://api.github.com/users/bartoszmajsak/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszmajsak/received_events","type":"User","site_admin":false},"body":"@vikram-raj can we encapsulate all `project` related checks to one meaningful property? This looks a bit hackish and could simply be `isProjectDefined`?","created_at":"2018-08-17T09:04:26Z","updated_at":"2018-08-17T09:08:39Z","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3247#discussion_r210848015","pull_request_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/210848015"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3247#discussion_r210848015"},"pull_request":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247","id":207954451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTU0NDUx","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3247","diff_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3247.diff","patch_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3247.patch","issue_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3247","number":3247,"state":"open","locked":false,"title":"fix(add-app-overlay): close overlay on navigation end","user":{"login":"vikram-raj","id":2561818,"node_id":"MDQ6VXNlcjI1NjE4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2561818?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-raj","html_url":"https://github.com/vikram-raj","followers_url":"https://api.github.com/users/vikram-raj/followers","following_url":"https://api.github.com/users/vikram-raj/following{/other_user}","gists_url":"https://api.github.com/users/vikram-raj/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-raj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-raj/subscriptions","organizations_url":"https://api.github.com/users/vikram-raj/orgs","repos_url":"https://api.github.com/users/vikram-raj/repos","events_url":"https://api.github.com/users/vikram-raj/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-raj/received_events","type":"User","site_admin":false},"body":"Issue - https://github.com/openshiftio/openshift.io/issues/4018","created_at":"2018-08-13T11:59:17Z","updated_at":"2018-08-17T09:08:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"480b9e5cf99b1e48bc2bba0ba4a753af3748d89d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joshuawilson","id":1184371,"node_id":"MDQ6VXNlcjExODQzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1184371?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuawilson","html_url":"https://github.com/joshuawilson","followers_url":"https://api.github.com/users/joshuawilson/followers","following_url":"https://api.github.com/users/joshuawilson/following{/other_user}","gists_url":"https://api.github.com/users/joshuawilson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuawilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuawilson/subscriptions","organizations_url":"https://api.github.com/users/joshuawilson/orgs","repos_url":"https://api.github.com/users/joshuawilson/repos","events_url":"https://api.github.com/users/joshuawilson/events{/privacy}","received_events_url":"https://api.github.com/users/joshuawilson/received_events","type":"User","site_admin":false},{"login":"jyasveer","id":5430080,"node_id":"MDQ6VXNlcjU0MzAwODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5430080?v=4","gravatar_id":"","url":"https://api.github.com/users/jyasveer","html_url":"https://github.com/jyasveer","followers_url":"https://api.github.com/users/jyasveer/followers","following_url":"https://api.github.com/users/jyasveer/following{/other_user}","gists_url":"https://api.github.com/users/jyasveer/gists{/gist_id}","starred_url":"https://api.github.com/users/jyasveer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyasveer/subscriptions","organizations_url":"https://api.github.com/users/jyasveer/orgs","repos_url":"https://api.github.com/users/jyasveer/repos","events_url":"https://api.github.com/users/jyasveer/events{/privacy}","received_events_url":"https://api.github.com/users/jyasveer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247/commits","review_comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247/comments","review_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3247/comments","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/de9c963baefffb864100f865a953e9e86600a656","head":{"label":"vikram-raj:osio-4018","ref":"osio-4018","sha":"de9c963baefffb864100f865a953e9e86600a656","user":{"login":"vikram-raj","id":2561818,"node_id":"MDQ6VXNlcjI1NjE4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2561818?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-raj","html_url":"https://github.com/vikram-raj","followers_url":"https://api.github.com/users/vikram-raj/followers","following_url":"https://api.github.com/users/vikram-raj/following{/other_user}","gists_url":"https://api.github.com/users/vikram-raj/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-raj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-raj/subscriptions","organizations_url":"https://api.github.com/users/vikram-raj/orgs","repos_url":"https://api.github.com/users/vikram-raj/repos","events_url":"https://api.github.com/users/vikram-raj/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-raj/received_events","type":"User","site_admin":false},"repo":{"id":84298552,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI5ODU1Mg==","name":"fabric8-ui","full_name":"vikram-raj/fabric8-ui","owner":{"login":"vikram-raj","id":2561818,"node_id":"MDQ6VXNlcjI1NjE4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2561818?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-raj","html_url":"https://github.com/vikram-raj","followers_url":"https://api.github.com/users/vikram-raj/followers","following_url":"https://api.github.com/users/vikram-raj/following{/other_user}","gists_url":"https://api.github.com/users/vikram-raj/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-raj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-raj/subscriptions","organizations_url":"https://api.github.com/users/vikram-raj/orgs","repos_url":"https://api.github.com/users/vikram-raj/repos","events_url":"https://api.github.com/users/vikram-raj/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-raj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikram-raj/fabric8-ui","description":"the angular 2 console for fabric8 online","fork":true,"url":"https://api.github.com/repos/vikram-raj/fabric8-ui","forks_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/forks","keys_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/events","assignees_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/merges","archive_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/vikram-raj/fabric8-ui/deployments","created_at":"2017-03-08T08:45:36Z","updated_at":"2018-07-30T08:02:45Z","pushed_at":"2018-08-16T18:48:57Z","git_url":"git://github.com/vikram-raj/fabric8-ui.git","ssh_url":"git@github.com:vikram-raj/fabric8-ui.git","clone_url":"https://github.com/vikram-raj/fabric8-ui.git","svn_url":"https://github.com/vikram-raj/fabric8-ui","homepage":"","size":14861,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-ui:master","ref":"master","sha":"c49e2821890118cdddb8603c222a0ba84fb350dc","user":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":73824736,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgyNDczNg==","name":"fabric8-ui","full_name":"fabric8-ui/fabric8-ui","owner":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-ui/fabric8-ui","description":"The Angular frontend for fabric8 online (OpenShift.IO)","fork":false,"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui","forks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/forks","keys_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/events","assignees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/merges","archive_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/deployments","created_at":"2016-11-15T15:04:11Z","updated_at":"2018-08-16T15:53:41Z","pushed_at":"2018-08-17T08:07:47Z","git_url":"git://github.com/fabric8-ui/fabric8-ui.git","ssh_url":"git@github.com:fabric8-ui/fabric8-ui.git","clone_url":"https://github.com/fabric8-ui/fabric8-ui.git","svn_url":"https://github.com/fabric8-ui/fabric8-ui","homepage":"https://openshift.io/","size":14918,"stargazers_count":23,"watchers_count":23,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":13,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3247"},"issue":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3247"},"comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3247/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3247/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/de9c963baefffb864100f865a953e9e86600a656"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bartoszmajsak"}}