{"push_id":2374456972,"size":86,"distinct_size":86,"ref":"refs/heads/master","head":"da23f79cda056d87a6aadc161ad48a04224dbbfb","before":"21790b8f5fdd37efd0a874c139ea621eb92fb9e7","commits":[{"sha":"58ab12bdd7d79db943a9a2f79f216309ef5bd6e0","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"publish-artifacts: add tests\n\nThey are skipped by default as they build all of the binaries, which\nis only possible when run through the builder.","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/58ab12bdd7d79db943a9a2f79f216309ef5bd6e0"},{"sha":"e3b2e940b3f39d97061123ddc47994ab84c22dae","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"publish-artifacts: refactor code\n\nIn preparation for changing the naming scheme for non-release binaries\nto match that of release binaries.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/e3b2e940b3f39d97061123ddc47994ab84c22dae"},{"sha":"bd3146a1c02d3bf0b0fa79e45df81a52fcdedf79","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: replace placeholders with values\n\nIf we have value for placeholders, replace them with their values\nduring build.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/bd3146a1c02d3bf0b0fa79e45df81a52fcdedf79"},{"sha":"17622f1ba160c750fbd3d159315fdd7885a5e2d1","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: prefer short cast syntax\n\nWe are building CastExpr using the explicit syntax. This causes some\nchurn in some distsql tests when the new index constraints code is on.\nSwitching to the short syntax.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/17622f1ba160c750fbd3d159315fdd7885a5e2d1"},{"sha":"8a4d2840c50dc3ee863c11d33a9ac2f6016da297","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"sql: wire up the ported index constraints code\n\nThe new index constraints code was ported to the new optimizer\nstructures (in `opt/idxconstraint`). This change rewires sql to use\nthat.\n\nPlanning benchmark differences below. Note that we will be looking at\nimproving the performance before 2.1 ships.\n\n```\nname                                                             old time/op    new time/op    delta\nPlanning/SELECT_*_FROM_abc-8                                        265µs ± 3%     266µs ± 3%     ~     (p=0.886 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_a_>_5_ORDER_BY_a-8                 200µs ± 1%     214µs ± 1%   +6.88%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5-8                            196µs ± 2%     213µs ± 5%   +8.59%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5_ORDER_BY_a-8                 211µs ± 4%     225µs ± 2%   +6.54%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_c_=_5-8                            195µs ± 3%     209µs ± 4%   +6.85%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_JOIN_abc_AS_abc2_ON_abc.a_=_abc2.a-8     459µs ± 4%     435µs ± 4%     ~     (p=0.057 n=4+4)\n\nname                                                             old alloc/op   new alloc/op   delta\nPlanning/SELECT_*_FROM_abc-8                                       33.8kB ± 2%    33.8kB ± 2%     ~     (p=1.000 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_a_>_5_ORDER_BY_a-8                23.4kB ± 2%    27.1kB ± 1%  +15.86%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5-8                           25.1kB ± 1%    28.9kB ± 2%  +15.26%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5_ORDER_BY_a-8                26.2kB ± 3%    29.7kB ± 0%  +13.19%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_c_=_5-8                           24.9kB ± 0%    28.7kB ± 1%  +15.48%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_JOIN_abc_AS_abc2_ON_abc.a_=_abc2.a-8    70.0kB ± 2%    69.6kB ± 0%     ~     (p=0.886 n=4+4)\n\nname                                                             old allocs/op  new allocs/op  delta\nPlanning/SELECT_*_FROM_abc-8                                          354 ± 0%       354 ± 0%     ~     (p=1.000 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_a_>_5_ORDER_BY_a-8                   328 ± 0%       372 ± 0%  +13.41%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5-8                              320 ± 0%       364 ± 0%  +13.74%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_b_=_5_ORDER_BY_a-8                   360 ± 0%       404 ± 0%  +12.14%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_WHERE_c_=_5-8                              317 ± 0%       361 ± 0%  +13.96%  (p=0.029 n=4+4)\nPlanning/SELECT_*_FROM_abc_JOIN_abc_AS_abc2_ON_abc.a_=_abc2.a-8       649 ± 0%       648 ± 0%     ~     (p=0.429 n=4+4)\n```\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/8a4d2840c50dc3ee863c11d33a9ac2f6016da297"},{"sha":"45b0c6dc3afc4d4a96a594435e14a263e97ff28f","author":{"name":"Pete Vilter","email":"5d47304f45e2a81bf670b9af84999c9c9b730ca2@cockroachlabs.com"},"message":"ui: clusterviz: link from node component to node details page\n\nRelease note (admin ui change): in cluster viz, link from node component\nto node details page","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/45b0c6dc3afc4d4a96a594435e14a263e97ff28f"},{"sha":"78005982c7f9855d405339c74cb3b974e759b684","author":{"name":"Nikhil Benesch","email":"8468d930edb919b09d0b65aa1babaecbdcaf13cc@gmail.com"},"message":"Use GNU-style formatting directives on Windows\n\nBy default, on Windows, GCC will check to make sure that formatting directives\nthat are not supported on Windows, like %llu and %zu, are not used.  Recent\nversions of MinGW ship POSIX-compliant printf replacements that do support\nthese directives, but GCC is not smart enough to realize this on its own.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/78005982c7f9855d405339c74cb3b974e759b684"},{"sha":"d79f836047f4b761855168c488a9d04691b0627f","author":{"name":"Nikhil Benesch","email":"8468d930edb919b09d0b65aa1babaecbdcaf13cc@gmail.com"},"message":"Merge pull request #23263 from benesch/gnu-printf\n\nUse GNU-style formatting directives on Windows","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/d79f836047f4b761855168c488a9d04691b0627f"},{"sha":"802cebc592e0ff61fb503c5a00571edf53683fc0","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: optbuilder support for COALESCE\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/802cebc592e0ff61fb503c5a00571edf53683fc0"},{"sha":"517b83b9887b7b9ae5319d048b5b580e237d7dfc","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: execbuilder support for VALUES\n\nThe execbuilder only supported zero-column VALUES. Adding full\nsupport.\n\nRelease note: None.","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/517b83b9887b7b9ae5319d048b5b580e237d7dfc"},{"sha":"6cbdc12f66c9e16637494f3bbd6da642078cd542","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: add execbuilder tests for COALESCE\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/6cbdc12f66c9e16637494f3bbd6da642078cd542"},{"sha":"c42d839ee3584b7406d73a5fef1dbcba69d84c02","author":{"name":"Arjun Narayan","email":"e295f43f869eb4e47bb424bbbd86edcfa874ba78@cockroachlabs.com"},"message":"cli: stop synctest if the supplied dir exists\n\nPrior to this commit, synctest would just clobber the entire supplied\ndirectory, with no warning. Fixes #23242.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/c42d839ee3584b7406d73a5fef1dbcba69d84c02"},{"sha":"646cbf3ee32ca133c11c253fe2d0c282147baa1f","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"sql: improve cluster version upgrade semantics\n\nPrior to this change, `SHOW CLUSTER SETTING version` read the version\nstraight from the KV store. This was a terrible decision made by yours\ntruly to make tests that bumped the version not flaky but at the same\ntime implied that to check whether a node had processed a cluster\nversion bump, it was not enough to run `SHOW CLUSTER SETTING version`.\n\nThis manifested itself as a flake in the `TestVersionUpgrade` acceptance\ntest: we'd upgrade from 1.0 to 1.1 and prematurely restart a node into\n`master`; that node would then refuse to start since its last persisted\ncluster setting was 1.0 which is not compatible with a post-1.1.x\nbinary.\n\nSince the test deals mostly in historical binaries which can't be\nchanged now, I adapted the test to use `SHOW ALL CLUSTER SETTINGS`\ninstead. This goes straight to Gossip and thus has the semantics wanted\nby this test. For the source binary, we don't use this workaround.\n\nAs future-proofing, I changed `SHOW CLUSTER SETTING version` to read\nboth the Gossip variable *and* the KV store, and retry for a reasonable\namount of time until they are equal. This makes sure that a cluster\nversion bump immediately becomes reported on all nodes (i.e. you won't\never be able to issue a bump and then not see the version variable\nbumped) *and* that the node has actually applied the version upgrade\nbefore reporting it.\n\nFixes #22796.\nFixes #23257.\n\nRelease note (bug fix): Hardened the cluster version upgrade mechanism.\nRapid upgrades through more than two versions could sometimes fail\nrecoverably.","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/646cbf3ee32ca133c11c253fe2d0c282147baa1f"},{"sha":"b25189b256574bb0d2dd8479a7715fc0b26e7c6a","author":{"name":"Daniel Harrison","email":"96fdf737f2c68055d34b5e86ee18a69908830b01@gmail.com"},"message":"workload/tpcc: hardcode the now flag\n\nIt doesn't seem like anyone will want to change it and it's really noisy\nin the generated fixture paths.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/b25189b256574bb0d2dd8479a7715fc0b26e7c6a"},{"sha":"6d2a45b61cd2a6ccbec6a0d5f235e56cc8037946","author":{"name":"Daniel Harrison","email":"96fdf737f2c68055d34b5e86ee18a69908830b01@gmail.com"},"message":"workload/bank: set flags in FromConfig/FromRows\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/6d2a45b61cd2a6ccbec6a0d5f235e56cc8037946"},{"sha":"dfe4cf0c1d88c8d542735ae096daae670ec59327","author":{"name":"Daniel Harrison","email":"96fdf737f2c68055d34b5e86ee18a69908830b01@gmail.com"},"message":"roachtest: use cockroach-tmp as the temp bucket\n\nI'm going to delete cockroachdb-backup-testing. We don't need two temp\nbuckets.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/dfe4cf0c1d88c8d542735ae096daae670ec59327"},{"sha":"cbb95018561646a9ef46c9261ee68913a05af9e1","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":".github: add bulk io group\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/cbb95018561646a9ef46c9261ee68913a05af9e1"},{"sha":"bb6403c310853c597ed60a97d5b53b62104c4768","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"kubernetes: Let secure client pod be deleted with no delay\n\nOur docs say that you can delete this pod and recreate it as needed, but\nwithout this field it's given a minute to gracefully shut itself down,\nwhich it won't ever do on its own since it's just running sleep. This\ntells Kubernetes it's ok to kill it with no wait.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/bb6403c310853c597ed60a97d5b53b62104c4768"},{"sha":"333547dfb6f4f7f0c367cb3a7d78bb2854d6b9ff","author":{"name":"Ben Darnell","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@cockroachlabs.com"},"message":"storage: Disallow sync intent resolution in loadSystemConfig\n\nThis holds raftMu on the system config range for too long,\nand in extreme cases can lead to deadlock.\n\nFixes #23254\n\nRelease note (bug fix): Fixed a deadlock when tables are rapidly\ncreated or dropped.","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/333547dfb6f4f7f0c367cb3a7d78bb2854d6b9ff"},{"sha":"f9c7e9f6445d10f7bc86c41618b6fb3bb6a7c703","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #23272 from RaduBerinde/coalesce-tests\n\nopt: execbuilder support for COALESCE, VALUES","distinct":true,"url":"https://api.github.com/repos/salewski/cockroachdb/commits/f9c7e9f6445d10f7bc86c41618b6fb3bb6a7c703"}]}
{"actor":{"display_login":"salewski"}}