{"action":"created","issue":{"url":"https://api.github.com/repos/openml/openml-python/issues/463","repository_url":"https://api.github.com/repos/openml/openml-python","labels_url":"https://api.github.com/repos/openml/openml-python/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/openml/openml-python/issues/463/comments","events_url":"https://api.github.com/repos/openml/openml-python/issues/463/events","html_url":"https://github.com/openml/openml-python/issues/463","id":319935032,"number":463,"title":"Listing function bug","user":{"login":"janvanrijn","id":2292730,"avatar_url":"https://avatars1.githubusercontent.com/u/2292730?v=4","gravatar_id":"","url":"https://api.github.com/users/janvanrijn","html_url":"https://github.com/janvanrijn","followers_url":"https://api.github.com/users/janvanrijn/followers","following_url":"https://api.github.com/users/janvanrijn/following{/other_user}","gists_url":"https://api.github.com/users/janvanrijn/gists{/gist_id}","starred_url":"https://api.github.com/users/janvanrijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvanrijn/subscriptions","organizations_url":"https://api.github.com/users/janvanrijn/orgs","repos_url":"https://api.github.com/users/janvanrijn/repos","events_url":"https://api.github.com/users/janvanrijn/events{/privacy}","received_events_url":"https://api.github.com/users/janvanrijn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-03T14:04:26Z","updated_at":"2018-05-03T14:24:51Z","closed_at":null,"author_association":"OWNER","body":"#### Description\r\nOn the pip version of OpenML I keep on getting the following error:\r\n```\r\nTraceback (most recent call last):\r\n  File \"/home/janvanrijn/projects/openml-aslib/examples/generate_from_study.py\", line 22, in <module>\r\n    require_complete=args_.require_complete)\r\n  File \"/home/janvanrijn/projects/openml-aslib/openmlaslib/utils/scenario.py\", line 10, in generate_scenario\r\n    function=measure, setup=setups, task=tasks)\r\n  File \"/home/janvanrijn/anaconda3/envs/openml-aslib/lib/python3.6/site-packages/openml/utils.py\", line 147, in list_all\r\n    **active_filters\r\nTypeError: list_evaluations() got an unexpected keyword argument 'limit'\r\n```\r\n\r\n#### Steps/Code to Reproduce\r\n\r\n```python\r\nimport openml\r\nevaluations = openml.utils.list_all(openml.evaluations.list_evaluations,\r\n                                        function='predictive_accuracy', setup=[1], task=[1])\r\n```\r\n\r\n#### Notes\r\nI checked into the code, there are several things that I noted:\r\n* There are practically no unit tests for this functionality\r\n* The unit test that is there works on basis of a hidden function (i.e., _list_datasets)\r\n* There are several hidden functions for the list setup function? _list_setups and __list_setups?\r\n* When adding unit tests on the correct function, they practically all fail with with either of the following errors:\r\n** TypeError: _list_flows() got multiple values for keyword argument 'limit'\r\n** TypeError: list_evaluations() got an unexpected keyword argument 'limit'\r\n\r\n\r\n<!-- Thanks for contributing! -->"},"comment":{"url":"https://api.github.com/repos/openml/openml-python/issues/comments/386313554","html_url":"https://github.com/openml/openml-python/issues/463#issuecomment-386313554","issue_url":"https://api.github.com/repos/openml/openml-python/issues/463","id":386313554,"user":{"login":"janvanrijn","id":2292730,"avatar_url":"https://avatars1.githubusercontent.com/u/2292730?v=4","gravatar_id":"","url":"https://api.github.com/users/janvanrijn","html_url":"https://github.com/janvanrijn","followers_url":"https://api.github.com/users/janvanrijn/followers","following_url":"https://api.github.com/users/janvanrijn/following{/other_user}","gists_url":"https://api.github.com/users/janvanrijn/gists{/gist_id}","starred_url":"https://api.github.com/users/janvanrijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvanrijn/subscriptions","organizations_url":"https://api.github.com/users/janvanrijn/orgs","repos_url":"https://api.github.com/users/janvanrijn/repos","events_url":"https://api.github.com/users/janvanrijn/events{/privacy}","received_events_url":"https://api.github.com/users/janvanrijn/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T14:24:51Z","updated_at":"2018-05-03T14:24:51Z","author_association":"OWNER","body":"Apparently this can be fixed by changing the fn call into the following.\r\n```\r\nnew_batch = listing_call(\r\n                *args,\r\n                limit=batch_size,\r\n```\r\n\r\nAdditionally, things go wrong with the batch size parameter. When I request a size that is not a multiplier of the batch_size, I don't get the exact amount. \r\n\r\nI would also catch the error (in case of no results) in a different way. I will make a PR."}}
{"actor":{"display_login":"janvanrijn"}}