{"action":"created","comment":{"url":"https://api.github.com/repos/crate/crate/pulls/comments/192661846","pull_request_review_id":125475509,"id":192661846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjY2MTg0Ng==","diff_hunk":"@@ -145,7 +160,10 @@ public void operationStarted(int operationId, UUID jobId, String name) {\n     }\n \n     public Iterable<SysMetricsTableInfo.ClassifiedHist> metrics() {\n-        return singletonList(new SysMetricsTableInfo.ClassifiedHist(histogram.copy(), \"total\"));\n+        return histograms.entrySet()\n+            .stream()\n+            .map(e -> new SysMetricsTableInfo.ClassifiedHist(e.getValue().copy(), e.getKey()))\n+            .collect(Collectors.toList());","path":"sql/src/main/java/io/crate/execution/engine/collect/stats/JobsLogs.java","position":97,"original_position":97,"commit_id":"e597d8c92235ea6db29020dda507929fd8c05958","original_commit_id":"e597d8c92235ea6db29020dda507929fd8c05958","user":{"login":"mfussenegger","id":38700,"node_id":"MDQ6VXNlcjM4NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/38700?v=4","gravatar_id":"","url":"https://api.github.com/users/mfussenegger","html_url":"https://github.com/mfussenegger","followers_url":"https://api.github.com/users/mfussenegger/followers","following_url":"https://api.github.com/users/mfussenegger/following{/other_user}","gists_url":"https://api.github.com/users/mfussenegger/gists{/gist_id}","starred_url":"https://api.github.com/users/mfussenegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfussenegger/subscriptions","organizations_url":"https://api.github.com/users/mfussenegger/orgs","repos_url":"https://api.github.com/users/mfussenegger/repos","events_url":"https://api.github.com/users/mfussenegger/events{/privacy}","received_events_url":"https://api.github.com/users/mfussenegger/received_events","type":"User","site_admin":false},"body":"Please avoid `.collect(Collectors.toList())` if only a `Iterable` is returned. It's unnecessary memory usage and causes more allocations. Can use `::iterator` instead.","created_at":"2018-06-04T08:30:13Z","updated_at":"2018-06-04T08:36:40Z","html_url":"https://github.com/crate/crate/pull/7366#discussion_r192661846","pull_request_url":"https://api.github.com/repos/crate/crate/pulls/7366","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/comments/192661846"},"html":{"href":"https://github.com/crate/crate/pull/7366#discussion_r192661846"},"pull_request":{"href":"https://api.github.com/repos/crate/crate/pulls/7366"}}},"pull_request":{"url":"https://api.github.com/repos/crate/crate/pulls/7366","id":191547972,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTQ3OTcy","html_url":"https://github.com/crate/crate/pull/7366","diff_url":"https://github.com/crate/crate/pull/7366.diff","patch_url":"https://github.com/crate/crate/pull/7366.patch","issue_url":"https://api.github.com/repos/crate/crate/issues/7366","number":7366,"state":"open","locked":false,"title":"classify statements to expose the classification in sys.jobs_metrics table","user":{"login":"chaudum","id":281260,"node_id":"MDQ6VXNlcjI4MTI2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/281260?v=4","gravatar_id":"","url":"https://api.github.com/users/chaudum","html_url":"https://github.com/chaudum","followers_url":"https://api.github.com/users/chaudum/followers","following_url":"https://api.github.com/users/chaudum/following{/other_user}","gists_url":"https://api.github.com/users/chaudum/gists{/gist_id}","starred_url":"https://api.github.com/users/chaudum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaudum/subscriptions","organizations_url":"https://api.github.com/users/chaudum/orgs","repos_url":"https://api.github.com/users/chaudum/repos","events_url":"https://api.github.com/users/chaudum/events{/privacy}","received_events_url":"https://api.github.com/users/chaudum/received_events","type":"User","site_admin":false},"body":"WIP","created_at":"2018-05-30T18:54:02Z","updated_at":"2018-06-04T08:36:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"695712d2907a52afc5d73d63e418cc3b7012d386","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crate/crate/pulls/7366/commits","review_comments_url":"https://api.github.com/repos/crate/crate/pulls/7366/comments","review_comment_url":"https://api.github.com/repos/crate/crate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crate/crate/issues/7366/comments","statuses_url":"https://api.github.com/repos/crate/crate/statuses/e597d8c92235ea6db29020dda507929fd8c05958","head":{"label":"crate:h/query-classification","ref":"h/query-classification","sha":"e597d8c92235ea6db29020dda507929fd8c05958","user":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQyNTI5","name":"crate","full_name":"crate/crate","owner":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2018-06-03T21:13:43Z","pushed_at":"2018-06-04T08:15:55Z","git_url":"git://github.com/crate/crate.git","ssh_url":"git@github.com:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":85654,"stargazers_count":2024,"watchers_count":2024,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":269,"open_issues":82,"watchers":2024,"default_branch":"master"}},"base":{"label":"crate:sys-metrics","ref":"sys-metrics","sha":"9f0efc11d68b5ff1ae262573cf4d2bd7ecce8e6c","user":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQyNTI5","name":"crate","full_name":"crate/crate","owner":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2018-06-03T21:13:43Z","pushed_at":"2018-06-04T08:15:55Z","git_url":"git://github.com/crate/crate.git","ssh_url":"git@github.com:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":85654,"stargazers_count":2024,"watchers_count":2024,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":269,"open_issues":82,"watchers":2024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/7366"},"html":{"href":"https://github.com/crate/crate/pull/7366"},"issue":{"href":"https://api.github.com/repos/crate/crate/issues/7366"},"comments":{"href":"https://api.github.com/repos/crate/crate/issues/7366/comments"},"review_comments":{"href":"https://api.github.com/repos/crate/crate/pulls/7366/comments"},"review_comment":{"href":"https://api.github.com/repos/crate/crate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crate/crate/pulls/7366/commits"},"statuses":{"href":"https://api.github.com/repos/crate/crate/statuses/e597d8c92235ea6db29020dda507929fd8c05958"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mfussenegger"}}