{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/comments/218970608","pull_request_review_id":157029613,"id":218970608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk3MDYwOA==","diff_hunk":"@@ -0,0 +1,181 @@\n+# -*- coding: utf-8 -*-\n+'''\n+State for managing heroku apps.\n+\n+.. versionadded:: 2015.5.0\n+\n+:configuration: This state can be used by either passing an api key directly\n+    or by specifying it in a configuration profile in pillar.\n+\n+    It is possible to use a different API than http://api.heroku.com,\n+    by specifying the API URL in config as api_url, or by passing the value directly.\n+\n+    For example:\n+\n+    .. code-block:: yaml\n+\n+        heroku.<name_of_state>:\n+          - api_key: peWcBiMOS9HrZG15peWcBiMOS9HrZG15\n+'''\n+from __future__ import absolute_import\n+import logging\n+\n+import sys\n+import salt.config\n+import salt.exceptions\n+import salt.ext.six.moves.http_client\n+import salt.syspaths\n+import salt.utils","path":"extensions/_states/heroku.py","position":28,"original_position":28,"commit_id":"a8a95bff94bdc7ec51bf3e7bd3bca6625f2dfc69","original_commit_id":"a8a95bff94bdc7ec51bf3e7bd3bca6625f2dfc69","user":{"login":"blarghmatey","id":479088,"node_id":"MDQ6VXNlcjQ3OTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/479088?v=4","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false},"body":"It doesn't appear that any of these salt imports get used anywhere","created_at":"2018-09-19T21:30:04Z","updated_at":"2018-09-19T21:54:10Z","html_url":"https://github.com/mitodl/salt-extensions/pull/37#discussion_r218970608","pull_request_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/comments/218970608"},"html":{"href":"https://github.com/mitodl/salt-extensions/pull/37#discussion_r218970608"},"pull_request":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37","id":216762255,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzYyMjU1","html_url":"https://github.com/mitodl/salt-extensions/pull/37","diff_url":"https://github.com/mitodl/salt-extensions/pull/37.diff","patch_url":"https://github.com/mitodl/salt-extensions/pull/37.patch","issue_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/37","number":37,"state":"open","locked":false,"title":"Heroku state to manage config vars through salt pillar data","user":{"login":"shaidar","id":1447295,"node_id":"MDQ6VXNlcjE0NDcyOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1447295?v=4","gravatar_id":"","url":"https://api.github.com/users/shaidar","html_url":"https://github.com/shaidar","followers_url":"https://api.github.com/users/shaidar/followers","following_url":"https://api.github.com/users/shaidar/following{/other_user}","gists_url":"https://api.github.com/users/shaidar/gists{/gist_id}","starred_url":"https://api.github.com/users/shaidar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaidar/subscriptions","organizations_url":"https://api.github.com/users/shaidar/orgs","repos_url":"https://api.github.com/users/shaidar/repos","events_url":"https://api.github.com/users/shaidar/events{/privacy}","received_events_url":"https://api.github.com/users/shaidar/received_events","type":"User","site_admin":false},"body":"Created a Heroku state to manage config vars through Salt with three main functions:\r\n- Compare config vars in Heroku to pillar data\r\n- Update Heroku config vars from pillar data \r\n- Replace all Heroku config vars from pillar data\r\n\r\nThis extension relies on running salt-proxies to handle the request from the salt-master and render the pillar on the \"minion\". Additionally, the current limitation is that the values of the config_vars specified in pillar need to be strings as that it what Heroku stores its values as.\r\n\r\nThe other minor change was in the heroku modules where I noticed that the examples listed omitted the `app_name` and thus might be confusing to someone potentially using that module.","created_at":"2018-09-19T20:13:45Z","updated_at":"2018-09-19T21:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7acb9e2b6c30b4312bfb2c8f9c5d1a654d0a7b0b","assignee":{"login":"blarghmatey","id":479088,"node_id":"MDQ6VXNlcjQ3OTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/479088?v=4","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false},"assignees":[{"login":"blarghmatey","id":479088,"node_id":"MDQ6VXNlcjQ3OTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/479088?v=4","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":353840854,"node_id":"MDU6TGFiZWwzNTM4NDA4NTQ=","url":"https://api.github.com/repos/mitodl/salt-extensions/labels/DevOps","name":"DevOps","color":"EB6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37/commits","review_comments_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37/comments","review_comment_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/37/comments","statuses_url":"https://api.github.com/repos/mitodl/salt-extensions/statuses/a8a95bff94bdc7ec51bf3e7bd3bca6625f2dfc69","head":{"label":"mitodl:sar/heroku","ref":"sar/heroku","sha":"a8a95bff94bdc7ec51bf3e7bd3bca6625f2dfc69","user":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":55639690,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYzOTY5MA==","name":"salt-extensions","full_name":"mitodl/salt-extensions","private":false,"owner":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mitodl/salt-extensions","description":"Plugins and extension modules for use with SaltStack that are generally useful outside of a given environment.","fork":false,"url":"https://api.github.com/repos/mitodl/salt-extensions","forks_url":"https://api.github.com/repos/mitodl/salt-extensions/forks","keys_url":"https://api.github.com/repos/mitodl/salt-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-extensions/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-extensions/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-extensions/events","assignees_url":"https://api.github.com/repos/mitodl/salt-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-extensions/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-extensions/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-extensions/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-extensions/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-extensions/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-extensions/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-extensions/merges","archive_url":"https://api.github.com/repos/mitodl/salt-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-extensions/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-extensions/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-extensions/deployments","created_at":"2016-04-06T20:52:04Z","updated_at":"2018-07-12T18:56:28Z","pushed_at":"2018-09-19T20:13:46Z","git_url":"git://github.com/mitodl/salt-extensions.git","ssh_url":"git@github.com:mitodl/salt-extensions.git","clone_url":"https://github.com/mitodl/salt-extensions.git","svn_url":"https://github.com/mitodl/salt-extensions","homepage":null,"size":164,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"f7b224d04a9b17d2856fa02c13f3202915157cc5","user":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":55639690,"node_id":"MDEwOlJlcG9zaXRvcnk1NTYzOTY5MA==","name":"salt-extensions","full_name":"mitodl/salt-extensions","private":false,"owner":{"login":"mitodl","id":7918516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7918516?v=4","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mitodl/salt-extensions","description":"Plugins and extension modules for use with SaltStack that are generally useful outside of a given environment.","fork":false,"url":"https://api.github.com/repos/mitodl/salt-extensions","forks_url":"https://api.github.com/repos/mitodl/salt-extensions/forks","keys_url":"https://api.github.com/repos/mitodl/salt-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-extensions/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-extensions/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-extensions/events","assignees_url":"https://api.github.com/repos/mitodl/salt-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-extensions/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-extensions/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-extensions/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-extensions/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-extensions/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-extensions/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-extensions/merges","archive_url":"https://api.github.com/repos/mitodl/salt-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-extensions/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-extensions/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-extensions/deployments","created_at":"2016-04-06T20:52:04Z","updated_at":"2018-07-12T18:56:28Z","pushed_at":"2018-09-19T20:13:46Z","git_url":"git://github.com/mitodl/salt-extensions.git","ssh_url":"git@github.com:mitodl/salt-extensions.git","clone_url":"https://github.com/mitodl/salt-extensions.git","svn_url":"https://github.com/mitodl/salt-extensions","homepage":null,"size":164,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37"},"html":{"href":"https://github.com/mitodl/salt-extensions/pull/37"},"issue":{"href":"https://api.github.com/repos/mitodl/salt-extensions/issues/37"},"comments":{"href":"https://api.github.com/repos/mitodl/salt-extensions/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/salt-extensions/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/salt-extensions/statuses/a8a95bff94bdc7ec51bf3e7bd3bca6625f2dfc69"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blarghmatey"}}