{"action":"opened","issue":{"url":"https://api.github.com/repos/AppMetrics/AppMetrics/issues/262","repository_url":"https://api.github.com/repos/AppMetrics/AppMetrics","labels_url":"https://api.github.com/repos/AppMetrics/AppMetrics/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/AppMetrics/AppMetrics/issues/262/comments","events_url":"https://api.github.com/repos/AppMetrics/AppMetrics/issues/262/events","html_url":"https://github.com/AppMetrics/AppMetrics/issues/262","id":318210261,"number":262,"title":"AddMetricsResourceFilter()??","user":{"login":"WhatFreshHellIsThis","id":1392388,"avatar_url":"https://avatars3.githubusercontent.com/u/1392388?v=4","gravatar_id":"","url":"https://api.github.com/users/WhatFreshHellIsThis","html_url":"https://github.com/WhatFreshHellIsThis","followers_url":"https://api.github.com/users/WhatFreshHellIsThis/followers","following_url":"https://api.github.com/users/WhatFreshHellIsThis/following{/other_user}","gists_url":"https://api.github.com/users/WhatFreshHellIsThis/gists{/gist_id}","starred_url":"https://api.github.com/users/WhatFreshHellIsThis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhatFreshHellIsThis/subscriptions","organizations_url":"https://api.github.com/users/WhatFreshHellIsThis/orgs","repos_url":"https://api.github.com/users/WhatFreshHellIsThis/repos","events_url":"https://api.github.com/users/WhatFreshHellIsThis/events{/privacy}","received_events_url":"https://api.github.com/users/WhatFreshHellIsThis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-26T21:53:10Z","updated_at":"2018-04-26T21:53:10Z","closed_at":null,"author_association":"NONE","body":"QuickStart docs:\r\nhttps://www.app-metrics.io/web-monitoring/aspnet-core/quick-start/\r\n\r\nStates at one point:\r\n\r\n> \" Modify the Startup.cs allowing App Metrics to inspect MVC routes by using the MvcOptions extensions method AddMetricsResourceFilter():\"\r\n\r\nThen gives sample startup.cs code that does not have AddMetricsResourceFilter() anywhere in the example code.\r\n\r\nAfter that code block it again references the extension method:\r\n\r\n> \"The AddMetricsResourceFilter extension method on MvcOptions is required to allow App Metrics to inspect MVC route templates to tag metrics.\"\r\n\r\n\r\nI tried to follow that example but none of my WEBAPI routes are appearing in my metrics so it appears to not be working.\r\n\r\nI'm concerned that the docs are incorrect but I can't find any way to add AddMetricsResourceFilter(), it just doesn't seem to exist when following the example.\r\n\r\nAre the docs messed up or does this one line in Startup.cs ConfigureServices method supersede all that:\r\n`services.AddMvc().AddMetrics();`\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"WhatFreshHellIsThis"}}