{"action":"created","issue":{"url":"https://api.github.com/repos/gentoo/gentoo/issues/8169","repository_url":"https://api.github.com/repos/gentoo/gentoo","labels_url":"https://api.github.com/repos/gentoo/gentoo/issues/8169/labels{/name}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/8169/comments","events_url":"https://api.github.com/repos/gentoo/gentoo/issues/8169/events","html_url":"https://github.com/gentoo/gentoo/pull/8169","id":318479824,"number":8169,"title":"toolchain@g.o: migrate from git-2 to git-r3","user":{"login":"hanetzer","id":2760645,"avatar_url":"https://avatars1.githubusercontent.com/u/2760645?v=4","gravatar_id":"","url":"https://api.github.com/users/hanetzer","html_url":"https://github.com/hanetzer","followers_url":"https://api.github.com/users/hanetzer/followers","following_url":"https://api.github.com/users/hanetzer/following{/other_user}","gists_url":"https://api.github.com/users/hanetzer/gists{/gist_id}","starred_url":"https://api.github.com/users/hanetzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanetzer/subscriptions","organizations_url":"https://api.github.com/users/hanetzer/orgs","repos_url":"https://api.github.com/users/hanetzer/repos","events_url":"https://api.github.com/users/hanetzer/events{/privacy}","received_events_url":"https://api.github.com/users/hanetzer/received_events","type":"User","site_admin":false},"labels":[{"id":257560845,"url":"https://api.github.com/repos/gentoo/gentoo/labels/assigned","name":"assigned","color":"5319e7","default":false},{"id":740399504,"url":"https://api.github.com/repos/gentoo/gentoo/labels/no%20bug%20found","name":"no bug found","color":"b78a0e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-27T16:53:59Z","updated_at":"2018-05-07T12:34:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/8169","html_url":"https://github.com/gentoo/gentoo/pull/8169","diff_url":"https://github.com/gentoo/gentoo/pull/8169.diff","patch_url":"https://github.com/gentoo/gentoo/pull/8169.patch"},"body":"Also unify the layout of sys-libs/glibc's ebuilds."},"comment":{"url":"https://api.github.com/repos/gentoo/gentoo/issues/comments/387050472","html_url":"https://github.com/gentoo/gentoo/pull/8169#issuecomment-387050472","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/8169","id":387050472,"user":{"login":"trofi","id":226650,"avatar_url":"https://avatars2.githubusercontent.com/u/226650?v=4","gravatar_id":"","url":"https://api.github.com/users/trofi","html_url":"https://github.com/trofi","followers_url":"https://api.github.com/users/trofi/followers","following_url":"https://api.github.com/users/trofi/following{/other_user}","gists_url":"https://api.github.com/users/trofi/gists{/gist_id}","starred_url":"https://api.github.com/users/trofi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trofi/subscriptions","organizations_url":"https://api.github.com/users/trofi/orgs","repos_url":"https://api.github.com/users/trofi/repos","events_url":"https://api.github.com/users/trofi/events{/privacy}","received_events_url":"https://api.github.com/users/trofi/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T12:34:23Z","updated_at":"2018-05-07T12:34:23Z","author_association":"MEMBER","body":"Now these changes are clearly not just `git-2` -> `git-r3` transition but also a bunch of unrelated changes. This makes it hard to review and declare seemingly correct. Sometimes patches shuffle around variable declarations and inherits. This makes variables ordering in ebuilds even less usual that in other ebuilds. I would suggest not doing such invasive changes in one go and do instead them as separate pull requests:\r\n\r\n1. handle `git-2` -> `git-r3` in this pull request. This should change only an inherit and maybe variables that are absolutely needed to change.\r\n2. handle whitespace changes in another pull request and only for most recent ebuilds\r\n3. handle code motion around in another pull request as it looks like personal preference change. thus might not be accepted at all\r\n\r\nIf it's too much hassle let's do at least `1.` here."}}
{"actor":{"display_login":"trofi"}}