{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3945","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3945/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3945/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3945/events","html_url":"https://github.com/codice/ddf/pull/3945","id":374551227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjI5MTQx","number":3945,"title":"DDF-4273 properly handle hidden attributes in Table visual","user":{"login":"glenhein","id":17837152,"node_id":"MDQ6VXNlcjE3ODM3MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/17837152?v=4","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-26T21:19:47Z","updated_at":"2018-10-29T20:24:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3945","html_url":"https://github.com/codice/ddf/pull/3945","diff_url":"https://github.com/codice/ddf/pull/3945.diff","patch_url":"https://github.com/codice/ddf/pull/3945.patch"},"body":"#### What does this PR do?\r\nAlign the logic that determines if an attribute is hidden when rendering thumbnail hovers.\r\n\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@brianfelix \r\n@jrnorth \r\n@andrewkfiedler \r\n@leo-sakh \r\n#### Select relevant component teams: \r\n@codice/ui \r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@andrewkfiedler\r\n@bdeining\r\n#### How should this be tested?\r\nTo reproduce the error on master, add `^thumbnail$` to the list of hidden attributes in `Catalog UI Search Hidden Attributes`.  Upload a document that produces a thumbnail, such a PNG. Add the `Table` visual. The search results should indicate that there is one result, but no results will be shown. Also, in the javascript console, you should see a message like `Error: An \"el\" undefined must exist in DOM`. Repeat this steps with this PR and confirm that the search results are displayed and the console message is no longer present.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4273](https://codice.atlassian.net/browse/DDF-4273)\r\n#### Screenshots\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/434065601","html_url":"https://github.com/codice/ddf/pull/3945#issuecomment-434065601","issue_url":"https://api.github.com/repos/codice/ddf/issues/3945","id":434065601,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDA2NTYwMQ==","user":{"login":"cxbot","id":21088360,"node_id":"MDQ6VXNlcjIxMDg4MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T20:24:59Z","updated_at":"2018-10-29T20:24:59Z","author_association":"COLLABORATOR","body":"Internal build has been scheduled, your results will be available at build completion."}}
{"actor":{"display_login":"cxbot"}}