{"action":"created","comment":{"url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/comments/175060917","pull_request_review_id":104527602,"id":175060917,"diff_hunk":"@@ -283,27 +341,27 @@ def remove_snapshot(self, volname, snapname):\n             if snapshot:\n                 LOG.info(\"Found snapshot by name: %s\" % snapname)\n                 # Does the snapshot have child snapshot(s)?\n-                for ss in snapshots:\n-                    LOG.info(\"Checking if snapshot has children: %s\"\n-                             % snapname)\n-                    if ss['parent_id'] == snapshot['id']:\n-                        msg = (_LE('snapshot %s/%s has one or more child '\n-                                   'snapshots - it cannot be deleted!'\n-                                   % (volname, snapname)))\n-                        LOG.error(msg)\n-                        response = json.dumps({u\"Err\": msg})\n-                        return response\n-                try:\n-                    LOG.info(\"Deleting snapshot at backend: %s\" % snapname)\n-                    self._hpeplugin_driver.delete_volume(snapshot,\n-                                                         is_snapshot=True)\n-                except Exception as err:\n-                    msg = (_LE('Failed to remove snapshot error is: %s'),\n-                           six.text_type(err))\n-                    LOG.error(msg)\n-                    response = json.dumps({u\"Err\": six.text_type(err)})\n-                    return response\n-\n+#                for ss in snapshots:","path":"hpedockerplugin/volume_manager.py","position":148,"original_position":148,"commit_id":"541ecbbd57b938d426e06755f14974047e158b36","original_commit_id":"541ecbbd57b938d426e06755f14974047e158b36","user":{"login":"wdurairaj","id":8706684,"avatar_url":"https://avatars3.githubusercontent.com/u/8706684?v=4","gravatar_id":"","url":"https://api.github.com/users/wdurairaj","html_url":"https://github.com/wdurairaj","followers_url":"https://api.github.com/users/wdurairaj/followers","following_url":"https://api.github.com/users/wdurairaj/following{/other_user}","gists_url":"https://api.github.com/users/wdurairaj/gists{/gist_id}","starred_url":"https://api.github.com/users/wdurairaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdurairaj/subscriptions","organizations_url":"https://api.github.com/users/wdurairaj/orgs","repos_url":"https://api.github.com/users/wdurairaj/repos","events_url":"https://api.github.com/users/wdurairaj/events{/privacy}","received_events_url":"https://api.github.com/users/wdurairaj/received_events","type":"User","site_admin":false},"body":"you can remove this","created_at":"2018-03-16T11:25:09Z","updated_at":"2018-03-16T11:26:45Z","html_url":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152#discussion_r175060917","pull_request_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/comments/175060917"},"html":{"href":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152#discussion_r175060917"},"pull_request":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152","id":175451930,"html_url":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152","diff_url":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152.diff","patch_url":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152.patch","issue_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/152","number":152,"state":"open","locked":false,"title":"Snapshot support","user":{"login":"nilangekarss","id":28802946,"avatar_url":"https://avatars2.githubusercontent.com/u/28802946?v=4","gravatar_id":"","url":"https://api.github.com/users/nilangekarss","html_url":"https://github.com/nilangekarss","followers_url":"https://api.github.com/users/nilangekarss/followers","following_url":"https://api.github.com/users/nilangekarss/following{/other_user}","gists_url":"https://api.github.com/users/nilangekarss/gists{/gist_id}","starred_url":"https://api.github.com/users/nilangekarss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilangekarss/subscriptions","organizations_url":"https://api.github.com/users/nilangekarss/orgs","repos_url":"https://api.github.com/users/nilangekarss/repos","events_url":"https://api.github.com/users/nilangekarss/events{/privacy}","received_events_url":"https://api.github.com/users/nilangekarss/received_events","type":"User","site_admin":false},"body":"This is implementation for https://github.hpe.com/swapnil-sun-nilangekar/3par-docker/blob/master/snapshot_design_2_1.md\r\n","created_at":"2018-03-16T06:40:13Z","updated_at":"2018-03-16T11:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148ea2766e664e9d459464ae339707e3e47992e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152/commits","review_comments_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152/comments","review_comment_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/152/comments","statuses_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/statuses/541ecbbd57b938d426e06755f14974047e158b36","head":{"label":"nilangekarss:snapshotSupport","ref":"snapshotSupport","sha":"541ecbbd57b938d426e06755f14974047e158b36","user":{"login":"nilangekarss","id":28802946,"avatar_url":"https://avatars2.githubusercontent.com/u/28802946?v=4","gravatar_id":"","url":"https://api.github.com/users/nilangekarss","html_url":"https://github.com/nilangekarss","followers_url":"https://api.github.com/users/nilangekarss/followers","following_url":"https://api.github.com/users/nilangekarss/following{/other_user}","gists_url":"https://api.github.com/users/nilangekarss/gists{/gist_id}","starred_url":"https://api.github.com/users/nilangekarss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilangekarss/subscriptions","organizations_url":"https://api.github.com/users/nilangekarss/orgs","repos_url":"https://api.github.com/users/nilangekarss/repos","events_url":"https://api.github.com/users/nilangekarss/events{/privacy}","received_events_url":"https://api.github.com/users/nilangekarss/received_events","type":"User","site_admin":false},"repo":{"id":108528282,"name":"python-hpedockerplugin","full_name":"nilangekarss/python-hpedockerplugin","owner":{"login":"nilangekarss","id":28802946,"avatar_url":"https://avatars2.githubusercontent.com/u/28802946?v=4","gravatar_id":"","url":"https://api.github.com/users/nilangekarss","html_url":"https://github.com/nilangekarss","followers_url":"https://api.github.com/users/nilangekarss/followers","following_url":"https://api.github.com/users/nilangekarss/following{/other_user}","gists_url":"https://api.github.com/users/nilangekarss/gists{/gist_id}","starred_url":"https://api.github.com/users/nilangekarss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilangekarss/subscriptions","organizations_url":"https://api.github.com/users/nilangekarss/orgs","repos_url":"https://api.github.com/users/nilangekarss/repos","events_url":"https://api.github.com/users/nilangekarss/events{/privacy}","received_events_url":"https://api.github.com/users/nilangekarss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nilangekarss/python-hpedockerplugin","description":"HPE Native Docker Plugin","fork":true,"url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin","forks_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/forks","keys_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/teams","hooks_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/hooks","issue_events_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/issues/events{/number}","events_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/events","assignees_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/assignees{/user}","branches_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/branches{/branch}","tags_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/tags","blobs_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/languages","stargazers_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/stargazers","contributors_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/contributors","subscribers_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/subscribers","subscription_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/subscription","commits_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/contents/{+path}","compare_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/merges","archive_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/downloads","issues_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/issues{/number}","pulls_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/labels{/name}","releases_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/releases{/id}","deployments_url":"https://api.github.com/repos/nilangekarss/python-hpedockerplugin/deployments","created_at":"2017-10-27T09:42:32Z","updated_at":"2017-10-27T09:42:34Z","pushed_at":"2018-03-16T10:35:27Z","git_url":"git://github.com/nilangekarss/python-hpedockerplugin.git","ssh_url":"git@github.com:nilangekarss/python-hpedockerplugin.git","clone_url":"https://github.com/nilangekarss/python-hpedockerplugin.git","svn_url":"https://github.com/nilangekarss/python-hpedockerplugin","homepage":null,"size":1011,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpe-storage:plugin_v2","ref":"plugin_v2","sha":"80fdd87b3bf4119b01ebb244b6c796613c225192","user":{"login":"hpe-storage","id":15615575,"avatar_url":"https://avatars2.githubusercontent.com/u/15615575?v=4","gravatar_id":"","url":"https://api.github.com/users/hpe-storage","html_url":"https://github.com/hpe-storage","followers_url":"https://api.github.com/users/hpe-storage/followers","following_url":"https://api.github.com/users/hpe-storage/following{/other_user}","gists_url":"https://api.github.com/users/hpe-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/hpe-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpe-storage/subscriptions","organizations_url":"https://api.github.com/users/hpe-storage/orgs","repos_url":"https://api.github.com/users/hpe-storage/repos","events_url":"https://api.github.com/users/hpe-storage/events{/privacy}","received_events_url":"https://api.github.com/users/hpe-storage/received_events","type":"User","site_admin":false},"repo":{"id":60213862,"name":"python-hpedockerplugin","full_name":"hpe-storage/python-hpedockerplugin","owner":{"login":"hpe-storage","id":15615575,"avatar_url":"https://avatars2.githubusercontent.com/u/15615575?v=4","gravatar_id":"","url":"https://api.github.com/users/hpe-storage","html_url":"https://github.com/hpe-storage","followers_url":"https://api.github.com/users/hpe-storage/followers","following_url":"https://api.github.com/users/hpe-storage/following{/other_user}","gists_url":"https://api.github.com/users/hpe-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/hpe-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpe-storage/subscriptions","organizations_url":"https://api.github.com/users/hpe-storage/orgs","repos_url":"https://api.github.com/users/hpe-storage/repos","events_url":"https://api.github.com/users/hpe-storage/events{/privacy}","received_events_url":"https://api.github.com/users/hpe-storage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hpe-storage/python-hpedockerplugin","description":"HPE Native Docker Plugin","fork":false,"url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin","forks_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/forks","keys_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/teams","hooks_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/hooks","issue_events_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/events{/number}","events_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/events","assignees_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/assignees{/user}","branches_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/branches{/branch}","tags_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/tags","blobs_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/languages","stargazers_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/stargazers","contributors_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/contributors","subscribers_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/subscribers","subscription_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/subscription","commits_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/contents/{+path}","compare_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/merges","archive_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/downloads","issues_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues{/number}","pulls_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/labels{/name}","releases_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/releases{/id}","deployments_url":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/deployments","created_at":"2016-06-01T22:04:03Z","updated_at":"2018-02-13T22:52:11Z","pushed_at":"2018-03-16T10:35:28Z","git_url":"git://github.com/hpe-storage/python-hpedockerplugin.git","ssh_url":"git@github.com:hpe-storage/python-hpedockerplugin.git","clone_url":"https://github.com/hpe-storage/python-hpedockerplugin.git","svn_url":"https://github.com/hpe-storage/python-hpedockerplugin","homepage":null,"size":1044,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":23,"open_issues":33,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152"},"html":{"href":"https://github.com/hpe-storage/python-hpedockerplugin/pull/152"},"issue":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/152"},"comments":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/hpe-storage/python-hpedockerplugin/statuses/541ecbbd57b938d426e06755f14974047e158b36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wdurairaj"}}