{"action":"created","comment":{"url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/comments/192365701","pull_request_review_id":125129967,"id":192365701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM2NTcwMQ==","diff_hunk":"@@ -61,6 +61,26 @@ internal DatatypeDefinitionInteger(ReqIFContent reqIfContent)\n         /// </summary>\n         public int Max { get; set; }\n \n+        /// <summary>\n+        /// Generates a <see cref=\"AttributeDefinition\"/> object from its XML representation.\n+        /// </summary>\n+        /// <param name=\"reader\">\n+        /// an instance of <see cref=\"XmlReader\"/>\n+        /// </param>\n+        public override void ReadXml(XmlReader reader)\n+        {\n+            base.ReadXml(reader);\n+\n+            if (int.TryParse(reader.GetAttribute(\"MAX\"), out int max))\n+            {\n+                this.Max = max;\n+            }\n+            if (int.TryParse(reader.GetAttribute(\"MIN\"), out int min))","path":"ReqIFSharp/Datatype/DatatypeDefinitionInteger.cs","position":18,"original_position":18,"commit_id":"380ded52ce81cecacd386d5ae37ecd76ee333f08","original_commit_id":"380ded52ce81cecacd386d5ae37ecd76ee333f08","user":{"login":"samatrhea","id":22165725,"node_id":"MDQ6VXNlcjIyMTY1NzI1","avatar_url":"https://avatars3.githubusercontent.com/u/22165725?v=4","gravatar_id":"","url":"https://api.github.com/users/samatrhea","html_url":"https://github.com/samatrhea","followers_url":"https://api.github.com/users/samatrhea/followers","following_url":"https://api.github.com/users/samatrhea/following{/other_user}","gists_url":"https://api.github.com/users/samatrhea/gists{/gist_id}","starred_url":"https://api.github.com/users/samatrhea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samatrhea/subscriptions","organizations_url":"https://api.github.com/users/samatrhea/orgs","repos_url":"https://api.github.com/users/samatrhea/repos","events_url":"https://api.github.com/users/samatrhea/events{/privacy}","received_events_url":"https://api.github.com/users/samatrhea/received_events","type":"User","site_admin":false},"body":"styling: please add empty line after 77","created_at":"2018-06-01T11:15:23Z","updated_at":"2018-06-01T11:28:38Z","html_url":"https://github.com/RHEAGROUP/reqifsharp/pull/2#discussion_r192365701","pull_request_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/comments/192365701"},"html":{"href":"https://github.com/RHEAGROUP/reqifsharp/pull/2#discussion_r192365701"},"pull_request":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2","id":192002515,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDAyNTE1","html_url":"https://github.com/RHEAGROUP/reqifsharp/pull/2","diff_url":"https://github.com/RHEAGROUP/reqifsharp/pull/2.diff","patch_url":"https://github.com/RHEAGROUP/reqifsharp/pull/2.patch","issue_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/2","number":2,"state":"open","locked":false,"title":"Fix reading of \"MAX\", \"MIN\" attributes","user":{"login":"bidolah","id":9832538,"node_id":"MDQ6VXNlcjk4MzI1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9832538?v=4","gravatar_id":"","url":"https://api.github.com/users/bidolah","html_url":"https://github.com/bidolah","followers_url":"https://api.github.com/users/bidolah/followers","following_url":"https://api.github.com/users/bidolah/following{/other_user}","gists_url":"https://api.github.com/users/bidolah/gists{/gist_id}","starred_url":"https://api.github.com/users/bidolah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bidolah/subscriptions","organizations_url":"https://api.github.com/users/bidolah/orgs","repos_url":"https://api.github.com/users/bidolah/repos","events_url":"https://api.github.com/users/bidolah/events{/privacy}","received_events_url":"https://api.github.com/users/bidolah/received_events","type":"User","site_admin":false},"body":"Fix reading of \"MAX\", \"MIN\" attributes for \"DATATYPE-DEFINITION-INTEGER\" and \"DATATYPE-DEFINITION-REAL\"\r\n\r\nI plan to add tests later in another PR. Sorry, but I do not have any free time at this moment. ","created_at":"2018-06-01T11:03:17Z","updated_at":"2018-06-01T11:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28660e6345c65721ca6438861a9fb21203bbfb1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/2/comments","statuses_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/statuses/380ded52ce81cecacd386d5ae37ecd76ee333f08","head":{"label":"bidolah:development","ref":"development","sha":"380ded52ce81cecacd386d5ae37ecd76ee333f08","user":{"login":"bidolah","id":9832538,"node_id":"MDQ6VXNlcjk4MzI1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9832538?v=4","gravatar_id":"","url":"https://api.github.com/users/bidolah","html_url":"https://github.com/bidolah","followers_url":"https://api.github.com/users/bidolah/followers","following_url":"https://api.github.com/users/bidolah/following{/other_user}","gists_url":"https://api.github.com/users/bidolah/gists{/gist_id}","starred_url":"https://api.github.com/users/bidolah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bidolah/subscriptions","organizations_url":"https://api.github.com/users/bidolah/orgs","repos_url":"https://api.github.com/users/bidolah/repos","events_url":"https://api.github.com/users/bidolah/events{/privacy}","received_events_url":"https://api.github.com/users/bidolah/received_events","type":"User","site_admin":false},"repo":{"id":135203926,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyMDM5MjY=","name":"reqifsharp","full_name":"bidolah/reqifsharp","owner":{"login":"bidolah","id":9832538,"node_id":"MDQ6VXNlcjk4MzI1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9832538?v=4","gravatar_id":"","url":"https://api.github.com/users/bidolah","html_url":"https://github.com/bidolah","followers_url":"https://api.github.com/users/bidolah/followers","following_url":"https://api.github.com/users/bidolah/following{/other_user}","gists_url":"https://api.github.com/users/bidolah/gists{/gist_id}","starred_url":"https://api.github.com/users/bidolah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bidolah/subscriptions","organizations_url":"https://api.github.com/users/bidolah/orgs","repos_url":"https://api.github.com/users/bidolah/repos","events_url":"https://api.github.com/users/bidolah/events{/privacy}","received_events_url":"https://api.github.com/users/bidolah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bidolah/reqifsharp","description":"A C# library for reading and writing reqif documents","fork":true,"url":"https://api.github.com/repos/bidolah/reqifsharp","forks_url":"https://api.github.com/repos/bidolah/reqifsharp/forks","keys_url":"https://api.github.com/repos/bidolah/reqifsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bidolah/reqifsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bidolah/reqifsharp/teams","hooks_url":"https://api.github.com/repos/bidolah/reqifsharp/hooks","issue_events_url":"https://api.github.com/repos/bidolah/reqifsharp/issues/events{/number}","events_url":"https://api.github.com/repos/bidolah/reqifsharp/events","assignees_url":"https://api.github.com/repos/bidolah/reqifsharp/assignees{/user}","branches_url":"https://api.github.com/repos/bidolah/reqifsharp/branches{/branch}","tags_url":"https://api.github.com/repos/bidolah/reqifsharp/tags","blobs_url":"https://api.github.com/repos/bidolah/reqifsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bidolah/reqifsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bidolah/reqifsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bidolah/reqifsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bidolah/reqifsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/bidolah/reqifsharp/languages","stargazers_url":"https://api.github.com/repos/bidolah/reqifsharp/stargazers","contributors_url":"https://api.github.com/repos/bidolah/reqifsharp/contributors","subscribers_url":"https://api.github.com/repos/bidolah/reqifsharp/subscribers","subscription_url":"https://api.github.com/repos/bidolah/reqifsharp/subscription","commits_url":"https://api.github.com/repos/bidolah/reqifsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bidolah/reqifsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bidolah/reqifsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bidolah/reqifsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bidolah/reqifsharp/contents/{+path}","compare_url":"https://api.github.com/repos/bidolah/reqifsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bidolah/reqifsharp/merges","archive_url":"https://api.github.com/repos/bidolah/reqifsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bidolah/reqifsharp/downloads","issues_url":"https://api.github.com/repos/bidolah/reqifsharp/issues{/number}","pulls_url":"https://api.github.com/repos/bidolah/reqifsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/bidolah/reqifsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/bidolah/reqifsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bidolah/reqifsharp/labels{/name}","releases_url":"https://api.github.com/repos/bidolah/reqifsharp/releases{/id}","deployments_url":"https://api.github.com/repos/bidolah/reqifsharp/deployments","created_at":"2018-05-28T20:00:23Z","updated_at":"2018-06-01T11:07:38Z","pushed_at":"2018-06-01T11:07:36Z","git_url":"git://github.com/bidolah/reqifsharp.git","ssh_url":"git@github.com:bidolah/reqifsharp.git","clone_url":"https://github.com/bidolah/reqifsharp.git","svn_url":"https://github.com/bidolah/reqifsharp","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"RHEAGROUP:development","ref":"development","sha":"688a4298622f82c7ba1dec01cb8546ca26749c2e","user":{"login":"RHEAGROUP","id":22165742,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTY1NzQy","avatar_url":"https://avatars2.githubusercontent.com/u/22165742?v=4","gravatar_id":"","url":"https://api.github.com/users/RHEAGROUP","html_url":"https://github.com/RHEAGROUP","followers_url":"https://api.github.com/users/RHEAGROUP/followers","following_url":"https://api.github.com/users/RHEAGROUP/following{/other_user}","gists_url":"https://api.github.com/users/RHEAGROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/RHEAGROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RHEAGROUP/subscriptions","organizations_url":"https://api.github.com/users/RHEAGROUP/orgs","repos_url":"https://api.github.com/users/RHEAGROUP/repos","events_url":"https://api.github.com/users/RHEAGROUP/events{/privacy}","received_events_url":"https://api.github.com/users/RHEAGROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":78343798,"node_id":"MDEwOlJlcG9zaXRvcnk3ODM0Mzc5OA==","name":"reqifsharp","full_name":"RHEAGROUP/reqifsharp","owner":{"login":"RHEAGROUP","id":22165742,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTY1NzQy","avatar_url":"https://avatars2.githubusercontent.com/u/22165742?v=4","gravatar_id":"","url":"https://api.github.com/users/RHEAGROUP","html_url":"https://github.com/RHEAGROUP","followers_url":"https://api.github.com/users/RHEAGROUP/followers","following_url":"https://api.github.com/users/RHEAGROUP/following{/other_user}","gists_url":"https://api.github.com/users/RHEAGROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/RHEAGROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RHEAGROUP/subscriptions","organizations_url":"https://api.github.com/users/RHEAGROUP/orgs","repos_url":"https://api.github.com/users/RHEAGROUP/repos","events_url":"https://api.github.com/users/RHEAGROUP/events{/privacy}","received_events_url":"https://api.github.com/users/RHEAGROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RHEAGROUP/reqifsharp","description":"A C# library for reading and writing reqif documents","fork":false,"url":"https://api.github.com/repos/RHEAGROUP/reqifsharp","forks_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/forks","keys_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/teams","hooks_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/hooks","issue_events_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/events{/number}","events_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/events","assignees_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/assignees{/user}","branches_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/branches{/branch}","tags_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/tags","blobs_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/languages","stargazers_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/stargazers","contributors_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/contributors","subscribers_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/subscribers","subscription_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/subscription","commits_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/contents/{+path}","compare_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/merges","archive_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/downloads","issues_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues{/number}","pulls_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/labels{/name}","releases_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/releases{/id}","deployments_url":"https://api.github.com/repos/RHEAGROUP/reqifsharp/deployments","created_at":"2017-01-08T13:17:49Z","updated_at":"2018-05-28T07:33:53Z","pushed_at":"2018-06-01T11:07:37Z","git_url":"git://github.com/RHEAGROUP/reqifsharp.git","ssh_url":"git@github.com:RHEAGROUP/reqifsharp.git","clone_url":"https://github.com/RHEAGROUP/reqifsharp.git","svn_url":"https://github.com/RHEAGROUP/reqifsharp","homepage":null,"size":196,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":5,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2"},"html":{"href":"https://github.com/RHEAGROUP/reqifsharp/pull/2"},"issue":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/2"},"comments":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/RHEAGROUP/reqifsharp/statuses/380ded52ce81cecacd386d5ae37ecd76ee333f08"}},"author_association":"NONE"}}
{"actor":{"display_login":"samatrhea"}}