{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/189859957","pull_request_review_id":122117712,"id":189859957,"diff_hunk":"@@ -150,6 +150,10 @@ public CharSequence subSequence(final int start, final int end) {\n       return subSeq(start, end);\n    }\n \n+   public static boolean compare(SimpleString s1, SimpleString s2) {","path":"artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java","position":4,"original_position":4,"commit_id":"39488e6cd21b96e06a3b7ab6f72ac8df62a39551","original_commit_id":"39488e6cd21b96e06a3b7ab6f72ac8df62a39551","user":{"login":"franz1981","id":13125299,"avatar_url":"https://avatars2.githubusercontent.com/u/13125299?v=4","gravatar_id":"","url":"https://api.github.com/users/franz1981","html_url":"https://github.com/franz1981","followers_url":"https://api.github.com/users/franz1981/followers","following_url":"https://api.github.com/users/franz1981/following{/other_user}","gists_url":"https://api.github.com/users/franz1981/gists{/gist_id}","starred_url":"https://api.github.com/users/franz1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz1981/subscriptions","organizations_url":"https://api.github.com/users/franz1981/orgs","repos_url":"https://api.github.com/users/franz1981/repos","events_url":"https://api.github.com/users/franz1981/events{/privacy}","received_events_url":"https://api.github.com/users/franz1981/received_events","type":"User","site_admin":false},"body":"you can call it equals as well, `compare` usually is used for `Comparator` API-like ie that return a `int` value","created_at":"2018-05-22T11:02:16Z","updated_at":"2018-05-22T11:02:16Z","html_url":"https://github.com/apache/activemq-artemis/pull/2093#discussion_r189859957","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/189859957"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2093#discussion_r189859957"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093"}}},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093","id":189141435,"html_url":"https://github.com/apache/activemq-artemis/pull/2093","diff_url":"https://github.com/apache/activemq-artemis/pull/2093.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2093.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2093","number":2093,"state":"open","locked":false,"title":"ARTEMIS-1872 Check for queue exists before creating shared queue","user":{"login":"michaelandrepearce","id":1387822,"avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"body":"1. Add tests case to verify issue and fix, tests also tests for same behavior using CORE, OPENWIRE and AMQP JMS Clients.\r\n2. Update Core Client to check for queue before creating, sharedQueue as per createQueue logic.\r\n3. Update ServerSessionPacketHandler to handle packets from old clients to perform to implement the same fix server side for older clients.\r\n4. Correct AMQP protocol so correct error code is returned on security exception so that amqp jms can correctly throw JMSsecurityException\r\n5. Correct AMQP protocol to check for queue exists before create\r\n6. Correct OpenWire protocol to check for address exists before create","created_at":"2018-05-18T21:41:37Z","updated_at":"2018-05-22T11:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0474a41b8c3bdd3b901d6619afecd08372a4df9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2093/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/39488e6cd21b96e06a3b7ab6f72ac8df62a39551","head":{"label":"michaelandrepearce:ARTEMIS-1872","ref":"ARTEMIS-1872","sha":"39488e6cd21b96e06a3b7ab6f72ac8df62a39551","user":{"login":"michaelandrepearce","id":1387822,"avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"repo":{"id":90807775,"name":"activemq-artemis","full_name":"michaelandrepearce/activemq-artemis","owner":{"login":"michaelandrepearce","id":1387822,"avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelandrepearce/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis","forks_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/forks","keys_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/events","assignees_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/merges","archive_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/deployments","created_at":"2017-05-10T01:29:30Z","updated_at":"2017-05-10T01:29:44Z","pushed_at":"2018-05-22T07:38:12Z","git_url":"git://github.com/michaelandrepearce/activemq-artemis.git","ssh_url":"git@github.com:michaelandrepearce/activemq-artemis.git","clone_url":"https://github.com/michaelandrepearce/activemq-artemis.git","svn_url":"https://github.com/michaelandrepearce/activemq-artemis","homepage":"","size":51985,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"90273c92cc29e7ee67dd61d82879ce0107a279c4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"name":"activemq-artemis","full_name":"apache/activemq-artemis","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2018-05-22T10:18:39Z","pushed_at":"2018-05-22T10:18:35Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":51242,"stargazers_count":311,"watchers_count":311,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":346,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":346,"open_issues":15,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2093"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2093"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2093/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2093/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/39488e6cd21b96e06a3b7ab6f72ac8df62a39551"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"franz1981"}}