{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/210734796","pull_request_review_id":147015259,"id":210734796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDczNDc5Ng==","diff_hunk":"@@ -161,12 +159,16 @@ function (Okta, BaseLoginModel, CookieUtil, Enums) {\n       }\n     },\n \n-    doPrimaryAuth: function (authClient, deviceFingerprintEnabled, signInArgs, func) {\n+    doPrimaryAuth: function (authClient, signInArgs, func) {\n+      var deviceFingerprintEnabled = this.settings.get('features.deviceFingerprinting');\n       // Add the custom header for fingerprint if needed, and then remove it afterwards\n       // Since we only need to send it for primary auth","path":"src/models/PrimaryAuth.js","position":null,"original_position":38,"commit_id":"ae72dcaa42ea21cb80172fb443c6a1f9da0732db","original_commit_id":"74372decf1318b8380e3903edcb6762880e02aca","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"body":"Good catch ! Fixed now. ","created_at":"2018-08-16T20:41:04Z","updated_at":"2018-08-16T20:41:04Z","html_url":"https://github.com/okta/okta-signin-widget/pull/521#discussion_r210734796","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/210734796"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/521#discussion_r210734796"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521"}},"in_reply_to_id":210708408},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521","id":208618473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjE4NDcz","html_url":"https://github.com/okta/okta-signin-widget/pull/521","diff_url":"https://github.com/okta/okta-signin-widget/pull/521.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/521.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/521","number":521,"state":"open","locked":false,"title":":seedling: Added Typing Biometrics","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"body":"* Added ability to track user typing pattern behind a flag trackTypingPattern.\r\n* Using external TypingDNA library https://github.com/TypingDNA/TypingDnaRecorder-JavaScript\r\nChecking in it in as it is not available as a npm dist.\r\n\r\n@rpamidimarri-okta  @chrisleung-okta  \r\nThe X-Typing-Pattern header is \r\n1) **null** when - there is any error in capturing the pattern or in cases where usernams are autofilled. \r\n2) **undefined** when flag is off\r\n3) present - if flag is on and data was captured successfully\r\n\r\nLet me know if this is okay. \r\n\r\n<img width=\"1190\" alt=\"screen shot 2018-08-14 at 3 50 05 pm\" src=\"https://user-images.githubusercontent.com/17267130/44160879-99af8b80-a070-11e8-85aa-85eac96b14ea.png\">\r\n\r\nEdited  username\r\n![typing](https://user-images.githubusercontent.com/17267130/44160901-ac29c500-a070-11e8-896b-3761d35db907.gif)\r\n","created_at":"2018-08-15T16:51:06Z","updated_at":"2018-08-16T20:41:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"316390ae42563255e8aeb155708c6d58247d58d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisleung-okta","id":39062148,"node_id":"MDQ6VXNlcjM5MDYyMTQ4","avatar_url":"https://avatars1.githubusercontent.com/u/39062148?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisleung-okta","html_url":"https://github.com/chrisleung-okta","followers_url":"https://api.github.com/users/chrisleung-okta/followers","following_url":"https://api.github.com/users/chrisleung-okta/following{/other_user}","gists_url":"https://api.github.com/users/chrisleung-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisleung-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisleung-okta/subscriptions","organizations_url":"https://api.github.com/users/chrisleung-okta/orgs","repos_url":"https://api.github.com/users/chrisleung-okta/repos","events_url":"https://api.github.com/users/chrisleung-okta/events{/privacy}","received_events_url":"https://api.github.com/users/chrisleung-okta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/521/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/ae72dcaa42ea21cb80172fb443c6a1f9da0732db","head":{"label":"magizh-okta:mt-okta-178321-typing","ref":"mt-okta-178321-typing","sha":"ae72dcaa42ea21cb80172fb443c6a1f9da0732db","user":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"repo":{"id":86117589,"node_id":"MDEwOlJlcG9zaXRvcnk4NjExNzU4OQ==","name":"okta-signin-widget","full_name":"magizh-okta/okta-signin-widget","owner":{"login":"magizh-okta","id":17267130,"node_id":"MDQ6VXNlcjE3MjY3MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/17267130?v=4","gravatar_id":"","url":"https://api.github.com/users/magizh-okta","html_url":"https://github.com/magizh-okta","followers_url":"https://api.github.com/users/magizh-okta/followers","following_url":"https://api.github.com/users/magizh-okta/following{/other_user}","gists_url":"https://api.github.com/users/magizh-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/magizh-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magizh-okta/subscriptions","organizations_url":"https://api.github.com/users/magizh-okta/orgs","repos_url":"https://api.github.com/users/magizh-okta/repos","events_url":"https://api.github.com/users/magizh-okta/events{/privacy}","received_events_url":"https://api.github.com/users/magizh-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magizh-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/magizh-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/magizh-okta/okta-signin-widget/deployments","created_at":"2017-03-24T23:07:17Z","updated_at":"2018-08-07T19:08:50Z","pushed_at":"2018-08-16T20:40:58Z","git_url":"git://github.com/magizh-okta/okta-signin-widget.git","ssh_url":"git@github.com:magizh-okta/okta-signin-widget.git","clone_url":"https://github.com/magizh-okta/okta-signin-widget.git","svn_url":"https://github.com/magizh-okta/okta-signin-widget","homepage":null,"size":19133,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"b2850072ab1b7be6b150dc0cde8dfa27851c3acd","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-08-16T11:40:35Z","pushed_at":"2018-08-16T20:40:59Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":19380,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":88,"open_issues":45,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/521"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/521"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/ae72dcaa42ea21cb80172fb443c6a1f9da0732db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"magizh-okta"}}