{"action":"closed","number":2377,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2377","id":167772049,"html_url":"https://github.com/ripple/rippled/pull/2377","diff_url":"https://github.com/ripple/rippled/pull/2377.diff","patch_url":"https://github.com/ripple/rippled/pull/2377.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2377","number":2377,"state":"closed","locked":false,"title":"Json cleanup","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars2.githubusercontent.com/u/6708789?v=4","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"body":"This PR is intended to have minimal behavioral change.  It renames the existing `isObject` member function of `Json::Value` to `isObjectorNull` since this is what that member function actually checks.  Then it adds a new `isObject` that only checks if the value has object type, and changes as many `isObjectorNull` back to `isObject` as possible.  Ditto for `isArray`.\r\n\r\nReviewers should concentrate on the 3rd commit ensuring that no change from `isXxxorNull` back to `isXxx` is incorrect, and that no opportunities to do so have been missed.\r\n\r\nThe rationale is that it makes the code easier to read because it was very easy to forget that `isObject` answers to true to a null value.\r\n\r\nAs the 3rd commit touches many parts of rippled, please feel free to suggest other reviewers, and limit yourself to just those parts of rippled you feel comfortable (or are interested in) reviewing.  Thanks.","created_at":"2018-02-07T18:26:07Z","updated_at":"2018-03-02T23:49:10Z","closed_at":"2018-03-02T23:49:10Z","merged_at":null,"merge_commit_sha":"5f83d1a3410ee508913844678685068ceb8dd398","assignee":{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars0.githubusercontent.com/u/7840379?v=4","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":145690697,"url":"https://api.github.com/repos/ripple/rippled/labels/Passed","name":"Passed","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/2377/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/2377/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2377/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/e81908a2effa1aa5f6b602da6d4cc2fef01a7689","head":{"label":"HowardHinnant:json_cleanup","ref":"json_cleanup","sha":"e81908a2effa1aa5f6b602da6d4cc2fef01a7689","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars2.githubusercontent.com/u/6708789?v=4","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"repo":{"id":16925449,"name":"rippled","full_name":"HowardHinnant/rippled","owner":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars2.githubusercontent.com/u/6708789?v=4","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HowardHinnant/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/HowardHinnant/rippled","forks_url":"https://api.github.com/repos/HowardHinnant/rippled/forks","keys_url":"https://api.github.com/repos/HowardHinnant/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HowardHinnant/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HowardHinnant/rippled/teams","hooks_url":"https://api.github.com/repos/HowardHinnant/rippled/hooks","issue_events_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/HowardHinnant/rippled/events","assignees_url":"https://api.github.com/repos/HowardHinnant/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/HowardHinnant/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/HowardHinnant/rippled/tags","blobs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HowardHinnant/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/HowardHinnant/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HowardHinnant/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/HowardHinnant/rippled/languages","stargazers_url":"https://api.github.com/repos/HowardHinnant/rippled/stargazers","contributors_url":"https://api.github.com/repos/HowardHinnant/rippled/contributors","subscribers_url":"https://api.github.com/repos/HowardHinnant/rippled/subscribers","subscription_url":"https://api.github.com/repos/HowardHinnant/rippled/subscription","commits_url":"https://api.github.com/repos/HowardHinnant/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/HowardHinnant/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/HowardHinnant/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/HowardHinnant/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/HowardHinnant/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HowardHinnant/rippled/merges","archive_url":"https://api.github.com/repos/HowardHinnant/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HowardHinnant/rippled/downloads","issues_url":"https://api.github.com/repos/HowardHinnant/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/HowardHinnant/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/HowardHinnant/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/HowardHinnant/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HowardHinnant/rippled/labels{/name}","releases_url":"https://api.github.com/repos/HowardHinnant/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/HowardHinnant/rippled/deployments","created_at":"2014-02-17T20:21:56Z","updated_at":"2015-04-07T16:53:12Z","pushed_at":"2018-02-28T16:11:41Z","git_url":"git://github.com/HowardHinnant/rippled.git","ssh_url":"git@github.com:HowardHinnant/rippled.git","clone_url":"https://github.com/HowardHinnant/rippled.git","svn_url":"https://github.com/HowardHinnant/rippled","homepage":"https://ripple.com","size":98884,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"5807ce21278951e3582e2fbc5eafa8b30c91e244","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2018-03-02T13:27:41Z","pushed_at":"2018-03-02T23:46:10Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com/xrp","size":92786,"stargazers_count":2549,"watchers_count":2549,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":722,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":722,"open_issues":106,"watchers":2549,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2377"},"html":{"href":"https://github.com/ripple/rippled/pull/2377"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/2377"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/2377/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2377/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2377/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/e81908a2effa1aa5f6b602da6d4cc2fef01a7689"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":60,"maintainer_can_modify":false,"commits":6,"additions":90,"deletions":63,"changed_files":24}}
{"actor":{"display_login":"mellery451"}}