{"action":"created","issue":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/49","repository_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB","labels_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/49/comments","events_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/49/events","html_url":"https://github.com/RxSwiftCommunity/RxGRDB/issues/49","id":378292589,"node_id":"MDU6SXNzdWUzNzgyOTI1ODk=","number":49,"title":"RxGRDB backward compatibility v0.11 to v0.12.1 Cocoapods","user":{"login":"KingConnors","id":39980719,"node_id":"MDQ6VXNlcjM5OTgwNzE5","avatar_url":"https://avatars1.githubusercontent.com/u/39980719?v=4","gravatar_id":"","url":"https://api.github.com/users/KingConnors","html_url":"https://github.com/KingConnors","followers_url":"https://api.github.com/users/KingConnors/followers","following_url":"https://api.github.com/users/KingConnors/following{/other_user}","gists_url":"https://api.github.com/users/KingConnors/gists{/gist_id}","starred_url":"https://api.github.com/users/KingConnors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingConnors/subscriptions","organizations_url":"https://api.github.com/users/KingConnors/orgs","repos_url":"https://api.github.com/users/KingConnors/repos","events_url":"https://api.github.com/users/KingConnors/events{/privacy}","received_events_url":"https://api.github.com/users/KingConnors/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T13:42:27Z","updated_at":"2018-11-07T14:14:21Z","closed_at":null,"author_association":"NONE","body":"Hi Groue,\r\n\r\nI've been making fair use of your library so far, implementing an example for the DatabaseRegionConvertible protocol to have observable regions for joined queries. And it has come to my attention that v0.13.0 it no longer supports the fetch:from: method. Instead it now tells us to use the ValueObservation struct.\r\n\r\nI had the DatabaseRegionConvertible protocol implement in a few places and naturally the breaking changes made me have to revisit these to implement them using the ValueObservation struct.\r\n\r\nMy first reaction however was to port back, using Cocoapods, to a previous version of RxGRDB to keep using the DatabaseRegionConvertible protocol and look at a way to implement the struct later.\r\n\r\nHowever the podspec v0.11.0 to 0.12.1 of RxGRDB have a dependency on GRDB or GRDBCipher for version '~> 3.0', which picks up the latest version being 3.5.\r\n\r\nIn these versions RxGRDB still has the DatabaseRegionConvertible.swift file which implements the Protocol. But now the GRDB and GRDBCipher versions also contain an implementation of the protocol, which gives a bunch of 'Ambigious' type errors.\r\n\r\nSo basically my question is if the dependencies in the cocoapod files for these versions could be set to a specific version of the GRDB or GRDBCipher.\r\n\r\nI suppose I could have made a pull request for this change, but I don't feel comfortable doing this yet. And it seems to me this change would need to be pushed towards the cocoapods reposit as well. My apologies for this. I hope my story made some sense and didn't mess up the terminology of the project to much."},"comment":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/comments/436635942","html_url":"https://github.com/RxSwiftCommunity/RxGRDB/issues/49#issuecomment-436635942","issue_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/49","id":436635942,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjYzNTk0Mg==","user":{"login":"groue","id":54219,"node_id":"MDQ6VXNlcjU0MjE5","avatar_url":"https://avatars2.githubusercontent.com/u/54219?v=4","gravatar_id":"","url":"https://api.github.com/users/groue","html_url":"https://github.com/groue","followers_url":"https://api.github.com/users/groue/followers","following_url":"https://api.github.com/users/groue/following{/other_user}","gists_url":"https://api.github.com/users/groue/gists{/gist_id}","starred_url":"https://api.github.com/users/groue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groue/subscriptions","organizations_url":"https://api.github.com/users/groue/orgs","repos_url":"https://api.github.com/users/groue/repos","events_url":"https://api.github.com/users/groue/events{/privacy}","received_events_url":"https://api.github.com/users/groue/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T14:14:21Z","updated_at":"2018-11-07T14:14:21Z","author_association":"COLLABORATOR","body":"Hello @KingConnors,\r\n\r\n> In these versions RxGRDB still has the DatabaseRegionConvertible.swift file which implements the Protocol. But now the GRDB and GRDBCipher versions also contain an implementation of the protocol, which gives a bunch of 'Ambigious' type errors.\r\n\r\nHmm, I see. My tests showed no conflict, but I didn't check your setup.\r\n\r\nRxGRDB is still in the 0.x versioning phase, so breaking changes are to be expected. Yet it's not nice when there is no easy workaround 😅 \r\n\r\n> So basically my question is if the dependencies in the cocoapod files for these versions could be set to a specific version of the GRDB or GRDBCipher.\r\n\r\nIndeed, RxGRDB before 0.13.0 will conflict with GRDB 3.5. Those versions are sort of dead now.\r\n\r\nWe could sort of fix this by introducing RxGRDB 0.12.2 with a hard-coded dependency on GRDB 3.4.0. Is this what you had in mind?"}}
{"actor":{"display_login":"groue"}}