{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/4240","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/4240/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/4240/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/4240/events","html_url":"https://github.com/triplea-game/triplea/pull/4240","id":374544522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjIzNjk2","number":4240,"title":"Remove InternalDoNotExport annotation","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T20:55:46Z","updated_at":"2018-10-26T21:08:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/4240","html_url":"https://github.com/triplea-game/triplea/pull/4240","diff_url":"https://github.com/triplea-game/triplea/pull/4240.diff","patch_url":"https://github.com/triplea-game/triplea/pull/4240.patch"},"body":"## Overview\r\n\r\nRemoves the `InternalDoNotExport` annotation.\r\n\r\nAFAICT, this annotation no longer serves any purpose.  It was previously used by `GameParser` and `PropertyUtil` (a class that no longer exists) when the reflection-based machinery was still in place.  As everything is now controlled by the map returned from `DynamicallyModifiable#getPropertyMap()`, the configuration of a property in that map (including its absence)  seems to take the place of this annotation.\r\n\r\n@RoiEXLab @ron-murhammer Is there some useful purpose for `InternalDoNotExport` that I'm missing here (e.g. documentation that is not already covered by `getPropertyMap()`)?\r\n\r\n## Functional Changes\r\n\r\nNone.\r\n\r\n## Manual Testing Performed\r\n\r\nSmoke tested a peer-to-peer network game with both AI and human players."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/433544005","html_url":"https://github.com/triplea-game/triplea/pull/4240#issuecomment-433544005","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/4240","id":433544005,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzU0NDAwNQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T21:08:44Z","updated_at":"2018-10-26T21:08:44Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=h1) Report\n> Merging [#4240](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/4df5b2db397238b03a482d12d8616521f05b20c7?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/4240/graphs/tree.svg?width=650&token=QPS14q4xnG&height=150&src=pr)](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #4240      +/-   ##\n============================================\n- Coverage     22.54%   22.54%   -0.01%     \n+ Complexity     6094     6093       -1     \n============================================\n  Files           871      871              \n  Lines         71319    71319              \n  Branches      11390    11390              \n============================================\n- Hits          16081    16080       -1     \n- Misses        53173    53174       +1     \n  Partials       2065     2065\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [.../games/strategy/engine/data/DefaultAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvRGVmYXVsdEF0dGFjaG1lbnQuamF2YQ==) | `100% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |\n| [.../strategy/triplea/attachments/RulesAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9SdWxlc0F0dGFjaG1lbnQuamF2YQ==) | `36.96% <ø> (ø)` | `93 <0> (ø)` | :arrow_down: |\n| [...plea/attachments/AbstractUserActionAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9BYnN0cmFjdFVzZXJBY3Rpb25BdHRhY2htZW50LmphdmE=) | `48.35% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |\n| [...y/triplea/attachments/AbstractRulesAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9BYnN0cmFjdFJ1bGVzQXR0YWNobWVudC5qYXZh) | `48.25% <ø> (ø)` | `36 <0> (ø)` | :arrow_down: |\n| [...triplea/attachments/AbstractTriggerAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9BYnN0cmFjdFRyaWdnZXJBdHRhY2htZW50LmphdmE=) | `50% <ø> (ø)` | `32 <0> (ø)` | :arrow_down: |\n| [.../games/strategy/engine/data/GameDataComponent.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvR2FtZURhdGFDb21wb25lbnQuamF2YQ==) | `100% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |\n| [...triplea/attachments/TerritoryEffectAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9UZXJyaXRvcnlFZmZlY3RBdHRhY2htZW50LmphdmE=) | `58.97% <ø> (ø)` | `16 <0> (ø)` | :arrow_down: |\n| [...egy/triplea/attachments/UnitSupportAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9Vbml0U3VwcG9ydEF0dGFjaG1lbnQuamF2YQ==) | `70.81% <ø> (ø)` | `51 <0> (ø)` | :arrow_down: |\n| [...egy/triplea/attachments/TechAbilityAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9UZWNoQWJpbGl0eUF0dGFjaG1lbnQuamF2YQ==) | `63.45% <ø> (ø)` | `99 <0> (ø)` | :arrow_down: |\n| [...java/games/strategy/engine/xml/TestAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL3htbC9UZXN0QXR0YWNobWVudC5qYXZh) | `73.33% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |\n| ... and [2 more](https://codecov.io/gh/triplea-game/triplea/pull/4240/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=footer). Last update [4df5b2d...03aea03](https://codecov.io/gh/triplea-game/triplea/pull/4240?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}