{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/14003","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/14003/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/14003/comments","events_url":"https://api.github.com/repos/facebook/react/issues/14003/events","html_url":"https://github.com/facebook/react/pull/14003","id":374678632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzE2Nzc1","number":14003,"title":"chore(tests): don't rely on jest fake timers scheduling real timers","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-27T19:12:39Z","updated_at":"2018-11-04T23:32:29Z","closed_at":"2018-11-02T21:54:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14003","html_url":"https://github.com/facebook/react/pull/14003","diff_url":"https://github.com/facebook/react/pull/14003.diff","patch_url":"https://github.com/facebook/react/pull/14003.patch"},"body":"I'm currently working on replacing Jest's custom fake timers implementation with Lolex (https://github.com/facebook/jest/pull/5171). As part of that, I wanted to test that React's tests still work. They didn't...\r\n\r\nA quirk of Jest's current implementation is that we schedule `process.nextTick` and `setImmediate` on the real timers, even though they're faked. Then we just make sure to do nothing if Jest invoked the function when advancing time, or vice versa if Node triggered it before us. That behavior is intentionally _not_ re-implemented in the new version.\r\n\r\nThis PR changes from using `setImmediate` to `Promise.resolve().then()` to \"wait 1 tick\" which behaves the same."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/435719075","html_url":"https://github.com/facebook/react/pull/14003#issuecomment-435719075","issue_url":"https://api.github.com/repos/facebook/react/issues/14003","id":435719075,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTcxOTA3NQ==","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T23:32:29Z","updated_at":"2018-11-04T23:32:29Z","author_association":"CONTRIBUTOR","body":"Did it break anything, or is that just a precaution?"}}
{"actor":{"display_login":"SimenB"}}