{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67521","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67521/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67521/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67521/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67521","id":351408658,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDE0NzM1","number":67521,"title":"CRD supports multi-version Subresources and AdditionalPrintColumns","user":{"login":"roycaihw","id":6629765,"node_id":"MDQ6VXNlcjY2Mjk3NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6629765?v=4","gravatar_id":"","url":"https://api.github.com/users/roycaihw","html_url":"https://github.com/roycaihw","followers_url":"https://api.github.com/users/roycaihw/followers","following_url":"https://api.github.com/users/roycaihw/following{/other_user}","gists_url":"https://api.github.com/users/roycaihw/gists{/gist_id}","starred_url":"https://api.github.com/users/roycaihw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roycaihw/subscriptions","organizations_url":"https://api.github.com/users/roycaihw/orgs","repos_url":"https://api.github.com/users/roycaihw/repos","events_url":"https://api.github.com/users/roycaihw/events{/privacy}","received_events_url":"https://api.github.com/users/roycaihw/received_events","type":"User","site_admin":false},"labels":[{"id":556590057,"node_id":"MDU6TGFiZWw1NTY1OTAwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/custom-resources","name":"area/custom-resources","color":"0052cc","default":false},{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":203,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-09-05T23:07:14Z","due_on":null,"closed_at":null},"comments":36,"created_at":"2018-08-17T00:00:51Z","updated_at":"2018-09-05T23:26:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67521","html_url":"https://github.com/kubernetes/kubernetes/pull/67521","diff_url":"https://github.com/kubernetes/kubernetes/pull/67521.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67521.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nPart of the CRD conversion webhook KEP: https://github.com/kubernetes/community/pull/2420\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nMost line changes are indentation change in tests. Please hide whitespace changes when reviewing: https://github.com/kubernetes/kubernetes/pull/67521/files?w=1\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nCRD supports multi-version Subresources and AdditionalPrintColumns\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/418913240","html_url":"https://github.com/kubernetes/kubernetes/pull/67521#issuecomment-418913240","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67521","id":418913240,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODkxMzI0MA==","user":{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T23:26:08Z","updated_at":"2018-09-05T23:26:08Z","author_association":"MEMBER","body":"If by \"logical defaulting\" you mean the client or reader of a resource applies a default rather than apiserver before it sends an item to a client, that's an anti-pattern: it makes the defaults impossible to change centrally. If you meant something else, I didn't understand.\r\n\r\nEither way I have to work on other things, I asked Eric to take over for me."}}
{"actor":{"display_login":"lavalamp"}}