{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/228600190","pull_request_review_id":168916175,"id":228600190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODYwMDE5MA==","diff_hunk":"@@ -199,113 +218,158 @@ var buildFormatNewCmd = &cobra.Command{\n \t\tif err != nil {\n \t\t\tfail(err)\n \t\t}\n+\t\t// Update mixer to build version +20, to build the bundles with +20 inside not +10\n \t\tif err = b.UpdateMixVer(ver + 20); err != nil {\n \t\t\tfailf(\"Couldn't update Mix Version\")\n \t\t}\n \n-\t\t// Set format to format+1 so that the format file inserted into the\n-\t\t// update content is the new one\n-\t\tnewFormat, err := strconv.Atoi(b.State.Mix.Format)\n-\t\tif err != nil {\n-\t\t\tfail(err)\n-\t\t}\n-\t\tnewFormat++\n-\t\tif err = b.UpdateFormatVersion(strconv.Itoa(newFormat)); err != nil {\n-\t\t\tfail(err)\n-\t\t}\n-\t\tsetWorkers(b)\n+\t\t// Change the format internally just for building bundles so the right\n+\t\t// /usr/share/defaults/swupd/format is inserted; preserve old format\n+\t\toldFormat := b.State.Mix.Format\n+\t\tb.State.Mix.Format = buildFlags.newFormat\n \n-\t\tfmt.Println(\" Backing up full groups.ini\")\n-\t\t// Back up groups.ini in case we have deprecated bundles to delete\n-\t\tif err = b.CopyFullGroupsINI(); err != nil {\n+\t\t// Build bundles normally. At this point the bundles to be deleted should still\n+\t\t// be part of the mixbundles list and the groups.ini\n+\t\tif err = buildBundles(b, buildFlags.noSigning, buildFlags.clean); err != nil {\n \t\t\tfail(err)\n \t\t}\n-\t\t// Fill this in w/Update bundle definitions\n-\t\t// if err := UpdateBudlesForFormatBump(); err != nil {...}\n \n-\t\t// Build the +20 (first build in new format) bundles\n-\t\tif err = buildBundles(b, buildFlags.noSigning, buildFlags.clean); err != nil {\n+\t\t// Wipes the <bundle>-info files and replaces them with\n+\t\t// <bundle>/ directories that are empty. When the manifest creation happens it will\n+\t\t// mark all files in that bundles as deleted.\n+\t\tf := func(filename string) error {","path":"mixer/cmd/build.go","position":123,"original_position":123,"commit_id":"e427242bf3868a3723bbb26bd95acbf6444db4d2","original_commit_id":"e427242bf3868a3723bbb26bd95acbf6444db4d2","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"body":"'cause por que no","created_at":"2018-10-26T17:05:15Z","updated_at":"2018-10-26T17:05:15Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/472#discussion_r228600190","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/228600190"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/472#discussion_r228600190"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472"}},"in_reply_to_id":228591919},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472","id":224758624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzU4NjI0","html_url":"https://github.com/clearlinux/mixer-tools/pull/472","diff_url":"https://github.com/clearlinux/mixer-tools/pull/472.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/472.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/472","number":472,"state":"open","locked":false,"title":"New format bump process","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"body":"This is just an initial code drop if anyone wants to review or test. It still has some debug prints in it that don't need to be there, and I am going to add a full test including bundle deletion with it. Testing locally shows the bundle deletion works, and os-release and format/version files are updated to the right numbers.\r\n\r\n\r\nSigned-off-by: Tudor Marcu <tudor.marcu@intel.com>","created_at":"2018-10-22T17:48:12Z","updated_at":"2018-10-26T17:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88ad9fcd455583219585199838738f1a286f105b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},{"login":"phmccarty","id":1093718,"node_id":"MDQ6VXNlcjEwOTM3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1093718?v=4","gravatar_id":"","url":"https://api.github.com/users/phmccarty","html_url":"https://github.com/phmccarty","followers_url":"https://api.github.com/users/phmccarty/followers","following_url":"https://api.github.com/users/phmccarty/following{/other_user}","gists_url":"https://api.github.com/users/phmccarty/gists{/gist_id}","starred_url":"https://api.github.com/users/phmccarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phmccarty/subscriptions","organizations_url":"https://api.github.com/users/phmccarty/orgs","repos_url":"https://api.github.com/users/phmccarty/repos","events_url":"https://api.github.com/users/phmccarty/events{/privacy}","received_events_url":"https://api.github.com/users/phmccarty/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/472/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/e427242bf3868a3723bbb26bd95acbf6444db4d2","head":{"label":"tmarcu:doBump","ref":"doBump","sha":"e427242bf3868a3723bbb26bd95acbf6444db4d2","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"repo":{"id":120857933,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4NTc5MzM=","name":"mixer-tools","full_name":"tmarcu/mixer-tools","private":false,"owner":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tmarcu/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/tmarcu/mixer-tools","forks_url":"https://api.github.com/repos/tmarcu/mixer-tools/forks","keys_url":"https://api.github.com/repos/tmarcu/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmarcu/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmarcu/mixer-tools/teams","hooks_url":"https://api.github.com/repos/tmarcu/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/tmarcu/mixer-tools/events","assignees_url":"https://api.github.com/repos/tmarcu/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/tmarcu/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/tmarcu/mixer-tools/tags","blobs_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmarcu/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/tmarcu/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/tmarcu/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/tmarcu/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/tmarcu/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/tmarcu/mixer-tools/subscription","commits_url":"https://api.github.com/repos/tmarcu/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmarcu/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmarcu/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/tmarcu/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmarcu/mixer-tools/merges","archive_url":"https://api.github.com/repos/tmarcu/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmarcu/mixer-tools/downloads","issues_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/tmarcu/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/tmarcu/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/tmarcu/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmarcu/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/tmarcu/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/tmarcu/mixer-tools/deployments","created_at":"2018-02-09T04:49:32Z","updated_at":"2018-08-10T22:57:53Z","pushed_at":"2018-10-25T23:23:46Z","git_url":"git://github.com/tmarcu/mixer-tools.git","ssh_url":"git@github.com:tmarcu/mixer-tools.git","clone_url":"https://github.com/tmarcu/mixer-tools.git","svn_url":"https://github.com/tmarcu/mixer-tools","homepage":null,"size":1569,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"99e8091205ee979b5d328734b294cad065e14784","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","private":false,"owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-10-24T04:48:35Z","pushed_at":"2018-10-26T16:46:50Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1541,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":54,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/472"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/472"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/e427242bf3868a3723bbb26bd95acbf6444db4d2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tmarcu"}}