{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments/204661227","pull_request_review_id":139776940,"id":204661227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDY2MTIyNw==","diff_hunk":"@@ -60,7 +60,14 @@ final class CallSystemMessageGenerator: NSObject {\n                 systemMessage =  conversation.appendPerformedCallMessage(with: 0, caller: caller)\n             } else if reason == .canceled || reason == .timeout || reason == .normal {\n                 log.info(\"Appending missed call message: \\(caller.displayName), \\\"\\(conversation.displayName)\\\"\")\n-                systemMessage = conversation.appendMissedCallMessage(fromUser: caller, at: timestamp ?? Date())\n+                \n+                var isRelevant = true\n+                if case .incoming(video: _, shouldRing: false, degraded: _)? = previousCallState {","path":"Source/Calling/SystemMessageCallObserver.swift","position":33,"original_position":33,"commit_id":"8ee80f7b693ff3a439feeda3370fb40e7eda1750","original_commit_id":"8ee80f7b693ff3a439feeda3370fb40e7eda1750","user":{"login":"typfel","id":7156,"node_id":"MDQ6VXNlcjcxNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7156?v=4","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"body":"`shouldRing: false` seems wrong here, when `shouldRing` is false  the receiver doesn't get the option to decline the call.","created_at":"2018-07-24T08:10:56Z","updated_at":"2018-07-24T08:10:56Z","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/811#discussion_r204661227","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments/204661227"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/811#discussion_r204661227"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811","id":203222454,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjIyNDU0","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/811","diff_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/811.diff","patch_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/811.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/811","number":811,"state":"open","locked":false,"title":"ZIOS-10243: Fix \"Declined call\" state","user":{"login":"nicorsm","id":2906234,"node_id":"MDQ6VXNlcjI5MDYyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2906234?v=4","gravatar_id":"","url":"https://api.github.com/users/nicorsm","html_url":"https://github.com/nicorsm","followers_url":"https://api.github.com/users/nicorsm/followers","following_url":"https://api.github.com/users/nicorsm/following{/other_user}","gists_url":"https://api.github.com/users/nicorsm/gists{/gist_id}","starred_url":"https://api.github.com/users/nicorsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicorsm/subscriptions","organizations_url":"https://api.github.com/users/nicorsm/orgs","repos_url":"https://api.github.com/users/nicorsm/repos","events_url":"https://api.github.com/users/nicorsm/events{/privacy}","received_events_url":"https://api.github.com/users/nicorsm/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nCalls rejected by the recipient should not be counted towards the amount of missed calls inside the conversations list.\r\n\r\n### Solutions\r\n\r\nWhile posting new notifications on the `WireCallCenterCallStateNotification`, I'm now passing the `previousCallState` parameter, so we can know if the call was previously rejected by the recipient and currently closed by the sender. I've also added the support for the `isRelevant` flag.\r\n\r\n### Needs release with\r\n\r\n- [ ] https://github.com/wireapp/wire-ios-data-model/pull/523","created_at":"2018-07-23T13:39:15Z","updated_at":"2018-07-24T08:10:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec0773883c497cb13932905b0cfd0cbc02f86471","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/811/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/8ee80f7b693ff3a439feeda3370fb40e7eda1750","head":{"label":"wireapp:fix/declined-call","ref":"fix/declined-call","sha":"8ee80f7b693ff3a439feeda3370fb40e7eda1750","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"node_id":"MDEwOlJlcG9zaXRvcnk1MzU3NDMzOA==","name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2018-07-23T14:55:47Z","pushed_at":"2018-07-24T08:09:46Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":12459,"stargazers_count":136,"watchers_count":136,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":4,"watchers":136,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"620d54f15a50a7b76217dafb9b9daecd9586590b","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"node_id":"MDEwOlJlcG9zaXRvcnk1MzU3NDMzOA==","name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2018-07-23T14:55:47Z","pushed_at":"2018-07-24T08:09:46Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":12459,"stargazers_count":136,"watchers_count":136,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":4,"watchers":136,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/811"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/811"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/8ee80f7b693ff3a439feeda3370fb40e7eda1750"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"typfel"}}