{"action":"created","comment":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/219625560","pull_request_review_id":157856527,"id":219625560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTYyNTU2MA==","diff_hunk":"@@ -19,6 +19,9 @@ pxr_library(js\n         types.h\n )\n \n+# This removes warnings generated by rapidjson\n+target_compile_definitions(js PRIVATE RAPIDJSON_HAS_CXX11_RVALUE_REFS=1)","path":"pxr/base/lib/js/CMakeLists.txt","position":5,"original_position":5,"commit_id":"bb94259ef52f1bc41019278f8e276b025bf2e086","original_commit_id":"bb94259ef52f1bc41019278f8e276b025bf2e086","user":{"login":"sunyab","id":11516093,"node_id":"MDQ6VXNlcjExNTE2MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/11516093?v=4","gravatar_id":"","url":"https://api.github.com/users/sunyab","html_url":"https://github.com/sunyab","followers_url":"https://api.github.com/users/sunyab/followers","following_url":"https://api.github.com/users/sunyab/following{/other_user}","gists_url":"https://api.github.com/users/sunyab/gists{/gist_id}","starred_url":"https://api.github.com/users/sunyab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunyab/subscriptions","organizations_url":"https://api.github.com/users/sunyab/orgs","repos_url":"https://api.github.com/users/sunyab/repos","events_url":"https://api.github.com/users/sunyab/events{/privacy}","received_events_url":"https://api.github.com/users/sunyab/received_events","type":"User","site_admin":false},"body":"Instead of adding this define here, can we add a #define in js/json.cpp, near where the other RAPIDJSON defines are located? rapidjson includes are contained to this one file, and it'd be good to centralize all of the necessary configuration there.","created_at":"2018-09-21T20:57:59Z","updated_at":"2018-09-21T20:58:18Z","html_url":"https://github.com/PixarAnimationStudios/USD/pull/620#discussion_r219625560","pull_request_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/219625560"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/620#discussion_r219625560"},"pull_request":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620","id":215787828,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzg3ODI4","html_url":"https://github.com/PixarAnimationStudios/USD/pull/620","diff_url":"https://github.com/PixarAnimationStudios/USD/pull/620.diff","patch_url":"https://github.com/PixarAnimationStudios/USD/pull/620.patch","issue_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/620","number":620,"state":"open","locked":false,"title":"Add define for rapidjson","user":{"login":"superfunc","id":1583002,"node_id":"MDQ6VXNlcjE1ODMwMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1583002?v=4","gravatar_id":"","url":"https://api.github.com/users/superfunc","html_url":"https://github.com/superfunc","followers_url":"https://api.github.com/users/superfunc/followers","following_url":"https://api.github.com/users/superfunc/following{/other_user}","gists_url":"https://api.github.com/users/superfunc/gists{/gist_id}","starred_url":"https://api.github.com/users/superfunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfunc/subscriptions","organizations_url":"https://api.github.com/users/superfunc/orgs","repos_url":"https://api.github.com/users/superfunc/repos","events_url":"https://api.github.com/users/superfunc/events{/privacy}","received_events_url":"https://api.github.com/users/superfunc/received_events","type":"User","site_admin":false},"body":"See discussion in #610, suggested by the wise @meshula \r\n","created_at":"2018-09-15T20:25:01Z","updated_at":"2018-09-21T20:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"371c55a5170244d451832332a957be6372d9275d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620/commits","review_comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620/comments","review_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/620/comments","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/bb94259ef52f1bc41019278f8e276b025bf2e086","head":{"label":"superfunc:cmakeFix","ref":"cmakeFix","sha":"bb94259ef52f1bc41019278f8e276b025bf2e086","user":{"login":"superfunc","id":1583002,"node_id":"MDQ6VXNlcjE1ODMwMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1583002?v=4","gravatar_id":"","url":"https://api.github.com/users/superfunc","html_url":"https://github.com/superfunc","followers_url":"https://api.github.com/users/superfunc/followers","following_url":"https://api.github.com/users/superfunc/following{/other_user}","gists_url":"https://api.github.com/users/superfunc/gists{/gist_id}","starred_url":"https://api.github.com/users/superfunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfunc/subscriptions","organizations_url":"https://api.github.com/users/superfunc/orgs","repos_url":"https://api.github.com/users/superfunc/repos","events_url":"https://api.github.com/users/superfunc/events{/privacy}","received_events_url":"https://api.github.com/users/superfunc/received_events","type":"User","site_admin":false},"repo":{"id":97337234,"node_id":"MDEwOlJlcG9zaXRvcnk5NzMzNzIzNA==","name":"USD","full_name":"superfunc/USD","private":false,"owner":{"login":"superfunc","id":1583002,"node_id":"MDQ6VXNlcjE1ODMwMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1583002?v=4","gravatar_id":"","url":"https://api.github.com/users/superfunc","html_url":"https://github.com/superfunc","followers_url":"https://api.github.com/users/superfunc/followers","following_url":"https://api.github.com/users/superfunc/following{/other_user}","gists_url":"https://api.github.com/users/superfunc/gists{/gist_id}","starred_url":"https://api.github.com/users/superfunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfunc/subscriptions","organizations_url":"https://api.github.com/users/superfunc/orgs","repos_url":"https://api.github.com/users/superfunc/repos","events_url":"https://api.github.com/users/superfunc/events{/privacy}","received_events_url":"https://api.github.com/users/superfunc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/superfunc/USD","description":"Universal Scene Description","fork":true,"url":"https://api.github.com/repos/superfunc/USD","forks_url":"https://api.github.com/repos/superfunc/USD/forks","keys_url":"https://api.github.com/repos/superfunc/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superfunc/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superfunc/USD/teams","hooks_url":"https://api.github.com/repos/superfunc/USD/hooks","issue_events_url":"https://api.github.com/repos/superfunc/USD/issues/events{/number}","events_url":"https://api.github.com/repos/superfunc/USD/events","assignees_url":"https://api.github.com/repos/superfunc/USD/assignees{/user}","branches_url":"https://api.github.com/repos/superfunc/USD/branches{/branch}","tags_url":"https://api.github.com/repos/superfunc/USD/tags","blobs_url":"https://api.github.com/repos/superfunc/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superfunc/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superfunc/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/superfunc/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superfunc/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/superfunc/USD/languages","stargazers_url":"https://api.github.com/repos/superfunc/USD/stargazers","contributors_url":"https://api.github.com/repos/superfunc/USD/contributors","subscribers_url":"https://api.github.com/repos/superfunc/USD/subscribers","subscription_url":"https://api.github.com/repos/superfunc/USD/subscription","commits_url":"https://api.github.com/repos/superfunc/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/superfunc/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/superfunc/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/superfunc/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/superfunc/USD/contents/{+path}","compare_url":"https://api.github.com/repos/superfunc/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superfunc/USD/merges","archive_url":"https://api.github.com/repos/superfunc/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superfunc/USD/downloads","issues_url":"https://api.github.com/repos/superfunc/USD/issues{/number}","pulls_url":"https://api.github.com/repos/superfunc/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/superfunc/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/superfunc/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superfunc/USD/labels{/name}","releases_url":"https://api.github.com/repos/superfunc/USD/releases{/id}","deployments_url":"https://api.github.com/repos/superfunc/USD/deployments","created_at":"2017-07-15T19:17:37Z","updated_at":"2017-07-15T19:17:48Z","pushed_at":"2018-09-20T15:51:01Z","git_url":"git://github.com/superfunc/USD.git","ssh_url":"git@github.com:superfunc/USD.git","clone_url":"https://github.com/superfunc/USD.git","svn_url":"https://github.com/superfunc/USD","homepage":"http://www.openusd.org","size":52044,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PixarAnimationStudios:dev","ref":"dev","sha":"f1b04adaf18de98ad205f9a110d0143f75d312f4","user":{"login":"PixarAnimationStudios","id":1672744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzI3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1672744?v=4","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":58168143,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE2ODE0Mw==","name":"USD","full_name":"PixarAnimationStudios/USD","private":false,"owner":{"login":"PixarAnimationStudios","id":1672744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzI3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1672744?v=4","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PixarAnimationStudios/USD","description":"Universal Scene Description","fork":false,"url":"https://api.github.com/repos/PixarAnimationStudios/USD","forks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/forks","keys_url":"https://api.github.com/repos/PixarAnimationStudios/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PixarAnimationStudios/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PixarAnimationStudios/USD/teams","hooks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/hooks","issue_events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/events{/number}","events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/events","assignees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/assignees{/user}","branches_url":"https://api.github.com/repos/PixarAnimationStudios/USD/branches{/branch}","tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/tags","blobs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/PixarAnimationStudios/USD/languages","stargazers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/stargazers","contributors_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contributors","subscribers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscribers","subscription_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscription","commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contents/{+path}","compare_url":"https://api.github.com/repos/PixarAnimationStudios/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PixarAnimationStudios/USD/merges","archive_url":"https://api.github.com/repos/PixarAnimationStudios/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PixarAnimationStudios/USD/downloads","issues_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues{/number}","pulls_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/PixarAnimationStudios/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/PixarAnimationStudios/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PixarAnimationStudios/USD/labels{/name}","releases_url":"https://api.github.com/repos/PixarAnimationStudios/USD/releases{/id}","deployments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/deployments","created_at":"2016-05-06T00:02:56Z","updated_at":"2018-09-21T13:59:54Z","pushed_at":"2018-09-21T13:51:54Z","git_url":"git://github.com/PixarAnimationStudios/USD.git","ssh_url":"git@github.com:PixarAnimationStudios/USD.git","clone_url":"https://github.com/PixarAnimationStudios/USD.git","svn_url":"https://github.com/PixarAnimationStudios/USD","homepage":"http://www.openusd.org","size":37200,"stargazers_count":1527,"watchers_count":1527,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":273,"open_issues":212,"watchers":1527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/620"},"issue":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/620"},"comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/bb94259ef52f1bc41019278f8e276b025bf2e086"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sunyab"}}