{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18474","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18474/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18474/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18474/events","html_url":"https://github.com/magento/magento2/pull/18474","id":367944499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjM2NjAw","number":18474,"title":"Fixed - Fatal Error when save configurable product in Magento 2.2.5 #18082","user":{"login":"Shubham-Webkul","id":35595582,"node_id":"MDQ6VXNlcjM1NTk1NTgy","avatar_url":"https://avatars3.githubusercontent.com/u/35595582?v=4","gravatar_id":"","url":"https://api.github.com/users/Shubham-Webkul","html_url":"https://github.com/Shubham-Webkul","followers_url":"https://api.github.com/users/Shubham-Webkul/followers","following_url":"https://api.github.com/users/Shubham-Webkul/following{/other_user}","gists_url":"https://api.github.com/users/Shubham-Webkul/gists{/gist_id}","starred_url":"https://api.github.com/users/Shubham-Webkul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shubham-Webkul/subscriptions","organizations_url":"https://api.github.com/users/Shubham-Webkul/orgs","repos_url":"https://api.github.com/users/Shubham-Webkul/repos","events_url":"https://api.github.com/users/Shubham-Webkul/events{/privacy}","received_events_url":"https://api.github.com/users/Shubham-Webkul/received_events","type":"User","site_admin":false},"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":944433568,"node_id":"MDU6TGFiZWw5NDQ0MzM1Njg=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20AdminNotification","name":"Component: AdminNotification","color":"7fb703","default":false},{"id":954313588,"node_id":"MDU6TGFiZWw5NTQzMTM1ODg=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20AdvancedPricingImportExport","name":"Component: AdvancedPricingImportExport","color":"7fb703","default":false},{"id":962343990,"node_id":"MDU6TGFiZWw5NjIzNDM5OTA=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Analytics","name":"Component: Analytics","color":"7fb703","default":false},{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"VladimirZaets","id":8035672,"node_id":"MDQ6VXNlcjgwMzU2NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/8035672?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirZaets","html_url":"https://github.com/VladimirZaets","followers_url":"https://api.github.com/users/VladimirZaets/followers","following_url":"https://api.github.com/users/VladimirZaets/following{/other_user}","gists_url":"https://api.github.com/users/VladimirZaets/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirZaets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirZaets/subscriptions","organizations_url":"https://api.github.com/users/VladimirZaets/orgs","repos_url":"https://api.github.com/users/VladimirZaets/repos","events_url":"https://api.github.com/users/VladimirZaets/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirZaets/received_events","type":"User","site_admin":false},"assignees":[{"login":"VladimirZaets","id":8035672,"node_id":"MDQ6VXNlcjgwMzU2NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/8035672?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirZaets","html_url":"https://github.com/VladimirZaets","followers_url":"https://api.github.com/users/VladimirZaets/followers","following_url":"https://api.github.com/users/VladimirZaets/following{/other_user}","gists_url":"https://api.github.com/users/VladimirZaets/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirZaets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirZaets/subscriptions","organizations_url":"https://api.github.com/users/VladimirZaets/orgs","repos_url":"https://api.github.com/users/VladimirZaets/repos","events_url":"https://api.github.com/users/VladimirZaets/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirZaets/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-08T20:38:51Z","updated_at":"2018-10-18T13:59:43Z","closed_at":"2018-10-18T13:59:43Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18474","html_url":"https://github.com/magento/magento2/pull/18474","diff_url":"https://github.com/magento/magento2/pull/18474.diff","patch_url":"https://github.com/magento/magento2/pull/18474.patch"},"body":"**Description**\r\nI have checked that if there is any validation error exist then after click save button configurable-matrix data remove.You can check the file app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/variations.js in function serializeData due to fatal error comes.Now I have added condition that if there is any validation error exist then configurable-matrix data will not remove and after submit form all value will exist and product will successfully save.\r\n\r\n**Fixed Issues (if relevant)**\r\n1 - magento/magento2#18082: Fatal Error when save configurable product in Magento 2.2.5\r\n\r\n### Manual testing scenarios\r\n1. Add new configurable product with name and sku of 63 characters length For Example: \"Amzer 203877 Kristal FULL HD Tempered Glass for OnePlus 6 Clear\".\r\n2. Now click on \"Create Configuration\" button.\r\n3. Now, When you try to save it's configuration, It shows client side validation error for child products SKUs. Decrease length of child product's SKUs and then save the product. It generates a error report as attached.But after apply changes product successfully saved.\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/431019691","html_url":"https://github.com/magento/magento2/pull/18474#issuecomment-431019691","issue_url":"https://api.github.com/repos/magento/magento2/issues/18474","id":431019691,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTAxOTY5MQ==","user":{"login":"VladimirZaets","id":8035672,"node_id":"MDQ6VXNlcjgwMzU2NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/8035672?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirZaets","html_url":"https://github.com/VladimirZaets","followers_url":"https://api.github.com/users/VladimirZaets/followers","following_url":"https://api.github.com/users/VladimirZaets/following{/other_user}","gists_url":"https://api.github.com/users/VladimirZaets/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirZaets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirZaets/subscriptions","organizations_url":"https://api.github.com/users/VladimirZaets/orgs","repos_url":"https://api.github.com/users/VladimirZaets/repos","events_url":"https://api.github.com/users/VladimirZaets/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirZaets/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T13:59:43Z","updated_at":"2018-10-18T13:59:43Z","author_association":"CONTRIBUTOR","body":"Hi @Shubham-Webkul, currently your branch contains more than 5000 changed files, I tried to change base branch but had the same situation. Please fix your branch and create new one PR. Thanks."}}
{"actor":{"display_login":"VladimirZaets"}}