{"action":"closed","number":3689,"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3689","id":223944606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTQ0NjA2","html_url":"https://github.com/tikv/tikv/pull/3689","diff_url":"https://github.com/tikv/tikv/pull/3689.diff","patch_url":"https://github.com/tikv/tikv/pull/3689.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3689","number":3689,"state":"closed","locked":false,"title":"Prepare for Coprocessor Executor Benchmarks","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nThis PR sets up foundations for executor benchmarks. As an illustration, it also contains a simple executor benchmark \"bench_table_scan_primary_key\", which measures time of iterating (by calling `TableScanExecutor::next()`) a row with only primary key listed in interested column. This will happen for SQLs like `SELECT COUNT(*)`. \r\n\r\nNote that this is a layered benchmark, which depends on https://github.com/tikv/tikv/pull/3685\r\n\r\n- [x] Wait https://github.com/tikv/tikv/pull/3685 to be merged\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n```\r\ntable_scan_primary_key  time:   [21.910 us 22.869 us 25.453 us]\r\n```\r\n","created_at":"2018-10-18T12:53:18Z","updated_at":"2018-11-13T05:16:29Z","closed_at":"2018-11-13T05:16:29Z","merged_at":"2018-11-13T05:16:29Z","merge_commit_sha":"1f1926037d644a645e245f9e3aded2b6b9e476ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":462930498,"node_id":"MDU6TGFiZWw0NjI5MzA0OTg=","url":"https://api.github.com/repos/tikv/tikv/labels/C:%20Test","name":"C: Test","color":"d1fad7","default":false},{"id":1015578892,"node_id":"MDU6TGFiZWwxMDE1NTc4ODky","url":"https://api.github.com/repos/tikv/tikv/labels/S:%20LGT1","name":"S: LGT1","color":"66d7ee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3689/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3689/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3689/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/d92f857de6edcceab0040ebfaa79289faf96b397","head":{"label":"breeswish:_cop_benchmarks/table_scan/bench1","ref":"_cop_benchmarks/table_scan/bench1","sha":"d92f857de6edcceab0040ebfaa79289faf96b397","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"repo":{"id":113962357,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5NjIzNTc=","name":"tikv","full_name":"breeswish/tikv","private":false,"owner":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"html_url":"https://github.com/breeswish/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/breeswish/tikv","forks_url":"https://api.github.com/repos/breeswish/tikv/forks","keys_url":"https://api.github.com/repos/breeswish/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/breeswish/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/breeswish/tikv/teams","hooks_url":"https://api.github.com/repos/breeswish/tikv/hooks","issue_events_url":"https://api.github.com/repos/breeswish/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/breeswish/tikv/events","assignees_url":"https://api.github.com/repos/breeswish/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/breeswish/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/breeswish/tikv/tags","blobs_url":"https://api.github.com/repos/breeswish/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/breeswish/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/breeswish/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/breeswish/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/breeswish/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/breeswish/tikv/languages","stargazers_url":"https://api.github.com/repos/breeswish/tikv/stargazers","contributors_url":"https://api.github.com/repos/breeswish/tikv/contributors","subscribers_url":"https://api.github.com/repos/breeswish/tikv/subscribers","subscription_url":"https://api.github.com/repos/breeswish/tikv/subscription","commits_url":"https://api.github.com/repos/breeswish/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/breeswish/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/breeswish/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/breeswish/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/breeswish/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/breeswish/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/breeswish/tikv/merges","archive_url":"https://api.github.com/repos/breeswish/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/breeswish/tikv/downloads","issues_url":"https://api.github.com/repos/breeswish/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/breeswish/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/breeswish/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/breeswish/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/breeswish/tikv/labels{/name}","releases_url":"https://api.github.com/repos/breeswish/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/breeswish/tikv/deployments","created_at":"2017-12-12T08:14:53Z","updated_at":"2018-08-07T00:45:16Z","pushed_at":"2018-11-13T04:07:19Z","git_url":"git://github.com/breeswish/tikv.git","ssh_url":"git@github.com:breeswish/tikv.git","clone_url":"https://github.com/breeswish/tikv.git","svn_url":"https://github.com/breeswish/tikv","homepage":"https://pingcap.com","size":17391,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"f3f495a49fbcc0f22ae103317c3f25466423d9f9","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","private":false,"owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key-value database, originally created to complement TiDB","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-11-13T04:04:16Z","pushed_at":"2018-11-13T05:16:29Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"https://tikv.org","size":17523,"stargazers_count":3900,"watchers_count":3900,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":543,"open_issues":284,"watchers":3900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3689"},"html":{"href":"https://github.com/tikv/tikv/pull/3689"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3689"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3689/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3689/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3689/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/d92f857de6edcceab0040ebfaa79289faf96b397"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"huachaohuang","id":7806468,"node_id":"MDQ6VXNlcjc4MDY0Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/7806468?v=4","gravatar_id":"","url":"https://api.github.com/users/huachaohuang","html_url":"https://github.com/huachaohuang","followers_url":"https://api.github.com/users/huachaohuang/followers","following_url":"https://api.github.com/users/huachaohuang/following{/other_user}","gists_url":"https://api.github.com/users/huachaohuang/gists{/gist_id}","starred_url":"https://api.github.com/users/huachaohuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huachaohuang/subscriptions","organizations_url":"https://api.github.com/users/huachaohuang/orgs","repos_url":"https://api.github.com/users/huachaohuang/repos","events_url":"https://api.github.com/users/huachaohuang/events{/privacy}","received_events_url":"https://api.github.com/users/huachaohuang/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":12,"additions":397,"deletions":138,"changed_files":14}}
{"actor":{"display_login":"huachaohuang"}}