{"action":"created","issue":{"url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/6","repository_url":"https://api.github.com/repos/DemocracyClub/dc_signup_form","labels_url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/6/comments","events_url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/6/events","html_url":"https://github.com/DemocracyClub/dc_signup_form/pull/6","id":335361645,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDc4Njgz","number":6,"title":"Form prefixes","user":{"login":"symroe","id":242329,"node_id":"MDQ6VXNlcjI0MjMyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/242329?v=4","gravatar_id":"","url":"https://api.github.com/users/symroe","html_url":"https://github.com/symroe","followers_url":"https://api.github.com/users/symroe/followers","following_url":"https://api.github.com/users/symroe/following{/other_user}","gists_url":"https://api.github.com/users/symroe/gists{/gist_id}","starred_url":"https://api.github.com/users/symroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symroe/subscriptions","organizations_url":"https://api.github.com/users/symroe/orgs","repos_url":"https://api.github.com/users/symroe/repos","events_url":"https://api.github.com/users/symroe/events{/privacy}","received_events_url":"https://api.github.com/users/symroe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-25T11:12:18Z","updated_at":"2018-06-25T14:55:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/pulls/6","html_url":"https://github.com/DemocracyClub/dc_signup_form/pull/6","diff_url":"https://github.com/DemocracyClub/dc_signup_form/pull/6.diff","patch_url":"https://github.com/DemocracyClub/dc_signup_form/pull/6.patch"},"body":"This adds form prefixes to both forms, meaning that when they appear on\r\na page with other forms then validation doesn't get performed on the\r\nwrong form.\r\n\r\nFor example, if a form error shows on a page for another form, the\r\nmailing list form gets \"This field is required\" as an error, something\r\nthat's confusing if the user isn't trying to fill that form out."},"comment":{"url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/comments/399981225","html_url":"https://github.com/DemocracyClub/dc_signup_form/pull/6#issuecomment-399981225","issue_url":"https://api.github.com/repos/DemocracyClub/dc_signup_form/issues/6","id":399981225,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTk4MTIyNQ==","user":{"login":"chris48s","id":6025893,"node_id":"MDQ6VXNlcjYwMjU4OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6025893?v=4","gravatar_id":"","url":"https://api.github.com/users/chris48s","html_url":"https://github.com/chris48s","followers_url":"https://api.github.com/users/chris48s/followers","following_url":"https://api.github.com/users/chris48s/following{/other_user}","gists_url":"https://api.github.com/users/chris48s/gists{/gist_id}","starred_url":"https://api.github.com/users/chris48s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris48s/subscriptions","organizations_url":"https://api.github.com/users/chris48s/orgs","repos_url":"https://api.github.com/users/chris48s/repos","events_url":"https://api.github.com/users/chris48s/events{/privacy}","received_events_url":"https://api.github.com/users/chris48s/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T14:55:24Z","updated_at":"2018-06-25T14:55:24Z","author_association":"MEMBER","body":"> for some reason, the DC website repo overwrites the package template with it's own\r\n\r\nIts because (unlike all the other sites where we use this) the form is inline in the footer of every page. If you have a page where the all of the content for that page is a signup form in the body and then the exact same signup form in the footer, it looked really odd so I had to customise it. Its maybe worth thinking about that design decision, but I think its a change for the website repo not this package."}}
{"actor":{"display_login":"chris48s"}}