{"action":"created","issue":{"url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/990","repository_url":"https://api.github.com/repos/APY/APYDataGridBundle","labels_url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/990/labels{/name}","comments_url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/990/comments","events_url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/990/events","html_url":"https://github.com/APY/APYDataGridBundle/pull/990","id":278990346,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU2MTkyODIx","number":990,"title":"Update for Symfony 4 ","user":{"login":"parasetam0l","id":9287640,"node_id":"MDQ6VXNlcjkyODc2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/9287640?v=4","gravatar_id":"","url":"https://api.github.com/users/parasetam0l","html_url":"https://github.com/parasetam0l","followers_url":"https://api.github.com/users/parasetam0l/followers","following_url":"https://api.github.com/users/parasetam0l/following{/other_user}","gists_url":"https://api.github.com/users/parasetam0l/gists{/gist_id}","starred_url":"https://api.github.com/users/parasetam0l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parasetam0l/subscriptions","organizations_url":"https://api.github.com/users/parasetam0l/orgs","repos_url":"https://api.github.com/users/parasetam0l/repos","events_url":"https://api.github.com/users/parasetam0l/events{/privacy}","received_events_url":"https://api.github.com/users/parasetam0l/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-04T13:10:04Z","updated_at":"2018-07-16T11:39:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/APY/APYDataGridBundle/pulls/990","html_url":"https://github.com/APY/APYDataGridBundle/pull/990","diff_url":"https://github.com/APY/APYDataGridBundle/pull/990.diff","patch_url":"https://github.com/APY/APYDataGridBundle/pull/990.patch"},"body":"Hello,\r\nI started to use APYDataGridBundle on my new Symfony 4 project. I forked project and solved some problems. Now bundle is not giving any installation or deprecation error. I can not get work \"symfony/symfony\": \"~2.8|~3.0|^4.0\" line in composer.json. I think it can be replaced by \"symfony/framework-bundle\" etc. But I removed that line temporary for my project. Still working on it. \r\n\r\nPS: Do not use AbstractController class while extending your Controller. Use Controller class. Otherwise you will get '\"grid\" service not found' error.\r\n\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/comments/405220217","html_url":"https://github.com/APY/APYDataGridBundle/pull/990#issuecomment-405220217","issue_url":"https://api.github.com/repos/APY/APYDataGridBundle/issues/990","id":405220217,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIyMDIxNw==","user":{"login":"romainguerrero","id":13657074,"node_id":"MDQ6VXNlcjEzNjU3MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/13657074?v=4","gravatar_id":"","url":"https://api.github.com/users/romainguerrero","html_url":"https://github.com/romainguerrero","followers_url":"https://api.github.com/users/romainguerrero/followers","following_url":"https://api.github.com/users/romainguerrero/following{/other_user}","gists_url":"https://api.github.com/users/romainguerrero/gists{/gist_id}","starred_url":"https://api.github.com/users/romainguerrero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainguerrero/subscriptions","organizations_url":"https://api.github.com/users/romainguerrero/orgs","repos_url":"https://api.github.com/users/romainguerrero/repos","events_url":"https://api.github.com/users/romainguerrero/events{/privacy}","received_events_url":"https://api.github.com/users/romainguerrero/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T11:39:48Z","updated_at":"2018-07-16T11:39:48Z","author_association":"NONE","body":"I don't think you can totally remove the `symfony/symfony` dependency but for this problem the PR #1011 should resolved it.\r\nFor the other parts I am also interested in this PR to be able to use a public `grid` service in my Symfony 4 project (for the moment I use a public alias...) but I'm not sure that setting \"public\" as default visibility for services is a good idea in reference to the Symfony recommandations. Maybe you could explicitly indicate as public only services which are supposed to be used by developers ?"}}
{"actor":{"display_login":"romainguerrero"}}