{"action":"created","comment":{"url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/comments/223862543","pull_request_review_id":163094711,"id":223862543,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg2MjU0Mw==","diff_hunk":"@@ -1,33 +1,129 @@\n-## Deploying to the Google Play Store\n-##### Prerequirements\n-- You **must** read the [general deploy info](README.md).\n-- You **must** have the official PVTrAck signing key. See [the keys doc](android-keys.md) for more info.\n-- You **must** have the Android SDK and Android build tools installed (both bundled with Android Studio). We target API level 25 (Nougat, 7.1).\n-- You **must** have access to the [Google Play Developer Console](play.google.com/apps/publish) (see @sherson).\n-- You *should* have [Android Studio](https://developer.android.com/studio/index.html) installed.\n+# Building an Android App to Deploy in Google Play\n \n-##### Steps\n+## Requirements\n+_These instructions assume you are running a Mac. If you're not, the installation\n+instructions will be vastly different. You can ask for help or, since you're probably\n+running Linux, just translate them like you're probably used to doing._\n \n-1. `npm install`\n+### General\n+- Did you read the [general deploy info](README.md)?\n+- Do you have access to the [Google Play Developer Console](play.google.com/apps/publish)?\n+ If not, see Adam.\n \n-2. Open `config.xml`. On line 2, increment `android-versionCode` with your appropriately chosen new version number.\n+### Android Studio\n+We use Android Studio to easily manage the Android SDK tools. If you wish, you can attempt\n+to download the tools separately, but these instructions will not help you because I found the\n+attempt maddening. Plus, Android Studio will keep track of updates for you, which is nice.\n+1. Get [Android Studio](https://developer.android.com/studio/)\n+1. Use it to download the SDK platforms and tools: \n+  1. Click menu items Android Studio -> Appearance and Behavior -> System Settings -> Android SDK\n+  1. In the main window, click \"sdk platforms\"\n+  1. Click 'edit' to choose an sdk location. Follow the prompts. \n+  The default location is fine--keep note of where that is so you can run the tools \n+  from the command line.  Wait for it to download the components.\n+  1. Keep waiting\n+  1. Check the boxes next to Android 8.0(Oreo) and any others leading up to the latest--you'll see that that's API \n+  level 26, which we target at the moment. \n+  1. Click on the \"tools\" tab. Make sure \"Android SDK Platform Tools\", \"Android SDK Tools\", and\n+  \"Android SDK Build Tools\" are checked. If you don't have access to an Android phone, make sure\n+  the Emulator is also installed. Click \"apply\"\n \n-3. (PVTrAck 2+) `ionic build android --prod --release`\n+### Java 1.8\n+  1. `$brew update`\n+  1. `$brew tap caskroom/versions`\n+  1. `brew search java`\n+  1. `brew cask install java8`\n+  1. If you can figure out why this app requires an old version of Java, please\n+  fix it.\n \n-    Troubleshooting: if you get an error related to whether this is an Android project, try the following:\n+### Gradle\n+  1. `$brew install gradle`\n+  1. Follow any additional commands to set Gradle up.\n \n+### Node\n+  1. Install node: `$brew install node`.\n+  1. Then use it actually install our packages:`$npm install` (You probably\n+  already did this when doing work on the application, but it can't hurt to\n+  update if you pulled from master)\n+\n+## Ready to build?\n+  1. Open `config.xml`: On line 2, increment `android-versionCode`\n+  with your appropriately chosen new version number.\n+  1. You may make a debug build first to try the changes to your application on\n+  an emulator or phone: `$ionic cordova build android`.\n+  1. If you have an Android: Plug it into the computer with a USB cable and enable USB\n+  debugging. Side-load like so, replacing the paths with your own:\n+ `~/Library/Android/sdk/platform-tools/adb install /Users/my_name/pvta-multiplatform/platforms/android/build/outputs/apk/debug/android-debug.apk","path":"doc/deploy/android.md","position":68,"original_position":68,"commit_id":"5d337a760f691a47ce95e314d6db44e9564bd59a","original_commit_id":"5d337a760f691a47ce95e314d6db44e9564bd59a","user":{"login":"werebus","id":240275,"node_id":"MDQ6VXNlcjI0MDI3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/240275?v=4","gravatar_id":"","url":"https://api.github.com/users/werebus","html_url":"https://github.com/werebus","followers_url":"https://api.github.com/users/werebus/followers","following_url":"https://api.github.com/users/werebus/following{/other_user}","gists_url":"https://api.github.com/users/werebus/gists{/gist_id}","starred_url":"https://api.github.com/users/werebus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werebus/subscriptions","organizations_url":"https://api.github.com/users/werebus/orgs","repos_url":"https://api.github.com/users/werebus/repos","events_url":"https://api.github.com/users/werebus/events{/privacy}","received_events_url":"https://api.github.com/users/werebus/received_events","type":"User","site_admin":false},"body":"Better to use placeholders here rather than full paths: `<android_sdk>/platform_tools/adb install platforms/android/build/outputs/apk/debug/android-debug.apk`","created_at":"2018-10-09T21:02:11Z","updated_at":"2018-10-09T21:07:42Z","html_url":"https://github.com/umts/pvta-multiplatform/pull/477#discussion_r223862543","pull_request_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/comments/223862543"},"html":{"href":"https://github.com/umts/pvta-multiplatform/pull/477#discussion_r223862543"},"pull_request":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477","id":221549755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTQ5NzU1","html_url":"https://github.com/umts/pvta-multiplatform/pull/477","diff_url":"https://github.com/umts/pvta-multiplatform/pull/477.diff","patch_url":"https://github.com/umts/pvta-multiplatform/pull/477.patch","issue_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/477","number":477,"state":"open","locked":false,"title":"Enable automatic signing for releases","user":{"login":"Anbranin","id":9645316,"node_id":"MDQ6VXNlcjk2NDUzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9645316?v=4","gravatar_id":"","url":"https://api.github.com/users/Anbranin","html_url":"https://github.com/Anbranin","followers_url":"https://api.github.com/users/Anbranin/followers","following_url":"https://api.github.com/users/Anbranin/following{/other_user}","gists_url":"https://api.github.com/users/Anbranin/gists{/gist_id}","starred_url":"https://api.github.com/users/Anbranin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anbranin/subscriptions","organizations_url":"https://api.github.com/users/Anbranin/orgs","repos_url":"https://api.github.com/users/Anbranin/repos","events_url":"https://api.github.com/users/Anbranin/events{/privacy}","received_events_url":"https://api.github.com/users/Anbranin/received_events","type":"User","site_admin":false},"body":"Updated the Android [doc](https://github.com/umts/pvta-multiplatform/blob/70de4aa4ef74892002b09f349e097d79b4862b9d/doc/deploy/android.md) and some packages.","created_at":"2018-10-09T19:00:56Z","updated_at":"2018-10-09T21:07:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c3d45d0548dc2ac116820dc71efe864e22af71d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mboneil10","id":19267771,"node_id":"MDQ6VXNlcjE5MjY3Nzcx","avatar_url":"https://avatars2.githubusercontent.com/u/19267771?v=4","gravatar_id":"","url":"https://api.github.com/users/mboneil10","html_url":"https://github.com/mboneil10","followers_url":"https://api.github.com/users/mboneil10/followers","following_url":"https://api.github.com/users/mboneil10/following{/other_user}","gists_url":"https://api.github.com/users/mboneil10/gists{/gist_id}","starred_url":"https://api.github.com/users/mboneil10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboneil10/subscriptions","organizations_url":"https://api.github.com/users/mboneil10/orgs","repos_url":"https://api.github.com/users/mboneil10/repos","events_url":"https://api.github.com/users/mboneil10/events{/privacy}","received_events_url":"https://api.github.com/users/mboneil10/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477/commits","review_comments_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477/comments","review_comment_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/477/comments","statuses_url":"https://api.github.com/repos/umts/pvta-multiplatform/statuses/5d337a760f691a47ce95e314d6db44e9564bd59a","head":{"label":"umts:build-test","ref":"build-test","sha":"5d337a760f691a47ce95e314d6db44e9564bd59a","user":{"login":"umts","id":398175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398175?v=4","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"repo":{"id":49676297,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY3NjI5Nw==","name":"pvta-multiplatform","full_name":"umts/pvta-multiplatform","private":false,"owner":{"login":"umts","id":398175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398175?v=4","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/umts/pvta-multiplatform","description":"Transit realtime app for mobile devices","fork":false,"url":"https://api.github.com/repos/umts/pvta-multiplatform","forks_url":"https://api.github.com/repos/umts/pvta-multiplatform/forks","keys_url":"https://api.github.com/repos/umts/pvta-multiplatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umts/pvta-multiplatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umts/pvta-multiplatform/teams","hooks_url":"https://api.github.com/repos/umts/pvta-multiplatform/hooks","issue_events_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/events{/number}","events_url":"https://api.github.com/repos/umts/pvta-multiplatform/events","assignees_url":"https://api.github.com/repos/umts/pvta-multiplatform/assignees{/user}","branches_url":"https://api.github.com/repos/umts/pvta-multiplatform/branches{/branch}","tags_url":"https://api.github.com/repos/umts/pvta-multiplatform/tags","blobs_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umts/pvta-multiplatform/statuses/{sha}","languages_url":"https://api.github.com/repos/umts/pvta-multiplatform/languages","stargazers_url":"https://api.github.com/repos/umts/pvta-multiplatform/stargazers","contributors_url":"https://api.github.com/repos/umts/pvta-multiplatform/contributors","subscribers_url":"https://api.github.com/repos/umts/pvta-multiplatform/subscribers","subscription_url":"https://api.github.com/repos/umts/pvta-multiplatform/subscription","commits_url":"https://api.github.com/repos/umts/pvta-multiplatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/umts/pvta-multiplatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/umts/pvta-multiplatform/contents/{+path}","compare_url":"https://api.github.com/repos/umts/pvta-multiplatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umts/pvta-multiplatform/merges","archive_url":"https://api.github.com/repos/umts/pvta-multiplatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umts/pvta-multiplatform/downloads","issues_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues{/number}","pulls_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls{/number}","milestones_url":"https://api.github.com/repos/umts/pvta-multiplatform/milestones{/number}","notifications_url":"https://api.github.com/repos/umts/pvta-multiplatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umts/pvta-multiplatform/labels{/name}","releases_url":"https://api.github.com/repos/umts/pvta-multiplatform/releases{/id}","deployments_url":"https://api.github.com/repos/umts/pvta-multiplatform/deployments","created_at":"2016-01-14T21:28:36Z","updated_at":"2018-10-01T14:46:35Z","pushed_at":"2018-10-09T19:40:28Z","git_url":"git://github.com/umts/pvta-multiplatform.git","ssh_url":"git@github.com:umts/pvta-multiplatform.git","clone_url":"https://github.com/umts/pvta-multiplatform.git","svn_url":"https://github.com/umts/pvta-multiplatform","homepage":"","size":52597,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":15,"watchers":5,"default_branch":"master"}},"base":{"label":"umts:master","ref":"master","sha":"a3cb4ac3a9819288a2976c97a0596ecfaff3b391","user":{"login":"umts","id":398175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398175?v=4","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"repo":{"id":49676297,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY3NjI5Nw==","name":"pvta-multiplatform","full_name":"umts/pvta-multiplatform","private":false,"owner":{"login":"umts","id":398175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398175?v=4","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/umts/pvta-multiplatform","description":"Transit realtime app for mobile devices","fork":false,"url":"https://api.github.com/repos/umts/pvta-multiplatform","forks_url":"https://api.github.com/repos/umts/pvta-multiplatform/forks","keys_url":"https://api.github.com/repos/umts/pvta-multiplatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umts/pvta-multiplatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umts/pvta-multiplatform/teams","hooks_url":"https://api.github.com/repos/umts/pvta-multiplatform/hooks","issue_events_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/events{/number}","events_url":"https://api.github.com/repos/umts/pvta-multiplatform/events","assignees_url":"https://api.github.com/repos/umts/pvta-multiplatform/assignees{/user}","branches_url":"https://api.github.com/repos/umts/pvta-multiplatform/branches{/branch}","tags_url":"https://api.github.com/repos/umts/pvta-multiplatform/tags","blobs_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umts/pvta-multiplatform/statuses/{sha}","languages_url":"https://api.github.com/repos/umts/pvta-multiplatform/languages","stargazers_url":"https://api.github.com/repos/umts/pvta-multiplatform/stargazers","contributors_url":"https://api.github.com/repos/umts/pvta-multiplatform/contributors","subscribers_url":"https://api.github.com/repos/umts/pvta-multiplatform/subscribers","subscription_url":"https://api.github.com/repos/umts/pvta-multiplatform/subscription","commits_url":"https://api.github.com/repos/umts/pvta-multiplatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/umts/pvta-multiplatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/umts/pvta-multiplatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/umts/pvta-multiplatform/contents/{+path}","compare_url":"https://api.github.com/repos/umts/pvta-multiplatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umts/pvta-multiplatform/merges","archive_url":"https://api.github.com/repos/umts/pvta-multiplatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umts/pvta-multiplatform/downloads","issues_url":"https://api.github.com/repos/umts/pvta-multiplatform/issues{/number}","pulls_url":"https://api.github.com/repos/umts/pvta-multiplatform/pulls{/number}","milestones_url":"https://api.github.com/repos/umts/pvta-multiplatform/milestones{/number}","notifications_url":"https://api.github.com/repos/umts/pvta-multiplatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umts/pvta-multiplatform/labels{/name}","releases_url":"https://api.github.com/repos/umts/pvta-multiplatform/releases{/id}","deployments_url":"https://api.github.com/repos/umts/pvta-multiplatform/deployments","created_at":"2016-01-14T21:28:36Z","updated_at":"2018-10-01T14:46:35Z","pushed_at":"2018-10-09T19:40:28Z","git_url":"git://github.com/umts/pvta-multiplatform.git","ssh_url":"git@github.com:umts/pvta-multiplatform.git","clone_url":"https://github.com/umts/pvta-multiplatform.git","svn_url":"https://github.com/umts/pvta-multiplatform","homepage":"","size":52597,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":15,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477"},"html":{"href":"https://github.com/umts/pvta-multiplatform/pull/477"},"issue":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/issues/477"},"comments":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/umts/pvta-multiplatform/statuses/5d337a760f691a47ce95e314d6db44e9564bd59a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"werebus"}}