{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/526","repository_url":"https://api.github.com/repos/kubeflow/tf-operator","labels_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/526/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/526/comments","events_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/526/events","html_url":"https://github.com/kubeflow/tf-operator/pull/526","id":313167533,"number":526,"title":"v1alpha2: Add implementation","user":{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"labels":[{"id":845800081,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/size/XXL","name":"size/XXL","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"ddysher","id":2191361,"avatar_url":"https://avatars1.githubusercontent.com/u/2191361?v=4","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},{"login":"mitake","id":1173955,"avatar_url":"https://avatars3.githubusercontent.com/u/1173955?v=4","gravatar_id":"","url":"https://api.github.com/users/mitake","html_url":"https://github.com/mitake","followers_url":"https://api.github.com/users/mitake/followers","following_url":"https://api.github.com/users/mitake/following{/other_user}","gists_url":"https://api.github.com/users/mitake/gists{/gist_id}","starred_url":"https://api.github.com/users/mitake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitake/subscriptions","organizations_url":"https://api.github.com/users/mitake/orgs","repos_url":"https://api.github.com/users/mitake/repos","events_url":"https://api.github.com/users/mitake/events{/privacy}","received_events_url":"https://api.github.com/users/mitake/received_events","type":"User","site_admin":false},{"login":"ddysher","id":2191361,"avatar_url":"https://avatars1.githubusercontent.com/u/2191361?v=4","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},{"login":"DjangoPeng","id":16943353,"avatar_url":"https://avatars3.githubusercontent.com/u/16943353?v=4","gravatar_id":"","url":"https://api.github.com/users/DjangoPeng","html_url":"https://github.com/DjangoPeng","followers_url":"https://api.github.com/users/DjangoPeng/followers","following_url":"https://api.github.com/users/DjangoPeng/following{/other_user}","gists_url":"https://api.github.com/users/DjangoPeng/gists{/gist_id}","starred_url":"https://api.github.com/users/DjangoPeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DjangoPeng/subscriptions","organizations_url":"https://api.github.com/users/DjangoPeng/orgs","repos_url":"https://api.github.com/users/DjangoPeng/repos","events_url":"https://api.github.com/users/DjangoPeng/events{/privacy}","received_events_url":"https://api.github.com/users/DjangoPeng/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-04-11T04:12:31Z","updated_at":"2018-04-13T03:55:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/526","html_url":"https://github.com/kubeflow/tf-operator/pull/526","diff_url":"https://github.com/kubeflow/tf-operator/pull/526.diff","patch_url":"https://github.com/kubeflow/tf-operator/pull/526.patch"},"body":"/assign @ddysher @DjangoPeng @jlewi @mitake @ScorpioCPH \r\n\r\nThis PR is the implementation of v1alpha2 and it is mainly contributed by @ScorpioCPH  and @gaocegege\r\n\r\nSigned-off-by: Ce Gao <gaoce@caicloud.io>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/tf-operator/526)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/comments/381014482","html_url":"https://github.com/kubeflow/tf-operator/pull/526#issuecomment-381014482","issue_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/526","id":381014482,"user":{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T03:55:28Z","updated_at":"2018-04-13T03:55:28Z","author_association":"MEMBER","body":"\n\n\n\n\n\n\n\n*[pkg/controller.v2/controller_pod.go, line 218 at r7](https://beta.reviewable.io/reviews/kubeflow/tf-operator/526#-L9x1FyGAyzQyM2DeIhg:-L9x6hOY09JDcKw2mxLu:b-ksrkrq) ([raw file](https://github.com/kubeflow/tf-operator/blob/5390442472f33c00ed5f4d1341811d60373d5ff6/pkg/controller.v2/controller_pod.go#L218)):*\n<details><summary><i>Previously, jlewi (Jeremy Lewi) wrote…</i></summary><blockquote>\n\nWhat does adopting/orphaning pods mean? I assume it means changing the owner ref on the pod to point to this TFJob controller.\n\nDo we actually expect this to happen? Why would the labels or selector get changed  on the pod?\n</blockquote></details>\n\nIt is from job controllers. We do not expect there are orphaning pods but there will be new pods which need to be claimed.\n\n/cc @ScorpioCPH\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/kubeflow/tf-operator/526)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"gaocegege"}}