{"action":"created","comment":{"url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/comments/206039312","pull_request_review_id":141420851,"id":206039312,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjAzOTMxMg==","diff_hunk":"@@ -234,43 +197,53 @@ case \"$SYSTEM_NAME\" in\n \t\tmv -v ${DESTDIR}share ${macOSPath}/ || exit 1\n \t;;\n \tWindows)\n-\t\tmingw=/usr\n \t\tlua=\"\"\n \t\tcase \"$SYSTEM_ARCH\" in\n \t\t\ti686|*86)\n-\t\t\t\tif [ -d /usr/i686-pc-mingw32 ]; then\n-\t\t\t\t\tmingw=/usr/i686-pc-mingw32\n-\t\t\t\telse\n-\t\t\t\t\tmingw=/usr/i686-mingw32\n-\t\t\t\tfi\n \t\t\t\tlua=win32\n \t\t\t;;\n \t\t\tx86_64|*64)\n-\t\t\t\tif [ -d /usr/i686-pc-mingw32 ]; then\n-\t\t\t\t\tmingw=/usr/x86_64-pc-mingw32\n-\t\t\t\telse\n-\t\t\t\t\tmingw=/usr/x86_64-mingw32\n-\t\t\t\tfi\n \t\t\t\tlua=win64\n \t\t\t;;\n \t\tesac\n-\t\t\n+\n \t\tcp -v ${RTTR_SRCDIR}/contrib/lua/${lua}/lua52.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libgcc_s_sjlj-1.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libminiupnpc-5.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libiconv-2.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libintl-8.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libogg-0.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/SDL_mixer.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/SDL.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libvorbis-0.dll ${DESTDIR} || exit 1\n-\t\tcp -v ${mingw}/bin/libvorbisfile-3.dll ${DESTDIR} || exit 1\n+\n+\t\tif [ -f $SYSROOT/bin/libgcc_s_sjlj-1.dll ] ; then","path":"release/prepareRelease.sh.cmake","position":162,"original_position":162,"commit_id":"2734336c9c81aeada57950ea67e00bd3d19608ef","original_commit_id":"2734336c9c81aeada57950ea67e00bd3d19608ef","user":{"login":"Flow86","id":656249,"node_id":"MDQ6VXNlcjY1NjI0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/656249?v=4","gravatar_id":"","url":"https://api.github.com/users/Flow86","html_url":"https://github.com/Flow86","followers_url":"https://api.github.com/users/Flow86/followers","following_url":"https://api.github.com/users/Flow86/following{/other_user}","gists_url":"https://api.github.com/users/Flow86/gists{/gist_id}","starred_url":"https://api.github.com/users/Flow86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flow86/subscriptions","organizations_url":"https://api.github.com/users/Flow86/orgs","repos_url":"https://api.github.com/users/Flow86/repos","events_url":"https://api.github.com/users/Flow86/events{/privacy}","received_events_url":"https://api.github.com/users/Flow86/received_events","type":"User","site_admin":false},"body":"hier ists doch etwas \"komplizierter\" da der 32bit mingw compiler die sjlj erzeugt, der 64bit die seh. Beide brauchen jedoch in der neuen Version zwingend die libstdc++","created_at":"2018-07-30T07:43:30Z","updated_at":"2018-07-30T07:43:30Z","html_url":"https://github.com/Return-To-The-Roots/s25client/pull/857#discussion_r206039312","pull_request_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/comments/206039312"},"html":{"href":"https://github.com/Return-To-The-Roots/s25client/pull/857#discussion_r206039312"},"pull_request":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857"}}},"pull_request":{"url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857","id":204587294,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTg3Mjk0","html_url":"https://github.com/Return-To-The-Roots/s25client/pull/857","diff_url":"https://github.com/Return-To-The-Roots/s25client/pull/857.diff","patch_url":"https://github.com/Return-To-The-Roots/s25client/pull/857.patch","issue_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/857","number":857,"state":"open","locked":false,"title":"ENH: Update Mingw Compiler","user":{"login":"Flow86","id":656249,"node_id":"MDQ6VXNlcjY1NjI0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/656249?v=4","gravatar_id":"","url":"https://api.github.com/users/Flow86","html_url":"https://github.com/Flow86","followers_url":"https://api.github.com/users/Flow86/followers","following_url":"https://api.github.com/users/Flow86/following{/other_user}","gists_url":"https://api.github.com/users/Flow86/gists{/gist_id}","starred_url":"https://api.github.com/users/Flow86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flow86/subscriptions","organizations_url":"https://api.github.com/users/Flow86/orgs","repos_url":"https://api.github.com/users/Flow86/repos","events_url":"https://api.github.com/users/Flow86/events{/privacy}","received_events_url":"https://api.github.com/users/Flow86/received_events","type":"User","site_admin":false},"body":"https://github.com/Return-To-The-Roots/s25client/issues/856\r\n\r\nI also had to add FindSDL_mixer.cmake and fix the include path find code. it seems to be wrong in cmake 3.0.2","created_at":"2018-07-28T10:23:39Z","updated_at":"2018-07-30T07:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"434fc170a8269f2f5df28adc4b5c9a1b443aaba5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857/commits","review_comments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857/comments","review_comment_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/857/comments","statuses_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/statuses/2734336c9c81aeada57950ea67e00bd3d19608ef","head":{"label":"Return-To-The-Roots:updated-mingw","ref":"updated-mingw","sha":"2734336c9c81aeada57950ea67e00bd3d19608ef","user":{"login":"Return-To-The-Roots","id":2520313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjAzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2520313?v=4","gravatar_id":"","url":"https://api.github.com/users/Return-To-The-Roots","html_url":"https://github.com/Return-To-The-Roots","followers_url":"https://api.github.com/users/Return-To-The-Roots/followers","following_url":"https://api.github.com/users/Return-To-The-Roots/following{/other_user}","gists_url":"https://api.github.com/users/Return-To-The-Roots/gists{/gist_id}","starred_url":"https://api.github.com/users/Return-To-The-Roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Return-To-The-Roots/subscriptions","organizations_url":"https://api.github.com/users/Return-To-The-Roots/orgs","repos_url":"https://api.github.com/users/Return-To-The-Roots/repos","events_url":"https://api.github.com/users/Return-To-The-Roots/events{/privacy}","received_events_url":"https://api.github.com/users/Return-To-The-Roots/received_events","type":"Organization","site_admin":false},"repo":{"id":11231381,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMTM4MQ==","name":"s25client","full_name":"Return-To-The-Roots/s25client","owner":{"login":"Return-To-The-Roots","id":2520313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjAzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2520313?v=4","gravatar_id":"","url":"https://api.github.com/users/Return-To-The-Roots","html_url":"https://github.com/Return-To-The-Roots","followers_url":"https://api.github.com/users/Return-To-The-Roots/followers","following_url":"https://api.github.com/users/Return-To-The-Roots/following{/other_user}","gists_url":"https://api.github.com/users/Return-To-The-Roots/gists{/gist_id}","starred_url":"https://api.github.com/users/Return-To-The-Roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Return-To-The-Roots/subscriptions","organizations_url":"https://api.github.com/users/Return-To-The-Roots/orgs","repos_url":"https://api.github.com/users/Return-To-The-Roots/repos","events_url":"https://api.github.com/users/Return-To-The-Roots/events{/privacy}","received_events_url":"https://api.github.com/users/Return-To-The-Roots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Return-To-The-Roots/s25client","description":"Return To The Roots (Settlers II(R) Clone)","fork":false,"url":"https://api.github.com/repos/Return-To-The-Roots/s25client","forks_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/forks","keys_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/teams","hooks_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/hooks","issue_events_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/events{/number}","events_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/events","assignees_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/assignees{/user}","branches_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/branches{/branch}","tags_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/tags","blobs_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/statuses/{sha}","languages_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/languages","stargazers_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/stargazers","contributors_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/contributors","subscribers_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/subscribers","subscription_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/subscription","commits_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/contents/{+path}","compare_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/merges","archive_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/downloads","issues_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues{/number}","pulls_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls{/number}","milestones_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/milestones{/number}","notifications_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/labels{/name}","releases_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/releases{/id}","deployments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/deployments","created_at":"2013-07-07T09:38:04Z","updated_at":"2018-07-24T07:57:39Z","pushed_at":"2018-07-30T07:41:18Z","git_url":"git://github.com/Return-To-The-Roots/s25client.git","ssh_url":"git@github.com:Return-To-The-Roots/s25client.git","clone_url":"https://github.com/Return-To-The-Roots/s25client.git","svn_url":"https://github.com/Return-To-The-Roots/s25client","homepage":"http://www.rttr.info","size":185068,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":32,"open_issues":162,"watchers":171,"default_branch":"master"}},"base":{"label":"Return-To-The-Roots:master","ref":"master","sha":"b85f9802479c05ef95e3257d2aa093a930827656","user":{"login":"Return-To-The-Roots","id":2520313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjAzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2520313?v=4","gravatar_id":"","url":"https://api.github.com/users/Return-To-The-Roots","html_url":"https://github.com/Return-To-The-Roots","followers_url":"https://api.github.com/users/Return-To-The-Roots/followers","following_url":"https://api.github.com/users/Return-To-The-Roots/following{/other_user}","gists_url":"https://api.github.com/users/Return-To-The-Roots/gists{/gist_id}","starred_url":"https://api.github.com/users/Return-To-The-Roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Return-To-The-Roots/subscriptions","organizations_url":"https://api.github.com/users/Return-To-The-Roots/orgs","repos_url":"https://api.github.com/users/Return-To-The-Roots/repos","events_url":"https://api.github.com/users/Return-To-The-Roots/events{/privacy}","received_events_url":"https://api.github.com/users/Return-To-The-Roots/received_events","type":"Organization","site_admin":false},"repo":{"id":11231381,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMTM4MQ==","name":"s25client","full_name":"Return-To-The-Roots/s25client","owner":{"login":"Return-To-The-Roots","id":2520313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjAzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2520313?v=4","gravatar_id":"","url":"https://api.github.com/users/Return-To-The-Roots","html_url":"https://github.com/Return-To-The-Roots","followers_url":"https://api.github.com/users/Return-To-The-Roots/followers","following_url":"https://api.github.com/users/Return-To-The-Roots/following{/other_user}","gists_url":"https://api.github.com/users/Return-To-The-Roots/gists{/gist_id}","starred_url":"https://api.github.com/users/Return-To-The-Roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Return-To-The-Roots/subscriptions","organizations_url":"https://api.github.com/users/Return-To-The-Roots/orgs","repos_url":"https://api.github.com/users/Return-To-The-Roots/repos","events_url":"https://api.github.com/users/Return-To-The-Roots/events{/privacy}","received_events_url":"https://api.github.com/users/Return-To-The-Roots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Return-To-The-Roots/s25client","description":"Return To The Roots (Settlers II(R) Clone)","fork":false,"url":"https://api.github.com/repos/Return-To-The-Roots/s25client","forks_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/forks","keys_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/teams","hooks_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/hooks","issue_events_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/events{/number}","events_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/events","assignees_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/assignees{/user}","branches_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/branches{/branch}","tags_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/tags","blobs_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/statuses/{sha}","languages_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/languages","stargazers_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/stargazers","contributors_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/contributors","subscribers_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/subscribers","subscription_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/subscription","commits_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/contents/{+path}","compare_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/merges","archive_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/downloads","issues_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues{/number}","pulls_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls{/number}","milestones_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/milestones{/number}","notifications_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/labels{/name}","releases_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/releases{/id}","deployments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/deployments","created_at":"2013-07-07T09:38:04Z","updated_at":"2018-07-24T07:57:39Z","pushed_at":"2018-07-30T07:41:18Z","git_url":"git://github.com/Return-To-The-Roots/s25client.git","ssh_url":"git@github.com:Return-To-The-Roots/s25client.git","clone_url":"https://github.com/Return-To-The-Roots/s25client.git","svn_url":"https://github.com/Return-To-The-Roots/s25client","homepage":"http://www.rttr.info","size":185068,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":32,"open_issues":162,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857"},"html":{"href":"https://github.com/Return-To-The-Roots/s25client/pull/857"},"issue":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/857"},"comments":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/857/comments"},"review_comments":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857/comments"},"review_comment":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/pulls/857/commits"},"statuses":{"href":"https://api.github.com/repos/Return-To-The-Roots/s25client/statuses/2734336c9c81aeada57950ea67e00bd3d19608ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Flow86"}}