{"action":"created","issue":{"url":"https://api.github.com/repos/teeworlds/teeworlds/issues/1946","repository_url":"https://api.github.com/repos/teeworlds/teeworlds","labels_url":"https://api.github.com/repos/teeworlds/teeworlds/issues/1946/labels{/name}","comments_url":"https://api.github.com/repos/teeworlds/teeworlds/issues/1946/comments","events_url":"https://api.github.com/repos/teeworlds/teeworlds/issues/1946/events","html_url":"https://github.com/teeworlds/teeworlds/issues/1946","id":395523713,"node_id":"MDU6SXNzdWUzOTU1MjM3MTM=","number":1946,"title":"Windows x64 Compiling not possible with latest version","user":{"login":"Fisico","id":329471,"node_id":"MDQ6VXNlcjMyOTQ3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329471?v=4","gravatar_id":"","url":"https://api.github.com/users/Fisico","html_url":"https://github.com/Fisico","followers_url":"https://api.github.com/users/Fisico/followers","following_url":"https://api.github.com/users/Fisico/following{/other_user}","gists_url":"https://api.github.com/users/Fisico/gists{/gist_id}","starred_url":"https://api.github.com/users/Fisico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fisico/subscriptions","organizations_url":"https://api.github.com/users/Fisico/orgs","repos_url":"https://api.github.com/users/Fisico/repos","events_url":"https://api.github.com/users/Fisico/events{/privacy}","received_events_url":"https://api.github.com/users/Fisico/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-03T10:33:09Z","updated_at":"2019-01-04T00:17:22Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Windows x64 compiling is not possible any more with the latest build.\r\n\r\nDownload.py asks for a x86_64 argument that can't be run because cross platform compiling is not supported on windows. \r\n\r\nLatest TW source\r\nLatest bam build\r\nVS 2017 Community Edition\r\n\r\n------------Log----------\r\n[ 11/707] [2] c++ src/engine/shared/ringbuffer.cpp\r\nusage: download.py [-h] [--arch {x86,x86_64}] [--conf {debug,release}]\r\n                   TARGET [TARGET ...]\r\ndownload.py: error: argument --arch: invalid choice: 'unknown' (choose from 'x86', 'x86_64')\r\nbam: 'Downloading SDL2 headers and DLL...' error 2\r\n\r\n[ 59/707] [8] c++ src/game/client/render_map.cpp\r\nusage: download.py [-h] [--arch {x86,x86_64}] [--conf {debug,release}]\r\n                   TARGET [TARGET ...]\r\ndownload.py: error: argument --arch: invalid choice: 'unknown' (choose from 'x86', 'x86_64')\r\n\r\n[ 60/707] [3] c++ src/game/client/ui.cpp\r\n[ 61/707] [6] c++ src/game/client/gameclient.cpp\r\nbam: 'Downloading freetype headers and DLL...' error 2\r\n\r\n[136/707] [2] c src/engine/external/wavpack/metadata.c\r\nsrc/engine/external/json-parser/json.c(141): warning C4311: \"Typumwandlung\": Zeigerverkürzung von \"json_object_entry *\" zu \"unsigned long\"\r\n"},"comment":{"url":"https://api.github.com/repos/teeworlds/teeworlds/issues/comments/451319727","html_url":"https://github.com/teeworlds/teeworlds/issues/1946#issuecomment-451319727","issue_url":"https://api.github.com/repos/teeworlds/teeworlds/issues/1946","id":451319727,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTMxOTcyNw==","user":{"login":"LordSk","id":294603,"node_id":"MDQ6VXNlcjI5NDYwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/294603?v=4","gravatar_id":"","url":"https://api.github.com/users/LordSk","html_url":"https://github.com/LordSk","followers_url":"https://api.github.com/users/LordSk/followers","following_url":"https://api.github.com/users/LordSk/following{/other_user}","gists_url":"https://api.github.com/users/LordSk/gists{/gist_id}","starred_url":"https://api.github.com/users/LordSk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LordSk/subscriptions","organizations_url":"https://api.github.com/users/LordSk/orgs","repos_url":"https://api.github.com/users/LordSk/repos","events_url":"https://api.github.com/users/LordSk/events{/privacy}","received_events_url":"https://api.github.com/users/LordSk/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T00:17:22Z","updated_at":"2019-01-04T00:17:22Z","author_association":"MEMBER","body":"This happens because bam does not detect x64 when building with MSCV2017 64bit.\r\nThe arch is then set to 'unknown'.\r\nIf we then try to force the arch, `bam arch=x86_64` we get a `Cross compiling is unsupported on Windows.`, because we check against bam's arch in bam.lua.\r\n\r\n```lua\r\nfunction GenerateWindowsSettings(settings, conf, target_arch, compiler)\r\n\tif compiler == \"cl\" then\r\n\t\tif (target_arch == \"x86\" and arch ~= \"ia32\") or\r\n\t\t   (target_arch == \"x86_64\" and arch ~= \"ia64\" and arch ~= \"amd64\") then\r\n\t\t\tprint(\"Cross compiling is unsupported on Windows.\")\r\n\t\t\tos.exit(1)\r\n\t\tend\r\n```\r\nhttps://github.com/teeworlds/teeworlds/blob/master/bam.lua#L218\r\n\r\nA simple fix would be checking the appropriate [predifined macro](https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2017) (_M_IX86, _M_AMD64).\r\nhttps://github.com/matricks/bam/blob/master/src/platform.h#L106\r\n\r\nSince matricks isn't really keeping bam up to date, should we use @Dune-jr's fork for now?\r\n"}}
{"actor":{"display_login":"LordSk"}}