{"action":"created","comment":{"url":"https://api.github.com/repos/cdapio/cdap/pulls/comments/244238254","pull_request_review_id":188191532,"id":244238254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDIzODI1NA==","diff_hunk":"@@ -0,0 +1,88 @@\n+/*\n+ * Copyright © 2018 Cask Data, Inc.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ *  use this file except in compliance with the License. You may obtain a copy of\n+ *  the License at\n+ *\n+ *  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ *  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ *  License for the specific language governing permissions and limitations under\n+ *  the License.\n+ */\n+\n+package co.cask.cdap.securestore.spi;\n+\n+import co.cask.cdap.securestore.spi.secret.Secret;\n+\n+import java.util.Map;\n+\n+/**\n+ * Secrets Manager interface to store secrets securely and retrieve them when needed. Secrets are small sensitive\n+ * information such as passwords, database credentials, API keys etc.\n+ *\n+ * TODO CDAP-14699 Expose dataset through context in initialize method.\n+ */\n+public interface SecretsManager {\n+  /**\n+   * Returns the name of the secrets manager.\n+   *\n+   * @return non-empty name of this secrets manager\n+   */\n+  String getSecretsManagerName();\n+\n+  /**\n+   * Initialize the secrets manager. This method is guaranteed to be called before any other method is called.\n+   * It will only be called once for the lifetime of the secrets manager.\n+   *\n+   * @param context the context that can be used to initialize the secrets manager\n+   */\n+  void initialize(SecretsManagerContext context) throws Exception;","path":"cdap-securestore-spi/src/main/java/co/cask/cdap/securestore/spi/SecretsManager.java","position":null,"original_position":43,"commit_id":"4690b3571083390c0049a059cc61baa763df93d8","original_commit_id":"3e68f683b2dcb249964a82c771d3862456760863","user":{"login":"CuriousVini","id":14131070,"node_id":"MDQ6VXNlcjE0MTMxMDcw","avatar_url":"https://avatars0.githubusercontent.com/u/14131070?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousVini","html_url":"https://github.com/CuriousVini","followers_url":"https://api.github.com/users/CuriousVini/followers","following_url":"https://api.github.com/users/CuriousVini/following{/other_user}","gists_url":"https://api.github.com/users/CuriousVini/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousVini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousVini/subscriptions","organizations_url":"https://api.github.com/users/CuriousVini/orgs","repos_url":"https://api.github.com/users/CuriousVini/repos","events_url":"https://api.github.com/users/CuriousVini/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousVini/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-12-27T23:03:16Z","updated_at":"2018-12-27T23:03:16Z","html_url":"https://github.com/cdapio/cdap/pull/10898#discussion_r244238254","pull_request_url":"https://api.github.com/repos/cdapio/cdap/pulls/10898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/comments/244238254"},"html":{"href":"https://github.com/cdapio/cdap/pull/10898#discussion_r244238254"},"pull_request":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10898"}},"in_reply_to_id":244041793},"pull_request":{"url":"https://api.github.com/repos/cdapio/cdap/pulls/10898","id":241025478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDI1NDc4","html_url":"https://github.com/cdapio/cdap/pull/10898","diff_url":"https://github.com/cdapio/cdap/pull/10898.diff","patch_url":"https://github.com/cdapio/cdap/pull/10898.patch","issue_url":"https://api.github.com/repos/cdapio/cdap/issues/10898","number":10898,"state":"open","locked":false,"title":"CDAP-14665 Add secure store spis","user":{"login":"CuriousVini","id":14131070,"node_id":"MDQ6VXNlcjE0MTMxMDcw","avatar_url":"https://avatars0.githubusercontent.com/u/14131070?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousVini","html_url":"https://github.com/CuriousVini","followers_url":"https://api.github.com/users/CuriousVini/followers","following_url":"https://api.github.com/users/CuriousVini/following{/other_user}","gists_url":"https://api.github.com/users/CuriousVini/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousVini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousVini/subscriptions","organizations_url":"https://api.github.com/users/CuriousVini/orgs","repos_url":"https://api.github.com/users/CuriousVini/repos","events_url":"https://api.github.com/users/CuriousVini/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousVini/received_events","type":"User","site_admin":false},"body":"Issue: https://issues.cask.co/browse/CDAP-14667\r\n","created_at":"2018-12-26T19:24:27Z","updated_at":"2018-12-27T23:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff99d1ca171ed6e3cf6cbc3f926f29f6d75539ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cdapio/cdap/pulls/10898/commits","review_comments_url":"https://api.github.com/repos/cdapio/cdap/pulls/10898/comments","review_comment_url":"https://api.github.com/repos/cdapio/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdapio/cdap/issues/10898/comments","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/4690b3571083390c0049a059cc61baa763df93d8","head":{"label":"cdapio:feature/CDAP-14667-add-secure-store-spi","ref":"feature/CDAP-14667-add-secure-store-spi","sha":"4690b3571083390c0049a059cc61baa763df93d8","user":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"cdapio/cdap","private":false,"owner":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cdapio/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/cdapio/cdap","forks_url":"https://api.github.com/repos/cdapio/cdap/forks","keys_url":"https://api.github.com/repos/cdapio/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdapio/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdapio/cdap/teams","hooks_url":"https://api.github.com/repos/cdapio/cdap/hooks","issue_events_url":"https://api.github.com/repos/cdapio/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/cdapio/cdap/events","assignees_url":"https://api.github.com/repos/cdapio/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/cdapio/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/cdapio/cdap/tags","blobs_url":"https://api.github.com/repos/cdapio/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdapio/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdapio/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdapio/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/cdapio/cdap/languages","stargazers_url":"https://api.github.com/repos/cdapio/cdap/stargazers","contributors_url":"https://api.github.com/repos/cdapio/cdap/contributors","subscribers_url":"https://api.github.com/repos/cdapio/cdap/subscribers","subscription_url":"https://api.github.com/repos/cdapio/cdap/subscription","commits_url":"https://api.github.com/repos/cdapio/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdapio/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdapio/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdapio/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdapio/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/cdapio/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdapio/cdap/merges","archive_url":"https://api.github.com/repos/cdapio/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdapio/cdap/downloads","issues_url":"https://api.github.com/repos/cdapio/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/cdapio/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/cdapio/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/cdapio/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdapio/cdap/labels{/name}","releases_url":"https://api.github.com/repos/cdapio/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/cdapio/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-12-27T18:49:58Z","pushed_at":"2018-12-27T23:02:14Z","git_url":"git://github.com/cdapio/cdap.git","ssh_url":"git@github.com:cdapio/cdap.git","clone_url":"https://github.com/cdapio/cdap.git","svn_url":"https://github.com/cdapio/cdap","homepage":"https://cdap.io","size":554504,"stargazers_count":283,"watchers_count":283,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":147,"open_issues":7,"watchers":283,"default_branch":"develop"}},"base":{"label":"cdapio:develop","ref":"develop","sha":"4283ac95d7827b709356a72adb9493ed3efe50a8","user":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU0Mjc1OQ==","name":"cdap","full_name":"cdapio/cdap","private":false,"owner":{"login":"cdapio","id":8123023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/cdapio","html_url":"https://github.com/cdapio","followers_url":"https://api.github.com/users/cdapio/followers","following_url":"https://api.github.com/users/cdapio/following{/other_user}","gists_url":"https://api.github.com/users/cdapio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdapio/subscriptions","organizations_url":"https://api.github.com/users/cdapio/orgs","repos_url":"https://api.github.com/users/cdapio/repos","events_url":"https://api.github.com/users/cdapio/events{/privacy}","received_events_url":"https://api.github.com/users/cdapio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cdapio/cdap","description":"An open source framework for building data analytic applications.","fork":false,"url":"https://api.github.com/repos/cdapio/cdap","forks_url":"https://api.github.com/repos/cdapio/cdap/forks","keys_url":"https://api.github.com/repos/cdapio/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdapio/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdapio/cdap/teams","hooks_url":"https://api.github.com/repos/cdapio/cdap/hooks","issue_events_url":"https://api.github.com/repos/cdapio/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/cdapio/cdap/events","assignees_url":"https://api.github.com/repos/cdapio/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/cdapio/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/cdapio/cdap/tags","blobs_url":"https://api.github.com/repos/cdapio/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdapio/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdapio/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdapio/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdapio/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/cdapio/cdap/languages","stargazers_url":"https://api.github.com/repos/cdapio/cdap/stargazers","contributors_url":"https://api.github.com/repos/cdapio/cdap/contributors","subscribers_url":"https://api.github.com/repos/cdapio/cdap/subscribers","subscription_url":"https://api.github.com/repos/cdapio/cdap/subscription","commits_url":"https://api.github.com/repos/cdapio/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdapio/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdapio/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdapio/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdapio/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/cdapio/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdapio/cdap/merges","archive_url":"https://api.github.com/repos/cdapio/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdapio/cdap/downloads","issues_url":"https://api.github.com/repos/cdapio/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/cdapio/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/cdapio/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/cdapio/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdapio/cdap/labels{/name}","releases_url":"https://api.github.com/repos/cdapio/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/cdapio/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2018-12-27T18:49:58Z","pushed_at":"2018-12-27T23:02:14Z","git_url":"git://github.com/cdapio/cdap.git","ssh_url":"git@github.com:cdapio/cdap.git","clone_url":"https://github.com/cdapio/cdap.git","svn_url":"https://github.com/cdapio/cdap","homepage":"https://cdap.io","size":554504,"stargazers_count":283,"watchers_count":283,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":147,"open_issues":7,"watchers":283,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10898"},"html":{"href":"https://github.com/cdapio/cdap/pull/10898"},"issue":{"href":"https://api.github.com/repos/cdapio/cdap/issues/10898"},"comments":{"href":"https://api.github.com/repos/cdapio/cdap/issues/10898/comments"},"review_comments":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10898/comments"},"review_comment":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdapio/cdap/pulls/10898/commits"},"statuses":{"href":"https://api.github.com/repos/cdapio/cdap/statuses/4690b3571083390c0049a059cc61baa763df93d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CuriousVini"}}