{"action":"created","comment":{"url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/comments/223205460","pull_request_review_id":162282184,"id":223205460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIwNTQ2MA==","diff_hunk":"@@ -30,6 +39,15 @@ export default function render(\n     getAllByName: getAllByName(instance),\n     getAllByText: getAllByText(instance),\n     getAllByProps: getAllByProps(instance),\n+\n+    queryByTestId: queryByTestId(instance),","path":"src/render.js","position":21,"original_position":21,"commit_id":"f2be9be4bc0c0ce0b7e145e3a9352f51c625ab2d","original_commit_id":"f2be9be4bc0c0ce0b7e145e3a9352f51c625ab2d","user":{"login":"Esemesek","id":9092510,"node_id":"MDQ6VXNlcjkwOTI1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9092510?v=4","gravatar_id":"","url":"https://api.github.com/users/Esemesek","html_url":"https://github.com/Esemesek","followers_url":"https://api.github.com/users/Esemesek/followers","following_url":"https://api.github.com/users/Esemesek/following{/other_user}","gists_url":"https://api.github.com/users/Esemesek/gists{/gist_id}","starred_url":"https://api.github.com/users/Esemesek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esemesek/subscriptions","organizations_url":"https://api.github.com/users/Esemesek/orgs","repos_url":"https://api.github.com/users/Esemesek/repos","events_url":"https://api.github.com/users/Esemesek/events{/privacy}","received_events_url":"https://api.github.com/users/Esemesek/received_events","type":"User","site_admin":false},"body":"I think we should replace exports from `getBy API` and `queryBy API` by some factory function to avoid listing all the re-exports here. Eg.\r\n```jsx\r\n// getBy.js\r\n...\r\nexport const getByAPI (instance) => ({\r\n  queryByTestId: queryByTestId(instance),\r\n  ...\r\n});\r\n\r\n// render.js\r\nreturn {\r\n  ...getByAPI(instance),\r\n  ...queryByAPI(instance),\r\n  ...\r\n}\r\n```","created_at":"2018-10-07T08:37:25Z","updated_at":"2018-10-07T08:38:41Z","html_url":"https://github.com/callstack/react-native-testing-library/pull/13#discussion_r223205460","pull_request_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/comments/223205460"},"html":{"href":"https://github.com/callstack/react-native-testing-library/pull/13#discussion_r223205460"},"pull_request":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13","id":220930931,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTMwOTMx","html_url":"https://github.com/callstack/react-native-testing-library/pull/13","diff_url":"https://github.com/callstack/react-native-testing-library/pull/13.diff","patch_url":"https://github.com/callstack/react-native-testing-library/pull/13.patch","issue_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/13","number":13,"state":"open","locked":false,"title":"feat: add query API","user":{"login":"thymikee","id":5106466,"node_id":"MDQ6VXNlcjUxMDY0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"body":"<!-- Please provide enough information so that others can review your pull request. -->\r\n<!-- Keep pull requests small and focused on a single change. -->\r\n\r\n### Summary\r\n\r\n`query` APIs corresponding to `get` APIs. For simplicity and code reuse I've decided to go with calling `get` APIs directly – as a downside we throw/catch errors twice. If this ever has a bigger perf impact we can switch the implementation.\r\n\r\nFixes #6 \r\n\r\n### Test plan\r\n\r\nAdded unit tests\r\n","created_at":"2018-10-07T06:54:10Z","updated_at":"2018-10-07T08:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab00929bd2c3e56e656107062e930cfaf2b1966","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13/commits","review_comments_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13/comments","review_comment_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/13/comments","statuses_url":"https://api.github.com/repos/callstack/react-native-testing-library/statuses/f2be9be4bc0c0ce0b7e145e3a9352f51c625ab2d","head":{"label":"callstack:feat/query-api","ref":"feat/query-api","sha":"f2be9be4bc0c0ce0b7e145e3a9352f51c625ab2d","user":{"login":"callstack","id":42239399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM5Mzk5","avatar_url":"https://avatars1.githubusercontent.com/u/42239399?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":151103020,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMDMwMjA=","name":"react-native-testing-library","full_name":"callstack/react-native-testing-library","private":false,"owner":{"login":"callstack","id":42239399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM5Mzk5","avatar_url":"https://avatars1.githubusercontent.com/u/42239399?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/callstack/react-native-testing-library","description":"Simple React Native testing utilities helping you write better tests with less effort","fork":false,"url":"https://api.github.com/repos/callstack/react-native-testing-library","forks_url":"https://api.github.com/repos/callstack/react-native-testing-library/forks","keys_url":"https://api.github.com/repos/callstack/react-native-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/react-native-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/react-native-testing-library/teams","hooks_url":"https://api.github.com/repos/callstack/react-native-testing-library/hooks","issue_events_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/react-native-testing-library/events","assignees_url":"https://api.github.com/repos/callstack/react-native-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/react-native-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/react-native-testing-library/tags","blobs_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/react-native-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/react-native-testing-library/languages","stargazers_url":"https://api.github.com/repos/callstack/react-native-testing-library/stargazers","contributors_url":"https://api.github.com/repos/callstack/react-native-testing-library/contributors","subscribers_url":"https://api.github.com/repos/callstack/react-native-testing-library/subscribers","subscription_url":"https://api.github.com/repos/callstack/react-native-testing-library/subscription","commits_url":"https://api.github.com/repos/callstack/react-native-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/react-native-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/react-native-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/react-native-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/react-native-testing-library/merges","archive_url":"https://api.github.com/repos/callstack/react-native-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/react-native-testing-library/downloads","issues_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/react-native-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/react-native-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/react-native-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/callstack/react-native-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/react-native-testing-library/deployments","created_at":"2018-10-01T14:32:13Z","updated_at":"2018-10-07T06:23:23Z","pushed_at":"2018-10-07T06:59:49Z","git_url":"git://github.com/callstack/react-native-testing-library.git","ssh_url":"git@github.com:callstack/react-native-testing-library.git","clone_url":"https://github.com/callstack/react-native-testing-library.git","svn_url":"https://github.com/callstack/react-native-testing-library","homepage":null,"size":115,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":14,"default_branch":"master"}},"base":{"label":"callstack:master","ref":"master","sha":"d66255d4825f1787ec4bdb659b3cf204e12846f2","user":{"login":"callstack","id":42239399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM5Mzk5","avatar_url":"https://avatars1.githubusercontent.com/u/42239399?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":151103020,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMDMwMjA=","name":"react-native-testing-library","full_name":"callstack/react-native-testing-library","private":false,"owner":{"login":"callstack","id":42239399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM5Mzk5","avatar_url":"https://avatars1.githubusercontent.com/u/42239399?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/callstack/react-native-testing-library","description":"Simple React Native testing utilities helping you write better tests with less effort","fork":false,"url":"https://api.github.com/repos/callstack/react-native-testing-library","forks_url":"https://api.github.com/repos/callstack/react-native-testing-library/forks","keys_url":"https://api.github.com/repos/callstack/react-native-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/react-native-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/react-native-testing-library/teams","hooks_url":"https://api.github.com/repos/callstack/react-native-testing-library/hooks","issue_events_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/react-native-testing-library/events","assignees_url":"https://api.github.com/repos/callstack/react-native-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/react-native-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/react-native-testing-library/tags","blobs_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/react-native-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/react-native-testing-library/languages","stargazers_url":"https://api.github.com/repos/callstack/react-native-testing-library/stargazers","contributors_url":"https://api.github.com/repos/callstack/react-native-testing-library/contributors","subscribers_url":"https://api.github.com/repos/callstack/react-native-testing-library/subscribers","subscription_url":"https://api.github.com/repos/callstack/react-native-testing-library/subscription","commits_url":"https://api.github.com/repos/callstack/react-native-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/react-native-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/react-native-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/react-native-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/react-native-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/react-native-testing-library/merges","archive_url":"https://api.github.com/repos/callstack/react-native-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/react-native-testing-library/downloads","issues_url":"https://api.github.com/repos/callstack/react-native-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/react-native-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/react-native-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/react-native-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/react-native-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/callstack/react-native-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/react-native-testing-library/deployments","created_at":"2018-10-01T14:32:13Z","updated_at":"2018-10-07T06:23:23Z","pushed_at":"2018-10-07T06:59:49Z","git_url":"git://github.com/callstack/react-native-testing-library.git","ssh_url":"git@github.com:callstack/react-native-testing-library.git","clone_url":"https://github.com/callstack/react-native-testing-library.git","svn_url":"https://github.com/callstack/react-native-testing-library","homepage":null,"size":115,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13"},"html":{"href":"https://github.com/callstack/react-native-testing-library/pull/13"},"issue":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/issues/13"},"comments":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/callstack/react-native-testing-library/statuses/f2be9be4bc0c0ce0b7e145e3a9352f51c625ab2d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Esemesek"}}