{"push_id":2592359043,"size":1,"distinct_size":1,"ref":"refs/heads/patch-9","head":"b2c0ec0cb3afb5134bcfb19a889fa9e15e2523e6","before":"82988def9e8d72f6eeb26c29b72e511c14a886df","commits":[{"sha":"b2c0ec0cb3afb5134bcfb19a889fa9e15e2523e6","author":{"name":"Web Addicto","email":"6a50effc1c370fbb2212182bac73dece0651063f@users.noreply.github.com"},"message":"Now data-expires=\"\" works as expected\n\nSeems that data-expires=\"90\" or data-expires=90 is always identified as string so here is the fix:\r\n\r\nIf this.options.expires is a string but is a valid number:\r\n\r\ndata-expires=\"90\"\r\n\r\nIt calculates today + 90 days and writes the expiration in cookie-friendly format.\r\n\r\nAnd if it is a string (but not a number):\r\n\r\ndata-expires=\"Thursday, August 28, 2018, 1:52:31 AM\"\r\n\r\nIt is written as is.\r\n\r\nTested and works fine like this:\r\n\r\ndata-expires=\"Thursday, August 28, 2018, 1:52:31 AM\"\r\nor\r\ndata-expires=\"90\"","distinct":true,"url":"https://api.github.com/repos/webaddicto/cookie-banner/commits/b2c0ec0cb3afb5134bcfb19a889fa9e15e2523e6"}]}
{"actor":{"display_login":"webaddicto"}}