{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/177183841","pull_request_review_id":107013432,"id":177183841,"diff_hunk":"@@ -322,15 +310,9 @@ - (nullable FSTMutationBatch *)nextMutationBatchAfterBatchID:(FSTBatchID)batchID\n   FSTBatchID nextBatchID = MAX(batchID, self.metadata.lastAcknowledgedBatchId) + 1;\n \n   std::string key = [self mutationKeyForBatchID:nextBatchID];\n-  std::unique_ptr<Iterator> it(_db->NewIterator(StandardReadOptions()));\n+  auto it = _db.currentTransaction->NewIterator();\n   it->Seek(key);\n \n-  Status status = it->status();","path":"Firestore/Source/Local/FSTLevelDBMutationQueue.mm","position":149,"original_position":149,"commit_id":"85ee18fe4864409d62b6d09dd3617f9bd1a98c41","original_commit_id":"4b9d73dffe093dd34c9d18dfdd489607e13adbbb","user":{"login":"wilhuff","id":10249104,"avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false},"body":"I'm not sure I want every call to `Valid()` to be paired with a call to `status()`, but it does seem like we likely want to call status at least once per method that called it.\r\n\r\nWithout necessarily addressing this throughout the codebase, is it possible to re-add these?","created_at":"2018-03-26T18:07:12Z","updated_at":"2018-03-26T18:07:12Z","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/968#discussion_r177183841","pull_request_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/177183841"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/968#discussion_r177183841"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968"}},"in_reply_to_id":176912882},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968","id":177136486,"html_url":"https://github.com/firebase/firebase-ios-sdk/pull/968","diff_url":"https://github.com/firebase/firebase-ios-sdk/pull/968.diff","patch_url":"https://github.com/firebase/firebase-ios-sdk/pull/968.patch","issue_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/968","number":968,"state":"open","locked":false,"title":"Switch LevelDB MutationQueue and RemoteDocumentCache to use transactions","user":{"login":"gsoltis","id":418301,"avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false},"body":"Adds `FSTWriteGroup` instances to the remaining places that need transactions. \r\n\r\nThis is the step before replacing `FSTWriteGroup` instances with calls to `FSTPersistence.runTransaction`.","created_at":"2018-03-23T17:26:53Z","updated_at":"2018-03-26T18:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c53ed46daae08ec68e8f9eb39cc2a1107234154e","assignee":{"login":"gsoltis","id":418301,"avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false},"assignees":[{"login":"gsoltis","id":418301,"avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":713434153,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/Firestore","name":"Firestore","color":"c5def5","default":false},{"id":658858759,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/968/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/85ee18fe4864409d62b6d09dd3617f9bd1a98c41","head":{"label":"firebase:swap_reads_rdc","ref":"swap_reads_rdc","sha":"85ee18fe4864409d62b6d09dd3617f9bd1a98c41","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-03-26T17:01:11Z","pushed_at":"2018-03-26T17:27:49Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":6262,"stargazers_count":624,"watchers_count":624,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":114,"open_issues":76,"watchers":624,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"b3050e42d842a4aef122efd277481c46bfa88dff","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-03-26T17:01:11Z","pushed_at":"2018-03-26T17:27:49Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":6262,"stargazers_count":624,"watchers_count":624,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":114,"open_issues":76,"watchers":624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/968"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/968"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/968/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/968/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/85ee18fe4864409d62b6d09dd3617f9bd1a98c41"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wilhuff"}}