{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/209713846","pull_request_review_id":145781540,"id":209713846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcxMzg0Ng==","diff_hunk":"@@ -398,6 +398,11 @@ def polyfit(x, y, deg, rcond=None, full=False, w=None, cov=False):\n     to points `(x, y)`. Returns a vector of coefficients `p` that minimises\n     the squared error.\n \n+    Please use `numpy.polynomial.Polynomial.fit` for new code. This remains","path":"numpy/lib/polynomial.py","position":4,"original_position":4,"commit_id":"4d704a9e0eee536a77b836cb6776b06913396da7","original_commit_id":"4d704a9e0eee536a77b836cb6776b06913396da7","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"Never mind, I now saw @charris's comment that in fact the class method is recommended.","created_at":"2018-08-13T18:34:47Z","updated_at":"2018-08-13T18:34:47Z","html_url":"https://github.com/numpy/numpy/pull/11733#discussion_r209713846","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/11733","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/209713846"},"html":{"href":"https://github.com/numpy/numpy/pull/11733#discussion_r209713846"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11733"}},"in_reply_to_id":209713574},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11733","id":208038309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDM4MzA5","html_url":"https://github.com/numpy/numpy/pull/11733","diff_url":"https://github.com/numpy/numpy/pull/11733.diff","patch_url":"https://github.com/numpy/numpy/pull/11733.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11733","number":11733,"state":"open","locked":false,"title":"DOC: recommend polynomial.Polynomial over np.polyfit","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"body":"Closes #11732 as per the comment in the issue.","created_at":"2018-08-13T16:47:37Z","updated_at":"2018-08-13T18:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e814d2d787db292aa30cdad69a189d4f9845d2e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359990,"node_id":"MDU6TGFiZWw2MzU5OTkw","url":"https://api.github.com/repos/numpy/numpy/labels/03%20-%20Documentation","name":"03 - Documentation","color":"fef2c0","default":false},{"id":16917596,"node_id":"MDU6TGFiZWwxNjkxNzU5Ng==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.polynomial","name":"component: numpy.polynomial","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/11733/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/11733/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11733/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/4d704a9e0eee536a77b836cb6776b06913396da7","head":{"label":"mattip:document-polyfit","ref":"document-polyfit","sha":"4d704a9e0eee536a77b836cb6776b06913396da7","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"repo":{"id":101918527,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTg1Mjc=","name":"numpy","full_name":"mattip/numpy","owner":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattip/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/mattip/numpy","forks_url":"https://api.github.com/repos/mattip/numpy/forks","keys_url":"https://api.github.com/repos/mattip/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattip/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattip/numpy/teams","hooks_url":"https://api.github.com/repos/mattip/numpy/hooks","issue_events_url":"https://api.github.com/repos/mattip/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/mattip/numpy/events","assignees_url":"https://api.github.com/repos/mattip/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/mattip/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/mattip/numpy/tags","blobs_url":"https://api.github.com/repos/mattip/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattip/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattip/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattip/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattip/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mattip/numpy/languages","stargazers_url":"https://api.github.com/repos/mattip/numpy/stargazers","contributors_url":"https://api.github.com/repos/mattip/numpy/contributors","subscribers_url":"https://api.github.com/repos/mattip/numpy/subscribers","subscription_url":"https://api.github.com/repos/mattip/numpy/subscription","commits_url":"https://api.github.com/repos/mattip/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattip/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattip/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattip/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattip/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/mattip/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattip/numpy/merges","archive_url":"https://api.github.com/repos/mattip/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattip/numpy/downloads","issues_url":"https://api.github.com/repos/mattip/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/mattip/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mattip/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mattip/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattip/numpy/labels{/name}","releases_url":"https://api.github.com/repos/mattip/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/mattip/numpy/deployments","created_at":"2017-08-30T19:01:59Z","updated_at":"2018-08-10T18:29:05Z","pushed_at":"2018-08-13T16:46:04Z","git_url":"git://github.com/mattip/numpy.git","ssh_url":"git@github.com:mattip/numpy.git","clone_url":"https://github.com/mattip/numpy.git","svn_url":"https://github.com/mattip/numpy","homepage":"http://www.numpy.org/","size":58963,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"ed35866c9fb5a25ba9368befebf3619575beaeb9","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-08-13T16:15:40Z","pushed_at":"2018-08-13T16:47:37Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":59795,"stargazers_count":7939,"watchers_count":7939,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2924,"mirror_url":null,"archived":false,"open_issues_count":1934,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2924,"open_issues":1934,"watchers":7939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11733"},"html":{"href":"https://github.com/numpy/numpy/pull/11733"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/11733"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/11733/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11733/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11733/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/4d704a9e0eee536a77b836cb6776b06913396da7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mhvk"}}