{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/comments/176657832","pull_request_review_id":106400300,"id":176657832,"diff_hunk":"@@ -12,18 +14,18 @@ export default class FindADomainComponent extends BaseContainer {\n \t}\n \n \twaitForResults() {\n-\t\tconst driver = this.driver;\n \t\tconst resultsLoadingSelector = By.css( '.domain-suggestion.is-placeholder' );\n-\t\tdriver.wait( function() {\n-\t\t\treturn driverHelper.isElementPresent( driver, resultsLoadingSelector ).then( function( present ) {\n-\t\t\t\treturn !present;\n-\t\t\t} );\n-\t\t}, this.explicitWaitMS * 2, 'The domain results loading element was still present when it should have disappeared by now.' );\n+\n+\t\tdriverHelper.waitTillNotPresent( this.driver, resultsLoadingSelector );","path":"lib/components/find-a-domain-component.js","position":18,"original_position":18,"commit_id":"afb934e528476ee1b4a0c21ba30df2582ad90686","original_commit_id":"afb934e528476ee1b4a0c21ba30df2582ad90686","user":{"login":"alisterscott","id":128826,"avatar_url":"https://avatars2.githubusercontent.com/u/128826?v=4","gravatar_id":"","url":"https://api.github.com/users/alisterscott","html_url":"https://github.com/alisterscott","followers_url":"https://api.github.com/users/alisterscott/followers","following_url":"https://api.github.com/users/alisterscott/following{/other_user}","gists_url":"https://api.github.com/users/alisterscott/gists{/gist_id}","starred_url":"https://api.github.com/users/alisterscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisterscott/subscriptions","organizations_url":"https://api.github.com/users/alisterscott/orgs","repos_url":"https://api.github.com/users/alisterscott/repos","events_url":"https://api.github.com/users/alisterscott/events{/privacy}","received_events_url":"https://api.github.com/users/alisterscott/received_events","type":"User","site_admin":false},"body":"This looks like it halved the waiting time","created_at":"2018-03-23T07:44:30Z","updated_at":"2018-03-23T07:54:01Z","html_url":"https://github.com/Automattic/wp-e2e-tests/pull/1067#discussion_r176657832","pull_request_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/comments/176657832"},"html":{"href":"https://github.com/Automattic/wp-e2e-tests/pull/1067#discussion_r176657832"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067","id":176742662,"html_url":"https://github.com/Automattic/wp-e2e-tests/pull/1067","diff_url":"https://github.com/Automattic/wp-e2e-tests/pull/1067.diff","patch_url":"https://github.com/Automattic/wp-e2e-tests/pull/1067.patch","issue_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/1067","number":1067,"state":"open","locked":false,"title":"Try to use prettier for code formatting","user":{"login":"brbrr","id":5654161,"avatar_url":"https://avatars2.githubusercontent.com/u/5654161?v=4","gravatar_id":"","url":"https://api.github.com/users/brbrr","html_url":"https://github.com/brbrr","followers_url":"https://api.github.com/users/brbrr/followers","following_url":"https://api.github.com/users/brbrr/following{/other_user}","gists_url":"https://api.github.com/users/brbrr/gists{/gist_id}","starred_url":"https://api.github.com/users/brbrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brbrr/subscriptions","organizations_url":"https://api.github.com/users/brbrr/orgs","repos_url":"https://api.github.com/users/brbrr/repos","events_url":"https://api.github.com/users/brbrr/events{/privacy}","received_events_url":"https://api.github.com/users/brbrr/received_events","type":"User","site_admin":false},"body":"WIP\r\n\r\nThis is a HUGE PR, so it would be great to have few reviewers once it ready\r\n\r\nThings were changed:\r\n- add `prettier` package\r\n- refactored all the code which was touched by prettier\r\n- using arrow functions when possible\r\n- get rid of `let self = this` & `let driver = this.driver` \r\n- factor-out some repetitive chunks of code\r\n\r\nThings need to be done:\r\n- add prettier pre-commit hook\r\n- fix all the tests (I definitely broke something) ","created_at":"2018-03-22T11:01:30Z","updated_at":"2018-03-23T07:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"brbrr","id":5654161,"avatar_url":"https://avatars2.githubusercontent.com/u/5654161?v=4","gravatar_id":"","url":"https://api.github.com/users/brbrr","html_url":"https://github.com/brbrr","followers_url":"https://api.github.com/users/brbrr/followers","following_url":"https://api.github.com/users/brbrr/following{/other_user}","gists_url":"https://api.github.com/users/brbrr/gists{/gist_id}","starred_url":"https://api.github.com/users/brbrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brbrr/subscriptions","organizations_url":"https://api.github.com/users/brbrr/orgs","repos_url":"https://api.github.com/users/brbrr/repos","events_url":"https://api.github.com/users/brbrr/events{/privacy}","received_events_url":"https://api.github.com/users/brbrr/received_events","type":"User","site_admin":false},"assignees":[{"login":"brbrr","id":5654161,"avatar_url":"https://avatars2.githubusercontent.com/u/5654161?v=4","gravatar_id":"","url":"https://api.github.com/users/brbrr","html_url":"https://github.com/brbrr","followers_url":"https://api.github.com/users/brbrr/followers","following_url":"https://api.github.com/users/brbrr/following{/other_user}","gists_url":"https://api.github.com/users/brbrr/gists{/gist_id}","starred_url":"https://api.github.com/users/brbrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brbrr/subscriptions","organizations_url":"https://api.github.com/users/brbrr/orgs","repos_url":"https://api.github.com/users/brbrr/repos","events_url":"https://api.github.com/users/brbrr/events{/privacy}","received_events_url":"https://api.github.com/users/brbrr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737067605,"url":"https://api.github.com/repos/Automattic/wp-e2e-tests/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/1067/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/statuses/afb934e528476ee1b4a0c21ba30df2582ad90686","head":{"label":"Automattic:try/use-prettier","ref":"try/use-prettier","sha":"afb934e528476ee1b4a0c21ba30df2582ad90686","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":57936731,"name":"wp-e2e-tests","full_name":"Automattic/wp-e2e-tests","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-e2e-tests","description":"Automated end-to-end tests for WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-e2e-tests","forks_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/forks","keys_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/events","assignees_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/merges","archive_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/deployments","created_at":"2016-05-03T02:49:24Z","updated_at":"2018-03-23T06:53:23Z","pushed_at":"2018-03-23T07:27:43Z","git_url":"git://github.com/Automattic/wp-e2e-tests.git","ssh_url":"git@github.com:Automattic/wp-e2e-tests.git","clone_url":"https://github.com/Automattic/wp-e2e-tests.git","svn_url":"https://github.com/Automattic/wp-e2e-tests","homepage":"https://github.com/Automattic/wp-calypso","size":4479,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":16,"open_issues":59,"watchers":96,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"1a7ba5c63775c1b7b4d50fd9520a14e628477181","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":57936731,"name":"wp-e2e-tests","full_name":"Automattic/wp-e2e-tests","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-e2e-tests","description":"Automated end-to-end tests for WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-e2e-tests","forks_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/forks","keys_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/events","assignees_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/merges","archive_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-e2e-tests/deployments","created_at":"2016-05-03T02:49:24Z","updated_at":"2018-03-23T06:53:23Z","pushed_at":"2018-03-23T07:27:43Z","git_url":"git://github.com/Automattic/wp-e2e-tests.git","ssh_url":"git@github.com:Automattic/wp-e2e-tests.git","clone_url":"https://github.com/Automattic/wp-e2e-tests.git","svn_url":"https://github.com/Automattic/wp-e2e-tests","homepage":"https://github.com/Automattic/wp-calypso","size":4479,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":16,"open_issues":59,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067"},"html":{"href":"https://github.com/Automattic/wp-e2e-tests/pull/1067"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/1067"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/issues/1067/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/pulls/1067/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-e2e-tests/statuses/afb934e528476ee1b4a0c21ba30df2582ad90686"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alisterscott"}}