{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/184899131","pull_request_review_id":116182369,"id":184899131,"diff_hunk":"@@ -1649,10 +1642,10 @@ int speed_main(int argc, char **argv)\n             dsa_doit[i] = 1;\n #endif\n #ifndef OPENSSL_NO_EC\n-        for (loop = 0; loop < OSSL_NELEM(ecdsa_choices); loop++)\n-            ecdsa_doit[ecdsa_choices[loop].retval] = 1;","path":"apps/speed.c","position":352,"original_position":352,"commit_id":"9983953f4c790043a827ff28b7558614d7ee74f1","original_commit_id":"9983953f4c790043a827ff28b7558614d7ee74f1","user":{"login":"FdaSilvaYY","id":15791524,"avatar_url":"https://avatars1.githubusercontent.com/u/15791524?v=4","gravatar_id":"","url":"https://api.github.com/users/FdaSilvaYY","html_url":"https://github.com/FdaSilvaYY","followers_url":"https://api.github.com/users/FdaSilvaYY/followers","following_url":"https://api.github.com/users/FdaSilvaYY/following{/other_user}","gists_url":"https://api.github.com/users/FdaSilvaYY/gists{/gist_id}","starred_url":"https://api.github.com/users/FdaSilvaYY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FdaSilvaYY/subscriptions","organizations_url":"https://api.github.com/users/FdaSilvaYY/orgs","repos_url":"https://api.github.com/users/FdaSilvaYY/repos","events_url":"https://api.github.com/users/FdaSilvaYY/events{/privacy}","received_events_url":"https://api.github.com/users/FdaSilvaYY/received_events","type":"User","site_admin":false},"body":"hopefully, these two arrays have the same size.","created_at":"2018-04-29T23:35:40Z","updated_at":"2018-04-29T23:37:27Z","html_url":"https://github.com/openssl/openssl/pull/6133#discussion_r184899131","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6133","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/184899131"},"html":{"href":"https://github.com/openssl/openssl/pull/6133#discussion_r184899131"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6133"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6133","id":184860717,"html_url":"https://github.com/openssl/openssl/pull/6133","diff_url":"https://github.com/openssl/openssl/pull/6133.diff","patch_url":"https://github.com/openssl/openssl/pull/6133.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6133","number":6133,"state":"open","locked":false,"title":"app/speed: fix weird EC arrays uses","user":{"login":"FdaSilvaYY","id":15791524,"avatar_url":"https://avatars1.githubusercontent.com/u/15791524?v=4","gravatar_id":"","url":"https://api.github.com/users/FdaSilvaYY","html_url":"https://github.com/FdaSilvaYY","followers_url":"https://api.github.com/users/FdaSilvaYY/followers","following_url":"https://api.github.com/users/FdaSilvaYY/following{/other_user}","gists_url":"https://api.github.com/users/FdaSilvaYY/gists{/gist_id}","starred_url":"https://api.github.com/users/FdaSilvaYY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FdaSilvaYY/subscriptions","organizations_url":"https://api.github.com/users/FdaSilvaYY/orgs","repos_url":"https://api.github.com/users/FdaSilvaYY/repos","events_url":"https://api.github.com/users/FdaSilvaYY/events{/privacy}","received_events_url":"https://api.github.com/users/FdaSilvaYY/received_events","type":"User","site_admin":false},"body":"because there is actually 18 curves defined, but only 16 are plugged for ecdsa test\r\nDeduce directly array size using OSSL_NELEM and so remove various magic numbers.\r\nRequire some declarations moving.\r\nImplement OPT_PAIR list search without a null-ending element.\r\n\r\nIMHO, this PR deserves a backport to 1.1.0 \r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [X] documentation is added or updated\r\n- [ ] tests are added or updated\r\n","created_at":"2018-04-29T23:20:32Z","updated_at":"2018-04-29T23:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf747ea8b87b0f1f6f609ab0686ef395ce49eb98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6133/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6133/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6133/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/9983953f4c790043a827ff28b7558614d7ee74f1","head":{"label":"FdaSilvaYY:app/speed/fix-ec-num-issue","ref":"app/speed/fix-ec-num-issue","sha":"9983953f4c790043a827ff28b7558614d7ee74f1","user":{"login":"FdaSilvaYY","id":15791524,"avatar_url":"https://avatars1.githubusercontent.com/u/15791524?v=4","gravatar_id":"","url":"https://api.github.com/users/FdaSilvaYY","html_url":"https://github.com/FdaSilvaYY","followers_url":"https://api.github.com/users/FdaSilvaYY/followers","following_url":"https://api.github.com/users/FdaSilvaYY/following{/other_user}","gists_url":"https://api.github.com/users/FdaSilvaYY/gists{/gist_id}","starred_url":"https://api.github.com/users/FdaSilvaYY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FdaSilvaYY/subscriptions","organizations_url":"https://api.github.com/users/FdaSilvaYY/orgs","repos_url":"https://api.github.com/users/FdaSilvaYY/repos","events_url":"https://api.github.com/users/FdaSilvaYY/events{/privacy}","received_events_url":"https://api.github.com/users/FdaSilvaYY/received_events","type":"User","site_admin":false},"repo":{"id":50681795,"name":"openssl","full_name":"FdaSilvaYY/openssl","owner":{"login":"FdaSilvaYY","id":15791524,"avatar_url":"https://avatars1.githubusercontent.com/u/15791524?v=4","gravatar_id":"","url":"https://api.github.com/users/FdaSilvaYY","html_url":"https://github.com/FdaSilvaYY","followers_url":"https://api.github.com/users/FdaSilvaYY/followers","following_url":"https://api.github.com/users/FdaSilvaYY/following{/other_user}","gists_url":"https://api.github.com/users/FdaSilvaYY/gists{/gist_id}","starred_url":"https://api.github.com/users/FdaSilvaYY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FdaSilvaYY/subscriptions","organizations_url":"https://api.github.com/users/FdaSilvaYY/orgs","repos_url":"https://api.github.com/users/FdaSilvaYY/repos","events_url":"https://api.github.com/users/FdaSilvaYY/events{/privacy}","received_events_url":"https://api.github.com/users/FdaSilvaYY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FdaSilvaYY/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/FdaSilvaYY/openssl","forks_url":"https://api.github.com/repos/FdaSilvaYY/openssl/forks","keys_url":"https://api.github.com/repos/FdaSilvaYY/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FdaSilvaYY/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FdaSilvaYY/openssl/teams","hooks_url":"https://api.github.com/repos/FdaSilvaYY/openssl/hooks","issue_events_url":"https://api.github.com/repos/FdaSilvaYY/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/FdaSilvaYY/openssl/events","assignees_url":"https://api.github.com/repos/FdaSilvaYY/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/FdaSilvaYY/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/FdaSilvaYY/openssl/tags","blobs_url":"https://api.github.com/repos/FdaSilvaYY/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FdaSilvaYY/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FdaSilvaYY/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/FdaSilvaYY/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FdaSilvaYY/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/FdaSilvaYY/openssl/languages","stargazers_url":"https://api.github.com/repos/FdaSilvaYY/openssl/stargazers","contributors_url":"https://api.github.com/repos/FdaSilvaYY/openssl/contributors","subscribers_url":"https://api.github.com/repos/FdaSilvaYY/openssl/subscribers","subscription_url":"https://api.github.com/repos/FdaSilvaYY/openssl/subscription","commits_url":"https://api.github.com/repos/FdaSilvaYY/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/FdaSilvaYY/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/FdaSilvaYY/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/FdaSilvaYY/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/FdaSilvaYY/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/FdaSilvaYY/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FdaSilvaYY/openssl/merges","archive_url":"https://api.github.com/repos/FdaSilvaYY/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FdaSilvaYY/openssl/downloads","issues_url":"https://api.github.com/repos/FdaSilvaYY/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/FdaSilvaYY/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/FdaSilvaYY/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/FdaSilvaYY/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FdaSilvaYY/openssl/labels{/name}","releases_url":"https://api.github.com/repos/FdaSilvaYY/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/FdaSilvaYY/openssl/deployments","created_at":"2016-01-29T18:20:16Z","updated_at":"2018-04-28T20:34:15Z","pushed_at":"2018-04-29T23:20:32Z","git_url":"git://github.com/FdaSilvaYY/openssl.git","ssh_url":"git@github.com:FdaSilvaYY/openssl.git","clone_url":"https://github.com/FdaSilvaYY/openssl.git","svn_url":"https://github.com/FdaSilvaYY/openssl","homepage":"https://www.openssl.org","size":137418,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"06444da464c038d7869908aaa26eaa728ae3a032","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-04-29T19:40:04Z","pushed_at":"2018-04-29T23:20:34Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":146731,"stargazers_count":6954,"watchers_count":6954,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3403,"mirror_url":null,"archived":false,"open_issues_count":368,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3403,"open_issues":368,"watchers":6954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6133"},"html":{"href":"https://github.com/openssl/openssl/pull/6133"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6133"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6133/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6133/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6133/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/9983953f4c790043a827ff28b7558614d7ee74f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FdaSilvaYY"}}