{"action":"created","comment":{"url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/comments/227244054","pull_request_review_id":167238045,"id":227244054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzI0NDA1NA==","diff_hunk":"@@ -0,0 +1,25 @@\n+# Copyright (c) 2017, Frappe and Contributors\r\n+# License: GNU General Public License v3. See license.txt\r\n+\r\n+from __future__ import unicode_literals\r\n+import frappe\r\n+\r\n+def execute():\r\n+\tfrappe.reload_doc('stock', 'doctype', 'delivery_trip')\r\n+\r\n+\tfor trip in frappe.get_all(\"Delivery Trip\"):\r\n+\t\ttrip_doc = frappe.get_doc(\"Delivery Trip\", trip.name)\r\n+\r\n+\t\tstatus_map = [\"Draft\", \"Scheduled\", \"Cancelled\"]\r","path":"erpnext/patches/v11_0/update_delivery_trip_status.py","position":13,"original_position":13,"commit_id":"2bf1a72a086e18472398c837c1266c51b5255128","original_commit_id":"2bf1a72a086e18472398c837c1266c51b5255128","user":{"login":"vjFaLk","id":6697133,"node_id":"MDQ6VXNlcjY2OTcxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/6697133?v=4","gravatar_id":"","url":"https://api.github.com/users/vjFaLk","html_url":"https://github.com/vjFaLk","followers_url":"https://api.github.com/users/vjFaLk/followers","following_url":"https://api.github.com/users/vjFaLk/following{/other_user}","gists_url":"https://api.github.com/users/vjFaLk/gists{/gist_id}","starred_url":"https://api.github.com/users/vjFaLk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjFaLk/subscriptions","organizations_url":"https://api.github.com/users/vjFaLk/orgs","repos_url":"https://api.github.com/users/vjFaLk/repos","events_url":"https://api.github.com/users/vjFaLk/events{/privacy}","received_events_url":"https://api.github.com/users/vjFaLk/received_events","type":"User","site_admin":false},"body":"Dunno, docstatus is a confusing thing as it is, code around it should at least be more clear","created_at":"2018-10-23T06:42:40Z","updated_at":"2018-10-23T06:42:40Z","html_url":"https://github.com/DigiThinkIT/erpnext/pull/91#discussion_r227244054","pull_request_url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/comments/227244054"},"html":{"href":"https://github.com/DigiThinkIT/erpnext/pull/91#discussion_r227244054"},"pull_request":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91"}},"in_reply_to_id":227222996},"pull_request":{"url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91","id":224752763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzUyNzYz","html_url":"https://github.com/DigiThinkIT/erpnext/pull/91","diff_url":"https://github.com/DigiThinkIT/erpnext/pull/91.diff","patch_url":"https://github.com/DigiThinkIT/erpnext/pull/91.patch","issue_url":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/91","number":91,"state":"open","locked":false,"title":"Fix allow on submit for status","user":{"login":"Alchez","id":13396535,"node_id":"MDQ6VXNlcjEzMzk2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/13396535?v=4","gravatar_id":"","url":"https://api.github.com/users/Alchez","html_url":"https://github.com/Alchez","followers_url":"https://api.github.com/users/Alchez/followers","following_url":"https://api.github.com/users/Alchez/following{/other_user}","gists_url":"https://api.github.com/users/Alchez/gists{/gist_id}","starred_url":"https://api.github.com/users/Alchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alchez/subscriptions","organizations_url":"https://api.github.com/users/Alchez/orgs","repos_url":"https://api.github.com/users/Alchez/repos","events_url":"https://api.github.com/users/Alchez/events{/privacy}","received_events_url":"https://api.github.com/users/Alchez/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-22T17:27:45Z","updated_at":"2018-10-23T06:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56d64fb79bfe84d6df2f9613e906448b96358812","assignee":{"login":"neilLasrado","id":8401344,"node_id":"MDQ6VXNlcjg0MDEzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8401344?v=4","gravatar_id":"","url":"https://api.github.com/users/neilLasrado","html_url":"https://github.com/neilLasrado","followers_url":"https://api.github.com/users/neilLasrado/followers","following_url":"https://api.github.com/users/neilLasrado/following{/other_user}","gists_url":"https://api.github.com/users/neilLasrado/gists{/gist_id}","starred_url":"https://api.github.com/users/neilLasrado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilLasrado/subscriptions","organizations_url":"https://api.github.com/users/neilLasrado/orgs","repos_url":"https://api.github.com/users/neilLasrado/repos","events_url":"https://api.github.com/users/neilLasrado/events{/privacy}","received_events_url":"https://api.github.com/users/neilLasrado/received_events","type":"User","site_admin":false},"assignees":[{"login":"neilLasrado","id":8401344,"node_id":"MDQ6VXNlcjg0MDEzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8401344?v=4","gravatar_id":"","url":"https://api.github.com/users/neilLasrado","html_url":"https://github.com/neilLasrado","followers_url":"https://api.github.com/users/neilLasrado/followers","following_url":"https://api.github.com/users/neilLasrado/following{/other_user}","gists_url":"https://api.github.com/users/neilLasrado/gists{/gist_id}","starred_url":"https://api.github.com/users/neilLasrado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilLasrado/subscriptions","organizations_url":"https://api.github.com/users/neilLasrado/orgs","repos_url":"https://api.github.com/users/neilLasrado/repos","events_url":"https://api.github.com/users/neilLasrado/events{/privacy}","received_events_url":"https://api.github.com/users/neilLasrado/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"neilLasrado","id":8401344,"node_id":"MDQ6VXNlcjg0MDEzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8401344?v=4","gravatar_id":"","url":"https://api.github.com/users/neilLasrado","html_url":"https://github.com/neilLasrado","followers_url":"https://api.github.com/users/neilLasrado/followers","following_url":"https://api.github.com/users/neilLasrado/following{/other_user}","gists_url":"https://api.github.com/users/neilLasrado/gists{/gist_id}","starred_url":"https://api.github.com/users/neilLasrado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilLasrado/subscriptions","organizations_url":"https://api.github.com/users/neilLasrado/orgs","repos_url":"https://api.github.com/users/neilLasrado/repos","events_url":"https://api.github.com/users/neilLasrado/events{/privacy}","received_events_url":"https://api.github.com/users/neilLasrado/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91/commits","review_comments_url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91/comments","review_comment_url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/91/comments","statuses_url":"https://api.github.com/repos/DigiThinkIT/erpnext/statuses/2bf1a72a086e18472398c837c1266c51b5255128","head":{"label":"Alchez:enhance-trip-status","ref":"enhance-trip-status","sha":"2bf1a72a086e18472398c837c1266c51b5255128","user":{"login":"Alchez","id":13396535,"node_id":"MDQ6VXNlcjEzMzk2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/13396535?v=4","gravatar_id":"","url":"https://api.github.com/users/Alchez","html_url":"https://github.com/Alchez","followers_url":"https://api.github.com/users/Alchez/followers","following_url":"https://api.github.com/users/Alchez/following{/other_user}","gists_url":"https://api.github.com/users/Alchez/gists{/gist_id}","starred_url":"https://api.github.com/users/Alchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alchez/subscriptions","organizations_url":"https://api.github.com/users/Alchez/orgs","repos_url":"https://api.github.com/users/Alchez/repos","events_url":"https://api.github.com/users/Alchez/events{/privacy}","received_events_url":"https://api.github.com/users/Alchez/received_events","type":"User","site_admin":false},"repo":{"id":85191578,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE5MTU3OA==","name":"erpnext","full_name":"Alchez/erpnext","private":false,"owner":{"login":"Alchez","id":13396535,"node_id":"MDQ6VXNlcjEzMzk2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/13396535?v=4","gravatar_id":"","url":"https://api.github.com/users/Alchez","html_url":"https://github.com/Alchez","followers_url":"https://api.github.com/users/Alchez/followers","following_url":"https://api.github.com/users/Alchez/following{/other_user}","gists_url":"https://api.github.com/users/Alchez/gists{/gist_id}","starred_url":"https://api.github.com/users/Alchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alchez/subscriptions","organizations_url":"https://api.github.com/users/Alchez/orgs","repos_url":"https://api.github.com/users/Alchez/repos","events_url":"https://api.github.com/users/Alchez/events{/privacy}","received_events_url":"https://api.github.com/users/Alchez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Alchez/erpnext","description":"ERP made Simple","fork":true,"url":"https://api.github.com/repos/Alchez/erpnext","forks_url":"https://api.github.com/repos/Alchez/erpnext/forks","keys_url":"https://api.github.com/repos/Alchez/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alchez/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alchez/erpnext/teams","hooks_url":"https://api.github.com/repos/Alchez/erpnext/hooks","issue_events_url":"https://api.github.com/repos/Alchez/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/Alchez/erpnext/events","assignees_url":"https://api.github.com/repos/Alchez/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/Alchez/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/Alchez/erpnext/tags","blobs_url":"https://api.github.com/repos/Alchez/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alchez/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alchez/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alchez/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alchez/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/Alchez/erpnext/languages","stargazers_url":"https://api.github.com/repos/Alchez/erpnext/stargazers","contributors_url":"https://api.github.com/repos/Alchez/erpnext/contributors","subscribers_url":"https://api.github.com/repos/Alchez/erpnext/subscribers","subscription_url":"https://api.github.com/repos/Alchez/erpnext/subscription","commits_url":"https://api.github.com/repos/Alchez/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alchez/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alchez/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alchez/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alchez/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/Alchez/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alchez/erpnext/merges","archive_url":"https://api.github.com/repos/Alchez/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alchez/erpnext/downloads","issues_url":"https://api.github.com/repos/Alchez/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/Alchez/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/Alchez/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/Alchez/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alchez/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/Alchez/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/Alchez/erpnext/deployments","created_at":"2017-03-16T12:07:37Z","updated_at":"2017-03-16T12:07:48Z","pushed_at":"2018-10-22T17:37:51Z","git_url":"git://github.com/Alchez/erpnext.git","ssh_url":"git@github.com:Alchez/erpnext.git","clone_url":"https://github.com/Alchez/erpnext.git","svn_url":"https://github.com/Alchez/erpnext","homepage":"http://erpnext.com","size":646819,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"DigiThinkIT:bloomstack-staging","ref":"bloomstack-staging","sha":"834f905d95c5644becf2304d4d4e273d9da094e0","user":{"login":"DigiThinkIT","id":1655928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/1655928?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiThinkIT","html_url":"https://github.com/DigiThinkIT","followers_url":"https://api.github.com/users/DigiThinkIT/followers","following_url":"https://api.github.com/users/DigiThinkIT/following{/other_user}","gists_url":"https://api.github.com/users/DigiThinkIT/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiThinkIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiThinkIT/subscriptions","organizations_url":"https://api.github.com/users/DigiThinkIT/orgs","repos_url":"https://api.github.com/users/DigiThinkIT/repos","events_url":"https://api.github.com/users/DigiThinkIT/events{/privacy}","received_events_url":"https://api.github.com/users/DigiThinkIT/received_events","type":"Organization","site_admin":false},"repo":{"id":69038911,"node_id":"MDEwOlJlcG9zaXRvcnk2OTAzODkxMQ==","name":"erpnext","full_name":"DigiThinkIT/erpnext","private":false,"owner":{"login":"DigiThinkIT","id":1655928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTU5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/1655928?v=4","gravatar_id":"","url":"https://api.github.com/users/DigiThinkIT","html_url":"https://github.com/DigiThinkIT","followers_url":"https://api.github.com/users/DigiThinkIT/followers","following_url":"https://api.github.com/users/DigiThinkIT/following{/other_user}","gists_url":"https://api.github.com/users/DigiThinkIT/gists{/gist_id}","starred_url":"https://api.github.com/users/DigiThinkIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigiThinkIT/subscriptions","organizations_url":"https://api.github.com/users/DigiThinkIT/orgs","repos_url":"https://api.github.com/users/DigiThinkIT/repos","events_url":"https://api.github.com/users/DigiThinkIT/events{/privacy}","received_events_url":"https://api.github.com/users/DigiThinkIT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DigiThinkIT/erpnext","description":"Open Source ERP built for the Web. Uses Python, MariaDB.","fork":true,"url":"https://api.github.com/repos/DigiThinkIT/erpnext","forks_url":"https://api.github.com/repos/DigiThinkIT/erpnext/forks","keys_url":"https://api.github.com/repos/DigiThinkIT/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigiThinkIT/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigiThinkIT/erpnext/teams","hooks_url":"https://api.github.com/repos/DigiThinkIT/erpnext/hooks","issue_events_url":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/DigiThinkIT/erpnext/events","assignees_url":"https://api.github.com/repos/DigiThinkIT/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/DigiThinkIT/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/DigiThinkIT/erpnext/tags","blobs_url":"https://api.github.com/repos/DigiThinkIT/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigiThinkIT/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigiThinkIT/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigiThinkIT/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigiThinkIT/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/DigiThinkIT/erpnext/languages","stargazers_url":"https://api.github.com/repos/DigiThinkIT/erpnext/stargazers","contributors_url":"https://api.github.com/repos/DigiThinkIT/erpnext/contributors","subscribers_url":"https://api.github.com/repos/DigiThinkIT/erpnext/subscribers","subscription_url":"https://api.github.com/repos/DigiThinkIT/erpnext/subscription","commits_url":"https://api.github.com/repos/DigiThinkIT/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigiThinkIT/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigiThinkIT/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigiThinkIT/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/DigiThinkIT/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigiThinkIT/erpnext/merges","archive_url":"https://api.github.com/repos/DigiThinkIT/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigiThinkIT/erpnext/downloads","issues_url":"https://api.github.com/repos/DigiThinkIT/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/DigiThinkIT/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/DigiThinkIT/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigiThinkIT/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/DigiThinkIT/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/DigiThinkIT/erpnext/deployments","created_at":"2016-09-23T15:47:08Z","updated_at":"2018-04-25T09:22:17Z","pushed_at":"2018-10-22T17:37:53Z","git_url":"git://github.com/DigiThinkIT/erpnext.git","ssh_url":"git@github.com:DigiThinkIT/erpnext.git","clone_url":"https://github.com/DigiThinkIT/erpnext.git","svn_url":"https://github.com/DigiThinkIT/erpnext","homepage":"http://erpnext.com","size":652120,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91"},"html":{"href":"https://github.com/DigiThinkIT/erpnext/pull/91"},"issue":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/91"},"comments":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/DigiThinkIT/erpnext/statuses/2bf1a72a086e18472398c837c1266c51b5255128"}},"author_association":"NONE"}}
{"actor":{"display_login":"vjFaLk"}}