{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/192604020","pull_request_review_id":125409709,"id":192604020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjYwNDAyMA==","diff_hunk":"@@ -132,6 +134,9 @@ def rst_xline(width, char=\"=\"):\n     return char * width\n \n \n+test_list = partial(is_sequence, include_strings=False)","path":"docs/bin/plugin_formatter.py","position":20,"original_position":20,"commit_id":"83de7324697ddb3598b96a3217d15c4939ce8c12","original_commit_id":"83de7324697ddb3598b96a3217d15c4939ce8c12","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"body":"So while it's been said that this would only be python-centric code, as I suspected it is now trickling into the Jinja filter. Sequence, list, strings, the mess is even messier now :-/ Both in Ansible python and Jinja.","created_at":"2018-06-03T22:04:55Z","updated_at":"2018-06-03T22:04:55Z","html_url":"https://github.com/ansible/ansible/pull/40212#discussion_r192604020","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/40212","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/192604020"},"html":{"href":"https://github.com/ansible/ansible/pull/40212#discussion_r192604020"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40212"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/40212","id":188321147,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MzIxMTQ3","html_url":"https://github.com/ansible/ansible/pull/40212","diff_url":"https://github.com/ansible/ansible/pull/40212.diff","patch_url":"https://github.com/ansible/ansible/pull/40212.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/40212","number":40212,"state":"open","locked":false,"title":"Documentation: show non-string non-iterable defaults for choices","user":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nIf there is a list of choices for an option whose type is not string, the default is currently not marked.\r\n\r\nExample: https://docs.ansible.com/ansible/devel/modules/acme_certificate_module.html, search for `acme_version`; the default value is `1` (integer), but it is not marked.\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n - Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\ndocs/templates/plugin.rst.j2\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.6.0\r\n```\r\n\r\n##### ADDITIONAL INFORMATION\r\nKind of follow-up to #40050, which fixed the display of the choices in this case. Pinging @webknjaz @dagwieers because of this.\r\n","created_at":"2018-05-16T05:17:45Z","updated_at":"2018-06-03T22:04:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458d194f6ea921e487adcb515cbdae7f8adb095f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abadger","id":209242,"node_id":"MDQ6VXNlcjIwOTI0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/209242?v=4","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},{"login":"acozine","id":879121,"node_id":"MDQ6VXNlcjg3OTEyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/879121?v=4","gravatar_id":"","url":"https://api.github.com/users/acozine","html_url":"https://github.com/acozine","followers_url":"https://api.github.com/users/acozine/followers","following_url":"https://api.github.com/users/acozine/following{/other_user}","gists_url":"https://api.github.com/users/acozine/gists{/gist_id}","starred_url":"https://api.github.com/users/acozine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acozine/subscriptions","organizations_url":"https://api.github.com/users/acozine/orgs","repos_url":"https://api.github.com/users/acozine/repos","events_url":"https://api.github.com/users/acozine/events{/privacy}","received_events_url":"https://api.github.com/users/acozine/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":835286067,"node_id":"MDU6TGFiZWw4MzUyODYwNjc=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.6","name":"affects_2.6","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":849212023,"node_id":"MDU6TGFiZWw4NDkyMTIwMjM=","url":"https://api.github.com/repos/ansible/ansible/labels/docs","name":"docs","color":"0052cc","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/40212/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/40212/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/40212/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/83de7324697ddb3598b96a3217d15c4939ce8c12","head":{"label":"felixfontein:improve-docs","ref":"improve-docs","sha":"83de7324697ddb3598b96a3217d15c4939ce8c12","user":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"repo":{"id":51219776,"node_id":"MDEwOlJlcG9zaXRvcnk1MTIxOTc3Ng==","name":"ansible","full_name":"felixfontein/ansible","owner":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixfontein/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/felixfontein/ansible","forks_url":"https://api.github.com/repos/felixfontein/ansible/forks","keys_url":"https://api.github.com/repos/felixfontein/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixfontein/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixfontein/ansible/teams","hooks_url":"https://api.github.com/repos/felixfontein/ansible/hooks","issue_events_url":"https://api.github.com/repos/felixfontein/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/felixfontein/ansible/events","assignees_url":"https://api.github.com/repos/felixfontein/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/felixfontein/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/felixfontein/ansible/tags","blobs_url":"https://api.github.com/repos/felixfontein/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixfontein/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixfontein/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixfontein/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixfontein/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/felixfontein/ansible/languages","stargazers_url":"https://api.github.com/repos/felixfontein/ansible/stargazers","contributors_url":"https://api.github.com/repos/felixfontein/ansible/contributors","subscribers_url":"https://api.github.com/repos/felixfontein/ansible/subscribers","subscription_url":"https://api.github.com/repos/felixfontein/ansible/subscription","commits_url":"https://api.github.com/repos/felixfontein/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixfontein/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixfontein/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixfontein/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixfontein/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/felixfontein/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixfontein/ansible/merges","archive_url":"https://api.github.com/repos/felixfontein/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixfontein/ansible/downloads","issues_url":"https://api.github.com/repos/felixfontein/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/felixfontein/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/felixfontein/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/felixfontein/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixfontein/ansible/labels{/name}","releases_url":"https://api.github.com/repos/felixfontein/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/felixfontein/ansible/deployments","created_at":"2016-02-06T20:16:02Z","updated_at":"2018-06-03T19:10:30Z","pushed_at":"2018-06-03T19:10:25Z","git_url":"git://github.com/felixfontein/ansible.git","ssh_url":"git@github.com:felixfontein/ansible.git","clone_url":"https://github.com/felixfontein/ansible.git","svn_url":"https://github.com/felixfontein/ansible","homepage":"http://ansible.com/","size":112917,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"5228b939fe0ec30e67a475c62c17aadd96886ecc","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-06-03T21:19:53Z","pushed_at":"2018-06-03T22:00:31Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":123965,"stargazers_count":30562,"watchers_count":30562,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11503,"mirror_url":null,"archived":false,"open_issues_count":5077,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11503,"open_issues":5077,"watchers":30562,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40212"},"html":{"href":"https://github.com/ansible/ansible/pull/40212"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/40212"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/40212/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40212/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/40212/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/83de7324697ddb3598b96a3217d15c4939ce8c12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dagwieers"}}