{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments/188871731","pull_request_review_id":120932407,"id":188871731,"diff_hunk":"@@ -0,0 +1,43 @@\n+package jenkins.plugins.openstack.pipeline;\n+\n+import jenkins.model.Jenkins;\n+import jenkins.plugins.openstack.compute.*;\n+import org.jenkinsci.plugins.cloudstats.ProvisioningActivity;\n+import org.jenkinsci.plugins.workflow.steps.StepContext;\n+import org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution;\n+\n+import javax.annotation.Nonnull;\n+\n+/**\n+ * Pipeline Step Execution class to run OpenStack with declared @{@link SlaveOptions}\n+ *\n+ * @author drichtar@redhat.com\n+ */\n+public class OpenStackNodeStepExecution extends SynchronousNonBlockingStepExecution<JCloudsSlave> {\n+\n+    private final @Nonnull String cloudName;\n+    private final @Nonnull SlaveOptions slaveOptions;\n+    private TemporaryServer temporaryServer;\n+    private JCloudsSlave newSlave;","path":"src/main/java/jenkins/plugins/openstack/pipeline/OpenStackNodeStepExecution.java","position":21,"original_position":21,"commit_id":"5489638c314960410ea7fe6503420c4f3270f7f7","original_commit_id":"5489638c314960410ea7fe6503420c4f3270f7f7","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars0.githubusercontent.com/u/206841?v=4","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"`newSlave` and `temporaryServer` can be made local variables.","created_at":"2018-05-17T08:11:09Z","updated_at":"2018-05-17T08:15:45Z","html_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203#discussion_r188871731","pull_request_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments/188871731"},"html":{"href":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203#discussion_r188871731"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203","id":188644703,"html_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203","diff_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203.diff","patch_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203.patch","issue_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/203","number":203,"state":"open","locked":false,"title":"JENKINS-47742 - Introduce declarative pipeline agent support","user":{"login":"drichtarik","id":19531958,"avatar_url":"https://avatars0.githubusercontent.com/u/19531958?v=4","gravatar_id":"","url":"https://api.github.com/users/drichtarik","html_url":"https://github.com/drichtarik","followers_url":"https://api.github.com/users/drichtarik/followers","following_url":"https://api.github.com/users/drichtarik/following{/other_user}","gists_url":"https://api.github.com/users/drichtarik/gists{/gist_id}","starred_url":"https://api.github.com/users/drichtarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichtarik/subscriptions","organizations_url":"https://api.github.com/users/drichtarik/orgs","repos_url":"https://api.github.com/users/drichtarik/repos","events_url":"https://api.github.com/users/drichtarik/events{/privacy}","received_events_url":"https://api.github.com/users/drichtarik/received_events","type":"User","site_admin":false},"body":"https://issues.jenkins-ci.org/browse/JENKINS-47742","created_at":"2018-05-17T07:24:07Z","updated_at":"2018-05-17T08:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33b959986cd4ce24f7b722740711108144514675","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/203/comments","statuses_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/5489638c314960410ea7fe6503420c4f3270f7f7","head":{"label":"drichtarik:JENKINS-47742","ref":"JENKINS-47742","sha":"5489638c314960410ea7fe6503420c4f3270f7f7","user":{"login":"drichtarik","id":19531958,"avatar_url":"https://avatars0.githubusercontent.com/u/19531958?v=4","gravatar_id":"","url":"https://api.github.com/users/drichtarik","html_url":"https://github.com/drichtarik","followers_url":"https://api.github.com/users/drichtarik/followers","following_url":"https://api.github.com/users/drichtarik/following{/other_user}","gists_url":"https://api.github.com/users/drichtarik/gists{/gist_id}","starred_url":"https://api.github.com/users/drichtarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichtarik/subscriptions","organizations_url":"https://api.github.com/users/drichtarik/orgs","repos_url":"https://api.github.com/users/drichtarik/repos","events_url":"https://api.github.com/users/drichtarik/events{/privacy}","received_events_url":"https://api.github.com/users/drichtarik/received_events","type":"User","site_admin":false},"repo":{"id":127147319,"name":"openstack-cloud-plugin","full_name":"drichtarik/openstack-cloud-plugin","owner":{"login":"drichtarik","id":19531958,"avatar_url":"https://avatars0.githubusercontent.com/u/19531958?v=4","gravatar_id":"","url":"https://api.github.com/users/drichtarik","html_url":"https://github.com/drichtarik","followers_url":"https://api.github.com/users/drichtarik/followers","following_url":"https://api.github.com/users/drichtarik/following{/other_user}","gists_url":"https://api.github.com/users/drichtarik/gists{/gist_id}","starred_url":"https://api.github.com/users/drichtarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichtarik/subscriptions","organizations_url":"https://api.github.com/users/drichtarik/orgs","repos_url":"https://api.github.com/users/drichtarik/repos","events_url":"https://api.github.com/users/drichtarik/events{/privacy}","received_events_url":"https://api.github.com/users/drichtarik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drichtarik/openstack-cloud-plugin","description":"Provision nodes from OpenStack on demand","fork":true,"url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin","forks_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/forks","keys_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/teams","hooks_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/hooks","issue_events_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/events","assignees_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/tags","blobs_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/languages","stargazers_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/stargazers","contributors_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/contributors","subscribers_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/subscribers","subscription_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/subscription","commits_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/merges","archive_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/downloads","issues_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/labels{/name}","releases_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/drichtarik/openstack-cloud-plugin/deployments","created_at":"2018-03-28T13:49:00Z","updated_at":"2018-03-28T13:49:03Z","pushed_at":"2018-05-17T08:00:42Z","git_url":"git://github.com/drichtarik/openstack-cloud-plugin.git","ssh_url":"git@github.com:drichtarik/openstack-cloud-plugin.git","clone_url":"https://github.com/drichtarik/openstack-cloud-plugin.git","svn_url":"https://github.com/drichtarik/openstack-cloud-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Openstack+Cloud+Plugin","size":1712,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"c7f058d3ad62a85bedb655269b3e94c6b5190887","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":30764186,"name":"openstack-cloud-plugin","full_name":"jenkinsci/openstack-cloud-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/openstack-cloud-plugin","description":"Provision nodes from OpenStack on demand","fork":false,"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin","forks_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/deployments","created_at":"2015-02-13T16:13:29Z","updated_at":"2018-04-25T12:48:36Z","pushed_at":"2018-05-17T08:00:44Z","git_url":"git://github.com/jenkinsci/openstack-cloud-plugin.git","ssh_url":"git@github.com:jenkinsci/openstack-cloud-plugin.git","clone_url":"https://github.com/jenkinsci/openstack-cloud-plugin.git","svn_url":"https://github.com/jenkinsci/openstack-cloud-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Openstack+Cloud+Plugin","size":1633,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":48,"license":null,"forks":56,"open_issues":48,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203"},"html":{"href":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/203"},"issue":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/203"},"comments":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/5489638c314960410ea7fe6503420c4f3270f7f7"}},"author_association":"NONE"}}
{"actor":{"display_login":"olivergondza"}}