{"action":"created","comment":{"url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/comments/166148241","pull_request_review_id":94183275,"id":166148241,"diff_hunk":"@@ -369,7 +369,13 @@\n \n \t\t\t\tcase 'select_geshi' :\n \t\t\t\t\t$ele = new icms_form_elements_Select($title, $config[$i]->getVar('conf_name'), $config[$i]->getConfValueForOutput());\n-\t\t\t\t\t$dirlist = str_replace('.php', '', icms_core_Filesystem::getFileList(ICMS_LIBRARIES_PATH . '/geshi/geshi/', '', array('php')));\n+\t\t\t\t\t$reflector = new ReflectionClass(\"\\\\GeSHi\");","path":"htdocs/modules/system/admin/preferences.php","position":14,"original_position":14,"commit_id":"55500a50376acde5b08d8eb5dc38e545946acc36","original_commit_id":"8660a74f21e0aea1508d0c1fcec7e374f24f4ba0","user":{"login":"fiammybe","id":3736946,"avatar_url":"https://avatars0.githubusercontent.com/u/3736946?v=4","gravatar_id":"","url":"https://api.github.com/users/fiammybe","html_url":"https://github.com/fiammybe","followers_url":"https://api.github.com/users/fiammybe/followers","following_url":"https://api.github.com/users/fiammybe/following{/other_user}","gists_url":"https://api.github.com/users/fiammybe/gists{/gist_id}","starred_url":"https://api.github.com/users/fiammybe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiammybe/subscriptions","organizations_url":"https://api.github.com/users/fiammybe/orgs","repos_url":"https://api.github.com/users/fiammybe/repos","events_url":"https://api.github.com/users/fiammybe/events{/privacy}","received_events_url":"https://api.github.com/users/fiammybe/received_events","type":"User","site_admin":false},"body":"Really good idea to use reflection, I was having a similar issue with loading the Smarty config : in essence you don't know where the library will be put on the file system, composer makes that transparent. So you cannot assume that your fiels will be in a specific spot.","created_at":"2018-02-05T23:42:06Z","updated_at":"2018-02-05T23:42:06Z","html_url":"https://github.com/ImpressCMS/impresscms/pull/136#discussion_r166148241","pull_request_url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/comments/166148241"},"html":{"href":"https://github.com/ImpressCMS/impresscms/pull/136#discussion_r166148241"},"pull_request":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136","id":165822236,"html_url":"https://github.com/ImpressCMS/impresscms/pull/136","diff_url":"https://github.com/ImpressCMS/impresscms/pull/136.diff","patch_url":"https://github.com/ImpressCMS/impresscms/pull/136.patch","issue_url":"https://api.github.com/repos/ImpressCMS/impresscms/issues/136","number":136,"state":"open","locked":false,"title":"Move geshi to composer.json","user":{"login":"MekDrop","id":342641,"avatar_url":"https://avatars1.githubusercontent.com/u/342641?v=4","gravatar_id":"","url":"https://api.github.com/users/MekDrop","html_url":"https://github.com/MekDrop","followers_url":"https://api.github.com/users/MekDrop/followers","following_url":"https://api.github.com/users/MekDrop/following{/other_user}","gists_url":"https://api.github.com/users/MekDrop/gists{/gist_id}","starred_url":"https://api.github.com/users/MekDrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MekDrop/subscriptions","organizations_url":"https://api.github.com/users/MekDrop/orgs","repos_url":"https://api.github.com/users/MekDrop/repos","events_url":"https://api.github.com/users/MekDrop/events{/privacy}","received_events_url":"https://api.github.com/users/MekDrop/received_events","type":"User","site_admin":false},"body":"Moved GeSHi from libraries to composer.json","created_at":"2018-01-29T21:26:25Z","updated_at":"2018-02-05T23:42:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da71fbedf21f3c87e25e62de1b9c889f20f6b721","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skenow","id":2429107,"avatar_url":"https://avatars1.githubusercontent.com/u/2429107?v=4","gravatar_id":"","url":"https://api.github.com/users/skenow","html_url":"https://github.com/skenow","followers_url":"https://api.github.com/users/skenow/followers","following_url":"https://api.github.com/users/skenow/following{/other_user}","gists_url":"https://api.github.com/users/skenow/gists{/gist_id}","starred_url":"https://api.github.com/users/skenow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skenow/subscriptions","organizations_url":"https://api.github.com/users/skenow/orgs","repos_url":"https://api.github.com/users/skenow/repos","events_url":"https://api.github.com/users/skenow/events{/privacy}","received_events_url":"https://api.github.com/users/skenow/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/ImpressCMS/impresscms/milestones/3","html_url":"https://github.com/ImpressCMS/impresscms/milestone/3","labels_url":"https://api.github.com/repos/ImpressCMS/impresscms/milestones/3/labels","id":2159465,"number":3,"title":"2.0.0","description":"First release of 2.0.x, removing the legacy classes marked deprecated and focus on community features - comments, notifications, users, groups, permissions, messaging. \r\nContinued improvement of the core architecture, PDO, security, and leveraging other methods for managing dependencies and 3rd party libraries\r\nPHP 7.2 compatibility is a goal","creator":{"login":"skenow","id":2429107,"avatar_url":"https://avatars1.githubusercontent.com/u/2429107?v=4","gravatar_id":"","url":"https://api.github.com/users/skenow","html_url":"https://github.com/skenow","followers_url":"https://api.github.com/users/skenow/followers","following_url":"https://api.github.com/users/skenow/following{/other_user}","gists_url":"https://api.github.com/users/skenow/gists{/gist_id}","starred_url":"https://api.github.com/users/skenow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skenow/subscriptions","organizations_url":"https://api.github.com/users/skenow/orgs","repos_url":"https://api.github.com/users/skenow/repos","events_url":"https://api.github.com/users/skenow/events{/privacy}","received_events_url":"https://api.github.com/users/skenow/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":17,"state":"open","created_at":"2016-11-27T18:44:06Z","updated_at":"2018-02-05T20:03:27Z","due_on":"2018-01-11T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136/commits","review_comments_url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136/comments","review_comment_url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImpressCMS/impresscms/issues/136/comments","statuses_url":"https://api.github.com/repos/ImpressCMS/impresscms/statuses/55500a50376acde5b08d8eb5dc38e545946acc36","head":{"label":"MekDrop:Move-Geshi-To-Composer.json","ref":"Move-Geshi-To-Composer.json","sha":"55500a50376acde5b08d8eb5dc38e545946acc36","user":{"login":"MekDrop","id":342641,"avatar_url":"https://avatars1.githubusercontent.com/u/342641?v=4","gravatar_id":"","url":"https://api.github.com/users/MekDrop","html_url":"https://github.com/MekDrop","followers_url":"https://api.github.com/users/MekDrop/followers","following_url":"https://api.github.com/users/MekDrop/following{/other_user}","gists_url":"https://api.github.com/users/MekDrop/gists{/gist_id}","starred_url":"https://api.github.com/users/MekDrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MekDrop/subscriptions","organizations_url":"https://api.github.com/users/MekDrop/orgs","repos_url":"https://api.github.com/users/MekDrop/repos","events_url":"https://api.github.com/users/MekDrop/events{/privacy}","received_events_url":"https://api.github.com/users/MekDrop/received_events","type":"User","site_admin":false},"repo":{"id":119292502,"name":"impresscms","full_name":"MekDrop/impresscms","owner":{"login":"MekDrop","id":342641,"avatar_url":"https://avatars1.githubusercontent.com/u/342641?v=4","gravatar_id":"","url":"https://api.github.com/users/MekDrop","html_url":"https://github.com/MekDrop","followers_url":"https://api.github.com/users/MekDrop/followers","following_url":"https://api.github.com/users/MekDrop/following{/other_user}","gists_url":"https://api.github.com/users/MekDrop/gists{/gist_id}","starred_url":"https://api.github.com/users/MekDrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MekDrop/subscriptions","organizations_url":"https://api.github.com/users/MekDrop/orgs","repos_url":"https://api.github.com/users/MekDrop/repos","events_url":"https://api.github.com/users/MekDrop/events{/privacy}","received_events_url":"https://api.github.com/users/MekDrop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MekDrop/impresscms","description":"A community developed CMS in PHP - easily build and maintain a dynamic web site","fork":true,"url":"https://api.github.com/repos/MekDrop/impresscms","forks_url":"https://api.github.com/repos/MekDrop/impresscms/forks","keys_url":"https://api.github.com/repos/MekDrop/impresscms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MekDrop/impresscms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MekDrop/impresscms/teams","hooks_url":"https://api.github.com/repos/MekDrop/impresscms/hooks","issue_events_url":"https://api.github.com/repos/MekDrop/impresscms/issues/events{/number}","events_url":"https://api.github.com/repos/MekDrop/impresscms/events","assignees_url":"https://api.github.com/repos/MekDrop/impresscms/assignees{/user}","branches_url":"https://api.github.com/repos/MekDrop/impresscms/branches{/branch}","tags_url":"https://api.github.com/repos/MekDrop/impresscms/tags","blobs_url":"https://api.github.com/repos/MekDrop/impresscms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MekDrop/impresscms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MekDrop/impresscms/git/refs{/sha}","trees_url":"https://api.github.com/repos/MekDrop/impresscms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MekDrop/impresscms/statuses/{sha}","languages_url":"https://api.github.com/repos/MekDrop/impresscms/languages","stargazers_url":"https://api.github.com/repos/MekDrop/impresscms/stargazers","contributors_url":"https://api.github.com/repos/MekDrop/impresscms/contributors","subscribers_url":"https://api.github.com/repos/MekDrop/impresscms/subscribers","subscription_url":"https://api.github.com/repos/MekDrop/impresscms/subscription","commits_url":"https://api.github.com/repos/MekDrop/impresscms/commits{/sha}","git_commits_url":"https://api.github.com/repos/MekDrop/impresscms/git/commits{/sha}","comments_url":"https://api.github.com/repos/MekDrop/impresscms/comments{/number}","issue_comment_url":"https://api.github.com/repos/MekDrop/impresscms/issues/comments{/number}","contents_url":"https://api.github.com/repos/MekDrop/impresscms/contents/{+path}","compare_url":"https://api.github.com/repos/MekDrop/impresscms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MekDrop/impresscms/merges","archive_url":"https://api.github.com/repos/MekDrop/impresscms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MekDrop/impresscms/downloads","issues_url":"https://api.github.com/repos/MekDrop/impresscms/issues{/number}","pulls_url":"https://api.github.com/repos/MekDrop/impresscms/pulls{/number}","milestones_url":"https://api.github.com/repos/MekDrop/impresscms/milestones{/number}","notifications_url":"https://api.github.com/repos/MekDrop/impresscms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MekDrop/impresscms/labels{/name}","releases_url":"https://api.github.com/repos/MekDrop/impresscms/releases{/id}","deployments_url":"https://api.github.com/repos/MekDrop/impresscms/deployments","created_at":"2018-01-28T19:56:12Z","updated_at":"2018-01-28T19:56:20Z","pushed_at":"2018-02-05T20:03:30Z","git_url":"git://github.com/MekDrop/impresscms.git","ssh_url":"git@github.com:MekDrop/impresscms.git","clone_url":"https://github.com/MekDrop/impresscms.git","svn_url":"https://github.com/MekDrop/impresscms","homepage":"http://www.impresscms.org","size":51056,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"retro"}},"base":{"label":"ImpressCMS:retro","ref":"retro","sha":"92586d4d86a37b8686c5bacf2f527418106a5c91","user":{"login":"ImpressCMS","id":2783896,"avatar_url":"https://avatars3.githubusercontent.com/u/2783896?v=4","gravatar_id":"","url":"https://api.github.com/users/ImpressCMS","html_url":"https://github.com/ImpressCMS","followers_url":"https://api.github.com/users/ImpressCMS/followers","following_url":"https://api.github.com/users/ImpressCMS/following{/other_user}","gists_url":"https://api.github.com/users/ImpressCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/ImpressCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImpressCMS/subscriptions","organizations_url":"https://api.github.com/users/ImpressCMS/orgs","repos_url":"https://api.github.com/users/ImpressCMS/repos","events_url":"https://api.github.com/users/ImpressCMS/events{/privacy}","received_events_url":"https://api.github.com/users/ImpressCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":39623572,"name":"impresscms","full_name":"ImpressCMS/impresscms","owner":{"login":"ImpressCMS","id":2783896,"avatar_url":"https://avatars3.githubusercontent.com/u/2783896?v=4","gravatar_id":"","url":"https://api.github.com/users/ImpressCMS","html_url":"https://github.com/ImpressCMS","followers_url":"https://api.github.com/users/ImpressCMS/followers","following_url":"https://api.github.com/users/ImpressCMS/following{/other_user}","gists_url":"https://api.github.com/users/ImpressCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/ImpressCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImpressCMS/subscriptions","organizations_url":"https://api.github.com/users/ImpressCMS/orgs","repos_url":"https://api.github.com/users/ImpressCMS/repos","events_url":"https://api.github.com/users/ImpressCMS/events{/privacy}","received_events_url":"https://api.github.com/users/ImpressCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImpressCMS/impresscms","description":"A community developed CMS in PHP - easily build and maintain a dynamic web site","fork":false,"url":"https://api.github.com/repos/ImpressCMS/impresscms","forks_url":"https://api.github.com/repos/ImpressCMS/impresscms/forks","keys_url":"https://api.github.com/repos/ImpressCMS/impresscms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImpressCMS/impresscms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImpressCMS/impresscms/teams","hooks_url":"https://api.github.com/repos/ImpressCMS/impresscms/hooks","issue_events_url":"https://api.github.com/repos/ImpressCMS/impresscms/issues/events{/number}","events_url":"https://api.github.com/repos/ImpressCMS/impresscms/events","assignees_url":"https://api.github.com/repos/ImpressCMS/impresscms/assignees{/user}","branches_url":"https://api.github.com/repos/ImpressCMS/impresscms/branches{/branch}","tags_url":"https://api.github.com/repos/ImpressCMS/impresscms/tags","blobs_url":"https://api.github.com/repos/ImpressCMS/impresscms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImpressCMS/impresscms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImpressCMS/impresscms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImpressCMS/impresscms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImpressCMS/impresscms/statuses/{sha}","languages_url":"https://api.github.com/repos/ImpressCMS/impresscms/languages","stargazers_url":"https://api.github.com/repos/ImpressCMS/impresscms/stargazers","contributors_url":"https://api.github.com/repos/ImpressCMS/impresscms/contributors","subscribers_url":"https://api.github.com/repos/ImpressCMS/impresscms/subscribers","subscription_url":"https://api.github.com/repos/ImpressCMS/impresscms/subscription","commits_url":"https://api.github.com/repos/ImpressCMS/impresscms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImpressCMS/impresscms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImpressCMS/impresscms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImpressCMS/impresscms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImpressCMS/impresscms/contents/{+path}","compare_url":"https://api.github.com/repos/ImpressCMS/impresscms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImpressCMS/impresscms/merges","archive_url":"https://api.github.com/repos/ImpressCMS/impresscms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImpressCMS/impresscms/downloads","issues_url":"https://api.github.com/repos/ImpressCMS/impresscms/issues{/number}","pulls_url":"https://api.github.com/repos/ImpressCMS/impresscms/pulls{/number}","milestones_url":"https://api.github.com/repos/ImpressCMS/impresscms/milestones{/number}","notifications_url":"https://api.github.com/repos/ImpressCMS/impresscms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImpressCMS/impresscms/labels{/name}","releases_url":"https://api.github.com/repos/ImpressCMS/impresscms/releases{/id}","deployments_url":"https://api.github.com/repos/ImpressCMS/impresscms/deployments","created_at":"2015-07-24T09:30:52Z","updated_at":"2017-11-29T13:09:16Z","pushed_at":"2018-02-05T20:03:27Z","git_url":"git://github.com/ImpressCMS/impresscms.git","ssh_url":"git@github.com:ImpressCMS/impresscms.git","clone_url":"https://github.com/ImpressCMS/impresscms.git","svn_url":"https://github.com/ImpressCMS/impresscms","homepage":"http://www.impresscms.org","size":50519,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":10,"open_issues":38,"watchers":5,"default_branch":"retro"}},"_links":{"self":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136"},"html":{"href":"https://github.com/ImpressCMS/impresscms/pull/136"},"issue":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/issues/136"},"comments":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/ImpressCMS/impresscms/statuses/55500a50376acde5b08d8eb5dc38e545946acc36"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fiammybe"}}