{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/commission/pulls/comments/171065137","pull_request_review_id":99853464,"id":171065137,"diff_hunk":"@@ -0,0 +1,25 @@\n+# -*- coding: utf-8 -*-\n+# Copyright 2018 Carlos Dauden - Tecnativa <carlos.dauden@tecnativa.com>\n+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).\n+\n+from odoo import api, models\n+\n+\n+class SaleOrderLine(models.Model):\n+    _inherit = 'sale.order.line'\n+\n+    @api.onchange('product_id')\n+    def _onchange_product_id_sale_commission_pricelist(self):\n+        self.ensure_one()\n+        if self.product_id:","path":"sale_commission_pricelist/models/sale_order.py","position":14,"original_position":14,"commit_id":"64df56c1fb76cb809b564f973d21b2ef776135e4","original_commit_id":"64df56c1fb76cb809b564f973d21b2ef776135e4","user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"Well, I'm saying this because our Gitlab CI has failed with that error, so there should be any condition that doesn't fit. I think it's due to calls to `new` instead of `create`. There, required fields are not applied.","created_at":"2018-02-27T21:03:18Z","updated_at":"2018-02-27T21:03:18Z","html_url":"https://github.com/OCA/commission/pull/146#discussion_r171065137","pull_request_url":"https://api.github.com/repos/OCA/commission/pulls/146","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OCA/commission/pulls/comments/171065137"},"html":{"href":"https://github.com/OCA/commission/pull/146#discussion_r171065137"},"pull_request":{"href":"https://api.github.com/repos/OCA/commission/pulls/146"}},"in_reply_to_id":171062974},"pull_request":{"url":"https://api.github.com/repos/OCA/commission/pulls/146","id":168484935,"html_url":"https://github.com/OCA/commission/pull/146","diff_url":"https://github.com/OCA/commission/pull/146.diff","patch_url":"https://github.com/OCA/commission/pull/146.patch","issue_url":"https://api.github.com/repos/OCA/commission/issues/146","number":146,"state":"open","locked":false,"title":"[ADD] sale_commission_pricelist: New module that assign commission to…","user":{"login":"carlosdauden","id":7701001,"avatar_url":"https://avatars3.githubusercontent.com/u/7701001?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosdauden","html_url":"https://github.com/carlosdauden","followers_url":"https://api.github.com/users/carlosdauden/followers","following_url":"https://api.github.com/users/carlosdauden/following{/other_user}","gists_url":"https://api.github.com/users/carlosdauden/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosdauden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosdauden/subscriptions","organizations_url":"https://api.github.com/users/carlosdauden/orgs","repos_url":"https://api.github.com/users/carlosdauden/repos","events_url":"https://api.github.com/users/carlosdauden/events{/privacy}","received_events_url":"https://api.github.com/users/carlosdauden/received_events","type":"User","site_admin":false},"body":"… pricelist item\r\n\r\n@Tecnativa","created_at":"2018-02-12T00:43:45Z","updated_at":"2018-02-27T21:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92a391f537e4284327a4cc1a8ac7bd614bc7993","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":121860968,"url":"https://api.github.com/repos/OCA/commission/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/OCA/commission/milestones/4","html_url":"https://github.com/OCA/commission/milestone/4","labels_url":"https://api.github.com/repos/OCA/commission/milestones/4/labels","id":2052074,"number":4,"title":"10.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-10-06T12:48:44Z","updated_at":"2018-02-14T05:40:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/commission/pulls/146/commits","review_comments_url":"https://api.github.com/repos/OCA/commission/pulls/146/comments","review_comment_url":"https://api.github.com/repos/OCA/commission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/commission/issues/146/comments","statuses_url":"https://api.github.com/repos/OCA/commission/statuses/64df56c1fb76cb809b564f973d21b2ef776135e4","head":{"label":"Tecnativa:10.0-ADD-sale_commission_pricelist","ref":"10.0-ADD-sale_commission_pricelist","sha":"64df56c1fb76cb809b564f973d21b2ef776135e4","user":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars2.githubusercontent.com/u/18120193?v=4","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"repo":{"id":76108785,"name":"commission","full_name":"Tecnativa/commission","owner":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars2.githubusercontent.com/u/18120193?v=4","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tecnativa/commission","description":"Odoo Commission Management","fork":true,"url":"https://api.github.com/repos/Tecnativa/commission","forks_url":"https://api.github.com/repos/Tecnativa/commission/forks","keys_url":"https://api.github.com/repos/Tecnativa/commission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tecnativa/commission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tecnativa/commission/teams","hooks_url":"https://api.github.com/repos/Tecnativa/commission/hooks","issue_events_url":"https://api.github.com/repos/Tecnativa/commission/issues/events{/number}","events_url":"https://api.github.com/repos/Tecnativa/commission/events","assignees_url":"https://api.github.com/repos/Tecnativa/commission/assignees{/user}","branches_url":"https://api.github.com/repos/Tecnativa/commission/branches{/branch}","tags_url":"https://api.github.com/repos/Tecnativa/commission/tags","blobs_url":"https://api.github.com/repos/Tecnativa/commission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tecnativa/commission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tecnativa/commission/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tecnativa/commission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tecnativa/commission/statuses/{sha}","languages_url":"https://api.github.com/repos/Tecnativa/commission/languages","stargazers_url":"https://api.github.com/repos/Tecnativa/commission/stargazers","contributors_url":"https://api.github.com/repos/Tecnativa/commission/contributors","subscribers_url":"https://api.github.com/repos/Tecnativa/commission/subscribers","subscription_url":"https://api.github.com/repos/Tecnativa/commission/subscription","commits_url":"https://api.github.com/repos/Tecnativa/commission/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tecnativa/commission/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tecnativa/commission/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tecnativa/commission/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tecnativa/commission/contents/{+path}","compare_url":"https://api.github.com/repos/Tecnativa/commission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tecnativa/commission/merges","archive_url":"https://api.github.com/repos/Tecnativa/commission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tecnativa/commission/downloads","issues_url":"https://api.github.com/repos/Tecnativa/commission/issues{/number}","pulls_url":"https://api.github.com/repos/Tecnativa/commission/pulls{/number}","milestones_url":"https://api.github.com/repos/Tecnativa/commission/milestones{/number}","notifications_url":"https://api.github.com/repos/Tecnativa/commission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tecnativa/commission/labels{/name}","releases_url":"https://api.github.com/repos/Tecnativa/commission/releases{/id}","deployments_url":"https://api.github.com/repos/Tecnativa/commission/deployments","created_at":"2016-12-10T11:36:27Z","updated_at":"2016-12-10T11:36:28Z","pushed_at":"2018-02-27T14:38:22Z","git_url":"git://github.com/Tecnativa/commission.git","ssh_url":"git@github.com:Tecnativa/commission.git","clone_url":"https://github.com/Tecnativa/commission.git","svn_url":"https://github.com/Tecnativa/commission","homepage":"","size":847,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"OCA:10.0","ref":"10.0","sha":"c7816c3ffc1c4a07328a517cfda162067283d96a","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20922238,"name":"commission","full_name":"OCA/commission","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/commission","description":"Odoo Commission Management","fork":false,"url":"https://api.github.com/repos/OCA/commission","forks_url":"https://api.github.com/repos/OCA/commission/forks","keys_url":"https://api.github.com/repos/OCA/commission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/commission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/commission/teams","hooks_url":"https://api.github.com/repos/OCA/commission/hooks","issue_events_url":"https://api.github.com/repos/OCA/commission/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/commission/events","assignees_url":"https://api.github.com/repos/OCA/commission/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/commission/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/commission/tags","blobs_url":"https://api.github.com/repos/OCA/commission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/commission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/commission/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/commission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/commission/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/commission/languages","stargazers_url":"https://api.github.com/repos/OCA/commission/stargazers","contributors_url":"https://api.github.com/repos/OCA/commission/contributors","subscribers_url":"https://api.github.com/repos/OCA/commission/subscribers","subscription_url":"https://api.github.com/repos/OCA/commission/subscription","commits_url":"https://api.github.com/repos/OCA/commission/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/commission/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/commission/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/commission/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/commission/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/commission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/commission/merges","archive_url":"https://api.github.com/repos/OCA/commission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/commission/downloads","issues_url":"https://api.github.com/repos/OCA/commission/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/commission/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/commission/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/commission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/commission/labels{/name}","releases_url":"https://api.github.com/repos/OCA/commission/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/commission/deployments","created_at":"2014-06-17T12:22:39Z","updated_at":"2018-02-08T07:01:28Z","pushed_at":"2018-02-27T14:38:19Z","git_url":"git://github.com/OCA/commission.git","ssh_url":"git@github.com:OCA/commission.git","clone_url":"https://github.com/OCA/commission.git","svn_url":"https://github.com/OCA/commission","homepage":"","size":1053,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":137,"open_issues":35,"watchers":29,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/commission/pulls/146"},"html":{"href":"https://github.com/OCA/commission/pull/146"},"issue":{"href":"https://api.github.com/repos/OCA/commission/issues/146"},"comments":{"href":"https://api.github.com/repos/OCA/commission/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/commission/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/commission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/commission/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/commission/statuses/64df56c1fb76cb809b564f973d21b2ef776135e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"pedrobaeza"}}