{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/dune/pulls/comments/200630161","pull_request_review_id":134984425,"id":200630161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDYzMDE2MQ==","diff_hunk":"@@ -772,23 +801,36 @@ module Action = struct\n     (t, acc)\n \n   let expand_step2 ~dir ~dynamic_expansions ~deps_written_by_user ~map_exe t =\n-    U.Partial.expand t ~dir ~map_exe ~f:(fun var _syntax_version ->\n+    U.Partial.expand t ~dir ~map_exe ~f:(fun var syntax_version ->\n       let key = String_with_vars.Var.full_name var in\n       let loc = String_with_vars.Var.loc var in\n       match String.Map.find dynamic_expansions key with\n       | Some _ as opt -> opt\n       | None ->\n+        let first_dep () =\n+          Some (\n+            match deps_written_by_user with\n+            | [] ->\n+              Loc.warn loc \"Variable '%s' used with no explicit \\\n+                            dependencies@.\" key;\n+              [Value.String \"\"]\n+            | v :: _  -> [Path v]\n+          )\n+        in\n         match key with\n         | \"<\" ->\n-          Some\n-            (match deps_written_by_user with\n-             | [] ->\n-               Loc.warn loc \"Variable '<' used with no explicit \\\n-                             dependencies@.\";\n-               [Value.String \"\"]\n-             | dep :: _ ->\n-               [Path dep])\n-        | \"^\" -> Some (Value.L.paths deps_written_by_user)\n+          if syntax_version < (1, 0) then\n+            first_dep ()\n+          else\n+            Loc.fail loc \"Variable '<' is renamed to 'first-dep' in dune\"","path":"src/super_context.ml","position":138,"original_position":138,"commit_id":"851a0d9d7b5d1b1360f4a478f8ed081ef1cb7c81","original_commit_id":"851a0d9d7b5d1b1360f4a478f8ed081ef1cb7c81","user":{"login":"rgrinberg","id":139003,"node_id":"MDQ6VXNlcjEzOTAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"body":"Agreed. I made all the errors a little more consistent. Full consistency will probably have to wait for the refactor that makes variable name changes first class.","created_at":"2018-07-06T11:49:29Z","updated_at":"2018-07-06T11:49:29Z","html_url":"https://github.com/ocaml/dune/pull/957#discussion_r200630161","pull_request_url":"https://api.github.com/repos/ocaml/dune/pulls/957","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments/200630161"},"html":{"href":"https://github.com/ocaml/dune/pull/957#discussion_r200630161"},"pull_request":{"href":"https://api.github.com/repos/ocaml/dune/pulls/957"}},"in_reply_to_id":200626799},"pull_request":{"url":"https://api.github.com/repos/ocaml/dune/pulls/957","id":199542115,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTQyMTE1","html_url":"https://github.com/ocaml/dune/pull/957","diff_url":"https://github.com/ocaml/dune/pull/957.diff","patch_url":"https://github.com/ocaml/dune/pull/957.patch","issue_url":"https://api.github.com/repos/ocaml/dune/issues/957","number":957,"state":"open","locked":false,"title":"Rename SCOPE_ROOT, ${@}, ${^}, etc.","user":{"login":"rgrinberg","id":139003,"node_id":"MDQ6VXNlcjEzOTAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-05T17:44:19Z","updated_at":"2018-07-06T11:49:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96ffccad5ee4a2fa86d4078df4a2379743f319bc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"emillon","id":496345,"node_id":"MDQ6VXNlcjQ5NjM0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/496345?v=4","gravatar_id":"","url":"https://api.github.com/users/emillon","html_url":"https://github.com/emillon","followers_url":"https://api.github.com/users/emillon/followers","following_url":"https://api.github.com/users/emillon/following{/other_user}","gists_url":"https://api.github.com/users/emillon/gists{/gist_id}","starred_url":"https://api.github.com/users/emillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emillon/subscriptions","organizations_url":"https://api.github.com/users/emillon/orgs","repos_url":"https://api.github.com/users/emillon/repos","events_url":"https://api.github.com/users/emillon/events{/privacy}","received_events_url":"https://api.github.com/users/emillon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/dune/pulls/957/commits","review_comments_url":"https://api.github.com/repos/ocaml/dune/pulls/957/comments","review_comment_url":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/dune/issues/957/comments","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/851a0d9d7b5d1b1360f4a478f8ed081ef1cb7c81","head":{"label":"rgrinberg:rename-scope-scope-root","ref":"rename-scope-scope-root","sha":"851a0d9d7b5d1b1360f4a478f8ed081ef1cb7c81","user":{"login":"rgrinberg","id":139003,"node_id":"MDQ6VXNlcjEzOTAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"repo":{"id":81893852,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg5Mzg1Mg==","name":"jbuilder","full_name":"rgrinberg/jbuilder","owner":{"login":"rgrinberg","id":139003,"node_id":"MDQ6VXNlcjEzOTAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgrinberg/jbuilder","description":"Release build system","fork":true,"url":"https://api.github.com/repos/rgrinberg/jbuilder","forks_url":"https://api.github.com/repos/rgrinberg/jbuilder/forks","keys_url":"https://api.github.com/repos/rgrinberg/jbuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgrinberg/jbuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgrinberg/jbuilder/teams","hooks_url":"https://api.github.com/repos/rgrinberg/jbuilder/hooks","issue_events_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues/events{/number}","events_url":"https://api.github.com/repos/rgrinberg/jbuilder/events","assignees_url":"https://api.github.com/repos/rgrinberg/jbuilder/assignees{/user}","branches_url":"https://api.github.com/repos/rgrinberg/jbuilder/branches{/branch}","tags_url":"https://api.github.com/repos/rgrinberg/jbuilder/tags","blobs_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgrinberg/jbuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/rgrinberg/jbuilder/languages","stargazers_url":"https://api.github.com/repos/rgrinberg/jbuilder/stargazers","contributors_url":"https://api.github.com/repos/rgrinberg/jbuilder/contributors","subscribers_url":"https://api.github.com/repos/rgrinberg/jbuilder/subscribers","subscription_url":"https://api.github.com/repos/rgrinberg/jbuilder/subscription","commits_url":"https://api.github.com/repos/rgrinberg/jbuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgrinberg/jbuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgrinberg/jbuilder/contents/{+path}","compare_url":"https://api.github.com/repos/rgrinberg/jbuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgrinberg/jbuilder/merges","archive_url":"https://api.github.com/repos/rgrinberg/jbuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgrinberg/jbuilder/downloads","issues_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues{/number}","pulls_url":"https://api.github.com/repos/rgrinberg/jbuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/rgrinberg/jbuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/rgrinberg/jbuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgrinberg/jbuilder/labels{/name}","releases_url":"https://api.github.com/repos/rgrinberg/jbuilder/releases{/id}","deployments_url":"https://api.github.com/repos/rgrinberg/jbuilder/deployments","created_at":"2017-02-14T02:11:03Z","updated_at":"2017-02-14T02:11:05Z","pushed_at":"2018-07-06T11:40:59Z","git_url":"git://github.com/rgrinberg/jbuilder.git","ssh_url":"git@github.com:rgrinberg/jbuilder.git","clone_url":"https://github.com/rgrinberg/jbuilder.git","svn_url":"https://github.com/rgrinberg/jbuilder","homepage":"","size":5062,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"19e332d8a40b0e7afb0aa43c50bb236196c7c711","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":72368050,"node_id":"MDEwOlJlcG9zaXRvcnk3MjM2ODA1MA==","name":"dune","full_name":"ocaml/dune","owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/dune","description":"A composable build system for OCaml","fork":false,"url":"https://api.github.com/repos/ocaml/dune","forks_url":"https://api.github.com/repos/ocaml/dune/forks","keys_url":"https://api.github.com/repos/ocaml/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/dune/teams","hooks_url":"https://api.github.com/repos/ocaml/dune/hooks","issue_events_url":"https://api.github.com/repos/ocaml/dune/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/dune/events","assignees_url":"https://api.github.com/repos/ocaml/dune/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/dune/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/dune/tags","blobs_url":"https://api.github.com/repos/ocaml/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/dune/languages","stargazers_url":"https://api.github.com/repos/ocaml/dune/stargazers","contributors_url":"https://api.github.com/repos/ocaml/dune/contributors","subscribers_url":"https://api.github.com/repos/ocaml/dune/subscribers","subscription_url":"https://api.github.com/repos/ocaml/dune/subscription","commits_url":"https://api.github.com/repos/ocaml/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/dune/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/dune/merges","archive_url":"https://api.github.com/repos/ocaml/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/dune/downloads","issues_url":"https://api.github.com/repos/ocaml/dune/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/dune/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/dune/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/dune/deployments","created_at":"2016-10-30T18:42:23Z","updated_at":"2018-07-06T11:43:37Z","pushed_at":"2018-07-06T11:43:32Z","git_url":"git://github.com/ocaml/dune.git","ssh_url":"git@github.com:ocaml/dune.git","clone_url":"https://github.com/ocaml/dune.git","svn_url":"https://github.com/ocaml/dune","homepage":"","size":4901,"stargazers_count":371,"watchers_count":371,"language":"OCaml","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":75,"open_issues":152,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/957"},"html":{"href":"https://github.com/ocaml/dune/pull/957"},"issue":{"href":"https://api.github.com/repos/ocaml/dune/issues/957"},"comments":{"href":"https://api.github.com/repos/ocaml/dune/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/dune/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/dune/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/dune/statuses/851a0d9d7b5d1b1360f4a478f8ed081ef1cb7c81"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rgrinberg"}}