{"push_id":2364981092,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"a1561af520f66a0d9b07c26052db295376ac299c","before":"524aad05a0b2d12a6872a9aa96caacc6edc1eec5","commits":[{"sha":"bcbe749d8061255225978ddcf9381ada6d1cabf8","author":{"name":"Krisztián Löki","email":"b7ef47cf1bbed44f4a005bb1dc17bbfa34a496a4@esss.se"},"message":"Print the mismatching characters to ease debugging","distinct":true,"url":"https://api.github.com/repos/paulscherrerinstitute/StreamDevice/commits/bcbe749d8061255225978ddcf9381ada6d1cabf8"},{"sha":"da174b099e09086d33ef0d9d51908f0739ec9d23","author":{"name":"Krisztián Löki","email":"b7ef47cf1bbed44f4a005bb1dc17bbfa34a496a4@esss.se"},"message":"Do not encode formats during recursion\n\nEncoding a format involves replacing it with binary encoded information\nthat contains a NULL byte. This null byte terminates the search for\nsubsequent formats. This means that if the encoding is done when\nthe recursion depth is greater than 0, no format will be recognized as\nsuch when the recursion depth decreases.\n\nA real life manifestation of this bug:\n\nwont_work {\n  prefix = \"@\" \"%3c\" \"ACK\";\n  in $prefix \"%s\";\n}\n\nThe \"%s\" will be interpreted as literal '%' followed by 's'.\nWhat happens here is that the variable $prefix will be replaced (by\nrecursively calling compileString()) with \"@%3cACK\" in the first step\nand in the second step the format conversion will be replaced with a\nbinary encoding (sg like \"<03>3c<00>...\"). That NUL byte will cause the\nsearch for '%' (in the parent compileString()) to stop, leaving the \"%s\" intact.\n\nThe fix is simple; defer the format encode until everything else is done.\nTo preserve binary compatibility a new private function is introduced\ninstead of changing the signature of the exising one.","distinct":true,"url":"https://api.github.com/repos/paulscherrerinstitute/StreamDevice/commits/da174b099e09086d33ef0d9d51908f0739ec9d23"},{"sha":"a1561af520f66a0d9b07c26052db295376ac299c","author":{"name":"dirk-zimoch","email":"e18531a46803188e7847e0a74c8cc2993a53e9eb@users.noreply.github.com"},"message":"Merge pull request #8 from krisztianloki/master\n\nFix for 'Not interpreted format conversions' accepted.","distinct":true,"url":"https://api.github.com/repos/paulscherrerinstitute/StreamDevice/commits/a1561af520f66a0d9b07c26052db295376ac299c"}]}
{"actor":{"display_login":"dirk-zimoch"}}