{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/150","repository_url":"https://api.github.com/repos/googleapis/nodejs-spanner","labels_url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/150/comments","events_url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/150/events","html_url":"https://github.com/googleapis/nodejs-spanner/pull/150","id":303731031,"number":150,"title":"test: make sure tests can run in parallel","user":{"login":"alexander-fenster","id":4015807,"avatar_url":"https://avatars1.githubusercontent.com/u/4015807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-fenster","html_url":"https://github.com/alexander-fenster","followers_url":"https://api.github.com/users/alexander-fenster/followers","following_url":"https://api.github.com/users/alexander-fenster/following{/other_user}","gists_url":"https://api.github.com/users/alexander-fenster/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-fenster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-fenster/subscriptions","organizations_url":"https://api.github.com/users/alexander-fenster/orgs","repos_url":"https://api.github.com/users/alexander-fenster/repos","events_url":"https://api.github.com/users/alexander-fenster/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-fenster/received_events","type":"User","site_admin":false},"labels":[{"id":725910346,"url":"https://api.github.com/repos/googleapis/nodejs-spanner/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"alexander-fenster","id":4015807,"avatar_url":"https://avatars1.githubusercontent.com/u/4015807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-fenster","html_url":"https://github.com/alexander-fenster","followers_url":"https://api.github.com/users/alexander-fenster/followers","following_url":"https://api.github.com/users/alexander-fenster/following{/other_user}","gists_url":"https://api.github.com/users/alexander-fenster/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-fenster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-fenster/subscriptions","organizations_url":"https://api.github.com/users/alexander-fenster/orgs","repos_url":"https://api.github.com/users/alexander-fenster/repos","events_url":"https://api.github.com/users/alexander-fenster/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-fenster/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexander-fenster","id":4015807,"avatar_url":"https://avatars1.githubusercontent.com/u/4015807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-fenster","html_url":"https://github.com/alexander-fenster","followers_url":"https://api.github.com/users/alexander-fenster/followers","following_url":"https://api.github.com/users/alexander-fenster/following{/other_user}","gists_url":"https://api.github.com/users/alexander-fenster/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-fenster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-fenster/subscriptions","organizations_url":"https://api.github.com/users/alexander-fenster/orgs","repos_url":"https://api.github.com/users/alexander-fenster/repos","events_url":"https://api.github.com/users/alexander-fenster/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-fenster/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-03-09T05:43:54Z","updated_at":"2018-03-09T16:52:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-spanner/pulls/150","html_url":"https://github.com/googleapis/nodejs-spanner/pull/150","diff_url":"https://github.com/googleapis/nodejs-spanner/pull/150.diff","patch_url":"https://github.com/googleapis/nodejs-spanner/pull/150.patch"},"body":"Since the problem of failing spanner tests was resolved in #148, the fix from #147 is not needed so let's put it back: we still want to delete our test data. Also, since we now allow multiple samples tests to run simultaneously (#149), we need to make sure that they are working with different instances, otherwise, when two CI tasks run simultaneously, the `before` hook of the second run will delete the instance that the first run is still using.\r\n\r\n[Also, found out that we cannot just make the test run in parallel, as they depend on their order. Ideally, they should be rewritten :)]\r\n\r\n- [x] Tests and linter pass\r\n- [x] And samples tests pass as well\r\n- [x] Code coverage does not decrease (if any source code was changed)\r\n- [x] Appropriate docs were updated (if necessary)\r\n"},"comment":{"url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/comments/371871211","html_url":"https://github.com/googleapis/nodejs-spanner/pull/150#issuecomment-371871211","issue_url":"https://api.github.com/repos/googleapis/nodejs-spanner/issues/150","id":371871211,"user":{"login":"alexander-fenster","id":4015807,"avatar_url":"https://avatars1.githubusercontent.com/u/4015807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-fenster","html_url":"https://github.com/alexander-fenster","followers_url":"https://api.github.com/users/alexander-fenster/followers","following_url":"https://api.github.com/users/alexander-fenster/following{/other_user}","gists_url":"https://api.github.com/users/alexander-fenster/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-fenster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-fenster/subscriptions","organizations_url":"https://api.github.com/users/alexander-fenster/orgs","repos_url":"https://api.github.com/users/alexander-fenster/repos","events_url":"https://api.github.com/users/alexander-fenster/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-fenster/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T16:52:52Z","updated_at":"2018-03-09T16:52:52Z","author_association":"CONTRIBUTOR","body":"@stephenplusplus We have 6 CircleCI tasks running in parallel for googleapis org, and since samples test take more than 5 minutes, it's possible that when 2 PRs are merged one after one, two samples test tasks start running at the same time and one of them would fail because they both use the same instance (but different databases though).  The output @callmehiphop is talking about was from my script (introduced in #113, removed in #149) - I'm pretty confident now that running two samples test in parallel is safe if they use different instances, so there is no need to serialize tasks anymore."}}
{"actor":{"display_login":"alexander-fenster"}}