{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/mtu-update/pulls/comments/198015611","pull_request_review_id":131865246,"id":198015611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODAxNTYxMQ==","diff_hunk":"@@ -0,0 +1,36 @@\n+Usage\n+-----\n+\n+```\n+$ ./mtu-update -h\n+Update the MTU inside network namespaces.\n+\n+Usage:\n+  mtu-update [flags]\n+\n+Flags:\n+  -h, --help                  help for mtu-update\n+  -m, --mtu int               Base MTU to configure on links (0 for autodetect) (default 1500)\n+  -p, --period int            Run once every x seconds (default 300)\n+  -t, --tunnel-overhead int   Expected tunnel overhead for overlay traffic (default 50)\n+  -v, --verbose               Print verbose debug log messages\n+```\n+\n+Update the MTU across a k8s cluster:\n+\n+```\n+$ kubectl create -f https://raw.githubusercontent.com/cilium/mtu-update/master/mtu-update.yaml\n+(Check the logs for the newly created pod to validate that the MTU was updated)","path":"README.rst","position":23,"original_position":23,"commit_id":"9ee6b56e12c039a0e3b2e63f81b3619b7f1991f0","original_commit_id":"9ee6b56e12c039a0e3b2e63f81b3619b7f1991f0","user":{"login":"aanm","id":5714066,"node_id":"MDQ6VXNlcjU3MTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5714066?v=4","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"How? For all pods? This step might be unnecessary, check my comments in the daemonset","created_at":"2018-06-26T05:14:49Z","updated_at":"2018-06-26T05:39:21Z","html_url":"https://github.com/cilium/mtu-update/pull/1#discussion_r198015611","pull_request_url":"https://api.github.com/repos/cilium/mtu-update/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/comments/198015611"},"html":{"href":"https://github.com/cilium/mtu-update/pull/1#discussion_r198015611"},"pull_request":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/mtu-update/pulls/1","id":197288444,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Mjg4NDQ0","html_url":"https://github.com/cilium/mtu-update/pull/1","diff_url":"https://github.com/cilium/mtu-update/pull/1.diff","patch_url":"https://github.com/cilium/mtu-update/pull/1.patch","issue_url":"https://api.github.com/repos/cilium/mtu-update/issues/1","number":1,"state":"open","locked":false,"title":"Import implementation of mtu-update","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":"### Overview\r\n\r\nThis PR prepares the `mtu-upgrade` program, which iterates through network namespaces and devices on a host to update the MTU for Cilium-managed endpoints to follow the Cilium 1.1 model.\r\n\r\nThe intended workflow is this:\r\n\r\n* User creates this `DaemonSet` in their cluster.\r\n* User upgrades their Cilium version\r\n* User waits ~5 minutes, checking the logs to see that the the log messages for this `DaemonSet` state that all namespaces and links are being skipped\r\n* User deletes the `DaemonSet`\r\n\r\n### Testing\r\n\r\n#### Docker preparation\r\n\r\nUpdate `/etc/docker/daemon.json` (or equivalent) with the following contents:\r\n```\r\n{\"insecure-registries\" : [\"192.168.99.1:5000\"]}\r\n```\r\nFor more information, see https://docs.docker.com/registry/insecure/\r\n\r\nRestart Docker and run a registry container (optional if you already have one running):\r\n```\r\n$ systemctl restart docker\r\n$ docker run -d -p 5000:5000 --restart=always --name registry registry:2\r\n```\r\n\r\n#### Minikube\r\n\r\nRun minikube:\r\n```\r\n$ minikube start --network-plugin=cni --extra-config=kubelet.network-plugin=cni --memory=5120 --insecure-registry=\"192.168.99.1:5000\"\r\n```\r\n\r\n#### Build and deploy\r\n\r\nBuild and push the image:\r\n```\r\n$ make\r\n$ docker tag cilium/mtu-update:latest 192.168.99.1:5000/cilium/mtu-update:latest\r\n$ docker push 192.168.99.1:5000/cilium/mtu-update:latest\r\n```\r\n\r\nEdit the `DaemonSet` to point to your local registry:\r\n```\r\ndiff --git a/mtu-update.yaml b/mtu-update.yaml\r\nindex 12421831f082..81ac623c5f41 100644\r\n--- a/mtu-update.yaml\r\n+++ b/mtu-update.yaml\r\n@@ -19,7 +19,7 @@ spec:\r\n     spec:\r\n       serviceAccountName: cilium\r\n       containers:\r\n-      - image: docker.io/cilium/update-mtu:latest\r\n+      - image: 192.168.99.1:5000/cilium/mtu-update:latest\r\n         imagePullPolicy: Always\r\n         name: mtu-update\r\n         command: [ \"./mtu-update\" ]\r\n```\r\n\r\nDeploy the DaemonSet:\r\n```\r\n$ kubectl create -f $GOPATH/src/github.com/cilium/mtu-update/mtu-update.yaml\r\n```\r\n\r\nThen, you can inspect the contents of the logs for the `DaemonSet`'s pod and see whether it updated any MTUs.\r\n\r\n","created_at":"2018-06-26T02:58:47Z","updated_at":"2018-06-26T05:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1799565235b7fb025f94a2bb4d28ee7ccf2540a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/mtu-update/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cilium/mtu-update/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cilium/mtu-update/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/mtu-update/issues/1/comments","statuses_url":"https://api.github.com/repos/cilium/mtu-update/statuses/9ee6b56e12c039a0e3b2e63f81b3619b7f1991f0","head":{"label":"joestringer:master","ref":"master","sha":"9ee6b56e12c039a0e3b2e63f81b3619b7f1991f0","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"repo":{"id":138677173,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NzcxNzM=","name":"mtu-update","full_name":"joestringer/mtu-update","owner":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joestringer/mtu-update","description":"Update the MTU inside running Cilium containers","fork":true,"url":"https://api.github.com/repos/joestringer/mtu-update","forks_url":"https://api.github.com/repos/joestringer/mtu-update/forks","keys_url":"https://api.github.com/repos/joestringer/mtu-update/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joestringer/mtu-update/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joestringer/mtu-update/teams","hooks_url":"https://api.github.com/repos/joestringer/mtu-update/hooks","issue_events_url":"https://api.github.com/repos/joestringer/mtu-update/issues/events{/number}","events_url":"https://api.github.com/repos/joestringer/mtu-update/events","assignees_url":"https://api.github.com/repos/joestringer/mtu-update/assignees{/user}","branches_url":"https://api.github.com/repos/joestringer/mtu-update/branches{/branch}","tags_url":"https://api.github.com/repos/joestringer/mtu-update/tags","blobs_url":"https://api.github.com/repos/joestringer/mtu-update/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joestringer/mtu-update/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joestringer/mtu-update/git/refs{/sha}","trees_url":"https://api.github.com/repos/joestringer/mtu-update/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joestringer/mtu-update/statuses/{sha}","languages_url":"https://api.github.com/repos/joestringer/mtu-update/languages","stargazers_url":"https://api.github.com/repos/joestringer/mtu-update/stargazers","contributors_url":"https://api.github.com/repos/joestringer/mtu-update/contributors","subscribers_url":"https://api.github.com/repos/joestringer/mtu-update/subscribers","subscription_url":"https://api.github.com/repos/joestringer/mtu-update/subscription","commits_url":"https://api.github.com/repos/joestringer/mtu-update/commits{/sha}","git_commits_url":"https://api.github.com/repos/joestringer/mtu-update/git/commits{/sha}","comments_url":"https://api.github.com/repos/joestringer/mtu-update/comments{/number}","issue_comment_url":"https://api.github.com/repos/joestringer/mtu-update/issues/comments{/number}","contents_url":"https://api.github.com/repos/joestringer/mtu-update/contents/{+path}","compare_url":"https://api.github.com/repos/joestringer/mtu-update/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joestringer/mtu-update/merges","archive_url":"https://api.github.com/repos/joestringer/mtu-update/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joestringer/mtu-update/downloads","issues_url":"https://api.github.com/repos/joestringer/mtu-update/issues{/number}","pulls_url":"https://api.github.com/repos/joestringer/mtu-update/pulls{/number}","milestones_url":"https://api.github.com/repos/joestringer/mtu-update/milestones{/number}","notifications_url":"https://api.github.com/repos/joestringer/mtu-update/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joestringer/mtu-update/labels{/name}","releases_url":"https://api.github.com/repos/joestringer/mtu-update/releases{/id}","deployments_url":"https://api.github.com/repos/joestringer/mtu-update/deployments","created_at":"2018-06-26T02:58:02Z","updated_at":"2018-06-26T02:58:23Z","pushed_at":"2018-06-26T02:58:21Z","git_url":"git://github.com/joestringer/mtu-update.git","ssh_url":"git@github.com:joestringer/mtu-update.git","clone_url":"https://github.com/joestringer/mtu-update.git","svn_url":"https://github.com/joestringer/mtu-update","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"1b311d1eeb635eb4b101288c7b4c0673f2e76cf4","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":138676582,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NzY1ODI=","name":"mtu-update","full_name":"cilium/mtu-update","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/mtu-update","description":"Update the MTU inside running Cilium containers","fork":false,"url":"https://api.github.com/repos/cilium/mtu-update","forks_url":"https://api.github.com/repos/cilium/mtu-update/forks","keys_url":"https://api.github.com/repos/cilium/mtu-update/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/mtu-update/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/mtu-update/teams","hooks_url":"https://api.github.com/repos/cilium/mtu-update/hooks","issue_events_url":"https://api.github.com/repos/cilium/mtu-update/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/mtu-update/events","assignees_url":"https://api.github.com/repos/cilium/mtu-update/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/mtu-update/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/mtu-update/tags","blobs_url":"https://api.github.com/repos/cilium/mtu-update/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/mtu-update/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/mtu-update/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/mtu-update/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/mtu-update/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/mtu-update/languages","stargazers_url":"https://api.github.com/repos/cilium/mtu-update/stargazers","contributors_url":"https://api.github.com/repos/cilium/mtu-update/contributors","subscribers_url":"https://api.github.com/repos/cilium/mtu-update/subscribers","subscription_url":"https://api.github.com/repos/cilium/mtu-update/subscription","commits_url":"https://api.github.com/repos/cilium/mtu-update/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/mtu-update/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/mtu-update/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/mtu-update/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/mtu-update/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/mtu-update/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/mtu-update/merges","archive_url":"https://api.github.com/repos/cilium/mtu-update/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/mtu-update/downloads","issues_url":"https://api.github.com/repos/cilium/mtu-update/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/mtu-update/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/mtu-update/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/mtu-update/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/mtu-update/labels{/name}","releases_url":"https://api.github.com/repos/cilium/mtu-update/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/mtu-update/deployments","created_at":"2018-06-26T02:52:07Z","updated_at":"2018-06-26T02:57:46Z","pushed_at":"2018-06-26T02:58:48Z","git_url":"git://github.com/cilium/mtu-update.git","ssh_url":"git@github.com:cilium/mtu-update.git","clone_url":"https://github.com/cilium/mtu-update.git","svn_url":"https://github.com/cilium/mtu-update","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/1"},"html":{"href":"https://github.com/cilium/mtu-update/pull/1"},"issue":{"href":"https://api.github.com/repos/cilium/mtu-update/issues/1"},"comments":{"href":"https://api.github.com/repos/cilium/mtu-update/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/mtu-update/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/mtu-update/statuses/9ee6b56e12c039a0e3b2e63f81b3619b7f1991f0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aanm"}}