{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/207965076","pull_request_review_id":143680120,"id":207965076,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk2NTA3Ng==","diff_hunk":"@@ -8907,11 +8908,11 @@ static void clif_charnameack(int fd, struct block_list *bl)\n \t\t\tif (p == NULL && g == NULL)\n \t\t\t\tbreak;\n \n-\t\t\tif (p != NULL) {\n+\t\t\tif (p != NULL && ssd->fakename_option != 1) {","path":"src/map/clif.c","position":15,"original_position":15,"commit_id":"878ea769b459474e641740a895224651a869a02c","original_commit_id":"878ea769b459474e641740a895224651a869a02c","user":{"login":"4144","id":959758,"node_id":"MDQ6VXNlcjk1OTc1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/959758?v=4","gravatar_id":"","url":"https://api.github.com/users/4144","html_url":"https://github.com/4144","followers_url":"https://api.github.com/users/4144/followers","following_url":"https://api.github.com/users/4144/following{/other_user}","gists_url":"https://api.github.com/users/4144/gists{/gist_id}","starred_url":"https://api.github.com/users/4144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4144/subscriptions","organizations_url":"https://api.github.com/users/4144/orgs","repos_url":"https://api.github.com/users/4144/repos","events_url":"https://api.github.com/users/4144/events{/privacy}","received_events_url":"https://api.github.com/users/4144/received_events","type":"User","site_admin":false},"body":"this will remove party name from all players by default.\r\nprobably better separate fakename command and hide party/guild?\r\n\r\nif you want use all in one command, then here need check also fake_name for empty string","created_at":"2018-08-06T17:10:39Z","updated_at":"2018-08-06T17:14:50Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2168#discussion_r207965076","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/207965076"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2168#discussion_r207965076"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168","id":206436653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDM2NjUz","html_url":"https://github.com/HerculesWS/Hercules/pull/2168","diff_url":"https://github.com/HerculesWS/Hercules/pull/2168.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2168.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2168","number":2168,"state":"open","locked":false,"title":"Adds options to @fakename so guild and party names can be displayed.","user":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\n[//]: # (Describe at length, the changes that this pull request makes.)\r\nAdds a parameter to the `@fakename` command, allowing the display of guild/party names. I previously made this PR, but deleted due to resetting my fork.\r\n\r\nE.g.\r\n`@fakename 0 Great Name` - would display the fake name 'Great Name' and hide party, guild and position names.\r\n`@fakename 1 Great Name` - would display the fake name 'Great Name' and hide party name, but not guild and position.\r\n\r\n**Affected Branches:** \r\n\r\n[//]: # (Master? Slave?)\r\n- [x] master\r\n- [x] stable\r\n\r\n**Issues addressed:**\r\n\r\n[//]: # (Issue Tracker Number if any.)\r\n\r\n### Known Issues and TODO List\r\n\r\n[//]: # (Insert checklist here)\r\n[//]: # (Syntax: - [ ] Checkbox)\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n","created_at":"2018-08-06T15:31:55Z","updated_at":"2018-08-06T17:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a5100141dd190593a248ffd2ccb90e1c9dcdef8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2168/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/878ea769b459474e641740a895224651a869a02c","head":{"label":"EyesOfAHawk:fakename_options","ref":"fakename_options","sha":"878ea769b459474e641740a895224651a869a02c","user":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"repo":{"id":120781877,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3ODE4Nzc=","name":"Hercules","full_name":"EyesOfAHawk/Hercules","owner":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EyesOfAHawk/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/EyesOfAHawk/Hercules","forks_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/forks","keys_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/teams","hooks_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/hooks","issue_events_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/events","assignees_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/tags","blobs_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/languages","stargazers_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/stargazers","contributors_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/contributors","subscribers_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/subscribers","subscription_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/subscription","commits_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/merges","archive_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/downloads","issues_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/deployments","created_at":"2018-02-08T15:48:33Z","updated_at":"2018-08-06T15:19:53Z","pushed_at":"2018-08-06T15:27:26Z","git_url":"git://github.com/EyesOfAHawk/Hercules.git","ssh_url":"git@github.com:EyesOfAHawk/Hercules.git","clone_url":"https://github.com/EyesOfAHawk/Hercules.git","svn_url":"https://github.com/EyesOfAHawk/Hercules","homepage":"http://herc.ws","size":172781,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"7f7b8060cba8f0aba60f43cf343bdf3f773f3438","user":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"node_id":"MDEwOlJlcG9zaXRvcnk3NTUxNDI5","name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2018-08-03T19:10:32Z","pushed_at":"2018-08-06T15:32:01Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":188903,"stargazers_count":431,"watchers_count":431,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":538,"open_issues":421,"watchers":431,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2168"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2168"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2168/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2168/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/878ea769b459474e641740a895224651a869a02c"}},"author_association":"NONE"}}
{"actor":{"display_login":"4144"}}