{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/239279849","pull_request_review_id":182026075,"id":239279849,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTI3OTg0OQ==","diff_hunk":"@@ -136,13 +136,13 @@ public function tokens($a = NULL, $b = NULL, $c = NULL) {\n    */\n   public function customToken($entity, $customFieldID, $entityID) {\n     $customFieldName = \"custom_\" . $customFieldID;\n-    $fieldValue = civicrm_api3($entity, 'getvalue', array(\n-      'return' => $customFieldName,\n-      'id' => $entityID,\n+    $record = civicrm_api3($entity, \"getSingle\", array(","path":"Civi/Token/TokenRow.php","position":7,"original_position":7,"commit_id":"459a591e1dfad4ec7752c9560262801c1149db14","original_commit_id":"459a591e1dfad4ec7752c9560262801c1149db14","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"body":"not having a return does impact the speed of the api - esp on contribution.get - ","created_at":"2018-12-05T23:37:28Z","updated_at":"2018-12-05T23:37:28Z","html_url":"https://github.com/civicrm/civicrm-core/pull/13174#discussion_r239279849","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/239279849"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/13174#discussion_r239279849"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174","id":234632774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjMyNzc0","html_url":"https://github.com/civicrm/civicrm-core/pull/13174","diff_url":"https://github.com/civicrm/civicrm-core/pull/13174.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13174.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13174","number":13174,"state":"open","locked":false,"title":"Token changes","user":{"login":"aydun","id":2730045,"node_id":"MDQ6VXNlcjI3MzAwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2730045?v=4","gravatar_id":"","url":"https://api.github.com/users/aydun","html_url":"https://github.com/aydun","followers_url":"https://api.github.com/users/aydun/followers","following_url":"https://api.github.com/users/aydun/following{/other_user}","gists_url":"https://api.github.com/users/aydun/gists{/gist_id}","starred_url":"https://api.github.com/users/aydun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aydun/subscriptions","organizations_url":"https://api.github.com/users/aydun/orgs","repos_url":"https://api.github.com/users/aydun/repos","events_url":"https://api.github.com/users/aydun/events{/privacy}","received_events_url":"https://api.github.com/users/aydun/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nA variety of changes affecting the TokenProcessor - see git commits.  These are extracted from PR #12012 and new functionality is used in that PR\r\n\r\nThere are no user changes here.\r\n","created_at":"2018-11-29T13:13:56Z","updated_at":"2018-12-05T23:37:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34b7db522d8450d1f999f1aa68eddcc9b25c1bd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13174/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/459a591e1dfad4ec7752c9560262801c1149db14","head":{"label":"aydun:token_changes","ref":"token_changes","sha":"459a591e1dfad4ec7752c9560262801c1149db14","user":{"login":"aydun","id":2730045,"node_id":"MDQ6VXNlcjI3MzAwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2730045?v=4","gravatar_id":"","url":"https://api.github.com/users/aydun","html_url":"https://github.com/aydun","followers_url":"https://api.github.com/users/aydun/followers","following_url":"https://api.github.com/users/aydun/following{/other_user}","gists_url":"https://api.github.com/users/aydun/gists{/gist_id}","starred_url":"https://api.github.com/users/aydun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aydun/subscriptions","organizations_url":"https://api.github.com/users/aydun/orgs","repos_url":"https://api.github.com/users/aydun/repos","events_url":"https://api.github.com/users/aydun/events{/privacy}","received_events_url":"https://api.github.com/users/aydun/received_events","type":"User","site_admin":false},"repo":{"id":9145845,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ1ODQ1","name":"civicrm-core","full_name":"aydun/civicrm-core","private":false,"owner":{"login":"aydun","id":2730045,"node_id":"MDQ6VXNlcjI3MzAwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2730045?v=4","gravatar_id":"","url":"https://api.github.com/users/aydun","html_url":"https://github.com/aydun","followers_url":"https://api.github.com/users/aydun/followers","following_url":"https://api.github.com/users/aydun/following{/other_user}","gists_url":"https://api.github.com/users/aydun/gists{/gist_id}","starred_url":"https://api.github.com/users/aydun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aydun/subscriptions","organizations_url":"https://api.github.com/users/aydun/orgs","repos_url":"https://api.github.com/users/aydun/repos","events_url":"https://api.github.com/users/aydun/events{/privacy}","received_events_url":"https://api.github.com/users/aydun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aydun/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/aydun/civicrm-core","forks_url":"https://api.github.com/repos/aydun/civicrm-core/forks","keys_url":"https://api.github.com/repos/aydun/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aydun/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aydun/civicrm-core/teams","hooks_url":"https://api.github.com/repos/aydun/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/aydun/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/aydun/civicrm-core/events","assignees_url":"https://api.github.com/repos/aydun/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/aydun/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/aydun/civicrm-core/tags","blobs_url":"https://api.github.com/repos/aydun/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aydun/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aydun/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/aydun/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aydun/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/aydun/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/aydun/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/aydun/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/aydun/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/aydun/civicrm-core/subscription","commits_url":"https://api.github.com/repos/aydun/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/aydun/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/aydun/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/aydun/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/aydun/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/aydun/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aydun/civicrm-core/merges","archive_url":"https://api.github.com/repos/aydun/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aydun/civicrm-core/downloads","issues_url":"https://api.github.com/repos/aydun/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/aydun/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/aydun/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/aydun/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aydun/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/aydun/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/aydun/civicrm-core/deployments","created_at":"2013-04-01T11:11:07Z","updated_at":"2016-10-11T21:26:42Z","pushed_at":"2018-12-05T23:32:46Z","git_url":"git://github.com/aydun/civicrm-core.git","ssh_url":"git@github.com:aydun/civicrm-core.git","clone_url":"https://github.com/aydun/civicrm-core.git","svn_url":"https://github.com/aydun/civicrm-core","homepage":null,"size":159713,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"be107882399c72acf05a47390ef0978b293f455c","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-12-05T23:35:00Z","pushed_at":"2018-12-05T23:34:46Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":170707,"stargazers_count":302,"watchers_count":302,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":654,"mirror_url":null,"archived":false,"open_issues_count":84,"license":null,"forks":654,"open_issues":84,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/13174"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13174"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13174/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13174/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/459a591e1dfad4ec7752c9560262801c1149db14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eileenmcnaughton"}}