{"action":"closed","issue":{"url":"https://api.github.com/repos/interledgerjs/ilp-protocol-psk2/issues/17","repository_url":"https://api.github.com/repos/interledgerjs/ilp-protocol-psk2","labels_url":"https://api.github.com/repos/interledgerjs/ilp-protocol-psk2/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-protocol-psk2/issues/17/comments","events_url":"https://api.github.com/repos/interledgerjs/ilp-protocol-psk2/issues/17/events","html_url":"https://github.com/interledgerjs/ilp-protocol-psk2/issues/17","id":293682602,"number":17,"title":"Add key ID when generating address and secret?","user":{"login":"emschwartz","id":3262610,"avatar_url":"https://avatars3.githubusercontent.com/u/3262610?v=4","gravatar_id":"","url":"https://api.github.com/users/emschwartz","html_url":"https://github.com/emschwartz","followers_url":"https://api.github.com/users/emschwartz/followers","following_url":"https://api.github.com/users/emschwartz/following{/other_user}","gists_url":"https://api.github.com/users/emschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/emschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emschwartz/subscriptions","organizations_url":"https://api.github.com/users/emschwartz/orgs","repos_url":"https://api.github.com/users/emschwartz/repos","events_url":"https://api.github.com/users/emschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/emschwartz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"justmoon","id":53233,"avatar_url":"https://avatars1.githubusercontent.com/u/53233?v=4","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"justmoon","id":53233,"avatar_url":"https://avatars1.githubusercontent.com/u/53233?v=4","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},{"login":"sharafian","id":3362563,"avatar_url":"https://avatars0.githubusercontent.com/u/3362563?v=4","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},{"login":"dappelt","id":23212287,"avatar_url":"https://avatars1.githubusercontent.com/u/23212287?v=4","gravatar_id":"","url":"https://api.github.com/users/dappelt","html_url":"https://github.com/dappelt","followers_url":"https://api.github.com/users/dappelt/followers","following_url":"https://api.github.com/users/dappelt/following{/other_user}","gists_url":"https://api.github.com/users/dappelt/gists{/gist_id}","starred_url":"https://api.github.com/users/dappelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dappelt/subscriptions","organizations_url":"https://api.github.com/users/dappelt/orgs","repos_url":"https://api.github.com/users/dappelt/repos","events_url":"https://api.github.com/users/dappelt/events{/privacy}","received_events_url":"https://api.github.com/users/dappelt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-02-01T21:03:14Z","updated_at":"2018-02-06T15:12:24Z","closed_at":"2018-02-06T15:12:24Z","author_association":"OWNER","body":"@sharafian asked for a way to specify something like a `keyId` when calling `Receiver.generateAddressAndSecret` that would be included in the details passed to the review callback when a payment comes in. It would be used to identify which user or invoice the incoming payment chunks are for.\r\n\r\nThe most obvious way to do this would be to append the `keyId` to the `destinationAccount`. However, this value must be authenticated (and probably encrypted), because otherwise the sender would be able to modify it and potentially mess with the receiver. We could use an authenticated encryption scheme to encrypt the `keyId` and put it into the `destinationAccount`, but this would get quite long.\r\n\r\nShould this be included as a feature in the PSK2 receiver, or should applications and application layer protocols that build on this library include such correlation IDs in the application data included in the PSK2 packet?\r\n\r\nAnother option would be to expose the `token` the receiver already appends to the `destinationAccount` to regenerate the `sharedSecret` in the response from `generateAddressAndSecret` and in the parameters passed to the review callback. That would allow  users to correlate incoming packets with address/secret pairs they gave out, but the user would need to remember the mapping (and it's possible they would have given multiple address/secret pairs out for the same `keyId`)."}}
{"actor":{"display_login":"emschwartz"}}